--- deliantra/server/common/treasure.C	2008/04/15 03:16:02	1.71
+++ deliantra/server/common/treasure.C	2009/10/12 14:00:57	1.86
@@ -1,22 +1,23 @@
 /*
  * This file is part of Deliantra, the Roguelike Realtime MMORPG.
  * 
- * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
+ * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
  * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
  * Copyright (©) 1992,2007 Frank Tore Johansen
  * 
- * Deliantra is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+ * Deliantra is free software: you can redistribute it and/or modify it under
+ * the terms of the Affero GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the License, or (at your
+ * option) any later version.
  * 
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  * 
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * You should have received a copy of the Affero GNU General Public License
+ * and the GNU General Public License along with this program. If not, see
+ * <http://www.gnu.org/licenses/>.
  * 
  * The authors can be reached via e-mail to <support@deliantra.net>
  */
@@ -34,7 +35,6 @@
 
 #include <global.h>
 #include <treasure.h>
-#include <funcpoint.h>
 #include <loader.h>
 
 extern char *spell_mapping[];
@@ -48,8 +48,7 @@
    treasurelist *,
    str_hash,
    str_equal,
-   slice_allocator< std::pair<const char *const, treasurelist *> >,
-   true
+   slice_allocator< std::pair<const char *const, treasurelist *> >
 > tl_map_t;
 
 static tl_map_t tl_map;
@@ -146,7 +145,14 @@
       switch (f.kw)
         {
           case KW_arch:
-            t->item = archetype::get (f.get_str ());
+            t->item = archetype::find (f.get_str ());
+
+            if (!t->item)
+              {
+                f.parse_warn ("treasure references unknown archetype");
+                t->item = archetype::empty;
+              }
+
             break;
 
           case KW_list:           f.get (t->name);                break;
@@ -170,13 +176,19 @@
 
           default:
             if (!f.parse_error ("treasurelist", t->name))
-              return 0;
+              goto error;
 
             return t;
         }
 
       f.next ();
     }
+
+  // not reached
+
+error:
+  delete t;
+  return 0;
 }
 
 /*
@@ -245,7 +257,7 @@
 
       op->expand_tail ();
 
-      if (op->blocked (creator->map, creator->x, creator->y))
+      if (!creator->is_on_map () || op->blocked (creator->map, creator->x, creator->y))
         op->destroy ();
       else
         {
@@ -259,10 +271,6 @@
 
       if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER))
         monster_check_apply (creator, op);
-
-      if (flags & GT_UPDATE_INV)
-        if (object *tmp = creator->in_player ())
-          esrv_send_item (tmp, op);
     }
 }
 
@@ -436,6 +444,7 @@
     LOG (llevError, "In generate treasure, created multiple objects.\n");
 
   ob->destroy ();
+
   return tmp;
 }
 
@@ -572,14 +581,17 @@
 
       if (magic < 0 && !(rndm (3)))        /* You can't just check the weight always */
         magic = (-magic);
+
       op->weight = (op->arch->weight * (100 - magic * 10)) / 100;
     }
   else
     {
       if (op->type == ARMOUR)
         ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100;
+
       if (magic < 0 && !(rndm (3)))        /* You can't just check the weight always */
         magic = (-magic);
+
       op->weight = (op->weight * (100 - magic * 10)) / 100;
     }
 }
@@ -818,7 +830,7 @@
 
   if (!(flags & GT_MINIMAL))
     {
-      if (op->arch == crown_arch)
+      if (IS_ARCH (op->arch, crown))
         {
           set_magic (difficulty, op, max_magic, flags);
           num_enchantments = calc_item_power (op, 1);
@@ -833,8 +845,7 @@
 
           if ((!was_magic && !rndm (CHANCE_FOR_ARTIFACT))
               || op->type == HORN
-              || difficulty >= settings.max_level)       /* high difficulties always generate an artifact,
-                                                                                                                                 * used for shop_floors or treasures */
+              || difficulty >= settings.max_level) /* high difficulties always generate an artifact, used for shop_floors or treasures */
             generate_artifact (op, difficulty);
         }
 
@@ -886,9 +897,7 @@
         /* Handle healing and magic power potions */
         if (op->stats.sp && !op->randomitems)
           {
-            object *tmp;
-
-            tmp = get_archetype (spell_mapping[op->stats.sp]);
+            object *tmp = get_archetype (spell_mapping [op->stats.sp]);
             insert_ob_in_ob (tmp, op);
             op->stats.sp = 0;
           }
@@ -956,18 +965,11 @@
             }
 
           case AMULET:
-            if (op->arch == amulet_arch)
+            if (IS_ARCH (op->arch, amulet))
               op->value *= 5;   /* Since it's not just decoration */
 
           case RING:
-            if (op->arch == NULL)
-              {
-                op->destroy ();
-                op = 0;
-                break;
-              }
-
-            if (op->arch != ring_arch && op->arch != amulet_arch)       /* It's a special artifact! */
+            if (!IS_ARCH (op->arch, ring) && !IS_ARCH (op->arch, amulet))       /* It's a special artifact! */
               break;
 
             if (!(flags & GT_ONLY_GOOD) && !(rndm (3)))
@@ -997,8 +999,8 @@
                   }
               }
 
-            if (GET_ANIM_ID (op))
-              SET_ANIMATION (op, rndm (NUM_ANIMATIONS (op)));
+            if (op->animation_id)
+              op->set_anim_frame (rndm (op->anim_frames ()));
 
             break;
 
@@ -1348,14 +1350,11 @@
        */
       if (op->type == HORN || op->type == POTION)
         {
-          object *tmp_obj;
-
           /* Remove any spells this object currently has in it */
-          while (op->inv)
-            op->inv->destroy ();
+          op->destroy_inv (false);
 
-          tmp_obj = arch_to_object (change->other_arch);
-          insert_ob_in_ob (tmp_obj, op);
+          object *tmp = arch_to_object (change->other_arch);
+          insert_ob_in_ob (tmp, op);
         }
       /* No harm setting this for potions/horns */
       op->other_arch = change->other_arch;
@@ -1570,9 +1569,11 @@
 #endif
           return;
         }
-      if (!strcmp (art->item->name, "NONE"))
+
+      if (art->item->name == shstr_NONE)
         return;
-      if (FABS (op->magic) < art->item->magic)
+
+      if (fabs (op->magic) < art->item->magic)
         continue;               /* Not magic enough to be this item */
 
       /* Map difficulty not high enough */
@@ -1633,8 +1634,10 @@
       /* if donor has some attacktypes, the flesh is poisonous */
       if (donor->attacktype & AT_POISON)
         item->type = POISON;
+
       if (donor->attacktype & AT_ACID)
         item->stats.hp = -1 * item->stats.food;
+
       SET_FLAG (item, FLAG_NO_STEAL);
     }
 }
@@ -1681,7 +1684,7 @@
   if (at->next)    free_artifact  (at->next);
   if (at->allowed) free_charlinks (at->allowed);
 
-  at->item->destroy (1);
+  at->item->destroy ();
 
   sfree (at);
 }