ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/treasure.C
(Generate patch)

Comparing deliantra/server/common/treasure.C (file contents):
Revision 1.16 by root, Sun Sep 10 16:00:23 2006 UTC vs.
Revision 1.64 by root, Sun Jul 1 05:00:18 2007 UTC

1
2/* 1/*
3 * static char *rcs_treasure_c = 2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG.
4 * "$Id: treasure.C,v 1.16 2006/09/10 16:00:23 root Exp $"; 3 *
5 */ 4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team
6
7/*
8 CrossFire, A Multiplayer game for X-windows
9
10 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
12 7 *
13 This program is free software; you can redistribute it and/or modify 8 * Crossfire TRT is free software: you can redistribute it and/or modify
14 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
15 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
16 (at your option) any later version. 11 * (at your option) any later version.
17 12 *
18 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details. 16 * GNU General Public License for more details.
22 17 *
23 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
26 21 * The authors can be reached via e-mail to <crossfire@schmorp.de>
27 The authors can be reached via e-mail at crossfire-devel@real-time.com
28*/ 22 */
29
30#define ALLOWED_COMBINATION
31 23
32/* TREASURE_DEBUG does some checking on the treasurelists after loading. 24/* TREASURE_DEBUG does some checking on the treasurelists after loading.
33 * It is useful for finding bugs in the treasures file. Since it only 25 * It is useful for finding bugs in the treasures file. Since it only
34 * slows the startup some (and not actual game play), it is by default 26 * slows the startup some (and not actual game play), it is by default
35 * left on 27 * left on
36 */ 28 */
37#define TREASURE_DEBUG 29#define TREASURE_DEBUG
38 30
39/* TREASURE_VERBOSE enables copious output concerning artifact generation */ 31/* TREASURE_VERBOSE enables copious output concerning artifact generation */
40 32
41/* #define TREASURE_VERBOSE */ 33//#define TREASURE_VERBOSE
42 34
43#include <global.h> 35#include <global.h>
44#include <treasure.h> 36#include <treasure.h>
45#include <funcpoint.h> 37#include <funcpoint.h>
46#include <loader.h> 38#include <loader.h>
47 39
40extern char *spell_mapping[];
41
42static treasurelist *first_treasurelist;
48 43
49static void change_treasure (treasure *t, object *op); /* overrule default values */ 44static void change_treasure (treasure *t, object *op); /* overrule default values */
50extern char *spell_mapping[];
51 45
52/* 46typedef std::tr1::unordered_map<
53 * Initialize global archtype pointers: 47 const char *,
54 */ 48 treasurelist *,
49 str_hash,
50 str_equal,
51 slice_allocator< std::pair<const char *const, treasurelist *> >,
52 true
53> tl_map_t;
55 54
55static tl_map_t tl_map;
56
57/*
58 * Searches for the given treasurelist
59 */
60treasurelist *
61treasurelist::find (const char *name)
62{
63 if (!name)
64 return 0;
65
66 auto (i, tl_map.find (name));
67
68 if (i == tl_map.end ())
69 return 0;
70
71 return i->second;
72}
73
74/*
75 * Searches for the given treasurelist in the globally linked list
76 * of treasurelists which has been built by load_treasures().
77 */
78treasurelist *
79treasurelist::get (const char *name)
80{
81 treasurelist *tl = find (name);
82
83 if (!tl)
84 {
85 tl = new treasurelist;
86
87 tl->name = name;
88 tl->next = first_treasurelist;
89 first_treasurelist = tl;
90
91 tl_map.insert (std::make_pair (tl->name, tl));
92 }
93
94 return tl;
95}
96
97//TODO: class method
56void 98void
57init_archetype_pointers () 99clear (treasurelist *tl)
58{ 100{
59 int prev_warn = warn_archetypes; 101 if (tl->items)
102 {
103 free_treasurestruct (tl->items);
104 tl->items = 0;
105 }
60 106
61 warn_archetypes = 1;
62 if (ring_arch == NULL)
63 ring_arch = find_archetype ("ring");
64 if (amulet_arch == NULL)
65 amulet_arch = find_archetype ("amulet");
66 if (staff_arch == NULL)
67 staff_arch = find_archetype ("staff");
68 if (crown_arch == NULL)
69 crown_arch = find_archetype ("crown");
70 warn_archetypes = prev_warn;
71}
72
73/*
74 * Allocate and return the pointer to an empty treasurelist structure.
75 */
76
77static treasurelist *
78get_empty_treasurelist (void)
79{
80 return new treasurelist;
81}
82
83/*
84 * Allocate and return the pointer to an empty treasure structure.
85 */
86//TODO: make this a constructor
87static treasure *
88get_empty_treasure (void)
89{
90 treasure *t = new treasure;
91
92 t->chance = 100; 107 tl->total_chance = 0;
93
94 return t;
95} 108}
109
110#ifdef TREASURE_DEBUG
111/* recursived checks the linked list. Treasurelist is passed only
112 * so that the treasure name can be printed out
113 */
114static void
115check_treasurelist (const treasure *t, const treasurelist * tl)
116{
117 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
118 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
119
120 if (t->next)
121 check_treasurelist (t->next, tl);
122
123 if (t->next_yes)
124 check_treasurelist (t->next_yes, tl);
125
126 if (t->next_no)
127 check_treasurelist (t->next_no, tl);
128}
129#endif
96 130
97/* 131/*
98 * Reads the lib/treasure file from disk, and parses the contents 132 * Reads the lib/treasure file from disk, and parses the contents
99 * into an internal treasure structure (very linked lists) 133 * into an internal treasure structure (very linked lists)
100 */ 134 */
101
102static treasure * 135static treasure *
103load_treasure (FILE * fp, int *line) 136read_treasure (object_thawer &f)
104{ 137{
105 char buf[MAX_BUF], *cp, variable[MAX_BUF];
106 treasure *t = get_empty_treasure (); 138 treasure *t = new treasure;
107 int value;
108 139
109 nroftreasures++; 140 f.next ();
110 while (fgets (buf, MAX_BUF, fp) != NULL)
111 {
112 (*line)++;
113 141
114 if (*buf == '#') 142 for (;;)
115 continue; 143 {
116 if ((cp = strchr (buf, '\n')) != NULL) 144 coroapi::cede_to_tick_every (10);
117 *cp = '\0';
118 cp = buf;
119 while (isspace (*cp)) /* Skip blanks */
120 cp++;
121 145
122 if (sscanf (cp, "arch %s", variable)) 146 switch (f.kw)
123 {
124 if ((t->item = find_archetype (variable)) == NULL)
125 LOG (llevError, "Treasure lacks archetype: %s\n", variable);
126 } 147 {
127 else if (sscanf (cp, "list %s", variable)) 148 case KW_arch:
128 t->name = variable; 149 t->item = archetype::get (f.get_str ());
129 else if (sscanf (cp, "change_name %s", variable)) 150 break;
130 t->change_arch.name = variable; 151
131 else if (sscanf (cp, "change_title %s", variable)) 152 case KW_list: f.get (t->name); break;
132 t->change_arch.title = variable; 153 case KW_change_name: f.get (t->change_arch.name); break;
133 else if (sscanf (cp, "change_slaying %s", variable)) 154 case KW_change_title: f.get (t->change_arch.title); break;
134 t->change_arch.slaying = variable; 155 case KW_change_slaying: f.get (t->change_arch.slaying); break;
135 else if (sscanf (cp, "chance %d", &value)) 156 case KW_chance: f.get (t->chance); break;
136 t->chance = (uint8) value; 157 case KW_nrof: f.get (t->nrof); break;
137 else if (sscanf (cp, "nrof %d", &value)) 158 case KW_magic: f.get (t->magic); break;
138 t->nrof = (uint16) value; 159
139 else if (sscanf (cp, "magic %d", &value)) 160 case KW_yes: t->next_yes = read_treasure (f); continue;
140 t->magic = (uint8) value; 161 case KW_no: t->next_no = read_treasure (f); continue;
141 else if (!strcmp (cp, "yes")) 162
142 t->next_yes = load_treasure (fp, line); 163 case KW_end:
143 else if (!strcmp (cp, "no")) 164 f.next ();
144 t->next_no = load_treasure (fp, line);
145 else if (!strcmp (cp, "end"))
146 return t;
147 else if (!strcmp (cp, "more"))
148 {
149 t->next = load_treasure (fp, line);
150 return t; 165 return t;
151 }
152 else
153 LOG (llevError, "Unknown treasure-command: '%s', last entry %s, line %d\n", cp, &t->name, *line);
154 }
155 LOG (llevError, "treasure lacks 'end'.\n");
156 return t;
157}
158 166
159#ifdef TREASURE_DEBUG 167 case KW_more:
168 t->next = read_treasure (f);
169 return t;
160 170
161/* recursived checks the linked list. Treasurelist is passed only 171 default:
162 * so that the treasure name can be printed out 172 if (!f.parse_error ("treasurelist", t->name))
163 */ 173 return 0;
164static void
165check_treasurelist (const treasure *t, const treasurelist * tl)
166{
167 if (t->item == NULL && t->name == NULL)
168 LOG (llevError, "Treasurelist %s has element with no name or archetype\n", &tl->name);
169 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
170 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
171 /* find_treasurelist will print out its own error message */
172 if (t->name && *t->name)
173 (void) find_treasurelist (t->name);
174 if (t->next)
175 check_treasurelist (t->next, tl);
176 if (t->next_yes)
177 check_treasurelist (t->next_yes, tl);
178 if (t->next_no)
179 check_treasurelist (t->next_no, tl);
180}
181#endif
182 174
175 return t;
176 }
177
178 f.next ();
179 }
180}
181
183/* 182/*
184 * Opens LIBDIR/treasure and reads all treasure-declarations from it.
185 * Each treasure is parsed with the help of load_treasure(). 183 * Each treasure is parsed with the help of load_treasure().
186 */ 184 */
187 185treasurelist *
188void 186treasurelist::read (object_thawer &f)
189load_treasures (void)
190{ 187{
191 FILE *fp; 188 assert (f.kw == KW_treasure || f.kw == KW_treasureone);
192 char filename[MAX_BUF], buf[MAX_BUF], name[MAX_BUF];
193 treasurelist *previous = NULL;
194 treasure *t;
195 int comp, line = 0;
196 189
197 sprintf (filename, "%s/%s", settings.datadir, settings.treasures); 190 bool one = f.kw == KW_treasureone;
198 if ((fp = open_and_uncompress (filename, 0, &comp)) == NULL) 191 treasurelist *tl = treasurelist::get (f.get_str ());
199 { 192 clear (tl);
200 LOG (llevError, "Can't open treasure file.\n"); 193 tl->items = read_treasure (f);
194 if (!tl->items)
201 return; 195 return 0;
202 }
203 while (fgets (buf, MAX_BUF, fp) != NULL)
204 {
205 line++;
206 if (*buf == '#')
207 continue;
208 196
209 if (sscanf (buf, "treasureone %s\n", name) || sscanf (buf, "treasure %s\n", name))
210 {
211 treasurelist *tl = get_empty_treasurelist ();
212
213 tl->name = name;
214 if (previous == NULL)
215 first_treasurelist = tl;
216 else
217 previous->next = tl;
218 previous = tl;
219 tl->items = load_treasure (fp, &line);
220
221 /* This is a one of the many items on the list should be generated. 197 /* This is a one of the many items on the list should be generated.
222 * Add up the chance total, and check to make sure the yes & no 198 * Add up the chance total, and check to make sure the yes & no
223 * fields of the treasures are not being used. 199 * fields of the treasures are not being used.
224 */ 200 */
225 if (!strncmp (buf, "treasureone", 11)) 201 if (one)
202 {
203 for (treasure *t = tl->items; t; t = t->next)
204 {
205 if (t->next_yes || t->next_no)
226 { 206 {
227 for (t = tl->items; t != NULL; t = t->next)
228 {
229#ifdef TREASURE_DEBUG
230 if (t->next_yes || t->next_no)
231 {
232 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->name : &t->name); 207 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->archname : &t->name);
233 LOG (llevError, " the next_yes or next_no field is set\n"); 208 LOG (llevError, " the next_yes or next_no field is set\n");
234 }
235#endif
236 tl->total_chance += t->chance;
237 }
238 } 209 }
239 }
240 else
241 LOG (llevError, "Treasure-list %s didn't understand: %s, line %d\n", filename, buf, line);
242 }
243 close_and_delete (fp, comp);
244 210
245#ifdef TREASURE_DEBUG 211 tl->total_chance += t->chance;
246 /* Perform some checks on how valid the treasure data actually is. 212 }
247 * verify that list transitions work (ie, the list that it is supposed 213 }
248 * to transition to exists). Also, verify that at least the name
249 * or archetype is set for each treasure element.
250 */
251 for (previous = first_treasurelist; previous != NULL; previous = previous->next)
252 check_treasurelist (previous->items, previous);
253#endif
254}
255 214
256/*
257 * Searches for the given treasurelist in the globally linked list
258 * of treasurelists which has been built by load_treasures().
259 */
260
261treasurelist *
262find_treasurelist (const char *name)
263{
264 /* Special cases - randomitems of NULL is to override default. If
265 * first_treasurelist is null, it means we are on the first pass of
266 * of loading archetypes, so for now, just return - second pass will
267 * init these values.
268 */
269 if (!name)
270 return 0;
271
272 if (const char *tmp = shstr::find (name))
273 for (treasurelist * tl = first_treasurelist; tl != 0; tl = tl->next)
274 if (tmp == tl->name)
275 return tl;
276
277 if (first_treasurelist)
278 LOG (llevError, "Couldn't find treasurelist %s\n", name);
279
280 return 0; 215 return tl;
281} 216}
282
283 217
284/* 218/*
285 * Generates the objects specified by the given treasure. 219 * Generates the objects specified by the given treasure.
286 * It goes recursively through the rest of the linked list. 220 * It goes recursively through the rest of the linked list.
287 * If there is a certain percental chance for a treasure to be generated, 221 * If there is a certain percental chance for a treasure to be generated,
290 * being generated. 224 * being generated.
291 * If flag is GT_INVISIBLE, only invisible objects are generated (ie, only 225 * If flag is GT_INVISIBLE, only invisible objects are generated (ie, only
292 * abilities. This is used by summon spells, thus no summoned monsters 226 * abilities. This is used by summon spells, thus no summoned monsters
293 * start with equipment, but only their abilities). 227 * start with equipment, but only their abilities).
294 */ 228 */
295
296
297static void 229static void
298put_treasure (object *op, object *creator, int flags) 230put_treasure (object *op, object *creator, int flags)
299{ 231{
300 object *tmp; 232 if (flags & GT_ENVIRONMENT)
301 233 {
302 /* Bit of a hack - spells should never be put onto the map. The entire 234 /* Bit of a hack - spells should never be put onto the map. The entire
303 * treasure stuff is a problem - there is no clear idea of knowing 235 * treasure stuff is a problem - there is no clear idea of knowing
304 * this is the original object, or if this is an object that should be created 236 * this is the original object, or if this is an object that should be created
305 * by another object. 237 * by another object.
306 */ 238 */
307 if (flags & GT_ENVIRONMENT && op->type != SPELL) 239 //TODO: flag such as objects... as such (no drop, anybody?)
308 { 240 if (op->type == SPELL)
309 op->x = creator->x; 241 {
310 op->y = creator->y; 242 op->destroy ();
243 return;
244 }
245
246 op->expand_tail ();
247
248 if (ob_blocked (op, creator->map, creator->x, creator->y))
249 op->destroy ();
250 else
251 {
311 SET_FLAG (op, FLAG_OBJ_ORIGINAL); 252 SET_FLAG (op, FLAG_OBJ_ORIGINAL);
312 insert_ob_in_map (op, creator->map, op, INS_NO_MERGE | INS_NO_WALK_ON); 253 op->insert_at (creator, creator, INS_NO_MERGE | INS_NO_WALK_ON);
254 }
313 } 255 }
314 else 256 else
315 { 257 {
316 op = insert_ob_in_ob (op, creator); 258 op = creator->insert (op);
259
317 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER)) 260 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER))
318 monster_check_apply (creator, op); 261 monster_check_apply (creator, op);
319 if ((flags & GT_UPDATE_INV) && (tmp = is_player_inv (creator)) != NULL) 262
263 if (flags & GT_UPDATE_INV)
264 if (object *tmp = creator->in_player ())
320 esrv_send_item (tmp, op); 265 esrv_send_item (tmp, op);
321 } 266 }
322} 267}
323 268
324/* if there are change_xxx commands in the treasure, we include the changes 269/* if there are change_xxx commands in the treasure, we include the changes
325 * in the generated object 270 * in the generated object
339 284
340 if (t->change_arch.slaying) 285 if (t->change_arch.slaying)
341 op->slaying = t->change_arch.slaying; 286 op->slaying = t->change_arch.slaying;
342} 287}
343 288
344void 289static void
345create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries) 290create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries)
346{ 291{
347 object *tmp;
348
349 if ((int) t->chance >= 100 || (RANDOM () % 100 + 1) < (int) t->chance) 292 if ((int) t->chance >= 100 || (rndm (100) + 1) < (int) t->chance)
350 { 293 {
351 if (t->name) 294 if (t->name)
352 { 295 {
353 if (strcmp (t->name, "NONE") && difficulty >= t->magic) 296 if (difficulty >= t->magic)
297 if (treasurelist *tl = treasurelist::find (t->name))
354 create_treasure (find_treasurelist (t->name), op, flag, difficulty, tries); 298 create_treasure (tl, op, flag, difficulty, tries);
299 else
300 LOG (llevError, "create_all_treasures: undefined reference to treasurelist '%s'.\n", &t->name);
355 } 301 }
356 else 302 else
357 { 303 {
358 if (t->item->clone.invisible != 0 || !(flag & GT_INVISIBLE)) 304 if (t->item && (t->item->invisible != 0 || !(flag & GT_INVISIBLE)))
359 { 305 {
360 tmp = arch_to_object (t->item); 306 object *tmp = arch_to_object (t->item);
307
361 if (t->nrof && tmp->nrof <= 1) 308 if (t->nrof && tmp->nrof <= 1)
362 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 309 tmp->nrof = rndm (t->nrof) + 1;
310
363 fix_generated_item (tmp, op, difficulty, t->magic, flag); 311 fix_generated_item (tmp, op, difficulty, t->magic, flag);
364 change_treasure (t, tmp); 312 change_treasure (t, tmp);
365 put_treasure (tmp, op, flag); 313 put_treasure (tmp, op, flag);
366 } 314 }
367 } 315 }
368 316
369 if (t->next_yes != NULL) 317 if (t->next_yes)
370 create_all_treasures (t->next_yes, op, flag, difficulty, tries); 318 create_all_treasures (t->next_yes, op, flag, difficulty, tries);
371 } 319 }
372 else if (t->next_no != NULL) 320 else if (t->next_no)
373 create_all_treasures (t->next_no, op, flag, difficulty, tries); 321 create_all_treasures (t->next_no, op, flag, difficulty, tries);
374 322
375 if (t->next != NULL) 323 if (t->next)
376 create_all_treasures (t->next, op, flag, difficulty, tries); 324 create_all_treasures (t->next, op, flag, difficulty, tries);
377} 325}
378 326
379void 327static void
380create_one_treasure (treasurelist * tl, object *op, int flag, int difficulty, int tries) 328create_one_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
381{ 329{
382 int value = RANDOM () % tl->total_chance; 330 int value = rndm (tl->total_chance);
383 treasure *t; 331 treasure *t;
384 332
385 if (tries++ > 100) 333 if (tries++ > 100)
386 { 334 {
387 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n"); 335 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n");
388 return; 336 return;
389 } 337 }
390 338
391 for (t = tl->items; t != NULL; t = t->next) 339 for (t = tl->items; t; t = t->next)
392 { 340 {
393 value -= t->chance; 341 value -= t->chance;
394 342
395 if (value < 0) 343 if (value < 0)
396 break; 344 break;
397 } 345 }
398 346
399 if (!t || value >= 0) 347 if (!t || value >= 0)
400 {
401 LOG (llevError, "create_one_treasure: got null object or not able to find treasure\n"); 348 cleanup ("create_one_treasure: got null object or not able to find treasure\n", 1);
402 abort ();
403 return;
404 }
405 349
406 if (t->name) 350 if (t->name)
407 { 351 {
408 if (!strcmp (t->name, "NONE"))
409 return;
410
411 if (difficulty >= t->magic) 352 if (difficulty >= t->magic)
353 {
354 treasurelist *tl = treasurelist::find (t->name);
355 if (tl)
412 create_treasure (find_treasurelist (t->name), op, flag, difficulty, tries); 356 create_treasure (tl, op, flag, difficulty, tries);
357 }
413 else if (t->nrof) 358 else if (t->nrof)
414 create_one_treasure (tl, op, flag, difficulty, tries); 359 create_one_treasure (tl, op, flag, difficulty, tries);
415
416 return;
417 } 360 }
418
419 if ((t->item && t->item->clone.invisible != 0) || flag != GT_INVISIBLE) 361 else if (t->item && (t->item->invisible != 0 || flag != GT_INVISIBLE))
420 { 362 {
421 object *tmp = arch_to_object (t->item); 363 if (object *tmp = arch_to_object (t->item))
422 364 {
423 if (!tmp)
424 return;
425
426 if (t->nrof && tmp->nrof <= 1) 365 if (t->nrof && tmp->nrof <= 1)
427 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 366 tmp->nrof = rndm (t->nrof) + 1;
428 367
429 fix_generated_item (tmp, op, difficulty, t->magic, flag); 368 fix_generated_item (tmp, op, difficulty, t->magic, flag);
430 change_treasure (t, tmp); 369 change_treasure (t, tmp);
431 put_treasure (tmp, op, flag); 370 put_treasure (tmp, op, flag);
371 }
432 } 372 }
373}
374
375void
376object::create_treasure (treasurelist *tl, int flags)
377{
378 ::create_treasure (tl, this, flags, map ? map->difficulty : 0);
433} 379}
434 380
435/* This calls the appropriate treasure creation function. tries is passed 381/* This calls the appropriate treasure creation function. tries is passed
436 * to determine how many list transitions or attempts to create treasure 382 * to determine how many list transitions or attempts to create treasure
437 * have been made. It is really in place to prevent infinite loops with 383 * have been made. It is really in place to prevent infinite loops with
438 * list transitions, or so that excessively good treasure will not be 384 * list transitions, or so that excessively good treasure will not be
439 * created on weak maps, because it will exceed the number of allowed tries 385 * created on weak maps, because it will exceed the number of allowed tries
440 * to do that. 386 * to do that.
441 */ 387 */
442void 388void
443create_treasure (treasurelist * t, object *op, int flag, int difficulty, int tries) 389create_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
444{ 390{
391 // empty treasurelists are legal
392 if (!tl->items)
393 return;
445 394
446 if (tries++ > 100) 395 if (tries++ > 100)
447 { 396 {
448 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n"); 397 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n");
449 return; 398 return;
450 } 399 }
400
401 if (op->flag [FLAG_TREASURE_ENV])
402 {
403 // do not generate items when there already is something above the object
404 if (op->flag [FLAG_IS_FLOOR] && op->above)
405 return;
406
407 flag |= GT_ENVIRONMENT;
408 }
409
451 if (t->total_chance) 410 if (tl->total_chance)
452 create_one_treasure (t, op, flag, difficulty, tries); 411 create_one_treasure (tl, op, flag, difficulty, tries);
453 else 412 else
454 create_all_treasures (t->items, op, flag, difficulty, tries); 413 create_all_treasures (tl->items, op, flag, difficulty, tries);
455} 414}
456 415
457/* This is similar to the old generate treasure function. However, 416/* This is similar to the old generate treasure function. However,
458 * it instead takes a treasurelist. It is really just a wrapper around 417 * it instead takes a treasurelist. It is really just a wrapper around
459 * create_treasure. We create a dummy object that the treasure gets 418 * create_treasure. We create a dummy object that the treasure gets
460 * inserted into, and then return that treausre 419 * inserted into, and then return that treausre
461 */ 420 */
462object * 421object *
463generate_treasure (treasurelist * t, int difficulty) 422generate_treasure (treasurelist *tl, int difficulty)
464{ 423{
465 object *ob = get_object (), *tmp; 424 difficulty = clamp (difficulty, 1, settings.max_level);
466 425
426 object *ob = object::create ();
427
467 create_treasure (t, ob, 0, difficulty, 0); 428 create_treasure (tl, ob, 0, difficulty, 0);
468 429
469 /* Don't want to free the object we are about to return */ 430 /* Don't want to free the object we are about to return */
470 tmp = ob->inv; 431 object *tmp = ob->inv;
471 if (tmp != NULL) 432 if (tmp)
472 remove_ob (tmp); 433 tmp->remove ();
434
473 if (ob->inv) 435 if (ob->inv)
474 {
475 LOG (llevError, "In generate treasure, created multiple objects.\n"); 436 LOG (llevError, "In generate treasure, created multiple objects.\n");
476 } 437
477 free_object (ob); 438 ob->destroy ();
478 return tmp; 439 return tmp;
479} 440}
480 441
481/* 442/*
482 * This is a new way of calculating the chance for an item to have 443 * This is a new way of calculating the chance for an item to have
484 * The array has two arguments, the difficulty of the level, and the 445 * The array has two arguments, the difficulty of the level, and the
485 * magical bonus "wanted". 446 * magical bonus "wanted".
486 */ 447 */
487 448
488static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = { 449static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = {
489
490/*chance of magic difficulty*/ 450// chance of magic difficulty
491
492/* +0 +1 +2 +3 +4 */ 451// +0 +1 +2 +3 +4
493 {95, 2, 2, 1, 0}, /*1 */ 452 {95, 2, 2, 1, 0}, // 1
494 {92, 5, 2, 1, 0}, /*2 */ 453 {92, 5, 2, 1, 0}, // 2
495 {85, 10, 4, 1, 0}, /*3 */ 454 {85, 10, 4, 1, 0}, // 3
496 {80, 14, 4, 2, 0}, /*4 */ 455 {80, 14, 4, 2, 0}, // 4
497 {75, 17, 5, 2, 1}, /*5 */ 456 {75, 17, 5, 2, 1}, // 5
498 {70, 18, 8, 3, 1}, /*6 */ 457 {70, 18, 8, 3, 1}, // 6
499 {65, 21, 10, 3, 1}, /*7 */ 458 {65, 21, 10, 3, 1}, // 7
500 {60, 22, 12, 4, 2}, /*8 */ 459 {60, 22, 12, 4, 2}, // 8
501 {55, 25, 14, 4, 2}, /*9 */ 460 {55, 25, 14, 4, 2}, // 9
502 {50, 27, 16, 5, 2}, /*10 */ 461 {50, 27, 16, 5, 2}, // 10
503 {45, 28, 18, 6, 3}, /*11 */ 462 {45, 28, 18, 6, 3}, // 11
504 {42, 28, 20, 7, 3}, /*12 */ 463 {42, 28, 20, 7, 3}, // 12
505 {40, 27, 21, 8, 4}, /*13 */ 464 {40, 27, 21, 8, 4}, // 13
506 {38, 25, 22, 10, 5}, /*14 */ 465 {38, 25, 22, 10, 5}, // 14
507 {36, 23, 23, 12, 6}, /*15 */ 466 {36, 23, 23, 12, 6}, // 15
508 {33, 21, 24, 14, 8}, /*16 */ 467 {33, 21, 24, 14, 8}, // 16
509 {31, 19, 25, 16, 9}, /*17 */ 468 {31, 19, 25, 16, 9}, // 17
510 {27, 15, 30, 18, 10}, /*18 */ 469 {27, 15, 30, 18, 10}, // 18
511 {20, 12, 30, 25, 13}, /*19 */ 470 {20, 12, 30, 25, 13}, // 19
512 {15, 10, 28, 30, 17}, /*20 */ 471 {15, 10, 28, 30, 17}, // 20
513 {13, 9, 27, 28, 23}, /*21 */ 472 {13, 9, 27, 28, 23}, // 21
514 {10, 8, 25, 28, 29}, /*22 */ 473 {10, 8, 25, 28, 29}, // 22
515 {8, 7, 23, 26, 36}, /*23 */ 474 { 8, 7, 23, 26, 36}, // 23
516 {6, 6, 20, 22, 46}, /*24 */ 475 { 6, 6, 20, 22, 46}, // 24
517 {4, 5, 17, 18, 56}, /*25 */ 476 { 4, 5, 17, 18, 56}, // 25
518 {2, 4, 12, 14, 68}, /*26 */ 477 { 2, 4, 12, 14, 68}, // 26
519 {0, 3, 7, 10, 80}, /*27 */ 478 { 0, 3, 7, 10, 80}, // 27
520 {0, 0, 3, 7, 90}, /*28 */ 479 { 0, 0, 3, 7, 90}, // 28
521 {0, 0, 0, 3, 97}, /*29 */ 480 { 0, 0, 0, 3, 97}, // 29
522 {0, 0, 0, 0, 100}, /*30 */ 481 { 0, 0, 0, 0, 100}, // 30
523 {0, 0, 0, 0, 100}, /*31 */ 482 { 0, 0, 0, 0, 100}, // 31
524}; 483};
525
526 484
527/* calculate the appropriate level for wands staves and scrolls. 485/* calculate the appropriate level for wands staves and scrolls.
528 * This code presumes that op has had its spell object created (in op->inv) 486 * This code presumes that op has had its spell object created (in op->inv)
529 * 487 *
530 * elmex Wed Aug 9 17:44:59 CEST 2006: 488 * elmex Wed Aug 9 17:44:59 CEST 2006:
531 * Removed multiplicator, too many high-level items were generated on low-difficulty maps. 489 * Removed multiplicator, too many high-level items were generated on low-difficulty maps.
532 */ 490 */
533
534int 491int
535level_for_item (const object *op, int difficulty) 492level_for_item (const object *op, int difficulty)
536{ 493{
537 int olevel = 0; 494 int olevel = 0;
538 495
561 * elmex Thu Aug 10 18:45:44 CEST 2006: 518 * elmex Thu Aug 10 18:45:44 CEST 2006:
562 * Scaling difficulty by max_level, as difficulty is a level and not some 519 * Scaling difficulty by max_level, as difficulty is a level and not some
563 * weird integer between 1-31. 520 * weird integer between 1-31.
564 * 521 *
565 */ 522 */
566
567int 523int
568magic_from_difficulty (int difficulty) 524magic_from_difficulty (int difficulty)
569{ 525{
570 int percent = 0, magic = 0; 526 int percent = 0, magic = 0;
571 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS); 527 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS);
576 scaled_diff = 0; 532 scaled_diff = 0;
577 533
578 if (scaled_diff >= DIFFLEVELS) 534 if (scaled_diff >= DIFFLEVELS)
579 scaled_diff = DIFFLEVELS - 1; 535 scaled_diff = DIFFLEVELS - 1;
580 536
581 percent = RANDOM () % 100; 537 percent = rndm (100);
582 538
583 for (magic = 0; magic < (MAXMAGIC + 1); magic++) 539 for (magic = 0; magic < (MAXMAGIC + 1); magic++)
584 { 540 {
585 percent -= difftomagic_list[scaled_diff][magic]; 541 percent -= difftomagic_list[scaled_diff][magic];
586 542
592 { 548 {
593 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty); 549 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty);
594 magic = 0; 550 magic = 0;
595 } 551 }
596 552
597 magic = (RANDOM () % 3) ? magic : -magic; 553 magic = (rndm (3)) ? magic : -magic;
598 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */ 554 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */
599 555
600 return magic; 556 return magic;
601} 557}
602 558
615 571
616 op->magic = magic; 572 op->magic = magic;
617 if (op->arch) 573 if (op->arch)
618 { 574 {
619 if (op->type == ARMOUR) 575 if (op->type == ARMOUR)
620 ARMOUR_SPEED (op) = (ARMOUR_SPEED (&op->arch->clone) * (100 + magic * 10)) / 100; 576 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op->arch) * (100 + magic * 10)) / 100;
621 577
622 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 578 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
623 magic = (-magic); 579 magic = (-magic);
624 op->weight = (op->arch->clone.weight * (100 - magic * 10)) / 100; 580 op->weight = (op->arch->weight * (100 - magic * 10)) / 100;
625 } 581 }
626 else 582 else
627 { 583 {
628 if (op->type == ARMOUR) 584 if (op->type == ARMOUR)
629 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100; 585 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100;
630 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 586 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
631 magic = (-magic); 587 magic = (-magic);
632 op->weight = (op->weight * (100 - magic * 10)) / 100; 588 op->weight = (op->weight * (100 - magic * 10)) / 100;
633 } 589 }
634} 590}
635 591
659 * 1) Since rings can have multiple bonuses, if the same bonus 615 * 1) Since rings can have multiple bonuses, if the same bonus
660 * is rolled again, increase it - the bonuses now stack with 616 * is rolled again, increase it - the bonuses now stack with
661 * other bonuses previously rolled and ones the item might natively have. 617 * other bonuses previously rolled and ones the item might natively have.
662 * 2) Add code to deal with new PR method. 618 * 2) Add code to deal with new PR method.
663 */ 619 */
664
665void 620void
666set_ring_bonus (object *op, int bonus) 621set_ring_bonus (object *op, int bonus)
667{ 622{
668 623
669 int r = RANDOM () % (bonus > 0 ? 25 : 11); 624 int r = rndm (bonus > 0 ? 25 : 11);
670 625
671 if (op->type == AMULET) 626 if (op->type == AMULET)
672 { 627 {
673 if (!(RANDOM () % 21)) 628 if (!(rndm (21)))
674 r = 20 + RANDOM () % 2; 629 r = 20 + rndm (2);
675 else 630 else
676 { 631 {
677 if (RANDOM () & 2) 632 if (rndm (2))
678 r = 10; 633 r = 10;
679 else 634 else
680 r = 11 + RANDOM () % 9; 635 r = 11 + rndm (9);
681 } 636 }
682 } 637 }
683 638
684 switch (r) 639 switch (r)
685 { 640 {
692 case 2: 647 case 2:
693 case 3: 648 case 3:
694 case 4: 649 case 4:
695 case 5: 650 case 5:
696 case 6: 651 case 6:
697 set_attr_value (&op->stats, r, (signed char) (bonus + get_attr_value (&op->stats, r))); 652 op->stats.stat (r) += bonus;
698 break; 653 break;
699 654
700 case 7: 655 case 7:
701 op->stats.dam += bonus; 656 op->stats.dam += bonus;
702 break; 657 break;
722 case 16: 677 case 16:
723 case 17: 678 case 17:
724 case 18: 679 case 18:
725 case 19: 680 case 19:
726 { 681 {
727 int b = 5 + FABS (bonus), val, resist = RANDOM () % num_resist_table; 682 int b = 5 + abs (bonus), val, resist = rndm (num_resist_table);
728 683
729 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */ 684 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */
730 val = 10 + RANDOM () % b + RANDOM () % b + RANDOM () % b + RANDOM () % b; 685 val = 10 + rndm (b) + rndm (b) + rndm (b) + rndm (b);
731 686
732 /* Cursed items need to have higher negative values to equal out with 687 /* Cursed items need to have higher negative values to equal out with
733 * positive values for how protections work out. Put another 688 * positive values for how protections work out. Put another
734 * little random element in since that they don't always end up with 689 * little random element in since that they don't always end up with
735 * even values. 690 * even values.
736 */ 691 */
737 if (bonus < 0) 692 if (bonus < 0)
738 val = 2 * -val - RANDOM () % b; 693 val = 2 * -val - rndm (b);
739 if (val > 35) 694 if (val > 35)
740 val = 35; /* Upper limit */ 695 val = 35; /* Upper limit */
741 b = 0; 696 b = 0;
697
742 while (op->resist[resist_table[resist]] != 0 && b < 4) 698 while (op->resist[resist_table[resist]] != 0 && b < 4)
743 {
744 resist = RANDOM () % num_resist_table; 699 resist = rndm (num_resist_table);
745 } 700
746 if (b == 4) 701 if (b == 4)
747 return; /* Not able to find a free resistance */ 702 return; /* Not able to find a free resistance */
703
748 op->resist[resist_table[resist]] = val; 704 op->resist[resist_table[resist]] = val;
749 /* We should probably do something more clever here to adjust value 705 /* We should probably do something more clever here to adjust value
750 * based on how good a resistance we gave. 706 * based on how good a resistance we gave.
751 */ 707 */
752 break; 708 break;
780 case 22: 736 case 22:
781 op->stats.exp += bonus; /* Speed! */ 737 op->stats.exp += bonus; /* Speed! */
782 op->value = (op->value * 2) / 3; 738 op->value = (op->value * 2) / 3;
783 break; 739 break;
784 } 740 }
741
785 if (bonus > 0) 742 if (bonus > 0)
786 op->value *= 2 * bonus; 743 op->value *= 2 * bonus;
787 else 744 else
788 op->value = -(op->value * 2 * bonus) / 3; 745 op->value = -(op->value * 2 * bonus) / 3;
789} 746}
794 * higher is the chance of returning a low number. 751 * higher is the chance of returning a low number.
795 * It is only used in fix_generated_treasure() to set bonuses on 752 * It is only used in fix_generated_treasure() to set bonuses on
796 * rings and amulets. 753 * rings and amulets.
797 * Another scheme is used to calculate the magic of weapons and armours. 754 * Another scheme is used to calculate the magic of weapons and armours.
798 */ 755 */
799
800int 756int
801get_magic (int diff) 757get_magic (int diff)
802{ 758{
803 int i; 759 int i;
804 760
805 if (diff < 3) 761 if (diff < 3)
806 diff = 3; 762 diff = 3;
763
807 for (i = 0; i < 4; i++) 764 for (i = 0; i < 4; i++)
808 if (RANDOM () % diff) 765 if (rndm (diff))
809 return i; 766 return i;
767
810 return 4; 768 return 4;
811} 769}
812 770
813#define DICE2 (get_magic(2)==2?2:1) 771#define DICE2 (get_magic(2)==2?2:1)
814#define DICESPELL (RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3) 772#define DICESPELL (rndm (3) + rndm (3) + rndm (3) + rndm (3) + rndm (3))
815 773
816/* 774/*
817 * fix_generated_item(): This is called after an item is generated, in 775 * fix_generated_item(): This is called after an item is generated, in
818 * order to set it up right. This produced magical bonuses, puts spells 776 * order to set it up right. This produced magical bonuses, puts spells
819 * into scrolls/books/wands, makes it unidentified, hides the value, etc. 777 * into scrolls/books/wands, makes it unidentified, hides the value, etc.
833 * value. 791 * value.
834 * GT_MINIMAL: Does minimal processing on the object - just enough to make it 792 * GT_MINIMAL: Does minimal processing on the object - just enough to make it
835 * a working object - don't change magic, value, etc, but set it material 793 * a working object - don't change magic, value, etc, but set it material
836 * type as appropriate, for objects that need spell objects, set those, etc 794 * type as appropriate, for objects that need spell objects, set those, etc
837 */ 795 */
838
839void 796void
840fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags) 797fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags)
841{ 798{
842 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0; 799 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0;
843 800
848 save_item_power = op->item_power; 805 save_item_power = op->item_power;
849 op->item_power = 0; 806 op->item_power = 0;
850 807
851 if (op->randomitems && op->type != SPELL) 808 if (op->randomitems && op->type != SPELL)
852 { 809 {
853 create_treasure (op->randomitems, op, flags, difficulty, 0); 810 create_treasure (op->randomitems, op, flags & ~GT_ENVIRONMENT, difficulty, 0);
854 if (!op->inv)
855 LOG (llevDebug, "fix_generated_item: Unable to generate treasure for %s\n", &op->name);
856
857 /* So the treasure doesn't get created again */ 811 /* So the treasure doesn't get created again */
858 op->randomitems = NULL; 812 op->randomitems = 0;
859 } 813 }
860 814
861 if (difficulty < 1) 815 if (difficulty < 1)
862 difficulty = 1; 816 difficulty = 1;
817
818 if (INVOKE_OBJECT (ADD_BONUS, op,
819 ARG_OBJECT (creator != op ? creator : 0),
820 ARG_INT (difficulty), ARG_INT (max_magic),
821 ARG_INT (flags)))
822 return;
863 823
864 if (!(flags & GT_MINIMAL)) 824 if (!(flags & GT_MINIMAL))
865 { 825 {
866 if (op->arch == crown_arch) 826 if (op->arch == crown_arch)
867 { 827 {
874 if (!op->magic && max_magic) 834 if (!op->magic && max_magic)
875 set_magic (difficulty, op, max_magic, flags); 835 set_magic (difficulty, op, max_magic, flags);
876 836
877 num_enchantments = calc_item_power (op, 1); 837 num_enchantments = calc_item_power (op, 1);
878 838
879 if ((!was_magic && !(RANDOM () % CHANCE_FOR_ARTIFACT)) || op->type == HORN || difficulty >= settings.max_level) /* high difficulties always generate an artifact, 839 if ((!was_magic && !rndm (CHANCE_FOR_ARTIFACT))
840 || op->type == HORN
841 || difficulty >= settings.max_level) /* high difficulties always generate an artifact,
880 * used for shop_floors or treasures */ 842 * used for shop_floors or treasures */
881 generate_artifact (op, difficulty); 843 generate_artifact (op, difficulty);
882 } 844 }
883 845
884 /* Object was made an artifact. Calculate its item_power rating. 846 /* Object was made an artifact. Calculate its item_power rating.
942 case WEAPON: 904 case WEAPON:
943 case ARMOUR: 905 case ARMOUR:
944 case SHIELD: 906 case SHIELD:
945 case HELMET: 907 case HELMET:
946 case CLOAK: 908 case CLOAK:
947 if (QUERY_FLAG (op, FLAG_CURSED) && !(RANDOM () % 4)) 909 if (QUERY_FLAG (op, FLAG_CURSED) && !(rndm (4)))
948 set_ring_bonus (op, -DICE2); 910 set_ring_bonus (op, -DICE2);
949 break; 911 break;
950 912
951 case BRACERS: 913 case BRACERS:
952 if (!(RANDOM () % (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))) 914 if (!rndm (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))
953 { 915 {
954 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 916 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
955 if (!QUERY_FLAG (op, FLAG_CURSED)) 917 if (!QUERY_FLAG (op, FLAG_CURSED))
956 op->value *= 3; 918 op->value *= 3;
957 } 919 }
983 */ 945 */
984 if (op->inv && op->randomitems) 946 if (op->inv && op->randomitems)
985 { 947 {
986 /* value multiplier is same as for scrolls */ 948 /* value multiplier is same as for scrolls */
987 op->value = (op->value * op->inv->value); 949 op->value = (op->value * op->inv->value);
988 op->level = op->inv->level / 2 + RANDOM () % difficulty + RANDOM () % difficulty; 950 op->level = op->inv->level / 2 + rndm (difficulty) + rndm (difficulty);
989 } 951 }
990 else 952 else
991 { 953 {
992 op->name = "potion"; 954 op->name = "potion";
993 op->name_pl = "potions"; 955 op->name_pl = "potions";
994 } 956 }
995 957
996 if (!(flags & GT_ONLY_GOOD) && RANDOM () % 2) 958 if (!(flags & GT_ONLY_GOOD) && rndm (2))
997 SET_FLAG (op, FLAG_CURSED); 959 SET_FLAG (op, FLAG_CURSED);
998 break; 960 break;
999 } 961 }
1000 962
1001 case AMULET: 963 case AMULET:
1003 op->value *= 5; /* Since it's not just decoration */ 965 op->value *= 5; /* Since it's not just decoration */
1004 966
1005 case RING: 967 case RING:
1006 if (op->arch == NULL) 968 if (op->arch == NULL)
1007 { 969 {
1008 remove_ob (op); 970 op->destroy ();
1009 free_object (op);
1010 op = NULL; 971 op = 0;
1011 break; 972 break;
1012 } 973 }
1013 974
1014 if (op->arch != ring_arch && op->arch != amulet_arch) /* It's a special artifact! */ 975 if (op->arch != ring_arch && op->arch != amulet_arch) /* It's a special artifact! */
1015 break; 976 break;
1016 977
1017 if (!(flags & GT_ONLY_GOOD) && !(RANDOM () % 3)) 978 if (!(flags & GT_ONLY_GOOD) && !(rndm (3)))
1018 SET_FLAG (op, FLAG_CURSED); 979 SET_FLAG (op, FLAG_CURSED);
1019 980
1020 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 981 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
1021 982
1022 if (op->type != RING) /* Amulets have only one ability */ 983 if (op->type != RING) /* Amulets have only one ability */
1023 break; 984 break;
1024 985
1025 if (!(RANDOM () % 4)) 986 if (!(rndm (4)))
1026 { 987 {
1027 int d = (RANDOM () % 2 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 988 int d = (rndm (2) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1028 989
1029 if (d > 0) 990 if (d > 0)
1030 op->value *= 3; 991 op->value *= 3;
1031 992
1032 set_ring_bonus (op, d); 993 set_ring_bonus (op, d);
1033 994
1034 if (!(RANDOM () % 4)) 995 if (!(rndm (4)))
1035 { 996 {
1036 int d = (RANDOM () % 3 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 997 int d = (rndm (3) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1037 998
1038 if (d > 0) 999 if (d > 0)
1039 op->value *= 5; 1000 op->value *= 5;
1040 set_ring_bonus (op, d); 1001 set_ring_bonus (op, d);
1041 } 1002 }
1042 } 1003 }
1043 1004
1044 if (GET_ANIM_ID (op)) 1005 if (GET_ANIM_ID (op))
1045 SET_ANIMATION (op, RANDOM () % ((int) NUM_ANIMATIONS (op))); 1006 SET_ANIMATION (op, rndm (NUM_ANIMATIONS (op)));
1046 1007
1047 break; 1008 break;
1048 1009
1049 case BOOK: 1010 case BOOK:
1050 /* Is it an empty book?, if yes lets make a special· 1011 /* Is it an empty book?, if yes lets make a special·
1051 * msg for it, and tailor its properties based on the· 1012 * msg for it, and tailor its properties based on the·
1052 * creator and/or map level we found it on. 1013 * creator and/or map level we found it on.
1053 */ 1014 */
1054 if (!op->msg && RANDOM () % 10) 1015 if (!op->msg && rndm (10))
1055 { 1016 {
1056 /* set the book level properly */ 1017 /* set the book level properly */
1057 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE)) 1018 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE))
1058 { 1019 {
1059 if (op->map && op->map->difficulty) 1020 if (op->map && op->map->difficulty)
1060 op->level = RANDOM () % (op->map->difficulty) + RANDOM () % 10 + 1; 1021 op->level = rndm (op->map->difficulty) + rndm (10) + 1;
1061 else 1022 else
1062 op->level = RANDOM () % 20 + 1; 1023 op->level = rndm (20) + 1;
1063 } 1024 }
1064 else 1025 else
1065 op->level = RANDOM () % creator->level; 1026 op->level = rndm (creator->level);
1066 1027
1067 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1); 1028 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1);
1068 /* books w/ info are worth more! */ 1029 /* books w/ info are worth more! */
1069 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1)); 1030 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1));
1070 /* creator related stuff */ 1031 /* creator related stuff */
1169 */ 1130 */
1170 1131
1171/* 1132/*
1172 * Allocate and return the pointer to an empty artifactlist structure. 1133 * Allocate and return the pointer to an empty artifactlist structure.
1173 */ 1134 */
1174
1175static artifactlist * 1135static artifactlist *
1176get_empty_artifactlist (void) 1136get_empty_artifactlist (void)
1177{ 1137{
1178 artifactlist *tl = (artifactlist *) malloc (sizeof (artifactlist)); 1138 return salloc0 <artifactlist> ();
1179
1180 if (tl == NULL)
1181 fatal (OUT_OF_MEMORY);
1182 tl->next = NULL;
1183 tl->items = NULL;
1184 tl->total_chance = 0;
1185 return tl;
1186} 1139}
1187 1140
1188/* 1141/*
1189 * Allocate and return the pointer to an empty artifact structure. 1142 * Allocate and return the pointer to an empty artifact structure.
1190 */ 1143 */
1191
1192static artifact * 1144static artifact *
1193get_empty_artifact (void) 1145get_empty_artifact (void)
1194{ 1146{
1195 artifact *t = (artifact *) malloc (sizeof (artifact)); 1147 return salloc0 <artifact> ();
1196
1197 if (t == NULL)
1198 fatal (OUT_OF_MEMORY);
1199 t->item = NULL;
1200 t->next = NULL;
1201 t->chance = 0;
1202 t->difficulty = 0;
1203 t->allowed = NULL;
1204 return t;
1205} 1148}
1206 1149
1207/* 1150/*
1208 * Searches the artifact lists and returns one that has the same type 1151 * Searches the artifact lists and returns one that has the same type
1209 * of objects on it. 1152 * of objects on it.
1210 */ 1153 */
1211
1212artifactlist * 1154artifactlist *
1213find_artifactlist (int type) 1155find_artifactlist (int type)
1214{ 1156{
1215 artifactlist *al;
1216
1217 for (al = first_artifactlist; al != NULL; al = al->next) 1157 for (artifactlist *al = first_artifactlist; al; al = al->next)
1218 if (al->type == type) 1158 if (al->type == type)
1219 return al; 1159 return al;
1160
1220 return NULL; 1161 return 0;
1221} 1162}
1222 1163
1223/* 1164/*
1224 * For debugging purposes. Dumps all tables. 1165 * For debugging purposes. Dumps all tables.
1225 */ 1166 */
1226
1227void 1167void
1228dump_artifacts (void) 1168dump_artifacts (void)
1229{ 1169{
1230 artifactlist *al; 1170 artifactlist *al;
1231 artifact *art; 1171 artifact *art;
1238 for (art = al->items; art != NULL; art = art->next) 1178 for (art = al->items; art != NULL; art = art->next)
1239 { 1179 {
1240 fprintf (logfile, "Artifact %-30s Difficulty %3d Chance %5d\n", &art->item->name, art->difficulty, art->chance); 1180 fprintf (logfile, "Artifact %-30s Difficulty %3d Chance %5d\n", &art->item->name, art->difficulty, art->chance);
1241 if (art->allowed != NULL) 1181 if (art->allowed != NULL)
1242 { 1182 {
1243 fprintf (logfile, "\tAllowed combinations:"); 1183 fprintf (logfile, "\tallowed combinations:");
1244 for (next = art->allowed; next != NULL; next = next->next) 1184 for (next = art->allowed; next != NULL; next = next->next)
1245 fprintf (logfile, "%s,", &next->name); 1185 fprintf (logfile, "%s,", &next->name);
1246 fprintf (logfile, "\n"); 1186 fprintf (logfile, "\n");
1247 } 1187 }
1248 } 1188 }
1259 treasurelist *tl; 1199 treasurelist *tl;
1260 int i; 1200 int i;
1261 1201
1262 if (depth > 100) 1202 if (depth > 100)
1263 return; 1203 return;
1264 while (t != NULL) 1204
1205 while (t)
1265 { 1206 {
1266 if (t->name != NULL) 1207 if (t->name)
1267 { 1208 {
1268 for (i = 0; i < depth; i++) 1209 for (i = 0; i < depth; i++)
1269 fprintf (logfile, " "); 1210 fprintf (logfile, " ");
1211
1270 fprintf (logfile, "{ (list: %s)\n", &t->name); 1212 fprintf (logfile, "{ (list: %s)\n", &t->name);
1213
1271 tl = find_treasurelist (t->name); 1214 tl = treasurelist::find (t->name);
1215 if (tl)
1272 dump_monster_treasure_rec (name, tl->items, depth + 2); 1216 dump_monster_treasure_rec (name, tl->items, depth + 2);
1217
1273 for (i = 0; i < depth; i++) 1218 for (i = 0; i < depth; i++)
1274 fprintf (logfile, " "); 1219 fprintf (logfile, " ");
1220
1275 fprintf (logfile, "} (end of list: %s)\n", &t->name); 1221 fprintf (logfile, "} (end of list: %s)\n", &t->name);
1276 } 1222 }
1277 else 1223 else
1278 { 1224 {
1279 for (i = 0; i < depth; i++) 1225 for (i = 0; i < depth; i++)
1280 fprintf (logfile, " "); 1226 fprintf (logfile, " ");
1227
1281 if (t->item->clone.type == FLESH) 1228 if (t->item && t->item->type == FLESH)
1282 fprintf (logfile, "%s's %s\n", name, &t->item->clone.name); 1229 fprintf (logfile, "%s's %s\n", name, &t->item->object::name);
1283 else 1230 else
1284 fprintf (logfile, "%s\n", &t->item->clone.name); 1231 fprintf (logfile, "%s\n", &t->item->object::name);
1285 } 1232 }
1233
1286 if (t->next_yes != NULL) 1234 if (t->next_yes)
1287 { 1235 {
1288 for (i = 0; i < depth; i++) 1236 for (i = 0; i < depth; i++)
1289 fprintf (logfile, " "); 1237 fprintf (logfile, " ");
1238
1290 fprintf (logfile, " (if yes)\n"); 1239 fprintf (logfile, " (if yes)\n");
1291 dump_monster_treasure_rec (name, t->next_yes, depth + 1); 1240 dump_monster_treasure_rec (name, t->next_yes, depth + 1);
1292 } 1241 }
1242
1293 if (t->next_no != NULL) 1243 if (t->next_no)
1294 { 1244 {
1295 for (i = 0; i < depth; i++) 1245 for (i = 0; i < depth; i++)
1296 fprintf (logfile, " "); 1246 fprintf (logfile, " ");
1247
1297 fprintf (logfile, " (if no)\n"); 1248 fprintf (logfile, " (if no)\n");
1298 dump_monster_treasure_rec (name, t->next_no, depth + 1); 1249 dump_monster_treasure_rec (name, t->next_no, depth + 1);
1299 } 1250 }
1251
1300 t = t->next; 1252 t = t->next;
1301 } 1253 }
1302} 1254}
1303 1255
1304/* 1256/*
1305 * For debugging purposes. Dumps all treasures for a given monster. 1257 * For debugging purposes. Dumps all treasures for a given monster.
1306 * Created originally by Raphael Quinet for debugging the alchemy code. 1258 * Created originally by Raphael Quinet for debugging the alchemy code.
1307 */ 1259 */
1308
1309void 1260void
1310dump_monster_treasure (const char *name) 1261dump_monster_treasure (const char *name)
1311{ 1262{
1312 archetype *at; 1263 archetype *at;
1313 int found; 1264 int found;
1314 1265
1315 found = 0; 1266 found = 0;
1316 fprintf (logfile, "\n"); 1267 fprintf (logfile, "\n");
1317 for (at = first_archetype; at != NULL; at = at->next) 1268
1269 for_all_archetypes (at)
1318 if (!strcasecmp (at->clone.name, name) && at->clone.title == NULL) 1270 if (!strcasecmp (at->object::name, name) && at->title == NULL)
1319 { 1271 {
1320 fprintf (logfile, "treasures for %s (arch: %s)\n", &at->clone.name, &at->name); 1272 fprintf (logfile, "treasures for %s (arch: %s)\n", &at->object::name, &at->archname);
1321 if (at->clone.randomitems != NULL) 1273 if (at->randomitems != NULL)
1322 dump_monster_treasure_rec (at->clone.name, at->clone.randomitems->items, 1); 1274 dump_monster_treasure_rec (at->object::name, at->randomitems->items, 1);
1323 else 1275 else
1324 fprintf (logfile, "(nothing)\n"); 1276 fprintf (logfile, "(nothing)\n");
1277
1325 fprintf (logfile, "\n"); 1278 fprintf (logfile, "\n");
1326 found++; 1279 found++;
1327 } 1280 }
1281
1328 if (found == 0) 1282 if (found == 0)
1329 fprintf (logfile, "No objects have the name %s!\n\n", name); 1283 fprintf (logfile, "No objects have the name %s!\n\n", name);
1330} 1284}
1331 1285
1332/* 1286/*
1333 * Builds up the lists of artifacts from the file in the libdir. 1287 * Builds up the lists of artifacts from the file in the libdir.
1334 */ 1288 */
1335
1336void 1289void
1337init_artifacts (void) 1290init_artifacts (void)
1338{ 1291{
1339 static int has_been_inited = 0; 1292 static int has_been_inited = 0;
1340 char filename[MAX_BUF], buf[HUGE_BUF], *cp, *next; 1293 char filename[MAX_BUF];
1341 artifact *art = NULL; 1294 artifact *art = NULL;
1342 linked_char *tmp;
1343 int value;
1344 artifactlist *al; 1295 artifactlist *al;
1345 1296
1346 if (has_been_inited) 1297 if (has_been_inited)
1347 return; 1298 return;
1348 else 1299 else
1349 has_been_inited = 1; 1300 has_been_inited = 1;
1350 1301
1351 sprintf (filename, "%s/artifacts", settings.datadir); 1302 sprintf (filename, "%s/artifacts", settings.datadir);
1352 object_thawer thawer (filename); 1303 object_thawer f (filename);
1353 1304
1354 if (!thawer) 1305 if (!f)
1355 return; 1306 return;
1356 1307
1357 while (fgets (buf, HUGE_BUF, thawer) != NULL) 1308 f.next ();
1358 {
1359 if (*buf == '#')
1360 continue;
1361 if ((cp = strchr (buf, '\n')) != NULL)
1362 *cp = '\0';
1363 cp = buf;
1364 while (*cp == ' ') /* Skip blanks */
1365 cp++;
1366 if (*cp == '\0')
1367 continue;
1368 1309
1369 if (!strncmp (cp, "Allowed", 7)) 1310 for (;;)
1311 {
1312 switch (f.kw)
1370 { 1313 {
1314 case KW_allowed:
1371 if (art == NULL) 1315 if (!art)
1316 art = get_empty_artifact ();
1317
1372 { 1318 {
1373 art = get_empty_artifact (); 1319 if (!strcmp (f.get_str (), "all"))
1374 nrofartifacts++; 1320 break;
1321
1322 char *next, *cp = f.get_str ();
1323
1324 do
1325 {
1326 if ((next = strchr (cp, ',')))
1327 *next++ = '\0';
1328
1329 linked_char *tmp = new linked_char;
1330
1331 tmp->name = cp;
1332 tmp->next = art->allowed;
1333 art->allowed = tmp;
1334 }
1335 while ((cp = next));
1375 } 1336 }
1376 cp = strchr (cp, ' ') + 1; 1337 break;
1377 if (!strcmp (cp, "all")) 1338
1339 case KW_chance:
1340 f.get (art->chance);
1341 break;
1342
1343 case KW_difficulty:
1344 f.get (art->difficulty);
1345 break;
1346
1347 case KW_object:
1348 {
1349 art->item = object::create ();
1350 f.get (art->item->name);
1351 f.next ();
1352
1353 if (!art->item->parse_kv (f))
1354 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1355
1356 al = find_artifactlist (art->item->type);
1357
1358 if (!al)
1359 {
1360 al = get_empty_artifactlist ();
1361 al->type = art->item->type;
1362 al->next = first_artifactlist;
1363 first_artifactlist = al;
1364 }
1365
1366 art->next = al->items;
1367 al->items = art;
1368 art = 0;
1369 }
1378 continue; 1370 continue;
1379 1371
1380 do 1372 case KW_EOF:
1373 goto done;
1374
1375 default:
1376 if (!f.parse_error ("artifacts file"))
1377 cleanup ("artifacts file required");
1381 { 1378 break;
1382 nrofallowedstr++;
1383 if ((next = strchr (cp, ',')) != NULL)
1384 *(next++) = '\0';
1385 tmp = new linked_char;
1386
1387 tmp->name = cp;
1388 tmp->next = art->allowed;
1389 art->allowed = tmp;
1390 }
1391 while ((cp = next) != NULL);
1392 }
1393 else if (sscanf (cp, "chance %d", &value))
1394 art->chance = (uint16) value;
1395 else if (sscanf (cp, "difficulty %d", &value))
1396 art->difficulty = (uint8) value;
1397 else if (!strncmp (cp, "Object", 6))
1398 { 1379 }
1399 art->item = get_object ();
1400 1380
1401 if (!load_object (thawer, art->item, 0)) 1381 f.next ();
1402 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1403
1404 art->item->name = strchr (cp, ' ') + 1;
1405 al = find_artifactlist (art->item->type);
1406 if (al == NULL)
1407 {
1408 al = get_empty_artifactlist ();
1409 al->type = art->item->type;
1410 al->next = first_artifactlist;
1411 first_artifactlist = al;
1412 }
1413 art->next = al->items;
1414 al->items = art;
1415 art = NULL;
1416 }
1417 else
1418 LOG (llevError, "Unknown input in artifact file: %s\n", buf);
1419 } 1382 }
1420 1383
1384done:
1421 for (al = first_artifactlist; al != NULL; al = al->next) 1385 for (al = first_artifactlist; al; al = al->next)
1422 { 1386 {
1387 al->total_chance = 0;
1388
1423 for (art = al->items; art != NULL; art = art->next) 1389 for (art = al->items; art; art = art->next)
1424 { 1390 {
1425 if (!art->chance) 1391 if (!art->chance)
1426 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name); 1392 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name);
1427 else 1393 else
1428 al->total_chance += art->chance; 1394 al->total_chance += art->chance;
1433 } 1399 }
1434 1400
1435 LOG (llevDebug, "done.\n"); 1401 LOG (llevDebug, "done.\n");
1436} 1402}
1437 1403
1438
1439/* 1404/*
1440 * Used in artifact generation. The bonuses of the first object 1405 * Used in artifact generation. The bonuses of the first object
1441 * is modified by the bonuses of the second object. 1406 * is modified by the bonuses of the second object.
1442 */ 1407 */
1443
1444void 1408void
1445add_abilities (object *op, object *change) 1409add_abilities (object *op, object *change)
1446{ 1410{
1447 int i, tmp; 1411 int i, tmp;
1448 1412
1449 if (change->face != blank_face) 1413 if (change->face != blank_face)
1450 { 1414 {
1451#ifdef TREASURE_VERBOSE 1415#ifdef TREASURE_VERBOSE
1452 LOG (llevDebug, "FACE: %d\n", change->face->number); 1416 LOG (llevDebug, "add_abilities change face: %d\n", change->face);
1453#endif 1417#endif
1454 op->face = change->face; 1418 op->face = change->face;
1455 } 1419 }
1456 1420
1457 for (i = 0; i < NUM_STATS; i++) 1421 for (i = 0; i < NUM_STATS; i++)
1458 change_attr_value (&(op->stats), i, get_attr_value (&(change->stats), i)); 1422 change_attr_value (&(op->stats), i, change->stats.stat (i));
1459 1423
1460 op->attacktype |= change->attacktype; 1424 op->attacktype |= change->attacktype;
1461 op->path_attuned |= change->path_attuned; 1425 op->path_attuned |= change->path_attuned;
1462 op->path_repelled |= change->path_repelled; 1426 op->path_repelled |= change->path_repelled;
1463 op->path_denied |= change->path_denied; 1427 op->path_denied |= change->path_denied;
1493 CLEAR_FLAG (op, FLAG_ANIMATE); 1457 CLEAR_FLAG (op, FLAG_ANIMATE);
1494 /* so artifacts will join */ 1458 /* so artifacts will join */
1495 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1459 if (!QUERY_FLAG (op, FLAG_ALIVE))
1496 op->speed = 0.0; 1460 op->speed = 0.0;
1497 1461
1498 update_ob_speed (op); 1462 op->set_speed (op->speed);
1499 } 1463 }
1500 1464
1501 if (change->nrof) 1465 if (change->nrof)
1502 op->nrof = RANDOM () % ((int) change->nrof) + 1; 1466 op->nrof = rndm (change->nrof) + 1;
1503 1467
1504 op->stats.exp += change->stats.exp; /* Speed modifier */ 1468 op->stats.exp += change->stats.exp; /* Speed modifier */
1505 op->stats.wc += change->stats.wc; 1469 op->stats.wc += change->stats.wc;
1506 op->stats.ac += change->stats.ac; 1470 op->stats.ac += change->stats.ac;
1507 1471
1515 { 1479 {
1516 object *tmp_obj; 1480 object *tmp_obj;
1517 1481
1518 /* Remove any spells this object currently has in it */ 1482 /* Remove any spells this object currently has in it */
1519 while (op->inv) 1483 while (op->inv)
1520 { 1484 op->inv->destroy ();
1521 tmp_obj = op->inv;
1522 remove_ob (tmp_obj);
1523 free_object (tmp_obj);
1524 }
1525 1485
1526 tmp_obj = arch_to_object (change->other_arch); 1486 tmp_obj = arch_to_object (change->other_arch);
1527 insert_ob_in_ob (tmp_obj, op); 1487 insert_ob_in_ob (tmp_obj, op);
1528 } 1488 }
1529 /* No harm setting this for potions/horns */ 1489 /* No harm setting this for potions/horns */
1566 op->gen_sp_armour = (op->gen_sp_armour * (change->gen_sp_armour)) / 100; 1526 op->gen_sp_armour = (op->gen_sp_armour * (change->gen_sp_armour)) / 100;
1567 1527
1568 op->item_power = change->item_power; 1528 op->item_power = change->item_power;
1569 1529
1570 for (i = 0; i < NROFATTACKS; i++) 1530 for (i = 0; i < NROFATTACKS; i++)
1571 {
1572 if (change->resist[i]) 1531 if (change->resist[i])
1573 {
1574 op->resist[i] += change->resist[i]; 1532 op->resist[i] += change->resist[i];
1575 }
1576 }
1577 1533
1578 if (change->stats.dam) 1534 if (change->stats.dam)
1579 { 1535 {
1580 if (change->stats.dam < 0) 1536 if (change->stats.dam < 0)
1581 op->stats.dam = (-change->stats.dam); 1537 op->stats.dam = (-change->stats.dam);
1618 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100); 1574 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100);
1619 } 1575 }
1620 1576
1621 op->value *= change->value; 1577 op->value *= change->value;
1622 1578
1623 if (change->material) 1579 if (change->materials)
1624 op->material = change->material; 1580 op->materials = change->materials;
1625 1581
1626 if (change->materialname) 1582 if (change->materialname)
1627 op->materialname = change->materialname; 1583 op->materialname = change->materialname;
1628 1584
1629 if (change->slaying) 1585 if (change->slaying)
1635 if (change->msg) 1591 if (change->msg)
1636 op->msg = change->msg; 1592 op->msg = change->msg;
1637} 1593}
1638 1594
1639static int 1595static int
1640legal_artifact_combination (object *op, artifact * art) 1596legal_artifact_combination (object *op, artifact *art)
1641{ 1597{
1642 int neg, success = 0; 1598 int neg, success = 0;
1643 linked_char *tmp; 1599 linked_char *tmp;
1644 const char *name; 1600 const char *name;
1645 1601
1646 if (art->allowed == (linked_char *) NULL) 1602 if (!art->allowed)
1647 return 1; /* Ie, "all" */ 1603 return 1; /* Ie, "all" */
1604
1648 for (tmp = art->allowed; tmp; tmp = tmp->next) 1605 for (tmp = art->allowed; tmp; tmp = tmp->next)
1649 { 1606 {
1650#ifdef TREASURE_VERBOSE 1607#ifdef TREASURE_VERBOSE
1651 LOG (llevDebug, "legal_art: %s\n", tmp->name); 1608 LOG (llevDebug, "legal_art: %s\n", &tmp->name);
1652#endif 1609#endif
1653 if (*tmp->name == '!') 1610 if (*tmp->name == '!')
1654 name = tmp->name + 1, neg = 1; 1611 name = tmp->name + 1, neg = 1;
1655 else 1612 else
1656 name = tmp->name, neg = 0; 1613 name = tmp->name, neg = 0;
1657 1614
1658 /* If we match name, then return the opposite of 'neg' */ 1615 /* If we match name, then return the opposite of 'neg' */
1659 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->name))) 1616 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->archname)))
1660 return !neg; 1617 return !neg;
1661 1618
1662 /* Set success as true, since if the match was an inverse, it means 1619 /* Set success as true, since if the match was an inverse, it means
1663 * everything is allowed except what we match 1620 * everything is allowed except what we match
1664 */ 1621 */
1665 else if (neg) 1622 else if (neg)
1666 success = 1; 1623 success = 1;
1667 } 1624 }
1625
1668 return success; 1626 return success;
1669} 1627}
1670 1628
1671/* 1629/*
1672 * Fixes the given object, giving it the abilities and titles 1630 * Fixes the given object, giving it the abilities and titles
1723 return; 1681 return;
1724 } 1682 }
1725 1683
1726 for (i = 0; i < ARTIFACT_TRIES; i++) 1684 for (i = 0; i < ARTIFACT_TRIES; i++)
1727 { 1685 {
1728 int roll = RANDOM () % al->total_chance; 1686 int roll = rndm (al->total_chance);
1729 1687
1730 for (art = al->items; art != NULL; art = art->next) 1688 for (art = al->items; art; art = art->next)
1731 { 1689 {
1732 roll -= art->chance; 1690 roll -= art->chance;
1733 if (roll < 0) 1691 if (roll < 0)
1734 break; 1692 break;
1735 } 1693 }
1751 continue; 1709 continue;
1752 1710
1753 if (!legal_artifact_combination (op, art)) 1711 if (!legal_artifact_combination (op, art))
1754 { 1712 {
1755#ifdef TREASURE_VERBOSE 1713#ifdef TREASURE_VERBOSE
1756 LOG (llevDebug, "%s of %s was not a legal combination.\n", op->name, art->item->name); 1714 LOG (llevDebug, "%s of %s was not a legal combination.\n", &op->name, &art->item->name);
1757#endif 1715#endif
1758 continue; 1716 continue;
1759 } 1717 }
1718
1760 give_artifact_abilities (op, art->item); 1719 give_artifact_abilities (op, art->item);
1761 return; 1720 return;
1762 } 1721 }
1763} 1722}
1764 1723
1808 SET_FLAG (item, FLAG_NO_STEAL); 1767 SET_FLAG (item, FLAG_NO_STEAL);
1809 } 1768 }
1810} 1769}
1811 1770
1812/* special_potion() - so that old potion code is still done right. */ 1771/* special_potion() - so that old potion code is still done right. */
1813
1814int 1772int
1815special_potion (object *op) 1773special_potion (object *op)
1816{ 1774{
1817
1818 int i;
1819
1820 if (op->attacktype) 1775 if (op->attacktype)
1821 return 1; 1776 return 1;
1822 1777
1823 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha) 1778 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha)
1824 return 1; 1779 return 1;
1825 1780
1826 for (i = 0; i < NROFATTACKS; i++) 1781 for (int i = 0; i < NROFATTACKS; i++)
1827 if (op->resist[i]) 1782 if (op->resist[i])
1828 return 1; 1783 return 1;
1829 1784
1830 return 0; 1785 return 0;
1831} 1786}
1832 1787
1833void 1788void
1834free_treasurestruct (treasure *t) 1789free_treasurestruct (treasure *t)
1835{ 1790{
1836 if (t->next)
1837 free_treasurestruct (t->next); 1791 if (t->next) free_treasurestruct (t->next);
1838 if (t->next_yes)
1839 free_treasurestruct (t->next_yes); 1792 if (t->next_yes) free_treasurestruct (t->next_yes);
1840 if (t->next_no)
1841 free_treasurestruct (t->next_no); 1793 if (t->next_no) free_treasurestruct (t->next_no);
1842 1794
1843 delete t; 1795 delete t;
1844} 1796}
1845 1797
1846void 1798void
1851 1803
1852 delete lc; 1804 delete lc;
1853} 1805}
1854 1806
1855void 1807void
1856free_artifact (artifact * at) 1808free_artifact (artifact *at)
1857{ 1809{
1858 if (at->next)
1859 free_artifact (at->next); 1810 if (at->next) free_artifact (at->next);
1860
1861 if (at->allowed)
1862 free_charlinks (at->allowed); 1811 if (at->allowed) free_charlinks (at->allowed);
1863 1812
1864 at->item->free (1); 1813 at->item->destroy (1);
1865 1814
1866 delete at; 1815 sfree (at);
1867} 1816}
1868 1817
1869void 1818void
1870free_artifactlist (artifactlist * al) 1819free_artifactlist (artifactlist *al)
1871{ 1820{
1872 artifactlist *nextal; 1821 artifactlist *nextal;
1873 1822
1874 for (al = first_artifactlist; al != NULL; al = nextal) 1823 for (al = first_artifactlist; al; al = nextal)
1875 { 1824 {
1876 nextal = al->next; 1825 nextal = al->next;
1877 1826
1878 if (al->items) 1827 if (al->items)
1879 free_artifact (al->items); 1828 free_artifact (al->items);
1880 1829
1881 free (al); 1830 sfree (al);
1882 } 1831 }
1883} 1832}
1884 1833
1885void 1834void
1886free_all_treasures (void) 1835free_all_treasures (void)
1887{ 1836{
1888 treasurelist *tl, *next; 1837 treasurelist *tl, *next;
1889 1838
1890
1891 for (tl = first_treasurelist; tl != NULL; tl = next) 1839 for (tl = first_treasurelist; tl; tl = next)
1892 { 1840 {
1841 clear (tl);
1842
1893 next = tl->next; 1843 next = tl->next;
1894 if (tl->items)
1895 free_treasurestruct (tl->items);
1896 delete tl; 1844 delete tl;
1897 } 1845 }
1846
1898 free_artifactlist (first_artifactlist); 1847 free_artifactlist (first_artifactlist);
1899} 1848}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines