ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/treasure.C
(Generate patch)

Comparing deliantra/server/common/treasure.C (file contents):
Revision 1.27 by root, Wed Dec 20 09:14:21 2006 UTC vs.
Revision 1.102 by root, Wed Apr 7 19:54:45 2010 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
8 it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
9 the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
10 (at your option) any later version. 11 * option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
18 along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22*/ 23 */
23
24#define ALLOWED_COMBINATION
25 24
26/* TREASURE_DEBUG does some checking on the treasurelists after loading. 25/* TREASURE_DEBUG does some checking on the treasurelists after loading.
27 * It is useful for finding bugs in the treasures file. Since it only 26 * It is useful for finding bugs in the treasures file. Since it only
28 * slows the startup some (and not actual game play), it is by default 27 * slows the startup some (and not actual game play), it is by default
29 * left on 28 * left on
30 */ 29 */
31#define TREASURE_DEBUG 30#define TREASURE_DEBUG
32 31
33/* TREASURE_VERBOSE enables copious output concerning artifact generation */ 32/* TREASURE_VERBOSE enables copious output concerning artifact generation */
34 33
35/* #define TREASURE_VERBOSE */ 34//#define TREASURE_VERBOSE
36 35
37#include <global.h> 36#include <global.h>
38#include <treasure.h> 37#include <treasure.h>
39#include <funcpoint.h>
40#include <loader.h>
41 38
39extern char *spell_mapping[];
40
41static treasurelist *first_treasurelist;
42 42
43static void change_treasure (treasure *t, object *op); /* overrule default values */ 43static void change_treasure (treasure *t, object *op); /* overrule default values */
44extern char *spell_mapping[];
45 44
46/* 45typedef std::tr1::unordered_map<
47 * Initialize global archtype pointers: 46 const char *,
48 */ 47 treasurelist *,
48 str_hash,
49 str_equal,
50 slice_allocator< std::pair<const char *const, treasurelist *> >
51> tl_map_t;
49 52
50void 53static tl_map_t tl_map;
51init_archetype_pointers ()
52{
53 int prev_warn = warn_archetypes;
54 54
55 warn_archetypes = 1; 55//TODO: class method
56 if (ring_arch == NULL) 56static void free_treasurestruct (treasure *t); // bleh desu
57 ring_arch = archetype::find ("ring"); 57static void
58 if (amulet_arch == NULL) 58clear (treasurelist *tl)
59 amulet_arch = archetype::find ("amulet"); 59{
60 if (staff_arch == NULL) 60 if (tl->items)
61 staff_arch = archetype::find ("staff"); 61 {
62 if (crown_arch == NULL) 62 free_treasurestruct (tl->items);
63 crown_arch = archetype::find ("crown"); 63 tl->items = 0;
64 warn_archetypes = prev_warn; 64 }
65}
66 65
67/* 66 tl->total_chance = 0;
68 * Allocate and return the pointer to an empty treasurelist structure. 67}
69 */
70 68
69/*
70 * Searches for the given treasurelist
71 */
71static treasurelist * 72treasurelist *
72get_empty_treasurelist (void) 73treasurelist::find (const char *name)
73{ 74{
75 if (!name)
76 return 0;
77
78 auto (i, tl_map.find (name));
79
80 if (i == tl_map.end ())
81 return 0;
82
83 return i->second;
84}
85
86/*
87 * Searches for the given treasurelist in the globally linked list
88 * of treasurelists which has been built by load_treasures().
89 */
90treasurelist *
91treasurelist::get (const char *name)
92{
93 treasurelist *tl = find (name);
94
95 if (!tl)
96 {
74 return new treasurelist; 97 tl = new treasurelist;
75}
76 98
77/* 99 tl->name = name;
78 * Allocate and return the pointer to an empty treasure structure. 100 tl->next = first_treasurelist;
79 */ 101 first_treasurelist = tl;
80//TODO: make this a constructor
81static treasure *
82get_empty_treasure (void)
83{
84 treasure *t = new treasure;
85 102
86 t->chance = 100; 103 tl_map.insert (std::make_pair (tl->name, tl));
104 }
87 105
88 return t; 106 return tl;
89} 107}
108
109#ifdef TREASURE_DEBUG
110/* recursived checks the linked list. Treasurelist is passed only
111 * so that the treasure name can be printed out
112 */
113static void
114check_treasurelist (const treasure *t, const treasurelist * tl)
115{
116 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
117 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
118
119 if (t->next)
120 check_treasurelist (t->next, tl);
121
122 if (t->next_yes)
123 check_treasurelist (t->next_yes, tl);
124
125 if (t->next_no)
126 check_treasurelist (t->next_no, tl);
127}
128#endif
90 129
91/* 130/*
92 * Reads the lib/treasure file from disk, and parses the contents 131 * Reads the lib/treasure file from disk, and parses the contents
93 * into an internal treasure structure (very linked lists) 132 * into an internal treasure structure (very linked lists)
94 */ 133 */
95
96static treasure * 134static treasure *
97load_treasure (FILE * fp, int *line) 135read_treasure (object_thawer &f)
98{ 136{
99 char buf[MAX_BUF], *cp, variable[MAX_BUF];
100 treasure *t = get_empty_treasure (); 137 treasure *t = new treasure;
101 int value;
102 138
103 nroftreasures++; 139 f.next ();
104 while (fgets (buf, MAX_BUF, fp) != NULL)
105 {
106 (*line)++;
107 140
108 if (*buf == '#') 141 for (;;)
109 continue; 142 {
110 if ((cp = strchr (buf, '\n')) != NULL) 143 coroapi::cede_to_tick ();
111 *cp = '\0';
112 cp = buf;
113 while (isspace (*cp)) /* Skip blanks */
114 cp++;
115 144
116 if (sscanf (cp, "arch %s", variable)) 145 switch (f.kw)
117 {
118 if ((t->item = archetype::find (variable)) == NULL)
119 LOG (llevError, "Treasure lacks archetype: %s\n", variable);
120 } 146 {
121 else if (sscanf (cp, "list %s", variable)) 147 case KW_arch:
122 t->name = variable; 148 t->item = archetype::find (f.get_str ());
123 else if (sscanf (cp, "change_name %s", variable)) 149
124 t->change_arch.name = variable; 150 if (!t->item)
125 else if (sscanf (cp, "change_title %s", variable))
126 t->change_arch.title = variable;
127 else if (sscanf (cp, "change_slaying %s", variable))
128 t->change_arch.slaying = variable;
129 else if (sscanf (cp, "chance %d", &value))
130 t->chance = (uint8) value;
131 else if (sscanf (cp, "nrof %d", &value))
132 t->nrof = (uint16) value;
133 else if (sscanf (cp, "magic %d", &value))
134 t->magic = (uint8) value;
135 else if (!strcmp (cp, "yes"))
136 t->next_yes = load_treasure (fp, line);
137 else if (!strcmp (cp, "no"))
138 t->next_no = load_treasure (fp, line);
139 else if (!strcmp (cp, "end"))
140 return t;
141 else if (!strcmp (cp, "more"))
142 { 151 {
143 t->next = load_treasure (fp, line); 152 f.parse_warn ("treasure references unknown archetype");
153 t->item = archetype::empty;
154 }
155
156 break;
157
158 case KW_list: f.get (t->name); break;
159 case KW_change_name: f.get (t->change_arch.name); break;
160 case KW_change_title: f.get (t->change_arch.title); break;
161 case KW_change_slaying: f.get (t->change_arch.slaying); break;
162 case KW_chance: f.get (t->chance); break;
163 case KW_nrof: f.get (t->nrof); break;
164 case KW_magic: f.get (t->magic); break;
165
166 case KW_yes: t->next_yes = read_treasure (f); continue;
167 case KW_no: t->next_no = read_treasure (f); continue;
168
169 case KW_end:
170 f.next ();
144 return t; 171 return t;
172
173 case KW_more:
174 t->next = read_treasure (f);
175 return t;
176
177 default:
178 if (!f.parse_error ("treasurelist", t->name))
179 goto error;
180
181 return t;
145 } 182 }
146 else 183
147 LOG (llevError, "Unknown treasure-command: '%s', last entry %s, line %d\n", cp, &t->name, *line); 184 f.next ();
148 } 185 }
149 LOG (llevError, "treasure lacks 'end'.\n"); 186
187 // not reached
188
189error:
190 delete t;
150 return t; 191 return 0;
151} 192}
152 193
153#ifdef TREASURE_DEBUG
154
155/* recursived checks the linked list. Treasurelist is passed only
156 * so that the treasure name can be printed out
157 */
158static void
159check_treasurelist (const treasure *t, const treasurelist * tl)
160{
161 if (t->item == NULL && t->name == NULL)
162 LOG (llevError, "Treasurelist %s has element with no name or archetype\n", &tl->name);
163 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
164 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
165 /* find_treasurelist will print out its own error message */
166 if (t->name && *t->name)
167 (void) find_treasurelist (t->name);
168 if (t->next)
169 check_treasurelist (t->next, tl);
170 if (t->next_yes)
171 check_treasurelist (t->next_yes, tl);
172 if (t->next_no)
173 check_treasurelist (t->next_no, tl);
174}
175#endif
176
177/* 194/*
178 * Opens LIBDIR/treasure and reads all treasure-declarations from it.
179 * Each treasure is parsed with the help of load_treasure(). 195 * Each treasure is parsed with the help of load_treasure().
180 */ 196 */
181 197treasurelist *
182void 198treasurelist::read (object_thawer &f)
183load_treasures (void)
184{ 199{
185 FILE *fp; 200 assert (f.kw == KW_treasure || f.kw == KW_treasureone);
186 char filename[MAX_BUF], buf[MAX_BUF], name[MAX_BUF];
187 treasurelist *previous = NULL;
188 treasure *t;
189 int comp, line = 0;
190 201
191 sprintf (filename, "%s/%s", settings.datadir, settings.treasures); 202 bool one = f.kw == KW_treasureone;
192 if ((fp = open_and_uncompress (filename, 0, &comp)) == NULL) 203 treasurelist *tl = treasurelist::get (f.get_str ());
193 { 204 clear (tl);
194 LOG (llevError, "Can't open treasure file.\n"); 205 tl->items = read_treasure (f);
206 if (!tl->items)
195 return; 207 return 0;
196 }
197 while (fgets (buf, MAX_BUF, fp) != NULL)
198 {
199 line++;
200 if (*buf == '#')
201 continue;
202 208
203 if (sscanf (buf, "treasureone %s\n", name) || sscanf (buf, "treasure %s\n", name))
204 {
205 treasurelist *tl = get_empty_treasurelist ();
206
207 tl->name = name;
208 if (previous == NULL)
209 first_treasurelist = tl;
210 else
211 previous->next = tl;
212 previous = tl;
213 tl->items = load_treasure (fp, &line);
214
215 /* This is a one of the many items on the list should be generated. 209 /* This is a one of the many items on the list should be generated.
216 * Add up the chance total, and check to make sure the yes & no 210 * Add up the chance total, and check to make sure the yes & no
217 * fields of the treasures are not being used. 211 * fields of the treasures are not being used.
218 */ 212 */
219 if (!strncmp (buf, "treasureone", 11)) 213 if (one)
214 {
215 for (treasure *t = tl->items; t; t = t->next)
216 {
217 if (t->next_yes || t->next_no)
220 { 218 {
221 for (t = tl->items; t != NULL; t = t->next)
222 {
223#ifdef TREASURE_DEBUG
224 if (t->next_yes || t->next_no)
225 {
226 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->name : &t->name); 219 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->archname : &t->name);
227 LOG (llevError, " the next_yes or next_no field is set\n"); 220 LOG (llevError, " the next_yes or next_no field is set\n");
228 }
229#endif
230 tl->total_chance += t->chance;
231 }
232 } 221 }
233 }
234 else
235 LOG (llevError, "Treasure-list %s didn't understand: %s, line %d\n", filename, buf, line);
236 }
237 close_and_delete (fp, comp);
238 222
239#ifdef TREASURE_DEBUG 223 tl->total_chance += t->chance;
240 /* Perform some checks on how valid the treasure data actually is. 224 }
241 * verify that list transitions work (ie, the list that it is supposed 225 }
242 * to transition to exists). Also, verify that at least the name
243 * or archetype is set for each treasure element.
244 */
245 for (previous = first_treasurelist; previous != NULL; previous = previous->next)
246 check_treasurelist (previous->items, previous);
247#endif
248}
249 226
250/*
251 * Searches for the given treasurelist in the globally linked list
252 * of treasurelists which has been built by load_treasures().
253 */
254
255treasurelist *
256find_treasurelist (const char *name)
257{
258 shstr_cmp name_ (name);
259
260 if (!name_)
261 return 0;
262
263 for (treasurelist *tl = first_treasurelist; tl != 0; tl = tl->next)
264 if (name_ == tl->name)
265 return tl;
266
267 if (first_treasurelist)
268 LOG (llevError, "Couldn't find treasurelist %s\n", name);
269
270 return 0; 227 return tl;
271} 228}
272
273 229
274/* 230/*
275 * Generates the objects specified by the given treasure. 231 * Generates the objects specified by the given treasure.
276 * It goes recursively through the rest of the linked list. 232 * It goes recursively through the rest of the linked list.
277 * If there is a certain percental chance for a treasure to be generated, 233 * If there is a certain percental chance for a treasure to be generated,
283 * start with equipment, but only their abilities). 239 * start with equipment, but only their abilities).
284 */ 240 */
285static void 241static void
286put_treasure (object *op, object *creator, int flags) 242put_treasure (object *op, object *creator, int flags)
287{ 243{
288 object *tmp; 244 if (flags & GT_ENVIRONMENT)
289 245 {
290 /* Bit of a hack - spells should never be put onto the map. The entire 246 /* Bit of a hack - spells should never be put onto the map. The entire
291 * treasure stuff is a problem - there is no clear idea of knowing 247 * treasure stuff is a problem - there is no clear idea of knowing
292 * this is the original object, or if this is an object that should be created 248 * this is the original object, or if this is an object that should be created
293 * by another object. 249 * by another object.
294 */ 250 */
295 if (flags & GT_ENVIRONMENT && op->type != SPELL) 251 //TODO: flag such as objects... as such (no drop, anybody?)
296 { 252 if (op->type == SPELL)
297 op->x = creator->x; 253 {
298 op->y = creator->y; 254 op->destroy ();
255 return;
256 }
257
258 op->expand_tail ();
259
260 if (!creator->is_on_map () || op->blocked (creator->map, creator->x, creator->y))
261 op->destroy ();
262 else
263 {
299 SET_FLAG (op, FLAG_OBJ_ORIGINAL); 264 SET_FLAG (op, FLAG_OBJ_ORIGINAL);
300 insert_ob_in_map (op, creator->map, op, INS_NO_MERGE | INS_NO_WALK_ON); 265 op->insert_at (creator, creator, INS_NO_MERGE | INS_NO_WALK_ON);
266 }
301 } 267 }
302 else 268 else
303 { 269 {
304 op = insert_ob_in_ob (op, creator); 270 op = creator->insert (op);
305 271
306 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER)) 272 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER))
307 monster_check_apply (creator, op); 273 monster_check_apply (creator, op);
308
309 if ((flags & GT_UPDATE_INV) && (tmp = creator->in_player ()))
310 esrv_send_item (tmp, op);
311 } 274 }
312} 275}
313 276
314/* if there are change_xxx commands in the treasure, we include the changes 277/* if there are change_xxx commands in the treasure, we include the changes
315 * in the generated object 278 * in the generated object
329 292
330 if (t->change_arch.slaying) 293 if (t->change_arch.slaying)
331 op->slaying = t->change_arch.slaying; 294 op->slaying = t->change_arch.slaying;
332} 295}
333 296
334void 297static void
335create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries) 298create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries)
336{ 299{
337 object *tmp;
338
339 if ((int) t->chance >= 100 || (RANDOM () % 100 + 1) < (int) t->chance) 300 if ((int) t->chance >= 100 || (rndm (100) + 1) < (int) t->chance)
340 { 301 {
341 if (t->name) 302 if (t->name)
342 { 303 {
343 if (strcmp (t->name, "NONE") && difficulty >= t->magic) 304 if (difficulty >= t->magic)
305 if (treasurelist *tl = treasurelist::find (t->name))
306 create_treasure (tl, op, flag, difficulty, tries);
307 else
308 LOG (llevError, "create_all_treasures: undefined reference to treasurelist '%s'.\n", &t->name);
309 }
310 else
311 {
312 if (t->item && (t->item->invisible != 0 || !(flag & GT_INVISIBLE)))
344 { 313 {
345 treasurelist *tl = find_treasurelist (t->name); 314 object *tmp = t->item->instance ();
346 if (tl) 315
347 create_treasure (tl, op, flag, difficulty, tries);
348 }
349 }
350 else
351 {
352 if (t->item->clone.invisible != 0 || !(flag & GT_INVISIBLE))
353 {
354 tmp = arch_to_object (t->item);
355 if (t->nrof && tmp->nrof <= 1) 316 if (t->nrof && tmp->nrof <= 1)
356 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 317 tmp->nrof = rndm (t->nrof) + 1;
318
357 fix_generated_item (tmp, op, difficulty, t->magic, flag); 319 fix_generated_item (tmp, op, difficulty, t->magic, flag);
358 change_treasure (t, tmp); 320 change_treasure (t, tmp);
359 put_treasure (tmp, op, flag); 321 put_treasure (tmp, op, flag);
360 } 322 }
361 } 323 }
362 324
363 if (t->next_yes != NULL) 325 if (t->next_yes)
364 create_all_treasures (t->next_yes, op, flag, difficulty, tries); 326 create_all_treasures (t->next_yes, op, flag, difficulty, tries);
365 } 327 }
366 else if (t->next_no != NULL) 328 else if (t->next_no)
367 create_all_treasures (t->next_no, op, flag, difficulty, tries); 329 create_all_treasures (t->next_no, op, flag, difficulty, tries);
368 330
369 if (t->next != NULL) 331 if (t->next)
370 create_all_treasures (t->next, op, flag, difficulty, tries); 332 create_all_treasures (t->next, op, flag, difficulty, tries);
371} 333}
372 334
373void 335static void
374create_one_treasure (treasurelist * tl, object *op, int flag, int difficulty, int tries) 336create_one_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
375{ 337{
376 int value = RANDOM () % tl->total_chance; 338 int value = rndm (tl->total_chance);
377 treasure *t; 339 treasure *t;
378 340
379 if (tries++ > 100) 341 if (tries++ > 100)
380 { 342 {
381 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n"); 343 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n");
382 return; 344 return;
383 } 345 }
384 346
385 for (t = tl->items; t != NULL; t = t->next) 347 for (t = tl->items; t; t = t->next)
386 { 348 {
387 value -= t->chance; 349 value -= t->chance;
388 350
389 if (value < 0) 351 if (value < 0)
390 break; 352 break;
391 } 353 }
392 354
393 if (!t || value >= 0) 355 if (!t || value >= 0)
394 {
395 LOG (llevError, "create_one_treasure: got null object or not able to find treasure\n"); 356 cleanup ("create_one_treasure: got null object or not able to find treasure\n", 1);
396 abort ();
397 return;
398 }
399 357
400 if (t->name) 358 if (t->name)
401 { 359 {
402 if (!strcmp (t->name, "NONE"))
403 return;
404
405 if (difficulty >= t->magic) 360 if (difficulty >= t->magic)
406 { 361 {
407 treasurelist *tl = find_treasurelist (t->name); 362 treasurelist *tl = treasurelist::find (t->name);
408 if (tl) 363 if (tl)
409 create_treasure (tl, op, flag, difficulty, tries); 364 create_treasure (tl, op, flag, difficulty, tries);
410 } 365 }
411 else if (t->nrof) 366 else if (t->nrof)
412 create_one_treasure (tl, op, flag, difficulty, tries); 367 create_one_treasure (tl, op, flag, difficulty, tries);
413
414 return;
415 } 368 }
416
417 if ((t->item && t->item->clone.invisible != 0) || flag != GT_INVISIBLE) 369 else if (t->item && (t->item->invisible != 0 || flag != GT_INVISIBLE))
418 { 370 {
419 object *tmp = arch_to_object (t->item); 371 if (object *tmp = t->item->instance ())
420 372 {
421 if (!tmp)
422 return;
423
424 if (t->nrof && tmp->nrof <= 1) 373 if (t->nrof && tmp->nrof <= 1)
425 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 374 tmp->nrof = rndm (t->nrof) + 1;
426 375
427 fix_generated_item (tmp, op, difficulty, t->magic, flag); 376 fix_generated_item (tmp, op, difficulty, t->magic, flag);
428 change_treasure (t, tmp); 377 change_treasure (t, tmp);
429 put_treasure (tmp, op, flag); 378 put_treasure (tmp, op, flag);
379 }
430 } 380 }
381}
382
383void
384object::create_treasure (treasurelist *tl, int flags)
385{
386 ::create_treasure (tl, this, flags, map ? map->difficulty : 0);
431} 387}
432 388
433/* This calls the appropriate treasure creation function. tries is passed 389/* This calls the appropriate treasure creation function. tries is passed
434 * to determine how many list transitions or attempts to create treasure 390 * to determine how many list transitions or attempts to create treasure
435 * have been made. It is really in place to prevent infinite loops with 391 * have been made. It is really in place to prevent infinite loops with
436 * list transitions, or so that excessively good treasure will not be 392 * list transitions, or so that excessively good treasure will not be
437 * created on weak maps, because it will exceed the number of allowed tries 393 * created on weak maps, because it will exceed the number of allowed tries
438 * to do that. 394 * to do that.
439 */ 395 */
440void 396void
441create_treasure (treasurelist * t, object *op, int flag, int difficulty, int tries) 397create_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
442{ 398{
399 // empty treasurelists are legal
400 if (!tl->items)
401 return;
443 402
444 if (tries++ > 100) 403 if (tries++ > 100)
445 { 404 {
446 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n"); 405 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n");
447 return; 406 return;
448 } 407 }
408
409 if (op->flag [FLAG_TREASURE_ENV])
410 {
411 // do not generate items when there already is something above the object
412 if (op->flag [FLAG_IS_FLOOR] && op->above)
413 return;
414
415 flag |= GT_ENVIRONMENT;
416 }
417
449 if (t->total_chance) 418 if (tl->total_chance)
450 create_one_treasure (t, op, flag, difficulty, tries); 419 create_one_treasure (tl, op, flag, difficulty, tries);
451 else 420 else
452 create_all_treasures (t->items, op, flag, difficulty, tries); 421 create_all_treasures (tl->items, op, flag, difficulty, tries);
453} 422}
454 423
455/* This is similar to the old generate treasure function. However, 424/* This is similar to the old generate treasure function. However,
456 * it instead takes a treasurelist. It is really just a wrapper around 425 * it instead takes a treasurelist. It is really just a wrapper around
457 * create_treasure. We create a dummy object that the treasure gets 426 * create_treasure. We create a dummy object that the treasure gets
458 * inserted into, and then return that treausre 427 * inserted into, and then return that treausre
459 */ 428 */
460object * 429object *
461generate_treasure (treasurelist *t, int difficulty) 430generate_treasure (treasurelist *tl, int difficulty)
462{ 431{
463 difficulty = clamp (difficulty, 1, settings.max_level); 432 difficulty = clamp (difficulty, 1, settings.max_level);
464 433
465 object *ob = object::create (), *tmp; 434 object *ob = object::create ();
466 435
467 create_treasure (t, ob, 0, difficulty, 0); 436 create_treasure (tl, ob, 0, difficulty, 0);
468 437
469 /* Don't want to free the object we are about to return */ 438 /* Don't want to free the object we are about to return */
470 tmp = ob->inv; 439 object *tmp = ob->inv;
471 if (tmp != NULL) 440 if (tmp)
472 tmp->remove (); 441 tmp->remove ();
473 442
474 if (ob->inv) 443 if (ob->inv)
475 LOG (llevError, "In generate treasure, created multiple objects.\n"); 444 LOG (llevError, "In generate treasure, created multiple objects.\n");
476 445
477 ob->destroy (); 446 ob->destroy ();
447
478 return tmp; 448 return tmp;
479} 449}
480 450
481/* 451/*
482 * This is a new way of calculating the chance for an item to have 452 * This is a new way of calculating the chance for an item to have
484 * The array has two arguments, the difficulty of the level, and the 454 * The array has two arguments, the difficulty of the level, and the
485 * magical bonus "wanted". 455 * magical bonus "wanted".
486 */ 456 */
487 457
488static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = { 458static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = {
489
490/*chance of magic difficulty*/ 459// chance of magic difficulty
491
492/* +0 +1 +2 +3 +4 */ 460// +0 +1 +2 +3 +4
493 {95, 2, 2, 1, 0}, /*1 */ 461 {95, 2, 2, 1, 0}, // 1
494 {92, 5, 2, 1, 0}, /*2 */ 462 {92, 5, 2, 1, 0}, // 2
495 {85, 10, 4, 1, 0}, /*3 */ 463 {85, 10, 4, 1, 0}, // 3
496 {80, 14, 4, 2, 0}, /*4 */ 464 {80, 14, 4, 2, 0}, // 4
497 {75, 17, 5, 2, 1}, /*5 */ 465 {75, 17, 5, 2, 1}, // 5
498 {70, 18, 8, 3, 1}, /*6 */ 466 {70, 18, 8, 3, 1}, // 6
499 {65, 21, 10, 3, 1}, /*7 */ 467 {65, 21, 10, 3, 1}, // 7
500 {60, 22, 12, 4, 2}, /*8 */ 468 {60, 22, 12, 4, 2}, // 8
501 {55, 25, 14, 4, 2}, /*9 */ 469 {55, 25, 14, 4, 2}, // 9
502 {50, 27, 16, 5, 2}, /*10 */ 470 {50, 27, 16, 5, 2}, // 10
503 {45, 28, 18, 6, 3}, /*11 */ 471 {45, 28, 18, 6, 3}, // 11
504 {42, 28, 20, 7, 3}, /*12 */ 472 {42, 28, 20, 7, 3}, // 12
505 {40, 27, 21, 8, 4}, /*13 */ 473 {40, 27, 21, 8, 4}, // 13
506 {38, 25, 22, 10, 5}, /*14 */ 474 {38, 25, 22, 10, 5}, // 14
507 {36, 23, 23, 12, 6}, /*15 */ 475 {36, 23, 23, 12, 6}, // 15
508 {33, 21, 24, 14, 8}, /*16 */ 476 {33, 21, 24, 14, 8}, // 16
509 {31, 19, 25, 16, 9}, /*17 */ 477 {31, 19, 25, 16, 9}, // 17
510 {27, 15, 30, 18, 10}, /*18 */ 478 {27, 15, 30, 18, 10}, // 18
511 {20, 12, 30, 25, 13}, /*19 */ 479 {20, 12, 30, 25, 13}, // 19
512 {15, 10, 28, 30, 17}, /*20 */ 480 {15, 10, 28, 30, 17}, // 20
513 {13, 9, 27, 28, 23}, /*21 */ 481 {13, 9, 27, 28, 23}, // 21
514 {10, 8, 25, 28, 29}, /*22 */ 482 {10, 8, 25, 28, 29}, // 22
515 {8, 7, 23, 26, 36}, /*23 */ 483 { 8, 7, 23, 26, 36}, // 23
516 {6, 6, 20, 22, 46}, /*24 */ 484 { 6, 6, 20, 22, 46}, // 24
517 {4, 5, 17, 18, 56}, /*25 */ 485 { 4, 5, 17, 18, 56}, // 25
518 {2, 4, 12, 14, 68}, /*26 */ 486 { 2, 4, 12, 14, 68}, // 26
519 {0, 3, 7, 10, 80}, /*27 */ 487 { 0, 3, 7, 10, 80}, // 27
520 {0, 0, 3, 7, 90}, /*28 */ 488 { 0, 0, 3, 7, 90}, // 28
521 {0, 0, 0, 3, 97}, /*29 */ 489 { 0, 0, 0, 3, 97}, // 29
522 {0, 0, 0, 0, 100}, /*30 */ 490 { 0, 0, 0, 0, 100}, // 30
523 {0, 0, 0, 0, 100}, /*31 */ 491 { 0, 0, 0, 0, 100}, // 31
524}; 492};
525
526 493
527/* calculate the appropriate level for wands staves and scrolls. 494/* calculate the appropriate level for wands staves and scrolls.
528 * This code presumes that op has had its spell object created (in op->inv) 495 * This code presumes that op has had its spell object created (in op->inv)
529 * 496 *
530 * elmex Wed Aug 9 17:44:59 CEST 2006: 497 * elmex Wed Aug 9 17:44:59 CEST 2006:
531 * Removed multiplicator, too many high-level items were generated on low-difficulty maps. 498 * Removed multiplicator, too many high-level items were generated on low-difficulty maps.
532 */ 499 */
533 500static int
534int
535level_for_item (const object *op, int difficulty) 501level_for_item (const object *op, int difficulty)
536{ 502{
537 int olevel = 0;
538
539 if (!op->inv) 503 if (!op->inv)
540 { 504 {
541 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name); 505 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name);
542 return 0; 506 return 0;
543 } 507 }
544 508
545 olevel = (int) (op->inv->level + (double) difficulty * (1 - drand48 () * drand48 () * 2)); 509 int olevel = op->inv->level + int (difficulty * (1. - rndm () * rndm () * 2.));
546 510
547 if (olevel <= 0) 511 if (olevel <= 0)
548 olevel = rndm (1, MIN (op->inv->level, 1)); 512 olevel = rndm (1, op->inv->level);
549 513
550 if (olevel > MAXLEVEL) 514 return min (olevel, MAXLEVEL);
551 olevel = MAXLEVEL;
552
553 return olevel;
554} 515}
555 516
556/* 517/*
557 * Based upon the specified difficulty and upon the difftomagic_list array, 518 * Based upon the specified difficulty and upon the difftomagic_list array,
558 * a random magical bonus is returned. This is used when determine 519 * a random magical bonus is returned. This is used when determine
561 * elmex Thu Aug 10 18:45:44 CEST 2006: 522 * elmex Thu Aug 10 18:45:44 CEST 2006:
562 * Scaling difficulty by max_level, as difficulty is a level and not some 523 * Scaling difficulty by max_level, as difficulty is a level and not some
563 * weird integer between 1-31. 524 * weird integer between 1-31.
564 * 525 *
565 */ 526 */
566 527static int
567int
568magic_from_difficulty (int difficulty) 528magic_from_difficulty (int difficulty)
569{ 529{
570 int percent = 0, magic = 0; 530 int percent = 0, magic = 0;
571 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS); 531 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS);
572 532
576 scaled_diff = 0; 536 scaled_diff = 0;
577 537
578 if (scaled_diff >= DIFFLEVELS) 538 if (scaled_diff >= DIFFLEVELS)
579 scaled_diff = DIFFLEVELS - 1; 539 scaled_diff = DIFFLEVELS - 1;
580 540
581 percent = RANDOM () % 100; 541 percent = rndm (100);
582 542
583 for (magic = 0; magic < (MAXMAGIC + 1); magic++) 543 for (magic = 0; magic < (MAXMAGIC + 1); magic++)
584 { 544 {
585 percent -= difftomagic_list[scaled_diff][magic]; 545 percent -= difftomagic_list[scaled_diff][magic];
586 546
592 { 552 {
593 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty); 553 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty);
594 magic = 0; 554 magic = 0;
595 } 555 }
596 556
597 magic = (RANDOM () % 3) ? magic : -magic; 557 magic = (rndm (3)) ? magic : -magic;
598 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */ 558 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */
599 559
600 return magic; 560 return magic;
601} 561}
602 562
615 575
616 op->magic = magic; 576 op->magic = magic;
617 if (op->arch) 577 if (op->arch)
618 { 578 {
619 if (op->type == ARMOUR) 579 if (op->type == ARMOUR)
620 ARMOUR_SPEED (op) = (ARMOUR_SPEED (&op->arch->clone) * (100 + magic * 10)) / 100; 580 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op->arch) * (100 + magic * 10)) / 100;
621 581
622 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 582 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
623 magic = (-magic); 583 magic = (-magic);
584
624 op->weight = (op->arch->clone.weight * (100 - magic * 10)) / 100; 585 op->weight = (op->arch->weight * (100 - magic * 10)) / 100;
625 } 586 }
626 else 587 else
627 { 588 {
628 if (op->type == ARMOUR) 589 if (op->type == ARMOUR)
629 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100; 590 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100;
591
630 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 592 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
631 magic = (-magic); 593 magic = (-magic);
594
632 op->weight = (op->weight * (100 - magic * 10)) / 100; 595 op->weight = (op->weight * (100 - magic * 10)) / 100;
633 } 596 }
634} 597}
635 598
636/* 599/*
659 * 1) Since rings can have multiple bonuses, if the same bonus 622 * 1) Since rings can have multiple bonuses, if the same bonus
660 * is rolled again, increase it - the bonuses now stack with 623 * is rolled again, increase it - the bonuses now stack with
661 * other bonuses previously rolled and ones the item might natively have. 624 * other bonuses previously rolled and ones the item might natively have.
662 * 2) Add code to deal with new PR method. 625 * 2) Add code to deal with new PR method.
663 */ 626 */
664 627static void
665void
666set_ring_bonus (object *op, int bonus) 628set_ring_bonus (object *op, int bonus)
667{ 629{
668
669 int r = RANDOM () % (bonus > 0 ? 25 : 11); 630 int r = rndm (bonus > 0 ? 25 : 11);
670 631
671 if (op->type == AMULET) 632 if (op->type == AMULET)
672 { 633 {
673 if (!(RANDOM () % 21)) 634 if (!(rndm (21)))
674 r = 20 + RANDOM () % 2; 635 r = 20 + rndm (2);
675 else 636 else
676 { 637 {
677 if (RANDOM () & 2) 638 if (rndm (2))
678 r = 10; 639 r = 10;
679 else 640 else
680 r = 11 + RANDOM () % 9; 641 r = 11 + rndm (9);
681 } 642 }
682 } 643 }
683 644
684 switch (r) 645 switch (r)
685 { 646 {
692 case 2: 653 case 2:
693 case 3: 654 case 3:
694 case 4: 655 case 4:
695 case 5: 656 case 5:
696 case 6: 657 case 6:
697 set_attr_value (&op->stats, r, (signed char) (bonus + get_attr_value (&op->stats, r))); 658 op->stats.stat (r) += bonus;
698 break; 659 break;
699 660
700 case 7: 661 case 7:
701 op->stats.dam += bonus; 662 op->stats.dam += bonus;
702 break; 663 break;
722 case 16: 683 case 16:
723 case 17: 684 case 17:
724 case 18: 685 case 18:
725 case 19: 686 case 19:
726 { 687 {
727 int b = 5 + FABS (bonus), val, resist = RANDOM () % num_resist_table; 688 int b = 5 + abs (bonus), val, resist = rndm (num_resist_table);
728 689
729 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */ 690 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */
730 val = 10 + RANDOM () % b + RANDOM () % b + RANDOM () % b + RANDOM () % b; 691 val = 10 + rndm (b) + rndm (b) + rndm (b) + rndm (b);
731 692
732 /* Cursed items need to have higher negative values to equal out with 693 /* Cursed items need to have higher negative values to equal out with
733 * positive values for how protections work out. Put another 694 * positive values for how protections work out. Put another
734 * little random element in since that they don't always end up with 695 * little random element in since that they don't always end up with
735 * even values. 696 * even values.
736 */ 697 */
737 if (bonus < 0) 698 if (bonus < 0)
738 val = 2 * -val - RANDOM () % b; 699 val = 2 * -val - rndm (b);
739 if (val > 35) 700 if (val > 35)
740 val = 35; /* Upper limit */ 701 val = 35; /* Upper limit */
741 b = 0; 702 b = 0;
703
742 while (op->resist[resist_table[resist]] != 0 && b < 4) 704 while (op->resist[resist_table[resist]] != 0 && b < 4)
743 {
744 resist = RANDOM () % num_resist_table; 705 resist = rndm (num_resist_table);
745 } 706
746 if (b == 4) 707 if (b == 4)
747 return; /* Not able to find a free resistance */ 708 return; /* Not able to find a free resistance */
709
748 op->resist[resist_table[resist]] = val; 710 op->resist[resist_table[resist]] = val;
749 /* We should probably do something more clever here to adjust value 711 /* We should probably do something more clever here to adjust value
750 * based on how good a resistance we gave. 712 * based on how good a resistance we gave.
751 */ 713 */
752 break; 714 break;
780 case 22: 742 case 22:
781 op->stats.exp += bonus; /* Speed! */ 743 op->stats.exp += bonus; /* Speed! */
782 op->value = (op->value * 2) / 3; 744 op->value = (op->value * 2) / 3;
783 break; 745 break;
784 } 746 }
747
785 if (bonus > 0) 748 if (bonus > 0)
786 op->value *= 2 * bonus; 749 op->value *= 2 * bonus;
787 else 750 else
788 op->value = -(op->value * 2 * bonus) / 3; 751 op->value = -(op->value * 2 * bonus) / 3;
789} 752}
794 * higher is the chance of returning a low number. 757 * higher is the chance of returning a low number.
795 * It is only used in fix_generated_treasure() to set bonuses on 758 * It is only used in fix_generated_treasure() to set bonuses on
796 * rings and amulets. 759 * rings and amulets.
797 * Another scheme is used to calculate the magic of weapons and armours. 760 * Another scheme is used to calculate the magic of weapons and armours.
798 */ 761 */
799 762static int
800int
801get_magic (int diff) 763get_magic (int diff)
802{ 764{
803 int i; 765 int i;
804 766
805 if (diff < 3) 767 if (diff < 3)
806 diff = 3; 768 diff = 3;
769
807 for (i = 0; i < 4; i++) 770 for (i = 0; i < 4; i++)
808 if (RANDOM () % diff) 771 if (rndm (diff))
809 return i; 772 return i;
773
810 return 4; 774 return 4;
811} 775}
812 776
777/* special_potion() - so that old potion code is still done right. */
778static int
779special_potion (object *op)
780{
781 if (op->attacktype)
782 return 1;
783
784 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha)
785 return 1;
786
787 for (int i = 0; i < NROFATTACKS; i++)
788 if (op->resist[i])
789 return 1;
790
791 return 0;
792}
793
813#define DICE2 (get_magic(2)==2?2:1) 794#define DICE2 (get_magic(2)==2?2:1)
814#define DICESPELL (RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3) 795#define DICESPELL (rndm (3) + rndm (3) + rndm (3) + rndm (3) + rndm (3))
815 796
816/* 797/*
817 * fix_generated_item(): This is called after an item is generated, in 798 * fix_generated_item(): This is called after an item is generated, in
818 * order to set it up right. This produced magical bonuses, puts spells 799 * order to set it up right. This produced magical bonuses, puts spells
819 * into scrolls/books/wands, makes it unidentified, hides the value, etc. 800 * into scrolls/books/wands, makes it unidentified, hides the value, etc.
833 * value. 814 * value.
834 * GT_MINIMAL: Does minimal processing on the object - just enough to make it 815 * GT_MINIMAL: Does minimal processing on the object - just enough to make it
835 * a working object - don't change magic, value, etc, but set it material 816 * a working object - don't change magic, value, etc, but set it material
836 * type as appropriate, for objects that need spell objects, set those, etc 817 * type as appropriate, for objects that need spell objects, set those, etc
837 */ 818 */
838
839void 819void
840fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags) 820fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags)
841{ 821{
842 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0; 822 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0;
843 823
848 save_item_power = op->item_power; 828 save_item_power = op->item_power;
849 op->item_power = 0; 829 op->item_power = 0;
850 830
851 if (op->randomitems && op->type != SPELL) 831 if (op->randomitems && op->type != SPELL)
852 { 832 {
853 create_treasure (op->randomitems, op, flags, difficulty, 0); 833 create_treasure (op->randomitems, op, flags & ~GT_ENVIRONMENT, difficulty, 0);
854 if (!op->inv)
855 LOG (llevDebug, "fix_generated_item: Unable to generate treasure for %s\n", &op->name);
856
857 /* So the treasure doesn't get created again */ 834 /* So the treasure doesn't get created again */
858 op->randomitems = NULL; 835 op->randomitems = 0;
859 } 836 }
860 837
861 if (difficulty < 1) 838 max_it (difficulty, 1);
862 difficulty = 1;
863 839
864 if (INVOKE_OBJECT (ADD_BONUS, op, 840 if (INVOKE_OBJECT (ADD_BONUS, op,
865 ARG_OBJECT (creator != op ? creator : 0), 841 ARG_OBJECT (creator != op ? creator : 0),
866 ARG_INT (difficulty), ARG_INT (max_magic), 842 ARG_INT (difficulty), ARG_INT (max_magic),
867 ARG_INT (flags))) 843 ARG_INT (flags)))
868 return; 844 return;
869 845
870 if (!(flags & GT_MINIMAL)) 846 if (!(flags & GT_MINIMAL))
871 { 847 {
872 if (op->arch == crown_arch) 848 if (IS_ARCH (op->arch, crown))
873 { 849 {
874 set_magic (difficulty, op, max_magic, flags); 850 set_magic (difficulty, op, max_magic, flags);
875 num_enchantments = calc_item_power (op, 1); 851 num_enchantments = calc_item_power (op, 1);
876 generate_artifact (op, difficulty); 852 generate_artifact (op, difficulty);
877 } 853 }
880 if (!op->magic && max_magic) 856 if (!op->magic && max_magic)
881 set_magic (difficulty, op, max_magic, flags); 857 set_magic (difficulty, op, max_magic, flags);
882 858
883 num_enchantments = calc_item_power (op, 1); 859 num_enchantments = calc_item_power (op, 1);
884 860
885 if ((!was_magic && !(RANDOM () % CHANCE_FOR_ARTIFACT)) || op->type == HORN || difficulty >= settings.max_level) /* high difficulties always generate an artifact, 861 if ((!was_magic && !rndm (CHANCE_FOR_ARTIFACT))
886 * used for shop_floors or treasures */ 862 || op->type == HORN
863 || difficulty >= settings.max_level) /* high difficulties always generate an artifact, used for shop_floors or treasures */
887 generate_artifact (op, difficulty); 864 generate_artifact (op, difficulty);
888 } 865 }
889 866
890 /* Object was made an artifact. Calculate its item_power rating. 867 /* Object was made an artifact. Calculate its item_power rating.
891 * the item_power in the object is what the artfiact adds. 868 * the item_power in the object is what the artfiact adds.
925 * again below */ 902 * again below */
926 } 903 }
927 } 904 }
928 905
929 /* materialtype modifications. Note we allow this on artifacts. */ 906 /* materialtype modifications. Note we allow this on artifacts. */
930 set_materialname (op, difficulty, NULL); 907 select_material (op, difficulty);
931 908
932 if (flags & GT_MINIMAL) 909 if (flags & GT_MINIMAL)
933 { 910 {
934 if (op->type == POTION) 911 if (op->type == POTION)
935 /* Handle healing and magic power potions */ 912 /* Handle healing and magic power potions */
936 if (op->stats.sp && !op->randomitems) 913 if (op->stats.sp && !op->randomitems)
937 { 914 {
938 object *tmp;
939
940 tmp = get_archetype (spell_mapping[op->stats.sp]); 915 object *tmp = get_archetype (spell_mapping [op->stats.sp]);
941 insert_ob_in_ob (tmp, op); 916 insert_ob_in_ob (tmp, op);
942 op->stats.sp = 0; 917 op->stats.sp = 0;
943 } 918 }
944 } 919 }
945 else if (!op->title) /* Only modify object if not special */ 920 else if (!op->title) /* Only modify object if not special */
948 case WEAPON: 923 case WEAPON:
949 case ARMOUR: 924 case ARMOUR:
950 case SHIELD: 925 case SHIELD:
951 case HELMET: 926 case HELMET:
952 case CLOAK: 927 case CLOAK:
953 if (QUERY_FLAG (op, FLAG_CURSED) && !(RANDOM () % 4)) 928 if (QUERY_FLAG (op, FLAG_CURSED) && !(rndm (4)))
954 set_ring_bonus (op, -DICE2); 929 set_ring_bonus (op, -DICE2);
955 break; 930 break;
956 931
957 case BRACERS: 932 case BRACERS:
958 if (!(RANDOM () % (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))) 933 if (!rndm (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))
959 { 934 {
960 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 935 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
961 if (!QUERY_FLAG (op, FLAG_CURSED)) 936 if (!QUERY_FLAG (op, FLAG_CURSED))
962 op->value *= 3; 937 op->value *= 3;
963 } 938 }
968 int too_many_tries = 0, is_special = 0; 943 int too_many_tries = 0, is_special = 0;
969 944
970 /* Handle healing and magic power potions */ 945 /* Handle healing and magic power potions */
971 if (op->stats.sp && !op->randomitems) 946 if (op->stats.sp && !op->randomitems)
972 { 947 {
973 object *tmp;
974
975 tmp = get_archetype (spell_mapping[op->stats.sp]); 948 object *tmp = get_archetype (spell_mapping[op->stats.sp]);
976 insert_ob_in_ob (tmp, op); 949 insert_ob_in_ob (tmp, op);
977 op->stats.sp = 0; 950 op->stats.sp = 0;
978 } 951 }
979 952
980 while (!(is_special = special_potion (op)) && !op->inv) 953 while (!(is_special = special_potion (op)) && !op->inv)
988 * since the value set on those is already correct. 961 * since the value set on those is already correct.
989 */ 962 */
990 if (op->inv && op->randomitems) 963 if (op->inv && op->randomitems)
991 { 964 {
992 /* value multiplier is same as for scrolls */ 965 /* value multiplier is same as for scrolls */
993 op->value = (op->value * op->inv->value); 966 op->value *= op->inv->value;
994 op->level = op->inv->level / 2 + RANDOM () % difficulty + RANDOM () % difficulty; 967 op->level = op->inv->level / 2 + rndm (difficulty) + rndm (difficulty);
995 } 968 }
996 else 969 else
997 { 970 {
998 op->name = "potion"; 971 op->name = "potion";
999 op->name_pl = "potions"; 972 op->name_pl = "potions";
1000 } 973 }
1001 974
1002 if (!(flags & GT_ONLY_GOOD) && RANDOM () % 2) 975 if (!(flags & GT_ONLY_GOOD) && rndm (2))
1003 SET_FLAG (op, FLAG_CURSED); 976 SET_FLAG (op, FLAG_CURSED);
977
1004 break; 978 break;
1005 } 979 }
1006 980
1007 case AMULET: 981 case AMULET:
1008 if (op->arch == amulet_arch) 982 if (IS_ARCH (op->arch, amulet))
1009 op->value *= 5; /* Since it's not just decoration */ 983 op->value *= 5; /* Since it's not just decoration */
1010 984
1011 case RING: 985 case RING:
1012 if (op->arch == NULL)
1013 {
1014 op->destroy ();
1015 op = 0;
1016 break;
1017 }
1018
1019 if (op->arch != ring_arch && op->arch != amulet_arch) /* It's a special artifact! */ 986 if (!IS_ARCH (op->arch, ring) && !IS_ARCH (op->arch, amulet)) /* It's a special artifact! */
1020 break; 987 break;
1021 988
1022 if (!(flags & GT_ONLY_GOOD) && !(RANDOM () % 3)) 989 if (!(flags & GT_ONLY_GOOD) && !(rndm (3)))
1023 SET_FLAG (op, FLAG_CURSED); 990 SET_FLAG (op, FLAG_CURSED);
1024 991
1025 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 992 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
1026 993
1027 if (op->type != RING) /* Amulets have only one ability */ 994 if (op->type != RING) /* Amulets have only one ability */
1028 break; 995 break;
1029 996
1030 if (!(RANDOM () % 4)) 997 if (!(rndm (4)))
1031 { 998 {
1032 int d = (RANDOM () % 2 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 999 int d = (rndm (2) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1033 1000
1034 if (d > 0) 1001 if (d > 0)
1035 op->value *= 3; 1002 op->value *= 3;
1036 1003
1037 set_ring_bonus (op, d); 1004 set_ring_bonus (op, d);
1038 1005
1039 if (!(RANDOM () % 4)) 1006 if (!(rndm (4)))
1040 { 1007 {
1041 int d = (RANDOM () % 3 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 1008 int d = (rndm (3) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1042 1009
1043 if (d > 0) 1010 if (d > 0)
1044 op->value *= 5; 1011 op->value *= 5;
1045 set_ring_bonus (op, d); 1012 set_ring_bonus (op, d);
1046 } 1013 }
1047 } 1014 }
1048 1015
1049 if (GET_ANIM_ID (op)) 1016 if (op->animation_id)
1050 SET_ANIMATION (op, RANDOM () % ((int) NUM_ANIMATIONS (op))); 1017 op->set_anim_frame (rndm (op->anim_frames ()));
1051 1018
1052 break; 1019 break;
1053 1020
1054 case BOOK: 1021 case BOOK:
1055 /* Is it an empty book?, if yes lets make a special· 1022 /* Is it an empty book?, if yes lets make a special·
1056 * msg for it, and tailor its properties based on the· 1023 * msg for it, and tailor its properties based on the·
1057 * creator and/or map level we found it on. 1024 * creator and/or map level we found it on.
1058 */ 1025 */
1059 if (!op->msg && RANDOM () % 10) 1026 if (!op->msg && rndm (10))
1060 { 1027 {
1061 /* set the book level properly */ 1028 /* set the book level properly */
1062 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE)) 1029 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE))
1063 { 1030 {
1064 if (op->map && op->map->difficulty) 1031 if (op->map && op->map->difficulty)
1065 op->level = RANDOM () % (op->map->difficulty) + RANDOM () % 10 + 1; 1032 op->level = rndm (op->map->difficulty) + rndm (10) + 1;
1066 else 1033 else
1067 op->level = RANDOM () % 20 + 1; 1034 op->level = rndm (20) + 1;
1068 } 1035 }
1069 else 1036 else
1070 op->level = RANDOM () % creator->level; 1037 op->level = rndm (creator->level);
1071 1038
1072 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1); 1039 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1);
1073 /* books w/ info are worth more! */ 1040 /* books w/ info are worth more! */
1074 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1)); 1041 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1));
1075 /* creator related stuff */
1076
1077 /* for library, chained books. Note that some monsters have no_pick
1078 * set - we don't want to set no pick in that case.
1079 */
1080 if (QUERY_FLAG (creator, FLAG_NO_PICK) && !QUERY_FLAG (creator, FLAG_MONSTER))
1081 SET_FLAG (op, FLAG_NO_PICK);
1082 if (creator->slaying && !op->slaying) /* for check_inv floors */
1083 op->slaying = creator->slaying;
1084 1042
1085 /* add exp so reading it gives xp (once) */ 1043 /* add exp so reading it gives xp (once) */
1086 op->stats.exp = op->value > 10000 ? op->value / 5 : op->value / 10; 1044 op->stats.exp = op->value > 10000 ? op->value / 5 : op->value / 10;
1087 } 1045 }
1046
1047 /* creator related stuff */
1048
1049 /* for library, chained books. Note that some monsters have no_pick
1050 * set - we don't want to set no pick in that case.
1051 */
1052 if (QUERY_FLAG (creator, FLAG_NO_PICK) && !QUERY_FLAG (creator, FLAG_MONSTER))
1053 SET_FLAG (op, FLAG_NO_PICK);
1054 if (creator->slaying && !op->slaying) /* for check_inv floors */
1055 op->slaying = creator->slaying;
1088 break; 1056 break;
1089 1057
1090 case SPELLBOOK: 1058 case SPELLBOOK:
1091 op->value = op->value * op->inv->value; 1059 op->value = op->value * op->inv->value;
1092 /* add exp so learning gives xp */ 1060 /* add exp so learning gives xp */
1126 * 10 time multiplier). This way, the value are a bit more reasonable. 1094 * 10 time multiplier). This way, the value are a bit more reasonable.
1127 */ 1095 */
1128 op->value = op->value * op->inv->value * (op->level + 50) / (op->inv->level + 50); 1096 op->value = op->value * op->inv->value * (op->level + 50) / (op->inv->level + 50);
1129 /* maxhp is used to denote how many 'charges' the rod holds before */ 1097 /* maxhp is used to denote how many 'charges' the rod holds before */
1130 if (op->stats.maxhp) 1098 if (op->stats.maxhp)
1131 op->stats.maxhp *= MAX (op->inv->stats.sp, op->inv->stats.grace); 1099 op->stats.maxhp *= max (op->inv->stats.sp, op->inv->stats.grace);
1132 else 1100 else
1133 op->stats.maxhp = 2 * MAX (op->inv->stats.sp, op->inv->stats.grace); 1101 op->stats.maxhp = 2 * max (op->inv->stats.sp, op->inv->stats.grace);
1134 1102
1135 op->stats.hp = op->stats.maxhp; 1103 op->stats.hp = op->stats.maxhp;
1136 break; 1104 break;
1137 1105
1138 case SCROLL: 1106 case SCROLL:
1174 */ 1142 */
1175 1143
1176/* 1144/*
1177 * Allocate and return the pointer to an empty artifactlist structure. 1145 * Allocate and return the pointer to an empty artifactlist structure.
1178 */ 1146 */
1179
1180static artifactlist * 1147static artifactlist *
1181get_empty_artifactlist (void) 1148get_empty_artifactlist ()
1182{ 1149{
1183 artifactlist *tl = (artifactlist *) malloc (sizeof (artifactlist)); 1150 return salloc0<artifactlist> ();
1184
1185 if (tl == NULL)
1186 fatal (OUT_OF_MEMORY);
1187 tl->next = NULL;
1188 tl->items = NULL;
1189 tl->total_chance = 0;
1190 return tl;
1191} 1151}
1192 1152
1193/* 1153/*
1194 * Allocate and return the pointer to an empty artifact structure. 1154 * Allocate and return the pointer to an empty artifact structure.
1195 */ 1155 */
1196
1197static artifact * 1156static artifact *
1198get_empty_artifact (void) 1157get_empty_artifact ()
1199{ 1158{
1200 artifact *t = (artifact *) malloc (sizeof (artifact)); 1159 return salloc0<artifact> ();
1201
1202 if (t == NULL)
1203 fatal (OUT_OF_MEMORY);
1204 t->item = NULL;
1205 t->next = NULL;
1206 t->chance = 0;
1207 t->difficulty = 0;
1208 t->allowed = NULL;
1209 return t;
1210} 1160}
1211 1161
1212/* 1162/*
1213 * Searches the artifact lists and returns one that has the same type 1163 * Searches the artifact lists and returns one that has the same type
1214 * of objects on it. 1164 * of objects on it.
1215 */ 1165 */
1216
1217artifactlist * 1166artifactlist *
1218find_artifactlist (int type) 1167find_artifactlist (int type)
1219{ 1168{
1220 artifactlist *al;
1221
1222 for (al = first_artifactlist; al != NULL; al = al->next) 1169 for (artifactlist *al = first_artifactlist; al; al = al->next)
1223 if (al->type == type) 1170 if (al->type == type)
1224 return al; 1171 return al;
1172
1225 return NULL; 1173 return 0;
1226} 1174}
1227 1175
1228/* 1176/*
1229 * For debugging purposes. Dumps all tables. 1177 * Builds up the lists of artifacts from the file in the libdir.
1230 */ 1178 */
1231
1232void 1179void
1233dump_artifacts (void)
1234{
1235 artifactlist *al;
1236 artifact *art;
1237 linked_char *next;
1238
1239 fprintf (logfile, "\n");
1240 for (al = first_artifactlist; al != NULL; al = al->next)
1241 {
1242 fprintf (logfile, "Artifact has type %d, total_chance=%d\n", al->type, al->total_chance);
1243 for (art = al->items; art != NULL; art = art->next)
1244 {
1245 fprintf (logfile, "Artifact %-30s Difficulty %3d Chance %5d\n", &art->item->name, art->difficulty, art->chance);
1246 if (art->allowed != NULL)
1247 {
1248 fprintf (logfile, "\tAllowed combinations:");
1249 for (next = art->allowed; next != NULL; next = next->next)
1250 fprintf (logfile, "%s,", &next->name);
1251 fprintf (logfile, "\n");
1252 }
1253 }
1254 }
1255 fprintf (logfile, "\n");
1256}
1257
1258/*
1259 * For debugging purposes. Dumps all treasures recursively (see below).
1260 */
1261void
1262dump_monster_treasure_rec (const char *name, treasure *t, int depth)
1263{
1264 treasurelist *tl;
1265 int i;
1266
1267 if (depth > 100)
1268 return;
1269 while (t != NULL)
1270 {
1271 if (t->name != NULL)
1272 {
1273 for (i = 0; i < depth; i++)
1274 fprintf (logfile, " ");
1275 fprintf (logfile, "{ (list: %s)\n", &t->name);
1276 tl = find_treasurelist (t->name);
1277 if (tl)
1278 dump_monster_treasure_rec (name, tl->items, depth + 2);
1279 for (i = 0; i < depth; i++)
1280 fprintf (logfile, " ");
1281 fprintf (logfile, "} (end of list: %s)\n", &t->name);
1282 }
1283 else
1284 {
1285 for (i = 0; i < depth; i++)
1286 fprintf (logfile, " ");
1287 if (t->item->clone.type == FLESH)
1288 fprintf (logfile, "%s's %s\n", name, &t->item->clone.name);
1289 else
1290 fprintf (logfile, "%s\n", &t->item->clone.name);
1291 }
1292 if (t->next_yes != NULL)
1293 {
1294 for (i = 0; i < depth; i++)
1295 fprintf (logfile, " ");
1296 fprintf (logfile, " (if yes)\n");
1297 dump_monster_treasure_rec (name, t->next_yes, depth + 1);
1298 }
1299 if (t->next_no != NULL)
1300 {
1301 for (i = 0; i < depth; i++)
1302 fprintf (logfile, " ");
1303 fprintf (logfile, " (if no)\n");
1304 dump_monster_treasure_rec (name, t->next_no, depth + 1);
1305 }
1306 t = t->next;
1307 }
1308}
1309
1310/*
1311 * For debugging purposes. Dumps all treasures for a given monster.
1312 * Created originally by Raphael Quinet for debugging the alchemy code.
1313 */
1314
1315void
1316dump_monster_treasure (const char *name)
1317{
1318 archetype *at;
1319 int found;
1320
1321 found = 0;
1322 fprintf (logfile, "\n");
1323 for (at = first_archetype; at != NULL; at = at->next)
1324 if (!strcasecmp (at->clone.name, name) && at->clone.title == NULL)
1325 {
1326 fprintf (logfile, "treasures for %s (arch: %s)\n", &at->clone.name, &at->name);
1327 if (at->clone.randomitems != NULL)
1328 dump_monster_treasure_rec (at->clone.name, at->clone.randomitems->items, 1);
1329 else
1330 fprintf (logfile, "(nothing)\n");
1331 fprintf (logfile, "\n");
1332 found++;
1333 }
1334 if (found == 0)
1335 fprintf (logfile, "No objects have the name %s!\n\n", name);
1336}
1337
1338/*
1339 * Builds up the lists of artifacts from the file in the libdir.
1340 */
1341
1342void
1343init_artifacts (void) 1180init_artifacts ()
1344{ 1181{
1345 static int has_been_inited = 0; 1182 static int has_been_inited = 0;
1346 char filename[MAX_BUF], buf[HUGE_BUF], *cp, *next; 1183 char filename[MAX_BUF];
1347 artifact *art = NULL; 1184 artifact *art = NULL;
1348 linked_char *tmp;
1349 int value;
1350 artifactlist *al; 1185 artifactlist *al;
1351 1186
1352 if (has_been_inited) 1187 if (has_been_inited)
1353 return; 1188 return;
1354 else 1189 else
1355 has_been_inited = 1; 1190 has_been_inited = 1;
1356 1191
1357 sprintf (filename, "%s/artifacts", settings.datadir); 1192 sprintf (filename, "%s/artifacts", settings.datadir);
1358 object_thawer thawer (filename); 1193 object_thawer f (filename);
1359 1194
1360 if (!thawer) 1195 if (!f)
1361 return; 1196 return;
1362 1197
1363 while (fgets (buf, HUGE_BUF, thawer) != NULL) 1198 for (;;)
1364 { 1199 {
1365 if (*buf == '#') 1200 switch (f.kw)
1366 continue;
1367 if ((cp = strchr (buf, '\n')) != NULL)
1368 *cp = '\0';
1369 cp = buf;
1370 while (*cp == ' ') /* Skip blanks */
1371 cp++;
1372 if (*cp == '\0')
1373 continue;
1374
1375 if (!strncmp (cp, "Allowed", 7))
1376 { 1201 {
1202 case KW_allowed:
1377 if (art == NULL) 1203 if (!art)
1204 art = get_empty_artifact ();
1205
1378 { 1206 {
1379 art = get_empty_artifact (); 1207 if (!strcmp (f.get_str (), "all"))
1380 nrofartifacts++; 1208 break;
1209
1210 const char *cp = f.get_str ();
1211 char *next;
1212 do
1213 {
1214 if ((next = (char *)strchr (cp, ',')))
1215 *next++ = '\0';
1216
1217 linked_char *tmp = new linked_char;
1218
1219 tmp->name = cp;
1220 tmp->next = art->allowed;
1221 art->allowed = tmp;
1222 }
1223 while ((cp = next));
1381 } 1224 }
1382 cp = strchr (cp, ' ') + 1; 1225 break;
1383 if (!strcmp (cp, "all")) 1226
1227 case KW_chance:
1228 f.get (art->chance);
1229 break;
1230
1231 case KW_difficulty:
1232 f.get (art->difficulty);
1233 break;
1234
1235 case KW_object:
1236 {
1237 art->item = object::create ();
1238 f.get (art->item->name);
1239 f.next ();
1240
1241 if (!art->item->parse_kv (f))
1242 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1243
1244 al = find_artifactlist (art->item->type);
1245
1246 if (!al)
1247 {
1248 al = get_empty_artifactlist ();
1249 al->type = art->item->type;
1250 al->next = first_artifactlist;
1251 first_artifactlist = al;
1252 }
1253
1254 art->next = al->items;
1255 al->items = art;
1256 art = 0;
1257 }
1384 continue; 1258 continue;
1385 1259
1386 do 1260 case KW_EOF:
1261 goto done;
1262
1263 default:
1264 if (!f.parse_error ("artifacts file"))
1265 cleanup ("artifacts file required");
1387 { 1266 break;
1388 nrofallowedstr++;
1389 if ((next = strchr (cp, ',')) != NULL)
1390 *(next++) = '\0';
1391 tmp = new linked_char;
1392
1393 tmp->name = cp;
1394 tmp->next = art->allowed;
1395 art->allowed = tmp;
1396 }
1397 while ((cp = next) != NULL);
1398 }
1399 else if (sscanf (cp, "chance %d", &value))
1400 art->chance = (uint16) value;
1401 else if (sscanf (cp, "difficulty %d", &value))
1402 art->difficulty = (uint8) value;
1403 else if (!strncmp (cp, "Object", 6))
1404 { 1267 }
1405 art->item = object::create ();
1406 1268
1407 if (!load_object (thawer, art->item, 0)) 1269 f.next ();
1408 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1409
1410 art->item->name = strchr (cp, ' ') + 1;
1411 al = find_artifactlist (art->item->type);
1412 if (al == NULL)
1413 {
1414 al = get_empty_artifactlist ();
1415 al->type = art->item->type;
1416 al->next = first_artifactlist;
1417 first_artifactlist = al;
1418 }
1419 art->next = al->items;
1420 al->items = art;
1421 art = NULL;
1422 }
1423 else
1424 LOG (llevError, "Unknown input in artifact file: %s\n", buf);
1425 } 1270 }
1426 1271
1272done:
1427 for (al = first_artifactlist; al != NULL; al = al->next) 1273 for (al = first_artifactlist; al; al = al->next)
1428 { 1274 {
1275 al->total_chance = 0;
1276
1429 for (art = al->items; art != NULL; art = art->next) 1277 for (art = al->items; art; art = art->next)
1430 { 1278 {
1431 if (!art->chance) 1279 if (!art->chance)
1432 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name); 1280 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name);
1433 else 1281 else
1434 al->total_chance += art->chance; 1282 al->total_chance += art->chance;
1439 } 1287 }
1440 1288
1441 LOG (llevDebug, "done.\n"); 1289 LOG (llevDebug, "done.\n");
1442} 1290}
1443 1291
1444
1445/* 1292/*
1446 * Used in artifact generation. The bonuses of the first object 1293 * Used in artifact generation. The bonuses of the first object
1447 * is modified by the bonuses of the second object. 1294 * is modified by the bonuses of the second object.
1448 */ 1295 */
1449
1450void 1296void
1451add_abilities (object *op, object *change) 1297add_abilities (object *op, object *change)
1452{ 1298{
1453 int i, tmp; 1299 int i, tmp;
1454 1300
1455 if (change->face != blank_face) 1301 if (change->face != blank_face)
1456 { 1302 {
1457#ifdef TREASURE_VERBOSE 1303#ifdef TREASURE_VERBOSE
1458 LOG (llevDebug, "FACE: %d\n", change->face->number); 1304 LOG (llevDebug, "add_abilities change face: %d\n", change->face);
1459#endif 1305#endif
1460 op->face = change->face; 1306 op->face = change->face;
1461 } 1307 }
1462 1308
1463 for (i = 0; i < NUM_STATS; i++) 1309 for (i = 0; i < NUM_STATS; i++)
1464 change_attr_value (&(op->stats), i, get_attr_value (&(change->stats), i)); 1310 change_attr_value (&(op->stats), i, change->stats.stat (i));
1465 1311
1466 op->attacktype |= change->attacktype; 1312 op->attacktype |= change->attacktype;
1467 op->path_attuned |= change->path_attuned; 1313 op->path_attuned |= change->path_attuned;
1468 op->path_repelled |= change->path_repelled; 1314 op->path_repelled |= change->path_repelled;
1469 op->path_denied |= change->path_denied; 1315 op->path_denied |= change->path_denied;
1499 CLEAR_FLAG (op, FLAG_ANIMATE); 1345 CLEAR_FLAG (op, FLAG_ANIMATE);
1500 /* so artifacts will join */ 1346 /* so artifacts will join */
1501 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1347 if (!QUERY_FLAG (op, FLAG_ALIVE))
1502 op->speed = 0.0; 1348 op->speed = 0.0;
1503 1349
1504 update_ob_speed (op); 1350 op->set_speed (op->speed);
1505 } 1351 }
1506 1352
1507 if (change->nrof) 1353 if (change->nrof)
1508 op->nrof = RANDOM () % ((int) change->nrof) + 1; 1354 op->nrof = rndm (change->nrof) + 1;
1509 1355
1510 op->stats.exp += change->stats.exp; /* Speed modifier */ 1356 op->stats.exp += change->stats.exp; /* Speed modifier */
1511 op->stats.wc += change->stats.wc; 1357 op->stats.wc += change->stats.wc;
1512 op->stats.ac += change->stats.ac; 1358 op->stats.ac += change->stats.ac;
1513 1359
1517 * to cast. So convert that to into a spell and put it into 1363 * to cast. So convert that to into a spell and put it into
1518 * this object. 1364 * this object.
1519 */ 1365 */
1520 if (op->type == HORN || op->type == POTION) 1366 if (op->type == HORN || op->type == POTION)
1521 { 1367 {
1522 object *tmp_obj;
1523
1524 /* Remove any spells this object currently has in it */ 1368 /* Remove any spells this object currently has in it */
1525 while (op->inv)
1526 op->inv->destroy (); 1369 op->destroy_inv (false);
1527 1370
1528 tmp_obj = arch_to_object (change->other_arch); 1371 object *tmp = change->other_arch->instance ();
1529 insert_ob_in_ob (tmp_obj, op); 1372 insert_ob_in_ob (tmp, op);
1530 } 1373 }
1374
1531 /* No harm setting this for potions/horns */ 1375 /* No harm setting this for potions/horns */
1532 op->other_arch = change->other_arch; 1376 op->other_arch = change->other_arch;
1533 } 1377 }
1534 1378
1535 if (change->stats.hp < 0) 1379 if (change->stats.hp < 0)
1616 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100); 1460 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100);
1617 } 1461 }
1618 1462
1619 op->value *= change->value; 1463 op->value *= change->value;
1620 1464
1621 if (change->material) 1465 if (change->materials)
1466 op->materials = change->materials;
1467
1468 if (change->material != MATERIAL_NULL)
1622 op->material = change->material; 1469 op->material = change->material;
1623
1624 if (change->materialname)
1625 op->materialname = change->materialname;
1626 1470
1627 if (change->slaying) 1471 if (change->slaying)
1628 op->slaying = change->slaying; 1472 op->slaying = change->slaying;
1629 1473
1630 if (change->race) 1474 if (change->race)
1633 if (change->msg) 1477 if (change->msg)
1634 op->msg = change->msg; 1478 op->msg = change->msg;
1635} 1479}
1636 1480
1637static int 1481static int
1638legal_artifact_combination (object *op, artifact * art) 1482legal_artifact_combination (object *op, artifact *art)
1639{ 1483{
1640 int neg, success = 0; 1484 int neg, success = 0;
1641 linked_char *tmp; 1485 linked_char *tmp;
1642 const char *name; 1486 const char *name;
1643 1487
1644 if (art->allowed == (linked_char *) NULL) 1488 if (!art->allowed)
1645 return 1; /* Ie, "all" */ 1489 return 1; /* Ie, "all" */
1490
1646 for (tmp = art->allowed; tmp; tmp = tmp->next) 1491 for (tmp = art->allowed; tmp; tmp = tmp->next)
1647 { 1492 {
1648#ifdef TREASURE_VERBOSE 1493#ifdef TREASURE_VERBOSE
1649 LOG (llevDebug, "legal_art: %s\n", tmp->name); 1494 LOG (llevDebug, "legal_art: %s\n", &tmp->name);
1650#endif 1495#endif
1651 if (*tmp->name == '!') 1496 if (*tmp->name == '!')
1652 name = tmp->name + 1, neg = 1; 1497 name = tmp->name + 1, neg = 1;
1653 else 1498 else
1654 name = tmp->name, neg = 0; 1499 name = tmp->name, neg = 0;
1655 1500
1656 /* If we match name, then return the opposite of 'neg' */ 1501 /* If we match name, then return the opposite of 'neg' */
1657 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->name))) 1502 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->archname)))
1658 return !neg; 1503 return !neg;
1659 1504
1660 /* Set success as true, since if the match was an inverse, it means 1505 /* Set success as true, since if the match was an inverse, it means
1661 * everything is allowed except what we match 1506 * everything is allowed except what we match
1662 */ 1507 */
1663 else if (neg) 1508 else if (neg)
1664 success = 1; 1509 success = 1;
1665 } 1510 }
1511
1666 return success; 1512 return success;
1667} 1513}
1668 1514
1669/* 1515/*
1670 * Fixes the given object, giving it the abilities and titles 1516 * Fixes the given object, giving it the abilities and titles
1721 return; 1567 return;
1722 } 1568 }
1723 1569
1724 for (i = 0; i < ARTIFACT_TRIES; i++) 1570 for (i = 0; i < ARTIFACT_TRIES; i++)
1725 { 1571 {
1726 int roll = RANDOM () % al->total_chance; 1572 int roll = rndm (al->total_chance);
1727 1573
1728 for (art = al->items; art != NULL; art = art->next) 1574 for (art = al->items; art; art = art->next)
1729 { 1575 {
1730 roll -= art->chance; 1576 roll -= art->chance;
1731 if (roll < 0) 1577 if (roll < 0)
1732 break; 1578 break;
1733 } 1579 }
1737#if 1 1583#if 1
1738 LOG (llevError, "Got null entry and non zero roll in generate_artifact, type %d\n", op->type); 1584 LOG (llevError, "Got null entry and non zero roll in generate_artifact, type %d\n", op->type);
1739#endif 1585#endif
1740 return; 1586 return;
1741 } 1587 }
1742 if (!strcmp (art->item->name, "NONE")) 1588
1589 if (art->item->name == shstr_NONE)
1743 return; 1590 return;
1591
1744 if (FABS (op->magic) < art->item->magic) 1592 if (fabs (op->magic) < art->item->magic)
1745 continue; /* Not magic enough to be this item */ 1593 continue; /* Not magic enough to be this item */
1746 1594
1747 /* Map difficulty not high enough */ 1595 /* Map difficulty not high enough */
1748 if (difficulty < art->difficulty) 1596 if (difficulty < art->difficulty)
1749 continue; 1597 continue;
1750 1598
1751 if (!legal_artifact_combination (op, art)) 1599 if (!legal_artifact_combination (op, art))
1752 { 1600 {
1753#ifdef TREASURE_VERBOSE 1601#ifdef TREASURE_VERBOSE
1754 LOG (llevDebug, "%s of %s was not a legal combination.\n", op->name, art->item->name); 1602 LOG (llevDebug, "%s of %s was not a legal combination.\n", &op->name, &art->item->name);
1755#endif 1603#endif
1756 continue; 1604 continue;
1757 } 1605 }
1606
1758 give_artifact_abilities (op, art->item); 1607 give_artifact_abilities (op, art->item);
1759 return; 1608 return;
1760 } 1609 }
1761} 1610}
1762 1611
1799 item->level = donor->level; 1648 item->level = donor->level;
1800 1649
1801 /* if donor has some attacktypes, the flesh is poisonous */ 1650 /* if donor has some attacktypes, the flesh is poisonous */
1802 if (donor->attacktype & AT_POISON) 1651 if (donor->attacktype & AT_POISON)
1803 item->type = POISON; 1652 item->type = POISON;
1653
1804 if (donor->attacktype & AT_ACID) 1654 if (donor->attacktype & AT_ACID)
1805 item->stats.hp = -1 * item->stats.food; 1655 item->stats.hp = -1 * item->stats.food;
1656
1806 SET_FLAG (item, FLAG_NO_STEAL); 1657 SET_FLAG (item, FLAG_NO_STEAL);
1807 } 1658 }
1808} 1659}
1809 1660
1810/* special_potion() - so that old potion code is still done right. */ 1661static void
1811
1812int
1813special_potion (object *op)
1814{
1815
1816 int i;
1817
1818 if (op->attacktype)
1819 return 1;
1820
1821 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha)
1822 return 1;
1823
1824 for (i = 0; i < NROFATTACKS; i++)
1825 if (op->resist[i])
1826 return 1;
1827
1828 return 0;
1829}
1830
1831void
1832free_treasurestruct (treasure *t) 1662free_treasurestruct (treasure *t)
1833{ 1663{
1834 if (t->next)
1835 free_treasurestruct (t->next); 1664 if (t->next) free_treasurestruct (t->next);
1836 if (t->next_yes)
1837 free_treasurestruct (t->next_yes); 1665 if (t->next_yes) free_treasurestruct (t->next_yes);
1838 if (t->next_no)
1839 free_treasurestruct (t->next_no); 1666 if (t->next_no) free_treasurestruct (t->next_no);
1840 1667
1841 delete t; 1668 delete t;
1842} 1669}
1843 1670
1844void 1671static void
1845free_charlinks (linked_char *lc) 1672free_charlinks (linked_char *lc)
1846{ 1673{
1847 if (lc->next) 1674 if (lc->next)
1848 free_charlinks (lc->next); 1675 free_charlinks (lc->next);
1849 1676
1850 delete lc; 1677 delete lc;
1851} 1678}
1852 1679
1853void 1680static void
1854free_artifact (artifact * at) 1681free_artifact (artifact *at)
1855{ 1682{
1856 if (at->next)
1857 free_artifact (at->next); 1683 if (at->next) free_artifact (at->next);
1858
1859 if (at->allowed)
1860 free_charlinks (at->allowed); 1684 if (at->allowed) free_charlinks (at->allowed);
1861 1685
1862 at->item->destroy (1); 1686 at->item->destroy ();
1863 1687
1864 delete at;
1865}
1866
1867void
1868free_artifactlist (artifactlist * al)
1869{
1870 artifactlist *nextal;
1871
1872 for (al = first_artifactlist; al; al = nextal)
1873 {
1874 nextal = al->next;
1875
1876 if (al->items)
1877 free_artifact (al->items);
1878
1879 free (al); 1688 sfree (at);
1880 }
1881} 1689}
1882 1690
1883void
1884free_all_treasures (void)
1885{
1886 treasurelist *tl, *next;
1887
1888
1889 for (tl = first_treasurelist; tl != NULL; tl = next)
1890 {
1891 next = tl->next;
1892 if (tl->items)
1893 free_treasurestruct (tl->items);
1894 delete tl;
1895 }
1896 free_artifactlist (first_artifactlist);
1897}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines