ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/treasure.C
(Generate patch)

Comparing deliantra/server/common/treasure.C (file contents):
Revision 1.27 by root, Wed Dec 20 09:14:21 2006 UTC vs.
Revision 1.123 by root, Tue Nov 27 18:50:22 2018 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2017,2018 Marc Alexander Lehmann / the Deliantra team
5 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 6 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 7 * Copyright (©) 1992 Frank Tore Johansen
6 8 *
7 This program is free software; you can redistribute it and/or modify 9 * Deliantra is free software: you can redistribute it and/or modify it under
8 it under the terms of the GNU General Public License as published by 10 * the terms of the Affero GNU General Public License as published by the
9 the Free Software Foundation; either version 2 of the License, or 11 * Free Software Foundation, either version 3 of the License, or (at your
10 (at your option) any later version. 12 * option) any later version.
11 13 *
12 This program is distributed in the hope that it will be useful, 14 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 17 * GNU General Public License for more details.
16 18 *
17 You should have received a copy of the GNU General Public License 19 * You should have received a copy of the Affero GNU General Public License
18 along with this program; if not, write to the Free Software 20 * and the GNU General Public License along with this program. If not, see
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 21 * <http://www.gnu.org/licenses/>.
20 22 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 23 * The authors can be reached via e-mail to <support@deliantra.net>
22*/ 24 */
23
24#define ALLOWED_COMBINATION
25 25
26/* TREASURE_DEBUG does some checking on the treasurelists after loading. 26/* TREASURE_DEBUG does some checking on the treasurelists after loading.
27 * It is useful for finding bugs in the treasures file. Since it only 27 * It is useful for finding bugs in the treasures file. Since it only
28 * slows the startup some (and not actual game play), it is by default 28 * slows the startup some (and not actual game play), it is by default
29 * left on 29 * left on
30 */ 30 */
31#define TREASURE_DEBUG 31#define TREASURE_DEBUG
32 32
33/* TREASURE_VERBOSE enables copious output concerning artifact generation */ 33/* TREASURE_VERBOSE enables copious output concerning artifact generation */
34 34
35/* #define TREASURE_VERBOSE */ 35//#define TREASURE_VERBOSE
36 36
37#include <global.h> 37#include <global.h>
38#include <treasure.h> 38#include <treasure.h>
39#include <funcpoint.h>
40#include <loader.h>
41 39
40#include <flat_hash_map.hpp>
41
42// used only by treasure.C, does not handle null arch ptrs
43#define IS_ARCH(arch,name) ((arch)->archname == shstr_ ## name)
44
45extern char *spell_mapping[];
46
47static treasurelist *first_treasurelist;
42 48
43static void change_treasure (treasure *t, object *op); /* overrule default values */ 49static void change_treasure (treasure *t, object *op); /* overrule default values */
44extern char *spell_mapping[];
45 50
46/* 51typedef ska::flat_hash_map
47 * Initialize global archtype pointers: 52 <
48 */ 53 const char *,
54 treasurelist *,
55 str_hash,
56 str_equal,
57 slice_allocator< std::pair<const char *const, treasurelist *> >
58 > tl_map_t;
49 59
50void 60static tl_map_t tl_map;
51init_archetype_pointers ()
52{
53 int prev_warn = warn_archetypes;
54 61
55 warn_archetypes = 1; 62//TODO: class method
56 if (ring_arch == NULL) 63static void free_treasurestruct (treasure *t); // bleh desu
57 ring_arch = archetype::find ("ring"); 64static void
58 if (amulet_arch == NULL) 65clear (treasurelist *tl)
59 amulet_arch = archetype::find ("amulet"); 66{
60 if (staff_arch == NULL) 67 if (tl->items)
61 staff_arch = archetype::find ("staff"); 68 {
62 if (crown_arch == NULL) 69 free_treasurestruct (tl->items);
63 crown_arch = archetype::find ("crown"); 70 tl->items = 0;
64 warn_archetypes = prev_warn; 71 }
65}
66 72
67/* 73 tl->total_chance = 0;
68 * Allocate and return the pointer to an empty treasurelist structure. 74}
69 */
70 75
76/*
77 * Searches for the given treasurelist
78 */
71static treasurelist * 79treasurelist *
72get_empty_treasurelist (void) 80treasurelist::find (const char *name)
73{ 81{
82 if (!name)
83 return 0;
84
85 auto (i, tl_map.find (name));
86
87 if (i == tl_map.end ())
88 return 0;
89
90 return i->second;
91}
92
93/*
94 * Searches for the given treasurelist in the globally linked list
95 * of treasurelists which has been built by load_treasures().
96 */
97treasurelist *
98treasurelist::get (const char *name)
99{
100 treasurelist *tl = find (name);
101
102 if (!tl)
103 {
74 return new treasurelist; 104 tl = new treasurelist;
75}
76 105
77/* 106 tl->name = name;
78 * Allocate and return the pointer to an empty treasure structure. 107 tl->next = first_treasurelist;
79 */ 108 first_treasurelist = tl;
80//TODO: make this a constructor
81static treasure *
82get_empty_treasure (void)
83{
84 treasure *t = new treasure;
85 109
86 t->chance = 100; 110 tl_map.insert (std::make_pair (tl->name, tl));
111 }
87 112
88 return t; 113 return tl;
89} 114}
115
116#ifdef TREASURE_DEBUG
117/* recursived checks the linked list. Treasurelist is passed only
118 * so that the treasure name can be printed out
119 */
120static void
121check_treasurelist (const treasure *t, const treasurelist * tl)
122{
123 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
124 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
125
126 if (t->next)
127 check_treasurelist (t->next, tl);
128
129 if (t->next_yes)
130 check_treasurelist (t->next_yes, tl);
131
132 if (t->next_no)
133 check_treasurelist (t->next_no, tl);
134}
135#endif
90 136
91/* 137/*
92 * Reads the lib/treasure file from disk, and parses the contents 138 * Reads the lib/treasure file from disk, and parses the contents
93 * into an internal treasure structure (very linked lists) 139 * into an internal treasure structure (very linked lists)
94 */ 140 */
95
96static treasure * 141static treasure *
97load_treasure (FILE * fp, int *line) 142read_treasure (object_thawer &f)
98{ 143{
99 char buf[MAX_BUF], *cp, variable[MAX_BUF];
100 treasure *t = get_empty_treasure (); 144 treasure *t = new treasure;
101 int value;
102 145
103 nroftreasures++; 146 f.next ();
104 while (fgets (buf, MAX_BUF, fp) != NULL)
105 {
106 (*line)++;
107 147
108 if (*buf == '#') 148 for (;;)
109 continue; 149 {
110 if ((cp = strchr (buf, '\n')) != NULL) 150 coroapi::cede_to_tick ();
111 *cp = '\0';
112 cp = buf;
113 while (isspace (*cp)) /* Skip blanks */
114 cp++;
115 151
116 if (sscanf (cp, "arch %s", variable)) 152 switch (f.kw)
117 {
118 if ((t->item = archetype::find (variable)) == NULL)
119 LOG (llevError, "Treasure lacks archetype: %s\n", variable);
120 } 153 {
121 else if (sscanf (cp, "list %s", variable)) 154 case KW_arch:
122 t->name = variable; 155 t->item = archetype::find (f.get_str ());
123 else if (sscanf (cp, "change_name %s", variable)) 156
124 t->change_arch.name = variable; 157 if (!t->item)
125 else if (sscanf (cp, "change_title %s", variable))
126 t->change_arch.title = variable;
127 else if (sscanf (cp, "change_slaying %s", variable))
128 t->change_arch.slaying = variable;
129 else if (sscanf (cp, "chance %d", &value))
130 t->chance = (uint8) value;
131 else if (sscanf (cp, "nrof %d", &value))
132 t->nrof = (uint16) value;
133 else if (sscanf (cp, "magic %d", &value))
134 t->magic = (uint8) value;
135 else if (!strcmp (cp, "yes"))
136 t->next_yes = load_treasure (fp, line);
137 else if (!strcmp (cp, "no"))
138 t->next_no = load_treasure (fp, line);
139 else if (!strcmp (cp, "end"))
140 return t;
141 else if (!strcmp (cp, "more"))
142 { 158 {
143 t->next = load_treasure (fp, line); 159 f.parse_warn ("treasure references unknown archetype");
160 t->item = archetype::empty;
161 }
162
163 break;
164
165 case KW_list: f.get (t->name); break;
166 case KW_change_name: f.get (t->change_arch.name); break;
167 case KW_change_title: f.get (t->change_arch.title); break;
168 case KW_change_slaying: f.get (t->change_arch.slaying); break;
169 case KW_chance: f.get (t->chance); break;
170 case KW_nrof: f.get (t->nrof); break;
171 case KW_magic: f.get (t->magic); break;
172
173 case KW_yes: t->next_yes = read_treasure (f); continue;
174 case KW_no: t->next_no = read_treasure (f); continue;
175
176 case KW_end:
177 f.next ();
144 return t; 178 return t;
179
180 case KW_more:
181 t->next = read_treasure (f);
182 return t;
183
184 default:
185 if (!f.parse_error ("treasurelist", t->name))
186 goto error;
187
188 return t;
145 } 189 }
146 else 190
147 LOG (llevError, "Unknown treasure-command: '%s', last entry %s, line %d\n", cp, &t->name, *line); 191 f.next ();
148 } 192 }
149 LOG (llevError, "treasure lacks 'end'.\n"); 193
194 // not reached
195
196error:
197 delete t;
150 return t; 198 return 0;
151} 199}
152 200
153#ifdef TREASURE_DEBUG
154
155/* recursived checks the linked list. Treasurelist is passed only
156 * so that the treasure name can be printed out
157 */
158static void
159check_treasurelist (const treasure *t, const treasurelist * tl)
160{
161 if (t->item == NULL && t->name == NULL)
162 LOG (llevError, "Treasurelist %s has element with no name or archetype\n", &tl->name);
163 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
164 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
165 /* find_treasurelist will print out its own error message */
166 if (t->name && *t->name)
167 (void) find_treasurelist (t->name);
168 if (t->next)
169 check_treasurelist (t->next, tl);
170 if (t->next_yes)
171 check_treasurelist (t->next_yes, tl);
172 if (t->next_no)
173 check_treasurelist (t->next_no, tl);
174}
175#endif
176
177/* 201/*
178 * Opens LIBDIR/treasure and reads all treasure-declarations from it.
179 * Each treasure is parsed with the help of load_treasure(). 202 * Each treasure is parsed with the help of load_treasure().
180 */ 203 */
181 204treasurelist *
182void 205treasurelist::read (object_thawer &f)
183load_treasures (void)
184{ 206{
185 FILE *fp; 207 assert (f.kw == KW_treasure || f.kw == KW_treasureone);
186 char filename[MAX_BUF], buf[MAX_BUF], name[MAX_BUF];
187 treasurelist *previous = NULL;
188 treasure *t;
189 int comp, line = 0;
190 208
191 sprintf (filename, "%s/%s", settings.datadir, settings.treasures); 209 bool one = f.kw == KW_treasureone;
192 if ((fp = open_and_uncompress (filename, 0, &comp)) == NULL) 210 treasurelist *tl = treasurelist::get (f.get_str ());
193 { 211 clear (tl);
194 LOG (llevError, "Can't open treasure file.\n"); 212 tl->items = read_treasure (f);
213 if (!tl->items)
195 return; 214 return 0;
196 }
197 while (fgets (buf, MAX_BUF, fp) != NULL)
198 {
199 line++;
200 if (*buf == '#')
201 continue;
202 215
203 if (sscanf (buf, "treasureone %s\n", name) || sscanf (buf, "treasure %s\n", name))
204 {
205 treasurelist *tl = get_empty_treasurelist ();
206
207 tl->name = name;
208 if (previous == NULL)
209 first_treasurelist = tl;
210 else
211 previous->next = tl;
212 previous = tl;
213 tl->items = load_treasure (fp, &line);
214
215 /* This is a one of the many items on the list should be generated. 216 /* This is a one of the many items on the list should be generated.
216 * Add up the chance total, and check to make sure the yes & no 217 * Add up the chance total, and check to make sure the yes & no
217 * fields of the treasures are not being used. 218 * fields of the treasures are not being used.
218 */ 219 */
219 if (!strncmp (buf, "treasureone", 11)) 220 if (one)
221 {
222 for (treasure *t = tl->items; t; t = t->next)
223 {
224 if (t->next_yes || t->next_no)
220 { 225 {
221 for (t = tl->items; t != NULL; t = t->next)
222 {
223#ifdef TREASURE_DEBUG
224 if (t->next_yes || t->next_no)
225 {
226 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->name : &t->name); 226 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->archname : &t->name);
227 LOG (llevError, " the next_yes or next_no field is set\n"); 227 LOG (llevError, " the next_yes or next_no field is set\n");
228 }
229#endif
230 tl->total_chance += t->chance;
231 }
232 } 228 }
233 }
234 else
235 LOG (llevError, "Treasure-list %s didn't understand: %s, line %d\n", filename, buf, line);
236 }
237 close_and_delete (fp, comp);
238 229
239#ifdef TREASURE_DEBUG 230 tl->total_chance += t->chance;
240 /* Perform some checks on how valid the treasure data actually is. 231 }
241 * verify that list transitions work (ie, the list that it is supposed 232 }
242 * to transition to exists). Also, verify that at least the name
243 * or archetype is set for each treasure element.
244 */
245 for (previous = first_treasurelist; previous != NULL; previous = previous->next)
246 check_treasurelist (previous->items, previous);
247#endif
248}
249 233
250/*
251 * Searches for the given treasurelist in the globally linked list
252 * of treasurelists which has been built by load_treasures().
253 */
254
255treasurelist *
256find_treasurelist (const char *name)
257{
258 shstr_cmp name_ (name);
259
260 if (!name_)
261 return 0;
262
263 for (treasurelist *tl = first_treasurelist; tl != 0; tl = tl->next)
264 if (name_ == tl->name)
265 return tl;
266
267 if (first_treasurelist)
268 LOG (llevError, "Couldn't find treasurelist %s\n", name);
269
270 return 0; 234 return tl;
271} 235}
272
273 236
274/* 237/*
275 * Generates the objects specified by the given treasure. 238 * Generates the objects specified by the given treasure.
276 * It goes recursively through the rest of the linked list. 239 * It goes recursively through the rest of the linked list.
277 * If there is a certain percental chance for a treasure to be generated, 240 * If there is a certain percental chance for a treasure to be generated,
283 * start with equipment, but only their abilities). 246 * start with equipment, but only their abilities).
284 */ 247 */
285static void 248static void
286put_treasure (object *op, object *creator, int flags) 249put_treasure (object *op, object *creator, int flags)
287{ 250{
288 object *tmp; 251 if (flags & GT_ENVIRONMENT)
289 252 {
290 /* Bit of a hack - spells should never be put onto the map. The entire 253 /* Bit of a hack - spells should never be put onto the map. The entire
291 * treasure stuff is a problem - there is no clear idea of knowing 254 * treasure stuff is a problem - there is no clear idea of knowing
292 * this is the original object, or if this is an object that should be created 255 * this is the original object, or if this is an object that should be created
293 * by another object. 256 * by another object.
294 */ 257 */
295 if (flags & GT_ENVIRONMENT && op->type != SPELL) 258 //TODO: flag such as objects... as such (no drop, anybody?)
296 { 259 if (op->type == SPELL)
297 op->x = creator->x; 260 {
298 op->y = creator->y; 261 op->destroy ();
299 SET_FLAG (op, FLAG_OBJ_ORIGINAL); 262 return;
263 }
264
265 op->expand_tail ();
266
267 if (!creator->is_on_map ()
268 || (op->weight && op->blocked (creator->map, creator->x, creator->y)))
269 op->destroy ();
270 else
271 {
272 op->flag [FLAG_OBJ_ORIGINAL] = true;
300 insert_ob_in_map (op, creator->map, op, INS_NO_MERGE | INS_NO_WALK_ON); 273 op->insert_at (creator, creator, INS_NO_MERGE | INS_NO_WALK_ON);
274 }
301 } 275 }
302 else 276 else
303 { 277 {
304 op = insert_ob_in_ob (op, creator); 278 op = creator->insert (op);
305 279
306 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER)) 280 if ((flags & GT_APPLY) && creator->flag [FLAG_MONSTER])
307 monster_check_apply (creator, op); 281 monster_check_apply (creator, op);
308
309 if ((flags & GT_UPDATE_INV) && (tmp = creator->in_player ()))
310 esrv_send_item (tmp, op);
311 } 282 }
312} 283}
313 284
314/* if there are change_xxx commands in the treasure, we include the changes 285/* if there are change_xxx commands in the treasure, we include the changes
315 * in the generated object 286 * in the generated object
329 300
330 if (t->change_arch.slaying) 301 if (t->change_arch.slaying)
331 op->slaying = t->change_arch.slaying; 302 op->slaying = t->change_arch.slaying;
332} 303}
333 304
334void 305static void
335create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries) 306create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries)
336{ 307{
337 object *tmp;
338
339 if ((int) t->chance >= 100 || (RANDOM () % 100 + 1) < (int) t->chance) 308 if ((int) t->chance >= 100 || (rndm (100) + 1) < (int) t->chance)
340 { 309 {
341 if (t->name) 310 if (t->name)
342 { 311 {
343 if (strcmp (t->name, "NONE") && difficulty >= t->magic) 312 if (difficulty >= t->magic)
313 if (treasurelist *tl = treasurelist::find (t->name))
314 create_treasure (tl, op, flag, difficulty, tries);
315 else
316 LOG (llevError, "create_all_treasures: undefined reference to treasurelist '%s'.\n", &t->name);
317 }
318 else
319 {
320 if (t->item && (t->item->invisible != 0 || !(flag & GT_INVISIBLE)))
344 { 321 {
345 treasurelist *tl = find_treasurelist (t->name); 322 object *tmp = t->item->instance ();
346 if (tl) 323
347 create_treasure (tl, op, flag, difficulty, tries);
348 }
349 }
350 else
351 {
352 if (t->item->clone.invisible != 0 || !(flag & GT_INVISIBLE))
353 {
354 tmp = arch_to_object (t->item);
355 if (t->nrof && tmp->nrof <= 1) 324 if (t->nrof && tmp->nrof <= 1)
356 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 325 tmp->nrof = rndm (t->nrof) + 1;
326
357 fix_generated_item (tmp, op, difficulty, t->magic, flag); 327 fix_generated_item (tmp, op, difficulty, t->magic, flag);
358 change_treasure (t, tmp); 328 change_treasure (t, tmp);
359 put_treasure (tmp, op, flag); 329 put_treasure (tmp, op, flag);
360 } 330 }
361 } 331 }
362 332
363 if (t->next_yes != NULL) 333 if (t->next_yes)
364 create_all_treasures (t->next_yes, op, flag, difficulty, tries); 334 create_all_treasures (t->next_yes, op, flag, difficulty, tries);
365 } 335 }
366 else if (t->next_no != NULL) 336 else if (t->next_no)
367 create_all_treasures (t->next_no, op, flag, difficulty, tries); 337 create_all_treasures (t->next_no, op, flag, difficulty, tries);
368 338
369 if (t->next != NULL) 339 if (t->next)
370 create_all_treasures (t->next, op, flag, difficulty, tries); 340 create_all_treasures (t->next, op, flag, difficulty, tries);
371} 341}
372 342
373void 343static void
374create_one_treasure (treasurelist * tl, object *op, int flag, int difficulty, int tries) 344create_one_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
375{ 345{
376 int value = RANDOM () % tl->total_chance; 346 int value = rndm (tl->total_chance);
377 treasure *t; 347 treasure *t;
378 348
379 if (tries++ > 100) 349 if (tries++ > 100)
380 { 350 {
381 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n"); 351 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n");
382 return; 352 return;
383 } 353 }
384 354
385 for (t = tl->items; t != NULL; t = t->next) 355 for (t = tl->items; t; t = t->next)
386 { 356 {
387 value -= t->chance; 357 value -= t->chance;
388 358
389 if (value < 0) 359 if (value < 0)
390 break; 360 break;
391 } 361 }
392 362
393 if (!t || value >= 0) 363 if (!t || value >= 0)
394 {
395 LOG (llevError, "create_one_treasure: got null object or not able to find treasure\n"); 364 cleanup ("create_one_treasure: got null object or not able to find treasure\n", 1);
396 abort ();
397 return;
398 }
399 365
400 if (t->name) 366 if (t->name)
401 { 367 {
402 if (!strcmp (t->name, "NONE"))
403 return;
404
405 if (difficulty >= t->magic) 368 if (difficulty >= t->magic)
406 { 369 {
407 treasurelist *tl = find_treasurelist (t->name); 370 treasurelist *tl = treasurelist::find (t->name);
408 if (tl) 371 if (tl)
409 create_treasure (tl, op, flag, difficulty, tries); 372 create_treasure (tl, op, flag, difficulty, tries);
410 } 373 }
411 else if (t->nrof) 374 else if (t->nrof)
412 create_one_treasure (tl, op, flag, difficulty, tries); 375 create_one_treasure (tl, op, flag, difficulty, tries);
413
414 return;
415 } 376 }
416
417 if ((t->item && t->item->clone.invisible != 0) || flag != GT_INVISIBLE) 377 else if (t->item && (t->item->invisible != 0 || flag != GT_INVISIBLE))
418 { 378 {
419 object *tmp = arch_to_object (t->item); 379 if (object *tmp = t->item->instance ())
420 380 {
421 if (!tmp)
422 return;
423
424 if (t->nrof && tmp->nrof <= 1) 381 if (t->nrof && tmp->nrof <= 1)
425 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 382 tmp->nrof = rndm (t->nrof) + 1;
426 383
427 fix_generated_item (tmp, op, difficulty, t->magic, flag); 384 fix_generated_item (tmp, op, difficulty, t->magic, flag);
428 change_treasure (t, tmp); 385 change_treasure (t, tmp);
429 put_treasure (tmp, op, flag); 386 put_treasure (tmp, op, flag);
387 }
430 } 388 }
389}
390
391void
392object::create_treasure (treasurelist *tl, int flags)
393{
394 ::create_treasure (tl, this, flags, map ? map->difficulty : 0);
431} 395}
432 396
433/* This calls the appropriate treasure creation function. tries is passed 397/* This calls the appropriate treasure creation function. tries is passed
434 * to determine how many list transitions or attempts to create treasure 398 * to determine how many list transitions or attempts to create treasure
435 * have been made. It is really in place to prevent infinite loops with 399 * have been made. It is really in place to prevent infinite loops with
436 * list transitions, or so that excessively good treasure will not be 400 * list transitions, or so that excessively good treasure will not be
437 * created on weak maps, because it will exceed the number of allowed tries 401 * created on weak maps, because it will exceed the number of allowed tries
438 * to do that. 402 * to do that.
439 */ 403 */
440void 404void
441create_treasure (treasurelist * t, object *op, int flag, int difficulty, int tries) 405create_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
442{ 406{
407 // empty treasurelists are legal
408 if (!tl->items)
409 return;
443 410
444 if (tries++ > 100) 411 if (tries++ > 100)
445 { 412 {
446 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n"); 413 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n");
447 return; 414 return;
448 } 415 }
416
417 if (op->flag [FLAG_TREASURE_ENV])
418 {
419 // do not generate items when there already is something above the object
420 if (op->flag [FLAG_IS_FLOOR] && op->above)
421 return;
422
423 flag |= GT_ENVIRONMENT;
424 }
425
449 if (t->total_chance) 426 if (tl->total_chance)
450 create_one_treasure (t, op, flag, difficulty, tries); 427 create_one_treasure (tl, op, flag, difficulty, tries);
451 else 428 else
452 create_all_treasures (t->items, op, flag, difficulty, tries); 429 create_all_treasures (tl->items, op, flag, difficulty, tries);
453} 430}
454 431
455/* This is similar to the old generate treasure function. However, 432/* This is similar to the old generate treasure function. However,
456 * it instead takes a treasurelist. It is really just a wrapper around 433 * it instead takes a treasurelist. It is really just a wrapper around
457 * create_treasure. We create a dummy object that the treasure gets 434 * create_treasure. We create a dummy object that the treasure gets
458 * inserted into, and then return that treausre 435 * inserted into, and then return that treausre
459 */ 436 */
460object * 437object *
461generate_treasure (treasurelist *t, int difficulty) 438generate_treasure (treasurelist *tl, int difficulty)
462{ 439{
463 difficulty = clamp (difficulty, 1, settings.max_level); 440 difficulty = clamp (difficulty, 1, settings.max_level);
464 441
465 object *ob = object::create (), *tmp; 442 object *ob = object::create ();
466 443
467 create_treasure (t, ob, 0, difficulty, 0); 444 create_treasure (tl, ob, 0, difficulty, 0);
468 445
469 /* Don't want to free the object we are about to return */ 446 /* Don't want to free the object we are about to return */
470 tmp = ob->inv; 447 object *tmp = ob->inv;
471 if (tmp != NULL) 448 if (tmp)
472 tmp->remove (); 449 tmp->remove ();
473 450
474 if (ob->inv) 451 if (ob->inv)
475 LOG (llevError, "In generate treasure, created multiple objects.\n"); 452 LOG (llevError, "In generate treasure, created multiple objects.\n");
476 453
477 ob->destroy (); 454 ob->destroy ();
455
478 return tmp; 456 return tmp;
479} 457}
480 458
481/* 459/*
482 * This is a new way of calculating the chance for an item to have 460 * This is a new way of calculating the chance for an item to have
484 * The array has two arguments, the difficulty of the level, and the 462 * The array has two arguments, the difficulty of the level, and the
485 * magical bonus "wanted". 463 * magical bonus "wanted".
486 */ 464 */
487 465
488static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = { 466static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = {
489
490/*chance of magic difficulty*/ 467// chance of magic difficulty
491
492/* +0 +1 +2 +3 +4 */ 468// +0 +1 +2 +3 +4
493 {95, 2, 2, 1, 0}, /*1 */ 469 {95, 2, 2, 1, 0}, // 1
494 {92, 5, 2, 1, 0}, /*2 */ 470 {92, 5, 2, 1, 0}, // 2
495 {85, 10, 4, 1, 0}, /*3 */ 471 {85, 10, 4, 1, 0}, // 3
496 {80, 14, 4, 2, 0}, /*4 */ 472 {80, 14, 4, 2, 0}, // 4
497 {75, 17, 5, 2, 1}, /*5 */ 473 {75, 17, 5, 2, 1}, // 5
498 {70, 18, 8, 3, 1}, /*6 */ 474 {70, 18, 8, 3, 1}, // 6
499 {65, 21, 10, 3, 1}, /*7 */ 475 {65, 21, 10, 3, 1}, // 7
500 {60, 22, 12, 4, 2}, /*8 */ 476 {60, 22, 12, 4, 2}, // 8
501 {55, 25, 14, 4, 2}, /*9 */ 477 {55, 25, 14, 4, 2}, // 9
502 {50, 27, 16, 5, 2}, /*10 */ 478 {50, 27, 16, 5, 2}, // 10
503 {45, 28, 18, 6, 3}, /*11 */ 479 {45, 28, 18, 6, 3}, // 11
504 {42, 28, 20, 7, 3}, /*12 */ 480 {42, 28, 20, 7, 3}, // 12
505 {40, 27, 21, 8, 4}, /*13 */ 481 {40, 27, 21, 8, 4}, // 13
506 {38, 25, 22, 10, 5}, /*14 */ 482 {38, 25, 22, 10, 5}, // 14
507 {36, 23, 23, 12, 6}, /*15 */ 483 {36, 23, 23, 12, 6}, // 15
508 {33, 21, 24, 14, 8}, /*16 */ 484 {33, 21, 24, 14, 8}, // 16
509 {31, 19, 25, 16, 9}, /*17 */ 485 {31, 19, 25, 16, 9}, // 17
510 {27, 15, 30, 18, 10}, /*18 */ 486 {27, 15, 30, 18, 10}, // 18
511 {20, 12, 30, 25, 13}, /*19 */ 487 {20, 12, 30, 25, 13}, // 19
512 {15, 10, 28, 30, 17}, /*20 */ 488 {15, 10, 28, 30, 17}, // 20
513 {13, 9, 27, 28, 23}, /*21 */ 489 {13, 9, 27, 28, 23}, // 21
514 {10, 8, 25, 28, 29}, /*22 */ 490 {10, 8, 25, 28, 29}, // 22
515 {8, 7, 23, 26, 36}, /*23 */ 491 { 8, 7, 23, 26, 36}, // 23
516 {6, 6, 20, 22, 46}, /*24 */ 492 { 6, 6, 20, 22, 46}, // 24
517 {4, 5, 17, 18, 56}, /*25 */ 493 { 4, 5, 17, 18, 56}, // 25
518 {2, 4, 12, 14, 68}, /*26 */ 494 { 2, 4, 12, 14, 68}, // 26
519 {0, 3, 7, 10, 80}, /*27 */ 495 { 0, 3, 7, 10, 80}, // 27
520 {0, 0, 3, 7, 90}, /*28 */ 496 { 0, 0, 3, 7, 90}, // 28
521 {0, 0, 0, 3, 97}, /*29 */ 497 { 0, 0, 0, 3, 97}, // 29
522 {0, 0, 0, 0, 100}, /*30 */ 498 { 0, 0, 0, 0, 100}, // 30
523 {0, 0, 0, 0, 100}, /*31 */ 499 { 0, 0, 0, 0, 100}, // 31
524}; 500};
525 501
526
527/* calculate the appropriate level for wands staves and scrolls. 502/* calculate the appropriate level for wands staves and scrolls.
528 * This code presumes that op has had its spell object created (in op->inv) 503 * This code presumes that op has had its spell object created (in op->inv)
529 * 504 *
530 * elmex Wed Aug 9 17:44:59 CEST 2006: 505 * elmex Wed Aug 9 17:44:59 CEST 2006:
531 * Removed multiplicator, too many high-level items were generated on low-difficulty maps. 506 * Removed multiplicator, too many high-level items were generated on low-difficulty maps.
532 */ 507 */
533 508static int
534int
535level_for_item (const object *op, int difficulty) 509level_for_item (const object *op, int difficulty)
536{ 510{
537 int olevel = 0;
538
539 if (!op->inv) 511 if (!op->inv)
540 { 512 {
541 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name); 513 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name);
542 return 0; 514 return 0;
543 } 515 }
544 516
545 olevel = (int) (op->inv->level + (double) difficulty * (1 - drand48 () * drand48 () * 2)); 517 int olevel = op->inv->level + int (difficulty * (1. - rndm () * rndm () * 2.));
546 518
547 if (olevel <= 0) 519 if (olevel <= 0)
548 olevel = rndm (1, MIN (op->inv->level, 1)); 520 olevel = rndm (1, op->inv->level);
549 521
550 if (olevel > MAXLEVEL) 522 return min (olevel, MAXLEVEL_TREASURE);
551 olevel = MAXLEVEL;
552
553 return olevel;
554} 523}
555 524
556/* 525/*
557 * Based upon the specified difficulty and upon the difftomagic_list array, 526 * Based upon the specified difficulty and upon the difftomagic_list array,
558 * a random magical bonus is returned. This is used when determine 527 * a random magical bonus is returned. This is used when determine
561 * elmex Thu Aug 10 18:45:44 CEST 2006: 530 * elmex Thu Aug 10 18:45:44 CEST 2006:
562 * Scaling difficulty by max_level, as difficulty is a level and not some 531 * Scaling difficulty by max_level, as difficulty is a level and not some
563 * weird integer between 1-31. 532 * weird integer between 1-31.
564 * 533 *
565 */ 534 */
566 535static int
567int
568magic_from_difficulty (int difficulty) 536magic_from_difficulty (int difficulty)
569{ 537{
570 int percent = 0, magic = 0;
571 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS); 538 int scaled_diff = lerp (difficulty, 0, settings.max_level, 0, DIFFLEVELS - 1);
539 scaled_diff = clamp (scaled_diff, 0, DIFFLEVELS - 1);
572 540
573 scaled_diff--; 541 int percent = rndm (100);
542 int magic;
574 543
575 if (scaled_diff < 0)
576 scaled_diff = 0;
577
578 if (scaled_diff >= DIFFLEVELS)
579 scaled_diff = DIFFLEVELS - 1;
580
581 percent = RANDOM () % 100;
582
583 for (magic = 0; magic < (MAXMAGIC + 1); magic++) 544 for (magic = 0; magic <= MAXMAGIC; magic++)
584 { 545 {
585 percent -= difftomagic_list[scaled_diff][magic]; 546 percent -= difftomagic_list[scaled_diff][magic];
586 547
587 if (percent < 0) 548 if (percent < 0)
588 break; 549 break;
589 } 550 }
590 551
591 if (magic == (MAXMAGIC + 1)) 552 if (magic > MAXMAGIC)
592 { 553 {
593 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty); 554 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty);
594 magic = 0; 555 magic = 0;
595 } 556 }
596 557
597 magic = (RANDOM () % 3) ? magic : -magic; 558 magic = (rndm (3)) ? magic : -magic;
598 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */ 559 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */
599 560
600 return magic; 561 return magic;
601} 562}
602 563
604 * Sets magical bonus in an object, and recalculates the effect on 565 * Sets magical bonus in an object, and recalculates the effect on
605 * the armour variable, and the effect on speed of armour. 566 * the armour variable, and the effect on speed of armour.
606 * This function doesn't work properly, should add use of archetypes 567 * This function doesn't work properly, should add use of archetypes
607 * to make it truly absolute. 568 * to make it truly absolute.
608 */ 569 */
609
610void 570void
611set_abs_magic (object *op, int magic) 571set_abs_magic (object *op, int magic)
612{ 572{
613 if (!magic) 573 if (!magic)
614 return; 574 return;
615 575
616 op->magic = magic; 576 op->magic = magic;
617 if (op->arch) 577 if (op->arch)
618 { 578 {
619 if (op->type == ARMOUR) 579 if (op->type == ARMOUR)
620 ARMOUR_SPEED (op) = (ARMOUR_SPEED (&op->arch->clone) * (100 + magic * 10)) / 100; 580 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op->arch) * (100 + magic * 10)) / 100;
621 581
622 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 582 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
623 magic = (-magic); 583 magic = (-magic);
584
624 op->weight = (op->arch->clone.weight * (100 - magic * 10)) / 100; 585 op->weight = (op->arch->weight * (100 - magic * 10)) / 100;
625 } 586 }
626 else 587 else
627 { 588 {
628 if (op->type == ARMOUR) 589 if (op->type == ARMOUR)
629 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100; 590 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100;
591
630 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 592 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
631 magic = (-magic); 593 magic = (-magic);
594
632 op->weight = (op->weight * (100 - magic * 10)) / 100; 595 op->weight = (op->weight * (100 - magic * 10)) / 100;
633 } 596 }
634} 597}
635 598
636/* 599/*
639 */ 602 */
640 603
641static void 604static void
642set_magic (int difficulty, object *op, int max_magic, int flags) 605set_magic (int difficulty, object *op, int max_magic, int flags)
643{ 606{
644 int i;
645
646 i = magic_from_difficulty (difficulty); 607 int i = magic_from_difficulty (difficulty);
608
647 if ((flags & GT_ONLY_GOOD) && i < 0) 609 if ((flags & GT_ONLY_GOOD) && i < 0)
648 i = -i; 610 i = -i;
611
649 if (i > max_magic) 612 i = min (i, max_magic);
650 i = max_magic; 613
651 set_abs_magic (op, i); 614 set_abs_magic (op, i);
652 if (i < 0) 615 if (i < 0)
653 SET_FLAG (op, FLAG_CURSED); 616 op->set_flag (FLAG_CURSED);
654} 617}
655 618
656/* 619/*
657 * Randomly adds one magical ability to the given object. 620 * Randomly adds one magical ability to the given object.
658 * Modified for Partial Resistance in many ways: 621 * Modified for Partial Resistance in many ways:
659 * 1) Since rings can have multiple bonuses, if the same bonus 622 * 1) Since rings can have multiple bonuses, if the same bonus
660 * is rolled again, increase it - the bonuses now stack with 623 * is rolled again, increase it - the bonuses now stack with
661 * other bonuses previously rolled and ones the item might natively have. 624 * other bonuses previously rolled and ones the item might natively have.
662 * 2) Add code to deal with new PR method. 625 * 2) Add code to deal with new PR method.
663 */ 626 */
664 627static void
665void
666set_ring_bonus (object *op, int bonus) 628set_ring_bonus (object *op, int bonus)
667{ 629{
668
669 int r = RANDOM () % (bonus > 0 ? 25 : 11); 630 int r = rndm (bonus > 0 ? 25 : 11);
670 631
671 if (op->type == AMULET) 632 if (op->type == AMULET)
672 { 633 if (!rndm (21))
673 if (!(RANDOM () % 21)) 634 r = 20 + rndm (2);
674 r = 20 + RANDOM () % 2; 635 else if (rndm (2))
636 r = 10;
675 else 637 else
676 { 638 r = 11 + rndm (9);
677 if (RANDOM () & 2)
678 r = 10;
679 else
680 r = 11 + RANDOM () % 9;
681 }
682 }
683 639
684 switch (r) 640 switch (r)
685 { 641 {
686 /* Redone by MSW 2000-11-26 to have much less code. Also, 642 /* Redone by MSW 2000-11-26 to have much less code. Also,
687 * bonuses and penalties will stack and add to existing values. 643 * bonuses and penalties will stack and add to existing values.
688 * of the item. 644 * of the item.
689 */ 645 */
690 case 0: 646 case 0:
691 case 1: 647 case 1:
692 case 2: 648 case 2:
693 case 3: 649 case 3:
694 case 4: 650 case 4:
695 case 5: 651 case 5:
696 case 6: 652 case 6:
697 set_attr_value (&op->stats, r, (signed char) (bonus + get_attr_value (&op->stats, r))); 653 op->stats.stat (r) += bonus;
698 break; 654 break;
699 655
700 case 7: 656 case 7:
701 op->stats.dam += bonus; 657 op->stats.dam += bonus;
702 break; 658 break;
722 case 16: 678 case 16:
723 case 17: 679 case 17:
724 case 18: 680 case 18:
725 case 19: 681 case 19:
726 { 682 {
727 int b = 5 + FABS (bonus), val, resist = RANDOM () % num_resist_table; 683 int b = 5 + abs (bonus), val, resist = rndm (num_resist_table);
728 684
729 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */ 685 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */
730 val = 10 + RANDOM () % b + RANDOM () % b + RANDOM () % b + RANDOM () % b; 686 val = 10 + rndm (b) + rndm (b) + rndm (b) + rndm (b);
731 687
732 /* Cursed items need to have higher negative values to equal out with 688 /* Cursed items need to have higher negative values to equal out with
733 * positive values for how protections work out. Put another 689 * positive values for how protections work out. Put another
734 * little random element in since that they don't always end up with 690 * little random element in since that they don't always end up with
735 * even values. 691 * even values.
736 */ 692 */
737 if (bonus < 0) 693 if (bonus < 0)
738 val = 2 * -val - RANDOM () % b; 694 val = 2 * -val - rndm (b);
739 if (val > 35) 695
740 val = 35; /* Upper limit */ 696 val = min (35, val); /* Upper limit */
697
741 b = 0; 698 b = 0;
699
742 while (op->resist[resist_table[resist]] != 0 && b < 4) 700 while (op->resist[resist_table[resist]] != 0 && b < 4)
743 {
744 resist = RANDOM () % num_resist_table; 701 resist = rndm (num_resist_table);
745 } 702
746 if (b == 4) 703 if (b == 4)
747 return; /* Not able to find a free resistance */ 704 return; /* Not able to find a free resistance */
705
748 op->resist[resist_table[resist]] = val; 706 op->resist[resist_table[resist]] = val;
749 /* We should probably do something more clever here to adjust value 707 /* We should probably do something more clever here to adjust value
750 * based on how good a resistance we gave. 708 * based on how good a resistance we gave.
751 */ 709 */
752 break; 710 break;
753 } 711 }
754 case 20: 712 case 20:
755 if (op->type == AMULET) 713 if (op->type == AMULET)
756 { 714 {
757 SET_FLAG (op, FLAG_REFL_SPELL); 715 op->set_flag (FLAG_REFL_SPELL);
758 op->value *= 11; 716 op->value *= 11;
759 } 717 }
760 else 718 else
761 { 719 {
762 op->stats.hp = 1; /* regenerate hit points */ 720 op->stats.hp = 1; /* regenerate hit points */
765 break; 723 break;
766 724
767 case 21: 725 case 21:
768 if (op->type == AMULET) 726 if (op->type == AMULET)
769 { 727 {
770 SET_FLAG (op, FLAG_REFL_MISSILE); 728 op->set_flag (FLAG_REFL_MISSILE);
771 op->value *= 9; 729 op->value *= 9;
772 } 730 }
773 else 731 else
774 { 732 {
775 op->stats.sp = 1; /* regenerate spell points */ 733 op->stats.sp = 1; /* regenerate spell points */
777 } 735 }
778 break; 736 break;
779 737
780 case 22: 738 case 22:
781 op->stats.exp += bonus; /* Speed! */ 739 op->stats.exp += bonus; /* Speed! */
782 op->value = (op->value * 2) / 3; 740 op->value = op->value * 2 / 3;
783 break; 741 break;
784 } 742 }
743
785 if (bonus > 0) 744 if (bonus > 0)
786 op->value *= 2 * bonus; 745 op->value = 2 * op->value * bonus;
787 else 746 else
788 op->value = -(op->value * 2 * bonus) / 3; 747 op->value = -2 * op->value * bonus / 3;
789} 748}
790 749
791/* 750/*
792 * get_magic(diff) will return a random number between 0 and 4. 751 * get_magic(diff) will return a random number between 0 and 4.
793 * diff can be any value above 2. The higher the diff-variable, the 752 * diff can be any value above 2. The higher the diff-variable, the
794 * higher is the chance of returning a low number. 753 * higher is the chance of returning a low number.
795 * It is only used in fix_generated_treasure() to set bonuses on 754 * It is only used in fix_generated_treasure() to set bonuses on
796 * rings and amulets. 755 * rings and amulets.
797 * Another scheme is used to calculate the magic of weapons and armours. 756 * Another scheme is used to calculate the magic of weapons and armours.
798 */ 757 */
799 758static int
800int
801get_magic (int diff) 759get_magic (int diff)
802{ 760{
803 int i; 761 diff = min (3, diff);
804 762
805 if (diff < 3)
806 diff = 3;
807 for (i = 0; i < 4; i++) 763 for (int i = 0; i < 4; i++)
808 if (RANDOM () % diff) 764 if (rndm (diff))
809 return i; 765 return i;
766
810 return 4; 767 return 4;
811} 768}
812 769
770/* special_potion() - so that old potion code is still done right. */
771static int
772special_potion (object *op)
773{
774 if (op->attacktype)
775 return 1;
776
777 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha)
778 return 1;
779
780 for (int i = 0; i < NROFATTACKS; i++)
781 if (op->resist[i])
782 return 1;
783
784 return 0;
785}
786
787static double
788value_factor_from_spell_item (object *spell, object *item)
789{
790 double factor =
791 pow ((spell->value > 0 ? spell->value : 1)
792 * spell->level, 1.5);
793
794 if (item) // this if for: wands/staffs/rods:
795 {
796 /* Old crossfire comment ahead:
797 * Add 50 to both level an divisor to keep prices a little more
798 * reasonable. Otherwise, a high level version of a low level
799 * spell can be worth tons a money (eg, level 20 rod, level 2 spell =
800 * 10 time multiplier). This way, the value are a bit more reasonable.
801 */
802
803 factor *= item->level + 50;
804 factor /= item->inv->level + 50;
805 }
806
807 return factor;
808}
809
813#define DICE2 (get_magic(2)==2?2:1) 810#define DICE2 (get_magic(2) == 2 ? 2 : 1)
814#define DICESPELL (RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3) 811#define DICESPELL (rndm (3) + rndm (3) + rndm (3) + rndm (3) + rndm (3))
815 812
816/* 813/*
817 * fix_generated_item(): This is called after an item is generated, in 814 * fix_generated_item(): This is called after an item is generated, in
818 * order to set it up right. This produced magical bonuses, puts spells 815 * order to set it up right. This produced magical bonuses, puts spells
819 * into scrolls/books/wands, makes it unidentified, hides the value, etc. 816 * into scrolls/books/wands, makes it unidentified, hides the value, etc.
820 */ 817 */
821 818
822/* 4/28/96 added creator object from which op may now inherit properties based on 819/* 4/28/96 added creator object from which op may now inherit properties based on
823 * op->type. Right now, which stuff the creator passes on is object type 820 * op->type. Right now, which stuff the creator passes on is object type
824 * dependant. I know this is a spagetti manuever, but is there a cleaner 821 * dependant. I know this is a spagetti manuever, but is there a cleaner
825 * way to do this? b.t. */ 822 * way to do this? b.t. */
826 823
827/* 824/*
828 * ! (flags & GT_ENVIRONMENT): 825 * ! (flags & GT_ENVIRONMENT):
829 * Automatically calls fix_flesh_item(). 826 * Automatically calls fix_flesh_item().
833 * value. 830 * value.
834 * GT_MINIMAL: Does minimal processing on the object - just enough to make it 831 * GT_MINIMAL: Does minimal processing on the object - just enough to make it
835 * a working object - don't change magic, value, etc, but set it material 832 * a working object - don't change magic, value, etc, but set it material
836 * type as appropriate, for objects that need spell objects, set those, etc 833 * type as appropriate, for objects that need spell objects, set those, etc
837 */ 834 */
838
839void 835void
840fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags) 836fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags)
841{ 837{
842 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0; 838 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0;
843 839
848 save_item_power = op->item_power; 844 save_item_power = op->item_power;
849 op->item_power = 0; 845 op->item_power = 0;
850 846
851 if (op->randomitems && op->type != SPELL) 847 if (op->randomitems && op->type != SPELL)
852 { 848 {
853 create_treasure (op->randomitems, op, flags, difficulty, 0); 849 create_treasure (op->randomitems, op, flags & ~GT_ENVIRONMENT, difficulty, 0);
854 if (!op->inv)
855 LOG (llevDebug, "fix_generated_item: Unable to generate treasure for %s\n", &op->name);
856
857 /* So the treasure doesn't get created again */ 850 /* So the treasure doesn't get created again */
858 op->randomitems = NULL; 851 op->randomitems = 0;
859 } 852 }
860 853
861 if (difficulty < 1) 854 max_it (difficulty, 1);
862 difficulty = 1;
863 855
864 if (INVOKE_OBJECT (ADD_BONUS, op, 856 if (INVOKE_OBJECT (ADD_BONUS, op,
865 ARG_OBJECT (creator != op ? creator : 0), 857 ARG_OBJECT (creator != op ? creator : 0),
866 ARG_INT (difficulty), ARG_INT (max_magic), 858 ARG_INT (difficulty), ARG_INT (max_magic),
867 ARG_INT (flags))) 859 ARG_INT (flags)))
868 return; 860 return;
869 861
870 if (!(flags & GT_MINIMAL)) 862 if (!(flags & GT_MINIMAL))
871 { 863 {
872 if (op->arch == crown_arch) 864 if (IS_ARCH (op->arch, crown))
873 { 865 {
874 set_magic (difficulty, op, max_magic, flags); 866 set_magic (difficulty, op, max_magic, flags);
875 num_enchantments = calc_item_power (op, 1); 867 num_enchantments = calc_item_power (op, 1);
876 generate_artifact (op, difficulty); 868 generate_artifact (op, difficulty);
877 } 869 }
880 if (!op->magic && max_magic) 872 if (!op->magic && max_magic)
881 set_magic (difficulty, op, max_magic, flags); 873 set_magic (difficulty, op, max_magic, flags);
882 874
883 num_enchantments = calc_item_power (op, 1); 875 num_enchantments = calc_item_power (op, 1);
884 876
885 if ((!was_magic && !(RANDOM () % CHANCE_FOR_ARTIFACT)) || op->type == HORN || difficulty >= settings.max_level) /* high difficulties always generate an artifact, 877 if ((!was_magic && !rndm (CHANCE_FOR_ARTIFACT))
886 * used for shop_floors or treasures */ 878 || op->type == HORN
879 || difficulty >= settings.max_level) /* high difficulties always generate an artifact, used for shop_floors or treasures */
887 generate_artifact (op, difficulty); 880 generate_artifact (op, difficulty);
888 } 881 }
889 882
890 /* Object was made an artifact. Calculate its item_power rating. 883 /* Object was made an artifact. Calculate its item_power rating.
891 * the item_power in the object is what the artfiact adds. 884 * the item_power in the object is what the artfiact adds.
925 * again below */ 918 * again below */
926 } 919 }
927 } 920 }
928 921
929 /* materialtype modifications. Note we allow this on artifacts. */ 922 /* materialtype modifications. Note we allow this on artifacts. */
930 set_materialname (op, difficulty, NULL); 923 select_material (op, difficulty);
931 924
932 if (flags & GT_MINIMAL) 925 if (flags & GT_MINIMAL)
933 { 926 {
934 if (op->type == POTION) 927 if (op->type == POTION)
935 /* Handle healing and magic power potions */ 928 /* Handle healing and magic power potions */
936 if (op->stats.sp && !op->randomitems) 929 if (op->stats.sp && !op->randomitems)
937 { 930 {
938 object *tmp;
939
940 tmp = get_archetype (spell_mapping[op->stats.sp]); 931 object *tmp = archetype::get (spell_mapping [op->stats.sp]);
941 insert_ob_in_ob (tmp, op); 932 insert_ob_in_ob (tmp, op);
942 op->stats.sp = 0; 933 op->stats.sp = 0;
943 } 934 }
944 } 935 }
945 else if (!op->title) /* Only modify object if not special */ 936 else if (!op->title) /* Only modify object if not special */
948 case WEAPON: 939 case WEAPON:
949 case ARMOUR: 940 case ARMOUR:
950 case SHIELD: 941 case SHIELD:
951 case HELMET: 942 case HELMET:
952 case CLOAK: 943 case CLOAK:
953 if (QUERY_FLAG (op, FLAG_CURSED) && !(RANDOM () % 4)) 944 if (op->flag [FLAG_CURSED] && !(rndm (4)))
954 set_ring_bonus (op, -DICE2); 945 set_ring_bonus (op, -DICE2);
955 break; 946 break;
956 947
957 case BRACERS: 948 case BRACERS:
958 if (!(RANDOM () % (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))) 949 if (!rndm (op->flag [FLAG_CURSED] ? 5 : 20))
959 { 950 {
960 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 951 set_ring_bonus (op, op->flag [FLAG_CURSED] ? -DICE2 : DICE2);
961 if (!QUERY_FLAG (op, FLAG_CURSED)) 952 if (!op->flag [FLAG_CURSED])
962 op->value *= 3; 953 op->value *= 3;
963 } 954 }
964 break; 955 break;
965 956
966 case POTION: 957 case POTION:
967 { 958 {
968 int too_many_tries = 0, is_special = 0; 959 int too_many_tries = 0;
969 960
970 /* Handle healing and magic power potions */ 961 /* Handle healing and magic power potions */
971 if (op->stats.sp && !op->randomitems) 962 if (op->stats.sp && !op->randomitems)
972 { 963 {
973 object *tmp;
974
975 tmp = get_archetype (spell_mapping[op->stats.sp]); 964 object *tmp = archetype::get (spell_mapping[op->stats.sp]);
976 insert_ob_in_ob (tmp, op); 965 insert_ob_in_ob (tmp, op);
977 op->stats.sp = 0; 966 op->stats.sp = 0;
978 } 967 }
979 968
980 while (!(is_special = special_potion (op)) && !op->inv) 969 while (!special_potion (op) && !op->inv)
981 { 970 {
982 generate_artifact (op, difficulty); 971 generate_artifact (op, difficulty);
983 if (too_many_tries++ > 10) 972 if (too_many_tries++ > 10)
984 break; 973 break;
985 } 974 }
988 * since the value set on those is already correct. 977 * since the value set on those is already correct.
989 */ 978 */
990 if (op->inv && op->randomitems) 979 if (op->inv && op->randomitems)
991 { 980 {
992 /* value multiplier is same as for scrolls */ 981 /* value multiplier is same as for scrolls */
993 op->value = (op->value * op->inv->value); 982 op->value *= op->inv->value;
994 op->level = op->inv->level / 2 + RANDOM () % difficulty + RANDOM () % difficulty; 983 op->level = op->inv->level / 2 + rndm (difficulty) + rndm (difficulty);
995 } 984 }
996 else 985 else
997 { 986 {
998 op->name = "potion"; 987 op->name = shstr_potion;
999 op->name_pl = "potions"; 988 op->name_pl = shstr_potions;
1000 } 989 }
1001 990
1002 if (!(flags & GT_ONLY_GOOD) && RANDOM () % 2) 991 if (!(flags & GT_ONLY_GOOD) && rndm (2))
1003 SET_FLAG (op, FLAG_CURSED); 992 op->set_flag (FLAG_CURSED);
993
1004 break; 994 break;
1005 } 995 }
1006 996
1007 case AMULET: 997 case AMULET:
1008 if (op->arch == amulet_arch) 998 if (IS_ARCH (op->arch, amulet))
1009 op->value *= 5; /* Since it's not just decoration */ 999 op->value *= 5; /* Since it's not just decoration */
1010 1000
1011 case RING: 1001 case RING:
1012 if (op->arch == NULL)
1013 {
1014 op->destroy ();
1015 op = 0;
1016 break;
1017 }
1018
1019 if (op->arch != ring_arch && op->arch != amulet_arch) /* It's a special artifact! */ 1002 if (!IS_ARCH (op->arch, ring) && !IS_ARCH (op->arch, amulet)) /* It's a special artifact! */
1020 break; 1003 break;
1021 1004
1022 if (!(flags & GT_ONLY_GOOD) && !(RANDOM () % 3)) 1005 if (!(flags & GT_ONLY_GOOD) && !(rndm (3)))
1023 SET_FLAG (op, FLAG_CURSED); 1006 op->set_flag (FLAG_CURSED);
1024 1007
1025 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 1008 set_ring_bonus (op, op->flag [FLAG_CURSED] ? -DICE2 : DICE2);
1026 1009
1027 if (op->type != RING) /* Amulets have only one ability */ 1010 if (op->type != RING) /* Amulets have only one ability */
1028 break; 1011 break;
1029 1012
1030 if (!(RANDOM () % 4)) 1013 if (!rndm (4))
1031 { 1014 {
1032 int d = (RANDOM () % 2 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 1015 int d = (rndm (2) || op->flag [FLAG_CURSED]) ? -DICE2 : DICE2;
1033 1016
1034 if (d > 0) 1017 if (d > 0)
1035 op->value *= 3; 1018 op->value *= 3;
1036 1019
1037 set_ring_bonus (op, d); 1020 set_ring_bonus (op, d);
1038 1021
1039 if (!(RANDOM () % 4)) 1022 if (!rndm (4))
1040 { 1023 {
1041 int d = (RANDOM () % 3 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 1024 int d = (rndm (3) || op->flag [FLAG_CURSED]) ? -DICE2 : DICE2;
1042 1025
1043 if (d > 0) 1026 if (d > 0)
1044 op->value *= 5; 1027 op->value *= 5;
1028
1045 set_ring_bonus (op, d); 1029 set_ring_bonus (op, d);
1046 } 1030 }
1047 } 1031 }
1048 1032
1049 if (GET_ANIM_ID (op)) 1033 if (op->animation_id)
1050 SET_ANIMATION (op, RANDOM () % ((int) NUM_ANIMATIONS (op))); 1034 op->set_anim_frame (rndm (op->anim_frames ()));
1051 1035
1052 break; 1036 break;
1053 1037
1054 case BOOK: 1038 case BOOK:
1055 /* Is it an empty book?, if yes lets make a special· 1039 /* Is it an empty book?, if yes lets make a special·
1056 * msg for it, and tailor its properties based on the· 1040 * msg for it, and tailor its properties based on the·
1057 * creator and/or map level we found it on. 1041 * creator and/or map level we found it on.
1058 */ 1042 */
1059 if (!op->msg && RANDOM () % 10) 1043 if (!op->msg && rndm (10))
1060 { 1044 {
1061 /* set the book level properly */ 1045 /* set the book level properly */
1062 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE)) 1046 if (creator->level == 0 || creator->flag [FLAG_ALIVE])
1063 { 1047 {
1064 if (op->map && op->map->difficulty) 1048 if (op->map && op->map->difficulty)
1065 op->level = RANDOM () % (op->map->difficulty) + RANDOM () % 10 + 1; 1049 op->level = rndm (op->map->difficulty) + rndm (10) + 1;
1066 else 1050 else
1067 op->level = RANDOM () % 20 + 1; 1051 op->level = rndm (20) + 1;
1068 } 1052 }
1069 else 1053 else
1070 op->level = RANDOM () % creator->level; 1054 op->level = rndm (creator->level);
1071 1055
1072 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1); 1056 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1);
1073 /* books w/ info are worth more! */ 1057 /* books w/ info are worth more! */
1074 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1)); 1058 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1));
1075 /* creator related stuff */
1076
1077 /* for library, chained books. Note that some monsters have no_pick
1078 * set - we don't want to set no pick in that case.
1079 */
1080 if (QUERY_FLAG (creator, FLAG_NO_PICK) && !QUERY_FLAG (creator, FLAG_MONSTER))
1081 SET_FLAG (op, FLAG_NO_PICK);
1082 if (creator->slaying && !op->slaying) /* for check_inv floors */
1083 op->slaying = creator->slaying;
1084 1059
1085 /* add exp so reading it gives xp (once) */ 1060 /* add exp so reading it gives xp (once) */
1086 op->stats.exp = op->value > 10000 ? op->value / 5 : op->value / 10; 1061 op->stats.exp = op->value > 10000 ? op->value / 5 : op->value / 10;
1087 } 1062 }
1063
1064 /* creator related stuff */
1065
1066 /* for library, chained books. Note that some monsters have no_pick
1067 * set - we don't want to set no pick in that case.
1068 */
1069 if (creator->flag [FLAG_NO_PICK] && !creator->flag [FLAG_MONSTER])
1070 op->set_flag (FLAG_NO_PICK);
1071 if (creator->slaying && !op->slaying) /* for check_inv floors */
1072 op->slaying = creator->slaying;
1088 break; 1073 break;
1089 1074
1090 case SPELLBOOK: 1075 case SPELLBOOK:
1091 op->value = op->value * op->inv->value; 1076 op->value *= value_factor_from_spell_item (op->inv, 0);
1077
1092 /* add exp so learning gives xp */ 1078 /* add exp so learning gives xp */
1093 op->level = op->inv->level; 1079 op->level = op->inv->level;
1094 op->stats.exp = op->value; 1080 op->stats.exp = op->value;
1095 break; 1081 break;
1096 1082
1100 * and reset nrof. 1086 * and reset nrof.
1101 */ 1087 */
1102 op->stats.food = op->inv->nrof; 1088 op->stats.food = op->inv->nrof;
1103 op->nrof = 1; 1089 op->nrof = 1;
1104 /* If the spell changes by level, choose a random level 1090 /* If the spell changes by level, choose a random level
1105 * for it, and adjust price. If the spell doesn't 1091 * for it.
1106 * change by level, just set the wand to the level of
1107 * the spell, and value calculation is simpler.
1108 */ 1092 */
1109 if (op->inv->duration_modifier || op->inv->dam_modifier || op->inv->range_modifier) 1093 if (op->inv->duration_modifier
1110 { 1094 || op->inv->dam_modifier
1095 || op->inv->range_modifier)
1111 op->level = level_for_item (op, difficulty); 1096 op->level = level_for_item (op, difficulty);
1112 op->value = op->value * op->inv->value * (op->level + 50) / (op->inv->level + 50);
1113 }
1114 else 1097 else
1115 {
1116 op->level = op->inv->level; 1098 op->level = op->inv->level;
1117 op->value = op->value * op->inv->value; 1099
1118 } 1100 op->value *= value_factor_from_spell_item (op->inv, op);
1119 break; 1101 break;
1120 1102
1121 case ROD: 1103 case ROD:
1122 op->level = level_for_item (op, difficulty); 1104 op->level = level_for_item (op, difficulty);
1123 /* Add 50 to both level an divisor to keep prices a little more 1105 op->value *= value_factor_from_spell_item (op->inv, op);
1124 * reasonable. Otherwise, a high level version of a low level 1106
1125 * spell can be worth tons a money (eg, level 20 rod, level 2 spell =
1126 * 10 time multiplier). This way, the value are a bit more reasonable.
1127 */
1128 op->value = op->value * op->inv->value * (op->level + 50) / (op->inv->level + 50);
1129 /* maxhp is used to denote how many 'charges' the rod holds before */ 1107 /* maxhp is used to denote how many 'charges' the rod holds before */
1130 if (op->stats.maxhp) 1108 if (op->stats.maxhp)
1131 op->stats.maxhp *= MAX (op->inv->stats.sp, op->inv->stats.grace); 1109 op->stats.maxhp *= max (op->inv->stats.sp, op->inv->stats.grace);
1132 else 1110 else
1133 op->stats.maxhp = 2 * MAX (op->inv->stats.sp, op->inv->stats.grace); 1111 op->stats.maxhp = 2 * max (op->inv->stats.sp, op->inv->stats.grace);
1134 1112
1135 op->stats.hp = op->stats.maxhp; 1113 op->stats.hp = op->stats.maxhp;
1136 break; 1114 break;
1137 1115
1138 case SCROLL: 1116 case SCROLL:
1139 op->level = level_for_item (op, difficulty); 1117 op->level = level_for_item (op, difficulty);
1140 op->value = op->value * op->inv->value * (op->level + 50) / (op->inv->level + 50); 1118 op->value *= value_factor_from_spell_item (op->inv, op);
1141 1119
1142 /* add exp so reading them properly gives xp */ 1120 /* add exp so reading them properly gives xp */
1143 op->stats.exp = op->value / 5; 1121 op->stats.exp = op->value / 5;
1144 op->nrof = op->inv->nrof; 1122 op->nrof = op->inv->nrof;
1145 break; 1123 break;
1153 break; 1131 break;
1154 } /* switch type */ 1132 } /* switch type */
1155 1133
1156 if (flags & GT_STARTEQUIP) 1134 if (flags & GT_STARTEQUIP)
1157 { 1135 {
1158 if (op->nrof < 2 && op->type != CONTAINER && op->type != MONEY && !QUERY_FLAG (op, FLAG_IS_THROWN)) 1136 if (op->nrof < 2 && op->type != CONTAINER && op->type != MONEY && !op->flag [FLAG_IS_THROWN])
1159 SET_FLAG (op, FLAG_STARTEQUIP); 1137 op->set_flag (FLAG_STARTEQUIP);
1160 else if (op->type != MONEY) 1138 else if (op->type != MONEY)
1161 op->value = 0; 1139 op->value = 0;
1162 } 1140 }
1163 1141
1164 if (!(flags & GT_ENVIRONMENT)) 1142 if (!(flags & GT_ENVIRONMENT))
1174 */ 1152 */
1175 1153
1176/* 1154/*
1177 * Allocate and return the pointer to an empty artifactlist structure. 1155 * Allocate and return the pointer to an empty artifactlist structure.
1178 */ 1156 */
1179
1180static artifactlist * 1157static artifactlist *
1181get_empty_artifactlist (void) 1158get_empty_artifactlist ()
1182{ 1159{
1183 artifactlist *tl = (artifactlist *) malloc (sizeof (artifactlist)); 1160 return salloc0<artifactlist> ();
1184
1185 if (tl == NULL)
1186 fatal (OUT_OF_MEMORY);
1187 tl->next = NULL;
1188 tl->items = NULL;
1189 tl->total_chance = 0;
1190 return tl;
1191} 1161}
1192 1162
1193/* 1163/*
1194 * Allocate and return the pointer to an empty artifact structure. 1164 * Allocate and return the pointer to an empty artifact structure.
1195 */ 1165 */
1196
1197static artifact * 1166static artifact *
1198get_empty_artifact (void) 1167get_empty_artifact ()
1199{ 1168{
1200 artifact *t = (artifact *) malloc (sizeof (artifact)); 1169 return salloc0<artifact> ();
1201
1202 if (t == NULL)
1203 fatal (OUT_OF_MEMORY);
1204 t->item = NULL;
1205 t->next = NULL;
1206 t->chance = 0;
1207 t->difficulty = 0;
1208 t->allowed = NULL;
1209 return t;
1210} 1170}
1211 1171
1212/* 1172/*
1213 * Searches the artifact lists and returns one that has the same type 1173 * Searches the artifact lists and returns one that has the same type
1214 * of objects on it. 1174 * of objects on it.
1215 */ 1175 */
1216
1217artifactlist * 1176artifactlist *
1218find_artifactlist (int type) 1177find_artifactlist (int type)
1219{ 1178{
1220 artifactlist *al;
1221
1222 for (al = first_artifactlist; al != NULL; al = al->next) 1179 for (artifactlist *al = first_artifactlist; al; al = al->next)
1223 if (al->type == type) 1180 if (al->type == type)
1224 return al; 1181 return al;
1182
1225 return NULL; 1183 return 0;
1226} 1184}
1227 1185
1228/* 1186/*
1229 * For debugging purposes. Dumps all tables. 1187 * Builds up the lists of artifacts from the file in the libdir.
1230 */ 1188 */
1231
1232void 1189void
1233dump_artifacts (void)
1234{
1235 artifactlist *al;
1236 artifact *art;
1237 linked_char *next;
1238
1239 fprintf (logfile, "\n");
1240 for (al = first_artifactlist; al != NULL; al = al->next)
1241 {
1242 fprintf (logfile, "Artifact has type %d, total_chance=%d\n", al->type, al->total_chance);
1243 for (art = al->items; art != NULL; art = art->next)
1244 {
1245 fprintf (logfile, "Artifact %-30s Difficulty %3d Chance %5d\n", &art->item->name, art->difficulty, art->chance);
1246 if (art->allowed != NULL)
1247 {
1248 fprintf (logfile, "\tAllowed combinations:");
1249 for (next = art->allowed; next != NULL; next = next->next)
1250 fprintf (logfile, "%s,", &next->name);
1251 fprintf (logfile, "\n");
1252 }
1253 }
1254 }
1255 fprintf (logfile, "\n");
1256}
1257
1258/*
1259 * For debugging purposes. Dumps all treasures recursively (see below).
1260 */
1261void
1262dump_monster_treasure_rec (const char *name, treasure *t, int depth)
1263{
1264 treasurelist *tl;
1265 int i;
1266
1267 if (depth > 100)
1268 return;
1269 while (t != NULL)
1270 {
1271 if (t->name != NULL)
1272 {
1273 for (i = 0; i < depth; i++)
1274 fprintf (logfile, " ");
1275 fprintf (logfile, "{ (list: %s)\n", &t->name);
1276 tl = find_treasurelist (t->name);
1277 if (tl)
1278 dump_monster_treasure_rec (name, tl->items, depth + 2);
1279 for (i = 0; i < depth; i++)
1280 fprintf (logfile, " ");
1281 fprintf (logfile, "} (end of list: %s)\n", &t->name);
1282 }
1283 else
1284 {
1285 for (i = 0; i < depth; i++)
1286 fprintf (logfile, " ");
1287 if (t->item->clone.type == FLESH)
1288 fprintf (logfile, "%s's %s\n", name, &t->item->clone.name);
1289 else
1290 fprintf (logfile, "%s\n", &t->item->clone.name);
1291 }
1292 if (t->next_yes != NULL)
1293 {
1294 for (i = 0; i < depth; i++)
1295 fprintf (logfile, " ");
1296 fprintf (logfile, " (if yes)\n");
1297 dump_monster_treasure_rec (name, t->next_yes, depth + 1);
1298 }
1299 if (t->next_no != NULL)
1300 {
1301 for (i = 0; i < depth; i++)
1302 fprintf (logfile, " ");
1303 fprintf (logfile, " (if no)\n");
1304 dump_monster_treasure_rec (name, t->next_no, depth + 1);
1305 }
1306 t = t->next;
1307 }
1308}
1309
1310/*
1311 * For debugging purposes. Dumps all treasures for a given monster.
1312 * Created originally by Raphael Quinet for debugging the alchemy code.
1313 */
1314
1315void
1316dump_monster_treasure (const char *name)
1317{
1318 archetype *at;
1319 int found;
1320
1321 found = 0;
1322 fprintf (logfile, "\n");
1323 for (at = first_archetype; at != NULL; at = at->next)
1324 if (!strcasecmp (at->clone.name, name) && at->clone.title == NULL)
1325 {
1326 fprintf (logfile, "treasures for %s (arch: %s)\n", &at->clone.name, &at->name);
1327 if (at->clone.randomitems != NULL)
1328 dump_monster_treasure_rec (at->clone.name, at->clone.randomitems->items, 1);
1329 else
1330 fprintf (logfile, "(nothing)\n");
1331 fprintf (logfile, "\n");
1332 found++;
1333 }
1334 if (found == 0)
1335 fprintf (logfile, "No objects have the name %s!\n\n", name);
1336}
1337
1338/*
1339 * Builds up the lists of artifacts from the file in the libdir.
1340 */
1341
1342void
1343init_artifacts (void) 1190init_artifacts ()
1344{ 1191{
1345 static int has_been_inited = 0; 1192 static int has_been_inited = 0;
1346 char filename[MAX_BUF], buf[HUGE_BUF], *cp, *next;
1347 artifact *art = NULL; 1193 artifact *art = NULL;
1348 linked_char *tmp;
1349 int value;
1350 artifactlist *al; 1194 artifactlist *al;
1351 1195
1352 if (has_been_inited) 1196 if (has_been_inited)
1353 return; 1197 return;
1354 else 1198 else
1355 has_been_inited = 1; 1199 has_been_inited = 1;
1356 1200
1357 sprintf (filename, "%s/artifacts", settings.datadir); 1201 object_thawer f (settings.datadir, "artifacts");
1358 object_thawer thawer (filename);
1359 1202
1360 if (!thawer) 1203 if (!f)
1361 return; 1204 return;
1362 1205
1363 while (fgets (buf, HUGE_BUF, thawer) != NULL) 1206 for (;;)
1364 { 1207 {
1365 if (*buf == '#') 1208 switch (f.kw)
1366 continue;
1367 if ((cp = strchr (buf, '\n')) != NULL)
1368 *cp = '\0';
1369 cp = buf;
1370 while (*cp == ' ') /* Skip blanks */
1371 cp++;
1372 if (*cp == '\0')
1373 continue;
1374
1375 if (!strncmp (cp, "Allowed", 7))
1376 { 1209 {
1210 case KW_allowed:
1377 if (art == NULL) 1211 if (!art)
1212 art = get_empty_artifact ();
1213
1378 { 1214 {
1379 art = get_empty_artifact (); 1215 if (!strcmp (f.get_str (), "all"))
1380 nrofartifacts++; 1216 break;
1217
1218 const char *cp = f.get_str ();
1219 char *next;
1220 do
1221 {
1222 if ((next = (char *)strchr (cp, ',')))
1223 *next++ = '\0';
1224
1225 linked_char *tmp = new linked_char;
1226
1227 tmp->name = cp;
1228 tmp->next = art->allowed;
1229 art->allowed = tmp;
1230 }
1231 while ((cp = next));
1381 } 1232 }
1382 cp = strchr (cp, ' ') + 1; 1233 break;
1383 if (!strcmp (cp, "all")) 1234
1235 case KW_chance:
1236 f.get (art->chance);
1237 break;
1238
1239 case KW_difficulty:
1240 f.get (art->difficulty);
1241 break;
1242
1243 case KW_object:
1244 {
1245 art->item = object::create ();
1246 f.get (art->item->name);
1247 f.next ();
1248
1249 if (!art->item->parse_kv (f))
1250 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1251
1252 al = find_artifactlist (art->item->type);
1253
1254 if (!al)
1255 {
1256 al = get_empty_artifactlist ();
1257 al->type = art->item->type;
1258 al->next = first_artifactlist;
1259 first_artifactlist = al;
1260 }
1261
1262 art->next = al->items;
1263 al->items = art;
1264 art = 0;
1265 }
1384 continue; 1266 continue;
1385 1267
1386 do 1268 case KW_EOF:
1269 goto done;
1270
1271 default:
1272 if (!f.parse_error ("artifacts file"))
1273 cleanup ("artifacts file required");
1387 { 1274 break;
1388 nrofallowedstr++;
1389 if ((next = strchr (cp, ',')) != NULL)
1390 *(next++) = '\0';
1391 tmp = new linked_char;
1392
1393 tmp->name = cp;
1394 tmp->next = art->allowed;
1395 art->allowed = tmp;
1396 }
1397 while ((cp = next) != NULL);
1398 }
1399 else if (sscanf (cp, "chance %d", &value))
1400 art->chance = (uint16) value;
1401 else if (sscanf (cp, "difficulty %d", &value))
1402 art->difficulty = (uint8) value;
1403 else if (!strncmp (cp, "Object", 6))
1404 { 1275 }
1405 art->item = object::create ();
1406 1276
1407 if (!load_object (thawer, art->item, 0)) 1277 f.next ();
1408 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1409
1410 art->item->name = strchr (cp, ' ') + 1;
1411 al = find_artifactlist (art->item->type);
1412 if (al == NULL)
1413 {
1414 al = get_empty_artifactlist ();
1415 al->type = art->item->type;
1416 al->next = first_artifactlist;
1417 first_artifactlist = al;
1418 }
1419 art->next = al->items;
1420 al->items = art;
1421 art = NULL;
1422 }
1423 else
1424 LOG (llevError, "Unknown input in artifact file: %s\n", buf);
1425 } 1278 }
1426 1279
1280done:
1427 for (al = first_artifactlist; al != NULL; al = al->next) 1281 for (al = first_artifactlist; al; al = al->next)
1428 { 1282 {
1283 al->total_chance = 0;
1284
1429 for (art = al->items; art != NULL; art = art->next) 1285 for (art = al->items; art; art = art->next)
1430 { 1286 {
1431 if (!art->chance) 1287 if (!art->chance)
1432 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name); 1288 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name);
1433 else 1289 else
1434 al->total_chance += art->chance; 1290 al->total_chance += art->chance;
1435 } 1291 }
1436#if 0 1292#if 0
1437 LOG (llevDebug, "Artifact list type %d has %d total chance\n", al->type, al->total_chance); 1293 LOG (llevDebug, "Artifact list type %d has %d total chance\n", al->type, al->total_chance);
1438#endif 1294#endif
1439 } 1295 }
1440
1441 LOG (llevDebug, "done.\n");
1442} 1296}
1443
1444 1297
1445/* 1298/*
1446 * Used in artifact generation. The bonuses of the first object 1299 * Used in artifact generation. The bonuses of the first object
1447 * is modified by the bonuses of the second object. 1300 * is modified by the bonuses of the second object.
1448 */ 1301 */
1449
1450void 1302void
1451add_abilities (object *op, object *change) 1303add_abilities (object *op, object *change)
1452{ 1304{
1453 int i, tmp;
1454
1455 if (change->face != blank_face) 1305 if (change->face != blank_face)
1456 {
1457#ifdef TREASURE_VERBOSE
1458 LOG (llevDebug, "FACE: %d\n", change->face->number);
1459#endif
1460 op->face = change->face; 1306 op->face = change->face;
1461 }
1462 1307
1463 for (i = 0; i < NUM_STATS; i++) 1308 for (int i = 0; i < NUM_STATS; i++)
1464 change_attr_value (&(op->stats), i, get_attr_value (&(change->stats), i)); 1309 change_attr_value (&(op->stats), i, change->stats.stat (i));
1465 1310
1466 op->attacktype |= change->attacktype; 1311 op->attacktype |= change->attacktype;
1467 op->path_attuned |= change->path_attuned; 1312 op->path_attuned |= change->path_attuned;
1468 op->path_repelled |= change->path_repelled; 1313 op->path_repelled |= change->path_repelled;
1469 op->path_denied |= change->path_denied; 1314 op->path_denied |= change->path_denied;
1470 op->move_type |= change->move_type; 1315 op->move_type |= change->move_type;
1471 op->stats.luck += change->stats.luck; 1316 op->stats.luck += change->stats.luck;
1472 1317
1473 if (QUERY_FLAG (change, FLAG_CURSED)) 1318 static const struct copyflags : object::flags_t
1474 SET_FLAG (op, FLAG_CURSED); 1319 {
1475 if (QUERY_FLAG (change, FLAG_DAMNED)) 1320 copyflags ()
1476 SET_FLAG (op, FLAG_DAMNED); 1321 {
1477 if ((QUERY_FLAG (change, FLAG_CURSED) || QUERY_FLAG (change, FLAG_DAMNED)) && op->magic > 0) 1322 set (FLAG_CURSED);
1323 set (FLAG_DAMNED);
1324 set (FLAG_LIFESAVE);
1325 set (FLAG_REFL_SPELL);
1326 set (FLAG_STEALTH);
1327 set (FLAG_XRAYS);
1328 set (FLAG_BLIND);
1329 set (FLAG_SEE_IN_DARK);
1330 set (FLAG_REFL_MISSILE);
1331 set (FLAG_MAKE_INVIS);
1332 }
1333 } copyflags;
1334
1335 // we might want to just copy, but or'ing is what the original code did
1336 op->flag |= change->flag & copyflags;
1337
1338 if ((change->flag [FLAG_CURSED] || change->flag [FLAG_DAMNED]) && op->magic > 0)
1478 set_abs_magic (op, -op->magic); 1339 set_abs_magic (op, -op->magic);
1479 1340
1480 if (QUERY_FLAG (change, FLAG_LIFESAVE)) 1341 if (change->flag [FLAG_STAND_STILL])
1481 SET_FLAG (op, FLAG_LIFESAVE);
1482 if (QUERY_FLAG (change, FLAG_REFL_SPELL))
1483 SET_FLAG (op, FLAG_REFL_SPELL);
1484 if (QUERY_FLAG (change, FLAG_STEALTH))
1485 SET_FLAG (op, FLAG_STEALTH);
1486 if (QUERY_FLAG (change, FLAG_XRAYS))
1487 SET_FLAG (op, FLAG_XRAYS);
1488 if (QUERY_FLAG (change, FLAG_BLIND))
1489 SET_FLAG (op, FLAG_BLIND);
1490 if (QUERY_FLAG (change, FLAG_SEE_IN_DARK))
1491 SET_FLAG (op, FLAG_SEE_IN_DARK);
1492 if (QUERY_FLAG (change, FLAG_REFL_MISSILE))
1493 SET_FLAG (op, FLAG_REFL_MISSILE);
1494 if (QUERY_FLAG (change, FLAG_MAKE_INVIS))
1495 SET_FLAG (op, FLAG_MAKE_INVIS);
1496
1497 if (QUERY_FLAG (change, FLAG_STAND_STILL))
1498 { 1342 {
1499 CLEAR_FLAG (op, FLAG_ANIMATE); 1343 op->clr_flag (FLAG_ANIMATE);
1344
1500 /* so artifacts will join */ 1345 /* so artifacts will join */
1501 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1346 if (!op->flag [FLAG_ALIVE])
1502 op->speed = 0.0; 1347 op->speed = 0.;
1503 1348
1504 update_ob_speed (op); 1349 op->set_speed (op->speed);
1505 } 1350 }
1506 1351
1507 if (change->nrof) 1352 if (change->nrof)
1508 op->nrof = RANDOM () % ((int) change->nrof) + 1; 1353 op->nrof = rndm (change->nrof) + 1;
1509 1354
1510 op->stats.exp += change->stats.exp; /* Speed modifier */ 1355 op->stats.exp += change->stats.exp; /* Speed modifier */
1511 op->stats.wc += change->stats.wc; 1356 op->stats.wc += change->stats.wc;
1512 op->stats.ac += change->stats.ac; 1357 op->stats.ac += change->stats.ac;
1513 1358
1514 if (change->other_arch) 1359 if (change->other_arch)
1515 { 1360 {
1516 /* Basically, for horns & potions, the other_arch field is the spell 1361 /* Basically, for horns & potions, the other_arch field is the spell
1517 * to cast. So convert that to into a spell and put it into 1362 * to cast. So convert that to into a spell and put it into
1518 * this object. 1363 * this object.
1519 */ 1364 */
1520 if (op->type == HORN || op->type == POTION) 1365 if (op->type == HORN || op->type == POTION)
1521 { 1366 {
1522 object *tmp_obj;
1523
1524 /* Remove any spells this object currently has in it */ 1367 /* Remove any spells this object currently has in it */
1525 while (op->inv)
1526 op->inv->destroy (); 1368 op->destroy_inv (false);
1527 1369
1528 tmp_obj = arch_to_object (change->other_arch); 1370 object *tmp = change->other_arch->instance ();
1529 insert_ob_in_ob (tmp_obj, op); 1371 insert_ob_in_ob (tmp, op);
1530 } 1372 }
1373
1531 /* No harm setting this for potions/horns */ 1374 /* No harm setting this for potions/horns */
1532 op->other_arch = change->other_arch; 1375 op->other_arch = change->other_arch;
1533 } 1376 }
1534 1377
1535 if (change->stats.hp < 0) 1378 if (change->stats.hp < 0)
1551 op->stats.maxsp = -change->stats.maxsp; 1394 op->stats.maxsp = -change->stats.maxsp;
1552 else 1395 else
1553 op->stats.maxsp += change->stats.maxsp; 1396 op->stats.maxsp += change->stats.maxsp;
1554 1397
1555 if (change->stats.food < 0) 1398 if (change->stats.food < 0)
1556 op->stats.food = -(change->stats.food); 1399 op->stats.food = -change->stats.food;
1557 else 1400 else
1558 op->stats.food += change->stats.food; 1401 op->stats.food += change->stats.food;
1559 1402
1560 if (change->level < 0) 1403 if (change->level < 0)
1561 op->level = -(change->level); 1404 op->level = -change->level;
1562 else 1405 else
1563 op->level += change->level; 1406 op->level += change->level;
1564 1407
1565 if (change->gen_sp_armour < 0) 1408 if (change->gen_sp_armour < 0)
1566 op->gen_sp_armour = -(change->gen_sp_armour); 1409 op->gen_sp_armour = -change->gen_sp_armour;
1567 else 1410 else
1568 op->gen_sp_armour = (op->gen_sp_armour * (change->gen_sp_armour)) / 100; 1411 op->gen_sp_armour = op->gen_sp_armour * (int)change->gen_sp_armour / 100;
1569 1412
1570 op->item_power = change->item_power; 1413 op->item_power = change->item_power;
1571 1414
1572 for (i = 0; i < NROFATTACKS; i++) 1415 for (int i = 0; i < NROFATTACKS; i++)
1573 if (change->resist[i])
1574 op->resist[i] += change->resist[i]; 1416 op->resist[i] += change->resist[i];
1575 1417
1576 if (change->stats.dam) 1418 if (change->stats.dam)
1577 { 1419 {
1578 if (change->stats.dam < 0) 1420 if (change->stats.dam < 0)
1579 op->stats.dam = (-change->stats.dam); 1421 op->stats.dam = -change->stats.dam;
1580 else if (op->stats.dam) 1422 else if (op->stats.dam)
1581 { 1423 {
1582 tmp = (signed char) (((int) op->stats.dam * (int) change->stats.dam) / 10); 1424 int tmp = op->stats.dam * change->stats.dam / 10;
1425
1583 if (tmp == op->stats.dam) 1426 if (tmp == op->stats.dam)
1584 { 1427 {
1585 if (change->stats.dam < 10) 1428 if (change->stats.dam < 10)
1586 op->stats.dam--; 1429 op->stats.dam--;
1587 else 1430 else
1593 } 1436 }
1594 1437
1595 if (change->weight) 1438 if (change->weight)
1596 { 1439 {
1597 if (change->weight < 0) 1440 if (change->weight < 0)
1598 op->weight = (-change->weight); 1441 op->weight = -change->weight;
1599 else 1442 else
1600 op->weight = (op->weight * (change->weight)) / 100; 1443 op->weight = op->weight * change->weight / 100;
1601 } 1444 }
1602 1445
1603 if (change->last_sp) 1446 if (change->last_sp)
1604 { 1447 {
1605 if (change->last_sp < 0) 1448 if (change->last_sp < 0)
1606 op->last_sp = (-change->last_sp); 1449 op->last_sp = -change->last_sp;
1607 else 1450 else
1608 op->last_sp = (signed char) (((int) op->last_sp * (int) change->last_sp) / (int) 100); 1451 op->last_sp = op->last_sp * (int)change->last_sp / 100;
1609 } 1452 }
1610 1453
1611 if (change->gen_sp_armour) 1454 if (change->gen_sp_armour)
1612 { 1455 {
1613 if (change->gen_sp_armour < 0) 1456 if (change->gen_sp_armour < 0)
1614 op->gen_sp_armour = (-change->gen_sp_armour); 1457 op->gen_sp_armour = -change->gen_sp_armour;
1615 else 1458 else
1616 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100); 1459 op->gen_sp_armour = op->gen_sp_armour * (int)change->gen_sp_armour / 100;
1617 } 1460 }
1618 1461
1619 op->value *= change->value; 1462 op->value *= change->value;
1620 1463
1621 if (change->material) 1464 if (change->materials)
1465 op->materials = change->materials;
1466
1467 if (change->material != MATERIAL_NULL)
1622 op->material = change->material; 1468 op->material = change->material;
1623
1624 if (change->materialname)
1625 op->materialname = change->materialname;
1626 1469
1627 if (change->slaying) 1470 if (change->slaying)
1628 op->slaying = change->slaying; 1471 op->slaying = change->slaying;
1629 1472
1630 if (change->race) 1473 if (change->race)
1633 if (change->msg) 1476 if (change->msg)
1634 op->msg = change->msg; 1477 op->msg = change->msg;
1635} 1478}
1636 1479
1637static int 1480static int
1638legal_artifact_combination (object *op, artifact * art) 1481legal_artifact_combination (object *op, artifact *art)
1639{ 1482{
1640 int neg, success = 0; 1483 int neg, success = 0;
1641 linked_char *tmp; 1484 linked_char *tmp;
1642 const char *name; 1485 const char *name;
1643 1486
1644 if (art->allowed == (linked_char *) NULL) 1487 if (!art->allowed)
1645 return 1; /* Ie, "all" */ 1488 return 1; /* Ie, "all" */
1489
1646 for (tmp = art->allowed; tmp; tmp = tmp->next) 1490 for (tmp = art->allowed; tmp; tmp = tmp->next)
1647 { 1491 {
1648#ifdef TREASURE_VERBOSE 1492#ifdef TREASURE_VERBOSE
1649 LOG (llevDebug, "legal_art: %s\n", tmp->name); 1493 LOG (llevDebug, "legal_art: %s\n", &tmp->name);
1650#endif 1494#endif
1651 if (*tmp->name == '!') 1495 if (*tmp->name == '!')
1652 name = tmp->name + 1, neg = 1; 1496 name = tmp->name + 1, neg = 1;
1653 else 1497 else
1654 name = tmp->name, neg = 0; 1498 name = tmp->name, neg = 0;
1655 1499
1656 /* If we match name, then return the opposite of 'neg' */ 1500 /* If we match name, then return the opposite of 'neg' */
1657 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->name))) 1501 if (!strcmp (name, op->arch->archname))
1658 return !neg; 1502 return !neg;
1659 1503
1660 /* Set success as true, since if the match was an inverse, it means 1504 /* Set success as true, since if the match was an inverse, it means
1661 * everything is allowed except what we match 1505 * everything is allowed except what we match
1662 */ 1506 */
1663 else if (neg) 1507 else if (neg)
1664 success = 1; 1508 success = 1;
1665 } 1509 }
1510
1666 return success; 1511 return success;
1667} 1512}
1668 1513
1669/* 1514/*
1670 * Fixes the given object, giving it the abilities and titles 1515 * Fixes the given object, giving it the abilities and titles
1672 */ 1517 */
1673 1518
1674void 1519void
1675give_artifact_abilities (object *op, object *artifct) 1520give_artifact_abilities (object *op, object *artifct)
1676{ 1521{
1677 char new_name[MAX_BUF]; 1522 op->title = format ("of %s", &artifct->name);
1678 1523
1679 sprintf (new_name, "of %s", &artifct->name);
1680 op->title = new_name;
1681 add_abilities (op, artifct); /* Give out the bonuses */ 1524 add_abilities (op, artifct); /* Give out the bonuses */
1682 1525
1683#if 0 /* Bit verbose, but keep it here until next time I need it... */ 1526#if 0 /* Bit verbose, but keep it here until next time I need it... */
1684 { 1527 {
1685 char identified = QUERY_FLAG (op, FLAG_IDENTIFIED); 1528 char identified = op->flag [FLAG_IDENTIFIED];
1686 1529
1687 SET_FLAG (op, FLAG_IDENTIFIED); 1530 op->set_flag (FLAG_IDENTIFIED);
1688 LOG (llevDebug, "Generated artifact %s %s [%s]\n", op->name, op->title, describe_item (op, NULL)); 1531 LOG (llevDebug, "Generated artifact %s %s [%s]\n", op->name, op->title, describe_item (op, NULL));
1689 if (!identified) 1532 if (!identified)
1690 CLEAR_FLAG (op, FLAG_IDENTIFIED); 1533 op->clr_flag (FLAG_IDENTIFIED);
1691 } 1534 }
1692#endif 1535#endif
1693 return; 1536 return;
1694} 1537}
1695 1538
1705#define ARTIFACT_TRIES 2 1548#define ARTIFACT_TRIES 2
1706 1549
1707void 1550void
1708generate_artifact (object *op, int difficulty) 1551generate_artifact (object *op, int difficulty)
1709{ 1552{
1710 artifactlist *al;
1711 artifact *art; 1553 artifact *art;
1712 int i;
1713 1554
1714 al = find_artifactlist (op->type); 1555 artifactlist *al = find_artifactlist (op->type);
1715 1556
1716 if (al == NULL) 1557 if (al == NULL)
1717 { 1558 {
1718#if 0 /* This is too verbose, usually */ 1559#if 0 /* This is too verbose, usually */
1719 LOG (llevDebug, "Couldn't change %s into artifact - no table.\n", op->name); 1560 LOG (llevDebug, "Couldn't change %s into artifact - no table.\n", op->name);
1720#endif 1561#endif
1721 return; 1562 return;
1722 } 1563 }
1723 1564
1724 for (i = 0; i < ARTIFACT_TRIES; i++) 1565 for (int i = 0; i < ARTIFACT_TRIES; i++)
1725 { 1566 {
1726 int roll = RANDOM () % al->total_chance; 1567 int roll = rndm (al->total_chance);
1727 1568
1728 for (art = al->items; art != NULL; art = art->next) 1569 for (art = al->items; art; art = art->next)
1729 { 1570 {
1730 roll -= art->chance; 1571 roll -= art->chance;
1731 if (roll < 0) 1572 if (roll < 0)
1732 break; 1573 break;
1733 } 1574 }
1737#if 1 1578#if 1
1738 LOG (llevError, "Got null entry and non zero roll in generate_artifact, type %d\n", op->type); 1579 LOG (llevError, "Got null entry and non zero roll in generate_artifact, type %d\n", op->type);
1739#endif 1580#endif
1740 return; 1581 return;
1741 } 1582 }
1742 if (!strcmp (art->item->name, "NONE")) 1583
1584 if (art->item->name == shstr_NONE)
1743 return; 1585 return;
1586
1744 if (FABS (op->magic) < art->item->magic) 1587 if (fabs (op->magic) < art->item->magic)
1745 continue; /* Not magic enough to be this item */ 1588 continue; /* Not magic enough to be this item */
1746 1589
1747 /* Map difficulty not high enough */ 1590 /* Map difficulty not high enough */
1748 if (difficulty < art->difficulty) 1591 if (difficulty < art->difficulty)
1749 continue; 1592 continue;
1750 1593
1751 if (!legal_artifact_combination (op, art)) 1594 if (!legal_artifact_combination (op, art))
1752 { 1595 {
1753#ifdef TREASURE_VERBOSE 1596#ifdef TREASURE_VERBOSE
1754 LOG (llevDebug, "%s of %s was not a legal combination.\n", op->name, art->item->name); 1597 LOG (llevDebug, "%s of %s was not a legal combination.\n", &op->name, &art->item->name);
1755#endif 1598#endif
1756 continue; 1599 continue;
1757 } 1600 }
1601
1758 give_artifact_abilities (op, art->item); 1602 give_artifact_abilities (op, art->item);
1759 return; 1603 return;
1760 } 1604 }
1761} 1605}
1762 1606
1766 */ 1610 */
1767 1611
1768void 1612void
1769fix_flesh_item (object *item, object *donor) 1613fix_flesh_item (object *item, object *donor)
1770{ 1614{
1771 char tmpbuf[MAX_BUF];
1772 int i;
1773
1774 if (item->type == FLESH && donor) 1615 if (item->type == FLESH && donor)
1775 { 1616 {
1776 /* change the name */ 1617 /* change the name */
1777 sprintf (tmpbuf, "%s's %s", &donor->name, &item->name); 1618 item->name = format ("%s's %s", &donor->name, &item->name);
1778 item->name = tmpbuf;
1779 sprintf (tmpbuf, "%s's %s", &donor->name, &item->name_pl); 1619 item->name_pl = format ("%s's %s", &donor->name, &item->name_pl);
1780 item->name_pl = tmpbuf;
1781 1620
1782 /* weight is FLESH weight/100 * donor */ 1621 /* weight is FLESH weight/100 * donor */
1783 if ((item->weight = (signed long) (((double) item->weight / (double) 100.0) * (double) donor->weight)) == 0) 1622 item->weight = max (1, item->weight * donor->weight / 100);
1784 item->weight = 1;
1785 1623
1786 /* value is multiplied by level of donor */ 1624 /* value is multiplied by level of donor */
1787 item->value *= isqrt (donor->level * 2); 1625 item->value *= isqrt (donor->level * 2);
1788 1626
1789 /* food value */ 1627 /* food value */
1790 item->stats.food += (donor->stats.hp / 100) + donor->stats.Con; 1628 item->stats.food += donor->stats.hp / 100 + donor->stats.Con;
1791 1629
1792 /* flesh items inherit some abilities of donor, but not 1630 /* flesh items inherit some abilities of donor, but not
1793 * full effect. 1631 * full effect.
1794 */ 1632 */
1795 for (i = 0; i < NROFATTACKS; i++) 1633 for (int i = 0; i < NROFATTACKS; i++)
1796 item->resist[i] = donor->resist[i] / 2; 1634 item->resist[i] = donor->resist[i] / 2;
1797 1635
1798 /* item inherits donor's level (important for quezals) */ 1636 /* item inherits donor's level (important for quezals) */
1799 item->level = donor->level; 1637 item->level = donor->level;
1800 1638
1801 /* if donor has some attacktypes, the flesh is poisonous */ 1639 /* if donor has some attacktypes, the flesh is poisonous */
1802 if (donor->attacktype & AT_POISON) 1640 if (donor->attacktype & AT_POISON)
1803 item->type = POISON; 1641 item->type = POISON;
1642
1804 if (donor->attacktype & AT_ACID) 1643 if (donor->attacktype & AT_ACID)
1805 item->stats.hp = -1 * item->stats.food; 1644 item->stats.hp = -item->stats.food;
1806 SET_FLAG (item, FLAG_NO_STEAL);
1807 }
1808}
1809 1645
1810/* special_potion() - so that old potion code is still done right. */ 1646 item->set_flag (FLAG_NO_STEAL);
1811 1647 }
1812int
1813special_potion (object *op)
1814{
1815
1816 int i;
1817
1818 if (op->attacktype)
1819 return 1;
1820
1821 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha)
1822 return 1;
1823
1824 for (i = 0; i < NROFATTACKS; i++)
1825 if (op->resist[i])
1826 return 1;
1827
1828 return 0;
1829} 1648}
1830 1649
1831void 1650static void
1832free_treasurestruct (treasure *t) 1651free_treasurestruct (treasure *t)
1833{ 1652{
1834 if (t->next)
1835 free_treasurestruct (t->next); 1653 if (t->next) free_treasurestruct (t->next);
1836 if (t->next_yes)
1837 free_treasurestruct (t->next_yes); 1654 if (t->next_yes) free_treasurestruct (t->next_yes);
1838 if (t->next_no)
1839 free_treasurestruct (t->next_no); 1655 if (t->next_no) free_treasurestruct (t->next_no);
1840 1656
1841 delete t; 1657 delete t;
1842} 1658}
1843 1659
1844void 1660static void
1845free_charlinks (linked_char *lc) 1661free_charlinks (linked_char *lc)
1846{ 1662{
1847 if (lc->next) 1663 if (lc->next)
1848 free_charlinks (lc->next); 1664 free_charlinks (lc->next);
1849 1665
1850 delete lc; 1666 delete lc;
1851} 1667}
1852 1668
1853void 1669static void
1854free_artifact (artifact * at) 1670free_artifact (artifact *at)
1855{ 1671{
1856 if (at->next)
1857 free_artifact (at->next); 1672 if (at->next) free_artifact (at->next);
1858
1859 if (at->allowed)
1860 free_charlinks (at->allowed); 1673 if (at->allowed) free_charlinks (at->allowed);
1861 1674
1862 at->item->destroy (1); 1675 at->item->destroy ();
1863 1676
1864 delete at;
1865}
1866
1867void
1868free_artifactlist (artifactlist * al)
1869{
1870 artifactlist *nextal;
1871
1872 for (al = first_artifactlist; al; al = nextal)
1873 {
1874 nextal = al->next;
1875
1876 if (al->items)
1877 free_artifact (al->items);
1878
1879 free (al); 1677 sfree (at);
1880 }
1881} 1678}
1882 1679
1883void
1884free_all_treasures (void)
1885{
1886 treasurelist *tl, *next;
1887
1888
1889 for (tl = first_treasurelist; tl != NULL; tl = next)
1890 {
1891 next = tl->next;
1892 if (tl->items)
1893 free_treasurestruct (tl->items);
1894 delete tl;
1895 }
1896 free_artifactlist (first_artifactlist);
1897}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines