ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/treasure.C
(Generate patch)

Comparing deliantra/server/common/treasure.C (file contents):
Revision 1.20 by root, Tue Sep 26 17:19:38 2006 UTC vs.
Revision 1.78 by root, Sun Jul 20 16:56:34 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 22 */
23
24#define ALLOWED_COMBINATION
25 23
26/* TREASURE_DEBUG does some checking on the treasurelists after loading. 24/* TREASURE_DEBUG does some checking on the treasurelists after loading.
27 * It is useful for finding bugs in the treasures file. Since it only 25 * It is useful for finding bugs in the treasures file. Since it only
28 * slows the startup some (and not actual game play), it is by default 26 * slows the startup some (and not actual game play), it is by default
29 * left on 27 * left on
30 */ 28 */
31#define TREASURE_DEBUG 29#define TREASURE_DEBUG
32 30
33/* TREASURE_VERBOSE enables copious output concerning artifact generation */ 31/* TREASURE_VERBOSE enables copious output concerning artifact generation */
34 32
35/* #define TREASURE_VERBOSE */ 33//#define TREASURE_VERBOSE
36 34
37#include <global.h> 35#include <global.h>
38#include <treasure.h> 36#include <treasure.h>
39#include <funcpoint.h>
40#include <loader.h> 37#include <loader.h>
41 38
39extern char *spell_mapping[];
40
41static treasurelist *first_treasurelist;
42 42
43static void change_treasure (treasure *t, object *op); /* overrule default values */ 43static void change_treasure (treasure *t, object *op); /* overrule default values */
44extern char *spell_mapping[];
45 44
46/* 45typedef std::tr1::unordered_map<
47 * Initialize global archtype pointers: 46 const char *,
48 */ 47 treasurelist *,
48 str_hash,
49 str_equal,
50 slice_allocator< std::pair<const char *const, treasurelist *> >,
51 true
52> tl_map_t;
49 53
54static tl_map_t tl_map;
55
56/*
57 * Searches for the given treasurelist
58 */
59treasurelist *
60treasurelist::find (const char *name)
61{
62 if (!name)
63 return 0;
64
65 auto (i, tl_map.find (name));
66
67 if (i == tl_map.end ())
68 return 0;
69
70 return i->second;
71}
72
73/*
74 * Searches for the given treasurelist in the globally linked list
75 * of treasurelists which has been built by load_treasures().
76 */
77treasurelist *
78treasurelist::get (const char *name)
79{
80 treasurelist *tl = find (name);
81
82 if (!tl)
83 {
84 tl = new treasurelist;
85
86 tl->name = name;
87 tl->next = first_treasurelist;
88 first_treasurelist = tl;
89
90 tl_map.insert (std::make_pair (tl->name, tl));
91 }
92
93 return tl;
94}
95
96//TODO: class method
50void 97void
51init_archetype_pointers () 98clear (treasurelist *tl)
52{ 99{
53 int prev_warn = warn_archetypes; 100 if (tl->items)
101 {
102 free_treasurestruct (tl->items);
103 tl->items = 0;
104 }
54 105
55 warn_archetypes = 1;
56 if (ring_arch == NULL)
57 ring_arch = archetype::find ("ring");
58 if (amulet_arch == NULL)
59 amulet_arch = archetype::find ("amulet");
60 if (staff_arch == NULL)
61 staff_arch = archetype::find ("staff");
62 if (crown_arch == NULL)
63 crown_arch = archetype::find ("crown");
64 warn_archetypes = prev_warn;
65}
66
67/*
68 * Allocate and return the pointer to an empty treasurelist structure.
69 */
70
71static treasurelist *
72get_empty_treasurelist (void)
73{
74 return new treasurelist;
75}
76
77/*
78 * Allocate and return the pointer to an empty treasure structure.
79 */
80//TODO: make this a constructor
81static treasure *
82get_empty_treasure (void)
83{
84 treasure *t = new treasure;
85
86 t->chance = 100; 106 tl->total_chance = 0;
87
88 return t;
89} 107}
108
109#ifdef TREASURE_DEBUG
110/* recursived checks the linked list. Treasurelist is passed only
111 * so that the treasure name can be printed out
112 */
113static void
114check_treasurelist (const treasure *t, const treasurelist * tl)
115{
116 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
117 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
118
119 if (t->next)
120 check_treasurelist (t->next, tl);
121
122 if (t->next_yes)
123 check_treasurelist (t->next_yes, tl);
124
125 if (t->next_no)
126 check_treasurelist (t->next_no, tl);
127}
128#endif
90 129
91/* 130/*
92 * Reads the lib/treasure file from disk, and parses the contents 131 * Reads the lib/treasure file from disk, and parses the contents
93 * into an internal treasure structure (very linked lists) 132 * into an internal treasure structure (very linked lists)
94 */ 133 */
95
96static treasure * 134static treasure *
97load_treasure (FILE * fp, int *line) 135read_treasure (object_thawer &f)
98{ 136{
99 char buf[MAX_BUF], *cp, variable[MAX_BUF];
100 treasure *t = get_empty_treasure (); 137 treasure *t = new treasure;
101 int value;
102 138
103 nroftreasures++; 139 f.next ();
104 while (fgets (buf, MAX_BUF, fp) != NULL)
105 {
106 (*line)++;
107 140
108 if (*buf == '#') 141 for (;;)
109 continue; 142 {
110 if ((cp = strchr (buf, '\n')) != NULL) 143 coroapi::cede_to_tick ();
111 *cp = '\0';
112 cp = buf;
113 while (isspace (*cp)) /* Skip blanks */
114 cp++;
115 144
116 if (sscanf (cp, "arch %s", variable)) 145 switch (f.kw)
117 {
118 if ((t->item = archetype::find (variable)) == NULL)
119 LOG (llevError, "Treasure lacks archetype: %s\n", variable);
120 } 146 {
121 else if (sscanf (cp, "list %s", variable)) 147 case KW_arch:
122 t->name = variable; 148 t->item = archetype::find (f.get_str ());
123 else if (sscanf (cp, "change_name %s", variable)) 149
124 t->change_arch.name = variable; 150 if (!t->item)
125 else if (sscanf (cp, "change_title %s", variable))
126 t->change_arch.title = variable;
127 else if (sscanf (cp, "change_slaying %s", variable))
128 t->change_arch.slaying = variable;
129 else if (sscanf (cp, "chance %d", &value))
130 t->chance = (uint8) value;
131 else if (sscanf (cp, "nrof %d", &value))
132 t->nrof = (uint16) value;
133 else if (sscanf (cp, "magic %d", &value))
134 t->magic = (uint8) value;
135 else if (!strcmp (cp, "yes"))
136 t->next_yes = load_treasure (fp, line);
137 else if (!strcmp (cp, "no"))
138 t->next_no = load_treasure (fp, line);
139 else if (!strcmp (cp, "end"))
140 return t;
141 else if (!strcmp (cp, "more"))
142 { 151 {
143 t->next = load_treasure (fp, line); 152 f.parse_warn ("treasure references unknown archetype");
153 t->item = archetype::empty;
154 }
155
156 break;
157
158 case KW_list: f.get (t->name); break;
159 case KW_change_name: f.get (t->change_arch.name); break;
160 case KW_change_title: f.get (t->change_arch.title); break;
161 case KW_change_slaying: f.get (t->change_arch.slaying); break;
162 case KW_chance: f.get (t->chance); break;
163 case KW_nrof: f.get (t->nrof); break;
164 case KW_magic: f.get (t->magic); break;
165
166 case KW_yes: t->next_yes = read_treasure (f); continue;
167 case KW_no: t->next_no = read_treasure (f); continue;
168
169 case KW_end:
170 f.next ();
144 return t; 171 return t;
172
173 case KW_more:
174 t->next = read_treasure (f);
175 return t;
176
177 default:
178 if (!f.parse_error ("treasurelist", t->name))
179 goto error;
180
181 return t;
145 } 182 }
146 else 183
147 LOG (llevError, "Unknown treasure-command: '%s', last entry %s, line %d\n", cp, &t->name, *line); 184 f.next ();
148 } 185 }
149 LOG (llevError, "treasure lacks 'end'.\n"); 186
187 // not reached
188
189error:
190 delete t;
150 return t; 191 return 0;
151} 192}
152 193
153#ifdef TREASURE_DEBUG
154
155/* recursived checks the linked list. Treasurelist is passed only
156 * so that the treasure name can be printed out
157 */
158static void
159check_treasurelist (const treasure *t, const treasurelist * tl)
160{
161 if (t->item == NULL && t->name == NULL)
162 LOG (llevError, "Treasurelist %s has element with no name or archetype\n", &tl->name);
163 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
164 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
165 /* find_treasurelist will print out its own error message */
166 if (t->name && *t->name)
167 (void) find_treasurelist (t->name);
168 if (t->next)
169 check_treasurelist (t->next, tl);
170 if (t->next_yes)
171 check_treasurelist (t->next_yes, tl);
172 if (t->next_no)
173 check_treasurelist (t->next_no, tl);
174}
175#endif
176
177/* 194/*
178 * Opens LIBDIR/treasure and reads all treasure-declarations from it.
179 * Each treasure is parsed with the help of load_treasure(). 195 * Each treasure is parsed with the help of load_treasure().
180 */ 196 */
181 197treasurelist *
182void 198treasurelist::read (object_thawer &f)
183load_treasures (void)
184{ 199{
185 FILE *fp; 200 assert (f.kw == KW_treasure || f.kw == KW_treasureone);
186 char filename[MAX_BUF], buf[MAX_BUF], name[MAX_BUF];
187 treasurelist *previous = NULL;
188 treasure *t;
189 int comp, line = 0;
190 201
191 sprintf (filename, "%s/%s", settings.datadir, settings.treasures); 202 bool one = f.kw == KW_treasureone;
192 if ((fp = open_and_uncompress (filename, 0, &comp)) == NULL) 203 treasurelist *tl = treasurelist::get (f.get_str ());
193 { 204 clear (tl);
194 LOG (llevError, "Can't open treasure file.\n"); 205 tl->items = read_treasure (f);
206 if (!tl->items)
195 return; 207 return 0;
196 }
197 while (fgets (buf, MAX_BUF, fp) != NULL)
198 {
199 line++;
200 if (*buf == '#')
201 continue;
202 208
203 if (sscanf (buf, "treasureone %s\n", name) || sscanf (buf, "treasure %s\n", name))
204 {
205 treasurelist *tl = get_empty_treasurelist ();
206
207 tl->name = name;
208 if (previous == NULL)
209 first_treasurelist = tl;
210 else
211 previous->next = tl;
212 previous = tl;
213 tl->items = load_treasure (fp, &line);
214
215 /* This is a one of the many items on the list should be generated. 209 /* This is a one of the many items on the list should be generated.
216 * Add up the chance total, and check to make sure the yes & no 210 * Add up the chance total, and check to make sure the yes & no
217 * fields of the treasures are not being used. 211 * fields of the treasures are not being used.
218 */ 212 */
219 if (!strncmp (buf, "treasureone", 11)) 213 if (one)
214 {
215 for (treasure *t = tl->items; t; t = t->next)
216 {
217 if (t->next_yes || t->next_no)
220 { 218 {
221 for (t = tl->items; t != NULL; t = t->next)
222 {
223#ifdef TREASURE_DEBUG
224 if (t->next_yes || t->next_no)
225 {
226 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->name : &t->name); 219 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->archname : &t->name);
227 LOG (llevError, " the next_yes or next_no field is set\n"); 220 LOG (llevError, " the next_yes or next_no field is set\n");
228 }
229#endif
230 tl->total_chance += t->chance;
231 }
232 } 221 }
233 }
234 else
235 LOG (llevError, "Treasure-list %s didn't understand: %s, line %d\n", filename, buf, line);
236 }
237 close_and_delete (fp, comp);
238 222
239#ifdef TREASURE_DEBUG 223 tl->total_chance += t->chance;
240 /* Perform some checks on how valid the treasure data actually is. 224 }
241 * verify that list transitions work (ie, the list that it is supposed 225 }
242 * to transition to exists). Also, verify that at least the name
243 * or archetype is set for each treasure element.
244 */
245 for (previous = first_treasurelist; previous != NULL; previous = previous->next)
246 check_treasurelist (previous->items, previous);
247#endif
248}
249 226
250/*
251 * Searches for the given treasurelist in the globally linked list
252 * of treasurelists which has been built by load_treasures().
253 */
254
255treasurelist *
256find_treasurelist (const char *name)
257{
258 shstr_cmp name_ (name);
259
260 if (!name_)
261 return 0;
262
263 for (treasurelist * tl = first_treasurelist; tl != 0; tl = tl->next)
264 if (name_ == tl->name)
265 return tl;
266
267 if (first_treasurelist)
268 LOG (llevError, "Couldn't find treasurelist %s\n", name);
269
270 return 0; 227 return tl;
271} 228}
272
273 229
274/* 230/*
275 * Generates the objects specified by the given treasure. 231 * Generates the objects specified by the given treasure.
276 * It goes recursively through the rest of the linked list. 232 * It goes recursively through the rest of the linked list.
277 * If there is a certain percental chance for a treasure to be generated, 233 * If there is a certain percental chance for a treasure to be generated,
280 * being generated. 236 * being generated.
281 * If flag is GT_INVISIBLE, only invisible objects are generated (ie, only 237 * If flag is GT_INVISIBLE, only invisible objects are generated (ie, only
282 * abilities. This is used by summon spells, thus no summoned monsters 238 * abilities. This is used by summon spells, thus no summoned monsters
283 * start with equipment, but only their abilities). 239 * start with equipment, but only their abilities).
284 */ 240 */
285
286
287static void 241static void
288put_treasure (object *op, object *creator, int flags) 242put_treasure (object *op, object *creator, int flags)
289{ 243{
290 object *tmp; 244 if (flags & GT_ENVIRONMENT)
291 245 {
292 /* Bit of a hack - spells should never be put onto the map. The entire 246 /* Bit of a hack - spells should never be put onto the map. The entire
293 * treasure stuff is a problem - there is no clear idea of knowing 247 * treasure stuff is a problem - there is no clear idea of knowing
294 * this is the original object, or if this is an object that should be created 248 * this is the original object, or if this is an object that should be created
295 * by another object. 249 * by another object.
296 */ 250 */
297 if (flags & GT_ENVIRONMENT && op->type != SPELL) 251 //TODO: flag such as objects... as such (no drop, anybody?)
298 { 252 if (op->type == SPELL)
299 op->x = creator->x; 253 {
300 op->y = creator->y; 254 op->destroy ();
255 return;
256 }
257
258 op->expand_tail ();
259
260 if (!creator->is_on_map () || op->blocked (creator->map, creator->x, creator->y))
261 op->destroy ();
262 else
263 {
301 SET_FLAG (op, FLAG_OBJ_ORIGINAL); 264 SET_FLAG (op, FLAG_OBJ_ORIGINAL);
302 insert_ob_in_map (op, creator->map, op, INS_NO_MERGE | INS_NO_WALK_ON); 265 op->insert_at (creator, creator, INS_NO_MERGE | INS_NO_WALK_ON);
266 }
303 } 267 }
304 else 268 else
305 { 269 {
306 op = insert_ob_in_ob (op, creator); 270 op = creator->insert (op);
271
307 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER)) 272 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER))
308 monster_check_apply (creator, op); 273 monster_check_apply (creator, op);
309 if ((flags & GT_UPDATE_INV) && (tmp = is_player_inv (creator)) != NULL)
310 esrv_send_item (tmp, op);
311 } 274 }
312} 275}
313 276
314/* if there are change_xxx commands in the treasure, we include the changes 277/* if there are change_xxx commands in the treasure, we include the changes
315 * in the generated object 278 * in the generated object
329 292
330 if (t->change_arch.slaying) 293 if (t->change_arch.slaying)
331 op->slaying = t->change_arch.slaying; 294 op->slaying = t->change_arch.slaying;
332} 295}
333 296
334void 297static void
335create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries) 298create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries)
336{ 299{
337 object *tmp;
338
339 if ((int) t->chance >= 100 || (RANDOM () % 100 + 1) < (int) t->chance) 300 if ((int) t->chance >= 100 || (rndm (100) + 1) < (int) t->chance)
340 { 301 {
341 if (t->name) 302 if (t->name)
342 { 303 {
343 if (strcmp (t->name, "NONE") && difficulty >= t->magic) 304 if (difficulty >= t->magic)
305 if (treasurelist *tl = treasurelist::find (t->name))
344 create_treasure (find_treasurelist (t->name), op, flag, difficulty, tries); 306 create_treasure (tl, op, flag, difficulty, tries);
307 else
308 LOG (llevError, "create_all_treasures: undefined reference to treasurelist '%s'.\n", &t->name);
345 } 309 }
346 else 310 else
347 { 311 {
348 if (t->item->clone.invisible != 0 || !(flag & GT_INVISIBLE)) 312 if (t->item && (t->item->invisible != 0 || !(flag & GT_INVISIBLE)))
349 { 313 {
350 tmp = arch_to_object (t->item); 314 object *tmp = arch_to_object (t->item);
315
351 if (t->nrof && tmp->nrof <= 1) 316 if (t->nrof && tmp->nrof <= 1)
352 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 317 tmp->nrof = rndm (t->nrof) + 1;
318
353 fix_generated_item (tmp, op, difficulty, t->magic, flag); 319 fix_generated_item (tmp, op, difficulty, t->magic, flag);
354 change_treasure (t, tmp); 320 change_treasure (t, tmp);
355 put_treasure (tmp, op, flag); 321 put_treasure (tmp, op, flag);
356 } 322 }
357 } 323 }
358 324
359 if (t->next_yes != NULL) 325 if (t->next_yes)
360 create_all_treasures (t->next_yes, op, flag, difficulty, tries); 326 create_all_treasures (t->next_yes, op, flag, difficulty, tries);
361 } 327 }
362 else if (t->next_no != NULL) 328 else if (t->next_no)
363 create_all_treasures (t->next_no, op, flag, difficulty, tries); 329 create_all_treasures (t->next_no, op, flag, difficulty, tries);
364 330
365 if (t->next != NULL) 331 if (t->next)
366 create_all_treasures (t->next, op, flag, difficulty, tries); 332 create_all_treasures (t->next, op, flag, difficulty, tries);
367} 333}
368 334
369void 335static void
370create_one_treasure (treasurelist * tl, object *op, int flag, int difficulty, int tries) 336create_one_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
371{ 337{
372 int value = RANDOM () % tl->total_chance; 338 int value = rndm (tl->total_chance);
373 treasure *t; 339 treasure *t;
374 340
375 if (tries++ > 100) 341 if (tries++ > 100)
376 { 342 {
377 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n"); 343 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n");
378 return; 344 return;
379 } 345 }
380 346
381 for (t = tl->items; t != NULL; t = t->next) 347 for (t = tl->items; t; t = t->next)
382 { 348 {
383 value -= t->chance; 349 value -= t->chance;
384 350
385 if (value < 0) 351 if (value < 0)
386 break; 352 break;
387 } 353 }
388 354
389 if (!t || value >= 0) 355 if (!t || value >= 0)
390 {
391 LOG (llevError, "create_one_treasure: got null object or not able to find treasure\n"); 356 cleanup ("create_one_treasure: got null object or not able to find treasure\n", 1);
392 abort ();
393 return;
394 }
395 357
396 if (t->name) 358 if (t->name)
397 { 359 {
398 if (!strcmp (t->name, "NONE"))
399 return;
400
401 if (difficulty >= t->magic) 360 if (difficulty >= t->magic)
361 {
362 treasurelist *tl = treasurelist::find (t->name);
363 if (tl)
402 create_treasure (find_treasurelist (t->name), op, flag, difficulty, tries); 364 create_treasure (tl, op, flag, difficulty, tries);
365 }
403 else if (t->nrof) 366 else if (t->nrof)
404 create_one_treasure (tl, op, flag, difficulty, tries); 367 create_one_treasure (tl, op, flag, difficulty, tries);
405
406 return;
407 } 368 }
408
409 if ((t->item && t->item->clone.invisible != 0) || flag != GT_INVISIBLE) 369 else if (t->item && (t->item->invisible != 0 || flag != GT_INVISIBLE))
410 { 370 {
411 object *tmp = arch_to_object (t->item); 371 if (object *tmp = arch_to_object (t->item))
412 372 {
413 if (!tmp)
414 return;
415
416 if (t->nrof && tmp->nrof <= 1) 373 if (t->nrof && tmp->nrof <= 1)
417 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 374 tmp->nrof = rndm (t->nrof) + 1;
418 375
419 fix_generated_item (tmp, op, difficulty, t->magic, flag); 376 fix_generated_item (tmp, op, difficulty, t->magic, flag);
420 change_treasure (t, tmp); 377 change_treasure (t, tmp);
421 put_treasure (tmp, op, flag); 378 put_treasure (tmp, op, flag);
379 }
422 } 380 }
381}
382
383void
384object::create_treasure (treasurelist *tl, int flags)
385{
386 ::create_treasure (tl, this, flags, map ? map->difficulty : 0);
423} 387}
424 388
425/* This calls the appropriate treasure creation function. tries is passed 389/* This calls the appropriate treasure creation function. tries is passed
426 * to determine how many list transitions or attempts to create treasure 390 * to determine how many list transitions or attempts to create treasure
427 * have been made. It is really in place to prevent infinite loops with 391 * have been made. It is really in place to prevent infinite loops with
428 * list transitions, or so that excessively good treasure will not be 392 * list transitions, or so that excessively good treasure will not be
429 * created on weak maps, because it will exceed the number of allowed tries 393 * created on weak maps, because it will exceed the number of allowed tries
430 * to do that. 394 * to do that.
431 */ 395 */
432void 396void
433create_treasure (treasurelist * t, object *op, int flag, int difficulty, int tries) 397create_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
434{ 398{
399 // empty treasurelists are legal
400 if (!tl->items)
401 return;
435 402
436 if (tries++ > 100) 403 if (tries++ > 100)
437 { 404 {
438 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n"); 405 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n");
439 return; 406 return;
440 } 407 }
408
409 if (op->flag [FLAG_TREASURE_ENV])
410 {
411 // do not generate items when there already is something above the object
412 if (op->flag [FLAG_IS_FLOOR] && op->above)
413 return;
414
415 flag |= GT_ENVIRONMENT;
416 }
417
441 if (t->total_chance) 418 if (tl->total_chance)
442 create_one_treasure (t, op, flag, difficulty, tries); 419 create_one_treasure (tl, op, flag, difficulty, tries);
443 else 420 else
444 create_all_treasures (t->items, op, flag, difficulty, tries); 421 create_all_treasures (tl->items, op, flag, difficulty, tries);
445} 422}
446 423
447/* This is similar to the old generate treasure function. However, 424/* This is similar to the old generate treasure function. However,
448 * it instead takes a treasurelist. It is really just a wrapper around 425 * it instead takes a treasurelist. It is really just a wrapper around
449 * create_treasure. We create a dummy object that the treasure gets 426 * create_treasure. We create a dummy object that the treasure gets
450 * inserted into, and then return that treausre 427 * inserted into, and then return that treausre
451 */ 428 */
452object * 429object *
453generate_treasure (treasurelist * t, int difficulty) 430generate_treasure (treasurelist *tl, int difficulty)
454{ 431{
455 object *ob = get_object (), *tmp; 432 difficulty = clamp (difficulty, 1, settings.max_level);
456 433
434 object *ob = object::create ();
435
457 create_treasure (t, ob, 0, difficulty, 0); 436 create_treasure (tl, ob, 0, difficulty, 0);
458 437
459 /* Don't want to free the object we are about to return */ 438 /* Don't want to free the object we are about to return */
460 tmp = ob->inv; 439 object *tmp = ob->inv;
461 if (tmp != NULL) 440 if (tmp)
462 remove_ob (tmp); 441 tmp->remove ();
442
463 if (ob->inv) 443 if (ob->inv)
464 {
465 LOG (llevError, "In generate treasure, created multiple objects.\n"); 444 LOG (llevError, "In generate treasure, created multiple objects.\n");
466 } 445
467 free_object (ob); 446 ob->destroy ();
468 return tmp; 447 return tmp;
469} 448}
470 449
471/* 450/*
472 * This is a new way of calculating the chance for an item to have 451 * This is a new way of calculating the chance for an item to have
474 * The array has two arguments, the difficulty of the level, and the 453 * The array has two arguments, the difficulty of the level, and the
475 * magical bonus "wanted". 454 * magical bonus "wanted".
476 */ 455 */
477 456
478static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = { 457static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = {
479
480/*chance of magic difficulty*/ 458// chance of magic difficulty
481
482/* +0 +1 +2 +3 +4 */ 459// +0 +1 +2 +3 +4
483 {95, 2, 2, 1, 0}, /*1 */ 460 {95, 2, 2, 1, 0}, // 1
484 {92, 5, 2, 1, 0}, /*2 */ 461 {92, 5, 2, 1, 0}, // 2
485 {85, 10, 4, 1, 0}, /*3 */ 462 {85, 10, 4, 1, 0}, // 3
486 {80, 14, 4, 2, 0}, /*4 */ 463 {80, 14, 4, 2, 0}, // 4
487 {75, 17, 5, 2, 1}, /*5 */ 464 {75, 17, 5, 2, 1}, // 5
488 {70, 18, 8, 3, 1}, /*6 */ 465 {70, 18, 8, 3, 1}, // 6
489 {65, 21, 10, 3, 1}, /*7 */ 466 {65, 21, 10, 3, 1}, // 7
490 {60, 22, 12, 4, 2}, /*8 */ 467 {60, 22, 12, 4, 2}, // 8
491 {55, 25, 14, 4, 2}, /*9 */ 468 {55, 25, 14, 4, 2}, // 9
492 {50, 27, 16, 5, 2}, /*10 */ 469 {50, 27, 16, 5, 2}, // 10
493 {45, 28, 18, 6, 3}, /*11 */ 470 {45, 28, 18, 6, 3}, // 11
494 {42, 28, 20, 7, 3}, /*12 */ 471 {42, 28, 20, 7, 3}, // 12
495 {40, 27, 21, 8, 4}, /*13 */ 472 {40, 27, 21, 8, 4}, // 13
496 {38, 25, 22, 10, 5}, /*14 */ 473 {38, 25, 22, 10, 5}, // 14
497 {36, 23, 23, 12, 6}, /*15 */ 474 {36, 23, 23, 12, 6}, // 15
498 {33, 21, 24, 14, 8}, /*16 */ 475 {33, 21, 24, 14, 8}, // 16
499 {31, 19, 25, 16, 9}, /*17 */ 476 {31, 19, 25, 16, 9}, // 17
500 {27, 15, 30, 18, 10}, /*18 */ 477 {27, 15, 30, 18, 10}, // 18
501 {20, 12, 30, 25, 13}, /*19 */ 478 {20, 12, 30, 25, 13}, // 19
502 {15, 10, 28, 30, 17}, /*20 */ 479 {15, 10, 28, 30, 17}, // 20
503 {13, 9, 27, 28, 23}, /*21 */ 480 {13, 9, 27, 28, 23}, // 21
504 {10, 8, 25, 28, 29}, /*22 */ 481 {10, 8, 25, 28, 29}, // 22
505 {8, 7, 23, 26, 36}, /*23 */ 482 { 8, 7, 23, 26, 36}, // 23
506 {6, 6, 20, 22, 46}, /*24 */ 483 { 6, 6, 20, 22, 46}, // 24
507 {4, 5, 17, 18, 56}, /*25 */ 484 { 4, 5, 17, 18, 56}, // 25
508 {2, 4, 12, 14, 68}, /*26 */ 485 { 2, 4, 12, 14, 68}, // 26
509 {0, 3, 7, 10, 80}, /*27 */ 486 { 0, 3, 7, 10, 80}, // 27
510 {0, 0, 3, 7, 90}, /*28 */ 487 { 0, 0, 3, 7, 90}, // 28
511 {0, 0, 0, 3, 97}, /*29 */ 488 { 0, 0, 0, 3, 97}, // 29
512 {0, 0, 0, 0, 100}, /*30 */ 489 { 0, 0, 0, 0, 100}, // 30
513 {0, 0, 0, 0, 100}, /*31 */ 490 { 0, 0, 0, 0, 100}, // 31
514}; 491};
515
516 492
517/* calculate the appropriate level for wands staves and scrolls. 493/* calculate the appropriate level for wands staves and scrolls.
518 * This code presumes that op has had its spell object created (in op->inv) 494 * This code presumes that op has had its spell object created (in op->inv)
519 * 495 *
520 * elmex Wed Aug 9 17:44:59 CEST 2006: 496 * elmex Wed Aug 9 17:44:59 CEST 2006:
521 * Removed multiplicator, too many high-level items were generated on low-difficulty maps. 497 * Removed multiplicator, too many high-level items were generated on low-difficulty maps.
522 */ 498 */
523
524int 499int
525level_for_item (const object *op, int difficulty) 500level_for_item (const object *op, int difficulty)
526{ 501{
527 int olevel = 0;
528
529 if (!op->inv) 502 if (!op->inv)
530 { 503 {
531 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name); 504 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name);
532 return 0; 505 return 0;
533 } 506 }
534 507
535 olevel = (int) (op->inv->level + (double) difficulty * (1 - drand48 () * drand48 () * 2)); 508 int olevel = op->inv->level + int (difficulty * (1. - rndm () * rndm () * 2.));
536 509
537 if (olevel <= 0) 510 if (olevel <= 0)
538 olevel = rndm (1, MIN (op->inv->level, 1)); 511 olevel = rndm (1, op->inv->level);
539 512
540 if (olevel > MAXLEVEL) 513 return min (olevel, MAXLEVEL);
541 olevel = MAXLEVEL;
542
543 return olevel;
544} 514}
545 515
546/* 516/*
547 * Based upon the specified difficulty and upon the difftomagic_list array, 517 * Based upon the specified difficulty and upon the difftomagic_list array,
548 * a random magical bonus is returned. This is used when determine 518 * a random magical bonus is returned. This is used when determine
551 * elmex Thu Aug 10 18:45:44 CEST 2006: 521 * elmex Thu Aug 10 18:45:44 CEST 2006:
552 * Scaling difficulty by max_level, as difficulty is a level and not some 522 * Scaling difficulty by max_level, as difficulty is a level and not some
553 * weird integer between 1-31. 523 * weird integer between 1-31.
554 * 524 *
555 */ 525 */
556
557int 526int
558magic_from_difficulty (int difficulty) 527magic_from_difficulty (int difficulty)
559{ 528{
560 int percent = 0, magic = 0; 529 int percent = 0, magic = 0;
561 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS); 530 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS);
566 scaled_diff = 0; 535 scaled_diff = 0;
567 536
568 if (scaled_diff >= DIFFLEVELS) 537 if (scaled_diff >= DIFFLEVELS)
569 scaled_diff = DIFFLEVELS - 1; 538 scaled_diff = DIFFLEVELS - 1;
570 539
571 percent = RANDOM () % 100; 540 percent = rndm (100);
572 541
573 for (magic = 0; magic < (MAXMAGIC + 1); magic++) 542 for (magic = 0; magic < (MAXMAGIC + 1); magic++)
574 { 543 {
575 percent -= difftomagic_list[scaled_diff][magic]; 544 percent -= difftomagic_list[scaled_diff][magic];
576 545
582 { 551 {
583 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty); 552 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty);
584 magic = 0; 553 magic = 0;
585 } 554 }
586 555
587 magic = (RANDOM () % 3) ? magic : -magic; 556 magic = (rndm (3)) ? magic : -magic;
588 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */ 557 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */
589 558
590 return magic; 559 return magic;
591} 560}
592 561
605 574
606 op->magic = magic; 575 op->magic = magic;
607 if (op->arch) 576 if (op->arch)
608 { 577 {
609 if (op->type == ARMOUR) 578 if (op->type == ARMOUR)
610 ARMOUR_SPEED (op) = (ARMOUR_SPEED (&op->arch->clone) * (100 + magic * 10)) / 100; 579 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op->arch) * (100 + magic * 10)) / 100;
611 580
612 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 581 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
613 magic = (-magic); 582 magic = (-magic);
583
614 op->weight = (op->arch->clone.weight * (100 - magic * 10)) / 100; 584 op->weight = (op->arch->weight * (100 - magic * 10)) / 100;
615 } 585 }
616 else 586 else
617 { 587 {
618 if (op->type == ARMOUR) 588 if (op->type == ARMOUR)
619 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100; 589 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100;
590
620 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 591 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
621 magic = (-magic); 592 magic = (-magic);
593
622 op->weight = (op->weight * (100 - magic * 10)) / 100; 594 op->weight = (op->weight * (100 - magic * 10)) / 100;
623 } 595 }
624} 596}
625 597
626/* 598/*
649 * 1) Since rings can have multiple bonuses, if the same bonus 621 * 1) Since rings can have multiple bonuses, if the same bonus
650 * is rolled again, increase it - the bonuses now stack with 622 * is rolled again, increase it - the bonuses now stack with
651 * other bonuses previously rolled and ones the item might natively have. 623 * other bonuses previously rolled and ones the item might natively have.
652 * 2) Add code to deal with new PR method. 624 * 2) Add code to deal with new PR method.
653 */ 625 */
654
655void 626void
656set_ring_bonus (object *op, int bonus) 627set_ring_bonus (object *op, int bonus)
657{ 628{
658 629
659 int r = RANDOM () % (bonus > 0 ? 25 : 11); 630 int r = rndm (bonus > 0 ? 25 : 11);
660 631
661 if (op->type == AMULET) 632 if (op->type == AMULET)
662 { 633 {
663 if (!(RANDOM () % 21)) 634 if (!(rndm (21)))
664 r = 20 + RANDOM () % 2; 635 r = 20 + rndm (2);
665 else 636 else
666 { 637 {
667 if (RANDOM () & 2) 638 if (rndm (2))
668 r = 10; 639 r = 10;
669 else 640 else
670 r = 11 + RANDOM () % 9; 641 r = 11 + rndm (9);
671 } 642 }
672 } 643 }
673 644
674 switch (r) 645 switch (r)
675 { 646 {
682 case 2: 653 case 2:
683 case 3: 654 case 3:
684 case 4: 655 case 4:
685 case 5: 656 case 5:
686 case 6: 657 case 6:
687 set_attr_value (&op->stats, r, (signed char) (bonus + get_attr_value (&op->stats, r))); 658 op->stats.stat (r) += bonus;
688 break; 659 break;
689 660
690 case 7: 661 case 7:
691 op->stats.dam += bonus; 662 op->stats.dam += bonus;
692 break; 663 break;
712 case 16: 683 case 16:
713 case 17: 684 case 17:
714 case 18: 685 case 18:
715 case 19: 686 case 19:
716 { 687 {
717 int b = 5 + FABS (bonus), val, resist = RANDOM () % num_resist_table; 688 int b = 5 + abs (bonus), val, resist = rndm (num_resist_table);
718 689
719 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */ 690 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */
720 val = 10 + RANDOM () % b + RANDOM () % b + RANDOM () % b + RANDOM () % b; 691 val = 10 + rndm (b) + rndm (b) + rndm (b) + rndm (b);
721 692
722 /* Cursed items need to have higher negative values to equal out with 693 /* Cursed items need to have higher negative values to equal out with
723 * positive values for how protections work out. Put another 694 * positive values for how protections work out. Put another
724 * little random element in since that they don't always end up with 695 * little random element in since that they don't always end up with
725 * even values. 696 * even values.
726 */ 697 */
727 if (bonus < 0) 698 if (bonus < 0)
728 val = 2 * -val - RANDOM () % b; 699 val = 2 * -val - rndm (b);
729 if (val > 35) 700 if (val > 35)
730 val = 35; /* Upper limit */ 701 val = 35; /* Upper limit */
731 b = 0; 702 b = 0;
703
732 while (op->resist[resist_table[resist]] != 0 && b < 4) 704 while (op->resist[resist_table[resist]] != 0 && b < 4)
733 {
734 resist = RANDOM () % num_resist_table; 705 resist = rndm (num_resist_table);
735 } 706
736 if (b == 4) 707 if (b == 4)
737 return; /* Not able to find a free resistance */ 708 return; /* Not able to find a free resistance */
709
738 op->resist[resist_table[resist]] = val; 710 op->resist[resist_table[resist]] = val;
739 /* We should probably do something more clever here to adjust value 711 /* We should probably do something more clever here to adjust value
740 * based on how good a resistance we gave. 712 * based on how good a resistance we gave.
741 */ 713 */
742 break; 714 break;
770 case 22: 742 case 22:
771 op->stats.exp += bonus; /* Speed! */ 743 op->stats.exp += bonus; /* Speed! */
772 op->value = (op->value * 2) / 3; 744 op->value = (op->value * 2) / 3;
773 break; 745 break;
774 } 746 }
747
775 if (bonus > 0) 748 if (bonus > 0)
776 op->value *= 2 * bonus; 749 op->value *= 2 * bonus;
777 else 750 else
778 op->value = -(op->value * 2 * bonus) / 3; 751 op->value = -(op->value * 2 * bonus) / 3;
779} 752}
784 * higher is the chance of returning a low number. 757 * higher is the chance of returning a low number.
785 * It is only used in fix_generated_treasure() to set bonuses on 758 * It is only used in fix_generated_treasure() to set bonuses on
786 * rings and amulets. 759 * rings and amulets.
787 * Another scheme is used to calculate the magic of weapons and armours. 760 * Another scheme is used to calculate the magic of weapons and armours.
788 */ 761 */
789
790int 762int
791get_magic (int diff) 763get_magic (int diff)
792{ 764{
793 int i; 765 int i;
794 766
795 if (diff < 3) 767 if (diff < 3)
796 diff = 3; 768 diff = 3;
769
797 for (i = 0; i < 4; i++) 770 for (i = 0; i < 4; i++)
798 if (RANDOM () % diff) 771 if (rndm (diff))
799 return i; 772 return i;
773
800 return 4; 774 return 4;
801} 775}
802 776
803#define DICE2 (get_magic(2)==2?2:1) 777#define DICE2 (get_magic(2)==2?2:1)
804#define DICESPELL (RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3) 778#define DICESPELL (rndm (3) + rndm (3) + rndm (3) + rndm (3) + rndm (3))
805 779
806/* 780/*
807 * fix_generated_item(): This is called after an item is generated, in 781 * fix_generated_item(): This is called after an item is generated, in
808 * order to set it up right. This produced magical bonuses, puts spells 782 * order to set it up right. This produced magical bonuses, puts spells
809 * into scrolls/books/wands, makes it unidentified, hides the value, etc. 783 * into scrolls/books/wands, makes it unidentified, hides the value, etc.
823 * value. 797 * value.
824 * GT_MINIMAL: Does minimal processing on the object - just enough to make it 798 * GT_MINIMAL: Does minimal processing on the object - just enough to make it
825 * a working object - don't change magic, value, etc, but set it material 799 * a working object - don't change magic, value, etc, but set it material
826 * type as appropriate, for objects that need spell objects, set those, etc 800 * type as appropriate, for objects that need spell objects, set those, etc
827 */ 801 */
828
829void 802void
830fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags) 803fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags)
831{ 804{
832 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0; 805 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0;
833 806
838 save_item_power = op->item_power; 811 save_item_power = op->item_power;
839 op->item_power = 0; 812 op->item_power = 0;
840 813
841 if (op->randomitems && op->type != SPELL) 814 if (op->randomitems && op->type != SPELL)
842 { 815 {
843 create_treasure (op->randomitems, op, flags, difficulty, 0); 816 create_treasure (op->randomitems, op, flags & ~GT_ENVIRONMENT, difficulty, 0);
844 if (!op->inv)
845 LOG (llevDebug, "fix_generated_item: Unable to generate treasure for %s\n", &op->name);
846
847 /* So the treasure doesn't get created again */ 817 /* So the treasure doesn't get created again */
848 op->randomitems = NULL; 818 op->randomitems = 0;
849 } 819 }
850 820
851 if (difficulty < 1) 821 if (difficulty < 1)
852 difficulty = 1; 822 difficulty = 1;
853 823
824 if (INVOKE_OBJECT (ADD_BONUS, op,
825 ARG_OBJECT (creator != op ? creator : 0),
826 ARG_INT (difficulty), ARG_INT (max_magic),
827 ARG_INT (flags)))
828 return;
829
854 if (!(flags & GT_MINIMAL)) 830 if (!(flags & GT_MINIMAL))
855 { 831 {
856 if (op->arch == crown_arch) 832 if (IS_ARCH (op->arch, crown))
857 { 833 {
858 set_magic (difficulty, op, max_magic, flags); 834 set_magic (difficulty, op, max_magic, flags);
859 num_enchantments = calc_item_power (op, 1); 835 num_enchantments = calc_item_power (op, 1);
860 generate_artifact (op, difficulty); 836 generate_artifact (op, difficulty);
861 } 837 }
864 if (!op->magic && max_magic) 840 if (!op->magic && max_magic)
865 set_magic (difficulty, op, max_magic, flags); 841 set_magic (difficulty, op, max_magic, flags);
866 842
867 num_enchantments = calc_item_power (op, 1); 843 num_enchantments = calc_item_power (op, 1);
868 844
869 if ((!was_magic && !(RANDOM () % CHANCE_FOR_ARTIFACT)) || op->type == HORN || difficulty >= settings.max_level) /* high difficulties always generate an artifact, 845 if ((!was_magic && !rndm (CHANCE_FOR_ARTIFACT))
870 * used for shop_floors or treasures */ 846 || op->type == HORN
847 || difficulty >= settings.max_level) /* high difficulties always generate an artifact, used for shop_floors or treasures */
871 generate_artifact (op, difficulty); 848 generate_artifact (op, difficulty);
872 } 849 }
873 850
874 /* Object was made an artifact. Calculate its item_power rating. 851 /* Object was made an artifact. Calculate its item_power rating.
875 * the item_power in the object is what the artfiact adds. 852 * the item_power in the object is what the artfiact adds.
917 { 894 {
918 if (op->type == POTION) 895 if (op->type == POTION)
919 /* Handle healing and magic power potions */ 896 /* Handle healing and magic power potions */
920 if (op->stats.sp && !op->randomitems) 897 if (op->stats.sp && !op->randomitems)
921 { 898 {
922 object *tmp;
923
924 tmp = get_archetype (spell_mapping[op->stats.sp]); 899 object *tmp = get_archetype (spell_mapping [op->stats.sp]);
925 insert_ob_in_ob (tmp, op); 900 insert_ob_in_ob (tmp, op);
926 op->stats.sp = 0; 901 op->stats.sp = 0;
927 } 902 }
928 } 903 }
929 else if (!op->title) /* Only modify object if not special */ 904 else if (!op->title) /* Only modify object if not special */
932 case WEAPON: 907 case WEAPON:
933 case ARMOUR: 908 case ARMOUR:
934 case SHIELD: 909 case SHIELD:
935 case HELMET: 910 case HELMET:
936 case CLOAK: 911 case CLOAK:
937 if (QUERY_FLAG (op, FLAG_CURSED) && !(RANDOM () % 4)) 912 if (QUERY_FLAG (op, FLAG_CURSED) && !(rndm (4)))
938 set_ring_bonus (op, -DICE2); 913 set_ring_bonus (op, -DICE2);
939 break; 914 break;
940 915
941 case BRACERS: 916 case BRACERS:
942 if (!(RANDOM () % (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))) 917 if (!rndm (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))
943 { 918 {
944 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 919 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
945 if (!QUERY_FLAG (op, FLAG_CURSED)) 920 if (!QUERY_FLAG (op, FLAG_CURSED))
946 op->value *= 3; 921 op->value *= 3;
947 } 922 }
973 */ 948 */
974 if (op->inv && op->randomitems) 949 if (op->inv && op->randomitems)
975 { 950 {
976 /* value multiplier is same as for scrolls */ 951 /* value multiplier is same as for scrolls */
977 op->value = (op->value * op->inv->value); 952 op->value = (op->value * op->inv->value);
978 op->level = op->inv->level / 2 + RANDOM () % difficulty + RANDOM () % difficulty; 953 op->level = op->inv->level / 2 + rndm (difficulty) + rndm (difficulty);
979 } 954 }
980 else 955 else
981 { 956 {
982 op->name = "potion"; 957 op->name = "potion";
983 op->name_pl = "potions"; 958 op->name_pl = "potions";
984 } 959 }
985 960
986 if (!(flags & GT_ONLY_GOOD) && RANDOM () % 2) 961 if (!(flags & GT_ONLY_GOOD) && rndm (2))
987 SET_FLAG (op, FLAG_CURSED); 962 SET_FLAG (op, FLAG_CURSED);
988 break; 963 break;
989 } 964 }
990 965
991 case AMULET: 966 case AMULET:
992 if (op->arch == amulet_arch) 967 if (IS_ARCH (op->arch, amulet))
993 op->value *= 5; /* Since it's not just decoration */ 968 op->value *= 5; /* Since it's not just decoration */
994 969
995 case RING: 970 case RING:
996 if (op->arch == NULL) 971 if (!op->arch) // wtf? schmorp
997 { 972 {
998 remove_ob (op); 973 op->destroy ();
999 free_object (op);
1000 op = NULL; 974 op = 0;
1001 break; 975 break;
1002 } 976 }
1003 977
1004 if (op->arch != ring_arch && op->arch != amulet_arch) /* It's a special artifact! */ 978 if (!IS_ARCH (op->arch, ring) && !IS_ARCH (op->arch, amulet)) /* It's a special artifact! */
1005 break; 979 break;
1006 980
1007 if (!(flags & GT_ONLY_GOOD) && !(RANDOM () % 3)) 981 if (!(flags & GT_ONLY_GOOD) && !(rndm (3)))
1008 SET_FLAG (op, FLAG_CURSED); 982 SET_FLAG (op, FLAG_CURSED);
1009 983
1010 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 984 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
1011 985
1012 if (op->type != RING) /* Amulets have only one ability */ 986 if (op->type != RING) /* Amulets have only one ability */
1013 break; 987 break;
1014 988
1015 if (!(RANDOM () % 4)) 989 if (!(rndm (4)))
1016 { 990 {
1017 int d = (RANDOM () % 2 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 991 int d = (rndm (2) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1018 992
1019 if (d > 0) 993 if (d > 0)
1020 op->value *= 3; 994 op->value *= 3;
1021 995
1022 set_ring_bonus (op, d); 996 set_ring_bonus (op, d);
1023 997
1024 if (!(RANDOM () % 4)) 998 if (!(rndm (4)))
1025 { 999 {
1026 int d = (RANDOM () % 3 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 1000 int d = (rndm (3) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1027 1001
1028 if (d > 0) 1002 if (d > 0)
1029 op->value *= 5; 1003 op->value *= 5;
1030 set_ring_bonus (op, d); 1004 set_ring_bonus (op, d);
1031 } 1005 }
1032 } 1006 }
1033 1007
1034 if (GET_ANIM_ID (op)) 1008 if (GET_ANIM_ID (op))
1035 SET_ANIMATION (op, RANDOM () % ((int) NUM_ANIMATIONS (op))); 1009 SET_ANIMATION (op, rndm (NUM_ANIMATIONS (op)));
1036 1010
1037 break; 1011 break;
1038 1012
1039 case BOOK: 1013 case BOOK:
1040 /* Is it an empty book?, if yes lets make a special· 1014 /* Is it an empty book?, if yes lets make a special·
1041 * msg for it, and tailor its properties based on the· 1015 * msg for it, and tailor its properties based on the·
1042 * creator and/or map level we found it on. 1016 * creator and/or map level we found it on.
1043 */ 1017 */
1044 if (!op->msg && RANDOM () % 10) 1018 if (!op->msg && rndm (10))
1045 { 1019 {
1046 /* set the book level properly */ 1020 /* set the book level properly */
1047 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE)) 1021 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE))
1048 { 1022 {
1049 if (op->map && op->map->difficulty) 1023 if (op->map && op->map->difficulty)
1050 op->level = RANDOM () % (op->map->difficulty) + RANDOM () % 10 + 1; 1024 op->level = rndm (op->map->difficulty) + rndm (10) + 1;
1051 else 1025 else
1052 op->level = RANDOM () % 20 + 1; 1026 op->level = rndm (20) + 1;
1053 } 1027 }
1054 else 1028 else
1055 op->level = RANDOM () % creator->level; 1029 op->level = rndm (creator->level);
1056 1030
1057 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1); 1031 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1);
1058 /* books w/ info are worth more! */ 1032 /* books w/ info are worth more! */
1059 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1)); 1033 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1));
1060 /* creator related stuff */ 1034 /* creator related stuff */
1159 */ 1133 */
1160 1134
1161/* 1135/*
1162 * Allocate and return the pointer to an empty artifactlist structure. 1136 * Allocate and return the pointer to an empty artifactlist structure.
1163 */ 1137 */
1164
1165static artifactlist * 1138static artifactlist *
1166get_empty_artifactlist (void) 1139get_empty_artifactlist (void)
1167{ 1140{
1168 artifactlist *tl = (artifactlist *) malloc (sizeof (artifactlist)); 1141 return salloc0<artifactlist> ();
1169
1170 if (tl == NULL)
1171 fatal (OUT_OF_MEMORY);
1172 tl->next = NULL;
1173 tl->items = NULL;
1174 tl->total_chance = 0;
1175 return tl;
1176} 1142}
1177 1143
1178/* 1144/*
1179 * Allocate and return the pointer to an empty artifact structure. 1145 * Allocate and return the pointer to an empty artifact structure.
1180 */ 1146 */
1181
1182static artifact * 1147static artifact *
1183get_empty_artifact (void) 1148get_empty_artifact (void)
1184{ 1149{
1185 artifact *t = (artifact *) malloc (sizeof (artifact)); 1150 return salloc0<artifact> ();
1186
1187 if (t == NULL)
1188 fatal (OUT_OF_MEMORY);
1189 t->item = NULL;
1190 t->next = NULL;
1191 t->chance = 0;
1192 t->difficulty = 0;
1193 t->allowed = NULL;
1194 return t;
1195} 1151}
1196 1152
1197/* 1153/*
1198 * Searches the artifact lists and returns one that has the same type 1154 * Searches the artifact lists and returns one that has the same type
1199 * of objects on it. 1155 * of objects on it.
1200 */ 1156 */
1201
1202artifactlist * 1157artifactlist *
1203find_artifactlist (int type) 1158find_artifactlist (int type)
1204{ 1159{
1205 artifactlist *al;
1206
1207 for (al = first_artifactlist; al != NULL; al = al->next) 1160 for (artifactlist *al = first_artifactlist; al; al = al->next)
1208 if (al->type == type) 1161 if (al->type == type)
1209 return al; 1162 return al;
1210 return NULL;
1211}
1212 1163
1213/*
1214 * For debugging purposes. Dumps all tables.
1215 */
1216
1217void
1218dump_artifacts (void)
1219{
1220 artifactlist *al;
1221 artifact *art;
1222 linked_char *next;
1223
1224 fprintf (logfile, "\n");
1225 for (al = first_artifactlist; al != NULL; al = al->next)
1226 {
1227 fprintf (logfile, "Artifact has type %d, total_chance=%d\n", al->type, al->total_chance);
1228 for (art = al->items; art != NULL; art = art->next)
1229 {
1230 fprintf (logfile, "Artifact %-30s Difficulty %3d Chance %5d\n", &art->item->name, art->difficulty, art->chance);
1231 if (art->allowed != NULL)
1232 {
1233 fprintf (logfile, "\tAllowed combinations:");
1234 for (next = art->allowed; next != NULL; next = next->next)
1235 fprintf (logfile, "%s,", &next->name);
1236 fprintf (logfile, "\n");
1237 }
1238 }
1239 }
1240 fprintf (logfile, "\n");
1241}
1242
1243/*
1244 * For debugging purposes. Dumps all treasures recursively (see below).
1245 */
1246void
1247dump_monster_treasure_rec (const char *name, treasure *t, int depth)
1248{
1249 treasurelist *tl;
1250 int i;
1251
1252 if (depth > 100)
1253 return; 1164 return 0;
1254 while (t != NULL)
1255 {
1256 if (t->name != NULL)
1257 {
1258 for (i = 0; i < depth; i++)
1259 fprintf (logfile, " ");
1260 fprintf (logfile, "{ (list: %s)\n", &t->name);
1261 tl = find_treasurelist (t->name);
1262 dump_monster_treasure_rec (name, tl->items, depth + 2);
1263 for (i = 0; i < depth; i++)
1264 fprintf (logfile, " ");
1265 fprintf (logfile, "} (end of list: %s)\n", &t->name);
1266 }
1267 else
1268 {
1269 for (i = 0; i < depth; i++)
1270 fprintf (logfile, " ");
1271 if (t->item->clone.type == FLESH)
1272 fprintf (logfile, "%s's %s\n", name, &t->item->clone.name);
1273 else
1274 fprintf (logfile, "%s\n", &t->item->clone.name);
1275 }
1276 if (t->next_yes != NULL)
1277 {
1278 for (i = 0; i < depth; i++)
1279 fprintf (logfile, " ");
1280 fprintf (logfile, " (if yes)\n");
1281 dump_monster_treasure_rec (name, t->next_yes, depth + 1);
1282 }
1283 if (t->next_no != NULL)
1284 {
1285 for (i = 0; i < depth; i++)
1286 fprintf (logfile, " ");
1287 fprintf (logfile, " (if no)\n");
1288 dump_monster_treasure_rec (name, t->next_no, depth + 1);
1289 }
1290 t = t->next;
1291 }
1292}
1293
1294/*
1295 * For debugging purposes. Dumps all treasures for a given monster.
1296 * Created originally by Raphael Quinet for debugging the alchemy code.
1297 */
1298
1299void
1300dump_monster_treasure (const char *name)
1301{
1302 archetype *at;
1303 int found;
1304
1305 found = 0;
1306 fprintf (logfile, "\n");
1307 for (at = first_archetype; at != NULL; at = at->next)
1308 if (!strcasecmp (at->clone.name, name) && at->clone.title == NULL)
1309 {
1310 fprintf (logfile, "treasures for %s (arch: %s)\n", &at->clone.name, &at->name);
1311 if (at->clone.randomitems != NULL)
1312 dump_monster_treasure_rec (at->clone.name, at->clone.randomitems->items, 1);
1313 else
1314 fprintf (logfile, "(nothing)\n");
1315 fprintf (logfile, "\n");
1316 found++;
1317 }
1318 if (found == 0)
1319 fprintf (logfile, "No objects have the name %s!\n\n", name);
1320} 1165}
1321 1166
1322/* 1167/*
1323 * Builds up the lists of artifacts from the file in the libdir. 1168 * Builds up the lists of artifacts from the file in the libdir.
1324 */ 1169 */
1325
1326void 1170void
1327init_artifacts (void) 1171init_artifacts (void)
1328{ 1172{
1329 static int has_been_inited = 0; 1173 static int has_been_inited = 0;
1330 char filename[MAX_BUF], buf[HUGE_BUF], *cp, *next; 1174 char filename[MAX_BUF];
1331 artifact *art = NULL; 1175 artifact *art = NULL;
1332 linked_char *tmp;
1333 int value;
1334 artifactlist *al; 1176 artifactlist *al;
1335 1177
1336 if (has_been_inited) 1178 if (has_been_inited)
1337 return; 1179 return;
1338 else 1180 else
1339 has_been_inited = 1; 1181 has_been_inited = 1;
1340 1182
1341 sprintf (filename, "%s/artifacts", settings.datadir); 1183 sprintf (filename, "%s/artifacts", settings.datadir);
1342 object_thawer thawer (filename); 1184 object_thawer f (filename);
1343 1185
1344 if (!thawer) 1186 if (!f)
1345 return; 1187 return;
1346 1188
1347 while (fgets (buf, HUGE_BUF, thawer) != NULL) 1189 for (;;)
1348 { 1190 {
1349 if (*buf == '#') 1191 switch (f.kw)
1350 continue;
1351 if ((cp = strchr (buf, '\n')) != NULL)
1352 *cp = '\0';
1353 cp = buf;
1354 while (*cp == ' ') /* Skip blanks */
1355 cp++;
1356 if (*cp == '\0')
1357 continue;
1358
1359 if (!strncmp (cp, "Allowed", 7))
1360 { 1192 {
1193 case KW_allowed:
1361 if (art == NULL) 1194 if (!art)
1195 art = get_empty_artifact ();
1196
1362 { 1197 {
1363 art = get_empty_artifact (); 1198 if (!strcmp (f.get_str (), "all"))
1364 nrofartifacts++; 1199 break;
1200
1201 char *next, *cp = f.get_str ();
1202
1203 do
1204 {
1205 if ((next = strchr (cp, ',')))
1206 *next++ = '\0';
1207
1208 linked_char *tmp = new linked_char;
1209
1210 tmp->name = cp;
1211 tmp->next = art->allowed;
1212 art->allowed = tmp;
1213 }
1214 while ((cp = next));
1365 } 1215 }
1366 cp = strchr (cp, ' ') + 1; 1216 break;
1367 if (!strcmp (cp, "all")) 1217
1218 case KW_chance:
1219 f.get (art->chance);
1220 break;
1221
1222 case KW_difficulty:
1223 f.get (art->difficulty);
1224 break;
1225
1226 case KW_object:
1227 {
1228 art->item = object::create ();
1229 f.get (art->item->name);
1230 f.next ();
1231
1232 if (!art->item->parse_kv (f))
1233 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1234
1235 al = find_artifactlist (art->item->type);
1236
1237 if (!al)
1238 {
1239 al = get_empty_artifactlist ();
1240 al->type = art->item->type;
1241 al->next = first_artifactlist;
1242 first_artifactlist = al;
1243 }
1244
1245 art->next = al->items;
1246 al->items = art;
1247 art = 0;
1248 }
1368 continue; 1249 continue;
1369 1250
1370 do 1251 case KW_EOF:
1252 goto done;
1253
1254 default:
1255 if (!f.parse_error ("artifacts file"))
1256 cleanup ("artifacts file required");
1371 { 1257 break;
1372 nrofallowedstr++;
1373 if ((next = strchr (cp, ',')) != NULL)
1374 *(next++) = '\0';
1375 tmp = new linked_char;
1376
1377 tmp->name = cp;
1378 tmp->next = art->allowed;
1379 art->allowed = tmp;
1380 }
1381 while ((cp = next) != NULL);
1382 }
1383 else if (sscanf (cp, "chance %d", &value))
1384 art->chance = (uint16) value;
1385 else if (sscanf (cp, "difficulty %d", &value))
1386 art->difficulty = (uint8) value;
1387 else if (!strncmp (cp, "Object", 6))
1388 { 1258 }
1389 art->item = get_object ();
1390 1259
1391 if (!load_object (thawer, art->item, 0)) 1260 f.next ();
1392 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1393
1394 art->item->name = strchr (cp, ' ') + 1;
1395 al = find_artifactlist (art->item->type);
1396 if (al == NULL)
1397 {
1398 al = get_empty_artifactlist ();
1399 al->type = art->item->type;
1400 al->next = first_artifactlist;
1401 first_artifactlist = al;
1402 }
1403 art->next = al->items;
1404 al->items = art;
1405 art = NULL;
1406 }
1407 else
1408 LOG (llevError, "Unknown input in artifact file: %s\n", buf);
1409 } 1261 }
1410 1262
1263done:
1411 for (al = first_artifactlist; al != NULL; al = al->next) 1264 for (al = first_artifactlist; al; al = al->next)
1412 { 1265 {
1266 al->total_chance = 0;
1267
1413 for (art = al->items; art != NULL; art = art->next) 1268 for (art = al->items; art; art = art->next)
1414 { 1269 {
1415 if (!art->chance) 1270 if (!art->chance)
1416 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name); 1271 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name);
1417 else 1272 else
1418 al->total_chance += art->chance; 1273 al->total_chance += art->chance;
1423 } 1278 }
1424 1279
1425 LOG (llevDebug, "done.\n"); 1280 LOG (llevDebug, "done.\n");
1426} 1281}
1427 1282
1428
1429/* 1283/*
1430 * Used in artifact generation. The bonuses of the first object 1284 * Used in artifact generation. The bonuses of the first object
1431 * is modified by the bonuses of the second object. 1285 * is modified by the bonuses of the second object.
1432 */ 1286 */
1433
1434void 1287void
1435add_abilities (object *op, object *change) 1288add_abilities (object *op, object *change)
1436{ 1289{
1437 int i, tmp; 1290 int i, tmp;
1438 1291
1439 if (change->face != blank_face) 1292 if (change->face != blank_face)
1440 { 1293 {
1441#ifdef TREASURE_VERBOSE 1294#ifdef TREASURE_VERBOSE
1442 LOG (llevDebug, "FACE: %d\n", change->face->number); 1295 LOG (llevDebug, "add_abilities change face: %d\n", change->face);
1443#endif 1296#endif
1444 op->face = change->face; 1297 op->face = change->face;
1445 } 1298 }
1446 1299
1447 for (i = 0; i < NUM_STATS; i++) 1300 for (i = 0; i < NUM_STATS; i++)
1448 change_attr_value (&(op->stats), i, get_attr_value (&(change->stats), i)); 1301 change_attr_value (&(op->stats), i, change->stats.stat (i));
1449 1302
1450 op->attacktype |= change->attacktype; 1303 op->attacktype |= change->attacktype;
1451 op->path_attuned |= change->path_attuned; 1304 op->path_attuned |= change->path_attuned;
1452 op->path_repelled |= change->path_repelled; 1305 op->path_repelled |= change->path_repelled;
1453 op->path_denied |= change->path_denied; 1306 op->path_denied |= change->path_denied;
1483 CLEAR_FLAG (op, FLAG_ANIMATE); 1336 CLEAR_FLAG (op, FLAG_ANIMATE);
1484 /* so artifacts will join */ 1337 /* so artifacts will join */
1485 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1338 if (!QUERY_FLAG (op, FLAG_ALIVE))
1486 op->speed = 0.0; 1339 op->speed = 0.0;
1487 1340
1488 update_ob_speed (op); 1341 op->set_speed (op->speed);
1489 } 1342 }
1490 1343
1491 if (change->nrof) 1344 if (change->nrof)
1492 op->nrof = RANDOM () % ((int) change->nrof) + 1; 1345 op->nrof = rndm (change->nrof) + 1;
1493 1346
1494 op->stats.exp += change->stats.exp; /* Speed modifier */ 1347 op->stats.exp += change->stats.exp; /* Speed modifier */
1495 op->stats.wc += change->stats.wc; 1348 op->stats.wc += change->stats.wc;
1496 op->stats.ac += change->stats.ac; 1349 op->stats.ac += change->stats.ac;
1497 1350
1505 { 1358 {
1506 object *tmp_obj; 1359 object *tmp_obj;
1507 1360
1508 /* Remove any spells this object currently has in it */ 1361 /* Remove any spells this object currently has in it */
1509 while (op->inv) 1362 while (op->inv)
1510 { 1363 op->inv->destroy ();
1511 tmp_obj = op->inv;
1512 remove_ob (tmp_obj);
1513 free_object (tmp_obj);
1514 }
1515 1364
1516 tmp_obj = arch_to_object (change->other_arch); 1365 tmp_obj = arch_to_object (change->other_arch);
1517 insert_ob_in_ob (tmp_obj, op); 1366 insert_ob_in_ob (tmp_obj, op);
1518 } 1367 }
1519 /* No harm setting this for potions/horns */ 1368 /* No harm setting this for potions/horns */
1604 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100); 1453 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100);
1605 } 1454 }
1606 1455
1607 op->value *= change->value; 1456 op->value *= change->value;
1608 1457
1609 if (change->material) 1458 if (change->materials)
1610 op->material = change->material; 1459 op->materials = change->materials;
1611 1460
1612 if (change->materialname) 1461 if (change->materialname)
1613 op->materialname = change->materialname; 1462 op->materialname = change->materialname;
1614 1463
1615 if (change->slaying) 1464 if (change->slaying)
1621 if (change->msg) 1470 if (change->msg)
1622 op->msg = change->msg; 1471 op->msg = change->msg;
1623} 1472}
1624 1473
1625static int 1474static int
1626legal_artifact_combination (object *op, artifact * art) 1475legal_artifact_combination (object *op, artifact *art)
1627{ 1476{
1628 int neg, success = 0; 1477 int neg, success = 0;
1629 linked_char *tmp; 1478 linked_char *tmp;
1630 const char *name; 1479 const char *name;
1631 1480
1632 if (art->allowed == (linked_char *) NULL) 1481 if (!art->allowed)
1633 return 1; /* Ie, "all" */ 1482 return 1; /* Ie, "all" */
1483
1634 for (tmp = art->allowed; tmp; tmp = tmp->next) 1484 for (tmp = art->allowed; tmp; tmp = tmp->next)
1635 { 1485 {
1636#ifdef TREASURE_VERBOSE 1486#ifdef TREASURE_VERBOSE
1637 LOG (llevDebug, "legal_art: %s\n", tmp->name); 1487 LOG (llevDebug, "legal_art: %s\n", &tmp->name);
1638#endif 1488#endif
1639 if (*tmp->name == '!') 1489 if (*tmp->name == '!')
1640 name = tmp->name + 1, neg = 1; 1490 name = tmp->name + 1, neg = 1;
1641 else 1491 else
1642 name = tmp->name, neg = 0; 1492 name = tmp->name, neg = 0;
1643 1493
1644 /* If we match name, then return the opposite of 'neg' */ 1494 /* If we match name, then return the opposite of 'neg' */
1645 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->name))) 1495 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->archname)))
1646 return !neg; 1496 return !neg;
1647 1497
1648 /* Set success as true, since if the match was an inverse, it means 1498 /* Set success as true, since if the match was an inverse, it means
1649 * everything is allowed except what we match 1499 * everything is allowed except what we match
1650 */ 1500 */
1651 else if (neg) 1501 else if (neg)
1652 success = 1; 1502 success = 1;
1653 } 1503 }
1504
1654 return success; 1505 return success;
1655} 1506}
1656 1507
1657/* 1508/*
1658 * Fixes the given object, giving it the abilities and titles 1509 * Fixes the given object, giving it the abilities and titles
1709 return; 1560 return;
1710 } 1561 }
1711 1562
1712 for (i = 0; i < ARTIFACT_TRIES; i++) 1563 for (i = 0; i < ARTIFACT_TRIES; i++)
1713 { 1564 {
1714 int roll = RANDOM () % al->total_chance; 1565 int roll = rndm (al->total_chance);
1715 1566
1716 for (art = al->items; art != NULL; art = art->next) 1567 for (art = al->items; art; art = art->next)
1717 { 1568 {
1718 roll -= art->chance; 1569 roll -= art->chance;
1719 if (roll < 0) 1570 if (roll < 0)
1720 break; 1571 break;
1721 } 1572 }
1737 continue; 1588 continue;
1738 1589
1739 if (!legal_artifact_combination (op, art)) 1590 if (!legal_artifact_combination (op, art))
1740 { 1591 {
1741#ifdef TREASURE_VERBOSE 1592#ifdef TREASURE_VERBOSE
1742 LOG (llevDebug, "%s of %s was not a legal combination.\n", op->name, art->item->name); 1593 LOG (llevDebug, "%s of %s was not a legal combination.\n", &op->name, &art->item->name);
1743#endif 1594#endif
1744 continue; 1595 continue;
1745 } 1596 }
1597
1746 give_artifact_abilities (op, art->item); 1598 give_artifact_abilities (op, art->item);
1747 return; 1599 return;
1748 } 1600 }
1749} 1601}
1750 1602
1794 SET_FLAG (item, FLAG_NO_STEAL); 1646 SET_FLAG (item, FLAG_NO_STEAL);
1795 } 1647 }
1796} 1648}
1797 1649
1798/* special_potion() - so that old potion code is still done right. */ 1650/* special_potion() - so that old potion code is still done right. */
1799
1800int 1651int
1801special_potion (object *op) 1652special_potion (object *op)
1802{ 1653{
1803
1804 int i;
1805
1806 if (op->attacktype) 1654 if (op->attacktype)
1807 return 1; 1655 return 1;
1808 1656
1809 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha) 1657 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha)
1810 return 1; 1658 return 1;
1811 1659
1812 for (i = 0; i < NROFATTACKS; i++) 1660 for (int i = 0; i < NROFATTACKS; i++)
1813 if (op->resist[i]) 1661 if (op->resist[i])
1814 return 1; 1662 return 1;
1815 1663
1816 return 0; 1664 return 0;
1817} 1665}
1818 1666
1819void 1667void
1820free_treasurestruct (treasure *t) 1668free_treasurestruct (treasure *t)
1821{ 1669{
1822 if (t->next)
1823 free_treasurestruct (t->next); 1670 if (t->next) free_treasurestruct (t->next);
1824 if (t->next_yes)
1825 free_treasurestruct (t->next_yes); 1671 if (t->next_yes) free_treasurestruct (t->next_yes);
1826 if (t->next_no)
1827 free_treasurestruct (t->next_no); 1672 if (t->next_no) free_treasurestruct (t->next_no);
1828 1673
1829 delete t; 1674 delete t;
1830} 1675}
1831 1676
1832void 1677void
1837 1682
1838 delete lc; 1683 delete lc;
1839} 1684}
1840 1685
1841void 1686void
1842free_artifact (artifact * at) 1687free_artifact (artifact *at)
1843{ 1688{
1844 if (at->next)
1845 free_artifact (at->next); 1689 if (at->next) free_artifact (at->next);
1846
1847 if (at->allowed)
1848 free_charlinks (at->allowed); 1690 if (at->allowed) free_charlinks (at->allowed);
1849 1691
1850 at->item->free (1); 1692 at->item->destroy (1);
1851 1693
1852 delete at; 1694 sfree (at);
1853} 1695}
1854 1696
1855void 1697void
1856free_artifactlist (artifactlist * al) 1698free_artifactlist (artifactlist *al)
1857{ 1699{
1858 artifactlist *nextal; 1700 artifactlist *nextal;
1859 1701
1860 for (al = first_artifactlist; al != NULL; al = nextal) 1702 for (al = first_artifactlist; al; al = nextal)
1861 { 1703 {
1862 nextal = al->next; 1704 nextal = al->next;
1863 1705
1864 if (al->items) 1706 if (al->items)
1865 free_artifact (al->items); 1707 free_artifact (al->items);
1866 1708
1867 free (al); 1709 sfree (al);
1868 } 1710 }
1869} 1711}
1870 1712
1871void 1713void
1872free_all_treasures (void) 1714free_all_treasures (void)
1873{ 1715{
1874 treasurelist *tl, *next; 1716 treasurelist *tl, *next;
1875 1717
1876
1877 for (tl = first_treasurelist; tl != NULL; tl = next) 1718 for (tl = first_treasurelist; tl; tl = next)
1878 { 1719 {
1720 clear (tl);
1721
1879 next = tl->next; 1722 next = tl->next;
1880 if (tl->items)
1881 free_treasurestruct (tl->items);
1882 delete tl; 1723 delete tl;
1883 } 1724 }
1725
1884 free_artifactlist (first_artifactlist); 1726 free_artifactlist (first_artifactlist);
1885} 1727}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines