ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/treasure.C
(Generate patch)

Comparing deliantra/server/common/treasure.C (file contents):
Revision 1.23 by root, Tue Dec 12 20:53:02 2006 UTC vs.
Revision 1.84 by root, Thu Jan 1 11:41:17 2009 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 22 */
23
24#define ALLOWED_COMBINATION
25 23
26/* TREASURE_DEBUG does some checking on the treasurelists after loading. 24/* TREASURE_DEBUG does some checking on the treasurelists after loading.
27 * It is useful for finding bugs in the treasures file. Since it only 25 * It is useful for finding bugs in the treasures file. Since it only
28 * slows the startup some (and not actual game play), it is by default 26 * slows the startup some (and not actual game play), it is by default
29 * left on 27 * left on
30 */ 28 */
31#define TREASURE_DEBUG 29#define TREASURE_DEBUG
32 30
33/* TREASURE_VERBOSE enables copious output concerning artifact generation */ 31/* TREASURE_VERBOSE enables copious output concerning artifact generation */
34 32
35/* #define TREASURE_VERBOSE */ 33//#define TREASURE_VERBOSE
36 34
37#include <global.h> 35#include <global.h>
38#include <treasure.h> 36#include <treasure.h>
39#include <funcpoint.h>
40#include <loader.h> 37#include <loader.h>
41 38
39extern char *spell_mapping[];
40
41static treasurelist *first_treasurelist;
42 42
43static void change_treasure (treasure *t, object *op); /* overrule default values */ 43static void change_treasure (treasure *t, object *op); /* overrule default values */
44extern char *spell_mapping[];
45 44
46/* 45typedef std::tr1::unordered_map<
47 * Initialize global archtype pointers: 46 const char *,
48 */ 47 treasurelist *,
48 str_hash,
49 str_equal,
50 slice_allocator< std::pair<const char *const, treasurelist *> >
51> tl_map_t;
49 52
53static tl_map_t tl_map;
54
55/*
56 * Searches for the given treasurelist
57 */
58treasurelist *
59treasurelist::find (const char *name)
60{
61 if (!name)
62 return 0;
63
64 auto (i, tl_map.find (name));
65
66 if (i == tl_map.end ())
67 return 0;
68
69 return i->second;
70}
71
72/*
73 * Searches for the given treasurelist in the globally linked list
74 * of treasurelists which has been built by load_treasures().
75 */
76treasurelist *
77treasurelist::get (const char *name)
78{
79 treasurelist *tl = find (name);
80
81 if (!tl)
82 {
83 tl = new treasurelist;
84
85 tl->name = name;
86 tl->next = first_treasurelist;
87 first_treasurelist = tl;
88
89 tl_map.insert (std::make_pair (tl->name, tl));
90 }
91
92 return tl;
93}
94
95//TODO: class method
50void 96void
51init_archetype_pointers () 97clear (treasurelist *tl)
52{ 98{
53 int prev_warn = warn_archetypes; 99 if (tl->items)
100 {
101 free_treasurestruct (tl->items);
102 tl->items = 0;
103 }
54 104
55 warn_archetypes = 1;
56 if (ring_arch == NULL)
57 ring_arch = archetype::find ("ring");
58 if (amulet_arch == NULL)
59 amulet_arch = archetype::find ("amulet");
60 if (staff_arch == NULL)
61 staff_arch = archetype::find ("staff");
62 if (crown_arch == NULL)
63 crown_arch = archetype::find ("crown");
64 warn_archetypes = prev_warn;
65}
66
67/*
68 * Allocate and return the pointer to an empty treasurelist structure.
69 */
70
71static treasurelist *
72get_empty_treasurelist (void)
73{
74 return new treasurelist;
75}
76
77/*
78 * Allocate and return the pointer to an empty treasure structure.
79 */
80//TODO: make this a constructor
81static treasure *
82get_empty_treasure (void)
83{
84 treasure *t = new treasure;
85
86 t->chance = 100; 105 tl->total_chance = 0;
87
88 return t;
89} 106}
107
108#ifdef TREASURE_DEBUG
109/* recursived checks the linked list. Treasurelist is passed only
110 * so that the treasure name can be printed out
111 */
112static void
113check_treasurelist (const treasure *t, const treasurelist * tl)
114{
115 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
116 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
117
118 if (t->next)
119 check_treasurelist (t->next, tl);
120
121 if (t->next_yes)
122 check_treasurelist (t->next_yes, tl);
123
124 if (t->next_no)
125 check_treasurelist (t->next_no, tl);
126}
127#endif
90 128
91/* 129/*
92 * Reads the lib/treasure file from disk, and parses the contents 130 * Reads the lib/treasure file from disk, and parses the contents
93 * into an internal treasure structure (very linked lists) 131 * into an internal treasure structure (very linked lists)
94 */ 132 */
95
96static treasure * 133static treasure *
97load_treasure (FILE * fp, int *line) 134read_treasure (object_thawer &f)
98{ 135{
99 char buf[MAX_BUF], *cp, variable[MAX_BUF];
100 treasure *t = get_empty_treasure (); 136 treasure *t = new treasure;
101 int value;
102 137
103 nroftreasures++; 138 f.next ();
104 while (fgets (buf, MAX_BUF, fp) != NULL)
105 {
106 (*line)++;
107 139
108 if (*buf == '#') 140 for (;;)
109 continue; 141 {
110 if ((cp = strchr (buf, '\n')) != NULL) 142 coroapi::cede_to_tick ();
111 *cp = '\0';
112 cp = buf;
113 while (isspace (*cp)) /* Skip blanks */
114 cp++;
115 143
116 if (sscanf (cp, "arch %s", variable)) 144 switch (f.kw)
117 {
118 if ((t->item = archetype::find (variable)) == NULL)
119 LOG (llevError, "Treasure lacks archetype: %s\n", variable);
120 } 145 {
121 else if (sscanf (cp, "list %s", variable)) 146 case KW_arch:
122 t->name = variable; 147 t->item = archetype::find (f.get_str ());
123 else if (sscanf (cp, "change_name %s", variable)) 148
124 t->change_arch.name = variable; 149 if (!t->item)
125 else if (sscanf (cp, "change_title %s", variable))
126 t->change_arch.title = variable;
127 else if (sscanf (cp, "change_slaying %s", variable))
128 t->change_arch.slaying = variable;
129 else if (sscanf (cp, "chance %d", &value))
130 t->chance = (uint8) value;
131 else if (sscanf (cp, "nrof %d", &value))
132 t->nrof = (uint16) value;
133 else if (sscanf (cp, "magic %d", &value))
134 t->magic = (uint8) value;
135 else if (!strcmp (cp, "yes"))
136 t->next_yes = load_treasure (fp, line);
137 else if (!strcmp (cp, "no"))
138 t->next_no = load_treasure (fp, line);
139 else if (!strcmp (cp, "end"))
140 return t;
141 else if (!strcmp (cp, "more"))
142 { 150 {
143 t->next = load_treasure (fp, line); 151 f.parse_warn ("treasure references unknown archetype");
152 t->item = archetype::empty;
153 }
154
155 break;
156
157 case KW_list: f.get (t->name); break;
158 case KW_change_name: f.get (t->change_arch.name); break;
159 case KW_change_title: f.get (t->change_arch.title); break;
160 case KW_change_slaying: f.get (t->change_arch.slaying); break;
161 case KW_chance: f.get (t->chance); break;
162 case KW_nrof: f.get (t->nrof); break;
163 case KW_magic: f.get (t->magic); break;
164
165 case KW_yes: t->next_yes = read_treasure (f); continue;
166 case KW_no: t->next_no = read_treasure (f); continue;
167
168 case KW_end:
169 f.next ();
144 return t; 170 return t;
171
172 case KW_more:
173 t->next = read_treasure (f);
174 return t;
175
176 default:
177 if (!f.parse_error ("treasurelist", t->name))
178 goto error;
179
180 return t;
145 } 181 }
146 else 182
147 LOG (llevError, "Unknown treasure-command: '%s', last entry %s, line %d\n", cp, &t->name, *line); 183 f.next ();
148 } 184 }
149 LOG (llevError, "treasure lacks 'end'.\n"); 185
186 // not reached
187
188error:
189 delete t;
150 return t; 190 return 0;
151} 191}
152 192
153#ifdef TREASURE_DEBUG
154
155/* recursived checks the linked list. Treasurelist is passed only
156 * so that the treasure name can be printed out
157 */
158static void
159check_treasurelist (const treasure *t, const treasurelist * tl)
160{
161 if (t->item == NULL && t->name == NULL)
162 LOG (llevError, "Treasurelist %s has element with no name or archetype\n", &tl->name);
163 if (t->chance >= 100 && t->next_yes && (t->next || t->next_no))
164 LOG (llevError, "Treasurelist %s has element that has 100%% generation, next_yes field as well as next or next_no\n", &tl->name);
165 /* find_treasurelist will print out its own error message */
166 if (t->name && *t->name)
167 (void) find_treasurelist (t->name);
168 if (t->next)
169 check_treasurelist (t->next, tl);
170 if (t->next_yes)
171 check_treasurelist (t->next_yes, tl);
172 if (t->next_no)
173 check_treasurelist (t->next_no, tl);
174}
175#endif
176
177/* 193/*
178 * Opens LIBDIR/treasure and reads all treasure-declarations from it.
179 * Each treasure is parsed with the help of load_treasure(). 194 * Each treasure is parsed with the help of load_treasure().
180 */ 195 */
181 196treasurelist *
182void 197treasurelist::read (object_thawer &f)
183load_treasures (void)
184{ 198{
185 FILE *fp; 199 assert (f.kw == KW_treasure || f.kw == KW_treasureone);
186 char filename[MAX_BUF], buf[MAX_BUF], name[MAX_BUF];
187 treasurelist *previous = NULL;
188 treasure *t;
189 int comp, line = 0;
190 200
191 sprintf (filename, "%s/%s", settings.datadir, settings.treasures); 201 bool one = f.kw == KW_treasureone;
192 if ((fp = open_and_uncompress (filename, 0, &comp)) == NULL) 202 treasurelist *tl = treasurelist::get (f.get_str ());
193 { 203 clear (tl);
194 LOG (llevError, "Can't open treasure file.\n"); 204 tl->items = read_treasure (f);
205 if (!tl->items)
195 return; 206 return 0;
196 }
197 while (fgets (buf, MAX_BUF, fp) != NULL)
198 {
199 line++;
200 if (*buf == '#')
201 continue;
202 207
203 if (sscanf (buf, "treasureone %s\n", name) || sscanf (buf, "treasure %s\n", name))
204 {
205 treasurelist *tl = get_empty_treasurelist ();
206
207 tl->name = name;
208 if (previous == NULL)
209 first_treasurelist = tl;
210 else
211 previous->next = tl;
212 previous = tl;
213 tl->items = load_treasure (fp, &line);
214
215 /* This is a one of the many items on the list should be generated. 208 /* This is a one of the many items on the list should be generated.
216 * Add up the chance total, and check to make sure the yes & no 209 * Add up the chance total, and check to make sure the yes & no
217 * fields of the treasures are not being used. 210 * fields of the treasures are not being used.
218 */ 211 */
219 if (!strncmp (buf, "treasureone", 11)) 212 if (one)
213 {
214 for (treasure *t = tl->items; t; t = t->next)
215 {
216 if (t->next_yes || t->next_no)
220 { 217 {
221 for (t = tl->items; t != NULL; t = t->next)
222 {
223#ifdef TREASURE_DEBUG
224 if (t->next_yes || t->next_no)
225 {
226 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->name : &t->name); 218 LOG (llevError, "Treasure %s is one item, but on treasure %s\n", &tl->name, t->item ? &t->item->archname : &t->name);
227 LOG (llevError, " the next_yes or next_no field is set\n"); 219 LOG (llevError, " the next_yes or next_no field is set\n");
228 }
229#endif
230 tl->total_chance += t->chance;
231 }
232 } 220 }
233 }
234 else
235 LOG (llevError, "Treasure-list %s didn't understand: %s, line %d\n", filename, buf, line);
236 }
237 close_and_delete (fp, comp);
238 221
239#ifdef TREASURE_DEBUG 222 tl->total_chance += t->chance;
240 /* Perform some checks on how valid the treasure data actually is. 223 }
241 * verify that list transitions work (ie, the list that it is supposed 224 }
242 * to transition to exists). Also, verify that at least the name
243 * or archetype is set for each treasure element.
244 */
245 for (previous = first_treasurelist; previous != NULL; previous = previous->next)
246 check_treasurelist (previous->items, previous);
247#endif
248}
249 225
250/*
251 * Searches for the given treasurelist in the globally linked list
252 * of treasurelists which has been built by load_treasures().
253 */
254
255treasurelist *
256find_treasurelist (const char *name)
257{
258 shstr_cmp name_ (name);
259
260 if (!name_)
261 return 0;
262
263 for (treasurelist * tl = first_treasurelist; tl != 0; tl = tl->next)
264 if (name_ == tl->name)
265 return tl;
266
267 if (first_treasurelist)
268 LOG (llevError, "Couldn't find treasurelist %s\n", name);
269
270 return 0; 226 return tl;
271} 227}
272
273 228
274/* 229/*
275 * Generates the objects specified by the given treasure. 230 * Generates the objects specified by the given treasure.
276 * It goes recursively through the rest of the linked list. 231 * It goes recursively through the rest of the linked list.
277 * If there is a certain percental chance for a treasure to be generated, 232 * If there is a certain percental chance for a treasure to be generated,
280 * being generated. 235 * being generated.
281 * If flag is GT_INVISIBLE, only invisible objects are generated (ie, only 236 * If flag is GT_INVISIBLE, only invisible objects are generated (ie, only
282 * abilities. This is used by summon spells, thus no summoned monsters 237 * abilities. This is used by summon spells, thus no summoned monsters
283 * start with equipment, but only their abilities). 238 * start with equipment, but only their abilities).
284 */ 239 */
285
286
287static void 240static void
288put_treasure (object *op, object *creator, int flags) 241put_treasure (object *op, object *creator, int flags)
289{ 242{
290 object *tmp; 243 if (flags & GT_ENVIRONMENT)
291 244 {
292 /* Bit of a hack - spells should never be put onto the map. The entire 245 /* Bit of a hack - spells should never be put onto the map. The entire
293 * treasure stuff is a problem - there is no clear idea of knowing 246 * treasure stuff is a problem - there is no clear idea of knowing
294 * this is the original object, or if this is an object that should be created 247 * this is the original object, or if this is an object that should be created
295 * by another object. 248 * by another object.
296 */ 249 */
297 if (flags & GT_ENVIRONMENT && op->type != SPELL) 250 //TODO: flag such as objects... as such (no drop, anybody?)
298 { 251 if (op->type == SPELL)
299 op->x = creator->x; 252 {
300 op->y = creator->y; 253 op->destroy ();
254 return;
255 }
256
257 op->expand_tail ();
258
259 if (!creator->is_on_map () || op->blocked (creator->map, creator->x, creator->y))
260 op->destroy ();
261 else
262 {
301 SET_FLAG (op, FLAG_OBJ_ORIGINAL); 263 SET_FLAG (op, FLAG_OBJ_ORIGINAL);
302 insert_ob_in_map (op, creator->map, op, INS_NO_MERGE | INS_NO_WALK_ON); 264 op->insert_at (creator, creator, INS_NO_MERGE | INS_NO_WALK_ON);
265 }
303 } 266 }
304 else 267 else
305 { 268 {
306 op = insert_ob_in_ob (op, creator); 269 op = creator->insert (op);
270
307 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER)) 271 if ((flags & GT_APPLY) && QUERY_FLAG (creator, FLAG_MONSTER))
308 monster_check_apply (creator, op); 272 monster_check_apply (creator, op);
309 if ((flags & GT_UPDATE_INV) && (tmp = is_player_inv (creator)) != NULL)
310 esrv_send_item (tmp, op);
311 } 273 }
312} 274}
313 275
314/* if there are change_xxx commands in the treasure, we include the changes 276/* if there are change_xxx commands in the treasure, we include the changes
315 * in the generated object 277 * in the generated object
329 291
330 if (t->change_arch.slaying) 292 if (t->change_arch.slaying)
331 op->slaying = t->change_arch.slaying; 293 op->slaying = t->change_arch.slaying;
332} 294}
333 295
334void 296static void
335create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries) 297create_all_treasures (treasure *t, object *op, int flag, int difficulty, int tries)
336{ 298{
337 object *tmp;
338
339 if ((int) t->chance >= 100 || (RANDOM () % 100 + 1) < (int) t->chance) 299 if ((int) t->chance >= 100 || (rndm (100) + 1) < (int) t->chance)
340 { 300 {
341 if (t->name) 301 if (t->name)
342 { 302 {
343 if (strcmp (t->name, "NONE") && difficulty >= t->magic) 303 if (difficulty >= t->magic)
304 if (treasurelist *tl = treasurelist::find (t->name))
344 create_treasure (find_treasurelist (t->name), op, flag, difficulty, tries); 305 create_treasure (tl, op, flag, difficulty, tries);
306 else
307 LOG (llevError, "create_all_treasures: undefined reference to treasurelist '%s'.\n", &t->name);
345 } 308 }
346 else 309 else
347 { 310 {
348 if (t->item->clone.invisible != 0 || !(flag & GT_INVISIBLE)) 311 if (t->item && (t->item->invisible != 0 || !(flag & GT_INVISIBLE)))
349 { 312 {
350 tmp = arch_to_object (t->item); 313 object *tmp = arch_to_object (t->item);
314
351 if (t->nrof && tmp->nrof <= 1) 315 if (t->nrof && tmp->nrof <= 1)
352 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 316 tmp->nrof = rndm (t->nrof) + 1;
317
353 fix_generated_item (tmp, op, difficulty, t->magic, flag); 318 fix_generated_item (tmp, op, difficulty, t->magic, flag);
354 change_treasure (t, tmp); 319 change_treasure (t, tmp);
355 put_treasure (tmp, op, flag); 320 put_treasure (tmp, op, flag);
356 } 321 }
357 } 322 }
358 323
359 if (t->next_yes != NULL) 324 if (t->next_yes)
360 create_all_treasures (t->next_yes, op, flag, difficulty, tries); 325 create_all_treasures (t->next_yes, op, flag, difficulty, tries);
361 } 326 }
362 else if (t->next_no != NULL) 327 else if (t->next_no)
363 create_all_treasures (t->next_no, op, flag, difficulty, tries); 328 create_all_treasures (t->next_no, op, flag, difficulty, tries);
364 329
365 if (t->next != NULL) 330 if (t->next)
366 create_all_treasures (t->next, op, flag, difficulty, tries); 331 create_all_treasures (t->next, op, flag, difficulty, tries);
367} 332}
368 333
369void 334static void
370create_one_treasure (treasurelist * tl, object *op, int flag, int difficulty, int tries) 335create_one_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
371{ 336{
372 int value = RANDOM () % tl->total_chance; 337 int value = rndm (tl->total_chance);
373 treasure *t; 338 treasure *t;
374 339
375 if (tries++ > 100) 340 if (tries++ > 100)
376 { 341 {
377 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n"); 342 LOG (llevDebug, "create_one_treasure: tries exceeded 100, returning without making treasure\n");
378 return; 343 return;
379 } 344 }
380 345
381 for (t = tl->items; t != NULL; t = t->next) 346 for (t = tl->items; t; t = t->next)
382 { 347 {
383 value -= t->chance; 348 value -= t->chance;
384 349
385 if (value < 0) 350 if (value < 0)
386 break; 351 break;
387 } 352 }
388 353
389 if (!t || value >= 0) 354 if (!t || value >= 0)
390 {
391 LOG (llevError, "create_one_treasure: got null object or not able to find treasure\n"); 355 cleanup ("create_one_treasure: got null object or not able to find treasure\n", 1);
392 abort ();
393 return;
394 }
395 356
396 if (t->name) 357 if (t->name)
397 { 358 {
398 if (!strcmp (t->name, "NONE"))
399 return;
400
401 if (difficulty >= t->magic) 359 if (difficulty >= t->magic)
360 {
361 treasurelist *tl = treasurelist::find (t->name);
362 if (tl)
402 create_treasure (find_treasurelist (t->name), op, flag, difficulty, tries); 363 create_treasure (tl, op, flag, difficulty, tries);
364 }
403 else if (t->nrof) 365 else if (t->nrof)
404 create_one_treasure (tl, op, flag, difficulty, tries); 366 create_one_treasure (tl, op, flag, difficulty, tries);
405
406 return;
407 } 367 }
408
409 if ((t->item && t->item->clone.invisible != 0) || flag != GT_INVISIBLE) 368 else if (t->item && (t->item->invisible != 0 || flag != GT_INVISIBLE))
410 { 369 {
411 object *tmp = arch_to_object (t->item); 370 if (object *tmp = arch_to_object (t->item))
412 371 {
413 if (!tmp)
414 return;
415
416 if (t->nrof && tmp->nrof <= 1) 372 if (t->nrof && tmp->nrof <= 1)
417 tmp->nrof = RANDOM () % ((int) t->nrof) + 1; 373 tmp->nrof = rndm (t->nrof) + 1;
418 374
419 fix_generated_item (tmp, op, difficulty, t->magic, flag); 375 fix_generated_item (tmp, op, difficulty, t->magic, flag);
420 change_treasure (t, tmp); 376 change_treasure (t, tmp);
421 put_treasure (tmp, op, flag); 377 put_treasure (tmp, op, flag);
378 }
422 } 379 }
380}
381
382void
383object::create_treasure (treasurelist *tl, int flags)
384{
385 ::create_treasure (tl, this, flags, map ? map->difficulty : 0);
423} 386}
424 387
425/* This calls the appropriate treasure creation function. tries is passed 388/* This calls the appropriate treasure creation function. tries is passed
426 * to determine how many list transitions or attempts to create treasure 389 * to determine how many list transitions or attempts to create treasure
427 * have been made. It is really in place to prevent infinite loops with 390 * have been made. It is really in place to prevent infinite loops with
428 * list transitions, or so that excessively good treasure will not be 391 * list transitions, or so that excessively good treasure will not be
429 * created on weak maps, because it will exceed the number of allowed tries 392 * created on weak maps, because it will exceed the number of allowed tries
430 * to do that. 393 * to do that.
431 */ 394 */
432void 395void
433create_treasure (treasurelist * t, object *op, int flag, int difficulty, int tries) 396create_treasure (treasurelist *tl, object *op, int flag, int difficulty, int tries)
434{ 397{
398 // empty treasurelists are legal
399 if (!tl->items)
400 return;
435 401
436 if (tries++ > 100) 402 if (tries++ > 100)
437 { 403 {
438 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n"); 404 LOG (llevDebug, "createtreasure: tries exceeded 100, returning without making treasure\n");
439 return; 405 return;
440 } 406 }
407
408 if (op->flag [FLAG_TREASURE_ENV])
409 {
410 // do not generate items when there already is something above the object
411 if (op->flag [FLAG_IS_FLOOR] && op->above)
412 return;
413
414 flag |= GT_ENVIRONMENT;
415 }
416
441 if (t->total_chance) 417 if (tl->total_chance)
442 create_one_treasure (t, op, flag, difficulty, tries); 418 create_one_treasure (tl, op, flag, difficulty, tries);
443 else 419 else
444 create_all_treasures (t->items, op, flag, difficulty, tries); 420 create_all_treasures (tl->items, op, flag, difficulty, tries);
445} 421}
446 422
447/* This is similar to the old generate treasure function. However, 423/* This is similar to the old generate treasure function. However,
448 * it instead takes a treasurelist. It is really just a wrapper around 424 * it instead takes a treasurelist. It is really just a wrapper around
449 * create_treasure. We create a dummy object that the treasure gets 425 * create_treasure. We create a dummy object that the treasure gets
450 * inserted into, and then return that treausre 426 * inserted into, and then return that treausre
451 */ 427 */
452object * 428object *
453generate_treasure (treasurelist * t, int difficulty) 429generate_treasure (treasurelist *tl, int difficulty)
454{ 430{
455 object *ob = get_object (), *tmp; 431 difficulty = clamp (difficulty, 1, settings.max_level);
456 432
433 object *ob = object::create ();
434
457 create_treasure (t, ob, 0, difficulty, 0); 435 create_treasure (tl, ob, 0, difficulty, 0);
458 436
459 /* Don't want to free the object we are about to return */ 437 /* Don't want to free the object we are about to return */
460 tmp = ob->inv; 438 object *tmp = ob->inv;
461 if (tmp != NULL) 439 if (tmp)
462 tmp->remove (); 440 tmp->remove ();
463 441
464 if (ob->inv) 442 if (ob->inv)
465 LOG (llevError, "In generate treasure, created multiple objects.\n"); 443 LOG (llevError, "In generate treasure, created multiple objects.\n");
466 444
467 ob->destroy (0); 445 ob->destroy ();
446
468 return tmp; 447 return tmp;
469} 448}
470 449
471/* 450/*
472 * This is a new way of calculating the chance for an item to have 451 * This is a new way of calculating the chance for an item to have
474 * The array has two arguments, the difficulty of the level, and the 453 * The array has two arguments, the difficulty of the level, and the
475 * magical bonus "wanted". 454 * magical bonus "wanted".
476 */ 455 */
477 456
478static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = { 457static int difftomagic_list[DIFFLEVELS][MAXMAGIC + 1] = {
479
480/*chance of magic difficulty*/ 458// chance of magic difficulty
481
482/* +0 +1 +2 +3 +4 */ 459// +0 +1 +2 +3 +4
483 {95, 2, 2, 1, 0}, /*1 */ 460 {95, 2, 2, 1, 0}, // 1
484 {92, 5, 2, 1, 0}, /*2 */ 461 {92, 5, 2, 1, 0}, // 2
485 {85, 10, 4, 1, 0}, /*3 */ 462 {85, 10, 4, 1, 0}, // 3
486 {80, 14, 4, 2, 0}, /*4 */ 463 {80, 14, 4, 2, 0}, // 4
487 {75, 17, 5, 2, 1}, /*5 */ 464 {75, 17, 5, 2, 1}, // 5
488 {70, 18, 8, 3, 1}, /*6 */ 465 {70, 18, 8, 3, 1}, // 6
489 {65, 21, 10, 3, 1}, /*7 */ 466 {65, 21, 10, 3, 1}, // 7
490 {60, 22, 12, 4, 2}, /*8 */ 467 {60, 22, 12, 4, 2}, // 8
491 {55, 25, 14, 4, 2}, /*9 */ 468 {55, 25, 14, 4, 2}, // 9
492 {50, 27, 16, 5, 2}, /*10 */ 469 {50, 27, 16, 5, 2}, // 10
493 {45, 28, 18, 6, 3}, /*11 */ 470 {45, 28, 18, 6, 3}, // 11
494 {42, 28, 20, 7, 3}, /*12 */ 471 {42, 28, 20, 7, 3}, // 12
495 {40, 27, 21, 8, 4}, /*13 */ 472 {40, 27, 21, 8, 4}, // 13
496 {38, 25, 22, 10, 5}, /*14 */ 473 {38, 25, 22, 10, 5}, // 14
497 {36, 23, 23, 12, 6}, /*15 */ 474 {36, 23, 23, 12, 6}, // 15
498 {33, 21, 24, 14, 8}, /*16 */ 475 {33, 21, 24, 14, 8}, // 16
499 {31, 19, 25, 16, 9}, /*17 */ 476 {31, 19, 25, 16, 9}, // 17
500 {27, 15, 30, 18, 10}, /*18 */ 477 {27, 15, 30, 18, 10}, // 18
501 {20, 12, 30, 25, 13}, /*19 */ 478 {20, 12, 30, 25, 13}, // 19
502 {15, 10, 28, 30, 17}, /*20 */ 479 {15, 10, 28, 30, 17}, // 20
503 {13, 9, 27, 28, 23}, /*21 */ 480 {13, 9, 27, 28, 23}, // 21
504 {10, 8, 25, 28, 29}, /*22 */ 481 {10, 8, 25, 28, 29}, // 22
505 {8, 7, 23, 26, 36}, /*23 */ 482 { 8, 7, 23, 26, 36}, // 23
506 {6, 6, 20, 22, 46}, /*24 */ 483 { 6, 6, 20, 22, 46}, // 24
507 {4, 5, 17, 18, 56}, /*25 */ 484 { 4, 5, 17, 18, 56}, // 25
508 {2, 4, 12, 14, 68}, /*26 */ 485 { 2, 4, 12, 14, 68}, // 26
509 {0, 3, 7, 10, 80}, /*27 */ 486 { 0, 3, 7, 10, 80}, // 27
510 {0, 0, 3, 7, 90}, /*28 */ 487 { 0, 0, 3, 7, 90}, // 28
511 {0, 0, 0, 3, 97}, /*29 */ 488 { 0, 0, 0, 3, 97}, // 29
512 {0, 0, 0, 0, 100}, /*30 */ 489 { 0, 0, 0, 0, 100}, // 30
513 {0, 0, 0, 0, 100}, /*31 */ 490 { 0, 0, 0, 0, 100}, // 31
514}; 491};
515
516 492
517/* calculate the appropriate level for wands staves and scrolls. 493/* calculate the appropriate level for wands staves and scrolls.
518 * This code presumes that op has had its spell object created (in op->inv) 494 * This code presumes that op has had its spell object created (in op->inv)
519 * 495 *
520 * elmex Wed Aug 9 17:44:59 CEST 2006: 496 * elmex Wed Aug 9 17:44:59 CEST 2006:
521 * Removed multiplicator, too many high-level items were generated on low-difficulty maps. 497 * Removed multiplicator, too many high-level items were generated on low-difficulty maps.
522 */ 498 */
523
524int 499int
525level_for_item (const object *op, int difficulty) 500level_for_item (const object *op, int difficulty)
526{ 501{
527 int olevel = 0;
528
529 if (!op->inv) 502 if (!op->inv)
530 { 503 {
531 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name); 504 LOG (llevError, "level_for_item: Object %s has no inventory!\n", &op->name);
532 return 0; 505 return 0;
533 } 506 }
534 507
535 olevel = (int) (op->inv->level + (double) difficulty * (1 - drand48 () * drand48 () * 2)); 508 int olevel = op->inv->level + int (difficulty * (1. - rndm () * rndm () * 2.));
536 509
537 if (olevel <= 0) 510 if (olevel <= 0)
538 olevel = rndm (1, MIN (op->inv->level, 1)); 511 olevel = rndm (1, op->inv->level);
539 512
540 if (olevel > MAXLEVEL) 513 return min (olevel, MAXLEVEL);
541 olevel = MAXLEVEL;
542
543 return olevel;
544} 514}
545 515
546/* 516/*
547 * Based upon the specified difficulty and upon the difftomagic_list array, 517 * Based upon the specified difficulty and upon the difftomagic_list array,
548 * a random magical bonus is returned. This is used when determine 518 * a random magical bonus is returned. This is used when determine
551 * elmex Thu Aug 10 18:45:44 CEST 2006: 521 * elmex Thu Aug 10 18:45:44 CEST 2006:
552 * Scaling difficulty by max_level, as difficulty is a level and not some 522 * Scaling difficulty by max_level, as difficulty is a level and not some
553 * weird integer between 1-31. 523 * weird integer between 1-31.
554 * 524 *
555 */ 525 */
556
557int 526int
558magic_from_difficulty (int difficulty) 527magic_from_difficulty (int difficulty)
559{ 528{
560 int percent = 0, magic = 0; 529 int percent = 0, magic = 0;
561 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS); 530 int scaled_diff = (int) (((double) difficulty / settings.max_level) * DIFFLEVELS);
566 scaled_diff = 0; 535 scaled_diff = 0;
567 536
568 if (scaled_diff >= DIFFLEVELS) 537 if (scaled_diff >= DIFFLEVELS)
569 scaled_diff = DIFFLEVELS - 1; 538 scaled_diff = DIFFLEVELS - 1;
570 539
571 percent = RANDOM () % 100; 540 percent = rndm (100);
572 541
573 for (magic = 0; magic < (MAXMAGIC + 1); magic++) 542 for (magic = 0; magic < (MAXMAGIC + 1); magic++)
574 { 543 {
575 percent -= difftomagic_list[scaled_diff][magic]; 544 percent -= difftomagic_list[scaled_diff][magic];
576 545
582 { 551 {
583 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty); 552 LOG (llevError, "Warning, table for difficulty (scaled %d) %d bad.\n", scaled_diff, difficulty);
584 magic = 0; 553 magic = 0;
585 } 554 }
586 555
587 magic = (RANDOM () % 3) ? magic : -magic; 556 magic = (rndm (3)) ? magic : -magic;
588 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */ 557 /* LOG(llevDebug, "Chose magic %d for difficulty (scaled %d) %d\n", magic, scaled_diff, difficulty); */
589 558
590 return magic; 559 return magic;
591} 560}
592 561
605 574
606 op->magic = magic; 575 op->magic = magic;
607 if (op->arch) 576 if (op->arch)
608 { 577 {
609 if (op->type == ARMOUR) 578 if (op->type == ARMOUR)
610 ARMOUR_SPEED (op) = (ARMOUR_SPEED (&op->arch->clone) * (100 + magic * 10)) / 100; 579 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op->arch) * (100 + magic * 10)) / 100;
611 580
612 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 581 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
613 magic = (-magic); 582 magic = (-magic);
583
614 op->weight = (op->arch->clone.weight * (100 - magic * 10)) / 100; 584 op->weight = (op->arch->weight * (100 - magic * 10)) / 100;
615 } 585 }
616 else 586 else
617 { 587 {
618 if (op->type == ARMOUR) 588 if (op->type == ARMOUR)
619 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100; 589 ARMOUR_SPEED (op) = (ARMOUR_SPEED (op) * (100 + magic * 10)) / 100;
590
620 if (magic < 0 && !(RANDOM () % 3)) /* You can't just check the weight always */ 591 if (magic < 0 && !(rndm (3))) /* You can't just check the weight always */
621 magic = (-magic); 592 magic = (-magic);
593
622 op->weight = (op->weight * (100 - magic * 10)) / 100; 594 op->weight = (op->weight * (100 - magic * 10)) / 100;
623 } 595 }
624} 596}
625 597
626/* 598/*
649 * 1) Since rings can have multiple bonuses, if the same bonus 621 * 1) Since rings can have multiple bonuses, if the same bonus
650 * is rolled again, increase it - the bonuses now stack with 622 * is rolled again, increase it - the bonuses now stack with
651 * other bonuses previously rolled and ones the item might natively have. 623 * other bonuses previously rolled and ones the item might natively have.
652 * 2) Add code to deal with new PR method. 624 * 2) Add code to deal with new PR method.
653 */ 625 */
654
655void 626void
656set_ring_bonus (object *op, int bonus) 627set_ring_bonus (object *op, int bonus)
657{ 628{
658 629
659 int r = RANDOM () % (bonus > 0 ? 25 : 11); 630 int r = rndm (bonus > 0 ? 25 : 11);
660 631
661 if (op->type == AMULET) 632 if (op->type == AMULET)
662 { 633 {
663 if (!(RANDOM () % 21)) 634 if (!(rndm (21)))
664 r = 20 + RANDOM () % 2; 635 r = 20 + rndm (2);
665 else 636 else
666 { 637 {
667 if (RANDOM () & 2) 638 if (rndm (2))
668 r = 10; 639 r = 10;
669 else 640 else
670 r = 11 + RANDOM () % 9; 641 r = 11 + rndm (9);
671 } 642 }
672 } 643 }
673 644
674 switch (r) 645 switch (r)
675 { 646 {
682 case 2: 653 case 2:
683 case 3: 654 case 3:
684 case 4: 655 case 4:
685 case 5: 656 case 5:
686 case 6: 657 case 6:
687 set_attr_value (&op->stats, r, (signed char) (bonus + get_attr_value (&op->stats, r))); 658 op->stats.stat (r) += bonus;
688 break; 659 break;
689 660
690 case 7: 661 case 7:
691 op->stats.dam += bonus; 662 op->stats.dam += bonus;
692 break; 663 break;
712 case 16: 683 case 16:
713 case 17: 684 case 17:
714 case 18: 685 case 18:
715 case 19: 686 case 19:
716 { 687 {
717 int b = 5 + FABS (bonus), val, resist = RANDOM () % num_resist_table; 688 int b = 5 + abs (bonus), val, resist = rndm (num_resist_table);
718 689
719 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */ 690 /* Roughly generate a bonus between 100 and 35 (depending on the bonus) */
720 val = 10 + RANDOM () % b + RANDOM () % b + RANDOM () % b + RANDOM () % b; 691 val = 10 + rndm (b) + rndm (b) + rndm (b) + rndm (b);
721 692
722 /* Cursed items need to have higher negative values to equal out with 693 /* Cursed items need to have higher negative values to equal out with
723 * positive values for how protections work out. Put another 694 * positive values for how protections work out. Put another
724 * little random element in since that they don't always end up with 695 * little random element in since that they don't always end up with
725 * even values. 696 * even values.
726 */ 697 */
727 if (bonus < 0) 698 if (bonus < 0)
728 val = 2 * -val - RANDOM () % b; 699 val = 2 * -val - rndm (b);
729 if (val > 35) 700 if (val > 35)
730 val = 35; /* Upper limit */ 701 val = 35; /* Upper limit */
731 b = 0; 702 b = 0;
703
732 while (op->resist[resist_table[resist]] != 0 && b < 4) 704 while (op->resist[resist_table[resist]] != 0 && b < 4)
733 {
734 resist = RANDOM () % num_resist_table; 705 resist = rndm (num_resist_table);
735 } 706
736 if (b == 4) 707 if (b == 4)
737 return; /* Not able to find a free resistance */ 708 return; /* Not able to find a free resistance */
709
738 op->resist[resist_table[resist]] = val; 710 op->resist[resist_table[resist]] = val;
739 /* We should probably do something more clever here to adjust value 711 /* We should probably do something more clever here to adjust value
740 * based on how good a resistance we gave. 712 * based on how good a resistance we gave.
741 */ 713 */
742 break; 714 break;
770 case 22: 742 case 22:
771 op->stats.exp += bonus; /* Speed! */ 743 op->stats.exp += bonus; /* Speed! */
772 op->value = (op->value * 2) / 3; 744 op->value = (op->value * 2) / 3;
773 break; 745 break;
774 } 746 }
747
775 if (bonus > 0) 748 if (bonus > 0)
776 op->value *= 2 * bonus; 749 op->value *= 2 * bonus;
777 else 750 else
778 op->value = -(op->value * 2 * bonus) / 3; 751 op->value = -(op->value * 2 * bonus) / 3;
779} 752}
784 * higher is the chance of returning a low number. 757 * higher is the chance of returning a low number.
785 * It is only used in fix_generated_treasure() to set bonuses on 758 * It is only used in fix_generated_treasure() to set bonuses on
786 * rings and amulets. 759 * rings and amulets.
787 * Another scheme is used to calculate the magic of weapons and armours. 760 * Another scheme is used to calculate the magic of weapons and armours.
788 */ 761 */
789
790int 762int
791get_magic (int diff) 763get_magic (int diff)
792{ 764{
793 int i; 765 int i;
794 766
795 if (diff < 3) 767 if (diff < 3)
796 diff = 3; 768 diff = 3;
769
797 for (i = 0; i < 4; i++) 770 for (i = 0; i < 4; i++)
798 if (RANDOM () % diff) 771 if (rndm (diff))
799 return i; 772 return i;
773
800 return 4; 774 return 4;
801} 775}
802 776
803#define DICE2 (get_magic(2)==2?2:1) 777#define DICE2 (get_magic(2)==2?2:1)
804#define DICESPELL (RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3+RANDOM()%3) 778#define DICESPELL (rndm (3) + rndm (3) + rndm (3) + rndm (3) + rndm (3))
805 779
806/* 780/*
807 * fix_generated_item(): This is called after an item is generated, in 781 * fix_generated_item(): This is called after an item is generated, in
808 * order to set it up right. This produced magical bonuses, puts spells 782 * order to set it up right. This produced magical bonuses, puts spells
809 * into scrolls/books/wands, makes it unidentified, hides the value, etc. 783 * into scrolls/books/wands, makes it unidentified, hides the value, etc.
823 * value. 797 * value.
824 * GT_MINIMAL: Does minimal processing on the object - just enough to make it 798 * GT_MINIMAL: Does minimal processing on the object - just enough to make it
825 * a working object - don't change magic, value, etc, but set it material 799 * a working object - don't change magic, value, etc, but set it material
826 * type as appropriate, for objects that need spell objects, set those, etc 800 * type as appropriate, for objects that need spell objects, set those, etc
827 */ 801 */
828
829void 802void
830fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags) 803fix_generated_item (object *op, object *creator, int difficulty, int max_magic, int flags)
831{ 804{
832 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0; 805 int was_magic = op->magic, num_enchantments = 0, save_item_power = 0;
833 806
838 save_item_power = op->item_power; 811 save_item_power = op->item_power;
839 op->item_power = 0; 812 op->item_power = 0;
840 813
841 if (op->randomitems && op->type != SPELL) 814 if (op->randomitems && op->type != SPELL)
842 { 815 {
843 create_treasure (op->randomitems, op, flags, difficulty, 0); 816 create_treasure (op->randomitems, op, flags & ~GT_ENVIRONMENT, difficulty, 0);
844 if (!op->inv)
845 LOG (llevDebug, "fix_generated_item: Unable to generate treasure for %s\n", &op->name);
846
847 /* So the treasure doesn't get created again */ 817 /* So the treasure doesn't get created again */
848 op->randomitems = NULL; 818 op->randomitems = 0;
849 } 819 }
850 820
851 if (difficulty < 1) 821 if (difficulty < 1)
852 difficulty = 1; 822 difficulty = 1;
853 823
857 ARG_INT (flags))) 827 ARG_INT (flags)))
858 return; 828 return;
859 829
860 if (!(flags & GT_MINIMAL)) 830 if (!(flags & GT_MINIMAL))
861 { 831 {
862 if (op->arch == crown_arch) 832 if (IS_ARCH (op->arch, crown))
863 { 833 {
864 set_magic (difficulty, op, max_magic, flags); 834 set_magic (difficulty, op, max_magic, flags);
865 num_enchantments = calc_item_power (op, 1); 835 num_enchantments = calc_item_power (op, 1);
866 generate_artifact (op, difficulty); 836 generate_artifact (op, difficulty);
867 } 837 }
870 if (!op->magic && max_magic) 840 if (!op->magic && max_magic)
871 set_magic (difficulty, op, max_magic, flags); 841 set_magic (difficulty, op, max_magic, flags);
872 842
873 num_enchantments = calc_item_power (op, 1); 843 num_enchantments = calc_item_power (op, 1);
874 844
875 if ((!was_magic && !(RANDOM () % CHANCE_FOR_ARTIFACT)) || op->type == HORN || difficulty >= settings.max_level) /* high difficulties always generate an artifact, 845 if ((!was_magic && !rndm (CHANCE_FOR_ARTIFACT))
876 * used for shop_floors or treasures */ 846 || op->type == HORN
847 || difficulty >= settings.max_level) /* high difficulties always generate an artifact, used for shop_floors or treasures */
877 generate_artifact (op, difficulty); 848 generate_artifact (op, difficulty);
878 } 849 }
879 850
880 /* Object was made an artifact. Calculate its item_power rating. 851 /* Object was made an artifact. Calculate its item_power rating.
881 * the item_power in the object is what the artfiact adds. 852 * the item_power in the object is what the artfiact adds.
923 { 894 {
924 if (op->type == POTION) 895 if (op->type == POTION)
925 /* Handle healing and magic power potions */ 896 /* Handle healing and magic power potions */
926 if (op->stats.sp && !op->randomitems) 897 if (op->stats.sp && !op->randomitems)
927 { 898 {
928 object *tmp;
929
930 tmp = get_archetype (spell_mapping[op->stats.sp]); 899 object *tmp = get_archetype (spell_mapping [op->stats.sp]);
931 insert_ob_in_ob (tmp, op); 900 insert_ob_in_ob (tmp, op);
932 op->stats.sp = 0; 901 op->stats.sp = 0;
933 } 902 }
934 } 903 }
935 else if (!op->title) /* Only modify object if not special */ 904 else if (!op->title) /* Only modify object if not special */
938 case WEAPON: 907 case WEAPON:
939 case ARMOUR: 908 case ARMOUR:
940 case SHIELD: 909 case SHIELD:
941 case HELMET: 910 case HELMET:
942 case CLOAK: 911 case CLOAK:
943 if (QUERY_FLAG (op, FLAG_CURSED) && !(RANDOM () % 4)) 912 if (QUERY_FLAG (op, FLAG_CURSED) && !(rndm (4)))
944 set_ring_bonus (op, -DICE2); 913 set_ring_bonus (op, -DICE2);
945 break; 914 break;
946 915
947 case BRACERS: 916 case BRACERS:
948 if (!(RANDOM () % (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))) 917 if (!rndm (QUERY_FLAG (op, FLAG_CURSED) ? 5 : 20))
949 { 918 {
950 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 919 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
951 if (!QUERY_FLAG (op, FLAG_CURSED)) 920 if (!QUERY_FLAG (op, FLAG_CURSED))
952 op->value *= 3; 921 op->value *= 3;
953 } 922 }
979 */ 948 */
980 if (op->inv && op->randomitems) 949 if (op->inv && op->randomitems)
981 { 950 {
982 /* value multiplier is same as for scrolls */ 951 /* value multiplier is same as for scrolls */
983 op->value = (op->value * op->inv->value); 952 op->value = (op->value * op->inv->value);
984 op->level = op->inv->level / 2 + RANDOM () % difficulty + RANDOM () % difficulty; 953 op->level = op->inv->level / 2 + rndm (difficulty) + rndm (difficulty);
985 } 954 }
986 else 955 else
987 { 956 {
988 op->name = "potion"; 957 op->name = "potion";
989 op->name_pl = "potions"; 958 op->name_pl = "potions";
990 } 959 }
991 960
992 if (!(flags & GT_ONLY_GOOD) && RANDOM () % 2) 961 if (!(flags & GT_ONLY_GOOD) && rndm (2))
993 SET_FLAG (op, FLAG_CURSED); 962 SET_FLAG (op, FLAG_CURSED);
994 break; 963 break;
995 } 964 }
996 965
997 case AMULET: 966 case AMULET:
998 if (op->arch == amulet_arch) 967 if (IS_ARCH (op->arch, amulet))
999 op->value *= 5; /* Since it's not just decoration */ 968 op->value *= 5; /* Since it's not just decoration */
1000 969
1001 case RING: 970 case RING:
1002 if (op->arch == NULL)
1003 {
1004 op->remove ();
1005 op->destroy (0);
1006 op = NULL;
1007 break;
1008 }
1009
1010 if (op->arch != ring_arch && op->arch != amulet_arch) /* It's a special artifact! */ 971 if (!IS_ARCH (op->arch, ring) && !IS_ARCH (op->arch, amulet)) /* It's a special artifact! */
1011 break; 972 break;
1012 973
1013 if (!(flags & GT_ONLY_GOOD) && !(RANDOM () % 3)) 974 if (!(flags & GT_ONLY_GOOD) && !(rndm (3)))
1014 SET_FLAG (op, FLAG_CURSED); 975 SET_FLAG (op, FLAG_CURSED);
1015 976
1016 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2); 977 set_ring_bonus (op, QUERY_FLAG (op, FLAG_CURSED) ? -DICE2 : DICE2);
1017 978
1018 if (op->type != RING) /* Amulets have only one ability */ 979 if (op->type != RING) /* Amulets have only one ability */
1019 break; 980 break;
1020 981
1021 if (!(RANDOM () % 4)) 982 if (!(rndm (4)))
1022 { 983 {
1023 int d = (RANDOM () % 2 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 984 int d = (rndm (2) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1024 985
1025 if (d > 0) 986 if (d > 0)
1026 op->value *= 3; 987 op->value *= 3;
1027 988
1028 set_ring_bonus (op, d); 989 set_ring_bonus (op, d);
1029 990
1030 if (!(RANDOM () % 4)) 991 if (!(rndm (4)))
1031 { 992 {
1032 int d = (RANDOM () % 3 || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2; 993 int d = (rndm (3) || QUERY_FLAG (op, FLAG_CURSED)) ? -DICE2 : DICE2;
1033 994
1034 if (d > 0) 995 if (d > 0)
1035 op->value *= 5; 996 op->value *= 5;
1036 set_ring_bonus (op, d); 997 set_ring_bonus (op, d);
1037 } 998 }
1038 } 999 }
1039 1000
1040 if (GET_ANIM_ID (op)) 1001 if (GET_ANIM_ID (op))
1041 SET_ANIMATION (op, RANDOM () % ((int) NUM_ANIMATIONS (op))); 1002 SET_ANIMATION (op, rndm (NUM_ANIMATIONS (op)));
1042 1003
1043 break; 1004 break;
1044 1005
1045 case BOOK: 1006 case BOOK:
1046 /* Is it an empty book?, if yes lets make a special· 1007 /* Is it an empty book?, if yes lets make a special·
1047 * msg for it, and tailor its properties based on the· 1008 * msg for it, and tailor its properties based on the·
1048 * creator and/or map level we found it on. 1009 * creator and/or map level we found it on.
1049 */ 1010 */
1050 if (!op->msg && RANDOM () % 10) 1011 if (!op->msg && rndm (10))
1051 { 1012 {
1052 /* set the book level properly */ 1013 /* set the book level properly */
1053 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE)) 1014 if (creator->level == 0 || QUERY_FLAG (creator, FLAG_ALIVE))
1054 { 1015 {
1055 if (op->map && op->map->difficulty) 1016 if (op->map && op->map->difficulty)
1056 op->level = RANDOM () % (op->map->difficulty) + RANDOM () % 10 + 1; 1017 op->level = rndm (op->map->difficulty) + rndm (10) + 1;
1057 else 1018 else
1058 op->level = RANDOM () % 20 + 1; 1019 op->level = rndm (20) + 1;
1059 } 1020 }
1060 else 1021 else
1061 op->level = RANDOM () % creator->level; 1022 op->level = rndm (creator->level);
1062 1023
1063 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1); 1024 tailor_readable_ob (op, (creator && creator->stats.sp) ? creator->stats.sp : -1);
1064 /* books w/ info are worth more! */ 1025 /* books w/ info are worth more! */
1065 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1)); 1026 op->value *= ((op->level > 10 ? op->level : (op->level + 1) / 2) * ((strlen (op->msg) / 250) + 1));
1066 /* creator related stuff */ 1027 /* creator related stuff */
1165 */ 1126 */
1166 1127
1167/* 1128/*
1168 * Allocate and return the pointer to an empty artifactlist structure. 1129 * Allocate and return the pointer to an empty artifactlist structure.
1169 */ 1130 */
1170
1171static artifactlist * 1131static artifactlist *
1172get_empty_artifactlist (void) 1132get_empty_artifactlist (void)
1173{ 1133{
1174 artifactlist *tl = (artifactlist *) malloc (sizeof (artifactlist)); 1134 return salloc0<artifactlist> ();
1175
1176 if (tl == NULL)
1177 fatal (OUT_OF_MEMORY);
1178 tl->next = NULL;
1179 tl->items = NULL;
1180 tl->total_chance = 0;
1181 return tl;
1182} 1135}
1183 1136
1184/* 1137/*
1185 * Allocate and return the pointer to an empty artifact structure. 1138 * Allocate and return the pointer to an empty artifact structure.
1186 */ 1139 */
1187
1188static artifact * 1140static artifact *
1189get_empty_artifact (void) 1141get_empty_artifact (void)
1190{ 1142{
1191 artifact *t = (artifact *) malloc (sizeof (artifact)); 1143 return salloc0<artifact> ();
1192
1193 if (t == NULL)
1194 fatal (OUT_OF_MEMORY);
1195 t->item = NULL;
1196 t->next = NULL;
1197 t->chance = 0;
1198 t->difficulty = 0;
1199 t->allowed = NULL;
1200 return t;
1201} 1144}
1202 1145
1203/* 1146/*
1204 * Searches the artifact lists and returns one that has the same type 1147 * Searches the artifact lists and returns one that has the same type
1205 * of objects on it. 1148 * of objects on it.
1206 */ 1149 */
1207
1208artifactlist * 1150artifactlist *
1209find_artifactlist (int type) 1151find_artifactlist (int type)
1210{ 1152{
1211 artifactlist *al;
1212
1213 for (al = first_artifactlist; al != NULL; al = al->next) 1153 for (artifactlist *al = first_artifactlist; al; al = al->next)
1214 if (al->type == type) 1154 if (al->type == type)
1215 return al; 1155 return al;
1216 return NULL;
1217}
1218 1156
1219/*
1220 * For debugging purposes. Dumps all tables.
1221 */
1222
1223void
1224dump_artifacts (void)
1225{
1226 artifactlist *al;
1227 artifact *art;
1228 linked_char *next;
1229
1230 fprintf (logfile, "\n");
1231 for (al = first_artifactlist; al != NULL; al = al->next)
1232 {
1233 fprintf (logfile, "Artifact has type %d, total_chance=%d\n", al->type, al->total_chance);
1234 for (art = al->items; art != NULL; art = art->next)
1235 {
1236 fprintf (logfile, "Artifact %-30s Difficulty %3d Chance %5d\n", &art->item->name, art->difficulty, art->chance);
1237 if (art->allowed != NULL)
1238 {
1239 fprintf (logfile, "\tAllowed combinations:");
1240 for (next = art->allowed; next != NULL; next = next->next)
1241 fprintf (logfile, "%s,", &next->name);
1242 fprintf (logfile, "\n");
1243 }
1244 }
1245 }
1246 fprintf (logfile, "\n");
1247}
1248
1249/*
1250 * For debugging purposes. Dumps all treasures recursively (see below).
1251 */
1252void
1253dump_monster_treasure_rec (const char *name, treasure *t, int depth)
1254{
1255 treasurelist *tl;
1256 int i;
1257
1258 if (depth > 100)
1259 return; 1157 return 0;
1260 while (t != NULL)
1261 {
1262 if (t->name != NULL)
1263 {
1264 for (i = 0; i < depth; i++)
1265 fprintf (logfile, " ");
1266 fprintf (logfile, "{ (list: %s)\n", &t->name);
1267 tl = find_treasurelist (t->name);
1268 dump_monster_treasure_rec (name, tl->items, depth + 2);
1269 for (i = 0; i < depth; i++)
1270 fprintf (logfile, " ");
1271 fprintf (logfile, "} (end of list: %s)\n", &t->name);
1272 }
1273 else
1274 {
1275 for (i = 0; i < depth; i++)
1276 fprintf (logfile, " ");
1277 if (t->item->clone.type == FLESH)
1278 fprintf (logfile, "%s's %s\n", name, &t->item->clone.name);
1279 else
1280 fprintf (logfile, "%s\n", &t->item->clone.name);
1281 }
1282 if (t->next_yes != NULL)
1283 {
1284 for (i = 0; i < depth; i++)
1285 fprintf (logfile, " ");
1286 fprintf (logfile, " (if yes)\n");
1287 dump_monster_treasure_rec (name, t->next_yes, depth + 1);
1288 }
1289 if (t->next_no != NULL)
1290 {
1291 for (i = 0; i < depth; i++)
1292 fprintf (logfile, " ");
1293 fprintf (logfile, " (if no)\n");
1294 dump_monster_treasure_rec (name, t->next_no, depth + 1);
1295 }
1296 t = t->next;
1297 }
1298}
1299
1300/*
1301 * For debugging purposes. Dumps all treasures for a given monster.
1302 * Created originally by Raphael Quinet for debugging the alchemy code.
1303 */
1304
1305void
1306dump_monster_treasure (const char *name)
1307{
1308 archetype *at;
1309 int found;
1310
1311 found = 0;
1312 fprintf (logfile, "\n");
1313 for (at = first_archetype; at != NULL; at = at->next)
1314 if (!strcasecmp (at->clone.name, name) && at->clone.title == NULL)
1315 {
1316 fprintf (logfile, "treasures for %s (arch: %s)\n", &at->clone.name, &at->name);
1317 if (at->clone.randomitems != NULL)
1318 dump_monster_treasure_rec (at->clone.name, at->clone.randomitems->items, 1);
1319 else
1320 fprintf (logfile, "(nothing)\n");
1321 fprintf (logfile, "\n");
1322 found++;
1323 }
1324 if (found == 0)
1325 fprintf (logfile, "No objects have the name %s!\n\n", name);
1326} 1158}
1327 1159
1328/* 1160/*
1329 * Builds up the lists of artifacts from the file in the libdir. 1161 * Builds up the lists of artifacts from the file in the libdir.
1330 */ 1162 */
1331
1332void 1163void
1333init_artifacts (void) 1164init_artifacts (void)
1334{ 1165{
1335 static int has_been_inited = 0; 1166 static int has_been_inited = 0;
1336 char filename[MAX_BUF], buf[HUGE_BUF], *cp, *next; 1167 char filename[MAX_BUF];
1337 artifact *art = NULL; 1168 artifact *art = NULL;
1338 linked_char *tmp;
1339 int value;
1340 artifactlist *al; 1169 artifactlist *al;
1341 1170
1342 if (has_been_inited) 1171 if (has_been_inited)
1343 return; 1172 return;
1344 else 1173 else
1345 has_been_inited = 1; 1174 has_been_inited = 1;
1346 1175
1347 sprintf (filename, "%s/artifacts", settings.datadir); 1176 sprintf (filename, "%s/artifacts", settings.datadir);
1348 object_thawer thawer (filename); 1177 object_thawer f (filename);
1349 1178
1350 if (!thawer) 1179 if (!f)
1351 return; 1180 return;
1352 1181
1353 while (fgets (buf, HUGE_BUF, thawer) != NULL) 1182 for (;;)
1354 { 1183 {
1355 if (*buf == '#') 1184 switch (f.kw)
1356 continue;
1357 if ((cp = strchr (buf, '\n')) != NULL)
1358 *cp = '\0';
1359 cp = buf;
1360 while (*cp == ' ') /* Skip blanks */
1361 cp++;
1362 if (*cp == '\0')
1363 continue;
1364
1365 if (!strncmp (cp, "Allowed", 7))
1366 { 1185 {
1186 case KW_allowed:
1367 if (art == NULL) 1187 if (!art)
1188 art = get_empty_artifact ();
1189
1368 { 1190 {
1369 art = get_empty_artifact (); 1191 if (!strcmp (f.get_str (), "all"))
1370 nrofartifacts++; 1192 break;
1193
1194 char *next, *cp = f.get_str ();
1195
1196 do
1197 {
1198 if ((next = strchr (cp, ',')))
1199 *next++ = '\0';
1200
1201 linked_char *tmp = new linked_char;
1202
1203 tmp->name = cp;
1204 tmp->next = art->allowed;
1205 art->allowed = tmp;
1206 }
1207 while ((cp = next));
1371 } 1208 }
1372 cp = strchr (cp, ' ') + 1; 1209 break;
1373 if (!strcmp (cp, "all")) 1210
1211 case KW_chance:
1212 f.get (art->chance);
1213 break;
1214
1215 case KW_difficulty:
1216 f.get (art->difficulty);
1217 break;
1218
1219 case KW_object:
1220 {
1221 art->item = object::create ();
1222 f.get (art->item->name);
1223 f.next ();
1224
1225 if (!art->item->parse_kv (f))
1226 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1227
1228 al = find_artifactlist (art->item->type);
1229
1230 if (!al)
1231 {
1232 al = get_empty_artifactlist ();
1233 al->type = art->item->type;
1234 al->next = first_artifactlist;
1235 first_artifactlist = al;
1236 }
1237
1238 art->next = al->items;
1239 al->items = art;
1240 art = 0;
1241 }
1374 continue; 1242 continue;
1375 1243
1376 do 1244 case KW_EOF:
1245 goto done;
1246
1247 default:
1248 if (!f.parse_error ("artifacts file"))
1249 cleanup ("artifacts file required");
1377 { 1250 break;
1378 nrofallowedstr++;
1379 if ((next = strchr (cp, ',')) != NULL)
1380 *(next++) = '\0';
1381 tmp = new linked_char;
1382
1383 tmp->name = cp;
1384 tmp->next = art->allowed;
1385 art->allowed = tmp;
1386 }
1387 while ((cp = next) != NULL);
1388 }
1389 else if (sscanf (cp, "chance %d", &value))
1390 art->chance = (uint16) value;
1391 else if (sscanf (cp, "difficulty %d", &value))
1392 art->difficulty = (uint8) value;
1393 else if (!strncmp (cp, "Object", 6))
1394 { 1251 }
1395 art->item = get_object ();
1396 1252
1397 if (!load_object (thawer, art->item, 0)) 1253 f.next ();
1398 LOG (llevError, "Init_Artifacts: Could not load object.\n");
1399
1400 art->item->name = strchr (cp, ' ') + 1;
1401 al = find_artifactlist (art->item->type);
1402 if (al == NULL)
1403 {
1404 al = get_empty_artifactlist ();
1405 al->type = art->item->type;
1406 al->next = first_artifactlist;
1407 first_artifactlist = al;
1408 }
1409 art->next = al->items;
1410 al->items = art;
1411 art = NULL;
1412 }
1413 else
1414 LOG (llevError, "Unknown input in artifact file: %s\n", buf);
1415 } 1254 }
1416 1255
1256done:
1417 for (al = first_artifactlist; al != NULL; al = al->next) 1257 for (al = first_artifactlist; al; al = al->next)
1418 { 1258 {
1259 al->total_chance = 0;
1260
1419 for (art = al->items; art != NULL; art = art->next) 1261 for (art = al->items; art; art = art->next)
1420 { 1262 {
1421 if (!art->chance) 1263 if (!art->chance)
1422 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name); 1264 LOG (llevError, "Warning: artifact with no chance: %s\n", &art->item->name);
1423 else 1265 else
1424 al->total_chance += art->chance; 1266 al->total_chance += art->chance;
1429 } 1271 }
1430 1272
1431 LOG (llevDebug, "done.\n"); 1273 LOG (llevDebug, "done.\n");
1432} 1274}
1433 1275
1434
1435/* 1276/*
1436 * Used in artifact generation. The bonuses of the first object 1277 * Used in artifact generation. The bonuses of the first object
1437 * is modified by the bonuses of the second object. 1278 * is modified by the bonuses of the second object.
1438 */ 1279 */
1439
1440void 1280void
1441add_abilities (object *op, object *change) 1281add_abilities (object *op, object *change)
1442{ 1282{
1443 int i, tmp; 1283 int i, tmp;
1444 1284
1445 if (change->face != blank_face) 1285 if (change->face != blank_face)
1446 { 1286 {
1447#ifdef TREASURE_VERBOSE 1287#ifdef TREASURE_VERBOSE
1448 LOG (llevDebug, "FACE: %d\n", change->face->number); 1288 LOG (llevDebug, "add_abilities change face: %d\n", change->face);
1449#endif 1289#endif
1450 op->face = change->face; 1290 op->face = change->face;
1451 } 1291 }
1452 1292
1453 for (i = 0; i < NUM_STATS; i++) 1293 for (i = 0; i < NUM_STATS; i++)
1454 change_attr_value (&(op->stats), i, get_attr_value (&(change->stats), i)); 1294 change_attr_value (&(op->stats), i, change->stats.stat (i));
1455 1295
1456 op->attacktype |= change->attacktype; 1296 op->attacktype |= change->attacktype;
1457 op->path_attuned |= change->path_attuned; 1297 op->path_attuned |= change->path_attuned;
1458 op->path_repelled |= change->path_repelled; 1298 op->path_repelled |= change->path_repelled;
1459 op->path_denied |= change->path_denied; 1299 op->path_denied |= change->path_denied;
1489 CLEAR_FLAG (op, FLAG_ANIMATE); 1329 CLEAR_FLAG (op, FLAG_ANIMATE);
1490 /* so artifacts will join */ 1330 /* so artifacts will join */
1491 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1331 if (!QUERY_FLAG (op, FLAG_ALIVE))
1492 op->speed = 0.0; 1332 op->speed = 0.0;
1493 1333
1494 update_ob_speed (op); 1334 op->set_speed (op->speed);
1495 } 1335 }
1496 1336
1497 if (change->nrof) 1337 if (change->nrof)
1498 op->nrof = RANDOM () % ((int) change->nrof) + 1; 1338 op->nrof = rndm (change->nrof) + 1;
1499 1339
1500 op->stats.exp += change->stats.exp; /* Speed modifier */ 1340 op->stats.exp += change->stats.exp; /* Speed modifier */
1501 op->stats.wc += change->stats.wc; 1341 op->stats.wc += change->stats.wc;
1502 op->stats.ac += change->stats.ac; 1342 op->stats.ac += change->stats.ac;
1503 1343
1507 * to cast. So convert that to into a spell and put it into 1347 * to cast. So convert that to into a spell and put it into
1508 * this object. 1348 * this object.
1509 */ 1349 */
1510 if (op->type == HORN || op->type == POTION) 1350 if (op->type == HORN || op->type == POTION)
1511 { 1351 {
1512 object *tmp_obj;
1513
1514 /* Remove any spells this object currently has in it */ 1352 /* Remove any spells this object currently has in it */
1515 while (op->inv) 1353 op->destroy_inv (false);
1516 {
1517 tmp_obj = op->inv;
1518 tmp_obj->remove ();
1519 tmp_obj->destroy (0);
1520 }
1521 1354
1522 tmp_obj = arch_to_object (change->other_arch); 1355 object *tmp = arch_to_object (change->other_arch);
1523 insert_ob_in_ob (tmp_obj, op); 1356 insert_ob_in_ob (tmp, op);
1524 } 1357 }
1525 /* No harm setting this for potions/horns */ 1358 /* No harm setting this for potions/horns */
1526 op->other_arch = change->other_arch; 1359 op->other_arch = change->other_arch;
1527 } 1360 }
1528 1361
1610 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100); 1443 op->gen_sp_armour = (signed char) (((int) op->gen_sp_armour * ((int) change->gen_sp_armour)) / (int) 100);
1611 } 1444 }
1612 1445
1613 op->value *= change->value; 1446 op->value *= change->value;
1614 1447
1615 if (change->material) 1448 if (change->materials)
1616 op->material = change->material; 1449 op->materials = change->materials;
1617 1450
1618 if (change->materialname) 1451 if (change->materialname)
1619 op->materialname = change->materialname; 1452 op->materialname = change->materialname;
1620 1453
1621 if (change->slaying) 1454 if (change->slaying)
1627 if (change->msg) 1460 if (change->msg)
1628 op->msg = change->msg; 1461 op->msg = change->msg;
1629} 1462}
1630 1463
1631static int 1464static int
1632legal_artifact_combination (object *op, artifact * art) 1465legal_artifact_combination (object *op, artifact *art)
1633{ 1466{
1634 int neg, success = 0; 1467 int neg, success = 0;
1635 linked_char *tmp; 1468 linked_char *tmp;
1636 const char *name; 1469 const char *name;
1637 1470
1638 if (art->allowed == (linked_char *) NULL) 1471 if (!art->allowed)
1639 return 1; /* Ie, "all" */ 1472 return 1; /* Ie, "all" */
1473
1640 for (tmp = art->allowed; tmp; tmp = tmp->next) 1474 for (tmp = art->allowed; tmp; tmp = tmp->next)
1641 { 1475 {
1642#ifdef TREASURE_VERBOSE 1476#ifdef TREASURE_VERBOSE
1643 LOG (llevDebug, "legal_art: %s\n", tmp->name); 1477 LOG (llevDebug, "legal_art: %s\n", &tmp->name);
1644#endif 1478#endif
1645 if (*tmp->name == '!') 1479 if (*tmp->name == '!')
1646 name = tmp->name + 1, neg = 1; 1480 name = tmp->name + 1, neg = 1;
1647 else 1481 else
1648 name = tmp->name, neg = 0; 1482 name = tmp->name, neg = 0;
1649 1483
1650 /* If we match name, then return the opposite of 'neg' */ 1484 /* If we match name, then return the opposite of 'neg' */
1651 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->name))) 1485 if (!strcmp (name, op->name) || (op->arch && !strcmp (name, op->arch->archname)))
1652 return !neg; 1486 return !neg;
1653 1487
1654 /* Set success as true, since if the match was an inverse, it means 1488 /* Set success as true, since if the match was an inverse, it means
1655 * everything is allowed except what we match 1489 * everything is allowed except what we match
1656 */ 1490 */
1657 else if (neg) 1491 else if (neg)
1658 success = 1; 1492 success = 1;
1659 } 1493 }
1494
1660 return success; 1495 return success;
1661} 1496}
1662 1497
1663/* 1498/*
1664 * Fixes the given object, giving it the abilities and titles 1499 * Fixes the given object, giving it the abilities and titles
1715 return; 1550 return;
1716 } 1551 }
1717 1552
1718 for (i = 0; i < ARTIFACT_TRIES; i++) 1553 for (i = 0; i < ARTIFACT_TRIES; i++)
1719 { 1554 {
1720 int roll = RANDOM () % al->total_chance; 1555 int roll = rndm (al->total_chance);
1721 1556
1722 for (art = al->items; art != NULL; art = art->next) 1557 for (art = al->items; art; art = art->next)
1723 { 1558 {
1724 roll -= art->chance; 1559 roll -= art->chance;
1725 if (roll < 0) 1560 if (roll < 0)
1726 break; 1561 break;
1727 } 1562 }
1731#if 1 1566#if 1
1732 LOG (llevError, "Got null entry and non zero roll in generate_artifact, type %d\n", op->type); 1567 LOG (llevError, "Got null entry and non zero roll in generate_artifact, type %d\n", op->type);
1733#endif 1568#endif
1734 return; 1569 return;
1735 } 1570 }
1736 if (!strcmp (art->item->name, "NONE")) 1571
1572 if (art->item->name == shstr_NONE)
1737 return; 1573 return;
1574
1738 if (FABS (op->magic) < art->item->magic) 1575 if (fabs (op->magic) < art->item->magic)
1739 continue; /* Not magic enough to be this item */ 1576 continue; /* Not magic enough to be this item */
1740 1577
1741 /* Map difficulty not high enough */ 1578 /* Map difficulty not high enough */
1742 if (difficulty < art->difficulty) 1579 if (difficulty < art->difficulty)
1743 continue; 1580 continue;
1744 1581
1745 if (!legal_artifact_combination (op, art)) 1582 if (!legal_artifact_combination (op, art))
1746 { 1583 {
1747#ifdef TREASURE_VERBOSE 1584#ifdef TREASURE_VERBOSE
1748 LOG (llevDebug, "%s of %s was not a legal combination.\n", op->name, art->item->name); 1585 LOG (llevDebug, "%s of %s was not a legal combination.\n", &op->name, &art->item->name);
1749#endif 1586#endif
1750 continue; 1587 continue;
1751 } 1588 }
1589
1752 give_artifact_abilities (op, art->item); 1590 give_artifact_abilities (op, art->item);
1753 return; 1591 return;
1754 } 1592 }
1755} 1593}
1756 1594
1793 item->level = donor->level; 1631 item->level = donor->level;
1794 1632
1795 /* if donor has some attacktypes, the flesh is poisonous */ 1633 /* if donor has some attacktypes, the flesh is poisonous */
1796 if (donor->attacktype & AT_POISON) 1634 if (donor->attacktype & AT_POISON)
1797 item->type = POISON; 1635 item->type = POISON;
1636
1798 if (donor->attacktype & AT_ACID) 1637 if (donor->attacktype & AT_ACID)
1799 item->stats.hp = -1 * item->stats.food; 1638 item->stats.hp = -1 * item->stats.food;
1639
1800 SET_FLAG (item, FLAG_NO_STEAL); 1640 SET_FLAG (item, FLAG_NO_STEAL);
1801 } 1641 }
1802} 1642}
1803 1643
1804/* special_potion() - so that old potion code is still done right. */ 1644/* special_potion() - so that old potion code is still done right. */
1805
1806int 1645int
1807special_potion (object *op) 1646special_potion (object *op)
1808{ 1647{
1809
1810 int i;
1811
1812 if (op->attacktype) 1648 if (op->attacktype)
1813 return 1; 1649 return 1;
1814 1650
1815 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha) 1651 if (op->stats.Str || op->stats.Dex || op->stats.Con || op->stats.Pow || op->stats.Wis || op->stats.Int || op->stats.Cha)
1816 return 1; 1652 return 1;
1817 1653
1818 for (i = 0; i < NROFATTACKS; i++) 1654 for (int i = 0; i < NROFATTACKS; i++)
1819 if (op->resist[i]) 1655 if (op->resist[i])
1820 return 1; 1656 return 1;
1821 1657
1822 return 0; 1658 return 0;
1823} 1659}
1824 1660
1825void 1661void
1826free_treasurestruct (treasure *t) 1662free_treasurestruct (treasure *t)
1827{ 1663{
1828 if (t->next)
1829 free_treasurestruct (t->next); 1664 if (t->next) free_treasurestruct (t->next);
1830 if (t->next_yes)
1831 free_treasurestruct (t->next_yes); 1665 if (t->next_yes) free_treasurestruct (t->next_yes);
1832 if (t->next_no)
1833 free_treasurestruct (t->next_no); 1666 if (t->next_no) free_treasurestruct (t->next_no);
1834 1667
1835 delete t; 1668 delete t;
1836} 1669}
1837 1670
1838void 1671void
1843 1676
1844 delete lc; 1677 delete lc;
1845} 1678}
1846 1679
1847void 1680void
1848free_artifact (artifact * at) 1681free_artifact (artifact *at)
1849{ 1682{
1850 if (at->next)
1851 free_artifact (at->next); 1683 if (at->next) free_artifact (at->next);
1852
1853 if (at->allowed)
1854 free_charlinks (at->allowed); 1684 if (at->allowed) free_charlinks (at->allowed);
1855 1685
1856 at->item->destroy (1); 1686 at->item->destroy ();
1857 1687
1858 delete at; 1688 sfree (at);
1859} 1689}
1860 1690
1861void 1691void
1862free_artifactlist (artifactlist * al) 1692free_artifactlist (artifactlist *al)
1863{ 1693{
1864 artifactlist *nextal; 1694 artifactlist *nextal;
1865 1695
1866 for (al = first_artifactlist; al; al = nextal) 1696 for (al = first_artifactlist; al; al = nextal)
1867 { 1697 {
1868 nextal = al->next; 1698 nextal = al->next;
1869 1699
1870 if (al->items) 1700 if (al->items)
1871 free_artifact (al->items); 1701 free_artifact (al->items);
1872 1702
1873 free (al); 1703 sfree (al);
1874 } 1704 }
1875} 1705}
1876 1706
1877void 1707void
1878free_all_treasures (void) 1708free_all_treasures (void)
1879{ 1709{
1880 treasurelist *tl, *next; 1710 treasurelist *tl, *next;
1881 1711
1882
1883 for (tl = first_treasurelist; tl != NULL; tl = next) 1712 for (tl = first_treasurelist; tl; tl = next)
1884 { 1713 {
1714 clear (tl);
1715
1885 next = tl->next; 1716 next = tl->next;
1886 if (tl->items)
1887 free_treasurestruct (tl->items);
1888 delete tl; 1717 delete tl;
1889 } 1718 }
1719
1890 free_artifactlist (first_artifactlist); 1720 free_artifactlist (first_artifactlist);
1891} 1721}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines