[ViewVC] Diff of: cvs/deliantra/server/common/utils.C

Comparing deliantra/server/common/utils.C (file contents):
Revision 1.77 by root, Sun May 4 14:12:37 2008 UTC vs.
Revision 1.83 by root, Sun Dec 28 06:59:26 2008 UTC

 #include <signal.h>
 #include <global.h>
 #include <material.h>
+#include <sys/time.h>
+#include <sys/resource.h>
 #include <glib.h>
 refcnt_base::refcnt_t refcnt_dummy;
 ssize_t slice_alloc;
 rand_gen rndm, rmg_rndm;
  * not the recipient (ie, the poor slob getting hit). [garbled 20010916]
  */
 int
 random_roll (int r_min, int r_max, const object *op, int goodbad)
 {
+  r_max = max (r_min, r_max);
   int base = r_max - r_min > 1 ? 20 : 50;     /* d2 and d3 are corner cases */
-  if (r_max < r_min)
-    {
-      LOG (llevError | logBacktrace, "Calling random_roll with min=%d max=%d\n", r_min, r_max);
-      return r_min;
-    }
   if (op->type == PLAYER)
     {
       int luck = op->stats.luck;
 /*
  * This is a 64 bit version of random_roll above.  This is needed
  * for exp loss calculations for players changing religions.
  */
 sint64
-random_roll64 (sint64 min, sint64 max, const object *op, int goodbad)
+random_roll64 (sint64 r_min, sint64 r_max, const object *op, int goodbad)
 {
-  sint64 omin = min;
+  sint64 omin = r_min;
-  sint64 diff = max - min + 1;
+  sint64 range = max (0, r_max - r_min + 1);
-  int base = diff > 2 ? 20 : 50;     /* d2 and d3 are corner cases */
+  int base = range > 2 ? 20 : 50;     /* d2 and d3 are corner cases */
-  if (diff < 0)
-    {
-      LOG (llevError | logBacktrace, "Calling random_roll64 with min=%" PRId64 " max=%" PRId64 "\n", min, max);
-      return (min);             /* avoids a float exception */
-    }
   /*
    * Make a call to get two 32 bit unsigned random numbers, and just to
    * a little bitshifting.
    */
   sint64 ran = (sint64) rndm.next () ^ ((sint64) rndm.next () << 31);
   if (op->type != PLAYER)
-    return ((ran % diff) + min);
+    return ((ran % range) + r_min);
   int luck = op->stats.luck;
-  if (rndm (base) < MIN (10, abs (luck)))
+  if (rndm (base) < min (10, abs (luck)))
     {
       /* we have a winner */
       ((luck > 0) ? (luck = 1) : (luck = -1));
-      diff -= luck;
+      range -= luck;
-      if (diff < 1)
+      if (range < 1)
         return (omin);          /*check again */
-      ((goodbad) ? (min += luck) : (diff));
+      ((goodbad) ? (r_min += luck) : (range));
-      return (MAX (omin, MIN (max, (ran % diff) + min)));
+      return (max (omin, min (r_max, (ran % range) + r_min)));
     }
-  return ran % diff + min;
+  return ran % range + r_min;
 }
 /*
  * Roll a number of dice (2d3, 4d6).  Uses op to determine luck,
  * If goodbad is non-zero, luck increases the roll, if zero, it decreases.
 }
 /* convert materialname to materialtype_t */
 materialtype_t *
-name_to_material (const shstr &name)
+name_to_material (const shstr_cmp name)
 {
-  for (materialtype_t *mt = materialt; mt && mt->next; mt = mt->next)
+  for (materialtype_t *mt = materialt; mt; mt = mt->next)
     if (name == mt->name)
       return mt;
   return 0;
 }
 transmute_materialname (object *op, const object *change)
 {
   materialtype_t *mt;
   int j;
-  if (op->materialname == NULL)
+  if (!op->materialname)
     return;
-  if (change->materialname != NULL && strcmp (op->materialname, change->materialname))
+  if (change->materialname && strcmp (op->materialname, change->materialname))
     return;
   if (!op->is_armor ())
     return;
 void
 set_materialname (object *op, int difficulty, materialtype_t *nmt)
 {
   materialtype_t *mt, *lmt;
-  if (op->materialname != NULL)
+  if (!op->materialname)
     return;
-  if (nmt == NULL)
+  if (nmt)
+    lmt = nmt;
+  else
     {
-      lmt = NULL;
+      lmt = 0;
-      for (mt = materialt; mt && mt->next; mt = mt->next)
+      for (mt = materialt; mt; mt = mt->next)
         if (op->materials & mt->material && rndm (1, 100) <= mt->chance &&
             difficulty >= mt->difficulty && (op->magic >= mt->magic || mt->magic == 0))
           {
             lmt = mt;
             if (!(op->is_weapon () || op->is_armor ()))
               break;
           }
     }
-  else
-    lmt = nmt;
-  if (lmt != NULL)
+  if (lmt)
     {
       if (op->stats.dam && op->is_weapon ())
         {
           op->stats.dam += lmt->damage;
           if (op->stats.dam < 1)
 void
 fork_abort (const char *msg)
 {
   if (!fork ())
     {
+      signal (SIGINT , SIG_IGN);
+      signal (SIGTERM, SIG_IGN);
-      signal (SIGABRT, SIG_DFL);
+      signal (SIGABRT, SIG_IGN);
+      signal (SIGSEGV, SIG_DFL);
+      signal (SIGBUS , SIG_DFL);
+      signal (SIGILL , SIG_DFL);
+      signal (SIGTRAP, SIG_DFL);
       // try to put corefiles into a subdirectory, if existing, to allow
       // an administrator to reduce the I/O load.
       chdir ("cores");
+      // try to detach us from as many external dependencies as possible
+      // as coredumping can take time by closing all fd's.
+      {
+        struct rlimit lim;
+        if (getrlimit (RLIMIT_NOFILE, &lim))
+          lim.rlim_cur = 1024;
+        for (int i = 0; i < lim.rlim_cur; ++i)
+          close (i);
+      }
+      {
+        sigset_t empty;
+        sigemptyset (&empty);
+        sigprocmask (SIG_SETMASK, &empty, 0);
+      }
+      // try to coredump with SIGTRAP
+      kill (getpid (), SIGTRAP);
       abort ();
     }
   LOG (llevError, "fork abort: %s\n", msg);
 }

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/utils.C (file contents): Revision 1.77 by root, Sun May 4 14:12:37 2008 UTC vs. Revision 1.83 by root, Sun Dec 28 06:59:26 2008 UTC

Diff Legend

Comparing deliantra/server/common/utils.C (file contents):
Revision 1.77 by root, Sun May 4 14:12:37 2008 UTC vs.
Revision 1.83 by root, Sun Dec 28 06:59:26 2008 UTC