ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/utils.C
(Generate patch)

Comparing deliantra/server/common/utils.C (file contents):
Revision 1.60 by root, Sun Jul 1 05:00:18 2007 UTC vs.
Revision 1.89 by root, Mon Oct 12 14:00:57 2009 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24/* 25/*
25 * General convenience functions for crossfire. 26 * General convenience functions for crossfire.
26 */ 27 */
… …
31#include <sys/time.h> 32#include <sys/time.h>
32#include <time.h> 33#include <time.h>
33#include <signal.h> 34#include <signal.h>
34 35
35#include <global.h> 36#include <global.h>
36#include <funcpoint.h>
37#include <material.h> 37#include <material.h>
38#include <object.h>
39
40#include <sys/time.h>
41#include <sys/resource.h>
38 42
39#include <glib.h> 43#include <glib.h>
40 44
41rand_gen rndm; 45refcnt_base::refcnt_t refcnt_dummy;
46ssize_t slice_alloc;
47rand_gen rndm, rmg_rndm;
42 48
43void 49void
44tausworthe_random_generator::seed (uint32_t seed) 50tausworthe_random_generator::seed (uint32_t seed)
45{ 51{
46 state [0] = seed * 69069U; if (state [0] < 2U) state [0] += 2U; 52 state [0] = seed * 69069U; if (state [0] < 2U) state [0] += 2U;
47 state [1] = state [0] * 69069U; if (state [0] < 8U) state [0] += 8U; 53 state [1] = state [0] * 69069U; if (state [0] < 8U) state [0] += 8U;
48 state [2] = state [1] * 69069U; if (state [0] < 16U) state [0] += 16U; 54 state [2] = state [1] * 69069U; if (state [0] < 16U) state [0] += 16U;
49 state [3] = state [2] * 69069U; if (state [0] < 128) state [0] += 128U; 55 state [3] = state [2] * 69069U; if (state [0] < 128U) state [0] += 128U;
50 56
51 for (int i = 11; --i; ) 57 for (int i = 11; --i; )
52 operator ()(); 58 next ();
53} 59}
54 60
55uint32_t 61uint32_t
56tausworthe_random_generator::next () 62tausworthe_random_generator::next ()
57{ 63{
… …
61 state [3] = ((state [3] & 0xFFFFFF80U) << 13U) ^ (((state [3] << 3U) ^ state [3]) >> 12U); 67 state [3] = ((state [3] & 0xFFFFFF80U) << 13U) ^ (((state [3] << 3U) ^ state [3]) >> 12U);
62 68
63 return state [0] ^ state [1] ^ state [2] ^ state [3]; 69 return state [0] ^ state [1] ^ state [2] ^ state [3];
64} 70}
65 71
72template<class generator>
66uint32_t 73uint32_t
67tausworthe_random_generator::get_range (uint32_t num) 74random_number_generator<generator>::get_range (uint32_t num)
68{ 75{
69 return (next () * (uint64_t)num) >> 32U; 76 return (this->next () * (uint64_t)num) >> 32U;
70} 77}
71 78
72// return a number within (min .. max) 79// return a number within (min .. max)
80template<class generator>
73int 81int
74tausworthe_random_generator::get_range (int r_min, int r_max) 82random_number_generator<generator>::get_range (int r_min, int r_max)
75{ 83{
76 return r_min + get_range (max (r_max - r_min + 1, 0)); 84 return r_min + get_range (max (r_max - r_min + 1, 0));
77} 85}
86
87template struct random_number_generator<tausworthe_random_generator>;
88template struct random_number_generator<xorshift_random_generator>;
78 89
79/* 90/*
80 * The random functions here take luck into account when rolling random 91 * The random functions here take luck into account when rolling random
81 * dice or numbers. This function has less of an impact the larger the 92 * dice or numbers. This function has less of an impact the larger the
82 * difference becomes in the random numbers. IE, the effect is lessened 93 * difference becomes in the random numbers. IE, the effect is lessened
… …
92 * not the recipient (ie, the poor slob getting hit). [garbled 20010916] 103 * not the recipient (ie, the poor slob getting hit). [garbled 20010916]
93 */ 104 */
94int 105int
95random_roll (int r_min, int r_max, const object *op, int goodbad) 106random_roll (int r_min, int r_max, const object *op, int goodbad)
96{ 107{
108 r_max = max (r_min, r_max);
109
97 int base = r_max - r_min > 1 ? 20 : 50; /* d2 and d3 are corner cases */ 110 int base = r_max - r_min > 1 ? 20 : 50; /* d2 and d3 are corner cases */
98
99 if (r_max < r_min)
100 {
101 LOG (llevError | logBacktrace, "Calling random_roll with min=%d max=%d\n", r_min, r_max);
102 return r_min;
103 }
104 111
105 if (op->type == PLAYER) 112 if (op->type == PLAYER)
106 { 113 {
107 int luck = op->stats.luck; 114 int luck = op->stats.luck;
108 115
… …
118/* 125/*
119 * This is a 64 bit version of random_roll above. This is needed 126 * This is a 64 bit version of random_roll above. This is needed
120 * for exp loss calculations for players changing religions. 127 * for exp loss calculations for players changing religions.
121 */ 128 */
122sint64 129sint64
123random_roll64 (sint64 min, sint64 max, const object *op, int goodbad) 130random_roll64 (sint64 r_min, sint64 r_max, const object *op, int goodbad)
124{ 131{
125 sint64 omin = min; 132 sint64 omin = r_min;
126 sint64 diff = max - min + 1; 133 sint64 range = max (0, r_max - r_min + 1);
127 int base = diff > 2 ? 20 : 50; /* d2 and d3 are corner cases */ 134 int base = range > 2 ? 20 : 50; /* d2 and d3 are corner cases */
128
129 if (diff < 0)
130 {
131 LOG (llevError | logBacktrace, "Calling random_roll64 with min=%" PRId64 " max=%" PRId64 "\n", min, max);
132 return (min); /* avoids a float exception */
133 }
134 135
135 /* 136 /*
136 * Make a call to get two 32 bit unsigned random numbers, and just to 137 * Make a call to get two 32 bit unsigned random numbers, and just to
137 * a little bitshifting. 138 * a little bitshifting.
138 */ 139 */
139 sint64 ran = (sint64) rndm.next () ^ ((sint64) rndm.next () << 31); 140 sint64 ran = (sint64) rndm.next () ^ ((sint64) rndm.next () << 31);
140 141
141 if (op->type != PLAYER) 142 if (op->type != PLAYER)
142 return ((ran % diff) + min); 143 return ((ran % range) + r_min);
143 144
144 int luck = op->stats.luck; 145 int luck = op->stats.luck;
145 146
146 if (rndm (base) < MIN (10, abs (luck))) 147 if (rndm (base) < min (10, abs (luck)))
147 { 148 {
148 /* we have a winner */ 149 /* we have a winner */
149 ((luck > 0) ? (luck = 1) : (luck = -1)); 150 ((luck > 0) ? (luck = 1) : (luck = -1));
150 diff -= luck; 151 range -= luck;
151 if (diff < 1) 152 if (range < 1)
152 return (omin); /*check again */ 153 return (omin); /*check again */
153 154
154 ((goodbad) ? (min += luck) : (diff)); 155 ((goodbad) ? (r_min += luck) : (range));
155 156
156 return (MAX (omin, MIN (max, (ran % diff) + min))); 157 return (max (omin, min (r_max, (ran % range) + r_min)));
157 } 158 }
158 159
159 return ran % diff + min; 160 return ran % range + r_min;
160} 161}
161 162
162/* 163/*
163 * Roll a number of dice (2d3, 4d6). Uses op to determine luck, 164 * Roll a number of dice (2d3, 4d6). Uses op to determine luck,
164 * If goodbad is non-zero, luck increases the roll, if zero, it decreases. 165 * If goodbad is non-zero, luck increases the roll, if zero, it decreases.
… …
206} 207}
207 208
208/* convert materialname to materialtype_t */ 209/* convert materialname to materialtype_t */
209 210
210materialtype_t * 211materialtype_t *
211name_to_material (const shstr &name) 212name_to_material (const shstr_cmp name)
212{ 213{
213 for (materialtype_t *mt = materialt; mt && mt->next; mt = mt->next) 214 for (materialtype_t *mt = materialt; mt; mt = mt->next)
214 if (name == mt->name) 215 if (name == mt->name)
215 return mt; 216 return mt;
216 217
217 return materialt; 218 return 0;
218} 219}
219 220
220/* when doing transmutation of objects, we have to recheck the resistances, 221/* when doing transmutation of objects, we have to recheck the resistances,
221 * as some that did not apply previously, may apply now. 222 * as some that did not apply previously, may apply now.
222 */ 223 */
223
224void 224void
225transmute_materialname (object *op, const object *change) 225transmute_materialname (object *op, const object *change)
226{ 226{
227 materialtype_t *mt; 227 materialtype_t *mt;
228 int j; 228 int j;
229 229
230 if (op->materialname == NULL) 230 if (!op->materialname)
231 return; 231 return;
232 232
233 if (change->materialname != NULL && strcmp (op->materialname, change->materialname)) 233 if (op->materialname != change->materialname)
234 return; 234 return;
235 235
236 if (!op->is_armor ()) 236 if (!op->is_armor ())
237 return; 237 return;
238 238
… …
258void 258void
259set_materialname (object *op, int difficulty, materialtype_t *nmt) 259set_materialname (object *op, int difficulty, materialtype_t *nmt)
260{ 260{
261 materialtype_t *mt, *lmt; 261 materialtype_t *mt, *lmt;
262 262
263#ifdef NEW_MATERIAL_CODE
264 int j;
265#endif
266
267 if (op->materialname != NULL) 263 if (!op->materialname)
268 return; 264 return;
269 265
270 266 if (nmt)
271 267 lmt = nmt;
272 if (nmt == NULL) 268 else
273 { 269 {
274 lmt = NULL; 270 lmt = 0;
275#ifndef NEW_MATERIAL_CODE 271
276 for (mt = materialt; mt && mt->next; mt = mt->next) 272 for (mt = materialt; mt; mt = mt->next)
277 { 273 if (op->materials & mt->material && rndm (1, 100) <= mt->chance &&
278 if (op->materials & mt->material) 274 difficulty >= mt->difficulty && (op->magic >= mt->magic || mt->magic == 0))
279 { 275 {
280 lmt = mt; 276 lmt = mt;
277 if (!(op->is_weapon () || op->is_armor ()))
281 break; 278 break;
282 } 279 }
283 }
284
285#else
286 for (mt = materialt; mt && mt->next; mt = mt->next)
287 {
288 if (op->materials & mt->material && rndm (1, 100) <= mt->chance &&
289 difficulty >= mt->difficulty && (op->magic >= mt->magic || mt->magic == 0))
290 {
291 lmt = mt;
292 if (!(op->is_weapon () || op->is_armor ()))
293 break;
294 }
295 }
296#endif
297 }
298 else
299 { 280 }
300 lmt = nmt; 281
282 if (lmt)
301 } 283 {
302
303 if (lmt != NULL)
304 {
305#ifndef NEW_MATERIAL_CODE
306 op->materialname = lmt->name;
307 return;
308#else
309
310 if (op->stats.dam && op->is_weapon ()) 284 if (op->stats.dam && op->is_weapon ())
311 { 285 {
312 op->stats.dam += lmt->damage; 286 op->stats.dam += lmt->damage;
313 if (op->stats.dam < 1) 287 if (op->stats.dam < 1)
314 op->stats.dam = 1; 288 op->stats.dam = 1;
… …
320 op->stats.wc += lmt->wc; 294 op->stats.wc += lmt->wc;
321 if (op->is_armor ()) 295 if (op->is_armor ())
322 { 296 {
323 if (op->stats.ac) 297 if (op->stats.ac)
324 op->stats.ac += lmt->ac; 298 op->stats.ac += lmt->ac;
299
325 for (j = 0; j < NROFATTACKS; j++) 300 for (int j = 0; j < NROFATTACKS; j++)
326 if (op->resist[j] != 0) 301 if (op->resist[j] != 0)
327 { 302 {
328 op->resist[j] += lmt->mod[j]; 303 op->resist[j] += lmt->mod[j];
329 if (op->resist[j] > 100) 304 if (op->resist[j] > 100)
330 op->resist[j] = 100; 305 op->resist[j] = 100;
331 if (op->resist[j] < -100) 306 if (op->resist[j] < -100)
332 op->resist[j] = -100; 307 op->resist[j] = -100;
333 } 308 }
334 } 309 }
310
335 op->materialname = lmt->name; 311 op->materialname = lmt->name;
336 /* dont make it unstackable if it doesn't need to be */ 312 /* dont make it unstackable if it doesn't need to be */
337 if (op->is_weapon () || op->is_armor ()) 313 if (op->is_weapon () || op->is_armor ())
338 { 314 {
339 op->weight = (op->weight * lmt->weight) / 100; 315 op->weight = (op->weight * lmt->weight) / 100;
340 op->value = (op->value * lmt->value) / 100; 316 op->value = (op->value * lmt->value) / 100;
341 } 317 }
342#endif
343 } 318 }
344} 319}
345 320
346/* 321/*
347 * Strip out the media tags from a String. 322 * Strip out the media tags from a String.
… …
442 * a 'list' for the purposes here, is a string of items, seperated by commas, except 417 * a 'list' for the purposes here, is a string of items, seperated by commas, except
443 * for the last entry, which has an 'and' before it, and a full stop (period) after it. 418 * for the last entry, which has an 'and' before it, and a full stop (period) after it.
444 * This function will also strip all trailing non alphanumeric characters. 419 * This function will also strip all trailing non alphanumeric characters.
445 * It does not insert an oxford comma. 420 * It does not insert an oxford comma.
446 */ 421 */
447
448void 422void
449make_list_like (char *input) 423make_list_like (char *input)
450{ 424{
451 char *p, tmp[MAX_BUF]; 425 char *p, tmp[MAX_BUF];
452 int i; 426 int i;
… …
475 strcpy (input, tmp); 449 strcpy (input, tmp);
476 450
477 return; 451 return;
478} 452}
479 453
454/******************************************************************************/
455
456/* Checks a player-provided string which will become the msg property of
457 * an object for dangerous input.
458 */
459bool
460msg_is_safe (const char *msg)
461{
462 bool safe = true;
463
464 /* Trying to cheat by getting data into the object */
465 if (!strncmp (msg, "endmsg", sizeof ("endmsg") - 1)
466 || strstr (msg, "\nendmsg"))
467 safe = false;
468
469 /* Trying to make the object talk, and potentially access arbitrary code */
470 if (object::msg_has_dialogue (msg))
471 safe = false;
472
473 return safe;
474}
475
480///////////////////////////////////////////////////////////////////////////// 476/////////////////////////////////////////////////////////////////////////////
481 477
482void 478void
483fork_abort (const char *msg) 479fork_abort (const char *msg)
484{ 480{
485 if (!fork ()) 481 if (!fork ())
486 { 482 {
483 signal (SIGINT , SIG_IGN);
484 signal (SIGTERM, SIG_IGN);
487 signal (SIGABRT, SIG_DFL); 485 signal (SIGABRT, SIG_IGN);
486
487 signal (SIGSEGV, SIG_DFL);
488 signal (SIGBUS , SIG_DFL);
489 signal (SIGILL , SIG_DFL);
490 signal (SIGTRAP, SIG_DFL);
491
488 // try to put corefiles into a subdirectory, if existing, to allow 492 // try to put corefiles into a subdirectory, if existing, to allow
489 // an administrator to reduce the I/O load. 493 // an administrator to reduce the I/O load.
490 chdir ("cores"); 494 chdir ("cores");
495
496 // try to detach us from as many external dependencies as possible
497 // as coredumping can take time by closing all fd's.
498 {
499 struct rlimit lim;
500
501 if (getrlimit (RLIMIT_NOFILE, &lim))
502 lim.rlim_cur = 1024;
503
504 for (int i = 0; i < lim.rlim_cur; ++i)
505 close (i);
506 }
507
508 {
509 sigset_t empty;
510 sigemptyset (&empty);
511 sigprocmask (SIG_SETMASK, &empty, 0);
512 }
513
514 // try to coredump with SIGTRAP
515 kill (getpid (), SIGTRAP);
491 abort (); 516 abort ();
492 } 517 }
493 518
494 LOG (llevError, "fork abort: %s\n", msg); 519 LOG (llevError, "fork abort: %s\n", msg);
495} 520}
496 521
497void *salloc_ (int n) throw (std::bad_alloc) 522void *salloc_ (int n) throw (std::bad_alloc)
498{ 523{
499#ifdef PREFER_MALLOC
500 void *ptr = malloc (n);
501#else
502 void *ptr = g_slice_alloc (n); 524 void *ptr = g_slice_alloc (n);
503#endif
504 525
505 if (!ptr) 526 if (!ptr)
506 throw std::bad_alloc (); 527 throw std::bad_alloc ();
507 528
529 slice_alloc += n;
508 return ptr; 530 return ptr;
509} 531}
510 532
511void *salloc_ (int n, void *src) throw (std::bad_alloc) 533void *salloc_ (int n, void *src) throw (std::bad_alloc)
512{ 534{
… …
518 memset (ptr, 0, n); 540 memset (ptr, 0, n);
519 541
520 return ptr; 542 return ptr;
521} 543}
522 544
545/******************************************************************************/
546
547#if DEBUG_SALLOC
548
549#define MAGIC 0xa1b2c35543deadLL
550
551void *g_slice_alloc (unsigned long size)
552{
553 unsigned long *p = (unsigned long *) (g_slice_alloc)(size + sizeof (unsigned long));
554 *p++ = size ^ MAGIC;
555 //fprintf (stderr, "g_slice_alloc %ld %p\n", size, p);//D
556 return (void *)p;
557}
558
559void *g_slice_alloc0 (unsigned long size)
560{
561 return memset (g_slice_alloc (size), 0, size);
562}
563
564void g_slice_free1 (unsigned long size, void *ptr)
565{
566 //fprintf (stderr, "g_slice_free %ld %p\n", size, ptr);//D
567 if (expect_true (ptr))
568 {
569 unsigned long *p = (unsigned long *)ptr;
570 unsigned long s = *--p ^ MAGIC;
571
572 if (size != (unsigned long)(*p ^ MAGIC))
573 {
574 LOG (logBacktrace | llevError, "slice free size (%lx) doesn't match alloc size (%lx)\n", size, s);
575 abort ();
576 }
577
578 *p = MAGIC;
579
580 (g_slice_free1)(s + sizeof (unsigned long), p);
581 }
582}
583
584#endif
585
586/******************************************************************************/
587
588int
523void assign (char *dst, const char *src, int maxlen) 589assign (char *dst, const char *src, int maxsize)
524{ 590{
525 if (!src) 591 if (!src)
526 src = ""; 592 src = "";
527 593
528 int len = strlen (src); 594 int len = strlen (src);
529 595
530 if (len >= maxlen - 1) 596 if (len >= maxsize)
531 { 597 {
532 if (maxlen <= 4) 598 if (maxsize <= 4)
533 { 599 {
534 memset (dst, '.', maxlen - 1); 600 memset (dst, '.', maxsize - 2);
535 dst [maxlen - 1] = 0; 601 dst [maxsize - 1] = 0;
536 } 602 }
537 else 603 else
538 { 604 {
539 memcpy (dst, src, maxlen - 4); 605 memcpy (dst, src, maxsize - 4);
540 memcpy (dst + maxlen - 4, "...", 4); 606 memcpy (dst + maxsize - 4, "...", 4);
541 } 607 }
608
609 len = maxsize;
542 } 610 }
543 else 611 else
544 memcpy (dst, src, len + 1); 612 memcpy (dst, src, ++len);
545}
546 613
547const std::string 614 return len;
615}
616
617const char *
548format (const char *format, ...) 618format (const char *format, ...)
549{ 619{
550 int len; 620 static dynbuf_text buf;
551 621
552 { 622 buf.clear ();
553 char buf[128];
554 623
555 va_list ap; 624 va_list ap;
556 va_start (ap, format); 625 va_start (ap, format);
557 len = vsnprintf (buf, sizeof (buf), format, ap); 626 buf.vprintf (format, ap);
558 va_end (ap); 627 va_end (ap);
559 628
560 assert (len >= 0); // shield againstz broken vsnprintf's
561
562 // was our static buffer short enough?
563 if (len < sizeof (buf))
564 return std::string (buf, len);
565 }
566
567 {
568 // longer, try harder
569 char *buf = salloc<char> (len + 1);
570
571 va_list ap;
572 va_start (ap, format);
573 vsnprintf (buf, len + 1, format, ap);
574 va_end (ap);
575
576 const std::string s (buf, len);
577 sfree<char> (buf, len + 1);
578
579 return buf; 629 return buf;
580 }
581} 630}
582 631
583tstamp now () 632tstamp now ()
584{ 633{
585 struct timeval tv; 634 struct timeval tv;
… …
653 0xcdd70693UL, 0x54de5729UL, 0x23d967bfUL, 0xb3667a2eUL, 0xc4614ab8UL, 702 0xcdd70693UL, 0x54de5729UL, 0x23d967bfUL, 0xb3667a2eUL, 0xc4614ab8UL,
654 0x5d681b02UL, 0x2a6f2b94UL, 0xb40bbe37UL, 0xc30c8ea1UL, 0x5a05df1bUL, 703 0x5d681b02UL, 0x2a6f2b94UL, 0xb40bbe37UL, 0xc30c8ea1UL, 0x5a05df1bUL,
655 0x2d02ef8dL 704 0x2d02ef8dL
656}; 705};
657 706
707void thread::start (void *(*start_routine)(void *), void *arg)
708{
709 pthread_attr_t attr;
658 710
711 pthread_attr_init (&attr);
712 pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED);
713 pthread_attr_setstacksize (&attr, PTHREAD_STACK_MIN < sizeof (long) * 4096
714 ? sizeof (long) * 4096 : PTHREAD_STACK_MIN);
715#ifdef PTHREAD_SCOPE_PROCESS
716 pthread_attr_setscope (&attr, PTHREAD_SCOPE_PROCESS);
717#endif
718
719 sigset_t fullsigset, oldsigset;
720 sigfillset (&fullsigset);
721
722 pthread_sigmask (SIG_SETMASK, &fullsigset, &oldsigset);
723
724 if (pthread_create (&id, &attr, start_routine, arg))
725 cleanup ("unable to create a new thread");
726
727 pthread_sigmask (SIG_SETMASK, &oldsigset, 0);
728}
729

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines