ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/Jeweler.pm
(Generate patch)

Comparing deliantra/server/ext/Jeweler.pm (file contents):
Revision 1.16 by root, Mon Jun 4 12:19:08 2007 UTC vs.
Revision 1.38 by elmex, Mon Oct 25 09:08:31 2010 UTC

… …
8 8
9=cut 9=cut
10 10
11package Jeweler; 11package Jeweler;
12 12
13use strict; 13use common::sense;
14use YAML;
15 14
16=over 4 15=over 4
17 16
18=item @RESISTS 17=item @RESISTS
19 18
… …
21 20
22=cut 21=cut
23 22
24our $CFG; 23our $CFG;
25 24
26sub read_config { 25sub load_config {
27 my ($filename) = @_; 26 cf::trace "loading jeweler config from $cf::DATADIR/jeweler\n";
28 27
29 unless (-e $filename) { 28 0 < Coro::AIO::aio_load "$cf::DATADIR/jeweler", my $data
30 warn "$filename doesn't exists! no config for jeweler skill loaded!\n"; 29 or die "$cf::DATADIR/jeweler: $!";
31 $CFG = {};
32 return
33 }
34 30
35 $CFG = YAML::LoadFile $filename; 31 $CFG = cf::decode_json $data;
36} 32}
37 33
38sub getcfg { 34sub getcfg {
39 my ($sect, $key) = @_; 35 my ($sect, $key) = @_;
40 return $CFG->{$sect} unless defined $key; 36 return $CFG->{$sect} unless defined $key;
… …
162 $delta = 5 if $delta > 5; 158 $delta = 5 if $delta > 5;
163 return $LVL_DIFF_CHANCES{$delta} 159 return $LVL_DIFF_CHANCES{$delta}
164} 160}
165 161
166sub analyze { 162sub analyze {
167 my ($sk, $chdl, $pl) = @_; 163 my ($sk, $chdl, $pl, $input_level) = @_;
168 164
169 my $hadunid = 0; 165 my $hadunid = 0;
166 my $found = 0;
170 for ($chdl->grep_by_type (cf::RING, cf::AMULET)) { 167 for ($chdl->grep_by_type (cf::RING, cf::AMULET)) {
171 if (!$_->flag (cf::FLAG_IDENTIFIED) && $_->need_identify) { 168 if (!$_->flag (cf::FLAG_IDENTIFIED) && $_->need_identify) {
172 $hadunid = 1; 169 $hadunid = 1;
173 next; 170 next;
174 } 171 }
172 $found = 1;
175 my $r = Jeweler::Object->new (object => $_); 173 my $r = Jeweler::Object->new (object => $_);
176 my $msg = $r->analyze ($sk, $pl); 174 my $msg = $r->analyze ($sk, $pl, $input_level);
177 $pl->message ($r->to_string . ": " . $msg); 175 $pl->message ("There is a '" . $r->to_string . "' in the workbench. Your analysis: " . $msg);
178 if ($pl->flag (cf::FLAG_WIZ)) { 176 if ($pl->flag (cf::FLAG_WIZ)) {
179 $r->wiz_analyze ($pl); 177 $r->wiz_analyze ($pl);
180 } 178 }
181 } 179 }
182 if ($hadunid) {
183 $pl->message ("You couldn't identify the other rings and not analyze them!"); 180 $pl->message ("You couldn't identify the other rings and not analyze them!")
184 } 181 if $hadunid;
182 $pl->message ("You couldn't find anything in the bench to analyse!")
183 unless $found;
185} 184}
186 185
187# this function converts metals/minerals into a raw ring (of adornment) 186# this function converts metals/minerals into a raw ring (of adornment)
188sub simple_converter { 187sub simple_converter {
189 my ($pl, $ingred, $chdl, $conv) = @_; 188 my ($pl, $ingred, $chdl, $conv, $sk_lvl, $low_skill_cb) = @_;
190 189
191 $conv = lc $conv; 190 $conv = lc $conv;
192 my $cnvs = $CFG->{conversions}; 191 my $cnvs = $CFG->{conversions};
193 192
194 return unless $cnvs->{$conv}; 193 return unless $cnvs->{$conv};
… …
203 warn "ERROR: Conversion for '$outarch' has only " . (@conv_cfg) . " arguments!"; 202 warn "ERROR: Conversion for '$outarch' has only " . (@conv_cfg) . " arguments!";
204 return; 203 return;
205 } 204 }
206 205
207 unless ($xp_gain > 0) { 206 unless ($xp_gain > 0) {
208 warn "WARNING: xp gain isn't > 0 in convesion '$outarch'\n"; 207 warn "WARNING: xp gain isn't > 0 in conversion '$outarch'\n";
209 return; 208 return;
210 } 209 }
211 210
212 unless ($outarchvalfact) { 211 unless ($outarchvalfact) {
213 warn "ERROR: source-arch-value-multiplier == 0 in conversion '$outarch'\n"; 212 warn "ERROR: source-arch-value-multiplier == 0 in conversion '$outarch'\n";
… …
216 215
217 unless ($outarchvalfact >= 1) { 216 unless ($outarchvalfact >= 1) {
218 warn "WARNING: source-arch-value-multiplier < 1 in conversion '$outarch', results in more valuable output!\n"; 217 warn "WARNING: source-arch-value-multiplier < 1 in conversion '$outarch', results in more valuable output!\n";
219 } 218 }
220 219
221 my $archvalsum = $ingred->value ($ingr_grp, $srcarchname); 220 my $archvalsum = $ingred->value ($ingr_grp, $srcarchname);
222 $ingred->remove ($ingr_grp, $srcarchname);
223
224 my $outarchval = cf::arch::find ($outarch)->value; 221 my $outarchval = cf::arch::find ($outarch)->value;
225
226 my $nrof = int ($archvalsum / (($outarchval || 1000) * $outarchvalfact)); 222 my $nrof = int $archvalsum / (($outarchval || 1000) * $outarchvalfact);
223 my $can_make_nr = int (($sk_lvl / 2) + 10);
224
225 if ($nrof > $can_make_nr) {
226 $pl->ob->message ("Your jeweler level is too low to make $nrof rings, you can only make $can_make_nr at your current level.");
227 return;
228 }
229
227 if ($nrof) { 230 if ($nrof) {
228 # XXX: yes, i know what i'm doing here, i don't set nrof, but it didn't work somehow (pls. chek sometimes) 231 # XXX: yes, I know what I'm doing here, I don't set nrof, but it didn't work somehow (pls. check sometimes)
232 $ingred->remove ($ingr_grp, $srcarchname);
229 for (1..$nrof) { 233 for (1 .. $nrof) {
230 $chdl->put (my $ob = cf::object::new $outarch); 234 $chdl->put (my $ob = cf::object::new $outarch);
231 $ob->set_animation (cf::rndm $ob->num_animations) 235 $ob->set_animation (cf::rndm $ob->num_animations)
232 if ($ob->type == cf::RING); 236 if ($ob->type == cf::RING);
233 $ob->flag (cf::FLAG_IDENTIFIED, 1); 237 $ob->flag (cf::FLAG_IDENTIFIED, 1);
234 } 238 }
235 239
236 my $xp_sum = ($xp_gain * $nrof); 240 my $xp_sum = $xp_gain * $nrof;
237 241
238 if ($xp_sum) { 242 if ($xp_sum) {
239 $pl->ob->message ("You got $xp_sum xp by making $nrof ${outarch}s"); 243 $pl->ob->message ("You got $xp_sum xp by making $nrof ${outarch}s");
240 $pl->ob->change_exp ($xp_sum, "jeweler", cf::SK_EXP_SKILL_ONLY); 244 $pl->ob->change_exp ($xp_sum, "jeweler", cf::SK_EXP_SKILL_ONLY);
241 } 245 }
… …
245} 249}
246 250
247 251
248package Jeweler::CauldronHandler; 252package Jeweler::CauldronHandler;
249 253
250use strict; 254use common::sense;
251 255
252=head2 CauldronHandler 256=head2 CauldronHandler
253 257
254The Jeweler::CauldronHandler package, that helps you with handling the 258The Jeweler::CauldronHandler package, that helps you with handling the
255cauldron stuff. Can also be used for other skills. 259cauldron stuff. Can also be used for other skills.
… …
280 my ($self, $arch_name, @map_stack) = @_; 284 my ($self, $arch_name, @map_stack) = @_;
281 285
282 my @c = 286 my @c =
283 grep { 287 grep {
284 $_->flag (cf::FLAG_IS_CAULDRON) 288 $_->flag (cf::FLAG_IS_CAULDRON)
285 and $_->arch->name eq $arch_name 289 and $_->arch->archname eq $arch_name
286 } @map_stack; 290 } @map_stack;
287 291
288 $self->{cauldron} = $c[0]; 292 $self->{cauldron} = $c[0];
289} 293}
290 294
… …
355 359
356sub put { 360sub put {
357 my ($self, $obj) = @_; 361 my ($self, $obj) = @_;
358 362
359 return undef unless $self->{cauldron}; 363 return undef unless $self->{cauldron};
360 $obj->insert_ob_in_ob ($self->{cauldron}); 364 $self->{cauldron}->insert ($obj);
361} 365}
362 366
363=back 367=back
364 368
365=cut 369=cut
366 370
367package Jeweler::Ingredients; 371package Jeweler::Ingredients;
372
373use common::sense;
374
368use Storable qw/dclone/; 375use Storable qw/dclone/;
369use strict;
370 376
371=head2 Ingredients 377=head2 Ingredients
372 378
373This class handles the ingredients. 379This class handles the ingredients.
374 380
… …
398 404
399sub value { 405sub value {
400 my ($self, $group, $archname) = @_; 406 my ($self, $group, $archname) = @_;
401 407
402 my @objs = grep { 408 my @objs = grep {
403 $_->arch->name eq $archname 409 $_->arch->archname eq $archname
404 } @{$self->{ingredients}->{$group} || []}; 410 } @{$self->{ingredients}->{$group} || []};
405 411
406 my $sum = 0; 412 my $sum = 0;
407 for (@objs) { 413 for (@objs) {
408 $sum += ($_->nrof || 1) * $_->value; 414 $sum += ($_->nrof || 1) * $_->value;
… …
425 431
426 my @out; 432 my @out;
427 433
428 for (@{$ingred->{$group}}) { 434 for (@{$ingred->{$group}}) {
429 if (defined $archname) { 435 if (defined $archname) {
430 if ($_->arch->name eq $archname) { 436 if ($_->arch->archname eq $archname) {
431 Jeweler::Util::remove ($_); 437 Jeweler::Util::remove ($_);
432 } else { 438 } else {
433 push @out, $_; 439 push @out, $_;
434 } 440 }
435 } else { 441 } else {
… …
477} 483}
478 484
479sub improve_ring_by_plan { 485sub improve_ring_by_plan {
480 my ($self, $plan, $ring) = @_; 486 my ($self, $plan, $ring) = @_;
481 487
482 $ring = dclone ($ring); 488 $ring = dclone $ring;
483 489
484 my $ingred = $self->{ingredients}; 490 my $ingred = $self->{ingredients};
485 my $impr = {}; 491 my $impr = {};
486 492
487 if ($plan =~ m/^stat_(\S+)$/) { 493 if ($plan =~ m/^stat_(\S+)$/) {
… …
571} 577}
572 578
573sub check_costs { 579sub check_costs {
574 my ($self, $costs, $do_remove) = @_; 580 my ($self, $costs, $do_remove) = @_;
575 581
576 my $costs = dclone ($costs); 582 my $costs = dclone $costs;
577 583
578 for my $key (keys %$costs) { 584 for my $key (keys %$costs) {
579 my @grepar; 585 my @grepar;
580 if ($key =~ m/^(resist_|spec_|stat_)/) { # check the special items 586 if ($key =~ m/^(resist_|spec_|stat_)/) { # check the special items
581 eval { @grepar = @{Jeweler::getcfg (plans => $key) || []} }; 587 eval { @grepar = @{Jeweler::getcfg (plans => $key) || []} };
… …
584 @grepar = ('gems', undef, undef, $key); 590 @grepar = ('gems', undef, undef, $key);
585 } 591 }
586 592
587 if ($do_remove) { 593 if ($do_remove) {
588 my $rem = $costs->{$key}; 594 my $rem = $costs->{$key};
589 $self->do_grep (sub { if ($rem) { $rem = Jeweler::Util::remove ($_[0], $rem); } 1 }, @grepar); 595 $self->do_grep (sub {
596 if ($rem) {
597 $rem = Jeweler::Util::remove ($_[0], $rem);
598 }
599 1
600 }, @grepar);
590 if ($rem > 0) { 601 if ($rem > 0) {
591 warn "JEWELER BUG: removed ingredients $rem > 0 after removing!"; 602 warn "JEWELER BUG: removed ingredients ($key) $rem > 0 after removing!";
592 } 603 }
604
593 } else { 605 } else {
594 my $nr; 606 my $nr;
595 $self->do_grep (sub { $nr += ($_[0]->nrof || 1); 0 }, @grepar); 607 $self->do_grep (sub { $nr += ($_[0]->nrof || 1); 0 }, @grepar);
596 $costs->{$key} -= $nr; 608 $costs->{$key} -= $nr;
597 } 609 }
… …
616 } 628 }
617 } 629 }
618} 630}
619 631
620package Jeweler::Object; 632package Jeweler::Object;
621use strict; 633
634use common::sense;
622use POSIX; 635use POSIX;
623use List::Util qw/max min sum/; 636use List::Util qw/max min sum/;
624 637
625sub new { 638sub new {
626 my ($class, %arg) = @_; 639 my ($class, %arg) = @_;
… …
641 return 1 if $self->{hash}->{resist}->{$resnum}; 654 return 1 if $self->{hash}->{resist}->{$resnum};
642 } 655 }
643 return undef; 656 return undef;
644} 657}
645 658
659sub lvl2exp {
660 my $lvl = shift;
661 (cf::level_to_min_exp ($lvl) - cf::level_to_min_exp ($lvl - 1))
662 / (20 + max ($lvl - 1, 0)) # 20 + level times making such a ring
663 # should get you to the rings level at least.
664}
665
666sub projected_exp {
667 my ($self, $input_level) = @_;
668
669 my $lvl = max ($self->power_to_level, 1);
670 my $exp = lvl2exp ($lvl);
671
672 if (defined $input_level) { # in case we merge rings:
673 my $subexp = lvl2exp ($input_level);
674 $exp -= $subexp;
675 $exp = max ($exp, 0);
676
677 } else {
678 # the experience bonus here is to make level 1 rings give you at least
679 # 200 exp points when making them. This also makes leveling in the
680 # first few levels a bit easier. (probably until around level 5-6).
681 my $expbonus = cf::level_to_min_exp (2) / 5;
682 # this bonus should also only be given for _new_ rings and not for merged
683 # ones - to prevent infinite exp making.
684 $exp += $expbonus;
685 }
686
687 $exp
688}
689
646sub analyze { 690sub analyze {
647 my ($self, $sk, $pl) = @_; 691 my ($self, $sk, $pl, $input_level) = @_;
692 my $costs = $self->calc_costs;
693
694 unless (defined $costs) {
695 return "This ring has a resistancy above 99%, you can't make that.";
696 }
648 697
649 my $sklvl = cf::exp_to_level ($sk->stats->exp); 698 my $sklvl = cf::exp_to_level ($sk->stats->exp);
650 my $ringlvl = $self->power_to_level; 699 my $ringlvl = $self->power_to_level;
651 700
652 my $tmpl; 701 my $tmpl;
653 if ($pl->flag (cf::FLAG_WIZ)) { 702 if ($pl->flag (cf::FLAG_WIZ)) {
654 $tmpl = Jeweler::level_diff_to_chance_perc ($sklvl - $ringlvl); 703 $tmpl = Jeweler::level_diff_to_chance_perc ($sklvl - $ringlvl);
655 } else { 704 } else {
656 $tmpl = Jeweler::level_diff_to_str ($sklvl - $ringlvl); 705 $tmpl = Jeweler::level_diff_to_str ($sklvl - $ringlvl);
657 } 706 }
658 my $msg = sprintf "Projected success rate: %s", $tmpl; 707 my $msg = sprintf "Projected success rate: %s, you would get %d exp for this.", $tmpl, $self->projected_exp ($input_level);
659 return $msg; 708 return $msg;
660} 709}
661 710
662sub calc_value_from_cost { 711sub calc_value_from_cost {
663 my ($self, $costs) = @_; 712 my ($self, $costs) = @_;
… …
676} 725}
677 726
678sub wiz_analyze { 727sub wiz_analyze {
679 my ($self, $pl) = @_; 728 my ($self, $pl) = @_;
680 my $costs = $self->calc_costs; 729 my $costs = $self->calc_costs;
730 if (defined $costs) {
681 my $desc = ""; 731 my $desc = "";
682 my $lvl = $self->power_to_level (\$desc); 732 my $lvl = $self->power_to_level (\$desc);
683 my $scosts = $self->calc_value_from_cost ($costs); 733 my $scosts = $self->calc_value_from_cost ($costs);
684 734
685 $pl->message ("costs: " . (join (', ', map { "$_: " . sprintf "%.2f", $costs->{$_} } keys %$costs)) . " (".($scosts / 5000)." royalties)"); 735 $pl->message ("costs: "
736 . (join ', ', map { "$_: " . sprintf "%.2f", $costs->{$_} } keys %$costs)
737 . " ("
738 . ($scosts / "platinacoin"->cf::arch::find->value)
739 . " platinum)");
686 $pl->message ("level: " . $desc); 740 $pl->message ("level: $desc");
741 } else {
742 $pl->message ("level: impossible to make, due to impossible resistancy configuration");
743 }
687} 744}
688 745
689sub get_chance_perc { 746sub get_chance_perc {
690 my ($self, $sk) = @_; 747 my ($self, $sk) = @_;
691 my $sklvl = cf::exp_to_level ($sk->stats->exp); 748 my $sklvl = cf::exp_to_level ($sk->stats->exp);
… …
696sub fx { 753sub fx {
697 my ($res, $cfg) = @_; 754 my ($res, $cfg) = @_;
698 my $or = $res; 755 my $or = $res;
699 my $ar = $Jeweler::CFG->{functions}->{$cfg}; 756 my $ar = $Jeweler::CFG->{functions}->{$cfg};
700 757
701 if (ref $ar->[0] eq 'ARRAY') { 758 if (ref $ar && ref $ar->[0] eq 'ARRAY') {
702 $res = $res - 1; 759 $res = $res - 1;
703 return $ar->[max (min ($res, @$ar - 1), 0)]; 760 return $ar->[max (min ($res, @$ar - 1), 0)];
704 761
705 } else { 762 } else {
706 # +0.1 is for a jump to the next index when $res / 5 is exactly 1, 2, 3... 763 # +0.1 is for a jump to the next index when $res / 5 is exactly 1, 2, 3...
764 # old code:
707 my $idx = ceil (($res / 5) + 0.1) - 1; 765 #my $idx = ceil (($res / 5) + 0.1) - 1;
708 my $a = $ar->[max (min ($idx, @$ar - 1), 0)]; 766 #my $a = $ar->[max (min ($idx, @$ar - 1), 0)];
709 my $b = $ar->[max (min ($idx + 1, @$ar - 1), 0)]; 767 #my $b = $ar->[max (min ($idx + 1, @$ar - 1), 0)];
710 my $diff = $b - $a; # use the difference of the cost to the next cost 768 #my $diff = $b - $a; # use the difference of the cost to the next cost
711 my $o_cost = $a + ($diff / 5) * ($res % 5); # and do some linear interpolation 769 #my $o_cost = $a + ($diff / 5) * ($res % 5); # and do some linear interpolation
712 return $o_cost; 770 #return $o_cost;
771 return 0 if $res <= 0;
772 return ($ar / (1 - ($res * 0.01)) - $ar)
713 } 773 }
714} 774}
715 775
716sub improve_by_ring { 776sub improve_by_ring {
717 my ($self, @rings) = @_; 777 my ($self, @rings) = @_;
… …
783 $obj->{spec}{ac} = $stats->ac; 843 $obj->{spec}{ac} = $stats->ac;
784 $obj->{spec}{speed} = $stats->exp; 844 $obj->{spec}{speed} = $stats->exp;
785 $obj->{spec}{food} = $stats->food; 845 $obj->{spec}{food} = $stats->food;
786 846
787 $obj->{name} = $thing->name; 847 $obj->{name} = $thing->name;
788 $obj->{arch} = $thing->arch->name; 848 $obj->{arch} = $thing->arch->archname;
789 $obj->{face} = $thing->face; 849 $obj->{face} = $thing->face;
790 850
791 $obj->{value} = $thing->value; 851 $obj->{value} = $thing->value;
852
853 $obj->{is_ring} = ($thing->type == cf::RING);
792 854
793 $self->{hash} = $obj 855 $self->{hash} = $obj
794} 856}
795 857
796sub to_object { 858sub to_object {
797 my ($self) = @_; 859 my ($self) = @_;
798 860
799 my $obj = cf::object::new $self->{hash}->{arch}; 861 my $obj = cf::object::new $self->{hash}->{arch};
800 862
801 $obj->item_power (floor ($self->power_to_level / 3)); # there have to be strings attached! 863 $obj->item_power (floor ($self->power_to_level / 5)); # there have to be strings attached!
802 864
803 $obj->face ($self->{hash}{face}); 865 $obj->face ($self->{hash}{face});
804 866
805 my $stats = $obj->stats; 867 my $stats = $obj->stats;
806 868
… …
859sub resist_level { 921sub resist_level {
860 my ($self) = @_; 922 my ($self) = @_;
861 923
862 my $resists = $self->{hash}->{resist} || {}; 924 my $resists = $self->{hash}->{resist} || {};
863 925
864 my $att_res_lvl = Jeweler::getcfg (maxlevels => 'resist_level'); 926 my $att_res_lvl = Jeweler::getcfg (maxlevels => 'resist_level');
865 my $efc_res_lvl = Jeweler::getcfg (maxlevels => 'effect_resist_level'); 927 my $efc_res_lvl = Jeweler::getcfg (maxlevels => 'effect_resist_level');
866 my $max_att_res = Jeweler::getcfg (maximprovements => 'attack_resistances'); 928 my $max_att_res = Jeweler::getcfg (maximprovements => 'attack_resistances');
867 my $max_efc_res = Jeweler::getcfg (maximprovements => 'effect_resistances'); 929 my $max_efc_res = Jeweler::getcfg (maximprovements => 'effect_resistances');
868 my $max_ovr_res = Jeweler::getcfg (maximprovements => 'resistances'); 930 my $max_ovr_res = Jeweler::getcfg (maximprovements => 'resistances');
869 931
870 my $ressum = 0; 932 my $ressum = 0;
… …
930sub power_to_level { 992sub power_to_level {
931 my ($self, $lvldescr) = @_; 993 my ($self, $lvldescr) = @_;
932 994
933 my $max_imprs = Jeweler::getcfg (maximprovements => 'improvements'); 995 my $max_imprs = Jeweler::getcfg (maximprovements => 'improvements');
934 my $max_impr_lvl = Jeweler::getcfg (maxlevels => 'improve_level'); 996 my $max_impr_lvl = Jeweler::getcfg (maxlevels => 'improve_level');
997 my $ring_offs = Jeweler::getcfg (maxlevels => 'ring_offset');
935 998
936 my ($stat_lvl, $stat_imprs) = $self->stat_level; 999 my ($stat_lvl, $stat_imprs) = $self->stat_level;
937 my ($resist_lvl, $res_imprs) = $self->resist_level; 1000 my ($resist_lvl, $res_imprs) = $self->resist_level;
938 my ($spec_lvl, $spec_imprs) = $self->special_level; 1001 my ($spec_lvl, $spec_imprs) = $self->special_level;
939 1002
940 my $impr_sum = $stat_imprs + $res_imprs + $spec_imprs; 1003 my $impr_sum = $stat_imprs + $res_imprs + $spec_imprs;
941 1004
942 my $impr_lvl = ceil (($max_impr_lvl / ($max_imprs + 1)) * ($impr_sum - 1)); # 1 improvemnt bonus 1005 my $impr_lvl =
1006 ceil (($max_impr_lvl / ($max_imprs + 1))
1007 * ($impr_sum - 1)); # 1 improvemnt bonus
943 1008
944 my $levl = int max ($stat_lvl, $resist_lvl, $impr_lvl, $spec_lvl, 0); 1009 my $levl = int max ($stat_lvl, $resist_lvl, $impr_lvl, $spec_lvl, 0);
1010
1011 if ($self->{hash}->{is_ring}) {
1012 $levl += $ring_offs;
1013 }
1014
1015 $levl = min ($levl, cf::settings->max_level);
945 1016
946 if ($lvldescr) { 1017 if ($lvldescr) {
947 $$lvldescr = 1018 $$lvldescr =
948 sprintf "%3d: %s\n", $levl, 1019 sprintf "%3d: %s\n", $levl,
949 "stat: $stat_lvl, resist: $resist_lvl, improve: $impr_lvl, " 1020 "stat: $stat_lvl, resist: $resist_lvl, improve: $impr_lvl, "
… …
996 1067
997 my $res = $ring->{resist}->{$resnum}; 1068 my $res = $ring->{resist}->{$resnum};
998 1069
999 next unless $res > 0; 1070 next unless $res > 0;
1000 1071
1072 return undef if $res == 100;
1073
1001 $costs->{"resist_" . $Jeweler::RESMAP{$resnum}} += $res; 1074 $costs->{"resist_" . $Jeweler::RESMAP{$resnum}} += $res;
1002 1075
1003 my $diamonds; 1076 my $diamonds;
1004 if (grep { $resnum eq $_ } @Jeweler::EFFECT_RESISTS) { 1077 if (grep { $resnum eq $_ } @Jeweler::EFFECT_RESISTS) {
1005 $diamonds += fx ($res, 'effect_resist_diamonds'); 1078 $diamonds += fx ($res, 'effect_resist_diamonds_x');
1006 } else { 1079 } else {
1007 $diamonds += fx ($res, 'attack_resist_diamonds'); 1080 $diamonds += fx ($res, 'attack_resist_diamonds_x');
1008 } 1081 }
1009 1082
1010 split_diamonds ($costs, $diamonds, 'resist_' . $Jeweler::RESMAP{$resnum}); 1083 split_diamonds ($costs, $diamonds, 'resist_' . $Jeweler::RESMAP{$resnum});
1011 } 1084 }
1012 1085
… …
1020 my ($cost, $diamonds, $category) = @_; 1093 my ($cost, $diamonds, $category) = @_;
1021 1094
1022 my $stat_split = Jeweler::getcfg (diamond_split => $category); 1095 my $stat_split = Jeweler::getcfg (diamond_split => $category);
1023 1096
1024 my $sum = sum (@$stat_split); 1097 my $sum = sum (@$stat_split);
1025 if ($sum < (1 - 0.0001)) {
1026 warn "JEWELER BUG: sum (@$stat_split) = $sum < 1 for $category!";
1027 }
1028 1098
1029 my $emarch = cf::arch::find 'emerald'; 1099 my $emarch = cf::arch::find 'emerald';
1030 my $saarch = cf::arch::find 'sapphire'; 1100 my $saarch = cf::arch::find 'sapphire';
1031 my $pearch = cf::arch::find 'pearl'; 1101 my $pearch = cf::arch::find 'pearl';
1032 my $ruarch = cf::arch::find 'ruby'; 1102 my $ruarch = cf::arch::find 'ruby';
… …
1041 $cost->{gem} += ceil $sumvalue * $stat_split->[4] / max 1, $diarch->value; 1111 $cost->{gem} += ceil $sumvalue * $stat_split->[4] / max 1, $diarch->value;
1042} 1112}
1043 1113
1044package Jeweler::Util; 1114package Jeweler::Util;
1045 1115
1046use strict; 1116use common::sense;
1047 1117
1048=head2 Util 1118=head2 Util
1049 1119
1050Some utility functions for the Jeweler skill. 1120Some utility functions for the Jeweler skill.
1051 1121
1052=over 4 1122=over 4
1053 1123
1054=item remove ($object[, $nrof]) 1124=item remove ($object[, $nrof])
1055 1125
1056Removes the C<$object>. If C<$nrof> is given, remove only C<$nrof> objects. 1126Removes the C<$object>. If C<$nrof> is given, remove only C<$nrof> objects.
1057The returnvalue is the number of 'single' objects that couldn't be removed. 1127The return value is the number of 'single' objects that couldn't be removed.
1058 1128
1059=cut 1129=cut
1060 1130
1061sub remove { 1131sub remove {
1062 my ($obj, $nrof) = @_; 1132 my ($obj, $nrof) = @_;
1063 1133
1064 my $cnt; 1134 my $c = $obj->number_of;
1135 my $r = $c > $nrof ? 0 : $nrof - $c;
1136 $obj->decrease (defined ($nrof) ? $nrof : ($obj->nrof || 1));
1065 1137
1066 if (defined $nrof) { 1138 $r
1067 # TODO: Check tihis line:
1068 return 0 if ($nrof * 1) == 0; #XXX: ???
1069 $cnt = int (($obj->nrof || 1) - (1 * $nrof));
1070
1071 if ($cnt > 0) {
1072 $obj->nrof ($cnt);
1073 return 0;
1074 }
1075 }
1076
1077 remove ($_) for $obj->inv;
1078 $obj->destroy;
1079 return $cnt;
1080} 1139}
1081 1140
1082sub check_for_match { 1141sub check_for_match {
1083 my ($thing, @matchar) = @_; 1142 my ($thing, @matchar) = @_;
1084 1143
… …
1103 and $check_true++; 1162 and $check_true++;
1104 } elsif ($i % 3 == 1) { 1163 } elsif ($i % 3 == 1) {
1105 $thing->title eq $match 1164 $thing->title eq $match
1106 and $check_true++; 1165 and $check_true++;
1107 } else { # $i % 3 == 2 1166 } else { # $i % 3 == 2
1108 $thing->arch->name eq $match 1167 $thing->arch->archname eq $match
1109 and $check_true++; 1168 and $check_true++;
1110 } 1169 }
1111 $i++; 1170 $i++;
1112 } 1171 }
1113 #d# warn "CHECK $check_true | $check_cnts | [".(join ',', @matchar).":".join (",", ($thing->name, $thing->title, $thing->arch->name))."\n"; 1172 #d# warn "CHECK $check_true | $check_cnts | [".(join ',', @matchar).":".join (",", ($thing->name, $thing->title, $thing->arch->archname))."\n";
1114 return 1 if $check_true && $check_cnts == $check_true; 1173 return 1 if $check_true && $check_cnts == $check_true;
1115 return 0; 1174 return 0;
1116} 1175}
1117 1176
1118sub grep_for_match { 1177sub grep_for_match {
1119 my ($ingred, $group, @matchar) = @_; 1178 my ($ingred, $group, @matchar) = @_;
1120 1179
1121 for my $thing (@{$ingred->{$group} || []}) { 1180 for my $thing (@{$ingred->{$group} || []}) {
1122 #d# warn sprintf "DEB:(%s,%s,%s)<->%s\n", $thing->name, $thing->title, $thing->arch->name, "@matchar"; #d# 1181 #d# warn sprintf "DEB:(%s,%s,%s)<->%s\n", $thing->name, $thing->title, $thing->arch->archname, "@matchar"; #d#
1123 if (check_for_match ($thing, @matchar)) { 1182 if (check_for_match ($thing, @matchar)) {
1124 return $thing; 1183 return $thing;
1125 } 1184 }
1126 } 1185 }
1127 return undef; 1186 return undef;

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines