[ViewVC] Diff of: cvs/deliantra/server/ext/jeweler.ext

Comparing deliantra/server/ext/jeweler.ext (file contents):
Revision 1.9 by elmex, Tue Apr 10 17:46:22 2007 UTC vs.
Revision 1.26 by elmex, Sun May 30 19:49:40 2010 UTC

 #! perl
-use Data::Dumper;
+use strict;
 use Jeweler;
 use List::Util qw/max min sum/;
-use strict;
 sub ingred_alias {
    my ($ing) = @_;
    my %aliases = (
    my @ring = $ingred->get_ring;
    my @rings = map { Jeweler::Object->new (object => $_) } @ring;
    @rings >= 2
-      or return $pl->reply (undef, "You slap yourself, you forgot to put at least 2 jewels in!");
+      or return $pl->message ("You slap yourself, you forgot to put at least 2 jewels in!");
-   my $input_level;
+   my $input_level = 0;
    my $value;
    for (@rings) {
       $input_level = max ($_->power_to_level, $input_level);
       $value += $_->{hash}->{value};
    }
    my $ring = shift @rings;
    $ring->improve_by_ring (@rings);
    if ($do_analyze) {
-      $pl->reply (undef, "You want to make a " . $ring->to_string . ": " . $ring->analyze ($sk, $pl));
+      $pl->message ("You want to make a " . $ring->to_string . ": " . $ring->analyze ($sk, $pl, $input_level));
       $ring->wiz_analyze ($pl)
          if $pl->flag (cf::FLAG_WIZ);
       return;
    }
       $ingred->remove ('ammys');
    }
    my $ch = $ring->get_chance_perc ($sk);
    my $succ = 0;
-   my $r = cf::random_roll (0, 100, $pl, cf::PREFER_HIGH);
+   my $r = cf::random_roll (0, 100, $pl, cf::PREFER_LOW);
    my $make_status;
    my $exp;
    if ($r <= $ch or $pl->flag (cf::FLAG_WIZ)) {
-      my $lvl = max ($ring->power_to_level, 1);
+      $exp = $ring->projected_exp ($input_level);
-      $exp =
-         (cf::level_to_min_exp ($lvl) - cf::level_to_min_exp ($lvl - 1))
-            / (10 + max ($lvl - 1, 0)); # 10 + level times making such a ring
-                                        # should get you to the rings level at least.
-      if (defined $input_level) {
-         my $subexp =
-            (cf::level_to_min_exp ($input_level)
-               - cf::level_to_min_exp ($input_level - 1))
-                  / (10 + max ($input_level - 1, 0)); # see above for comment
-         $exp -= $subexp;
-         $exp = max ($exp, 0);
-      } else {
-         # the experience bonus here is to make level 1 rings give you at least
-         # 100 exp points when making them. This also makes leveling in the
-         # first few levels a bit easier. (Propably until around level 5-6).
-         my $expbonus = cf::level_to_min_exp (2) / 10;
-         # this bonus should also only be given for _new_ rings and not for merged
-         # ones - to prevent infinite exp making.
-         $exp += $expbonus;
-      }
       $pl->change_exp ($exp, "jeweler", cf::SK_EXP_SKILL_ONLY);
+      $pl->message (
-      $pl->message ("You succeed and get $exp experience points.");
+         "You succeed and get " . int ($exp) . " experience points.");
       $make_status = "succeeded";
-      $ring->set_value ($value * 0.8); # 20% of the input values will vanish
+      $ring->set_value ($value);
    } else {
       $pl->message ("You fail!");
       $ring->negate;
       $make_status = "fail";
       $exp = 0;
    }
    my $ring_ob = $ring->to_object;
+   $ring_ob->kv_set (ext_jeweler_maker => $pl->name);
    { # some audit info calculation
       my $sklvl = cf::exp_to_level ($sk->stats->exp);
       my $make_info = sprintf
          "JEWELER AUDIT: '%s' made '%s' (%s) (sk lvl %d, ring lvl %d, got %d exp): %s",
             $pl->name, $ring->to_string, $ring_ob->uuid, $sklvl,
             $ring->power_to_level, $exp, $make_status;
+      cf::debug "$make_info\n"
-      warn "$make_info\n" if $make_status eq 'succeeded';
+         if $make_status eq 'succeeded';
-      $ring_ob->set_ob_key_value (ext_jeweler_made_by   => $pl->name);
-      $ring_ob->set_ob_key_value (ext_jeweler_make_info => $make_info);
    }
    $chdl->put ($ring_ob);
 }
       return
    } elsif ($@ =~ /unidentified/) {
       $pl->message ("There are unidentified items in the workbench, identify them before you do anything.").
       return
    } elsif ($@) {
-      warn "error in jeweler ingredient extraction: $@";
+      cf::error "error in jeweler ingredient extraction: $@";
       return;
    }
    $ingred;
 }
                if ($ringo->has_resist ($1)) {
                   $self->map->trigger (
                      $cfg->{connection},
                      $cfg->{state}
                   );
+                  $obj->decrease (1);
                   cf::override;
                }
             }
          }
       }
             unless ($Jeweler::CFG->{conversions}->{lc $1}) {
                $pl->message ("You don't know how to make '$1', is does such a thing even exist?");
                return
             }
-            Jeweler::simple_converter ($player, $ingred, $chdl, $1);
+            Jeweler::simple_converter (
+               $player, $ingred, $chdl, $1,
+               cf::exp_to_level ($sk->stats->exp));
          } elsif ($msg =~ m/^\s*merge\s*analy[sz]e\s*$/i) {
             merge ($chdl, $sk, $pl, 1);
          } elsif ($msg =~ m/^\s*merge\s*$/i) {
             my $plan   = $ingred->get_plan;
             if ($plan) {
                my @ring = $ingred->get_ring;
+               if (!@ring) {
+                  # actually the algorithm cant
+                  $pl->message ("You slap yourself, you forgot the jewelery!");
+                  return;
-               if ((@ring > 1) || ($ring[0]->nrof > 1)) {
+               } elsif ((@ring > 1) || (grep { $_->nrof > 1 } @ring)) {
                   # actually the algorithm cant handle more than one improvement at a time
                   $pl->message ("You can't manage to improve more than one thing at a time!");
                   return;
-               } elsif (@ring < 1) {
-                  # actually the algorithm cant
-                  $pl->message ("You slap yourself, you forgot the jewelery!");
-                  return;
                } else {
                   my $ringo = Jeweler::Object->new (object => $ring[0]);
                   my $iring = $ingred->improve_ring_by_plan ($plan, $ringo);
                   my $c1    = $ringo->calc_costs;
                   my $c2    = $iring->calc_costs;
                   my $value = $iring->calc_value_from_cost ($c2);
+                  if ((not defined $c1) || (not defined $c2)) {
+                     $pl->message ("The jewel has or will become a resistancy above 99%,\n"
+                                  ."that is completly impossible to make!");
+                     return;
+                  }
                   my %keys;
                   my %cdiff;
                   for (keys %$c1, keys %$c2) { $keys{$_} = 1 }
                   for (keys %keys) { $cdiff{$_} = $c2->{$_} - $c1->{$_}; }
             } else {
                $pl->message ("You've got no idea what you are planning to do!");
             }
          }
       };
-      $@ and warn "ERROR: $@\n";
+      $@ and cf::error "$@\n";
    }
 );
-Jeweler::read_config (cf::datadir . '/jeweler.yaml');
+Jeweler::load_config;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/ext/jeweler.ext (file contents): Revision 1.9 by elmex, Tue Apr 10 17:46:22 2007 UTC vs. Revision 1.26 by elmex, Sun May 30 19:49:40 2010 UTC

Diff Legend

Comparing deliantra/server/ext/jeweler.ext (file contents):
Revision 1.9 by elmex, Tue Apr 10 17:46:22 2007 UTC vs.
Revision 1.26 by elmex, Sun May 30 19:49:40 2010 UTC