--- deliantra/server/ext/login.ext 2007/01/08 12:39:16 1.16 +++ deliantra/server/ext/login.ext 2007/01/08 14:11:05 1.17 @@ -343,8 +343,7 @@ ############################################################################# our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs -our $SWAP_TIMEOUT = 30; # time after which an unused player is evicted form memory -our $SAVE_TIMEOUT = 20; # save players every n seconds +our $SAVE_TIMEOUT = 200; # save players every n seconds our $SAVE_INTERVAL = 0.1; # save at max. one player every $SAVE_INTERVAL our $SCHEDULER = cf::async_ext { @@ -366,14 +365,28 @@ $pl->save; Coro::Timer::sleep $SAVE_INTERVAL; } - my $ob = $pl->ob; - Scalar::Util::weaken $pl; # 2 == from object + from perl - Scalar::Util::weaken $ob; # 2 == one from being an object + ??? - my $a_ = $pl->refcnt; - my $b_ = $ob->refcnt; - my $a = $pl->refcnt_cnt; - my $b = $ob->refcnt_cnt; - warn "rc $a,$a_ $b,$b_\n";#d# + + unless ($pl->active) { + # check refcounts, this is tricky and needs to be adjusted to fit server internals + my $ob = $pl->ob; + Scalar::Util::weaken $pl; + Scalar::Util::weaken $ob; + my $a_ = $pl->refcnt; + my $b_ = $ob->refcnt; + my $pl_ref = $pl->refcnt_cnt; + my $ob_ref = $ob->refcnt_cnt; + + if ($pl_ref == 2 && $ob_ref == 1) { + warn "player-scheduler destroy ", $ob->name;#d# + delete $cf::PLAYER{$ob->name}; + # pl_ref == one from object + one from cf::PLAYER + # ob_ref == one from simply being an object + $ob->destroy; + $pl->destroy; + } else { + warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d# + } + } }; warn $@ if $@; Coro::cede;