ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.60 by root, Thu Jul 5 20:52:22 2007 UTC vs.
Revision 1.107 by root, Thu Apr 29 07:52:02 2010 UTC

1#! perl # mandatory 1#! perl # mandatory depends=highscore
2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7
8our $MAX_DISCONNECT_TIME = $cf::CFG{max_disconnect_time} || 3600;
7 9
8# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
9sub nuke_str { 11sub nuke_str {
10 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
11} 13}
12 14
13sub query { 15sub query {
14 my ($ns, $flags, $text) = @_; 16 my ($ns, $flags, $text) = @_;
15 17
16 my $current = $Coro::current; 18 $ns->query ($flags, $text, Coro::rouse_cb);
17 $ns->query ($flags, $text, sub { $current->ready; $current = $_[0] }); 19 Coro::rouse_wait
18 Coro::schedule while ref $current;
19
20 $current
21} 20}
22 21
23sub can_cleanup { 22sub can_cleanup {
24 my ($pl, $mtime) = @_; 23 my ($pl, $mtime) = @_;
25 24
… …
50 ); 49 );
51 50
52 1 51 1
53} 52}
54 53
54sub safe_spot($) {
55 my ($pl) = @_;
56
57 my $ob = $pl->ob;
58
59 my $m = $ob->map
60 or return;
61 my $x = $ob->x;
62 my $y = $ob->y;
63
64# return 0;#d#
65# warn join ":", $m->at ($x, $y);#d#
66# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
67# return 0;
68
69 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
70}
71
55sub enter_map { 72sub enter_map {
56 my ($pl) = @_; 73 my ($pl) = @_;
57 74
75 my $ob = $pl->ob;
76
58 my ($map, $x, $y) 77 my ($map, $x, $y)
59 = $pl->ob->{_link_pos} 78 = $ob->{_link_pos}
60 ? @{delete $pl->ob->{_link_pos}} 79 ? @{delete $ob->{_link_pos}}
61 : ($pl->maplevel, $pl->ob->x, $pl->ob->y); 80 : ($pl->maplevel, $ob->x, $ob->y);
62 81
63 $pl->ob->enter_link; 82 $ob->enter_link;
64 83
84 my $m = cf::map::find $map;
65 if (my $time = delete $pl->{unclean_save}) { 85 my $time = delete $pl->{unclean_save};
66 if (my $m = cf::map::find $map) { 86
87 if ($time && $m) {
67 if ($time < $m->{instantiate_time}) { 88 if ($time < $m->{instantiate_time}) {
68 # the map was reset in the meantime 89 # the map was reset in the meantime
69 my $age = $cf::RUNTIME - $time; 90 my $age = $cf::RUNTIME - $time;
91
70 warn $pl->ob->name, " map reset after logout, logout age $age\n";#d# 92 cf::info $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
71 93
72 # for now, just go back to savebed 94 if ($age >= $MAX_DISCONNECT_TIME) {
95 $ob->message (
96 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
97 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
98 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
99 . "H<You disconnected too long without having used a savebed.>",
100 cf::NDI_RED
101 );
102 # kill them.
103 # reminds me of the famous badness 10000 syndrome...
104 $ob->stats->hp (-10000); #] if they survive this they deserved to live
105 my $killer = cf::arch::get "killer_login"; $pl->killer ($killer); $killer->destroy;
106 } else {
73 ($map, $x, $y) = $pl->savebed; 107 ($map, $x, $y) = $pl->savebed;
74 108
75 $pl->ns->send_drawinfo ( 109 $ob->message (
76 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. " 110 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
77 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. " 111 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
78 . "Better use a savebed next time, much worse things could have happened...", 112 . "Better use a savebed next time, much worse things could have happened... "
113 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
79 cf::NDI_RED 114 cf::NDI_RED
80 ); 115 );
116 }
81 } else { 117 } else {
82 $pl->ns->send_drawinfo ( 118 $ob->message (
83 "You didn't use a bed to reality to leave this realm. This is very dangerous, " 119 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
84 . "as lots of things could happen when you leave by other means, such as cave-ins, " 120 . "as lots of things could happen when you leave by other means, such as cave-ins, "
85 . "or monsters suddenly snapping your body. Better use a savebed next time.", 121 . "or monsters suddenly snapping your body. Better use a savebed next time. "
122 . "H<Always apply a bed of reality to disconnect from the server.>",
86 cf::NDI_RED 123 cf::NDI_RED
87 ); 124 );
88 }
89 } 125 }
90 } 126 }
91 127
92 $pl->ob->goto ($map, $x, $y); 128 $ob->goto ($map, $x, $y);
129}
130
131sub encode_password {
132 crypt $_[0],
133 join '',
134 ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64), (cf::rndm 64)]
93} 135}
94 136
95# delete a player directory, be non-blocking AND synchronous... 137# delete a player directory, be non-blocking AND synchronous...
96# (thats hard, so we crap out and fork). 138# (that's hard, so we crap out and fork).
97sub nuke_playerdir { 139sub nuke_playerdir {
98 my ($user) = @_; 140 my ($user) = @_;
99 141
100 aio_stat "$PLAYERDIR/$user"; 142 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
101 system "cd \Q$PLAYERDIR\E " 143
102 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null " 144 cf::fork_call {
103 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)"; 145 rename "$PLAYERDIR/$user", $temp;
146 system "rm", "-rf", $temp;
147 };
104} 148}
105 149
106cf::client->attach (on_addme => sub { 150cf::client->attach (on_addme => sub {
107 my ($ns) = @_; 151 my ($ns) = @_;
108 152
109 if (!$ns->facecache)
110 {
111 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
112
113
114***
115*** WARNING:
116*** Your client does not support face/image caching,
117*** or it has been disabled. Face caching is mandatory
118*** so please enable it or use a newer client.
119***
120*** Look at your client preferences:
121***
122*** CFPlus: all known versions automatically enable the facecache.
123*** cfclient: use the -cache commandline option.
124*** cfclient: map will not redraw automatically (bug).
125*** gcfclient: use -cache commandline option, or enable
126*** gcfclient: Client=>Configure=>Map & Image=>Cache Images.
127*** jcrossclient: your client is broken, use CFPlus or gcfclient.
128***
129***
130EOF
131 if ($ns->version =~ /jcrossclient/) {
132 # let them, for now
133 } else {
134 $ns->flush;
135 return $ns->destroy;
136 }
137
138 # $ns->facecache = true;
139 }
140
141 if ($ns->mapmode < cf::Map1aCmd) {
142 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
143
144
145***
146*** WARNING:
147*** Your client is too old. Please upgrade to a newer version.
148EOF
149
150 $ns->flush;
151 return $ns->destroy;
152 }
153
154 $ns->pl and return $ns->destroy; 153 $ns->pl and return $ns->destroy;
155 154
156 $ns->async (sub { 155 $ns->async (sub {
156 $Coro::current->{desc} = "addme init";
157
157 my ($user, $pass); 158 my ($user, $pass);
158 159
159 $ns->send_packet ("addme_success"); 160 $ns->send_packet ("addme_success");
160 161
161 for (;;) { 162 for (;;) {
… …
166 cf::NDI_BLUE 167 cf::NDI_BLUE
167 ); 168 );
168 169
169 # read username 170 # read username
170 while () { 171 while () {
171 $user = query $ns, 0, "What is your name?\n:"; 172 $user = query $ns, 0, "What is your name? (login names are case-sensitive)\n:";
172 173
173 if ($cf::LOGIN_LOCK{$user}) { 174 if ($cf::LOGIN_LOCK{$user}) {
174 $ns->send_drawinfo ( 175 $ns->send_drawinfo (
175 "That username is currently used in another login session. " 176 "That username is currently used in another login session. "
176 . "Chose another, or wait till the other session has ended.", 177 . "Chose another, or wait till the other session has ended.",
177 cf::NDI_RED 178 cf::NDI_RED
178 ); 179 );
179 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}\z/) { 180 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,19}\z/) {
180 last; 181 last;
181 } else { 182 } else {
182 $ns->send_drawinfo ( 183 $ns->send_drawinfo (
183 "Your username contains illegal characters " 184 "Your username contains illegal characters "
184 . "(only a-z, A-Z and 0-9 are allowed), " 185 . "(only a-z, A-Z and 0-9 are allowed), "
185 . "or is not between 3 and 18 characters in length.", 186 . "or is not between 3 and 20 characters in length.",
186 cf::NDI_RED 187 cf::NDI_RED
187 ); 188 );
188 } 189 }
190 Coro::Timer::sleep 0.4;
189 } 191 }
190 192
191 check_playing $ns, $user and next; 193 check_playing $ns, $user and next;
194
195 $Coro::current->{desc} = "addme($user) pass";
192 196
193 $ns->send_drawinfo ( 197 $ns->send_drawinfo (
194 "Welcome $user, please enter your password now. " 198 "Welcome $user, please enter your password now. "
195 . "New users should now choose a password. " 199 . "New users should now choose a password. "
196 . "Anything your client lets you enter is fine.", 200 . "Anything your client lets you enter is fine.",
… …
204 $ns->send_drawinfo ( 208 $ns->send_drawinfo (
205 "Try to use at least three characters as your password please, " 209 "Try to use at least three characters as your password please, "
206 . "that cannot be too much to ask for :)", 210 . "that cannot be too much to ask for :)",
207 cf::NDI_RED 211 cf::NDI_RED
208 ); 212 );
213 Coro::Timer::sleep 0.4;
209 } 214 }
210 215
211 # lock this username for the remainder of this login session 216 # lock this username for the remainder of this login session
212 if ($cf::LOGIN_LOCK{$user}) { 217 if ($cf::LOGIN_LOCK{$user}) {
213 $ns->send_drawinfo ( 218 $ns->send_drawinfo (
… …
218 next; 223 next;
219 } 224 }
220 local $cf::LOGIN_LOCK{$user} = 1; 225 local $cf::LOGIN_LOCK{$user} = 1;
221 226
222 check_playing $ns, $user and next; 227 check_playing $ns, $user and next;
228
229 $Coro::current->{desc} = "addme($user) check";
223 230
224 # try to read the user file and check the password 231 # try to read the user file and check the password
225 if (my $pl = cf::player::find $user) { 232 if (my $pl = cf::player::find $user) {
226 aio_stat $pl->path and next; 233 aio_stat $pl->path and next;
227 my $mtime = (stat _)[9]; 234 my $mtime = (stat _)[9];
… …
281 next; 288 next;
282 } 289 }
283 } 290 }
284 291
285 # the rest of this function is character creation 292 # the rest of this function is character creation
293 $Coro::current->{desc} = "addme($user) chargen";
286 294
287 # just to make sure nothing is left over 295 # just to make sure nothing is left over
288 nuke_playerdir $user; 296 nuke_playerdir $user;
289 297
290 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 298 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
… …
294 nuke_str $pass2; 302 nuke_str $pass2;
295 $ns->send_drawinfo ( 303 $ns->send_drawinfo (
296 "The passwords do not match, please try again.", 304 "The passwords do not match, please try again.",
297 cf::NDI_RED 305 cf::NDI_RED
298 ); 306 );
307 Coro::Timer::sleep 0.5;
299 next; 308 next;
300 } 309 }
301 310
302 nuke_str $pass2; 311 nuke_str $pass2;
303 312
304 my $pl = cf::player::new $user; 313 my $pl = cf::player::new $user;
305 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); 314 $pl->password (encode_password $pass);
306 nuke_str $pass; 315 nuke_str $pass;
307 $pl->connect ($ns); 316 $pl->connect ($ns);
308 my $ob = $pl->ob; 317 my $ob = $pl->ob;
309 318
310 $ob->goto ($pl->maplevel, $ob->x, $ob->y); 319 $ob->goto ($pl->maplevel, $ob->x, $ob->y);
… …
325 $ob->swap_stats ($res - 1, $swap - 1); 334 $ob->swap_stats ($res - 1, $swap - 1);
326 } 335 }
327 } else { 336 } else {
328 $ob->roll_stats; 337 $ob->roll_stats;
329 } 338 }
339
340 Coro::Timer::sleep 0.05;
330 } 341 }
331 342
332 $ob->set_animation (2); 343 $ob->set_animation (2);
333 $ob->add_statbonus; 344 $ob->add_statbonus;
334 345
335 while () { 346 while () {
336 $ns->send_msg (-1, "chargen-race-title", ucfirst $pl->title); 347 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
337 my $msg = $ob->msg; 348 my $msg = $ob->msg;
338 $msg =~ s/(?<=\S)\n(?=\S)/ /g; 349 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
339 $ns->send_msg (cf::NDI_BLUE, "chargen-race-description", $msg); 350 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
340 351
341 my $res = query $ns, cf::CS_QUERY_SINGLECHAR, 352 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
342 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"; 353 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
343 354
344 last if $res =~ /[dD]/; 355 last if $res =~ /[dD]/;
345 356
346 $pl->chargen_race_next; 357 $pl->chargen_race_next;
358 Coro::Timer::sleep 0.05;
347 } 359 }
348 360
361 # create the playerdir, if necessary, as chargen_race_done did it before
362 # presumably because of unique maps
363 aio_mkdir playerdir $pl, 0770;
349 $pl->chargen_race_done; 364 $pl->chargen_race_done;
350 365
351 while () { 366 while () {
352 my $res = query $ns, cf::CS_QUERY_SINGLECHAR, 367 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
353 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n"; 368 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
… …
357 last; 372 last;
358 } elsif ($res =~ /^[mM]/) { 373 } elsif ($res =~ /^[mM]/) {
359 $pl->gender (0); 374 $pl->gender (0);
360 last; 375 last;
361 } 376 }
377 Coro::Timer::sleep 0.05;
362 } 378 }
363 379
364 $ob->reply (undef, "Welcome to Crossfire!"); 380 $ob->reply (undef, "Welcome to Deliantra!");
381
382 # XXX: Workaround for delayed client ext protocol handshake
383 $pl->esrv_new_player;
365 384
366 delete $pl->{deny_save}; 385 delete $pl->{deny_save};
367 386
368 last; 387 last;
388 }
389
390 if (0 < Coro::AIO::aio_load "$cf::CONFDIR/motd", my $motd) {
391 $ns->send_msg ("c/motd" => $motd, cf::NDI_CLEAR);
369 } 392 }
370 }); 393 });
371}); 394});
372 395
396cf::register_command password => sub {
397 my ($pl, $arg) = @_;
398
399 my (@args) = split /\s+/, $arg;
400
401 my ($new_pw, $player);
402
403 if ($pl->flag (cf::FLAG_WIZ)) {
404 ($player, $new_pw) = @args;
405 } else {
406 $new_pw = $args[0];
407 }
408
409 if ($pl->flag (cf::FLAG_WIZ) && $player eq '') {
410 $pl->message (
411 "Usage: password <player> [<new password>]",
412 cf::NDI_UNIQUE | cf::NDI_REPLY);
413 return;
414 } elsif (!$pl->flag (cf::FLAG_WIZ) && $new_pw eq '') {
415 $pl->message (
416 "Usage: password <new password>",
417 cf::NDI_UNIQUE | cf::NDI_REPLY);
418 return;
419 }
420
421 if ($player ne '' && $pl->flag (cf::FLAG_WIZ)) {
422 unless ($new_pw ne '') {
423 $new_pw =
424 join '',
425 map { ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64)] }
426 1..9;
427 }
428
429 cf::async {
430 my $plc = cf::player::find $player;
431 if ($plc) {
432 $plc->password (encode_password $new_pw);
433 $pl->message (
434 "Ok, changed password of '$player' to '$new_pw'!",
435 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
436 } else {
437 $pl->message (
438 "Fail! Couldn't set password for '$player', "
439 . "he doesn't seem to exist!",
440 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
441 }
442 };
443 } else {
444 my $change = delete $pl->{password_change};
445 cf::debug "CHECK: @$change | $pl->{password_change} <<<<<\n";
446
447 if ($change && (time - $change->[0]) < 60) {
448 $pl->message (
449 "Ok, changed your password!",
450 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
451 $pl->contr->password (encode_password $new_pw);
452
453 } else {
454 $pl->message (
455 "Ok, please confirm your new password by sending "
456 . "the command again within one minute!",
457 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
458 $pl->{password_change} = [time, $new_pw];
459 }
460 }
461};
462
373cf::register_command quit => sub { 463cf::register_command quit => sub {
374 my ($ob, $arg) = @_; 464 my ($ob, $arg) = @_;
375 465
376 $ob->reply (undef, 466 $ob->send_msg (undef,
377 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. " 467 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. "
378 . "If you are sure you want to do this, then use the quit_character command instead of quit.", 468 . "If you are sure you want to do this, then use the quit_character command instead of quit.",
379 cf::NDI_UNIQUE | cf::NDI_RED); 469 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
380}; 470};
381 471
382cf::register_command quit_character => sub { 472cf::register_command quit_character => sub {
383 my ($ob, $arg) = @_; 473 my ($ob, $arg) = @_;
384 474
385 my $pl = $ob->contr; 475 my $pl = $ob->contr;
386 476
387 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub { 477 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub {
388 if ($_[0] !~ /^[yY]/) { 478 if ($_[0] !~ /^[yY]/) {
389 $ob->reply (undef, 479 $ob->send_msg (undef, "Ok, not not quitting then.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
390 "Ok, not not quitting then.",
391 cf::NDI_UNIQUE | cf::NDI_RED);
392 } else { 480 } else {
393 $ob->reply (undef, 481 $ob->send_msg (undef, "Ok, quitting, hope to see you again.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
394 "Ok, quitting, hope to see you again.",
395 cf::NDI_UNIQUE | cf::NDI_RED);
396 $pl->ns->flush; 482 $pl->ns->flush;
483 cf::async {
484 ext::highscore::check $pl->ob;
397 cf::async { $pl->quit_character }; 485 $pl->quit_character;
486 };
398 } 487 }
399 }); 488 });
400}; 489};
401 490
402cf::object->attach ( 491cf::object->attach (
… …
410 499
411 # update respawn position 500 # update respawn position
412 $pl->savebed ($bed->map->path, $bed->x, $bed->y); 501 $pl->savebed ($bed->map->path, $bed->x, $bed->y);
413 cf::async { $pl->save }; 502 cf::async { $pl->save };
414 503
415 $pl->killer ("left"); 504 my $killer = cf::arch::get "killer_logout"; $pl->killer ($killer); $killer->destroy;
416 $ob->check_score; 505 ext::highscore::check $ob;
417 506
418 $ob->reply (undef, "In the future, you will wake up here when you die."); 507 $ob->send_msg ($cf::SAY_CHANNEL => "In the future, you will wake up here when you die.", cf::NDI_DEF | cf::NDI_REPLY);
419 508
420 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { 509 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub {
421 if ($_[0] !~ /^[yY]/) { 510 if ($_[0] !~ /^[yY]/) {
422 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1); 511 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1);
423 $pl->deactivate; 512 $pl->deactivate;
… …
442 531
443 if ($cleanly) { 532 if ($cleanly) {
444 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 533 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
445 } else { 534 } else {
446 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 535 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
447 $pl->{unclean_save} = $cf::RUNTIME; 536 $pl->{unclean_save} = $cf::RUNTIME
537 unless safe_spot $pl;
448 } 538 }
449 }, 539 },
450); 540);
451 541
452#############################################################################
453 542
454our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs
455our $SAVE_TIMEOUT = 20; # save players every n seconds
456
457our $SCHEDULER = cf::async_ext {
458 my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL);
459 while () {
460 $schedule_interval->next;
461
462 # this weird form of iteration over values is used because
463 # the hash changes underneath us frequently, and for
464 # keeps a direct reference to the value without (in 5.8 perls)
465 # keeping a reference, so this is prone to crashes or worse.
466 my @players = keys %cf::PLAYER;
467 for (@players) {
468 my $pl = $cf::PLAYER{$_}
469 or next;
470 $pl->valid or next;
471
472 eval {
473 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
474 cf::wait_for_tick_begin;
475 $pl->save;
476
477 unless ($pl->active || $pl->ns) {
478 # check refcounts, this is tricky and needs to be adjusted to fit server internals
479 my $ob = $pl->ob;
480
481 my $pl_ref = $pl->refcnt_cnt;
482 my $ob_ref = $ob->refcnt_cnt;
483
484 ## pl_ref == $pl + ob->contr + %cf::PLAYER
485 ## ob_ref == $ob + pl->observe + simply being an object
486 if ($pl_ref == 3 && $ob_ref == 3) {
487 warn "player-scheduler destroy ", $ob->name;#d#
488
489 # remove from sight and get fresh "copies"
490 $pl = delete $cf::PLAYER{$ob->name};
491 $ob = $pl->ob;
492
493 $pl->destroy; # destroys $ob
494 } else {
495 my $a_ = $pl->refcnt;#d#
496 my $b_ = $ob->refcnt;#d#
497
498 warn "player-scheduler refcnt ", $ob->name, " pl $pl_ref ob $ob_ref (C pl $a_ ob $b_)\n";#d#
499 }
500 }
501 }
502 };
503 warn $@ if $@;
504 Coro::cede;
505 };
506 }
507};
508
509$SCHEDULER->prio (1);
510

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines