ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.63 by root, Sat Jul 14 14:54:05 2007 UTC vs.
Revision 1.111 by root, Sun May 9 22:51:13 2010 UTC

1#! perl # mandatory 1#! perl # mandatory depends=highscore
2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7
8our $MAX_DISCONNECT_TIME = $cf::CFG{max_disconnect_time} || 3600;
7 9
8# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
9sub nuke_str { 11sub nuke_str {
10 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
11} 13}
12 14
13sub query { 15sub query {
14 my ($ns, $flags, $text) = @_; 16 my ($ns, $flags, $text) = @_;
15 17
16 my $current = $Coro::current; 18 $ns->query ($flags, $text, Coro::rouse_cb);
17 $ns->query ($flags, $text, sub { $current->ready; $current = $_[0] }); 19 Coro::rouse_wait
18 Coro::schedule while ref $current;
19
20 $current
21} 20}
22 21
23sub can_cleanup { 22sub can_cleanup {
24 my ($pl, $mtime) = @_; 23 my ($pl, $mtime) = @_;
25 24
50 ); 49 );
51 50
52 1 51 1
53} 52}
54 53
54sub safe_spot($) {
55 my ($pl) = @_;
56
57 my $ob = $pl->ob;
58
59 my $m = $ob->map
60 or return;
61 my $x = $ob->x;
62 my $y = $ob->y;
63
64# return 0;#d#
65# warn join ":", $m->at ($x, $y);#d#
66# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
67# return 0;
68
69 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
70}
71
55sub enter_map { 72sub enter_map {
56 my ($pl) = @_; 73 my ($pl) = @_;
57 74
58 my $ob = $pl->ob; 75 my $ob = $pl->ob;
59 76
62 ? @{delete $ob->{_link_pos}} 79 ? @{delete $ob->{_link_pos}}
63 : ($pl->maplevel, $ob->x, $ob->y); 80 : ($pl->maplevel, $ob->x, $ob->y);
64 81
65 $ob->enter_link; 82 $ob->enter_link;
66 83
84 my $m = cf::map::find $map;
67 if (my $time = delete $pl->{unclean_save}) { 85 my $time = delete $pl->{unclean_save};
68 if (my $m = cf::map::find $map) { 86
87 if ($time && $m) {
69 if ($time < $m->{instantiate_time}) { 88 if ($time < $m->{instantiate_time}) {
70 # the map was reset in the meantime 89 # the map was reset in the meantime
71 my $age = $cf::RUNTIME - $time; 90 my $age = $cf::RUNTIME - $time;
91
72 warn $ob->name, " map reset after logout, logout age $age\n";#d# 92 cf::info $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
73 93
74 # for now, just go back to savebed 94 if ($age >= $MAX_DISCONNECT_TIME) {
95 $ob->message (
96 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
97 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
98 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
99 . "H<You disconnected too long without having used a savebed.>",
100 cf::NDI_RED
101 );
102 # kill them.
103 # reminds me of the famous badness 10000 syndrome...
104 $ob->stats->hp (-10000); #] if they survive this they deserved to live
105 my $killer = cf::arch::get "killer_login"; $pl->killer ($killer); $killer->destroy;
106 } else {
75 ($map, $x, $y) = $pl->savebed; 107 ($map, $x, $y) = $pl->savebed;
76 108
77 $pl->ns->send_drawinfo ( 109 $ob->message (
78 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. " 110 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
79 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. " 111 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
80 . "Better use a savebed next time, much worse things could have happened...", 112 . "Better use a savebed next time, much worse things could have happened... "
113 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
81 cf::NDI_RED 114 cf::NDI_RED
82 ); 115 );
116 }
83 } else { 117 } else {
84 $pl->ns->send_drawinfo ( 118 $ob->message (
85 "You didn't use a bed to reality to leave this realm. This is very dangerous, " 119 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
86 . "as lots of things could happen when you leave by other means, such as cave-ins, " 120 . "as lots of things could happen when you leave by other means, such as cave-ins, "
87 . "or monsters suddenly snapping your body. Better use a savebed next time.", 121 . "or monsters suddenly snapping your body. Better use a savebed next time. "
122 . "H<Always apply a bed of reality to disconnect from the server.>",
88 cf::NDI_RED 123 cf::NDI_RED
89 ); 124 );
90 }
91 } 125 }
92 } 126 }
93 127
94 $ob->goto ($map, $x, $y); 128 $ob->goto ($map, $x, $y);
95} 129}
96 130
97# delete a player directory, be non-blocking AND synchronous... 131sub encode_password($) {
98# (thats hard, so we crap out and fork). 132# crypt $_[0],
133# join '',
134# ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64), (cf::rndm 64)]
135 "!" . unpack "H*", $_[0]
136}
137
138sub compare_password($$) {
139 my ($pass, $token) = @_;
140
141 if ($token =~ /\!(.*)/) {
142 return $pass eq pack "H*", $1;
143 } else {
144 return $token eq crypt $pass, $token;
145 }
146}
147
148# delete a player directory
99sub nuke_playerdir { 149sub nuke_playerdir {
100 my ($user) = @_; 150 my ($user) = @_;
101 151
152 my $lock = cf::lock_acquire "ext::login::nuke_playerdir";
153
154 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
102 aio_stat "$PLAYERDIR/$user"; 155 aio_rename "$PLAYERDIR/$user", $temp;
103 system "cd \Q$PLAYERDIR\E " 156 IO::AIO::aio_rmtree $temp;
104 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null "
105 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)";
106} 157}
107 158
108cf::client->attach (on_addme => sub { 159cf::client->attach (on_addme => sub {
109 my ($ns) = @_; 160 my ($ns) = @_;
110 161
111 if (!$ns->facecache)
112 {
113 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
114
115
116***
117*** WARNING:
118*** Your client does not support face/image caching,
119*** or it has been disabled. Face caching is mandatory
120*** so please enable it or use a newer client.
121***
122*** Look at your client preferences:
123***
124*** CFPlus: all known versions automatically enable the facecache.
125*** cfclient: use the -cache commandline option.
126*** cfclient: map will not redraw automatically (bug).
127*** gcfclient: use -cache commandline option, or enable
128*** gcfclient: Client=>Configure=>Map & Image=>Cache Images.
129*** jcrossclient: your client is broken, use CFPlus or gcfclient.
130***
131***
132EOF
133 if ($ns->version =~ /jcrossclient/) {
134 # let them, for now
135 } else {
136 $ns->flush;
137 return $ns->destroy;
138 }
139
140 # $ns->facecache = true;
141 }
142
143 if ($ns->mapmode < cf::Map1aCmd) {
144 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
145
146
147***
148*** WARNING:
149*** Your client is too old. Please upgrade to a newer version.
150EOF
151
152 $ns->flush;
153 return $ns->destroy;
154 }
155
156 $ns->pl and return $ns->destroy; 162 $ns->pl and return $ns->destroy;
157 163
158 $ns->async (sub { 164 $ns->async (sub {
165 $Coro::current->{desc} = "addme init";
166
159 my ($user, $pass); 167 my ($user, $pass);
160 168
161 $ns->send_packet ("addme_success"); 169 $ns->send_packet ("addme_success");
162 170
163 for (;;) { 171 for (;;) {
168 cf::NDI_BLUE 176 cf::NDI_BLUE
169 ); 177 );
170 178
171 # read username 179 # read username
172 while () { 180 while () {
173 $user = query $ns, 0, "What is your name?\n:"; 181 $user = query $ns, 0, "What is your name? (login names are case-sensitive)\n:";
174 182
175 if ($cf::LOGIN_LOCK{$user}) { 183 if ($cf::LOGIN_LOCK{$user}) {
176 $ns->send_drawinfo ( 184 $ns->send_drawinfo (
177 "That username is currently used in another login session. " 185 "That username is currently used in another login session. "
178 . "Chose another, or wait till the other session has ended.", 186 . "Chose another, or wait till the other session has ended.",
179 cf::NDI_RED 187 cf::NDI_RED
180 ); 188 );
181 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}\z/) { 189 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,19}\z/) {
182 last; 190 last;
183 } else { 191 } else {
184 $ns->send_drawinfo ( 192 $ns->send_drawinfo (
185 "Your username contains illegal characters " 193 "Your username contains illegal characters "
186 . "(only a-z, A-Z and 0-9 are allowed), " 194 . "(only a-z, A-Z and 0-9 are allowed), "
187 . "or is not between 3 and 18 characters in length.", 195 . "or is not between 3 and 20 characters in length.",
188 cf::NDI_RED 196 cf::NDI_RED
189 ); 197 );
190 } 198 }
191 Coro::Timer::sleep 0.4; 199 Coro::Timer::sleep 0.4;
192 } 200 }
193 201
194 check_playing $ns, $user and next; 202 check_playing $ns, $user and next;
203
204 $Coro::current->{desc} = "addme($user) pass";
195 205
196 $ns->send_drawinfo ( 206 $ns->send_drawinfo (
197 "Welcome $user, please enter your password now. " 207 "Welcome $user, please enter your password now. "
198 . "New users should now choose a password. " 208 . "New users should now choose a password. "
199 . "Anything your client lets you enter is fine.", 209 . "Anything your client lets you enter is fine.",
223 } 233 }
224 local $cf::LOGIN_LOCK{$user} = 1; 234 local $cf::LOGIN_LOCK{$user} = 1;
225 235
226 check_playing $ns, $user and next; 236 check_playing $ns, $user and next;
227 237
238 $Coro::current->{desc} = "addme($user) check";
239
228 # try to read the user file and check the password 240 # try to read the user file and check the password
229 if (my $pl = cf::player::find $user) { 241 if (my $pl = cf::player::find $user) {
230 aio_stat $pl->path and next; 242 aio_stat $pl->path and next;
231 my $mtime = (stat _)[9]; 243 my $mtime = (stat _)[9];
232 my $hash = $pl->password; 244 my $token = $pl->password;
233 245
234 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) { 246 if ($cf::CFG{ext_login_nocheck} or compare_password $pass, $token) {
247 $pl->password (encode_password $pass); # make sure we store the new encoding #d#
235 nuke_str $pass; 248 nuke_str $pass;
236 # password matches, wonderful 249 # password matches, wonderful
237 my $pl = cf::player::find $user or next; 250 my $pl = cf::player::find $user or next;
238 $pl->connect ($ns); 251 $pl->connect ($ns);
239 enter_map $pl; 252 enter_map $pl;
285 next; 298 next;
286 } 299 }
287 } 300 }
288 301
289 # the rest of this function is character creation 302 # the rest of this function is character creation
303 $Coro::current->{desc} = "addme($user) chargen";
290 304
291 # just to make sure nothing is left over 305 # just to make sure nothing is left over
306 # normally, nothing is there.
292 nuke_playerdir $user; 307 nuke_playerdir $user;
293 308
294 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 309 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
295 310
296 if ($pass2 ne $pass) { 311 if ($pass2 ne $pass) {
305 } 320 }
306 321
307 nuke_str $pass2; 322 nuke_str $pass2;
308 323
309 my $pl = cf::player::new $user; 324 my $pl = cf::player::new $user;
310 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); 325 $pl->password (encode_password $pass);
311 nuke_str $pass; 326 nuke_str $pass;
312 $pl->connect ($ns); 327 $pl->connect ($ns);
313 my $ob = $pl->ob; 328 my $ob = $pl->ob;
314 329
315 $ob->goto ($pl->maplevel, $ob->x, $ob->y); 330 $ob->goto ($pl->maplevel, $ob->x, $ob->y);
331 } 346 }
332 } else { 347 } else {
333 $ob->roll_stats; 348 $ob->roll_stats;
334 } 349 }
335 350
336 Coro::Timer::sleep 0.2; 351 Coro::Timer::sleep 0.05;
337 } 352 }
338 353
339 $ob->set_animation (2); 354 $ob->set_animation (2);
340 $ob->add_statbonus; 355 $ob->add_statbonus;
341 356
342 while () { 357 while () {
343 $ns->send_msg (-1, "chargen-race-title", ucfirst $pl->title); 358 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
344 my $msg = $ob->msg; 359 my $msg = $ob->msg;
345 $msg =~ s/(?<=\S)\n(?=\S)/ /g; 360 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
346 $ns->send_msg (cf::NDI_BLUE, "chargen-race-description", $msg); 361 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
347 362
348 my $res = query $ns, cf::CS_QUERY_SINGLECHAR, 363 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
349 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"; 364 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
350 365
351 last if $res =~ /[dD]/; 366 last if $res =~ /[dD]/;
352 367
353 $pl->chargen_race_next; 368 $pl->chargen_race_next;
354 Coro::Timer::sleep 0.2; 369 Coro::Timer::sleep 0.05;
355 } 370 }
356 371
372 # create the playerdir, if necessary, as chargen_race_done did it before
373 # presumably because of unique maps
374 aio_mkdir playerdir $pl, 0770;
357 $pl->chargen_race_done; 375 $pl->chargen_race_done;
358 376
359 while () { 377 while () {
360 my $res = query $ns, cf::CS_QUERY_SINGLECHAR, 378 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
361 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n"; 379 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
365 last; 383 last;
366 } elsif ($res =~ /^[mM]/) { 384 } elsif ($res =~ /^[mM]/) {
367 $pl->gender (0); 385 $pl->gender (0);
368 last; 386 last;
369 } 387 }
370 Coro::Timer::sleep 0.2; 388 Coro::Timer::sleep 0.05;
371 } 389 }
372 390
373 $ob->reply (undef, "Welcome to Crossfire!"); 391 $ob->reply (undef, "Welcome to Deliantra!");
392
393 # XXX: Workaround for delayed client ext protocol handshake
394 $pl->esrv_new_player;
374 395
375 delete $pl->{deny_save}; 396 delete $pl->{deny_save};
376 397
377 last; 398 last;
399 }
400
401 if (0 < Coro::AIO::aio_load "$cf::CONFDIR/motd", my $motd) {
402 $ns->send_msg ("c/motd" => $motd, cf::NDI_CLEAR);
378 } 403 }
379 }); 404 });
380}); 405});
381 406
407cf::register_command password => sub {
408 my ($pl, $arg) = @_;
409
410 my (@args) = split /\s+/, $arg;
411
412 my ($new_pw, $player);
413
414 if ($pl->flag (cf::FLAG_WIZ)) {
415 ($player, $new_pw) = @args;
416 } else {
417 $new_pw = $args[0];
418 }
419
420 if ($pl->flag (cf::FLAG_WIZ) && $player eq '') {
421 $pl->message (
422 "Usage: password <player> [<new password>]",
423 cf::NDI_UNIQUE | cf::NDI_REPLY);
424 return;
425 } elsif (!$pl->flag (cf::FLAG_WIZ) && $new_pw eq '') {
426 $pl->message (
427 "Usage: password <new password>",
428 cf::NDI_UNIQUE | cf::NDI_REPLY);
429 return;
430 }
431
432 if ($player ne '' && $pl->flag (cf::FLAG_WIZ)) {
433 unless ($new_pw ne '') {
434 $new_pw =
435 join '',
436 map { ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64)] }
437 1..9;
438 }
439
440 cf::async {
441 my $plc = cf::player::find $player;
442 if ($plc) {
443 $plc->password (encode_password $new_pw);
444 $pl->message (
445 "Ok, changed password of '$player' to '$new_pw'!",
446 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
447 } else {
448 $pl->message (
449 "Fail! Couldn't set password for '$player', "
450 . "he doesn't seem to exist!",
451 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
452 }
453 };
454 } else {
455 my $change = delete $pl->{password_change};
456
457 if ($change && (time - $change->[0]) < 60) {
458 $pl->message (
459 "Ok, changed your password!",
460 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
461 $pl->contr->password (encode_password $new_pw);
462
463 } else {
464 $pl->message (
465 "Ok, please confirm your new password by sending "
466 . "the command again within one minute!",
467 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
468 $pl->{password_change} = [time, $new_pw];
469 }
470 }
471};
472
382cf::register_command quit => sub { 473cf::register_command quit => sub {
383 my ($ob, $arg) = @_; 474 my ($ob, $arg) = @_;
384 475
385 $ob->reply (undef, 476 $ob->send_msg (undef,
386 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. " 477 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. "
387 . "If you are sure you want to do this, then use the quit_character command instead of quit.", 478 . "If you are sure you want to do this, then use the quit_character command instead of quit.",
388 cf::NDI_UNIQUE | cf::NDI_RED); 479 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
389}; 480};
390 481
391cf::register_command quit_character => sub { 482cf::register_command quit_character => sub {
392 my ($ob, $arg) = @_; 483 my ($ob, $arg) = @_;
393 484
394 my $pl = $ob->contr; 485 my $pl = $ob->contr;
395 486
396 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub { 487 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub {
397 if ($_[0] !~ /^[yY]/) { 488 if ($_[0] !~ /^[yY]/) {
398 $ob->reply (undef, 489 $ob->send_msg (undef, "Ok, not not quitting then.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
399 "Ok, not not quitting then.",
400 cf::NDI_UNIQUE | cf::NDI_RED);
401 } else { 490 } else {
402 $ob->reply (undef, 491 $ob->send_msg (undef, "Ok, quitting, hope to see you again.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
403 "Ok, quitting, hope to see you again.", 492 cf::async {
404 cf::NDI_UNIQUE | cf::NDI_RED);
405 $pl->ns->flush;
406 cf::async { $pl->quit_character }; 493 $pl->quit_character;
494 };
407 } 495 }
408 }); 496 });
409}; 497};
410 498
411cf::object->attach ( 499cf::object->attach (
417 505
418 my $pl = $ob->contr; 506 my $pl = $ob->contr;
419 507
420 # update respawn position 508 # update respawn position
421 $pl->savebed ($bed->map->path, $bed->x, $bed->y); 509 $pl->savebed ($bed->map->path, $bed->x, $bed->y);
422 cf::async { $pl->save };
423 510
424 $pl->killer ("left"); 511 cf::async {
425 $ob->check_score; 512 my $killer = cf::arch::get "killer_logout"; $pl->killer ($killer); $killer->destroy;
513 ext::highscore::check $ob;
426 514
427 $ob->reply (undef, "In the future, you will wake up here when you die."); 515 $pl->save;
428 516
517 $ob->send_msg ($cf::SAY_CHANNEL => "In the future, you will wake up here when you die.", cf::NDI_DEF | cf::NDI_REPLY);
518
429 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { 519 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub {
430 if ($_[0] !~ /^[yY]/) { 520 if ($_[0] !~ /^[yY]/) {
431 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1); 521 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1);
432 $pl->deactivate; 522 $pl->deactivate;
433 $pl->ns->destroy; 523 $pl->ns->destroy;
434 } else { 524 }
435 cf::async { $pl->save };
436 } 525 });
437 }); 526 };
438 }, 527 },
439); 528);
440 529
441cf::player->attach ( 530cf::player->attach (
442 on_login => sub { 531 on_login => sub {
451 540
452 if ($cleanly) { 541 if ($cleanly) {
453 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 542 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
454 } else { 543 } else {
455 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 544 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
456 $pl->{unclean_save} = $cf::RUNTIME; 545 $pl->{unclean_save} = $cf::RUNTIME
546 unless safe_spot $pl;
457 } 547 }
458 }, 548 },
459); 549);
460 550
461#############################################################################
462
463our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs
464our $SAVE_TIMEOUT = 20; # save players every n seconds
465
466our $SCHEDULER = cf::async_ext {
467 my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL);
468 while () {
469 $schedule_interval->next;
470
471 # this weird form of iteration over values is used because
472 # the hash changes underneath us frequently, and for
473 # keeps a direct reference to the value without (in 5.8 perls)
474 # keeping a reference, so this is prone to crashes or worse.
475 my @players = keys %cf::PLAYER;
476 for (@players) {
477 my $pl = $cf::PLAYER{$_}
478 or next;
479 $pl->valid or next;
480
481 eval {
482 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
483 cf::wait_for_tick_begin;
484 $pl->save;
485
486 unless ($pl->active || $pl->ns) {
487 # check refcounts, this is tricky and needs to be adjusted to fit server internals
488 my $ob = $pl->ob;
489
490 my $pl_ref = $pl->refcnt_cnt;
491 my $ob_ref = $ob->refcnt_cnt;
492
493 ## pl_ref == $pl + ob->contr + %cf::PLAYER
494 ## ob_ref == $ob + pl->observe + simply being an object
495 if ($pl_ref == 3 && $ob_ref == 3) {
496 warn "player-scheduler destroy ", $ob->name;#d#
497
498 # remove from sight and get fresh "copies"
499 $pl = delete $cf::PLAYER{$ob->name};
500 $ob = $pl->ob;
501
502 $pl->destroy; # destroys $ob
503 } else {
504 my $a_ = $pl->refcnt;#d#
505 my $b_ = $ob->refcnt;#d#
506
507 warn "player-scheduler refcnt ", $ob->name, " pl $pl_ref ob $ob_ref (C pl $a_ ob $b_)\n";#d#
508 }
509 }
510 }
511 };
512 warn $@ if $@;
513 Coro::cede;
514 };
515 }
516};
517
518$SCHEDULER->prio (1);
519

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines