--- deliantra/server/ext/login.ext 2007/01/08 14:11:05 1.17 +++ deliantra/server/ext/login.ext 2012/11/18 10:00:55 1.130 @@ -1,32 +1,28 @@ -#! perl +#! perl # mandatory depends=highscore # login handling use Fcntl; use Coro::AIO; +use Deliantra::Util (); -my $PLAYERDIR = sprintf "%s/%s", cf::localdir, cf::playerdir; +CONF MAX_DISCONNECT_TIME = 3600; -# paranoia function to overwrite a string-in-place -sub nuke_str { - substr $_[0], 0, (length $_[0]), "x" x length $_[0] -} +our $VALID_LOGIN = qr<^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,19}\z>; +our %LOGIN_LOCK; sub query { my ($ns, $flags, $text) = @_; - my $current = $Coro::current; - $ns->query ($flags, $text, sub { $current->ready; $current = $_[0]; }); - Coro::schedule while ref $current; - - $current + $ns->query ($flags, $text, Coro::rouse_cb); + Coro::rouse_wait } sub can_cleanup { - my ($playerfile, $mtime) = @_; + my ($pl, $mtime) = @_; my $age = time - $mtime; - my $level = $playerfile =~ /^level (\d+)$/m ? $1 : return; + my $level = $pl->ob->level; ($level <= 3 && $age > 7 * 86400) # 7 days for level 0..3 || ($level <= 9 && $age > 90 * 86400) # 3 months for level 4..9 @@ -34,145 +30,337 @@ || $age > 700 * 86400 # 2 years for everybody else } -sub check_playing { - my ($ns, $user) = @_; +# return a guard object for a lock on the given username, if available +sub login_guard { + my ($user) = @_; + + exists $LOGIN_LOCK{$user} + and return undef; + + cf::player::find_active $user + and return undef; - return unless cf::player::find_active $user; + undef $LOGIN_LOCK{$user}; + Guard::guard { delete $LOGIN_LOCK{$user} } +} + +sub safe_spot($) { + my ($pl) = @_; + + my $ob = $pl->ob; - $ns->send_drawinfo ( - "That player is already logged in on this server. " - . "If you want to create a new player, choose another name. " - . "If you are already a registered player, make sure nobody " - . "else is using your account at this time. If you lost your conenction " - . "then the server will likely timeout within a minute. If you still " - . "cannot log-in after a minute, you are still logged in. Make sure " - . "you do not have another client running. If you use windows, reboot, " - . "this will fix anything.", - cf::NDI_RED - ); + my $m = $ob->map + or return; + my $x = $ob->x; + my $y = $ob->y; + + # never happens normally, but helps when shell users make mistakes + $m->linkable + or return 1; - 1 + scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y) } -sub check_clean_save { +sub enter_map { my ($pl) = @_; - unless (delete $pl->{clean_save}) { - #d#TODO + my $ob = $pl->ob; + + my ($map, $x, $y) + = $ob->{_link_pos} + ? @{delete $ob->{_link_pos}} + : ($pl->maplevel, $ob->x, $ob->y); + + $ob->enter_link; + + my $m = cf::map::find $map; + my $time = delete $pl->{unclean_save}; + + if ($time && $m) { + if ($time < $m->{instantiate_time}) { + # the map was reset in the meantime + my $age = $cf::RUNTIME - $time; + + cf::info $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d# + + if ($age >= $MAX_DISCONNECT_TIME) { + $ob->message ( + "You didn't use a bed to reality to leave this realm, leaving your body in great danger. " + . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. " + . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... " + . "H", + cf::NDI_RED | cf::NDI_REPLY + ); + # kill them. + # reminds me of the famous badness 10000 syndrome... + $ob->stats->hp (-10000); #] if they survive this they deserved to live + my $killer = cf::arch::get "killer_login"; $pl->killer ($killer); $killer->destroy; + } else { + ($map, $x, $y) = $pl->savebed; + + $ob->message ( + "You didn't use a bed to reality to leave this realm, leaving your body in great danger. " + . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. " + . "Better use a savebed next time, much worse things could have happened... " + . "H", + cf::NDI_RED | cf::NDI_REPLY + ); + } + } else { + $ob->message ( + "You didn't use a bed to reality to leave this realm. This is very dangerous, " + . "as lots of things could happen when you leave by other means, such as cave-ins, " + . "or monsters suddenly snapping your body. Better use a savebed next time. " + . "H", + cf::NDI_RED | cf::NDI_REPLY + ); + } } + + $ob->goto ($map, $x, $y); +} + +sub encode_password($) { + unpack "H*", Deliantra::Util::hash_pw $_[0] } -# delete a player directory, be non-blocking AND synchronous... -# (thats hard, so we crap out and fork). +sub compare_password($$) { + my ($pass, $token) = @_; + + if ($token =~ /!!(.*)/) { + return +(substr $pass, 0, 8) eq pack "H*", $1; + } elsif ($token =~ /!(.*)/) { + return $pass eq pack "H*", $1; + } else { + return $token eq crypt $pass, $token; + } +} + +# delete a player directory sub nuke_playerdir { my ($user) = @_; - aio_stat "$PLAYERDIR/$user"; - system "cd \Q$PLAYERDIR\E " - . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null " - . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)"; + my $lock = cf::lock_acquire "ext::login::nuke_playerdir"; + + my $temp = "$PLAYERDIR/~$Coro::current~deleting~"; + aio_rename "$PLAYERDIR/$user", $temp; + IO::AIO::aio_rmtree $temp; +} + +sub login { + my ($pl) = @_; + + # handle character creation, if neccessary + # the rest of this function is character creation + + my $ns = $pl->ns; + my $ob = $pl->ob; + + if ($pl->{chargen} eq "init") { + $ob->goto ($pl->maplevel, $ob->x, $ob->y); + + # create the playerdir, if necessary, as chargen_race_done did it before + # presumably because of unique maps + aio_mkdir playerdir $pl, 0770; + delete $pl->{deny_save}; # set by new + $pl->save; + + $pl->{chargen} = "stats"; + } + + if ($pl->{chargen} eq "stats") { + while () { + $ob->update_stats; + $pl->save_stats; + + my $res = query $ns, cf::CS_QUERY_SINGLECHAR, + "[y] to roll new stats [n] to use stats\n[1-7] [1-7] to swap stats.\nRoll again (y/n/1-7)?"; + + if ($res =~ /^[Nn]/) { + last; + } elsif ($res > 0 && $res <= 7) { + my $swap = query $ns, cf::CS_QUERY_SINGLECHAR, "Swap stat with (will not roll new stats) [1-7]?"; + + if ($swap > 0 && $swap <= 7) { + $ob->swap_stats ($res - 1, $swap - 1); + } + } else { + $ob->roll_stats; + } + + Coro::Timer::sleep 0.05; + } + + $ob->set_animation (2); + $ob->add_statbonus; + + $pl->{chargen} = "race"; + } + + if ($pl->{chargen} eq "race") { + while () { + $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1); + my $msg = $ob->msg; + $msg =~ s/(?<=\S)\n(?=\S)/ /g; + $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE); + + my $res = query $ns, cf::CS_QUERY_SINGLECHAR, + "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"; + + last if $res =~ /[dD]/; + + $pl->chargen_race_next; + Coro::Timer::sleep 0.05; + } + + $pl->chargen_race_done; + $pl->{chargen} = "gender"; + } + + if ($pl->{chargen} eq "race") { + while () { + my $res = query $ns, cf::CS_QUERY_SINGLECHAR, + "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n"; + + if ($res =~ /^[fF]/) { + $pl->gender (1); + last; + } elsif ($res =~ /^[mM]/) { + $pl->gender (0); + last; + } + Coro::Timer::sleep 0.05; + } + $pl->{chargen} = "done"; + } + + $ns->state (cf::ST_PLAYING); + + if ($pl->{chargen} eq "done") { + # XXX: Workaround for delayed client ext protocol handshake + $pl->esrv_new_player; + + $pl->{chargen} = "done"; + } + + $ob->reply (undef, "Welcome to Deliantra!"); + + if (0 < Coro::AIO::aio_load "$cf::CONFDIR/motd", my $motd) { + $pl->ns->send_msg ("c/motd" => $motd, cf::NDI_CLEAR); + } +} + +sub chargen { + my ($ns, $user, $hash) = @_; + + # just to make sure nothing is left over + # normally, nothing is there. + nuke_playerdir $user; + + my $pl = cf::player::new $user; + $pl->password (unpack "H*", $hash); + $pl->connect ($ns); + + $pl->{chargen} = "init"; + + login $pl; } -sub addme { +cf::client->attach (on_addme => sub { my ($ns) = @_; - $ns->destroy if $ns->pl; + $ns->{addme}++ and return $ns->destroy; $ns->async (sub { + $Coro::current->{desc} = "addme init"; + my ($user, $pass); $ns->send_packet ("addme_success"); for (;;) { - $ns->send_drawinfo ( + delete $ns->{login_guard}; + + $ns->send_msg (log => "Please enter your username now. If you are a new user, " . "make one up that describes your character best. " . "Only letters and digits are allowed, though.", - cf::NDI_BLUE + cf::NDI_BLUE | cf::NDI_REPLY ); # read username while () { - $user = query $ns, 0, "What is your name?\n:"; + $user = query $ns, 0, "What is your name? (login names are case-sensitive)\n:"; - if ($cf::LOGIN_LOCK{$user}) { - $ns->send_drawinfo ( - "That username is currently used in another login session. " - . "Chose another, or wait till the other session has ended.", - cf::NDI_RED - ); - } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}$/) { + if ($user =~ $VALID_LOGIN) { last; } else { - $ns->send_drawinfo ( + $ns->send_msg (log => "Your username contains illegal characters " . "(only a-z, A-Z and 0-9 are allowed), " - . "or is not between 3 and 18 characters in length.", - cf::NDI_RED + . "or is not between 3 and 20 characters in length.", + cf::NDI_RED | cf::NDI_REPLY ); } + Coro::Timer::sleep 0.4; } - check_playing $ns, $user and next; + $Coro::current->{desc} = "addme($user)"; - $ns->send_drawinfo ( + $ns->send_msg (log => "Welcome $user, please enter your password now. " . "New users should now choose a password. " . "Anything your client lets you enter is fine.", - cf::NDI_BLUE + cf::NDI_BLUE | cf::NDI_REPLY ); # read password while () { $pass = query $ns, cf::CS_QUERY_HIDEINPUT, "What is your password?\n:"; last if $pass =~ /.../; - $ns->send_drawinfo ( + $ns->send_msg (log => "Try to use at least three characters as your password please, " . "that cannot be too much to ask for :)", - cf::NDI_RED + cf::NDI_RED | cf::NDI_REPLY ); + Coro::Timer::sleep 0.4; } - # lock this username for the remainder of this login session - if ($cf::LOGIN_LOCK{$user}) { - $ns->send_drawinfo ( - "That username is currently used in another login session. " - . "Chose another, or wait till the other session has ended.", - cf::NDI_RED - ); - next; - } - local $cf::LOGIN_LOCK{$user} = 1; - - check_playing $ns, $user and next; + $ns->{login_guard} = login_guard $user + or do { + $ns->send_msg (log => + "That user is already logged in (or is logging in)." + . "Chose another, or wait till the other session has ended.", + cf::NDI_RED | cf::NDI_REPLY + ); + next; + }; # try to read the user file and check the password - if (my $fh = aio_open cf::player::path $user, O_RDONLY, 0) { - my $mtime = (stat $fh)[9]; + if (my $pl = cf::player::find $user) { + aio_stat $pl->path and next; + my $mtime = (stat _)[9]; + my $token = $pl->password; - 0 < aio_read $fh, 0, 16384, my $buf, 0 or next; - $buf =~ /^password (\S+)$/m or next; - my $hash = $1; + if ($cf::CFG{ext_login_nocheck} or compare_password $pass, $token) { + # player exists and passwords match - we can proceed - if ($hash eq crypt $pass, $hash) { - nuke_str $pass; # password matches, wonderful my $pl = cf::player::find $user or next; $pl->connect ($ns); - check_clean_save $pl; - $pl->{clean_save} = 1; - last; - } elsif (can_cleanup $buf, $mtime) { + enter_map $pl; + login $pl; + return; + } elsif (can_cleanup $pl, $mtime) { Coro::Timer::sleep 1; - $ns->send_drawinfo ( + $ns->send_msg (log => "Player exists, but password does not match. If this is your account, " . "please try again. If not, you can now decide to take over this account " . "because it has not been in-use for some time.", - cf::NDI_RED + cf::NDI_RED | cf::NDI_REPLY ); - #TODO: nuke_str (query $ns, cf::CS_QUERY_SINGLECHAR, "Delete existing account and create a new one (Y/N)?") =~ /^[yY]/ or next; @@ -180,91 +368,206 @@ aio_stat cf::player::path $user and next; $mtime == (stat _)[9] or next; - nuke_playerdir $user; + $pl->quit_character; # fall through to creation } else { - nuke_str $pass; - Coro::Timer::sleep 1; - $ns->send_drawinfo ( + $ns->send_msg (log => "Wrong username or password. Please try again " . "(check for Numlock and other semi-obvious error sources).", - cf::NDI_RED + cf::NDI_RED | cf::NDI_REPLY + ); + next; + } + } else { + # unable to load the playerfile: + # check whether the player dir exists, which means the file is corrupted or + # something very similar. + if (!aio_stat cf::player::playerdir $user) { + $ns->send_msg ( log => + "Unable to retrieve this player. It might be a locked or broken account. " + . "If this is your account, ask a dungeon master for assistance. " + . "Otherwise choose a different login name.", + cf::NDI_RED | cf::NDI_REPLY ); next; } } - # the rest of this function is character creation - - # just to make sure nothing is left over - nuke_playerdir $user; - my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; if ($pass2 ne $pass) { - nuke_str $pass; - nuke_str $pass2; - $ns->send_drawinfo ( + $ns->send_msg (log => "The passwords do not match, please try again.", - cf::NDI_RED + cf::NDI_RED | cf::NDI_REPLY ); + Coro::Timer::sleep 0.5; next; } - nuke_str $pass2; + last; + } - my $pl = cf::player::new $user; - $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); - nuke_str $pass; - $pl->connect ($ns); + chargen $ns, $user, Deliantra::Util::hash_pw $pass; + }); +}); - my $ob = $pl->ob; +cf::client->attach ( + on_version => sub { + my ($ns, $arg) = @_; - while () { - $ob->update_stats; - $pl->save_stats; + # perl probably uses lrand48, which is not secure at all + # maybe require linux and use /dev/urandom. + $ns->{nonces} = [map { join "", map { chr rand 256 } 0..63 } 1..2]; + $ns->ext_msg (nonces => @{ $ns->{nonces} }); + }, +); - my $res = query $ns, cf::CS_QUERY_SINGLECHAR, - "[y] to roll new stats [n] to use stats\n[1-7] [1-7] to swap stats.\nRoll again (y/n/1-7)?"; +cf::register_async_exticmd create_login => sub { + my ($ns, $reply, $user, $pass) = @_; - if ($res =~ /^[Nn]/) { - last; - } elsif ($res > 0 && $res <= 7) { - my $swap = query $ns, cf::CS_QUERY_SINGLECHAR, "Swap stat with (will not roll new stats) [1-7]?"; + $ns->{addme}++ and return $ns->destroy; - if ($swap > 0 && $swap <= 7) { - $ob->swap_stats ($res - 1, $swap - 1); - } - } else { - $ob->roll_stats; - } - } + $ns->async (sub { + my $fail = sub { + $reply->(0, $_[0]); + $ns->flush; # does not ensure that the data reaches the client - TODO + # need to do this in another thread, as this one gets canceled + Coro::async_pool { + Coro::AnyEvent::sleep 0.1; # TODO, see above, extra hack + $ns->destroy if $ns->valid; + }; + Coro::schedule; # do the destroy, should not return + }; - $ob->set_animation (2); - $ob->add_statbonus; + $user =~ $VALID_LOGIN + or return $fail ( + "Your username contains illegal characters (only a-z, A-Z and 0-9 are allowed), " + . "or is not between 3 and 20 characters in length." + ); - $ns->send_drawinfo ($ob->msg, cf::NDI_BLUE); - $ns->send_packet (sprintf "query %d %s", cf::CS_QUERY_SINGLECHAR, - "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"); + $ns->{login_guard} = login_guard $user + or return $fail->("User name '$user' is in use - try another login name."); - $ns->state (cf::ST_CHANGE_CLASS); - delete $pl->{deny_save};#d# too early + cf::player::find $user + and return $fail->("User name '$user' is already registered - choose another login name."); - last; - } + $reply->(1, "Account Created"); + + chargen $ns, $user, $pass; }); -} +}; + +cf::register_async_exticmd login => sub { + my ($ns, $reply, $user, $hash) = @_; + + $ns->{addme}++ and return $ns->destroy; + + $ns->async (sub { + $Coro::current->{desc} = "login($user)"; + + my $fail = sub { + $reply->(0, $_[0]); + $ns->flush; # does not ensure that the data reaches the client - TODO + # need to do this in another thread, as this one gets canceled + Coro::async_pool { + Coro::AnyEvent::sleep 0.1; # TODO, see above, extra hack + $ns->destroy if $ns->valid; + }; + Coro::schedule; # do the destroy, should not return + }; + + $ns->{login_guard} = login_guard $user + or return $fail->("User '$user' is currently playing or logging in in another session. If that is your " + . "user name, make sure you are not running two clients. When in doubt, reboot."); + + # try to read the user file and check the password + my $pl = cf::player::find $user + or return $fail->("User '$user' does not exist - wrong spelling?"); + + aio_stat $pl->path + and return $ns->destroy; + + my $mtime = (stat _)[9]; + my $token = $pl->password; + + $token = $token =~ /^!/ + ? Deliantra::Util::hash_pw pack "H*", substr $token, 1 + : pack "H*", $token; + + $token = Deliantra::Util::auth_pw $token, $ns->{nonces}[0], $ns->{nonces}[1]; + + $token eq $hash + or $cf::CFG{ext_login_nocheck} + or return $fail->("User exists, but the password doesn't match - check your spelling, NumLock/CapsLock etc."); + + # player exists and passwords match - we can proceed + + $reply->(1, "Success"); + + $pl->connect ($ns); + enter_map $pl; + login $pl; + }); +}; + +cf::register_command password => sub { + my ($pl, $arg) = @_; + + unless ($pl->flag (cf::FLAG_WIZ)) { + $pl->message ( + "The password can currently only changed by a DM.", + cf::NDI_UNIQUE | cf::NDI_REPLY); + return; + } + + $pl->message (#d# + "Passwords cannot currently be changed.",#d# + cf::NDI_UNIQUE | cf::NDI_REPLY);#d# + return;#d# + + my (@args) = split /\s+/, $arg; + my ($player, $new_pw) = @args; + + if ($pl->flag (cf::FLAG_WIZ) && $player eq '') { + $pl->message ( + "Usage: password []", + cf::NDI_UNIQUE | cf::NDI_REPLY); + return; + } + + if ($new_pw eq '') { + $new_pw = + join '', + map { ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64)] } + 1..9; + } + + cf::async { + my $plc = cf::player::find $player; + if ($plc) { + $plc->password (encode_password $new_pw); + $pl->message ( + "Ok, changed password of '$player' to '$new_pw'!", + cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY); + } else { + $pl->message ( + "Fail! Couldn't set password for '$player', " + . "he doesn't seem to exist!", + cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY); + } + }; +}; cf::register_command quit => sub { my ($ob, $arg) = @_; - $ob->reply (undef, - "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. " - . "If you are sure you want to do this, then use the quit_character command instead of quit.", - cf::NDI_UNIQUE | cf::NDI_RED); + $ob->send_msg (undef, + "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. " + . "If you are sure you want to do this, then use the quit_character command instead of quit.", + cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY); }; cf::register_command quit_character => sub { @@ -274,15 +577,12 @@ $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub { if ($_[0] !~ /^[yY]/) { - $ob->reply (undef, - "Ok, not not quitting then.", - cf::NDI_UNIQUE | cf::NDI_RED); + $ob->send_msg (undef, "Ok, not not quitting then.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY); } else { - $ob->reply (undef, - "Ok, quitting, hope to see you again.", - cf::NDI_UNIQUE | cf::NDI_RED); - $pl->ns->flush; - $pl->quit_character; + $ob->send_msg (undef, "Ok, quitting, hope to see you again.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY); + cf::async { + $pl->quit_character; + }; } }); }; @@ -299,20 +599,25 @@ # update respawn position $pl->savebed ($bed->map->path, $bed->x, $bed->y); - $pl->killer ("left"); - $ob->check_score; - - $ob->reply (undef, "In the future, you will wake up here when you die."); - - $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { - if ($_[0] !~ /^[yY]/) { - $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1); - $pl->deactivate; - $pl->ns->destroy; - } else { - cf::async { $pl->save }; - } - }); + cf::async { + my $killer = cf::arch::get "killer_logout"; $pl->killer ($killer); $killer->destroy; + ext::highscore::check $ob; + + $pl->save; + + $ob->send_msg ($cf::SAY_CHANNEL => "In the future, you will wake up here when you die.", cf::NDI_DEF | cf::NDI_REPLY); + + my $ns = $pl->ns + or return; + + $ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { + if ($_[0] !~ /^[yY]/) { + $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1); + $pl->deactivate; + $pl->ns->destroy; + } + }); + }; }, ); @@ -331,68 +636,9 @@ $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; } else { $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; - delete $pl->{clean_save}; + $pl->{unclean_save} = $cf::RUNTIME + unless safe_spot $pl; } }, ); -cf::client->attach ( - on_addme => \&addme, -); - -############################################################################# - -our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs -our $SAVE_TIMEOUT = 200; # save players every n seconds -our $SAVE_INTERVAL = 0.1; # save at max. one player every $SAVE_INTERVAL - -our $SCHEDULER = cf::async_ext { - while () { - Coro::Timer::sleep $SCHEDULE_INTERVAL; - - # this weird form of iteration over values is used because - # the hash changes underneath us frequently, and for - # keeps a direct reference to the value without (in 5.8 perls) - # keeping a reference, so this is prone to crashes or worse. - my @players = keys %cf::PLAYER; - for (@players) { - my $pl = $cf::PLAYER{$_} - or next; - $pl->valid or next; - - eval { - if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) { - $pl->save; - Coro::Timer::sleep $SAVE_INTERVAL; - } - - unless ($pl->active) { - # check refcounts, this is tricky and needs to be adjusted to fit server internals - my $ob = $pl->ob; - Scalar::Util::weaken $pl; - Scalar::Util::weaken $ob; - my $a_ = $pl->refcnt; - my $b_ = $ob->refcnt; - my $pl_ref = $pl->refcnt_cnt; - my $ob_ref = $ob->refcnt_cnt; - - if ($pl_ref == 2 && $ob_ref == 1) { - warn "player-scheduler destroy ", $ob->name;#d# - delete $cf::PLAYER{$ob->name}; - # pl_ref == one from object + one from cf::PLAYER - # ob_ref == one from simply being an object - $ob->destroy; - $pl->destroy; - } else { - warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d# - } - } - }; - warn $@ if $@; - Coro::cede; - }; - } -}; - -$SCHEDULER->prio (1); -