--- deliantra/server/ext/login.ext 2007/01/08 19:25:53 1.19 +++ deliantra/server/ext/login.ext 2007/04/03 00:21:37 1.34 @@ -1,9 +1,10 @@ -#! perl +#! perl # MANDATORY # login handling use Fcntl; use Coro::AIO; +use List::Util qw(min max); my $PLAYERDIR = sprintf "%s/%s", cf::localdir, cf::playerdir; @@ -57,7 +58,13 @@ sub check_clean_save { my ($pl) = @_; - unless (delete $pl->{clean_save}) { + if (my $time = delete $pl->{unclean_save}) { + $pl->ns->send_drawinfo ( + "You didn't use a savebed to leave this realm. This is very dangerous, " + . "as lots of things could happen when you leave by other means, such as cave-ins, " + . "or monsters suddenly snapping your body. Better use a savebed next time.", + cf::NDI_RED + ); #d#TODO } } @@ -73,10 +80,153 @@ . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)"; } +sub setup { + my ($ns, $args) = @_; + + # run through the cmds of setup + # syntax is setup ... + # + # we send the status of the cmd back, or a FALSE is the cmd is the server unknown + # The client then must sort this out + + my %setup = split / +/, $args; + while (my ($k, $v) = each %setup) { + + if ($k eq "sound") { + $ns->sound ($v); + + } elsif ($k eq "exp64") { + $setup{$k} = 1; + + } elsif ($k eq "spellmon") { + $ns->monitor_spells ($v); + + } elsif ($k eq "darkness") { + $ns->darkness ($v); + + } elsif ($k eq "map1cmd") { + $ns->mapmode (cf::Map1Cmd) if $v > 0; + + } elsif ($k eq "map1acmd") { + $ns->mapmode (cf::Map1aCmd) if $v > 0; + + } elsif ($k eq "map2cmd") { + # gcfclient bug, map1acmd is sent too late + $ns->mapmode (cf::Map1aCmd); + $setup{$k} = "FALSE"; + + } elsif ($k eq "newmapcmd") { + $ns->newmapcmd ($v); + + } elsif ($k eq "mapinfocmd") { + $ns->mapinfocmd ($v); + + } elsif ($k eq "extcmd") { + $ns->extcmd ($v > 0); + + } elsif ($k eq "extmap") { + $ns->extmap ($v); + + } elsif ($k eq "facecache") { + $ns->facecache ($v); + + } elsif ($k eq "faceset") { + $ns->faceset (0); + $setup{$k} = 0; + # $ns->image2 (1) + + } elsif ($k eq "itemcmd") { + # Version of the item protocol command to use. Currently, + # only supported versions are 1 and 2. Using a numeric + # value will make it very easy to extend this in the future. + $ns->itemcmd ($v) if $v >= 1 && $v <= 2; + + $setup{$k} = $ns->itemcmd; + + } elsif ($k eq "mapsize") { + my ($x, $y) = split /x/, $v; + + $ns->mapx ($x = max 9, min cf::MAP_CLIENT_X, $x); + $ns->mapy ($y = max 9, min cf::MAP_CLIENT_Y, $y); + + $setup{$k} = "${x}x${y}"; + + } elsif ($k eq "extendedMapInfos") { + $ns->ext_mapinfos ($v); + + } elsif ($k eq "extendedTextInfos") { + $ns->has_readable_type ($v); + + } elsif ($k eq "fxix") { + $ns->fxix ($v); + + } else { + # other commands: + # sexp: no idea, probably for oudated servers + # tick: more stupidity, server should sned a tick per tick + + $setup{$k} = "FALSE"; + } + } + + $ns->send_packet (join " ", setup => %setup); + + cf::datalog setup => + request => $args, + reply => \%setup, + client => $ns->version, + ; +} + sub addme { my ($ns) = @_; - $ns->destroy if $ns->pl; + if (!$ns->facecache) + { + $ns->send_drawinfo (<Configure=>Map & Image=>Cache Images. +*** jcrossclient: your client is broken, use CFPlus or gcfclient. +*** +*** +EOF + if ($ns->version =~ /jcrossclient/) { + # let them, for now + } else { + $ns->flush; + return $ns->destroy; + } + + # $ns->facecache = true; + } + + if ($ns->mapmode < cf::Map1aCmd) { + $ns->send_drawinfo (<flush; + return $ns->destroy; + } + + $ns->pl and return $ns->destroy; $ns->async (sub { my ($user, $pass); @@ -101,7 +251,7 @@ . "Chose another, or wait till the other session has ended.", cf::NDI_RED ); - } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}$/) { + } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}\z/) { last; } else { $ns->send_drawinfo ( @@ -158,7 +308,6 @@ my $pl = cf::player::find $user or next; $pl->connect ($ns); check_clean_save $pl; - $pl->{clean_save} = 1; last; } elsif (can_cleanup $pl, $mtime) { Coro::Timer::sleep 1; @@ -280,7 +429,7 @@ "Ok, quitting, hope to see you again.", cf::NDI_UNIQUE | cf::NDI_RED); $pl->ns->flush; - $pl->quit_character; + cf::async { $pl->quit_character }; } }); }; @@ -296,6 +445,7 @@ # update respawn position $pl->savebed ($bed->map->path, $bed->x, $bed->y); + cf::async { $pl->save }; $pl->killer ("left"); $ob->check_score; @@ -329,24 +479,25 @@ $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; } else { $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; - delete $pl->{clean_save}; + $pl->{unclean_save} = $cf::RUNTIME; } }, ); cf::client->attach ( on_addme => \&addme, + on_setup => \&setup, ); ############################################################################# -our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs -our $SAVE_TIMEOUT = 200; # save players every n seconds -our $SAVE_INTERVAL = 0.1; # save at max. one player every $SAVE_INTERVAL +our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs +our $SAVE_TIMEOUT = 20; # save players every n seconds our $SCHEDULER = cf::async_ext { + my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL); while () { - Coro::Timer::sleep $SCHEDULE_INTERVAL; + $schedule_interval->next; # this weird form of iteration over values is used because # the hash changes underneath us frequently, and for @@ -360,29 +511,33 @@ eval { if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) { + $cf::WAIT_FOR_TICK_ONE->wait; $pl->save; - Coro::Timer::sleep $SAVE_INTERVAL; - } - unless ($pl->active) { - # check refcounts, this is tricky and needs to be adjusted to fit server internals - my $ob = $pl->ob; - Scalar::Util::weaken $pl; - Scalar::Util::weaken $ob; - my $a_ = $pl->refcnt; - my $b_ = $ob->refcnt; - my $pl_ref = $pl->refcnt_cnt; - my $ob_ref = $ob->refcnt_cnt; - - if ($pl_ref == 2 && $ob_ref == 1) { - warn "player-scheduler destroy ", $ob->name;#d# - delete $cf::PLAYER{$ob->name}; - # pl_ref == one from object + one from cf::PLAYER - # ob_ref == one from simply being an object - $ob->destroy; - $pl->destroy; - } else { - warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d# + unless ($pl->active) { + # check refcounts, this is tricky and needs to be adjusted to fit server internals + my $ob = $pl->ob; + Scalar::Util::weaken $pl; + Scalar::Util::weaken $ob; + my $a_ = $pl->refcnt;#d# + my $b_ = $ob->refcnt;#d# + my $pl_ref = $pl->refcnt_cnt; + my $ob_ref = $ob->refcnt_cnt; + + ## pl_ref == one from object + one from cf::PLAYER + ## ob_ref == one from simply being an object + if ($pl_ref == 2 && $ob_ref == 1) { + warn "player-scheduler destroy ", $ob->name;#d# + + # remove from sight and get fresh "copies" + $pl = delete $cf::PLAYER{$ob->name}; + $ob = $pl->ob; + + $ob->destroy; + $pl->destroy; + } else { + warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d# + } } } };