ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.20 by root, Mon Jan 8 22:32:10 2007 UTC vs.
Revision 1.110 by root, Sat May 8 10:49:44 2010 UTC

1#! perl 1#! perl # mandatory depends=highscore
2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7 7
8my $PLAYERDIR = sprintf "%s/%s", cf::localdir, cf::playerdir; 8our $MAX_DISCONNECT_TIME = $cf::CFG{max_disconnect_time} || 3600;
9 9
10# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
11sub nuke_str { 11sub nuke_str {
12 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
13} 13}
14 14
15sub query { 15sub query {
16 my ($ns, $flags, $text) = @_; 16 my ($ns, $flags, $text) = @_;
17 17
18 my $current = $Coro::current; 18 $ns->query ($flags, $text, Coro::rouse_cb);
19 $ns->query ($flags, $text, sub { $current->ready; $current = $_[0]; }); 19 Coro::rouse_wait
20 Coro::schedule while ref $current;
21
22 $current
23} 20}
24 21
25sub can_cleanup { 22sub can_cleanup {
26 my ($pl, $mtime) = @_; 23 my ($pl, $mtime) = @_;
27 24
… …
40 return unless cf::player::find_active $user; 37 return unless cf::player::find_active $user;
41 38
42 $ns->send_drawinfo ( 39 $ns->send_drawinfo (
43 "That player is already logged in on this server. " 40 "That player is already logged in on this server. "
44 . "If you want to create a new player, choose another name. " 41 . "If you want to create a new player, choose another name. "
45 . "If you are already a registered player, make sure nobody " 42 . "If you have already a registered, make sure nobody "
46 . "else is using your account at this time. If you lost your conenction " 43 . "else is using your account at this time. If you lost your connection "
47 . "then the server will likely timeout within a minute. If you still " 44 . "then the server will likely timeout within a minute. If you still "
48 . "cannot log-in after a minute, you are still logged in. Make sure " 45 . "cannot log-in after a minute, you are still logged in. Make sure "
49 . "you do not have another client running. If you use windows, reboot, " 46 . "you do not have another client running. If you use windows, reboot, "
50 . "this will fix anything.", 47 . "this will fix anything.",
51 cf::NDI_RED 48 cf::NDI_RED
52 ); 49 );
53 50
54 1 51 1
55} 52}
56 53
57sub check_clean_save { 54sub safe_spot($) {
58 my ($pl) = @_; 55 my ($pl) = @_;
56
57 my $ob = $pl->ob;
59 58
60 unless (delete $pl->{clean_save}) { 59 my $m = $ob->map
61 #d#TODO 60 or return;
61 my $x = $ob->x;
62 my $y = $ob->y;
63
64# return 0;#d#
65# warn join ":", $m->at ($x, $y);#d#
66# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
67# return 0;
68
69 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
70}
71
72sub enter_map {
73 my ($pl) = @_;
74
75 my $ob = $pl->ob;
76
77 my ($map, $x, $y)
78 = $ob->{_link_pos}
79 ? @{delete $ob->{_link_pos}}
80 : ($pl->maplevel, $ob->x, $ob->y);
81
82 $ob->enter_link;
83
84 my $m = cf::map::find $map;
85 my $time = delete $pl->{unclean_save};
86
87 if ($time && $m) {
88 if ($time < $m->{instantiate_time}) {
89 # the map was reset in the meantime
90 my $age = $cf::RUNTIME - $time;
91
92 cf::info $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
93
94 if ($age >= $MAX_DISCONNECT_TIME) {
95 $ob->message (
96 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
97 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
98 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
99 . "H<You disconnected too long without having used a savebed.>",
100 cf::NDI_RED
101 );
102 # kill them.
103 # reminds me of the famous badness 10000 syndrome...
104 $ob->stats->hp (-10000); #] if they survive this they deserved to live
105 my $killer = cf::arch::get "killer_login"; $pl->killer ($killer); $killer->destroy;
106 } else {
107 ($map, $x, $y) = $pl->savebed;
108
109 $ob->message (
110 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
111 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
112 . "Better use a savebed next time, much worse things could have happened... "
113 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
114 cf::NDI_RED
115 );
116 }
117 } else {
118 $ob->message (
119 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
120 . "as lots of things could happen when you leave by other means, such as cave-ins, "
121 . "or monsters suddenly snapping your body. Better use a savebed next time. "
122 . "H<Always apply a bed of reality to disconnect from the server.>",
123 cf::NDI_RED
124 );
125 }
62 } 126 }
127
128 $ob->goto ($map, $x, $y);
129}
130
131sub encode_password($) {
132# crypt $_[0],
133# join '',
134# ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64), (cf::rndm 64)]
135 "!" . unpack "H*", $_[0]
136}
137
138sub compare_password($$) {
139 my ($pass, $token) = @_;
140
141 if ($token =~ /\!(.*)/) {
142 return $pass eq pack "H*", $1;
143 } else {
144 return $token eq crypt $pass, $token;
145 }
63} 146}
64 147
65# delete a player directory, be non-blocking AND synchronous... 148# delete a player directory, be non-blocking AND synchronous...
66# (thats hard, so we crap out and fork). 149# (that's hard, so we crap out and fork).
67sub nuke_playerdir { 150sub nuke_playerdir {
68 my ($user) = @_; 151 my ($user) = @_;
69 152
70 aio_stat "$PLAYERDIR/$user"; 153 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
71 system "cd \Q$PLAYERDIR\E "
72 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null "
73 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)";
74}
75 154
76sub addme { 155 cf::fork_call {
156 rename "$PLAYERDIR/$user", $temp;
157 system "rm", "-rf", $temp;
158 };
159}
160
161cf::client->attach (on_addme => sub {
77 my ($ns) = @_; 162 my ($ns) = @_;
78 163
79 $ns->destroy if $ns->pl; 164 $ns->pl and return $ns->destroy;
80 165
81 $ns->async (sub { 166 $ns->async (sub {
167 $Coro::current->{desc} = "addme init";
168
82 my ($user, $pass); 169 my ($user, $pass);
83 170
84 $ns->send_packet ("addme_success"); 171 $ns->send_packet ("addme_success");
85 172
86 for (;;) { 173 for (;;) {
… …
91 cf::NDI_BLUE 178 cf::NDI_BLUE
92 ); 179 );
93 180
94 # read username 181 # read username
95 while () { 182 while () {
96 $user = query $ns, 0, "What is your name?\n:"; 183 $user = query $ns, 0, "What is your name? (login names are case-sensitive)\n:";
97 184
98 if ($cf::LOGIN_LOCK{$user}) { 185 if ($cf::LOGIN_LOCK{$user}) {
99 $ns->send_drawinfo ( 186 $ns->send_drawinfo (
100 "That username is currently used in another login session. " 187 "That username is currently used in another login session. "
101 . "Chose another, or wait till the other session has ended.", 188 . "Chose another, or wait till the other session has ended.",
102 cf::NDI_RED 189 cf::NDI_RED
103 ); 190 );
104 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}$/) { 191 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,19}\z/) {
105 last; 192 last;
106 } else { 193 } else {
107 $ns->send_drawinfo ( 194 $ns->send_drawinfo (
108 "Your username contains illegal characters " 195 "Your username contains illegal characters "
109 . "(only a-z, A-Z and 0-9 are allowed), " 196 . "(only a-z, A-Z and 0-9 are allowed), "
110 . "or is not between 3 and 18 characters in length.", 197 . "or is not between 3 and 20 characters in length.",
111 cf::NDI_RED 198 cf::NDI_RED
112 ); 199 );
113 } 200 }
201 Coro::Timer::sleep 0.4;
114 } 202 }
115 203
116 check_playing $ns, $user and next; 204 check_playing $ns, $user and next;
205
206 $Coro::current->{desc} = "addme($user) pass";
117 207
118 $ns->send_drawinfo ( 208 $ns->send_drawinfo (
119 "Welcome $user, please enter your password now. " 209 "Welcome $user, please enter your password now. "
120 . "New users should now choose a password. " 210 . "New users should now choose a password. "
121 . "Anything your client lets you enter is fine.", 211 . "Anything your client lets you enter is fine.",
… …
129 $ns->send_drawinfo ( 219 $ns->send_drawinfo (
130 "Try to use at least three characters as your password please, " 220 "Try to use at least three characters as your password please, "
131 . "that cannot be too much to ask for :)", 221 . "that cannot be too much to ask for :)",
132 cf::NDI_RED 222 cf::NDI_RED
133 ); 223 );
224 Coro::Timer::sleep 0.4;
134 } 225 }
135 226
136 # lock this username for the remainder of this login session 227 # lock this username for the remainder of this login session
137 if ($cf::LOGIN_LOCK{$user}) { 228 if ($cf::LOGIN_LOCK{$user}) {
138 $ns->send_drawinfo ( 229 $ns->send_drawinfo (
… …
144 } 235 }
145 local $cf::LOGIN_LOCK{$user} = 1; 236 local $cf::LOGIN_LOCK{$user} = 1;
146 237
147 check_playing $ns, $user and next; 238 check_playing $ns, $user and next;
148 239
240 $Coro::current->{desc} = "addme($user) check";
241
149 # try to read the user file and check the password 242 # try to read the user file and check the password
150 if (my $pl = cf::player::find $user) { 243 if (my $pl = cf::player::find $user) {
151 aio_stat $pl->path and next; 244 aio_stat $pl->path and next;
152 my $mtime = (stat _)[9]; 245 my $mtime = (stat _)[9];
153 my $hash = $pl->password; 246 my $token = $pl->password;
154 247
155 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) { 248 if ($cf::CFG{ext_login_nocheck} or compare_password $pass, $token) {
249 $pl->password (encode_password $pass); # make sure we store the new encoding #d#
156 nuke_str $pass; 250 nuke_str $pass;
157 # password matches, wonderful 251 # password matches, wonderful
158 my $pl = cf::player::find $user or next; 252 my $pl = cf::player::find $user or next;
159 $pl->connect ($ns); 253 $pl->connect ($ns);
160 check_clean_save $pl; 254 enter_map $pl;
161 $pl->{clean_save} = 1;
162 last; 255 last;
163 } elsif (can_cleanup $pl, $mtime) { 256 } elsif (can_cleanup $pl, $mtime) {
164 Coro::Timer::sleep 1; 257 Coro::Timer::sleep 1;
165 258
166 $ns->send_drawinfo ( 259 $ns->send_drawinfo (
… …
191 . "(check for Numlock and other semi-obvious error sources).", 284 . "(check for Numlock and other semi-obvious error sources).",
192 cf::NDI_RED 285 cf::NDI_RED
193 ); 286 );
194 next; 287 next;
195 } 288 }
289 } else {
290 # unable to load the playerfile:
291 # check wether the player dir exists, which means the file is corrupted or
292 # something very similar.
293 if (!aio_stat cf::player::playerdir $user) {
294 $ns->send_drawinfo (
295 "Unable to retrieve this player. It might be a locked or broken account. "
296 . "If this is your account, ask a dungeon master for assistance. "
297 . "Otherwise choose a different login name.",
298 cf::NDI_RED
299 );
300 next;
301 }
196 } 302 }
197 303
198 # the rest of this function is character creation 304 # the rest of this function is character creation
305 $Coro::current->{desc} = "addme($user) chargen";
199 306
200 # just to make sure nothing is left over 307 # just to make sure nothing is left over
201 nuke_playerdir $user; 308 nuke_playerdir $user;
202 309
203 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 310 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
… …
207 nuke_str $pass2; 314 nuke_str $pass2;
208 $ns->send_drawinfo ( 315 $ns->send_drawinfo (
209 "The passwords do not match, please try again.", 316 "The passwords do not match, please try again.",
210 cf::NDI_RED 317 cf::NDI_RED
211 ); 318 );
319 Coro::Timer::sleep 0.5;
212 next; 320 next;
213 } 321 }
214 322
215 nuke_str $pass2; 323 nuke_str $pass2;
216 324
217 my $pl = cf::player::new $user; 325 my $pl = cf::player::new $user;
218 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); 326 $pl->password (encode_password $pass);
219 nuke_str $pass; 327 nuke_str $pass;
220 $pl->connect ($ns); 328 $pl->connect ($ns);
221
222 my $ob = $pl->ob; 329 my $ob = $pl->ob;
330
331 $ob->goto ($pl->maplevel, $ob->x, $ob->y);
223 332
224 while () { 333 while () {
225 $ob->update_stats; 334 $ob->update_stats;
226 $pl->save_stats; 335 $pl->save_stats;
227 336
… …
237 $ob->swap_stats ($res - 1, $swap - 1); 346 $ob->swap_stats ($res - 1, $swap - 1);
238 } 347 }
239 } else { 348 } else {
240 $ob->roll_stats; 349 $ob->roll_stats;
241 } 350 }
351
352 Coro::Timer::sleep 0.05;
242 } 353 }
243 354
244 $ob->set_animation (2); 355 $ob->set_animation (2);
245 $ob->add_statbonus; 356 $ob->add_statbonus;
246 357
247 $ns->send_drawinfo ($ob->msg, cf::NDI_BLUE); 358 while () {
248 $ns->send_packet (sprintf "query %d %s", cf::CS_QUERY_SINGLECHAR, 359 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
360 my $msg = $ob->msg;
361 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
362 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
363
364 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
249 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"); 365 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
250 366
251 $ns->state (cf::ST_CHANGE_CLASS); 367 last if $res =~ /[dD]/;
368
369 $pl->chargen_race_next;
370 Coro::Timer::sleep 0.05;
371 }
372
373 # create the playerdir, if necessary, as chargen_race_done did it before
374 # presumably because of unique maps
375 aio_mkdir playerdir $pl, 0770;
376 $pl->chargen_race_done;
377
378 while () {
379 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
380 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
381
382 if ($res =~ /^[fF]/) {
383 $pl->gender (1);
384 last;
385 } elsif ($res =~ /^[mM]/) {
386 $pl->gender (0);
387 last;
388 }
389 Coro::Timer::sleep 0.05;
390 }
391
392 $ob->reply (undef, "Welcome to Deliantra!");
393
394 # XXX: Workaround for delayed client ext protocol handshake
395 $pl->esrv_new_player;
396
252 delete $pl->{deny_save};#d# too early 397 delete $pl->{deny_save};
253 398
254 last; 399 last;
255 } 400 }
401
402 if (0 < Coro::AIO::aio_load "$cf::CONFDIR/motd", my $motd) {
403 $ns->send_msg ("c/motd" => $motd, cf::NDI_CLEAR);
404 }
256 }); 405 });
257} 406});
407
408cf::register_command password => sub {
409 my ($pl, $arg) = @_;
410
411 my (@args) = split /\s+/, $arg;
412
413 my ($new_pw, $player);
414
415 if ($pl->flag (cf::FLAG_WIZ)) {
416 ($player, $new_pw) = @args;
417 } else {
418 $new_pw = $args[0];
419 }
420
421 if ($pl->flag (cf::FLAG_WIZ) && $player eq '') {
422 $pl->message (
423 "Usage: password <player> [<new password>]",
424 cf::NDI_UNIQUE | cf::NDI_REPLY);
425 return;
426 } elsif (!$pl->flag (cf::FLAG_WIZ) && $new_pw eq '') {
427 $pl->message (
428 "Usage: password <new password>",
429 cf::NDI_UNIQUE | cf::NDI_REPLY);
430 return;
431 }
432
433 if ($player ne '' && $pl->flag (cf::FLAG_WIZ)) {
434 unless ($new_pw ne '') {
435 $new_pw =
436 join '',
437 map { ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64)] }
438 1..9;
439 }
440
441 cf::async {
442 my $plc = cf::player::find $player;
443 if ($plc) {
444 $plc->password (encode_password $new_pw);
445 $pl->message (
446 "Ok, changed password of '$player' to '$new_pw'!",
447 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
448 } else {
449 $pl->message (
450 "Fail! Couldn't set password for '$player', "
451 . "he doesn't seem to exist!",
452 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
453 }
454 };
455 } else {
456 my $change = delete $pl->{password_change};
457
458 if ($change && (time - $change->[0]) < 60) {
459 $pl->message (
460 "Ok, changed your password!",
461 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
462 $pl->contr->password (encode_password $new_pw);
463
464 } else {
465 $pl->message (
466 "Ok, please confirm your new password by sending "
467 . "the command again within one minute!",
468 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
469 $pl->{password_change} = [time, $new_pw];
470 }
471 }
472};
258 473
259cf::register_command quit => sub { 474cf::register_command quit => sub {
260 my ($ob, $arg) = @_; 475 my ($ob, $arg) = @_;
261 476
262 $ob->reply (undef, 477 $ob->send_msg (undef,
263 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. " 478 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. "
264 . "If you are sure you want to do this, then use the quit_character command instead of quit.", 479 . "If you are sure you want to do this, then use the quit_character command instead of quit.",
265 cf::NDI_UNIQUE | cf::NDI_RED); 480 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
266}; 481};
267 482
268cf::register_command quit_character => sub { 483cf::register_command quit_character => sub {
269 my ($ob, $arg) = @_; 484 my ($ob, $arg) = @_;
270 485
271 my $pl = $ob->contr; 486 my $pl = $ob->contr;
272 487
273 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub { 488 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub {
274 if ($_[0] !~ /^[yY]/) { 489 if ($_[0] !~ /^[yY]/) {
275 $ob->reply (undef, 490 $ob->send_msg (undef, "Ok, not not quitting then.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
276 "Ok, not not quitting then.",
277 cf::NDI_UNIQUE | cf::NDI_RED);
278 } else { 491 } else {
279 $ob->reply (undef, 492 $ob->send_msg (undef, "Ok, quitting, hope to see you again.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
280 "Ok, quitting, hope to see you again.",
281 cf::NDI_UNIQUE | cf::NDI_RED);
282 $pl->ns->flush; 493 $pl->ns->flush;
494 cf::async {
495 ext::highscore::check $pl->ob;
283 $pl->quit_character; 496 $pl->quit_character;
497 };
284 } 498 }
285 }); 499 });
286}; 500};
287 501
288cf::object->attach ( 502cf::object->attach (
… …
294 508
295 my $pl = $ob->contr; 509 my $pl = $ob->contr;
296 510
297 # update respawn position 511 # update respawn position
298 $pl->savebed ($bed->map->path, $bed->x, $bed->y); 512 $pl->savebed ($bed->map->path, $bed->x, $bed->y);
513 cf::async { $pl->save };
299 514
300 $pl->killer ("left"); 515 my $killer = cf::arch::get "killer_logout"; $pl->killer ($killer); $killer->destroy;
301 $ob->check_score; 516 ext::highscore::check $ob;
302 517
303 $ob->reply (undef, "In the future, you will wake up here when you die."); 518 $ob->send_msg ($cf::SAY_CHANNEL => "In the future, you will wake up here when you die.", cf::NDI_DEF | cf::NDI_REPLY);
304 519
305 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { 520 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub {
306 if ($_[0] !~ /^[yY]/) { 521 if ($_[0] !~ /^[yY]/) {
307 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1); 522 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1);
308 $pl->deactivate; 523 $pl->deactivate;
… …
327 542
328 if ($cleanly) { 543 if ($cleanly) {
329 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 544 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
330 } else { 545 } else {
331 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 546 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
332 delete $pl->{clean_save}; 547 $pl->{unclean_save} = $cf::RUNTIME
548 unless safe_spot $pl;
333 } 549 }
334 }, 550 },
335); 551);
336 552
337cf::client->attach (
338 on_addme => \&addme,
339);
340
341#############################################################################
342
343our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs
344our $SAVE_TIMEOUT = 200; # save players every n seconds
345our $SAVE_INTERVAL = 1.1; # save at max. one player every $SAVE_INTERVAL
346
347our $SCHEDULER = cf::async_ext {
348 while () {
349 Coro::Timer::sleep $SCHEDULE_INTERVAL;
350
351 # this weird form of iteration over values is used because
352 # the hash changes underneath us frequently, and for
353 # keeps a direct reference to the value without (in 5.8 perls)
354 # keeping a reference, so this is prone to crashes or worse.
355 my @players = keys %cf::PLAYER;
356 for (@players) {
357 my $pl = $cf::PLAYER{$_}
358 or next;
359 $pl->valid or next;
360
361 eval {
362 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
363 $pl->save;
364 Coro::Timer::sleep $SAVE_INTERVAL;
365 }
366
367 unless ($pl->active) {
368 # check refcounts, this is tricky and needs to be adjusted to fit server internals
369 my $ob = $pl->ob;
370 Scalar::Util::weaken $pl;
371 Scalar::Util::weaken $ob;
372 my $a_ = $pl->refcnt;
373 my $b_ = $ob->refcnt;
374 my $pl_ref = $pl->refcnt_cnt;
375 my $ob_ref = $ob->refcnt_cnt;
376
377 if ($pl_ref == 2 && $ob_ref == 1) {
378 warn "player-scheduler destroy ", $ob->name;#d#
379 #delete $cf::PLAYER{$ob->name};
380 ## pl_ref == one from object + one from cf::PLAYER
381 ## ob_ref == one from simply being an object
382 #$ob->destroy;
383 #$pl->destroy;
384 } else {
385 warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d#
386 }
387 }
388 };
389 warn $@ if $@;
390 Coro::cede;
391 };
392 }
393};
394
395$SCHEDULER->prio (1);
396

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines