ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.27 by root, Mon Jan 22 03:44:41 2007 UTC vs.
Revision 1.118 by root, Thu Nov 8 00:16:07 2012 UTC

1#! perl # MANDATORY 1#! perl # mandatory depends=highscore
2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7 7
8my $PLAYERDIR = sprintf "%s/%s", cf::localdir, cf::playerdir; 8CONF MAX_DISCONNECT_TIME = 3600;
9 9
10# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
11sub nuke_str { 11sub nuke_str {
12 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
13} 13}
14 14
15sub query { 15sub query {
16 my ($ns, $flags, $text) = @_; 16 my ($ns, $flags, $text) = @_;
17 17
18 my $current = $Coro::current; 18 $ns->query ($flags, $text, Coro::rouse_cb);
19 $ns->query ($flags, $text, sub { $current->ready; $current = $_[0]; }); 19 Coro::rouse_wait
20 Coro::schedule while ref $current;
21
22 $current
23} 20}
24 21
25sub can_cleanup { 22sub can_cleanup {
26 my ($pl, $mtime) = @_; 23 my ($pl, $mtime) = @_;
27 24
… …
40 return unless cf::player::find_active $user; 37 return unless cf::player::find_active $user;
41 38
42 $ns->send_drawinfo ( 39 $ns->send_drawinfo (
43 "That player is already logged in on this server. " 40 "That player is already logged in on this server. "
44 . "If you want to create a new player, choose another name. " 41 . "If you want to create a new player, choose another name. "
45 . "If you are already a registered player, make sure nobody " 42 . "If you have already a registered, make sure nobody "
46 . "else is using your account at this time. If you lost your conenction " 43 . "else is using your account at this time. If you lost your connection "
47 . "then the server will likely timeout within a minute. If you still " 44 . "then the server will likely timeout within a minute. If you still "
48 . "cannot log-in after a minute, you are still logged in. Make sure " 45 . "cannot log-in after a minute, you are still logged in. Make sure "
49 . "you do not have another client running. If you use windows, reboot, " 46 . "you do not have another client running. If you use windows, reboot, "
50 . "this will fix anything.", 47 . "this will fix anything.",
51 cf::NDI_RED 48 cf::NDI_RED
52 ); 49 );
53 50
54 1 51 1
55} 52}
56 53
57sub check_clean_save { 54sub safe_spot($) {
58 my ($pl) = @_; 55 my ($pl) = @_;
56
57 my $ob = $pl->ob;
59 58
59 my $m = $ob->map
60 or return;
61 my $x = $ob->x;
62 my $y = $ob->y;
63
64 # never happens normally, but helps when shell users make mistakes
65 $m->linkable
66 or return 1;
67
68# return 0;#d#
69# warn join ":", $m->at ($x, $y);#d#
70# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
71# return 0;
72
73 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
74}
75
76sub enter_map {
77 my ($pl) = @_;
78
79 my $ob = $pl->ob;
80
81 my ($map, $x, $y)
82 = $ob->{_link_pos}
83 ? @{delete $ob->{_link_pos}}
84 : ($pl->maplevel, $ob->x, $ob->y);
85
86 $ob->enter_link;
87
88 my $m = cf::map::find $map;
60 if (my $time = delete $pl->{unclean_save}) { 89 my $time = delete $pl->{unclean_save};
61 $pl->ns->send_drawinfo ( 90
91 if ($time && $m) {
92 if ($time < $m->{instantiate_time}) {
93 # the map was reset in the meantime
94 my $age = $cf::RUNTIME - $time;
95
96 cf::info $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
97
98 if ($age >= $MAX_DISCONNECT_TIME) {
99 $ob->message (
100 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
101 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
102 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
103 . "H<You disconnected too long without having used a savebed.>",
104 cf::NDI_RED
105 );
106 # kill them.
107 # reminds me of the famous badness 10000 syndrome...
108 $ob->stats->hp (-10000); #] if they survive this they deserved to live
109 my $killer = cf::arch::get "killer_login"; $pl->killer ($killer); $killer->destroy;
110 } else {
111 ($map, $x, $y) = $pl->savebed;
112
113 $ob->message (
114 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
115 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
116 . "Better use a savebed next time, much worse things could have happened... "
117 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
118 cf::NDI_RED
119 );
120 }
121 } else {
122 $ob->message (
62 "You didn't use a savebed to leave this realm. This is very dangerous, " 123 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
63 . "as lots of things could happen when you leave by other means, such as cave-ins, " 124 . "as lots of things could happen when you leave by other means, such as cave-ins, "
64 . "or monsters suddenly snapping your body. Better use a savebed next time.", 125 . "or monsters suddenly snapping your body. Better use a savebed next time. "
126 . "H<Always apply a bed of reality to disconnect from the server.>",
65 cf::NDI_RED 127 cf::NDI_RED
66 ); 128 );
67 #d#TODO 129 }
68 } 130 }
69}
70 131
71# delete a player directory, be non-blocking AND synchronous... 132 $ob->goto ($map, $x, $y);
72# (thats hard, so we crap out and fork). 133}
134
135sub encode_password($) {
136# crypt $_[0],
137# join '',
138# ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64), (cf::rndm 64)]
139 "!" . unpack "H*", $_[0]
140}
141
142sub compare_password($$) {
143 my ($pass, $token) = @_;
144
145 if ($token =~ /!!(.*)/) {
146 return +(substr $pass, 0, 8) eq pack "H*", $1;
147 } elsif ($token =~ /!(.*)/) {
148 return $pass eq pack "H*", $1;
149 } else {
150 return $token eq crypt $pass, $token;
151 }
152}
153
154# delete a player directory
73sub nuke_playerdir { 155sub nuke_playerdir {
74 my ($user) = @_; 156 my ($user) = @_;
75 157
158 my $lock = cf::lock_acquire "ext::login::nuke_playerdir";
159
160 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
76 aio_stat "$PLAYERDIR/$user"; 161 aio_rename "$PLAYERDIR/$user", $temp;
77 system "cd \Q$PLAYERDIR\E " 162 IO::AIO::aio_rmtree $temp;
78 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null "
79 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)";
80} 163}
81 164
82sub addme { 165cf::client->attach (on_addme => sub {
83 my ($ns) = @_; 166 my ($ns) = @_;
84 167
85 $ns->destroy if $ns->pl; 168 $ns->pl and return $ns->destroy;
86 169
87 $ns->async (sub { 170 $ns->async (sub {
171 $Coro::current->{desc} = "addme init";
172
88 my ($user, $pass); 173 my ($user, $pass);
89 174
90 $ns->send_packet ("addme_success"); 175 $ns->send_packet ("addme_success");
91 176
92 for (;;) { 177 for (;;) {
… …
97 cf::NDI_BLUE 182 cf::NDI_BLUE
98 ); 183 );
99 184
100 # read username 185 # read username
101 while () { 186 while () {
102 $user = query $ns, 0, "What is your name?\n:"; 187 $user = query $ns, 0, "What is your name? (login names are case-sensitive)\n:";
103 188
104 if ($cf::LOGIN_LOCK{$user}) { 189 if ($cf::LOGIN_LOCK{$user}) {
105 $ns->send_drawinfo ( 190 $ns->send_drawinfo (
106 "That username is currently used in another login session. " 191 "That username is currently used in another login session. "
107 . "Chose another, or wait till the other session has ended.", 192 . "Chose another, or wait till the other session has ended.",
108 cf::NDI_RED 193 cf::NDI_RED
109 ); 194 );
110 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}$/) { 195 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,19}\z/) {
111 last; 196 last;
112 } else { 197 } else {
113 $ns->send_drawinfo ( 198 $ns->send_drawinfo (
114 "Your username contains illegal characters " 199 "Your username contains illegal characters "
115 . "(only a-z, A-Z and 0-9 are allowed), " 200 . "(only a-z, A-Z and 0-9 are allowed), "
116 . "or is not between 3 and 18 characters in length.", 201 . "or is not between 3 and 20 characters in length.",
117 cf::NDI_RED 202 cf::NDI_RED
118 ); 203 );
119 } 204 }
205 Coro::Timer::sleep 0.4;
120 } 206 }
121 207
122 check_playing $ns, $user and next; 208 check_playing $ns, $user and next;
209
210 $Coro::current->{desc} = "addme($user) pass";
123 211
124 $ns->send_drawinfo ( 212 $ns->send_drawinfo (
125 "Welcome $user, please enter your password now. " 213 "Welcome $user, please enter your password now. "
126 . "New users should now choose a password. " 214 . "New users should now choose a password. "
127 . "Anything your client lets you enter is fine.", 215 . "Anything your client lets you enter is fine.",
… …
135 $ns->send_drawinfo ( 223 $ns->send_drawinfo (
136 "Try to use at least three characters as your password please, " 224 "Try to use at least three characters as your password please, "
137 . "that cannot be too much to ask for :)", 225 . "that cannot be too much to ask for :)",
138 cf::NDI_RED 226 cf::NDI_RED
139 ); 227 );
228 Coro::Timer::sleep 0.4;
140 } 229 }
141 230
142 # lock this username for the remainder of this login session 231 # lock this username for the remainder of this login session
143 if ($cf::LOGIN_LOCK{$user}) { 232 if ($cf::LOGIN_LOCK{$user}) {
144 $ns->send_drawinfo ( 233 $ns->send_drawinfo (
… …
150 } 239 }
151 local $cf::LOGIN_LOCK{$user} = 1; 240 local $cf::LOGIN_LOCK{$user} = 1;
152 241
153 check_playing $ns, $user and next; 242 check_playing $ns, $user and next;
154 243
244 $Coro::current->{desc} = "addme($user) check";
245
155 # try to read the user file and check the password 246 # try to read the user file and check the password
156 if (my $pl = cf::player::find $user) { 247 if (my $pl = cf::player::find $user) {
157 aio_stat $pl->path and next; 248 aio_stat $pl->path and next;
158 my $mtime = (stat _)[9]; 249 my $mtime = (stat _)[9];
159 my $hash = $pl->password; 250 my $token = $pl->password;
160 251
161 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) { 252 if ($cf::CFG{ext_login_nocheck} or compare_password $pass, $token) {
253 $pl->password (encode_password $pass); # make sure we store the new encoding #d#
162 nuke_str $pass; 254 nuke_str $pass;
163 # password matches, wonderful 255 # password matches, wonderful
164 my $pl = cf::player::find $user or next; 256 my $pl = cf::player::find $user or next;
165 $pl->connect ($ns); 257 $pl->connect ($ns);
166 check_clean_save $pl; 258 enter_map $pl;
167 last; 259 last;
168 } elsif (can_cleanup $pl, $mtime) { 260 } elsif (can_cleanup $pl, $mtime) {
169 Coro::Timer::sleep 1; 261 Coro::Timer::sleep 1;
170 262
171 $ns->send_drawinfo ( 263 $ns->send_drawinfo (
… …
196 . "(check for Numlock and other semi-obvious error sources).", 288 . "(check for Numlock and other semi-obvious error sources).",
197 cf::NDI_RED 289 cf::NDI_RED
198 ); 290 );
199 next; 291 next;
200 } 292 }
293 } else {
294 # unable to load the playerfile:
295 # check whether the player dir exists, which means the file is corrupted or
296 # something very similar.
297 if (!aio_stat cf::player::playerdir $user) {
298 $ns->send_drawinfo (
299 "Unable to retrieve this player. It might be a locked or broken account. "
300 . "If this is your account, ask a dungeon master for assistance. "
301 . "Otherwise choose a different login name.",
302 cf::NDI_RED
303 );
304 next;
305 }
201 } 306 }
202 307
203 # the rest of this function is character creation 308 # the rest of this function is character creation
309 $Coro::current->{desc} = "addme($user) chargen";
204 310
205 # just to make sure nothing is left over 311 # just to make sure nothing is left over
312 # normally, nothing is there.
206 nuke_playerdir $user; 313 nuke_playerdir $user;
207 314
208 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 315 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
209 316
210 if ($pass2 ne $pass) { 317 if ($pass2 ne $pass) {
… …
212 nuke_str $pass2; 319 nuke_str $pass2;
213 $ns->send_drawinfo ( 320 $ns->send_drawinfo (
214 "The passwords do not match, please try again.", 321 "The passwords do not match, please try again.",
215 cf::NDI_RED 322 cf::NDI_RED
216 ); 323 );
324 Coro::Timer::sleep 0.5;
217 next; 325 next;
218 } 326 }
219 327
220 nuke_str $pass2; 328 nuke_str $pass2;
221 329
222 my $pl = cf::player::new $user; 330 my $pl = cf::player::new $user;
223 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); 331 $pl->password (encode_password $pass);
224 nuke_str $pass; 332 nuke_str $pass;
225 $pl->connect ($ns); 333 $pl->connect ($ns);
226
227 my $ob = $pl->ob; 334 my $ob = $pl->ob;
335
336 $ob->goto ($pl->maplevel, $ob->x, $ob->y);
228 337
229 while () { 338 while () {
230 $ob->update_stats; 339 $ob->update_stats;
231 $pl->save_stats; 340 $pl->save_stats;
232 341
… …
242 $ob->swap_stats ($res - 1, $swap - 1); 351 $ob->swap_stats ($res - 1, $swap - 1);
243 } 352 }
244 } else { 353 } else {
245 $ob->roll_stats; 354 $ob->roll_stats;
246 } 355 }
356
357 Coro::Timer::sleep 0.05;
247 } 358 }
248 359
249 $ob->set_animation (2); 360 $ob->set_animation (2);
250 $ob->add_statbonus; 361 $ob->add_statbonus;
251 362
252 $ns->send_drawinfo ($ob->msg, cf::NDI_BLUE); 363 while () {
253 $ns->send_packet (sprintf "query %d %s", cf::CS_QUERY_SINGLECHAR, 364 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
365 my $msg = $ob->msg;
366 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
367 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
368
369 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
254 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"); 370 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
255 371
256 $ns->state (cf::ST_CHANGE_CLASS); 372 last if $res =~ /[dD]/;
373
374 $pl->chargen_race_next;
375 Coro::Timer::sleep 0.05;
376 }
377
378 # create the playerdir, if necessary, as chargen_race_done did it before
379 # presumably because of unique maps
380 aio_mkdir playerdir $pl, 0770;
381 $pl->chargen_race_done;
382
383 while () {
384 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
385 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
386
387 if ($res =~ /^[fF]/) {
388 $pl->gender (1);
389 last;
390 } elsif ($res =~ /^[mM]/) {
391 $pl->gender (0);
392 last;
393 }
394 Coro::Timer::sleep 0.05;
395 }
396
397 $ob->reply (undef, "Welcome to Deliantra!");
398
399 # XXX: Workaround for delayed client ext protocol handshake
400 $pl->esrv_new_player;
401
257 delete $pl->{deny_save};#d# too early 402 delete $pl->{deny_save};
258 403
259 last; 404 last;
260 } 405 }
406
407 if (0 < Coro::AIO::aio_load "$cf::CONFDIR/motd", my $motd) {
408 $ns->send_msg ("c/motd" => $motd, cf::NDI_CLEAR);
409 }
261 }); 410 });
262} 411});
412
413cf::register_command password => sub {
414 my ($pl, $arg) = @_;
415
416 unless ($pl->flag (cf::FLAG_WIZ)) {
417 $pl->message (
418 "The password can currently only changed by a DM.",
419 cf::NDI_UNIQUE | cf::NDI_REPLY);
420 return;
421 }
422
423 my (@args) = split /\s+/, $arg;
424 my ($player, $new_pw) = @args;
425
426 if ($pl->flag (cf::FLAG_WIZ) && $player eq '') {
427 $pl->message (
428 "Usage: password <player> [<new password>]",
429 cf::NDI_UNIQUE | cf::NDI_REPLY);
430 return;
431 }
432
433 if ($new_pw eq '') {
434 $new_pw =
435 join '',
436 map { ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64)] }
437 1..9;
438 }
439
440 cf::async {
441 my $plc = cf::player::find $player;
442 if ($plc) {
443 $plc->password (encode_password $new_pw);
444 $pl->message (
445 "Ok, changed password of '$player' to '$new_pw'!",
446 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
447 } else {
448 $pl->message (
449 "Fail! Couldn't set password for '$player', "
450 . "he doesn't seem to exist!",
451 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
452 }
453 };
454};
263 455
264cf::register_command quit => sub { 456cf::register_command quit => sub {
265 my ($ob, $arg) = @_; 457 my ($ob, $arg) = @_;
266 458
267 $ob->reply (undef, 459 $ob->send_msg (undef,
268 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. " 460 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. "
269 . "If you are sure you want to do this, then use the quit_character command instead of quit.", 461 . "If you are sure you want to do this, then use the quit_character command instead of quit.",
270 cf::NDI_UNIQUE | cf::NDI_RED); 462 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
271}; 463};
272 464
273cf::register_command quit_character => sub { 465cf::register_command quit_character => sub {
274 my ($ob, $arg) = @_; 466 my ($ob, $arg) = @_;
275 467
276 my $pl = $ob->contr; 468 my $pl = $ob->contr;
277 469
278 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub { 470 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub {
279 if ($_[0] !~ /^[yY]/) { 471 if ($_[0] !~ /^[yY]/) {
280 $ob->reply (undef, 472 $ob->send_msg (undef, "Ok, not not quitting then.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
281 "Ok, not not quitting then.",
282 cf::NDI_UNIQUE | cf::NDI_RED);
283 } else { 473 } else {
284 $ob->reply (undef, 474 $ob->send_msg (undef, "Ok, quitting, hope to see you again.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
285 "Ok, quitting, hope to see you again.", 475 cf::async {
286 cf::NDI_UNIQUE | cf::NDI_RED);
287 $pl->ns->flush;
288 $pl->quit_character; 476 $pl->quit_character;
477 };
289 } 478 }
290 }); 479 });
291}; 480};
292 481
293cf::object->attach ( 482cf::object->attach (
… …
299 488
300 my $pl = $ob->contr; 489 my $pl = $ob->contr;
301 490
302 # update respawn position 491 # update respawn position
303 $pl->savebed ($bed->map->path, $bed->x, $bed->y); 492 $pl->savebed ($bed->map->path, $bed->x, $bed->y);
304 cf::async { $pl->save };
305 493
306 $pl->killer ("left"); 494 cf::async {
307 $ob->check_score; 495 my $killer = cf::arch::get "killer_logout"; $pl->killer ($killer); $killer->destroy;
496 ext::highscore::check $ob;
308 497
309 $ob->reply (undef, "In the future, you will wake up here when you die."); 498 $pl->save;
310 499
500 $ob->send_msg ($cf::SAY_CHANNEL => "In the future, you will wake up here when you die.", cf::NDI_DEF | cf::NDI_REPLY);
501
502 my $ns = $pl->ns
503 or return;
504
311 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { 505 $ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub {
312 if ($_[0] !~ /^[yY]/) { 506 if ($_[0] !~ /^[yY]/) {
313 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1); 507 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1);
314 $pl->deactivate; 508 $pl->deactivate;
315 $pl->ns->destroy; 509 $pl->ns->destroy;
316 } else { 510 }
317 cf::async { $pl->save };
318 } 511 });
319 }); 512 };
320 }, 513 },
321); 514);
322 515
323cf::player->attach ( 516cf::player->attach (
324 on_login => sub { 517 on_login => sub {
… …
333 526
334 if ($cleanly) { 527 if ($cleanly) {
335 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 528 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
336 } else { 529 } else {
337 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 530 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
338 $pl->{unclean_save} = $cf::RUNTIME; 531 $pl->{unclean_save} = $cf::RUNTIME
532 unless safe_spot $pl;
339 } 533 }
340 }, 534 },
341); 535);
342 536
343cf::client->attach (
344 on_addme => \&addme,
345);
346
347#############################################################################
348
349our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs
350our $SAVE_TIMEOUT = 20; # save players every n seconds
351
352our $SCHEDULER = cf::async_ext {
353 my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL);
354 while () {
355 $schedule_interval->next;
356
357 # this weird form of iteration over values is used because
358 # the hash changes underneath us frequently, and for
359 # keeps a direct reference to the value without (in 5.8 perls)
360 # keeping a reference, so this is prone to crashes or worse.
361 my @players = keys %cf::PLAYER;
362 for (@players) {
363 my $pl = $cf::PLAYER{$_}
364 or next;
365 $pl->valid or next;
366
367 eval {
368 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
369 $cf::WAIT_FOR_TICK_ONE->wait;
370 $pl->save;
371
372 unless ($pl->active) {
373 # check refcounts, this is tricky and needs to be adjusted to fit server internals
374 my $ob = $pl->ob;
375 Scalar::Util::weaken $pl;
376 Scalar::Util::weaken $ob;
377 my $a_ = $pl->refcnt;#d#
378 my $b_ = $ob->refcnt;#d#
379 my $pl_ref = $pl->refcnt_cnt;
380 my $ob_ref = $ob->refcnt_cnt;
381
382 ## pl_ref == one from object + one from cf::PLAYER
383 ## ob_ref == one from simply being an object
384 if ($pl_ref == 2 && $ob_ref == 1) {
385 warn "player-scheduler destroy ", $ob->name;#d#
386
387 # remove from sight and get fresh "copies"
388 $pl = delete $cf::PLAYER{$ob->name};
389 $ob = $pl->ob;
390
391 $ob->destroy;
392 $pl->destroy;
393 } else {
394 warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d#
395 }
396 }
397 }
398 };
399 warn $@ if $@;
400 Coro::cede;
401 };
402 }
403};
404
405$SCHEDULER->prio (1);
406

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines