ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.63 by root, Sat Jul 14 14:54:05 2007 UTC vs.
Revision 1.116 by root, Wed May 4 07:36:40 2011 UTC

1#! perl # mandatory 1#! perl # mandatory depends=highscore
2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7
8our $MAX_DISCONNECT_TIME = $cf::CFG{max_disconnect_time} || 3600;
7 9
8# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
9sub nuke_str { 11sub nuke_str {
10 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
11} 13}
12 14
13sub query { 15sub query {
14 my ($ns, $flags, $text) = @_; 16 my ($ns, $flags, $text) = @_;
15 17
16 my $current = $Coro::current; 18 $ns->query ($flags, $text, Coro::rouse_cb);
17 $ns->query ($flags, $text, sub { $current->ready; $current = $_[0] }); 19 Coro::rouse_wait
18 Coro::schedule while ref $current;
19
20 $current
21} 20}
22 21
23sub can_cleanup { 22sub can_cleanup {
24 my ($pl, $mtime) = @_; 23 my ($pl, $mtime) = @_;
25 24
50 ); 49 );
51 50
52 1 51 1
53} 52}
54 53
54sub safe_spot($) {
55 my ($pl) = @_;
56
57 my $ob = $pl->ob;
58
59 my $m = $ob->map
60 or return;
61 my $x = $ob->x;
62 my $y = $ob->y;
63
64 # never happens normally, but helps when shell users make mistakes
65 $m->linkable
66 or return 1;
67
68# return 0;#d#
69# warn join ":", $m->at ($x, $y);#d#
70# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
71# return 0;
72
73 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
74}
75
55sub enter_map { 76sub enter_map {
56 my ($pl) = @_; 77 my ($pl) = @_;
57 78
58 my $ob = $pl->ob; 79 my $ob = $pl->ob;
59 80
62 ? @{delete $ob->{_link_pos}} 83 ? @{delete $ob->{_link_pos}}
63 : ($pl->maplevel, $ob->x, $ob->y); 84 : ($pl->maplevel, $ob->x, $ob->y);
64 85
65 $ob->enter_link; 86 $ob->enter_link;
66 87
88 my $m = cf::map::find $map;
67 if (my $time = delete $pl->{unclean_save}) { 89 my $time = delete $pl->{unclean_save};
68 if (my $m = cf::map::find $map) { 90
91 if ($time && $m) {
69 if ($time < $m->{instantiate_time}) { 92 if ($time < $m->{instantiate_time}) {
70 # the map was reset in the meantime 93 # the map was reset in the meantime
71 my $age = $cf::RUNTIME - $time; 94 my $age = $cf::RUNTIME - $time;
95
72 warn $ob->name, " map reset after logout, logout age $age\n";#d# 96 cf::info $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
73 97
74 # for now, just go back to savebed 98 if ($age >= $MAX_DISCONNECT_TIME) {
99 $ob->message (
100 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
101 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
102 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
103 . "H<You disconnected too long without having used a savebed.>",
104 cf::NDI_RED
105 );
106 # kill them.
107 # reminds me of the famous badness 10000 syndrome...
108 $ob->stats->hp (-10000); #] if they survive this they deserved to live
109 my $killer = cf::arch::get "killer_login"; $pl->killer ($killer); $killer->destroy;
110 } else {
75 ($map, $x, $y) = $pl->savebed; 111 ($map, $x, $y) = $pl->savebed;
76 112
77 $pl->ns->send_drawinfo ( 113 $ob->message (
78 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. " 114 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
79 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. " 115 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
80 . "Better use a savebed next time, much worse things could have happened...", 116 . "Better use a savebed next time, much worse things could have happened... "
117 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
81 cf::NDI_RED 118 cf::NDI_RED
82 ); 119 );
120 }
83 } else { 121 } else {
84 $pl->ns->send_drawinfo ( 122 $ob->message (
85 "You didn't use a bed to reality to leave this realm. This is very dangerous, " 123 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
86 . "as lots of things could happen when you leave by other means, such as cave-ins, " 124 . "as lots of things could happen when you leave by other means, such as cave-ins, "
87 . "or monsters suddenly snapping your body. Better use a savebed next time.", 125 . "or monsters suddenly snapping your body. Better use a savebed next time. "
126 . "H<Always apply a bed of reality to disconnect from the server.>",
88 cf::NDI_RED 127 cf::NDI_RED
89 ); 128 );
90 }
91 } 129 }
92 } 130 }
93 131
94 $ob->goto ($map, $x, $y); 132 $ob->goto ($map, $x, $y);
95} 133}
96 134
97# delete a player directory, be non-blocking AND synchronous... 135sub encode_password($) {
98# (thats hard, so we crap out and fork). 136# crypt $_[0],
137# join '',
138# ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64), (cf::rndm 64)]
139 "!" . unpack "H*", $_[0]
140}
141
142sub compare_password($$) {
143 my ($pass, $token) = @_;
144
145 if ($token =~ /\!(.*)/) {
146 return $pass eq pack "H*", $1;
147 } else {
148 return $token eq crypt $pass, $token;
149 }
150}
151
152# delete a player directory
99sub nuke_playerdir { 153sub nuke_playerdir {
100 my ($user) = @_; 154 my ($user) = @_;
101 155
156 my $lock = cf::lock_acquire "ext::login::nuke_playerdir";
157
158 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
102 aio_stat "$PLAYERDIR/$user"; 159 aio_rename "$PLAYERDIR/$user", $temp;
103 system "cd \Q$PLAYERDIR\E " 160 IO::AIO::aio_rmtree $temp;
104 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null "
105 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)";
106} 161}
107 162
108cf::client->attach (on_addme => sub { 163cf::client->attach (on_addme => sub {
109 my ($ns) = @_; 164 my ($ns) = @_;
110 165
111 if (!$ns->facecache)
112 {
113 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
114
115
116***
117*** WARNING:
118*** Your client does not support face/image caching,
119*** or it has been disabled. Face caching is mandatory
120*** so please enable it or use a newer client.
121***
122*** Look at your client preferences:
123***
124*** CFPlus: all known versions automatically enable the facecache.
125*** cfclient: use the -cache commandline option.
126*** cfclient: map will not redraw automatically (bug).
127*** gcfclient: use -cache commandline option, or enable
128*** gcfclient: Client=>Configure=>Map & Image=>Cache Images.
129*** jcrossclient: your client is broken, use CFPlus or gcfclient.
130***
131***
132EOF
133 if ($ns->version =~ /jcrossclient/) {
134 # let them, for now
135 } else {
136 $ns->flush;
137 return $ns->destroy;
138 }
139
140 # $ns->facecache = true;
141 }
142
143 if ($ns->mapmode < cf::Map1aCmd) {
144 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
145
146
147***
148*** WARNING:
149*** Your client is too old. Please upgrade to a newer version.
150EOF
151
152 $ns->flush;
153 return $ns->destroy;
154 }
155
156 $ns->pl and return $ns->destroy; 166 $ns->pl and return $ns->destroy;
157 167
158 $ns->async (sub { 168 $ns->async (sub {
169 $Coro::current->{desc} = "addme init";
170
159 my ($user, $pass); 171 my ($user, $pass);
160 172
161 $ns->send_packet ("addme_success"); 173 $ns->send_packet ("addme_success");
162 174
163 for (;;) { 175 for (;;) {
168 cf::NDI_BLUE 180 cf::NDI_BLUE
169 ); 181 );
170 182
171 # read username 183 # read username
172 while () { 184 while () {
173 $user = query $ns, 0, "What is your name?\n:"; 185 $user = query $ns, 0, "What is your name? (login names are case-sensitive)\n:";
174 186
175 if ($cf::LOGIN_LOCK{$user}) { 187 if ($cf::LOGIN_LOCK{$user}) {
176 $ns->send_drawinfo ( 188 $ns->send_drawinfo (
177 "That username is currently used in another login session. " 189 "That username is currently used in another login session. "
178 . "Chose another, or wait till the other session has ended.", 190 . "Chose another, or wait till the other session has ended.",
179 cf::NDI_RED 191 cf::NDI_RED
180 ); 192 );
181 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,17}\z/) { 193 } elsif ($user =~ /^[a-zA-Z0-9][a-zA-Z0-9\-_]{2,19}\z/) {
182 last; 194 last;
183 } else { 195 } else {
184 $ns->send_drawinfo ( 196 $ns->send_drawinfo (
185 "Your username contains illegal characters " 197 "Your username contains illegal characters "
186 . "(only a-z, A-Z and 0-9 are allowed), " 198 . "(only a-z, A-Z and 0-9 are allowed), "
187 . "or is not between 3 and 18 characters in length.", 199 . "or is not between 3 and 20 characters in length.",
188 cf::NDI_RED 200 cf::NDI_RED
189 ); 201 );
190 } 202 }
191 Coro::Timer::sleep 0.4; 203 Coro::Timer::sleep 0.4;
192 } 204 }
193 205
194 check_playing $ns, $user and next; 206 check_playing $ns, $user and next;
207
208 $Coro::current->{desc} = "addme($user) pass";
195 209
196 $ns->send_drawinfo ( 210 $ns->send_drawinfo (
197 "Welcome $user, please enter your password now. " 211 "Welcome $user, please enter your password now. "
198 . "New users should now choose a password. " 212 . "New users should now choose a password. "
199 . "Anything your client lets you enter is fine.", 213 . "Anything your client lets you enter is fine.",
223 } 237 }
224 local $cf::LOGIN_LOCK{$user} = 1; 238 local $cf::LOGIN_LOCK{$user} = 1;
225 239
226 check_playing $ns, $user and next; 240 check_playing $ns, $user and next;
227 241
242 $Coro::current->{desc} = "addme($user) check";
243
228 # try to read the user file and check the password 244 # try to read the user file and check the password
229 if (my $pl = cf::player::find $user) { 245 if (my $pl = cf::player::find $user) {
230 aio_stat $pl->path and next; 246 aio_stat $pl->path and next;
231 my $mtime = (stat _)[9]; 247 my $mtime = (stat _)[9];
232 my $hash = $pl->password; 248 my $token = $pl->password;
233 249
234 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) { 250 if ($cf::CFG{ext_login_nocheck} or compare_password $pass, $token) {
251 $pl->password (encode_password $pass); # make sure we store the new encoding #d#
235 nuke_str $pass; 252 nuke_str $pass;
236 # password matches, wonderful 253 # password matches, wonderful
237 my $pl = cf::player::find $user or next; 254 my $pl = cf::player::find $user or next;
238 $pl->connect ($ns); 255 $pl->connect ($ns);
239 enter_map $pl; 256 enter_map $pl;
271 ); 288 );
272 next; 289 next;
273 } 290 }
274 } else { 291 } else {
275 # unable to load the playerfile: 292 # unable to load the playerfile:
276 # check wether the player dir exists, which means the file is corrupted or 293 # check whether the player dir exists, which means the file is corrupted or
277 # something very similar. 294 # something very similar.
278 if (!aio_stat cf::player::playerdir $user) { 295 if (!aio_stat cf::player::playerdir $user) {
279 $ns->send_drawinfo ( 296 $ns->send_drawinfo (
280 "Unable to retrieve this player. It might be a locked or broken account. " 297 "Unable to retrieve this player. It might be a locked or broken account. "
281 . "If this is your account, ask a dungeon master for assistance. " 298 . "If this is your account, ask a dungeon master for assistance. "
285 next; 302 next;
286 } 303 }
287 } 304 }
288 305
289 # the rest of this function is character creation 306 # the rest of this function is character creation
307 $Coro::current->{desc} = "addme($user) chargen";
290 308
291 # just to make sure nothing is left over 309 # just to make sure nothing is left over
310 # normally, nothing is there.
292 nuke_playerdir $user; 311 nuke_playerdir $user;
293 312
294 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 313 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
295 314
296 if ($pass2 ne $pass) { 315 if ($pass2 ne $pass) {
305 } 324 }
306 325
307 nuke_str $pass2; 326 nuke_str $pass2;
308 327
309 my $pl = cf::player::new $user; 328 my $pl = cf::player::new $user;
310 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); 329 $pl->password (encode_password $pass);
311 nuke_str $pass; 330 nuke_str $pass;
312 $pl->connect ($ns); 331 $pl->connect ($ns);
313 my $ob = $pl->ob; 332 my $ob = $pl->ob;
314 333
315 $ob->goto ($pl->maplevel, $ob->x, $ob->y); 334 $ob->goto ($pl->maplevel, $ob->x, $ob->y);
331 } 350 }
332 } else { 351 } else {
333 $ob->roll_stats; 352 $ob->roll_stats;
334 } 353 }
335 354
336 Coro::Timer::sleep 0.2; 355 Coro::Timer::sleep 0.05;
337 } 356 }
338 357
339 $ob->set_animation (2); 358 $ob->set_animation (2);
340 $ob->add_statbonus; 359 $ob->add_statbonus;
341 360
342 while () { 361 while () {
343 $ns->send_msg (-1, "chargen-race-title", ucfirst $pl->title); 362 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
344 my $msg = $ob->msg; 363 my $msg = $ob->msg;
345 $msg =~ s/(?<=\S)\n(?=\S)/ /g; 364 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
346 $ns->send_msg (cf::NDI_BLUE, "chargen-race-description", $msg); 365 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
347 366
348 my $res = query $ns, cf::CS_QUERY_SINGLECHAR, 367 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
349 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"; 368 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
350 369
351 last if $res =~ /[dD]/; 370 last if $res =~ /[dD]/;
352 371
353 $pl->chargen_race_next; 372 $pl->chargen_race_next;
354 Coro::Timer::sleep 0.2; 373 Coro::Timer::sleep 0.05;
355 } 374 }
356 375
376 # create the playerdir, if necessary, as chargen_race_done did it before
377 # presumably because of unique maps
378 aio_mkdir playerdir $pl, 0770;
357 $pl->chargen_race_done; 379 $pl->chargen_race_done;
358 380
359 while () { 381 while () {
360 my $res = query $ns, cf::CS_QUERY_SINGLECHAR, 382 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
361 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n"; 383 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
365 last; 387 last;
366 } elsif ($res =~ /^[mM]/) { 388 } elsif ($res =~ /^[mM]/) {
367 $pl->gender (0); 389 $pl->gender (0);
368 last; 390 last;
369 } 391 }
370 Coro::Timer::sleep 0.2; 392 Coro::Timer::sleep 0.05;
371 } 393 }
372 394
373 $ob->reply (undef, "Welcome to Crossfire!"); 395 $ob->reply (undef, "Welcome to Deliantra!");
396
397 # XXX: Workaround for delayed client ext protocol handshake
398 $pl->esrv_new_player;
374 399
375 delete $pl->{deny_save}; 400 delete $pl->{deny_save};
376 401
377 last; 402 last;
403 }
404
405 if (0 < Coro::AIO::aio_load "$cf::CONFDIR/motd", my $motd) {
406 $ns->send_msg ("c/motd" => $motd, cf::NDI_CLEAR);
378 } 407 }
379 }); 408 });
380}); 409});
381 410
411cf::register_command password => sub {
412 my ($pl, $arg) = @_;
413
414 unless ($pl->flag (cf::FLAG_WIZ)) {
415 $pl->message (
416 "The password can currently only changed by a DM.",
417 cf::NDI_UNIQUE | cf::NDI_REPLY);
418 return;
419 }
420
421 my (@args) = split /\s+/, $arg;
422 my ($player, $new_pw) = @args;
423
424 if ($pl->flag (cf::FLAG_WIZ) && $player eq '') {
425 $pl->message (
426 "Usage: password <player> [<new password>]",
427 cf::NDI_UNIQUE | cf::NDI_REPLY);
428 return;
429 }
430
431 if ($new_pw eq '') {
432 $new_pw =
433 join '',
434 map { ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[(cf::rndm 64)] }
435 1..9;
436 }
437
438 cf::async {
439 my $plc = cf::player::find $player;
440 if ($plc) {
441 $plc->password (encode_password $new_pw);
442 $pl->message (
443 "Ok, changed password of '$player' to '$new_pw'!",
444 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
445 } else {
446 $pl->message (
447 "Fail! Couldn't set password for '$player', "
448 . "he doesn't seem to exist!",
449 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
450 }
451 };
452};
453
382cf::register_command quit => sub { 454cf::register_command quit => sub {
383 my ($ob, $arg) = @_; 455 my ($ob, $arg) = @_;
384 456
385 $ob->reply (undef, 457 $ob->send_msg (undef,
386 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. " 458 "Quitting will delete your character PERMANENTLY: It will be gone forever and any progress will be lost. "
387 . "If you are sure you want to do this, then use the quit_character command instead of quit.", 459 . "If you are sure you want to do this, then use the quit_character command instead of quit.",
388 cf::NDI_UNIQUE | cf::NDI_RED); 460 cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
389}; 461};
390 462
391cf::register_command quit_character => sub { 463cf::register_command quit_character => sub {
392 my ($ob, $arg) = @_; 464 my ($ob, $arg) = @_;
393 465
394 my $pl = $ob->contr; 466 my $pl = $ob->contr;
395 467
396 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub { 468 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to PERMANENTLY delete your character and all associated data (y/n)?", sub {
397 if ($_[0] !~ /^[yY]/) { 469 if ($_[0] !~ /^[yY]/) {
398 $ob->reply (undef, 470 $ob->send_msg (undef, "Ok, not not quitting then.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
399 "Ok, not not quitting then.",
400 cf::NDI_UNIQUE | cf::NDI_RED);
401 } else { 471 } else {
402 $ob->reply (undef, 472 $ob->send_msg (undef, "Ok, quitting, hope to see you again.", cf::NDI_UNIQUE | cf::NDI_RED | cf::NDI_REPLY);
403 "Ok, quitting, hope to see you again.", 473 cf::async {
404 cf::NDI_UNIQUE | cf::NDI_RED);
405 $pl->ns->flush;
406 cf::async { $pl->quit_character }; 474 $pl->quit_character;
475 };
407 } 476 }
408 }); 477 });
409}; 478};
410 479
411cf::object->attach ( 480cf::object->attach (
417 486
418 my $pl = $ob->contr; 487 my $pl = $ob->contr;
419 488
420 # update respawn position 489 # update respawn position
421 $pl->savebed ($bed->map->path, $bed->x, $bed->y); 490 $pl->savebed ($bed->map->path, $bed->x, $bed->y);
422 cf::async { $pl->save };
423 491
424 $pl->killer ("left"); 492 cf::async {
425 $ob->check_score; 493 my $killer = cf::arch::get "killer_logout"; $pl->killer ($killer); $killer->destroy;
494 ext::highscore::check $ob;
426 495
427 $ob->reply (undef, "In the future, you will wake up here when you die."); 496 $pl->save;
428 497
498 $ob->send_msg ($cf::SAY_CHANNEL => "In the future, you will wake up here when you die.", cf::NDI_DEF | cf::NDI_REPLY);
499
500 my $ns = $pl->ns
501 or return;
502
429 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { 503 $ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub {
430 if ($_[0] !~ /^[yY]/) { 504 if ($_[0] !~ /^[yY]/) {
431 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1); 505 $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1);
432 $pl->deactivate; 506 $pl->deactivate;
433 $pl->ns->destroy; 507 $pl->ns->destroy;
434 } else { 508 }
435 cf::async { $pl->save };
436 } 509 });
437 }); 510 };
438 }, 511 },
439); 512);
440 513
441cf::player->attach ( 514cf::player->attach (
442 on_login => sub { 515 on_login => sub {
451 524
452 if ($cleanly) { 525 if ($cleanly) {
453 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 526 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
454 } else { 527 } else {
455 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 528 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
456 $pl->{unclean_save} = $cf::RUNTIME; 529 $pl->{unclean_save} = $cf::RUNTIME
530 unless safe_spot $pl;
457 } 531 }
458 }, 532 },
459); 533);
460 534
461#############################################################################
462
463our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs
464our $SAVE_TIMEOUT = 20; # save players every n seconds
465
466our $SCHEDULER = cf::async_ext {
467 my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL);
468 while () {
469 $schedule_interval->next;
470
471 # this weird form of iteration over values is used because
472 # the hash changes underneath us frequently, and for
473 # keeps a direct reference to the value without (in 5.8 perls)
474 # keeping a reference, so this is prone to crashes or worse.
475 my @players = keys %cf::PLAYER;
476 for (@players) {
477 my $pl = $cf::PLAYER{$_}
478 or next;
479 $pl->valid or next;
480
481 eval {
482 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
483 cf::wait_for_tick_begin;
484 $pl->save;
485
486 unless ($pl->active || $pl->ns) {
487 # check refcounts, this is tricky and needs to be adjusted to fit server internals
488 my $ob = $pl->ob;
489
490 my $pl_ref = $pl->refcnt_cnt;
491 my $ob_ref = $ob->refcnt_cnt;
492
493 ## pl_ref == $pl + ob->contr + %cf::PLAYER
494 ## ob_ref == $ob + pl->observe + simply being an object
495 if ($pl_ref == 3 && $ob_ref == 3) {
496 warn "player-scheduler destroy ", $ob->name;#d#
497
498 # remove from sight and get fresh "copies"
499 $pl = delete $cf::PLAYER{$ob->name};
500 $ob = $pl->ob;
501
502 $pl->destroy; # destroys $ob
503 } else {
504 my $a_ = $pl->refcnt;#d#
505 my $b_ = $ob->refcnt;#d#
506
507 warn "player-scheduler refcnt ", $ob->name, " pl $pl_ref ob $ob_ref (C pl $a_ ob $b_)\n";#d#
508 }
509 }
510 }
511 };
512 warn $@ if $@;
513 Coro::cede;
514 };
515 }
516};
517
518$SCHEDULER->prio (1);
519

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines