ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.40 by root, Mon Apr 16 15:50:49 2007 UTC vs.
Revision 1.79 by root, Sun Jan 13 09:19:56 2008 UTC

1#! perl # MANDATORY 1#! perl # mandatory
2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7use List::Util qw(min max);
8 7
9my $PLAYERDIR = sprintf "%s/%s", cf::localdir, cf::playerdir; 8our $MAX_DISCONNECT_TIME = $cf::CFG{max_disconnect_time} || 3600;
10 9
11# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
12sub nuke_str { 11sub nuke_str {
13 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
14} 13}
… …
41 return unless cf::player::find_active $user; 40 return unless cf::player::find_active $user;
42 41
43 $ns->send_drawinfo ( 42 $ns->send_drawinfo (
44 "That player is already logged in on this server. " 43 "That player is already logged in on this server. "
45 . "If you want to create a new player, choose another name. " 44 . "If you want to create a new player, choose another name. "
46 . "If you are already a registered player, make sure nobody " 45 . "If you have already a registered, make sure nobody "
47 . "else is using your account at this time. If you lost your conenction " 46 . "else is using your account at this time. If you lost your connection "
48 . "then the server will likely timeout within a minute. If you still " 47 . "then the server will likely timeout within a minute. If you still "
49 . "cannot log-in after a minute, you are still logged in. Make sure " 48 . "cannot log-in after a minute, you are still logged in. Make sure "
50 . "you do not have another client running. If you use windows, reboot, " 49 . "you do not have another client running. If you use windows, reboot, "
51 . "this will fix anything.", 50 . "this will fix anything.",
52 cf::NDI_RED 51 cf::NDI_RED
53 ); 52 );
54 53
55 1 54 1
56} 55}
57 56
58sub check_clean_save { 57sub safe_spot($) {
59 my ($pl) = @_; 58 my ($pl) = @_;
59
60 my $ob = $pl->ob;
60 61
62 my $m = $ob->map
63 or return;
64 my $x = $ob->x;
65 my $y = $ob->y;
66
67# return 0;#d#
68# warn join ":", $m->at ($x, $y);#d#
69# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
70# return 0;
71
72 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
73}
74
75sub enter_map {
76 my ($pl) = @_;
77
78 my $ob = $pl->ob;
79
80 my ($map, $x, $y)
81 = $ob->{_link_pos}
82 ? @{delete $ob->{_link_pos}}
83 : ($pl->maplevel, $ob->x, $ob->y);
84
85 $ob->enter_link;
86
87 my $m = cf::map::find $map;
61 if (my $time = delete $pl->{unclean_save}) { 88 my $time = delete $pl->{unclean_save};
62 $pl->ns->send_drawinfo ( 89
90 if ($time && $m) {
91 if ($time < $m->{instantiate_time}) {
92 # the map was reset in the meantime
93 my $age = $cf::RUNTIME - $time;
94
95 warn $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
96
97 ($map, $x, $y) = $pl->savebed;
98
99 if ($age >= $MAX_DISCONNECT_TIME) {
100 $ob->message (
101 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
102 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
103 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
104 . "H<You disconnected too long without having used a savebed.>",
105 cf::NDI_RED
106 );
107 # kill them.
108 # reminds me of the famous badness 10000 syndrome...
109 $ob->stats->hp (-10000); #] if they survive this they deserved to live
110 $pl->killer ("a cave-in");
111 } else {
112 $ob->message (
113 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
114 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
115 . "Better use a savebed next time, much worse things could have happened... "
116 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
117 cf::NDI_RED
118 );
119 }
120 } else {
121 $ob->message (
63 "You didn't use a savebed to leave this realm. This is very dangerous, " 122 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
64 . "as lots of things could happen when you leave by other means, such as cave-ins, " 123 . "as lots of things could happen when you leave by other means, such as cave-ins, "
65 . "or monsters suddenly snapping your body. Better use a savebed next time.", 124 . "or monsters suddenly snapping your body. Better use a savebed next time. "
125 . "H<Always apply a bed of reality to disconnect from the server.>",
66 cf::NDI_RED 126 cf::NDI_RED
67 ); 127 );
68 #d#TODO 128 }
69 } 129 }
130
131 $ob->goto ($map, $x, $y);
70} 132}
71 133
72# delete a player directory, be non-blocking AND synchronous... 134# delete a player directory, be non-blocking AND synchronous...
73# (thats hard, so we crap out and fork). 135# (thats hard, so we crap out and fork).
74sub nuke_playerdir { 136sub nuke_playerdir {
75 my ($user) = @_; 137 my ($user) = @_;
76 138
77 aio_stat "$PLAYERDIR/$user"; 139 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
78 system "cd \Q$PLAYERDIR\E "
79 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null "
80 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)";
81}
82 140
83sub send_capabilities { 141 cf::fork_call {
142 rename "$PLAYERDIR/$user", $temp;
143 system "rm", "-rf", $temp;
144 };
145}
146
147cf::client->attach (on_addme => sub {
84 my ($ns) = @_; 148 my ($ns) = @_;
85 149
86 return unless $ns->extcmd;
87
88 $ns->ext_event (capabilities =>
89 # id, name, flags (1 == 2d), edge length
90 tileset => [[1, "default 64x64 faceset", 1, 64], [0, "default 32x32 faceset", 1, 32]],
91 );
92}
93
94sub setup {
95 my ($ns, $args) = @_;
96
97 # run through the cmds of setup
98 # syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
99 #
100 # we send the status of the cmd back, or a FALSE is the cmd is the server unknown
101 # The client then must sort this out
102
103 my %setup = split / +/, $args;
104 while (my ($k, $v) = each %setup) {
105 if ($k eq "sound") {
106 $ns->sound ($v);
107
108 } elsif ($k eq "exp64") {
109 $setup{$k} = 1;
110
111 } elsif ($k eq "spellmon") {
112 $ns->monitor_spells ($v);
113
114 } elsif ($k eq "darkness") {
115 $ns->darkness ($v);
116
117 } elsif ($k eq "map1cmd") {
118 $ns->mapmode (cf::Map1Cmd) if $v > 0;
119
120 } elsif ($k eq "map1acmd") {
121 $ns->mapmode (cf::Map1aCmd) if $v > 0;
122
123 } elsif ($k eq "map2cmd") {
124 # gcfclient bug, map1acmd is sent too late
125 $ns->mapmode (cf::Map1aCmd);
126 $setup{$k} = "FALSE";
127
128 } elsif ($k eq "newmapcmd") {
129 $ns->newmapcmd ($v);
130
131 } elsif ($k eq "mapinfocmd") {
132 $ns->mapinfocmd ($v);
133
134 } elsif ($k eq "extcmd") {
135 $ns->extcmd ($v > 0);
136 send_capabilities $ns;
137
138 } elsif ($k eq "extmap") {
139 $ns->extmap ($v);
140
141 } elsif ($k eq "facecache") {
142 if (!$v) {
143 $v = 1;
144 $setup{$k} = $v;
145 $ns->send_drawinfo ("(trying to force facecaching to be enabled)", cf::NDI_RED);
146 }
147
148 $ns->facecache ($v);
149
150 } elsif ($k eq "faceset") {
151 $ns->faceset (0);
152 $setup{$k} = 0;
153 # $ns->image2 (1)
154
155 } elsif ($k eq "tileset") {
156 $setup{$k} = $ns->faceset ($v & 1);
157
158 } elsif ($k eq "itemcmd") {
159 # Version of the item protocol command to use. Currently,
160 # only supported versions are 1 and 2. Using a numeric
161 # value will make it very easy to extend this in the future.
162 $ns->itemcmd ($v) if $v >= 1 && $v <= 2;
163
164 $setup{$k} = $ns->itemcmd;
165
166 } elsif ($k eq "mapsize") {
167 my ($x, $y) = split /x/, $v;
168
169 $ns->mapx ($x = max 9, min cf::MAP_CLIENT_X, ($x - 1) | 1);
170 $ns->mapy ($y = max 9, min cf::MAP_CLIENT_Y, ($y - 1) | 1);
171
172 $setup{$k} = "${x}x${y}";
173
174 } elsif ($k eq "extendedMapInfos") {
175 $ns->ext_mapinfos ($v);
176
177 } elsif ($k eq "extendedTextInfos") {
178 $ns->has_readable_type ($v);
179
180 } elsif ($k eq "smoothing") { # cfplus-style smoothing
181 $ns->smoothing ($v);
182
183 } elsif ($k eq "fxix") {
184 $ns->fxix ($v);
185
186 } else {
187 # other commands:
188 # sexp: no idea, probably for oudated servers
189 # tick: more stupidity, server should sned a tick per tick
190
191 $setup{$k} = "FALSE";
192 }
193 }
194
195 $ns->send_packet (join " ", setup => %setup);
196
197 cf::datalog setup =>
198 request => $args,
199 reply => \%setup,
200 client => $ns->version,
201 ;
202}
203
204sub addme {
205 my ($ns) = @_;
206
207 if (!$ns->facecache) 150 if (!$ns->facecache)
208 { 151 {
209 $ns->send_drawinfo (<<EOF, cf::NDI_RED); 152 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
210 153
211 154
212*** 155***
213*** WARNING: 156*** WARNING:
214*** Your client does not support face/image caching, 157*** Your client does not support face/image caching,
215*** or it has been disabled. Face caching is mandatory 158*** or it has been disabled. Face caching is mandatory
216*** so please enable it or use a newer client. 159*** so please enable it or use a newer client.
217*** 160***
218*** Look at your client preferences: 161*** Look at your client preferences:
219*** 162***
220*** CFPlus: all known versions automatically enable the facecache. 163*** deliantra: all known versions automatically enable the facecache.
221*** cfclient: use the -cache commandline option. 164*** cfclient: use the -cache commandline option.
222*** cfclient: map will not redraw automatically (bug). 165*** cfclient: map will not redraw automatically (bug).
223*** gcfclient: use -cache commandline option, or enable 166*** gcfclient: use -cache commandline option, or enable
224*** gcfclient: Client=>Configure=>Map & Image=>Cache Images. 167*** gcfclient: Client => Configure => Map & Image => Cache Images.
225*** jcrossclient: your client is broken, use CFPlus or gcfclient. 168*** jcrossclient: your client is broken, use deliantra or gcfclient.
226*** 169***
227*** 170***
228EOF 171EOF
229 if ($ns->version =~ /jcrossclient/) { 172 if ($ns->version =~ /jcrossclient/) {
230 # let them, for now 173 # let them, for now
… …
250 } 193 }
251 194
252 $ns->pl and return $ns->destroy; 195 $ns->pl and return $ns->destroy;
253 196
254 $ns->async (sub { 197 $ns->async (sub {
198 $Coro::current->{desc} = "addme init";
199
255 my ($user, $pass); 200 my ($user, $pass);
256 201
257 $ns->send_packet ("addme_success"); 202 $ns->send_packet ("addme_success");
258 203
259 for (;;) { 204 for (;;) {
… …
282 . "(only a-z, A-Z and 0-9 are allowed), " 227 . "(only a-z, A-Z and 0-9 are allowed), "
283 . "or is not between 3 and 18 characters in length.", 228 . "or is not between 3 and 18 characters in length.",
284 cf::NDI_RED 229 cf::NDI_RED
285 ); 230 );
286 } 231 }
232 Coro::Timer::sleep 0.4;
287 } 233 }
288 234
289 check_playing $ns, $user and next; 235 check_playing $ns, $user and next;
236
237 $Coro::current->{desc} = "addme($user) pass";
290 238
291 $ns->send_drawinfo ( 239 $ns->send_drawinfo (
292 "Welcome $user, please enter your password now. " 240 "Welcome $user, please enter your password now. "
293 . "New users should now choose a password. " 241 . "New users should now choose a password. "
294 . "Anything your client lets you enter is fine.", 242 . "Anything your client lets you enter is fine.",
… …
302 $ns->send_drawinfo ( 250 $ns->send_drawinfo (
303 "Try to use at least three characters as your password please, " 251 "Try to use at least three characters as your password please, "
304 . "that cannot be too much to ask for :)", 252 . "that cannot be too much to ask for :)",
305 cf::NDI_RED 253 cf::NDI_RED
306 ); 254 );
255 Coro::Timer::sleep 0.4;
307 } 256 }
308 257
309 # lock this username for the remainder of this login session 258 # lock this username for the remainder of this login session
310 if ($cf::LOGIN_LOCK{$user}) { 259 if ($cf::LOGIN_LOCK{$user}) {
311 $ns->send_drawinfo ( 260 $ns->send_drawinfo (
… …
317 } 266 }
318 local $cf::LOGIN_LOCK{$user} = 1; 267 local $cf::LOGIN_LOCK{$user} = 1;
319 268
320 check_playing $ns, $user and next; 269 check_playing $ns, $user and next;
321 270
271 $Coro::current->{desc} = "addme($user) check";
272
322 # try to read the user file and check the password 273 # try to read the user file and check the password
323 if (my $pl = cf::player::find $user) { 274 if (my $pl = cf::player::find $user) {
324 aio_stat $pl->path and next; 275 aio_stat $pl->path and next;
325 my $mtime = (stat _)[9]; 276 my $mtime = (stat _)[9];
326 my $hash = $pl->password; 277 my $hash = $pl->password;
… …
328 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) { 279 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) {
329 nuke_str $pass; 280 nuke_str $pass;
330 # password matches, wonderful 281 # password matches, wonderful
331 my $pl = cf::player::find $user or next; 282 my $pl = cf::player::find $user or next;
332 $pl->connect ($ns); 283 $pl->connect ($ns);
333 check_clean_save $pl; 284 enter_map $pl;
334 last; 285 last;
335 } elsif (can_cleanup $pl, $mtime) { 286 } elsif (can_cleanup $pl, $mtime) {
336 Coro::Timer::sleep 1; 287 Coro::Timer::sleep 1;
337 288
338 $ns->send_drawinfo ( 289 $ns->send_drawinfo (
… …
379 next; 330 next;
380 } 331 }
381 } 332 }
382 333
383 # the rest of this function is character creation 334 # the rest of this function is character creation
335 $Coro::current->{desc} = "addme($user) chargen";
384 336
385 # just to make sure nothing is left over 337 # just to make sure nothing is left over
386 nuke_playerdir $user; 338 nuke_playerdir $user;
387 339
388 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 340 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
… …
392 nuke_str $pass2; 344 nuke_str $pass2;
393 $ns->send_drawinfo ( 345 $ns->send_drawinfo (
394 "The passwords do not match, please try again.", 346 "The passwords do not match, please try again.",
395 cf::NDI_RED 347 cf::NDI_RED
396 ); 348 );
349 Coro::Timer::sleep 0.5;
397 next; 350 next;
398 } 351 }
399 352
400 nuke_str $pass2; 353 nuke_str $pass2;
401 354
402 my $pl = cf::player::new $user; 355 my $pl = cf::player::new $user;
403 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); 356 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]);
404 nuke_str $pass; 357 nuke_str $pass;
405 $pl->connect ($ns); 358 $pl->connect ($ns);
406
407 my $ob = $pl->ob; 359 my $ob = $pl->ob;
360
361 $ob->goto ($pl->maplevel, $ob->x, $ob->y);
408 362
409 while () { 363 while () {
410 $ob->update_stats; 364 $ob->update_stats;
411 $pl->save_stats; 365 $pl->save_stats;
412 366
… …
422 $ob->swap_stats ($res - 1, $swap - 1); 376 $ob->swap_stats ($res - 1, $swap - 1);
423 } 377 }
424 } else { 378 } else {
425 $ob->roll_stats; 379 $ob->roll_stats;
426 } 380 }
381
382 Coro::Timer::sleep 0.2;
427 } 383 }
428 384
429 $ob->set_animation (2); 385 $ob->set_animation (2);
430 $ob->add_statbonus; 386 $ob->add_statbonus;
431 387
432 $ns->send_drawinfo ($ob->msg, cf::NDI_BLUE); 388 while () {
433 $ns->send_packet (sprintf "query %d %s", cf::CS_QUERY_SINGLECHAR, 389 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
390 my $msg = $ob->msg;
391 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
392 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
393
394 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
434 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"); 395 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
435 396
436 $ns->state (cf::ST_CHANGE_CLASS); 397 last if $res =~ /[dD]/;
398
399 $pl->chargen_race_next;
400 Coro::Timer::sleep 0.2;
401 }
402
403 $pl->chargen_race_done;
404
405 while () {
406 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
407 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
408
409 if ($res =~ /^[fF]/) {
410 $pl->gender (1);
411 last;
412 } elsif ($res =~ /^[mM]/) {
413 $pl->gender (0);
414 last;
415 }
416 Coro::Timer::sleep 0.2;
417 }
418
419 $ob->reply (undef, "Welcome to Deliantra!");
420
437 delete $pl->{deny_save};#d# too early 421 delete $pl->{deny_save};
438 422
439 last; 423 last;
440 } 424 }
441 }); 425 });
442} 426});
443 427
444cf::register_command quit => sub { 428cf::register_command quit => sub {
445 my ($ob, $arg) = @_; 429 my ($ob, $arg) = @_;
446 430
447 $ob->reply (undef, 431 $ob->reply (undef,
… …
513 497
514 if ($cleanly) { 498 if ($cleanly) {
515 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 499 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
516 } else { 500 } else {
517 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 501 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
502 warn "unclean\n" unless safe_spot $pl;#d#
518 $pl->{unclean_save} = $cf::RUNTIME; 503 $pl->{unclean_save} = $cf::RUNTIME
504 unless safe_spot $pl;
519 } 505 }
520 }, 506 },
521); 507);
522 508
523cf::client->attach (
524 on_addme => \&addme,
525 on_setup => \&setup,
526);
527
528############################################################################# 509#############################################################################
529 510
530our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs 511our $SCHEDULE_INTERVAL = $cf::CFG{player_schedule_interval} || 10; # time the player scheduler sleeps between runs
531our $SAVE_TIMEOUT = 20; # save players every n seconds 512our $SAVE_TIMEOUT = $cf::CFG{player_save_interval} || 20; # save players every n seconds
532 513
533our $SCHEDULER = cf::async_ext { 514our $SCHEDULER = cf::async_ext {
534 my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL); 515 $Coro::current->{desc} = "player scheduler";
516
535 while () { 517 while () {
536 $schedule_interval->next; 518 Coro::EV::timer_once $SCHEDULE_INTERVAL;
537 519
538 # this weird form of iteration over values is used because 520 # this weird form of iteration over values is used because
539 # the hash changes underneath us frequently, and for 521 # the hash changes underneath us frequently, and for
540 # keeps a direct reference to the value without (in 5.8 perls) 522 # keeps a direct reference to the value without (in 5.8 perls)
541 # keeping a reference, so this is prone to crashes or worse. 523 # keeping a reference, so this is prone to crashes or worse.
… …
545 or next; 527 or next;
546 $pl->valid or next; 528 $pl->valid or next;
547 529
548 eval { 530 eval {
549 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) { 531 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
550 cf::wait_for_tick_begin;
551 $pl->save; 532 $pl->save;
552 533
553 unless ($pl->active) { 534 unless ($pl->active || $pl->ns) {
554 # check refcounts, this is tricky and needs to be adjusted to fit server internals 535 # check refcounts, this is tricky and needs to be adjusted to fit server internals
555 my $ob = $pl->ob; 536 my $ob = $pl->ob;
556 Scalar::Util::weaken $pl; 537
557 Scalar::Util::weaken $ob;
558 my $a_ = $pl->refcnt;#d#
559 my $b_ = $ob->refcnt;#d#
560 my $pl_ref = $pl->refcnt_cnt; 538 my $pl_ref = $pl->refcnt_cnt;
561 my $ob_ref = $ob->refcnt_cnt; 539 my $ob_ref = $ob->refcnt_cnt;
562 540
563 ## pl_ref == one from object + one from cf::PLAYER 541 ## pl_ref == $pl + ob->contr + %cf::PLAYER
564 ## ob_ref == one from simply being an object 542 ## ob_ref == $ob + pl->observe + simply being an object
565 if ($pl_ref == 2 && $ob_ref == 1) { 543 if ($pl_ref == 3 && $ob_ref == 3) {
566 warn "player-scheduler destroy ", $ob->name;#d# 544 warn "player-scheduler destroy ", $ob->name;#d#
567 545
568 # remove from sight and get fresh "copies" 546 # remove from sight and get fresh "copies"
569 $pl = delete $cf::PLAYER{$ob->name}; 547 $pl = delete $cf::PLAYER{$ob->name};
570 $ob = $pl->ob; 548 $ob = $pl->ob;
571 549
572 $ob->destroy;
573 $pl->destroy; 550 $pl->destroy; # destroys $ob
574 } else { 551 } else {
552 my $a_ = $pl->refcnt;#d#
553 my $b_ = $ob->refcnt;#d#
554
575 warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d# 555 warn "player-scheduler refcnt ", $ob->name, " pl $pl_ref ob $ob_ref (C pl $a_ ob $b_)\n";#d#
576 } 556 }
577 } 557 }
578 } 558 }
579 }; 559 };
580 warn $@ if $@; 560 warn $@ if $@;

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines