ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.53 by root, Mon Jun 11 21:38:13 2007 UTC vs.
Revision 1.84 by root, Wed Apr 30 06:40:28 2008 UTC

2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7use List::Util qw(min max);
8 7
9our %EXT_SETUP; 8our $MAX_DISCONNECT_TIME = $cf::CFG{max_disconnect_time} || 3600;
10 9
11# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
12sub nuke_str { 11sub nuke_str {
13 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
14} 13}
41 return unless cf::player::find_active $user; 40 return unless cf::player::find_active $user;
42 41
43 $ns->send_drawinfo ( 42 $ns->send_drawinfo (
44 "That player is already logged in on this server. " 43 "That player is already logged in on this server. "
45 . "If you want to create a new player, choose another name. " 44 . "If you want to create a new player, choose another name. "
46 . "If you are already a registered player, make sure nobody " 45 . "If you have already a registered, make sure nobody "
47 . "else is using your account at this time. If you lost your conenction " 46 . "else is using your account at this time. If you lost your connection "
48 . "then the server will likely timeout within a minute. If you still " 47 . "then the server will likely timeout within a minute. If you still "
49 . "cannot log-in after a minute, you are still logged in. Make sure " 48 . "cannot log-in after a minute, you are still logged in. Make sure "
50 . "you do not have another client running. If you use windows, reboot, " 49 . "you do not have another client running. If you use windows, reboot, "
51 . "this will fix anything.", 50 . "this will fix anything.",
52 cf::NDI_RED 51 cf::NDI_RED
53 ); 52 );
54 53
55 1 54 1
56} 55}
57 56
57sub safe_spot($) {
58 my ($pl) = @_;
59
60 my $ob = $pl->ob;
61
62 my $m = $ob->map
63 or return;
64 my $x = $ob->x;
65 my $y = $ob->y;
66
67# return 0;#d#
68# warn join ":", $m->at ($x, $y);#d#
69# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
70# return 0;
71
72 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
73}
74
58sub enter_map { 75sub enter_map {
59 my ($pl) = @_; 76 my ($pl) = @_;
60 77
78 my $ob = $pl->ob;
79
61 my ($map, $x, $y) 80 my ($map, $x, $y)
62 = $pl->ob->{_link_pos} 81 = $ob->{_link_pos}
63 ? @{delete $pl->ob->{_link_pos}} 82 ? @{delete $ob->{_link_pos}}
64 : ($pl->maplevel, $pl->ob->x, $pl->ob->y); 83 : ($pl->maplevel, $ob->x, $ob->y);
65 84
66 $pl->ob->enter_link; 85 $ob->enter_link;
67 86
87 my $m = cf::map::find $map;
68 if (my $time = delete $pl->{unclean_save}) { 88 my $time = delete $pl->{unclean_save};
69 if (my $m = cf::map::find $map) { 89
90 if ($time && $m) {
70 if ($time < $m->{instantiate_time}) { 91 if ($time < $m->{instantiate_time}) {
71 # the map was reset in the meantime 92 # the map was reset in the meantime
72 my $age = $cf::RUNTIME - $time; 93 my $age = $cf::RUNTIME - $time;
94
73 warn $pl->ob->name, " map reset after logout, logout age $age\n";#d# 95 warn $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
74 96
75 # for now, just go back to savebed 97 if ($age >= $MAX_DISCONNECT_TIME) {
98 $ob->message (
99 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
100 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
101 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
102 . "H<You disconnected too long without having used a savebed.>",
103 cf::NDI_RED
104 );
105 # kill them.
106 # reminds me of the famous badness 10000 syndrome...
107 $ob->stats->hp (-10000); #] if they survive this they deserved to live
108 my $killer = cf::arch::get "killer_login";
109 $pl->killer ($killer);
110 $killer->destroy;
111 } else {
76 ($map, $x, $y) = $pl->savebed; 112 ($map, $x, $y) = $pl->savebed;
77 113
78 $pl->ns->send_drawinfo ( 114 $ob->message (
79 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. " 115 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
80 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. " 116 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
81 . "Better use a savebed next time, much worse things could have happened...", 117 . "Better use a savebed next time, much worse things could have happened... "
118 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
82 cf::NDI_RED 119 cf::NDI_RED
83 ); 120 );
121 }
84 } else { 122 } else {
85 $pl->ns->send_drawinfo ( 123 $ob->message (
86 "You didn't use a bed to reality to leave this realm. This is very dangerous, " 124 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
87 . "as lots of things could happen when you leave by other means, such as cave-ins, " 125 . "as lots of things could happen when you leave by other means, such as cave-ins, "
88 . "or monsters suddenly snapping your body. Better use a savebed next time.", 126 . "or monsters suddenly snapping your body. Better use a savebed next time. "
127 . "H<Always apply a bed of reality to disconnect from the server.>",
89 cf::NDI_RED 128 cf::NDI_RED
90 ); 129 );
91 }
92 } 130 }
93 } 131 }
94 132
95 $pl->ob->goto ($map, $x, $y); 133 $ob->goto ($map, $x, $y);
96} 134}
97 135
98# delete a player directory, be non-blocking AND synchronous... 136# delete a player directory, be non-blocking AND synchronous...
99# (thats hard, so we crap out and fork). 137# (thats hard, so we crap out and fork).
100sub nuke_playerdir { 138sub nuke_playerdir {
101 my ($user) = @_; 139 my ($user) = @_;
102 140
103 aio_stat "$PLAYERDIR/$user"; 141 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
104 system "cd \Q$PLAYERDIR\E "
105 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null "
106 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)";
107}
108 142
109sub send_capabilities { 143 cf::fork_call {
144 rename "$PLAYERDIR/$user", $temp;
145 system "rm", "-rf", $temp;
146 };
147}
148
149cf::client->attach (on_addme => sub {
110 my ($ns) = @_; 150 my ($ns) = @_;
111 151
112 return unless $ns->extcmd;
113
114 $ns->ext_event (capabilities =>
115 # id, name, flags (1 == 2d), edge length
116 tileset => [[1, "default 64x64 faceset", 1, 64], [0, "default 32x32 faceset", 1, 32]],
117 );
118}
119
120sub setup {
121 my ($ns, $args) = @_;
122
123 # run through the cmds of setup
124 # syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
125 #
126 # we send the status of the cmd back, or a FALSE is the cmd is the server unknown
127 # The client then must sort this out
128
129 my %setup = split / +/, $args;
130 while (my ($k, $v) = each %setup) {
131 if ($k eq "sound") {
132 $ns->sound ($v);
133
134 } elsif ($k eq "exp64") {
135 $setup{$k} = 1;
136
137 } elsif ($k eq "spellmon") {
138 $ns->monitor_spells ($v);
139
140 } elsif ($k eq "darkness") {
141 $ns->darkness ($v);
142
143 } elsif ($k eq "map1cmd") {
144 $ns->mapmode (cf::Map1Cmd) if $v > 0;
145
146 } elsif ($k eq "map1acmd") {
147 $ns->mapmode (cf::Map1aCmd) if $v > 0;
148
149 } elsif ($k eq "map2cmd") {
150 # gcfclient bug, map1acmd is sent too late
151 $ns->mapmode (cf::Map1aCmd);
152 $setup{$k} = "FALSE";
153
154 } elsif ($k eq "newmapcmd") {
155 $ns->newmapcmd ($v);
156
157 } elsif ($k eq "mapinfocmd") {
158 $ns->mapinfocmd ($v);
159
160 } elsif ($k eq "extcmd") {
161 $ns->extcmd ($v > 0);
162 send_capabilities $ns;
163
164 } elsif ($k eq "extmap") {
165 $ns->extmap ($v);
166
167 } elsif ($k eq "facecache") {
168 if (!$v) {
169 $v = 1;
170 $setup{$k} = $v;
171 $ns->send_drawinfo ("(trying to forcefully enable facecaching)", cf::NDI_RED);
172 }
173
174 $ns->facecache ($v);
175
176 } elsif ($k eq "faceset") {
177 $ns->faceset (0);
178 $setup{$k} = 0;
179 # $ns->image2 (1)
180
181 } elsif ($k eq "tileset") {
182 $setup{$k} = $ns->faceset ($v & 1);
183
184 } elsif ($k eq "itemcmd") {
185 # Version of the item protocol command to use. Currently,
186 # only supported versions are 1 and 2. Using a numeric
187 # value will make it very easy to extend this in the future.
188 $ns->itemcmd ($v) if $v >= 1 && $v <= 2;
189
190 $setup{$k} = $ns->itemcmd;
191
192 } elsif ($k eq "mapsize") {
193 my ($x, $y) = split /x/, $v;
194
195 $ns->mapx ($x = max 9, min cf::MAP_CLIENT_X, ($x - 1) | 1);
196 $ns->mapy ($y = max 9, min cf::MAP_CLIENT_Y, ($y - 1) | 1);
197
198 $setup{$k} = "${x}x${y}";
199
200 } elsif ($k eq "extendedMapInfos") {
201 $ns->ext_mapinfos ($v);
202
203 } elsif ($k eq "extendedTextInfos") {
204 $ns->has_readable_type ($v);
205
206 } elsif ($k eq "smoothing") { # cfplus-style smoothing
207 $ns->smoothing ($v);
208
209 } elsif ($k eq "fxix") {
210 $ns->fxix ($v);
211
212 } elsif ($k eq "msg") {
213 $ns->can_msg ($v);
214
215 } elsif ($k eq "excmd") {
216 # we support it
217
218 } else {
219 # other commands:
220 # sexp: no idea, probably for oudated servers
221 # tick: more stupidity, server should send a tick per tick
222
223 $setup{$k} = "FALSE";
224 }
225 }
226
227 $ns->send_packet (join " ", setup => %setup);
228
229 cf::datalog setup =>
230 request => $args,
231 reply => \%setup,
232 client => $ns->version,
233 ;
234}
235
236sub addme {
237 my ($ns) = @_;
238
239 if (!$ns->facecache) 152 if (!$ns->facecache)
240 { 153 {
241 $ns->send_drawinfo (<<EOF, cf::NDI_RED); 154 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
242 155
243 156
244*** 157***
245*** WARNING: 158*** WARNING:
246*** Your client does not support face/image caching, 159*** Your client does not support face/image caching,
247*** or it has been disabled. Face caching is mandatory 160*** or it has been disabled. Face caching is mandatory
248*** so please enable it or use a newer client. 161*** so please enable it or use a newer client.
249*** 162***
250*** Look at your client preferences: 163*** Look at your client preferences:
251*** 164***
252*** CFPlus: all known versions automatically enable the facecache. 165*** deliantra: all known versions automatically enable the facecache.
253*** cfclient: use the -cache commandline option. 166*** cfclient: use the -cache commandline option.
254*** cfclient: map will not redraw automatically (bug). 167*** cfclient: map will not redraw automatically (bug).
255*** gcfclient: use -cache commandline option, or enable 168*** gcfclient: use -cache commandline option, or enable
256*** gcfclient: Client=>Configure=>Map & Image=>Cache Images. 169*** gcfclient: Client => Configure => Map & Image => Cache Images.
257*** jcrossclient: your client is broken, use CFPlus or gcfclient. 170*** jcrossclient: your client is broken, use deliantra or gcfclient.
258*** 171***
259*** 172***
260EOF 173EOF
261 if ($ns->version =~ /jcrossclient/) { 174 if ($ns->version =~ /jcrossclient/) {
262 # let them, for now 175 # let them, for now
282 } 195 }
283 196
284 $ns->pl and return $ns->destroy; 197 $ns->pl and return $ns->destroy;
285 198
286 $ns->async (sub { 199 $ns->async (sub {
200 $Coro::current->{desc} = "addme init";
201
287 my ($user, $pass); 202 my ($user, $pass);
288 203
289 $ns->send_packet ("addme_success"); 204 $ns->send_packet ("addme_success");
290 205
291 for (;;) { 206 for (;;) {
314 . "(only a-z, A-Z and 0-9 are allowed), " 229 . "(only a-z, A-Z and 0-9 are allowed), "
315 . "or is not between 3 and 18 characters in length.", 230 . "or is not between 3 and 18 characters in length.",
316 cf::NDI_RED 231 cf::NDI_RED
317 ); 232 );
318 } 233 }
234 Coro::Timer::sleep 0.4;
319 } 235 }
320 236
321 check_playing $ns, $user and next; 237 check_playing $ns, $user and next;
238
239 $Coro::current->{desc} = "addme($user) pass";
322 240
323 $ns->send_drawinfo ( 241 $ns->send_drawinfo (
324 "Welcome $user, please enter your password now. " 242 "Welcome $user, please enter your password now. "
325 . "New users should now choose a password. " 243 . "New users should now choose a password. "
326 . "Anything your client lets you enter is fine.", 244 . "Anything your client lets you enter is fine.",
334 $ns->send_drawinfo ( 252 $ns->send_drawinfo (
335 "Try to use at least three characters as your password please, " 253 "Try to use at least three characters as your password please, "
336 . "that cannot be too much to ask for :)", 254 . "that cannot be too much to ask for :)",
337 cf::NDI_RED 255 cf::NDI_RED
338 ); 256 );
257 Coro::Timer::sleep 0.4;
339 } 258 }
340 259
341 # lock this username for the remainder of this login session 260 # lock this username for the remainder of this login session
342 if ($cf::LOGIN_LOCK{$user}) { 261 if ($cf::LOGIN_LOCK{$user}) {
343 $ns->send_drawinfo ( 262 $ns->send_drawinfo (
348 next; 267 next;
349 } 268 }
350 local $cf::LOGIN_LOCK{$user} = 1; 269 local $cf::LOGIN_LOCK{$user} = 1;
351 270
352 check_playing $ns, $user and next; 271 check_playing $ns, $user and next;
272
273 $Coro::current->{desc} = "addme($user) check";
353 274
354 # try to read the user file and check the password 275 # try to read the user file and check the password
355 if (my $pl = cf::player::find $user) { 276 if (my $pl = cf::player::find $user) {
356 aio_stat $pl->path and next; 277 aio_stat $pl->path and next;
357 my $mtime = (stat _)[9]; 278 my $mtime = (stat _)[9];
411 next; 332 next;
412 } 333 }
413 } 334 }
414 335
415 # the rest of this function is character creation 336 # the rest of this function is character creation
337 $Coro::current->{desc} = "addme($user) chargen";
416 338
417 # just to make sure nothing is left over 339 # just to make sure nothing is left over
418 nuke_playerdir $user; 340 nuke_playerdir $user;
419 341
420 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 342 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
424 nuke_str $pass2; 346 nuke_str $pass2;
425 $ns->send_drawinfo ( 347 $ns->send_drawinfo (
426 "The passwords do not match, please try again.", 348 "The passwords do not match, please try again.",
427 cf::NDI_RED 349 cf::NDI_RED
428 ); 350 );
351 Coro::Timer::sleep 0.5;
429 next; 352 next;
430 } 353 }
431 354
432 nuke_str $pass2; 355 nuke_str $pass2;
433 356
455 $ob->swap_stats ($res - 1, $swap - 1); 378 $ob->swap_stats ($res - 1, $swap - 1);
456 } 379 }
457 } else { 380 } else {
458 $ob->roll_stats; 381 $ob->roll_stats;
459 } 382 }
383
384 Coro::Timer::sleep 0.2;
460 } 385 }
461 386
462 $ob->set_animation (2); 387 $ob->set_animation (2);
463 $ob->add_statbonus; 388 $ob->add_statbonus;
464 389
465 while () { 390 while () {
466 $ns->send_msg (-1, "chargen-race-title", ucfirst $pl->title); 391 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
467 my $msg = $ob->msg; 392 my $msg = $ob->msg;
468 $msg =~ s/(?<=\S)\n(?=\S)/ /g; 393 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
469 $ns->send_msg (cf::NDI_BLUE, "chargen-race-description", $msg); 394 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
470 395
471 my $res = query $ns, cf::CS_QUERY_SINGLECHAR, 396 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
472 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"; 397 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
473 398
474 last if $res =~ /[dD]/; 399 last if $res =~ /[dD]/;
475 400
476 $pl->chargen_race_next; 401 $pl->chargen_race_next;
402 Coro::Timer::sleep 0.2;
477 } 403 }
478 404
479 $pl->chargen_race_done; 405 $pl->chargen_race_done;
406
407 while () {
408 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
409 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
410
411 if ($res =~ /^[fF]/) {
412 $pl->gender (1);
413 last;
414 } elsif ($res =~ /^[mM]/) {
415 $pl->gender (0);
416 last;
417 }
418 Coro::Timer::sleep 0.2;
419 }
420
421 $ob->reply (undef, "Welcome to Deliantra!");
480 422
481 delete $pl->{deny_save}; 423 delete $pl->{deny_save};
482 424
483 last; 425 last;
484 } 426 }
485 }); 427 });
486} 428});
487 429
488cf::register_command quit => sub { 430cf::register_command quit => sub {
489 my ($ob, $arg) = @_; 431 my ($ob, $arg) = @_;
490 432
491 $ob->reply (undef, 433 $ob->reply (undef,
525 467
526 # update respawn position 468 # update respawn position
527 $pl->savebed ($bed->map->path, $bed->x, $bed->y); 469 $pl->savebed ($bed->map->path, $bed->x, $bed->y);
528 cf::async { $pl->save }; 470 cf::async { $pl->save };
529 471
472 my $killer = cf::arch::get "killer_logout";
530 $pl->killer ("left"); 473 $pl->killer ($killer);
474 $killer->destroy;
531 $ob->check_score; 475 $ob->check_score;
532 476
533 $ob->reply (undef, "In the future, you will wake up here when you die."); 477 $ob->reply (undef, "In the future, you will wake up here when you die.");
534 478
535 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { 479 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub {
557 501
558 if ($cleanly) { 502 if ($cleanly) {
559 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 503 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
560 } else { 504 } else {
561 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 505 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
562 $pl->{unclean_save} = $cf::RUNTIME; 506 $pl->{unclean_save} = $cf::RUNTIME
507 unless safe_spot $pl;
563 } 508 }
564 }, 509 },
565); 510);
566 511
567cf::client->attach (
568 on_addme => \&addme,
569 on_setup => \&setup,
570);
571
572############################################################################# 512#############################################################################
573 513
574our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs 514our $SCHEDULE_INTERVAL = $cf::CFG{player_schedule_interval} || 10; # time the player scheduler sleeps between runs
575our $SAVE_TIMEOUT = 20; # save players every n seconds 515our $SAVE_TIMEOUT = $cf::CFG{player_save_interval} || 20; # save players every n seconds
576 516
577our $SCHEDULER = cf::async_ext { 517our $SCHEDULER = cf::async_ext {
578 my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL); 518 $Coro::current->{desc} = "player scheduler";
519
579 while () { 520 while () {
580 $schedule_interval->next; 521 Coro::EV::timer_once $SCHEDULE_INTERVAL;
581 522
582 # this weird form of iteration over values is used because 523 # this weird form of iteration over values is used because
583 # the hash changes underneath us frequently, and for 524 # the hash changes underneath us frequently, and for
584 # keeps a direct reference to the value without (in 5.8 perls) 525 # keeps a direct reference to the value without (in 5.8 perls)
585 # keeping a reference, so this is prone to crashes or worse. 526 # keeping a reference, so this is prone to crashes or worse.
589 or next; 530 or next;
590 $pl->valid or next; 531 $pl->valid or next;
591 532
592 eval { 533 eval {
593 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) { 534 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
594 cf::wait_for_tick_begin;
595 $pl->save; 535 $pl->save;
596 536
597 unless ($pl->active || $pl->ns) { 537 unless ($pl->active || $pl->ns) {
598 # check refcounts, this is tricky and needs to be adjusted to fit server internals 538 # check refcounts, this is tricky and needs to be adjusted to fit server internals
599 my $ob = $pl->ob; 539 my $ob = $pl->ob;
608 548
609 # remove from sight and get fresh "copies" 549 # remove from sight and get fresh "copies"
610 $pl = delete $cf::PLAYER{$ob->name}; 550 $pl = delete $cf::PLAYER{$ob->name};
611 $ob = $pl->ob; 551 $ob = $pl->ob;
612 552
613 $ob->destroy;
614 $pl->destroy; 553 $pl->destroy; # destroys $ob
615 } else { 554 } else {
616 my $a_ = $pl->refcnt;#d# 555 my $a_ = $pl->refcnt;#d#
617 my $b_ = $ob->refcnt;#d# 556 my $b_ = $ob->refcnt;#d#
618 557
619 warn "player-scheduler refcnt ", $ob->name, " pl $pl_ref ob $ob_ref (C pl $a_ ob $b_)\n";#d# 558 warn "player-scheduler refcnt ", $ob->name, " pl $pl_ref/3 ob $ob_ref/3 (C pl $a_/1 ob $b_/2)\n";#d#
620 } 559 }
621 } 560 }
622 } 561 }
623 }; 562 };
624 warn $@ if $@; 563 warn $@ if $@;
625 Coro::cede; 564 cf::cede_to_tick;
626 }; 565 };
627 } 566 }
628}; 567};
629 568
630$SCHEDULER->prio (1); 569$SCHEDULER->prio (1);

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines