ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/ext/login.ext
(Generate patch)

Comparing deliantra/server/ext/login.ext (file contents):
Revision 1.32 by root, Mon Apr 2 18:04:45 2007 UTC vs.
Revision 1.90 by root, Tue Sep 16 16:03:02 2008 UTC

1#! perl # MANDATORY 1#! perl # mandatory
2 2
3# login handling 3# login handling
4 4
5use Fcntl; 5use Fcntl;
6use Coro::AIO; 6use Coro::AIO;
7use List::Util qw(min max);
8 7
9my $PLAYERDIR = sprintf "%s/%s", cf::localdir, cf::playerdir; 8our $MAX_DISCONNECT_TIME = $cf::CFG{max_disconnect_time} || 3600;
10 9
11# paranoia function to overwrite a string-in-place 10# paranoia function to overwrite a string-in-place
12sub nuke_str { 11sub nuke_str {
13 substr $_[0], 0, (length $_[0]), "x" x length $_[0] 12 substr $_[0], 0, (length $_[0]), "x" x length $_[0]
14} 13}
15 14
16sub query { 15sub query {
17 my ($ns, $flags, $text) = @_; 16 my ($ns, $flags, $text) = @_;
18 17
19 my $current = $Coro::current; 18 my $current = $Coro::current;
20 $ns->query ($flags, $text, sub { $current->ready; $current = $_[0]; }); 19 $ns->query ($flags, $text, sub { $current->ready; $current = $_[0] });
21 Coro::schedule while ref $current; 20 Coro::schedule while ref $current;
22 21
23 $current 22 $current
24} 23}
25 24
… …
41 return unless cf::player::find_active $user; 40 return unless cf::player::find_active $user;
42 41
43 $ns->send_drawinfo ( 42 $ns->send_drawinfo (
44 "That player is already logged in on this server. " 43 "That player is already logged in on this server. "
45 . "If you want to create a new player, choose another name. " 44 . "If you want to create a new player, choose another name. "
46 . "If you are already a registered player, make sure nobody " 45 . "If you have already a registered, make sure nobody "
47 . "else is using your account at this time. If you lost your conenction " 46 . "else is using your account at this time. If you lost your connection "
48 . "then the server will likely timeout within a minute. If you still " 47 . "then the server will likely timeout within a minute. If you still "
49 . "cannot log-in after a minute, you are still logged in. Make sure " 48 . "cannot log-in after a minute, you are still logged in. Make sure "
50 . "you do not have another client running. If you use windows, reboot, " 49 . "you do not have another client running. If you use windows, reboot, "
51 . "this will fix anything.", 50 . "this will fix anything.",
52 cf::NDI_RED 51 cf::NDI_RED
53 ); 52 );
54 53
55 1 54 1
56} 55}
57 56
58sub check_clean_save { 57sub safe_spot($) {
59 my ($pl) = @_; 58 my ($pl) = @_;
59
60 my $ob = $pl->ob;
60 61
62 my $m = $ob->map
63 or return;
64 my $x = $ob->x;
65 my $y = $ob->y;
66
67# return 0;#d#
68# warn join ":", $m->at ($x, $y);#d#
69# warn "FOO$m { ".scalar ($m->at ($x, $y))." }\n";
70# return 0;
71
72 scalar grep $_->type == cf::SAVEBED, $m->at ($x, $y)
73}
74
75sub enter_map {
76 my ($pl) = @_;
77
78 warn $pl->ob->name, ": enter map 1\n";#d#
79 my $ob = $pl->ob;
80
81 my ($map, $x, $y)
82 = $ob->{_link_pos}
83 ? @{delete $ob->{_link_pos}}
84 : ($pl->maplevel, $ob->x, $ob->y);
85
86 warn $pl->ob->name, ": enter map 2\n";#d#
87 $ob->enter_link;
88 warn $pl->ob->name, ": enter map 3\n";#d#
89
90 my $m = cf::map::find $map;
61 if (my $time = delete $pl->{unclean_save}) { 91 my $time = delete $pl->{unclean_save};
62 $pl->ns->send_drawinfo ( 92 warn $pl->ob->name, ": enter map 4\n";#d#
93
94 if ($time && $m) {
95 if ($time < $m->{instantiate_time}) {
96 # the map was reset in the meantime
97 my $age = $cf::RUNTIME - $time;
98
99 warn $ob->name, " map reset after logout, logout age $age (>= $MAX_DISCONNECT_TIME)\n";#d#
100
101 if ($age >= $MAX_DISCONNECT_TIME) {
102 $ob->message (
103 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
104 . "Unfortunately, nobody was near to help you when the monsters arrived to eat you. "
105 . "Maybe you can find comfort in the thought that your body was quite satisfying in taste... "
106 . "H<You disconnected too long without having used a savebed.>",
107 cf::NDI_RED
108 );
109 # kill them.
110 # reminds me of the famous badness 10000 syndrome...
111 $ob->stats->hp (-10000); #] if they survive this they deserved to live
112 my $killer = cf::arch::get "killer_login"; $pl->killer ($killer); $killer->destroy;
113 } else {
114 ($map, $x, $y) = $pl->savebed;
115
116 $ob->message (
117 "You didn't use a bed to reality to leave this realm, leaving your body in great danger. "
118 . "Fortunately, some friendly dwellers found you, checked your passport, and brought you to safety. "
119 . "Better use a savebed next time, much worse things could have happened... "
120 . "H<You disconnected without having used a savebed. When you do that for too long, you might die.>",
121 cf::NDI_RED
122 );
123 }
124 } else {
125 $ob->message (
63 "You didn't use a savebed to leave this realm. This is very dangerous, " 126 "You didn't use a bed to reality to leave this realm. This is very dangerous, "
64 . "as lots of things could happen when you leave by other means, such as cave-ins, " 127 . "as lots of things could happen when you leave by other means, such as cave-ins, "
65 . "or monsters suddenly snapping your body. Better use a savebed next time.", 128 . "or monsters suddenly snapping your body. Better use a savebed next time. "
129 . "H<Always apply a bed of reality to disconnect from the server.>",
66 cf::NDI_RED 130 cf::NDI_RED
67 ); 131 );
68 #d#TODO 132 }
69 } 133 }
134
135 warn $pl->ob->name, ": enter map 5\n";#d#
136 #$ob->goto ($map, $x, $y);
137 $ob->goto ($map, $x, $y, sub {
138 warn $pl->ob->name, ": enter map check\n";#d#
139 $_[0]
140 }, sub {
141 warn $pl->ob->name, ": enter map done\n";#d#
142 });
143 warn $pl->ob->name, ": enter map 6\n";#d#
144
70} 145}
71 146
72# delete a player directory, be non-blocking AND synchronous... 147# delete a player directory, be non-blocking AND synchronous...
73# (thats hard, so we crap out and fork). 148# (thats hard, so we crap out and fork).
74sub nuke_playerdir { 149sub nuke_playerdir {
75 my ($user) = @_; 150 my ($user) = @_;
76 151
77 aio_stat "$PLAYERDIR/$user"; 152 my $temp = "$PLAYERDIR/~$Coro::current~deleting~";
78 system "cd \Q$PLAYERDIR\E "
79 . "&& mv \Q$user\E ~\Q$Coro::current\E~deleting~ 2>/dev/null "
80 . "&& (rm -rf ~\Q$Coro::current\E~deleting~ &)";
81}
82 153
83sub addme { 154 cf::fork_call {
155 rename "$PLAYERDIR/$user", $temp;
156 system "rm", "-rf", $temp;
157 };
158}
159
160cf::client->attach (on_addme => sub {
84 my ($ns) = @_; 161 my ($ns) = @_;
85 162
86 if (!$ns->facecache) 163 if (!$ns->facecache)
87 { 164 {
88 $ns->send_drawinfo (<<EOF, cf::NDI_RED); 165 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
89 166
90 167
91*** 168***
92*** WARNING: 169*** WARNING:
93*** Your client does not support face/image caching, 170*** Your client does not support face/image caching,
94*** or it has been disabled. Face caching is mandatory 171*** or it has been disabled. Face caching is mandatory
95*** so please enable it or use a newer client. 172*** so please enable it or use a newer client.
96*** 173***
97*** Look at your client preferences: 174*** Look at your client preferences:
98*** 175***
99*** CFPlus: all known versions automatically enable the facecache. 176*** deliantra: all known versions automatically enable the facecache.
100*** cfclient: use the -cache commandline option. 177*** cfclient: use the -cache commandline option.
101*** cfclient: map will not redraw automatically (bug). 178*** cfclient: map will not redraw automatically (bug).
102*** gcfclient: use -cache commandline option, or enable 179*** gcfclient: use -cache commandline option, or enable
103*** gcfclient: Client=>Configure=>Map & Image=>Cache Images. 180*** gcfclient: Client => Configure => Map & Image => Cache Images.
104*** jcrossclient: your client is broken, use CFPlus or gcfclient. 181*** jcrossclient: your client is broken, use deliantra or gcfclient.
105*** 182***
106*** 183***
107EOF 184EOF
108 if ($ns->version =~ /jcrossclient/) { 185 if ($ns->version =~ /jcrossclient/) {
109 # let them, for now 186 # let them, for now
… …
111 $ns->flush; 188 $ns->flush;
112 return $ns->destroy; 189 return $ns->destroy;
113 } 190 }
114 191
115 # $ns->facecache = true; 192 # $ns->facecache = true;
116 } 193 }
194
195 if ($ns->mapmode < cf::Map1aCmd) {
196 $ns->send_drawinfo (<<EOF, cf::NDI_RED);
197
198
199***
200*** WARNING:
201*** Your client is too old. Please upgrade to a newer version.
202EOF
203
204 $ns->flush;
205 return $ns->destroy;
206 }
117 207
118 $ns->pl and return $ns->destroy; 208 $ns->pl and return $ns->destroy;
119 209
120 $ns->async (sub { 210 $ns->async (sub {
211 $Coro::current->{desc} = "addme init";
212
121 my ($user, $pass); 213 my ($user, $pass);
122 214
123 $ns->send_packet ("addme_success"); 215 $ns->send_packet ("addme_success");
124 216
125 for (;;) { 217 for (;;) {
… …
130 cf::NDI_BLUE 222 cf::NDI_BLUE
131 ); 223 );
132 224
133 # read username 225 # read username
134 while () { 226 while () {
135 $user = query $ns, 0, "What is your name?\n:"; 227 $user = query $ns, 0, "What is your name? (login names are case-sensitive)\n:";
136 228
137 if ($cf::LOGIN_LOCK{$user}) { 229 if ($cf::LOGIN_LOCK{$user}) {
138 $ns->send_drawinfo ( 230 $ns->send_drawinfo (
139 "That username is currently used in another login session. " 231 "That username is currently used in another login session. "
140 . "Chose another, or wait till the other session has ended.", 232 . "Chose another, or wait till the other session has ended.",
… …
148 . "(only a-z, A-Z and 0-9 are allowed), " 240 . "(only a-z, A-Z and 0-9 are allowed), "
149 . "or is not between 3 and 18 characters in length.", 241 . "or is not between 3 and 18 characters in length.",
150 cf::NDI_RED 242 cf::NDI_RED
151 ); 243 );
152 } 244 }
245 Coro::Timer::sleep 0.4;
153 } 246 }
154 247
155 check_playing $ns, $user and next; 248 check_playing $ns, $user and next;
249
250 $Coro::current->{desc} = "addme($user) pass";
156 251
157 $ns->send_drawinfo ( 252 $ns->send_drawinfo (
158 "Welcome $user, please enter your password now. " 253 "Welcome $user, please enter your password now. "
159 . "New users should now choose a password. " 254 . "New users should now choose a password. "
160 . "Anything your client lets you enter is fine.", 255 . "Anything your client lets you enter is fine.",
… …
168 $ns->send_drawinfo ( 263 $ns->send_drawinfo (
169 "Try to use at least three characters as your password please, " 264 "Try to use at least three characters as your password please, "
170 . "that cannot be too much to ask for :)", 265 . "that cannot be too much to ask for :)",
171 cf::NDI_RED 266 cf::NDI_RED
172 ); 267 );
268 Coro::Timer::sleep 0.4;
173 } 269 }
174 270
175 # lock this username for the remainder of this login session 271 # lock this username for the remainder of this login session
176 if ($cf::LOGIN_LOCK{$user}) { 272 if ($cf::LOGIN_LOCK{$user}) {
177 $ns->send_drawinfo ( 273 $ns->send_drawinfo (
… …
183 } 279 }
184 local $cf::LOGIN_LOCK{$user} = 1; 280 local $cf::LOGIN_LOCK{$user} = 1;
185 281
186 check_playing $ns, $user and next; 282 check_playing $ns, $user and next;
187 283
284 $Coro::current->{desc} = "addme($user) check";
285
188 # try to read the user file and check the password 286 # try to read the user file and check the password
189 if (my $pl = cf::player::find $user) { 287 if (my $pl = cf::player::find $user) {
190 aio_stat $pl->path and next; 288 aio_stat $pl->path and next;
191 my $mtime = (stat _)[9]; 289 my $mtime = (stat _)[9];
192 my $hash = $pl->password; 290 my $hash = $pl->password;
… …
194 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) { 292 if ($cf::CFG{ext_login_nocheck} or $hash eq crypt $pass, $hash) {
195 nuke_str $pass; 293 nuke_str $pass;
196 # password matches, wonderful 294 # password matches, wonderful
197 my $pl = cf::player::find $user or next; 295 my $pl = cf::player::find $user or next;
198 $pl->connect ($ns); 296 $pl->connect ($ns);
199 check_clean_save $pl; 297 $pl->ob->flag (cf::FLAG_DEBUG, 1);#d# temp
298 enter_map $pl;
200 last; 299 last;
201 } elsif (can_cleanup $pl, $mtime) { 300 } elsif (can_cleanup $pl, $mtime) {
202 Coro::Timer::sleep 1; 301 Coro::Timer::sleep 1;
203 302
204 $ns->send_drawinfo ( 303 $ns->send_drawinfo (
… …
229 . "(check for Numlock and other semi-obvious error sources).", 328 . "(check for Numlock and other semi-obvious error sources).",
230 cf::NDI_RED 329 cf::NDI_RED
231 ); 330 );
232 next; 331 next;
233 } 332 }
333 } else {
334 # unable to load the playerfile:
335 # check wether the player dir exists, which means the file is corrupted or
336 # something very similar.
337 if (!aio_stat cf::player::playerdir $user) {
338 $ns->send_drawinfo (
339 "Unable to retrieve this player. It might be a locked or broken account. "
340 . "If this is your account, ask a dungeon master for assistance. "
341 . "Otherwise choose a different login name.",
342 cf::NDI_RED
343 );
344 next;
345 }
234 } 346 }
235 347
236 # the rest of this function is character creation 348 # the rest of this function is character creation
349 $Coro::current->{desc} = "addme($user) chargen";
237 350
238 # just to make sure nothing is left over 351 # just to make sure nothing is left over
239 nuke_playerdir $user; 352 nuke_playerdir $user;
240 353
241 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again."; 354 my $pass2 = query $ns, cf::CS_QUERY_HIDEINPUT, "Please type your password again.";
… …
245 nuke_str $pass2; 358 nuke_str $pass2;
246 $ns->send_drawinfo ( 359 $ns->send_drawinfo (
247 "The passwords do not match, please try again.", 360 "The passwords do not match, please try again.",
248 cf::NDI_RED 361 cf::NDI_RED
249 ); 362 );
363 Coro::Timer::sleep 0.5;
250 next; 364 next;
251 } 365 }
252 366
253 nuke_str $pass2; 367 nuke_str $pass2;
254 368
255 my $pl = cf::player::new $user; 369 my $pl = cf::player::new $user;
256 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]); 370 $pl->password (crypt $pass, join '', ('.', '/', 0..9, 'A'..'Z', 'a'..'z')[rand 64, rand 64]);
257 nuke_str $pass; 371 nuke_str $pass;
258 $pl->connect ($ns); 372 $pl->connect ($ns);
259
260 my $ob = $pl->ob; 373 my $ob = $pl->ob;
374
375 $ob->goto ($pl->maplevel, $ob->x, $ob->y);
261 376
262 while () { 377 while () {
263 $ob->update_stats; 378 $ob->update_stats;
264 $pl->save_stats; 379 $pl->save_stats;
265 380
… …
275 $ob->swap_stats ($res - 1, $swap - 1); 390 $ob->swap_stats ($res - 1, $swap - 1);
276 } 391 }
277 } else { 392 } else {
278 $ob->roll_stats; 393 $ob->roll_stats;
279 } 394 }
395
396 Coro::Timer::sleep 0.05;
280 } 397 }
281 398
282 $ob->set_animation (2); 399 $ob->set_animation (2);
283 $ob->add_statbonus; 400 $ob->add_statbonus;
284 401
285 $ns->send_drawinfo ($ob->msg, cf::NDI_BLUE); 402 while () {
286 $ns->send_packet (sprintf "query %d %s", cf::CS_QUERY_SINGLECHAR, 403 $ns->send_msg ("chargen-race-title", ucfirst $pl->title, -1);
404 my $msg = $ob->msg;
405 $msg =~ s/(?<=\S)\n(?=\S)/ /g;
406 $ns->send_msg ("chargen-race-description", $msg, cf::NDI_BLUE);
407
408 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
287 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n"); 409 "Now choose a character.\nPress any key to change outlook.\nPress `d' when you're pleased.\n";
288 410
289 $ns->state (cf::ST_CHANGE_CLASS); 411 last if $res =~ /[dD]/;
412
413 $pl->chargen_race_next;
414 Coro::Timer::sleep 0.2;
415 }
416
417 # create the playerdir, if necessary, as chargen_race_done did it before
418 # presumably because of unique maps
419 aio_mkdir playerdir $pl, 0770;
420 $pl->chargen_race_done;
421
422 while () {
423 my $res = query $ns, cf::CS_QUERY_SINGLECHAR,
424 "Now choose a gender.\nPress 'f' to become female, and 'm' to become male.\n";
425
426 if ($res =~ /^[fF]/) {
427 $pl->gender (1);
428 last;
429 } elsif ($res =~ /^[mM]/) {
430 $pl->gender (0);
431 last;
432 }
433 Coro::Timer::sleep 0.2;
434 }
435
436 $ob->reply (undef, "Welcome to Deliantra!");
437
290 delete $pl->{deny_save};#d# too early 438 delete $pl->{deny_save};
291 439
292 last; 440 last;
293 } 441 }
294 }); 442 });
295} 443});
296 444
297cf::register_command quit => sub { 445cf::register_command quit => sub {
298 my ($ob, $arg) = @_; 446 my ($ob, $arg) = @_;
299 447
300 $ob->reply (undef, 448 $ob->reply (undef,
… …
334 482
335 # update respawn position 483 # update respawn position
336 $pl->savebed ($bed->map->path, $bed->x, $bed->y); 484 $pl->savebed ($bed->map->path, $bed->x, $bed->y);
337 cf::async { $pl->save }; 485 cf::async { $pl->save };
338 486
339 $pl->killer ("left"); 487 my $killer = cf::arch::get "killer_logout"; $pl->killer ($killer); $killer->destroy;
340 $ob->check_score; 488 $ob->check_score;
341 489
342 $ob->reply (undef, "In the future, you will wake up here when you die."); 490 $ob->reply (undef, "In the future, you will wake up here when you die.");
343 491
344 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub { 492 $pl->ns->query (cf::CS_QUERY_SINGLECHAR, "Do you want to continue playing (y/n)?", sub {
… …
366 514
367 if ($cleanly) { 515 if ($cleanly) {
368 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 516 $_->ob->message ("$name left the game.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
369 } else { 517 } else {
370 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list; 518 $_->ob->message ("$name uncerimoniously disconnected.", cf::NDI_DK_ORANGE | cf::NDI_UNIQUE) for cf::player::list;
371 $pl->{unclean_save} = $cf::RUNTIME; 519 $pl->{unclean_save} = $cf::RUNTIME
520 unless safe_spot $pl;
372 } 521 }
373 }, 522 },
374); 523);
375 524
376sub setup {
377 my ($ns, $args) = @_;
378
379 # run through the cmds of setup
380 # syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
381 #
382 # we send the status of the cmd back, or a FALSE is the cmd is the server unknown
383 # The client then must sort this out
384
385 my %setup = split / +/, $args;
386 while (my ($k, $v) = each %setup) {
387
388 if ($k eq "sound") {
389 $ns->sound ($v);
390
391 } elsif ($k eq "exp64") {
392 $setup{$k} = 1;
393
394 } elsif ($k eq "spellmon") {
395 $ns->monitor_spells ($v);
396
397 } elsif ($k eq "darkness") {
398 $ns->darkness ($v);
399
400 } elsif ($k eq "map1cmd") {
401 $ns->mapmode (cf::Map1Cmd) if $v > 0;
402
403 } elsif ($k eq "map1acmd") {
404 $ns->mapmode (cf::Map1aCmd) if $v > 0;
405
406 } elsif ($k eq "newmapcmd") {
407 $ns->newmapcmd ($v);
408
409 } elsif ($k eq "mapinfocmd") {
410 $ns->mapinfocmd ($v);
411
412 } elsif ($k eq "extcmd") {
413 $ns->extcmd ($v > 0);
414
415 } elsif ($k eq "extmap") {
416 $ns->extmap ($v);
417
418 } elsif ($k eq "facecache") {
419 $ns->facecache ($v);
420
421 } elsif ($k eq "faceset") {
422 $ns->faceset (0);
423 $setup{$k} = 0;
424 # $ns->image2 (1)
425
426 } elsif ($k eq "itemcmd") {
427 # Version of the item protocol command to use. Currently,
428 # only supported versions are 1 and 2. Using a numeric
429 # value will make it very easy to extend this in the future.
430 $ns->itemcmd ($v) if $v >= 1 && $v <= 2;
431
432 $setup{$k} = $ns->itemcmd;
433
434 } elsif ($k eq "mapsize") {
435 my ($x, $y) = split /x/, $v;
436
437 $ns->mapx ($x = max 9, min cf::MAP_CLIENT_X, $x);
438 $ns->mapy ($y = max 9, min cf::MAP_CLIENT_Y, $y);
439
440 $setup{$k} = "${x}x${y}";
441
442 } elsif ($k eq "extendedMapInfos") {
443 $ns->ext_mapinfos ($v);
444
445 } elsif ($k eq "extendedTextInfos") {
446 $ns->has_readable_type ($v);
447
448 } else {
449 # other commands:
450 # sexp: no idea, probably for oudated servers
451 # tick: more stupidity, server should sned a tick per tick
452
453 $setup{$k} = "FALSE";
454 }
455 }
456
457 $ns->send_packet (join " ", setup => %setup);
458
459 cf::datalog setup =>
460 request => $args,
461 reply => \%setup,
462 client => $ns->version,
463 ;
464}
465
466cf::client->attach (
467 on_addme => \&addme,
468 on_setup => \&setup,
469);
470
471############################################################################# 525#############################################################################
472 526
473our $SCHEDULE_INTERVAL = 10; # time the player scheduler sleeps between runs 527our $SCHEDULE_INTERVAL = $cf::CFG{player_schedule_interval} || 10; # time the player scheduler sleeps between runs
474our $SAVE_TIMEOUT = 20; # save players every n seconds 528our $SAVE_TIMEOUT = $cf::CFG{player_save_interval} || 20; # save players every n seconds
475 529
476our $SCHEDULER = cf::async_ext { 530our $SCHEDULER = cf::async_ext {
477 my $schedule_interval = Coro::Event->timer (after => 1, interval => $SCHEDULE_INTERVAL); 531 $Coro::current->{desc} = "player scheduler";
532
478 while () { 533 while () {
479 $schedule_interval->next; 534 Coro::EV::timer_once $SCHEDULE_INTERVAL;
480 535
481 # this weird form of iteration over values is used because 536 # this weird form of iteration over values is used because
482 # the hash changes underneath us frequently, and for 537 # the hash changes underneath us frequently, and for
483 # keeps a direct reference to the value without (in 5.8 perls) 538 # keeps a direct reference to the value without (in 5.8 perls)
484 # keeping a reference, so this is prone to crashes or worse. 539 # keeping a reference, so this is prone to crashes or worse.
… …
488 or next; 543 or next;
489 $pl->valid or next; 544 $pl->valid or next;
490 545
491 eval { 546 eval {
492 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) { 547 if ($pl->{last_save} + $SAVE_TIMEOUT <= $cf::RUNTIME) {
493 $cf::WAIT_FOR_TICK_ONE->wait;
494 $pl->save; 548 $pl->save;
495 549
496 unless ($pl->active) { 550 unless ($pl->active || $pl->ns) {
497 # check refcounts, this is tricky and needs to be adjusted to fit server internals 551 # check refcounts, this is tricky and needs to be adjusted to fit server internals
498 my $ob = $pl->ob; 552 my $ob = $pl->ob;
499 Scalar::Util::weaken $pl; 553
500 Scalar::Util::weaken $ob;
501 my $a_ = $pl->refcnt;#d#
502 my $b_ = $ob->refcnt;#d#
503 my $pl_ref = $pl->refcnt_cnt; 554 my $pl_ref = $pl->refcnt_cnt;
504 my $ob_ref = $ob->refcnt_cnt; 555 my $ob_ref = $ob->refcnt_cnt;
505 556
506 ## pl_ref == one from object + one from cf::PLAYER 557 ## pl_ref == $pl + ob->contr + %cf::PLAYER
507 ## ob_ref == one from simply being an object 558 ## ob_ref == $ob + pl->observe + simply being an object
508 if ($pl_ref == 2 && $ob_ref == 1) { 559 if ($pl_ref == 3 && $ob_ref == 3) {
509 warn "player-scheduler destroy ", $ob->name;#d# 560 warn "player-scheduler destroy ", $ob->name;#d#
510 561
511 # remove from sight and get fresh "copies" 562 # remove from sight and get fresh "copies"
512 $pl = delete $cf::PLAYER{$ob->name}; 563 $pl = delete $cf::PLAYER{$ob->name};
513 $ob = $pl->ob; 564 $ob = $pl->ob;
514 565
515 $ob->destroy;
516 $pl->destroy; 566 $pl->destroy; # destroys $ob
517 } else { 567 } else {
568 my $a_ = $pl->refcnt;#d#
569 my $b_ = $ob->refcnt;#d#
570
518 warn "player-scheduler refcnt ", $ob->name, " $pl_ref,$a_ $ob_ref,$b_\n";#d# 571 warn "player-scheduler refcnt ", $ob->name, " pl $pl_ref/3 ob $ob_ref/3 (C pl $a_/1 ob $b_/2)\n";#d#
519 } 572 }
520 } 573 }
521 } 574 }
522 }; 575 };
523 warn $@ if $@; 576 warn $@ if $@;
524 Coro::cede; 577 cf::cede_to_tick;
525 }; 578 };
526 } 579 }
527}; 580};
528 581
529$SCHEDULER->prio (1); 582$SCHEDULER->prio (1);

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines