--- deliantra/server/ext/schmorplog.ext	2008/05/03 11:14:50	1.19
+++ deliantra/server/ext/schmorplog.ext	2010/05/04 21:45:42	1.29
@@ -1,11 +1,13 @@
-#! perl # depends=irc
+#! perl # depends=irc mandatory
 
 # statistics-package
 
 use Fcntl;
 use Coro::AIO;
 
-our $UPDATE_LOGINS = EV::idle sub {
+our %PLAYERSEEN;
+
+our $UPDATE_LOGINS = AE::idle sub {
    $_[0]->stop;
 
    cf::async {
@@ -45,51 +47,58 @@
 cf::player->attach (
    on_login => sub {
       my ($pl) = @_;
+
       $pl->ob->kv_set (schmorplog_last_login => time);
 
       $pl->ob->kv_set (schmorplog_login_count =>
          1 + $pl->ob->kv_get ("schmorplog_login_count"));
 
-      (my $client = $pl->ns->version) =~ s/\n/\\n/g;
+      $pl->ob->kv_set (schmorplog_client => $pl->ns->{who_version});
 
-      $pl->ob->kv_set (schmorplog_client => $client);
+      my $name = $pl->ob->name;
 
-      ext::irc::do_notice (sprintf "%s logged in", $pl->ob->name);
+      ext::irc::do_notice $name . " logged in";
 
+      undef $PLAYERSEEN{$name};
       $UPDATE_LOGINS->start;
 
-      warn "LOGIN: ", $pl->ob->name, " from ", $pl->ns->host;
+      cf::trace "LOGIN: ", $pl->ob->name, " from ", $pl->ns->host;
    },
    on_logout => sub {
       my ($pl, $cleanly) = @_;
       $pl->ob->kv_set (schmorplog_last_logout => time);
-      ext::irc::do_notice (sprintf "%s left", $pl->ob->name);
+      ext::irc::do_notice $pl->ob->name . " left";
 
       $UPDATE_LOGINS->start;
 
-      warn "LOGOUT: ", $pl->ob->name, " from ", $pl->ns->host, " ($cleanly)";
+      cf::trace "LOGOUT: ", $pl->ob->name, " from ", $pl->ns->host, " ($cleanly)";
    },
    on_birth => sub {
       my ($pl) = @_;
-      ext::irc::do_notice (sprintf "%s was just born", $pl->ob->name);
       $pl->ob->kv_set (schmorplog_birthdate => time);
+      ext::irc::do_notice $pl->ob->name . " was just born";
 
-      warn "BIRTH: ", $pl->ob->name, " from ", $pl->ns->host;
+      cf::trace "BIRTH: ", $pl->ob->name, " from ", $pl->ns->host;
    },
    on_quit => sub {
       my ($pl) = @_;
-      ext::irc::do_notice (sprintf "%s quit the game", $pl->ob->name);
+      ext::irc::do_notice $pl->ob->name . " quit the game";
 
-      warn "QUIT: ", $pl->ob->name, " from ", $pl->ns->host;
+      cf::trace "QUIT: ", $pl->ob->name, " from ", $pl->ns->host;
    },
    on_death => sub {
       my ($pl) = @_;
-      ext::irc::do_notice (sprintf "%s was killed by %s", $pl->ob->name, $pl->killer_name);
+
+      my $msg = $pl->expand_cfpod ($pl->ob->name . " was killed by " . $pl->killer_name . ".");
+      ext::irc::do_notice $msg;
 
       ++$pl->ob->{stats_death}{$pl->killer_name};
 
       $pl->ob->kv_set (schmorplog_death_count =>
          1 + $pl->ob->kv_get ("schmorplog_death_count"));
+
+      $_->send_msg ("" => $msg, cf::NDI_VERBATIM)
+         for cf::player::list;
    },
    on_load => sub {
       my ($pl, $path) = @_;
@@ -116,10 +125,10 @@
          my $s = $pl->ob->{stats_death}
             or return $who->reply ($npc, "$args didn't die even once.");
 
-         my $rep = "$args died a total of " . $pl->ob->kv_set ("schmorplog_death_count") . " times, among them:\n\n\n\n";
+         my $rep = "$args died a total of " . $pl->ob->kv_get ("schmorplog_death_count") . " times, among them:\n\n";
 
          for (sort { $s->{$b} <=> $s->{$a} } keys %$s) {
-            $rep .= "$s->{$_} time(s) due to $_.\n\n";
+            $rep .= sprintf " C<%4d> time(s) due to %s.\n", $s->{$_}, $_;
          }
 
          $who->reply ($npc, $rep);
@@ -132,9 +141,9 @@
          my $s = $pl->ob->{stats_kill}
             or return $who->reply ($npc, "I don't know of I<anything> that $args has killed so far.");
 
-         my $rep = sprintf "\n\nC<%6s> %s\n\n", "Kills", "Name";
-         for (sort { $s->{$a} <=> $s->{$b} } keys %$s) {
-            $rep .= sprintf "C<%6s> %s\n\n", $s->{$_}, $_;
+         my $rep = sprintf "Here is a list of all the kills I know about:\n\n";
+         for (sort { $s->{$b} <=> $s->{$a} } keys %$s) {
+            $rep .= sprintf " C<%6s> %s\n", $s->{$_}, $_;
          }
 
          $who->reply ($npc, $rep);
@@ -142,8 +151,8 @@
    } elsif ($cmd eq "hi") {
       $who->reply ($npc, "Hello!\n\n"
                    . "I am a statistician, I keep statistics about all people here.\n\n"
-                   . "To know how often somebody died, ask C<deaths> I<playername>\n\n"
-                   . "To know how many kills somebody scored, ask C<kills> I<playername>");
+                   . " - To know how often somebody died, ask C<deaths> I<playername>\n"
+                   . " - To know how many kills somebody scored, ask C<kills> I<playername>");
    } else {
       $who->reply ($npc, "No idea what you want of me, how about saying 'hi' first?");
    }
@@ -151,3 +160,53 @@
    $cmd = lc $cmd;
 };
 
+# log "crash" messages, i.e. client exit reasons
+cf::register_exticmd clientlog => sub {
+   my ($ns, $msg) = @_;
+
+   my $name = $ns->pl && $ns->pl->ob ? $ns->pl->ob->name : "<unknown>";
+
+   $msg =~ y/\x0a\x20-\x7f//cd;
+   $msg =~ s/\s+$//;
+
+   cf::error sprintf "clientlog [%s/%s]: %s\n", $ns->host, $name, $msg;
+
+   ()
+};
+
+# log max playercount every minute
+#############################################################################
+
+our $STATSDIR = "$LOCALDIR/maxplayers";
+
+mkdir $STATSDIR;
+
+our $WRITE_MAXPLAYERS = EV::periodic 0, 60, undef, sub {
+   my $now = AE::now;
+   my $cnt = scalar keys %PLAYERSEEN;
+   
+   %PLAYERSEEN = map +($_->ob->name => undef), grep $_->ns, cf::player::list;
+
+   my @time = gmtime $now;
+
+   my $path = sprintf "%s/%04d-%02d-%02d", $STATSDIR, $time[5] + 1900, $time[4] + 1, $time[3];
+   my $offs = $time [2] * 60 + $time [1];
+   
+   $cnt++;
+   $cnt = 254 if $cnt > 254;
+   $cnt = chr $cnt;
+
+   IO::AIO::aio_open $path, O_WRONLY | O_CREAT, 0666, sub {
+      my $fh = shift
+         or return;
+
+      # the truncate is 1440 extra syscalls, but saves 1439
+      # slow metadata updates.
+      IO::AIO::aio_truncate $fh, 1440, sub {
+         IO::AIO::aio_write $fh, $offs, 1, $cnt, 0, sub {
+            IO::AIO::aio_close $fh;
+         };
+      };
+   };
+};
+