--- deliantra/server/ext/widget.ext	2007/07/21 18:01:26	1.11
+++ deliantra/server/ext/widget.ext	2007/07/24 19:33:57	1.16
@@ -1,10 +1,10 @@
 #! perl # mandatory depends=login
 
 # sends the following ext message types
-# ws_n       id                                # widgetset new
-# ws_d       id                                # widgetset destroy
+# ws_n       ws                                # widgetset new
+# ws_d       ws                                # widgetset destroy
 # ws_c       ws id class args                  # widgetset create
-# w_c        id [rid] name args                # widget method call
+# w_c        id rid name args                  # widget method call
 # w_s        id @attr                          # widget member set
 # w_g        id rid @attr                      # widget member get
 #
@@ -12,6 +12,8 @@
 # w_r        rid res                           # widget call return
 # w_e        id name args                      # widget_event
 
+our $DEBUG = 1;
+
 cf::client->attach (
    on_connect => sub {
       my ($ns) = @_;
@@ -19,7 +21,7 @@
       Scalar::Util::weaken (my $weakns = $ns);
 
       $ns->{id} = "a";
-      $ns->{json_coder}->filter_json_single_key_object (__widget_ref__ => sub {
+      $ns->{json_coder}->filter_json_single_key_object (__w_ => sub {
         # cannot deserialise ATM
         undef
       });
@@ -97,11 +99,11 @@
 );
 
 cf::register_exticmd w_e => sub {
-   my ($ns, $pkt) = @_;
+   my ($ns, $id, $name, $args) = @_;
 
-   if (my $w = $ns->{widget}{$pkt->{id}}) {
-      if (my $cb = $w->{ev}{$pkt->{name}}) {
-         $_->($w, @{ $pkt->{args} || [] })
+   if (my $w = $ns->{widget}{$id}) {
+      if (my $cb = $w->{ev}{$name}) {
+         $_->($w, @$args)
             for @$cb;
       }
    }
@@ -110,10 +112,10 @@
 };
 
 cf::register_exticmd w_r => sub {
-   my ($ns, $pkt) = @_;
+   my ($ns, $rid, $res) = @_;
 
-   if (my $cb = delete $ns->{widget_return}{$pkt->{rid}}) {
-      $cb->(@{$pkt->{res} || [] });
+   if (my $cb = delete $ns->{widget_return}{$rid}) {
+      $cb->(@$res);
    }
 
    ()
@@ -127,10 +129,10 @@
    my $ws = bless {
       id => $id,
       ns => $self,
-      w  => {},
+      _w => {},
    }, "ext::widget::set";
 
-   $ws->msg (ws_n => id => $id);
+   $ws->msg (ws_n => $id);
 
    $ws
 }
@@ -146,18 +148,18 @@
 sub destroy {
    my ($self) = @_;
 
-   $self->msg (ws_d => id => $self->{id});
+   $self->msg (ws_d => $self->{id});
    delete $self->{ns};
    $_->destroy
       for values %{ $self->{w} };
 }
 
 sub msg {
-   my ($self, $type, %msg) = @_;
+   my ($self, @msg) = @_;
 
    if (my $ns = shift->{ns}) {
-      $msg{msgtype} = $type;
-      $ns->send_packet ("ext " . $ns->{json_coder}->encode (\%msg));
+      warn "msg " . $ns->{json_coder}->encode (\@msg) if $DEBUG;#d#
+      $ns->send_packet ("ext " . $ns->{json_coder}->encode (\@msg));
    }
 }
 
@@ -166,10 +168,11 @@
 
    my $id = ++$self->{ns}{id};
 
-   my $proxy = $self->{w}{$id} = bless {
+   my $proxy = bless {
       id => $id,
    }, "ext::widget::proxy";
 
+   Scalar::Util::weaken ($self->{_w}{$id} = $proxy);
    Scalar::Util::weaken ($proxy->{ws} = $self);
    Scalar::Util::weaken ($proxy->{ns} = $self->{ns});
    Scalar::Util::weaken ($self->{ns}{widget}{$id} = $proxy);
@@ -180,10 +183,10 @@
    }
 
    $self->msg (ws_c =>
-      ws    => $self->{w}{id},
-      id    => $id,
-      class => $class,
-      args  => \%args,
+      $self->{id},
+      $id,
+      $class,
+      \%args,
    );
 
    $proxy
@@ -199,30 +202,26 @@
    delete $self->{ns}{widget}{$self->{id}};
 
    if (my $ws = $self->{ws}) {
-      delete $ws->{w}{$self->{id}};
-      $self->msg (w_c => name => "destroy");
+      $self->msg (w_c => 0, "destroy");
+      delete $ws->{_w}{$self->{id}};
    }
 }
 
 sub msg {
-   my ($self, $type, %msg) = @_;
+   my ($self, $type, @arg) = @_;
 
    if (my $ws = $self->{ws}) {
-      $ws->msg ($type,
-         %msg,
-         id => $self->{id},
-      );
+      $ws->msg ($type, $self->{id}, @arg);
    }
 }
 
 sub msg_cb {
-   my ($self, $cb, $type, %msg) = @_;
+   my ($self, $cb, $type, @arg) = @_;
 
    if (my $ws = $self->{ws}) {
-
       my $rid = ++$ws->{ns}{id};
 
-      $self->msg ($type, %msg, rid => $rid);
+      $self->msg ($type, $rid, @arg);
 
       if ($cb) {
          $ws->{ns}{widget_return}{$rid} = $cb;
@@ -245,19 +244,19 @@
 }
 
 sub set {
-   my ($self, $member, $value) = @_;
+   my ($self, @kv) = @_;
 
-   $self->msg (w_s => attr => [ [$member, $value] ]);
+   $self->msg (w_s => \@kv);
 }
 
 sub get {
    my ($self, $member, $cb) = @_;
 
-   $self->msg_cb ($cb, w_g => attr => [$member]);
+   $self->msg_cb ($cb, w_g => [$member]);
 }
 
 sub TO_JSON {
-   { __widget_ref__ => $_[0]{id} }
+   { __w_ => $_[0]{id} }
 }
 
 our $AUTOLOAD;
@@ -268,7 +267,7 @@
 
    my $self = shift;
 
-   $self->msg (w_c => name => $AUTOLOAD, args => \@_);
+   $self->msg (w_c => 0, $AUTOLOAD, \@_);
 
    ()
 }