ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/include/cfperl.h
(Generate patch)

Comparing deliantra/server/include/cfperl.h (file contents):
Revision 1.5 by root, Fri Aug 25 17:11:53 2006 UTC vs.
Revision 1.120 by root, Mon Apr 12 05:22:38 2010 UTC

1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 *
4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 *
6 * Deliantra is free software: you can redistribute it and/or modify it under
7 * the terms of the Affero GNU General Public License as published by the
8 * Free Software Foundation, either version 3 of the License, or (at your
9 * option) any later version.
10 *
11 * This program is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 * GNU General Public License for more details.
15 *
16 * You should have received a copy of the Affero GNU General Public License
17 * and the GNU General Public License along with this program. If not, see
18 * <http://www.gnu.org/licenses/>.
19 *
20 * The authors can be reached via e-mail to <support@deliantra.net>
21 */
22
1// 23//
2// cfperl.h perl interface 24// cfperl.h perl interface
3// 25//
4#ifndef CFPERL_H__ 26#ifndef CFPERL_H__
5#define CFPERL_H__ 27#define CFPERL_H__
6 28
7// could have used templates, but a more traditional C api 29using namespace std;
8// uses more explicit typing which is ok for this purpose.
9enum data_type {
10 DT_END, // no further arguments
11 DT_INT,
12 DT_INT64,
13 DT_DOUBLE,
14 DT_STRING, // 0-terminated string
15 DT_DATA, // string + length
16 DT_OBJECT,
17 DT_MAP,
18 DT_PLAYER,
19 DT_ARCH,
20 DT_PARTY,
21 DT_REGION,
22 30
23 // following are only for cfapi-compatibility 31#include <EXTERN.h>
24 DT_INT_PTR, 32#include <perl.h>
25 DT_INT64_PTR, 33#include <XSUB.h>
26 DT_DOUBLE_PTR,
27};
28 34
35#include <EVAPI.h>
36#include <CoroAPI.h>
37
38#include "util.h"
39#include "keyword.h"
40#include "dynbuf.h"
41#include "callback.h"
42
43//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
44
45// optimisations/workaround for functions requiring my_perl in scope (anti-bloat)
46#undef localtime
47#undef srand48
48#undef drand48
49#undef srandom
50#undef opendir
51#undef readdir
52#undef closedir
53#undef getprotobyname
54#undef gethostbyname
55#undef ctime
56#undef strerror
57#undef _
58
59// same here, massive symbol spamming
60#undef do_open
61#undef do_close
62#undef ref
63#undef seed
64
65// perl bug #40256: perl does overwrite those with reentrant versions
66// but does not initialise their state structures.
67#undef random
68#undef crypt
69
70//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
71
72#define _(msg) (msg)
73#define N_(msg) (msg)
74
75//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
76
77// some macros to simplify perl in-calls
78
79#define CHECK_ERROR \
80 if (SvTRUE (ERRSV)) \
81 LOG (llevError, "runtime error in %s: %s", __func__, SvPVutf8_nolen (ERRSV));
82
83inline int call_pvsv (const char *ob, I32 flags) { return call_pv (ob, flags); }
84inline int call_pvsv (SV *ob, I32 flags) { return call_sv (ob, flags); }
85
86// TODO: temporarily enabled pushstack/popstack for all calls from the core, to maybe fix object memleak?
87#define CALL_PUSH PUSHSTACKi (PERLSI_UNKNOWN)
88#define CALL_POP PUTBACK; POPSTACK; SPAGAIN
89#define CALL_BEGIN(args) dSP; CALL_PUSH; ENTER; SAVETMPS; PUSHMARK (SP); EXTEND (SP, args)
90#define CALL_ARG_SV(sv) PUSHs (sv_2mortal (sv)) // separate because no refcount inc
91#define CALL_ARG(expr) PUSHs (sv_2mortal (to_sv (expr)))
92#define CALL_CALL(name, flags) PUTBACK; int count = call_pvsv (name, (flags) | G_EVAL); SPAGAIN;
93#define CALL_END PUTBACK; CHECK_ERROR; FREETMPS; LEAVE; CALL_POP
94
95//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
96
97void cfperl_init ();
98void cfperl_main ();
99void cfperl_tick ();
100void cfperl_emergency_save ();
101void cfperl_cleanup (int make_core);
102void cfperl_make_book (object *book, int level);
103void cfperl_send_msg (client *ns, int color, const_utf8_string type, const_utf8_string msg);
104int cfperl_can_merge (object *ob1, object *ob2);
105void cfperl_mapscript_activate (object *ob, int state, object *activator, object *originator = 0);
106
107bool is_match_expr (const_utf8_string expr);
108// applies the match expression and returns true if it matches
109bool match (const_utf8_string expr, object *ob, object *self = 0, object *source = 0, object *originator = 0);
110// same as above, but returns the first object found, or 0
111object *match_one (const_utf8_string expr, object *ob, object *self = 0, object *source = 0, object *originator = 0);
112
113//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
114
115#if IVSIZE >= 8
116 typedef IV val64;
117 typedef IV uval64;
118# define newSVval64 newSViv
119# define SvVAL64 SvIV
120# define newSVuval64 newSVuv
121# define SvUVAL64 SvUV
122#else
123 typedef double val64;
124 typedef double uval64;
125# define newSVval64 newSVnv
126# define SvVAL64 SvNV
127# define newSVuval64 newSVnv
128# define SvUVAL64 SvNV
129#endif
130
131extern tstamp runtime; // virtual server time, excluding time jumps and lag
132extern tstamp NOW; // real time of current server tick
133
29enum event_klass { 134enum event_klass
135{
136 KLASS_NONE,
30 KLASS_GLOBAL, 137 KLASS_GLOBAL,
138 KLASS_ATTACHABLE,
139 KLASS_CLIENT,
31 KLASS_PLAYER, 140 KLASS_PLAYER,
32 KLASS_OBJECT, 141 KLASS_OBJECT,
33 KLASS_MAP, 142 KLASS_MAP,
143 KLASS_COMMAND,
34}; 144};
35 145
36enum event_type { 146enum event_type
147{
37# define def(klass,name) EV_ ## klass ## _ ## name, 148# define def(klass,name) EVENT_ ## klass ## _ ## name,
38# include "eventinc.h" 149# include "eventinc.h"
39# undef def 150# undef def
40 NUM_EVENT_TYPES 151 NUM_EVENT_TYPES
41}; 152};
42 153
154// in which global events or per-type events are we interested
155extern bitset<NUM_EVENT_TYPES> ev_want_event;
156extern bitset<NUM_TYPES> ev_want_type;
157
158#define ARG_AV(o) DT_AV , static_cast<AV *> (o)
43#define ARG_INT(v) DT_INT , static_cast<int> (v) 159#define ARG_INT(v) DT_INT , static_cast<int> (v)
44#define ARG_INT64(v) DT_INT64 , static_cast<sint64> (v) 160#define ARG_INT64(v) DT_INT64 , static_cast<sint64> (v)
45#define ARG_DOUBLE(v) DT_DOUBLE, static_cast<double> (v) 161#define ARG_DOUBLE(v) DT_DOUBLE, static_cast<double> (v)
46#define ARG_STRING(v) DT_STRING, static_cast<const char *> (v) 162#define ARG_STRING(v) DT_STRING, static_cast<const char *> (v)
47#define ARG_DATA(s,l) DT_DATA , static_cast<const void *> (s), (l) 163#define ARG_DATA(s,l) DT_DATA , static_cast<const void *> (s), int (l)
48#define ARG_OBJECT(o) DT_OBJECT, static_cast<struct object *> (o) 164#define ARG_OBJECT(o) DT_OBJECT, (void *)(static_cast<object *> (o))
49#define ARG_MAP(o) DT_MAP , static_cast<struct mapstruct *> (o) 165#define ARG_MAP(o) DT_MAP , (void *)(static_cast<maptile *> (o))
50#define ARG_PLAYER(o) DT_PLAYER, static_cast<struct pl *> (o) 166#define ARG_PLAYER(o) DT_PLAYER, (void *)(static_cast<player *> (o))
51#define ARG_ARCH(o) DT_ARCH , static_cast<struct archetype *> (o) 167#define ARG_ARCH(o) DT_ARCH , (void *)(static_cast<archetype *> (o))
168#define ARG_CLIENT(o) DT_CLIENT, (void *)(static_cast<client *> (o))
52#define ARG_PARTY(o) DT_PARTY , static_cast<struct party *> (o) 169#define ARG_PARTY(o) DT_PARTY , (void *)(static_cast<party *> (o))
53#define ARG_REGION(o) DT_REGION, static_cast<struct region *> (o) 170#define ARG_REGION(o) DT_REGION, (void *)(static_cast<region *> (o))
54 171
55// the ", ## __VA_ARGS" is, unfortunately, a gnu-cpp extension 172// the ", ## __VA_ARGS" is, unfortunately, a gnu-cpp extension
173#define INVOKE(obj,event, ...) (expect_false ((obj)->should_invoke (event)) ? (obj)->invoke (event, ## __VA_ARGS__, DT_END) : 0)
174#define INVOKE_GLOBAL(event, ...) INVOKE (&gbl_ev, EVENT_ ## GLOBAL ## _ ## event, ## __VA_ARGS__)
175#define INVOKE_ATTACHABLE(event, obj, ...) INVOKE (obj , EVENT_ ## ATTACHABLE ## _ ## event, ## __VA_ARGS__)
176#define INVOKE_OBJECT(event, obj, ...) INVOKE (obj , EVENT_ ## OBJECT ## _ ## event, ## __VA_ARGS__)
177#define INVOKE_CLIENT(event, obj, ...) INVOKE (obj , EVENT_ ## CLIENT ## _ ## event, ## __VA_ARGS__)
178#define INVOKE_PLAYER(event, obj, ...) INVOKE (obj , EVENT_ ## PLAYER ## _ ## event, ## __VA_ARGS__)
179#define INVOKE_MAP(event, obj, ...) INVOKE (obj , EVENT_ ## MAP ## _ ## event, ## __VA_ARGS__)
56 180
57// all these return true when the normal event processing should be skipped (if any) 181//TODO should index into @result
58#define INVOKE(klass, event, ...) cfperl_invoke (EV_ ## klass ## _ ## event, ## __VA_ARGS__, DT_END) 182#define RESULT(idx,type) cfperl_result_ ## type (idx)
183#define RESULT_DOUBLE(idx) RESULT(idx, DOUBLE)
184#define RESULT_INT(idx) RESULT(idx, INT)
59 185
60#define INVOKE_GLOBAL(event, ...) INVOKE (GLOBAL, event, ## __VA_ARGS__) 186double cfperl_result_DOUBLE (int idx);
61#define INVOKE_OBJECT(event, op, ...) INVOKE (OBJECT, event, ARG_OBJECT (op), ## __VA_ARGS__) 187int cfperl_result_INT (int idx);
62#define INVOKE_PLAYER(event, pl, ...) INVOKE (PLAYER, event, ARG_PLAYER (pl), ## __VA_ARGS__)
63#define INVOKE_MAP(event, map, ...) INVOKE (MAP , event, ARG_MAP (map) , ## __VA_ARGS__)
64 188
65bool cfperl_invoke (event_type event, ...); 189//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
66void cfperl_free_ob (object *op);
67 190
68void cfperl_init (); 191INTERFACE_CLASS (attachable)
69void cfperl_main (); 192struct attachable : refcnt_base
193{
194 static MGVTBL vtbl;
70 195
196 enum {
197 F_DESTROYED = 0x01,
198 F_DEBUG_TRACE = 0x02,
199 };
200 uint8 ACC (RW, attachable_flags);
201
202 static unordered_vector<attachable *> mortals;
203 MTH static void check_mortals ();
204
205 // object is delete'd after the refcount reaches 0
206 MTH int refcnt_cnt () const;
207 // check wether the object has died and destroy
208 MTH void refcnt_chk () { if (expect_false (refcnt <= 0)) do_check (); }
209
210 // destroy the object unless it was already destroyed
211 // this politely asks everybody interested the reduce
212 // the refcount to 0 as soon as possible.
213 MTH void destroy ();
214
215 // return wether an object was destroyed already
216 MTH bool destroyed () const { return attachable_flags & F_DESTROYED; }
217
218 // destruct and free the memory for this object
219 virtual void do_delete ();
220
221 virtual void gather_callbacks (AV *&callbacks, event_type event) const;
222
223#if 0
224private:
225 static refcounted *rc_first;
226 refcounted *rc_next;
71#endif 227#endif
72 228
229 HV *self; // CF+ perl self
230 AV *cb; // CF+ callbacks
231 shstr attach; // generic extension attachment information
232
233 void sever_self (); // sever this object from its self, if it has one.
234 void optimise (); // possibly save some memory by destroying unneeded data
235
236 attachable ()
237 : attachable_flags (0), self (0), cb (0), attach (0)
238 {
239 }
240
241 attachable (const attachable &src)
242 : attachable_flags (0), self (0), cb (0), attach (src.attach)
243 {
244 }
245
246 // set a custom key to the given value, or delete it if value = 0
247 void set_key (const_utf8_string key, const_utf8_string value = 0, bool is_utf8 = 0);
248
249 void set_key_text (const_utf8_string key, const_utf8_string value = 0)
250 {
251 set_key (key, value, 1);
252 }
253
254 void set_key_data (const_utf8_string key, const_utf8_string value = 0)
255 {
256 set_key (key, value, 0);
257 }
258
259 attachable &operator =(const attachable &src);
260
261 // used to _quickly_ decide wether to shortcut the evaluation
262 bool should_invoke (event_type event)
263 {
264 return ev_want_event [event] || cb;
265 }
266
267 bool invoke (event_type event, ...);
268
269 MTH void instantiate ();
270 void reattach ();
271
272protected:
273 // do the real refcount checking work
274 void do_check ();
275
276 // the method that does the real destroy work
277 virtual void do_destroy ();
278
279 // destructor is protected, should not be called by anybody
280 virtual ~attachable ();
281};
282
283// the global object is a pseudo object that cares for the global events
284struct global : attachable
285{
286 void gather_callbacks (AV *&callbacks, event_type event) const;
287};
288
289extern struct global gbl_ev;
290
291//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
292
293// a little dirty hack, maybe unify with something else at a later time
294struct keyword_string
295{
296 const char *s;
297 const int l;
298
299 keyword_string (const char *s, int l)
300 : s(s), l(l)
301 { }
302
303 keyword_string (keyword kw)
304 : s(keyword_str [kw]), l(keyword_len [kw])
305 {
306 }
307
308 keyword_string (shstr_tmp sh)
309 : s(&sh), l(sh.length ())
310 {
311 }
312};
313
314#define CS(keyword) keyword_string (# keyword, sizeof (# keyword) - 1)
315#define KW(keyword) CS(keyword)
316
317INTERFACE_CLASS(object_freezer)
318struct object_freezer : dynbuf_text
319{
320 AV *av;
321
322 object_freezer ();
323 ~object_freezer ();
324
325 // serialise perl part
326 void put_ (attachable *ext);
327 void put (attachable *ext)
328 {
329 if (expect_false (ext->self))
330 put_ (ext);
331 }
332
333 // null value (== no space after keyword)
334 void put (const keyword_string k)
335 {
336 char *p = force (k.l + 1);
337 memcpy (p, k.s, k.l); p += k.l; *p++ = '\n';
338 alloc (p);
339 }
340
341 void put (const keyword_string k, const keyword_string v)
342 {
343 char *p = force (k.l + 1 + v.l + 1);
344 memcpy (p, k.s, k.l); p += k.l; *p++ = ' ';
345 memcpy (p, v.s, v.l); p += v.l; *p++ = '\n';
346 alloc (p);
347 }
348
349 void put (const keyword_string k, const_utf8_string v)
350 {
351 if (expect_true (v))
352 put (k, keyword_string (v, strlen (v)));
353 else
354 put (k);
355 }
356
357 void put (const keyword_string k, shstr_tmp v)
358 {
359 put (k, keyword_string (v));
360 }
361
362 void put (const keyword_string k, double v)
363 {
364 char *p = force (MAX_KEYWORD_LEN + 2 + 32);
365 memcpy (p, k.s, k.l); p += k.l; *p++ = ' ';
366 p += sprintf (p, "%.7g", v); *p++ = '\n';
367 alloc (p);
368 }
369
370 void put_(const keyword_string k, sint64 v)
371 {
372 force (MAX_KEYWORD_LEN + 2 + sint64_digits);
373 fadd (k.s, k.l);
374 fadd (' ');
375 add (v);
376 fadd ('\n');
377 }
378
379 void put_(const keyword_string k, sint32 v)
380 {
381 force (MAX_KEYWORD_LEN + 2 + sint32_digits);
382 fadd (k.s, k.l);
383 fadd (' ');
384 add (v);
385 fadd ('\n');
386 }
387
388 void put (const keyword_string k, float v) { put (k, (double)v); }
389 void put (const keyword_string k, signed char v) { put_(k, (sint32)v); }
390 void put (const keyword_string k, unsigned char v) { put_(k, (sint32)v); }
391 void put (const keyword_string k, signed short v) { put_(k, (sint32)v); }
392 void put (const keyword_string k, unsigned short v) { put_(k, (sint32)v); }
393 void put (const keyword_string k, signed int v) { put_(k, (sint32)v); }
394 void put (const keyword_string k, unsigned int v) { put_(k, (sint64)v); }
395 void put (const keyword_string k, signed long v) { put_(k, (sint64)v); }
396 void put (const keyword_string k, unsigned long v) { put_(k, (sint64)v); }
397 void put (const keyword_string k, signed long long v) { put_(k, (sint64)v); }
398 void put (const keyword_string k, unsigned long long v) { put_(k, (sint64)v); }
399
400 void put (const keyword_string kbeg, const keyword_string kend, shstr_tmp v)
401 {
402 force (MAX_KEYWORD_LEN + 1);
403 fadd (kbeg.s, kbeg.l); fadd ('\n');
404
405 if (expect_true (v))
406 {
407 add (v);
408 add ('\n');
409 }
410
411 force (MAX_KEYWORD_LEN + 1);
412 fadd (kend.s, kend.l); fadd ('\n');
413 }
414
415 void put (const keyword_string k, archetype *v);
416 void put (const keyword_string k, treasurelist *v);
417 void put (const keyword_string k, faceinfo *v);
418
419 template<typename T>
420 void put (const keyword_string k, const refptr<T> &v)
421 {
422 put (k, (T *)v);
423 }
424
425 MTH bool save (const_octet_string path);
426 utf8_string as_string (); // like strdup
427
428 operator bool () { return !!av; }
429};
430
431INTERFACE_CLASS(object_thawer)
432struct object_thawer
433{
434 char *line; // current beginning of line
435 SV *text; // text part
436 AV *av; // perl part
437 int linenum;
438 keyword kw;
439 char *kw_str; // the keyword parsed, as string
440 char *value; // the value, or 0 if no value
441 const char *value_nn; // the value, or the empty string if no value
442 const char *name;
443
444 operator bool () const { return !!text; }
445
446 object_thawer (const_utf8_string path = 0);
447 object_thawer (const_utf8_string data, AV *perlav);
448 ~object_thawer ();
449
450 void get (attachable *obj, int oid);
451
452 // parse next line
453 MTH void next ();
454 // skip the current key-value (usually fetch next line, for
455 // multiline-fields, skips till the corresponding end-kw
456 MTH void skip ();
457 MTH void skip_block (); // skips till and over KW_end
458
459 bool has_value () { return value; }
460 const_utf8_string get_str () { return value_nn; } // empty string when missing
461 void get_ml (keyword kend, shstr &sh);
462
463 void get_ornull (shstr &sh) const { sh = value; }
464 void get (shstr &sh) const { sh = value; } // might want to check for non-null here
465
466 bool get_bool () const { return *value_nn == '1'; }
467 sint32 get_sint32 () const;
468 sint64 get_sint64 () const { return strtoll (value_nn, 0, 10); }
469 double get_double () const { return strtod (value_nn, 0); }
470
471 void get (float &v) { v = get_double (); }
472 void get (double &v) { v = get_double (); }
473
474 void get (bool &i) { i = get_bool (); }
475 void get (sint8 &i) { i = get_sint32 (); }
476 void get (uint8 &i) { i = get_sint32 (); }
477 void get (sint16 &i) { i = get_sint32 (); }
478 void get (uint16 &i) { i = get_sint32 (); }
479 void get (sint32 &i) { i = get_sint32 (); }
480
481 void get (uint32 &i) { i = get_sint64 (); }
482 void get (sint64 &i) { i = get_sint64 (); }
483
484 MTH void parse_warn (const_utf8_string msg);
485 MTH bool parse_error (const_utf8_string type = 0, const_utf8_string name = 0, bool skip = true);
486
487 struct delayed_ref {
488 attachable *op;
489 object_ptr *ptr;
490 const_utf8_string ref;
491 };
492 std::vector<delayed_ref> delrefs;
493
494 void delayed_deref (attachable *op, object_ptr &ptr, const_utf8_string ref);
495 MTH void resolve_delayed_derefs (bool deref = true);
496};
497
498//TODO: remove
499char *fgets (char *s, int n, object_thawer &thawer);
500
501//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
502
503struct coroapi {
504 static struct CoroAPI *GCoroAPI;
505
506 static EV_ATOMIC_T cede_pending;
507
508 static int nready () { return CORO_NREADY; }
509 static int cede () { cede_pending = 0; return CORO_CEDE ; }
510
511 static void do_cede_to_tick ();
512
513 // actually cede's far more often
514 static bool cede_to_tick ()
515 {
516 if (expect_true (!cede_pending))
517 return false;
518
519 do_cede_to_tick ();
520 return true;
521 }
522
523 static void wait_for_tick ();
524 static void wait_for_tick_begin ();
525};
526
527struct evapi
528{
529 static struct EVAPI *GEVAPI;
530};
531
532struct iow : ev_io, evapi, callback<void (iow &, int)>
533{
534 static void thunk (EV_P_ struct ev_io *w_, int revents)
535 {
536 iow &w = *static_cast<iow *>(w_);
537
538 w (w, revents);
539 }
540
541 template<class O, class M>
542 iow (O object, M method)
543 : callback<void (iow &, int)> (object, method)
544 {
545 ev_init ((ev_io *)this, thunk);
546 }
547
548 void prio (int prio)
549 {
550 ev_set_priority ((ev_io *)this, prio);
551 }
552
553 void set (int fd, int events)
554 {
555 ev_io_set ((ev_io *)this, fd, events);
556 }
557
558 int poll () const { return events; }
559
560 void poll (int events);
561
562 void start ()
563 {
564 ev_io_start (EV_DEFAULT, (ev_io *)this);
565 }
566
567 void stop ()
568 {
569 ev_io_stop (EV_DEFAULT, (ev_io *)this);
570 }
571
572 ~iow ()
573 {
574 stop ();
575 }
576};
577
578struct asyncw : ev_async, evapi, callback<void (ev_async &, int)>
579{
580 static void thunk (EV_P_ struct ev_async *w_, int revents)
581 {
582 asyncw &w = *static_cast<asyncw *>(w_);
583
584 w (w, revents);
585 }
586
587 template<class O, class M>
588 asyncw (O object, M method)
589 : callback<void (asyncw &, int)> (object, method)
590 {
591 ev_init ((ev_async *)this, thunk);
592 }
593
594 void start ()
595 {
596 ev_async_start (EV_DEFAULT, (ev_async *)this);
597 }
598
599 void stop ()
600 {
601 ev_async_stop (EV_DEFAULT, (ev_async *)this);
602 }
603
604 ~asyncw ()
605 {
606 stop ();
607 }
608};
609
610#endif
611

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines