--- deliantra/server/include/shstr.h	2008/12/31 18:29:44	1.27
+++ deliantra/server/include/shstr.h	2009/01/01 20:49:48	1.32
@@ -70,9 +70,18 @@
     return length () >= plen && !strncasecmp (s, prefix, plen);
   }
 
+  // returns true if the substring is contained in the shstr
+  // if the shstr is 0, then this always returns false.
+  // the shstr is (theoretically) treated as a comma/colon/space etc. separated list.
   bool contains (const char *substring) const
   {
-    return strstr (s, substring);
+    return s != null () && strstr (s, substring);
+  }
+
+  //TODO: case sensitive should be eradicated
+  bool eq_nc (const char *otherstring) const
+  {
+    return !strcasecmp (s, otherstring);
   }
 
   shstr_tmp ()
@@ -115,14 +124,11 @@
   return a.s != b.s;
 }
 
-inline int strlen (const shstr_tmp &sh)
+inline int strlen (shstr_tmp sh)
 {
   return sh.length ();
 }
 
-// undefined external reference to catch people using strcmp when they shouldn't
-int strcmp (const shstr_tmp &a, const shstr_tmp &b);
-
 static std::ostream &operator <<(std::ostream &o, shstr_tmp sh)
 {
   o.write (sh.s, sh.length ());
@@ -208,7 +214,13 @@
 {
   const char *s;
 
-  explicit shstr_cmp (const char *str)
+  // initialies to the non-matching string (as opposed to the null string)
+  shstr_cmp ()
+  {
+    s = 0;
+  }
+
+  shstr_cmp (const char *str)
   : s (shstr::find (str))
   {
   }
@@ -234,9 +246,15 @@
   return a.s == b.s;
 }
 
-#define def(str) extern const shstr shstr_ ## str;
+#define def2(id,str) extern const shstr id;
+#define def(id)      def2(shstr_ ## id, # id)
 # include "shstrinc.h"
 #undef def
+#undef def2
+
+// undefined external reference to catch people using str* functions when they shouldn't
+//template<class any> void strcmp (const shstr_tmp &a, any b);
+template<class any> void strstr (const shstr_tmp &a, any b);
 
 #endif