--- deliantra/server/include/util.h 2007/01/19 15:15:50 1.34 +++ deliantra/server/include/util.h 2007/01/19 22:47:57 1.35 @@ -37,9 +37,11 @@ void fork_abort (const char *msg); -template static inline T min (T a, U b) { return a < (T)b ? a : (T)b; } -template static inline T max (T a, U b) { return a > (T)b ? a : (T)b; } -template static inline T clamp (T v, U a, V b) { return v < (T)a ? a : v >(T)b ? b : v; } +// rationale for using (U) not (T) is to reduce signed/unsigned issues, +// as a is often a constant while b is the variable. it is still a bug, though. +template static inline T min (T a, U b) { return (U)a < b ? (U)a : b; } +template static inline T max (T a, U b) { return (U)a > b ? (U)a : b; } +template static inline T clamp (T v, U a, V b) { return v < (T)a ? (T)a : v >(T)b ? (T)b : v; } template static inline void swap (T& a, U& b) { T t=a; a=(T)b; b=(U)t; }