[ViewVC] Diff of: cvs/deliantra/server/lib/cf.pm

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.120 by root, Tue Jan 2 11:08:36 2007 UTC vs.
Revision 1.130 by root, Thu Jan 4 00:08:08 2007 UTC

 use Storable;
 use Opcode;
 use Safe;
 use Safe::Hole;
-use Coro 3.3;
+use Coro 3.3 ();
 use Coro::Event;
 use Coro::Timer;
 use Coro::Signal;
 use Coro::Semaphore;
 use Coro::AIO;
       # wake up all waiters, to be on the safe side
       $_->ready for @{ delete $LOCK{$key} };
    }
 }
+=item cf::async { BLOCK }
+Like C<Coro::async>, but runs the given BLOCK in an eval and only logs the
+error instead of exiting the server in case of a problem.
+=cut
+sub async(&) {
+   my ($cb) = @_;
+   Coro::async {
+      eval { $cb->() };
+      warn $@ if $@;
+   }
+}
 =item cf::sync_job { BLOCK }
 The design of crossfire+ requires that the main coro ($Coro::main) is
 always able to handle events or runnable, as crossfire+ is only partly
 reentrant. Thus "blocking" it by e.g. waiting for I/O is not acceptable.
 =cut
 sub coro(&) {
    my $cb = shift;
-   my $coro; $coro = async {
+   my $coro = &cf::async ($cb);
-      eval {
-         $cb->();
-      };
-      warn $@ if $@;
-   };
    $coro->on_destroy (sub {
       delete $EXT_CORO{$coro+0};
    });
    $EXT_CORO{$coro+0} = $coro;
 # and all this just because we cannot iterate over
 # all maps in C++...
 sub change_all_map_light {
    my ($change) = @_;
-   $_->change_map_light ($change) for values %cf::MAP;
+   $_->change_map_light ($change)
+      for grep $_->outdoor, values %cf::MAP;
 }
 sub try_load_header($) {
    my ($path) = @_;
    $map->{load_path} = $path;
    $map
 }
+sub find_map;
 sub find_map {
    my ($path, $origin) = @_;
    #warn "find_map<$path,$origin>\n";#d#
          $map->instantiate;
          # per-player maps become, after loading, normal maps
          $map->per_player (0) if $path->{user_rel};
       }
-      #Coro::Timer::sleep 1;#d#
       $map->path ($key);
       $map->{path} = $path;
       $map->{last_save} = $cf::RUNTIME;
       $map->last_access ($cf::RUNTIME);
       if ($map->should_reset) {
          $map->reset;
+         undef $guard;
-         $map = find_map $path;
+         $map = find_map $path
+            or return;
       }
       $cf::MAP{$key} = $map
    }
 }
 }
 sub swap_out {
    my ($self) = @_;
+   # save first because save cedes
+   $self->save;
    return if $self->players;
    return if $self->in_memory != cf::MAP_IN_MEMORY;
    return if $self->{deny_save};
-   $self->save;
    $self->clear;
    $self->in_memory (cf::MAP_SWAPPED);
 }
 sub reset_at {
       # try to abort aborted map switching on player login :)
       # should happen only on crashes
       if ($pl->ob->{_link_pos}) {
          $pl->ob->enter_link;
-         Coro::async {
+         cf::async {
             # we need this sleep as the login has a concurrent enter_exit running
             # and this sleep increases chances of the player not ending up in scorn
             Coro::Timer::sleep 1;
             $pl->ob->leave_link;
          };
 sub cf::object::player::goto_map {
    my ($self, $path, $x, $y) = @_;
    $self->enter_link;
-   (Coro::async {
+   (cf::async {
       $path = new cf::path $path;
       my $map = cf::map::find_map $path->as_string;
       $map = $map->customise_for ($self) if $map;
    return unless $self->type == cf::PLAYER;
    $self->enter_link;
-   (Coro::async {
+   (cf::async {
       unless (eval {
          prepare_random_map $exit
             if $exit->slaying eq "/!";
          my $path = new cf::path $exit->slaying, $exit->map && $exit->map->path;
          $self->goto_map ($path, $exit->stats->hp, $exit->stats->sp);
    on_reply => sub {
       my ($ns, $msg) = @_;
       # this weird shuffling is so that direct followup queries
       # get handled first
-      my $queue = delete $ns->{query_queue};
+      my $queue = delete $ns->{query_queue}
+         or return; # be conservative, not sure how that can happen, but we saw a crash here
       (shift @$queue)->[1]->($msg);
       push @{ $ns->{query_queue} }, @$queue;
 =cut
 sub cf::client::coro {
    my ($self, $cb) = @_;
-   my $coro; $coro = async {
+   my $coro = &cf::async ($cb);
-      eval {
-         $cb->();
-      };
-      warn $@ if $@;
-   };
    $coro->on_destroy (sub {
       delete $self->{_coro}{$coro+0};
    });
 {
    my $path = cf::localdir . "/database.pst";
    sub db_load() {
-      warn "loading database $path\n";#d# remove later
       $DB = stat $path ? Storable::retrieve $path : { };
    }
    my $pid;
    sub db_save() {
-      warn "saving database $path\n";#d# remove later
       waitpid $pid, 0 if $pid;
       if (0 == ($pid = fork)) {
          $DB->{_meta}{version} = 1;
          Storable::nstore $DB, "$path~";
          rename "$path~", $path;
             or warn "ERROR: unable to write runtime file: $!";
       })->();
    },
 );
+END { cf::emergency_save }
 1

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/lib/cf.pm (file contents): Revision 1.120 by root, Tue Jan 2 11:08:36 2007 UTC vs. Revision 1.130 by root, Thu Jan 4 00:08:08 2007 UTC

Diff Legend

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.120 by root, Tue Jan 2 11:08:36 2007 UTC vs.
Revision 1.130 by root, Thu Jan 4 00:08:08 2007 UTC