--- deliantra/server/lib/cf.pm	2007/09/04 08:42:58	1.357
+++ deliantra/server/lib/cf.pm	2007/09/10 12:44:06	1.362
@@ -189,7 +189,6 @@
 
       $msg =~ s/([\x00-\x08\x0b-\x1f])/sprintf "\\x%02x", ord $1/ge;
 
-      utf8::encode $msg;
       LOG llevError, $msg;
    };
 }
@@ -287,10 +286,16 @@
 =cut
 
 our %LOCK;
+our %LOCKER;#d#
 
 sub lock_wait($) {
    my ($key) = @_;
 
+   if ($LOCKER{$key} == $Coro::current) {#d#
+      Carp::cluck "lock_wait($key) for already-acquired lock";#d#
+      return;#d#
+   }#d#
+
    # wait for lock, if any
    while ($LOCK{$key}) {
       push @{ $LOCK{$key} }, $Coro::current;
@@ -305,8 +310,10 @@
    lock_wait $key;
 
    $LOCK{$key} = [];
+   $LOCKER{$key} = $Coro::current;#d#
 
    Coro::guard {
+      delete $LOCKER{$key};#d#
       # wake up all waiters, to be on the safe side
       $_->ready for @{ delete $LOCK{$key} };
    }
@@ -1011,8 +1018,9 @@
 
    sync_job {
       if (length $$rdata) {
+         utf8::decode (my $decname = $filename);
          warn sprintf "saving %s (%d,%d)\n",
-            $filename, length $$rdata, scalar @$objs;
+            $decname, length $$rdata, scalar @$objs;
 
          if (my $fh = aio_open "$filename~", O_WRONLY | O_CREAT, 0600) {
             chmod SAVE_MODE, $fh;
@@ -1072,8 +1080,9 @@
       $av = eval { (Storable::thaw $av)->{objs} };
    }
 
-   warn sprintf "loading %s (%d)\n",
-      $filename, length $data, scalar @{$av || []};
+   utf8::decode (my $decname = $filename);
+   warn sprintf "loading %s (%d,%d)\n",
+      $decname, length $data, scalar @{$av || []};
 
    ($data, $av)
 }
@@ -1271,6 +1280,20 @@
 
 =over 4
 
+=item cf::player::num_playing
+
+Returns the official number of playing players, as per the Crossfire metaserver rules.
+
+=cut
+
+sub num_playing {
+   scalar grep
+      $_->ob->map
+      && !$_->hidden
+      && !$_->ob->flag (cf::FLAG_WIZ),
+      cf::player::list
+}
+
 =item cf::player::find $login
 
 Returns the given player object, loading it if necessary (might block).
@@ -1843,10 +1866,13 @@
 
    $path = normalise $path, $origin && $origin->path;
 
+   cf::lock_wait "map_data:$path";#d#remove
    cf::lock_wait "map_find:$path";
 
    $cf::MAP{$path} || do {
-      my $guard = cf::lock_acquire "map_find:$path";
+      my $guard1 = cf::lock_acquire "map_find:$path";
+      my $guard2 = cf::lock_acquire "map_data:$path"; # just for the fun of it
+
       my $map = new_from_path cf::map $path
          or return;
 
@@ -1858,8 +1884,9 @@
       if ($map->should_reset) {#d#TODO# disabled, crashy (locking issue?)
          # doing this can freeze the server in a sync job, obviously
          #$cf::WAIT_FOR_TICK->wait;
+         undef $guard1;
+         undef $guard2;
          $map->reset;
-         undef $guard;
          return find $path;
       }
 
@@ -1881,7 +1908,7 @@
       my $guard = cf::lock_acquire "map_data:$path";
 
       return unless $self->valid;
-      return if $self->in_memory != cf::MAP_SWAPPED;
+      return unless $self->in_memory == cf::MAP_SWAPPED;
 
       $self->in_memory (cf::MAP_LOADING);
 
@@ -2063,8 +2090,11 @@
    return if $self->in_memory != cf::MAP_IN_MEMORY;
    return if $self->{deny_save};
 
-   $self->clear;
    $self->in_memory (cf::MAP_SWAPPED);
+
+   $self->deactivate;
+   $_->clear_links_to ($self) for values %cf::MAP;
+   $self->clear;
 }
 
 sub reset_at {
@@ -2106,9 +2136,9 @@
 
    delete $cf::MAP{$self->path};
 
-   $self->clear;
-
+   $self->deactivate;
    $_->clear_links_to ($self) for values %cf::MAP;
+   $self->clear;
 
    $self->unlink_save;
    $self->destroy;