--- deliantra/server/lib/cf.pm	2006/07/30 17:42:14	1.28
+++ deliantra/server/lib/cf.pm	2006/08/26 08:44:06	1.44
@@ -7,19 +7,25 @@
 use Safe;
 use Safe::Hole;
 
+use Time::HiRes;
 use Event;
 $Event::Eval = 1; # no idea why this is required, but it is
 
 use strict;
 
-our %COMMAND;
+our %COMMAND = ();
 our @EVENT;
+our @PLUGIN_EVENT;
 our %PROP_TYPE;
 our %PROP_IDX;
 our $LIBDIR = maps_directory "perl";
 
+our $TICK = MAX_TIME * 1e-6;
+our $TICK_WATCHER;
+our $NEXT_TICK;
+
 BEGIN {
-   @EVENT = map lc, @EVENT;
+   @PLUGIN_EVENT = map lc, @PLUGIN_EVENT;
 
    *CORE::GLOBAL::warn = sub {
       my $msg = join "", @_;
@@ -67,14 +73,14 @@
 
 # guessed hierarchies
 
-@ext::cf::object::player::ISA = @cf::object::player::ISA = 'cf::object';
-@ext::cf::object::map::ISA    = @cf::object::map::ISA    = 'cf::object';
+@safe::cf::object::player::ISA = @cf::object::player::ISA = 'cf::object';
+@safe::cf::object::map::ISA    = @cf::object::map::ISA    = 'cf::object';
 
-# we bless all objects into derived classes to force a method lookup
+# we bless all objects into (empty) derived classes to force a method lookup
 # within the Safe compartment.
-for my $pkg (qw(cf::object cf::object::map cf::object::player cf::player cf::map cf::party cf::region)) {
+for my $pkg (qw(cf::object cf::object::map cf::object::player cf::player cf::map cf::party cf::region cf::arch)) {
    no strict 'refs';
-   @{"ext::$pkg\::wrap::ISA"} = @{"$pkg\::wrap::ISA"} = $pkg;
+   @{"safe::$pkg\::wrap::ISA"} = @{"$pkg\::wrap::ISA"} = $pkg;
 }
 
 $Event::DIED = sub {
@@ -87,6 +93,163 @@
 my %command;
 my %extcmd;
 
+#############################################################################
+# object support
+
+sub reattach {
+   warn "reattach<@_>\n";
+}
+
+sub instantiate {
+   warn "instantiate<@_>\n";
+}
+
+sub clone {
+   warn "clone<@_>\n";
+}
+
+#############################################################################
+# "new" plug-in system
+
+=item cf::object::attach ... # NYI
+
+=item cf::attach_global ...
+
+=item cf::attach_to_type ...
+
+=item cf::attach_to_objects ...
+
+=item cf::attach_to_players ...
+
+=item cf::attach_to_maps ...
+
+   prio    => $number, # lower is earlier
+   on_xxx  => \&cb,
+   package => package::,
+
+=cut
+
+# the following variables are defined in .xs and must not be re-created
+our @CB_GLOBAL = (); # registry for all global events
+our @CB_OBJECT = ();
+our @CB_PLAYER = ();
+our @CB_TYPE   = (); # registry for type (cf-object class) based events
+our @CB_MAP    = ();
+
+sub _attach_cb($\%$$$) {
+   my ($registry, $undo, $event, $prio, $cb) = @_;
+
+   use sort 'stable';
+
+   $cb = [$prio, $cb];
+
+   @{$registry->[$event]} = sort
+                           { $a->[0] cmp $b->[0] }
+                           @{$registry->[$event] || []}, $cb;
+
+   push @{$undo->{cb}}, [$event, $cb];
+}
+
+# attach handles attaching event callbacks
+# the only thing the caller has to do is pass the correct
+# registry (== where the callback attaches to).
+sub _attach(\@$\@) {
+   my ($registry, $klass, $arg) = @_;
+
+   my $prio = 0;
+
+   my %undo = (
+      registry => $registry,
+      cb       => [],
+   );
+
+   my %cb_id = map +("on_" . lc $EVENT[$_][0], $_) , grep $EVENT[$_][1] == $klass, 0 .. $#EVENT;
+
+   while (@$arg) {
+      my $type = shift @$arg;
+
+      if ($type eq "prio") {
+         $prio = shift @$arg;
+
+      } elsif ($type eq "package") {
+         my $pkg = shift @$arg;
+
+         while (my ($name, $id) = each %cb_id) {
+            if (my $cb = $pkg->can ($name)) {
+               _attach_cb $registry, %undo, $id, $prio, $cb;
+            }
+         }
+
+      } elsif (exists $cb_id{$type}) {
+         _attach_cb $registry, %undo, $cb_id{$type}, $prio, shift @$arg;
+
+      } elsif (ref $type) {
+         warn "attaching objects not supported, ignoring.\n";
+
+      } else {
+         shift @$arg;
+         warn "attach argument '$type' not supported, ignoring.\n";
+      }
+   }
+
+   \%undo
+}
+
+sub cf::object::attach {
+   die;
+}
+
+sub attach_global {
+   _attach @CB_GLOBAL, KLASS_GLOBAL, @_
+}
+
+sub attach_to_type {
+   my $type = shift;
+   _attach @{$CB_TYPE[$type]}, KLASS_OBJECT, @_
+}
+
+sub attach_to_objects {
+   _attach @CB_OBJECT, KLASS_OBJECT, @_
+}
+
+sub attach_to_players {
+   _attach @CB_PLAYER, KLASS_PLAYER, @_
+}
+
+sub attach_to_maps {
+   _attach @CB_MAP, KLASS_MAP, @_
+}
+
+our $override;
+
+sub override() {
+   $override = 1
+}
+
+sub invoke {
+   my $event = shift;
+   my $callbacks = shift;
+
+   local $override;
+
+   for (@$callbacks) {
+      eval { &{$_->[1]} };
+
+      if ($@) {
+         warn "$@";
+         warn "... while processing $EVENT[$event][0] event, skipping processing altogether.\n";
+         override;
+      }
+
+      return 1 if $override;
+   }
+
+   0
+}
+
+#############################################################################
+# old plug-in events
+
 sub inject_event {
    my $extension = shift;
    my $event_code = shift;
@@ -138,9 +301,9 @@
 sub register {
    my ($base, $pkg) = @_;
 
-   for my $idx (0 .. $#EVENT) {
-      if (my $ref = $pkg->can ("on_$EVENT[$idx]")) {
-         #warn "registering $EVENT[$idx] hook to '$pkg'\n";
+   for my $idx (0 .. $#PLUGIN_EVENT) {
+      if (my $ref = $pkg->can ("on_$PLUGIN_EVENT[$idx]")) {
+         #warn "registering $PLUGIN_EVENT[$idx] hook to '$pkg'\n";
          $hook[$idx]{$base} = $ref;
       }
    }
@@ -153,7 +316,7 @@
    my $base = $1;
    my $pkg = $1;
    $pkg =~ s/[^[:word:]]/_/g;
-   $pkg = "cf::ext::$pkg";
+   $pkg = "ext::$pkg";
 
    warn "loading '$path' into '$pkg'\n";
 
@@ -183,12 +346,8 @@
 
    warn "removing extension $pkg\n";
 
-   if (my $cb = $pkg->can ("on_unload")) {
-      $cb->($pkg);
-   }
-
    # remove hooks
-   for my $idx (0 .. $#EVENT) {
+   for my $idx (0 .. $#PLUGIN_EVENT) {
       delete $hook[$idx]{$pkg};
    }
 
@@ -210,6 +369,13 @@
       delete $extcmd{$name};
    }
 
+   if (my $cb = $pkg->can ("unload")) {
+      eval {
+         $cb->($pkg);
+         1
+      } or warn "$pkg unloaded, but with errors: $@";
+   }
+
    Symbol::delete_package $pkg;
 }
 
@@ -225,64 +391,76 @@
    }
 }
 
-register_command "perl-reload", 0, sub {
-   my ($who, $arg) = @_;
+sub _perl_reload(&) {
+   my ($msg) = @_;
 
-   if ($who->flag (FLAG_WIZ)) {
-      $who->message ("reloading...");
+   $msg->("reloading...");
 
-      warn "reloading...\n";
-      eval {
-         # 1. cancel all watchers
-         $_->cancel for Event::all_watchers;
+   eval {
+      # 1. cancel all watchers
+      $_->cancel for Event::all_watchers;
+
+      # 2. unload all extensions
+      for (@exts) {
+         $msg->("unloading <$_>");
+         unload_extension $_;
+      }
+
+      # 3. unload all modules loaded from $LIBDIR
+      while (my ($k, $v) = each %INC) {
+         next unless $v =~ /^\Q$LIBDIR\E\/.*\.pm$/;
+
+         $msg->("removing <$k>");
+         delete $INC{$k};
 
-         # 2. unload all extensions
-         for (@exts) {
-            $who->message ("unloading <$_>");
-            unload_extension $_;
+         $k =~ s/\.pm$//;
+         $k =~ s/\//::/g;
+
+         if (my $cb = $k->can ("unload_module")) {
+            $cb->();
          }
 
-         # 3. unload all modules loaded from $LIBDIR
-         while (my ($k, $v) = each %INC) {
-            next unless $v =~ /^\Q$LIBDIR\E\/.*\.pm$/;
+         Symbol::delete_package $k;
+      }
 
-            $who->message ("removing <$k>");
-            delete $INC{$k};
+      # 4. get rid of safe::, as good as possible
+      Symbol::delete_package "safe::$_"
+         for qw(cf::object cf::object::map cf::object::player cf::player cf::map cf::party cf::region);
+
+      # 5. remove register_script_function callbacks
+      # TODO
+      
+      # 6. unload cf.pm "a bit"
+      delete $INC{"cf.pm"};
+
+      # don't, removes xs symbols, too,
+      # and global variables created in xs
+      #Symbol::delete_package __PACKAGE__;
+
+      # 7. reload cf.pm
+      $msg->("reloading cf.pm");
+      require cf;
+   };
+   $msg->($@) if $@;
 
-            $k =~ s/\.pm$//;
-            $k =~ s/\//::/g;
+   $msg->("reloaded");
+};
 
-            if (my $cb = $k->can ("unload_module")) {
-               $cb->();
-            }
+sub perl_reload() {
+   _perl_reload {
+      warn $_[0];
+      print "$_[0]\n";
+   };
+}
 
-            Symbol::delete_package $k;
-         }
+register_command "perl-reload", 0, sub {
+   my ($who, $arg) = @_;
 
-         # 4. get rid of ext::, as good as possible
-         Symbol::delete_package "ext::$_"
-            for qw(cf::object cf::object::map cf::object::player cf::player cf::map cf::party cf::region);
-
-         # 5. remove register_script_function callbacks
-         # TODO
-         
-         # 6. unload cf.pm "a bit"
-         delete $INC{"cf.pm"};
-
-         # don't, removes xs symbols, too
-         #Symbol::delete_package __PACKAGE__;
-
-         # 7. reload cf.pm
-         $who->message ("reloading cf.pm");
-         require cf;
+   if ($who->flag (FLAG_WIZ)) {
+      _perl_reload {
+         warn $_[0];
+         $who->message ($_[0]);
       };
-      warn $@ if $@;
-      $who->message ($@) if $@;
-      warn "reloaded\n";
-
-      $who->message ("reloaded");
-   } else {
-      $who->message ("Intruder Alert!");
    }
 };
 
@@ -291,13 +469,13 @@
 
 use JSON::Syck (); # TODO# replace by JSON::PC once working
 
-$JSON::Syck::ImplicitUnicode = 1;
-
 sub from_json($) {
+   $JSON::Syck::ImplicitUnicode = 1; # work around JSON::Syck bugs
    JSON::Syck::Load $_[0]
 }
 
 sub to_json($) {
+   $JSON::Syck::ImplicitUnicode = 0;  # work around JSON::Syck bugs
    JSON::Syck::Dump $_[0]
 }
 
@@ -305,28 +483,30 @@
 # extcmd framework, basically convert ext <msg>
 # into pkg::->on_extcmd_arg1 (...) while shortcutting a few
 
-sub on_extcmd {
-   my ($pl, $buf) = @_;
-
-   my $msg = eval { from_json $buf };
-
-   if (ref $msg) {
-      if (my $cb = $extcmd{$msg->{msgtype}}) {
-         if (my %reply = $cb->[0]->($pl, $msg)) {
-            $pl->ext_reply ($msg->{msgid}, %reply);
+attach_to_players
+   on_extcmd => sub {
+      my ($pl, $buf) = @_;
+
+      my $msg = eval { from_json $buf };
+
+      if (ref $msg) {
+         if (my $cb = $extcmd{$msg->{msgtype}}) {
+            if (my %reply = $cb->[0]->($pl, $msg)) {
+               $pl->ext_reply ($msg->{msgid}, %reply);
+            }
          }
+      } else {
+         warn "player " . ($pl->ob->name) . " sent unparseable ext message: <$buf>\n";
       }
-   } else {
-      warn "player " . ($pl->ob->name) . " sent unparseable ext message: <$buf>\n";
-   }
 
-   1
-}
+      cf::override;
+   },
+;
 
 #############################################################################
 # load/save/clean perl data associated with a map
 
-*on_mapclean = sub {
+*cf::mapsupport::on_clean = sub {
    my ($map) = @_;
 
    my $path = $map->tmpname;
@@ -335,8 +515,8 @@
    unlink "$path.cfperl";
 };
 
-*on_mapin =
-*on_mapload = sub {
+*cf::mapsupport::on_swapin =
+*cf::mapsupport::on_load = sub {
    my ($map) = @_;
 
    my $path = $map->tmpname;
@@ -353,7 +533,7 @@
    $map->_set_obs ($data->{obs});
 };
 
-*on_mapout = sub {
+*cf::mapsupport::on_swapout = sub {
    my ($map) = @_;
 
    my $path = $map->tmpname;
@@ -380,27 +560,34 @@
    }
 };
 
+attach_to_maps prio => -10000, package => cf::mapsupport::;
+
 #############################################################################
 # load/save perl data associated with player->ob objects
 
-*on_player_load = sub {
-   my ($ob, $path) = @_;
-
-   for my $o ($ob, $ob->inv) {
-      if (my $value = $o->get_ob_key_value ("_perl_data")) {
-         $o->set_ob_key_value ("_perl_data");
+sub all_objects(@) {
+   @_, map all_objects ($_->inv), @_
+}
 
-         %$o = %{ Storable::thaw pack "H*", $value };
-      }
-   }
-};
+attach_to_players
+   on_load => sub {
+      my ($pl, $path) = @_;
 
-*on_player_save = sub {
-   my ($ob, $path) = @_;
+      for my $o (all_objects $pl->ob) {
+         if (my $value = $o->get_ob_key_value ("_perl_data")) {
+            $o->set_ob_key_value ("_perl_data");
 
-   $_->set_ob_key_value (_perl_data => unpack "H*", Storable::nfreeze $_)
-      for grep %$_, $ob, $ob->inv;
-};
+            %$o = %{ Storable::thaw pack "H*", $value };
+         }
+      }
+   },
+   on_save => sub {
+      my ($pl, $path) = @_;
+
+      $_->set_ob_key_value (_perl_data => unpack "H*", Storable::nfreeze $_)
+         for grep %$_, all_objects $pl->ob;
+   },
+;
 
 #############################################################################
 # core extensions - in perl
@@ -456,7 +643,7 @@
 #############################################################################
 # map scripting support
 
-our $safe = new Safe "ext";
+our $safe = new Safe "safe";
 our $safe_hole = new Safe::Hole;
 
 $SIG{FPE} = 'IGNORE';
@@ -472,7 +659,7 @@
 ) {
    no strict 'refs';
    my ($pkg, @funs) = @$_;
-   *{"ext::$pkg\::$_"} = $safe_hole->wrap (\&{"$pkg\::$_"})
+   *{"safe::$pkg\::$_"} = $safe_hole->wrap (\&{"$pkg\::$_"})
       for @funs;
 }
 
@@ -484,9 +671,9 @@
    $qcode =~ s/\n/\\n/g;
 
    local $_;
-   local @ext::cf::_safe_eval_args = values %vars;
+   local @safe::cf::_safe_eval_args = values %vars;
 
-   $code =
+   my $eval =
       "do {\n"
       . "my (" . (join ",", map "\$$_", keys %vars) . ") = \@cf::_safe_eval_args;\n"
       . "#line 0 \"{$qcode}\"\n"
@@ -495,9 +682,15 @@
    ;
 
    sub_generation_inc;
-   my @res = wantarray ? $safe->reval ($code) : scalar $safe->reval ($code);
+   my @res = wantarray ? $safe->reval ($eval) : scalar $safe->reval ($eval);
    sub_generation_inc;
 
+   if ($@) {
+      warn "$@";
+      warn "while executing safe code '$code'\n";
+      warn "with arguments " . (join " ", %vars) . "\n";
+   }
+
    wantarray ? @res : $res[0]
 }
 
@@ -505,7 +698,14 @@
    my ($fun, $cb) = @_;
 
    no strict 'refs';
-   *{"ext::$fun"} = $safe_hole->wrap ($cb);
+   *{"safe::$fun"} = $safe_hole->wrap ($cb);
+}
+
+#############################################################################
+# the server's main()
+
+sub main {
+   Event::loop;
 }
 
 #############################################################################
@@ -517,5 +717,22 @@
 
 load_extensions;
 
+$TICK_WATCHER = Event->timer (
+   prio => 1,
+   at   => $NEXT_TICK || 1,
+   cb   => sub {
+      cf::server_tick; # one server iteration
+
+      my $NOW = Event::time;
+      $NEXT_TICK += $TICK;
+
+      # if we are delayed by four ticks, skip them all
+      $NEXT_TICK = $NOW if $NOW >= $NEXT_TICK + $TICK * 4;
+
+      $TICK_WATCHER->at ($NEXT_TICK);
+      $TICK_WATCHER->start;
+   },
+);
+
 1