[ViewVC] Diff of: cvs/deliantra/server/random

Comparing deliantra/server/random_maps/wall.C (file contents):
Revision 1.39 by root, Fri Jul 2 16:24:25 2010 UTC vs.
Revision 1.43 by root, Fri Jul 2 17:43:16 2010 UTC

  *
  * The authors can be reached via e-mail to <support@deliantra.net>
  */
 #include <global.h>
+#include <util.h>
 #include <random_map.h>
 #include <rproto.h>
 /*  Put in the walls and autojoin them.  */
      2 = wall to right,
      4 = wall above
      8 = wall below */
   int surround_index = 0;
-  if (i >     0 && maze[i - 1][j] != 0) surround_index |= 1;
+  if (i >          0 && maze[i - 1][j] != 0) surround_index |= 1;
   if (i < maze.w - 1 && maze[i + 1][j] != 0) surround_index |= 2;
-  if (j >     0 && maze[i][j - 1] != 0) surround_index |= 4;
+  if (j >          0 && maze[i][j - 1] != 0) surround_index |= 4;
   if (j < maze.h - 1 && maze[i][j + 1] != 0) surround_index |= 8;
   return surround_index;
 }
      2 = wall to right,
      4 = wall above
      8 = wall below */
   int surround_index = 0;
-  if (i >     0 && maze[i - 1][j] == '#') surround_index |= 1;
+  if (i >          0 && maze[i - 1][j] == '#') surround_index |= 1;
   if (i < maze.w - 1 && maze[i + 1][j] == '#') surround_index |= 2;
-  if (j >     0 && maze[i][j - 1] == '#') surround_index |= 4;
+  if (j >          0 && maze[i][j - 1] == '#') surround_index |= 4;
   if (j < maze.h - 1 && maze[i][j + 1] == '#') surround_index |= 8;
   return surround_index;
 }
   /* extract the wall name, which is the text up to the leading _ */
   for (l = 0; l < 64; l++)
     {
       if (wall_name[l] == '_')
         {
-          wall_name[++l] = 0;
+          wall_name[l] = 0;
           break;
         }
     }
+  strcat (wall_name, "_");
   strcat (wall_name, wall_suffix [surround_flag2 (maze, i, j)]);
   wall_arch = archetype::find (wall_name);
   return wall_arch ? wall_arch->instance () : the_wall->arch->instance ();
+}
+// checks whether the layout has a "reachable" space at a given point, i.e.
+// not a wall that is completely surrounded by walls.
+static bool inline
+is_visible (layout &maze, int i, int j)
+{
+  for (int dx = -1; dx <= 1; ++dx)
+    for (int dy = -1; dy <= 1; ++dy)
+      {
+        int x = i + dx;
+        int y = j + dy;
+        if (IN_RANGE_EXC (x, 0, maze.w)
+            && IN_RANGE_EXC (y, 0, maze.h)
+            && maze [x][y] != '#')
+          return true;
+      }
+  return false;
 }
 /* takes a map and a maze, and puts walls in the map (picked from
         w_style) at '#' marks. */
 void
       ? find_style ("/styles/miningstyles", m_style, RP->difficulty)
       : 0;
   if ((the_wall = style_map->pick_random_object (rmg_rndm)))
     {
-      int i, j;
+      // first pass, remove all "unreachable" (in-rock) walls
-      char *cp;
+      // and replace them by "blocked" spaces.
+      layout clean_maze (maze);
+      if (archetype *blocked = archetype::find ("blocked"))
+        for (int x = 0; x < maze.w; ++x)
+          for (int y = 0; y < maze.h; ++y)
+            if (maze [x][y] == '#' && !is_visible (maze, x, y))
+              {
+                clean_maze [x][y] = 'X';
+                // erase everything on this space ad replace it by blocked
+                mapspace &ms = map->at (x, y);
+                while (ms.top)
+                  ms.top->destroy ();
+                map->insert (blocked->instance (), x, y, 0, INS_NO_MERGE | INS_NO_WALK_ON);
+              }
+      // second pass, add in walls
       int joinedwalls = 0;
-      object *thiswall;
-      sprintf (RP->wall_name, "%s", &the_wall->arch->archname);
+      assign (RP->wall_name, the_wall->arch->archname);
-      if ((cp = strchr (RP->wall_name, '_')) != NULL)
+      if (char *cp = strchr (RP->wall_name, '_'))
         {
           *cp = 0;
           joinedwalls = 1;
         }
-      for (i = 0; i < RP->Xsize; i++)
+      for (int i = 0; i < RP->Xsize; i++)
-        for (j = 0; j < RP->Ysize; j++)
+        for (int j = 0; j < RP->Ysize; j++)
-          {
-            if (maze[i][j] == '#')
+          if (clean_maze [i][j] == '#')
-              {
+            {
-                if (joinedwalls)
-                  thiswall = pick_joined_wall (the_wall, maze, i, j, RP);
+              object *thiswall = joinedwalls ? pick_joined_wall (the_wall, clean_maze, i, j, RP)
-                else
+                                             : the_wall->arch->instance ();
-                  thiswall = the_wall->arch->instance ();
-                thiswall->move_block = MOVE_ALL;
+              thiswall->move_block = MOVE_ALL;
-                map->insert (thiswall, i, j, thiswall, INS_NO_MERGE | INS_NO_WALK_ON);
+              map->insert (thiswall, i, j, thiswall, INS_NO_MERGE | INS_NO_WALK_ON);
-                if (mining_map)
+              if (mining_map)
-                  if (object *vein = mining_map->at (rmg_rndm (mining_map->width), rmg_rndm (mining_map->height)).bot)
+                if (object *vein = mining_map->at (rmg_rndm (mining_map->width), rmg_rndm (mining_map->height)).bot)
-                    map->insert (vein->clone (), i, j, thiswall, INS_NO_MERGE | INS_NO_WALK_ON);
+                  map->insert (vein->clone (), i, j, thiswall, INS_NO_MERGE | INS_NO_WALK_ON);
-              }
+            }
-          }
     }
 }
 /* this takes a map, and changes an existing wall to match what's blocked
  * around it, counting only doors and walls as blocked.  If insert_flag is
   object *the_wall = 0;
   object *new_wall = 0;
   archetype *wall_arch = 0;
   /* first find the wall */
-  for (the_wall = GET_MAP_OB (the_map, i, j); the_wall != NULL; the_wall = the_wall->above)
+  for (the_wall = GET_MAP_OB (the_map, i, j); the_wall; the_wall = the_wall->above)
     if ((the_wall->move_type & MOVE_WALK) && the_wall->type != EXIT && the_wall->type != TELEPORTER)
       break;
   /* if what we found is a door, don't remove it, set the_wall to NULL to
    * signal that later.
    */
   if (the_wall && (the_wall->type == DOOR || the_wall->type == LOCKED_DOOR))
   /* canonicalize the wall name */
   for (l = 0; l < 64; l++)
     {
       if (RP->wall_name[l] == '_')
         {
-          RP->wall_name[++l] = 0;
+          RP->wall_name[l] = 0;
           break;
         }
     }
+  strcat (RP->wall_name, "_");
   strcat (RP->wall_name, wall_suffix [surround_flag4 (the_map, i, j)]);
   wall_arch = archetype::find (RP->wall_name);
   if (!wall_arch)

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/random_maps/wall.C (file contents): Revision 1.39 by root, Fri Jul 2 16:24:25 2010 UTC vs. Revision 1.43 by root, Fri Jul 2 17:43:16 2010 UTC

Diff Legend

Comparing deliantra/server/random_maps/wall.C (file contents):
Revision 1.39 by root, Fri Jul 2 16:24:25 2010 UTC vs.
Revision 1.43 by root, Fri Jul 2 17:43:16 2010 UTC