ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/apply.C
(Generate patch)

Comparing deliantra/server/server/apply.C (file contents):
Revision 1.113 by root, Tue Jul 10 05:51:38 2007 UTC vs.
Revision 1.187 by elmex, Tue Jan 13 13:29:57 2009 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation, either version 3 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
… …
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24#include <cmath> 24#include <cmath>
25 25
26#include <global.h> 26#include <global.h>
… …
53 * subtype 5: arch or race 53 * subtype 5: arch or race
54 * subtype 7: all three 54 * subtype 7: all three
55 */ 55 */
56 if (op->subtype) 56 if (op->subtype)
57 { 57 {
58 arch_flag = (op->subtype & 1); 58 arch_flag = op->subtype & 1;
59 name_flag = (op->subtype & 2); 59 name_flag = op->subtype & 2;
60 race_flag = (op->subtype & 4); 60 race_flag = op->subtype & 4;
61 } 61 }
62 else 62 else
63 { 63 {
64 arch_flag = 1; 64 arch_flag = 1;
65 name_flag = 1; 65 name_flag = 1;
… …
92 * Return value: 1 if money was destroyed, 0 if not. 92 * Return value: 1 if money was destroyed, 0 if not.
93 */ 93 */
94static int 94static int
95apply_id_altar (object *money, object *altar, object *pl) 95apply_id_altar (object *money, object *altar, object *pl)
96{ 96{
97 object *id, *marked; 97 dynbuf_text buf;
98 int success = 0;
99 98
100 if (pl == NULL || pl->type != PLAYER) 99 if (!pl || pl->type != PLAYER)
101 return 0; 100 return 0;
102 101
103 /* Check for MONEY type is a special hack - it prevents 'nothing needs 102 /* Check for MONEY type is a special hack - it prevents 'nothing needs
104 * identifying' from being printed out more than it needs to be. 103 * identifying' from being printed out more than it needs to be.
105 */ 104 */
106 if (!check_altar_sacrifice (altar, money) || money->type != MONEY) 105 if (!check_altar_sacrifice (altar, money) || money->type != MONEY)
107 return 0; 106 return 0;
108 107
109 marked = find_marked_object (pl);
110 /* if the player has a marked item, identify that if it needs to be 108 /* if the player has a marked item, identify that if it needs to be
111 * identified. IF it doesn't, then go through the player inventory. 109 * identified. If it doesn't, then go through the player inventory.
112 */ 110 */
111 if (object *marked = find_marked_object (pl))
113 if (marked && !QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked)) 112 if (!QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked))
114 { 113 {
115 if (operate_altar (altar, &money)) 114 if (operate_altar (altar, &money))
116 { 115 {
117 identify (marked); 116 identify (marked);
118 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (marked, pl)); 117
118 buf.printf ("You have %s.\r", long_desc (marked, pl));
119 if (marked->msg) 119 if (marked->msg)
120 { 120 buf << "The item has a story:\r" << marked->msg << "\n\n";
121 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 121
122 new_draw_info (NDI_UNIQUE, 0, pl, marked->msg); 122 return !money;
123 } 123 }
124 return money == NULL;
125 } 124 }
126 }
127 125
128 for (id = pl->inv; id; id = id->below) 126 for (object *id = pl->inv; id; id = id->below)
129 { 127 {
130 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id)) 128 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id))
131 { 129 {
132 if (operate_altar (altar, &money)) 130 if (operate_altar (altar, &money))
133 { 131 {
134 identify (id); 132 identify (id);
135 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (id, pl)); 133
134 buf.printf ("You have %s.\r", long_desc (id, pl));
136 if (id->msg) 135 if (id->msg)
137 { 136 buf << "The item has a story:\r" << id->msg << "\n\n";
138 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 137
139 new_draw_info (NDI_UNIQUE, 0, pl, id->msg);
140 }
141 success = 1;
142 /* If no more money, might as well quit now */ 138 /* If no more money, might as well quit now */
143 if (money == NULL || !check_altar_sacrifice (altar, money)) 139 if (!money || !check_altar_sacrifice (altar, money))
144 break; 140 break;
145 } 141 }
146 else 142 else
147 { 143 {
148 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n"); 144 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n");
149 break; 145 break;
150 } 146 }
151 } 147 }
152 } 148 }
153 if (!success) 149
154 new_draw_info (NDI_UNIQUE, 0, pl, "You have nothing that needs identifying"); 150 if (buf.empty ())
151 pl->failmsg ("You have nothing that needs identifying");
152 else
153 pl->contr->infobox (MSG_CHANNEL ("identify"), buf);
154
155 return money == NULL; 155 return !money;
156} 156}
157 157
158/** 158/**
159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops 159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops
160 * matching item. 160 * matching item.
161 **/ 161 **/
162static void 162void
163handle_apply_yield (object *tmp) 163handle_apply_yield (object *tmp)
164{ 164{
165 const char *yield; 165 if (shstr_tmp yield = tmp->kv (shstr_on_use_yield))
166 166 archetype::get (yield)->insert_at (tmp, tmp, INS_BELOW_ORIGINATOR);
167 yield = get_ob_key_value (tmp, "on_use_yield");
168 if (yield != NULL)
169 {
170 object *drop = get_archetype (yield);
171
172 if (tmp->env)
173 {
174 drop = insert_ob_in_ob (drop, tmp->env);
175 if (tmp->env->type == PLAYER)
176 esrv_send_item (tmp->env, drop);
177 }
178 else
179 {
180 drop->x = tmp->x;
181 drop->y = tmp->y;
182 insert_ob_in_map (drop, tmp->map, tmp, INS_BELOW_ORIGINATOR);
183 }
184 }
185} 167}
186 168
187/** 169/**
188 * Handles applying a potion. 170 * Handles applying a potion.
189 */ 171 */
… …
195 177
196 floor = GET_MAP_OB (op->map, op->x, op->y); 178 floor = GET_MAP_OB (op->map, op->x, op->y);
197 179
198 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE) 180 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE)
199 { 181 {
200 if (op->type == PLAYER)
201 new_draw_info (NDI_UNIQUE, 0, op, "Gods prevent you from using this here, it's sacred ground!"); 182 op->failmsg ("Gods prevent you from using this here, it's sacred ground!");
183
202 CLEAR_FLAG (tmp, FLAG_APPLIED); 184 CLEAR_FLAG (tmp, FLAG_APPLIED);
203 return 0; 185 return 0;
204 } 186 }
205 187
206 if (op->type == PLAYER) 188 if (op->type == PLAYER)
… …
217 199
218 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 200 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
219 { 201 {
220 op->drain_stat (); 202 op->drain_stat ();
221 op->update_stats (); 203 op->update_stats ();
222 decrease_ob (tmp); 204 tmp->decrease ();
223 return 1; 205 return 1;
224 } 206 }
225 207
226 if (!(at = archetype::find (ARCH_DEPLETION))) 208 if (!(at = archetype::find (ARCH_DEPLETION)))
227 { 209 {
228 LOG (llevError, "Could not find archetype depletion\n"); 210 LOG (llevError, "Could not find archetype depletion\n");
229 return 0; 211 return 0;
230 } 212 }
213
231 depl = present_arch_in_ob (at, op); 214 depl = present_arch_in_ob (at, op);
232 215
233 if (depl) 216 if (depl)
234 { 217 {
235 for (i = 0; i < NUM_STATS; i++) 218 for (i = 0; i < NUM_STATS; i++)
236 if (depl->stats.stat (i)) 219 if (depl->stats.stat (i))
237 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]); 220 op->statusmsg (restore_msg[i]);
238 221
239 depl->destroy (); 222 depl->destroy ();
240 op->update_stats (); 223 op->update_stats ();
241 } 224 }
242 else 225 else
243 new_draw_info (NDI_UNIQUE, 0, op, "You potion had no effect."); 226 op->statusmsg ("Your potion had no effect.");
244 227
245 decrease_ob (tmp); 228 tmp->decrease ();
246 return 1; 229 return 1;
247 } 230 }
248 231
249 /* improvement potion - only for players */ 232 /* improvement potion - only for players */
250 if (op->type == PLAYER && tmp->attacktype & AT_GODPOWER) 233 if (op->type == PLAYER && (tmp->attacktype & AT_GODPOWER))
251 { 234 {
252 for (i = 1; i < MIN (11, op->level); i++) 235 for (i = 1; i < MIN (11, op->level); i++)
253 { 236 {
254 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 237 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
255 { 238 {
256 if (op->contr->levhp[i] != 1) 239 if (op->contr->levhp[i] != 1)
257 { 240 {
258 op->contr->levhp[i] = 1; 241 op->contr->levhp[i] = 1;
259 break; 242 break;
260 } 243 }
244
261 if (op->contr->levsp[i] != 1) 245 if (op->contr->levsp[i] != 1)
262 { 246 {
263 op->contr->levsp[i] = 1; 247 op->contr->levsp[i] = 1;
264 break; 248 break;
265 } 249 }
250
266 if (op->contr->levgrace[i] != 1) 251 if (op->contr->levgrace[i] != 1)
267 { 252 {
268 op->contr->levgrace[i] = 1; 253 op->contr->levgrace[i] = 1;
269 break; 254 break;
270 } 255 }
… …
274 if (op->contr->levhp[i] < 9) 259 if (op->contr->levhp[i] < 9)
275 { 260 {
276 op->contr->levhp[i] = 9; 261 op->contr->levhp[i] = 9;
277 break; 262 break;
278 } 263 }
264
279 if (op->contr->levsp[i] < 6) 265 if (op->contr->levsp[i] < 6)
280 { 266 {
281 op->contr->levsp[i] = 6; 267 op->contr->levsp[i] = 6;
282 break; 268 break;
283 } 269 }
270
284 if (op->contr->levgrace[i] < 3) 271 if (op->contr->levgrace[i] < 3)
285 { 272 {
286 op->contr->levgrace[i] = 3; 273 op->contr->levgrace[i] = 3;
287 break; 274 break;
288 } 275 }
… …
296 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)) 283 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))
297 { 284 {
298 if (got_one) 285 if (got_one)
299 { 286 {
300 op->update_stats (); 287 op->update_stats ();
301 new_draw_info (NDI_UNIQUE, 0, op, "The Gods smile upon you and remake you"); 288 op->statusmsg ("The Gods smile upon you and remake you "
302 new_draw_info (NDI_UNIQUE, 0, op, "a little more in their image."); 289 "a little more in their image. "
303 new_draw_info (NDI_UNIQUE, 0, op, "You feel a little more perfect."); 290 "You feel a little more perfect.", NDI_GREEN);
304 } 291 }
305 else 292 else
306 new_draw_info (NDI_UNIQUE, 0, op, "The potion had no effect - you are already perfect"); 293 op->statusmsg ("The potion had no effect - you are already perfect.");
307 } 294 }
308 else 295 else
309 { /* cursed potion */ 296 { /* cursed potion */
310 if (got_one) 297 if (got_one)
311 { 298 {
312 op->update_stats (); 299 op->update_stats ();
313 new_draw_info (NDI_UNIQUE, 0, op, "The Gods are angry and punish you."); 300 op->failmsg ("The Gods are angry and punish you.");
314 } 301 }
315 else 302 else
316 new_draw_info (NDI_UNIQUE, 0, op, "You are fortunate that you are so pathetic."); 303 op->statusmsg ("You are fortunate that you are so pathetic.", NDI_DK_ORANGE);
317 } 304 }
318 305
319 decrease_ob (tmp); 306 tmp->decrease ();
320 return 1; 307 return 1;
321 } 308 }
322 309
323 310
324 /* A potion that casts a spell. Healing, restore spellpoint (power potion) 311 /* A potion that casts a spell. Healing, restore spellpoint (power potion)
… …
328 */ 315 */
329 if (tmp->inv) 316 if (tmp->inv)
330 { 317 {
331 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 318 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
332 { 319 {
333 object *fball; 320 op->failmsg ("Yech! Your lungs are on fire!");
334 321 create_exploding_ball_at (op, op->level);
335 new_draw_info (NDI_UNIQUE, 0, op, "Yech! Your lungs are on fire!");
336 /* Explodes a fireball centered at player */
337 fball = get_archetype (EXPLODING_FIREBALL);
338 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1;
339 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2;
340 fball->x = op->x;
341 fball->y = op->y;
342 insert_ob_in_map (fball, op->map, NULL, 0);
343 } 322 }
344 else 323 else
345 cast_spell (op, tmp, op->facing, tmp->inv, NULL); 324 cast_spell (op, tmp, op->facing, tmp->inv, NULL);
346 325
347 decrease_ob (tmp); 326 tmp->decrease ();
327
348 /* if youre dead, no point in doing this... */ 328 /* if youre dead, no point in doing this... */
349 if (!QUERY_FLAG (op, FLAG_REMOVED)) 329 if (!QUERY_FLAG (op, FLAG_REMOVED))
350 op->update_stats (); 330 op->update_stats ();
331
351 return 1; 332 return 1;
352 } 333 }
353 334
354 /* Deal with protection potions */ 335 /* Deal with protection potions */
355 force = NULL; 336 force = NULL;
… …
357 { 338 {
358 if (tmp->resist[i]) 339 if (tmp->resist[i])
359 { 340 {
360 if (!force) 341 if (!force)
361 force = get_archetype (FORCE_NAME); 342 force = get_archetype (FORCE_NAME);
343
362 memcpy (force->resist, tmp->resist, sizeof (tmp->resist)); 344 memcpy (force->resist, tmp->resist, sizeof (tmp->resist));
363 force->type = POTION_EFFECT; 345 force->type = POTION_EFFECT;
364 break; /* Only need to find one protection since we copy entire batch */ 346 break; /* Only need to find one protection since we copy entire batch */
365 } 347 }
366 } 348 }
349
367 /* This is a protection potion */ 350 /* This is a protection potion */
368 if (force) 351 if (force)
369 { 352 {
370 /* cursed items last longer */ 353 /* cursed items last longer */
371 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 354 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
… …
379 force->speed_left = -1; 362 force->speed_left = -1;
380 force = insert_ob_in_ob (force, op); 363 force = insert_ob_in_ob (force, op);
381 CLEAR_FLAG (tmp, FLAG_APPLIED); 364 CLEAR_FLAG (tmp, FLAG_APPLIED);
382 SET_FLAG (force, FLAG_APPLIED); 365 SET_FLAG (force, FLAG_APPLIED);
383 change_abil (op, force); 366 change_abil (op, force);
384 decrease_ob (tmp); 367 tmp->decrease ();
385 return 1; 368 return 1;
386 } 369 }
387 370
388 /* Only thing left are the stat potions */ 371 /* Only thing left are the stat potions */
389 if (op->type == PLAYER) 372 if (op->type == PLAYER)
390 { /* only for players */ 373 { /* only for players */
391 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0) 374 if ((QUERY_FLAG (tmp, FLAG_CURSED)
375 || QUERY_FLAG (tmp, FLAG_DAMNED))
376 && tmp->value != 0)
392 CLEAR_FLAG (tmp, FLAG_APPLIED); 377 CLEAR_FLAG (tmp, FLAG_APPLIED);
393 else 378 else
394 SET_FLAG (tmp, FLAG_APPLIED); 379 SET_FLAG (tmp, FLAG_APPLIED);
380
395 if (!change_abil (op, tmp)) 381 if (!change_abil (op, tmp))
396 new_draw_info (NDI_UNIQUE, 0, op, "Nothing happened."); 382 op->statusmsg ("Nothing happened.");
397 } 383 }
398 384
399 /* CLEAR_FLAG is so that if the character has other potions 385 /* CLEAR_FLAG is so that if the character has other potions
400 * that were grouped with the one consumed, his 386 * that were grouped with the one consumed, his
401 * stat will not be raised by them. fix_player just clears 387 * stat will not be raised by them. fix_player just clears
402 * up all the stats. 388 * up all the stats.
403 */ 389 */
404 CLEAR_FLAG (tmp, FLAG_APPLIED); 390 CLEAR_FLAG (tmp, FLAG_APPLIED);
405 op->update_stats (); 391 op->update_stats ();
406 decrease_ob (tmp); 392 tmp->decrease ();
407 return 1; 393 return 1;
408} 394}
409 395
410/**************************************************************************** 396/****************************************************************************
411 * Weapon improvement code follows 397 * Weapon improvement code follows
… …
413 399
414/** 400/**
415 * This returns the sum of nrof of item (arch name). 401 * This returns the sum of nrof of item (arch name).
416 */ 402 */
417static int 403static int
418check_item (object *op, const char *item) 404check_item (object *op, shstr_cmp item)
419{ 405{
420 int count = 0; 406 int count = 0;
421 407
422 408 if (!item)
423 if (item == NULL)
424 return 0; 409 return 0;
425 410
426 op = op->below; 411 for (op = op->below; op; op = op->below)
427 while (op != NULL)
428 {
429 if (strcmp (op->arch->archname, item) == 0) 412 if (op->arch->archname == item)
430 {
431 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED) 413 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED)
432 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID)) 414 && /* Loophole bug? -FD- */ !QUERY_FLAG (op, FLAG_UNPAID))
433 {
434 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */
435 count++;
436 else
437 count += op->nrof; 415 count += op->number_of ();
438 }
439 }
440
441 op = op->below;
442 }
443 416
444 return count; 417 return count;
445} 418}
446 419
447/** 420/**
… …
449 * op is typically the player, which is only 422 * op is typically the player, which is only
450 * really used to determine what space to look at. 423 * really used to determine what space to look at.
451 * Modified to only eat 'nrof' of objects. 424 * Modified to only eat 'nrof' of objects.
452 */ 425 */
453static void 426static void
454eat_item (object *op, const char *item, uint32 nrof) 427eat_item (object *op, shstr_cmp item, uint32 nrof)
455{ 428{
456 object *prev; 429 object *prev;
457 430
458 prev = op; 431 prev = op;
459 op = op->below; 432 op = op->below;
460 433
461 while (op != NULL) 434 while (op)
462 { 435 {
463 if (strcmp (op->arch->archname, item) == 0) 436 if (op->arch->archname == item)
464 { 437 {
465 if (op->nrof >= nrof) 438 if (op->nrof >= nrof)
466 { 439 {
467 decrease_ob_nr (op, nrof); 440 op->decrease (nrof);
468 return; 441 return;
469 } 442 }
470 else 443 else
471 { 444 {
472 decrease_ob_nr (op, op->nrof); 445 op->decrease (nrof);
473 nrof -= op->nrof; 446 nrof -= op->nrof;
474 } 447 }
448
475 op = prev; 449 op = prev;
476 } 450 }
451
477 prev = op; 452 prev = op;
478 op = op->below; 453 op = op->below;
479 } 454 }
480} 455}
481 456
… …
487 * we return 1 (true) if the player can use the weapon. 462 * we return 1 (true) if the player can use the weapon.
488 */ 463 */
489static int 464static int
490check_weapon_power (const object *who, int improvs) 465check_weapon_power (const object *who, int improvs)
491{ 466{
492
493/* Old code is below (commented out). Basically, since weapons are the only 467/* Old code is below (commented out). Basically, since weapons are the only
494 * object players really have any control to improve, it's a bit harsh to 468 * object players really have any control to improve, it's a bit harsh to
495 * require high level in some combat skill, so we just use overall level. 469 * require high level in some combat skill, so we just use overall level.
496 */ 470 */
497#if 1 471#if 1
… …
538static int 512static int
539check_sacrifice (object *op, const object *improver) 513check_sacrifice (object *op, const object *improver)
540{ 514{
541 int count = 0; 515 int count = 0;
542 516
543 if (improver->slaying != NULL) 517 if (improver->slaying)
544 { 518 {
545 count = check_item (op, improver->slaying); 519 count = check_item (op, improver->slaying);
546 if (count < 1) 520 if (count < 1)
547 { 521 {
548 char buf[200];
549
550 sprintf (buf, "The gods want more %ss", &improver->slaying); 522 op->failmsg (format ("The gods want more %ss", &improver->slaying));
551 new_draw_info (NDI_UNIQUE, 0, op, buf);
552 return 0; 523 return 0;
553 } 524 }
554 } 525 }
555 else 526 else
556 count = 1; 527 count = 1;
… …
559} 530}
560 531
561/** 532/**
562 * Actually improves the weapon, and tells user. 533 * Actually improves the weapon, and tells user.
563 */ 534 */
564int 535static int
565improve_weapon_stat (object *op, object *improver, object *weapon, signed char *stat, int sacrifice_count, const char *statname) 536improve_weapon_stat (object *op, object *improver, object *weapon, sint8 &stat, int sacrifice_count, const char *statname)
566{ 537{
567
568 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
569 *stat += sacrifice_count; 538 stat += sacrifice_count;
570 weapon->last_eat++; 539 weapon->last_eat++;
571 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon's bonus to %s improved by %d", statname, sacrifice_count); 540 improver->decrease ();
572 decrease_ob (improver);
573 541
574 /* So it updates the players stats and the window */ 542 /* So it updates the players stats and the window */
575 op->update_stats (); 543 op->update_stats ();
544
545 op->statusmsg (format (
546 "Your sacrifice was accepted.\n"
547 "Weapon's bonus to %s improved by %d.",
548 statname, sacrifice_count
549 ));
550
576 return 1; 551 return 1;
577} 552}
578 553
579/* Types of improvements, hidden in the sp field. */ 554/* Types of improvements, hidden in the sp field. */
580#define IMPROVE_PREPARE 1 555#define IMPROVE_PREPARE 1
581#define IMPROVE_DAMAGE 2 556#define IMPROVE_DAMAGE 2
582#define IMPROVE_WEIGHT 3 557#define IMPROVE_WEIGHT 3
583#define IMPROVE_ENCHANT 4 558#define IMPROVE_ENCHANT 4
584#define IMPROVE_STR 5 559#define IMPROVE_STR 5
585#define IMPROVE_DEX 6 560#define IMPROVE_DEX 6
586#define IMPROVE_CON 7 561#define IMPROVE_CON 7
587#define IMPROVE_WIS 8 562#define IMPROVE_WIS 8
588#define IMPROVE_CHA 9 563#define IMPROVE_CHA 9
589#define IMPROVE_INT 10 564#define IMPROVE_INT 10
590#define IMPROVE_POW 11 565#define IMPROVE_POW 11
591
592 566
593/** 567/**
594 * This does the prepare weapon scroll. 568 * This does the prepare weapon scroll.
595 * Checks for sacrifice, and so on. 569 * Checks for sacrifice, and so on.
596 */ 570 */
597
598int 571int
599prepare_weapon (object *op, object *improver, object *weapon) 572prepare_weapon (object *op, object *improver, object *weapon)
600{ 573{
601 int sacrifice_count, i; 574 int sacrifice_count, i;
602 char buf[MAX_BUF]; 575 char buf[MAX_BUF];
603 576
604 if (weapon->level != 0) 577 if (weapon->level != 0)
605 { 578 {
606 new_draw_info (NDI_UNIQUE, 0, op, "Weapon already prepared."); 579 op->failmsg ("Weapon is already prepared!");
607 return 0; 580 return 0;
608 } 581 }
582
609 for (i = 0; i < NROFATTACKS; i++) 583 for (i = 0; i < NROFATTACKS; i++)
610 if (weapon->resist[i]) 584 if (weapon->resist[i])
611 break; 585 break;
612 586
613 /* If we break out, i will be less than nrofattacks, preventing 587 /* If we break out, i will be less than nrofattacks, preventing
… …
616 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */ 590 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */
617 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */ 591 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */
618 weapon->stats.exp || /* speed */ 592 weapon->stats.exp || /* speed */
619 weapon->stats.ac) /* AC - only taifu's I think */ 593 weapon->stats.ac) /* AC - only taifu's I think */
620 { 594 {
621 new_draw_info (NDI_UNIQUE, 0, op, "Cannot prepare magic weapons."); 595 op->failmsg ("You cannot prepare magic weapons. "
596 "H<A weapon is considered magical if it changes regeneration, "
597 "speed or ac, or has other protections.>");
622 return 0; 598 return 0;
623 } 599 }
600
624 sacrifice_count = check_sacrifice (op, improver); 601 sacrifice_count = check_sacrifice (op, improver);
625 if (sacrifice_count <= 0) 602 if (sacrifice_count <= 0)
626 return 0; 603 return 0;
604
627 weapon->level = isqrt (sacrifice_count); 605 weapon->level = isqrt (sacrifice_count);
628 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
629 eat_item (op, improver->slaying, sacrifice_count); 606 eat_item (op, improver->slaying, sacrifice_count);
630 607
631 new_draw_info_format (NDI_UNIQUE, 0, op, "Your *%s may be improved %d times.", &weapon->name, weapon->level); 608 op->statusmsg (format (
609 "Your sacrifice was accepted."
610 "Your *%s may be improved %d times.",
611 &weapon->name, weapon->level
612 ));
632 613
633 sprintf (buf, "%s's %s", &op->name, &weapon->name); 614 sprintf (buf, "%s's %s", &op->name, &weapon->name);
634 weapon->name = weapon->name_pl = buf; 615 weapon->name = weapon->name_pl = buf;
635 weapon->nrof = 0; /* prevents preparing n weapons in the same 616 weapon->nrof = 0; /* prevents preparing n weapons in the same
636 slot at once! */ 617 slot at once! */
637 decrease_ob (improver); 618 improver->decrease ();
638 weapon->last_eat = 0; 619 weapon->last_eat = 0;
639 return 1; 620 return 1;
640} 621}
641
642 622
643/** 623/**
644 * Does the dirty job for 'improve weapon' scroll, prepare or add something. 624 * Does the dirty job for 'improve weapon' scroll, prepare or add something.
645 * This is the new improve weapon code. 625 * This is the new improve weapon code.
646 * Returns 0 if it was not able to work for some reason. 626 * Returns 0 if it was not able to work for some reason.
… …
655improve_weapon (object *op, object *improver, object *weapon) 635improve_weapon (object *op, object *improver, object *weapon)
656{ 636{
657 int sacrifice_count, sacrifice_needed = 0; 637 int sacrifice_count, sacrifice_needed = 0;
658 638
659 if (improver->stats.sp == IMPROVE_PREPARE) 639 if (improver->stats.sp == IMPROVE_PREPARE)
660 {
661 return prepare_weapon (op, improver, weapon); 640 return prepare_weapon (op, improver, weapon);
662 } 641
663 if (weapon->level == 0) 642 if (weapon->level == 0)
664 { 643 {
665 new_draw_info (NDI_UNIQUE, 0, op, "This weapon has not been prepared."); 644 op->failmsg ("This weapon has not been prepared. H<You first ahve to prepare a weapon with a prepare weapon scroll.>");
666 return 0; 645 return 0;
667 } 646 }
647
668 if (weapon->level == weapon->last_eat && weapon->item_power >= 100) 648 if (weapon->level == weapon->last_eat && weapon->item_power >= 100)
669 { 649 {
670 new_draw_info (NDI_UNIQUE, 0, op, "This weapon cannot be improved any more."); 650 op->failmsg ("This weapon cannot be improved any more.");
671 return 0; 651 return 0;
672 } 652 }
653
673 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1)) 654 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1))
674 { 655 {
675 new_draw_info (NDI_UNIQUE, 0, op, "Improving the weapon will make it too"); 656 op->failmsg ("Improving the weapon will make it too "
676 new_draw_info (NDI_UNIQUE, 0, op, "powerful for you to use. Unready it if you"); 657 "powerful for you to use. Unready it if you "
677 new_draw_info (NDI_UNIQUE, 0, op, "really want to improve it."); 658 "really want to improve it.");
678 return 0; 659 return 0;
679 } 660 }
661
680 /* This just increases damage by 5 points, no matter what. No sacrifice 662 /* This just increases damage by 5 points, no matter what. No sacrifice
681 * is needed. Since stats.dam is now a 16 bit value and not 8 bit, 663 * is needed. Since stats.dam is now a 16 bit value and not 8 bit,
682 * don't put any maximum value on damage - the limit is how much the 664 * don't put any maximum value on damage - the limit is how much the
683 * weapon can be improved. 665 * weapon can be improved.
684 */ 666 */
685 if (improver->stats.sp == IMPROVE_DAMAGE) 667 if (improver->stats.sp == IMPROVE_DAMAGE)
686 { 668 {
687 weapon->stats.dam += 5; 669 weapon->stats.dam += 5;
688 weapon->weight += 5000; /* 5 KG's */ 670 weapon->weight += 5000; /* 5 KG's */
689 new_draw_info_format (NDI_UNIQUE, 0, op, "Damage has been increased by 5 to %d", weapon->stats.dam); 671 op->statusmsg (format ("Damage has been increased by 5 to %d.", weapon->stats.dam));
690 weapon->last_eat++; 672 weapon->last_eat++;
691 673
692 weapon->item_power++; 674 weapon->item_power++;
693 decrease_ob (improver); 675 improver->decrease ();
694 return 1; 676 return 1;
695 } 677 }
678
696 if (improver->stats.sp == IMPROVE_WEIGHT) 679 if (improver->stats.sp == IMPROVE_WEIGHT)
697 { 680 {
698 /* Reduce weight by 20% */ 681 /* Reduce weight by 20% */
699 weapon->weight = (weapon->weight * 8) / 10; 682 weapon->weight = (weapon->weight * 8) / 10;
700 if (weapon->weight < 1) 683 if (weapon->weight < 1)
701 weapon->weight = 1; 684 weapon->weight = 1;
685
702 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon weight reduced to %6.1f kg", (float) weapon->weight / 1000.0); 686 op->statusmsg (format ("Weapon weight reduced to %6.1fkg.", (float) weapon->weight / 1000.0));
703 weapon->last_eat++; 687 weapon->last_eat++;
704 weapon->item_power++; 688 weapon->item_power++;
705 decrease_ob (improver); 689 improver->decrease ();
706 return 1; 690 return 1;
707 } 691 }
692
708 if (improver->stats.sp == IMPROVE_ENCHANT) 693 if (improver->stats.sp == IMPROVE_ENCHANT)
709 { 694 {
710 weapon->magic++; 695 weapon->magic++;
711 weapon->last_eat++; 696 weapon->last_eat++;
712 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon magic increased to %d", weapon->magic); 697 op->statusmsg (format ("Weapon magic increased to %d.", weapon->magic));
713 decrease_ob (improver); 698 improver->decrease ();
714 weapon->item_power++; 699 weapon->item_power++;
715 return 1; 700 return 1;
716 } 701 }
717 702
718 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex + 703 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex +
… …
723 sacrifice_needed *= 2; 708 sacrifice_needed *= 2;
724 709
725 sacrifice_count = check_sacrifice (op, improver); 710 sacrifice_count = check_sacrifice (op, improver);
726 if (sacrifice_count < sacrifice_needed) 711 if (sacrifice_count < sacrifice_needed)
727 { 712 {
728 new_draw_info_format (NDI_UNIQUE, 0, op, "You need at least %d %s", sacrifice_needed, &improver->slaying); 713 op->failmsg (format ("You need at least %d %s.", sacrifice_needed, &improver->slaying));
729 return 0; 714 return 0;
730 } 715 }
716
731 eat_item (op, improver->slaying, sacrifice_needed); 717 eat_item (op, improver->slaying, sacrifice_needed);
732 weapon->item_power++; 718 weapon->item_power++;
733 719
734 switch (improver->stats.sp) 720 switch (improver->stats.sp)
735 { 721 {
736 case IMPROVE_STR:
737 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Str), 1, "strength"); 722 case IMPROVE_STR: return improve_weapon_stat (op, improver, weapon, weapon->stats.Str, 1, "strength");
738 case IMPROVE_DEX:
739 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Dex), 1, "dexterity"); 723 case IMPROVE_DEX: return improve_weapon_stat (op, improver, weapon, weapon->stats.Dex, 1, "dexterity");
740 case IMPROVE_CON:
741 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Con), 1, "constitution"); 724 case IMPROVE_CON: return improve_weapon_stat (op, improver, weapon, weapon->stats.Con, 1, "constitution");
742 case IMPROVE_WIS:
743 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Wis), 1, "wisdom"); 725 case IMPROVE_WIS: return improve_weapon_stat (op, improver, weapon, weapon->stats.Wis, 1, "wisdom");
744 case IMPROVE_CHA:
745 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Cha), 1, "charisma"); 726 case IMPROVE_CHA: return improve_weapon_stat (op, improver, weapon, weapon->stats.Cha, 1, "charisma");
746 case IMPROVE_INT:
747 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Int), 1, "intelligence"); 727 case IMPROVE_INT: return improve_weapon_stat (op, improver, weapon, weapon->stats.Int, 1, "intelligence");
748 case IMPROVE_POW:
749 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Pow), 1, "power"); 728 case IMPROVE_POW: return improve_weapon_stat (op, improver, weapon, weapon->stats.Pow, 1, "power");
750 default: 729 default:
751 new_draw_info (NDI_UNIQUE, 0, op, "Unknown improvement type."); 730 op->failmsg ("Unknown improvement type.");
752 } 731 }
732
753 LOG (llevError, "improve_weapon: Got to end of function\n"); 733 LOG (llevError, "improve_weapon: Got to end of function\n");
754 return 0; 734 return 0;
755} 735}
756 736
757/** 737/**
… …
767 if (op->type != PLAYER) 747 if (op->type != PLAYER)
768 return 0; 748 return 0;
769 749
770 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 750 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC))
771 { 751 {
772 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 752 op->failmsg ("Something blocks the magic of the scroll!");
773 return 0; 753 return 0;
774 } 754 }
775 755
776 otmp = find_marked_object (op); 756 otmp = find_marked_object (op);
757
777 if (!otmp) 758 if (!otmp)
778 { 759 {
779 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark a weapon object."); 760 op->failmsg ("You need to mark a weapon object. H<Use the mark command or the mark option from the item popup menu.>");
780 return 0; 761 return 0;
781 } 762 }
782 763
783 if (otmp->type != WEAPON && otmp->type != BOW) 764 if (otmp->type != WEAPON && otmp->type != BOW)
784 { 765 {
785 new_draw_info (NDI_UNIQUE, 0, op, "Marked item is not a weapon or bow"); 766 op->failmsg ("Marked item is not a weapon or bow!");
786 return 0; 767 return 0;
787 } 768 }
788 769
789 new_draw_info (NDI_UNIQUE, 0, op, "Applied weapon builder."); 770 op->statusmsg ("Applied weapon builder.");
771
790 improve_weapon (op, tmp, otmp); 772 improve_weapon (op, tmp, otmp);
791 esrv_send_item (op, otmp); 773 esrv_send_item (op, otmp);
792 return 1; 774 return 1;
793} 775}
794 776
… …
819{ 801{
820 object *tmp; 802 object *tmp;
821 803
822 if (armour->magic >= settings.armor_max_enchant) 804 if (armour->magic >= settings.armor_max_enchant)
823 { 805 {
824 new_draw_info (NDI_UNIQUE, 0, op, "This armour can not be enchanted any further."); 806 op->failmsg ("This armour can not be enchanted any further!");
825 return 0; 807 return 0;
826 } 808 }
809
827 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight, 810 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight,
828 * etc), so take the easy way out and don't worry about it. 811 * etc), so take the easy way out and don't worry about it.
829 * Note - maybe add scrolls which make the random artifact versions (eg, armour 812 * Note - maybe add scrolls which make the random artifact versions (eg, armour
830 * of gnarg and what not?) 813 * of gnarg and what not?)
831 */ 814 */
832 if (armour->title) 815 if (armour->title)
833 { 816 {
834 new_draw_info (NDI_UNIQUE, 0, op, "This armour will not accept further enchantment."); 817 op->failmsg ("This armour will not accept further enchantment.");
835 return 0; 818 return 0;
836 } 819 }
837 820
838 /* Split objects if needed. Can't insert tmp until the 821 /* Split objects if needed. Can't insert tmp until the
839 * end of this function - otherwise it will just re-merge. 822 * end of this function - otherwise it will just re-merge.
840 */ 823 */
841 if (armour->nrof > 1) 824 tmp = armour->nrof > 1 ? armour->split (armour->nrof - 1) : 0;
842 tmp = get_split_ob (armour, armour->nrof - 1);
843 else
844 tmp = NULL;
845 825
846 armour->magic++; 826 armour->magic++;
847 827
848 if (!settings.armor_speed_linear) 828 if (!settings.armor_speed_linear)
849 { 829 {
… …
886 armour->item_power = get_power_from_ench (armour->arch->item_power + armour->magic); 866 armour->item_power = get_power_from_ench (armour->arch->item_power + armour->magic);
887 867
888 if (op->type == PLAYER) 868 if (op->type == PLAYER)
889 { 869 {
890 esrv_send_item (op, armour); 870 esrv_send_item (op, armour);
871
891 if (QUERY_FLAG (armour, FLAG_APPLIED)) 872 if (QUERY_FLAG (armour, FLAG_APPLIED))
892 op->update_stats (); 873 op->update_stats ();
893 } 874 }
894 decrease_ob (improver); 875
876 improver->decrease ();
877
895 if (tmp) 878 if (tmp)
896 { 879 op->insert (tmp);
897 insert_ob_in_ob (tmp, op); 880
898 esrv_send_item (op, tmp);
899 }
900 return 1; 881 return 1;
901} 882}
902
903 883
904/* 884/*
905 * convert_item() returns 1 if anything was converted, 0 if the item was not 885 * convert_item() returns 1 if anything was converted, 0 if the item was not
906 * what the converter wants, -1 if the converter is broken. 886 * what the converter wants, -1 if the converter is broken.
907 */ 887 *
908#define CONV_FROM(xyz) xyz->slaying
909#define CONV_TO(xyz) xyz->other_arch
910#define CONV_NR(xyz) xyz->stats.sp
911#define CONV_NEED(xyz) xyz->stats.food
912
913/* Takes one items and makes another. 888 * Takes one type of items and makes another.
914 * converter is the object that is doing the conversion. 889 * converter is the object that is doing the conversion.
915 * item is the object that triggered the converter - if it is not 890 * item is the object that triggered the converter - if it is not
916 * what the converter wants, this will not do anything. 891 * what the converter wants, this will not do anything.
917 */ 892 */
918int 893static int
919convert_item (object *item, object *converter) 894convert_item (object *item, object *converter)
920{ 895{
921 int nr = 0;
922 uint32 price_in; 896 sint64 nr, price_in;
897
898 if (item->flag [FLAG_UNPAID])
899 return 0;
900
901 shstr conv_from = converter->slaying;
902 archetype *conv_to = converter->other_arch;
903 sint64 need = converter->stats.food;
904 sint64 give = converter->stats.sp;
923 905
924 /* We make some assumptions - we assume if it takes money as it type, 906 /* We make some assumptions - we assume if it takes money as it type,
925 * it wants some amount. We don't make change (ie, if something costs 907 * it wants some amount. We don't make change (ie, if something costs
926 * 3 gp and player drops a platinum, tough luck) 908 * 3 gp and player drops a platinum, tough luck)
927 */ 909 */
928 if (!strcmp (CONV_FROM (converter), "money")) 910 if (conv_from == shstr_money)
929 { 911 {
930 int cost;
931
932 if (item->type != MONEY) 912 if (item->type != MONEY)
933 return 0; 913 return 0;
934 914
935 nr = (item->nrof * item->value) / CONV_NEED (converter); 915 nr = sint64 (item->nrof) * item->value / need;
936 if (!nr) 916 if (!nr)
937 return 0; 917 return 0;
938 cost = nr * CONV_NEED (converter) / item->value; 918
939 /* take into account rounding errors */ 919 converter->play_sound (sound_find ("shop_buy"));
940 if (nr * CONV_NEED (converter) % item->value) 920
941 cost++; 921 sint64 cost = (nr * need + item->value - 1) / item->value;
942 decrease_ob_nr (item, cost); 922
923 item->decrease (cost);
943 924
944 price_in = cost * item->value; 925 price_in = cost * item->value;
945 } 926 }
946 else 927 else
947 { 928 {
948 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->archname || 929 if (item->type == PLAYER
949 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof)) 930 || conv_from != item->arch->archname
931 || (need && need > (uint16) item->nrof))
950 return 0; 932 return 0;
951 933
952 if (CONV_NEED (converter)) 934 converter->play_sound (sound_find ("convert_item"));
935
936 if (need)
953 { 937 {
954 nr = item->nrof / CONV_NEED (converter); 938 nr = sint64 (item->nrof) / need;
955 decrease_ob_nr (item, nr * CONV_NEED (converter)); 939 item->decrease (nr * need);
956 price_in = nr * CONV_NEED (converter) * item->value; 940 price_in = nr * need * item->value;
957 } 941 }
958 else 942 else
959 { 943 {
960 price_in = item->value; 944 price_in = item->value;
961 item->destroy (); 945 item->destroy ();
962 } 946 }
963 } 947 }
964 948
965 if (converter->inv != NULL) 949 if (converter->inv)
966 { 950 {
967 object *ob; 951 object *ob;
968 int i; 952 int i;
969 object *ob_to_copy; 953 object *ob_to_copy;
970 954
971 /* select random object from inventory to copy */ 955 /* select random object from inventory to copy */
972 ob_to_copy = converter->inv; 956 ob_to_copy = converter->inv;
973 for (ob = converter->inv->below, i = 1; ob != NULL; ob = ob->below, i++) 957 for (ob = converter->inv->below, i = 1; ob; ob = ob->below, i++)
974 {
975 if (rndm (0, i) == 0) 958 if (rndm (0, i) == 0)
976 {
977 ob_to_copy = ob; 959 ob_to_copy = ob;
978 } 960
979 } 961 item = ob_to_copy->deep_clone ();
980 item = object_create_clone (ob_to_copy);
981 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE); 962 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE);
982 unflag_inv (item, FLAG_IS_A_TEMPLATE); 963 unflag_inv (item, FLAG_IS_A_TEMPLATE);
983 } 964 }
984 else 965 else
985 { 966 {
986 if (converter->other_arch == NULL) 967 if (!conv_to)
987 { 968 {
988 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n", 969 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n",
989 &converter->name, &converter->map->path, converter->x, converter->y); 970 &converter->name, &converter->map->path, converter->x, converter->y);
990 return -1; 971 return -1;
991 } 972 }
992 973
993 item = object_create_arch (converter->other_arch); 974 item = object_create_arch (conv_to);
994 fix_generated_item (item, converter, 0, 0, GT_MINIMAL); 975 fix_generated_item (item, converter, 0, 0, GT_MINIMAL);
995 } 976 }
996 977
997 if (CONV_NR (converter)) 978 if (give)
998 item->nrof = CONV_NR (converter); 979 item->nrof = give;
980
999 if (nr) 981 if (nr)
1000 item->nrof *= nr; 982 item->nrof *= nr;
1001 if (is_in_shop (converter)) 983
984 if (converter->flag [FLAG_PRECIOUS])
1002 SET_FLAG (item, FLAG_UNPAID); 985 SET_FLAG (item, FLAG_UNPAID);
986
987 if (is_in_shop (converter))
988 {
989 // converters on shop floors don't work anymore, bug lets check for it
990 // and report in case someone still does it.
991 LOG (llevDebug, "ITEMBUG: broken converter, converters on shop floor don't work: %s\n",
992 converter->debug_desc ());
993 SET_FLAG (item, FLAG_UNPAID);
994 }
1003 else if (price_in < item->nrof * item->value) 995 else if (price_in < sint64 (item->nrof) * item->value)
1004 { 996 {
1005 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n", 997 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n",
1006 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name); 998 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name);
1007
1008 /** 999 /**
1009 * elmex: we are going to let the game continue, as the mapcreator 1000 * elmex: we are going to let the game continue, as the mapcreator
1010 * probably had something in mind when doing this 1001 * hopefully had something in mind when doing this.
1011 */ 1002 */
1012 } 1003 }
1004
1005 // elmex: only identify if we need to, for example so that generated money doesn't
1006 // get an 'identified' flag so easily.
1007 if (need_identify (item))
1008 identify (item);
1009
1013 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y); 1010 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y);
1014 return 1; 1011 return 1;
1015} 1012}
1016 1013
1017/** 1014/**
… …
1034 1031
1035 op->contr->last_used = 0; 1032 op->contr->last_used = 0;
1036 1033
1037 if (sack->env && sack->env != op) 1034 if (sack->env && sack->env != op)
1038 { 1035 {
1039 new_draw_info (NDI_UNIQUE, 0, op, "You must put it onto the floor or into your inventory first."); 1036 op->failmsg ("You must put it onto the floor or into your inventory first.");
1040 return 1; 1037 return 1;
1041 } 1038 }
1042 1039
1043 // already applied == open on ground, or open in inv, or active in inv 1040 // already applied == open on ground, or open in inv, or active in inv
1044 if (sack->flag [FLAG_APPLIED]) 1041 if (sack->flag [FLAG_APPLIED])
… …
1050 return 1; 1047 return 1;
1051 } 1048 }
1052 else if (!sack->env) 1049 else if (!sack->env)
1053 { 1050 {
1054 // active, but not ours: some other player has opened it 1051 // active, but not ours: some other player has opened it
1055 new_draw_info_format (NDI_UNIQUE, 0, op, "%s is already occupied.", query_name (sack)); 1052 op->failmsg (format ("Somebody else is using the %s already.", query_name (sack)));
1056 return 1; 1053 return 1;
1057 } 1054 }
1058 1055
1059 // fall through to opening it (active in inv) 1056 // fall through to opening it (active in inv)
1060 } 1057 }
… …
1062 { 1059 {
1063 // it is in our env, so activate it, do not open yet 1060 // it is in our env, so activate it, do not open yet
1064 op->close_container (); 1061 op->close_container ();
1065 sack->flag [FLAG_APPLIED] = 1; 1062 sack->flag [FLAG_APPLIED] = 1;
1066 esrv_update_item (UPD_FLAGS, op, sack); 1063 esrv_update_item (UPD_FLAGS, op, sack);
1067 new_draw_info_format (NDI_UNIQUE, 0, op, "You ready %s.", query_name (sack)); 1064 op->statusmsg (format ("You ready %s.", query_name (sack)));
1068 return 1; 1065 return 1;
1069 } 1066 }
1070 1067
1071 // it's locked? 1068 // it's locked?
1072 if (sack->slaying) 1069 if (sack->slaying)
1073 { 1070 {
1074 if (object *tmp = find_key (op, op, sack)) 1071 if (object *tmp = find_key (op, op, sack))
1075 new_draw_info_format (NDI_UNIQUE, 0, op, "You unlock %s with %s.", query_name (sack), query_name (tmp)); 1072 op->statusmsg (format ("You unlock %s with %s.", query_name (sack), query_name (tmp)));
1076 else 1073 else
1077 { 1074 {
1078 new_draw_info_format (NDI_UNIQUE, 0, op, "You don't have the key to unlock %s.", query_name (sack)); 1075 op->statusmsg (format ("You don't have the key to unlock %s.", query_name (sack)));
1079 return 1; 1076 return 1;
1080 } 1077 }
1081 } 1078 }
1082 1079
1083 op->open_container (sack); 1080 op->open_container (sack);
… …
1102 * with an altar. We call it a Potion - altars are stationary - it 1099 * with an altar. We call it a Potion - altars are stationary - it
1103 * is up to map designers to use them properly. 1100 * is up to map designers to use them properly.
1104 */ 1101 */
1105 if (altar->inv && altar->inv->type == SPELL) 1102 if (altar->inv && altar->inv->type == SPELL)
1106 { 1103 {
1107 new_draw_info_format (NDI_BLACK, 0, originator, "The altar casts %s.", &altar->inv->name); 1104 originator->statusmsg (format ("The altar casts %s.", &altar->inv->name));
1108 cast_spell (originator, altar, 0, altar->inv, NULL); 1105 cast_spell (originator, altar, 0, altar->inv, NULL);
1109 /* If it is connected, push the button. Fixes some problems with 1106 /* If it is connected, push the button. Fixes some problems with
1110 * old maps. 1107 * old maps.
1111 */ 1108 */
1112 1109
1113/* push_button (altar);*/ 1110/* push_button (altar);*/
1114 } 1111 }
1115 else 1112 else
1116 { 1113 {
1117 altar->value = 1; /* works only once */ 1114 altar->value = 1; /* works only once */
1118 push_button (altar); 1115 push_button (altar, originator);
1119 } 1116 }
1120 1117
1121 return !sacrifice; 1118 return !sacrifice;
1122 } 1119 }
1123 else 1120 else
… …
1138 double opinion; 1135 double opinion;
1139 object *tmp, *next; 1136 object *tmp, *next;
1140 1137
1141 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */ 1138 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */
1142 1139
1143 if (op->type != PLAYER) 1140 bool has_unpaid = false;
1141
1142 // quite inefficient to do this here twice, but the api doesn'T lend itself to
1143 // a quick and small change :(
1144 for (object::depth_iterator item = op->begin (); item != op->end (); ++item)
1145 if (item->flag [FLAG_UNPAID])
1146 {
1147 has_unpaid = true;
1148 break;
1149 }
1150
1151 if (!op->is_player ())
1144 { 1152 {
1145 /* Remove all the unpaid objects that may be carried here. 1153 /* Remove all the unpaid objects that may be carried here.
1146 * This could be pets or monsters that are somehow in 1154 * This could be pets or monsters that are somehow in
1147 * the shop. 1155 * the shop.
1148 */ 1156 */
… …
1152 1160
1153 if (QUERY_FLAG (tmp, FLAG_UNPAID)) 1161 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1154 { 1162 {
1155 int i = find_free_spot (tmp, op->map, op->x, op->y, 1, 9); 1163 int i = find_free_spot (tmp, op->map, op->x, op->y, 1, 9);
1156 1164
1165 if (i >= 0)
1157 tmp->remove (); 1166 tmp->move (i);
1158
1159 if (i == -1)
1160 i = 0;
1161
1162 tmp->map = op->map;
1163 tmp->x = op->x + freearr_x[i];
1164 tmp->y = op->y + freearr_y[i];
1165 insert_ob_in_map (tmp, op->map, op, 0);
1166 } 1167 }
1167 } 1168 }
1168 1169
1169 /* Don't teleport things like spell effects */ 1170 /* Don't teleport things like spell effects */
1170 if (QUERY_FLAG (op, FLAG_NO_PICK)) 1171 if (QUERY_FLAG (op, FLAG_NO_PICK))
… …
1173 /* unpaid objects, or non living objects, can't transfer by 1174 /* unpaid objects, or non living objects, can't transfer by
1174 * shop mats. Instead, put it on a nearby space. 1175 * shop mats. Instead, put it on a nearby space.
1175 */ 1176 */
1176 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE)) 1177 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE))
1177 { 1178 {
1178
1179 /* Somebody dropped an unpaid item, just move to an adjacent place. */ 1179 /* Somebody dropped an unpaid item, just move to an adjacent place. */
1180 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1180 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1181 1181
1182 if (i != -1) 1182 if (i != -1)
1183 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat); 1183 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat);
1184 1184
1185 return 0; 1185 return 0;
1186 } 1186 }
1187
1187 /* Removed code that checked for multipart objects - it appears that 1188 /* Removed code that checked for multipart objects - it appears that
1188 * the teleport function should be able to handle this just fine. 1189 * the teleport function should be able to handle this just fine.
1189 */ 1190 */
1190 rv = teleport (shop_mat, SHOP_MAT, op); 1191 rv = teleport (shop_mat, SHOP_MAT, op);
1191 } 1192 }
1192 else if (can_pay (op) && get_payment (op)) 1193 else if (can_pay (op) && get_payment (op))
1193 { 1194 {
1194 /* this is only used for players */ 1195 /* this is only used for players */
1195 rv = teleport (shop_mat, SHOP_MAT, op); 1196 rv = teleport (shop_mat, SHOP_MAT, op);
1196 1197
1198 if (has_unpaid)
1199 op->contr->play_sound (sound_find ("shop_buy"));
1200 else if (is_in_shop (op))
1201 op->contr->play_sound (sound_find ("shop_enter"));
1202 else
1203 op->contr->play_sound (sound_find ("shop_leave"));
1204
1197 if (shop_mat->msg) 1205 if (shop_mat->msg)
1198 new_draw_info (NDI_UNIQUE, 0, op, shop_mat->msg); 1206 op->statusmsg (shop_mat->msg);
1199 /* This check below is a bit simplistic - generally it should be correct, 1207 /* This check below is a bit simplistic - generally it should be correct,
1200 * but there is never a guarantee that the bottom space on the map is 1208 * but there is never a guarantee that the bottom space on the map is
1201 * actually the shop floor. 1209 * actually the shop floor.
1202 */ 1210 */
1203 else if (!rv && !is_in_shop (op)) 1211 else if (!rv && !is_in_shop (op))
1204 { 1212 {
1205 opinion = shopkeeper_approval (op->map, op); 1213 opinion = shopkeeper_approval (op->map, op);
1206 1214
1207 if (opinion > 0.9) 1215 op->statusmsg (
1208 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper gives you a friendly wave."); 1216 opinion >= 0.90 ? "The shopkeeper gives you a friendly wave."
1209 else if (opinion > 0.75) 1217 : opinion >= 0.75 ? "The shopkeeper waves to you."
1210 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper waves to you."); 1218 : opinion >= 0.50 ? "The shopkeeper ignores you."
1211 else if (opinion > 0.5) 1219 : "The shopkeeper glares at you with contempt."
1212 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper ignores you.");
1213 else 1220 );
1214 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper glares at you with contempt.");
1215 } 1221 }
1216 } 1222 }
1217 else 1223 else
1218 { 1224 {
1219 /* if we get here, a player tried to leave a shop but was not able 1225 /* if we get here, a player tried to leave a shop but was not able
1220 * to afford the items he has. We try to move the player so that 1226 * to afford the items he has. We try to move the player so that
1221 * they are not on the mat anymore 1227 * they are not on the mat anymore
1222 */ 1228 */
1223 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1229 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1224 1230
1225 if (i == -1) 1231 if (i == -1)
1226 {
1227 LOG (llevError, "Internal shop-mat problem.\n"); 1232 LOG (llevError, "Internal shop-mat problem.\n");
1228 }
1229 else 1233 else
1230 { 1234 {
1231 op->remove (); 1235 op->remove ();
1232 op->x += freearr_x[i]; 1236 op->x += freearr_x[i];
1233 op->y += freearr_y[i]; 1237 op->y += freearr_y[i];
… …
1243 * Handles applying a sign. 1247 * Handles applying a sign.
1244 */ 1248 */
1245static void 1249static void
1246apply_sign (object *op, object *sign, int autoapply) 1250apply_sign (object *op, object *sign, int autoapply)
1247{ 1251{
1248 readable_message_type *msgType; 1252 if (!op->is_player())
1253 return;
1249 1254
1250 if (sign->msg == NULL) 1255 if (sign->has_dialogue ())
1251 { 1256 {
1252 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it."); 1257 op->statusmsg (format ("Maybe you should I<talk> to the %s instead?", &sign->name));
1253 return; 1258 return;
1254 } 1259 }
1255 1260
1261 if (!sign->msg)
1262 {
1263 op->contr->infobox (MSG_CHANNEL ("examine"),
1264 format ("T<%s>\n\n Nothing %sis written on it.",
1265 &sign->name,
1266 sign->name == sign->arch->name ? "" : "else "));
1267 return;
1268 }
1269
1256 if (sign->stats.food) 1270 if (sign->stats.food)
1257 { 1271 {
1258 if (sign->last_eat >= sign->stats.food) 1272 if (sign->last_eat >= sign->stats.food)
1259 { 1273 {
1260 if (!sign->move_on) 1274 if (!sign->move_on)
1261 new_draw_info (NDI_UNIQUE, 0, op, "You cannot read it anymore."); 1275 op->failmsg ("You cannot read it anymore.");
1276
1262 return; 1277 return;
1263 } 1278 }
1264 1279
1265 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1280 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1266 sign->last_eat++; 1281 sign->last_eat++;
… …
1271 * move_on is zero, it needs to be manually applied (doesn't talk 1286 * move_on is zero, it needs to be manually applied (doesn't talk
1272 * to us). 1287 * to us).
1273 */ 1288 */
1274 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on) 1289 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on)
1275 { 1290 {
1276 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1291 op->failmsg ("You are unable to read while blind!");
1277 return; 1292 return;
1278 } 1293 }
1279 1294
1280 if (op->contr) 1295 if (op->contr)
1281 if (client *ns = op->contr->ns) 1296 if (client *ns = op->contr->ns)
1282 { 1297 {
1283 msgType = get_readable_message_type (sign); 1298 if (sign->sound)
1299 ns->play_sound (sign->sound);
1300 else if (autoapply)
1301 ns->play_sound (sound_find ("msg_voice"));
1284 1302
1285 if (ns->can_msg) 1303 op->contr->infobox (MSG_CHANNEL ("examine"), format ("T<%s>\n\n%s", &sign->name, &sign->msg));
1286 ns->send_msg (NDI_NAVY, msgType->msgtype, &sign->msg);
1287 else
1288 {
1289 char newbuf[HUGE_BUF];
1290 snprintf (newbuf, sizeof (newbuf), "%u %s", autoapply ? 1 : 0, &sign->msg);
1291 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg);
1292 }
1293 } 1304 }
1305}
1306
1307static void
1308move_apply_hole (object *trap, object *victim)
1309{
1310 /* Hole not open? */
1311 if (trap->stats.wc > 0)
1312 return;
1313
1314 /* Is this a multipart monster and not the head? If so, return.
1315 * Processing will happen if the head runs into the pit
1316 */
1317 if (victim->head)
1318 return;
1319
1320 // now find all possible locations and randomly pick one
1321 int dir = find_free_spot (victim, trap->map, EXIT_X (trap), EXIT_Y (trap), 0,
1322 trap->range >= 3 ? SIZEOFFREE3 + 1
1323 : trap->range >= 2 ? SIZEOFFREE2 + 1
1324 : trap->range >= 1 ? SIZEOFFREE1 + 1
1325 : SIZEOFFREE0 + 1);
1326
1327 if (dir < 0)
1328 return;
1329
1330 victim->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1331 victim->statusmsg ("You fall through the hole!", NDI_RED);
1332
1333 transfer_ob (victim,
1334 EXIT_X (trap) + freearr_x[dir],
1335 EXIT_Y (trap) + freearr_y[dir],
1336 0, victim);
1294} 1337}
1295 1338
1296/** 1339/**
1297 * 'victim' moves onto 'trap' 1340 * 'victim' moves onto 'trap'
1298 * 'victim' leaves 'trap' 1341 * 'victim' leaves 'trap'
… …
1373 } 1416 }
1374 goto leave; 1417 goto leave;
1375 1418
1376 case BUTTON: 1419 case BUTTON:
1377 case PEDESTAL: 1420 case PEDESTAL:
1378 update_button (trap); 1421 update_button (trap, originator);
1379 goto leave; 1422 goto leave;
1380 1423
1381 case ALTAR: 1424 case ALTAR:
1382 /* sacrifice victim on trap */ 1425 /* sacrifice victim on trap */
1383 apply_altar (trap, victim, originator); 1426 apply_altar (trap, victim, originator);
… …
1410 1453
1411 if (!trap->value) 1454 if (!trap->value)
1412 { 1455 {
1413 int tot; 1456 int tot;
1414 1457
1415 for (ab = trap->above, tot = 0; ab != NULL; ab = ab->above) 1458 for (ab = trap->above, tot = 0; ab; ab = ab->above)
1416 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1459 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1417 tot += (ab->nrof ? ab->nrof : 1) * ab->weight + ab->carrying; 1460 tot += ab->head_ ()->total_weight ();
1418 1461
1419 if (!(trap->value = (tot > trap->weight) ? 1 : 0)) 1462 if (!(trap->value = (tot > trap->weight) ? 1 : 0))
1420 goto leave; 1463 goto leave;
1421 1464
1422 SET_ANIMATION (trap, trap->value); 1465 SET_ANIMATION (trap, trap->value);
… …
1432 1475
1433 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1476 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1434 { 1477 {
1435 if (!sound_was_played) 1478 if (!sound_was_played)
1436 { 1479 {
1437 play_sound_map (trap->map, trap->x, trap->y, SOUND_FALL_HOLE); 1480 trap->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1438 sound_was_played = 1; 1481 sound_was_played = 1;
1439 } 1482 }
1440 new_draw_info (NDI_UNIQUE, 0, ab, "You fall into a trapdoor!"); 1483
1484 ab->statusmsg ("You fall into a trapdoor!", NDI_RED);
1441 transfer_ob (ab, (int) EXIT_X (trap), (int) EXIT_Y (trap), 0, ab); 1485 transfer_ob (ab, EXIT_X (trap), EXIT_Y (trap), 0, ab);
1442 } 1486 }
1443 } 1487 }
1444 goto leave; 1488 goto leave;
1445 } 1489 }
1446 1490
1447
1448 case CONVERTER: 1491 case CONVERTER:
1449 if (convert_item (victim, trap) < 0) 1492 if (convert_item (victim, trap) < 0)
1450 { 1493 {
1451 new_draw_info_format (NDI_UNIQUE, 0, originator, "The %s seems to be broken!", query_name (trap)); 1494 originator->failmsg (format ("The %s seems to be broken!", query_name (trap)));
1452 get_archetype ("burnout")->insert_at (trap, trap); 1495 archetype::get (shstr_burnout)->insert_at (trap, trap);
1453 } 1496 }
1454 1497
1455 goto leave; 1498 goto leave;
1456 1499
1457 case TRIGGER_BUTTON: 1500 case TRIGGER_BUTTON:
… …
1467 case CHECK_INV: 1510 case CHECK_INV:
1468 check_inv (victim, trap); 1511 check_inv (victim, trap);
1469 goto leave; 1512 goto leave;
1470 1513
1471 case HOLE: 1514 case HOLE:
1472 /* Hole not open? */ 1515 move_apply_hole (trap, victim);
1473 if (trap->stats.wc > 0)
1474 goto leave;
1475
1476 /* Is this a multipart monster and not the head? If so, return.
1477 * Processing will happen if the head runs into the pit
1478 */
1479 if (victim->head)
1480 goto leave;
1481
1482 play_sound_map (victim->map, victim->x, victim->y, SOUND_FALL_HOLE);
1483 new_draw_info (NDI_UNIQUE, 0, victim, "You fall through the hole!\n");
1484 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim);
1485 goto leave; 1516 goto leave;
1486 1517
1487 case EXIT: 1518 case EXIT:
1488 if (victim->type == PLAYER && EXIT_PATH (trap)) 1519 if (victim->type == PLAYER && EXIT_PATH (trap))
1489 { 1520 {
1490 /* Basically, don't show exits leading to random maps the 1521 /* Basically, don't show exits leading to random maps the
1491 * players output. 1522 * players output.
1492 */ 1523 */
1493 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2)) 1524 if (trap->msg && !EXIT_PATH (trap).starts_with ("/!"))
1494 new_draw_info (NDI_NAVY, 0, victim, trap->msg); 1525 victim->statusmsg (trap->msg, NDI_NAVY);
1495 1526
1527 trap->play_sound (trap->sound);
1496 victim->enter_exit (trap); 1528 victim->enter_exit (trap);
1497 } 1529 }
1498 goto leave; 1530 goto leave;
1499 1531
1500 case ENCOUNTER: 1532 case ENCOUNTER:
… …
1522 goto leave; 1554 goto leave;
1523 1555
1524 case RUNE: 1556 case RUNE:
1525 case TRAP: 1557 case TRAP:
1526 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE)) 1558 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE))
1527 {
1528 spring_trap (trap, victim); 1559 spring_trap (trap, victim);
1529 }
1530 goto leave; 1560 goto leave;
1531 1561
1532 default: 1562 default:
1533 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not " 1563 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not "
1534 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type); 1564 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type);
… …
1548 int lev_diff; 1578 int lev_diff;
1549 object *skill_ob; 1579 object *skill_ob;
1550 1580
1551 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1581 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1552 { 1582 {
1553 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1583 op->failmsg ("You are unable to read while blind!");
1554 return; 1584 return;
1555 } 1585 }
1556 1586
1557 if (!tmp->msg) 1587 if (!tmp->msg)
1558 { 1588 {
1559 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name); 1589 op->failmsg (format ("You open the %s and find it empty.", &tmp->name));
1560 return; 1590 return;
1561 } 1591 }
1562 1592
1563 /* need a literacy skill to read stuff! */ 1593 /* need a literacy skill to read stuff! */
1564 skill_ob = find_skill_by_name (op, tmp->skill); 1594 skill_ob = find_skill_by_name (op, tmp->skill);
1565 if (!skill_ob) 1595 if (!skill_ob)
1566 { 1596 {
1567 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1597 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill to read this.>", &tmp->skill));
1568 return; 1598 return;
1569 } 1599 }
1570 1600
1571 lev_diff = tmp->level - (skill_ob->level + 5); 1601 lev_diff = tmp->level - (skill_ob->level + 5);
1572 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0) 1602 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0)
1573 { 1603 {
1574 if (lev_diff < 2) 1604 op->failmsg (lev_diff < 2 ? "This book is just barely beyond your comprehension."
1575 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension."); 1605 : lev_diff < 3 ? "This book is slightly beyond your comprehension."
1576 else if (lev_diff < 3) 1606 : lev_diff < 5 ? "This book is beyond your comprehension."
1577 new_draw_info (NDI_UNIQUE, 0, op, "This book is slightly beyond your comprehension."); 1607 : lev_diff < 8 ? "This book is quite a bit beyond your comprehension."
1578 else if (lev_diff < 5) 1608 : lev_diff < 15 ? "This book is way beyond your comprehension."
1579 new_draw_info (NDI_UNIQUE, 0, op, "This book is beyond your comprehension."); 1609 : "This book is totally beyond your comprehension.");
1580 else if (lev_diff < 8)
1581 new_draw_info (NDI_UNIQUE, 0, op, "This book is quite a bit beyond your comprehension.");
1582 else if (lev_diff < 15)
1583 new_draw_info (NDI_UNIQUE, 0, op, "This book is way beyond your comprehension.");
1584 else
1585 new_draw_info (NDI_UNIQUE, 0, op, "This book is totally beyond your comprehension.");
1586 return; 1610 return;
1587 } 1611 }
1588 1612
1589 readable_message_type *msgType = get_readable_message_type (tmp); 1613 readable_message_type *msgType = get_readable_message_type (tmp);
1590 1614
1591 if (player *pl = op->contr) 1615 if (player *pl = op->contr)
1592 if (client *ns = pl->ns) 1616 if (client *ns = pl->ns)
1593 if (ns->can_msg) 1617 pl->infobox (MSG_CHANNEL ("book"), format ("T<%s>\n\n%s", (char *)long_desc (tmp, op), &tmp->msg));
1594 {
1595 dynbuf_text buf;
1596 buf << long_desc (tmp, op)
1597 << "\n\n"
1598 << tmp->msg
1599 << '\0';
1600 ns->send_msg (NDI_NAVY, msgType->msgtype, buf.linearise ());
1601 }
1602 else
1603 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op,
1604 msgType->message_type, msgType->message_subtype,
1605 "You open the %s and start reading.\n%s", (char *)"%s\n%s",
1606 long_desc (tmp, op), &tmp->msg);
1607 1618
1608 /* gain xp from reading */ 1619 /* gain xp from reading */
1609 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT)) 1620 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT))
1610 { /* only if not read before */ 1621 { /* only if not read before */
1611 int exp_gain = calc_skill_exp (op, tmp, skill_ob); 1622 int exp_gain = calc_skill_exp (op, tmp, skill_ob);
… …
1613 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1624 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1614 { 1625 {
1615 /*exp_gain *= 2; because they just identified it too */ 1626 /*exp_gain *= 2; because they just identified it too */
1616 SET_FLAG (tmp, FLAG_IDENTIFIED); 1627 SET_FLAG (tmp, FLAG_IDENTIFIED);
1617 1628
1618 /* If in a container, update how it looks */ 1629 if (object *pl = tmp->visible_to ())
1619 if (tmp->env)
1620 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp); 1630 esrv_update_item (UPD_FLAGS | UPD_NAME, pl, tmp);
1621 else
1622 op->contr->ns->floorbox_update ();
1623 } 1631 }
1624 1632
1625 change_exp (op, exp_gain, skill_ob->skill, 0); 1633 change_exp (op, exp_gain, skill_ob->skill, 0);
1626 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */ 1634 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */
1627 } 1635 }
… …
1632 * op is the person learning the skill, tmp is the skill scroll object 1640 * op is the person learning the skill, tmp is the skill scroll object
1633 */ 1641 */
1634static void 1642static void
1635apply_skillscroll (object *op, object *tmp) 1643apply_skillscroll (object *op, object *tmp)
1636{ 1644{
1637 switch ((int) learn_skill (op, tmp)) 1645 switch (learn_skill (op, tmp))
1638 { 1646 {
1639 case 0: 1647 case 0:
1640 new_draw_info (NDI_UNIQUE, 0, op, "You already possess the knowledge "); 1648 op->play_sound (sound_find ("generic_fail"));
1641 new_draw_info_format (NDI_UNIQUE, 0, op, "held within the %s.\n", query_name (tmp)); 1649 op->failmsg (format ("You already possess the knowledge held within the %s.", query_name (tmp)));
1642 return; 1650 break;
1643 1651
1644 case 1: 1652 case 1:
1645 new_draw_info_format (NDI_UNIQUE, 0, op, "You succeed in learning %s", &tmp->skill);
1646 decrease_ob (tmp); 1653 tmp->decrease ();
1654 op->play_sound (sound_find ("skill_learn"));
1655 op->statusmsg (format ("You succeed in learning %s", &tmp->skill));
1647 return; 1656 break;
1648 1657
1649 default: 1658 default:
1659 tmp->decrease ();
1660 op->play_sound (sound_find ("generic_fail"));
1650 new_draw_info_format (NDI_UNIQUE, 0, op, "You fail to learn the knowledge of the %s.\n", query_name (tmp)); 1661 op->failmsg (format ("You fail to learn the knowledge of the %s.\n", query_name (tmp)));
1651 decrease_ob (tmp);
1652 return; 1662 break;
1653 } 1663 }
1654} 1664}
1655 1665
1656/** 1666/**
1657 * Actually makes op learn spell. 1667 * Actually makes op learn spell.
… …
1677 return; 1687 return;
1678 } 1688 }
1679 return; 1689 return;
1680 } 1690 }
1681 1691
1682 play_sound_player_only (op->contr, SOUND_LEARN_SPELL, 0, 0); 1692 op->contr->play_sound (sound_find ("learn_spell"));
1693
1683 tmp = spell->clone (); 1694 tmp = spell->clone ();
1684 insert_ob_in_ob (tmp, op); 1695 insert_ob_in_ob (tmp, op);
1685 1696
1686 if (special_prayer) 1697 if (special_prayer)
1687 SET_FLAG (tmp, FLAG_STARTEQUIP); 1698 SET_FLAG (tmp, FLAG_STARTEQUIP);
… …
1706 { 1717 {
1707 LOG (llevError, "BUG: do_forget_spell(): spell not known\n"); 1718 LOG (llevError, "BUG: do_forget_spell(): spell not known\n");
1708 return; 1719 return;
1709 } 1720 }
1710 1721
1711 new_draw_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, "You lose knowledge of %s.", spell); 1722 op->failmsg (format ("You lose knowledge of %s.", spell));
1712 player_unready_range_ob (op->contr, spob); 1723 player_unready_range_ob (op->contr, spob);
1713 esrv_remove_spell (op->contr, spob); 1724 esrv_remove_spell (op->contr, spob);
1714 spob->destroy (); 1725 spob->destroy ();
1715} 1726}
1716 1727
… …
1724{ 1735{
1725 object *skop, *spell, *spell_skill; 1736 object *skop, *spell, *spell_skill;
1726 1737
1727 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1738 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1728 { 1739 {
1729 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1740 op->failmsg ("You are unable to read while blind.");
1730 return; 1741 return;
1731 } 1742 }
1732 1743
1733 /* artifact_spellbooks have 'slaying' field point to a spell name, 1744 /* artifact_spellbooks have 'slaying' field point to a spell name,
1734 * instead of having their spell stored in stats.sp. These are 1745 * instead of having their spell stored in stats.sp. These are
1735 * legacy spellbooks 1746 * legacy spellbooks
1736 */ 1747 */
1737
1738 if (tmp->slaying != NULL) 1748 if (tmp->slaying)
1739 { 1749 {
1740 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying)); 1750 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying));
1741 if (!spell) 1751 if (!spell)
1742 { 1752 {
1743 new_draw_info_format (NDI_UNIQUE, 0, op, "The book's formula for %s is incomplete", &tmp->slaying); 1753 op->failmsg (format ("The book's formula for %s is incomplete.", &tmp->slaying));
1744 return; 1754 return;
1745 } 1755 }
1746 else 1756 else
1747 insert_ob_in_ob (spell, tmp); 1757 insert_ob_in_ob (spell, tmp);
1758
1748 tmp->slaying = NULL; 1759 tmp->slaying = 0;
1749 } 1760 }
1750 1761
1751 skop = find_skill_by_name (op, tmp->skill); 1762 skop = find_skill_by_name (op, tmp->skill);
1752 1763
1753 /* need a literacy skill to learn spells. Also, having a literacy level 1764 /* need a literacy skill to learn spells. Also, having a literacy level
1754 * lower than the spell will make learning the spell more difficult */ 1765 * lower than the spell will make learning the spell more difficult */
1755 if (!skop) 1766 if (!skop)
1756 { 1767 {
1757 new_draw_info (NDI_UNIQUE, 0, op, "You can't read! Your attempt fails."); 1768 op->failmsg (format ("You can't read! Your attempt fails. H<You lack the %s skill.>", &tmp->skill));
1758 return; 1769 return;
1759 } 1770 }
1760 1771
1761 spell = tmp->inv; 1772 spell = tmp->inv;
1762 1773
1763 if (!spell) 1774 if (!spell)
1764 { 1775 {
1765 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name); 1776 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name);
1766 new_draw_info (NDI_UNIQUE, 0, op, "The spellbook symbols make no sense."); 1777 op->failmsg ("The spellbook symbols make no sense. This is a bug, please report!");
1767 return; 1778 return;
1768 } 1779 }
1769 1780
1770 if (skop->level < int (sqrtf (spell->level) * 1.5f)) 1781 if (skop->level < int (sqrtf (spell->level) * 1.5f))
1771 { 1782 {
1772 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols. [Your literacy level is too low]"); 1783 op->failmsg (format ("You are unable to decipher the strange symbols. H<Your %s level is too low.>", &tmp->skill));
1773 return; 1784 return;
1774 } 1785 }
1775 1786
1776 new_draw_info_format (NDI_UNIQUE, 0, op, "The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name); 1787 op->statusmsg (format ("The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name));
1777 1788
1778 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1789 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1779 {
1780 identify (tmp); 1790 identify (tmp);
1781
1782 if (tmp->env)
1783 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp);
1784 else
1785 op->contr->ns->floorbox_update ();
1786 }
1787 1791
1788 /* I removed the check for special_prayer_mark here - it didn't make 1792 /* I removed the check for special_prayer_mark here - it didn't make
1789 * a lot of sense - special prayers are not found in spellbooks, and 1793 * a lot of sense - special prayers are not found in spellbooks, and
1790 * if the player doesn't know the spell, doesn't make a lot of sense that 1794 * if the player doesn't know the spell, doesn't make a lot of sense that
1791 * they would have a special prayer mark. 1795 * they would have a special prayer mark.
1792 */ 1796 */
1793 if (check_spell_known (op, spell->name)) 1797 if (check_spell_known (op, spell->name))
1794 { 1798 {
1795 new_draw_info (NDI_UNIQUE, 0, op, "You already know that spell.\n"); 1799 op->statusmsg ("You already know that spell. H<It makes no sense to learn spells twice, and would only waste the spellbook.>\n");
1796 return; 1800 return;
1797 } 1801 }
1798 1802
1799 if (spell->skill) 1803 if (spell->skill)
1800 { 1804 {
1801 spell_skill = find_skill_by_name (op, spell->skill); 1805 spell_skill = find_skill_by_name (op, spell->skill);
1802 1806
1803 if (!spell_skill) 1807 if (!spell_skill)
1804 { 1808 {
1805 new_draw_info_format (NDI_UNIQUE, 0, op, "You lack the skill %s to use this spell.", &spell->skill); 1809 op->failmsg (format ("You lack the skill %s to use this spell.", &spell->skill));
1806 return; 1810 return;
1807 } 1811 }
1808 1812
1809 if (spell_skill->level < spell->level) 1813 if (spell_skill->level < spell->level)
1810 { 1814 {
1811 new_draw_info_format (NDI_UNIQUE, 0, op, "You need to be level %d in %s to learn this spell.", spell->level, &spell->skill); 1815 op->failmsg (format ("You need to be level %d in %s to learn this spell.", spell->level, &spell->skill));
1812 return; 1816 return;
1813 } 1817 }
1814 } 1818 }
1815 1819
1816 /* Logic as follows 1820 /* Logic as follows
… …
1825 * Overall, chances are the same but a player will find having a high 1829 * Overall, chances are the same but a player will find having a high
1826 * literacy rate very useful! -b.t. 1830 * literacy rate very useful! -b.t.
1827 */ 1831 */
1828 if (QUERY_FLAG (op, FLAG_CONFUSED)) 1832 if (QUERY_FLAG (op, FLAG_CONFUSED))
1829 { 1833 {
1830 new_draw_info (NDI_UNIQUE, 0, op, "In your confused state you flub the wording of the text!"); 1834 op->failmsg ("In your confused state you flub the wording of the text!");
1831 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace)); 1835 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace));
1832 } 1836 }
1833 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || 1837 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) ||
1834 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int]) 1838 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int])
1835 { 1839 {
1836 1840 op->statusmsg ("You succeed in learning the spell!", NDI_GREEN);
1837 new_draw_info (NDI_UNIQUE, 0, op, "You succeed in learning the spell!");
1838 do_learn_spell (op, spell, 0); 1841 do_learn_spell (op, spell, 0);
1839 1842
1840 /* xp gain to literacy for spell learning */ 1843 /* xp gain to literacy for spell learning */
1841 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP)) 1844 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP))
1842 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0); 1845 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0);
1843 } 1846 }
1844 else 1847 else
1845 { 1848 {
1846 play_sound_player_only (op->contr, SOUND_FUMBLE_SPELL, 0, 0); 1849 op->contr->play_sound (sound_find ("fumble_spell"));
1847 new_draw_info (NDI_UNIQUE, 0, op, "You fail to learn the spell.\n"); 1850 op->failmsg ("You fail to learn the spell. H<Wis (priests) or Int (wizards) governs the chance of learning a prayer or spell.>\n");
1848 } 1851 }
1849 1852
1850 decrease_ob (tmp); 1853 tmp->decrease ();
1851} 1854}
1852 1855
1853/** 1856/**
1854 * Handles applying a spell scroll. 1857 * Handles applying a spell scroll.
1855 */ 1858 */
… …
1858{ 1861{
1859 object *skop; 1862 object *skop;
1860 1863
1861 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1864 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1862 { 1865 {
1863 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1866 op->failmsg ("You are unable to read while blind.");
1864 return; 1867 return;
1865 } 1868 }
1866 1869
1867 if (!tmp->inv || tmp->inv->type != SPELL) 1870 if (!tmp->inv || tmp->inv->type != SPELL)
1868 { 1871 {
1869 new_draw_info (NDI_UNIQUE, 0, op, "The scroll just doesn't make sense!"); 1872 op->failmsg ("The scroll just doesn't make sense! H<...and never will make sense.>");
1870 return; 1873 return;
1871 } 1874 }
1872 1875
1873 if (op->type == PLAYER) 1876 if (op->type == PLAYER)
1874 { 1877 {
… …
1880 */ 1883 */
1881 skop = find_skill_by_name (op, skill_names[SK_LITERACY]); 1884 skop = find_skill_by_name (op, skill_names[SK_LITERACY]);
1882 1885
1883 if (!skop) 1886 if (!skop)
1884 { 1887 {
1885 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1888 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill.>", &skill_names[SK_LITERACY]));
1886 return; 1889 return;
1887 } 1890 }
1888 1891
1889 if ((exp_gain = calc_skill_exp (op, tmp, skop))) 1892 if ((exp_gain = calc_skill_exp (op, tmp, skop)))
1890 change_exp (op, exp_gain, skop->skill, 0); 1893 change_exp (op, exp_gain, skop->skill, 0);
1891 } 1894 }
1892 1895
1893 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1896 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1894 identify (tmp); 1897 identify (tmp);
1895 1898
1896 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name); 1899 op->statusmsg (format ("The scroll of %s turns to dust.", &tmp->inv->name));
1897 1900
1898 cast_spell (op, tmp, dir, tmp->inv, NULL); 1901 cast_spell (op, tmp, dir, tmp->inv, NULL);
1899 decrease_ob (tmp); 1902 tmp->decrease ();
1900} 1903}
1901 1904
1902/** 1905/**
1903 * Applies a treasure object - by default, chest. op 1906 * Applies a treasure object - by default, chest. op
1904 * is the person doing the applying, tmp is the treasure 1907 * is the person doing the applying, tmp is the treasure
1905 * chest. 1908 * chest.
1906 */ 1909 */
1907static void 1910static void
1908apply_treasure (object *op, object *tmp) 1911apply_treasure (object *op, object *tmp)
1909{ 1912{
1910 /* Nice side effect of new treasure creation method is that the treasure 1913 /* Nice side effect of this treasure creation method is that the treasure
1911 * for the chest is done when the chest is created, and put into the chest 1914 * for the chest is done when the chest is created, and put into the chest
1912 * inventory. So that when the chest burns up, the items still exist. Also 1915 * inventory. So that when the chest burns up, the items still exist. Also
1913 * prevents people fromt moving chests to more difficult maps to get better 1916 * prevents people from moving chests to more difficult maps to get better
1914 * treasure 1917 * treasure
1915 */ 1918 */
1916 object *treas = tmp->inv; 1919 object *treas = tmp->inv;
1917 1920
1918 if (!treas) 1921 if (!treas)
1919 { 1922 {
1920 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty."); 1923 op->statusmsg ("The chest was empty.");
1921 decrease_ob (tmp); 1924 tmp->decrease ();
1922 return; 1925 return;
1923 } 1926 }
1924 1927
1925 while (tmp->inv) 1928 while (tmp->inv)
1926 { 1929 {
1927 treas = tmp->inv; 1930 treas = tmp->inv;
1928
1929 treas->remove (); 1931 treas->remove ();
1930 new_draw_info_format (NDI_UNIQUE, 0, op, "You find %s in the chest.", query_name (treas));
1931 1932
1932 treas->x = op->x; 1933 treas->x = op->x;
1933 treas->y = op->y; 1934 treas->y = op->y;
1934 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR); 1935 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR);
1935 1936
1936 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE)) 1937 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE))
1937 spring_trap (treas, op); 1938 spring_trap (treas, op);
1938 1939
1939 /* If either player or container was destroyed, no need to do 1940 /* If either player or container was destroyed, no need to do
1940 * further processing. I think this should be enclused with 1941 * further processing. I think this should be enclused with
1941 * spring trap above, as I don't think there is otherwise 1942 * spring trap above, as I don't think there is otherwise
1942 * any way for the treasure chest or player to get killed 1943 * any way for the treasure chest or player to get killed.
1943 */ 1944 */
1944 if (op->destroyed () || tmp->destroyed ()) 1945 if (op->destroyed () || tmp->destroyed ())
1945 break; 1946 break;
1946 } 1947 }
1947 1948
1948 if (!tmp->destroyed () && tmp->inv == NULL) 1949 if (!tmp->destroyed () && !tmp->inv)
1949 decrease_ob (tmp); 1950 tmp->decrease (true);
1950
1951} 1951}
1952 1952
1953/** 1953/**
1954 * op eats food. 1954 * op eats food.
1955 * If player, takes care of messages and dragon special food. 1955 * If player, takes care of messages and dragon special food.
… …
1970 { 1970 {
1971 /* usual case - no dragon meal: */ 1971 /* usual case - no dragon meal: */
1972 if (op->stats.food + tmp->stats.food > 999) 1972 if (op->stats.food + tmp->stats.food > 999)
1973 { 1973 {
1974 if (tmp->type == FOOD || tmp->type == FLESH) 1974 if (tmp->type == FOOD || tmp->type == FLESH)
1975 new_draw_info (NDI_UNIQUE, 0, op, "You feel full, but what a waste of food!"); 1975 op->failmsg ("You feel full, but what a waste of food!");
1976 else 1976 else
1977 new_draw_info (NDI_UNIQUE, 0, op, "Most of the drink goes down your face not your throat!"); 1977 op->statusmsg ("Most of the drink goes down your face not your throat!");
1978 } 1978 }
1979
1980 tmp->play_sound (
1981 tmp->sound
1982 ? tmp->sound
1983 : tmp->type == DRINK
1984 ? sound_find ("eat_drink")
1985 : sound_find ("eat_food")
1986 );
1979 1987
1980 if (!QUERY_FLAG (tmp, FLAG_CURSED)) 1988 if (!QUERY_FLAG (tmp, FLAG_CURSED))
1981 { 1989 {
1982 char buf[MAX_BUF]; 1990 const char *buf;
1983 1991
1984 if (!is_dragon_pl (op)) 1992 if (!is_dragon_pl (op))
1985 { 1993 {
1986 /* eating message for normal players */ 1994 /* eating message for normal players */
1987 if (tmp->type == DRINK) 1995 if (tmp->type == DRINK)
1988 sprintf (buf, "Ahhh...that %s tasted good.", &tmp->name); 1996 buf = format ("Ahhh...that %s tasted good.", &tmp->name);
1989 else 1997 else
1990 sprintf (buf, "The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good."); 1998 buf = format ("The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good.");
1991 } 1999 }
1992 else 2000 else
1993 {
1994 /* eating message for dragon players */ 2001 /* eating message for dragon players */
1995 sprintf (buf, "The %s tasted terrible!", &tmp->name); 2002 buf = format ("The %s tasted terrible!", &tmp->name);
1996 }
1997 2003
1998 new_draw_info (NDI_UNIQUE, 0, op, buf); 2004 op->statusmsg (buf);
2005
1999 capacity_remaining = 999 - op->stats.food; 2006 capacity_remaining = 999 - op->stats.food;
2000 op->stats.food += tmp->stats.food; 2007 op->stats.food += tmp->stats.food;
2001 if (capacity_remaining < tmp->stats.food) 2008 if (capacity_remaining < tmp->stats.food)
2002 op->stats.hp += capacity_remaining / 50; 2009 op->stats.hp += capacity_remaining / 50;
2003 else 2010 else
2004 op->stats.hp += tmp->stats.food / 50; 2011 op->stats.hp += tmp->stats.food / 50;
2012
2005 if (op->stats.hp > op->stats.maxhp) 2013 if (op->stats.hp > op->stats.maxhp)
2006 op->stats.hp = op->stats.maxhp; 2014 op->stats.hp = op->stats.maxhp;
2007 if (op->stats.food > 999) 2015 if (op->stats.food > 999)
2008 op->stats.food = 999; 2016 op->stats.food = 999;
2009 } 2017 }
… …
2011 /* special food hack -b.t. */ 2019 /* special food hack -b.t. */
2012 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED)) 2020 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED))
2013 eat_special_food (op, tmp); 2021 eat_special_food (op, tmp);
2014 } 2022 }
2015 } 2023 }
2024
2016 handle_apply_yield (tmp); 2025 handle_apply_yield (tmp);
2017 decrease_ob (tmp); 2026 tmp->decrease ();
2018} 2027}
2019 2028
2020/** 2029/**
2021 * A dragon is eating some flesh. If the flesh contains resistances, 2030 * A dragon is eating some flesh. If the flesh contains resistances,
2022 * there is a chance for the dragon's skin to get improved. 2031 * there is a chance for the dragon's skin to get improved.
… …
2032{ 2041{
2033 object *skin = NULL; /* pointer to dragon skin force */ 2042 object *skin = NULL; /* pointer to dragon skin force */
2034 object *abil = NULL; /* pointer to dragon ability force */ 2043 object *abil = NULL; /* pointer to dragon ability force */
2035 object *tmp = NULL; /* tmp. object */ 2044 object *tmp = NULL; /* tmp. object */
2036 2045
2037 char buf[MAX_BUF]; /* tmp. string buffer */
2038 double chance; /* improvement-chance of one resistance type */ 2046 double chance; /* improvement-chance of one resistance type */
2039 double totalchance = 1; /* total chance of gaining one resistance */ 2047 double totalchance = 1; /* total chance of gaining one resistance */
2040 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */ 2048 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */
2041 double mbonus = 0; /* monster bonus */ 2049 double mbonus = 0; /* monster bonus */
2042 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */ 2050 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */
… …
2064 /* now start by filling stomache and health, according to food-value */ 2072 /* now start by filling stomache and health, according to food-value */
2065 if ((999 - op->stats.food) < meal->stats.food) 2073 if ((999 - op->stats.food) < meal->stats.food)
2066 op->stats.hp += (999 - op->stats.food) / 50; 2074 op->stats.hp += (999 - op->stats.food) / 50;
2067 else 2075 else
2068 op->stats.hp += meal->stats.food / 50; 2076 op->stats.hp += meal->stats.food / 50;
2077
2069 if (op->stats.hp > op->stats.maxhp) 2078 if (op->stats.hp > op->stats.maxhp)
2070 op->stats.hp = op->stats.maxhp; 2079 op->stats.hp = op->stats.maxhp;
2071 2080
2072 op->stats.food = MIN (999, op->stats.food + meal->stats.food); 2081 op->stats.food = MIN (999, op->stats.food + meal->stats.food);
2073 2082
… …
2118 } 2127 }
2119 } 2128 }
2120 2129
2121 /* inverse totalchance as until now we have the failure-chance */ 2130 /* inverse totalchance as until now we have the failure-chance */
2122 totalchance = 100 - totalchance * 100; 2131 totalchance = 100 - totalchance * 100;
2132
2123 /* print message according to totalchance */ 2133 /* print message according to totalchance */
2134 const char *buf;
2124 if (totalchance > 50.) 2135 if (totalchance > 50.)
2125 sprintf (buf, "Hmm! The %s tasted delicious!", &meal->name); 2136 buf = format ("Hmm! The %s tasted delicious!", &meal->name);
2126 else if (totalchance > 10.) 2137 else if (totalchance > 10.)
2127 sprintf (buf, "The %s tasted very good.", &meal->name); 2138 buf = format ("The %s tasted very good.", &meal->name);
2128 else if (totalchance > 1.) 2139 else if (totalchance > 1.)
2129 sprintf (buf, "The %s tasted good.", &meal->name); 2140 buf = format ("The %s tasted good.", &meal->name);
2130 else if (totalchance > 0.1) 2141 else if (totalchance > 0.1)
2131 sprintf (buf, "The %s tasted bland.", &meal->name); 2142 buf = format ("The %s tasted bland.", &meal->name);
2132 else if (totalchance >= 0.01) 2143 else if (totalchance >= 0.01)
2133 sprintf (buf, "The %s had a boring taste.", &meal->name); 2144 buf = format ("The %s had a boring taste.", &meal->name);
2134 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat)) 2145 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat))
2135 sprintf (buf, "The %s tasted strange.", &meal->name); 2146 buf = format ("The %s tasted strange.", &meal->name);
2136 else 2147 else
2137 sprintf (buf, "The %s had no taste.", &meal->name); 2148 buf = format ("The %s had no taste.", &meal->name);
2138 new_draw_info (NDI_UNIQUE, 0, op, buf); 2149
2150 op->statusmsg (buf);
2139 2151
2140 /* now choose a winner if we have any */ 2152 /* now choose a winner if we have any */
2141 i = -1; 2153 i = -1;
2142 if (winners > 0) 2154 if (winners > 0)
2143 i = atnr_winner[RANDOM () % winners]; 2155 i = atnr_winner [rndm (winners)];
2144 2156
2145 if (i >= 0 && i < NROFATTACKS && skin->resist[i] < 95) 2157 if (i >= 0 && i < NROFATTACKS && skin->resist[i] < 95)
2146 { 2158 {
2147 /* resistance increased! */ 2159 /* resistance increased! */
2148 skin->resist[i]++; 2160 skin->resist[i]++;
2149 op->update_stats (); 2161 op->update_stats ();
2150 2162
2151 sprintf (buf, "Your skin is now more resistant to %s!", change_resist_msg[i]); 2163 op->statusmsg (format ("Your skin is now more resistant to %s!", change_resist_msg[i]));
2152 new_draw_info (NDI_UNIQUE | NDI_RED, 0, op, buf);
2153 } 2164 }
2154 2165
2155 /* if this flesh contains a new ability focus, we mark it 2166 /* if this flesh contains a new ability focus, we mark it
2156 into the ability_force and it will take effect on next level */ 2167 into the ability_force and it will take effect on next level */
2157 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat) 2168 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat)
2158 { 2169 {
2159 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */ 2170 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */
2160 2171
2161 if (meal->last_eat != abil->stats.exp) 2172 if (meal->last_eat != abil->stats.exp)
2173 op->statusmsg (format (
2174 "Your metabolism prepares to focus on %s!\n"
2175 "The change will happen at level %d.",
2176 change_resist_msg[meal->last_eat],
2177 abil->level + 1
2162 { 2178 ));
2163 sprintf (buf, "Your metabolism prepares to focus on %s!", change_resist_msg[meal->last_eat]);
2164 new_draw_info (NDI_UNIQUE, 0, op, buf);
2165 sprintf (buf, "The change will happen at level %d", abil->level + 1);
2166 new_draw_info (NDI_UNIQUE, 0, op, buf);
2167 }
2168 else 2179 else
2169 { 2180 {
2170 sprintf (buf, "Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]); 2181 op->statusmsg (format ("Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]));
2171 new_draw_info (NDI_UNIQUE, 0, op, buf);
2172 abil->last_eat = 0; 2182 abil->last_eat = 0;
2173 } 2183 }
2174 } 2184 }
2185
2175 return 1; 2186 return 1;
2176} 2187}
2177 2188
2178/** 2189/**
2179 * Handles applying an improve armor scroll. 2190 * Handles applying an improve armor scroll.
… …
2182static void 2193static void
2183apply_armour_improver (object *op, object *tmp) 2194apply_armour_improver (object *op, object *tmp)
2184{ 2195{
2185 object *armor; 2196 object *armor;
2186 2197
2187 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 2198 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_NO_MAGIC))
2188 { 2199 {
2189 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 2200 op->failmsg ("Something blocks the magic of the scroll. H<This area prevents magic effects.>");
2190 return; 2201 return;
2191 } 2202 }
2192 2203
2193 armor = find_marked_object (op); 2204 armor = find_marked_object (op);
2194 2205
2195 if (!armor) 2206 if (!armor)
2196 { 2207 {
2197 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark an armor object."); 2208 op->failmsg ("You need to mark an armor object. Use the right mouse button popup or the mark command to do this.");
2198 return; 2209 return;
2199 } 2210 }
2200 2211
2201 if (armor->type != ARMOUR 2212 if (armor->type != ARMOUR
2202 && armor->type != CLOAK 2213 && armor->type != CLOAK
2203 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET) 2214 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET)
2204 { 2215 {
2205 new_draw_info (NDI_UNIQUE, 0, op, "Your marked item is not armour!\n"); 2216 op->failmsg ("Your marked item is not armour!\n");
2206 return; 2217 return;
2207 } 2218 }
2208 2219
2209 new_draw_info (NDI_UNIQUE, 0, op, "Applying armour enchantment."); 2220 op->statusmsg ("Applying armour enchantment.");
2210 improve_armour (op, tmp, armor); 2221 improve_armour (op, tmp, armor);
2211} 2222}
2212 2223
2213extern void 2224void
2214apply_poison (object *op, object *tmp) 2225apply_poison (object *op, object *tmp)
2215{ 2226{
2227 // need to do it now when it is still on the map
2228 handle_apply_yield (tmp);
2229
2230 object *poison = tmp->split (1);
2231
2216 if (op->type == PLAYER) 2232 if (op->type == PLAYER)
2217 { 2233 {
2218 play_sound_player_only (op->contr, SOUND_DRINK_POISON, 0, 0); 2234 op->contr->play_sound (sound_find ("drink_poison"));
2219 new_draw_info (NDI_UNIQUE, 0, op, "Yech! That tasted poisonous!"); 2235 op->failmsg ("Yech! That tasted poisonous!");
2220 strcpy (op->contr->killer, "poisonous booze"); 2236 op->contr->killer = poison;
2221 } 2237 }
2238
2222 if (tmp->stats.hp > 0) 2239 if (poison->stats.hp > 0)
2223 { 2240 {
2224 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", tmp->stats.hp); 2241 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", poison->stats.hp);
2225 hit_player (op, tmp->stats.hp, tmp, AT_POISON, 1); 2242 hit_player (op, poison->stats.hp, tmp, AT_POISON, 1);
2226 } 2243 }
2244
2227 op->stats.food -= op->stats.food / 4; 2245 op->stats.food -= op->stats.food / 4;
2228 handle_apply_yield (tmp); 2246 poison->destroy ();
2229 decrease_ob (tmp);
2230} 2247}
2231 2248
2232/** 2249/**
2233 * This function return true if the exit is not a 2 ways one or it is 2 ways, valid exit. 2250 * This function return true if the exit is not a 2 ways one or it is 2 ways, valid exit.
2234 * A valid 2 way exit means: 2251 * A valid 2 way exit means:
… …
2250#if 0 //TODO 2267#if 0 //TODO
2251 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race) 2268 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race)
2252 return 0; /* This is a reset town portal */ 2269 return 0; /* This is a reset town portal */
2253#endif 2270#endif
2254 2271
2272 LOG (llevError | logBacktrace, "sync map load due to %s\n", exit->debug_desc ());
2273
2255 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map); 2274 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map);
2256 2275
2257 if (exitmap) 2276 if (exitmap)
2258 { 2277 {
2259 exitmap->load_sync (); 2278 exitmap->load_sync ();
… …
2313 return 1; 2332 return 1;
2314 } 2333 }
2315 } 2334 }
2316 2335
2317 return 0; 2336 return 0;
2337}
2338
2339/**
2340 * This function will try to apply a lighter and in case no lighter
2341 * is specified it will try to find a lighter in the players inventory,
2342 * and inform him about this requirement.
2343 *
2344 * who - the player
2345 * op - the item we want to light
2346 * ligher - the lighter or 0 if a lighter has yet to be found
2347 */
2348object *auto_apply_lighter (object *who, object *op, object *lighter)
2349{
2350 if (lighter == 0)
2351 {
2352 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2353 {
2354 if (tmp->type == LIGHTER)
2355 {
2356 lighter = tmp;
2357 break;
2358 }
2359 }
2360
2361 if (!lighter)
2362 {
2363 who->failmsg (format (
2364 "You can't light up the %s with your bare hands! "
2365 "H<You need a lighter in your inventory, for example a flint and steel.>",
2366 &op->name));
2367 return 0;
2368 }
2369 }
2370
2371 // last_eat == 0 means the lighter is not being used up!
2372 if (lighter->last_eat && lighter->stats.food)
2373 {
2374 /* lighter gets used up */
2375 lighter = lighter->split ();
2376 lighter->stats.food--;
2377 who->insert (lighter);
2378 }
2379 else if (lighter->last_eat)
2380 {
2381 /* no charges left in lighter */
2382 who->failmsg (format (
2383 "You attempt to light the %s with a used up %s.",
2384 &op->name, &lighter->name));
2385 return 0;
2386 }
2387
2388 return lighter;
2389}
2390
2391/**
2392 * Designed primarily to light torches/lanterns/etc.
2393 * Also burns up burnable material too. First object in the inventory is
2394 * the selected object to "burn". -b.t.
2395 */
2396void
2397apply_lighter (object *who, object *lighter)
2398{
2399 object *item;
2400 int is_player_env = 0;
2401
2402 item = find_marked_object (who);
2403 if (item)
2404 {
2405 if (!auto_apply_lighter (who, 0, lighter))
2406 return;
2407
2408 /* Perhaps we should split what we are trying to light on fire?
2409 * I can't see many times when you would want to light multiple
2410 * objects at once.
2411 */
2412
2413 save_throw_object (item, AT_FIRE, who);
2414
2415 if (item->destroyed ()
2416 || ((item->type == LAMP || item->type == TORCH)
2417 && item->glow_radius > 0))
2418 who->statusmsg (format (
2419 "You light the %s with the %s.",
2420 &item->name, &lighter->name));
2421 else
2422 who->failmsg (format (
2423 "You attempt to light the %s with the %s and fail.",
2424 &item->name, &lighter->name));
2425 }
2426 else
2427 who->failmsg ("You need to mark a lightable object.");
2428}
2429
2430/**
2431 * This function generates a cursed effect for cursed lamps and torches.
2432 */
2433void player_apply_lamp_cursed_effect (object *who, object *op)
2434{
2435 if (op->level)
2436 {
2437 who->failmsg (format (
2438 "The %s was cursed, it explodes in a big fireball!",
2439 &op->name));
2440 create_exploding_ball_at (who, op->level);
2441 }
2442 else
2443 {
2444 who->failmsg (format (
2445 "The %s was cursed, it crumbles to dust, at least it didn't explode.!",
2446 &op->name));
2447 }
2448
2449 op->destroy ();
2450}
2451
2452/**
2453 * Apply for players and lamps
2454 *
2455 * who - the player
2456 * op - the lamp
2457 */
2458void player_apply_lamp (object *who, object *op)
2459{
2460 bool switch_on = op->glow_radius ? false : true;
2461
2462 if (switch_on)
2463 {
2464 object *lighter = 0;
2465
2466 if (op->flag [FLAG_IS_LIGHTABLE]
2467 && !(lighter = auto_apply_lighter (who, op, 0)))
2468 return;
2469
2470 if (op->stats.food < 1)
2471 {
2472 if (op->type == LAMP)
2473 who->failmsg (format (
2474 "The %s is out of fuel! "
2475 "H<Lamps and similar items need fuel. They cannot be refilled.>",
2476 &op->name));
2477 else
2478 who->failmsg (format (
2479 "The %s is burnt out! "
2480 "H<Torches and similar items burn out and become worthless.>",
2481 &op->name));
2482 return;
2483 }
2484
2485 if (op->flag [FLAG_CURSED])
2486 {
2487 player_apply_lamp_cursed_effect (who, op);
2488 return;
2489 }
2490
2491 if (lighter)
2492 who->statusmsg (format (
2493 "You light up the %s with the %s.", &op->name, &lighter->name));
2494 else
2495 who->statusmsg (format ("You light up the %s.", &op->name));
2496 }
2497 else
2498 {
2499 if (op->flag [FLAG_CURSED])
2500 {
2501 player_apply_lamp_cursed_effect (who, op);
2502 return;
2503 }
2504
2505 if (op->type == TORCH)
2506 {
2507 if (!op->flag [FLAG_IS_LIGHTABLE])
2508 {
2509 who->statusmsg (format (
2510 "You put out the %s. "
2511 "H<The %s can't be used anymore, as it can't be lighted up again.>",
2512 &op->name, &op->name));
2513 }
2514 else
2515 who->statusmsg (format (
2516 "You put out the %s."
2517 "H<Torches wear out if you put them out.>",
2518 &op->name));
2519 }
2520 else
2521 who->statusmsg (format ("You turn off the %s.", &op->name));
2522 }
2523
2524 apply_lamp (op, switch_on);
2525}
2526
2527void get_animation_from_arch (object *op, arch_ptr a)
2528{
2529 op->animation_id = a->animation_id;
2530 op->flag [FLAG_IS_TURNABLE] = a->flag [FLAG_IS_TURNABLE];
2531 op->flag [FLAG_ANIMATE] = a->flag [FLAG_ANIMATE];
2532 op->anim_speed = a->anim_speed;
2533 op->last_anim = 0;
2534 op->state = 0;
2535 op->face = a->face;
2536
2537 if (NUM_ANIMATIONS(op) > 1)
2538 {
2539 SET_ANIMATION(op, 0);
2540 animate_object (op, op->direction);
2541 }
2542 else
2543 update_object (op, UP_OBJ_FACE);
2544}
2545
2546/**
2547 * Apply for LAMPs and TORCHes.
2548 *
2549 * op - the lamp
2550 * switch_on - a flag which says whether the lamp should be switched on or off
2551 */
2552void apply_lamp (object *op, bool switch_on)
2553{
2554 op->set_glow_radius (switch_on ? op->range : 0);
2555 op->set_speed (switch_on ? op->arch->speed : 0);
2556
2557 // torches wear out if you put them out
2558 if (op->type == TORCH && !switch_on)
2559 {
2560 if (op->flag [FLAG_IS_LIGHTABLE])
2561 {
2562 op->stats.food -= (double) op->arch->stats.food / 15;
2563 if (op->stats.food < 0)
2564 op->stats.food = 0;
2565 }
2566 else
2567 op->stats.food = 0;
2568 }
2569
2570 // lamps and torched get worthless when used up
2571 if (op->stats.food <= 0)
2572 op->value = 0;
2573
2574 // FIXME: This is a hack to make the more sane torches and lamps
2575 // still animated ;-/
2576 if (op->other_arch)
2577 get_animation_from_arch (op, switch_on ? op->other_arch : op->arch);
2578
2579 if (object *pl = op->visible_to ())
2580 esrv_update_item (UPD_ANIM | UPD_FACE | UPD_NAME, pl, op);
2318} 2581}
2319 2582
2320/** 2583/**
2321 * Main apply handler. 2584 * Main apply handler.
2322 * 2585 *
… …
2325 * Return value: 2588 * Return value:
2326 * 0: player or monster can't apply objects of that type 2589 * 0: player or monster can't apply objects of that type
2327 * 1: has been applied, or there was an error applying the object 2590 * 1: has been applied, or there was an error applying the object
2328 * 2: objects of that type can't be applied if not in inventory 2591 * 2: objects of that type can't be applied if not in inventory
2329 * 2592 *
2330 * op is the object that is causing object to be applied, tmp is the object 2593 * who is the object that is causing object to be applied, op is the object
2331 * being applied. 2594 * being applied.
2332 * 2595 *
2333 * aflag is special (always apply/unapply) flags. Nothing is done with 2596 * aflag is special (always apply/unapply) flags. Nothing is done with
2334 * them in this function - they are passed to apply_special 2597 * them in this function - they are passed to apply_special
2335 */ 2598 */
2336int 2599int
2337manual_apply (object *op, object *tmp, int aflag) 2600manual_apply (object *who, object *op, int aflag)
2338{ 2601{
2339 if (tmp->head) 2602 op = op->head_ ();
2340 tmp = tmp->head;
2341 2603
2342 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED)) 2604 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED))
2343 { 2605 {
2344 if (op->type == PLAYER) 2606 if (who->type == PLAYER)
2345 { 2607 {
2346 new_draw_info (NDI_UNIQUE, 0, op, "You should pay for it first."); 2608 examine (who, op);
2609 //who->failmsg ("You should pay for it first! H<You cannot use items marked as unpaid.>");//TODO remove
2347 return 1; 2610 return 1;
2348 } 2611 }
2349 else 2612 else
2350 return 0; /* monsters just skip unpaid items */ 2613 return 0; /* monsters just skip unpaid items */
2351 } 2614 }
2352 2615
2353 if (INVOKE_OBJECT (APPLY, tmp, ARG_OBJECT (op))) 2616 if (INVOKE_OBJECT (APPLY, op, ARG_OBJECT (who)))
2354 return RESULT_INT (0); 2617 return RESULT_INT (0);
2355 2618
2356 switch (tmp->type) 2619 switch (op->type)
2357 { 2620 {
2358 case CF_HANDLE: 2621 case CF_HANDLE:
2359 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2622 who->play_sound (sound_find ("turn_handle"));
2360 play_sound_map (op->map, op->x, op->y, SOUND_TURN_HANDLE); 2623 who->statusmsg ("You turn the handle.");
2361 tmp->value = tmp->value ? 0 : 1; 2624 op->value = op->value ? 0 : 1;
2362 SET_ANIMATION (tmp, tmp->value); 2625 SET_ANIMATION (op, op->value);
2363 update_object (tmp, UP_OBJ_FACE); 2626 update_object (op, UP_OBJ_FACE);
2364 push_button (tmp); 2627 push_button (op, who);
2365 return 1; 2628 return 1;
2366 2629
2367 case TRIGGER: 2630 case TRIGGER:
2368 if (check_trigger (tmp, op)) 2631 if (check_trigger (op, who))
2369 { 2632 {
2370 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2633 who->statusmsg ("You turn the handle.");
2371 play_sound_map (tmp->map, tmp->x, tmp->y, SOUND_TURN_HANDLE); 2634 who->play_sound (sound_find ("turn_handle"));
2372 } 2635 }
2373 else 2636 else
2374 new_draw_info (NDI_UNIQUE, 0, op, "The handle doesn't move."); 2637 who->failmsg ("The handle doesn't move.");
2375 2638
2376 return 1; 2639 return 1;
2377 2640
2378 case EXIT: 2641 case EXIT:
2379 if (op->type != PLAYER) 2642 if (who->type != PLAYER)
2380 return 0; 2643 return 0;
2381 2644
2382 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp)) 2645 if (!EXIT_PATH (op) || !is_legal_2ways_exit (who, op))
2383 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s is closed.", query_name (tmp)); 2646 who->failmsg (format ("The %s is closed.", query_name (op)));
2384 else 2647 else
2385 { 2648 {
2386 /* Don't display messages for random maps. */ 2649 /* Don't display messages for random maps. */
2387 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2)) 2650 if (op->msg && !EXIT_PATH (op).starts_with ("/!"))
2388 new_draw_info (NDI_NAVY, 0, op, tmp->msg); 2651 who->statusmsg (op->msg, NDI_NAVY);
2389 2652
2390 op->enter_exit (tmp); 2653 who->enter_exit (op);
2391 } 2654 }
2392 2655
2393 return 1; 2656 return 1;
2394 2657
2658 case INSCRIBABLE:
2659 who->statusmsg (op->msg);
2660 // maybe show a spell menu to chose from or something like that
2661 return 1;
2662
2395 case SIGN: 2663 case SIGN:
2396 apply_sign (op, tmp, 0); 2664 apply_sign (who, op, 0);
2397 return 1; 2665 return 1;
2398 2666
2399 case BOOK: 2667 case BOOK:
2400 if (op->type == PLAYER) 2668 if (who->type == PLAYER)
2401 { 2669 {
2402 apply_book (op, tmp); 2670 apply_book (who, op);
2403 return 1; 2671 return 1;
2404 } 2672 }
2405 else 2673 else
2406 return 0; 2674 return 0;
2407 2675
2408 case SKILLSCROLL: 2676 case SKILLSCROLL:
2409 if (op->type == PLAYER) 2677 if (who->type == PLAYER)
2410 { 2678 {
2411 apply_skillscroll (op, tmp); 2679 apply_skillscroll (who, op);
2412 return 1; 2680 return 1;
2413 } 2681 }
2414 else 2682 else
2415 return 0; 2683 return 0;
2416 2684
2417 case SPELLBOOK: 2685 case SPELLBOOK:
2418 if (op->type == PLAYER) 2686 if (who->type == PLAYER)
2419 { 2687 {
2420 apply_spellbook (op, tmp); 2688 apply_spellbook (who, op);
2421 return 1; 2689 return 1;
2422 } 2690 }
2423 else 2691 else
2424 return 0; 2692 return 0;
2425 2693
2426 case SCROLL: 2694 case SCROLL:
2427 apply_scroll (op, tmp, 0); 2695 apply_scroll (who, op, 0);
2428 return 1; 2696 return 1;
2429 2697
2430 case POTION: 2698 case POTION:
2431 apply_potion (op, tmp); 2699 apply_potion (who, op);
2432 return 1; 2700 return 1;
2433 2701
2434 /* Eneq(@csd.uu.se): Handle apply on containers. */ 2702 /* Eneq(@csd.uu.se): Handle apply on containers. */
2435 //TODO: remove, as it is unsed? 2703 //TODO: remove, as it is unsed?
2436 case CLOSE_CON: 2704 case CLOSE_CON:
2437 apply_container (op, tmp->env); 2705 apply_container (who, op->env);
2438 return 1; 2706 return 1;
2439 2707
2440 case CONTAINER: 2708 case CONTAINER:
2441 apply_container (op, tmp); 2709 apply_container (who, op);
2442 return 1; 2710 return 1;
2443 2711
2444 case TREASURE: 2712 case TREASURE:
2445 if (op->type == PLAYER) 2713 if (who->type == PLAYER)
2446 { 2714 {
2447 apply_treasure (op, tmp); 2715 apply_treasure (who, op);
2448 return 1; 2716 return 1;
2449 } 2717 }
2450 else 2718 else
2451 return 0; 2719 return 0;
2720
2721 case LAMP:
2722 case TORCH:
2723 player_apply_lamp (who, op);
2724 return 1;
2452 2725
2453 case WEAPON: 2726 case WEAPON:
2454 case ARMOUR: 2727 case ARMOUR:
2455 case BOOTS: 2728 case BOOTS:
2456 case GLOVES: 2729 case GLOVES:
… …
2464 case WAND: 2737 case WAND:
2465 case ROD: 2738 case ROD:
2466 case HORN: 2739 case HORN:
2467 case SKILL: 2740 case SKILL:
2468 case BOW: 2741 case BOW:
2469 case LAMP:
2470 case BUILDER: 2742 case BUILDER:
2471 case SKILL_TOOL: 2743 case SKILL_TOOL:
2472 if (tmp->env != op) 2744 if (op->env != who)
2473 return 2; /* not in inventory */ 2745 return 2; /* not in inventory */
2474 2746
2475 apply_special (op, tmp, aflag); 2747 apply_special (who, op, aflag);
2476 return 1; 2748 return 1;
2477 2749
2478 case DRINK: 2750 case DRINK:
2479 case FOOD: 2751 case FOOD:
2480 case FLESH: 2752 case FLESH:
2481 apply_food (op, tmp); 2753 apply_food (who, op);
2482 return 1; 2754 return 1;
2483 2755
2484 case POISON: 2756 case POISON:
2485 apply_poison (op, tmp); 2757 apply_poison (who, op);
2486 return 1; 2758 return 1;
2487 2759
2488 case SAVEBED: 2760 case SAVEBED:
2489 return 1; 2761 return 1;
2490 2762
2491 case ARMOUR_IMPROVER: 2763 case ARMOUR_IMPROVER:
2492 if (op->type == PLAYER) 2764 if (who->type == PLAYER)
2493 { 2765 {
2494 apply_armour_improver (op, tmp); 2766 apply_armour_improver (who, op);
2495 return 1; 2767 return 1;
2496 } 2768 }
2497 else 2769 else
2498 return 0; 2770 return 0;
2499 2771
2500 case WEAPON_IMPROVER: 2772 case WEAPON_IMPROVER:
2501 check_improve_weapon (op, tmp); 2773 check_improve_weapon (who, op);
2502 return 1; 2774 return 1;
2503 2775
2504 case CLOCK: 2776 case CLOCK:
2505 if (op->type == PLAYER) 2777 if (who->type == PLAYER)
2506 { 2778 {
2507 char buf[MAX_BUF]; 2779 char buf[MAX_BUF];
2508 timeofday_t tod; 2780 timeofday_t tod;
2509 2781
2510 get_tod (&tod); 2782 get_tod (&tod);
2783 who->play_sound (sound_find ("sound_clock"));
2784 who->statusmsg (format (
2511 sprintf (buf, "It is %d minute%s past %d o'clock %s", 2785 "It is %d minute%s past %d o'clock %s",
2512 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"), 2786 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"),
2513 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")); 2787 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")
2514 play_sound_player_only (op->contr, SOUND_CLOCK, 0, 0); 2788 ));
2515 new_draw_info (NDI_UNIQUE, 0, op, buf);
2516 return 1; 2789 return 1;
2517 } 2790 }
2518 else 2791 else
2519 return 0; 2792 return 0;
2520 2793
2521 case MENU: 2794 case MENU:
2522 if (op->type == PLAYER) 2795 if (who->type == PLAYER)
2523 { 2796 {
2524 shop_listing (tmp, op); 2797 shop_listing (op, who);
2525 return 1; 2798 return 1;
2526 } 2799 }
2527 else 2800 else
2528 return 0; 2801 return 0;
2529 2802
2530 case POWER_CRYSTAL: 2803 case POWER_CRYSTAL:
2531 apply_power_crystal (op, tmp); /* see egoitem.c */ 2804 apply_power_crystal (who, op); /* see egoitem.c */
2532 return 1; 2805 return 1;
2533 2806
2534 case LIGHTER: /* for lighting torches/lanterns/etc */ 2807 case LIGHTER: /* for lighting torches/lanterns/etc */
2535 if (op->type == PLAYER) 2808 if (who->type == PLAYER)
2536 { 2809 {
2537 apply_lighter (op, tmp); 2810 apply_lighter (who, op);
2538 return 1; 2811 return 1;
2539 } 2812 }
2540 else 2813 else
2541 return 0; 2814 return 0;
2542 2815
2543 case ITEM_TRANSFORMER: 2816 case ITEM_TRANSFORMER:
2544 apply_item_transformer (op, tmp); 2817 apply_item_transformer (who, op);
2545 return 1; 2818 return 1;
2546 2819
2547 default: 2820 default:
2548 return 0; 2821 return 0;
2549 } 2822 }
2550} 2823}
2551
2552 2824
2553/* quiet suppresses the "don't know how to apply" and "you must get it first" 2825/* quiet suppresses the "don't know how to apply" and "you must get it first"
2554 * messages as needed by player_apply_below(). But there can still be 2826 * messages as needed by player_apply_below(). But there can still be
2555 * "but you are floating high above the ground" messages. 2827 * "but you are floating high above the ground" messages.
2556 * 2828 *
2557 * Same return value as apply() function. 2829 * Same return value as apply() function.
2558 */ 2830 */
2559int 2831int
2560player_apply (object *pl, object *op, int aflag, int quiet) 2832player_apply (object *pl, object *op, int aflag, int quiet)
2561{ 2833{
2562 int tmp;
2563
2564 if (op->env == NULL && (pl->move_type & MOVE_FLYING)) 2834 if (!op->env && (pl->move_type & MOVE_FLYING))
2565 { 2835 {
2566 /* player is flying and applying object not in inventory */ 2836 /* player is flying and applying object not in inventory */
2567 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING)) 2837 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING))
2568 { 2838 {
2569 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high " "above the ground!"); 2839 pl->failmsg ("But you are floating high above the ground! "
2840 "H<You have to stop levitating first, if you can, either by using your levitation skill, "
2841 "or waiting till the levitation effect wears off.>");
2570 return 0; 2842 return 0;
2571 } 2843 }
2572 } 2844 }
2573 2845
2574 pl->contr->last_used = op; 2846 pl->contr->last_used = op;
2575 2847
2576 tmp = manual_apply (pl, op, aflag); 2848 int tmp = manual_apply (pl, op, aflag);
2849
2577 if (!quiet) 2850 if (!quiet)
2578 { 2851 {
2579 if (tmp == 0) 2852 if (tmp == 0)
2580 new_draw_info_format (NDI_UNIQUE, 0, pl, "I don't know how to apply the %s.", query_name (op)); 2853 pl->statusmsg (format ("I don't know how to apply the %s.", query_name (op)));
2581 else if (tmp == 2) 2854 else if (tmp == 2)
2582 new_draw_info_format (NDI_UNIQUE, 0, pl, "You must get it first!\n"); 2855 pl->failmsg ("You must get it first!\n");
2583 } 2856 }
2857
2584 return tmp; 2858 return tmp;
2585} 2859}
2586 2860
2587/** 2861/**
2588 * player_apply_below attempts to apply the object 'below' the player. 2862 * player_apply_below attempts to apply the object 'below' the player.
… …
2615 * person moving on it, also activate. Added code to make it 2889 * person moving on it, also activate. Added code to make it
2616 * so that at least one of players movement types be that which 2890 * so that at least one of players movement types be that which
2617 * the item needs. 2891 * the item needs.
2618 */ 2892 */
2619 if (!tmp->invisible || (tmp->move_on & pl->move_type)) 2893 if (!tmp->invisible || (tmp->move_on & pl->move_type))
2620 {
2621 if (player_apply (pl, tmp, 0, 1) == 1) 2894 if (player_apply (pl, tmp, 0, 1) == 1)
2622 return; 2895 return;
2623 } 2896
2624 if (floors >= 2) 2897 if (floors >= 2)
2625 return; /* process at most two floor objects */ 2898 return; /* process at most two floor objects */
2626 } 2899 }
2627} 2900}
2628 2901
… …
2663 { 2936 {
2664 pl->combat_ob = 0; 2937 pl->combat_ob = 0;
2665 who->change_weapon (pl->ranged_ob); 2938 who->change_weapon (pl->ranged_ob);
2666 } 2939 }
2667 2940
2668 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op)); 2941 who->statusmsg (format ("You unwield %s.", query_name (op)));
2669 2942
2670 change_abil (who, op); 2943 change_abil (who, op);
2671 CLEAR_FLAG (who, FLAG_READY_WEAPON); 2944 CLEAR_FLAG (who, FLAG_READY_WEAPON);
2672 break; 2945 break;
2673 2946
2674 case SKILL: 2947 case SKILL:
2675 if (who->contr) 2948 if (who->contr)
2676 { 2949 {
2950 if (IS_COMBAT_SKILL (op->subtype))
2951 who->change_weapon (who->contr->combat_ob = 0);
2952 else if (IS_RANGED_SKILL (op->subtype))
2953 who->change_weapon (who->contr->ranged_ob = 0);
2954
2677 if (!op->invisible) 2955 if (op->invisible)
2678 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op)); 2956 who->statusmsg (format ("You can no longer use the skill: %s.", &op->skill));
2679 else 2957 else
2680 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill); 2958 who->statusmsg (format ("You stop using the %s.", query_name (op)));
2681 } 2959 }
2682 2960
2683 change_abil (who, op); 2961 change_abil (who, op);
2684 CLEAR_FLAG (who, FLAG_READY_SKILL); 2962 CLEAR_FLAG (who, FLAG_READY_SKILL);
2685 break; 2963 break;
… …
2692 case GLOVES: 2970 case GLOVES:
2693 case AMULET: 2971 case AMULET:
2694 case GIRDLE: 2972 case GIRDLE:
2695 case BRACERS: 2973 case BRACERS:
2696 case CLOAK: 2974 case CLOAK:
2697 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op)); 2975 who->statusmsg (format ("You unwear %s.", query_name (op)));
2698 change_abil (who, op); 2976 change_abil (who, op);
2699 break; 2977 break;
2700
2701 case LAMP:
2702 {
2703 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name);
2704
2705 object *tmp2 = arch_to_object (op->other_arch);
2706 tmp2->x = op->x;
2707 tmp2->y = op->y;
2708 tmp2->map = op->map;
2709 tmp2->below = op->below;
2710 tmp2->above = op->above;
2711 tmp2->stats.food = op->stats.food;
2712 CLEAR_FLAG (tmp2, FLAG_APPLIED);
2713
2714 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
2715 SET_FLAG (tmp2, FLAG_INV_LOCKED);
2716
2717 if (who->contr)
2718 esrv_del_item (who->contr, op->count);
2719
2720 op->destroy ();
2721 insert_ob_in_ob (tmp2, who);
2722 who->update_stats ();
2723
2724 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
2725 {
2726 if (who->contr)
2727 {
2728 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!");
2729 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
2730 }
2731 }
2732
2733 if (who->contr)
2734 esrv_send_item (who, tmp2);
2735 }
2736
2737 return 1; /* otherwise, an attempt to drop causes problems */
2738 2978
2739 case BOW: 2979 case BOW:
2740 case WAND: 2980 case WAND:
2741 case ROD: 2981 case ROD:
2742 case HORN: 2982 case HORN:
… …
2746 { 2986 {
2747 pl->ranged_ob = 0; 2987 pl->ranged_ob = 0;
2748 who->change_weapon (pl->combat_ob); 2988 who->change_weapon (pl->combat_ob);
2749 } 2989 }
2750 2990
2751 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2991 who->statusmsg (format ("You unready %s.", query_name (op)));
2752 } 2992 }
2753 else 2993 else
2754 { 2994 {
2755 who->change_skill (0); 2995 who->change_skill (0);
2756 2996
… …
2762 3002
2763 break; 3003 break;
2764 3004
2765 case BUILDER: 3005 case BUILDER:
2766 if (who->contr) 3006 if (who->contr)
2767 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 3007 who->statusmsg (format ("You unready %s.", query_name (op)));
2768 break; 3008 break;
2769 3009
2770 default: 3010 default:
2771 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op)); 3011 who->statusmsg (format ("You unapply %s.", query_name (op)));
2772 break; 3012 break;
2773 } 3013 }
2774 3014
3015 if (aflags & AP_NO_MERGE || !merge_ob (op, 0))
3016 if (object *pl = op->visible_to ())
3017 esrv_send_item (pl, op);
3018
2775 who->update_stats (); 3019 who->update_stats ();
2776
2777 if (!(aflags & AP_NO_MERGE))
2778 {
2779 object *tmp = merge_ob (op, 0);
2780
2781 if (who->contr)
2782 {
2783 if (tmp)
2784 { /* it was merged */
2785 esrv_del_item (who->contr, op->count);
2786 op = tmp;
2787 }
2788
2789 esrv_send_item (who, op);
2790 }
2791 }
2792 3020
2793 return 0; 3021 return 0;
2794} 3022}
2795 3023
2796/** 3024/**
… …
2828 * Returns 0 on success, returns 1 if there is some problem. 3056 * Returns 0 on success, returns 1 if there is some problem.
2829 * if aflags is AP_PRINT, we instead print out waht to unapply 3057 * if aflags is AP_PRINT, we instead print out waht to unapply
2830 * instead of doing it. This is a lot less code than having 3058 * instead of doing it. This is a lot less code than having
2831 * another function that does just that. 3059 * another function that does just that.
2832 */ 3060 */
3061
3062#define CANNOT_REMOVE_CURSED \
3063 "H<You cannot remove cursed or damned items, you first have to remove the curse. " \
3064 "Praying over an altar, scrolls of remove curse/damnation, " \
3065 "priests or even other players might help.>"
3066
2833int 3067int
2834unapply_for_ob (object *who, object *op, int aflags) 3068unapply_for_ob (object *who, object *op, int aflags)
2835{ 3069{
2836 if (op->is_range ()) 3070 if (op->is_range ())
2837 for (object *tmp = who->inv; tmp; tmp = tmp->below) 3071 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2838 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ()) 3072 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ())
2839 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))) 3073 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)))
2840 { 3074 {
2841 if (aflags & AP_PRINT) 3075 if (aflags & AP_PRINT)
2842 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 3076 who->failmsg (query_name (tmp));
2843 else 3077 else
2844 unapply_special (who, tmp, aflags); 3078 unapply_special (who, tmp, aflags);
2845 } 3079 }
2846 else 3080 else
2847 { 3081 {
2848 /* In this case, we want to try and remove a cursed item. 3082 /* In this case, we want to try and remove a cursed item.
2849 * While we know it won't work, we want unapply_special to 3083 * While we know it won't work, we want unapply_special to
2850 * at least generate the message. 3084 * at least generate the message.
2851 */ 3085 */
2852 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't remove the %s.", query_name (tmp)); 3086 who->failmsg (format ("No matter how hard you try, you just can't remove the %s." CANNOT_REMOVE_CURSED, query_name (tmp)));
2853 return 1; 3087 return 1;
2854 } 3088 }
2855 3089
2856 for (int i = 0; i < NUM_BODY_LOCATIONS; i++) 3090 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
2857 { 3091 {
… …
2880 3114
2881 /* If we are just printing, we don't care about cursed status */ 3115 /* If we are just printing, we don't care about cursed status */
2882 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)))) 3116 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))))
2883 { 3117 {
2884 if (aflags & AP_PRINT) 3118 if (aflags & AP_PRINT)
2885 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 3119 who->failmsg (query_name (tmp));
2886 else 3120 else
2887 unapply_special (who, tmp, aflags); 3121 unapply_special (who, tmp, aflags);
2888 } 3122 }
2889 else 3123 else
2890 { 3124 {
2891 /* Cursed item that we can't unequip - tell the player. 3125 /* Cursed item that we can't unequip - tell the player.
2892 * Note this could be annoying if this is just one of a few, 3126 * Note this could be annoying if this is just one of a few,
2893 * so it may not be critical (eg, putting on a ring and you have 3127 * so it may not be critical (eg, putting on a ring and you have
2894 * one cursed ring.) 3128 * one cursed ring.)
2895 */ 3129 */
2896 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s just won't come off", query_name (tmp)); 3130 who->failmsg (format ("The %s just won't come off." CANNOT_REMOVE_CURSED, query_name (tmp)));
2897 } 3131 }
2898 3132
2899 last = tmp->below; 3133 last = tmp->below;
2900 } 3134 }
2901 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the 3135 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the
… …
3054 * 3288 *
3055 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE) 3289 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE)
3056 * 3290 *
3057 * apply_special() doesn't check for unpaid items. 3291 * apply_special() doesn't check for unpaid items.
3058 */ 3292 */
3293
3294#define LACK_ITEM_POWER \
3295 " H<You lack enough unused item power to use this weapon, see the skills command.>"
3296
3059int 3297int
3060apply_special (object *who, object *op, int aflags) 3298apply_special (object *who, object *op, int aflags)
3061{ 3299{
3062 int basic_flag = aflags & AP_BASIC_FLAGS; 3300 int basic_flag = aflags & AP_BASIC_FLAGS;
3063 object *tmp, *tmp2, *skop = NULL; 3301 object *tmp, *tmp2, *skop = NULL;
… …
3078 if (basic_flag == AP_APPLY) 3316 if (basic_flag == AP_APPLY)
3079 return 0; 3317 return 0;
3080 3318
3081 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))) 3319 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)))
3082 { 3320 {
3083 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't remove %s.", query_name (op)); 3321 who->failmsg (format ("No matter how hard you try, you just can't remove %s." CANNOT_REMOVE_CURSED, query_name (op)));
3084 return 1; 3322 return 1;
3085 } 3323 }
3086 3324
3087 return unapply_special (who, op, aflags); 3325 return unapply_special (who, op, aflags);
3088 } 3326 }
3089
3090 if (basic_flag == AP_UNAPPLY) 3327 else if (basic_flag == AP_UNAPPLY)
3091 return 0; 3328 return 0;
3092 3329
3093 // if the item is combat/ranged, wield the relevant slot first 3330 // if the item is combat/ranged, wield the relevant slot first
3094 // to resolve conflicts. 3331 // to resolve conflicts.
3095 if (player *pl = who->contr) 3332 if (player *pl = who->contr)
… …
3104 /* Can't just apply this object. Lets see what not and what to do */ 3341 /* Can't just apply this object. Lets see what not and what to do */
3105 if (int i = can_apply_object (who, op)) 3342 if (int i = can_apply_object (who, op))
3106 { 3343 {
3107 if (i & CAN_APPLY_NEVER) 3344 if (i & CAN_APPLY_NEVER)
3108 { 3345 {
3109 new_draw_info_format (NDI_UNIQUE, 0, who, "You don't have the body to use a %s\n", query_name (op)); 3346 who->failmsg (format ("You don't have the body to use a %s. H<You can never apply this item.>", query_name (op)));
3110 return 1; 3347 return 1;
3111 } 3348 }
3112 else if (i & CAN_APPLY_RESTRICTION) 3349 else if (i & CAN_APPLY_RESTRICTION)
3113 { 3350 {
3114 new_draw_info_format (NDI_UNIQUE, 0, who, "You have a prohibition against using a %s\n", query_name (op)); 3351 who->failmsg (format (
3352 "You have a prohibition against using a %s. "
3353 "H<Your belief, profession or class prevents you from applying this item.>",
3354 query_name (op)
3355 ));
3115 return 1; 3356 return 1;
3116 } 3357 }
3117 3358
3118 if (who->type != PLAYER) 3359 if (who->type != PLAYER)
3119 { 3360 {
… …
3123 } 3364 }
3124 else 3365 else
3125 { 3366 {
3126 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice)) 3367 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice))
3127 { 3368 {
3128 new_draw_info (NDI_UNIQUE, 0, who, "You need to unapply some of the following item(s) or change your applymode:"); 3369 who->failmsg ("You need to unapply some of the following item(s) or change your applymode:");
3129 unapply_for_ob (who, op, AP_PRINT); 3370 unapply_for_ob (who, op, AP_PRINT);
3130 return 1; 3371 return 1;
3131 } 3372 }
3132 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE)) 3373 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE))
3133 if (unapply_for_ob (who, op, aflags)) 3374 if (unapply_for_ob (who, op, aflags))
… …
3139 { 3380 {
3140 skop = find_skill_by_name (who, op->skill); 3381 skop = find_skill_by_name (who, op->skill);
3141 3382
3142 if (!skop) 3383 if (!skop)
3143 { 3384 {
3144 new_draw_info_format (NDI_UNIQUE, 0, who, "You need the %s skill to use this item!", &op->skill); 3385 who->failmsg (format ("You need the %s skill to use this item!", &op->skill));
3145 return 1; 3386 return 1;
3146 } 3387 }
3147 else 3388 else
3148 /* While experience will be credited properly, we want to change the 3389 /* While experience will be credited properly, we want to change the
3149 * skill so that the dam and wc get updated 3390 * skill so that the dam and wc get updated
… …
3153 3394
3154 if (who->type == PLAYER 3395 if (who->type == PLAYER
3155 && op->item_power 3396 && op->item_power
3156 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level) 3397 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level)
3157 { 3398 {
3158 new_draw_info (NDI_UNIQUE, 0, who,
3159 "Equipping that combined with other items would consume your soul! " 3399 who->failmsg ("Equipping that combined with other items would consume your soul!" LACK_ITEM_POWER);
3160 "[use the skills command to check your available item power]");
3161 return 1; 3400 return 1;
3162 } 3401 }
3163 3402
3164 /* Ok. We are now at the state where we can apply the new object. 3403 /* Ok. We are now at the state where we can apply the new object.
3165 * Note that we don't have the checks for can_use_... 3404 * Note that we don't have the checks for can_use_...
3166 * below - that is already taken care of by can_apply_object. 3405 * below - that is already taken care of by can_apply_object.
3167 */ 3406 */
3168 if (op->nrof > 1) 3407 tmp = op->nrof > 1 ? op->split (op->nrof - 1) : 0;
3169 tmp = get_split_ob (op, op->nrof - 1);
3170 else
3171 tmp = 0;
3172 3408
3173 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op))) 3409 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op)))
3174 return RESULT_INT (0); 3410 return RESULT_INT (0);
3175 3411
3176 switch (op->type) 3412 switch (op->type)
3177 { 3413 {
3178 case WEAPON: 3414 case WEAPON:
3179 if (!check_weapon_power (who, op->last_eat)) 3415 if (!check_weapon_power (who, op->last_eat))
3180 { 3416 {
3181 new_draw_info (NDI_UNIQUE, 0, who, "This weapon is too powerful for you to use. " 3417 op->failmsg ("This weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3182 "It would consume your soul!.");
3183 3418
3184 if (tmp) 3419 if (tmp)
3185 insert_ob_in_ob (tmp, who); 3420 insert_ob_in_ob (tmp, who);
3186 3421
3187 return 1; 3422 return 1;
3188 } 3423 }
3189 3424
3190 //TODO: this obviously fails for players using a shorter prefix 3425 //TODO: this obviously fails for players using a shorter prefix
3191 // i.e. "R" can use Ragnarok's sword. 3426 // i.e. "R" can use Ragnarok's sword.
3192 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3427 if (op->level && !op->name.starts_with (who->name))
3193 { 3428 {
3194 /* if the weapon does not have the name as the character, can't use it. */ 3429 /* if the weapon does not have the name as the character, can't use it. */
3195 /* (Ragnarok's sword attempted to be used by Foo: won't work) */ 3430 /* (Ragnarok's sword attempted to be used by Foo: won't work) */
3196 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3431 who->failmsg ("The weapon does not recognize you as its owner. H<Its name indicates that it belongs to somebody else.>");
3197 3432
3198 if (tmp) 3433 if (tmp)
3199 insert_ob_in_ob (tmp, who); 3434 insert_ob_in_ob (tmp, who);
3200 3435
3201 return 1; 3436 return 1;
3202 } 3437 }
3203 3438
3204 if (!skop) 3439 if (!skop)
3205 { 3440 {
3206 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO 3441 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3207 return 1; 3442 return 1;
3208 } 3443 }
3209 3444
3210 SET_FLAG (op, FLAG_APPLIED); 3445 SET_FLAG (op, FLAG_APPLIED);
3211 who->change_skill (skop); 3446 who->change_skill (skop);
3212 3447
3213 if (who->contr) 3448 if (who->contr)
3214 who->change_weapon (who->contr->combat_ob = op); 3449 who->change_weapon (who->contr->combat_ob = op);
3215 3450
3216 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op)); 3451 who->statusmsg (format ("You wield %s.", query_name (op)));
3217 3452
3218 SET_FLAG (who, FLAG_READY_WEAPON); 3453 SET_FLAG (who, FLAG_READY_WEAPON);
3219 change_abil (who, op); 3454 change_abil (who, op);
3220 break; 3455 break;
3221 3456
… …
3228 case BRACERS: 3463 case BRACERS:
3229 case CLOAK: 3464 case CLOAK:
3230 case RING: 3465 case RING:
3231 case AMULET: 3466 case AMULET:
3232 SET_FLAG (op, FLAG_APPLIED); 3467 SET_FLAG (op, FLAG_APPLIED);
3233 new_draw_info_format (NDI_UNIQUE, 0, who, "You wear %s.", query_name (op)); 3468 who->statusmsg (format ("You wear %s.", query_name (op)));
3234 change_abil (who, op); 3469 change_abil (who, op);
3235 break; 3470 break;
3236
3237 case LAMP:
3238 if (op->stats.food < 1)
3239 {
3240 new_draw_info_format (NDI_UNIQUE, 0, who, "Your %s is out of fuel!", &op->name);
3241 return 1;
3242 }
3243
3244 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn on your %s.", &op->name);
3245 tmp2 = arch_to_object (op->other_arch);
3246 tmp2->stats.food = op->stats.food;
3247 SET_FLAG (tmp2, FLAG_APPLIED);
3248
3249 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
3250 SET_FLAG (tmp2, FLAG_INV_LOCKED);
3251
3252 insert_ob_in_ob (tmp2, who);
3253
3254 /* Remove the old lantern */
3255 if (who->type == PLAYER)
3256 esrv_del_item (who->contr, op->count);
3257
3258 op->destroy ();
3259
3260 /* insert the portion that was split off */
3261 if (tmp)
3262 {
3263 insert_ob_in_ob (tmp, who);
3264 if (who->type == PLAYER)
3265 esrv_send_item (who, tmp);
3266 }
3267
3268 who->update_stats ();
3269
3270 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3271 if (who->type == PLAYER)
3272 {
3273 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!");
3274 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
3275 }
3276
3277 if (who->type == PLAYER)
3278 esrv_send_item (who, tmp2);
3279
3280 return 0;
3281 3471
3282 case SKILL_TOOL: 3472 case SKILL_TOOL:
3283 // applying a skill tool also readies the skill 3473 // applying a skill tool also readies the skill
3284 SET_FLAG (op, FLAG_APPLIED); 3474 SET_FLAG (op, FLAG_APPLIED);
3285 3475
… …
3306 who->change_weapon (pl->combat_ob = item); 3496 who->change_weapon (pl->combat_ob = item);
3307 goto found_weapon; 3497 goto found_weapon;
3308 } 3498 }
3309 } 3499 }
3310 3500
3501 who->failmsg (format (
3311 new_draw_info_format (NDI_UNIQUE, 0, who, "You need to apply a '%s' melee weapon before readying this skill", &op->skill); 3502 "You need to apply a '%s' melee weapon before readying this skill. "
3503 "H<Some skills need an item, in this case a melee weapon, to function.>",
3504 &op->skill
3505 ));
3312 return 1; 3506 return 1;
3313 3507
3314 found_weapon:; 3508 found_weapon:;
3315 } 3509 }
3316 else 3510 else
… …
3326 //TODO: bows should/must all have skill missile weapon right now 3520 //TODO: bows should/must all have skill missile weapon right now
3327 who->change_weapon (pl->ranged_ob = item); 3521 who->change_weapon (pl->ranged_ob = item);
3328 goto found_bow; 3522 goto found_bow;
3329 } 3523 }
3330 3524
3525 who->failmsg (
3331 new_draw_info (NDI_UNIQUE, 0, who, "You need to apply a missile weapon before readying this skill"); 3526 "You need to apply a missile weapon before readying this skill. "
3527 "H<Some skills need an item, in this case a missile weapon, to function.>"
3528 );
3332 return 1; 3529 return 1;
3333 3530
3334 found_bow:; 3531 found_bow:;
3335 } 3532 }
3336 else 3533 else
3337 who->change_weapon (pl->ranged_ob = op); 3534 who->change_weapon (pl->ranged_ob = op);
3338 } 3535 }
3339 3536
3340 if (!op->invisible) 3537 if (!op->invisible)
3341 { 3538 {
3342 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3539 who->statusmsg (format (
3343 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill); 3540 "You ready %s."
3541 "You can now use the skill: %s.",
3542 query_name (op),
3543 &op->skill
3544 ));
3344 } 3545 }
3345 else 3546 else
3346 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name); 3547 who->statusmsg (format ("Readied skill: %s.", op->skill ? &op->skill : &op->name));
3347 } 3548 }
3348 else 3549 else
3349 { 3550 {
3350 SET_FLAG (op, FLAG_APPLIED); 3551 SET_FLAG (op, FLAG_APPLIED);
3351 change_abil (who, op); 3552 change_abil (who, op);
… …
3356 break; 3557 break;
3357 3558
3358 case BOW: 3559 case BOW:
3359 if (!check_weapon_power (who, op->last_eat)) 3560 if (!check_weapon_power (who, op->last_eat))
3360 { 3561 {
3361 new_draw_info (NDI_UNIQUE, 0, who, "That weapon is too powerful for you to use."); 3562 who->failmsg ("That weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3362 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!.");
3363 3563
3364 if (tmp) 3564 if (tmp)
3365 insert_ob_in_ob (tmp, who); 3565 insert_ob_in_ob (tmp, who);
3366 3566
3367 return 1; 3567 return 1;
3368 } 3568 }
3369 3569
3370 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3570 if (op->level && !op->name.starts_with (who->name))
3371 { 3571 {
3372 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3572 who->failmsg ("The weapon does not recognize you as its owner. "
3573 "H<Its name indicates that it belongs to somebody else.>");
3373 if (tmp) 3574 if (tmp)
3374 insert_ob_in_ob (tmp, who); 3575 insert_ob_in_ob (tmp, who);
3375 3576
3376 return 1; 3577 return 1;
3377 } 3578 }
… …
3382 case HORN: 3583 case HORN:
3383 /* check for skill, alter player status */ 3584 /* check for skill, alter player status */
3384 3585
3385 if (!skop) 3586 if (!skop)
3386 { 3587 {
3387 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO 3588 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3388 return 1; 3589 return 1;
3389 } 3590 }
3390 3591
3391 SET_FLAG (op, FLAG_APPLIED); 3592 SET_FLAG (op, FLAG_APPLIED);
3392 who->change_skill (skop); 3593 who->change_skill (skop);
3393 3594
3394 if (who->contr) 3595 if (who->contr)
3395 { 3596 {
3396 who->contr->ranged_ob = op; 3597 who->contr->ranged_ob = op;
3397 3598
3398 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3599 who->statusmsg (format ("You ready %s.", query_name (op)));
3399 3600
3400 if (op->type == BOW) 3601 if (op->type == BOW)
3401 { 3602 {
3402 who->current_weapon = op; 3603 who->current_weapon = op;
3403 change_abil (who, op); 3604 change_abil (who, op);
3404 new_draw_info_format (NDI_UNIQUE, 0, who,
3405 "You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)); 3605 who->statusmsg (format ("You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)));
3406 } 3606 }
3407 } 3607 }
3408 else 3608 else
3409 { 3609 {
3410 if (op->type == BOW) 3610 if (op->type == BOW)
… …
3420 { 3620 {
3421 //TODO: wtf does this do? shouldn't this be managed automatically (slots?) 3621 //TODO: wtf does this do? shouldn't this be managed automatically (slots?)
3422 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER) 3622 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER)
3423 unapply_special (who, who->contr->ranged_ob, 0); 3623 unapply_special (who, who->contr->ranged_ob, 0);
3424 3624
3425 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op)); 3625 who->statusmsg (format ("You ready your %s.", query_name (op)));
3426 3626
3427 who->contr->ranged_ob = op; 3627 who->contr->ranged_ob = op;
3428 } 3628 }
3429 break; 3629 break;
3430 3630
3431 default: 3631 default:
3432 new_draw_info_format (NDI_UNIQUE, 0, who, "You apply %s.", query_name (op)); 3632 who->statusmsg (format ("You apply %s.", query_name (op)));
3433 } /* end of switch op->type */ 3633 }
3434 3634
3435 SET_FLAG (op, FLAG_APPLIED); 3635 SET_FLAG (op, FLAG_APPLIED);
3436 3636
3437 if (tmp) 3637 if (tmp)
3438 tmp = insert_ob_in_ob (tmp, who); 3638 who->insert (tmp);
3439 3639
3440 who->update_stats (); 3640 who->update_stats ();
3441 3641
3442 /* We exclude spell casting objects. The fire code will set the 3642 /* We exclude spell casting objects. The fire code will set the
3443 * been applied flag when they are used - until that point, 3643 * been applied flag when they are used - until that point,
… …
3445 */ 3645 */
3446 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD) 3646 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD)
3447 SET_FLAG (op, FLAG_BEEN_APPLIED); 3647 SET_FLAG (op, FLAG_BEEN_APPLIED);
3448 3648
3449 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3649 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3450 {
3451 if (who->type == PLAYER) 3650 if (who->type == PLAYER)
3452 { 3651 {
3453 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3652 who->failmsg (
3653 "Oops, it feels deadly cold! "
3654 "H<Maybe it wasn't such a bright idea to apply this cursed or damned item.>"
3655 );
3454 SET_FLAG (op, FLAG_KNOWN_CURSED); 3656 SET_FLAG (op, FLAG_KNOWN_CURSED);
3455 } 3657 }
3456 }
3457 3658
3458 if (who->type == PLAYER) 3659 if (object *pl = op->visible_to ())
3459 {
3460 /* if multiple objects were applied, update both slots */
3461 if (tmp)
3462 esrv_send_item (who, tmp);
3463
3464 esrv_send_item (who, op); 3660 esrv_send_item (pl, op);
3465 }
3466 3661
3467 return 0; 3662 return 0;
3468} 3663}
3469 3664
3470int 3665int
3471monster_apply_special (object *who, object *op, int aflags) 3666monster_apply_special (object *who, object *op, int aflags)
3472{ 3667{
3473 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED)) 3668 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED))
3474 return 1; 3669 return 1;
3670
3475 return apply_special (who, op, aflags); 3671 return apply_special (who, op, aflags);
3476} 3672}
3477 3673
3478/** 3674/**
3479 * Map was just loaded, handle op's initialisation. 3675 * Map was just loaded, handle op's initialisation.
… …
3483int 3679int
3484auto_apply (object *op) 3680auto_apply (object *op)
3485{ 3681{
3486 object *tmp = NULL, *tmp2; 3682 object *tmp = NULL, *tmp2;
3487 int i; 3683 int i;
3684
3685 CLEAR_FLAG (op, FLAG_AUTO_APPLY);
3488 3686
3489 switch (op->type) 3687 switch (op->type)
3490 { 3688 {
3491 case SHOP_FLOOR: 3689 case SHOP_FLOOR:
3492 if (!op->has_random_items ()) 3690 if (!op->has_random_items ())
… …
3494 3692
3495 do 3693 do
3496 { 3694 {
3497 i = 10; /* let's give it 10 tries */ 3695 i = 10; /* let's give it 10 tries */
3498 while ((tmp = generate_treasure (op->randomitems, 3696 while ((tmp = generate_treasure (op->randomitems,
3499 op->stats.exp ? (int) op->stats.exp : MAX (op->map->difficulty, 5))) == NULL && --i); 3697 op->stats.exp
3698 ? (int) op->stats.exp
3699 : max (op->map->difficulty, 5)))
3700 == NULL && --i);
3701
3500 if (tmp == NULL) 3702 if (tmp == NULL)
3501 return 0; 3703 return 0;
3704
3502 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 3705 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
3503 { 3706 {
3504 tmp->destroy (); 3707 tmp->destroy ();
3505 tmp = NULL; 3708 tmp = NULL;
3506 } 3709 }
… …
3509 3712
3510 tmp->x = op->x; 3713 tmp->x = op->x;
3511 tmp->y = op->y; 3714 tmp->y = op->y;
3512 SET_FLAG (tmp, FLAG_UNPAID); 3715 SET_FLAG (tmp, FLAG_UNPAID);
3513 insert_ob_in_map (tmp, op->map, NULL, 0); 3716 insert_ob_in_map (tmp, op->map, NULL, 0);
3514 CLEAR_FLAG (op, FLAG_AUTO_APPLY);
3515 identify (tmp); 3717 identify (tmp);
3516 break; 3718 break;
3517 3719
3518 case TREASURE: 3720 case TREASURE:
3519 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 3721 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
… …
3526 /* If we generated an object and put it in this object inventory, 3728 /* If we generated an object and put it in this object inventory,
3527 * move it to the parent object as the current object is about 3729 * move it to the parent object as the current object is about
3528 * to disappear. An example of this item is the random_* stuff 3730 * to disappear. An example of this item is the random_* stuff
3529 * that is put inside other objects. 3731 * that is put inside other objects.
3530 */ 3732 */
3531 for (tmp = op->inv; tmp; tmp = tmp2)
3532 {
3533 tmp2 = tmp->below;
3534 tmp->remove ();
3535
3536 if (op->env) 3733 if (op->env)
3537 insert_ob_in_ob (tmp, op->env); 3734 while (op->inv)
3538 else 3735 op->env->insert (op->inv);
3539 tmp->destroy ();
3540 }
3541 3736
3542 op->destroy (); 3737 op->destroy ();
3543 break; 3738 break;
3544 } 3739 }
3545 return tmp ? 1 : 0; 3740
3741 return !!tmp;
3546} 3742}
3547 3743
3548/** 3744/**
3549 * fix_auto_apply goes through the entire map every time a map 3745 * fix_auto_apply goes through the entire map every time a map
3550 * is loaded or swapped in and performs special actions for 3746 * is loaded or swapped in and performs special actions for
… …
3564 3760
3565 if (tmp->inv) 3761 if (tmp->inv)
3566 { 3762 {
3567 object *invtmp, *invnext; 3763 object *invtmp, *invnext;
3568 3764
3569 for (invtmp = tmp->inv; invtmp != NULL; invtmp = invnext) 3765 for (invtmp = tmp->inv; invtmp; invtmp = invnext)
3570 { 3766 {
3571 invnext = invtmp->below; 3767 invnext = invtmp->below;
3572 3768
3573 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY)) 3769 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY))
3574 auto_apply (invtmp); 3770 auto_apply (invtmp);
3575 else if (invtmp->type == TREASURE && invtmp->has_random_items ()) 3771 else if (invtmp->type == TREASURE && invtmp->has_random_items ())
3576 { 3772 {
3577 while ((invtmp->stats.hp--) > 0) 3773 while (invtmp->stats.hp-- > 0)
3578 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0); 3774 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0);
3579 3775
3580 invtmp->randomitems = NULL; 3776 invtmp->randomitems = NULL;
3581 } 3777 }
3582 else if (invtmp && invtmp->arch 3778 else if (invtmp && invtmp->arch
… …
3694 /* check for hp, sp change */ 3890 /* check for hp, sp change */
3695 if (food->stats.hp != 0) 3891 if (food->stats.hp != 0)
3696 { 3892 {
3697 if (QUERY_FLAG (food, FLAG_CURSED)) 3893 if (QUERY_FLAG (food, FLAG_CURSED))
3698 { 3894 {
3699 assign (who->contr->killer, food->name); 3895 who->contr->killer = food;
3700 hit_player (who, food->stats.hp, food, AT_POISON, 1); 3896 hit_player (who, food->stats.hp, food, AT_POISON, 1);
3701 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3897 who->failmsg ("Eck!...that was poisonous!");
3702 } 3898 }
3703 else 3899 else
3704 { 3900 {
3705 if (food->stats.hp > 0) 3901 if (food->stats.hp > 0)
3706 new_draw_info (NDI_UNIQUE, 0, who, "You begin to feel better."); 3902 who->statusmsg ("You begin to feel better.");
3707 else 3903 else
3708 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3904 who->failmsg ("Eck!...that was poisonous!");
3905
3709 who->stats.hp += food->stats.hp; 3906 who->stats.hp += food->stats.hp;
3710 } 3907 }
3711 } 3908 }
3909
3712 if (food->stats.sp != 0) 3910 if (food->stats.sp != 0)
3713 { 3911 {
3714 if (QUERY_FLAG (food, FLAG_CURSED)) 3912 if (QUERY_FLAG (food, FLAG_CURSED))
3715 { 3913 {
3716 new_draw_info (NDI_UNIQUE, 0, who, "You are drained of mana!"); 3914 who->failmsg ("You are drained of mana!");
3717 who->stats.sp -= food->stats.sp; 3915 who->stats.sp -= food->stats.sp;
3718 if (who->stats.sp < 0) 3916 if (who->stats.sp < 0)
3719 who->stats.sp = 0; 3917 who->stats.sp = 0;
3720 } 3918 }
3721 else 3919 else
3722 { 3920 {
3723 new_draw_info (NDI_UNIQUE, 0, who, "You feel a rush of magical energy!"); 3921 who->statusmsg ("You feel a rush of magical energy!");
3724 who->stats.sp += food->stats.sp; 3922 who->stats.sp += food->stats.sp;
3725 /* place limit on max sp from food? */ 3923 /* place limit on max sp from food? */
3726 } 3924 }
3727 } 3925 }
3926
3728 who->update_stats (); 3927 who->update_stats ();
3729} 3928}
3730 3929
3731/**
3732 * Designed primarily to light torches/lanterns/etc.
3733 * Also burns up burnable material too. First object in the inventory is
3734 * the selected object to "burn". -b.t.
3735 */
3736void
3737apply_lighter (object *who, object *lighter)
3738{
3739 object *item;
3740 int is_player_env = 0;
3741
3742 item = find_marked_object (who);
3743 if (item)
3744 {
3745 if (lighter->last_eat && lighter->stats.food)
3746 { /* lighter gets used up */
3747 /* Split multiple lighters if they're being used up. Otherwise *
3748 * one charge from each would be used up. --DAMN */
3749 if (lighter->nrof > 1)
3750 {
3751 object *oneLighter = lighter->clone ();
3752
3753 lighter->nrof -= 1;
3754 oneLighter->nrof = 1;
3755 oneLighter->stats.food--;
3756 esrv_send_item (who, lighter);
3757 oneLighter = insert_ob_in_ob (oneLighter, who);
3758 esrv_send_item (who, oneLighter);
3759 }
3760 else
3761 lighter->stats.food--;
3762 }
3763 else if (lighter->last_eat)
3764 { /* no charges left in lighter */
3765 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with a used up %s.", &item->name, &lighter->name);
3766 return;
3767 }
3768
3769 /* Perhaps we should split what we are trying to light on fire?
3770 * I can't see many times when you would want to light multiple
3771 * objects at once.
3772 */
3773
3774 if (who == item->in_player ())
3775 is_player_env = 1;
3776
3777 save_throw_object (item, AT_FIRE, who);
3778
3779 if (item->destroyed ())
3780 {
3781 new_draw_info_format (NDI_UNIQUE, 0, who, "You light the %s with the %s.", &item->name, &lighter->name);
3782 /* Need to update the player so that the players glow radius
3783 * gets changed.
3784 */
3785 if (is_player_env)
3786 who->update_stats ();
3787 }
3788 else
3789 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with the %s and fail.", &item->name, &lighter->name);
3790 }
3791 else /* nothing to light */
3792 new_draw_info (NDI_UNIQUE, 0, who, "You need to mark a lightable object.");
3793
3794}
3795 3930
3796/** 3931/**
3797 * op made some mistake with a scroll, this takes care of punishment. 3932 * op made some mistake with a scroll, this takes care of punishment.
3798 * scroll_failure()- hacked directly from spell_failure 3933 * scroll_failure()- hacked directly from spell_failure
3799 */ 3934 */
… …
3805 3940
3806 if (failure <= -1 && failure > -15) 3941 if (failure <= -1 && failure > -15)
3807 { /* wonder */ 3942 { /* wonder */
3808 object *tmp; 3943 object *tmp;
3809 3944
3810 new_draw_info (NDI_UNIQUE, 0, op, "Your spell warps!."); 3945 op->failmsg ("Your spell warps!");
3811 tmp = get_archetype (SPELL_WONDER); 3946 tmp = get_archetype (SPELL_WONDER);
3812 cast_wonder (op, op, 0, tmp); 3947 cast_wonder (op, op, 0, tmp);
3813 tmp->destroy (); 3948 tmp->destroy ();
3814 } 3949 }
3815 else if (failure <= -15 && failure > -35) 3950 else if (failure <= -15 && failure > -35)
3816 { /* drain mana */ 3951 { /* drain mana */
3817 new_draw_info (NDI_UNIQUE, 0, op, "Your mana is drained!."); 3952 op->failmsg ("Your mana is drained!");
3818 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW); 3953 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW);
3819 if (op->stats.sp < 0) 3954 if (op->stats.sp < 0)
3820 op->stats.sp = 0; 3955 op->stats.sp = 0;
3821 } 3956 }
3822 else if (settings.spell_failure_effects == TRUE) 3957 else if (settings.spell_failure_effects == TRUE)
3823 { 3958 {
3824 if (failure <= -35 && failure > -60) 3959 if (failure <= -35 && failure > -60)
3825 { /* confusion */ 3960 { /* confusion */
3826 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3961 op->failmsg ("The magic recoils on you!");
3827 confuse_player (op, op, power); 3962 confuse_player (op, op, power);
3828 } 3963 }
3829 else if (failure <= -60 && failure > -70) 3964 else if (failure <= -60 && failure > -70)
3830 { /* paralysis */ 3965 { /* paralysis */
3831 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils and paralyzes " "you!"); 3966 op->failmsg ("The magic recoils and paralyzes you!");
3832 paralyze_player (op, op, power); 3967 paralyze_player (op, op, power);
3833 } 3968 }
3834 else if (failure <= -70 && failure > -80) 3969 else if (failure <= -70 && failure > -80)
3835 { /* blind */ 3970 { /* blind */
3836 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3971 op->failmsg ("The magic recoils on you!");
3837 blind_player (op, op, power); 3972 blind_player (op, op, power);
3838 } 3973 }
3839 else if (failure <= -80) 3974 else if (failure <= -80)
3840 { /* blast the immediate area */ 3975 { /* blast the immediate area */
3841 object *tmp = get_archetype (LOOSE_MANA); 3976 object *tmp = get_archetype (LOOSE_MANA);
3842 cast_magic_storm (op, tmp, power); 3977 cast_magic_storm (op, tmp, power);
3843 new_draw_info (NDI_UNIQUE, 0, op, "You unleash uncontrolled mana!"); 3978 op->failmsg ("You unleash uncontrolled mana!");
3844 tmp->destroy (); 3979 tmp->destroy ();
3845 } 3980 }
3846 } 3981 }
3847} 3982}
3848 3983
… …
3899 } 4034 }
3900 4035
3901 /* insert the randomitems from the change's treasurelist into 4036 /* insert the randomitems from the change's treasurelist into
3902 * the player ref: player.c 4037 * the player ref: player.c
3903 */ 4038 */
3904 if (change->randomitems != NULL) 4039 if (change->randomitems)
3905 give_initial_items (pl, change->randomitems); 4040 give_initial_items (pl, change->randomitems);
3906 4041
3907 /* set up the face, for some races. */ 4042 /* set up the face, for some races. */
3908 4043
3909 /* first, look for the force object banning 4044 /* first, look for the force object banning
3910 * changing the face. Certain races never change face with class. 4045 * changing the face. Certain races never change face with class.
3911 */ 4046 */
3912 for (walk = pl->inv; walk != NULL; walk = walk->below) 4047 for (walk = pl->inv; walk; walk = walk->below)
3913 if (!strcmp (walk->name, "NOCLASSFACECHANGE")) 4048 if (walk->name == shstr_NOCLASSFACECHANGE)
3914 flag_change_face = 0; 4049 flag_change_face = 0;
3915 4050
3916 if (flag_change_face) 4051 if (flag_change_face)
3917 { 4052 {
3918 pl->animation_id = GET_ANIM_ID (change);
3919 pl->face = change->face; 4053 pl->face = change->face;
3920 4054 pl->animation_id = change->animation_id;
3921 if (QUERY_FLAG (change, FLAG_ANIMATE)) 4055 pl->flag [FLAG_ANIMATE] = change->flag [FLAG_ANIMATE];
3922 SET_FLAG (pl, FLAG_ANIMATE);
3923 else
3924 CLEAR_FLAG (pl, FLAG_ANIMATE);
3925 } 4056 }
3926 4057
3927 /* check the special case of can't use weapons */ 4058 /* check the special case of can't use weapons */
3928 /*if(QUERY_FLAG(change,FLAG_USE_WEAPON)) CLEAR_FLAG(pl,FLAG_USE_WEAPON); */ 4059 /*if(QUERY_FLAG(change,FLAG_USE_WEAPON)) CLEAR_FLAG(pl,FLAG_USE_WEAPON); */
3929 if (!strcmp (change->name, "monk")) 4060 if (change->name == shstr_monk)
3930 CLEAR_FLAG (pl, FLAG_USE_WEAPON); 4061 CLEAR_FLAG (pl, FLAG_USE_WEAPON);
3931 4062
3932 break; 4063 break;
3933 } 4064 }
3934 } 4065 }
… …
3955 char got[MAX_BUF]; 4086 char got[MAX_BUF];
3956 int len; 4087 int len;
3957 4088
3958 if (!pl || !transformer) 4089 if (!pl || !transformer)
3959 return; 4090 return;
4091
3960 marked = find_marked_object (pl); 4092 marked = find_marked_object (pl);
4093
3961 if (!marked) 4094 if (!marked)
3962 { 4095 {
3963 new_draw_info_format (NDI_UNIQUE, 0, pl, "Use the %s with what item?", query_name (transformer)); 4096 pl->failmsg (format ("Use the %s with what item?", query_name (transformer)));
3964 return; 4097 return;
3965 } 4098 }
4099
3966 if (!marked->slaying) 4100 if (!marked->slaying)
3967 { 4101 {
3968 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 4102 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
3969 return; 4103 return;
3970 } 4104 }
4105
3971 /* check whether they are compatible or not */ 4106 /* check whether they are compatible or not */
3972 find = strstr (marked->slaying, transformer->arch->archname); 4107 find = strstr (&marked->slaying, transformer->arch->archname);
3973 if (!find || (*(find + strlen (transformer->arch->archname)) != ':')) 4108 if (!find || (*(find + strlen (transformer->arch->archname)) != ':'))
3974 { 4109 {
3975 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 4110 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
3976 return; 4111 return;
3977 } 4112 }
4113
3978 find += strlen (transformer->arch->archname) + 1; 4114 find += strlen (transformer->arch->archname) + 1;
3979 /* Item can be used, now find how many and what it yields */ 4115 /* Item can be used, now find how many and what it yields */
3980 if (isdigit (*(find))) 4116 if (isdigit (*(find)))
3981 { 4117 {
3982 yield = atoi (find); 4118 yield = atoi (find);
… …
3989 else 4125 else
3990 yield = 1; 4126 yield = 1;
3991 4127
3992 while (isdigit (*find)) 4128 while (isdigit (*find))
3993 find++; 4129 find++;
4130
3994 while (*find == ' ') 4131 while (*find == ' ')
3995 find++; 4132 find++;
4133
3996 memset (got, 0, MAX_BUF); 4134 memset (got, 0, MAX_BUF);
4135
3997 if ((separator = strchr (find, ';')) != NULL) 4136 if ((separator = strchr (find, ';')) != NULL)
3998 {
3999 len = separator - find; 4137 len = separator - find;
4000 }
4001 else 4138 else
4002 {
4003 len = strlen (find); 4139 len = strlen (find);
4004 } 4140
4005 if (len > MAX_BUF - 1) 4141 if (len > MAX_BUF - 1)
4006 len = MAX_BUF - 1; 4142 len = MAX_BUF - 1;
4143
4007 strcpy (got, find); 4144 strcpy (got, find);
4008 got[len] = '\0'; 4145 got[len] = '\0';
4009 4146
4010 /* Now create new item, remove used ones when required. */ 4147 /* Now create new item, remove used ones when required. */
4011 new_item = get_archetype (got); 4148 new_item = get_archetype (got);
4012 if (!new_item) 4149 if (!new_item)
4013 { 4150 {
4014 new_draw_info_format (NDI_UNIQUE, 0, pl, "This %s is strange, better to not use it.", query_base_name (marked, 0)); 4151 pl->failmsg (format ("This %s is strange, better to not use it.", query_base_name (marked, 0)));
4015 return; 4152 return;
4016 } 4153 }
4017 4154
4018 new_item->nrof = yield; 4155 new_item->nrof = yield;
4156
4019 new_draw_info_format (NDI_UNIQUE, 0, pl, "You %s the %s.", &transformer->slaying, query_base_name (marked, 0)); 4157 pl->statusmsg (format ("You %s the %s.", &transformer->slaying, query_base_name (marked, 0)));
4020 insert_ob_in_ob (new_item, pl); 4158
4021 esrv_send_inventory (pl, pl); 4159 pl->insert (new_item);
4022 /* Eat up one item */ 4160 /* Eat up one item */
4023 decrease_ob_nr (marked, 1); 4161 marked->decrease ();
4162
4024 /* Eat one transformer if needed */ 4163 /* Eat one transformer if needed */
4025 if (transformer->stats.food) 4164 if (transformer->stats.food)
4026 if (--transformer->stats.food == 0) 4165 if (--transformer->stats.food == 0)
4027 decrease_ob_nr (transformer, 1); 4166 transformer->decrease ();
4028} 4167}
4168

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines