ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/apply.C
(Generate patch)

Comparing deliantra/server/server/apply.C (file contents):
Revision 1.90 by root, Sat May 12 16:06:42 2007 UTC vs.
Revision 1.113 by root, Tue Jul 10 05:51:38 2007 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team
5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Crossfire TRT is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <crossfire@schmorp.de>
23 */ 22 */
24 23
25#include <cmath> 24#include <cmath>
26 25
… …
69 68
70 /* If the director has race set, only affect objects with a arch, 69 /* If the director has race set, only affect objects with a arch,
71 * name or race that matches. 70 * name or race that matches.
72 */ 71 */
73 if ((op->race) && 72 if ((op->race) &&
74 ((!(victim->arch && arch_flag && victim->arch->name) || op->race != victim->arch->name)) && 73 ((!(victim->arch && arch_flag && victim->arch->archname) || op->race != victim->arch->archname)) &&
75 ((!(victim->name && name_flag) || op->race != victim->name)) && 74 ((!(victim->name && name_flag) || op->race != victim->name)) &&
76 ((!(victim->race && race_flag) || op->race != victim->race))) 75 ((!(victim->race && race_flag) || op->race != victim->race)))
77 return 1; 76 return 1;
78 77
79 /* If the director has slaying set, only affect objects where none 78 /* If the director has slaying set, only affect objects where none
80 * of arch, name, or race match. 79 * of arch, name, or race match.
81 */ 80 */
82 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->name && op->slaying == victim->arch->name))) || 81 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->archname && op->slaying == victim->arch->archname))) ||
83 ((victim->name && name_flag && op->slaying == victim->name)) || 82 ((victim->name && name_flag && op->slaying == victim->name)) ||
84 ((victim->race && race_flag && op->slaying == victim->race))) 83 ((victim->race && race_flag && op->slaying == victim->race)))
85 return 1; 84 return 1;
86 85
87 return 0; 86 return 0;
… …
232 depl = present_arch_in_ob (at, op); 231 depl = present_arch_in_ob (at, op);
233 232
234 if (depl) 233 if (depl)
235 { 234 {
236 for (i = 0; i < NUM_STATS; i++) 235 for (i = 0; i < NUM_STATS; i++)
237 if (get_attr_value (&depl->stats, i)) 236 if (depl->stats.stat (i))
238 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]); 237 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]);
239 238
240 depl->destroy (); 239 depl->destroy ();
241 op->update_stats (); 240 op->update_stats ();
242 } 241 }
… …
374 force->stats.food *= 10; 373 force->stats.food *= 10;
375 for (i = 0; i < NROFATTACKS; i++) 374 for (i = 0; i < NROFATTACKS; i++)
376 if (force->resist[i] > 0) 375 if (force->resist[i] > 0)
377 force->resist[i] = -force->resist[i]; /* prot => vuln */ 376 force->resist[i] = -force->resist[i]; /* prot => vuln */
378 } 377 }
378
379 force->speed_left = -1; 379 force->speed_left = -1;
380 force = insert_ob_in_ob (force, op); 380 force = insert_ob_in_ob (force, op);
381 CLEAR_FLAG (tmp, FLAG_APPLIED); 381 CLEAR_FLAG (tmp, FLAG_APPLIED);
382 SET_FLAG (force, FLAG_APPLIED); 382 SET_FLAG (force, FLAG_APPLIED);
383 change_abil (op, force); 383 change_abil (op, force);
… …
424 return 0; 424 return 0;
425 425
426 op = op->below; 426 op = op->below;
427 while (op != NULL) 427 while (op != NULL)
428 { 428 {
429 if (strcmp (op->arch->name, item) == 0) 429 if (strcmp (op->arch->archname, item) == 0)
430 { 430 {
431 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED) 431 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED)
432 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID)) 432 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID))
433 { 433 {
434 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */ 434 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */
… …
458 prev = op; 458 prev = op;
459 op = op->below; 459 op = op->below;
460 460
461 while (op != NULL) 461 while (op != NULL)
462 { 462 {
463 if (strcmp (op->arch->name, item) == 0) 463 if (strcmp (op->arch->archname, item) == 0)
464 { 464 {
465 if (op->nrof >= nrof) 465 if (op->nrof >= nrof)
466 { 466 {
467 decrease_ob_nr (op, nrof); 467 decrease_ob_nr (op, nrof);
468 return; 468 return;
… …
854 { 854 {
855 base = base - (base * settings.armor_speed_improvement) / 100; 855 base = base - (base * settings.armor_speed_improvement) / 100;
856 pow++; 856 pow++;
857 } 857 }
858 858
859 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * base) / 100; 859 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * base) / 100;
860 } 860 }
861 else 861 else
862 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * (100 + armour->magic * settings.armor_speed_improvement)) / 100; 862 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * (100 + armour->magic * settings.armor_speed_improvement)) / 100;
863 863
864 if (!settings.armor_weight_linear) 864 if (!settings.armor_weight_linear)
865 { 865 {
866 int base = 100; 866 int base = 100;
867 int pow = 0; 867 int pow = 0;
… …
870 { 870 {
871 base = base - (base * settings.armor_weight_reduction) / 100; 871 base = base - (base * settings.armor_weight_reduction) / 100;
872 pow++; 872 pow++;
873 } 873 }
874 874
875 armour->weight = (armour->arch->clone.weight * base) / 100; 875 armour->weight = (armour->arch->weight * base) / 100;
876 } 876 }
877 else 877 else
878 armour->weight = (armour->arch->clone.weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100; 878 armour->weight = (armour->arch->weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100;
879 879
880 if (armour->weight <= 0) 880 if (armour->weight <= 0)
881 { 881 {
882 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n."); 882 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n.");
883 armour->weight = 1; 883 armour->weight = 1;
884 } 884 }
885 885
886 armour->item_power = get_power_from_ench (armour->arch->clone.item_power + armour->magic); 886 armour->item_power = get_power_from_ench (armour->arch->item_power + armour->magic);
887 887
888 if (op->type == PLAYER) 888 if (op->type == PLAYER)
889 { 889 {
890 esrv_send_item (op, armour); 890 esrv_send_item (op, armour);
891 if (QUERY_FLAG (armour, FLAG_APPLIED)) 891 if (QUERY_FLAG (armour, FLAG_APPLIED))
… …
943 943
944 price_in = cost * item->value; 944 price_in = cost * item->value;
945 } 945 }
946 else 946 else
947 { 947 {
948 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->name || 948 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->archname ||
949 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof)) 949 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof))
950 return 0; 950 return 0;
951 951
952 if (CONV_NEED (converter)) 952 if (CONV_NEED (converter))
953 { 953 {
… …
1005 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n", 1005 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n",
1006 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name); 1006 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name);
1007 1007
1008 /** 1008 /**
1009 * elmex: we are going to let the game continue, as the mapcreator 1009 * elmex: we are going to let the game continue, as the mapcreator
1010 * propably had something in mind when doing this 1010 * probably had something in mind when doing this
1011 */ 1011 */
1012 } 1012 }
1013 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y); 1013 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y);
1014 return 1; 1014 return 1;
1015} 1015}
… …
1244 */ 1244 */
1245static void 1245static void
1246apply_sign (object *op, object *sign, int autoapply) 1246apply_sign (object *op, object *sign, int autoapply)
1247{ 1247{
1248 readable_message_type *msgType; 1248 readable_message_type *msgType;
1249 char newbuf[HUGE_BUF];
1250 1249
1251 if (sign->msg == NULL) 1250 if (sign->msg == NULL)
1252 { 1251 {
1253 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it."); 1252 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it.");
1254 return; 1253 return;
… …
1275 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on) 1274 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on)
1276 { 1275 {
1277 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1276 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind.");
1278 return; 1277 return;
1279 } 1278 }
1279
1280 if (op->contr)
1281 if (client *ns = op->contr->ns)
1282 {
1280 msgType = get_readable_message_type (sign); 1283 msgType = get_readable_message_type (sign);
1284
1285 if (ns->can_msg)
1286 ns->send_msg (NDI_NAVY, msgType->msgtype, &sign->msg);
1287 else
1288 {
1289 char newbuf[HUGE_BUF];
1281 snprintf (newbuf, sizeof (newbuf), "%hhu %s", autoapply ? 1 : 0, &sign->msg); 1290 snprintf (newbuf, sizeof (newbuf), "%u %s", autoapply ? 1 : 0, &sign->msg);
1282 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg); 1291 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg);
1292 }
1293 }
1283} 1294}
1284 1295
1285/** 1296/**
1286 * 'victim' moves onto 'trap' 1297 * 'victim' moves onto 'trap'
1287 * 'victim' leaves 'trap' 1298 * 'victim' leaves 'trap'
… …
1310 * proper. This code was causing needless crashes. 1321 * proper. This code was causing needless crashes.
1311 */ 1322 */
1312 if (recursion_depth >= 500) 1323 if (recursion_depth >= 500)
1313 { 1324 {
1314 LOG (llevDebug, "WARNING: move_apply(): aborting recursion " 1325 LOG (llevDebug, "WARNING: move_apply(): aborting recursion "
1315 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->name, &trap->name, &victim->arch->name, &victim->name); 1326 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->archname, &trap->name, &victim->arch->archname, &victim->name);
1316 return; 1327 return;
1317 } 1328 }
1329
1318 recursion_depth++; 1330 recursion_depth++;
1319 if (trap->head) 1331 if (trap->head)
1320 trap = trap->head; 1332 trap = trap->head;
1321 1333
1322 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator))) 1334 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator)))
… …
1337 1349
1338 /* Just put in some sanity check. I think there is a bug in the 1350 /* Just put in some sanity check. I think there is a bug in the
1339 * above with some objects have zero speed, and thus the player 1351 * above with some objects have zero speed, and thus the player
1340 * getting permanently paralyzed. 1352 * getting permanently paralyzed.
1341 */ 1353 */
1342 if (victim->speed_left < -50.0) 1354 if (victim->speed_left < -50.f)
1343 victim->speed_left = -50.0; 1355 victim->speed_left = -50.f;
1344 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */ 1356 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */
1345 } 1357 }
1346 goto leave; 1358 goto leave;
1347 1359
1348 case SPINNER: 1360 case SPINNER:
… …
1517 } 1529 }
1518 goto leave; 1530 goto leave;
1519 1531
1520 default: 1532 default:
1521 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not " 1533 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not "
1522 "handled in move_apply()\n", &trap->name, &trap->arch->name, trap->type); 1534 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type);
1523 goto leave; 1535 goto leave;
1524 } 1536 }
1525 1537
1526leave: 1538leave:
1527 recursion_depth--; 1539 recursion_depth--;
… …
1539 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1551 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1540 { 1552 {
1541 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1553 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind.");
1542 return; 1554 return;
1543 } 1555 }
1556
1544 if (tmp->msg == NULL) 1557 if (!tmp->msg)
1545 { 1558 {
1546 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name); 1559 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name);
1547 return; 1560 return;
1548 } 1561 }
1549 1562
… …
1552 if (!skill_ob) 1565 if (!skill_ob)
1553 { 1566 {
1554 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1567 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols.");
1555 return; 1568 return;
1556 } 1569 }
1570
1557 lev_diff = tmp->level - (skill_ob->level + 5); 1571 lev_diff = tmp->level - (skill_ob->level + 5);
1558 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0) 1572 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0)
1559 { 1573 {
1560 if (lev_diff < 2) 1574 if (lev_diff < 2)
1561 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension."); 1575 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension.");
… …
1572 return; 1586 return;
1573 } 1587 }
1574 1588
1575 readable_message_type *msgType = get_readable_message_type (tmp); 1589 readable_message_type *msgType = get_readable_message_type (tmp);
1576 1590
1591 if (player *pl = op->contr)
1592 if (client *ns = pl->ns)
1593 if (ns->can_msg)
1594 {
1595 dynbuf_text buf;
1596 buf << long_desc (tmp, op)
1597 << "\n\n"
1598 << tmp->msg
1599 << '\0';
1600 ns->send_msg (NDI_NAVY, msgType->msgtype, buf.linearise ());
1601 }
1602 else
1577 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, 1603 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op,
1578 msgType->message_type, msgType->message_subtype, 1604 msgType->message_type, msgType->message_subtype,
1579 "You open the %s and start reading.\n%s", (char *)"%s\n%s", 1605 "You open the %s and start reading.\n%s", (char *)"%s\n%s",
1580 long_desc (tmp, op), &tmp->msg); 1606 long_desc (tmp, op), &tmp->msg);
1581 1607
1582 /* gain xp from reading */ 1608 /* gain xp from reading */
1583 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT)) 1609 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT))
1584 { /* only if not read before */ 1610 { /* only if not read before */
1585 int exp_gain = calc_skill_exp (op, tmp, skill_ob); 1611 int exp_gain = calc_skill_exp (op, tmp, skill_ob);
… …
1867 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1893 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1868 identify (tmp); 1894 identify (tmp);
1869 1895
1870 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name); 1896 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name);
1871 1897
1872
1873 cast_spell (op, tmp, dir, tmp->inv, NULL); 1898 cast_spell (op, tmp, dir, tmp->inv, NULL);
1874 decrease_ob (tmp); 1899 decrease_ob (tmp);
1875} 1900}
1876 1901
1877/** 1902/**
… …
1880 * chest. 1905 * chest.
1881 */ 1906 */
1882static void 1907static void
1883apply_treasure (object *op, object *tmp) 1908apply_treasure (object *op, object *tmp)
1884{ 1909{
1885 object *treas;
1886
1887
1888 /* Nice side effect of new treasure creation method is that the treasure 1910 /* Nice side effect of new treasure creation method is that the treasure
1889 * for the chest is done when the chest is created, and put into the chest 1911 * for the chest is done when the chest is created, and put into the chest
1890 * inventory. So that when the chest burns up, the items still exist. Also 1912 * inventory. So that when the chest burns up, the items still exist. Also
1891 * prevents people fromt moving chests to more difficult maps to get better 1913 * prevents people fromt moving chests to more difficult maps to get better
1892 * treasure 1914 * treasure
1893 */ 1915 */
1894
1895 treas = tmp->inv; 1916 object *treas = tmp->inv;
1896 if (treas == NULL) 1917
1918 if (!treas)
1897 { 1919 {
1898 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty."); 1920 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty.");
1899 decrease_ob (tmp); 1921 decrease_ob (tmp);
1900 return; 1922 return;
1901 } 1923 }
1924
1902 while (tmp->inv) 1925 while (tmp->inv)
1903 { 1926 {
1904 treas = tmp->inv; 1927 treas = tmp->inv;
1905 1928
1906 treas->remove (); 1929 treas->remove ();
… …
2024 if (meal->type != FLESH || !is_dragon_pl (op)) 2047 if (meal->type != FLESH || !is_dragon_pl (op))
2025 return 0; 2048 return 0;
2026 2049
2027 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces 2050 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces
2028 from the player's inventory */ 2051 from the player's inventory */
2029 shstr_cmp dragon_ability_force ("dragon_ability_force");
2030 shstr_cmp dragon_skin_force ("dragon_skin_force");
2031
2032 for (tmp = op->inv; tmp; tmp = tmp->below) 2052 for (tmp = op->inv; tmp; tmp = tmp->below)
2033 if (tmp->type == FORCE) 2053 if (tmp->type == FORCE)
2034 if (tmp->arch->name == dragon_skin_force) 2054 if (tmp->arch->archname == shstr_dragon_skin_force)
2035 skin = tmp; 2055 skin = tmp;
2036 else if (tmp->arch->name == dragon_ability_force) 2056 else if (tmp->arch->archname == shstr_dragon_ability_force)
2037 abil = tmp; 2057 abil = tmp;
2038 2058
2039 /* if either skin or ability are missing, this is an old player 2059 /* if either skin or ability are missing, this is an old player
2040 which is not to be considered a dragon -> bail out */ 2060 which is not to be considered a dragon -> bail out */
2041 if (skin == NULL || abil == NULL) 2061 if (skin == NULL || abil == NULL)
… …
2549 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high " "above the ground!"); 2569 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high " "above the ground!");
2550 return 0; 2570 return 0;
2551 } 2571 }
2552 } 2572 }
2553 2573
2554 /* Check for PLAYER to avoid a DM to disappear in a puff of smoke if
2555 * applied.
2556 */
2557 if (op->type != PLAYER && QUERY_FLAG (op, FLAG_WAS_WIZ) && !QUERY_FLAG (pl, FLAG_WAS_WIZ))
2558 {
2559 play_sound_map (pl->map, pl->x, pl->y, SOUND_OB_EVAPORATE);
2560 new_draw_info (NDI_UNIQUE, 0, pl, "The object disappears in a puff " "of smoke!");
2561 new_draw_info (NDI_UNIQUE, 0, pl, "It must have been an illusion.");
2562 op->destroy ();
2563 return 1;
2564 }
2565
2566 pl->contr->last_used = op; 2574 pl->contr->last_used = op;
2567 2575
2568 tmp = manual_apply (pl, op, aflag); 2576 tmp = manual_apply (pl, op, aflag);
2569 if (!quiet) 2577 if (!quiet)
2570 { 2578 {
… …
2629{ 2637{
2630 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags)) 2638 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags))
2631 || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags))) 2639 || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags)))
2632 return RESULT_INT (0); 2640 return RESULT_INT (0);
2633 2641
2634 object *tmp2;
2635
2636 CLEAR_FLAG (op, FLAG_APPLIED); 2642 CLEAR_FLAG (op, FLAG_APPLIED);
2637 2643
2638 switch (op->type) 2644 switch (op->type)
2639 { 2645 {
2646 case SKILL_TOOL:
2647 // unapplying a skill tool should also unapply the skill it governs
2648 // but this is hard, as it shouldn't do so when the skill can
2649 // be used for other reasons
2650 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2651 if (tmp->skill == op->skill
2652 && tmp->type == SKILL
2653 && tmp->flag [FLAG_APPLIED]
2654 && !tmp->flag [FLAG_CAN_USE_SKILL])
2655 unapply_special (who, tmp, 0);
2656
2657 change_abil (who, op);
2658 break;
2659
2640 case WEAPON: 2660 case WEAPON:
2661 if (player *pl = who->contr)
2662 if (op == pl->combat_ob)
2663 {
2664 pl->combat_ob = 0;
2665 who->change_weapon (pl->ranged_ob);
2666 }
2667
2641 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op)); 2668 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op));
2642 2669
2643 change_abil (who, op); 2670 change_abil (who, op);
2644 CLEAR_FLAG (who, FLAG_READY_WEAPON); 2671 CLEAR_FLAG (who, FLAG_READY_WEAPON);
2645
2646 if (who->contr)
2647 {
2648 if (who->contr->combat_ob == op)
2649 who->contr->combat_ob = 0;
2650
2651 if (who->current_weapon == op)
2652 who->current_weapon = 0;
2653 }
2654
2655 clear_skill (who);
2656 break; 2672 break;
2657 2673
2658 case SKILL: /* allows objects to impart skills */
2659 case SKILL_TOOL: 2674 case SKILL:
2660 if (op != who->chosen_skill)
2661 LOG (llevError, "BUG: apply_special(): applied skill is not a chosen skill\n");
2662
2663 if (who->contr) 2675 if (who->contr)
2664 { 2676 {
2665 if (!op->invisible) 2677 if (!op->invisible)
2666 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op)); 2678 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op));
2667 else 2679 else
2668 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill); 2680 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill);
2669 } 2681 }
2670 2682
2671 change_abil (who, op); 2683 change_abil (who, op);
2672 who->chosen_skill = 0;
2673 CLEAR_FLAG (who, FLAG_READY_SKILL); 2684 CLEAR_FLAG (who, FLAG_READY_SKILL);
2674 break; 2685 break;
2675 2686
2676 case ARMOUR: 2687 case ARMOUR:
2677 case HELMET: 2688 case HELMET:
… …
2686 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op)); 2697 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op));
2687 change_abil (who, op); 2698 change_abil (who, op);
2688 break; 2699 break;
2689 2700
2690 case LAMP: 2701 case LAMP:
2702 {
2691 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name); 2703 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name);
2704
2692 tmp2 = arch_to_object (op->other_arch); 2705 object *tmp2 = arch_to_object (op->other_arch);
2693 tmp2->x = op->x; 2706 tmp2->x = op->x;
2694 tmp2->y = op->y; 2707 tmp2->y = op->y;
2695 tmp2->map = op->map; 2708 tmp2->map = op->map;
2696 tmp2->below = op->below; 2709 tmp2->below = op->below;
2697 tmp2->above = op->above; 2710 tmp2->above = op->above;
2698 tmp2->stats.food = op->stats.food; 2711 tmp2->stats.food = op->stats.food;
2699 CLEAR_FLAG (tmp2, FLAG_APPLIED); 2712 CLEAR_FLAG (tmp2, FLAG_APPLIED);
2700 2713
2701 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 2714 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
2702 SET_FLAG (tmp2, FLAG_INV_LOCKED); 2715 SET_FLAG (tmp2, FLAG_INV_LOCKED);
2703 2716
2704 if (who->contr) 2717 if (who->contr)
2705 esrv_del_item (who->contr, op->count); 2718 esrv_del_item (who->contr, op->count);
2706 2719
2707 op->destroy (); 2720 op->destroy ();
2708 insert_ob_in_ob (tmp2, who); 2721 insert_ob_in_ob (tmp2, who);
2709 who->update_stats (); 2722 who->update_stats ();
2710 2723
2711 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 2724 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
2712 { 2725 {
2713 if (who->contr) 2726 if (who->contr)
2714 { 2727 {
2715 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 2728 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!");
2716 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 2729 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
2717 } 2730 }
2718 } 2731 }
2719 2732
2720 if (who->contr) 2733 if (who->contr)
2721 esrv_send_item (who, tmp2); 2734 esrv_send_item (who, tmp2);
2735 }
2722 2736
2723 return 1; /* otherwise, an attempt to drop causes problems */ 2737 return 1; /* otherwise, an attempt to drop causes problems */
2724 2738
2725 case BOW: 2739 case BOW:
2726 case WAND: 2740 case WAND:
2727 case ROD: 2741 case ROD:
2728 case HORN: 2742 case HORN:
2729 clear_skill (who);
2730
2731 if (who->contr) 2743 if (player *pl = who->contr)
2744 {
2745 if (op == pl->ranged_ob)
2732 { 2746 {
2747 pl->ranged_ob = 0;
2748 who->change_weapon (pl->combat_ob);
2749 }
2750
2733 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2751 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op));
2734
2735 if (who->contr->ranged_ob == op)
2736 who->contr->ranged_ob = 0;
2737
2738 if (who->current_weapon == op)
2739 who->current_weapon = 0;
2740 } 2752 }
2741 else 2753 else
2742 { 2754 {
2755 who->change_skill (0);
2756
2743 if (op->type == BOW) 2757 if (op->type == BOW)
2744 CLEAR_FLAG (who, FLAG_READY_BOW); 2758 CLEAR_FLAG (who, FLAG_READY_BOW);
2745 else 2759 else
2746 CLEAR_FLAG (who, FLAG_READY_RANGE); 2760 CLEAR_FLAG (who, FLAG_READY_RANGE);
2747 } 2761 }
2748 2762
2749 break; 2763 break;
2750 2764
2751 case BUILDER: 2765 case BUILDER:
2752 if (who->contr) 2766 if (who->contr)
2753 {
2754 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2767 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op));
2755
2756 if (who->contr->ranged_ob == op)
2757 who->contr->ranged_ob = 0;
2758 }
2759 break; 2768 break;
2760 2769
2761 default: 2770 default:
2762 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op)); 2771 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op));
2763 break; 2772 break;
… …
2787/** 2796/**
2788 * Returns the object that is using location 'loc'. 2797 * Returns the object that is using location 'loc'.
2789 * Note that 'start' is the first object to start examing - we 2798 * Note that 'start' is the first object to start examing - we
2790 * then go through the below of this. In this way, you can do 2799 * then go through the below of this. In this way, you can do
2791 * something like: 2800 * something like:
2792 * tmp = get_item_from_body_location(who->inv, 1); 2801 * tmp = get_next_item_from_body_location(who->inv, 1);
2793 * if (tmp) tmp1 = get_item_from_body_location(tmp->below, 1); 2802 * if (tmp) tmp1 = get_next_item_from_body_location(tmp->below, 1);
2794 * to find the second object that may use this location, etc. 2803 * to find the second object that may use this location, etc.
2795 * Returns NULL if no match is found. 2804 * Returns NULL if no match is found.
2796 * loc is the index into the array we are looking for a match. 2805 * loc is the index into the array we are looking for a match.
2797 * don't return invisible objects unless they are skill objects 2806 * don't return invisible objects unless they are skill objects
2798 * invisible other objects that use 2807 * invisible other objects that use
2799 * up body locations can be used as restrictions. 2808 * up body locations can be used as restrictions.
2800 */ 2809 */
2801static object * 2810static object *
2802get_item_from_body_location (int loc, object *start) 2811get_next_item_from_body_location (int loc, object *start)
2803{ 2812{
2804 if (start)
2805 for (object *tmp = start; tmp; tmp = tmp->below) 2813 for (object *tmp = start; tmp; tmp = tmp->below)
2806 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->slot[loc].info && (!tmp->invisible || tmp->type == SKILL)) 2814 if (tmp->flag [FLAG_APPLIED]
2815 && tmp->slot[loc].info
2816 && (!tmp->invisible || tmp->type == SKILL))
2807 return tmp; 2817 return tmp;
2808 2818
2809 return 0; 2819 return 0;
2810} 2820}
2811 2821
2812/** 2822/**
… …
2853 /* We do a while loop - may need to remove several items in order 2863 /* We do a while loop - may need to remove several items in order
2854 * to free up enough slots. 2864 * to free up enough slots.
2855 */ 2865 */
2856 while ((who->slot[i].used + op->slot[i].info) < 0) 2866 while ((who->slot[i].used + op->slot[i].info) < 0)
2857 { 2867 {
2858 object *tmp = get_item_from_body_location (i, last); 2868 object *tmp = get_next_item_from_body_location (i, last);
2859 2869
2860 if (!tmp) 2870 if (!tmp)
2861 { 2871 {
2862#if 0 2872#if 0
2863 /* Not a bug - we'll get this if the player has cursed items 2873 /* Not a bug - we'll get this if the player has cursed items
… …
2901 * Checks to see if 'who' can apply object 'op'. 2911 * Checks to see if 'who' can apply object 'op'.
2902 * Returns 0 if apply can be done without anything special. 2912 * Returns 0 if apply can be done without anything special.
2903 * Otherwise returns a bitmask - potentially several of these may be 2913 * Otherwise returns a bitmask - potentially several of these may be
2904 * set, but largely depends on circumstance - in the future, processing 2914 * set, but largely depends on circumstance - in the future, processing
2905 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER 2915 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER
2906 * is set, do we really are what the other flags may be?) 2916 * is set, do we really care what the other flags may be?)
2907 * 2917 *
2908 * See include/define.h for detailed description of the meaning of 2918 * See include/define.h for detailed description of the meaning of
2909 * these return values. 2919 * these return values.
2910 */ 2920 */
2911int 2921int
… …
2920 for (int i = 0; i < NUM_BODY_LOCATIONS; i++) 2930 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
2921 { 2931 {
2922 if (op->slot[i].info) 2932 if (op->slot[i].info)
2923 { 2933 {
2924 /* Item uses more slots than we have */ 2934 /* Item uses more slots than we have */
2925 if (abs (op->slot[i].info) > who->slot[i].info) 2935 if (who->slot[i].info + op->slot [i].info < 0)
2926 { 2936 {
2927 /* Could return now for efficiency - rest of info below isn't 2937 /* Could return now for efficiency - rest of info below isn't
2928 * really needed. 2938 * really needed.
2929 */ 2939 */
2930 retval |= CAN_APPLY_NEVER; 2940 retval |= CAN_APPLY_NEVER;
2931 } 2941 }
2932 else if ((who->slot[i].used + op->slot[i].info) < 0) 2942 else if (who->slot[i].used + op->slot[i].info < 0)
2933 { 2943 {
2934 /* in this case, equipping this would use more free spots than 2944 /* in this case, equipping this would use more free spots than
2935 * we have. 2945 * we have.
2936 */ 2946 */
2937 2947
… …
2948 { 2958 {
2949 retval |= CAN_APPLY_UNAPPLY; 2959 retval |= CAN_APPLY_UNAPPLY;
2950 continue; 2960 continue;
2951 } 2961 }
2952 2962
2953 object *tmp1 = get_item_from_body_location (i, who->inv); 2963 object *tmp1 = get_next_item_from_body_location (i, who->inv);
2954 if (!tmp1) 2964 if (!tmp1)
2955 { 2965 {
2956#if 0 2966#if 0
2957 /* This is sort of an error, but happens a lot when old players 2967 /* This is sort of an error, but happens a lot when old players
2958 * join in with more stuff equipped than they are now allowed. 2968 * join in with more stuff equipped than they are now allowed.
… …
2966 /* need to unapply something. However, if this something 2976 /* need to unapply something. However, if this something
2967 * is different than we had found before, it means they need 2977 * is different than we had found before, it means they need
2968 * to apply multiple objects 2978 * to apply multiple objects
2969 */ 2979 */
2970 retval |= CAN_APPLY_UNAPPLY; 2980 retval |= CAN_APPLY_UNAPPLY;
2981
2971 if (!tmp) 2982 if (!tmp)
2972 tmp = tmp1; 2983 tmp = tmp1;
2973 else if (tmp != tmp1) 2984 else if (tmp != tmp1)
2974 retval |= CAN_APPLY_UNAPPLY_MULT; 2985 retval |= CAN_APPLY_UNAPPLY_MULT;
2975 2986
… …
3037 * AP_UNAPPLY=always unapply). 3048 * AP_UNAPPLY=always unapply).
3038 * 3049 *
3039 * Optional flags: 3050 * Optional flags:
3040 * AP_NO_MERGE: don't merge an unapplied object with other objects 3051 * AP_NO_MERGE: don't merge an unapplied object with other objects
3041 * AP_IGNORE_CURSE: unapply cursed items 3052 * AP_IGNORE_CURSE: unapply cursed items
3053 * AP_NO_READY: do not ready skills when applying skill tools
3042 * 3054 *
3043 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE) 3055 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE)
3044 * 3056 *
3045 * apply_special() doesn't check for unpaid items. 3057 * apply_special() doesn't check for unpaid items.
3046 */ 3058 */
… …
3079 return 0; 3091 return 0;
3080 3092
3081 // if the item is combat/ranged, wield the relevant slot first 3093 // if the item is combat/ranged, wield the relevant slot first
3082 // to resolve conflicts. 3094 // to resolve conflicts.
3083 if (player *pl = who->contr) 3095 if (player *pl = who->contr)
3084 switch (op->type) 3096 switch (op->slottype ())
3085 { 3097 {
3086 case WEAPON:
3087 who->change_weapon (pl->combat_ob); 3098 case slot_combat: who->change_weapon (pl->combat_ob); break;
3088 break;
3089
3090 case BOW:
3091 case ROD:
3092 case WAND:
3093 case HORN:
3094 case SKILL_TOOL:
3095 who->change_weapon (pl->ranged_ob); 3099 case slot_ranged: who->change_weapon (pl->ranged_ob); break;
3096 break;
3097
3098 case SKILL:
3099 if (IS_COMBAT_SKILL (op->subtype))
3100 who->change_weapon (pl->combat_ob);
3101 else if (IS_RANGED_SKILL (op->subtype))
3102 who->change_weapon (pl->ranged_ob);
3103 break;
3104 } 3100 }
3101
3102 splay (op);
3105 3103
3106 /* Can't just apply this object. Lets see what not and what to do */ 3104 /* Can't just apply this object. Lets see what not and what to do */
3107 if (int i = can_apply_object (who, op)) 3105 if (int i = can_apply_object (who, op))
3108 { 3106 {
3109 if (i & CAN_APPLY_NEVER) 3107 if (i & CAN_APPLY_NEVER)
… …
3148 } 3146 }
3149 else 3147 else
3150 /* While experience will be credited properly, we want to change the 3148 /* While experience will be credited properly, we want to change the
3151 * skill so that the dam and wc get updated 3149 * skill so that the dam and wc get updated
3152 */ 3150 */
3153 change_skill (who, skop, 0); 3151 who->change_skill (skop);
3154 } 3152 }
3155 3153
3156 if (who->type == PLAYER 3154 if (who->type == PLAYER
3157 && op->item_power 3155 && op->item_power
3158 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level) 3156 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level)
… …
3178 switch (op->type) 3176 switch (op->type)
3179 { 3177 {
3180 case WEAPON: 3178 case WEAPON:
3181 if (!check_weapon_power (who, op->last_eat)) 3179 if (!check_weapon_power (who, op->last_eat))
3182 { 3180 {
3183 new_draw_info (NDI_UNIQUE, 0, who, "This weapon is too powerful for you to use.\n" 3181 new_draw_info (NDI_UNIQUE, 0, who, "This weapon is too powerful for you to use. "
3184 "It would consume your soul!."); 3182 "It would consume your soul!.");
3185 3183
3186 if (tmp) 3184 if (tmp)
3187 insert_ob_in_ob (tmp, who); 3185 insert_ob_in_ob (tmp, who);
3188 3186
… …
3208 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO 3206 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO
3209 return 1; 3207 return 1;
3210 } 3208 }
3211 3209
3212 SET_FLAG (op, FLAG_APPLIED); 3210 SET_FLAG (op, FLAG_APPLIED);
3213 change_skill (who, skop, 1); 3211 who->change_skill (skop);
3214 3212
3215 if (who->contr) 3213 if (who->contr)
3216 who->change_weapon (who->contr->combat_ob = op); 3214 who->change_weapon (who->contr->combat_ob = op);
3217 3215
3218 if (!QUERY_FLAG (who, FLAG_READY_WEAPON))
3219 SET_FLAG (who, FLAG_READY_WEAPON);
3220
3221 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op)); 3216 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op));
3222 3217
3218 SET_FLAG (who, FLAG_READY_WEAPON);
3223 change_abil (who, op); 3219 change_abil (who, op);
3224 break; 3220 break;
3225 3221
3226 case ARMOUR: 3222 case ARMOUR:
3227 case HELMET: 3223 case HELMET:
… …
3281 if (who->type == PLAYER) 3277 if (who->type == PLAYER)
3282 esrv_send_item (who, tmp2); 3278 esrv_send_item (who, tmp2);
3283 3279
3284 return 0; 3280 return 0;
3285 3281
3286 /* this part is needed for skill-tools */ 3282 case SKILL_TOOL:
3283 // applying a skill tool also readies the skill
3284 SET_FLAG (op, FLAG_APPLIED);
3285
3286 if (!(aflags & AP_NO_READY))
3287 {
3288 skop = find_skill_by_name (who, op->skill);
3289 if (!skop->flag [FLAG_APPLIED])
3290 apply_special (who, skop, AP_APPLY);
3291 }
3292 break;
3293
3287 case SKILL: 3294 case SKILL:
3288 case SKILL_TOOL:
3289 if (who->chosen_skill)
3290 {
3291 LOG (llevError, "BUG: apply_special(): can't apply two skills\n");
3292 return 1;
3293 }
3294
3295 if (player *pl = who->contr) 3295 if (player *pl = who->contr)
3296 { 3296 {
3297 if (IS_COMBAT_SKILL (op->subtype)) 3297 if (IS_COMBAT_SKILL (op->subtype))
3298 { 3298 {
3299 if (skill_flags [op->subtype] & SF_NEED_WEAPON) 3299 if (skill_flags [op->subtype] & SF_NEED_WEAPON)
3300 { 3300 {
3301 for (object *item = who->inv; item; item = item->below) 3301 for (object *item = who->inv; item; item = item->below)
3302 if (item->type == WEAPON && item->flag [FLAG_APPLIED]) 3302 if (item->type == WEAPON && item->flag [FLAG_APPLIED])
3303 { 3303 {
3304 if (item->skill == op->skill)
3305 {
3304 who->change_weapon (pl->combat_ob = item); 3306 who->change_weapon (pl->combat_ob = item);
3305 goto found_weapon; 3307 goto found_weapon;
3308 }
3306 } 3309 }
3307 3310
3308 new_draw_info (NDI_UNIQUE, 0, who, "You need to apply a melee weapon before readying this skill"); 3311 new_draw_info_format (NDI_UNIQUE, 0, who, "You need to apply a '%s' melee weapon before readying this skill", &op->skill);
3309 return 1; 3312 return 1;
3310 3313
3311 found_weapon:; 3314 found_weapon:;
3312 } 3315 }
3313 else 3316 else
… …
3318 if (skill_flags [op->subtype] & SF_NEED_BOW) 3321 if (skill_flags [op->subtype] & SF_NEED_BOW)
3319 { 3322 {
3320 for (object *item = who->inv; item; item = item->below) 3323 for (object *item = who->inv; item; item = item->below)
3321 if (item->type == BOW && item->flag [FLAG_APPLIED]) 3324 if (item->type == BOW && item->flag [FLAG_APPLIED])
3322 { 3325 {
3326 //TODO: bows should/must all have skill missile weapon right now
3323 who->change_weapon (pl->ranged_ob = item); 3327 who->change_weapon (pl->ranged_ob = item);
3324 goto found_bow; 3328 goto found_bow;
3325 } 3329 }
3326 3330
3327 new_draw_info (NDI_UNIQUE, 0, who, "You need to apply a missile weapon before readying this skill"); 3331 new_draw_info (NDI_UNIQUE, 0, who, "You need to apply a missile weapon before readying this skill");
3328 return 1; 3332 return 1;
3329 3333
3330 found_bow:; 3334 found_bow:;
3331 }
3332 else if (skill_flags [op->subtype] & SF_NEED_ITEM)
3333 {
3334 for (object *item = who->inv; item; item = item->below)
3335 if (item->flag [FLAG_APPLIED]
3336 && (item->type == WAND || item->type == ROD || item->type == HORN))
3337 {
3338 who->change_weapon (pl->ranged_ob = item);
3339 goto found_item;
3340 }
3341
3342 new_draw_info (NDI_UNIQUE, 0, who, "You need to apply a magic item before readying this skill");
3343 return 1;
3344
3345 found_item:;
3346 } 3335 }
3347 else 3336 else
3348 who->change_weapon (pl->ranged_ob = op); 3337 who->change_weapon (pl->ranged_ob = op);
3349 } 3338 }
3350 3339
… …
3354 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill); 3343 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill);
3355 } 3344 }
3356 else 3345 else
3357 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name); 3346 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name);
3358 } 3347 }
3359 3348 else
3349 {
3360 SET_FLAG (op, FLAG_APPLIED); 3350 SET_FLAG (op, FLAG_APPLIED);
3361 change_abil (who, op); 3351 change_abil (who, op);
3362 who->chosen_skill = op; 3352 who->chosen_skill = op;
3363 SET_FLAG (who, FLAG_READY_SKILL); 3353 SET_FLAG (who, FLAG_READY_SKILL);
3354 }
3355
3364 break; 3356 break;
3365 3357
3366 case BOW: 3358 case BOW:
3367 if (!check_weapon_power (who, op->last_eat)) 3359 if (!check_weapon_power (who, op->last_eat))
3368 { 3360 {
… …
3395 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO 3387 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO
3396 return 1; 3388 return 1;
3397 } 3389 }
3398 3390
3399 SET_FLAG (op, FLAG_APPLIED); 3391 SET_FLAG (op, FLAG_APPLIED);
3400 change_skill (who, skop, 0); 3392 who->change_skill (skop);
3401 3393
3402 if (who->contr) 3394 if (who->contr)
3403 { 3395 {
3404 who->contr->ranged_ob = op; 3396 who->contr->ranged_ob = op;
3405 3397
… …
3424 break; 3416 break;
3425 3417
3426 case BUILDER: 3418 case BUILDER:
3427 if (who->type == PLAYER) 3419 if (who->type == PLAYER)
3428 { 3420 {
3421 //TODO: wtf does this do? shouldn't this be managed automatically (slots?)
3429 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER) 3422 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER)
3430 unapply_special (who, who->contr->ranged_ob, 0); 3423 unapply_special (who, who->contr->ranged_ob, 0);
3431 3424
3432 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op)); 3425 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op));
3433 3426
… …
3659 * Handles player eating food that temporarily changes status (resistances, stats). 3652 * Handles player eating food that temporarily changes status (resistances, stats).
3660 * This used to call cast_change_attr(), but 3653 * This used to call cast_change_attr(), but
3661 * that doesn't work with the new spell code. Since we know what 3654 * that doesn't work with the new spell code. Since we know what
3662 * the food changes, just grab a force and use that instead. 3655 * the food changes, just grab a force and use that instead.
3663 */ 3656 */
3664
3665void 3657void
3666eat_special_food (object *who, object *food) 3658eat_special_food (object *who, object *food)
3667{ 3659{
3668 object *force; 3660 object *force;
3669 int i, did_one = 0; 3661 int i, did_one = 0;
3670 sint8 k;
3671 3662
3672 force = get_archetype (FORCE_NAME); 3663 force = get_archetype (FORCE_NAME);
3673 3664
3674 for (i = 0; i < NUM_STATS; i++) 3665 for (i = 0; i < NUM_STATS; i++)
3675 { 3666 if (sint8 k = food->stats.stat (i))
3676 k = get_attr_value (&food->stats, i);
3677 if (k)
3678 { 3667 {
3679 set_attr_value (&force->stats, i, k); 3668 force->stats.stat (i) = k;
3680 did_one = 1; 3669 did_one = 1;
3681 } 3670 }
3682 }
3683 3671
3684 /* check if we can protect the eater */ 3672 /* check if we can protect the eater */
3685 for (i = 0; i < NROFATTACKS; i++) 3673 for (i = 0; i < NROFATTACKS; i++)
3686 { 3674 {
3687 if (food->resist[i] > 0) 3675 if (food->resist[i] > 0)
… …
3880 */ 3868 */
3881 int i, j; 3869 int i, j;
3882 3870
3883 for (i = 0; i < NUM_STATS; i++) 3871 for (i = 0; i < NUM_STATS; i++)
3884 { 3872 {
3885 sint8 stat = get_attr_value (stats, i); 3873 int race_bonus = pl->arch->stats.stat (i);
3886 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i); 3874 sint8 stat = stats->stat (i) + ns->stat (i);
3887 3875
3888 stat += get_attr_value (ns, i);
3889 if (stat > 20 + race_bonus) 3876 if (stat > 20 + race_bonus)
3890 { 3877 {
3891 excess_stat++; 3878 excess_stat++;
3892 stat = 20 + race_bonus; 3879 stat = 20 + race_bonus;
3893 } 3880 }
3894 set_attr_value (stats, i, stat); 3881
3882 stats->stat (i) = stat;
3895 } 3883 }
3896 3884
3897 for (j = 0; excess_stat > 0 && j < 100; j++) 3885 for (j = 0; excess_stat > 0 && j < 100; j++)
3898 { /* try 100 times to assign excess stats */ 3886 { /* try 100 times to assign excess stats */
3899 int i = rndm (0, 6); 3887 int i = rndm (0, 6);
3900 int stat = get_attr_value (stats, i);
3901 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i);
3902 3888
3903 if (i == CHA) 3889 if (i == CHA)
3904 continue; /* exclude cha from this */ 3890 continue; /* exclude cha from this */
3891
3892 int stat = stats->stat (i);
3893 int race_bonus = pl->arch->stats.stat (i);
3905 if (stat < 20 + race_bonus) 3894 if (stat < 20 + race_bonus)
3906 { 3895 {
3907 change_attr_value (stats, i, 1); 3896 change_attr_value (stats, i, 1);
3908 excess_stat--; 3897 excess_stat--;
3909 } 3898 }
… …
3912 /* insert the randomitems from the change's treasurelist into 3901 /* insert the randomitems from the change's treasurelist into
3913 * the player ref: player.c 3902 * the player ref: player.c
3914 */ 3903 */
3915 if (change->randomitems != NULL) 3904 if (change->randomitems != NULL)
3916 give_initial_items (pl, change->randomitems); 3905 give_initial_items (pl, change->randomitems);
3917
3918 3906
3919 /* set up the face, for some races. */ 3907 /* set up the face, for some races. */
3920 3908
3921 /* first, look for the force object banning 3909 /* first, look for the force object banning
3922 * changing the face. Certain races never change face with class. 3910 * changing the face. Certain races never change face with class.
… …
3979 { 3967 {
3980 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3968 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked));
3981 return; 3969 return;
3982 } 3970 }
3983 /* check whether they are compatible or not */ 3971 /* check whether they are compatible or not */
3984 find = strstr (marked->slaying, transformer->arch->name); 3972 find = strstr (marked->slaying, transformer->arch->archname);
3985 if (!find || (*(find + strlen (transformer->arch->name)) != ':')) 3973 if (!find || (*(find + strlen (transformer->arch->archname)) != ':'))
3986 { 3974 {
3987 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3975 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked));
3988 return; 3976 return;
3989 } 3977 }
3990 find += strlen (transformer->arch->name) + 1; 3978 find += strlen (transformer->arch->archname) + 1;
3991 /* Item can be used, now find how many and what it yields */ 3979 /* Item can be used, now find how many and what it yields */
3992 if (isdigit (*(find))) 3980 if (isdigit (*(find)))
3993 { 3981 {
3994 yield = atoi (find); 3982 yield = atoi (find);
3995 if (yield < 1) 3983 if (yield < 1)

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines