ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/apply.C
(Generate patch)

Comparing deliantra/server/server/apply.C (file contents):
Revision 1.117 by elmex, Mon Jul 16 14:49:01 2007 UTC vs.
Revision 1.142 by root, Sun Apr 13 20:21:50 2008 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation, either version 3 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24#include <cmath> 24#include <cmath>
25 25
26#include <global.h> 26#include <global.h>
92 * Return value: 1 if money was destroyed, 0 if not. 92 * Return value: 1 if money was destroyed, 0 if not.
93 */ 93 */
94static int 94static int
95apply_id_altar (object *money, object *altar, object *pl) 95apply_id_altar (object *money, object *altar, object *pl)
96{ 96{
97 object *id, *marked; 97 dynbuf_text buf;
98 int success = 0;
99 98
100 if (pl == NULL || pl->type != PLAYER) 99 if (!pl || pl->type != PLAYER)
101 return 0; 100 return 0;
102 101
103 /* Check for MONEY type is a special hack - it prevents 'nothing needs 102 /* Check for MONEY type is a special hack - it prevents 'nothing needs
104 * identifying' from being printed out more than it needs to be. 103 * identifying' from being printed out more than it needs to be.
105 */ 104 */
106 if (!check_altar_sacrifice (altar, money) || money->type != MONEY) 105 if (!check_altar_sacrifice (altar, money) || money->type != MONEY)
107 return 0; 106 return 0;
108 107
109 marked = find_marked_object (pl);
110 /* if the player has a marked item, identify that if it needs to be 108 /* if the player has a marked item, identify that if it needs to be
111 * identified. IF it doesn't, then go through the player inventory. 109 * identified. If it doesn't, then go through the player inventory.
112 */ 110 */
111 if (object *marked = find_marked_object (pl))
113 if (marked && !QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked)) 112 if (!QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked))
114 { 113 {
115 if (operate_altar (altar, &money)) 114 if (operate_altar (altar, &money))
116 { 115 {
117 identify (marked); 116 identify (marked);
118 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (marked, pl)); 117
118 buf.printf ("You have %s.\n\n", long_desc (marked, pl));
119 if (marked->msg) 119 if (marked->msg)
120 { 120 buf << "The item has a story:\n\n" << marked->msg << "\n\n";
121 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 121
122 new_draw_info (NDI_UNIQUE, 0, pl, marked->msg); 122 return !money;
123 } 123 }
124 return money == NULL;
125 } 124 }
126 }
127 125
128 for (id = pl->inv; id; id = id->below) 126 for (object *id = pl->inv; id; id = id->below)
129 { 127 {
130 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id)) 128 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id))
131 { 129 {
132 if (operate_altar (altar, &money)) 130 if (operate_altar (altar, &money))
133 { 131 {
134 identify (id); 132 identify (id);
135 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (id, pl)); 133
134 buf.printf ("You have %s.\n\n", long_desc (id, pl));
136 if (id->msg) 135 if (id->msg)
137 { 136 buf << "The item has a story:\n\n" << id->msg << "\n\n";
138 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 137
139 new_draw_info (NDI_UNIQUE, 0, pl, id->msg);
140 }
141 success = 1;
142 /* If no more money, might as well quit now */ 138 /* If no more money, might as well quit now */
143 if (money == NULL || !check_altar_sacrifice (altar, money)) 139 if (!money || !check_altar_sacrifice (altar, money))
144 break; 140 break;
145 } 141 }
146 else 142 else
147 { 143 {
148 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n"); 144 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n");
149 break; 145 break;
150 } 146 }
151 } 147 }
152 } 148 }
153 if (!success) 149
154 new_draw_info (NDI_UNIQUE, 0, pl, "You have nothing that needs identifying"); 150 if (buf.empty ())
151 pl->failmsg ("You have nothing that needs identifying");
152 else
153 pl->contr->infobox (MSG_CHANNEL ("identify"), buf);
154
155 return money == NULL; 155 return !money;
156} 156}
157 157
158/** 158/**
159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops 159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops
160 * matching item. 160 * matching item.
195 195
196 floor = GET_MAP_OB (op->map, op->x, op->y); 196 floor = GET_MAP_OB (op->map, op->x, op->y);
197 197
198 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE) 198 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE)
199 { 199 {
200 if (op->type == PLAYER)
201 new_draw_info (NDI_UNIQUE, 0, op, "Gods prevent you from using this here, it's sacred ground!"); 200 op->failmsg ("Gods prevent you from using this here, it's sacred ground!");
201
202 CLEAR_FLAG (tmp, FLAG_APPLIED); 202 CLEAR_FLAG (tmp, FLAG_APPLIED);
203 return 0; 203 return 0;
204 } 204 }
205 205
206 if (op->type == PLAYER) 206 if (op->type == PLAYER)
232 232
233 if (depl) 233 if (depl)
234 { 234 {
235 for (i = 0; i < NUM_STATS; i++) 235 for (i = 0; i < NUM_STATS; i++)
236 if (depl->stats.stat (i)) 236 if (depl->stats.stat (i))
237 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]); 237 op->statusmsg (restore_msg[i]);
238 238
239 depl->destroy (); 239 depl->destroy ();
240 op->update_stats (); 240 op->update_stats ();
241 } 241 }
242 else 242 else
243 new_draw_info (NDI_UNIQUE, 0, op, "You potion had no effect."); 243 op->statusmsg ("Your potion had no effect.");
244 244
245 decrease_ob (tmp); 245 decrease_ob (tmp);
246 return 1; 246 return 1;
247 } 247 }
248 248
249 /* improvement potion - only for players */ 249 /* improvement potion - only for players */
250 if (op->type == PLAYER && tmp->attacktype & AT_GODPOWER) 250 if (op->type == PLAYER && (tmp->attacktype & AT_GODPOWER))
251 { 251 {
252 for (i = 1; i < MIN (11, op->level); i++) 252 for (i = 1; i < MIN (11, op->level); i++)
253 { 253 {
254 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 254 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
255 { 255 {
256 if (op->contr->levhp[i] != 1) 256 if (op->contr->levhp[i] != 1)
257 { 257 {
258 op->contr->levhp[i] = 1; 258 op->contr->levhp[i] = 1;
259 break; 259 break;
260 } 260 }
261
261 if (op->contr->levsp[i] != 1) 262 if (op->contr->levsp[i] != 1)
262 { 263 {
263 op->contr->levsp[i] = 1; 264 op->contr->levsp[i] = 1;
264 break; 265 break;
265 } 266 }
267
266 if (op->contr->levgrace[i] != 1) 268 if (op->contr->levgrace[i] != 1)
267 { 269 {
268 op->contr->levgrace[i] = 1; 270 op->contr->levgrace[i] = 1;
269 break; 271 break;
270 } 272 }
274 if (op->contr->levhp[i] < 9) 276 if (op->contr->levhp[i] < 9)
275 { 277 {
276 op->contr->levhp[i] = 9; 278 op->contr->levhp[i] = 9;
277 break; 279 break;
278 } 280 }
281
279 if (op->contr->levsp[i] < 6) 282 if (op->contr->levsp[i] < 6)
280 { 283 {
281 op->contr->levsp[i] = 6; 284 op->contr->levsp[i] = 6;
282 break; 285 break;
283 } 286 }
287
284 if (op->contr->levgrace[i] < 3) 288 if (op->contr->levgrace[i] < 3)
285 { 289 {
286 op->contr->levgrace[i] = 3; 290 op->contr->levgrace[i] = 3;
287 break; 291 break;
288 } 292 }
296 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)) 300 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))
297 { 301 {
298 if (got_one) 302 if (got_one)
299 { 303 {
300 op->update_stats (); 304 op->update_stats ();
301 new_draw_info (NDI_UNIQUE, 0, op, "The Gods smile upon you and remake you"); 305 op->statusmsg ("The Gods smile upon you and remake you "
302 new_draw_info (NDI_UNIQUE, 0, op, "a little more in their image."); 306 "a little more in their image. "
303 new_draw_info (NDI_UNIQUE, 0, op, "You feel a little more perfect."); 307 "You feel a little more perfect.", NDI_GREEN);
304 } 308 }
305 else 309 else
306 new_draw_info (NDI_UNIQUE, 0, op, "The potion had no effect - you are already perfect"); 310 op->statusmsg ("The potion had no effect - you are already perfect.");
307 } 311 }
308 else 312 else
309 { /* cursed potion */ 313 { /* cursed potion */
310 if (got_one) 314 if (got_one)
311 { 315 {
312 op->update_stats (); 316 op->update_stats ();
313 new_draw_info (NDI_UNIQUE, 0, op, "The Gods are angry and punish you."); 317 op->failmsg ("The Gods are angry and punish you.");
314 } 318 }
315 else 319 else
316 new_draw_info (NDI_UNIQUE, 0, op, "You are fortunate that you are so pathetic."); 320 op->statusmsg ("You are fortunate that you are so pathetic.", NDI_DK_ORANGE);
317 } 321 }
318 322
319 decrease_ob (tmp); 323 decrease_ob (tmp);
320 return 1; 324 return 1;
321 } 325 }
330 { 334 {
331 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 335 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
332 { 336 {
333 object *fball; 337 object *fball;
334 338
335 new_draw_info (NDI_UNIQUE, 0, op, "Yech! Your lungs are on fire!"); 339 op->failmsg ("Yech! Your lungs are on fire!");
340
336 /* Explodes a fireball centered at player */ 341 /* Explodes a fireball centered at player */
337 fball = get_archetype (EXPLODING_FIREBALL); 342 fball = get_archetype (EXPLODING_FIREBALL);
338 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1; 343 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1;
339 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2; 344 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2;
340 fball->x = op->x; 345 fball->x = op->x;
343 } 348 }
344 else 349 else
345 cast_spell (op, tmp, op->facing, tmp->inv, NULL); 350 cast_spell (op, tmp, op->facing, tmp->inv, NULL);
346 351
347 decrease_ob (tmp); 352 decrease_ob (tmp);
353
348 /* if youre dead, no point in doing this... */ 354 /* if youre dead, no point in doing this... */
349 if (!QUERY_FLAG (op, FLAG_REMOVED)) 355 if (!QUERY_FLAG (op, FLAG_REMOVED))
350 op->update_stats (); 356 op->update_stats ();
357
351 return 1; 358 return 1;
352 } 359 }
353 360
354 /* Deal with protection potions */ 361 /* Deal with protection potions */
355 force = NULL; 362 force = NULL;
357 { 364 {
358 if (tmp->resist[i]) 365 if (tmp->resist[i])
359 { 366 {
360 if (!force) 367 if (!force)
361 force = get_archetype (FORCE_NAME); 368 force = get_archetype (FORCE_NAME);
369
362 memcpy (force->resist, tmp->resist, sizeof (tmp->resist)); 370 memcpy (force->resist, tmp->resist, sizeof (tmp->resist));
363 force->type = POTION_EFFECT; 371 force->type = POTION_EFFECT;
364 break; /* Only need to find one protection since we copy entire batch */ 372 break; /* Only need to find one protection since we copy entire batch */
365 } 373 }
366 } 374 }
375
367 /* This is a protection potion */ 376 /* This is a protection potion */
368 if (force) 377 if (force)
369 { 378 {
370 /* cursed items last longer */ 379 /* cursed items last longer */
371 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 380 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
390 { /* only for players */ 399 { /* only for players */
391 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0) 400 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0)
392 CLEAR_FLAG (tmp, FLAG_APPLIED); 401 CLEAR_FLAG (tmp, FLAG_APPLIED);
393 else 402 else
394 SET_FLAG (tmp, FLAG_APPLIED); 403 SET_FLAG (tmp, FLAG_APPLIED);
404
395 if (!change_abil (op, tmp)) 405 if (!change_abil (op, tmp))
396 new_draw_info (NDI_UNIQUE, 0, op, "Nothing happened."); 406 op->statusmsg ("Nothing happened.");
397 } 407 }
398 408
399 /* CLEAR_FLAG is so that if the character has other potions 409 /* CLEAR_FLAG is so that if the character has other potions
400 * that were grouped with the one consumed, his 410 * that were grouped with the one consumed, his
401 * stat will not be raised by them. fix_player just clears 411 * stat will not be raised by them. fix_player just clears
417static int 427static int
418check_item (object *op, const char *item) 428check_item (object *op, const char *item)
419{ 429{
420 int count = 0; 430 int count = 0;
421 431
422 432 if (!item)
423 if (item == NULL)
424 return 0; 433 return 0;
425 434
426 op = op->below; 435 for (op = op->below; op; op = op->below)
427 while (op != NULL)
428 { 436 {
429 if (strcmp (op->arch->archname, item) == 0) 437 if (strcmp (op->arch->archname, item) == 0)
430 { 438 {
431 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED) 439 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED)
432 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID)) 440 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID))
435 count++; 443 count++;
436 else 444 else
437 count += op->nrof; 445 count += op->nrof;
438 } 446 }
439 } 447 }
440
441 op = op->below;
442 } 448 }
443 449
444 return count; 450 return count;
445} 451}
446 452
456 object *prev; 462 object *prev;
457 463
458 prev = op; 464 prev = op;
459 op = op->below; 465 op = op->below;
460 466
461 while (op != NULL) 467 while (op)
462 { 468 {
463 if (strcmp (op->arch->archname, item) == 0) 469 if (strcmp (op->arch->archname, item) == 0)
464 { 470 {
465 if (op->nrof >= nrof) 471 if (op->nrof >= nrof)
466 { 472 {
470 else 476 else
471 { 477 {
472 decrease_ob_nr (op, op->nrof); 478 decrease_ob_nr (op, op->nrof);
473 nrof -= op->nrof; 479 nrof -= op->nrof;
474 } 480 }
481
475 op = prev; 482 op = prev;
476 } 483 }
484
477 prev = op; 485 prev = op;
478 op = op->below; 486 op = op->below;
479 } 487 }
480} 488}
481 489
487 * we return 1 (true) if the player can use the weapon. 495 * we return 1 (true) if the player can use the weapon.
488 */ 496 */
489static int 497static int
490check_weapon_power (const object *who, int improvs) 498check_weapon_power (const object *who, int improvs)
491{ 499{
492
493/* Old code is below (commented out). Basically, since weapons are the only 500/* Old code is below (commented out). Basically, since weapons are the only
494 * object players really have any control to improve, it's a bit harsh to 501 * object players really have any control to improve, it's a bit harsh to
495 * require high level in some combat skill, so we just use overall level. 502 * require high level in some combat skill, so we just use overall level.
496 */ 503 */
497#if 1 504#if 1
538static int 545static int
539check_sacrifice (object *op, const object *improver) 546check_sacrifice (object *op, const object *improver)
540{ 547{
541 int count = 0; 548 int count = 0;
542 549
543 if (improver->slaying != NULL) 550 if (improver->slaying)
544 { 551 {
545 count = check_item (op, improver->slaying); 552 count = check_item (op, improver->slaying);
546 if (count < 1) 553 if (count < 1)
547 { 554 {
548 char buf[200];
549
550 sprintf (buf, "The gods want more %ss", &improver->slaying); 555 op->failmsg (format ("The gods want more %ss", &improver->slaying));
551 new_draw_info (NDI_UNIQUE, 0, op, buf);
552 return 0; 556 return 0;
553 } 557 }
554 } 558 }
555 else 559 else
556 count = 1; 560 count = 1;
559} 563}
560 564
561/** 565/**
562 * Actually improves the weapon, and tells user. 566 * Actually improves the weapon, and tells user.
563 */ 567 */
564int 568static int
565improve_weapon_stat (object *op, object *improver, object *weapon, signed char *stat, int sacrifice_count, const char *statname) 569improve_weapon_stat (object *op, object *improver, object *weapon, sint8 &stat, int sacrifice_count, const char *statname)
566{ 570{
567
568 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
569 *stat += sacrifice_count; 571 stat += sacrifice_count;
570 weapon->last_eat++; 572 weapon->last_eat++;
571 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon's bonus to %s improved by %d", statname, sacrifice_count);
572 decrease_ob (improver); 573 decrease_ob (improver);
573 574
574 /* So it updates the players stats and the window */ 575 /* So it updates the players stats and the window */
575 op->update_stats (); 576 op->update_stats ();
577
578 op->statusmsg (format (
579 "Your sacrifice was accepted.\n"
580 "Weapon's bonus to %s improved by %d.",
581 statname, sacrifice_count
582 ));
583
576 return 1; 584 return 1;
577} 585}
578 586
579/* Types of improvements, hidden in the sp field. */ 587/* Types of improvements, hidden in the sp field. */
580#define IMPROVE_PREPARE 1 588#define IMPROVE_PREPARE 1
599 int sacrifice_count, i; 607 int sacrifice_count, i;
600 char buf[MAX_BUF]; 608 char buf[MAX_BUF];
601 609
602 if (weapon->level != 0) 610 if (weapon->level != 0)
603 { 611 {
604 new_draw_info (NDI_UNIQUE, 0, op, "Weapon already prepared."); 612 op->failmsg ("Weapon is already prepared!");
605 return 0; 613 return 0;
606 } 614 }
607 615
608 for (i = 0; i < NROFATTACKS; i++) 616 for (i = 0; i < NROFATTACKS; i++)
609 if (weapon->resist[i]) 617 if (weapon->resist[i])
615 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */ 623 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */
616 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */ 624 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */
617 weapon->stats.exp || /* speed */ 625 weapon->stats.exp || /* speed */
618 weapon->stats.ac) /* AC - only taifu's I think */ 626 weapon->stats.ac) /* AC - only taifu's I think */
619 { 627 {
620 new_draw_info (NDI_UNIQUE, 0, op, "Cannot prepare magic weapons."); 628 op->failmsg ("You cannot prepare magic weapons. "
629 "H<A weapon is considered magical if it changes regeneration, "
630 "speed or ac.>");
621 return 0; 631 return 0;
622 } 632 }
623 633
624 sacrifice_count = check_sacrifice (op, improver); 634 sacrifice_count = check_sacrifice (op, improver);
625 if (sacrifice_count <= 0) 635 if (sacrifice_count <= 0)
626 return 0; 636 return 0;
627 637
628 weapon->level = isqrt (sacrifice_count); 638 weapon->level = isqrt (sacrifice_count);
629 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
630 eat_item (op, improver->slaying, sacrifice_count); 639 eat_item (op, improver->slaying, sacrifice_count);
631 640
632 new_draw_info_format (NDI_UNIQUE, 0, op, "Your *%s may be improved %d times.", &weapon->name, weapon->level); 641 op->statusmsg (format (
642 "Your sacrifice was accepted."
643 "Your *%s may be improved %d times.",
644 &weapon->name, weapon->level
645 ));
633 646
634 sprintf (buf, "%s's %s", &op->name, &weapon->name); 647 sprintf (buf, "%s's %s", &op->name, &weapon->name);
635 weapon->name = weapon->name_pl = buf; 648 weapon->name = weapon->name_pl = buf;
636 weapon->nrof = 0; /* prevents preparing n weapons in the same 649 weapon->nrof = 0; /* prevents preparing n weapons in the same
637 slot at once! */ 650 slot at once! */
656improve_weapon (object *op, object *improver, object *weapon) 669improve_weapon (object *op, object *improver, object *weapon)
657{ 670{
658 int sacrifice_count, sacrifice_needed = 0; 671 int sacrifice_count, sacrifice_needed = 0;
659 672
660 if (improver->stats.sp == IMPROVE_PREPARE) 673 if (improver->stats.sp == IMPROVE_PREPARE)
661 {
662 return prepare_weapon (op, improver, weapon); 674 return prepare_weapon (op, improver, weapon);
663 } 675
664 if (weapon->level == 0) 676 if (weapon->level == 0)
665 { 677 {
666 new_draw_info (NDI_UNIQUE, 0, op, "This weapon has not been prepared."); 678 op->failmsg ("This weapon has not been prepared. H<You first ahve to prepare a weapon with a prepare weapon scroll.>");
667 return 0; 679 return 0;
668 } 680 }
681
669 if (weapon->level == weapon->last_eat && weapon->item_power >= 100) 682 if (weapon->level == weapon->last_eat && weapon->item_power >= 100)
670 { 683 {
671 new_draw_info (NDI_UNIQUE, 0, op, "This weapon cannot be improved any more."); 684 op->failmsg ("This weapon cannot be improved any more.");
672 return 0; 685 return 0;
673 } 686 }
687
674 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1)) 688 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1))
675 { 689 {
676 new_draw_info (NDI_UNIQUE, 0, op, "Improving the weapon will make it too"); 690 op->failmsg ("Improving the weapon will make it too "
677 new_draw_info (NDI_UNIQUE, 0, op, "powerful for you to use. Unready it if you"); 691 "powerful for you to use. Unready it if you "
678 new_draw_info (NDI_UNIQUE, 0, op, "really want to improve it."); 692 "really want to improve it.");
679 return 0; 693 return 0;
680 } 694 }
695
681 /* This just increases damage by 5 points, no matter what. No sacrifice 696 /* This just increases damage by 5 points, no matter what. No sacrifice
682 * is needed. Since stats.dam is now a 16 bit value and not 8 bit, 697 * is needed. Since stats.dam is now a 16 bit value and not 8 bit,
683 * don't put any maximum value on damage - the limit is how much the 698 * don't put any maximum value on damage - the limit is how much the
684 * weapon can be improved. 699 * weapon can be improved.
685 */ 700 */
686 if (improver->stats.sp == IMPROVE_DAMAGE) 701 if (improver->stats.sp == IMPROVE_DAMAGE)
687 { 702 {
688 weapon->stats.dam += 5; 703 weapon->stats.dam += 5;
689 weapon->weight += 5000; /* 5 KG's */ 704 weapon->weight += 5000; /* 5 KG's */
690 new_draw_info_format (NDI_UNIQUE, 0, op, "Damage has been increased by 5 to %d", weapon->stats.dam); 705 op->statusmsg (format ("Damage has been increased by 5 to %d.", weapon->stats.dam));
691 weapon->last_eat++; 706 weapon->last_eat++;
692 707
693 weapon->item_power++; 708 weapon->item_power++;
694 decrease_ob (improver); 709 decrease_ob (improver);
695 return 1; 710 return 1;
696 } 711 }
712
697 if (improver->stats.sp == IMPROVE_WEIGHT) 713 if (improver->stats.sp == IMPROVE_WEIGHT)
698 { 714 {
699 /* Reduce weight by 20% */ 715 /* Reduce weight by 20% */
700 weapon->weight = (weapon->weight * 8) / 10; 716 weapon->weight = (weapon->weight * 8) / 10;
701 if (weapon->weight < 1) 717 if (weapon->weight < 1)
702 weapon->weight = 1; 718 weapon->weight = 1;
719
703 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon weight reduced to %6.1f kg", (float) weapon->weight / 1000.0); 720 op->statusmsg (format ("Weapon weight reduced to %6.1fkg.", (float) weapon->weight / 1000.0));
704 weapon->last_eat++; 721 weapon->last_eat++;
705 weapon->item_power++; 722 weapon->item_power++;
706 decrease_ob (improver); 723 decrease_ob (improver);
707 return 1; 724 return 1;
708 } 725 }
709 if (improver->stats.sp == IMPROVE_ENCHANT) 726 if (improver->stats.sp == IMPROVE_ENCHANT)
710 { 727 {
711 weapon->magic++; 728 weapon->magic++;
712 weapon->last_eat++; 729 weapon->last_eat++;
713 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon magic increased to %d", weapon->magic); 730 op->statusmsg (format ("Weapon magic increased to %d.", weapon->magic));
714 decrease_ob (improver); 731 decrease_ob (improver);
715 weapon->item_power++; 732 weapon->item_power++;
716 return 1; 733 return 1;
717 } 734 }
718 735
724 sacrifice_needed *= 2; 741 sacrifice_needed *= 2;
725 742
726 sacrifice_count = check_sacrifice (op, improver); 743 sacrifice_count = check_sacrifice (op, improver);
727 if (sacrifice_count < sacrifice_needed) 744 if (sacrifice_count < sacrifice_needed)
728 { 745 {
729 new_draw_info_format (NDI_UNIQUE, 0, op, "You need at least %d %s", sacrifice_needed, &improver->slaying); 746 op->failmsg (format ("You need at least %d %s.", sacrifice_needed, &improver->slaying));
730 return 0; 747 return 0;
731 } 748 }
749
732 eat_item (op, improver->slaying, sacrifice_needed); 750 eat_item (op, improver->slaying, sacrifice_needed);
733 weapon->item_power++; 751 weapon->item_power++;
734 752
735 switch (improver->stats.sp) 753 switch (improver->stats.sp)
736 { 754 {
737 case IMPROVE_STR:
738 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Str), 1, "strength"); 755 case IMPROVE_STR: return improve_weapon_stat (op, improver, weapon, weapon->stats.Str, 1, "strength");
739 case IMPROVE_DEX:
740 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Dex), 1, "dexterity"); 756 case IMPROVE_DEX: return improve_weapon_stat (op, improver, weapon, weapon->stats.Dex, 1, "dexterity");
741 case IMPROVE_CON:
742 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Con), 1, "constitution"); 757 case IMPROVE_CON: return improve_weapon_stat (op, improver, weapon, weapon->stats.Con, 1, "constitution");
743 case IMPROVE_WIS:
744 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Wis), 1, "wisdom"); 758 case IMPROVE_WIS: return improve_weapon_stat (op, improver, weapon, weapon->stats.Wis, 1, "wisdom");
745 case IMPROVE_CHA:
746 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Cha), 1, "charisma"); 759 case IMPROVE_CHA: return improve_weapon_stat (op, improver, weapon, weapon->stats.Cha, 1, "charisma");
747 case IMPROVE_INT:
748 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Int), 1, "intelligence"); 760 case IMPROVE_INT: return improve_weapon_stat (op, improver, weapon, weapon->stats.Int, 1, "intelligence");
749 case IMPROVE_POW:
750 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Pow), 1, "power"); 761 case IMPROVE_POW: return improve_weapon_stat (op, improver, weapon, weapon->stats.Pow, 1, "power");
751 default: 762 default:
752 new_draw_info (NDI_UNIQUE, 0, op, "Unknown improvement type."); 763 op->failmsg ("Unknown improvement type.");
753 } 764 }
765
754 LOG (llevError, "improve_weapon: Got to end of function\n"); 766 LOG (llevError, "improve_weapon: Got to end of function\n");
755 return 0; 767 return 0;
756} 768}
757 769
758/** 770/**
768 if (op->type != PLAYER) 780 if (op->type != PLAYER)
769 return 0; 781 return 0;
770 782
771 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 783 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC))
772 { 784 {
773 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 785 op->failmsg ("Something blocks the magic of the scroll!");
774 return 0; 786 return 0;
775 } 787 }
776 788
777 otmp = find_marked_object (op); 789 otmp = find_marked_object (op);
778 if (!otmp) 790 if (!otmp)
779 { 791 {
780 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark a weapon object."); 792 op->failmsg ("You need to mark a weapon object. H<Use the mark command or the mark option from the item popup menu.>");
781 return 0; 793 return 0;
782 } 794 }
783 795
784 if (otmp->type != WEAPON && otmp->type != BOW) 796 if (otmp->type != WEAPON && otmp->type != BOW)
785 { 797 {
786 new_draw_info (NDI_UNIQUE, 0, op, "Marked item is not a weapon or bow"); 798 op->failmsg ("Marked item is not a weapon or bow!");
787 return 0; 799 return 0;
788 } 800 }
789 801
790 new_draw_info (NDI_UNIQUE, 0, op, "Applied weapon builder."); 802 op->statusmsg ("Applied weapon builder.");
803
791 improve_weapon (op, tmp, otmp); 804 improve_weapon (op, tmp, otmp);
792 esrv_send_item (op, otmp); 805 esrv_send_item (op, otmp);
793 return 1; 806 return 1;
794} 807}
795 808
820{ 833{
821 object *tmp; 834 object *tmp;
822 835
823 if (armour->magic >= settings.armor_max_enchant) 836 if (armour->magic >= settings.armor_max_enchant)
824 { 837 {
825 new_draw_info (NDI_UNIQUE, 0, op, "This armour can not be enchanted any further."); 838 op->failmsg ("This armour can not be enchanted any further!");
826 return 0; 839 return 0;
827 } 840 }
841
828 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight, 842 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight,
829 * etc), so take the easy way out and don't worry about it. 843 * etc), so take the easy way out and don't worry about it.
830 * Note - maybe add scrolls which make the random artifact versions (eg, armour 844 * Note - maybe add scrolls which make the random artifact versions (eg, armour
831 * of gnarg and what not?) 845 * of gnarg and what not?)
832 */ 846 */
833 if (armour->title) 847 if (armour->title)
834 { 848 {
835 new_draw_info (NDI_UNIQUE, 0, op, "This armour will not accept further enchantment."); 849 op->failmsg ("This armour will not accept further enchantment.");
836 return 0; 850 return 0;
837 } 851 }
838 852
839 /* Split objects if needed. Can't insert tmp until the 853 /* Split objects if needed. Can't insert tmp until the
840 * end of this function - otherwise it will just re-merge. 854 * end of this function - otherwise it will just re-merge.
841 */ 855 */
842 if (armour->nrof > 1) 856 if (armour->nrof > 1)
843 tmp = get_split_ob (armour, armour->nrof - 1); 857 tmp = get_split_ob (armour, armour->nrof - 1);
844 else 858 else
890 { 904 {
891 esrv_send_item (op, armour); 905 esrv_send_item (op, armour);
892 if (QUERY_FLAG (armour, FLAG_APPLIED)) 906 if (QUERY_FLAG (armour, FLAG_APPLIED))
893 op->update_stats (); 907 op->update_stats ();
894 } 908 }
909
895 decrease_ob (improver); 910 decrease_ob (improver);
911
896 if (tmp) 912 if (tmp)
897 { 913 {
898 insert_ob_in_ob (tmp, op); 914 insert_ob_in_ob (tmp, op);
899 esrv_send_item (op, tmp); 915 esrv_send_item (op, tmp);
900 } 916 }
917
901 return 1; 918 return 1;
902} 919}
903
904 920
905/* 921/*
906 * convert_item() returns 1 if anything was converted, 0 if the item was not 922 * convert_item() returns 1 if anything was converted, 0 if the item was not
907 * what the converter wants, -1 if the converter is broken. 923 * what the converter wants, -1 if the converter is broken.
908 */ 924 *
909#define CONV_FROM(xyz) xyz->slaying
910#define CONV_TO(xyz) xyz->other_arch
911#define CONV_NR(xyz) xyz->stats.sp
912#define CONV_NEED(xyz) xyz->stats.food
913
914/* Takes one items and makes another. 925 * Takes one type of items and makes another.
915 * converter is the object that is doing the conversion. 926 * converter is the object that is doing the conversion.
916 * item is the object that triggered the converter - if it is not 927 * item is the object that triggered the converter - if it is not
917 * what the converter wants, this will not do anything. 928 * what the converter wants, this will not do anything.
918 */ 929 */
919int 930static int
920convert_item (object *item, object *converter) 931convert_item (object *item, object *converter)
921{ 932{
922 int nr = 0;
923 uint32 price_in; 933 sint64 nr, price_in;
934
935 if (item->flag [FLAG_UNPAID])
936 return 0;
937
938 shstr conv_from = converter->slaying;
939 archetype *conv_to = converter->other_arch;
940 sint64 need = converter->stats.food;
941 sint64 give = converter->stats.sp;
924 942
925 /* We make some assumptions - we assume if it takes money as it type, 943 /* We make some assumptions - we assume if it takes money as it type,
926 * it wants some amount. We don't make change (ie, if something costs 944 * it wants some amount. We don't make change (ie, if something costs
927 * 3 gp and player drops a platinum, tough luck) 945 * 3 gp and player drops a platinum, tough luck)
928 */ 946 */
929 if (!strcmp (CONV_FROM (converter), "money")) 947 if (conv_from == shstr_money)
930 { 948 {
931 int cost;
932
933 if (item->type != MONEY) 949 if (item->type != MONEY)
934 return 0; 950 return 0;
935 951
936 nr = (item->nrof * item->value) / CONV_NEED (converter); 952 nr = sint64 (item->nrof) * item->value / need;
937 if (!nr) 953 if (!nr)
938 return 0; 954 return 0;
939 cost = nr * CONV_NEED (converter) / item->value; 955
940 /* take into account rounding errors */ 956 converter->play_sound (sound_find ("shop_buy"));
941 if (nr * CONV_NEED (converter) % item->value) 957
942 cost++; 958 sint64 cost = (nr * need + item->value - 1) / item->value;
959
943 decrease_ob_nr (item, cost); 960 decrease_ob_nr (item, cost);
944 961
945 price_in = cost * item->value; 962 price_in = cost * item->value;
946 } 963 }
947 else 964 else
948 { 965 {
949 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->archname || 966 if (item->type == PLAYER
950 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof)) 967 || conv_from != item->arch->archname
968 || (need && need > (uint16) item->nrof))
951 return 0; 969 return 0;
952 970
953 if (CONV_NEED (converter)) 971 converter->play_sound (sound_find ("convert_item"));
972
973 if (need)
954 { 974 {
955 nr = item->nrof / CONV_NEED (converter); 975 nr = sint64 (item->nrof) / need;
956 decrease_ob_nr (item, nr * CONV_NEED (converter)); 976 decrease_ob_nr (item, nr * need);
957 price_in = nr * CONV_NEED (converter) * item->value; 977 price_in = nr * need * item->value;
958 } 978 }
959 else 979 else
960 { 980 {
961 price_in = item->value; 981 price_in = item->value;
962 item->destroy (); 982 item->destroy ();
963 } 983 }
964 } 984 }
965 985
966 if (converter->inv != NULL) 986 if (converter->inv)
967 { 987 {
968 object *ob; 988 object *ob;
969 int i; 989 int i;
970 object *ob_to_copy; 990 object *ob_to_copy;
971 991
972 /* select random object from inventory to copy */ 992 /* select random object from inventory to copy */
973 ob_to_copy = converter->inv; 993 ob_to_copy = converter->inv;
974 for (ob = converter->inv->below, i = 1; ob != NULL; ob = ob->below, i++) 994 for (ob = converter->inv->below, i = 1; ob; ob = ob->below, i++)
975 {
976 if (rndm (0, i) == 0) 995 if (rndm (0, i) == 0)
977 {
978 ob_to_copy = ob; 996 ob_to_copy = ob;
979 } 997
980 }
981 item = object_create_clone (ob_to_copy); 998 item = object_create_clone (ob_to_copy);
982 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE); 999 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE);
983 unflag_inv (item, FLAG_IS_A_TEMPLATE); 1000 unflag_inv (item, FLAG_IS_A_TEMPLATE);
984 } 1001 }
985 else 1002 else
986 { 1003 {
987 if (converter->other_arch == NULL) 1004 if (!conv_to)
988 { 1005 {
989 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n", 1006 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n",
990 &converter->name, &converter->map->path, converter->x, converter->y); 1007 &converter->name, &converter->map->path, converter->x, converter->y);
991 return -1; 1008 return -1;
992 } 1009 }
993 1010
994 item = object_create_arch (converter->other_arch); 1011 item = object_create_arch (conv_to);
995 fix_generated_item (item, converter, 0, 0, GT_MINIMAL); 1012 fix_generated_item (item, converter, 0, 0, GT_MINIMAL);
996 } 1013 }
997 1014
998 if (CONV_NR (converter)) 1015 if (give)
999 item->nrof = CONV_NR (converter); 1016 item->nrof = give;
1017
1000 if (nr) 1018 if (nr)
1001 item->nrof *= nr; 1019 item->nrof *= nr;
1020
1002 if (is_in_shop (converter)) 1021 if (is_in_shop (converter))
1003 SET_FLAG (item, FLAG_UNPAID); 1022 SET_FLAG (item, FLAG_UNPAID);
1004 else if (price_in < item->nrof * item->value) 1023 else if (price_in < sint64 (item->nrof) * item->value)
1005 { 1024 {
1006 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n", 1025 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n",
1007 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name); 1026 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name);
1008
1009 /** 1027 /**
1010 * elmex: we are going to let the game continue, as the mapcreator 1028 * elmex: we are going to let the game continue, as the mapcreator
1011 * probably had something in mind when doing this 1029 * hopefully had something in mind when doing this.
1012 */ 1030 */
1013 } 1031 }
1032
1033 SET_FLAG (item, FLAG_IDENTIFIED);
1014 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y); 1034 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y);
1015 return 1; 1035 return 1;
1016} 1036}
1017 1037
1018/** 1038/**
1035 1055
1036 op->contr->last_used = 0; 1056 op->contr->last_used = 0;
1037 1057
1038 if (sack->env && sack->env != op) 1058 if (sack->env && sack->env != op)
1039 { 1059 {
1040 new_draw_info (NDI_UNIQUE, 0, op, "You must put it onto the floor or into your inventory first."); 1060 op->failmsg ("You must put it onto the floor or into your inventory first.");
1041 return 1; 1061 return 1;
1042 } 1062 }
1043 1063
1044 // already applied == open on ground, or open in inv, or active in inv 1064 // already applied == open on ground, or open in inv, or active in inv
1045 if (sack->flag [FLAG_APPLIED]) 1065 if (sack->flag [FLAG_APPLIED])
1051 return 1; 1071 return 1;
1052 } 1072 }
1053 else if (!sack->env) 1073 else if (!sack->env)
1054 { 1074 {
1055 // active, but not ours: some other player has opened it 1075 // active, but not ours: some other player has opened it
1056 new_draw_info_format (NDI_UNIQUE, 0, op, "%s is already occupied.", query_name (sack)); 1076 op->failmsg (format ("Somebody else is using the %s already.", query_name (sack)));
1057 return 1; 1077 return 1;
1058 } 1078 }
1059 1079
1060 // fall through to opening it (active in inv) 1080 // fall through to opening it (active in inv)
1061 } 1081 }
1063 { 1083 {
1064 // it is in our env, so activate it, do not open yet 1084 // it is in our env, so activate it, do not open yet
1065 op->close_container (); 1085 op->close_container ();
1066 sack->flag [FLAG_APPLIED] = 1; 1086 sack->flag [FLAG_APPLIED] = 1;
1067 esrv_update_item (UPD_FLAGS, op, sack); 1087 esrv_update_item (UPD_FLAGS, op, sack);
1068 new_draw_info_format (NDI_UNIQUE, 0, op, "You ready %s.", query_name (sack)); 1088 op->statusmsg (format ("You ready %s.", query_name (sack)));
1069 return 1; 1089 return 1;
1070 } 1090 }
1071 1091
1072 // it's locked? 1092 // it's locked?
1073 if (sack->slaying) 1093 if (sack->slaying)
1074 { 1094 {
1075 if (object *tmp = find_key (op, op, sack)) 1095 if (object *tmp = find_key (op, op, sack))
1076 new_draw_info_format (NDI_UNIQUE, 0, op, "You unlock %s with %s.", query_name (sack), query_name (tmp)); 1096 op->statusmsg (format ("You unlock %s with %s.", query_name (sack), query_name (tmp)));
1077 else 1097 else
1078 { 1098 {
1079 new_draw_info_format (NDI_UNIQUE, 0, op, "You don't have the key to unlock %s.", query_name (sack)); 1099 op->statusmsg (format ("You don't have the key to unlock %s.", query_name (sack)));
1080 return 1; 1100 return 1;
1081 } 1101 }
1082 } 1102 }
1083 1103
1084 op->open_container (sack); 1104 op->open_container (sack);
1103 * with an altar. We call it a Potion - altars are stationary - it 1123 * with an altar. We call it a Potion - altars are stationary - it
1104 * is up to map designers to use them properly. 1124 * is up to map designers to use them properly.
1105 */ 1125 */
1106 if (altar->inv && altar->inv->type == SPELL) 1126 if (altar->inv && altar->inv->type == SPELL)
1107 { 1127 {
1108 new_draw_info_format (NDI_BLACK, 0, originator, "The altar casts %s.", &altar->inv->name); 1128 originator->statusmsg (format ("The altar casts %s.", &altar->inv->name));
1109 cast_spell (originator, altar, 0, altar->inv, NULL); 1129 cast_spell (originator, altar, 0, altar->inv, NULL);
1110 /* If it is connected, push the button. Fixes some problems with 1130 /* If it is connected, push the button. Fixes some problems with
1111 * old maps. 1131 * old maps.
1112 */ 1132 */
1113 1133
1114/* push_button (altar);*/ 1134/* push_button (altar);*/
1115 } 1135 }
1139 double opinion; 1159 double opinion;
1140 object *tmp, *next; 1160 object *tmp, *next;
1141 1161
1142 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */ 1162 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */
1143 1163
1164 bool has_unpaid = false;
1165
1166 // quite inefficient to do this here twice, but the api doesn'T lend itself to
1167 // a quick and small change :(
1168 for (object::depth_iterator item = op->begin (); item != op->end (); ++item)
1169 if (item->flag [FLAG_UNPAID])
1170 {
1171 has_unpaid = true;
1172 break;
1173 }
1174
1144 if (op->type != PLAYER) 1175 if (op->type != PLAYER)
1145 { 1176 {
1146 /* Remove all the unpaid objects that may be carried here. 1177 /* Remove all the unpaid objects that may be carried here.
1147 * This could be pets or monsters that are somehow in 1178 * This could be pets or monsters that are somehow in
1148 * the shop. 1179 * the shop.
1174 /* unpaid objects, or non living objects, can't transfer by 1205 /* unpaid objects, or non living objects, can't transfer by
1175 * shop mats. Instead, put it on a nearby space. 1206 * shop mats. Instead, put it on a nearby space.
1176 */ 1207 */
1177 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE)) 1208 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE))
1178 { 1209 {
1179
1180 /* Somebody dropped an unpaid item, just move to an adjacent place. */ 1210 /* Somebody dropped an unpaid item, just move to an adjacent place. */
1181 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1211 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1182 1212
1183 if (i != -1) 1213 if (i != -1)
1184 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat); 1214 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat);
1193 else if (can_pay (op) && get_payment (op)) 1223 else if (can_pay (op) && get_payment (op))
1194 { 1224 {
1195 /* this is only used for players */ 1225 /* this is only used for players */
1196 rv = teleport (shop_mat, SHOP_MAT, op); 1226 rv = teleport (shop_mat, SHOP_MAT, op);
1197 1227
1228 if (has_unpaid)
1229 op->contr->play_sound (sound_find ("shop_buy"));
1230 else if (is_in_shop (op))
1231 op->contr->play_sound (sound_find ("shop_enter"));
1232 else
1233 op->contr->play_sound (sound_find ("shop_leave"));
1234
1198 if (shop_mat->msg) 1235 if (shop_mat->msg)
1199 new_draw_info (NDI_UNIQUE, 0, op, shop_mat->msg); 1236 op->statusmsg (shop_mat->msg);
1200 /* This check below is a bit simplistic - generally it should be correct, 1237 /* This check below is a bit simplistic - generally it should be correct,
1201 * but there is never a guarantee that the bottom space on the map is 1238 * but there is never a guarantee that the bottom space on the map is
1202 * actually the shop floor. 1239 * actually the shop floor.
1203 */ 1240 */
1204 else if (!rv && !is_in_shop (op)) 1241 else if (!rv && !is_in_shop (op))
1205 { 1242 {
1206 opinion = shopkeeper_approval (op->map, op); 1243 opinion = shopkeeper_approval (op->map, op);
1207 1244
1208 if (opinion > 0.9) 1245 op->statusmsg (
1209 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper gives you a friendly wave."); 1246 opinion >= 0.90 ? "The shopkeeper gives you a friendly wave."
1210 else if (opinion > 0.75) 1247 : opinion >= 0.75 ? "The shopkeeper waves to you."
1211 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper waves to you."); 1248 : opinion >= 0.50 ? "The shopkeeper ignores you."
1212 else if (opinion > 0.5) 1249 : "The shopkeeper glares at you with contempt."
1213 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper ignores you.");
1214 else 1250 );
1215 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper glares at you with contempt.");
1216 } 1251 }
1217 } 1252 }
1218 else 1253 else
1219 { 1254 {
1220 /* if we get here, a player tried to leave a shop but was not able 1255 /* if we get here, a player tried to leave a shop but was not able
1221 * to afford the items he has. We try to move the player so that 1256 * to afford the items he has. We try to move the player so that
1222 * they are not on the mat anymore 1257 * they are not on the mat anymore
1223 */ 1258 */
1224 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1259 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1225 1260
1226 if (i == -1) 1261 if (i == -1)
1227 {
1228 LOG (llevError, "Internal shop-mat problem.\n"); 1262 LOG (llevError, "Internal shop-mat problem.\n");
1229 }
1230 else 1263 else
1231 { 1264 {
1232 op->remove (); 1265 op->remove ();
1233 op->x += freearr_x[i]; 1266 op->x += freearr_x[i];
1234 op->y += freearr_y[i]; 1267 op->y += freearr_y[i];
1246static void 1279static void
1247apply_sign (object *op, object *sign, int autoapply) 1280apply_sign (object *op, object *sign, int autoapply)
1248{ 1281{
1249 readable_message_type *msgType; 1282 readable_message_type *msgType;
1250 1283
1251 if (sign->msg == NULL) 1284 if (!sign->msg)
1252 { 1285 {
1253 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it."); 1286 op->statusmsg ("Nothing is written on it.");
1254 return; 1287 return;
1255 } 1288 }
1256 1289
1257 if (sign->stats.food) 1290 if (sign->stats.food)
1258 { 1291 {
1259 if (sign->last_eat >= sign->stats.food) 1292 if (sign->last_eat >= sign->stats.food)
1260 { 1293 {
1261 if (!sign->move_on) 1294 if (!sign->move_on)
1262 new_draw_info (NDI_UNIQUE, 0, op, "You cannot read it anymore."); 1295 op->statusmsg ("You cannot read it anymore.");
1296
1263 return; 1297 return;
1264 } 1298 }
1265 1299
1266 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1300 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1267 sign->last_eat++; 1301 sign->last_eat++;
1272 * move_on is zero, it needs to be manually applied (doesn't talk 1306 * move_on is zero, it needs to be manually applied (doesn't talk
1273 * to us). 1307 * to us).
1274 */ 1308 */
1275 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on) 1309 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on)
1276 { 1310 {
1277 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1311 op->failmsg ("You are unable to read while blind!");
1278 return; 1312 return;
1279 } 1313 }
1280 1314
1281 if (op->contr) 1315 if (op->contr)
1282 if (client *ns = op->contr->ns) 1316 if (client *ns = op->contr->ns)
1283 { 1317 {
1284 msgType = get_readable_message_type (sign); 1318 if (sign->sound)
1319 ns->play_sound (sign->sound);
1320 else if (autoapply)
1321 ns->play_sound (sound_find ("msg_voice"));
1285 1322
1286 if (ns->can_msg) 1323 if (ns->can_msg)
1287 ns->send_msg (NDI_NAVY, msgType->msgtype, &sign->msg); 1324 op->contr->infobox (MSG_CHANNEL ("examine"), format ("T<%s>\n\n\n\n%s", &sign->name, &sign->msg));
1288 else 1325 else
1289 { 1326 {
1290 char newbuf[HUGE_BUF]; 1327 msgType = get_readable_message_type (sign);
1291 snprintf (newbuf, sizeof (newbuf), "%u %s", autoapply ? 1 : 0, &sign->msg); 1328 const char *somemsg = format ("%u %s", autoapply ? 1 : 0, &sign->msg);
1292 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg); 1329 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, somemsg, &sign->msg);
1293 } 1330 }
1294 } 1331 }
1295} 1332}
1296 1333
1297/** 1334/**
1433 1470
1434 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1471 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1435 { 1472 {
1436 if (!sound_was_played) 1473 if (!sound_was_played)
1437 { 1474 {
1438 play_sound_map (trap->map, trap->x, trap->y, SOUND_FALL_HOLE); 1475 trap->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1439 sound_was_played = 1; 1476 sound_was_played = 1;
1440 } 1477 }
1441 new_draw_info (NDI_UNIQUE, 0, ab, "You fall into a trapdoor!"); 1478
1479 ab->statusmsg ("You fall into a trapdoor!", NDI_RED);
1442 transfer_ob (ab, (int) EXIT_X (trap), (int) EXIT_Y (trap), 0, ab); 1480 transfer_ob (ab, EXIT_X (trap), EXIT_Y (trap), 0, ab);
1443 } 1481 }
1444 } 1482 }
1445 goto leave; 1483 goto leave;
1446 } 1484 }
1447 1485
1448
1449 case CONVERTER: 1486 case CONVERTER:
1450 if (convert_item (victim, trap) < 0) 1487 if (convert_item (victim, trap) < 0)
1451 { 1488 {
1452 new_draw_info_format (NDI_UNIQUE, 0, originator, "The %s seems to be broken!", query_name (trap)); 1489 originator->failmsg (format ("The %s seems to be broken!", query_name (trap)));
1453 get_archetype ("burnout")->insert_at (trap, trap); 1490 get_archetype ("burnout")->insert_at (trap, trap);
1454 } 1491 }
1455 1492
1456 goto leave; 1493 goto leave;
1457 1494
1478 * Processing will happen if the head runs into the pit 1515 * Processing will happen if the head runs into the pit
1479 */ 1516 */
1480 if (victim->head) 1517 if (victim->head)
1481 goto leave; 1518 goto leave;
1482 1519
1483 play_sound_map (victim->map, victim->x, victim->y, SOUND_FALL_HOLE); 1520 victim->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1484 new_draw_info (NDI_UNIQUE, 0, victim, "You fall through the hole!\n"); 1521 victim->statusmsg ("You fall through the hole!", NDI_RED);
1485 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim); 1522 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim);
1486 goto leave; 1523 goto leave;
1487 1524
1488 case EXIT: 1525 case EXIT:
1489 if (victim->type == PLAYER && EXIT_PATH (trap)) 1526 if (victim->type == PLAYER && EXIT_PATH (trap))
1490 { 1527 {
1491 /* Basically, don't show exits leading to random maps the 1528 /* Basically, don't show exits leading to random maps the
1492 * players output. 1529 * players output.
1493 */ 1530 */
1494 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2)) 1531 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2))
1495 new_draw_info (NDI_NAVY, 0, victim, trap->msg); 1532 victim->statusmsg (trap->msg, NDI_NAVY);
1496 1533
1534 trap->play_sound (trap->sound);
1497 victim->enter_exit (trap); 1535 victim->enter_exit (trap);
1498 } 1536 }
1499 goto leave; 1537 goto leave;
1500 1538
1501 case ENCOUNTER: 1539 case ENCOUNTER:
1523 goto leave; 1561 goto leave;
1524 1562
1525 case RUNE: 1563 case RUNE:
1526 case TRAP: 1564 case TRAP:
1527 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE)) 1565 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE))
1528 {
1529 spring_trap (trap, victim); 1566 spring_trap (trap, victim);
1530 }
1531 goto leave; 1567 goto leave;
1532 1568
1533 default: 1569 default:
1534 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not " 1570 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not "
1535 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type); 1571 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type);
1549 int lev_diff; 1585 int lev_diff;
1550 object *skill_ob; 1586 object *skill_ob;
1551 1587
1552 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1588 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1553 { 1589 {
1554 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1590 op->failmsg ("You are unable to read while blind!");
1555 return; 1591 return;
1556 } 1592 }
1557 1593
1558 if (!tmp->msg) 1594 if (!tmp->msg)
1559 { 1595 {
1560 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name); 1596 op->failmsg (format ("You open the %s and find it empty.", &tmp->name));
1561 return; 1597 return;
1562 } 1598 }
1563 1599
1564 /* need a literacy skill to read stuff! */ 1600 /* need a literacy skill to read stuff! */
1565 skill_ob = find_skill_by_name (op, tmp->skill); 1601 skill_ob = find_skill_by_name (op, tmp->skill);
1566 if (!skill_ob) 1602 if (!skill_ob)
1567 { 1603 {
1568 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols. H<You lack the skill to read this>"); 1604 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill to read this.>", &tmp->skill));
1569 return; 1605 return;
1570 } 1606 }
1571 1607
1572 lev_diff = tmp->level - (skill_ob->level + 5); 1608 lev_diff = tmp->level - (skill_ob->level + 5);
1573 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0) 1609 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0)
1574 { 1610 {
1575 if (lev_diff < 2) 1611 op->failmsg (lev_diff < 2 ? "This book is just barely beyond your comprehension."
1576 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension."); 1612 : lev_diff < 3 ? "This book is slightly beyond your comprehension."
1577 else if (lev_diff < 3) 1613 : lev_diff < 5 ? "This book is beyond your comprehension."
1578 new_draw_info (NDI_UNIQUE, 0, op, "This book is slightly beyond your comprehension."); 1614 : lev_diff < 8 ? "This book is quite a bit beyond your comprehension."
1579 else if (lev_diff < 5) 1615 : lev_diff < 15 ? "This book is way beyond your comprehension."
1580 new_draw_info (NDI_UNIQUE, 0, op, "This book is beyond your comprehension."); 1616 : "This book is totally beyond your comprehension.");
1581 else if (lev_diff < 8)
1582 new_draw_info (NDI_UNIQUE, 0, op, "This book is quite a bit beyond your comprehension.");
1583 else if (lev_diff < 15)
1584 new_draw_info (NDI_UNIQUE, 0, op, "This book is way beyond your comprehension.");
1585 else
1586 new_draw_info (NDI_UNIQUE, 0, op, "This book is totally beyond your comprehension.");
1587 return; 1617 return;
1588 } 1618 }
1589 1619
1590 readable_message_type *msgType = get_readable_message_type (tmp); 1620 readable_message_type *msgType = get_readable_message_type (tmp);
1591 1621
1592 if (player *pl = op->contr) 1622 if (player *pl = op->contr)
1593 if (client *ns = pl->ns) 1623 if (client *ns = pl->ns)
1594 if (ns->can_msg) 1624 if (ns->can_msg)
1595 { 1625 pl->infobox (MSG_CHANNEL ("book"), format ("T<%s>\n\n\n\n%s", (char *)long_desc (tmp, op), &tmp->msg));
1596 dynbuf_text buf;
1597 buf << long_desc (tmp, op)
1598 << "\n\n"
1599 << tmp->msg
1600 << '\0';
1601 ns->send_msg (NDI_NAVY, msgType->msgtype, buf.linearise ());
1602 }
1603 else 1626 else
1604 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, 1627 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op,
1605 msgType->message_type, msgType->message_subtype, 1628 msgType->message_type, msgType->message_subtype,
1606 "You open the %s and start reading.\n%s", (char *)"%s\n%s", 1629 "You open the %s and start reading.\n%s", (char *)"%s\n%s",
1607 long_desc (tmp, op), &tmp->msg); 1630 long_desc (tmp, op), &tmp->msg);
1633 * op is the person learning the skill, tmp is the skill scroll object 1656 * op is the person learning the skill, tmp is the skill scroll object
1634 */ 1657 */
1635static void 1658static void
1636apply_skillscroll (object *op, object *tmp) 1659apply_skillscroll (object *op, object *tmp)
1637{ 1660{
1638 switch ((int) learn_skill (op, tmp)) 1661 switch (learn_skill (op, tmp))
1639 { 1662 {
1640 case 0: 1663 case 0:
1641 new_draw_info (NDI_UNIQUE, 0, op, "You already possess the knowledge "); 1664 op->play_sound (sound_find ("generic_fail"));
1642 new_draw_info_format (NDI_UNIQUE, 0, op, "held within the %s.\n", query_name (tmp)); 1665 op->failmsg (format ("You already possess the knowledge held within the %s.", query_name (tmp)));
1643 return; 1666 break;
1644 1667
1645 case 1: 1668 case 1:
1646 new_draw_info_format (NDI_UNIQUE, 0, op, "You succeed in learning %s", &tmp->skill);
1647 decrease_ob (tmp); 1669 decrease_ob (tmp);
1670 op->play_sound (sound_find ("skill_learn"));
1671 op->statusmsg (format ("You succeed in learning %s", &tmp->skill));
1648 return; 1672 break;
1649 1673
1650 default: 1674 default:
1651 new_draw_info_format (NDI_UNIQUE, 0, op, "You fail to learn the knowledge of the %s.\n", query_name (tmp));
1652 decrease_ob (tmp); 1675 decrease_ob (tmp);
1676 op->play_sound (sound_find ("generic_fail"));
1677 op->failmsg (format ("You fail to learn the knowledge of the %s.\n", query_name (tmp)));
1653 return; 1678 break;
1654 } 1679 }
1655} 1680}
1656 1681
1657/** 1682/**
1658 * Actually makes op learn spell. 1683 * Actually makes op learn spell.
1678 return; 1703 return;
1679 } 1704 }
1680 return; 1705 return;
1681 } 1706 }
1682 1707
1683 play_sound_player_only (op->contr, SOUND_LEARN_SPELL, 0, 0); 1708 op->contr->play_sound (sound_find ("learn_spell"));
1709
1684 tmp = spell->clone (); 1710 tmp = spell->clone ();
1685 insert_ob_in_ob (tmp, op); 1711 insert_ob_in_ob (tmp, op);
1686 1712
1687 if (special_prayer) 1713 if (special_prayer)
1688 SET_FLAG (tmp, FLAG_STARTEQUIP); 1714 SET_FLAG (tmp, FLAG_STARTEQUIP);
1707 { 1733 {
1708 LOG (llevError, "BUG: do_forget_spell(): spell not known\n"); 1734 LOG (llevError, "BUG: do_forget_spell(): spell not known\n");
1709 return; 1735 return;
1710 } 1736 }
1711 1737
1712 new_draw_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, "You lose knowledge of %s.", spell); 1738 op->failmsg (format ("You lose knowledge of %s.", spell));
1713 player_unready_range_ob (op->contr, spob); 1739 player_unready_range_ob (op->contr, spob);
1714 esrv_remove_spell (op->contr, spob); 1740 esrv_remove_spell (op->contr, spob);
1715 spob->destroy (); 1741 spob->destroy ();
1716} 1742}
1717 1743
1725{ 1751{
1726 object *skop, *spell, *spell_skill; 1752 object *skop, *spell, *spell_skill;
1727 1753
1728 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1754 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1729 { 1755 {
1730 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1756 op->failmsg ("You are unable to read while blind.");
1731 return; 1757 return;
1732 } 1758 }
1733 1759
1734 /* artifact_spellbooks have 'slaying' field point to a spell name, 1760 /* artifact_spellbooks have 'slaying' field point to a spell name,
1735 * instead of having their spell stored in stats.sp. These are 1761 * instead of having their spell stored in stats.sp. These are
1738 if (tmp->slaying) 1764 if (tmp->slaying)
1739 { 1765 {
1740 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying)); 1766 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying));
1741 if (!spell) 1767 if (!spell)
1742 { 1768 {
1743 new_draw_info_format (NDI_UNIQUE, 0, op, "The book's formula for %s is incomplete", &tmp->slaying); 1769 op->failmsg (format ("The book's formula for %s is incomplete.", &tmp->slaying));
1744 return; 1770 return;
1745 } 1771 }
1746 else 1772 else
1747 insert_ob_in_ob (spell, tmp); 1773 insert_ob_in_ob (spell, tmp);
1748 1774
1753 1779
1754 /* need a literacy skill to learn spells. Also, having a literacy level 1780 /* need a literacy skill to learn spells. Also, having a literacy level
1755 * lower than the spell will make learning the spell more difficult */ 1781 * lower than the spell will make learning the spell more difficult */
1756 if (!skop) 1782 if (!skop)
1757 { 1783 {
1758 new_draw_info (NDI_UNIQUE, 0, op, "You can't read! Your attempt fails. H<You lack the literacy skill.>"); 1784 op->failmsg (format ("You can't read! Your attempt fails. H<You lack the %s skill.>", &tmp->skill));
1759 return; 1785 return;
1760 } 1786 }
1761 1787
1762 spell = tmp->inv; 1788 spell = tmp->inv;
1763 1789
1764 if (!spell) 1790 if (!spell)
1765 { 1791 {
1766 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name); 1792 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name);
1767 new_draw_info (NDI_UNIQUE, 0, op, "The spellbook symbols make no sense. This is a bug, please report!"); 1793 op->failmsg ("The spellbook symbols make no sense. This is a bug, please report!");
1768 return; 1794 return;
1769 } 1795 }
1770 1796
1771 if (skop->level < int (sqrtf (spell->level) * 1.5f)) 1797 if (skop->level < int (sqrtf (spell->level) * 1.5f))
1772 { 1798 {
1773 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols. H<Your literacy level is too low.>"); 1799 op->failmsg (format ("You are unable to decipher the strange symbols. H<Your %s level is too low.>", &tmp->skill));
1774 return; 1800 return;
1775 } 1801 }
1776 1802
1777 new_draw_info_format (NDI_UNIQUE, 0, op, "The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name); 1803 op->statusmsg (format ("The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name));
1778 1804
1779 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1805 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1780 { 1806 {
1781 identify (tmp); 1807 identify (tmp);
1782 1808
1791 * if the player doesn't know the spell, doesn't make a lot of sense that 1817 * if the player doesn't know the spell, doesn't make a lot of sense that
1792 * they would have a special prayer mark. 1818 * they would have a special prayer mark.
1793 */ 1819 */
1794 if (check_spell_known (op, spell->name)) 1820 if (check_spell_known (op, spell->name))
1795 { 1821 {
1796 new_draw_info (NDI_UNIQUE, 0, op, "You already know that spell. H<It makes no sense to learn spells twice, and would only waste the spellbook.>\n"); 1822 op->statusmsg ("You already know that spell. H<It makes no sense to learn spells twice, and would only waste the spellbook.>\n");
1797 return; 1823 return;
1798 } 1824 }
1799 1825
1800 if (spell->skill) 1826 if (spell->skill)
1801 { 1827 {
1802 spell_skill = find_skill_by_name (op, spell->skill); 1828 spell_skill = find_skill_by_name (op, spell->skill);
1803 1829
1804 if (!spell_skill) 1830 if (!spell_skill)
1805 { 1831 {
1806 new_draw_info_format (NDI_UNIQUE, 0, op, "You lack the skill %s to use this spell.", &spell->skill); 1832 op->failmsg (format ("You lack the skill %s to use this spell.", &spell->skill));
1807 return; 1833 return;
1808 } 1834 }
1809 1835
1810 if (spell_skill->level < spell->level) 1836 if (spell_skill->level < spell->level)
1811 { 1837 {
1812 new_draw_info_format (NDI_UNIQUE, 0, op, "You need to be level %d in %s to learn this spell.", spell->level, &spell->skill); 1838 op->failmsg (format ("You need to be level %d in %s to learn this spell.", spell->level, &spell->skill));
1813 return; 1839 return;
1814 } 1840 }
1815 } 1841 }
1816 1842
1817 /* Logic as follows 1843 /* Logic as follows
1826 * Overall, chances are the same but a player will find having a high 1852 * Overall, chances are the same but a player will find having a high
1827 * literacy rate very useful! -b.t. 1853 * literacy rate very useful! -b.t.
1828 */ 1854 */
1829 if (QUERY_FLAG (op, FLAG_CONFUSED)) 1855 if (QUERY_FLAG (op, FLAG_CONFUSED))
1830 { 1856 {
1831 new_draw_info (NDI_UNIQUE, 0, op, "In your confused state you flub the wording of the text!"); 1857 op->failmsg ("In your confused state you flub the wording of the text!");
1832 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace)); 1858 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace));
1833 } 1859 }
1834 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || 1860 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) ||
1835 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int]) 1861 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int])
1836 { 1862 {
1837 1863 op->statusmsg ("You succeed in learning the spell!", NDI_GREEN);
1838 new_draw_info (NDI_UNIQUE, 0, op, "You succeed in learning the spell!");
1839 do_learn_spell (op, spell, 0); 1864 do_learn_spell (op, spell, 0);
1840 1865
1841 /* xp gain to literacy for spell learning */ 1866 /* xp gain to literacy for spell learning */
1842 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP)) 1867 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP))
1843 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0); 1868 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0);
1844 } 1869 }
1845 else 1870 else
1846 { 1871 {
1847 play_sound_player_only (op->contr, SOUND_FUMBLE_SPELL, 0, 0); 1872 op->contr->play_sound (sound_find ("fumble_spell"));
1848 new_draw_info (NDI_UNIQUE, 0, op, "You fail to learn the spell. H<Wis (priests) or Int (wizards) governs the chance of learning a prayer or spell.>\n"); 1873 op->failmsg ("You fail to learn the spell. H<Wis (priests) or Int (wizards) governs the chance of learning a prayer or spell.>\n");
1849 } 1874 }
1850 1875
1851 decrease_ob (tmp); 1876 decrease_ob (tmp);
1852} 1877}
1853 1878
1859{ 1884{
1860 object *skop; 1885 object *skop;
1861 1886
1862 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1887 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1863 { 1888 {
1864 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1889 op->failmsg ("You are unable to read while blind.");
1865 return; 1890 return;
1866 } 1891 }
1867 1892
1868 if (!tmp->inv || tmp->inv->type != SPELL) 1893 if (!tmp->inv || tmp->inv->type != SPELL)
1869 { 1894 {
1870 new_draw_info (NDI_UNIQUE, 0, op, "The scroll just doesn't make sense! H<...and never will make sense.>"); 1895 op->failmsg ("The scroll just doesn't make sense! H<...and never will make sense.>");
1871 return; 1896 return;
1872 } 1897 }
1873 1898
1874 if (op->type == PLAYER) 1899 if (op->type == PLAYER)
1875 { 1900 {
1881 */ 1906 */
1882 skop = find_skill_by_name (op, skill_names[SK_LITERACY]); 1907 skop = find_skill_by_name (op, skill_names[SK_LITERACY]);
1883 1908
1884 if (!skop) 1909 if (!skop)
1885 { 1910 {
1886 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols. H<You lack the literacy skill.>"); 1911 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill.>", &skill_names[SK_LITERACY]));
1887 return; 1912 return;
1888 } 1913 }
1889 1914
1890 if ((exp_gain = calc_skill_exp (op, tmp, skop))) 1915 if ((exp_gain = calc_skill_exp (op, tmp, skop)))
1891 change_exp (op, exp_gain, skop->skill, 0); 1916 change_exp (op, exp_gain, skop->skill, 0);
1892 } 1917 }
1893 1918
1894 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1919 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1895 identify (tmp); 1920 identify (tmp);
1896 1921
1897 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name); 1922 op->statusmsg (format ("The scroll of %s turns to dust.", &tmp->inv->name));
1898 1923
1899 cast_spell (op, tmp, dir, tmp->inv, NULL); 1924 cast_spell (op, tmp, dir, tmp->inv, NULL);
1900 decrease_ob (tmp); 1925 decrease_ob (tmp);
1901} 1926}
1902 1927
1906 * chest. 1931 * chest.
1907 */ 1932 */
1908static void 1933static void
1909apply_treasure (object *op, object *tmp) 1934apply_treasure (object *op, object *tmp)
1910{ 1935{
1911 /* Nice side effect of new treasure creation method is that the treasure 1936 /* Nice side effect of this treasure creation method is that the treasure
1912 * for the chest is done when the chest is created, and put into the chest 1937 * for the chest is done when the chest is created, and put into the chest
1913 * inventory. So that when the chest burns up, the items still exist. Also 1938 * inventory. So that when the chest burns up, the items still exist. Also
1914 * prevents people fromt moving chests to more difficult maps to get better 1939 * prevents people from moving chests to more difficult maps to get better
1915 * treasure 1940 * treasure
1916 */ 1941 */
1917 object *treas = tmp->inv; 1942 object *treas = tmp->inv;
1918 1943
1919 if (!treas) 1944 if (!treas)
1920 { 1945 {
1921 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty."); 1946 op->statusmsg ("The chest was empty.");
1922 decrease_ob (tmp); 1947 decrease_ob (tmp);
1923 return; 1948 return;
1924 } 1949 }
1925 1950
1926 while (tmp->inv) 1951 while (tmp->inv)
1927 { 1952 {
1928 treas = tmp->inv; 1953 treas = tmp->inv;
1929
1930 treas->remove (); 1954 treas->remove ();
1931 new_draw_info_format (NDI_UNIQUE, 0, op, "You find %s in the chest.", query_name (treas));
1932 1955
1933 treas->x = op->x; 1956 treas->x = op->x;
1934 treas->y = op->y; 1957 treas->y = op->y;
1935 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR); 1958 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR);
1936 1959
1937 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE)) 1960 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE))
1938 spring_trap (treas, op); 1961 spring_trap (treas, op);
1939 1962
1940 /* If either player or container was destroyed, no need to do 1963 /* If either player or container was destroyed, no need to do
1941 * further processing. I think this should be enclused with 1964 * further processing. I think this should be enclused with
1942 * spring trap above, as I don't think there is otherwise 1965 * spring trap above, as I don't think there is otherwise
1943 * any way for the treasure chest or player to get killed 1966 * any way for the treasure chest or player to get killed.
1944 */ 1967 */
1945 if (op->destroyed () || tmp->destroyed ()) 1968 if (op->destroyed () || tmp->destroyed ())
1946 break; 1969 break;
1947 } 1970 }
1948 1971
1949 if (!tmp->destroyed () && tmp->inv == NULL) 1972 if (!tmp->destroyed () && !tmp->inv)
1950 decrease_ob (tmp); 1973 decrease_ob (tmp);
1951
1952} 1974}
1953 1975
1954/** 1976/**
1955 * op eats food. 1977 * op eats food.
1956 * If player, takes care of messages and dragon special food. 1978 * If player, takes care of messages and dragon special food.
1971 { 1993 {
1972 /* usual case - no dragon meal: */ 1994 /* usual case - no dragon meal: */
1973 if (op->stats.food + tmp->stats.food > 999) 1995 if (op->stats.food + tmp->stats.food > 999)
1974 { 1996 {
1975 if (tmp->type == FOOD || tmp->type == FLESH) 1997 if (tmp->type == FOOD || tmp->type == FLESH)
1976 new_draw_info (NDI_UNIQUE, 0, op, "You feel full, but what a waste of food!"); 1998 op->failmsg ("You feel full, but what a waste of food!");
1977 else 1999 else
1978 new_draw_info (NDI_UNIQUE, 0, op, "Most of the drink goes down your face not your throat!"); 2000 op->statusmsg ("Most of the drink goes down your face not your throat!");
1979 } 2001 }
2002
2003 tmp->play_sound (
2004 tmp->sound
2005 ? tmp->sound
2006 : tmp->type == DRINK
2007 ? sound_find ("eat_drink")
2008 : sound_find ("eat_food")
2009 );
1980 2010
1981 if (!QUERY_FLAG (tmp, FLAG_CURSED)) 2011 if (!QUERY_FLAG (tmp, FLAG_CURSED))
1982 { 2012 {
1983 char buf[MAX_BUF]; 2013 const char *buf;
1984 2014
1985 if (!is_dragon_pl (op)) 2015 if (!is_dragon_pl (op))
1986 { 2016 {
1987 /* eating message for normal players */ 2017 /* eating message for normal players */
1988 if (tmp->type == DRINK) 2018 if (tmp->type == DRINK)
1989 sprintf (buf, "Ahhh...that %s tasted good.", &tmp->name); 2019 buf = format ("Ahhh...that %s tasted good.", &tmp->name);
1990 else 2020 else
1991 sprintf (buf, "The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good."); 2021 buf = format ("The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good.");
1992 } 2022 }
1993 else 2023 else
1994 {
1995 /* eating message for dragon players */ 2024 /* eating message for dragon players */
1996 sprintf (buf, "The %s tasted terrible!", &tmp->name); 2025 buf = format ("The %s tasted terrible!", &tmp->name);
1997 }
1998 2026
1999 new_draw_info (NDI_UNIQUE, 0, op, buf); 2027 op->statusmsg (buf);
2028
2000 capacity_remaining = 999 - op->stats.food; 2029 capacity_remaining = 999 - op->stats.food;
2001 op->stats.food += tmp->stats.food; 2030 op->stats.food += tmp->stats.food;
2002 if (capacity_remaining < tmp->stats.food) 2031 if (capacity_remaining < tmp->stats.food)
2003 op->stats.hp += capacity_remaining / 50; 2032 op->stats.hp += capacity_remaining / 50;
2004 else 2033 else
2005 op->stats.hp += tmp->stats.food / 50; 2034 op->stats.hp += tmp->stats.food / 50;
2035
2006 if (op->stats.hp > op->stats.maxhp) 2036 if (op->stats.hp > op->stats.maxhp)
2007 op->stats.hp = op->stats.maxhp; 2037 op->stats.hp = op->stats.maxhp;
2008 if (op->stats.food > 999) 2038 if (op->stats.food > 999)
2009 op->stats.food = 999; 2039 op->stats.food = 999;
2010 } 2040 }
2034{ 2064{
2035 object *skin = NULL; /* pointer to dragon skin force */ 2065 object *skin = NULL; /* pointer to dragon skin force */
2036 object *abil = NULL; /* pointer to dragon ability force */ 2066 object *abil = NULL; /* pointer to dragon ability force */
2037 object *tmp = NULL; /* tmp. object */ 2067 object *tmp = NULL; /* tmp. object */
2038 2068
2039 char buf[MAX_BUF]; /* tmp. string buffer */
2040 double chance; /* improvement-chance of one resistance type */ 2069 double chance; /* improvement-chance of one resistance type */
2041 double totalchance = 1; /* total chance of gaining one resistance */ 2070 double totalchance = 1; /* total chance of gaining one resistance */
2042 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */ 2071 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */
2043 double mbonus = 0; /* monster bonus */ 2072 double mbonus = 0; /* monster bonus */
2044 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */ 2073 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */
2066 /* now start by filling stomache and health, according to food-value */ 2095 /* now start by filling stomache and health, according to food-value */
2067 if ((999 - op->stats.food) < meal->stats.food) 2096 if ((999 - op->stats.food) < meal->stats.food)
2068 op->stats.hp += (999 - op->stats.food) / 50; 2097 op->stats.hp += (999 - op->stats.food) / 50;
2069 else 2098 else
2070 op->stats.hp += meal->stats.food / 50; 2099 op->stats.hp += meal->stats.food / 50;
2100
2071 if (op->stats.hp > op->stats.maxhp) 2101 if (op->stats.hp > op->stats.maxhp)
2072 op->stats.hp = op->stats.maxhp; 2102 op->stats.hp = op->stats.maxhp;
2073 2103
2074 op->stats.food = MIN (999, op->stats.food + meal->stats.food); 2104 op->stats.food = MIN (999, op->stats.food + meal->stats.food);
2075 2105
2120 } 2150 }
2121 } 2151 }
2122 2152
2123 /* inverse totalchance as until now we have the failure-chance */ 2153 /* inverse totalchance as until now we have the failure-chance */
2124 totalchance = 100 - totalchance * 100; 2154 totalchance = 100 - totalchance * 100;
2155
2125 /* print message according to totalchance */ 2156 /* print message according to totalchance */
2157 const char *buf;
2126 if (totalchance > 50.) 2158 if (totalchance > 50.)
2127 sprintf (buf, "Hmm! The %s tasted delicious!", &meal->name); 2159 buf = format ("Hmm! The %s tasted delicious!", &meal->name);
2128 else if (totalchance > 10.) 2160 else if (totalchance > 10.)
2129 sprintf (buf, "The %s tasted very good.", &meal->name); 2161 buf = format ("The %s tasted very good.", &meal->name);
2130 else if (totalchance > 1.) 2162 else if (totalchance > 1.)
2131 sprintf (buf, "The %s tasted good.", &meal->name); 2163 buf = format ("The %s tasted good.", &meal->name);
2132 else if (totalchance > 0.1) 2164 else if (totalchance > 0.1)
2133 sprintf (buf, "The %s tasted bland.", &meal->name); 2165 buf = format ("The %s tasted bland.", &meal->name);
2134 else if (totalchance >= 0.01) 2166 else if (totalchance >= 0.01)
2135 sprintf (buf, "The %s had a boring taste.", &meal->name); 2167 buf = format ("The %s had a boring taste.", &meal->name);
2136 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat)) 2168 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat))
2137 sprintf (buf, "The %s tasted strange.", &meal->name); 2169 buf = format ("The %s tasted strange.", &meal->name);
2138 else 2170 else
2139 sprintf (buf, "The %s had no taste.", &meal->name); 2171 buf = format ("The %s had no taste.", &meal->name);
2140 new_draw_info (NDI_UNIQUE, 0, op, buf); 2172
2173 op->statusmsg (buf);
2141 2174
2142 /* now choose a winner if we have any */ 2175 /* now choose a winner if we have any */
2143 i = -1; 2176 i = -1;
2144 if (winners > 0) 2177 if (winners > 0)
2145 i = atnr_winner[RANDOM () % winners]; 2178 i = atnr_winner[RANDOM () % winners];
2148 { 2181 {
2149 /* resistance increased! */ 2182 /* resistance increased! */
2150 skin->resist[i]++; 2183 skin->resist[i]++;
2151 op->update_stats (); 2184 op->update_stats ();
2152 2185
2153 sprintf (buf, "Your skin is now more resistant to %s!", change_resist_msg[i]); 2186 op->statusmsg (format ("Your skin is now more resistant to %s!", change_resist_msg[i]));
2154 new_draw_info (NDI_UNIQUE | NDI_RED, 0, op, buf);
2155 } 2187 }
2156 2188
2157 /* if this flesh contains a new ability focus, we mark it 2189 /* if this flesh contains a new ability focus, we mark it
2158 into the ability_force and it will take effect on next level */ 2190 into the ability_force and it will take effect on next level */
2159 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat) 2191 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat)
2160 { 2192 {
2161 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */ 2193 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */
2162 2194
2163 if (meal->last_eat != abil->stats.exp) 2195 if (meal->last_eat != abil->stats.exp)
2196 op->statusmsg (format (
2197 "Your metabolism prepares to focus on %s!\n"
2198 "The change will happen at level %d.",
2199 change_resist_msg[meal->last_eat],
2200 abil->level + 1
2164 { 2201 ));
2165 sprintf (buf, "Your metabolism prepares to focus on %s!", change_resist_msg[meal->last_eat]);
2166 new_draw_info (NDI_UNIQUE, 0, op, buf);
2167 sprintf (buf, "The change will happen at level %d", abil->level + 1);
2168 new_draw_info (NDI_UNIQUE, 0, op, buf);
2169 }
2170 else 2202 else
2171 { 2203 {
2172 sprintf (buf, "Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]); 2204 op->statusmsg (format ("Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]));
2173 new_draw_info (NDI_UNIQUE, 0, op, buf);
2174 abil->last_eat = 0; 2205 abil->last_eat = 0;
2175 } 2206 }
2176 } 2207 }
2208
2177 return 1; 2209 return 1;
2178} 2210}
2179 2211
2180/** 2212/**
2181 * Handles applying an improve armor scroll. 2213 * Handles applying an improve armor scroll.
2186{ 2218{
2187 object *armor; 2219 object *armor;
2188 2220
2189 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_NO_MAGIC)) 2221 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_NO_MAGIC))
2190 { 2222 {
2191 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll. H<The area prevents magic effects.>"); 2223 op->failmsg ("Something blocks the magic of the scroll. H<This area prevents magic effects.>");
2192 return; 2224 return;
2193 } 2225 }
2194 2226
2195 armor = find_marked_object (op); 2227 armor = find_marked_object (op);
2196 2228
2197 if (!armor) 2229 if (!armor)
2198 { 2230 {
2199 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark an armor object. Use the right mouse button popup or the mark command to do this."); 2231 op->failmsg ("You need to mark an armor object. Use the right mouse button popup or the mark command to do this.");
2200 return; 2232 return;
2201 } 2233 }
2202 2234
2203 if (armor->type != ARMOUR 2235 if (armor->type != ARMOUR
2204 && armor->type != CLOAK 2236 && armor->type != CLOAK
2205 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET) 2237 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET)
2206 { 2238 {
2207 new_draw_info (NDI_UNIQUE, 0, op, "Your marked item is not armour!\n"); 2239 op->failmsg ("Your marked item is not armour!\n");
2208 return; 2240 return;
2209 } 2241 }
2210 2242
2211 new_draw_info (NDI_UNIQUE, 0, op, "Applying armour enchantment."); 2243 op->statusmsg ("Applying armour enchantment.");
2212 improve_armour (op, tmp, armor); 2244 improve_armour (op, tmp, armor);
2213} 2245}
2214 2246
2215extern void 2247extern void
2216apply_poison (object *op, object *tmp) 2248apply_poison (object *op, object *tmp)
2217{ 2249{
2218 if (op->type == PLAYER) 2250 if (op->type == PLAYER)
2219 { 2251 {
2220 play_sound_player_only (op->contr, SOUND_DRINK_POISON, 0, 0); 2252 op->contr->play_sound (sound_find ("drink_poison"));
2221 new_draw_info (NDI_UNIQUE, 0, op, "Yech! That tasted poisonous!"); 2253 op->failmsg ("Yech! That tasted poisonous!");
2222 strcpy (op->contr->killer, "poisonous booze"); 2254 strcpy (op->contr->killer, "poisonous booze");
2223 } 2255 }
2224 2256
2225 if (tmp->stats.hp > 0) 2257 if (tmp->stats.hp > 0)
2226 { 2258 {
2253 2285
2254#if 0 //TODO 2286#if 0 //TODO
2255 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race) 2287 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race)
2256 return 0; /* This is a reset town portal */ 2288 return 0; /* This is a reset town portal */
2257#endif 2289#endif
2290
2291 LOG (llevError | logBacktrace, "sync map load due to %s\n", exit->debug_desc ());
2258 2292
2259 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map); 2293 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map);
2260 2294
2261 if (exitmap) 2295 if (exitmap)
2262 { 2296 {
2345 2379
2346 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED)) 2380 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED))
2347 { 2381 {
2348 if (op->type == PLAYER) 2382 if (op->type == PLAYER)
2349 { 2383 {
2350 new_draw_info (NDI_UNIQUE, 0, op, "You should pay for it first. H<You cannot use items marked as unpaid.>"); 2384 op->failmsg ("You should pay for it first! H<You cannot use items marked as unpaid.>");
2351 return 1; 2385 return 1;
2352 } 2386 }
2353 else 2387 else
2354 return 0; /* monsters just skip unpaid items */ 2388 return 0; /* monsters just skip unpaid items */
2355 } 2389 }
2358 return RESULT_INT (0); 2392 return RESULT_INT (0);
2359 2393
2360 switch (tmp->type) 2394 switch (tmp->type)
2361 { 2395 {
2362 case CF_HANDLE: 2396 case CF_HANDLE:
2363 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2397 op->play_sound (sound_find ("turn_handle"));
2364 play_sound_map (op->map, op->x, op->y, SOUND_TURN_HANDLE); 2398 op->statusmsg ("You turn the handle.");
2365 tmp->value = tmp->value ? 0 : 1; 2399 tmp->value = tmp->value ? 0 : 1;
2366 SET_ANIMATION (tmp, tmp->value); 2400 SET_ANIMATION (tmp, tmp->value);
2367 update_object (tmp, UP_OBJ_FACE); 2401 update_object (tmp, UP_OBJ_FACE);
2368 push_button (tmp); 2402 push_button (tmp);
2369 return 1; 2403 return 1;
2370 2404
2371 case TRIGGER: 2405 case TRIGGER:
2372 if (check_trigger (tmp, op)) 2406 if (check_trigger (tmp, op))
2373 { 2407 {
2374 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2408 op->statusmsg ("You turn the handle.");
2375 play_sound_map (tmp->map, tmp->x, tmp->y, SOUND_TURN_HANDLE); 2409 op->play_sound (sound_find ("turn_handle"));
2376 } 2410 }
2377 else 2411 else
2378 new_draw_info (NDI_UNIQUE, 0, op, "The handle doesn't move."); 2412 op->failmsg ("The handle doesn't move.");
2379 2413
2380 return 1; 2414 return 1;
2381 2415
2382 case EXIT: 2416 case EXIT:
2383 if (op->type != PLAYER) 2417 if (op->type != PLAYER)
2384 return 0; 2418 return 0;
2385 2419
2386 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp)) 2420 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp))
2387 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s is closed.", query_name (tmp)); 2421 op->failmsg (format ("The %s is closed.", query_name (tmp)));
2388 else 2422 else
2389 { 2423 {
2390 /* Don't display messages for random maps. */ 2424 /* Don't display messages for random maps. */
2391 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2)) 2425 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2))
2392 new_draw_info (NDI_NAVY, 0, op, tmp->msg); 2426 op->statusmsg (tmp->msg, NDI_NAVY);
2393 2427
2394 op->enter_exit (tmp); 2428 op->enter_exit (tmp);
2395 } 2429 }
2396 2430
2431 return 1;
2432
2433 case INSCRIBABLE:
2434 op->statusmsg (tmp->msg);
2435 // maybe show a spell menu to chose from or something like that
2397 return 1; 2436 return 1;
2398 2437
2399 case SIGN: 2438 case SIGN:
2400 apply_sign (op, tmp, 0); 2439 apply_sign (op, tmp, 0);
2401 return 1; 2440 return 1;
2510 { 2549 {
2511 char buf[MAX_BUF]; 2550 char buf[MAX_BUF];
2512 timeofday_t tod; 2551 timeofday_t tod;
2513 2552
2514 get_tod (&tod); 2553 get_tod (&tod);
2554 op->play_sound (sound_find ("sound_clock"));
2555 op->statusmsg (format (
2515 sprintf (buf, "It is %d minute%s past %d o'clock %s", 2556 "It is %d minute%s past %d o'clock %s",
2516 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"), 2557 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"),
2517 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")); 2558 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")
2518 play_sound_player_only (op->contr, SOUND_CLOCK, 0, 0); 2559 ));
2519 new_draw_info (NDI_UNIQUE, 0, op, buf);
2520 return 1; 2560 return 1;
2521 } 2561 }
2522 else 2562 else
2523 return 0; 2563 return 0;
2524 2564
2568 if (op->env && (pl->move_type & MOVE_FLYING)) 2608 if (op->env && (pl->move_type & MOVE_FLYING))
2569 { 2609 {
2570 /* player is flying and applying object not in inventory */ 2610 /* player is flying and applying object not in inventory */
2571 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING)) 2611 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING))
2572 { 2612 {
2573 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high above the ground! H<You have to stop levitating first, if you can.>"); 2613 pl->failmsg ("But you are floating high above the ground! H<You have to stop levitating first, if you can.>");
2574 return 0; 2614 return 0;
2575 } 2615 }
2576 } 2616 }
2577 2617
2578 pl->contr->last_used = op; 2618 pl->contr->last_used = op;
2579 2619
2580 tmp = manual_apply (pl, op, aflag); 2620 tmp = manual_apply (pl, op, aflag);
2581 if (!quiet) 2621 if (!quiet)
2582 { 2622 {
2583 if (tmp == 0) 2623 if (tmp == 0)
2584 new_draw_info_format (NDI_UNIQUE, 0, pl, "I don't know how to apply the %s.", query_name (op)); 2624 pl->statusmsg (format ("I don't know how to apply the %s.", query_name (op)));
2585 else if (tmp == 2) 2625 else if (tmp == 2)
2586 new_draw_info_format (NDI_UNIQUE, 0, pl, "You must get it first!\n"); 2626 pl->failmsg ("You must get it first!\n");
2587 } 2627 }
2588 2628
2589 return tmp; 2629 return tmp;
2590} 2630}
2591 2631
2668 { 2708 {
2669 pl->combat_ob = 0; 2709 pl->combat_ob = 0;
2670 who->change_weapon (pl->ranged_ob); 2710 who->change_weapon (pl->ranged_ob);
2671 } 2711 }
2672 2712
2673 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op)); 2713 who->statusmsg (format ("You unwield %s.", query_name (op)));
2674 2714
2675 change_abil (who, op); 2715 change_abil (who, op);
2676 CLEAR_FLAG (who, FLAG_READY_WEAPON); 2716 CLEAR_FLAG (who, FLAG_READY_WEAPON);
2677 break; 2717 break;
2678 2718
2679 case SKILL: 2719 case SKILL:
2680 if (who->contr) 2720 if (who->contr)
2681 { 2721 {
2682 if (!op->invisible) 2722 if (!op->invisible)
2683 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op)); 2723 who->statusmsg (format ("You stop using the %s.", query_name (op)));
2684 else 2724 else
2685 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill); 2725 who->statusmsg (format ("You can no longer use the skill: %s.", &op->skill));
2686 } 2726 }
2687 2727
2688 change_abil (who, op); 2728 change_abil (who, op);
2689 CLEAR_FLAG (who, FLAG_READY_SKILL); 2729 CLEAR_FLAG (who, FLAG_READY_SKILL);
2690 break; 2730 break;
2697 case GLOVES: 2737 case GLOVES:
2698 case AMULET: 2738 case AMULET:
2699 case GIRDLE: 2739 case GIRDLE:
2700 case BRACERS: 2740 case BRACERS:
2701 case CLOAK: 2741 case CLOAK:
2702 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op)); 2742 who->statusmsg (format ("You unwear %s.", query_name (op)));
2703 change_abil (who, op); 2743 change_abil (who, op);
2704 break; 2744 break;
2705 2745
2706 case LAMP: 2746 case LAMP:
2707 { 2747 {
2708 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name); 2748 who->statusmsg (format ("You turn off your %s.", &op->name));
2709 2749
2710 object *tmp2 = arch_to_object (op->other_arch); 2750 object *tmp2 = arch_to_object (op->other_arch);
2711 tmp2->x = op->x; 2751 tmp2->x = op->x;
2712 tmp2->y = op->y; 2752 tmp2->y = op->y;
2713 tmp2->map = op->map; 2753 tmp2->map = op->map;
2728 2768
2729 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 2769 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
2730 { 2770 {
2731 if (who->contr) 2771 if (who->contr)
2732 { 2772 {
2733 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 2773 who->failmsg ("Oops, it feels deadly cold!");
2734 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 2774 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
2735 } 2775 }
2736 } 2776 }
2737 2777
2738 if (who->contr) 2778 if (who->contr)
2751 { 2791 {
2752 pl->ranged_ob = 0; 2792 pl->ranged_ob = 0;
2753 who->change_weapon (pl->combat_ob); 2793 who->change_weapon (pl->combat_ob);
2754 } 2794 }
2755 2795
2756 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2796 who->statusmsg (format ("You unready %s.", query_name (op)));
2757 } 2797 }
2758 else 2798 else
2759 { 2799 {
2760 who->change_skill (0); 2800 who->change_skill (0);
2761 2801
2767 2807
2768 break; 2808 break;
2769 2809
2770 case BUILDER: 2810 case BUILDER:
2771 if (who->contr) 2811 if (who->contr)
2772 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2812 who->statusmsg (format ("You unready %s.", query_name (op)));
2773 break; 2813 break;
2774 2814
2775 default: 2815 default:
2776 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op)); 2816 who->statusmsg (format ("You unapply %s.", query_name (op)));
2777 break; 2817 break;
2778 } 2818 }
2779 2819
2780 who->update_stats (); 2820 who->update_stats ();
2781 2821
2848 for (object *tmp = who->inv; tmp; tmp = tmp->below) 2888 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2849 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ()) 2889 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ())
2850 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))) 2890 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)))
2851 { 2891 {
2852 if (aflags & AP_PRINT) 2892 if (aflags & AP_PRINT)
2853 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2893 who->failmsg (query_name (tmp));
2854 else 2894 else
2855 unapply_special (who, tmp, aflags); 2895 unapply_special (who, tmp, aflags);
2856 } 2896 }
2857 else 2897 else
2858 { 2898 {
2859 /* In this case, we want to try and remove a cursed item. 2899 /* In this case, we want to try and remove a cursed item.
2860 * While we know it won't work, we want unapply_special to 2900 * While we know it won't work, we want unapply_special to
2861 * at least generate the message. 2901 * at least generate the message.
2862 */ 2902 */
2863 new_draw_info_format (NDI_UNIQUE, 0, who, 2903 who->failmsg (format ("No matter how hard you try, you just can't remove the %s." CANNOT_REMOVE_CURSED, query_name (tmp)));
2864 "No matter how hard you try, you just can't remove the %s." CANNOT_REMOVE_CURSED,
2865 query_name (tmp));
2866 return 1; 2904 return 1;
2867 } 2905 }
2868 2906
2869 for (int i = 0; i < NUM_BODY_LOCATIONS; i++) 2907 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
2870 { 2908 {
2893 2931
2894 /* If we are just printing, we don't care about cursed status */ 2932 /* If we are just printing, we don't care about cursed status */
2895 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)))) 2933 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))))
2896 { 2934 {
2897 if (aflags & AP_PRINT) 2935 if (aflags & AP_PRINT)
2898 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2936 who->failmsg (query_name (tmp));
2899 else 2937 else
2900 unapply_special (who, tmp, aflags); 2938 unapply_special (who, tmp, aflags);
2901 } 2939 }
2902 else 2940 else
2903 { 2941 {
2904 /* Cursed item that we can't unequip - tell the player. 2942 /* Cursed item that we can't unequip - tell the player.
2905 * Note this could be annoying if this is just one of a few, 2943 * Note this could be annoying if this is just one of a few,
2906 * so it may not be critical (eg, putting on a ring and you have 2944 * so it may not be critical (eg, putting on a ring and you have
2907 * one cursed ring.) 2945 * one cursed ring.)
2908 */ 2946 */
2909 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s just won't come off." CANNOT_REMOVE_CURSED, query_name (tmp)); 2947 who->failmsg (format ("The %s just won't come off." CANNOT_REMOVE_CURSED, query_name (tmp)));
2910 } 2948 }
2911 2949
2912 last = tmp->below; 2950 last = tmp->below;
2913 } 2951 }
2914 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the 2952 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the
3095 if (basic_flag == AP_APPLY) 3133 if (basic_flag == AP_APPLY)
3096 return 0; 3134 return 0;
3097 3135
3098 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))) 3136 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)))
3099 { 3137 {
3100 new_draw_info_format (NDI_UNIQUE, 0, who, 3138 who->failmsg (format ("No matter how hard you try, you just can't remove %s." CANNOT_REMOVE_CURSED, query_name (op)));
3101 "No matter how hard you try, you just can't remove %s." CANNOT_REMOVE_CURSED,
3102 query_name (op));
3103 return 1; 3139 return 1;
3104 } 3140 }
3105 3141
3106 return unapply_special (who, op, aflags); 3142 return unapply_special (who, op, aflags);
3107 } 3143 }
3123 /* Can't just apply this object. Lets see what not and what to do */ 3159 /* Can't just apply this object. Lets see what not and what to do */
3124 if (int i = can_apply_object (who, op)) 3160 if (int i = can_apply_object (who, op))
3125 { 3161 {
3126 if (i & CAN_APPLY_NEVER) 3162 if (i & CAN_APPLY_NEVER)
3127 { 3163 {
3128 new_draw_info_format (NDI_UNIQUE, 0, who, 3164 who->failmsg (format ("You don't have the body to use a %s. H<You can never apply this item.>", query_name (op)));
3129 "You don't have the body to use a %s. H<You can never apply this item.>",
3130 query_name (op));
3131 return 1; 3165 return 1;
3132 } 3166 }
3133 else if (i & CAN_APPLY_RESTRICTION) 3167 else if (i & CAN_APPLY_RESTRICTION)
3134 { 3168 {
3135 new_draw_info_format (NDI_UNIQUE, 0, who, 3169 who->failmsg (format (
3136 "You have a prohibition against using a %s. " 3170 "You have a prohibition against using a %s. "
3137 "H<Your belief, profession or class prevents you from applying this item.>", 3171 "H<Your belief, profession or class prevents you from applying this item.>",
3138 query_name (op)); 3172 query_name (op)
3173 ));
3139 return 1; 3174 return 1;
3140 } 3175 }
3141 3176
3142 if (who->type != PLAYER) 3177 if (who->type != PLAYER)
3143 { 3178 {
3147 } 3182 }
3148 else 3183 else
3149 { 3184 {
3150 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice)) 3185 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice))
3151 { 3186 {
3152 new_draw_info (NDI_UNIQUE, 0, who, "You need to unapply some of the following item(s) or change your applymode:"); 3187 who->failmsg ("You need to unapply some of the following item(s) or change your applymode:");
3153 unapply_for_ob (who, op, AP_PRINT); 3188 unapply_for_ob (who, op, AP_PRINT);
3154 return 1; 3189 return 1;
3155 } 3190 }
3156 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE)) 3191 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE))
3157 if (unapply_for_ob (who, op, aflags)) 3192 if (unapply_for_ob (who, op, aflags))
3163 { 3198 {
3164 skop = find_skill_by_name (who, op->skill); 3199 skop = find_skill_by_name (who, op->skill);
3165 3200
3166 if (!skop) 3201 if (!skop)
3167 { 3202 {
3168 new_draw_info_format (NDI_UNIQUE, 0, who, "You need the %s skill to use this item!", &op->skill); 3203 who->failmsg (format ("You need the %s skill to use this item!", &op->skill));
3169 return 1; 3204 return 1;
3170 } 3205 }
3171 else 3206 else
3172 /* While experience will be credited properly, we want to change the 3207 /* While experience will be credited properly, we want to change the
3173 * skill so that the dam and wc get updated 3208 * skill so that the dam and wc get updated
3177 3212
3178 if (who->type == PLAYER 3213 if (who->type == PLAYER
3179 && op->item_power 3214 && op->item_power
3180 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level) 3215 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level)
3181 { 3216 {
3182 new_draw_info (NDI_UNIQUE, 0, who,
3183 "Equipping that combined with other items would consume your soul!" LACK_ITEM_POWER); 3217 who->failmsg ("Equipping that combined with other items would consume your soul!" LACK_ITEM_POWER);
3184 return 1; 3218 return 1;
3185 } 3219 }
3186 3220
3187 /* Ok. We are now at the state where we can apply the new object. 3221 /* Ok. We are now at the state where we can apply the new object.
3188 * Note that we don't have the checks for can_use_... 3222 * Note that we don't have the checks for can_use_...
3199 switch (op->type) 3233 switch (op->type)
3200 { 3234 {
3201 case WEAPON: 3235 case WEAPON:
3202 if (!check_weapon_power (who, op->last_eat)) 3236 if (!check_weapon_power (who, op->last_eat))
3203 { 3237 {
3204 new_draw_info (NDI_UNIQUE, 0, who, "This weapon is too powerful for you to use. " 3238 op->failmsg ("This weapon is too powerful for you to use. It would consume your soul!." LACK_ITEM_POWER);
3205 "It would consume your soul!." LACK_ITEM_POWER);
3206 3239
3207 if (tmp) 3240 if (tmp)
3208 insert_ob_in_ob (tmp, who); 3241 insert_ob_in_ob (tmp, who);
3209 3242
3210 return 1; 3243 return 1;
3214 // i.e. "R" can use Ragnarok's sword. 3247 // i.e. "R" can use Ragnarok's sword.
3215 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3248 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3216 { 3249 {
3217 /* if the weapon does not have the name as the character, can't use it. */ 3250 /* if the weapon does not have the name as the character, can't use it. */
3218 /* (Ragnarok's sword attempted to be used by Foo: won't work) */ 3251 /* (Ragnarok's sword attempted to be used by Foo: won't work) */
3219 new_draw_info (NDI_UNIQUE, 0, who, 3252 who->failmsg ("The weapon does not recognize you as its owner. H<Its name indicates that it belongs to somebody else.>");
3220 "The weapon does not recognize you as its owner. "
3221 "H<Its name indicates that it belongs to somebody else.>");
3222 3253
3223 if (tmp) 3254 if (tmp)
3224 insert_ob_in_ob (tmp, who); 3255 insert_ob_in_ob (tmp, who);
3225 3256
3226 return 1; 3257 return 1;
3227 } 3258 }
3228 3259
3229 if (!skop) 3260 if (!skop)
3230 { 3261 {
3231 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO 3262 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3232 return 1; 3263 return 1;
3233 } 3264 }
3234 3265
3235 SET_FLAG (op, FLAG_APPLIED); 3266 SET_FLAG (op, FLAG_APPLIED);
3236 who->change_skill (skop); 3267 who->change_skill (skop);
3237 3268
3238 if (who->contr) 3269 if (who->contr)
3239 who->change_weapon (who->contr->combat_ob = op); 3270 who->change_weapon (who->contr->combat_ob = op);
3240 3271
3241 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op)); 3272 who->statusmsg (format ("You wield %s.", query_name (op)));
3242 3273
3243 SET_FLAG (who, FLAG_READY_WEAPON); 3274 SET_FLAG (who, FLAG_READY_WEAPON);
3244 change_abil (who, op); 3275 change_abil (who, op);
3245 break; 3276 break;
3246 3277
3253 case BRACERS: 3284 case BRACERS:
3254 case CLOAK: 3285 case CLOAK:
3255 case RING: 3286 case RING:
3256 case AMULET: 3287 case AMULET:
3257 SET_FLAG (op, FLAG_APPLIED); 3288 SET_FLAG (op, FLAG_APPLIED);
3258 new_draw_info_format (NDI_UNIQUE, 0, who, "You wear %s.", query_name (op)); 3289 who->statusmsg (format ("You wear %s.", query_name (op)));
3259 change_abil (who, op); 3290 change_abil (who, op);
3260 break; 3291 break;
3261 3292
3262 case LAMP: 3293 case LAMP:
3263 if (op->stats.food < 1) 3294 if (op->stats.food < 1)
3264 { 3295 {
3265 new_draw_info_format (NDI_UNIQUE, 0, who, 3296 who->failmsg (format (
3266 "Your %s is out of fuel! " 3297 "Your %s is out of fuel! "
3267 "H<Lamps and similar items need fuel. They cannot be refilled.>", &op->name); 3298 "H<Lamps and similar items need fuel. They cannot be refilled.>",
3299 &op->name
3300 ));
3268 return 1; 3301 return 1;
3269 } 3302 }
3270 3303
3271 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn on your %s.", &op->name); 3304 who->statusmsg (format ("You turn on your %s.", &op->name));
3305
3272 tmp2 = arch_to_object (op->other_arch); 3306 tmp2 = arch_to_object (op->other_arch);
3273 tmp2->stats.food = op->stats.food; 3307 tmp2->stats.food = op->stats.food;
3274 SET_FLAG (tmp2, FLAG_APPLIED); 3308 SET_FLAG (tmp2, FLAG_APPLIED);
3275 3309
3276 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 3310 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
3295 who->update_stats (); 3329 who->update_stats ();
3296 3330
3297 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3331 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3298 if (who->type == PLAYER) 3332 if (who->type == PLAYER)
3299 { 3333 {
3300 new_draw_info (NDI_UNIQUE, 0, who,
3301 "Oops, it feels deadly cold! "
3302 "H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>"); 3334 who->failmsg ("Oops, it feels deadly cold! H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>");
3303 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 3335 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
3304 } 3336 }
3305 3337
3306 if (who->type == PLAYER) 3338 if (who->type == PLAYER)
3307 esrv_send_item (who, tmp2); 3339 esrv_send_item (who, tmp2);
3335 who->change_weapon (pl->combat_ob = item); 3367 who->change_weapon (pl->combat_ob = item);
3336 goto found_weapon; 3368 goto found_weapon;
3337 } 3369 }
3338 } 3370 }
3339 3371
3340 new_draw_info_format (NDI_UNIQUE, 0, who, 3372 who->failmsg (format (
3341 "You need to apply a '%s' melee weapon before readying this skill. " 3373 "You need to apply a '%s' melee weapon before readying this skill. "
3342 "H<Some skills need an item, in this case a melee weapon, to function.>", 3374 "H<Some skills need an item, in this case a melee weapon, to function.>",
3343 &op->skill); 3375 &op->skill
3376 ));
3344 return 1; 3377 return 1;
3345 3378
3346 found_weapon:; 3379 found_weapon:;
3347 } 3380 }
3348 else 3381 else
3358 //TODO: bows should/must all have skill missile weapon right now 3391 //TODO: bows should/must all have skill missile weapon right now
3359 who->change_weapon (pl->ranged_ob = item); 3392 who->change_weapon (pl->ranged_ob = item);
3360 goto found_bow; 3393 goto found_bow;
3361 } 3394 }
3362 3395
3363 new_draw_info (NDI_UNIQUE, 0, who, 3396 who->failmsg (
3364 "You need to apply a missile weapon before readying this skill. " 3397 "You need to apply a missile weapon before readying this skill. "
3365 "H<Some skills need an item, in this case a missile weapon, to function.>"); 3398 "H<Some skills need an item, in this case a missile weapon, to function.>"
3399 );
3366 return 1; 3400 return 1;
3367 3401
3368 found_bow:; 3402 found_bow:;
3369 } 3403 }
3370 else 3404 else
3371 who->change_weapon (pl->ranged_ob = op); 3405 who->change_weapon (pl->ranged_ob = op);
3372 } 3406 }
3373 3407
3374 if (!op->invisible) 3408 if (!op->invisible)
3375 { 3409 {
3376 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3410 who->statusmsg (format (
3377 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill); 3411 "You ready %s."
3412 "You can now use the skill: %s.",
3413 query_name (op),
3414 &op->skill
3415 ));
3378 } 3416 }
3379 else 3417 else
3380 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name); 3418 who->statusmsg (format ("Readied skill: %s.", op->skill ? &op->skill : &op->name));
3381 } 3419 }
3382 else 3420 else
3383 { 3421 {
3384 SET_FLAG (op, FLAG_APPLIED); 3422 SET_FLAG (op, FLAG_APPLIED);
3385 change_abil (who, op); 3423 change_abil (who, op);
3390 break; 3428 break;
3391 3429
3392 case BOW: 3430 case BOW:
3393 if (!check_weapon_power (who, op->last_eat)) 3431 if (!check_weapon_power (who, op->last_eat))
3394 { 3432 {
3395 new_draw_info (NDI_UNIQUE, 0, who,
3396 "That weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER); 3433 who->failmsg ("That weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3397 3434
3398 if (tmp) 3435 if (tmp)
3399 insert_ob_in_ob (tmp, who); 3436 insert_ob_in_ob (tmp, who);
3400 3437
3401 return 1; 3438 return 1;
3402 } 3439 }
3403 3440
3404 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3441 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3405 { 3442 {
3406 new_draw_info (NDI_UNIQUE, 0, who,
3407 "The weapon does not recognize you as its owner. " 3443 who->failmsg ("The weapon does not recognize you as its owner. "
3408 "H<Its name indicates that it belongs to somebody else.>"); 3444 "H<Its name indicates that it belongs to somebody else.>");
3409 if (tmp) 3445 if (tmp)
3410 insert_ob_in_ob (tmp, who); 3446 insert_ob_in_ob (tmp, who);
3411 3447
3412 return 1; 3448 return 1;
3418 case HORN: 3454 case HORN:
3419 /* check for skill, alter player status */ 3455 /* check for skill, alter player status */
3420 3456
3421 if (!skop) 3457 if (!skop)
3422 { 3458 {
3423 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s is broken, please report this to the dungeon master!", query_name (op));//TODO 3459 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3424 return 1; 3460 return 1;
3425 } 3461 }
3426 3462
3427 SET_FLAG (op, FLAG_APPLIED); 3463 SET_FLAG (op, FLAG_APPLIED);
3428 who->change_skill (skop); 3464 who->change_skill (skop);
3429 3465
3430 if (who->contr) 3466 if (who->contr)
3431 { 3467 {
3432 who->contr->ranged_ob = op; 3468 who->contr->ranged_ob = op;
3433 3469
3434 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3470 who->statusmsg (format ("You ready %s.", query_name (op)));
3435 3471
3436 if (op->type == BOW) 3472 if (op->type == BOW)
3437 { 3473 {
3438 who->current_weapon = op; 3474 who->current_weapon = op;
3439 change_abil (who, op); 3475 change_abil (who, op);
3440 new_draw_info_format (NDI_UNIQUE, 0, who,
3441 "You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)); 3476 who->statusmsg (format ("You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)));
3442 } 3477 }
3443 } 3478 }
3444 else 3479 else
3445 { 3480 {
3446 if (op->type == BOW) 3481 if (op->type == BOW)
3456 { 3491 {
3457 //TODO: wtf does this do? shouldn't this be managed automatically (slots?) 3492 //TODO: wtf does this do? shouldn't this be managed automatically (slots?)
3458 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER) 3493 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER)
3459 unapply_special (who, who->contr->ranged_ob, 0); 3494 unapply_special (who, who->contr->ranged_ob, 0);
3460 3495
3461 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op)); 3496 who->statusmsg (format ("You ready your %s.", query_name (op)));
3462 3497
3463 who->contr->ranged_ob = op; 3498 who->contr->ranged_ob = op;
3464 } 3499 }
3465 break; 3500 break;
3466 3501
3467 default: 3502 default:
3468 new_draw_info_format (NDI_UNIQUE, 0, who, "You apply %s.", query_name (op)); 3503 who->statusmsg (format ("You apply %s.", query_name (op)));
3469 } /* end of switch op->type */ 3504 }
3470 3505
3471 SET_FLAG (op, FLAG_APPLIED); 3506 SET_FLAG (op, FLAG_APPLIED);
3472 3507
3473 if (tmp) 3508 if (tmp)
3474 tmp = insert_ob_in_ob (tmp, who); 3509 tmp = insert_ob_in_ob (tmp, who);
3483 SET_FLAG (op, FLAG_BEEN_APPLIED); 3518 SET_FLAG (op, FLAG_BEEN_APPLIED);
3484 3519
3485 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3520 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3486 if (who->type == PLAYER) 3521 if (who->type == PLAYER)
3487 { 3522 {
3488 new_draw_info (NDI_UNIQUE, 0, who, 3523 who->failmsg (
3489 "Oops, it feels deadly cold! " 3524 "Oops, it feels deadly cold! "
3490 "H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>"); 3525 "H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>"
3526 );
3491 SET_FLAG (op, FLAG_KNOWN_CURSED); 3527 SET_FLAG (op, FLAG_KNOWN_CURSED);
3492 } 3528 }
3493 3529
3494 if (who->type == PLAYER) 3530 if (who->type == PLAYER)
3495 { 3531 {
3733 { 3769 {
3734 if (QUERY_FLAG (food, FLAG_CURSED)) 3770 if (QUERY_FLAG (food, FLAG_CURSED))
3735 { 3771 {
3736 assign (who->contr->killer, food->name); 3772 assign (who->contr->killer, food->name);
3737 hit_player (who, food->stats.hp, food, AT_POISON, 1); 3773 hit_player (who, food->stats.hp, food, AT_POISON, 1);
3738 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3774 who->failmsg ("Eck!...that was poisonous!");
3739 } 3775 }
3740 else 3776 else
3741 { 3777 {
3742 if (food->stats.hp > 0) 3778 if (food->stats.hp > 0)
3743 new_draw_info (NDI_UNIQUE, 0, who, "You begin to feel better."); 3779 who->statusmsg ("You begin to feel better.");
3744 else 3780 else
3745 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3781 who->failmsg ("Eck!...that was poisonous!");
3782
3746 who->stats.hp += food->stats.hp; 3783 who->stats.hp += food->stats.hp;
3747 } 3784 }
3748 } 3785 }
3749 if (food->stats.sp != 0) 3786 if (food->stats.sp != 0)
3750 { 3787 {
3751 if (QUERY_FLAG (food, FLAG_CURSED)) 3788 if (QUERY_FLAG (food, FLAG_CURSED))
3752 { 3789 {
3753 new_draw_info (NDI_UNIQUE, 0, who, "You are drained of mana!"); 3790 who->failmsg ("You are drained of mana!");
3754 who->stats.sp -= food->stats.sp; 3791 who->stats.sp -= food->stats.sp;
3755 if (who->stats.sp < 0) 3792 if (who->stats.sp < 0)
3756 who->stats.sp = 0; 3793 who->stats.sp = 0;
3757 } 3794 }
3758 else 3795 else
3759 { 3796 {
3760 new_draw_info (NDI_UNIQUE, 0, who, "You feel a rush of magical energy!"); 3797 who->statusmsg ("You feel a rush of magical energy!");
3761 who->stats.sp += food->stats.sp; 3798 who->stats.sp += food->stats.sp;
3762 /* place limit on max sp from food? */ 3799 /* place limit on max sp from food? */
3763 } 3800 }
3764 } 3801 }
3802
3765 who->update_stats (); 3803 who->update_stats ();
3766} 3804}
3767 3805
3768/** 3806/**
3769 * Designed primarily to light torches/lanterns/etc. 3807 * Designed primarily to light torches/lanterns/etc.
3796 } 3834 }
3797 else 3835 else
3798 lighter->stats.food--; 3836 lighter->stats.food--;
3799 } 3837 }
3800 else if (lighter->last_eat) 3838 else if (lighter->last_eat)
3839 {
3801 { /* no charges left in lighter */ 3840 /* no charges left in lighter */
3802 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with a used up %s.", &item->name, &lighter->name); 3841 who->failmsg (format ("You attempt to light the %s with a used up %s.", &item->name, &lighter->name));
3803 return; 3842 return;
3804 } 3843 }
3805 3844
3806 /* Perhaps we should split what we are trying to light on fire? 3845 /* Perhaps we should split what we are trying to light on fire?
3807 * I can't see many times when you would want to light multiple 3846 * I can't see many times when you would want to light multiple
3813 3852
3814 save_throw_object (item, AT_FIRE, who); 3853 save_throw_object (item, AT_FIRE, who);
3815 3854
3816 if (item->destroyed ()) 3855 if (item->destroyed ())
3817 { 3856 {
3818 new_draw_info_format (NDI_UNIQUE, 0, who, "You light the %s with the %s.", &item->name, &lighter->name); 3857 who->statusmsg (format ("You light the %s with the %s.", &item->name, &lighter->name));
3819 /* Need to update the player so that the players glow radius 3858 /* Need to update the player so that the players glow radius
3820 * gets changed. 3859 * gets changed.
3821 */ 3860 */
3822 if (is_player_env) 3861 if (is_player_env)
3823 who->update_stats (); 3862 who->update_stats ();
3824 } 3863 }
3825 else 3864 else
3826 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with the %s and fail.", &item->name, &lighter->name); 3865 who->failmsg (format ("You attempt to light the %s with the %s and fail.", &item->name, &lighter->name));
3827 } 3866 }
3828 else /* nothing to light */ 3867 else
3829 new_draw_info (NDI_UNIQUE, 0, who, "You need to mark a lightable object."); 3868 who->failmsg ("You need to mark a lightable object.");
3830
3831} 3869}
3832 3870
3833/** 3871/**
3834 * op made some mistake with a scroll, this takes care of punishment. 3872 * op made some mistake with a scroll, this takes care of punishment.
3835 * scroll_failure()- hacked directly from spell_failure 3873 * scroll_failure()- hacked directly from spell_failure
3842 3880
3843 if (failure <= -1 && failure > -15) 3881 if (failure <= -1 && failure > -15)
3844 { /* wonder */ 3882 { /* wonder */
3845 object *tmp; 3883 object *tmp;
3846 3884
3847 new_draw_info (NDI_UNIQUE, 0, op, "Your spell warps!"); 3885 op->failmsg ("Your spell warps!");
3848 tmp = get_archetype (SPELL_WONDER); 3886 tmp = get_archetype (SPELL_WONDER);
3849 cast_wonder (op, op, 0, tmp); 3887 cast_wonder (op, op, 0, tmp);
3850 tmp->destroy (); 3888 tmp->destroy ();
3851 } 3889 }
3852 else if (failure <= -15 && failure > -35) 3890 else if (failure <= -15 && failure > -35)
3853 { /* drain mana */ 3891 { /* drain mana */
3854 new_draw_info (NDI_UNIQUE, 0, op, "Your mana is drained!."); 3892 op->failmsg ("Your mana is drained!");
3855 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW); 3893 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW);
3856 if (op->stats.sp < 0) 3894 if (op->stats.sp < 0)
3857 op->stats.sp = 0; 3895 op->stats.sp = 0;
3858 } 3896 }
3859 else if (settings.spell_failure_effects == TRUE) 3897 else if (settings.spell_failure_effects == TRUE)
3860 { 3898 {
3861 if (failure <= -35 && failure > -60) 3899 if (failure <= -35 && failure > -60)
3862 { /* confusion */ 3900 { /* confusion */
3863 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3901 op->failmsg ("The magic recoils on you!");
3864 confuse_player (op, op, power); 3902 confuse_player (op, op, power);
3865 } 3903 }
3866 else if (failure <= -60 && failure > -70) 3904 else if (failure <= -60 && failure > -70)
3867 { /* paralysis */ 3905 { /* paralysis */
3868 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils and paralyzes " "you!"); 3906 op->failmsg ("The magic recoils and paralyzes you!");
3869 paralyze_player (op, op, power); 3907 paralyze_player (op, op, power);
3870 } 3908 }
3871 else if (failure <= -70 && failure > -80) 3909 else if (failure <= -70 && failure > -80)
3872 { /* blind */ 3910 { /* blind */
3873 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3911 op->failmsg ("The magic recoils on you!");
3874 blind_player (op, op, power); 3912 blind_player (op, op, power);
3875 } 3913 }
3876 else if (failure <= -80) 3914 else if (failure <= -80)
3877 { /* blast the immediate area */ 3915 { /* blast the immediate area */
3878 object *tmp = get_archetype (LOOSE_MANA); 3916 object *tmp = get_archetype (LOOSE_MANA);
3879 cast_magic_storm (op, tmp, power); 3917 cast_magic_storm (op, tmp, power);
3880 new_draw_info (NDI_UNIQUE, 0, op, "You unleash uncontrolled mana!"); 3918 op->failmsg ("You unleash uncontrolled mana!");
3881 tmp->destroy (); 3919 tmp->destroy ();
3882 } 3920 }
3883 } 3921 }
3884} 3922}
3885 3923
3997 4035
3998 marked = find_marked_object (pl); 4036 marked = find_marked_object (pl);
3999 4037
4000 if (!marked) 4038 if (!marked)
4001 { 4039 {
4002 new_draw_info_format (NDI_UNIQUE, 0, pl, "Use the %s with what item?", query_name (transformer)); 4040 pl->failmsg (format ("Use the %s with what item?", query_name (transformer)));
4003 return; 4041 return;
4004 } 4042 }
4005 4043
4006 if (!marked->slaying) 4044 if (!marked->slaying)
4007 { 4045 {
4008 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 4046 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4009 return; 4047 return;
4010 } 4048 }
4011 4049
4012 /* check whether they are compatible or not */ 4050 /* check whether they are compatible or not */
4013 find = strstr (marked->slaying, transformer->arch->archname); 4051 find = strstr (marked->slaying, transformer->arch->archname);
4014 if (!find || (*(find + strlen (transformer->arch->archname)) != ':')) 4052 if (!find || (*(find + strlen (transformer->arch->archname)) != ':'))
4015 { 4053 {
4016 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 4054 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4017 return; 4055 return;
4018 } 4056 }
4019 4057
4020 find += strlen (transformer->arch->archname) + 1; 4058 find += strlen (transformer->arch->archname) + 1;
4021 /* Item can be used, now find how many and what it yields */ 4059 /* Item can be used, now find how many and what it yields */
4031 else 4069 else
4032 yield = 1; 4070 yield = 1;
4033 4071
4034 while (isdigit (*find)) 4072 while (isdigit (*find))
4035 find++; 4073 find++;
4074
4036 while (*find == ' ') 4075 while (*find == ' ')
4037 find++; 4076 find++;
4038 4077
4039 memset (got, 0, MAX_BUF); 4078 memset (got, 0, MAX_BUF);
4040 4079
4051 4090
4052 /* Now create new item, remove used ones when required. */ 4091 /* Now create new item, remove used ones when required. */
4053 new_item = get_archetype (got); 4092 new_item = get_archetype (got);
4054 if (!new_item) 4093 if (!new_item)
4055 { 4094 {
4056 new_draw_info_format (NDI_UNIQUE, 0, pl, "This %s is strange, better to not use it.", query_base_name (marked, 0)); 4095 pl->failmsg (format ("This %s is strange, better to not use it.", query_base_name (marked, 0)));
4057 return; 4096 return;
4058 } 4097 }
4059 4098
4060 new_item->nrof = yield; 4099 new_item->nrof = yield;
4100
4061 new_draw_info_format (NDI_UNIQUE, 0, pl, "You %s the %s.", &transformer->slaying, query_base_name (marked, 0)); 4101 pl->statusmsg (format ("You %s the %s.", &transformer->slaying, query_base_name (marked, 0)));
4102
4062 insert_ob_in_ob (new_item, pl); 4103 insert_ob_in_ob (new_item, pl);
4063 esrv_send_inventory (pl, pl); 4104 esrv_send_inventory (pl, pl);
4064 /* Eat up one item */ 4105 /* Eat up one item */
4065 decrease_ob_nr (marked, 1); 4106 decrease_ob_nr (marked, 1);
4066 4107
4067 /* Eat one transformer if needed */ 4108 /* Eat one transformer if needed */
4068 if (transformer->stats.food) 4109 if (transformer->stats.food)
4069 if (--transformer->stats.food == 0) 4110 if (--transformer->stats.food == 0)
4070 decrease_ob_nr (transformer, 1); 4111 decrease_ob_nr (transformer, 1);
4071} 4112}
4113

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines