ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/apply.C
(Generate patch)

Comparing deliantra/server/server/apply.C (file contents):
Revision 1.38 by root, Tue Dec 12 22:37:05 2006 UTC vs.
Revision 1.178 by root, Sun Dec 28 15:28:47 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The authors can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23
24#include <cmath>
23 25
24#include <global.h> 26#include <global.h>
25#include <living.h> 27#include <living.h>
26#include <spells.h> 28#include <spells.h>
27#include <skills.h> 29#include <skills.h>
28#include <tod.h> 30#include <tod.h>
29 31
30#ifndef __CEXTRACT__
31# include <sproto.h> 32#include <sproto.h>
32#endif
33 33
34/* Want this regardless of rplay. */ 34/* Want this regardless of rplay. */
35#include <sounds.h> 35#include <sounds.h>
36
37/* need math lib for double-precision and pow() in dragon_eat_flesh() */
38#include <math.h>
39 36
40/** 37/**
41 * Check if op should abort moving victim because of it's race or slaying. 38 * Check if op should abort moving victim because of it's race or slaying.
42 * Returns 1 if it should abort, returns 0 if it should continue. 39 * Returns 1 if it should abort, returns 0 if it should continue.
43 */ 40 */
… …
56 * subtype 5: arch or race 53 * subtype 5: arch or race
57 * subtype 7: all three 54 * subtype 7: all three
58 */ 55 */
59 if (op->subtype) 56 if (op->subtype)
60 { 57 {
61 arch_flag = (op->subtype & 1); 58 arch_flag = op->subtype & 1;
62 name_flag = (op->subtype & 2); 59 name_flag = op->subtype & 2;
63 race_flag = (op->subtype & 4); 60 race_flag = op->subtype & 4;
64 } 61 }
65 else 62 else
66 { 63 {
67 arch_flag = 1; 64 arch_flag = 1;
68 name_flag = 1; 65 name_flag = 1;
69 race_flag = 1; 66 race_flag = 1;
70 } 67 }
68
71 /* If the director has race set, only affect objects with a arch, 69 /* If the director has race set, only affect objects with a arch,
72 * name or race that matches. 70 * name or race that matches.
73 */ 71 */
74 if ((op->race) && 72 if ((op->race) &&
75 ((!(victim->arch && arch_flag && victim->arch->name) || strcmp (op->race, victim->arch->name))) && 73 ((!(victim->arch && arch_flag && victim->arch->archname) || op->race != victim->arch->archname)) &&
76 ((!(victim->name && name_flag) || strcmp (op->race, victim->name))) && 74 ((!(victim->name && name_flag) || op->race != victim->name)) &&
77 ((!(victim->race && race_flag) || strcmp (op->race, victim->race)))) 75 ((!(victim->race && race_flag) || op->race != victim->race)))
78 {
79 return 1; 76 return 1;
80 } 77
81 /* If the director has slaying set, only affect objects where none 78 /* If the director has slaying set, only affect objects where none
82 * of arch, name, or race match. 79 * of arch, name, or race match.
83 */ 80 */
84 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->name && !strcmp (op->slaying, victim->arch->name))) || 81 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->archname && op->slaying == victim->arch->archname))) ||
85 ((victim->name && name_flag && !strcmp (op->slaying, victim->name))) || 82 ((victim->name && name_flag && op->slaying == victim->name)) ||
86 ((victim->race && race_flag && !strcmp (op->slaying, victim->race))))) 83 ((victim->race && race_flag && op->slaying == victim->race)))
87 {
88 return 1; 84 return 1;
89 } 85
90 return 0; 86 return 0;
91} 87}
92 88
93/** 89/**
94 * This handles a player dropping money on an altar to identify stuff. 90 * This handles a player dropping money on an altar to identify stuff.
… …
96 * Return value: 1 if money was destroyed, 0 if not. 92 * Return value: 1 if money was destroyed, 0 if not.
97 */ 93 */
98static int 94static int
99apply_id_altar (object *money, object *altar, object *pl) 95apply_id_altar (object *money, object *altar, object *pl)
100{ 96{
101 object *id, *marked; 97 dynbuf_text buf;
102 int success = 0;
103 98
104 if (pl == NULL || pl->type != PLAYER) 99 if (!pl || pl->type != PLAYER)
105 return 0; 100 return 0;
106 101
107 /* Check for MONEY type is a special hack - it prevents 'nothing needs 102 /* Check for MONEY type is a special hack - it prevents 'nothing needs
108 * identifying' from being printed out more than it needs to be. 103 * identifying' from being printed out more than it needs to be.
109 */ 104 */
110 if (!check_altar_sacrifice (altar, money) || money->type != MONEY) 105 if (!check_altar_sacrifice (altar, money) || money->type != MONEY)
111 return 0; 106 return 0;
112 107
113 marked = find_marked_object (pl);
114 /* if the player has a marked item, identify that if it needs to be 108 /* if the player has a marked item, identify that if it needs to be
115 * identified. IF it doesn't, then go through the player inventory. 109 * identified. If it doesn't, then go through the player inventory.
116 */ 110 */
111 if (object *marked = find_marked_object (pl))
117 if (marked && !QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked)) 112 if (!QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked))
118 { 113 {
119 if (operate_altar (altar, &money)) 114 if (operate_altar (altar, &money))
120 { 115 {
121 identify (marked); 116 identify (marked);
122 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (marked, pl)); 117
118 buf.printf ("You have %s.\r", long_desc (marked, pl));
123 if (marked->msg) 119 if (marked->msg)
124 { 120 buf << "The item has a story:\r" << marked->msg << "\n\n";
125 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 121
126 new_draw_info (NDI_UNIQUE, 0, pl, marked->msg); 122 return !money;
127 } 123 }
128 return money == NULL;
129 } 124 }
130 }
131 125
132 for (id = pl->inv; id; id = id->below) 126 for (object *id = pl->inv; id; id = id->below)
133 { 127 {
134 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id)) 128 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id))
135 { 129 {
136 if (operate_altar (altar, &money)) 130 if (operate_altar (altar, &money))
137 { 131 {
138 identify (id); 132 identify (id);
139 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (id, pl)); 133
134 buf.printf ("You have %s.\r", long_desc (id, pl));
140 if (id->msg) 135 if (id->msg)
141 { 136 buf << "The item has a story:\r" << id->msg << "\n\n";
142 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 137
143 new_draw_info (NDI_UNIQUE, 0, pl, id->msg);
144 }
145 success = 1;
146 /* If no more money, might as well quit now */ 138 /* If no more money, might as well quit now */
147 if (money == NULL || !check_altar_sacrifice (altar, money)) 139 if (!money || !check_altar_sacrifice (altar, money))
148 break; 140 break;
149 } 141 }
150 else 142 else
151 { 143 {
152 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n"); 144 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n");
153 break; 145 break;
154 } 146 }
155 } 147 }
156 } 148 }
157 if (!success) 149
158 new_draw_info (NDI_UNIQUE, 0, pl, "You have nothing that needs identifying"); 150 if (buf.empty ())
151 pl->failmsg ("You have nothing that needs identifying");
152 else
153 pl->contr->infobox (MSG_CHANNEL ("identify"), buf);
154
159 return money == NULL; 155 return !money;
160} 156}
161 157
162/** 158/**
163 * This checks whether the object has a "on_use_yield" field, and if so generated and drops 159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops
164 * matching item. 160 * matching item.
165 **/ 161 **/
166static void 162void
167handle_apply_yield (object *tmp) 163handle_apply_yield (object *tmp)
168{ 164{
169 const char *yield; 165 if (shstr yield = tmp->kv (shstr_on_use_yield))
170 166 archetype::get (yield)->insert_at (tmp, tmp, INS_BELOW_ORIGINATOR);
171 yield = get_ob_key_value (tmp, "on_use_yield");
172 if (yield != NULL)
173 {
174 object *drop = get_archetype (yield);
175
176 if (tmp->env)
177 {
178 drop = insert_ob_in_ob (drop, tmp->env);
179 if (tmp->env->type == PLAYER)
180 esrv_send_item (tmp->env, drop);
181 }
182 else
183 {
184 drop->x = tmp->x;
185 drop->y = tmp->y;
186 insert_ob_in_map (drop, tmp->map, tmp, INS_BELOW_ORIGINATOR);
187 }
188 }
189} 167}
190 168
191/** 169/**
192 * Handles applying a potion. 170 * Handles applying a potion.
193 */ 171 */
… …
195apply_potion (object *op, object *tmp) 173apply_potion (object *op, object *tmp)
196{ 174{
197 int got_one = 0, i; 175 int got_one = 0, i;
198 object *force = 0, *floor = 0; 176 object *force = 0, *floor = 0;
199 177
200 floor = get_map_ob (op->map, op->x, op->y); 178 floor = GET_MAP_OB (op->map, op->x, op->y);
201 179
202 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE) 180 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE)
203 { 181 {
204 if (op->type == PLAYER)
205 new_draw_info (NDI_UNIQUE, 0, op, "Gods prevent you from using this here, it's sacred ground!"); 182 op->failmsg ("Gods prevent you from using this here, it's sacred ground!");
183
206 CLEAR_FLAG (tmp, FLAG_APPLIED); 184 CLEAR_FLAG (tmp, FLAG_APPLIED);
207 return 0; 185 return 0;
208 } 186 }
209 187
210 if (op->type == PLAYER) 188 if (op->type == PLAYER)
… …
219 object *depl; 197 object *depl;
220 archetype *at; 198 archetype *at;
221 199
222 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 200 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
223 { 201 {
224 drain_stat (op); 202 op->drain_stat ();
225 fix_player (op); 203 op->update_stats ();
226 decrease_ob (tmp); 204 tmp->decrease ();
227 return 1; 205 return 1;
228 } 206 }
229 207
230 if ((at = archetype::find (ARCH_DEPLETION)) == NULL) 208 if (!(at = archetype::find (ARCH_DEPLETION)))
231 { 209 {
232 LOG (llevError, "Could not find archetype depletion\n"); 210 LOG (llevError, "Could not find archetype depletion\n");
233 return 0; 211 return 0;
234 } 212 }
213
235 depl = present_arch_in_ob (at, op); 214 depl = present_arch_in_ob (at, op);
236 215
237 if (depl != NULL) 216 if (depl)
238 { 217 {
239 for (i = 0; i < NUM_STATS; i++) 218 for (i = 0; i < NUM_STATS; i++)
240 if (get_attr_value (&depl->stats, i)) 219 if (depl->stats.stat (i))
241 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]); 220 op->statusmsg (restore_msg[i]);
242 221
243 depl->destroy (); 222 depl->destroy ();
244 fix_player (op); 223 op->update_stats ();
245 } 224 }
246 else 225 else
247 new_draw_info (NDI_UNIQUE, 0, op, "You potion had no effect."); 226 op->statusmsg ("Your potion had no effect.");
248 227
249 decrease_ob (tmp); 228 tmp->decrease ();
250 return 1; 229 return 1;
251 } 230 }
252 231
253 /* improvement potion - only for players */ 232 /* improvement potion - only for players */
254 if (op->type == PLAYER && tmp->attacktype & AT_GODPOWER) 233 if (op->type == PLAYER && (tmp->attacktype & AT_GODPOWER))
255 { 234 {
256 for (i = 1; i < MIN (11, op->level); i++) 235 for (i = 1; i < MIN (11, op->level); i++)
257 { 236 {
258 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 237 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
259 { 238 {
260 if (op->contr->levhp[i] != 1) 239 if (op->contr->levhp[i] != 1)
261 { 240 {
262 op->contr->levhp[i] = 1; 241 op->contr->levhp[i] = 1;
263 break; 242 break;
264 } 243 }
244
265 if (op->contr->levsp[i] != 1) 245 if (op->contr->levsp[i] != 1)
266 { 246 {
267 op->contr->levsp[i] = 1; 247 op->contr->levsp[i] = 1;
268 break; 248 break;
269 } 249 }
250
270 if (op->contr->levgrace[i] != 1) 251 if (op->contr->levgrace[i] != 1)
271 { 252 {
272 op->contr->levgrace[i] = 1; 253 op->contr->levgrace[i] = 1;
273 break; 254 break;
274 } 255 }
… …
278 if (op->contr->levhp[i] < 9) 259 if (op->contr->levhp[i] < 9)
279 { 260 {
280 op->contr->levhp[i] = 9; 261 op->contr->levhp[i] = 9;
281 break; 262 break;
282 } 263 }
264
283 if (op->contr->levsp[i] < 6) 265 if (op->contr->levsp[i] < 6)
284 { 266 {
285 op->contr->levsp[i] = 6; 267 op->contr->levsp[i] = 6;
286 break; 268 break;
287 } 269 }
270
288 if (op->contr->levgrace[i] < 3) 271 if (op->contr->levgrace[i] < 3)
289 { 272 {
290 op->contr->levgrace[i] = 3; 273 op->contr->levgrace[i] = 3;
291 break; 274 break;
292 } 275 }
… …
299 282
300 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)) 283 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))
301 { 284 {
302 if (got_one) 285 if (got_one)
303 { 286 {
304 fix_player (op); 287 op->update_stats ();
305 new_draw_info (NDI_UNIQUE, 0, op, "The Gods smile upon you and remake you"); 288 op->statusmsg ("The Gods smile upon you and remake you "
306 new_draw_info (NDI_UNIQUE, 0, op, "a little more in their image."); 289 "a little more in their image. "
307 new_draw_info (NDI_UNIQUE, 0, op, "You feel a little more perfect."); 290 "You feel a little more perfect.", NDI_GREEN);
308 } 291 }
309 else 292 else
310 new_draw_info (NDI_UNIQUE, 0, op, "The potion had no effect - you are already perfect"); 293 op->statusmsg ("The potion had no effect - you are already perfect.");
311 } 294 }
312 else 295 else
313 { /* cursed potion */ 296 { /* cursed potion */
314 if (got_one) 297 if (got_one)
315 { 298 {
316 fix_player (op); 299 op->update_stats ();
317 new_draw_info (NDI_UNIQUE, 0, op, "The Gods are angry and punish you."); 300 op->failmsg ("The Gods are angry and punish you.");
318 } 301 }
319 else 302 else
320 new_draw_info (NDI_UNIQUE, 0, op, "You are fortunate that you are so pathetic."); 303 op->statusmsg ("You are fortunate that you are so pathetic.", NDI_DK_ORANGE);
321 } 304 }
322 305
323 decrease_ob (tmp); 306 tmp->decrease ();
324 return 1; 307 return 1;
325 } 308 }
326 309
327 310
328 /* A potion that casts a spell. Healing, restore spellpoint (power potion) 311 /* A potion that casts a spell. Healing, restore spellpoint (power potion)
… …
334 { 317 {
335 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 318 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
336 { 319 {
337 object *fball; 320 object *fball;
338 321
339 new_draw_info (NDI_UNIQUE, 0, op, "Yech! Your lungs are on fire!"); 322 op->failmsg ("Yech! Your lungs are on fire!");
323
340 /* Explodes a fireball centered at player */ 324 /* Explodes a fireball centered at player */
341 fball = get_archetype (EXPLODING_FIREBALL); 325 fball = get_archetype (EXPLODING_FIREBALL);
342 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1; 326 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1;
343 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2; 327 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2;
344 fball->x = op->x; 328 fball->x = op->x;
… …
346 insert_ob_in_map (fball, op->map, NULL, 0); 330 insert_ob_in_map (fball, op->map, NULL, 0);
347 } 331 }
348 else 332 else
349 cast_spell (op, tmp, op->facing, tmp->inv, NULL); 333 cast_spell (op, tmp, op->facing, tmp->inv, NULL);
350 334
351 decrease_ob (tmp); 335 tmp->decrease ();
336
352 /* if youre dead, no point in doing this... */ 337 /* if youre dead, no point in doing this... */
353 if (!QUERY_FLAG (op, FLAG_REMOVED)) 338 if (!QUERY_FLAG (op, FLAG_REMOVED))
354 fix_player (op); 339 op->update_stats ();
340
355 return 1; 341 return 1;
356 } 342 }
357 343
358 /* Deal with protection potions */ 344 /* Deal with protection potions */
359 force = NULL; 345 force = NULL;
… …
361 { 347 {
362 if (tmp->resist[i]) 348 if (tmp->resist[i])
363 { 349 {
364 if (!force) 350 if (!force)
365 force = get_archetype (FORCE_NAME); 351 force = get_archetype (FORCE_NAME);
352
366 memcpy (force->resist, tmp->resist, sizeof (tmp->resist)); 353 memcpy (force->resist, tmp->resist, sizeof (tmp->resist));
367 force->type = POTION_EFFECT; 354 force->type = POTION_EFFECT;
368 break; /* Only need to find one protection since we copy entire batch */ 355 break; /* Only need to find one protection since we copy entire batch */
369 } 356 }
370 } 357 }
358
371 /* This is a protection potion */ 359 /* This is a protection potion */
372 if (force) 360 if (force)
373 { 361 {
374 /* cursed items last longer */ 362 /* cursed items last longer */
375 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 363 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
… …
377 force->stats.food *= 10; 365 force->stats.food *= 10;
378 for (i = 0; i < NROFATTACKS; i++) 366 for (i = 0; i < NROFATTACKS; i++)
379 if (force->resist[i] > 0) 367 if (force->resist[i] > 0)
380 force->resist[i] = -force->resist[i]; /* prot => vuln */ 368 force->resist[i] = -force->resist[i]; /* prot => vuln */
381 } 369 }
370
382 force->speed_left = -1; 371 force->speed_left = -1;
383 force = insert_ob_in_ob (force, op); 372 force = insert_ob_in_ob (force, op);
384 CLEAR_FLAG (tmp, FLAG_APPLIED); 373 CLEAR_FLAG (tmp, FLAG_APPLIED);
385 SET_FLAG (force, FLAG_APPLIED); 374 SET_FLAG (force, FLAG_APPLIED);
386 change_abil (op, force); 375 change_abil (op, force);
387 decrease_ob (tmp); 376 tmp->decrease ();
388 return 1; 377 return 1;
389 } 378 }
390 379
391 /* Only thing left are the stat potions */ 380 /* Only thing left are the stat potions */
392 if (op->type == PLAYER) 381 if (op->type == PLAYER)
393 { /* only for players */ 382 { /* only for players */
394 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0) 383 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0)
395 CLEAR_FLAG (tmp, FLAG_APPLIED); 384 CLEAR_FLAG (tmp, FLAG_APPLIED);
396 else 385 else
397 SET_FLAG (tmp, FLAG_APPLIED); 386 SET_FLAG (tmp, FLAG_APPLIED);
387
398 if (!change_abil (op, tmp)) 388 if (!change_abil (op, tmp))
399 new_draw_info (NDI_UNIQUE, 0, op, "Nothing happened."); 389 op->statusmsg ("Nothing happened.");
400 } 390 }
401 391
402 /* CLEAR_FLAG is so that if the character has other potions 392 /* CLEAR_FLAG is so that if the character has other potions
403 * that were grouped with the one consumed, his 393 * that were grouped with the one consumed, his
404 * stat will not be raised by them. fix_player just clears 394 * stat will not be raised by them. fix_player just clears
405 * up all the stats. 395 * up all the stats.
406 */ 396 */
407 CLEAR_FLAG (tmp, FLAG_APPLIED); 397 CLEAR_FLAG (tmp, FLAG_APPLIED);
408 fix_player (op); 398 op->update_stats ();
409 decrease_ob (tmp); 399 tmp->decrease ();
410 return 1; 400 return 1;
411} 401}
412 402
413/**************************************************************************** 403/****************************************************************************
414 * Weapon improvement code follows 404 * Weapon improvement code follows
… …
420static int 410static int
421check_item (object *op, const char *item) 411check_item (object *op, const char *item)
422{ 412{
423 int count = 0; 413 int count = 0;
424 414
425 415 if (!item)
426 if (item == NULL)
427 return 0; 416 return 0;
428 op = op->below; 417
429 while (op != NULL) 418 for (op = op->below; op; op = op->below)
430 { 419 {
431 if (strcmp (op->arch->name, item) == 0) 420 if (strcmp (op->arch->archname, item) == 0)
432 { 421 {
433 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED) 422 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED)
434 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID)) 423 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID))
435 { 424 {
436 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */ 425 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */
437 count++; 426 count++;
438 else 427 else
439 count += op->nrof; 428 count += op->nrof;
440 } 429 }
441 } 430 }
442 op = op->below;
443 } 431 }
432
444 return count; 433 return count;
445} 434}
446 435
447/** 436/**
448 * This removes 'nrof' of what item->slaying says to remove. 437 * This removes 'nrof' of what item->slaying says to remove.
… …
456 object *prev; 445 object *prev;
457 446
458 prev = op; 447 prev = op;
459 op = op->below; 448 op = op->below;
460 449
461 while (op != NULL) 450 while (op)
462 { 451 {
463 if (strcmp (op->arch->name, item) == 0) 452 if (strcmp (op->arch->archname, item) == 0)
464 { 453 {
465 if (op->nrof >= nrof) 454 if (op->nrof >= nrof)
466 { 455 {
467 decrease_ob_nr (op, nrof); 456 op->decrease (nrof);
468 return; 457 return;
469 } 458 }
470 else 459 else
471 { 460 {
472 decrease_ob_nr (op, op->nrof); 461 op->decrease (nrof);
473 nrof -= op->nrof; 462 nrof -= op->nrof;
474 } 463 }
464
475 op = prev; 465 op = prev;
476 } 466 }
467
477 prev = op; 468 prev = op;
478 op = op->below; 469 op = op->below;
479 } 470 }
480} 471}
481 472
… …
487 * we return 1 (true) if the player can use the weapon. 478 * we return 1 (true) if the player can use the weapon.
488 */ 479 */
489static int 480static int
490check_weapon_power (const object *who, int improvs) 481check_weapon_power (const object *who, int improvs)
491{ 482{
492
493/* Old code is below (commented out). Basically, since weapons are the only 483/* Old code is below (commented out). Basically, since weapons are the only
494 * object players really have any control to improve, it's a bit harsh to 484 * object players really have any control to improve, it's a bit harsh to
495 * require high level in some combat skill, so we just use overall level. 485 * require high level in some combat skill, so we just use overall level.
496 */ 486 */
497#if 1 487#if 1
… …
538static int 528static int
539check_sacrifice (object *op, const object *improver) 529check_sacrifice (object *op, const object *improver)
540{ 530{
541 int count = 0; 531 int count = 0;
542 532
543 if (improver->slaying != NULL) 533 if (improver->slaying)
544 { 534 {
545 count = check_item (op, improver->slaying); 535 count = check_item (op, improver->slaying);
546 if (count < 1) 536 if (count < 1)
547 { 537 {
548 char buf[200];
549
550 sprintf (buf, "The gods want more %ss", &improver->slaying); 538 op->failmsg (format ("The gods want more %ss", &improver->slaying));
551 new_draw_info (NDI_UNIQUE, 0, op, buf);
552 return 0; 539 return 0;
553 } 540 }
554 } 541 }
555 else 542 else
556 count = 1; 543 count = 1;
… …
559} 546}
560 547
561/** 548/**
562 * Actually improves the weapon, and tells user. 549 * Actually improves the weapon, and tells user.
563 */ 550 */
564int 551static int
565improve_weapon_stat (object *op, object *improver, object *weapon, signed char *stat, int sacrifice_count, const char *statname) 552improve_weapon_stat (object *op, object *improver, object *weapon, sint8 &stat, int sacrifice_count, const char *statname)
566{ 553{
567
568 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
569 *stat += sacrifice_count; 554 stat += sacrifice_count;
570 weapon->last_eat++; 555 weapon->last_eat++;
571 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon's bonus to %s improved by %d", statname, sacrifice_count); 556 improver->decrease ();
572 decrease_ob (improver);
573 557
574 /* So it updates the players stats and the window */ 558 /* So it updates the players stats and the window */
575 fix_player (op); 559 op->update_stats ();
560
561 op->statusmsg (format (
562 "Your sacrifice was accepted.\n"
563 "Weapon's bonus to %s improved by %d.",
564 statname, sacrifice_count
565 ));
566
576 return 1; 567 return 1;
577} 568}
578 569
579/* Types of improvements, hidden in the sp field. */ 570/* Types of improvements, hidden in the sp field. */
580#define IMPROVE_PREPARE 1 571#define IMPROVE_PREPARE 1
581#define IMPROVE_DAMAGE 2 572#define IMPROVE_DAMAGE 2
582#define IMPROVE_WEIGHT 3 573#define IMPROVE_WEIGHT 3
583#define IMPROVE_ENCHANT 4 574#define IMPROVE_ENCHANT 4
584#define IMPROVE_STR 5 575#define IMPROVE_STR 5
585#define IMPROVE_DEX 6 576#define IMPROVE_DEX 6
586#define IMPROVE_CON 7 577#define IMPROVE_CON 7
587#define IMPROVE_WIS 8 578#define IMPROVE_WIS 8
588#define IMPROVE_CHA 9 579#define IMPROVE_CHA 9
589#define IMPROVE_INT 10 580#define IMPROVE_INT 10
590#define IMPROVE_POW 11 581#define IMPROVE_POW 11
591
592 582
593/** 583/**
594 * This does the prepare weapon scroll. 584 * This does the prepare weapon scroll.
595 * Checks for sacrifice, and so on. 585 * Checks for sacrifice, and so on.
596 */ 586 */
597
598int 587int
599prepare_weapon (object *op, object *improver, object *weapon) 588prepare_weapon (object *op, object *improver, object *weapon)
600{ 589{
601 int sacrifice_count, i; 590 int sacrifice_count, i;
602 char buf[MAX_BUF]; 591 char buf[MAX_BUF];
603 592
604 if (weapon->level != 0) 593 if (weapon->level != 0)
605 { 594 {
606 new_draw_info (NDI_UNIQUE, 0, op, "Weapon already prepared."); 595 op->failmsg ("Weapon is already prepared!");
607 return 0; 596 return 0;
608 } 597 }
598
609 for (i = 0; i < NROFATTACKS; i++) 599 for (i = 0; i < NROFATTACKS; i++)
610 if (weapon->resist[i]) 600 if (weapon->resist[i])
611 break; 601 break;
612 602
613 /* If we break out, i will be less than nrofattacks, preventing 603 /* If we break out, i will be less than nrofattacks, preventing
… …
616 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */ 606 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */
617 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */ 607 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */
618 weapon->stats.exp || /* speed */ 608 weapon->stats.exp || /* speed */
619 weapon->stats.ac) /* AC - only taifu's I think */ 609 weapon->stats.ac) /* AC - only taifu's I think */
620 { 610 {
621 new_draw_info (NDI_UNIQUE, 0, op, "Cannot prepare magic weapons."); 611 op->failmsg ("You cannot prepare magic weapons. "
612 "H<A weapon is considered magical if it changes regeneration, "
613 "speed or ac, or has other protections.>");
622 return 0; 614 return 0;
623 } 615 }
616
624 sacrifice_count = check_sacrifice (op, improver); 617 sacrifice_count = check_sacrifice (op, improver);
625 if (sacrifice_count <= 0) 618 if (sacrifice_count <= 0)
626 return 0; 619 return 0;
620
627 weapon->level = isqrt (sacrifice_count); 621 weapon->level = isqrt (sacrifice_count);
628 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
629 eat_item (op, improver->slaying, sacrifice_count); 622 eat_item (op, improver->slaying, sacrifice_count);
630 623
631 new_draw_info_format (NDI_UNIQUE, 0, op, "Your *%s may be improved %d times.", &weapon->name, weapon->level); 624 op->statusmsg (format (
625 "Your sacrifice was accepted."
626 "Your *%s may be improved %d times.",
627 &weapon->name, weapon->level
628 ));
632 629
633 sprintf (buf, "%s's %s", &op->name, &weapon->name); 630 sprintf (buf, "%s's %s", &op->name, &weapon->name);
634 weapon->name = weapon->name_pl = buf; 631 weapon->name = weapon->name_pl = buf;
635 weapon->nrof = 0; /* prevents preparing n weapons in the same 632 weapon->nrof = 0; /* prevents preparing n weapons in the same
636 slot at once! */ 633 slot at once! */
637 decrease_ob (improver); 634 improver->decrease ();
638 weapon->last_eat = 0; 635 weapon->last_eat = 0;
639 return 1; 636 return 1;
640} 637}
641
642 638
643/** 639/**
644 * Does the dirty job for 'improve weapon' scroll, prepare or add something. 640 * Does the dirty job for 'improve weapon' scroll, prepare or add something.
645 * This is the new improve weapon code. 641 * This is the new improve weapon code.
646 * Returns 0 if it was not able to work for some reason. 642 * Returns 0 if it was not able to work for some reason.
… …
655improve_weapon (object *op, object *improver, object *weapon) 651improve_weapon (object *op, object *improver, object *weapon)
656{ 652{
657 int sacrifice_count, sacrifice_needed = 0; 653 int sacrifice_count, sacrifice_needed = 0;
658 654
659 if (improver->stats.sp == IMPROVE_PREPARE) 655 if (improver->stats.sp == IMPROVE_PREPARE)
660 {
661 return prepare_weapon (op, improver, weapon); 656 return prepare_weapon (op, improver, weapon);
662 } 657
663 if (weapon->level == 0) 658 if (weapon->level == 0)
664 { 659 {
665 new_draw_info (NDI_UNIQUE, 0, op, "This weapon has not been prepared."); 660 op->failmsg ("This weapon has not been prepared. H<You first ahve to prepare a weapon with a prepare weapon scroll.>");
666 return 0; 661 return 0;
667 } 662 }
663
668 if (weapon->level == weapon->last_eat && weapon->item_power >= 100) 664 if (weapon->level == weapon->last_eat && weapon->item_power >= 100)
669 { 665 {
670 new_draw_info (NDI_UNIQUE, 0, op, "This weapon cannot be improved any more."); 666 op->failmsg ("This weapon cannot be improved any more.");
671 return 0; 667 return 0;
672 } 668 }
669
673 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1)) 670 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1))
674 { 671 {
675 new_draw_info (NDI_UNIQUE, 0, op, "Improving the weapon will make it too"); 672 op->failmsg ("Improving the weapon will make it too "
676 new_draw_info (NDI_UNIQUE, 0, op, "powerful for you to use. Unready it if you"); 673 "powerful for you to use. Unready it if you "
677 new_draw_info (NDI_UNIQUE, 0, op, "really want to improve it."); 674 "really want to improve it.");
678 return 0; 675 return 0;
679 } 676 }
677
680 /* This just increases damage by 5 points, no matter what. No sacrifice 678 /* This just increases damage by 5 points, no matter what. No sacrifice
681 * is needed. Since stats.dam is now a 16 bit value and not 8 bit, 679 * is needed. Since stats.dam is now a 16 bit value and not 8 bit,
682 * don't put any maximum value on damage - the limit is how much the 680 * don't put any maximum value on damage - the limit is how much the
683 * weapon can be improved. 681 * weapon can be improved.
684 */ 682 */
685 if (improver->stats.sp == IMPROVE_DAMAGE) 683 if (improver->stats.sp == IMPROVE_DAMAGE)
686 { 684 {
687 weapon->stats.dam += 5; 685 weapon->stats.dam += 5;
688 weapon->weight += 5000; /* 5 KG's */ 686 weapon->weight += 5000; /* 5 KG's */
689 new_draw_info_format (NDI_UNIQUE, 0, op, "Damage has been increased by 5 to %d", weapon->stats.dam); 687 op->statusmsg (format ("Damage has been increased by 5 to %d.", weapon->stats.dam));
690 weapon->last_eat++; 688 weapon->last_eat++;
691 689
692 weapon->item_power++; 690 weapon->item_power++;
693 decrease_ob (improver); 691 improver->decrease ();
694 return 1; 692 return 1;
695 } 693 }
694
696 if (improver->stats.sp == IMPROVE_WEIGHT) 695 if (improver->stats.sp == IMPROVE_WEIGHT)
697 { 696 {
698 /* Reduce weight by 20% */ 697 /* Reduce weight by 20% */
699 weapon->weight = (weapon->weight * 8) / 10; 698 weapon->weight = (weapon->weight * 8) / 10;
700 if (weapon->weight < 1) 699 if (weapon->weight < 1)
701 weapon->weight = 1; 700 weapon->weight = 1;
701
702 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon weight reduced to %6.1f kg", (float) weapon->weight / 1000.0); 702 op->statusmsg (format ("Weapon weight reduced to %6.1fkg.", (float) weapon->weight / 1000.0));
703 weapon->last_eat++; 703 weapon->last_eat++;
704 weapon->item_power++; 704 weapon->item_power++;
705 decrease_ob (improver); 705 improver->decrease ();
706 return 1; 706 return 1;
707 } 707 }
708
708 if (improver->stats.sp == IMPROVE_ENCHANT) 709 if (improver->stats.sp == IMPROVE_ENCHANT)
709 { 710 {
710 weapon->magic++; 711 weapon->magic++;
711 weapon->last_eat++; 712 weapon->last_eat++;
712 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon magic increased to %d", weapon->magic); 713 op->statusmsg (format ("Weapon magic increased to %d.", weapon->magic));
713 decrease_ob (improver); 714 improver->decrease ();
714 weapon->item_power++; 715 weapon->item_power++;
715 return 1; 716 return 1;
716 } 717 }
717 718
718 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex + 719 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex +
… …
723 sacrifice_needed *= 2; 724 sacrifice_needed *= 2;
724 725
725 sacrifice_count = check_sacrifice (op, improver); 726 sacrifice_count = check_sacrifice (op, improver);
726 if (sacrifice_count < sacrifice_needed) 727 if (sacrifice_count < sacrifice_needed)
727 { 728 {
728 new_draw_info_format (NDI_UNIQUE, 0, op, "You need at least %d %s", sacrifice_needed, &improver->slaying); 729 op->failmsg (format ("You need at least %d %s.", sacrifice_needed, &improver->slaying));
729 return 0; 730 return 0;
730 } 731 }
732
731 eat_item (op, improver->slaying, sacrifice_needed); 733 eat_item (op, improver->slaying, sacrifice_needed);
732 weapon->item_power++; 734 weapon->item_power++;
733 735
734 switch (improver->stats.sp) 736 switch (improver->stats.sp)
735 { 737 {
736 case IMPROVE_STR:
737 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Str), 1, "strength"); 738 case IMPROVE_STR: return improve_weapon_stat (op, improver, weapon, weapon->stats.Str, 1, "strength");
738 case IMPROVE_DEX:
739 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Dex), 1, "dexterity"); 739 case IMPROVE_DEX: return improve_weapon_stat (op, improver, weapon, weapon->stats.Dex, 1, "dexterity");
740 case IMPROVE_CON:
741 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Con), 1, "constitution"); 740 case IMPROVE_CON: return improve_weapon_stat (op, improver, weapon, weapon->stats.Con, 1, "constitution");
742 case IMPROVE_WIS:
743 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Wis), 1, "wisdom"); 741 case IMPROVE_WIS: return improve_weapon_stat (op, improver, weapon, weapon->stats.Wis, 1, "wisdom");
744 case IMPROVE_CHA:
745 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Cha), 1, "charisma"); 742 case IMPROVE_CHA: return improve_weapon_stat (op, improver, weapon, weapon->stats.Cha, 1, "charisma");
746 case IMPROVE_INT:
747 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Int), 1, "intelligence"); 743 case IMPROVE_INT: return improve_weapon_stat (op, improver, weapon, weapon->stats.Int, 1, "intelligence");
748 case IMPROVE_POW:
749 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Pow), 1, "power"); 744 case IMPROVE_POW: return improve_weapon_stat (op, improver, weapon, weapon->stats.Pow, 1, "power");
750 default: 745 default:
751 new_draw_info (NDI_UNIQUE, 0, op, "Unknown improvement type."); 746 op->failmsg ("Unknown improvement type.");
752 } 747 }
748
753 LOG (llevError, "improve_weapon: Got to end of function\n"); 749 LOG (llevError, "improve_weapon: Got to end of function\n");
754 return 0; 750 return 0;
755} 751}
756 752
757/** 753/**
… …
764{ 760{
765 object *otmp; 761 object *otmp;
766 762
767 if (op->type != PLAYER) 763 if (op->type != PLAYER)
768 return 0; 764 return 0;
765
769 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 766 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC))
770 { 767 {
771 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 768 op->failmsg ("Something blocks the magic of the scroll!");
772 return 0; 769 return 0;
773 } 770 }
771
774 otmp = find_marked_object (op); 772 otmp = find_marked_object (op);
773
775 if (!otmp) 774 if (!otmp)
776 { 775 {
777 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark a weapon object."); 776 op->failmsg ("You need to mark a weapon object. H<Use the mark command or the mark option from the item popup menu.>");
778 return 0; 777 return 0;
779 } 778 }
779
780 if (otmp->type != WEAPON && otmp->type != BOW) 780 if (otmp->type != WEAPON && otmp->type != BOW)
781 { 781 {
782 new_draw_info (NDI_UNIQUE, 0, op, "Marked item is not a weapon or bow"); 782 op->failmsg ("Marked item is not a weapon or bow!");
783 return 0; 783 return 0;
784 } 784 }
785 new_draw_info (NDI_UNIQUE, 0, op, "Applied weapon builder."); 785
786 op->statusmsg ("Applied weapon builder.");
787
786 improve_weapon (op, tmp, otmp); 788 improve_weapon (op, tmp, otmp);
787 esrv_send_item (op, otmp); 789 esrv_send_item (op, otmp);
788 return 1; 790 return 1;
789} 791}
790 792
… …
815{ 817{
816 object *tmp; 818 object *tmp;
817 819
818 if (armour->magic >= settings.armor_max_enchant) 820 if (armour->magic >= settings.armor_max_enchant)
819 { 821 {
820 new_draw_info (NDI_UNIQUE, 0, op, "This armour can not be enchanted any further."); 822 op->failmsg ("This armour can not be enchanted any further!");
821 return 0; 823 return 0;
822 } 824 }
825
823 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight, 826 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight,
824 * etc), so take the easy way out and don't worry about it. 827 * etc), so take the easy way out and don't worry about it.
825 * Note - maybe add scrolls which make the random artifact versions (eg, armour 828 * Note - maybe add scrolls which make the random artifact versions (eg, armour
826 * of gnarg and what not?) 829 * of gnarg and what not?)
827 */ 830 */
828 if (armour->title) 831 if (armour->title)
829 { 832 {
830 new_draw_info (NDI_UNIQUE, 0, op, "This armour will not accept further enchantment."); 833 op->failmsg ("This armour will not accept further enchantment.");
831 return 0; 834 return 0;
832 } 835 }
833 836
834 /* Split objects if needed. Can't insert tmp until the 837 /* Split objects if needed. Can't insert tmp until the
835 * end of this function - otherwise it will just re-merge. 838 * end of this function - otherwise it will just re-merge.
836 */ 839 */
837 if (armour->nrof > 1) 840 tmp = armour->nrof > 1 ? armour->split (armour->nrof - 1) : 0;
838 tmp = get_split_ob (armour, armour->nrof - 1);
839 else
840 tmp = NULL;
841 841
842 armour->magic++; 842 armour->magic++;
843 843
844 if (!settings.armor_speed_linear) 844 if (!settings.armor_speed_linear)
845 { 845 {
… …
850 { 850 {
851 base = base - (base * settings.armor_speed_improvement) / 100; 851 base = base - (base * settings.armor_speed_improvement) / 100;
852 pow++; 852 pow++;
853 } 853 }
854 854
855 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * base) / 100; 855 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * base) / 100;
856 } 856 }
857 else 857 else
858 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * (100 + armour->magic * settings.armor_speed_improvement)) / 100; 858 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * (100 + armour->magic * settings.armor_speed_improvement)) / 100;
859 859
860 if (!settings.armor_weight_linear) 860 if (!settings.armor_weight_linear)
861 { 861 {
862 int base = 100; 862 int base = 100;
863 int pow = 0; 863 int pow = 0;
… …
866 { 866 {
867 base = base - (base * settings.armor_weight_reduction) / 100; 867 base = base - (base * settings.armor_weight_reduction) / 100;
868 pow++; 868 pow++;
869 } 869 }
870 870
871 armour->weight = (armour->arch->clone.weight * base) / 100; 871 armour->weight = (armour->arch->weight * base) / 100;
872 } 872 }
873 else 873 else
874 armour->weight = (armour->arch->clone.weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100; 874 armour->weight = (armour->arch->weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100;
875 875
876 if (armour->weight <= 0) 876 if (armour->weight <= 0)
877 { 877 {
878 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n."); 878 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n.");
879 armour->weight = 1; 879 armour->weight = 1;
880 } 880 }
881 881
882 armour->item_power = get_power_from_ench (armour->arch->clone.item_power + armour->magic); 882 armour->item_power = get_power_from_ench (armour->arch->item_power + armour->magic);
883 883
884 if (op->type == PLAYER) 884 if (op->type == PLAYER)
885 { 885 {
886 esrv_send_item (op, armour); 886 esrv_send_item (op, armour);
887
887 if (QUERY_FLAG (armour, FLAG_APPLIED)) 888 if (QUERY_FLAG (armour, FLAG_APPLIED))
888 fix_player (op); 889 op->update_stats ();
889 } 890 }
890 decrease_ob (improver); 891
892 improver->decrease ();
893
891 if (tmp) 894 if (tmp)
892 { 895 op->insert (tmp);
893 insert_ob_in_ob (tmp, op); 896
894 esrv_send_item (op, tmp);
895 }
896 return 1; 897 return 1;
897} 898}
898
899 899
900/* 900/*
901 * convert_item() returns 1 if anything was converted, 0 if the item was not 901 * convert_item() returns 1 if anything was converted, 0 if the item was not
902 * what the converter wants, -1 if the converter is broken. 902 * what the converter wants, -1 if the converter is broken.
903 */ 903 *
904#define CONV_FROM(xyz) xyz->slaying
905#define CONV_TO(xyz) xyz->other_arch
906#define CONV_NR(xyz) xyz->stats.sp
907#define CONV_NEED(xyz) xyz->stats.food
908
909/* Takes one items and makes another. 904 * Takes one type of items and makes another.
910 * converter is the object that is doing the conversion. 905 * converter is the object that is doing the conversion.
911 * item is the object that triggered the converter - if it is not 906 * item is the object that triggered the converter - if it is not
912 * what the converter wants, this will not do anything. 907 * what the converter wants, this will not do anything.
913 */ 908 */
914int 909static int
915convert_item (object *item, object *converter) 910convert_item (object *item, object *converter)
916{ 911{
917 int nr = 0;
918 uint32 price_in; 912 sint64 nr, price_in;
913
914 if (item->flag [FLAG_UNPAID])
915 return 0;
916
917 shstr conv_from = converter->slaying;
918 archetype *conv_to = converter->other_arch;
919 sint64 need = converter->stats.food;
920 sint64 give = converter->stats.sp;
919 921
920 /* We make some assumptions - we assume if it takes money as it type, 922 /* We make some assumptions - we assume if it takes money as it type,
921 * it wants some amount. We don't make change (ie, if something costs 923 * it wants some amount. We don't make change (ie, if something costs
922 * 3 gp and player drops a platinum, tough luck) 924 * 3 gp and player drops a platinum, tough luck)
923 */ 925 */
924 if (!strcmp (CONV_FROM (converter), "money")) 926 if (conv_from == shstr_money)
925 { 927 {
926 int cost;
927
928 if (item->type != MONEY) 928 if (item->type != MONEY)
929 return 0; 929 return 0;
930 930
931 nr = (item->nrof * item->value) / CONV_NEED (converter); 931 nr = sint64 (item->nrof) * item->value / need;
932 if (!nr) 932 if (!nr)
933 return 0; 933 return 0;
934 cost = nr * CONV_NEED (converter) / item->value; 934
935 /* take into account rounding errors */ 935 converter->play_sound (sound_find ("shop_buy"));
936 if (nr * CONV_NEED (converter) % item->value) 936
937 cost++; 937 sint64 cost = (nr * need + item->value - 1) / item->value;
938 decrease_ob_nr (item, cost); 938
939 item->decrease (cost);
939 940
940 price_in = cost * item->value; 941 price_in = cost * item->value;
941 } 942 }
942 else 943 else
943 { 944 {
944 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->name || 945 if (item->type == PLAYER
945 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof)) 946 || conv_from != item->arch->archname
947 || (need && need > (uint16) item->nrof))
946 return 0; 948 return 0;
947 949
948 if (CONV_NEED (converter)) 950 converter->play_sound (sound_find ("convert_item"));
951
952 if (need)
949 { 953 {
950 nr = item->nrof / CONV_NEED (converter); 954 nr = sint64 (item->nrof) / need;
951 decrease_ob_nr (item, nr * CONV_NEED (converter)); 955 item->decrease (nr * need);
952 price_in = nr * CONV_NEED (converter) * item->value; 956 price_in = nr * need * item->value;
953 } 957 }
954 else 958 else
955 { 959 {
956 price_in = item->value; 960 price_in = item->value;
957 item->destroy (); 961 item->destroy ();
958 } 962 }
959 } 963 }
960 964
961 if (converter->inv != NULL) 965 if (converter->inv)
962 { 966 {
963 object *ob; 967 object *ob;
964 int i; 968 int i;
965 object *ob_to_copy; 969 object *ob_to_copy;
966 970
967 /* select random object from inventory to copy */ 971 /* select random object from inventory to copy */
968 ob_to_copy = converter->inv; 972 ob_to_copy = converter->inv;
969 for (ob = converter->inv->below, i = 1; ob != NULL; ob = ob->below, i++) 973 for (ob = converter->inv->below, i = 1; ob; ob = ob->below, i++)
970 {
971 if (rndm (0, i) == 0) 974 if (rndm (0, i) == 0)
972 {
973 ob_to_copy = ob; 975 ob_to_copy = ob;
974 } 976
975 } 977 item = ob_to_copy->deep_clone ();
976 item = object_create_clone (ob_to_copy);
977 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE); 978 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE);
978 unflag_inv (item, FLAG_IS_A_TEMPLATE); 979 unflag_inv (item, FLAG_IS_A_TEMPLATE);
979 } 980 }
980 else 981 else
981 { 982 {
982 if (converter->other_arch == NULL) 983 if (!conv_to)
983 { 984 {
984 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n", 985 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n",
985 &converter->name, converter->map->path, converter->x, converter->y); 986 &converter->name, &converter->map->path, converter->x, converter->y);
986 return -1; 987 return -1;
987 } 988 }
988 989
989 item = object_create_arch (converter->other_arch); 990 item = object_create_arch (conv_to);
990 fix_generated_item (item, converter, 0, 0, GT_MINIMAL); 991 fix_generated_item (item, converter, 0, 0, GT_MINIMAL);
991 } 992 }
992 993
993 if (CONV_NR (converter)) 994 if (give)
994 item->nrof = CONV_NR (converter); 995 item->nrof = give;
996
995 if (nr) 997 if (nr)
996 item->nrof *= nr; 998 item->nrof *= nr;
997 if (is_in_shop (converter)) 999
1000 if (converter->flag [FLAG_PRECIOUS])
998 SET_FLAG (item, FLAG_UNPAID); 1001 SET_FLAG (item, FLAG_UNPAID);
1002
1003 if (is_in_shop (converter))
1004 {
1005 // converters on shop floors don't work anymore, bug lets check for it
1006 // and report in case someone still does it.
1007 LOG (llevDebug, "ITEMBUG: broken converter, converters on shop floor don't work: %s\n",
1008 converter->debug_desc ());
1009 SET_FLAG (item, FLAG_UNPAID);
1010 }
999 else if (price_in < item->nrof * item->value) 1011 else if (price_in < sint64 (item->nrof) * item->value)
1000 { 1012 {
1001 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n", 1013 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n",
1002 &converter->name, converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name); 1014 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name);
1003
1004 /** 1015 /**
1005 * elmex: we are going to let the game continue, as the mapcreator 1016 * elmex: we are going to let the game continue, as the mapcreator
1006 * propably had something in mind when doing this 1017 * hopefully had something in mind when doing this.
1007 */ 1018 */
1008 } 1019 }
1020
1021 // elmex: only identify if we need to, for example so that generated money doesn't
1022 // get an 'identified' flag so easily.
1023 if (need_identify (item))
1024 identify (item);
1025
1009 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y); 1026 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y);
1010 return 1; 1027 return 1;
1011} 1028}
1012 1029
1013/** 1030/**
1014 * Handle apply on containers. 1031 * Handle apply on containers.
1015 * By Eneq(@csd.uu.se). 1032 * By Eneq(@csd.uu.se).
1016 * Moved to own function and added many features [Tero.Haatanen@lut.fi] 1033 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1017 * added the alchemical cauldron to the code -b.t. 1034 * added the alchemical cauldron to the code -b.t.
1018 */ 1035 */
1019
1020int 1036int
1021apply_container (object *op, object *sack) 1037apply_container (object *op, object *sack)
1022{ 1038{
1023 char buf[MAX_BUF]; 1039 if (op->type != PLAYER || !op->contr->ns)
1024 object *tmp;
1025
1026 if (op->type != PLAYER)
1027 return 0; /* This might change */ 1040 return 0; /* This might change */
1028 1041
1029 if (sack == NULL || sack->type != CONTAINER) 1042 if (!sack || sack->type != CONTAINER)
1030 { 1043 {
1031 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]"); 1044 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1032 return 0; 1045 return 0;
1033 } 1046 }
1034 op->contr->last_used = NULL; 1047
1035 op->contr->last_used_id = 0; 1048 op->contr->last_used = 0;
1036 1049
1037 if (sack->env != op) 1050 if (sack->env && sack->env != op)
1051 {
1052 op->failmsg ("You must put it onto the floor or into your inventory first.");
1053 return 1;
1038 { 1054 }
1039 if (sack->other_arch == NULL || sack->env != NULL) 1055
1056 // already applied == open on ground, or open in inv, or active in inv
1057 if (sack->flag [FLAG_APPLIED])
1058 {
1059 if (op->container == sack)
1040 { 1060 {
1041 new_draw_info (NDI_UNIQUE, 0, op, "You must get it first."); 1061 // open on ground or inv, so close
1062 op->close_container ();
1042 return 1; 1063 return 1;
1043 } 1064 }
1044 /* It's on the ground, the problems begin */ 1065 else if (!sack->env)
1045 if (op->container != sack)
1046 {
1047 /* it's closed OR some player has opened it */
1048 if (QUERY_FLAG (sack, FLAG_APPLIED))
1049 {
1050 for (tmp = get_map_ob (sack->map, sack->x, sack->y); tmp && tmp->container != sack; tmp = tmp->above);
1051 if (tmp)
1052 {
1053 /* some other player have opened it */
1054 new_draw_info_format (NDI_UNIQUE, 0, op, "%s is already occupied.", query_name (sack));
1055 return 1;
1056 }
1057 }
1058 } 1066 {
1059 if (QUERY_FLAG (sack, FLAG_APPLIED)) 1067 // active, but not ours: some other player has opened it
1068 op->failmsg (format ("Somebody else is using the %s already.", query_name (sack)));
1069 return 1;
1060 { 1070 }
1061 if (op->container == NULL)
1062 {
1063 tmp = arch_to_object (sack->other_arch);
1064 /* not good, but insert_ob_in_ob() is too smart */
1065 CLEAR_FLAG (tmp, FLAG_REMOVED);
1066 tmp->x = tmp->y = 0;
1067 tmp->map = NULL;
1068 tmp->env = sack;
1069 if (sack->inv)
1070 sack->inv->above = tmp;
1071 tmp->below = sack->inv;
1072 tmp->above = NULL;
1073 sack->inv = tmp;
1074 sack->move_off = MOVE_ALL; /* trying force closing it */
1075 }
1076 else
1077 {
1078 sack->move_off = 0;
1079 tmp = sack->inv;
1080 1071
1081 if (tmp && tmp->type == CLOSE_CON) 1072 // fall through to opening it (active in inv)
1082 tmp->destroy ();
1083 }
1084 }
1085 }
1086
1087 if (QUERY_FLAG (sack, FLAG_APPLIED))
1088 { 1073 }
1074 else if (sack->env)
1075 {
1076 // it is in our env, so activate it, do not open yet
1089 if (op->container) 1077 op->close_container ();
1090 { 1078 sack->flag [FLAG_APPLIED] = 1;
1091 if (op->container != sack) 1079 esrv_update_item (UPD_FLAGS, op, sack);
1092 { 1080 op->statusmsg (format ("You ready %s.", query_name (sack)));
1093 tmp = op->container; 1081 return 1;
1094 apply_container (op, tmp); 1082 }
1095 sprintf (buf, "You close %s and open ", query_name (tmp)); 1083
1096 op->container = sack; 1084 // it's locked?
1097 strcat (buf, query_name (sack)); 1085 if (sack->slaying)
1098 strcat (buf, "."); 1086 {
1099 } 1087 if (object *tmp = find_key (op, op, sack))
1100 else 1088 op->statusmsg (format ("You unlock %s with %s.", query_name (sack), query_name (tmp)));
1101 {
1102 CLEAR_FLAG (sack, FLAG_APPLIED);
1103 op->container = NULL;
1104 sprintf (buf, "You close %s.", query_name (sack));
1105 }
1106 }
1107 else 1089 else
1108 { 1090 {
1109 CLEAR_FLAG (sack, FLAG_APPLIED);
1110 sprintf (buf, "You open %s.", query_name (sack));
1111 SET_FLAG (sack, FLAG_APPLIED);
1112 op->container = sack;
1113 }
1114 }
1115 else
1116 { /* not applied */
1117 if (sack->slaying)
1118 { /* it's locked */
1119 tmp = find_key (op, op, sack);
1120 if (tmp)
1121 {
1122 sprintf (buf, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1123 SET_FLAG (sack, FLAG_APPLIED);
1124 if (sack->env == NULL)
1125 { /* if it's on ground,open it also */
1126 new_draw_info (NDI_UNIQUE, 0, op, buf);
1127 apply_container (op, sack);
1128 return 1;
1129 }
1130 }
1131 else
1132 {
1133 sprintf (buf, "You don't have the key to unlock %s.", query_name (sack)); 1091 op->statusmsg (format ("You don't have the key to unlock %s.", query_name (sack)));
1134 }
1135 }
1136 else
1137 {
1138 sprintf (buf, "You readied %s.", query_name (sack));
1139 SET_FLAG (sack, FLAG_APPLIED);
1140 if (sack->env == NULL)
1141 { /* if it's on ground,open it also */
1142 new_draw_info (NDI_UNIQUE, 0, op, buf);
1143 apply_container (op, sack);
1144 return 1; 1092 return 1;
1145 } 1093 }
1146 }
1147 } 1094 }
1148 new_draw_info (NDI_UNIQUE, 0, op, buf); 1095
1149 if (op->contr) 1096 op->open_container (sack);
1150 op->contr->socket.update_look = 1; 1097
1151 return 1; 1098 return 1;
1152} 1099}
1153
1154/**
1155 * Eneq(@csd.uu.se): Handle apply on containers. This is for containers
1156 * the player has in their inventory, eg, sacks, luggages, etc.
1157 *
1158 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1159 * This version is for client/server mode.
1160 * op is the player, sack is the container the player is opening or closing.
1161 * return 1 if an object is apllied somehow or another, 0 if error/no apply
1162 *
1163 * Reminder - there are three states for any container - closed (non applied),
1164 * applied (not open, but objects that match get tossed into it), and open
1165 * (applied flag set, and op->container points to the open container)
1166 */
1167
1168int
1169esrv_apply_container (object *op, object *sack)
1170{
1171 object *tmp = op->container;
1172
1173 if (op->type != PLAYER)
1174 return 0; /* This might change */
1175
1176 if (sack == NULL || sack->type != CONTAINER)
1177 {
1178 LOG (llevError, "esrv_apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1179 return 0;
1180 }
1181
1182 /* If we have a currently open container, then it needs to be closed in all cases
1183 * if we are opening this one up. We then fall through if appropriate for
1184 * openening the new container.
1185 */
1186
1187 if (op->container && QUERY_FLAG (sack, FLAG_APPLIED))
1188 {
1189 if (op->container->env != op)
1190 { /* if container is on the ground */
1191 op->container->move_off = 0;
1192 }
1193
1194 if (INVOKE_OBJECT (CLOSE, tmp, ARG_OBJECT (op)))
1195 return 1;
1196
1197 new_draw_info_format (NDI_UNIQUE, 0, op, "You close %s.", query_name (op->container));
1198 CLEAR_FLAG (op->container, FLAG_APPLIED);
1199 op->container = NULL;
1200 esrv_update_item (UPD_FLAGS, op, tmp);
1201 if (tmp == sack)
1202 return 1;
1203 }
1204
1205
1206 /* If the player is trying to open it (which he must be doing if we got here),
1207 * and it is locked, check to see if player has the equipment to open it.
1208 */
1209
1210 if (sack->slaying)
1211 { /* it's locked */
1212 tmp = find_key (op, op, sack);
1213 if (tmp)
1214 {
1215 new_draw_info_format (NDI_UNIQUE, 0, op, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1216 }
1217 else
1218 {
1219 new_draw_info_format (NDI_UNIQUE, 0, op, "You don't have the key to unlock %s.", query_name (sack));
1220 return 0;
1221 }
1222 }
1223
1224 /* By the time we get here, we have made sure any other container has been closed and
1225 * if this is a locked container, the player they key to open it.
1226 */
1227
1228 /* There are really two cases - the sack is either on the ground, or the sack is
1229 * part of the players inventory. If on the ground, we assume that the player is
1230 * opening it, since if it was being closed, that would have been taken care of above.
1231 */
1232
1233
1234 if (sack->env != op)
1235 {
1236 /* Hypothetical case - the player is trying to open a sack that belong to someone
1237 * else. This normally should not happen, but a misbehaving client/player could
1238 * try to do it, so lets handle it gracefully.
1239 */
1240 if (sack->env)
1241 {
1242 new_draw_info_format (NDI_UNIQUE, 0, op, "You can't open %s", query_name (sack));
1243 return 0;
1244 }
1245 /* set these so when the player walks off, we can unapply the sack */
1246 sack->move_off = MOVE_ALL; /* trying force closing it */
1247
1248 CLEAR_FLAG (sack, FLAG_APPLIED);
1249 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1250 SET_FLAG (sack, FLAG_APPLIED);
1251 op->container = sack;
1252 esrv_update_item (UPD_FLAGS, op, sack);
1253 esrv_send_inventory (op, sack);
1254
1255 }
1256 else
1257 { /* sack is in players inventory */
1258 if (QUERY_FLAG (sack, FLAG_APPLIED))
1259 { /* readied sack becoming open */
1260 CLEAR_FLAG (sack, FLAG_APPLIED);
1261 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1262 SET_FLAG (sack, FLAG_APPLIED);
1263 op->container = sack;
1264 esrv_update_item (UPD_FLAGS, op, sack);
1265 esrv_send_inventory (op, sack);
1266 }
1267 else
1268 {
1269 CLEAR_FLAG (sack, FLAG_APPLIED);
1270 new_draw_info_format (NDI_UNIQUE, 0, op, "You readied %s.", query_name (sack));
1271 SET_FLAG (sack, FLAG_APPLIED);
1272 esrv_update_item (UPD_FLAGS, op, sack);
1273 }
1274 }
1275 return 1;
1276}
1277
1278 1100
1279/** 1101/**
1280 * Handles dropping things on altar. 1102 * Handles dropping things on altar.
1281 * Returns true if sacrifice was accepted. 1103 * Returns true if sacrifice was accepted.
1282 */ 1104 */
… …
1293 * with an altar. We call it a Potion - altars are stationary - it 1115 * with an altar. We call it a Potion - altars are stationary - it
1294 * is up to map designers to use them properly. 1116 * is up to map designers to use them properly.
1295 */ 1117 */
1296 if (altar->inv && altar->inv->type == SPELL) 1118 if (altar->inv && altar->inv->type == SPELL)
1297 { 1119 {
1298 new_draw_info_format (NDI_BLACK, 0, originator, "The altar casts %s.", &altar->inv->name); 1120 originator->statusmsg (format ("The altar casts %s.", &altar->inv->name));
1299 cast_spell (originator, altar, 0, altar->inv, NULL); 1121 cast_spell (originator, altar, 0, altar->inv, NULL);
1300 /* If it is connected, push the button. Fixes some problems with 1122 /* If it is connected, push the button. Fixes some problems with
1301 * old maps. 1123 * old maps.
1302 */ 1124 */
1303 1125
1304/* push_button (altar);*/ 1126/* push_button (altar);*/
1305 } 1127 }
… …
1329 double opinion; 1151 double opinion;
1330 object *tmp, *next; 1152 object *tmp, *next;
1331 1153
1332 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */ 1154 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */
1333 1155
1334 if (op->type != PLAYER) 1156 bool has_unpaid = false;
1157
1158 // quite inefficient to do this here twice, but the api doesn'T lend itself to
1159 // a quick and small change :(
1160 for (object::depth_iterator item = op->begin (); item != op->end (); ++item)
1161 if (item->flag [FLAG_UNPAID])
1162 {
1163 has_unpaid = true;
1164 break;
1165 }
1166
1167 if (!op->is_player ())
1335 { 1168 {
1336 /* Remove all the unpaid objects that may be carried here. 1169 /* Remove all the unpaid objects that may be carried here.
1337 * This could be pets or monsters that are somehow in 1170 * This could be pets or monsters that are somehow in
1338 * the shop. 1171 * the shop.
1339 */ 1172 */
… …
1343 1176
1344 if (QUERY_FLAG (tmp, FLAG_UNPAID)) 1177 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1345 { 1178 {
1346 int i = find_free_spot (tmp, op->map, op->x, op->y, 1, 9); 1179 int i = find_free_spot (tmp, op->map, op->x, op->y, 1, 9);
1347 1180
1181 if (i >= 0)
1348 tmp->remove (); 1182 tmp->move (i);
1349
1350 if (i == -1)
1351 i = 0;
1352
1353 tmp->map = op->map;
1354 tmp->x = op->x + freearr_x[i];
1355 tmp->y = op->y + freearr_y[i];
1356 insert_ob_in_map (tmp, op->map, op, 0);
1357 } 1183 }
1358 } 1184 }
1359 1185
1360 /* Don't teleport things like spell effects */ 1186 /* Don't teleport things like spell effects */
1361 if (QUERY_FLAG (op, FLAG_NO_PICK)) 1187 if (QUERY_FLAG (op, FLAG_NO_PICK))
… …
1364 /* unpaid objects, or non living objects, can't transfer by 1190 /* unpaid objects, or non living objects, can't transfer by
1365 * shop mats. Instead, put it on a nearby space. 1191 * shop mats. Instead, put it on a nearby space.
1366 */ 1192 */
1367 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE)) 1193 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE))
1368 { 1194 {
1369
1370 /* Somebody dropped an unpaid item, just move to an adjacent place. */ 1195 /* Somebody dropped an unpaid item, just move to an adjacent place. */
1371 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1196 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1372 1197
1373 if (i != -1) 1198 if (i != -1)
1374 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat); 1199 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat);
1375 1200
1376 return 0; 1201 return 0;
1377 } 1202 }
1203
1378 /* Removed code that checked for multipart objects - it appears that 1204 /* Removed code that checked for multipart objects - it appears that
1379 * the teleport function should be able to handle this just fine. 1205 * the teleport function should be able to handle this just fine.
1380 */ 1206 */
1381 rv = teleport (shop_mat, SHOP_MAT, op); 1207 rv = teleport (shop_mat, SHOP_MAT, op);
1382 } 1208 }
1383 else if (can_pay (op) && get_payment (op)) 1209 else if (can_pay (op) && get_payment (op))
1384 { 1210 {
1385 /* this is only used for players */ 1211 /* this is only used for players */
1386 rv = teleport (shop_mat, SHOP_MAT, op); 1212 rv = teleport (shop_mat, SHOP_MAT, op);
1387 1213
1214 if (has_unpaid)
1215 op->contr->play_sound (sound_find ("shop_buy"));
1216 else if (is_in_shop (op))
1217 op->contr->play_sound (sound_find ("shop_enter"));
1218 else
1219 op->contr->play_sound (sound_find ("shop_leave"));
1220
1388 if (shop_mat->msg) 1221 if (shop_mat->msg)
1389 new_draw_info (NDI_UNIQUE, 0, op, shop_mat->msg); 1222 op->statusmsg (shop_mat->msg);
1390 /* This check below is a bit simplistic - generally it should be correct, 1223 /* This check below is a bit simplistic - generally it should be correct,
1391 * but there is never a guarantee that the bottom space on the map is 1224 * but there is never a guarantee that the bottom space on the map is
1392 * actually the shop floor. 1225 * actually the shop floor.
1393 */ 1226 */
1394 else if (!rv && !is_in_shop (op)) 1227 else if (!rv && !is_in_shop (op))
1395 { 1228 {
1396 opinion = shopkeeper_approval (op->map, op); 1229 opinion = shopkeeper_approval (op->map, op);
1397 1230
1398 if (opinion > 0.9) 1231 op->statusmsg (
1399 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper gives you a friendly wave."); 1232 opinion >= 0.90 ? "The shopkeeper gives you a friendly wave."
1400 else if (opinion > 0.75) 1233 : opinion >= 0.75 ? "The shopkeeper waves to you."
1401 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper waves to you."); 1234 : opinion >= 0.50 ? "The shopkeeper ignores you."
1402 else if (opinion > 0.5) 1235 : "The shopkeeper glares at you with contempt."
1403 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper ignores you.");
1404 else 1236 );
1405 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper glares at you with contempt.");
1406 } 1237 }
1407 } 1238 }
1408 else 1239 else
1409 { 1240 {
1410 /* if we get here, a player tried to leave a shop but was not able 1241 /* if we get here, a player tried to leave a shop but was not able
1411 * to afford the items he has. We try to move the player so that 1242 * to afford the items he has. We try to move the player so that
1412 * they are not on the mat anymore 1243 * they are not on the mat anymore
1413 */ 1244 */
1414 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1245 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1415 1246
1416 if (i == -1) 1247 if (i == -1)
1417 {
1418 LOG (llevError, "Internal shop-mat problem.\n"); 1248 LOG (llevError, "Internal shop-mat problem.\n");
1419 }
1420 else 1249 else
1421 { 1250 {
1422 op->remove (); 1251 op->remove ();
1423 op->x += freearr_x[i]; 1252 op->x += freearr_x[i];
1424 op->y += freearr_y[i]; 1253 op->y += freearr_y[i];
… …
1434 * Handles applying a sign. 1263 * Handles applying a sign.
1435 */ 1264 */
1436static void 1265static void
1437apply_sign (object *op, object *sign, int autoapply) 1266apply_sign (object *op, object *sign, int autoapply)
1438{ 1267{
1439 readable_message_type *msgType; 1268 if (sign->has_dialogue ())
1440 char newbuf[HUGE_BUF];
1441
1442 if (sign->msg == NULL)
1443 { 1269 {
1444 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it."); 1270 op->statusmsg (format ("Maybe you should I<talk> to the %s instead?", &sign->name));
1445 return; 1271 return;
1446 } 1272 }
1447 1273
1274 if (!sign->msg)
1275 {
1276 op->contr->infobox (MSG_CHANNEL ("examine"),
1277 format ("T<%s>\n\n Nothing %sis written on it.",
1278 &sign->name,
1279 sign->name == sign->arch->name ? "" : "else "));
1280 return;
1281 }
1282
1448 if (sign->stats.food) 1283 if (sign->stats.food)
1449 { 1284 {
1450 if (sign->last_eat >= sign->stats.food) 1285 if (sign->last_eat >= sign->stats.food)
1451 { 1286 {
1452 if (!sign->move_on) 1287 if (!sign->move_on)
1453 new_draw_info (NDI_UNIQUE, 0, op, "You cannot read it anymore."); 1288 op->failmsg ("You cannot read it anymore.");
1289
1454 return; 1290 return;
1455 } 1291 }
1456 1292
1457 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1293 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1458 sign->last_eat++; 1294 sign->last_eat++;
… …
1463 * move_on is zero, it needs to be manually applied (doesn't talk 1299 * move_on is zero, it needs to be manually applied (doesn't talk
1464 * to us). 1300 * to us).
1465 */ 1301 */
1466 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on) 1302 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on)
1467 { 1303 {
1468 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1304 op->failmsg ("You are unable to read while blind!");
1469 return; 1305 return;
1470 } 1306 }
1471 msgType = get_readable_message_type (sign); 1307
1472 snprintf (newbuf, sizeof (newbuf), "%hhu %s", autoapply ? 1 : 0, &sign->msg); 1308 if (op->contr)
1473 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg); 1309 if (client *ns = op->contr->ns)
1310 {
1311 if (sign->sound)
1312 ns->play_sound (sign->sound);
1313 else if (autoapply)
1314 ns->play_sound (sound_find ("msg_voice"));
1315
1316 op->contr->infobox (MSG_CHANNEL ("examine"), format ("T<%s>\n\n%s", &sign->name, &sign->msg));
1317 }
1318}
1319
1320static void
1321move_apply_hole (object *trap, object *victim)
1322{
1323 /* Hole not open? */
1324 if (trap->stats.wc > 0)
1325 return;
1326
1327 /* Is this a multipart monster and not the head? If so, return.
1328 * Processing will happen if the head runs into the pit
1329 */
1330 if (victim->head)
1331 return;
1332
1333 // now find all possible locations and randomly pick one
1334 int dir = find_free_spot (victim, trap->map, EXIT_X (trap), EXIT_Y (trap), 0,
1335 trap->range >= 3 ? SIZEOFFREE3 + 1
1336 : trap->range >= 2 ? SIZEOFFREE2 + 1
1337 : trap->range >= 1 ? SIZEOFFREE1 + 1
1338 : SIZEOFFREE0 + 1);
1339
1340 if (dir < 0)
1341 return;
1342
1343 victim->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1344 victim->statusmsg ("You fall through the hole!", NDI_RED);
1345
1346 transfer_ob (victim,
1347 EXIT_X (trap) + freearr_x[dir],
1348 EXIT_Y (trap) + freearr_y[dir],
1349 0, victim);
1474} 1350}
1475 1351
1476/** 1352/**
1477 * 'victim' moves onto 'trap' 1353 * 'victim' moves onto 'trap'
1478 * 'victim' leaves 'trap' 1354 * 'victim' leaves 'trap'
… …
1501 * proper. This code was causing needless crashes. 1377 * proper. This code was causing needless crashes.
1502 */ 1378 */
1503 if (recursion_depth >= 500) 1379 if (recursion_depth >= 500)
1504 { 1380 {
1505 LOG (llevDebug, "WARNING: move_apply(): aborting recursion " 1381 LOG (llevDebug, "WARNING: move_apply(): aborting recursion "
1506 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->name, &trap->name, &victim->arch->name, &victim->name); 1382 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->archname, &trap->name, &victim->arch->archname, &victim->name);
1507 return; 1383 return;
1508 } 1384 }
1385
1509 recursion_depth++; 1386 recursion_depth++;
1510 if (trap->head) 1387 if (trap->head)
1511 trap = trap->head; 1388 trap = trap->head;
1512 1389
1513 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator))) 1390 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator)))
… …
1528 1405
1529 /* Just put in some sanity check. I think there is a bug in the 1406 /* Just put in some sanity check. I think there is a bug in the
1530 * above with some objects have zero speed, and thus the player 1407 * above with some objects have zero speed, and thus the player
1531 * getting permanently paralyzed. 1408 * getting permanently paralyzed.
1532 */ 1409 */
1533 if (victim->speed_left < -50.0) 1410 if (victim->speed_left < -50.f)
1534 victim->speed_left = -50.0; 1411 victim->speed_left = -50.f;
1535 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */ 1412 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */
1536 } 1413 }
1537 goto leave; 1414 goto leave;
1538 1415
1539 case SPINNER: 1416 case SPINNER:
… …
1589 1466
1590 if (!trap->value) 1467 if (!trap->value)
1591 { 1468 {
1592 int tot; 1469 int tot;
1593 1470
1594 for (ab = trap->above, tot = 0; ab != NULL; ab = ab->above) 1471 for (ab = trap->above, tot = 0; ab; ab = ab->above)
1595 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1472 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1596 tot += (ab->nrof ? ab->nrof : 1) * ab->weight + ab->carrying; 1473 tot += ab->head_ ()->total_weight ();
1597 1474
1598 if (!(trap->value = (tot > trap->weight) ? 1 : 0)) 1475 if (!(trap->value = (tot > trap->weight) ? 1 : 0))
1599 goto leave; 1476 goto leave;
1600 1477
1601 SET_ANIMATION (trap, trap->value); 1478 SET_ANIMATION (trap, trap->value);
… …
1611 1488
1612 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1489 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1613 { 1490 {
1614 if (!sound_was_played) 1491 if (!sound_was_played)
1615 { 1492 {
1616 play_sound_map (trap->map, trap->x, trap->y, SOUND_FALL_HOLE); 1493 trap->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1617 sound_was_played = 1; 1494 sound_was_played = 1;
1618 } 1495 }
1619 new_draw_info (NDI_UNIQUE, 0, ab, "You fall into a trapdoor!"); 1496
1497 ab->statusmsg ("You fall into a trapdoor!", NDI_RED);
1620 transfer_ob (ab, (int) EXIT_X (trap), (int) EXIT_Y (trap), 0, ab); 1498 transfer_ob (ab, EXIT_X (trap), EXIT_Y (trap), 0, ab);
1621 } 1499 }
1622 } 1500 }
1623 goto leave; 1501 goto leave;
1624 } 1502 }
1625 1503
1626
1627 case CONVERTER: 1504 case CONVERTER:
1628 if (convert_item (victim, trap) < 0) 1505 if (convert_item (victim, trap) < 0)
1629 { 1506 {
1630 object *op; 1507 originator->failmsg (format ("The %s seems to be broken!", query_name (trap)));
1631 1508 archetype::get (shstr_burnout)->insert_at (trap, trap);
1632 new_draw_info_format (NDI_UNIQUE, 0, originator, "The %s seems to be broken!", query_name (trap));
1633
1634 op = get_archetype ("burnout");
1635 if (op != NULL)
1636 {
1637 op->x = trap->x;
1638 op->y = trap->y;
1639 insert_ob_in_map (op, trap->map, trap, 0);
1640 }
1641 } 1509 }
1510
1642 goto leave; 1511 goto leave;
1643 1512
1644 case TRIGGER_BUTTON: 1513 case TRIGGER_BUTTON:
1645 case TRIGGER_PEDESTAL: 1514 case TRIGGER_PEDESTAL:
1646 case TRIGGER_ALTAR: 1515 case TRIGGER_ALTAR:
… …
1654 case CHECK_INV: 1523 case CHECK_INV:
1655 check_inv (victim, trap); 1524 check_inv (victim, trap);
1656 goto leave; 1525 goto leave;
1657 1526
1658 case HOLE: 1527 case HOLE:
1659 /* Hole not open? */ 1528 move_apply_hole (trap, victim);
1660 if (trap->stats.wc > 0)
1661 goto leave;
1662
1663 /* Is this a multipart monster and not the head? If so, return.
1664 * Processing will happen if the head runs into the pit
1665 */
1666 if (victim->head)
1667 goto leave;
1668
1669 play_sound_map (victim->map, victim->x, victim->y, SOUND_FALL_HOLE);
1670 new_draw_info (NDI_UNIQUE, 0, victim, "You fall through the hole!\n");
1671 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim);
1672 goto leave; 1529 goto leave;
1673 1530
1674 case EXIT: 1531 case EXIT:
1675 if (victim->type == PLAYER && EXIT_PATH (trap)) 1532 if (victim->type == PLAYER && EXIT_PATH (trap))
1676 { 1533 {
1677 /* Basically, don't show exits leading to random maps the 1534 /* Basically, don't show exits leading to random maps the
1678 * players output. 1535 * players output.
1679 */ 1536 */
1680 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2) && strncmp (EXIT_PATH (trap), "/random/", 8)) 1537 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2))
1681 new_draw_info (NDI_NAVY, 0, victim, trap->msg); 1538 victim->statusmsg (trap->msg, NDI_NAVY);
1539
1540 trap->play_sound (trap->sound);
1682 enter_exit (victim, trap); 1541 victim->enter_exit (trap);
1683 } 1542 }
1684 goto leave; 1543 goto leave;
1685 1544
1686 case ENCOUNTER: 1545 case ENCOUNTER:
1687 /* may be some leftovers on this */ 1546 /* may be some leftovers on this */
… …
1702 1561
1703 apply_sign (victim, trap, 1); 1562 apply_sign (victim, trap, 1);
1704 goto leave; 1563 goto leave;
1705 1564
1706 case CONTAINER: 1565 case CONTAINER:
1707 if (victim->type == PLAYER)
1708 (void) esrv_apply_container (victim, trap);
1709 else
1710 (void) apply_container (victim, trap); 1566 apply_container (victim, trap);
1711 goto leave; 1567 goto leave;
1712 1568
1713 case RUNE: 1569 case RUNE:
1714 case TRAP: 1570 case TRAP:
1715 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE)) 1571 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE))
1716 {
1717 spring_trap (trap, victim); 1572 spring_trap (trap, victim);
1718 }
1719 goto leave; 1573 goto leave;
1720 1574
1721 default: 1575 default:
1722 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not " 1576 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not "
1723 "handled in move_apply()\n", &trap->name, &trap->arch->name, trap->type); 1577 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type);
1724 goto leave; 1578 goto leave;
1725 } 1579 }
1726 1580
1727leave: 1581leave:
1728 recursion_depth--; 1582 recursion_depth--;
… …
1737 int lev_diff; 1591 int lev_diff;
1738 object *skill_ob; 1592 object *skill_ob;
1739 1593
1740 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1594 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1741 { 1595 {
1742 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1596 op->failmsg ("You are unable to read while blind!");
1743 return; 1597 return;
1744 } 1598 }
1599
1745 if (tmp->msg == NULL) 1600 if (!tmp->msg)
1746 { 1601 {
1747 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name); 1602 op->failmsg (format ("You open the %s and find it empty.", &tmp->name));
1748 return; 1603 return;
1749 } 1604 }
1750 1605
1751 /* need a literacy skill to read stuff! */ 1606 /* need a literacy skill to read stuff! */
1752 skill_ob = find_skill_by_name (op, tmp->skill); 1607 skill_ob = find_skill_by_name (op, tmp->skill);
1753 if (!skill_ob) 1608 if (!skill_ob)
1754 { 1609 {
1755 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1610 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill to read this.>", &tmp->skill));
1756 return; 1611 return;
1757 } 1612 }
1613
1758 lev_diff = tmp->level - (skill_ob->level + 5); 1614 lev_diff = tmp->level - (skill_ob->level + 5);
1759 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0) 1615 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0)
1760 { 1616 {
1761 if (lev_diff < 2) 1617 op->failmsg (lev_diff < 2 ? "This book is just barely beyond your comprehension."
1762 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension."); 1618 : lev_diff < 3 ? "This book is slightly beyond your comprehension."
1763 else if (lev_diff < 3) 1619 : lev_diff < 5 ? "This book is beyond your comprehension."
1764 new_draw_info (NDI_UNIQUE, 0, op, "This book is slightly beyond your comprehension."); 1620 : lev_diff < 8 ? "This book is quite a bit beyond your comprehension."
1765 else if (lev_diff < 5) 1621 : lev_diff < 15 ? "This book is way beyond your comprehension."
1766 new_draw_info (NDI_UNIQUE, 0, op, "This book is beyond your comprehension."); 1622 : "This book is totally beyond your comprehension.");
1767 else if (lev_diff < 8)
1768 new_draw_info (NDI_UNIQUE, 0, op, "This book is quite a bit beyond your comprehension.");
1769 else if (lev_diff < 15)
1770 new_draw_info (NDI_UNIQUE, 0, op, "This book is way beyond your comprehension.");
1771 else
1772 new_draw_info (NDI_UNIQUE, 0, op, "This book is totally beyond your comprehension.");
1773 return; 1623 return;
1774 } 1624 }
1775 1625
1776 readable_message_type *msgType = get_readable_message_type (tmp); 1626 readable_message_type *msgType = get_readable_message_type (tmp);
1777 1627
1778 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, 1628 if (player *pl = op->contr)
1779 msgType->message_type, msgType->message_subtype, 1629 if (client *ns = pl->ns)
1780 "You open the %s and start reading.\n%s", "%s\n%s", long_desc (tmp, op), &tmp->msg); 1630 pl->infobox (MSG_CHANNEL ("book"), format ("T<%s>\n\n%s", (char *)long_desc (tmp, op), &tmp->msg));
1781 1631
1782 /* gain xp from reading */ 1632 /* gain xp from reading */
1783 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT)) 1633 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT))
1784 { /* only if not read before */ 1634 { /* only if not read before */
1785 int exp_gain = calc_skill_exp (op, tmp, skill_ob); 1635 int exp_gain = calc_skill_exp (op, tmp, skill_ob);
1786 1636
1787 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1637 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1788 { 1638 {
1789 /*exp_gain *= 2; because they just identified it too */ 1639 /*exp_gain *= 2; because they just identified it too */
1790 SET_FLAG (tmp, FLAG_IDENTIFIED); 1640 SET_FLAG (tmp, FLAG_IDENTIFIED);
1791 /* If in a container, update how it looks */ 1641
1792 if (tmp->env) 1642 if (object *pl = tmp->visible_to ())
1793 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp); 1643 esrv_update_item (UPD_FLAGS | UPD_NAME, pl, tmp);
1794 else
1795 op->contr->socket.update_look = 1;
1796 } 1644 }
1645
1797 change_exp (op, exp_gain, skill_ob->skill, 0); 1646 change_exp (op, exp_gain, skill_ob->skill, 0);
1798 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */ 1647 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */
1799 } 1648 }
1800} 1649}
1801 1650
… …
1804 * op is the person learning the skill, tmp is the skill scroll object 1653 * op is the person learning the skill, tmp is the skill scroll object
1805 */ 1654 */
1806static void 1655static void
1807apply_skillscroll (object *op, object *tmp) 1656apply_skillscroll (object *op, object *tmp)
1808{ 1657{
1809 switch ((int) learn_skill (op, tmp)) 1658 switch (learn_skill (op, tmp))
1810 { 1659 {
1811 case 0: 1660 case 0:
1812 new_draw_info (NDI_UNIQUE, 0, op, "You already possess the knowledge "); 1661 op->play_sound (sound_find ("generic_fail"));
1813 new_draw_info_format (NDI_UNIQUE, 0, op, "held within the %s.\n", query_name (tmp)); 1662 op->failmsg (format ("You already possess the knowledge held within the %s.", query_name (tmp)));
1814 return; 1663 break;
1815 1664
1816 case 1: 1665 case 1:
1817 new_draw_info_format (NDI_UNIQUE, 0, op, "You succeed in learning %s", &tmp->skill);
1818 decrease_ob (tmp); 1666 tmp->decrease ();
1667 op->play_sound (sound_find ("skill_learn"));
1668 op->statusmsg (format ("You succeed in learning %s", &tmp->skill));
1819 return; 1669 break;
1820 1670
1821 default: 1671 default:
1672 tmp->decrease ();
1673 op->play_sound (sound_find ("generic_fail"));
1822 new_draw_info_format (NDI_UNIQUE, 0, op, "You fail to learn the knowledge of the %s.\n", query_name (tmp)); 1674 op->failmsg (format ("You fail to learn the knowledge of the %s.\n", query_name (tmp)));
1823 decrease_ob (tmp);
1824 return; 1675 break;
1825 } 1676 }
1826} 1677}
1827 1678
1828/** 1679/**
1829 * Actually makes op learn spell. 1680 * Actually makes op learn spell.
… …
1849 return; 1700 return;
1850 } 1701 }
1851 return; 1702 return;
1852 } 1703 }
1853 1704
1854 play_sound_player_only (op->contr, SOUND_LEARN_SPELL, 0, 0); 1705 op->contr->play_sound (sound_find ("learn_spell"));
1855 tmp = object::create (); 1706
1856 spell->copy_to (tmp); 1707 tmp = spell->clone ();
1857 insert_ob_in_ob (tmp, op); 1708 insert_ob_in_ob (tmp, op);
1858 1709
1859 if (special_prayer) 1710 if (special_prayer)
1860 {
1861 SET_FLAG (tmp, FLAG_STARTEQUIP); 1711 SET_FLAG (tmp, FLAG_STARTEQUIP);
1862 }
1863 1712
1864 esrv_add_spells (op->contr, tmp); 1713 esrv_add_spells (op->contr, tmp);
1865} 1714}
1866 1715
1867/** 1716/**
… …
1881 { 1730 {
1882 LOG (llevError, "BUG: do_forget_spell(): spell not known\n"); 1731 LOG (llevError, "BUG: do_forget_spell(): spell not known\n");
1883 return; 1732 return;
1884 } 1733 }
1885 1734
1886 new_draw_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, "You lose knowledge of %s.", spell); 1735 op->failmsg (format ("You lose knowledge of %s.", spell));
1887 player_unready_range_ob (op->contr, spob); 1736 player_unready_range_ob (op->contr, spob);
1888 esrv_remove_spell (op->contr, spob); 1737 esrv_remove_spell (op->contr, spob);
1889 spob->destroy (); 1738 spob->destroy ();
1890} 1739}
1891 1740
… …
1899{ 1748{
1900 object *skop, *spell, *spell_skill; 1749 object *skop, *spell, *spell_skill;
1901 1750
1902 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1751 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1903 { 1752 {
1904 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1753 op->failmsg ("You are unable to read while blind.");
1905 return; 1754 return;
1906 } 1755 }
1907 1756
1908 /* artifact_spellbooks have 'slaying' field point to a spell name, 1757 /* artifact_spellbooks have 'slaying' field point to a spell name,
1909 * instead of having their spell stored in stats.sp. These are 1758 * instead of having their spell stored in stats.sp. These are
1910 * legacy spellbooks 1759 * legacy spellbooks
1911 */ 1760 */
1912
1913 if (tmp->slaying != NULL) 1761 if (tmp->slaying)
1914 { 1762 {
1915 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying)); 1763 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying));
1916 if (!spell) 1764 if (!spell)
1917 { 1765 {
1918 new_draw_info_format (NDI_UNIQUE, 0, op, "The book's formula for %s is incomplete", &tmp->slaying); 1766 op->failmsg (format ("The book's formula for %s is incomplete.", &tmp->slaying));
1919 return; 1767 return;
1920 } 1768 }
1921 else 1769 else
1922 insert_ob_in_ob (spell, tmp); 1770 insert_ob_in_ob (spell, tmp);
1771
1923 tmp->slaying = NULL; 1772 tmp->slaying = 0;
1924 } 1773 }
1925 1774
1926 skop = find_skill_by_name (op, tmp->skill); 1775 skop = find_skill_by_name (op, tmp->skill);
1927 1776
1928 /* need a literacy skill to learn spells. Also, having a literacy level 1777 /* need a literacy skill to learn spells. Also, having a literacy level
1929 * lower than the spell will make learning the spell more difficult */ 1778 * lower than the spell will make learning the spell more difficult */
1930 if (!skop) 1779 if (!skop)
1931 { 1780 {
1932 new_draw_info (NDI_UNIQUE, 0, op, "You can't read! Your attempt fails."); 1781 op->failmsg (format ("You can't read! Your attempt fails. H<You lack the %s skill.>", &tmp->skill));
1933 return; 1782 return;
1934 } 1783 }
1935 1784
1936 spell = tmp->inv; 1785 spell = tmp->inv;
1937 1786
1938 if (!spell) 1787 if (!spell)
1939 { 1788 {
1940 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name); 1789 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name);
1941 new_draw_info (NDI_UNIQUE, 0, op, "The spellbook symbols make no sense."); 1790 op->failmsg ("The spellbook symbols make no sense. This is a bug, please report!");
1942 return; 1791 return;
1943 } 1792 }
1944 1793
1945 if (skop->level < int (sqrtf (spell->level) * 1.5f)) 1794 if (skop->level < int (sqrtf (spell->level) * 1.5f))
1946 { 1795 {
1947 new_draw_info (NDI_UNIQUE, 0, op, "It is too hard to read at your level: You are unable to decipher the strange symbols."); 1796 op->failmsg (format ("You are unable to decipher the strange symbols. H<Your %s level is too low.>", &tmp->skill));
1948 return; 1797 return;
1949 } 1798 }
1950 1799
1951 new_draw_info_format (NDI_UNIQUE, 0, op, "The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name); 1800 op->statusmsg (format ("The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name));
1952 1801
1953 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1802 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1954 {
1955 identify (tmp); 1803 identify (tmp);
1956 if (tmp->env)
1957 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp);
1958 else
1959 op->contr->socket.update_look = 1;
1960 }
1961 1804
1962 /* I removed the check for special_prayer_mark here - it didn't make 1805 /* I removed the check for special_prayer_mark here - it didn't make
1963 * a lot of sense - special prayers are not found in spellbooks, and 1806 * a lot of sense - special prayers are not found in spellbooks, and
1964 * if the player doesn't know the spell, doesn't make a lot of sense that 1807 * if the player doesn't know the spell, doesn't make a lot of sense that
1965 * they would have a special prayer mark. 1808 * they would have a special prayer mark.
1966 */ 1809 */
1967 if (check_spell_known (op, spell->name)) 1810 if (check_spell_known (op, spell->name))
1968 { 1811 {
1969 new_draw_info (NDI_UNIQUE, 0, op, "You already know that spell.\n"); 1812 op->statusmsg ("You already know that spell. H<It makes no sense to learn spells twice, and would only waste the spellbook.>\n");
1970 return; 1813 return;
1971 } 1814 }
1972 1815
1973 if (spell->skill) 1816 if (spell->skill)
1974 { 1817 {
1975 spell_skill = find_skill_by_name (op, spell->skill); 1818 spell_skill = find_skill_by_name (op, spell->skill);
1976 1819
1977 if (!spell_skill) 1820 if (!spell_skill)
1978 { 1821 {
1979 new_draw_info_format (NDI_UNIQUE, 0, op, "You lack the skill %s to use this spell", &spell->skill); 1822 op->failmsg (format ("You lack the skill %s to use this spell.", &spell->skill));
1980 return; 1823 return;
1981 } 1824 }
1982 1825
1983 if (spell_skill->level < spell->level) 1826 if (spell_skill->level < spell->level)
1984 { 1827 {
1985 new_draw_info_format (NDI_UNIQUE, 0, op, "You need to be level %d in %s to learn this spell.", spell->level, &spell->skill); 1828 op->failmsg (format ("You need to be level %d in %s to learn this spell.", spell->level, &spell->skill));
1986 return; 1829 return;
1987 } 1830 }
1988 } 1831 }
1989 1832
1990 /* Logic as follows 1833 /* Logic as follows
… …
1999 * Overall, chances are the same but a player will find having a high 1842 * Overall, chances are the same but a player will find having a high
2000 * literacy rate very useful! -b.t. 1843 * literacy rate very useful! -b.t.
2001 */ 1844 */
2002 if (QUERY_FLAG (op, FLAG_CONFUSED)) 1845 if (QUERY_FLAG (op, FLAG_CONFUSED))
2003 { 1846 {
2004 new_draw_info (NDI_UNIQUE, 0, op, "In your confused state you flub the wording of the text!"); 1847 op->failmsg ("In your confused state you flub the wording of the text!");
2005 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace)); 1848 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace));
2006 } 1849 }
2007 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || 1850 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) ||
2008 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int]) 1851 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int])
2009 { 1852 {
2010 1853 op->statusmsg ("You succeed in learning the spell!", NDI_GREEN);
2011 new_draw_info (NDI_UNIQUE, 0, op, "You succeed in learning the spell!");
2012 do_learn_spell (op, spell, 0); 1854 do_learn_spell (op, spell, 0);
2013 1855
2014 /* xp gain to literacy for spell learning */ 1856 /* xp gain to literacy for spell learning */
2015 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP)) 1857 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP))
2016 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0); 1858 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0);
2017 } 1859 }
2018 else 1860 else
2019 { 1861 {
2020 play_sound_player_only (op->contr, SOUND_FUMBLE_SPELL, 0, 0); 1862 op->contr->play_sound (sound_find ("fumble_spell"));
2021 new_draw_info (NDI_UNIQUE, 0, op, "You fail to learn the spell.\n"); 1863 op->failmsg ("You fail to learn the spell. H<Wis (priests) or Int (wizards) governs the chance of learning a prayer or spell.>\n");
2022 } 1864 }
2023 decrease_ob (tmp); 1865
1866 tmp->decrease ();
2024} 1867}
2025 1868
2026/** 1869/**
2027 * Handles applying a spell scroll. 1870 * Handles applying a spell scroll.
2028 */ 1871 */
… …
2031{ 1874{
2032 object *skop; 1875 object *skop;
2033 1876
2034 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1877 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
2035 { 1878 {
2036 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1879 op->failmsg ("You are unable to read while blind.");
2037 return; 1880 return;
2038 } 1881 }
2039 1882
2040 if (!tmp->inv || tmp->inv->type != SPELL) 1883 if (!tmp->inv || tmp->inv->type != SPELL)
2041 { 1884 {
2042 new_draw_info (NDI_UNIQUE, 0, op, "The scroll just doesn't make sense!"); 1885 op->failmsg ("The scroll just doesn't make sense! H<...and never will make sense.>");
2043 return; 1886 return;
2044 } 1887 }
2045 1888
2046 if (op->type == PLAYER) 1889 if (op->type == PLAYER)
2047 { 1890 {
… …
2053 */ 1896 */
2054 skop = find_skill_by_name (op, skill_names[SK_LITERACY]); 1897 skop = find_skill_by_name (op, skill_names[SK_LITERACY]);
2055 1898
2056 if (!skop) 1899 if (!skop)
2057 { 1900 {
2058 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1901 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill.>", &skill_names[SK_LITERACY]));
2059 return; 1902 return;
2060 } 1903 }
2061 1904
2062 if ((exp_gain = calc_skill_exp (op, tmp, skop))) 1905 if ((exp_gain = calc_skill_exp (op, tmp, skop)))
2063 change_exp (op, exp_gain, skop->skill, 0); 1906 change_exp (op, exp_gain, skop->skill, 0);
2064 } 1907 }
2065 1908
2066 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1909 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
2067 identify (tmp); 1910 identify (tmp);
2068 1911
2069 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name); 1912 op->statusmsg (format ("The scroll of %s turns to dust.", &tmp->inv->name));
2070
2071 1913
2072 cast_spell (op, tmp, dir, tmp->inv, NULL); 1914 cast_spell (op, tmp, dir, tmp->inv, NULL);
2073 decrease_ob (tmp); 1915 tmp->decrease ();
2074} 1916}
2075 1917
2076/** 1918/**
2077 * Applies a treasure object - by default, chest. op 1919 * Applies a treasure object - by default, chest. op
2078 * is the person doing the applying, tmp is the treasure 1920 * is the person doing the applying, tmp is the treasure
2079 * chest. 1921 * chest.
2080 */ 1922 */
2081static void 1923static void
2082apply_treasure (object *op, object *tmp) 1924apply_treasure (object *op, object *tmp)
2083{ 1925{
2084 object *treas;
2085
2086
2087 /* Nice side effect of new treasure creation method is that the treasure 1926 /* Nice side effect of this treasure creation method is that the treasure
2088 * for the chest is done when the chest is created, and put into the chest 1927 * for the chest is done when the chest is created, and put into the chest
2089 * inventory. So that when the chest burns up, the items still exist. Also 1928 * inventory. So that when the chest burns up, the items still exist. Also
2090 * prevents people fromt moving chests to more difficult maps to get better 1929 * prevents people from moving chests to more difficult maps to get better
2091 * treasure 1930 * treasure
2092 */ 1931 */
2093
2094 treas = tmp->inv; 1932 object *treas = tmp->inv;
2095 if (treas == NULL) 1933
1934 if (!treas)
2096 { 1935 {
2097 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty."); 1936 op->statusmsg ("The chest was empty.");
2098 decrease_ob (tmp); 1937 tmp->decrease ();
2099 return; 1938 return;
2100 } 1939 }
1940
2101 while (tmp->inv) 1941 while (tmp->inv)
2102 { 1942 {
2103 treas = tmp->inv; 1943 treas = tmp->inv;
2104
2105 treas->remove (); 1944 treas->remove ();
2106 new_draw_info_format (NDI_UNIQUE, 0, op, "You find %s in the chest.", query_name (treas));
2107 1945
2108 treas->x = op->x; 1946 treas->x = op->x;
2109 treas->y = op->y; 1947 treas->y = op->y;
2110 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR); 1948 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR);
2111 1949
2112 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE)) 1950 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE))
2113 spring_trap (treas, op); 1951 spring_trap (treas, op);
2114 1952
2115 /* If either player or container was destroyed, no need to do 1953 /* If either player or container was destroyed, no need to do
2116 * further processing. I think this should be enclused with 1954 * further processing. I think this should be enclused with
2117 * spring trap above, as I don't think there is otherwise 1955 * spring trap above, as I don't think there is otherwise
2118 * any way for the treasure chest or player to get killed 1956 * any way for the treasure chest or player to get killed.
2119 */ 1957 */
2120 if (op->destroyed () || tmp->destroyed ()) 1958 if (op->destroyed () || tmp->destroyed ())
2121 break; 1959 break;
2122 } 1960 }
2123 1961
2124 if (!tmp->destroyed () && tmp->inv == NULL) 1962 if (!tmp->destroyed () && !tmp->inv)
2125 decrease_ob (tmp); 1963 tmp->decrease (true);
2126
2127} 1964}
2128 1965
2129/** 1966/**
2130 * op eats food. 1967 * op eats food.
2131 * If player, takes care of messages and dragon special food. 1968 * If player, takes care of messages and dragon special food.
… …
2146 { 1983 {
2147 /* usual case - no dragon meal: */ 1984 /* usual case - no dragon meal: */
2148 if (op->stats.food + tmp->stats.food > 999) 1985 if (op->stats.food + tmp->stats.food > 999)
2149 { 1986 {
2150 if (tmp->type == FOOD || tmp->type == FLESH) 1987 if (tmp->type == FOOD || tmp->type == FLESH)
2151 new_draw_info (NDI_UNIQUE, 0, op, "You feel full, but what a waste of food!"); 1988 op->failmsg ("You feel full, but what a waste of food!");
2152 else 1989 else
2153 new_draw_info (NDI_UNIQUE, 0, op, "Most of the drink goes down your face not your throat!"); 1990 op->statusmsg ("Most of the drink goes down your face not your throat!");
2154 } 1991 }
1992
1993 tmp->play_sound (
1994 tmp->sound
1995 ? tmp->sound
1996 : tmp->type == DRINK
1997 ? sound_find ("eat_drink")
1998 : sound_find ("eat_food")
1999 );
2155 2000
2156 if (!QUERY_FLAG (tmp, FLAG_CURSED)) 2001 if (!QUERY_FLAG (tmp, FLAG_CURSED))
2157 { 2002 {
2158 char buf[MAX_BUF]; 2003 const char *buf;
2159 2004
2160 if (!is_dragon_pl (op)) 2005 if (!is_dragon_pl (op))
2161 { 2006 {
2162 /* eating message for normal players */ 2007 /* eating message for normal players */
2163 if (tmp->type == DRINK) 2008 if (tmp->type == DRINK)
2164 sprintf (buf, "Ahhh...that %s tasted good.", &tmp->name); 2009 buf = format ("Ahhh...that %s tasted good.", &tmp->name);
2165 else 2010 else
2166 sprintf (buf, "The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good."); 2011 buf = format ("The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good.");
2167 } 2012 }
2168 else 2013 else
2169 {
2170 /* eating message for dragon players */ 2014 /* eating message for dragon players */
2171 sprintf (buf, "The %s tasted terrible!", &tmp->name); 2015 buf = format ("The %s tasted terrible!", &tmp->name);
2172 }
2173 2016
2174 new_draw_info (NDI_UNIQUE, 0, op, buf); 2017 op->statusmsg (buf);
2018
2175 capacity_remaining = 999 - op->stats.food; 2019 capacity_remaining = 999 - op->stats.food;
2176 op->stats.food += tmp->stats.food; 2020 op->stats.food += tmp->stats.food;
2177 if (capacity_remaining < tmp->stats.food) 2021 if (capacity_remaining < tmp->stats.food)
2178 op->stats.hp += capacity_remaining / 50; 2022 op->stats.hp += capacity_remaining / 50;
2179 else 2023 else
2180 op->stats.hp += tmp->stats.food / 50; 2024 op->stats.hp += tmp->stats.food / 50;
2025
2181 if (op->stats.hp > op->stats.maxhp) 2026 if (op->stats.hp > op->stats.maxhp)
2182 op->stats.hp = op->stats.maxhp; 2027 op->stats.hp = op->stats.maxhp;
2183 if (op->stats.food > 999) 2028 if (op->stats.food > 999)
2184 op->stats.food = 999; 2029 op->stats.food = 999;
2185 } 2030 }
… …
2187 /* special food hack -b.t. */ 2032 /* special food hack -b.t. */
2188 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED)) 2033 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED))
2189 eat_special_food (op, tmp); 2034 eat_special_food (op, tmp);
2190 } 2035 }
2191 } 2036 }
2037
2192 handle_apply_yield (tmp); 2038 handle_apply_yield (tmp);
2193 decrease_ob (tmp); 2039 tmp->decrease ();
2194} 2040}
2195 2041
2196/** 2042/**
2197 * A dragon is eating some flesh. If the flesh contains resistances, 2043 * A dragon is eating some flesh. If the flesh contains resistances,
2198 * there is a chance for the dragon's skin to get improved. 2044 * there is a chance for the dragon's skin to get improved.
… …
2208{ 2054{
2209 object *skin = NULL; /* pointer to dragon skin force */ 2055 object *skin = NULL; /* pointer to dragon skin force */
2210 object *abil = NULL; /* pointer to dragon ability force */ 2056 object *abil = NULL; /* pointer to dragon ability force */
2211 object *tmp = NULL; /* tmp. object */ 2057 object *tmp = NULL; /* tmp. object */
2212 2058
2213 char buf[MAX_BUF]; /* tmp. string buffer */
2214 double chance; /* improvement-chance of one resistance type */ 2059 double chance; /* improvement-chance of one resistance type */
2215 double totalchance = 1; /* total chance of gaining one resistance */ 2060 double totalchance = 1; /* total chance of gaining one resistance */
2216 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */ 2061 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */
2217 double mbonus = 0; /* monster bonus */ 2062 double mbonus = 0; /* monster bonus */
2218 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */ 2063 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */
… …
2223 if (meal->type != FLESH || !is_dragon_pl (op)) 2068 if (meal->type != FLESH || !is_dragon_pl (op))
2224 return 0; 2069 return 0;
2225 2070
2226 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces 2071 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces
2227 from the player's inventory */ 2072 from the player's inventory */
2228 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 2073 for (tmp = op->inv; tmp; tmp = tmp->below)
2229 {
2230 if (tmp->type == FORCE) 2074 if (tmp->type == FORCE)
2231 { 2075 if (tmp->arch->archname == shstr_dragon_skin_force)
2232 if (strcmp (tmp->arch->name, "dragon_skin_force") == 0)
2233 skin = tmp; 2076 skin = tmp;
2234 else if (strcmp (tmp->arch->name, "dragon_ability_force") == 0) 2077 else if (tmp->arch->archname == shstr_dragon_ability_force)
2235 abil = tmp; 2078 abil = tmp;
2236 }
2237 }
2238 2079
2239 /* if either skin or ability are missing, this is an old player 2080 /* if either skin or ability are missing, this is an old player
2240 which is not to be considered a dragon -> bail out */ 2081 which is not to be considered a dragon -> bail out */
2241 if (skin == NULL || abil == NULL) 2082 if (skin == NULL || abil == NULL)
2242 return 0; 2083 return 0;
… …
2244 /* now start by filling stomache and health, according to food-value */ 2085 /* now start by filling stomache and health, according to food-value */
2245 if ((999 - op->stats.food) < meal->stats.food) 2086 if ((999 - op->stats.food) < meal->stats.food)
2246 op->stats.hp += (999 - op->stats.food) / 50; 2087 op->stats.hp += (999 - op->stats.food) / 50;
2247 else 2088 else
2248 op->stats.hp += meal->stats.food / 50; 2089 op->stats.hp += meal->stats.food / 50;
2090
2249 if (op->stats.hp > op->stats.maxhp) 2091 if (op->stats.hp > op->stats.maxhp)
2250 op->stats.hp = op->stats.maxhp; 2092 op->stats.hp = op->stats.maxhp;
2251 2093
2252 op->stats.food = MIN (999, op->stats.food + meal->stats.food); 2094 op->stats.food = MIN (999, op->stats.food + meal->stats.food);
2253 2095
… …
2283 /* doubled chance for resistance of ability-focus */ 2125 /* doubled chance for resistance of ability-focus */
2284 if (i == abil->stats.exp) 2126 if (i == abil->stats.exp)
2285 chance = MIN (100., chance * 2.); 2127 chance = MIN (100., chance * 2.);
2286 2128
2287 /* now make the throw and save all winners (Don't insert luck bonus here!) */ 2129 /* now make the throw and save all winners (Don't insert luck bonus here!) */
2288 if (RANDOM () % 10000 < (int) (chance * 100)) 2130 if (rndm (10000) < (unsigned int) (chance * 100))
2289 { 2131 {
2290 atnr_winner[winners] = i; 2132 atnr_winner[winners] = i;
2291 winners++; 2133 winners++;
2292 } 2134 }
2293 2135
… …
2298 } 2140 }
2299 } 2141 }
2300 2142
2301 /* inverse totalchance as until now we have the failure-chance */ 2143 /* inverse totalchance as until now we have the failure-chance */
2302 totalchance = 100 - totalchance * 100; 2144 totalchance = 100 - totalchance * 100;
2145
2303 /* print message according to totalchance */ 2146 /* print message according to totalchance */
2147 const char *buf;
2304 if (totalchance > 50.) 2148 if (totalchance > 50.)
2305 sprintf (buf, "Hmm! The %s tasted delicious!", &meal->name); 2149 buf = format ("Hmm! The %s tasted delicious!", &meal->name);
2306 else if (totalchance > 10.) 2150 else if (totalchance > 10.)
2307 sprintf (buf, "The %s tasted very good.", &meal->name); 2151 buf = format ("The %s tasted very good.", &meal->name);
2308 else if (totalchance > 1.) 2152 else if (totalchance > 1.)
2309 sprintf (buf, "The %s tasted good.", &meal->name); 2153 buf = format ("The %s tasted good.", &meal->name);
2310 else if (totalchance > 0.1) 2154 else if (totalchance > 0.1)
2311 sprintf (buf, "The %s tasted bland.", &meal->name); 2155 buf = format ("The %s tasted bland.", &meal->name);
2312 else if (totalchance >= 0.01) 2156 else if (totalchance >= 0.01)
2313 sprintf (buf, "The %s had a boring taste.", &meal->name); 2157 buf = format ("The %s had a boring taste.", &meal->name);
2314 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat)) 2158 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat))
2315 sprintf (buf, "The %s tasted strange.", &meal->name); 2159 buf = format ("The %s tasted strange.", &meal->name);
2316 else 2160 else
2317 sprintf (buf, "The %s had no taste.", &meal->name); 2161 buf = format ("The %s had no taste.", &meal->name);
2318 new_draw_info (NDI_UNIQUE, 0, op, buf); 2162
2163 op->statusmsg (buf);
2319 2164
2320 /* now choose a winner if we have any */ 2165 /* now choose a winner if we have any */
2321 i = -1; 2166 i = -1;
2322 if (winners > 0) 2167 if (winners > 0)
2323 i = atnr_winner[RANDOM () % winners]; 2168 i = atnr_winner [rndm (winners)];
2324 2169
2325 if (i >= 0 && i < NROFATTACKS && skin->resist[i] < 95) 2170 if (i >= 0 && i < NROFATTACKS && skin->resist[i] < 95)
2326 { 2171 {
2327 /* resistance increased! */ 2172 /* resistance increased! */
2328 skin->resist[i]++; 2173 skin->resist[i]++;
2329 fix_player (op); 2174 op->update_stats ();
2330 2175
2331 sprintf (buf, "Your skin is now more resistant to %s!", change_resist_msg[i]); 2176 op->statusmsg (format ("Your skin is now more resistant to %s!", change_resist_msg[i]));
2332 new_draw_info (NDI_UNIQUE | NDI_RED, 0, op, buf);
2333 } 2177 }
2334 2178
2335 /* if this flesh contains a new ability focus, we mark it 2179 /* if this flesh contains a new ability focus, we mark it
2336 into the ability_force and it will take effect on next level */ 2180 into the ability_force and it will take effect on next level */
2337 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat) 2181 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat)
2338 { 2182 {
2339 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */ 2183 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */
2340 2184
2341 if (meal->last_eat != abil->stats.exp) 2185 if (meal->last_eat != abil->stats.exp)
2186 op->statusmsg (format (
2187 "Your metabolism prepares to focus on %s!\n"
2188 "The change will happen at level %d.",
2189 change_resist_msg[meal->last_eat],
2190 abil->level + 1
2342 { 2191 ));
2343 sprintf (buf, "Your metabolism prepares to focus on %s!", change_resist_msg[meal->last_eat]);
2344 new_draw_info (NDI_UNIQUE, 0, op, buf);
2345 sprintf (buf, "The change will happen at level %d", abil->level + 1);
2346 new_draw_info (NDI_UNIQUE, 0, op, buf);
2347 }
2348 else 2192 else
2349 { 2193 {
2350 sprintf (buf, "Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]); 2194 op->statusmsg (format ("Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]));
2351 new_draw_info (NDI_UNIQUE, 0, op, buf);
2352 abil->last_eat = 0; 2195 abil->last_eat = 0;
2353 } 2196 }
2354 } 2197 }
2198
2355 return 1; 2199 return 1;
2356}
2357
2358static void
2359apply_savebed (object *pl)
2360{
2361#ifndef COZY_SERVER
2362 if (!pl->contr->name_changed || !pl->stats.exp)
2363 {
2364 new_draw_info (NDI_UNIQUE, 0, pl, "You don't deserve to save your character yet.");
2365 return;
2366 }
2367#endif
2368 INVOKE_PLAYER (LOGOUT, pl->contr);
2369 /* Need to call terminate_all_pets() before we remove the player ob */
2370 terminate_all_pets (pl);
2371 pl->remove ();
2372 pl->direction = 0;
2373 new_draw_info_format (NDI_UNIQUE | NDI_ALL | NDI_DK_ORANGE, 5, pl, "%s leaves the game.", &pl->name);
2374
2375 /* update respawn position */
2376 strcpy (pl->contr->savebed_map, pl->map->path);
2377 pl->contr->bed_x = pl->x;
2378 pl->contr->bed_y = pl->y;
2379
2380 strcpy (pl->contr->killer, "left");
2381 check_score (pl); /* Always check score */
2382 (void) save_player (pl, 0);
2383 pl->map->players--;
2384#if MAP_MAXTIMEOUT
2385 MAP_SWAP_TIME (pl->map) = MAP_TIMEOUT (pl->map);
2386#endif
2387 play_again (pl);
2388 pl->speed = 0;
2389 update_ob_speed (pl);
2390} 2200}
2391 2201
2392/** 2202/**
2393 * Handles applying an improve armor scroll. 2203 * Handles applying an improve armor scroll.
2394 * Does some sanity checks, then calls improve_armour. 2204 * Does some sanity checks, then calls improve_armour.
… …
2396static void 2206static void
2397apply_armour_improver (object *op, object *tmp) 2207apply_armour_improver (object *op, object *tmp)
2398{ 2208{
2399 object *armor; 2209 object *armor;
2400 2210
2401 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 2211 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_NO_MAGIC))
2402 { 2212 {
2403 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 2213 op->failmsg ("Something blocks the magic of the scroll. H<This area prevents magic effects.>");
2404 return; 2214 return;
2405 } 2215 }
2216
2406 armor = find_marked_object (op); 2217 armor = find_marked_object (op);
2218
2407 if (!armor) 2219 if (!armor)
2408 { 2220 {
2409 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark an armor object."); 2221 op->failmsg ("You need to mark an armor object. Use the right mouse button popup or the mark command to do this.");
2410 return; 2222 return;
2411 } 2223 }
2224
2412 if (armor->type != ARMOUR 2225 if (armor->type != ARMOUR
2413 && armor->type != CLOAK 2226 && armor->type != CLOAK
2414 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET) 2227 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET)
2415 { 2228 {
2416 new_draw_info (NDI_UNIQUE, 0, op, "Your marked item is not armour!\n"); 2229 op->failmsg ("Your marked item is not armour!\n");
2417 return; 2230 return;
2418 } 2231 }
2419 2232
2420 new_draw_info (NDI_UNIQUE, 0, op, "Applying armour enchantment."); 2233 op->statusmsg ("Applying armour enchantment.");
2421 improve_armour (op, tmp, armor); 2234 improve_armour (op, tmp, armor);
2422} 2235}
2423 2236
2424 2237void
2425extern void
2426apply_poison (object *op, object *tmp) 2238apply_poison (object *op, object *tmp)
2427{ 2239{
2240 // need to do it now when it is still on the map
2241 handle_apply_yield (tmp);
2242
2243 object *poison = tmp->split (1);
2244
2428 if (op->type == PLAYER) 2245 if (op->type == PLAYER)
2429 { 2246 {
2430 play_sound_player_only (op->contr, SOUND_DRINK_POISON, 0, 0); 2247 op->contr->play_sound (sound_find ("drink_poison"));
2431 new_draw_info (NDI_UNIQUE, 0, op, "Yech! That tasted poisonous!"); 2248 op->failmsg ("Yech! That tasted poisonous!");
2432 strcpy (op->contr->killer, "poisonous booze"); 2249 op->contr->killer = poison;
2433 } 2250 }
2251
2434 if (tmp->stats.hp > 0) 2252 if (poison->stats.hp > 0)
2435 { 2253 {
2436 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", tmp->stats.hp); 2254 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", poison->stats.hp);
2437 hit_player (op, tmp->stats.hp, tmp, AT_POISON, 1); 2255 hit_player (op, poison->stats.hp, tmp, AT_POISON, 1);
2438 } 2256 }
2257
2439 op->stats.food -= op->stats.food / 4; 2258 op->stats.food -= op->stats.food / 4;
2440 handle_apply_yield (tmp); 2259 poison->destroy ();
2441 decrease_ob (tmp);
2442} 2260}
2443 2261
2444/** 2262/**
2445 * This fonction return true if the exit is not a 2 ways one or it is 2 ways, valid exit. 2263 * This function return true if the exit is not a 2 ways one or it is 2 ways, valid exit.
2446 * A valid 2 way exit means: 2264 * A valid 2 way exit means:
2447 * -You can come back (there is another exit at the other side) 2265 * -You can come back (there is another exit at the other side)
2448 * -You are 2266 * -You are
2449 * ° the owner of the exit 2267 * ° the owner of the exit
2450 * ° or in the same party as the owner 2268 * ° or in the same party as the owner
2451 * 2269 *
2452 * Note: a owner in a 2 way exit is saved as the owner's name 2270 * Note: a owner in a 2 way exit is saved as the owner's name
2453 * in the field exit->name cause the field exit->owner doesn't 2271 * in the field exit->name cause the field exit->owner doesn't
2454 * survive in the swapping (in fact the whole exit doesn't survive). 2272 * survive in the swapping (in fact the whole exit doesn't survive).
2455 */ 2273 */
2456int 2274int
2457is_legal_2ways_exit (object *op, object *exit) 2275is_legal_2ways_exit (object *op, object *exit)
2458{ 2276{
2459 object *tmp;
2460 object *exit_owner;
2461 player *pp;
2462 maptile *exitmap;
2463
2464 if (exit->stats.exp != 1) 2277 if (exit->stats.exp != 1)
2465 return 1; /*This is not a 2 way, so it is legal */ 2278 return 1; /*This is not a 2 way, so it is legal */
2279
2280#if 0 //TODO
2466 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race) 2281 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race)
2467 return 0; /* This is a reset town portal */ 2282 return 0; /* This is a reset town portal */
2468 /* To know if an exit has a correspondant, we look at 2283#endif
2469 * all the exits in destination and try to find one with same path as 2284
2470 * the current exit's position */ 2285 LOG (llevError | logBacktrace, "sync map load due to %s\n", exit->debug_desc ());
2471 if (!strncmp (EXIT_PATH (exit), settings.localdir, strlen (settings.localdir))) 2286
2472 exitmap = ready_map_name (EXIT_PATH (exit), MAP_PLAYER_UNIQUE); 2287 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map);
2473 else 2288
2474 exitmap = ready_map_name (EXIT_PATH (exit), 0);
2475 if (exitmap) 2289 if (exitmap)
2476 { 2290 {
2291 exitmap->load_sync ();
2292
2477 tmp = get_map_ob (exitmap, EXIT_X (exit), EXIT_Y (exit)); 2293 object *tmp = exitmap->at (EXIT_X (exit), EXIT_Y (exit)).bot;
2294
2478 if (!tmp) 2295 if (!tmp)
2479 return 0; 2296 return 0;
2480 for ((tmp = get_map_ob (exitmap, EXIT_X (exit), EXIT_Y (exit))); tmp; tmp = tmp->above) 2297
2298 for (; tmp; tmp = tmp->above)
2481 { 2299 {
2482 if (tmp->type != EXIT) 2300 if (tmp->type != EXIT)
2483 continue; /*Not an exit */ 2301 continue; /*Not an exit */
2302
2484 if (!EXIT_PATH (tmp)) 2303 if (!EXIT_PATH (tmp))
2485 continue; /*Not a valid exit */ 2304 continue; /*Not a valid exit */
2305
2486 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y)) 2306 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y))
2487 continue; /*Not in the same place */ 2307 continue; /*Not in the same place */
2308
2488 if (strcmp (exit->map->path, EXIT_PATH (tmp)) != 0) 2309 if (exit->map->path != EXIT_PATH (tmp))
2489 continue; /*Not in the same map */ 2310 continue; /*Not in the same map */
2490 2311
2491 /* From here we have found the exit is valid. However we do 2312 /* From here we have found the exit is valid. However we do
2492 * here the check of the exit owner. It is important for the 2313 * here the check of the exit owner. It is important for the
2493 * town portals to prevent strangers from visiting your appartments 2314 * town portals to prevent strangers from visiting your appartments
2494 */ 2315 */
2495 if (!exit->race) 2316 if (!exit->race)
2496 return 1; /*No owner, free for all! */ 2317 return 1; /*No owner, free for all! */
2318
2497 exit_owner = NULL; 2319 object *exit_owner = 0;
2498 for (pp = first_player; pp; pp = pp->next) 2320
2321 for_all_players (pp)
2499 { 2322 {
2500 if (!pp->ob) 2323 if (!pp->ob)
2501 continue; 2324 continue;
2325
2502 if (pp->ob->name != exit->race) 2326 if (pp->ob->name != exit->race)
2503 continue; 2327 continue;
2328
2504 exit_owner = pp->ob; /*We found a player which correspond to the player name */ 2329 exit_owner = pp->ob; /*We found a player which correspond to the player name */
2505 break; 2330 break;
2506 } 2331 }
2332
2507 if (!exit_owner) 2333 if (!exit_owner)
2508 return 0; /* No more owner */ 2334 return 0; /* No more owner */
2335
2509 if (exit_owner->contr == op->contr) 2336 if (exit_owner->contr == op->contr)
2510 return 1; /*It is your exit */ 2337 return 1; /*It is your exit */
2338
2511 if (exit_owner && /*There is a owner */ 2339 if (exit_owner && /*There is a owner */
2512 (op->contr) && /*A player tries to pass */ 2340 (op->contr) && /*A player tries to pass */
2513 ((exit_owner->contr->party == NULL) || /*No pass if controller has no party */ 2341 ((exit_owner->contr->party == NULL) || /*No pass if controller has no party */
2514 (exit_owner->contr->party != op->contr->party))) /* Or not the same as op */ 2342 (exit_owner->contr->party != op->contr->party))) /* Or not the same as op */
2515 return 0; 2343 return 0;
2344
2516 return 1; 2345 return 1;
2517 } 2346 }
2518 } 2347 }
2348
2519 return 0; 2349 return 0;
2520} 2350}
2521
2522 2351
2523/** 2352/**
2524 * Main apply handler. 2353 * Main apply handler.
2525 * 2354 *
2526 * Checks for unpaid items before applying. 2355 * Checks for unpaid items before applying.
… …
2534 * being applied. 2363 * being applied.
2535 * 2364 *
2536 * aflag is special (always apply/unapply) flags. Nothing is done with 2365 * aflag is special (always apply/unapply) flags. Nothing is done with
2537 * them in this function - they are passed to apply_special 2366 * them in this function - they are passed to apply_special
2538 */ 2367 */
2539
2540int 2368int
2541manual_apply (object *op, object *tmp, int aflag) 2369manual_apply (object *op, object *tmp, int aflag)
2542{ 2370{
2543 if (tmp->head)
2544 tmp = tmp->head; 2371 tmp = tmp->head_ ();
2545 2372
2546 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED)) 2373 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED))
2547 { 2374 {
2548 if (op->type == PLAYER) 2375 if (op->type == PLAYER)
2549 { 2376 {
2550 new_draw_info (NDI_UNIQUE, 0, op, "You should pay for it first."); 2377 op->failmsg ("You should pay for it first! H<You cannot use items marked as unpaid.>");
2551 return 1; 2378 return 1;
2552 } 2379 }
2553 else 2380 else
2554 {
2555 return 0; /* monsters just skip unpaid items */ 2381 return 0; /* monsters just skip unpaid items */
2556 }
2557 } 2382 }
2558 2383
2559 if (INVOKE_OBJECT (APPLY, tmp, ARG_OBJECT (op))) 2384 if (INVOKE_OBJECT (APPLY, tmp, ARG_OBJECT (op)))
2560 return RESULT_INT (0); 2385 return RESULT_INT (0);
2561 2386
2562 switch (tmp->type) 2387 switch (tmp->type)
2563 { 2388 {
2564
2565 case CF_HANDLE: 2389 case CF_HANDLE:
2566 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2390 op->play_sound (sound_find ("turn_handle"));
2567 play_sound_map (op->map, op->x, op->y, SOUND_TURN_HANDLE); 2391 op->statusmsg ("You turn the handle.");
2568 tmp->value = tmp->value ? 0 : 1; 2392 tmp->value = tmp->value ? 0 : 1;
2569 SET_ANIMATION (tmp, tmp->value); 2393 SET_ANIMATION (tmp, tmp->value);
2570 update_object (tmp, UP_OBJ_FACE); 2394 update_object (tmp, UP_OBJ_FACE);
2571 push_button (tmp); 2395 push_button (tmp);
2572 return 1; 2396 return 1;
2573 2397
2574 case TRIGGER: 2398 case TRIGGER:
2575 if (check_trigger (tmp, op)) 2399 if (check_trigger (tmp, op))
2576 { 2400 {
2577 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2401 op->statusmsg ("You turn the handle.");
2578 play_sound_map (tmp->map, tmp->x, tmp->y, SOUND_TURN_HANDLE); 2402 op->play_sound (sound_find ("turn_handle"));
2579 } 2403 }
2580 else 2404 else
2581 { 2405 op->failmsg ("The handle doesn't move.");
2582 new_draw_info (NDI_UNIQUE, 0, op, "The handle doesn't move."); 2406
2583 }
2584 return 1; 2407 return 1;
2585 2408
2586 case EXIT: 2409 case EXIT:
2587 if (op->type != PLAYER) 2410 if (op->type != PLAYER)
2588 return 0; 2411 return 0;
2412
2589 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp)) 2413 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp))
2590 { 2414 op->failmsg (format ("The %s is closed.", query_name (tmp)));
2591 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s is closed.", query_name (tmp));
2592 }
2593 else 2415 else
2594 { 2416 {
2595 /* Don't display messages for random maps. */ 2417 /* Don't display messages for random maps. */
2596 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2) && strncmp (EXIT_PATH (tmp), "/random/", 8)) 2418 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2))
2597 new_draw_info (NDI_NAVY, 0, op, tmp->msg); 2419 op->statusmsg (tmp->msg, NDI_NAVY);
2420
2598 enter_exit (op, tmp); 2421 op->enter_exit (tmp);
2599 } 2422 }
2423
2424 return 1;
2425
2426 case INSCRIBABLE:
2427 op->statusmsg (tmp->msg);
2428 // maybe show a spell menu to chose from or something like that
2600 return 1; 2429 return 1;
2601 2430
2602 case SIGN: 2431 case SIGN:
2603 apply_sign (op, tmp, 0); 2432 apply_sign (op, tmp, 0);
2604 return 1; 2433 return 1;
… …
2608 { 2437 {
2609 apply_book (op, tmp); 2438 apply_book (op, tmp);
2610 return 1; 2439 return 1;
2611 } 2440 }
2612 else 2441 else
2613 {
2614 return 0; 2442 return 0;
2615 }
2616 2443
2617 case SKILLSCROLL: 2444 case SKILLSCROLL:
2618 if (op->type == PLAYER) 2445 if (op->type == PLAYER)
2619 { 2446 {
2620 apply_skillscroll (op, tmp); 2447 apply_skillscroll (op, tmp);
2621 return 1; 2448 return 1;
2622 } 2449 }
2450 else
2623 return 0; 2451 return 0;
2624 2452
2625 case SPELLBOOK: 2453 case SPELLBOOK:
2626 if (op->type == PLAYER) 2454 if (op->type == PLAYER)
2627 { 2455 {
2628 apply_spellbook (op, tmp); 2456 apply_spellbook (op, tmp);
2629 return 1; 2457 return 1;
2630 } 2458 }
2459 else
2631 return 0; 2460 return 0;
2632 2461
2633 case SCROLL: 2462 case SCROLL:
2634 apply_scroll (op, tmp, 0); 2463 apply_scroll (op, tmp, 0);
2635 return 1; 2464 return 1;
2636 2465
2637 case POTION: 2466 case POTION:
2638 (void) apply_potion (op, tmp); 2467 apply_potion (op, tmp);
2639 return 1; 2468 return 1;
2640 2469
2641 /* Eneq(@csd.uu.se): Handle apply on containers. */ 2470 /* Eneq(@csd.uu.se): Handle apply on containers. */
2471 //TODO: remove, as it is unsed?
2642 case CLOSE_CON: 2472 case CLOSE_CON:
2643 if (op->type == PLAYER)
2644 (void) esrv_apply_container (op, tmp->env);
2645 else
2646 (void) apply_container (op, tmp->env); 2473 apply_container (op, tmp->env);
2647 return 1; 2474 return 1;
2648 2475
2649 case CONTAINER: 2476 case CONTAINER:
2650 if (op->type == PLAYER)
2651 (void) esrv_apply_container (op, tmp);
2652 else
2653 (void) apply_container (op, tmp); 2477 apply_container (op, tmp);
2654 return 1; 2478 return 1;
2655 2479
2656 case TREASURE: 2480 case TREASURE:
2657 if (op->type == PLAYER) 2481 if (op->type == PLAYER)
2658 { 2482 {
2659 apply_treasure (op, tmp); 2483 apply_treasure (op, tmp);
2660 return 1; 2484 return 1;
2661 } 2485 }
2662 else 2486 else
2663 {
2664 return 0; 2487 return 0;
2665 }
2666 2488
2667 case WEAPON: 2489 case WEAPON:
2668 case ARMOUR: 2490 case ARMOUR:
2669 case BOOTS: 2491 case BOOTS:
2670 case GLOVES: 2492 case GLOVES:
… …
2683 case LAMP: 2505 case LAMP:
2684 case BUILDER: 2506 case BUILDER:
2685 case SKILL_TOOL: 2507 case SKILL_TOOL:
2686 if (tmp->env != op) 2508 if (tmp->env != op)
2687 return 2; /* not in inventory */ 2509 return 2; /* not in inventory */
2510
2688 (void) apply_special (op, tmp, aflag); 2511 apply_special (op, tmp, aflag);
2689 return 1; 2512 return 1;
2690 2513
2691 case DRINK: 2514 case DRINK:
2692 case FOOD: 2515 case FOOD:
2693 case FLESH: 2516 case FLESH:
… …
2697 case POISON: 2520 case POISON:
2698 apply_poison (op, tmp); 2521 apply_poison (op, tmp);
2699 return 1; 2522 return 1;
2700 2523
2701 case SAVEBED: 2524 case SAVEBED:
2702 if (op->type == PLAYER)
2703 {
2704 apply_savebed (op);
2705 return 1; 2525 return 1;
2706 }
2707 else
2708 {
2709 return 0;
2710 }
2711 2526
2712 case ARMOUR_IMPROVER: 2527 case ARMOUR_IMPROVER:
2713 if (op->type == PLAYER) 2528 if (op->type == PLAYER)
2714 { 2529 {
2715 apply_armour_improver (op, tmp); 2530 apply_armour_improver (op, tmp);
2716 return 1; 2531 return 1;
2717 } 2532 }
2718 else 2533 else
2719 {
2720 return 0; 2534 return 0;
2721 }
2722 2535
2723 case WEAPON_IMPROVER: 2536 case WEAPON_IMPROVER:
2724 (void) check_improve_weapon (op, tmp); 2537 check_improve_weapon (op, tmp);
2725 return 1; 2538 return 1;
2726 2539
2727 case CLOCK: 2540 case CLOCK:
2728 if (op->type == PLAYER) 2541 if (op->type == PLAYER)
2729 { 2542 {
2730 char buf[MAX_BUF]; 2543 char buf[MAX_BUF];
2731 timeofday_t tod; 2544 timeofday_t tod;
2732 2545
2733 get_tod (&tod); 2546 get_tod (&tod);
2547 op->play_sound (sound_find ("sound_clock"));
2548 op->statusmsg (format (
2734 sprintf (buf, "It is %d minute%s past %d o'clock %s", 2549 "It is %d minute%s past %d o'clock %s",
2735 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"), 2550 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"),
2736 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")); 2551 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")
2737 play_sound_player_only (op->contr, SOUND_CLOCK, 0, 0); 2552 ));
2738 new_draw_info (NDI_UNIQUE, 0, op, buf);
2739 return 1; 2553 return 1;
2740 } 2554 }
2741 else 2555 else
2742 {
2743 return 0; 2556 return 0;
2744 }
2745 2557
2746 case MENU: 2558 case MENU:
2747 if (op->type == PLAYER) 2559 if (op->type == PLAYER)
2748 { 2560 {
2749 shop_listing (op); 2561 shop_listing (tmp, op);
2750 return 1; 2562 return 1;
2751 } 2563 }
2752 else 2564 else
2753 {
2754 return 0; 2565 return 0;
2755 }
2756 2566
2757 case POWER_CRYSTAL: 2567 case POWER_CRYSTAL:
2758 apply_power_crystal (op, tmp); /* see egoitem.c */ 2568 apply_power_crystal (op, tmp); /* see egoitem.c */
2759 return 1; 2569 return 1;
2760 2570
… …
2763 { 2573 {
2764 apply_lighter (op, tmp); 2574 apply_lighter (op, tmp);
2765 return 1; 2575 return 1;
2766 } 2576 }
2767 else 2577 else
2768 {
2769 return 0; 2578 return 0;
2770 }
2771 2579
2772 case ITEM_TRANSFORMER: 2580 case ITEM_TRANSFORMER:
2773 apply_item_transformer (op, tmp); 2581 apply_item_transformer (op, tmp);
2774 return 1; 2582 return 1;
2775 2583
2776 default: 2584 default:
2777 return 0; 2585 return 0;
2778 } 2586 }
2779} 2587}
2780
2781 2588
2782/* quiet suppresses the "don't know how to apply" and "you must get it first" 2589/* quiet suppresses the "don't know how to apply" and "you must get it first"
2783 * messages as needed by player_apply_below(). But there can still be 2590 * messages as needed by player_apply_below(). But there can still be
2784 * "but you are floating high above the ground" messages. 2591 * "but you are floating high above the ground" messages.
2785 * 2592 *
2786 * Same return value as apply() function. 2593 * Same return value as apply() function.
2787 */ 2594 */
2788int 2595int
2789player_apply (object *pl, object *op, int aflag, int quiet) 2596player_apply (object *pl, object *op, int aflag, int quiet)
2790{ 2597{
2791 int tmp;
2792
2793 if (op->env == NULL && (pl->move_type & MOVE_FLYING)) 2598 if (!op->env && (pl->move_type & MOVE_FLYING))
2794 { 2599 {
2795 /* player is flying and applying object not in inventory */ 2600 /* player is flying and applying object not in inventory */
2796 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING)) 2601 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING))
2797 { 2602 {
2798 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high " "above the ground!"); 2603 pl->failmsg ("But you are floating high above the ground! "
2604 "H<You have to stop levitating first, if you can, either by using your levitation skill, "
2605 "or waiting till the levitation effect wears off.>");
2799 return 0; 2606 return 0;
2800 } 2607 }
2801 } 2608 }
2802 2609
2803 /* Check for PLAYER to avoid a DM to disappear in a puff of smoke if
2804 * applied.
2805 */
2806 if (op->type != PLAYER && QUERY_FLAG (op, FLAG_WAS_WIZ) && !QUERY_FLAG (pl, FLAG_WAS_WIZ))
2807 {
2808 play_sound_map (pl->map, pl->x, pl->y, SOUND_OB_EVAPORATE);
2809 new_draw_info (NDI_UNIQUE, 0, pl, "The object disappears in a puff " "of smoke!");
2810 new_draw_info (NDI_UNIQUE, 0, pl, "It must have been an illusion.");
2811 op->destroy ();
2812 return 1;
2813 }
2814
2815 pl->contr->last_used = op; 2610 pl->contr->last_used = op;
2816 pl->contr->last_used_id = op->count;
2817 2611
2818 tmp = manual_apply (pl, op, aflag); 2612 int tmp = manual_apply (pl, op, aflag);
2613
2819 if (!quiet) 2614 if (!quiet)
2820 { 2615 {
2821 if (tmp == 0) 2616 if (tmp == 0)
2822 new_draw_info_format (NDI_UNIQUE, 0, pl, "I don't know how to apply the %s.", query_name (op)); 2617 pl->statusmsg (format ("I don't know how to apply the %s.", query_name (op)));
2823 else if (tmp == 2) 2618 else if (tmp == 2)
2824 new_draw_info_format (NDI_UNIQUE, 0, pl, "You must get it first!\n"); 2619 pl->failmsg ("You must get it first!\n");
2825 } 2620 }
2621
2826 return tmp; 2622 return tmp;
2827} 2623}
2828 2624
2829/** 2625/**
2830 * player_apply_below attempts to apply the object 'below' the player. 2626 * player_apply_below attempts to apply the object 'below' the player.
2831 * If the player has an open container, we use that for below, otherwise 2627 * If the player has an open container, we use that for below, otherwise
2832 * we use the ground. 2628 * we use the ground.
2833 */ 2629 */
2834
2835void 2630void
2836player_apply_below (object *pl) 2631player_apply_below (object *pl)
2837{ 2632{
2838 object *tmp, *next;
2839 int floors; 2633 int floors = 0;
2840 2634
2841 /* If using a container, set the starting item to be the top 2635 /* If using a container, set the starting item to be the top
2842 * item in the container. Otherwise, use the map. 2636 * item in the container. Otherwise, use the map.
2843 */
2844 tmp = (pl->container != NULL) ? pl->container->inv : pl->below;
2845
2846 /* This is perhaps more complicated. However, I want to make sure that 2637 * This is perhaps more complicated. However, I want to make sure that
2847 * we don't use a corrupt pointer for the next object, so we get the 2638 * we don't use a corrupt pointer for the next object, so we get the
2848 * next object in the stack before applying. This is can only be a 2639 * next object in the stack before applying. This is can only be a
2849 * problem if player_apply() has a bug in that it uses the object but does 2640 * problem if player_apply() has a bug in that it uses the object but does
2850 * not return a proper value. 2641 * not return a proper value.
2851 */ 2642 */
2852 for (floors = 0; tmp != NULL; tmp = next) 2643 for (object *next, *tmp = pl->container ? pl->container->inv : pl->below; tmp; tmp = next)
2853 { 2644 {
2854 next = tmp->below; 2645 next = tmp->below;
2646
2855 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 2647 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
2856 floors++; 2648 floors++;
2857 else if (floors > 0) 2649 else if (floors > 0)
2858 return; /* process only floor objects after first floor object */ 2650 return; /* process only floor objects after first floor object */
2859 2651
… …
2861 * person moving on it, also activate. Added code to make it 2653 * person moving on it, also activate. Added code to make it
2862 * so that at least one of players movement types be that which 2654 * so that at least one of players movement types be that which
2863 * the item needs. 2655 * the item needs.
2864 */ 2656 */
2865 if (!tmp->invisible || (tmp->move_on & pl->move_type)) 2657 if (!tmp->invisible || (tmp->move_on & pl->move_type))
2866 {
2867 if (player_apply (pl, tmp, 0, 1) == 1) 2658 if (player_apply (pl, tmp, 0, 1) == 1)
2868 return; 2659 return;
2869 } 2660
2870 if (floors >= 2) 2661 if (floors >= 2)
2871 return; /* process at most two floor objects */ 2662 return; /* process at most two floor objects */
2872 } 2663 }
2873} 2664}
2874 2665
… …
2879 * to keep the size of apply_special to a more managable size. 2670 * to keep the size of apply_special to a more managable size.
2880 */ 2671 */
2881static int 2672static int
2882unapply_special (object *who, object *op, int aflags) 2673unapply_special (object *who, object *op, int aflags)
2883{ 2674{
2884 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags)) || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags))) 2675 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags))
2676 || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags)))
2885 return RESULT_INT (0); 2677 return RESULT_INT (0);
2886 2678
2887 object *tmp2;
2888
2889 CLEAR_FLAG (op, FLAG_APPLIED); 2679 CLEAR_FLAG (op, FLAG_APPLIED);
2680
2890 switch (op->type) 2681 switch (op->type)
2891 { 2682 {
2683 case SKILL_TOOL:
2684 // unapplying a skill tool should also unapply the skill it governs
2685 // but this is hard, as it shouldn't do so when the skill can
2686 // be used for other reasons
2687 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2688 if (tmp->skill == op->skill
2689 && tmp->type == SKILL
2690 && tmp->flag [FLAG_APPLIED]
2691 && !tmp->flag [FLAG_CAN_USE_SKILL])
2692 unapply_special (who, tmp, 0);
2693
2694 change_abil (who, op);
2695 break;
2696
2892 case WEAPON: 2697 case WEAPON:
2893 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op)); 2698 if (player *pl = who->contr)
2699 if (op == pl->combat_ob)
2700 {
2701 pl->combat_ob = 0;
2702 who->change_weapon (pl->ranged_ob);
2703 }
2894 2704
2705 who->statusmsg (format ("You unwield %s.", query_name (op)));
2706
2895 (void) change_abil (who, op); 2707 change_abil (who, op);
2896 if (QUERY_FLAG (who, FLAG_READY_WEAPON))
2897 CLEAR_FLAG (who, FLAG_READY_WEAPON); 2708 CLEAR_FLAG (who, FLAG_READY_WEAPON);
2898 clear_skill (who);
2899 break; 2709 break;
2900 2710
2901 case SKILL: /* allows objects to impart skills */
2902 case SKILL_TOOL: 2711 case SKILL:
2903 if (op != who->chosen_skill) 2712 if (who->contr)
2904 { 2713 {
2905 LOG (llevError, "BUG: apply_special(): applied skill is not a chosen skill\n"); 2714 if (IS_COMBAT_SKILL (op->subtype))
2715 who->change_weapon (who->contr->combat_ob = 0);
2716 else if (IS_RANGED_SKILL (op->subtype))
2717 who->change_weapon (who->contr->ranged_ob = 0);
2718
2719 if (op->invisible)
2720 who->statusmsg (format ("You can no longer use the skill: %s.", &op->skill));
2721 else
2722 who->statusmsg (format ("You stop using the %s.", query_name (op)));
2906 } 2723 }
2907 if (who->type == PLAYER) 2724
2908 {
2909 if (who->contr->shoottype == range_skill)
2910 who->contr->shoottype = range_none;
2911 if (!op->invisible)
2912 {
2913 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op));
2914 }
2915 else
2916 {
2917 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill);
2918 }
2919 }
2920 (void) change_abil (who, op); 2725 change_abil (who, op);
2921 who->chosen_skill = NULL;
2922 CLEAR_FLAG (who, FLAG_READY_SKILL); 2726 CLEAR_FLAG (who, FLAG_READY_SKILL);
2923 break; 2727 break;
2924 2728
2925 case ARMOUR: 2729 case ARMOUR:
2926 case HELMET: 2730 case HELMET:
… …
2930 case GLOVES: 2734 case GLOVES:
2931 case AMULET: 2735 case AMULET:
2932 case GIRDLE: 2736 case GIRDLE:
2933 case BRACERS: 2737 case BRACERS:
2934 case CLOAK: 2738 case CLOAK:
2935 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op)); 2739 who->statusmsg (format ("You unwear %s.", query_name (op)));
2936 (void) change_abil (who, op); 2740 change_abil (who, op);
2937 break; 2741 break;
2742
2938 case LAMP: 2743 case LAMP:
2939 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name); 2744 {
2745 who->statusmsg (format ("You turn off your %s.", &op->name));
2746
2940 tmp2 = arch_to_object (op->other_arch); 2747 object *tmp2 = arch_to_object (op->other_arch);
2941 tmp2->x = op->x; 2748 tmp2->x = op->x;
2942 tmp2->y = op->y; 2749 tmp2->y = op->y;
2943 tmp2->map = op->map; 2750 tmp2->map = op->map;
2944 tmp2->below = op->below; 2751 tmp2->below = op->below;
2945 tmp2->above = op->above; 2752 tmp2->above = op->above;
2946 tmp2->stats.food = op->stats.food; 2753 tmp2->stats.food = op->stats.food;
2947 CLEAR_FLAG (tmp2, FLAG_APPLIED); 2754 CLEAR_FLAG (tmp2, FLAG_APPLIED);
2948 2755
2949 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 2756 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
2950 SET_FLAG (tmp2, FLAG_INV_LOCKED); 2757 SET_FLAG (tmp2, FLAG_INV_LOCKED);
2951 2758
2952 if (who->type == PLAYER)
2953 esrv_del_item (who->contr, op->count);
2954
2955 op->destroy (); 2759 op->destroy ();
2956 insert_ob_in_ob (tmp2, who); 2760 who->insert (tmp2);
2957 fix_player (who); 2761 who->update_stats ();
2762
2763 if (who->contr)
2958 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 2764 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
2959 {
2960 if (who->type == PLAYER)
2961 { 2765 {
2962 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 2766 who->failmsg ("Oops, it feels deadly cold!");
2963 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 2767 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
2964 } 2768 }
2965 } 2769 }
2966 if (who->type == PLAYER) 2770
2967 esrv_send_item (who, tmp2);
2968 return 1; /* otherwise, an attempt to drop causes problems */ 2771 return 1; /* otherwise, an attempt to drop causes problems */
2969 break; 2772
2970 case BOW: 2773 case BOW:
2971 case WAND: 2774 case WAND:
2972 case ROD: 2775 case ROD:
2973 case HORN: 2776 case HORN:
2974 clear_skill (who); 2777 if (player *pl = who->contr)
2975 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op));
2976 if (who->type == PLAYER)
2977 { 2778 {
2978 who->contr->shoottype = range_none; 2779 if (op == pl->ranged_ob)
2780 {
2781 pl->ranged_ob = 0;
2782 who->change_weapon (pl->combat_ob);
2783 }
2784
2785 who->statusmsg (format ("You unready %s.", query_name (op)));
2979 } 2786 }
2980 else 2787 else
2981 { 2788 {
2789 who->change_skill (0);
2790
2982 if (op->type == BOW) 2791 if (op->type == BOW)
2983 CLEAR_FLAG (who, FLAG_READY_BOW); 2792 CLEAR_FLAG (who, FLAG_READY_BOW);
2984 else 2793 else
2985 CLEAR_FLAG (who, FLAG_READY_RANGE); 2794 CLEAR_FLAG (who, FLAG_READY_RANGE);
2986 } 2795 }
2796
2987 break; 2797 break;
2988 2798
2989 case BUILDER: 2799 case BUILDER:
2990 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2800 if (who->contr)
2991 who->contr->shoottype = range_none; 2801 who->statusmsg (format ("You unready %s.", query_name (op)));
2992 who->contr->ranges[range_builder] = NULL;
2993 break; 2802 break;
2994 2803
2995 default: 2804 default:
2996 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op)); 2805 who->statusmsg (format ("You unapply %s.", query_name (op)));
2997 break; 2806 break;
2998 } 2807 }
2999 2808
3000 fix_player (who); 2809 if (aflags & AP_NO_MERGE || !merge_ob (op, 0))
3001 2810 if (object *pl = op->visible_to ())
3002 if (!(aflags & AP_NO_MERGE))
3003 {
3004 object *tmp;
3005
3006 tmp = merge_ob (op, NULL);
3007 if (who->type == PLAYER)
3008 {
3009 if (tmp)
3010 { /* it was merged */
3011 esrv_del_item (who->contr, op->count);
3012 op = tmp;
3013 }
3014
3015 esrv_send_item (who, op); 2811 esrv_send_item (pl, op);
3016 } 2812
3017 } 2813 who->update_stats ();
2814
3018 return 0; 2815 return 0;
3019} 2816}
3020 2817
3021/** 2818/**
3022 * Returns the object that is using location 'loc'. 2819 * Returns the object that is using location 'loc'.
3023 * Note that 'start' is the first object to start examing - we 2820 * Note that 'start' is the first object to start examing - we
3024 * then go through the below of this. In this way, you can do 2821 * then go through the below of this. In this way, you can do
3025 * something like: 2822 * something like:
3026 * tmp = get_item_from_body_location(who->inv, 1); 2823 * tmp = get_next_item_from_body_location(who->inv, 1);
3027 * if (tmp) tmp1 = get_item_from_body_location(tmp->below, 1); 2824 * if (tmp) tmp1 = get_next_item_from_body_location(tmp->below, 1);
3028 * to find the second object that may use this location, etc. 2825 * to find the second object that may use this location, etc.
3029 * Returns NULL if no match is found. 2826 * Returns NULL if no match is found.
3030 * loc is the index into the array we are looking for a match. 2827 * loc is the index into the array we are looking for a match.
3031 * don't return invisible objects unless they are skill objects 2828 * don't return invisible objects unless they are skill objects
3032 * invisible other objects that use 2829 * invisible other objects that use
3033 * up body locations can be used as restrictions. 2830 * up body locations can be used as restrictions.
3034 */ 2831 */
3035object * 2832static object *
3036get_item_from_body_location (object *start, int loc) 2833get_next_item_from_body_location (int loc, object *start)
3037{ 2834{
3038 object *tmp;
3039
3040 if (!start)
3041 return NULL;
3042
3043 for (tmp = start; tmp; tmp = tmp->below) 2835 for (object *tmp = start; tmp; tmp = tmp->below)
3044 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->body_info[loc] && (!tmp->invisible || tmp->type == SKILL)) 2836 if (tmp->flag [FLAG_APPLIED]
2837 && tmp->slot[loc].info
2838 && (!tmp->invisible || tmp->type == SKILL))
3045 return tmp; 2839 return tmp;
3046 2840
3047 return NULL; 2841 return 0;
3048} 2842}
3049
3050
3051 2843
3052/** 2844/**
3053 * 'op' wants to apply an object, but can't because of other equipment. 2845 * 'op' wants to apply an object, but can't because of other equipment.
3054 * This should only be called when it is known 2846 * This should only be called when it is known
3055 * that there are objects to unapply. This makes pretty heavy 2847 * that there are objects to unapply. This makes pretty heavy
… …
3058 * Returns 0 on success, returns 1 if there is some problem. 2850 * Returns 0 on success, returns 1 if there is some problem.
3059 * if aflags is AP_PRINT, we instead print out waht to unapply 2851 * if aflags is AP_PRINT, we instead print out waht to unapply
3060 * instead of doing it. This is a lot less code than having 2852 * instead of doing it. This is a lot less code than having
3061 * another function that does just that. 2853 * another function that does just that.
3062 */ 2854 */
2855
2856#define CANNOT_REMOVE_CURSED \
2857 "H<You cannot remove cursed or damned items, you first have to remove the curse. " \
2858 "Praying over an altar, scrolls of remove curse/damnation, " \
2859 "priests or even other players might help.>"
2860
3063int 2861int
3064unapply_for_ob (object *who, object *op, int aflags) 2862unapply_for_ob (object *who, object *op, int aflags)
3065{ 2863{
3066 int i; 2864 if (op->is_range ())
3067 object *tmp = NULL, *last;
3068
3069 /* If we are applying a shield or weapon, unapply any equipped shield
3070 * or weapons first - only allowed to use one weapon/shield at a time.
3071 */
3072 if (op->type == WEAPON || op->type == SHIELD)
3073 {
3074 for (tmp = who->inv; tmp; tmp = tmp->below) 2865 for (object *tmp = who->inv; tmp; tmp = tmp->below)
3075 {
3076 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2866 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ())
3077 {
3078 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))) 2867 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)))
3079 { 2868 {
3080 if (aflags & AP_PRINT) 2869 if (aflags & AP_PRINT)
3081 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2870 who->failmsg (query_name (tmp));
3082 else 2871 else
3083 unapply_special (who, tmp, aflags); 2872 unapply_special (who, tmp, aflags);
3084 } 2873 }
3085 else 2874 else
3086 { 2875 {
3087 /* In this case, we want to try and remove a cursed item. 2876 /* In this case, we want to try and remove a cursed item.
3088 * While we know it won't work, we want unapply_special to 2877 * While we know it won't work, we want unapply_special to
3089 * at least generate the message. 2878 * at least generate the message.
3090 */ 2879 */
3091 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (tmp)); 2880 who->failmsg (format ("No matter how hard you try, you just can't remove the %s." CANNOT_REMOVE_CURSED, query_name (tmp)));
3092 return 1; 2881 return 1;
3093 }
3094
3095 } 2882 }
3096 }
3097 }
3098 2883
3099 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 2884 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3100 { 2885 {
3101 /* this used up a slot that we need to free */ 2886 /* this used up a slot that we need to free */
3102 if (op->body_info[i]) 2887 if (op->slot[i].info)
3103 { 2888 {
3104 last = who->inv; 2889 object *last = who->inv;
3105 2890
3106 /* We do a while loop - may need to remove several items in order 2891 /* We do a while loop - may need to remove several items in order
3107 * to free up enough slots. 2892 * to free up enough slots.
3108 */ 2893 */
3109 while ((who->body_used[i] + op->body_info[i]) < 0) 2894 while ((who->slot[i].used + op->slot[i].info) < 0)
3110 { 2895 {
3111 tmp = get_item_from_body_location (last, i); 2896 object *tmp = get_next_item_from_body_location (i, last);
2897
3112 if (!tmp) 2898 if (!tmp)
3113 { 2899 {
3114#if 0 2900#if 0
3115 /* Not a bug - we'll get this if the player has cursed items 2901 /* Not a bug - we'll get this if the player has cursed items
3116 * equipped. 2902 * equipped.
3117 */ 2903 */
3118 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name); 2904 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name);
3119#endif 2905#endif
3120 return 1; 2906 return 1;
3121 } 2907 }
2908
3122 /* If we are just printing, we don't care about cursed status */ 2909 /* If we are just printing, we don't care about cursed status */
3123 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)))) 2910 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))))
3124 { 2911 {
3125 if (aflags & AP_PRINT) 2912 if (aflags & AP_PRINT)
3126 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2913 who->failmsg (query_name (tmp));
3127 else 2914 else
3128 unapply_special (who, tmp, aflags); 2915 unapply_special (who, tmp, aflags);
3129 } 2916 }
3130 else 2917 else
3131 { 2918 {
3132 /* Cursed item that we can't unequip - tell the player. 2919 /* Cursed item that we can't unequip - tell the player.
3133 * Note this could be annoying if this is just one of a few, 2920 * Note this could be annoying if this is just one of a few,
3134 * so it may not be critical (eg, putting on a ring and you have 2921 * so it may not be critical (eg, putting on a ring and you have
3135 * one cursed ring.) 2922 * one cursed ring.)
3136 */ 2923 */
3137 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s just won't come off", query_name (tmp)); 2924 who->failmsg (format ("The %s just won't come off." CANNOT_REMOVE_CURSED, query_name (tmp)));
3138 } 2925 }
2926
3139 last = tmp->below; 2927 last = tmp->below;
3140 } 2928 }
3141 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the 2929 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the
3142 * return in the !tmp would have kicked in. 2930 * return in the !tmp would have kicked in.
3143 */ 2931 */
3144 } /* if op is using this body location */ 2932 } /* if op is using this body location */
3145 } /* for body lcoations */ 2933 } /* for body lcoations */
2934
3146 return 0; 2935 return 0;
3147} 2936}
3148 2937
3149/** 2938/**
3150 * Checks to see if 'who' can apply object 'op'. 2939 * Checks to see if 'who' can apply object 'op'.
3151 * Returns 0 if apply can be done without anything special. 2940 * Returns 0 if apply can be done without anything special.
3152 * Otherwise returns a bitmask - potentially several of these may be 2941 * Otherwise returns a bitmask - potentially several of these may be
3153 * set, but largely depends on circumstance - in the future, processing 2942 * set, but largely depends on circumstance - in the future, processing
3154 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER 2943 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER
3155 * is set, do we really are what the other flags may be?) 2944 * is set, do we really care what the other flags may be?)
3156 * 2945 *
3157 * See include/define.h for detailed description of the meaning of 2946 * See include/define.h for detailed description of the meaning of
3158 * these return values. 2947 * these return values.
3159 */ 2948 */
3160int 2949int
3161can_apply_object (object *who, object *op) 2950can_apply_object (object *who, object *op)
3162{ 2951{
3163 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op))) 2952 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op)))
3164 return RESULT_INT (0); 2953 return RESULT_INT (0);
3165 2954
3166 int i, retval = 0; 2955 int retval = 0;
3167 object *tmp = NULL, *ws = NULL; 2956 object *tmp = 0, *ws = 0;
3168 2957
3169 /* Players have 2 'arm's, so they could in theory equip 2 shields or 2958 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3170 * 2 weapons, but we don't want to let them do that. So if they are
3171 * trying to equip a weapon or shield, see if they already have one
3172 * in place and store that way.
3173 */
3174 if (op->type == WEAPON || op->type == SHIELD)
3175 { 2959 {
3176 for (tmp = who->inv; tmp && !ws; tmp = tmp->below) 2960 if (op->slot[i].info)
3177 { 2961 {
3178 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2962 /* Item uses more slots than we have */
2963 if (who->slot[i].info + op->slot [i].info < 0)
3179 { 2964 {
3180 retval = CAN_APPLY_UNAPPLY;
3181 ws = tmp;
3182 }
3183 }
3184 }
3185
3186
3187 for (i = 0; i < NUM_BODY_LOCATIONS; i++)
3188 {
3189 if (op->body_info[i])
3190 {
3191 /* Item uses more slots than we have */
3192 if (FABS (op->body_info[i]) > who->body_info[i])
3193 {
3194 /* Could return now for efficiently - rest of info below isn' 2965 /* Could return now for efficiency - rest of info below isn't
3195 * really needed. 2966 * really needed.
3196 */ 2967 */
3197 retval |= CAN_APPLY_NEVER; 2968 retval |= CAN_APPLY_NEVER;
3198 } 2969 }
3199 else if ((who->body_used[i] + op->body_info[i]) < 0) 2970 else if (who->slot[i].used + op->slot[i].info < 0)
3200 { 2971 {
3201 /* in this case, equipping this would use more free spots than 2972 /* in this case, equipping this would use more free spots than
3202 * we have. 2973 * we have.
3203 */ 2974 */
3204 object *tmp1;
3205
3206 2975
3207 /* if we have an applied weapon/shield, and unapply it would free 2976 /* if we have an applied weapon/shield, and unapply it would free
3208 * enough slots to equip the new item, then just set this can 2977 * enough slots to equip the new item, then just set "can
3209 * continue. We don't care about the logic below - if you have 2978 * apply unapply". We don't care about the logic below - if you have a
3210 * shield equipped and try to equip another shield, there is only 2979 * shield equipped and try to equip another shield, there is only
3211 * one choice. However, the check for the number of body locations 2980 * one choice. However, the check for the number of body locations
3212 * does take into the account cases where what is being applied 2981 * does take into the account cases where what is being applied
3213 * may be two handed for example. 2982 * may be two handed for example.
3214 */ 2983 */
3215 if (ws) 2984 if (ws)
3216 { 2985 if ((who->slot[i].used - ws->slot[i].info + op->slot[i].info) >= 0)
3217 if ((who->body_used[i] - ws->body_info[i] + op->body_info[i]) >= 0)
3218 { 2986 {
3219 retval |= CAN_APPLY_UNAPPLY; 2987 retval |= CAN_APPLY_UNAPPLY;
3220 continue; 2988 continue;
3221 } 2989 }
3222 }
3223 2990
3224 tmp1 = get_item_from_body_location (who->inv, i); 2991 object *tmp1 = get_next_item_from_body_location (i, who->inv);
3225 if (!tmp1) 2992 if (!tmp1)
3226 { 2993 {
3227#if 0 2994#if 0
3228 /* This is sort of an error, but happens a lot when old players 2995 /* This is sort of an error, but happens a lot when old players
3229 * join in with more stuff equipped than they are now allowed. 2996 * join in with more stuff equipped than they are now allowed.
… …
3237 /* need to unapply something. However, if this something 3004 /* need to unapply something. However, if this something
3238 * is different than we had found before, it means they need 3005 * is different than we had found before, it means they need
3239 * to apply multiple objects 3006 * to apply multiple objects
3240 */ 3007 */
3241 retval |= CAN_APPLY_UNAPPLY; 3008 retval |= CAN_APPLY_UNAPPLY;
3009
3242 if (!tmp) 3010 if (!tmp)
3243 tmp = tmp1; 3011 tmp = tmp1;
3244 else if (tmp != tmp1) 3012 else if (tmp != tmp1)
3245 {
3246 retval |= CAN_APPLY_UNAPPLY_MULT; 3013 retval |= CAN_APPLY_UNAPPLY_MULT;
3247 } 3014
3248 /* This object isn't using up all the slots, so there must 3015 /* This object isn't using up all the slots, so there must
3249 * be another. If so, and it the new item doesn't need all 3016 * be another. If so, and it the new item doesn't need all
3250 * the slots, the player then has a choice. 3017 * the slots, the player then has a choice.
3251 */ 3018 */
3252 if (((who->body_used[i] - tmp1->body_info[i]) != who->body_info[i]) && (FABS (op->body_info[i]) < who->body_info[i])) 3019 if ((who->slot[i].used - tmp1->slot[i].info != who->slot[i].info)
3020 && abs (op->slot[i].info) < who->slot[i].info)
3253 retval |= CAN_APPLY_UNAPPLY_CHOICE; 3021 retval |= CAN_APPLY_UNAPPLY_CHOICE;
3254 3022
3255 /* Does unequippint 'tmp1' free up enough slots for this to be 3023 /* Does unequippint 'tmp1' free up enough slots for this to be
3256 * equipped? If not, there must be something else to unapply. 3024 * equipped? If not, there must be something else to unapply.
3257 */ 3025 */
3258 if ((who->body_used[i] + op->body_info[i] - tmp1->body_info[i]) < 0) 3026 if (who->slot[i].used + op->slot[i].info < tmp1->slot[i].info)
3259 retval |= CAN_APPLY_UNAPPLY_MULT; 3027 retval |= CAN_APPLY_UNAPPLY_MULT;
3260
3261 } 3028 }
3262 } /* if not enough free slots */ 3029 } /* if not enough free slots */
3263 } /* if this object uses location i */ 3030 } /* if this object uses location i */
3264 } /* for i -> num_body_locations loop */ 3031 } /* for i -> num_body_locations loop */
3265 3032
… …
3270 * and weapons all use the same slot. Similar for horn/rod/wand - they 3037 * and weapons all use the same slot. Similar for horn/rod/wand - they
3271 * all use the same location. 3038 * all use the same location.
3272 */ 3039 */
3273 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON)) 3040 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON))
3274 retval |= CAN_APPLY_RESTRICTION; 3041 retval |= CAN_APPLY_RESTRICTION;
3042
3275 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD)) 3043 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD))
3276 retval |= CAN_APPLY_RESTRICTION; 3044 retval |= CAN_APPLY_RESTRICTION;
3277 3045
3278
3279 if (who->type != PLAYER) 3046 if (who->type != PLAYER)
3280 { 3047 {
3281 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE)) 3048 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE))
3282 retval |= CAN_APPLY_RESTRICTION; 3049 retval |= CAN_APPLY_RESTRICTION;
3050
3283 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3051 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3284 retval |= CAN_APPLY_RESTRICTION; 3052 retval |= CAN_APPLY_RESTRICTION;
3053
3285 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING)) 3054 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING))
3286 retval |= CAN_APPLY_RESTRICTION; 3055 retval |= CAN_APPLY_RESTRICTION;
3056
3287 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3057 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3288 retval |= CAN_APPLY_RESTRICTION; 3058 retval |= CAN_APPLY_RESTRICTION;
3289 } 3059 }
3060
3290 return retval; 3061 return retval;
3291} 3062}
3292
3293
3294 3063
3295/** 3064/**
3296 * who is the object using the object. It can be a monster. 3065 * who is the object using the object. It can be a monster.
3297 * op is the object they are using. op is an equipment type item, 3066 * op is the object they are using. op is an equipment type item,
3298 * eg, one which you put on and keep on for a while, and not something 3067 * eg, one which you put on and keep on for a while, and not something
… …
3307 * AP_UNAPPLY=always unapply). 3076 * AP_UNAPPLY=always unapply).
3308 * 3077 *
3309 * Optional flags: 3078 * Optional flags:
3310 * AP_NO_MERGE: don't merge an unapplied object with other objects 3079 * AP_NO_MERGE: don't merge an unapplied object with other objects
3311 * AP_IGNORE_CURSE: unapply cursed items 3080 * AP_IGNORE_CURSE: unapply cursed items
3081 * AP_NO_READY: do not ready skills when applying skill tools
3312 * 3082 *
3313 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE) 3083 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE)
3314 * 3084 *
3315 * apply_special() doesn't check for unpaid items. 3085 * apply_special() doesn't check for unpaid items.
3316 */ 3086 */
3087
3088#define LACK_ITEM_POWER \
3089 " H<You lack enough unused item power to use this weapon, see the skills command.>"
3090
3317int 3091int
3318apply_special (object *who, object *op, int aflags) 3092apply_special (object *who, object *op, int aflags)
3319{ 3093{
3320 int basic_flag = aflags & AP_BASIC_FLAGS; 3094 int basic_flag = aflags & AP_BASIC_FLAGS;
3321 object *tmp, *tmp2, *skop = NULL; 3095 object *tmp, *tmp2, *skop = NULL;
3322 int i;
3323 3096
3324 if (who == NULL) 3097 if (who == NULL)
3325 { 3098 {
3326 LOG (llevError, "apply_special() from object without environment.\n"); 3099 LOG (llevError, "apply_special() from object without environment.\n");
3327 return 1; 3100 return 1;
… …
3337 if (basic_flag == AP_APPLY) 3110 if (basic_flag == AP_APPLY)
3338 return 0; 3111 return 0;
3339 3112
3340 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))) 3113 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)))
3341 { 3114 {
3342 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (op)); 3115 who->failmsg (format ("No matter how hard you try, you just can't remove %s." CANNOT_REMOVE_CURSED, query_name (op)));
3343 return 1; 3116 return 1;
3344 } 3117 }
3118
3345 return unapply_special (who, op, aflags); 3119 return unapply_special (who, op, aflags);
3346 } 3120 }
3347
3348 if (basic_flag == AP_UNAPPLY) 3121 else if (basic_flag == AP_UNAPPLY)
3349 return 0; 3122 return 0;
3350 3123
3351 i = can_apply_object (who, op); 3124 // if the item is combat/ranged, wield the relevant slot first
3125 // to resolve conflicts.
3126 if (player *pl = who->contr)
3127 switch (op->slottype ())
3128 {
3129 case slot_combat: who->change_weapon (pl->combat_ob); break;
3130 case slot_ranged: who->change_weapon (pl->ranged_ob); break;
3131 }
3132
3133 splay (op);
3352 3134
3353 /* Can't just apply this object. Lets see what not and what to do */ 3135 /* Can't just apply this object. Lets see what not and what to do */
3354 if (i) 3136 if (int i = can_apply_object (who, op))
3355 { 3137 {
3356 if (i & CAN_APPLY_NEVER) 3138 if (i & CAN_APPLY_NEVER)
3357 { 3139 {
3358 new_draw_info_format (NDI_UNIQUE, 0, who, "You don't have the body to use a %s\n", query_name (op)); 3140 who->failmsg (format ("You don't have the body to use a %s. H<You can never apply this item.>", query_name (op)));
3359 return 1; 3141 return 1;
3360 } 3142 }
3361 else if (i & CAN_APPLY_RESTRICTION) 3143 else if (i & CAN_APPLY_RESTRICTION)
3362 { 3144 {
3363 new_draw_info_format (NDI_UNIQUE, 0, who, "You have a prohibition against using a %s\n", query_name (op)); 3145 who->failmsg (format (
3146 "You have a prohibition against using a %s. "
3147 "H<Your belief, profession or class prevents you from applying this item.>",
3148 query_name (op)
3149 ));
3364 return 1; 3150 return 1;
3365 } 3151 }
3152
3366 if (who->type != PLAYER) 3153 if (who->type != PLAYER)
3367 { 3154 {
3368 /* Some error, so don't try to equip something more */ 3155 /* Some error, so don't try to equip something more */
3369 if (unapply_for_ob (who, op, aflags)) 3156 if (unapply_for_ob (who, op, aflags))
3370 return 1; 3157 return 1;
3371 } 3158 }
3372 else 3159 else
3373 { 3160 {
3374 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice)) 3161 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice))
3375 { 3162 {
3376 new_draw_info (NDI_UNIQUE, 0, who, "You need to unapply some item(s):"); 3163 who->failmsg ("You need to unapply some of the following item(s) or change your applymode:");
3377 unapply_for_ob (who, op, AP_PRINT); 3164 unapply_for_ob (who, op, AP_PRINT);
3378 return 1; 3165 return 1;
3379 } 3166 }
3380 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE)) 3167 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE))
3381 {
3382 i = unapply_for_ob (who, op, aflags); 3168 if (unapply_for_ob (who, op, aflags))
3383 if (i)
3384 return 1; 3169 return 1;
3385 } 3170 }
3386 }
3387 } 3171 }
3172
3388 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL) 3173 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL)
3389 { 3174 {
3390 skop = find_skill_by_name (who, op->skill); 3175 skop = find_skill_by_name (who, op->skill);
3176
3391 if (!skop) 3177 if (!skop)
3392 { 3178 {
3393 new_draw_info_format (NDI_UNIQUE, 0, who, "You need the %s skill to use this item!", &op->skill); 3179 who->failmsg (format ("You need the %s skill to use this item!", &op->skill));
3394 return 1; 3180 return 1;
3395 } 3181 }
3396 else 3182 else
3397 {
3398 /* While experience will be credited properly, we want to change the 3183 /* While experience will be credited properly, we want to change the
3399 * skill so that the dam and wc get updated 3184 * skill so that the dam and wc get updated
3400 */ 3185 */
3401 change_skill (who, skop, 0); 3186 who->change_skill (skop);
3402 }
3403 }
3404
3405 if (who->type == PLAYER && op->item_power && (op->item_power + who->contr->item_power) > (settings.item_power_factor * who->level))
3406 { 3187 }
3407 new_draw_info (NDI_UNIQUE, 0, who, "Equipping that combined with other items would consume your soul!"); 3188
3189 if (who->type == PLAYER
3190 && op->item_power
3191 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level)
3192 {
3193 who->failmsg ("Equipping that combined with other items would consume your soul!" LACK_ITEM_POWER);
3408 return 1; 3194 return 1;
3409 } 3195 }
3410
3411 3196
3412 /* Ok. We are now at the state where we can apply the new object. 3197 /* Ok. We are now at the state where we can apply the new object.
3413 * Note that we don't have the checks for can_use_... 3198 * Note that we don't have the checks for can_use_...
3414 * below - that is already taken care of by can_apply_object. 3199 * below - that is already taken care of by can_apply_object.
3415 */ 3200 */
3416 3201 tmp = op->nrof > 1 ? op->split (op->nrof - 1) : 0;
3417
3418 if (op->nrof > 1)
3419 tmp = get_split_ob (op, op->nrof - 1);
3420 else
3421 tmp = NULL;
3422 3202
3423 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op))) 3203 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op)))
3424 return RESULT_INT (0); 3204 return RESULT_INT (0);
3425 3205
3426 switch (op->type) 3206 switch (op->type)
3427 { 3207 {
3428 case WEAPON: 3208 case WEAPON:
3429 if (!check_weapon_power (who, op->last_eat)) 3209 if (!check_weapon_power (who, op->last_eat))
3430 { 3210 {
3431 new_draw_info (NDI_UNIQUE, 0, who, "That weapon is too powerful for you to use."); 3211 op->failmsg ("This weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3432 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3212
3433 if (tmp != NULL) 3213 if (tmp)
3434 (void) insert_ob_in_ob (tmp, who); 3214 insert_ob_in_ob (tmp, who);
3215
3435 return 1; 3216 return 1;
3436 } 3217 }
3218
3219 //TODO: this obviously fails for players using a shorter prefix
3220 // i.e. "R" can use Ragnarok's sword.
3437 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3221 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3438 { 3222 {
3439 /* if the weapon does not have the name as the character, can't use it. */ 3223 /* if the weapon does not have the name as the character, can't use it. */
3440 /* (Ragnarok's sword attempted to be used by Foo: won't work) */ 3224 /* (Ragnarok's sword attempted to be used by Foo: won't work) */
3441 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3225 who->failmsg ("The weapon does not recognize you as its owner. H<Its name indicates that it belongs to somebody else.>");
3226
3442 if (tmp != NULL) 3227 if (tmp)
3443 (void) insert_ob_in_ob (tmp, who); 3228 insert_ob_in_ob (tmp, who);
3229
3444 return 1; 3230 return 1;
3445 } 3231 }
3232
3233 if (!skop)
3234 {
3235 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3236 return 1;
3237 }
3238
3446 SET_FLAG (op, FLAG_APPLIED); 3239 SET_FLAG (op, FLAG_APPLIED);
3447
3448 if (skop)
3449 change_skill (who, skop, 1); 3240 who->change_skill (skop);
3450 if (!QUERY_FLAG (who, FLAG_READY_WEAPON)) 3241
3242 if (who->contr)
3243 who->change_weapon (who->contr->combat_ob = op);
3244
3245 who->statusmsg (format ("You wield %s.", query_name (op)));
3246
3451 SET_FLAG (who, FLAG_READY_WEAPON); 3247 SET_FLAG (who, FLAG_READY_WEAPON);
3452
3453 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op));
3454
3455 (void) change_abil (who, op); 3248 change_abil (who, op);
3456 break; 3249 break;
3457 3250
3458 case ARMOUR: 3251 case ARMOUR:
3459 case HELMET: 3252 case HELMET:
3460 case SHIELD: 3253 case SHIELD:
… …
3464 case BRACERS: 3257 case BRACERS:
3465 case CLOAK: 3258 case CLOAK:
3466 case RING: 3259 case RING:
3467 case AMULET: 3260 case AMULET:
3468 SET_FLAG (op, FLAG_APPLIED); 3261 SET_FLAG (op, FLAG_APPLIED);
3469 new_draw_info_format (NDI_UNIQUE, 0, who, "You wear %s.", query_name (op)); 3262 who->statusmsg (format ("You wear %s.", query_name (op)));
3470 (void) change_abil (who, op); 3263 change_abil (who, op);
3471 break; 3264 break;
3265
3472 case LAMP: 3266 case LAMP:
3473 if (op->stats.food < 1) 3267 if (op->stats.food < 1)
3474 { 3268 {
3475 new_draw_info_format (NDI_UNIQUE, 0, who, "Your %s is out of" " fuel!", &op->name); 3269 who->failmsg (format (
3270 "Your %s is out of fuel! "
3271 "H<Lamps and similar items need fuel. They cannot be refilled.>",
3272 &op->name
3273 ));
3476 return 1; 3274 return 1;
3477 } 3275 }
3478 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn on your %s.", &op->name); 3276
3277 who->statusmsg (format ("You turn on your %s.", &op->name));
3278
3479 tmp2 = arch_to_object (op->other_arch); 3279 tmp2 = arch_to_object (op->other_arch);
3480 tmp2->stats.food = op->stats.food; 3280 tmp2->stats.food = op->stats.food;
3481 SET_FLAG (tmp2, FLAG_APPLIED); 3281 SET_FLAG (tmp2, FLAG_APPLIED);
3282
3482 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 3283 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
3483 SET_FLAG (tmp2, FLAG_INV_LOCKED); 3284 SET_FLAG (tmp2, FLAG_INV_LOCKED);
3484 insert_ob_in_ob (tmp2, who); 3285
3286 who->insert (tmp2);
3485 3287
3486 /* Remove the old lantern */ 3288 /* Remove the old lantern */
3487 if (who->type == PLAYER)
3488 esrv_del_item (who->contr, op->count);
3489
3490 op->destroy (); 3289 op->destroy ();
3491 3290
3492 /* insert the portion that was split off */ 3291 /* insert the portion that was split off */
3493 if (tmp != NULL) 3292 if (tmp)
3293 who->insert (tmp);
3294
3295 who->update_stats ();
3296
3297 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3298 if (who->type == PLAYER)
3299 {
3300 who->failmsg ("Oops, it feels deadly cold! H<Maybe it wasn't such a bright (hrhrhr) idea to apply this cursed or damned item.>");
3301 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
3302 }
3303
3304 return 0;
3305
3306 case SKILL_TOOL:
3307 // applying a skill tool also readies the skill
3308 SET_FLAG (op, FLAG_APPLIED);
3309
3310 if (!(aflags & AP_NO_READY))
3494 { 3311 {
3495 (void) insert_ob_in_ob (tmp, who); 3312 skop = find_skill_by_name (who, op->skill);
3496 if (who->type == PLAYER) 3313 if (!skop->flag [FLAG_APPLIED])
3497 esrv_send_item (who, tmp); 3314 apply_special (who, skop, AP_APPLY);
3498 } 3315 }
3499 fix_player (who); 3316 break;
3500 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3317
3318 case SKILL:
3319 if (player *pl = who->contr)
3501 { 3320 {
3502 if (who->type == PLAYER) 3321 if (IS_COMBAT_SKILL (op->subtype))
3503 { 3322 {
3504 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3323 if (skill_flags [op->subtype] & SF_NEED_WEAPON)
3505 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 3324 {
3325 for (object *item = who->inv; item; item = item->below)
3326 if (item->type == WEAPON && item->flag [FLAG_APPLIED])
3327 {
3328 if (item->skill == op->skill)
3329 {
3330 who->change_weapon (pl->combat_ob = item);
3331 goto found_weapon;
3332 }
3333 }
3334
3335 who->failmsg (format (
3336 "You need to apply a '%s' melee weapon before readying this skill. "
3337 "H<Some skills need an item, in this case a melee weapon, to function.>",
3338 &op->skill
3339 ));
3340 return 1;
3341
3342 found_weapon:;
3343 }
3344 else
3345 who->change_weapon (pl->combat_ob = op);
3506 } 3346 }
3507 } 3347 else if (IS_RANGED_SKILL (op->subtype))
3508 if (who->type == PLAYER)
3509 esrv_send_item (who, tmp2);
3510 return 0;
3511 break;
3512
3513 /* this part is needed for skill-tools */
3514 case SKILL:
3515 case SKILL_TOOL:
3516 if (who->chosen_skill)
3517 { 3348 {
3518 LOG (llevError, "BUG: apply_special(): can't apply two skills\n"); 3349 if (skill_flags [op->subtype] & SF_NEED_BOW)
3350 {
3351 for (object *item = who->inv; item; item = item->below)
3352 if (item->type == BOW && item->flag [FLAG_APPLIED])
3353 {
3354 //TODO: bows should/must all have skill missile weapon right now
3355 who->change_weapon (pl->ranged_ob = item);
3356 goto found_bow;
3357 }
3358
3359 who->failmsg (
3360 "You need to apply a missile weapon before readying this skill. "
3361 "H<Some skills need an item, in this case a missile weapon, to function.>"
3362 );
3519 return 1; 3363 return 1;
3364
3365 found_bow:;
3366 }
3367 else
3368 who->change_weapon (pl->ranged_ob = op);
3520 } 3369 }
3521 if (who->type == PLAYER) 3370
3522 {
3523 who->contr->shoottype = range_skill;
3524 who->contr->ranges[range_skill] = op;
3525 if (!op->invisible) 3371 if (!op->invisible)
3526 { 3372 {
3527 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3373 who->statusmsg (format (
3528 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill); 3374 "You ready %s."
3375 "You can now use the skill: %s.",
3376 query_name (op),
3377 &op->skill
3378 ));
3529 } 3379 }
3530 else 3380 else
3531 {
3532 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name); 3381 who->statusmsg (format ("Readied skill: %s.", op->skill ? &op->skill : &op->name));
3533 }
3534 } 3382 }
3383 else
3384 {
3535 SET_FLAG (op, FLAG_APPLIED); 3385 SET_FLAG (op, FLAG_APPLIED);
3536 (void) change_abil (who, op); 3386 change_abil (who, op);
3537 who->chosen_skill = op; 3387 who->chosen_skill = op;
3538 SET_FLAG (who, FLAG_READY_SKILL); 3388 SET_FLAG (who, FLAG_READY_SKILL);
3389 }
3390
3539 break; 3391 break;
3540 3392
3541 case BOW: 3393 case BOW:
3542 if (!check_weapon_power (who, op->last_eat)) 3394 if (!check_weapon_power (who, op->last_eat))
3543 { 3395 {
3544 new_draw_info (NDI_UNIQUE, 0, who, "That item is too powerful for you to use."); 3396 who->failmsg ("That weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3545 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3397
3546 if (tmp != NULL) 3398 if (tmp)
3547 (void) insert_ob_in_ob (tmp, who); 3399 insert_ob_in_ob (tmp, who);
3400
3548 return 1; 3401 return 1;
3549 } 3402 }
3403
3550 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3404 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3551 { 3405 {
3552 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3406 who->failmsg ("The weapon does not recognize you as its owner. "
3407 "H<Its name indicates that it belongs to somebody else.>");
3553 if (tmp != NULL) 3408 if (tmp)
3554 (void) insert_ob_in_ob (tmp, who); 3409 insert_ob_in_ob (tmp, who);
3410
3555 return 1; 3411 return 1;
3556 } 3412 }
3413
3557 /*FALLTHROUGH*/ case WAND: 3414 /*FALLTHROUGH*/
3415 case WAND:
3558 case ROD: 3416 case ROD:
3559 case HORN: 3417 case HORN:
3560 /* check for skill, alter player status */ 3418 /* check for skill, alter player status */
3419
3420 if (!skop)
3421 {
3422 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3423 return 1;
3424 }
3425
3561 SET_FLAG (op, FLAG_APPLIED); 3426 SET_FLAG (op, FLAG_APPLIED);
3562 if (skop)
3563 change_skill (who, skop, 0); 3427 who->change_skill (skop);
3564 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op));
3565 3428
3566 if (who->type == PLAYER) 3429 if (who->contr)
3567 { 3430 {
3431 who->contr->ranged_ob = op;
3432
3433 who->statusmsg (format ("You ready %s.", query_name (op)));
3434
3568 if (op->type == BOW) 3435 if (op->type == BOW)
3569 { 3436 {
3437 who->current_weapon = op;
3570 (void) change_abil (who, op); 3438 change_abil (who, op);
3571 new_draw_info_format (NDI_UNIQUE, 0, who,
3572 "You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)); 3439 who->statusmsg (format ("You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)));
3573 who->contr->shoottype = range_bow;
3574 }
3575 else
3576 {
3577 who->contr->shoottype = range_misc;
3578 } 3440 }
3579 } 3441 }
3580 else 3442 else
3581 { 3443 {
3582 if (op->type == BOW) 3444 if (op->type == BOW)
3583 SET_FLAG (who, FLAG_READY_BOW); 3445 SET_FLAG (who, FLAG_READY_BOW);
3584 else 3446 else
3585 SET_FLAG (who, FLAG_READY_RANGE); 3447 SET_FLAG (who, FLAG_READY_RANGE);
3586 } 3448 }
3449
3587 break; 3450 break;
3588 3451
3589 case BUILDER: 3452 case BUILDER:
3590 if (who->contr->ranges[range_builder]) 3453 if (who->type == PLAYER)
3454 {
3455 //TODO: wtf does this do? shouldn't this be managed automatically (slots?)
3456 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER)
3591 unapply_special (who, who->contr->ranges[range_builder], 0); 3457 unapply_special (who, who->contr->ranged_ob, 0);
3592 who->contr->shoottype = range_builder; 3458
3459 who->statusmsg (format ("You ready your %s.", query_name (op)));
3460
3593 who->contr->ranges[range_builder] = op; 3461 who->contr->ranged_ob = op;
3594 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op)); 3462 }
3595 break; 3463 break;
3596 3464
3597 default: 3465 default:
3598 new_draw_info_format (NDI_UNIQUE, 0, who, "You apply %s.", query_name (op)); 3466 who->statusmsg (format ("You apply %s.", query_name (op)));
3599 } /* end of switch op->type */ 3467 }
3600 3468
3601 SET_FLAG (op, FLAG_APPLIED); 3469 SET_FLAG (op, FLAG_APPLIED);
3602 3470
3603 if (tmp != NULL) 3471 if (tmp)
3604 tmp = insert_ob_in_ob (tmp, who); 3472 who->insert (tmp);
3605 3473
3606 fix_player (who); 3474 who->update_stats ();
3607 3475
3608 /* We exclude spell casting objects. The fire code will set the 3476 /* We exclude spell casting objects. The fire code will set the
3609 * been applied flag when they are used - until that point, 3477 * been applied flag when they are used - until that point,
3610 * you don't know anything about them. 3478 * you don't know anything about them.
3611 */ 3479 */
3612 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD) 3480 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD)
3613 SET_FLAG (op, FLAG_BEEN_APPLIED); 3481 SET_FLAG (op, FLAG_BEEN_APPLIED);
3614 3482
3615 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3483 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3616 {
3617 if (who->type == PLAYER) 3484 if (who->type == PLAYER)
3618 { 3485 {
3619 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3486 who->failmsg (
3487 "Oops, it feels deadly cold! "
3488 "H<Maybe it wasn't such a bright idea to apply this cursed or damned item.>"
3489 );
3620 SET_FLAG (op, FLAG_KNOWN_CURSED); 3490 SET_FLAG (op, FLAG_KNOWN_CURSED);
3621 } 3491 }
3622 } 3492
3623 if (who->type == PLAYER) 3493 if (object *pl = op->visible_to ())
3624 {
3625 /* if multiple objects were applied, update both slots */
3626 if (tmp)
3627 esrv_send_item (who, tmp);
3628 esrv_send_item (who, op); 3494 esrv_send_item (pl, op);
3629 } 3495
3630 return 0; 3496 return 0;
3631} 3497}
3632
3633 3498
3634int 3499int
3635monster_apply_special (object *who, object *op, int aflags) 3500monster_apply_special (object *who, object *op, int aflags)
3636{ 3501{
3637 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED)) 3502 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED))
3638 return 1; 3503 return 1;
3504
3639 return apply_special (who, op, aflags); 3505 return apply_special (who, op, aflags);
3640} 3506}
3641 3507
3642/** 3508/**
3643 * Map was just loaded, handle op's initialisation. 3509 * Map was just loaded, handle op's initialisation.
… …
3648auto_apply (object *op) 3514auto_apply (object *op)
3649{ 3515{
3650 object *tmp = NULL, *tmp2; 3516 object *tmp = NULL, *tmp2;
3651 int i; 3517 int i;
3652 3518
3519 CLEAR_FLAG (op, FLAG_AUTO_APPLY);
3520
3653 switch (op->type) 3521 switch (op->type)
3654 { 3522 {
3655 case SHOP_FLOOR: 3523 case SHOP_FLOOR:
3656 if (!HAS_RANDOM_ITEMS (op)) 3524 if (!op->has_random_items ())
3657 return 0; 3525 return 0;
3658 3526
3659 do 3527 do
3660 { 3528 {
3661 i = 10; /* let's give it 10 tries */ 3529 i = 10; /* let's give it 10 tries */
3662 while ((tmp = generate_treasure (op->randomitems, 3530 while ((tmp = generate_treasure (op->randomitems,
3663 op->stats.exp ? (int) op->stats.exp : MAX (op->map->difficulty, 5))) == NULL && --i); 3531 op->stats.exp
3532 ? (int) op->stats.exp
3533 : max (op->map->difficulty, 5)))
3534 == NULL && --i);
3535
3664 if (tmp == NULL) 3536 if (tmp == NULL)
3665 return 0; 3537 return 0;
3538
3666 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 3539 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
3667 { 3540 {
3668 tmp->destroy (); 3541 tmp->destroy ();
3669 tmp = NULL; 3542 tmp = NULL;
3670 } 3543 }
… …
3673 3546
3674 tmp->x = op->x; 3547 tmp->x = op->x;
3675 tmp->y = op->y; 3548 tmp->y = op->y;
3676 SET_FLAG (tmp, FLAG_UNPAID); 3549 SET_FLAG (tmp, FLAG_UNPAID);
3677 insert_ob_in_map (tmp, op->map, NULL, 0); 3550 insert_ob_in_map (tmp, op->map, NULL, 0);
3678 CLEAR_FLAG (op, FLAG_AUTO_APPLY);
3679 identify (tmp); 3551 identify (tmp);
3680 break; 3552 break;
3681 3553
3682 case TREASURE: 3554 case TREASURE:
3683 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 3555 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
3684 return 0; 3556 return 0;
3685 3557
3686 while ((op->stats.hp--) > 0) 3558 while (op->stats.hp-- > 0)
3687 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0, 3559 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0,
3688 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0); 3560 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0);
3689 3561
3690 /* If we generated an object and put it in this object inventory, 3562 /* If we generated an object and put it in this object inventory,
3691 * move it to the parent object as the current object is about 3563 * move it to the parent object as the current object is about
3692 * to disappear. An example of this item is the random_* stuff 3564 * to disappear. An example of this item is the random_* stuff
3693 * that is put inside other objects. 3565 * that is put inside other objects.
3694 */ 3566 */
3695 for (tmp = op->inv; tmp; tmp = tmp2)
3696 {
3697 tmp2 = tmp->below;
3698 tmp->remove ();
3699
3700 if (op->env) 3567 if (op->env)
3701 insert_ob_in_ob (tmp, op->env); 3568 while (op->inv)
3702 else 3569 op->env->insert (op->inv);
3703 tmp->destroy ();
3704 }
3705 3570
3706 op->destroy (); 3571 op->destroy ();
3707 break; 3572 break;
3708 } 3573 }
3709 return tmp ? 1 : 0;
3710}
3711 3574
3575 return !!tmp;
3576}
3577
3712/** 3578/**
3713 * fix_auto_apply goes through the entire map (only the first time 3579 * fix_auto_apply goes through the entire map every time a map
3714 * when an original map is loaded) and performs special actions for 3580 * is loaded or swapped in and performs special actions for
3715 * certain objects (most initialization of chests and creation of 3581 * certain objects (most initialization of chests and creation of
3716 * treasures and stuff). Calls auto_apply if appropriate. 3582 * treasures and stuff). Calls auto_apply if appropriate.
3717 */ 3583 */
3718void 3584void
3719fix_auto_apply (maptile *m) 3585maptile::fix_auto_apply ()
3720{ 3586{
3721 object *tmp, *above = NULL; 3587 if (!spaces)
3722 int x, y;
3723
3724 if (m == NULL)
3725 return; 3588 return;
3726 3589
3727 for (x = 0; x < MAP_WIDTH (m); x++) 3590 for (mapspace *ms = spaces + size (); ms-- > spaces; )
3728 for (y = 0; y < MAP_HEIGHT (m); y++) 3591 for (object *tmp = ms->bot; tmp; )
3729 for (tmp = get_map_ob (m, x, y); tmp != NULL; tmp = above)
3730 { 3592 {
3731 above = tmp->above; 3593 object *above = tmp->above;
3732 3594
3733 if (tmp->inv) 3595 if (tmp->inv)
3734 { 3596 {
3735 object *invtmp, *invnext; 3597 object *invtmp, *invnext;
3736 3598
3737 for (invtmp = tmp->inv; invtmp != NULL; invtmp = invnext) 3599 for (invtmp = tmp->inv; invtmp; invtmp = invnext)
3738 { 3600 {
3739 invnext = invtmp->below; 3601 invnext = invtmp->below;
3740 3602
3741 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY)) 3603 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY))
3742 auto_apply (invtmp); 3604 auto_apply (invtmp);
3743 else if (invtmp->type == TREASURE && HAS_RANDOM_ITEMS (invtmp)) 3605 else if (invtmp->type == TREASURE && invtmp->has_random_items ())
3744 { 3606 {
3745 while ((invtmp->stats.hp--) > 0) 3607 while (invtmp->stats.hp-- > 0)
3746 create_treasure (invtmp->randomitems, invtmp, 0, m->difficulty, 0);
3747
3748 invtmp->randomitems = NULL;
3749 }
3750 else if (invtmp && invtmp->arch
3751 && invtmp->type != TREASURE && invtmp->type != SPELL && invtmp->type != CLASS && HAS_RANDOM_ITEMS (invtmp))
3752 {
3753 create_treasure (invtmp->randomitems, invtmp, 0, m->difficulty, 0); 3608 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0);
3609
3610 invtmp->randomitems = NULL;
3611 }
3612 else if (invtmp && invtmp->arch
3613 && invtmp->type != TREASURE && invtmp->type != SPELL && invtmp->type != CLASS && invtmp->has_random_items ())
3614 {
3615 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0);
3754 /* Need to clear this so that we never try to create 3616 /* Need to clear this so that we never try to create
3755 * treasure again for this object 3617 * treasure again for this object
3756 */ 3618 */
3757 invtmp->randomitems = NULL; 3619 invtmp->randomitems = NULL;
3758 } 3620 }
3759 } 3621 }
3760 /* This is really temporary - the code at the bottom will 3622 /* This is really temporary - the code at the bottom will
3761 * also set randomitems to null. The problem is there are bunches 3623 * also set randomitems to null. The problem is there are bunches
3762 * of maps/players already out there with items that have spells 3624 * of maps/players already out there with items that have spells
3763 * which haven't had the randomitems set to null yet. 3625 * which haven't had the randomitems set to null yet.
3764 * MSW 2004-05-13 3626 * MSW 2004-05-13
3765 * 3627 *
3766 * And if it's a spellbook, it's better to set randomitems to NULL too, 3628 * And if it's a spellbook, it's better to set randomitems to NULL too,
3767 * else you get two spells in the book ^_- 3629 * else you get two spells in the book ^_-
3768 * Ryo 2004-08-16 3630 * Ryo 2004-08-16
3769 */ 3631 */
3770 if (tmp->type == WAND || tmp->type == ROD || tmp->type == SCROLL 3632 if (tmp->type == WAND || tmp->type == ROD || tmp->type == SCROLL
3771 || tmp->type == HORN || tmp->type == FIREWALL || tmp->type == POTION || tmp->type == ALTAR || tmp->type == SPELLBOOK) 3633 || tmp->type == HORN || tmp->type == FIREWALL || tmp->type == POTION || tmp->type == ALTAR || tmp->type == SPELLBOOK)
3772 tmp->randomitems = NULL;
3773
3774 }
3775
3776 if (QUERY_FLAG (tmp, FLAG_AUTO_APPLY))
3777 auto_apply (tmp);
3778 else if ((tmp->type == TREASURE || (tmp->type == CONTAINER)) && HAS_RANDOM_ITEMS (tmp))
3779 {
3780 while ((tmp->stats.hp--) > 0)
3781 create_treasure (tmp->randomitems, tmp, 0, m->difficulty, 0);
3782 tmp->randomitems = NULL; 3634 tmp->randomitems = NULL;
3635
3783 } 3636 }
3637
3638 if (QUERY_FLAG (tmp, FLAG_AUTO_APPLY))
3639 auto_apply (tmp);
3640 else if ((tmp->type == TREASURE || (tmp->type == CONTAINER)) && tmp->has_random_items ())
3641 {
3642 while ((tmp->stats.hp--) > 0)
3643 create_treasure (tmp->randomitems, tmp, 0, difficulty, 0);
3644 tmp->randomitems = NULL;
3645 }
3784 else if (tmp->type == TIMED_GATE) 3646 else if (tmp->type == TIMED_GATE)
3785 { 3647 {
3786 object *head = tmp->head != NULL ? tmp->head : tmp; 3648 object *head = tmp->head != NULL ? tmp->head : tmp;
3787 3649
3788 if (QUERY_FLAG (head, FLAG_IS_LINKED)) 3650 if (QUERY_FLAG (head, FLAG_IS_LINKED))
3789 {
3790 tmp->speed = 0; 3651 tmp->set_speed (0);
3791 update_ob_speed (tmp);
3792 }
3793 } 3652 }
3794 /* This function can be called everytime a map is loaded, even when 3653 /* This function can be called everytime a map is loaded, even when
3795 * swapping back in. As such, we don't want to create the treasure 3654 * swapping back in. As such, we don't want to create the treasure
3796 * over and ove again, so after we generate the treasure, blank out 3655 * over and ove again, so after we generate the treasure, blank out
3797 * randomitems so if it is swapped in again, it won't make anything. 3656 * randomitems so if it is swapped in again, it won't make anything.
3798 * This is a problem for the above objects, because they have counters 3657 * This is a problem for the above objects, because they have counters
3799 * which say how many times to make the treasure. 3658 * which say how many times to make the treasure.
3800 */ 3659 */
3801 else if (tmp && tmp->arch && tmp->type != PLAYER 3660 else if (tmp && tmp->arch && tmp->type != PLAYER
3802 && tmp->type != TREASURE && tmp->type != SPELL 3661 && tmp->type != TREASURE && tmp->type != SPELL
3803 && tmp->type != PLAYER_CHANGER && tmp->type != CLASS && HAS_RANDOM_ITEMS (tmp)) 3662 && tmp->type != PLAYER_CHANGER && tmp->type != CLASS && tmp->has_random_items ())
3804 { 3663 {
3805 create_treasure (tmp->randomitems, tmp, GT_APPLY, m->difficulty, 0); 3664 create_treasure (tmp->randomitems, tmp, GT_APPLY, difficulty, 0);
3806 tmp->randomitems = NULL; 3665 tmp->randomitems = NULL;
3807 } 3666 }
3667
3668 // close all containers
3669 else if (tmp->type == CONTAINER)
3670 tmp->flag [FLAG_APPLIED] = 0;
3671
3672 tmp = above;
3808 } 3673 }
3809 3674
3810 for (x = 0; x < MAP_WIDTH (m); x++) 3675 for (mapspace *ms = spaces + size (); ms-- > spaces; )
3811 for (y = 0; y < MAP_HEIGHT (m); y++) 3676 for (object *tmp = ms->bot; tmp; tmp = tmp->above)
3812 for (tmp = get_map_ob (m, x, y); tmp != NULL; tmp = tmp->above)
3813 if (tmp->above && (tmp->type == TRIGGER_BUTTON || tmp->type == TRIGGER_PEDESTAL)) 3677 if (tmp->above && (tmp->type == TRIGGER_BUTTON || tmp->type == TRIGGER_PEDESTAL))
3814 check_trigger (tmp, tmp->above); 3678 check_trigger (tmp, tmp->above);
3815} 3679}
3816 3680
3817/** 3681/**
3818 * Handles player eating food that temporarily changes status (resistances, stats). 3682 * Handles player eating food that temporarily changes status (resistances, stats).
3819 * This used to call cast_change_attr(), but 3683 * This used to call cast_change_attr(), but
3820 * that doesn't work with the new spell code. Since we know what 3684 * that doesn't work with the new spell code. Since we know what
3821 * the food changes, just grab a force and use that instead. 3685 * the food changes, just grab a force and use that instead.
3822 */ 3686 */
3823
3824void 3687void
3825eat_special_food (object *who, object *food) 3688eat_special_food (object *who, object *food)
3826{ 3689{
3827 object *force; 3690 object *force;
3828 int i, did_one = 0; 3691 int i, did_one = 0;
3829 sint8 k;
3830 3692
3831 force = get_archetype (FORCE_NAME); 3693 force = get_archetype (FORCE_NAME);
3832 3694
3833 for (i = 0; i < NUM_STATS; i++) 3695 for (i = 0; i < NUM_STATS; i++)
3834 { 3696 if (sint8 k = food->stats.stat (i))
3835 k = get_attr_value (&food->stats, i);
3836 if (k)
3837 { 3697 {
3838 set_attr_value (&force->stats, i, k); 3698 force->stats.stat (i) = k;
3839 did_one = 1; 3699 did_one = 1;
3840 } 3700 }
3841 }
3842 3701
3843 /* check if we can protect the eater */ 3702 /* check if we can protect the eater */
3844 for (i = 0; i < NROFATTACKS; i++) 3703 for (i = 0; i < NROFATTACKS; i++)
3845 { 3704 {
3846 if (food->resist[i] > 0) 3705 if (food->resist[i] > 0)
3847 { 3706 {
3848 force->resist[i] = food->resist[i] / 2; 3707 force->resist[i] = food->resist[i] / 2;
3849 did_one = 1; 3708 did_one = 1;
3850 } 3709 }
3851 } 3710 }
3711
3852 if (did_one) 3712 if (did_one)
3853 { 3713 {
3854 force->speed = 0.1; 3714 force->set_speed (0.1);
3855 update_ob_speed (force);
3856 /* bigger morsel of food = longer effect time */ 3715 /* bigger morsel of food = longer effect time */
3857 force->stats.food = food->stats.food / 5; 3716 force->duration = food->stats.food / 5;
3858 SET_FLAG (force, FLAG_IS_USED_UP);
3859 SET_FLAG (force, FLAG_APPLIED); 3717 SET_FLAG (force, FLAG_APPLIED);
3860 change_abil (who, force); 3718 change_abil (who, force);
3861 insert_ob_in_ob (force, who); 3719 insert_ob_in_ob (force, who);
3862 } 3720 }
3863 else 3721 else
… …
3866 /* check for hp, sp change */ 3724 /* check for hp, sp change */
3867 if (food->stats.hp != 0) 3725 if (food->stats.hp != 0)
3868 { 3726 {
3869 if (QUERY_FLAG (food, FLAG_CURSED)) 3727 if (QUERY_FLAG (food, FLAG_CURSED))
3870 { 3728 {
3871 strcpy (who->contr->killer, food->name); 3729 who->contr->killer = food;
3872 hit_player (who, food->stats.hp, food, AT_POISON, 1); 3730 hit_player (who, food->stats.hp, food, AT_POISON, 1);
3873 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3731 who->failmsg ("Eck!...that was poisonous!");
3874 } 3732 }
3875 else 3733 else
3876 { 3734 {
3877 if (food->stats.hp > 0) 3735 if (food->stats.hp > 0)
3878 new_draw_info (NDI_UNIQUE, 0, who, "You begin to feel better."); 3736 who->statusmsg ("You begin to feel better.");
3879 else 3737 else
3880 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3738 who->failmsg ("Eck!...that was poisonous!");
3739
3881 who->stats.hp += food->stats.hp; 3740 who->stats.hp += food->stats.hp;
3882 } 3741 }
3883 } 3742 }
3743
3884 if (food->stats.sp != 0) 3744 if (food->stats.sp != 0)
3885 { 3745 {
3886 if (QUERY_FLAG (food, FLAG_CURSED)) 3746 if (QUERY_FLAG (food, FLAG_CURSED))
3887 { 3747 {
3888 new_draw_info (NDI_UNIQUE, 0, who, "You are drained of mana!"); 3748 who->failmsg ("You are drained of mana!");
3889 who->stats.sp -= food->stats.sp; 3749 who->stats.sp -= food->stats.sp;
3890 if (who->stats.sp < 0) 3750 if (who->stats.sp < 0)
3891 who->stats.sp = 0; 3751 who->stats.sp = 0;
3892 } 3752 }
3893 else 3753 else
3894 { 3754 {
3895 new_draw_info (NDI_UNIQUE, 0, who, "You feel a rush of magical energy!"); 3755 who->statusmsg ("You feel a rush of magical energy!");
3896 who->stats.sp += food->stats.sp; 3756 who->stats.sp += food->stats.sp;
3897 /* place limit on max sp from food? */ 3757 /* place limit on max sp from food? */
3898 } 3758 }
3899 } 3759 }
3900 fix_player (who);
3901}
3902 3760
3761 who->update_stats ();
3762}
3903 3763
3904/** 3764/**
3905 * Designed primarily to light torches/lanterns/etc. 3765 * Designed primarily to light torches/lanterns/etc.
3906 * Also burns up burnable material too. First object in the inventory is 3766 * Also burns up burnable material too. First object in the inventory is
3907 * the selected object to "burn". -b.t. 3767 * the selected object to "burn". -b.t.
3908 */ 3768 */
3909
3910void 3769void
3911apply_lighter (object *who, object *lighter) 3770apply_lighter (object *who, object *lighter)
3912{ 3771{
3913 object *item; 3772 object *item;
3914 int is_player_env = 0; 3773 int is_player_env = 0;
3915 char item_name[MAX_BUF];
3916 3774
3917 item = find_marked_object (who); 3775 item = find_marked_object (who);
3918 if (item) 3776 if (item)
3919 { 3777 {
3920 if (lighter->last_eat && lighter->stats.food) 3778 if (lighter->last_eat && lighter->stats.food)
3921 { /* lighter gets used up */ 3779 { /* lighter gets used up */
3922 /* Split multiple lighters if they're being used up. Otherwise * 3780 object *oneLighter = lighter->split ();
3923 * one charge from each would be used up. --DAMN */
3924 if (lighter->nrof > 1)
3925 {
3926 object *oneLighter = object::create ();
3927
3928 lighter->copy_to (oneLighter);
3929 lighter->nrof -= 1;
3930 oneLighter->nrof = 1;
3931 oneLighter->stats.food--; 3781 oneLighter->stats.food--;
3932 esrv_send_item (who, lighter); 3782 who->insert (oneLighter);
3933 oneLighter = insert_ob_in_ob (oneLighter, who);
3934 esrv_send_item (who, oneLighter);
3935 }
3936 else
3937 lighter->stats.food--;
3938 } 3783 }
3939 else if (lighter->last_eat) 3784 else if (lighter->last_eat)
3785 {
3940 { /* no charges left in lighter */ 3786 /* no charges left in lighter */
3941 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with a used up %s.", &item->name, &lighter->name); 3787 who->failmsg (format ("You attempt to light the %s with a used up %s.", &item->name, &lighter->name));
3942 return; 3788 return;
3943 } 3789 }
3790
3944 /* Perhaps we should split what we are trying to light on fire? 3791 /* Perhaps we should split what we are trying to light on fire?
3945 * I can't see many times when you would want to light multiple 3792 * I can't see many times when you would want to light multiple
3946 * objects at once. 3793 * objects at once.
3947 */ 3794 */
3948 /* If the item is destroyed, we don't have a valid pointer to the 3795
3949 * name object, so make a copy so the message we print out makes
3950 * some sense.
3951 */
3952 strcpy (item_name, item->name);
3953 if (who == is_player_inv (item)) 3796 if (who == item->in_player ())
3954 is_player_env = 1; 3797 is_player_env = 1;
3955 3798
3956 save_throw_object (item, AT_FIRE, who); 3799 save_throw_object (item, AT_FIRE, who);
3957 /* Change to check count and not freed, since the object pointer 3800
3958 * may have gotten recycled
3959 */
3960 if (item->destroyed ()) 3801 if (item->destroyed ())
3961 { 3802 {
3962 new_draw_info_format (NDI_UNIQUE, 0, who, "You light the %s with the %s.", &item_name, &lighter->name); 3803 who->statusmsg (format ("You light the %s with the %s.", &item->name, &lighter->name));
3963 /* Need to update the player so that the players glow radius 3804 /* Need to update the player so that the players glow radius
3964 * gets changed. 3805 * gets changed.
3965 */ 3806 */
3966 if (is_player_env) 3807 if (is_player_env)
3967 fix_player (who); 3808 who->update_stats ();
3968 } 3809 }
3969 else 3810 else
3970 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with the %s and fail.", &item->name, &lighter->name); 3811 who->failmsg (format ("You attempt to light the %s with the %s and fail.", &item->name, &lighter->name));
3971 } 3812 }
3972 else /* nothing to light */ 3813 else
3973 new_draw_info (NDI_UNIQUE, 0, who, "You need to mark a lightable object."); 3814 who->failmsg ("You need to mark a lightable object.");
3974
3975} 3815}
3976 3816
3977/** 3817/**
3978 * op made some mistake with a scroll, this takes care of punishment. 3818 * op made some mistake with a scroll, this takes care of punishment.
3979 * scroll_failure()- hacked directly from spell_failure 3819 * scroll_failure()- hacked directly from spell_failure
… …
3986 3826
3987 if (failure <= -1 && failure > -15) 3827 if (failure <= -1 && failure > -15)
3988 { /* wonder */ 3828 { /* wonder */
3989 object *tmp; 3829 object *tmp;
3990 3830
3991 new_draw_info (NDI_UNIQUE, 0, op, "Your spell warps!."); 3831 op->failmsg ("Your spell warps!");
3992 tmp = get_archetype (SPELL_WONDER); 3832 tmp = get_archetype (SPELL_WONDER);
3993 cast_wonder (op, op, 0, tmp); 3833 cast_wonder (op, op, 0, tmp);
3994 tmp->destroy (); 3834 tmp->destroy ();
3995 } 3835 }
3996 else if (failure <= -15 && failure > -35) 3836 else if (failure <= -15 && failure > -35)
3997 { /* drain mana */ 3837 { /* drain mana */
3998 new_draw_info (NDI_UNIQUE, 0, op, "Your mana is drained!."); 3838 op->failmsg ("Your mana is drained!");
3999 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW); 3839 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW);
4000 if (op->stats.sp < 0) 3840 if (op->stats.sp < 0)
4001 op->stats.sp = 0; 3841 op->stats.sp = 0;
4002 } 3842 }
4003 else if (settings.spell_failure_effects == TRUE) 3843 else if (settings.spell_failure_effects == TRUE)
4004 { 3844 {
4005 if (failure <= -35 && failure > -60) 3845 if (failure <= -35 && failure > -60)
4006 { /* confusion */ 3846 { /* confusion */
4007 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3847 op->failmsg ("The magic recoils on you!");
4008 confuse_player (op, op, power); 3848 confuse_player (op, op, power);
4009 } 3849 }
4010 else if (failure <= -60 && failure > -70) 3850 else if (failure <= -60 && failure > -70)
4011 { /* paralysis */ 3851 { /* paralysis */
4012 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils and paralyzes " "you!"); 3852 op->failmsg ("The magic recoils and paralyzes you!");
4013 paralyze_player (op, op, power); 3853 paralyze_player (op, op, power);
4014 } 3854 }
4015 else if (failure <= -70 && failure > -80) 3855 else if (failure <= -70 && failure > -80)
4016 { /* blind */ 3856 { /* blind */
4017 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3857 op->failmsg ("The magic recoils on you!");
4018 blind_player (op, op, power); 3858 blind_player (op, op, power);
4019 } 3859 }
4020 else if (failure <= -80) 3860 else if (failure <= -80)
4021 { /* blast the immediate area */ 3861 { /* blast the immediate area */
4022 object *tmp;
4023
4024 tmp = get_archetype (LOOSE_MANA); 3862 object *tmp = get_archetype (LOOSE_MANA);
4025 cast_magic_storm (op, tmp, power); 3863 cast_magic_storm (op, tmp, power);
4026 new_draw_info (NDI_UNIQUE, 0, op, "You unlease uncontrolled mana!"); 3864 op->failmsg ("You unleash uncontrolled mana!");
4027 tmp->destroy (); 3865 tmp->destroy ();
4028 } 3866 }
4029 } 3867 }
4030} 3868}
4031 3869
… …
4051 */ 3889 */
4052 int i, j; 3890 int i, j;
4053 3891
4054 for (i = 0; i < NUM_STATS; i++) 3892 for (i = 0; i < NUM_STATS; i++)
4055 { 3893 {
4056 sint8 stat = get_attr_value (stats, i); 3894 int race_bonus = pl->arch->stats.stat (i);
4057 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i); 3895 sint8 stat = stats->stat (i) + ns->stat (i);
4058 3896
4059 stat += get_attr_value (ns, i);
4060 if (stat > 20 + race_bonus) 3897 if (stat > 20 + race_bonus)
4061 { 3898 {
4062 excess_stat++; 3899 excess_stat++;
4063 stat = 20 + race_bonus; 3900 stat = 20 + race_bonus;
4064 } 3901 }
4065 set_attr_value (stats, i, stat); 3902
3903 stats->stat (i) = stat;
4066 } 3904 }
4067 3905
4068 for (j = 0; excess_stat > 0 && j < 100; j++) 3906 for (j = 0; excess_stat > 0 && j < 100; j++)
4069 { /* try 100 times to assign excess stats */ 3907 { /* try 100 times to assign excess stats */
4070 int i = rndm (0, 6); 3908 int i = rndm (0, 6);
4071 int stat = get_attr_value (stats, i);
4072 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i);
4073 3909
4074 if (i == CHA) 3910 if (i == CHA)
4075 continue; /* exclude cha from this */ 3911 continue; /* exclude cha from this */
3912
3913 int stat = stats->stat (i);
3914 int race_bonus = pl->arch->stats.stat (i);
4076 if (stat < 20 + race_bonus) 3915 if (stat < 20 + race_bonus)
4077 { 3916 {
4078 change_attr_value (stats, i, 1); 3917 change_attr_value (stats, i, 1);
4079 excess_stat--; 3918 excess_stat--;
4080 } 3919 }
… …
4084 * the player ref: player.c 3923 * the player ref: player.c
4085 */ 3924 */
4086 if (change->randomitems != NULL) 3925 if (change->randomitems != NULL)
4087 give_initial_items (pl, change->randomitems); 3926 give_initial_items (pl, change->randomitems);
4088 3927
4089
4090 /* set up the face, for some races. */ 3928 /* set up the face, for some races. */
4091 3929
4092 /* first, look for the force object banning 3930 /* first, look for the force object banning
4093 * changing the face. Certain races never change face with class. 3931 * changing the face. Certain races never change face with class.
4094 */ 3932 */
… …
4096 if (!strcmp (walk->name, "NOCLASSFACECHANGE")) 3934 if (!strcmp (walk->name, "NOCLASSFACECHANGE"))
4097 flag_change_face = 0; 3935 flag_change_face = 0;
4098 3936
4099 if (flag_change_face) 3937 if (flag_change_face)
4100 { 3938 {
4101 pl->animation_id = GET_ANIM_ID (change);
4102 pl->face = change->face; 3939 pl->face = change->face;
4103 3940 pl->animation_id = change->animation_id;
4104 if (QUERY_FLAG (change, FLAG_ANIMATE)) 3941 pl->flag [FLAG_ANIMATE] = change->flag [FLAG_ANIMATE];
4105 SET_FLAG (pl, FLAG_ANIMATE);
4106 else
4107 CLEAR_FLAG (pl, FLAG_ANIMATE);
4108 } 3942 }
4109 3943
4110 /* check the special case of can't use weapons */ 3944 /* check the special case of can't use weapons */
4111 /*if(QUERY_FLAG(change,FLAG_USE_WEAPON)) CLEAR_FLAG(pl,FLAG_USE_WEAPON); */ 3945 /*if(QUERY_FLAG(change,FLAG_USE_WEAPON)) CLEAR_FLAG(pl,FLAG_USE_WEAPON); */
4112 if (!strcmp (change->name, "monk")) 3946 if (!strcmp (change->name, "monk"))
… …
4138 char got[MAX_BUF]; 3972 char got[MAX_BUF];
4139 int len; 3973 int len;
4140 3974
4141 if (!pl || !transformer) 3975 if (!pl || !transformer)
4142 return; 3976 return;
3977
4143 marked = find_marked_object (pl); 3978 marked = find_marked_object (pl);
3979
4144 if (!marked) 3980 if (!marked)
4145 { 3981 {
4146 new_draw_info_format (NDI_UNIQUE, 0, pl, "Use the %s with what item?", query_name (transformer)); 3982 pl->failmsg (format ("Use the %s with what item?", query_name (transformer)));
4147 return; 3983 return;
4148 } 3984 }
3985
4149 if (!marked->slaying) 3986 if (!marked->slaying)
4150 { 3987 {
4151 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3988 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4152 return; 3989 return;
4153 } 3990 }
3991
4154 /* check whether they are compatible or not */ 3992 /* check whether they are compatible or not */
4155 find = strstr (marked->slaying, transformer->arch->name); 3993 find = strstr (marked->slaying, transformer->arch->archname);
4156 if (!find || (*(find + strlen (transformer->arch->name)) != ':')) 3994 if (!find || (*(find + strlen (transformer->arch->archname)) != ':'))
4157 { 3995 {
4158 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3996 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4159 return; 3997 return;
4160 } 3998 }
3999
4161 find += strlen (transformer->arch->name) + 1; 4000 find += strlen (transformer->arch->archname) + 1;
4162 /* Item can be used, now find how many and what it yields */ 4001 /* Item can be used, now find how many and what it yields */
4163 if (isdigit (*(find))) 4002 if (isdigit (*(find)))
4164 { 4003 {
4165 yield = atoi (find); 4004 yield = atoi (find);
4166 if (yield < 1) 4005 if (yield < 1)
… …
4172 else 4011 else
4173 yield = 1; 4012 yield = 1;
4174 4013
4175 while (isdigit (*find)) 4014 while (isdigit (*find))
4176 find++; 4015 find++;
4016
4177 while (*find == ' ') 4017 while (*find == ' ')
4178 find++; 4018 find++;
4019
4179 memset (got, 0, MAX_BUF); 4020 memset (got, 0, MAX_BUF);
4021
4180 if ((separator = strchr (find, ';')) != NULL) 4022 if ((separator = strchr (find, ';')) != NULL)
4181 {
4182 len = separator - find; 4023 len = separator - find;
4183 }
4184 else 4024 else
4185 {
4186 len = strlen (find); 4025 len = strlen (find);
4187 } 4026
4188 if (len > MAX_BUF - 1) 4027 if (len > MAX_BUF - 1)
4189 len = MAX_BUF - 1; 4028 len = MAX_BUF - 1;
4029
4190 strcpy (got, find); 4030 strcpy (got, find);
4191 got[len] = '\0'; 4031 got[len] = '\0';
4192 4032
4193 /* Now create new item, remove used ones when required. */ 4033 /* Now create new item, remove used ones when required. */
4194 new_item = get_archetype (got); 4034 new_item = get_archetype (got);
4195 if (!new_item) 4035 if (!new_item)
4196 { 4036 {
4197 new_draw_info_format (NDI_UNIQUE, 0, pl, "This %s is strange, better to not use it.", query_base_name (marked, 0)); 4037 pl->failmsg (format ("This %s is strange, better to not use it.", query_base_name (marked, 0)));
4198 return; 4038 return;
4199 } 4039 }
4200 4040
4201 new_item->nrof = yield; 4041 new_item->nrof = yield;
4042
4202 new_draw_info_format (NDI_UNIQUE, 0, pl, "You %s the %s.", &transformer->slaying, query_base_name (marked, 0)); 4043 pl->statusmsg (format ("You %s the %s.", &transformer->slaying, query_base_name (marked, 0)));
4203 insert_ob_in_ob (new_item, pl); 4044
4204 esrv_send_inventory (pl, pl); 4045 pl->insert (new_item);
4205 /* Eat up one item */ 4046 /* Eat up one item */
4206 decrease_ob_nr (marked, 1); 4047 marked->decrease ();
4048
4207 /* Eat one transformer if needed */ 4049 /* Eat one transformer if needed */
4208 if (transformer->stats.food) 4050 if (transformer->stats.food)
4209 if (--transformer->stats.food == 0) 4051 if (--transformer->stats.food == 0)
4210 decrease_ob_nr (transformer, 1); 4052 transformer->decrease ();
4211} 4053}
4054

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines