ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/apply.C
(Generate patch)

Comparing deliantra/server/server/apply.C (file contents):
Revision 1.51 by root, Fri Dec 22 16:34:00 2006 UTC vs.
Revision 1.135 by root, Sat Oct 20 05:10:29 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Crossfire TRT is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20
21 The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23
24#include <cmath>
23 25
24#include <global.h> 26#include <global.h>
25#include <living.h> 27#include <living.h>
26#include <spells.h> 28#include <spells.h>
27#include <skills.h> 29#include <skills.h>
… …
29 31
30#include <sproto.h> 32#include <sproto.h>
31 33
32/* Want this regardless of rplay. */ 34/* Want this regardless of rplay. */
33#include <sounds.h> 35#include <sounds.h>
34
35/* need math lib for double-precision and pow() in dragon_eat_flesh() */
36#include <math.h>
37 36
38/** 37/**
39 * Check if op should abort moving victim because of it's race or slaying. 38 * Check if op should abort moving victim because of it's race or slaying.
40 * Returns 1 if it should abort, returns 0 if it should continue. 39 * Returns 1 if it should abort, returns 0 if it should continue.
41 */ 40 */
… …
64 { 63 {
65 arch_flag = 1; 64 arch_flag = 1;
66 name_flag = 1; 65 name_flag = 1;
67 race_flag = 1; 66 race_flag = 1;
68 } 67 }
68
69 /* If the director has race set, only affect objects with a arch, 69 /* If the director has race set, only affect objects with a arch,
70 * name or race that matches. 70 * name or race that matches.
71 */ 71 */
72 if ((op->race) && 72 if ((op->race) &&
73 ((!(victim->arch && arch_flag && victim->arch->name) || strcmp (op->race, victim->arch->name))) && 73 ((!(victim->arch && arch_flag && victim->arch->archname) || op->race != victim->arch->archname)) &&
74 ((!(victim->name && name_flag) || strcmp (op->race, victim->name))) && 74 ((!(victim->name && name_flag) || op->race != victim->name)) &&
75 ((!(victim->race && race_flag) || strcmp (op->race, victim->race)))) 75 ((!(victim->race && race_flag) || op->race != victim->race)))
76 {
77 return 1; 76 return 1;
78 } 77
79 /* If the director has slaying set, only affect objects where none 78 /* If the director has slaying set, only affect objects where none
80 * of arch, name, or race match. 79 * of arch, name, or race match.
81 */ 80 */
82 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->name && !strcmp (op->slaying, victim->arch->name))) || 81 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->archname && op->slaying == victim->arch->archname))) ||
83 ((victim->name && name_flag && !strcmp (op->slaying, victim->name))) || 82 ((victim->name && name_flag && op->slaying == victim->name)) ||
84 ((victim->race && race_flag && !strcmp (op->slaying, victim->race))))) 83 ((victim->race && race_flag && op->slaying == victim->race)))
85 {
86 return 1; 84 return 1;
87 } 85
88 return 0; 86 return 0;
89} 87}
90 88
91/** 89/**
92 * This handles a player dropping money on an altar to identify stuff. 90 * This handles a player dropping money on an altar to identify stuff.
… …
94 * Return value: 1 if money was destroyed, 0 if not. 92 * Return value: 1 if money was destroyed, 0 if not.
95 */ 93 */
96static int 94static int
97apply_id_altar (object *money, object *altar, object *pl) 95apply_id_altar (object *money, object *altar, object *pl)
98{ 96{
99 object *id, *marked; 97 dynbuf_text buf;
100 int success = 0;
101 98
102 if (pl == NULL || pl->type != PLAYER) 99 if (!pl || pl->type != PLAYER)
103 return 0; 100 return 0;
104 101
105 /* Check for MONEY type is a special hack - it prevents 'nothing needs 102 /* Check for MONEY type is a special hack - it prevents 'nothing needs
106 * identifying' from being printed out more than it needs to be. 103 * identifying' from being printed out more than it needs to be.
107 */ 104 */
108 if (!check_altar_sacrifice (altar, money) || money->type != MONEY) 105 if (!check_altar_sacrifice (altar, money) || money->type != MONEY)
109 return 0; 106 return 0;
110 107
111 marked = find_marked_object (pl);
112 /* if the player has a marked item, identify that if it needs to be 108 /* if the player has a marked item, identify that if it needs to be
113 * identified. IF it doesn't, then go through the player inventory. 109 * identified. If it doesn't, then go through the player inventory.
114 */ 110 */
111 if (object *marked = find_marked_object (pl))
115 if (marked && !QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked)) 112 if (!QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked))
116 { 113 {
117 if (operate_altar (altar, &money)) 114 if (operate_altar (altar, &money))
118 { 115 {
119 identify (marked); 116 identify (marked);
120 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (marked, pl)); 117
118 buf.printf ("You have %s.\n\n", long_desc (marked, pl));
121 if (marked->msg) 119 if (marked->msg)
122 { 120 buf << "The item has a story:\n\n" << marked->msg << "\n\n";
123 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 121
124 new_draw_info (NDI_UNIQUE, 0, pl, marked->msg); 122 return !money;
125 } 123 }
126 return money == NULL;
127 } 124 }
128 }
129 125
130 for (id = pl->inv; id; id = id->below) 126 for (object *id = pl->inv; id; id = id->below)
131 { 127 {
132 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id)) 128 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id))
133 { 129 {
134 if (operate_altar (altar, &money)) 130 if (operate_altar (altar, &money))
135 { 131 {
136 identify (id); 132 identify (id);
137 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (id, pl)); 133
134 buf.printf ("You have %s.\n\n", long_desc (id, pl));
138 if (id->msg) 135 if (id->msg)
139 { 136 buf << "The item has a story:\n\n" << id->msg << "\n\n";
140 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 137
141 new_draw_info (NDI_UNIQUE, 0, pl, id->msg);
142 }
143 success = 1;
144 /* If no more money, might as well quit now */ 138 /* If no more money, might as well quit now */
145 if (money == NULL || !check_altar_sacrifice (altar, money)) 139 if (!money || !check_altar_sacrifice (altar, money))
146 break; 140 break;
147 } 141 }
148 else 142 else
149 { 143 {
150 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n"); 144 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n");
151 break; 145 break;
152 } 146 }
153 } 147 }
154 } 148 }
155 if (!success) 149
156 new_draw_info (NDI_UNIQUE, 0, pl, "You have nothing that needs identifying"); 150 if (buf.empty ())
151 pl->failmsg ("You have nothing that needs identifying");
152 else
153 pl->contr->infobox (MSG_CHANNEL ("identify"), buf);
154
157 return money == NULL; 155 return !money;
158} 156}
159 157
160/** 158/**
161 * This checks whether the object has a "on_use_yield" field, and if so generated and drops 159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops
162 * matching item. 160 * matching item.
163 **/ 161 **/
164static void 162void
165handle_apply_yield (object *tmp) 163handle_apply_yield (object *tmp)
166{ 164{
167 const char *yield; 165 const char *yield;
168 166
169 yield = get_ob_key_value (tmp, "on_use_yield"); 167 yield = get_ob_key_value (tmp, "on_use_yield");
… …
197 195
198 floor = GET_MAP_OB (op->map, op->x, op->y); 196 floor = GET_MAP_OB (op->map, op->x, op->y);
199 197
200 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE) 198 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE)
201 { 199 {
202 if (op->type == PLAYER)
203 new_draw_info (NDI_UNIQUE, 0, op, "Gods prevent you from using this here, it's sacred ground!"); 200 op->failmsg ("Gods prevent you from using this here, it's sacred ground!");
201
204 CLEAR_FLAG (tmp, FLAG_APPLIED); 202 CLEAR_FLAG (tmp, FLAG_APPLIED);
205 return 0; 203 return 0;
206 } 204 }
207 205
208 if (op->type == PLAYER) 206 if (op->type == PLAYER)
… …
233 depl = present_arch_in_ob (at, op); 231 depl = present_arch_in_ob (at, op);
234 232
235 if (depl) 233 if (depl)
236 { 234 {
237 for (i = 0; i < NUM_STATS; i++) 235 for (i = 0; i < NUM_STATS; i++)
238 if (get_attr_value (&depl->stats, i)) 236 if (depl->stats.stat (i))
239 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]); 237 op->statusmsg (restore_msg[i]);
240 238
241 depl->destroy (); 239 depl->destroy ();
242 op->update_stats (); 240 op->update_stats ();
243 } 241 }
244 else 242 else
245 new_draw_info (NDI_UNIQUE, 0, op, "You potion had no effect."); 243 op->statusmsg ("Your potion had no effect.");
246 244
247 decrease_ob (tmp); 245 decrease_ob (tmp);
248 return 1; 246 return 1;
249 } 247 }
250 248
251 /* improvement potion - only for players */ 249 /* improvement potion - only for players */
252 if (op->type == PLAYER && tmp->attacktype & AT_GODPOWER) 250 if (op->type == PLAYER && (tmp->attacktype & AT_GODPOWER))
253 { 251 {
254 for (i = 1; i < MIN (11, op->level); i++) 252 for (i = 1; i < MIN (11, op->level); i++)
255 { 253 {
256 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 254 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
257 { 255 {
258 if (op->contr->levhp[i] != 1) 256 if (op->contr->levhp[i] != 1)
259 { 257 {
260 op->contr->levhp[i] = 1; 258 op->contr->levhp[i] = 1;
261 break; 259 break;
262 } 260 }
261
263 if (op->contr->levsp[i] != 1) 262 if (op->contr->levsp[i] != 1)
264 { 263 {
265 op->contr->levsp[i] = 1; 264 op->contr->levsp[i] = 1;
266 break; 265 break;
267 } 266 }
267
268 if (op->contr->levgrace[i] != 1) 268 if (op->contr->levgrace[i] != 1)
269 { 269 {
270 op->contr->levgrace[i] = 1; 270 op->contr->levgrace[i] = 1;
271 break; 271 break;
272 } 272 }
… …
276 if (op->contr->levhp[i] < 9) 276 if (op->contr->levhp[i] < 9)
277 { 277 {
278 op->contr->levhp[i] = 9; 278 op->contr->levhp[i] = 9;
279 break; 279 break;
280 } 280 }
281
281 if (op->contr->levsp[i] < 6) 282 if (op->contr->levsp[i] < 6)
282 { 283 {
283 op->contr->levsp[i] = 6; 284 op->contr->levsp[i] = 6;
284 break; 285 break;
285 } 286 }
287
286 if (op->contr->levgrace[i] < 3) 288 if (op->contr->levgrace[i] < 3)
287 { 289 {
288 op->contr->levgrace[i] = 3; 290 op->contr->levgrace[i] = 3;
289 break; 291 break;
290 } 292 }
… …
298 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)) 300 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))
299 { 301 {
300 if (got_one) 302 if (got_one)
301 { 303 {
302 op->update_stats (); 304 op->update_stats ();
303 new_draw_info (NDI_UNIQUE, 0, op, "The Gods smile upon you and remake you"); 305 op->statusmsg ("The Gods smile upon you and remake you "
304 new_draw_info (NDI_UNIQUE, 0, op, "a little more in their image."); 306 "a little more in their image. "
305 new_draw_info (NDI_UNIQUE, 0, op, "You feel a little more perfect."); 307 "You feel a little more perfect.", NDI_GREEN);
306 } 308 }
307 else 309 else
308 new_draw_info (NDI_UNIQUE, 0, op, "The potion had no effect - you are already perfect"); 310 op->statusmsg ("The potion had no effect - you are already perfect.");
309 } 311 }
310 else 312 else
311 { /* cursed potion */ 313 { /* cursed potion */
312 if (got_one) 314 if (got_one)
313 { 315 {
314 op->update_stats (); 316 op->update_stats ();
315 new_draw_info (NDI_UNIQUE, 0, op, "The Gods are angry and punish you."); 317 op->failmsg ("The Gods are angry and punish you.");
316 } 318 }
317 else 319 else
318 new_draw_info (NDI_UNIQUE, 0, op, "You are fortunate that you are so pathetic."); 320 op->statusmsg ("You are fortunate that you are so pathetic.", NDI_DK_ORANGE);
319 } 321 }
320 322
321 decrease_ob (tmp); 323 decrease_ob (tmp);
322 return 1; 324 return 1;
323 } 325 }
… …
332 { 334 {
333 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 335 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
334 { 336 {
335 object *fball; 337 object *fball;
336 338
337 new_draw_info (NDI_UNIQUE, 0, op, "Yech! Your lungs are on fire!"); 339 op->failmsg ("Yech! Your lungs are on fire!");
340
338 /* Explodes a fireball centered at player */ 341 /* Explodes a fireball centered at player */
339 fball = get_archetype (EXPLODING_FIREBALL); 342 fball = get_archetype (EXPLODING_FIREBALL);
340 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1; 343 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1;
341 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2; 344 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2;
342 fball->x = op->x; 345 fball->x = op->x;
… …
345 } 348 }
346 else 349 else
347 cast_spell (op, tmp, op->facing, tmp->inv, NULL); 350 cast_spell (op, tmp, op->facing, tmp->inv, NULL);
348 351
349 decrease_ob (tmp); 352 decrease_ob (tmp);
353
350 /* if youre dead, no point in doing this... */ 354 /* if youre dead, no point in doing this... */
351 if (!QUERY_FLAG (op, FLAG_REMOVED)) 355 if (!QUERY_FLAG (op, FLAG_REMOVED))
352 op->update_stats (); 356 op->update_stats ();
357
353 return 1; 358 return 1;
354 } 359 }
355 360
356 /* Deal with protection potions */ 361 /* Deal with protection potions */
357 force = NULL; 362 force = NULL;
… …
359 { 364 {
360 if (tmp->resist[i]) 365 if (tmp->resist[i])
361 { 366 {
362 if (!force) 367 if (!force)
363 force = get_archetype (FORCE_NAME); 368 force = get_archetype (FORCE_NAME);
369
364 memcpy (force->resist, tmp->resist, sizeof (tmp->resist)); 370 memcpy (force->resist, tmp->resist, sizeof (tmp->resist));
365 force->type = POTION_EFFECT; 371 force->type = POTION_EFFECT;
366 break; /* Only need to find one protection since we copy entire batch */ 372 break; /* Only need to find one protection since we copy entire batch */
367 } 373 }
368 } 374 }
375
369 /* This is a protection potion */ 376 /* This is a protection potion */
370 if (force) 377 if (force)
371 { 378 {
372 /* cursed items last longer */ 379 /* cursed items last longer */
373 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 380 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
… …
375 force->stats.food *= 10; 382 force->stats.food *= 10;
376 for (i = 0; i < NROFATTACKS; i++) 383 for (i = 0; i < NROFATTACKS; i++)
377 if (force->resist[i] > 0) 384 if (force->resist[i] > 0)
378 force->resist[i] = -force->resist[i]; /* prot => vuln */ 385 force->resist[i] = -force->resist[i]; /* prot => vuln */
379 } 386 }
387
380 force->speed_left = -1; 388 force->speed_left = -1;
381 force = insert_ob_in_ob (force, op); 389 force = insert_ob_in_ob (force, op);
382 CLEAR_FLAG (tmp, FLAG_APPLIED); 390 CLEAR_FLAG (tmp, FLAG_APPLIED);
383 SET_FLAG (force, FLAG_APPLIED); 391 SET_FLAG (force, FLAG_APPLIED);
384 change_abil (op, force); 392 change_abil (op, force);
… …
391 { /* only for players */ 399 { /* only for players */
392 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0) 400 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0)
393 CLEAR_FLAG (tmp, FLAG_APPLIED); 401 CLEAR_FLAG (tmp, FLAG_APPLIED);
394 else 402 else
395 SET_FLAG (tmp, FLAG_APPLIED); 403 SET_FLAG (tmp, FLAG_APPLIED);
404
396 if (!change_abil (op, tmp)) 405 if (!change_abil (op, tmp))
397 new_draw_info (NDI_UNIQUE, 0, op, "Nothing happened."); 406 op->statusmsg ("Nothing happened.");
398 } 407 }
399 408
400 /* CLEAR_FLAG is so that if the character has other potions 409 /* CLEAR_FLAG is so that if the character has other potions
401 * that were grouped with the one consumed, his 410 * that were grouped with the one consumed, his
402 * stat will not be raised by them. fix_player just clears 411 * stat will not be raised by them. fix_player just clears
… …
418static int 427static int
419check_item (object *op, const char *item) 428check_item (object *op, const char *item)
420{ 429{
421 int count = 0; 430 int count = 0;
422 431
423 432 if (!item)
424 if (item == NULL)
425 return 0; 433 return 0;
426 op = op->below; 434
427 while (op != NULL) 435 for (op = op->below; op; op = op->below)
428 { 436 {
429 if (strcmp (op->arch->name, item) == 0) 437 if (strcmp (op->arch->archname, item) == 0)
430 { 438 {
431 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED) 439 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED)
432 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID)) 440 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID))
433 { 441 {
434 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */ 442 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */
435 count++; 443 count++;
436 else 444 else
437 count += op->nrof; 445 count += op->nrof;
438 } 446 }
439 } 447 }
440 op = op->below;
441 } 448 }
449
442 return count; 450 return count;
443} 451}
444 452
445/** 453/**
446 * This removes 'nrof' of what item->slaying says to remove. 454 * This removes 'nrof' of what item->slaying says to remove.
… …
454 object *prev; 462 object *prev;
455 463
456 prev = op; 464 prev = op;
457 op = op->below; 465 op = op->below;
458 466
459 while (op != NULL) 467 while (op)
460 { 468 {
461 if (strcmp (op->arch->name, item) == 0) 469 if (strcmp (op->arch->archname, item) == 0)
462 { 470 {
463 if (op->nrof >= nrof) 471 if (op->nrof >= nrof)
464 { 472 {
465 decrease_ob_nr (op, nrof); 473 decrease_ob_nr (op, nrof);
466 return; 474 return;
… …
468 else 476 else
469 { 477 {
470 decrease_ob_nr (op, op->nrof); 478 decrease_ob_nr (op, op->nrof);
471 nrof -= op->nrof; 479 nrof -= op->nrof;
472 } 480 }
481
473 op = prev; 482 op = prev;
474 } 483 }
484
475 prev = op; 485 prev = op;
476 op = op->below; 486 op = op->below;
477 } 487 }
478} 488}
479 489
… …
485 * we return 1 (true) if the player can use the weapon. 495 * we return 1 (true) if the player can use the weapon.
486 */ 496 */
487static int 497static int
488check_weapon_power (const object *who, int improvs) 498check_weapon_power (const object *who, int improvs)
489{ 499{
490
491/* Old code is below (commented out). Basically, since weapons are the only 500/* Old code is below (commented out). Basically, since weapons are the only
492 * object players really have any control to improve, it's a bit harsh to 501 * object players really have any control to improve, it's a bit harsh to
493 * require high level in some combat skill, so we just use overall level. 502 * require high level in some combat skill, so we just use overall level.
494 */ 503 */
495#if 1 504#if 1
… …
536static int 545static int
537check_sacrifice (object *op, const object *improver) 546check_sacrifice (object *op, const object *improver)
538{ 547{
539 int count = 0; 548 int count = 0;
540 549
541 if (improver->slaying != NULL) 550 if (improver->slaying)
542 { 551 {
543 count = check_item (op, improver->slaying); 552 count = check_item (op, improver->slaying);
544 if (count < 1) 553 if (count < 1)
545 { 554 {
546 char buf[200];
547
548 sprintf (buf, "The gods want more %ss", &improver->slaying); 555 op->failmsg (format ("The gods want more %ss", &improver->slaying));
549 new_draw_info (NDI_UNIQUE, 0, op, buf);
550 return 0; 556 return 0;
551 } 557 }
552 } 558 }
553 else 559 else
554 count = 1; 560 count = 1;
… …
557} 563}
558 564
559/** 565/**
560 * Actually improves the weapon, and tells user. 566 * Actually improves the weapon, and tells user.
561 */ 567 */
562int 568static int
563improve_weapon_stat (object *op, object *improver, object *weapon, signed char *stat, int sacrifice_count, const char *statname) 569improve_weapon_stat (object *op, object *improver, object *weapon, sint8 &stat, int sacrifice_count, const char *statname)
564{ 570{
565
566 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
567 *stat += sacrifice_count; 571 stat += sacrifice_count;
568 weapon->last_eat++; 572 weapon->last_eat++;
569 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon's bonus to %s improved by %d", statname, sacrifice_count);
570 decrease_ob (improver); 573 decrease_ob (improver);
571 574
572 /* So it updates the players stats and the window */ 575 /* So it updates the players stats and the window */
573 op->update_stats (); 576 op->update_stats ();
577
578 op->statusmsg (format (
579 "Your sacrifice was accepted.\n"
580 "Weapon's bonus to %s improved by %d.",
581 statname, sacrifice_count
582 ));
583
574 return 1; 584 return 1;
575} 585}
576 586
577/* Types of improvements, hidden in the sp field. */ 587/* Types of improvements, hidden in the sp field. */
578#define IMPROVE_PREPARE 1 588#define IMPROVE_PREPARE 1
579#define IMPROVE_DAMAGE 2 589#define IMPROVE_DAMAGE 2
580#define IMPROVE_WEIGHT 3 590#define IMPROVE_WEIGHT 3
581#define IMPROVE_ENCHANT 4 591#define IMPROVE_ENCHANT 4
582#define IMPROVE_STR 5 592#define IMPROVE_STR 5
583#define IMPROVE_DEX 6 593#define IMPROVE_DEX 6
584#define IMPROVE_CON 7 594#define IMPROVE_CON 7
585#define IMPROVE_WIS 8 595#define IMPROVE_WIS 8
586#define IMPROVE_CHA 9 596#define IMPROVE_CHA 9
587#define IMPROVE_INT 10 597#define IMPROVE_INT 10
588#define IMPROVE_POW 11 598#define IMPROVE_POW 11
589
590 599
591/** 600/**
592 * This does the prepare weapon scroll. 601 * This does the prepare weapon scroll.
593 * Checks for sacrifice, and so on. 602 * Checks for sacrifice, and so on.
594 */ 603 */
595
596int 604int
597prepare_weapon (object *op, object *improver, object *weapon) 605prepare_weapon (object *op, object *improver, object *weapon)
598{ 606{
599 int sacrifice_count, i; 607 int sacrifice_count, i;
600 char buf[MAX_BUF]; 608 char buf[MAX_BUF];
601 609
602 if (weapon->level != 0) 610 if (weapon->level != 0)
603 { 611 {
604 new_draw_info (NDI_UNIQUE, 0, op, "Weapon already prepared."); 612 op->failmsg ("Weapon is already prepared!");
605 return 0; 613 return 0;
606 } 614 }
615
607 for (i = 0; i < NROFATTACKS; i++) 616 for (i = 0; i < NROFATTACKS; i++)
608 if (weapon->resist[i]) 617 if (weapon->resist[i])
609 break; 618 break;
610 619
611 /* If we break out, i will be less than nrofattacks, preventing 620 /* If we break out, i will be less than nrofattacks, preventing
… …
614 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */ 623 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */
615 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */ 624 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */
616 weapon->stats.exp || /* speed */ 625 weapon->stats.exp || /* speed */
617 weapon->stats.ac) /* AC - only taifu's I think */ 626 weapon->stats.ac) /* AC - only taifu's I think */
618 { 627 {
619 new_draw_info (NDI_UNIQUE, 0, op, "Cannot prepare magic weapons."); 628 op->failmsg ("You cannot prepare magic weapons. "
629 "H<A weapon is considered magical if it changes regeneration, "
630 "speed or ac.>");
620 return 0; 631 return 0;
621 } 632 }
633
622 sacrifice_count = check_sacrifice (op, improver); 634 sacrifice_count = check_sacrifice (op, improver);
623 if (sacrifice_count <= 0) 635 if (sacrifice_count <= 0)
624 return 0; 636 return 0;
637
625 weapon->level = isqrt (sacrifice_count); 638 weapon->level = isqrt (sacrifice_count);
626 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
627 eat_item (op, improver->slaying, sacrifice_count); 639 eat_item (op, improver->slaying, sacrifice_count);
628 640
629 new_draw_info_format (NDI_UNIQUE, 0, op, "Your *%s may be improved %d times.", &weapon->name, weapon->level); 641 op->statusmsg (format (
642 "Your sacrifice was accepted."
643 "Your *%s may be improved %d times.",
644 &weapon->name, weapon->level
645 ));
630 646
631 sprintf (buf, "%s's %s", &op->name, &weapon->name); 647 sprintf (buf, "%s's %s", &op->name, &weapon->name);
632 weapon->name = weapon->name_pl = buf; 648 weapon->name = weapon->name_pl = buf;
633 weapon->nrof = 0; /* prevents preparing n weapons in the same 649 weapon->nrof = 0; /* prevents preparing n weapons in the same
634 slot at once! */ 650 slot at once! */
… …
653improve_weapon (object *op, object *improver, object *weapon) 669improve_weapon (object *op, object *improver, object *weapon)
654{ 670{
655 int sacrifice_count, sacrifice_needed = 0; 671 int sacrifice_count, sacrifice_needed = 0;
656 672
657 if (improver->stats.sp == IMPROVE_PREPARE) 673 if (improver->stats.sp == IMPROVE_PREPARE)
658 {
659 return prepare_weapon (op, improver, weapon); 674 return prepare_weapon (op, improver, weapon);
660 } 675
661 if (weapon->level == 0) 676 if (weapon->level == 0)
662 { 677 {
663 new_draw_info (NDI_UNIQUE, 0, op, "This weapon has not been prepared."); 678 op->failmsg ("This weapon has not been prepared. H<You first ahve to prepare a weapon with a prepare weapon scroll.>");
664 return 0; 679 return 0;
665 } 680 }
681
666 if (weapon->level == weapon->last_eat && weapon->item_power >= 100) 682 if (weapon->level == weapon->last_eat && weapon->item_power >= 100)
667 { 683 {
668 new_draw_info (NDI_UNIQUE, 0, op, "This weapon cannot be improved any more."); 684 op->failmsg ("This weapon cannot be improved any more.");
669 return 0; 685 return 0;
670 } 686 }
687
671 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1)) 688 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1))
672 { 689 {
673 new_draw_info (NDI_UNIQUE, 0, op, "Improving the weapon will make it too"); 690 op->failmsg ("Improving the weapon will make it too "
674 new_draw_info (NDI_UNIQUE, 0, op, "powerful for you to use. Unready it if you"); 691 "powerful for you to use. Unready it if you "
675 new_draw_info (NDI_UNIQUE, 0, op, "really want to improve it."); 692 "really want to improve it.");
676 return 0; 693 return 0;
677 } 694 }
695
678 /* This just increases damage by 5 points, no matter what. No sacrifice 696 /* This just increases damage by 5 points, no matter what. No sacrifice
679 * is needed. Since stats.dam is now a 16 bit value and not 8 bit, 697 * is needed. Since stats.dam is now a 16 bit value and not 8 bit,
680 * don't put any maximum value on damage - the limit is how much the 698 * don't put any maximum value on damage - the limit is how much the
681 * weapon can be improved. 699 * weapon can be improved.
682 */ 700 */
683 if (improver->stats.sp == IMPROVE_DAMAGE) 701 if (improver->stats.sp == IMPROVE_DAMAGE)
684 { 702 {
685 weapon->stats.dam += 5; 703 weapon->stats.dam += 5;
686 weapon->weight += 5000; /* 5 KG's */ 704 weapon->weight += 5000; /* 5 KG's */
687 new_draw_info_format (NDI_UNIQUE, 0, op, "Damage has been increased by 5 to %d", weapon->stats.dam); 705 op->statusmsg (format ("Damage has been increased by 5 to %d.", weapon->stats.dam));
688 weapon->last_eat++; 706 weapon->last_eat++;
689 707
690 weapon->item_power++; 708 weapon->item_power++;
691 decrease_ob (improver); 709 decrease_ob (improver);
692 return 1; 710 return 1;
693 } 711 }
712
694 if (improver->stats.sp == IMPROVE_WEIGHT) 713 if (improver->stats.sp == IMPROVE_WEIGHT)
695 { 714 {
696 /* Reduce weight by 20% */ 715 /* Reduce weight by 20% */
697 weapon->weight = (weapon->weight * 8) / 10; 716 weapon->weight = (weapon->weight * 8) / 10;
698 if (weapon->weight < 1) 717 if (weapon->weight < 1)
699 weapon->weight = 1; 718 weapon->weight = 1;
719
700 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon weight reduced to %6.1f kg", (float) weapon->weight / 1000.0); 720 op->statusmsg (format ("Weapon weight reduced to %6.1fkg.", (float) weapon->weight / 1000.0));
701 weapon->last_eat++; 721 weapon->last_eat++;
702 weapon->item_power++; 722 weapon->item_power++;
703 decrease_ob (improver); 723 decrease_ob (improver);
704 return 1; 724 return 1;
705 } 725 }
706 if (improver->stats.sp == IMPROVE_ENCHANT) 726 if (improver->stats.sp == IMPROVE_ENCHANT)
707 { 727 {
708 weapon->magic++; 728 weapon->magic++;
709 weapon->last_eat++; 729 weapon->last_eat++;
710 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon magic increased to %d", weapon->magic); 730 op->statusmsg (format ("Weapon magic increased to %d.", weapon->magic));
711 decrease_ob (improver); 731 decrease_ob (improver);
712 weapon->item_power++; 732 weapon->item_power++;
713 return 1; 733 return 1;
714 } 734 }
715 735
… …
721 sacrifice_needed *= 2; 741 sacrifice_needed *= 2;
722 742
723 sacrifice_count = check_sacrifice (op, improver); 743 sacrifice_count = check_sacrifice (op, improver);
724 if (sacrifice_count < sacrifice_needed) 744 if (sacrifice_count < sacrifice_needed)
725 { 745 {
726 new_draw_info_format (NDI_UNIQUE, 0, op, "You need at least %d %s", sacrifice_needed, &improver->slaying); 746 op->failmsg (format ("You need at least %d %s.", sacrifice_needed, &improver->slaying));
727 return 0; 747 return 0;
728 } 748 }
749
729 eat_item (op, improver->slaying, sacrifice_needed); 750 eat_item (op, improver->slaying, sacrifice_needed);
730 weapon->item_power++; 751 weapon->item_power++;
731 752
732 switch (improver->stats.sp) 753 switch (improver->stats.sp)
733 { 754 {
734 case IMPROVE_STR:
735 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Str), 1, "strength"); 755 case IMPROVE_STR: return improve_weapon_stat (op, improver, weapon, weapon->stats.Str, 1, "strength");
736 case IMPROVE_DEX:
737 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Dex), 1, "dexterity"); 756 case IMPROVE_DEX: return improve_weapon_stat (op, improver, weapon, weapon->stats.Dex, 1, "dexterity");
738 case IMPROVE_CON:
739 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Con), 1, "constitution"); 757 case IMPROVE_CON: return improve_weapon_stat (op, improver, weapon, weapon->stats.Con, 1, "constitution");
740 case IMPROVE_WIS:
741 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Wis), 1, "wisdom"); 758 case IMPROVE_WIS: return improve_weapon_stat (op, improver, weapon, weapon->stats.Wis, 1, "wisdom");
742 case IMPROVE_CHA:
743 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Cha), 1, "charisma"); 759 case IMPROVE_CHA: return improve_weapon_stat (op, improver, weapon, weapon->stats.Cha, 1, "charisma");
744 case IMPROVE_INT:
745 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Int), 1, "intelligence"); 760 case IMPROVE_INT: return improve_weapon_stat (op, improver, weapon, weapon->stats.Int, 1, "intelligence");
746 case IMPROVE_POW:
747 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Pow), 1, "power"); 761 case IMPROVE_POW: return improve_weapon_stat (op, improver, weapon, weapon->stats.Pow, 1, "power");
748 default: 762 default:
749 new_draw_info (NDI_UNIQUE, 0, op, "Unknown improvement type."); 763 op->failmsg ("Unknown improvement type.");
750 } 764 }
765
751 LOG (llevError, "improve_weapon: Got to end of function\n"); 766 LOG (llevError, "improve_weapon: Got to end of function\n");
752 return 0; 767 return 0;
753} 768}
754 769
755/** 770/**
… …
762{ 777{
763 object *otmp; 778 object *otmp;
764 779
765 if (op->type != PLAYER) 780 if (op->type != PLAYER)
766 return 0; 781 return 0;
782
767 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 783 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC))
768 { 784 {
769 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 785 op->failmsg ("Something blocks the magic of the scroll!");
770 return 0; 786 return 0;
771 } 787 }
788
772 otmp = find_marked_object (op); 789 otmp = find_marked_object (op);
773 if (!otmp) 790 if (!otmp)
774 { 791 {
775 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark a weapon object."); 792 op->failmsg ("You need to mark a weapon object. H<Use the mark command or the mark option from the item popup menu.>");
776 return 0; 793 return 0;
777 } 794 }
795
778 if (otmp->type != WEAPON && otmp->type != BOW) 796 if (otmp->type != WEAPON && otmp->type != BOW)
779 { 797 {
780 new_draw_info (NDI_UNIQUE, 0, op, "Marked item is not a weapon or bow"); 798 op->failmsg ("Marked item is not a weapon or bow!");
781 return 0; 799 return 0;
782 } 800 }
783 new_draw_info (NDI_UNIQUE, 0, op, "Applied weapon builder."); 801
802 op->statusmsg ("Applied weapon builder.");
803
784 improve_weapon (op, tmp, otmp); 804 improve_weapon (op, tmp, otmp);
785 esrv_send_item (op, otmp); 805 esrv_send_item (op, otmp);
786 return 1; 806 return 1;
787} 807}
788 808
… …
813{ 833{
814 object *tmp; 834 object *tmp;
815 835
816 if (armour->magic >= settings.armor_max_enchant) 836 if (armour->magic >= settings.armor_max_enchant)
817 { 837 {
818 new_draw_info (NDI_UNIQUE, 0, op, "This armour can not be enchanted any further."); 838 op->failmsg ("This armour can not be enchanted any further!");
819 return 0; 839 return 0;
820 } 840 }
821 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight, 841 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight,
822 * etc), so take the easy way out and don't worry about it. 842 * etc), so take the easy way out and don't worry about it.
823 * Note - maybe add scrolls which make the random artifact versions (eg, armour 843 * Note - maybe add scrolls which make the random artifact versions (eg, armour
824 * of gnarg and what not?) 844 * of gnarg and what not?)
825 */ 845 */
826 if (armour->title) 846 if (armour->title)
827 { 847 {
828 new_draw_info (NDI_UNIQUE, 0, op, "This armour will not accept further enchantment."); 848 op->failmsg ("This armour will not accept further enchantment.");
829 return 0; 849 return 0;
830 } 850 }
831 851
832 /* Split objects if needed. Can't insert tmp until the 852 /* Split objects if needed. Can't insert tmp until the
833 * end of this function - otherwise it will just re-merge. 853 * end of this function - otherwise it will just re-merge.
… …
848 { 868 {
849 base = base - (base * settings.armor_speed_improvement) / 100; 869 base = base - (base * settings.armor_speed_improvement) / 100;
850 pow++; 870 pow++;
851 } 871 }
852 872
853 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * base) / 100; 873 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * base) / 100;
854 } 874 }
855 else 875 else
856 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * (100 + armour->magic * settings.armor_speed_improvement)) / 100; 876 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * (100 + armour->magic * settings.armor_speed_improvement)) / 100;
857 877
858 if (!settings.armor_weight_linear) 878 if (!settings.armor_weight_linear)
859 { 879 {
860 int base = 100; 880 int base = 100;
861 int pow = 0; 881 int pow = 0;
… …
864 { 884 {
865 base = base - (base * settings.armor_weight_reduction) / 100; 885 base = base - (base * settings.armor_weight_reduction) / 100;
866 pow++; 886 pow++;
867 } 887 }
868 888
869 armour->weight = (armour->arch->clone.weight * base) / 100; 889 armour->weight = (armour->arch->weight * base) / 100;
870 } 890 }
871 else 891 else
872 armour->weight = (armour->arch->clone.weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100; 892 armour->weight = (armour->arch->weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100;
873 893
874 if (armour->weight <= 0) 894 if (armour->weight <= 0)
875 { 895 {
876 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n."); 896 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n.");
877 armour->weight = 1; 897 armour->weight = 1;
878 } 898 }
879 899
880 armour->item_power = get_power_from_ench (armour->arch->clone.item_power + armour->magic); 900 armour->item_power = get_power_from_ench (armour->arch->item_power + armour->magic);
881 901
882 if (op->type == PLAYER) 902 if (op->type == PLAYER)
883 { 903 {
884 esrv_send_item (op, armour); 904 esrv_send_item (op, armour);
885 if (QUERY_FLAG (armour, FLAG_APPLIED)) 905 if (QUERY_FLAG (armour, FLAG_APPLIED))
886 op->update_stats (); 906 op->update_stats ();
887 } 907 }
908
888 decrease_ob (improver); 909 decrease_ob (improver);
910
889 if (tmp) 911 if (tmp)
890 { 912 {
891 insert_ob_in_ob (tmp, op); 913 insert_ob_in_ob (tmp, op);
892 esrv_send_item (op, tmp); 914 esrv_send_item (op, tmp);
893 } 915 }
916
894 return 1; 917 return 1;
895} 918}
896
897 919
898/* 920/*
899 * convert_item() returns 1 if anything was converted, 0 if the item was not 921 * convert_item() returns 1 if anything was converted, 0 if the item was not
900 * what the converter wants, -1 if the converter is broken. 922 * what the converter wants, -1 if the converter is broken.
901 */ 923 */
… …
917 939
918 /* We make some assumptions - we assume if it takes money as it type, 940 /* We make some assumptions - we assume if it takes money as it type,
919 * it wants some amount. We don't make change (ie, if something costs 941 * it wants some amount. We don't make change (ie, if something costs
920 * 3 gp and player drops a platinum, tough luck) 942 * 3 gp and player drops a platinum, tough luck)
921 */ 943 */
922 if (!strcmp (CONV_FROM (converter), "money")) 944 if (CONV_FROM (converter) == shstr_money)
923 { 945 {
924 int cost;
925
926 if (item->type != MONEY) 946 if (item->type != MONEY)
927 return 0; 947 return 0;
928 948
929 nr = (item->nrof * item->value) / CONV_NEED (converter); 949 nr = (item->nrof * item->value) / CONV_NEED (converter);
930 if (!nr) 950 if (!nr)
931 return 0; 951 return 0;
952
953 converter->play_sound (sound_find ("shop_buy"));
954
932 cost = nr * CONV_NEED (converter) / item->value; 955 int cost = nr * CONV_NEED (converter) / item->value;
933 /* take into account rounding errors */ 956 /* take into account rounding errors */
934 if (nr * CONV_NEED (converter) % item->value) 957 if (nr * CONV_NEED (converter) % item->value)
935 cost++; 958 cost++;
959
936 decrease_ob_nr (item, cost); 960 decrease_ob_nr (item, cost);
937 961
938 price_in = cost * item->value; 962 price_in = cost * item->value;
939 } 963 }
940 else 964 else
941 { 965 {
942 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->name || 966 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->archname ||
943 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof)) 967 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof))
944 return 0; 968 return 0;
969
970 converter->play_sound (sound_find ("convert_item"));
945 971
946 if (CONV_NEED (converter)) 972 if (CONV_NEED (converter))
947 { 973 {
948 nr = item->nrof / CONV_NEED (converter); 974 nr = item->nrof / CONV_NEED (converter);
949 decrease_ob_nr (item, nr * CONV_NEED (converter)); 975 decrease_ob_nr (item, nr * CONV_NEED (converter));
… …
954 price_in = item->value; 980 price_in = item->value;
955 item->destroy (); 981 item->destroy ();
956 } 982 }
957 } 983 }
958 984
959 if (converter->inv != NULL) 985 if (converter->inv)
960 { 986 {
961 object *ob; 987 object *ob;
962 int i; 988 int i;
963 object *ob_to_copy; 989 object *ob_to_copy;
964 990
965 /* select random object from inventory to copy */ 991 /* select random object from inventory to copy */
966 ob_to_copy = converter->inv; 992 ob_to_copy = converter->inv;
967 for (ob = converter->inv->below, i = 1; ob != NULL; ob = ob->below, i++) 993 for (ob = converter->inv->below, i = 1; ob; ob = ob->below, i++)
968 {
969 if (rndm (0, i) == 0) 994 if (rndm (0, i) == 0)
970 {
971 ob_to_copy = ob; 995 ob_to_copy = ob;
972 } 996
973 }
974 item = object_create_clone (ob_to_copy); 997 item = object_create_clone (ob_to_copy);
975 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE); 998 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE);
976 unflag_inv (item, FLAG_IS_A_TEMPLATE); 999 unflag_inv (item, FLAG_IS_A_TEMPLATE);
977 } 1000 }
978 else 1001 else
979 { 1002 {
980 if (converter->other_arch == NULL) 1003 if (converter->other_arch == NULL)
981 { 1004 {
982 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n", 1005 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n",
983 &converter->name, converter->map->path, converter->x, converter->y); 1006 &converter->name, &converter->map->path, converter->x, converter->y);
984 return -1; 1007 return -1;
985 } 1008 }
986 1009
987 item = object_create_arch (converter->other_arch); 1010 item = object_create_arch (converter->other_arch);
988 fix_generated_item (item, converter, 0, 0, GT_MINIMAL); 1011 fix_generated_item (item, converter, 0, 0, GT_MINIMAL);
989 } 1012 }
990 1013
991 if (CONV_NR (converter)) 1014 if (CONV_NR (converter))
992 item->nrof = CONV_NR (converter); 1015 item->nrof = CONV_NR (converter);
1016
993 if (nr) 1017 if (nr)
994 item->nrof *= nr; 1018 item->nrof *= nr;
1019
995 if (is_in_shop (converter)) 1020 if (is_in_shop (converter))
996 SET_FLAG (item, FLAG_UNPAID); 1021 SET_FLAG (item, FLAG_UNPAID);
997 else if (price_in < item->nrof * item->value) 1022 else if (price_in < item->nrof * item->value)
998 { 1023 {
999 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n", 1024 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n",
1000 &converter->name, converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name); 1025 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name);
1001
1002 /** 1026 /**
1003 * elmex: we are going to let the game continue, as the mapcreator 1027 * elmex: we are going to let the game continue, as the mapcreator
1004 * propably had something in mind when doing this 1028 * hopefully had something in mind when doing this.
1005 */ 1029 */
1006 } 1030 }
1031
1032 SET_FLAG (item, FLAG_IDENTIFIED);
1007 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y); 1033 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y);
1008 return 1; 1034 return 1;
1009} 1035}
1010 1036
1011/** 1037/**
1012 * Handle apply on containers. 1038 * Handle apply on containers.
1013 * By Eneq(@csd.uu.se). 1039 * By Eneq(@csd.uu.se).
1014 * Moved to own function and added many features [Tero.Haatanen@lut.fi] 1040 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1015 * added the alchemical cauldron to the code -b.t. 1041 * added the alchemical cauldron to the code -b.t.
1016 */ 1042 */
1017
1018int 1043int
1019apply_container (object *op, object *sack) 1044apply_container (object *op, object *sack)
1020{ 1045{
1021 char buf[MAX_BUF]; 1046 if (op->type != PLAYER || !op->contr->ns)
1022 object *tmp;
1023
1024 if (op->type != PLAYER)
1025 return 0; /* This might change */ 1047 return 0; /* This might change */
1026 1048
1027 if (sack == NULL || sack->type != CONTAINER) 1049 if (!sack || sack->type != CONTAINER)
1028 { 1050 {
1029 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]"); 1051 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1030 return 0; 1052 return 0;
1031 } 1053 }
1032 1054
1033 op->contr->last_used = 0; 1055 op->contr->last_used = 0;
1034 1056
1035 if (sack->env != op) 1057 if (sack->env && sack->env != op)
1058 {
1059 op->failmsg ("You must put it onto the floor or into your inventory first.");
1060 return 1;
1036 { 1061 }
1037 if (sack->other_arch == NULL || sack->env != NULL) 1062
1063 // already applied == open on ground, or open in inv, or active in inv
1064 if (sack->flag [FLAG_APPLIED])
1065 {
1066 if (op->container == sack)
1038 { 1067 {
1039 new_draw_info (NDI_UNIQUE, 0, op, "You must get it first."); 1068 // open on ground or inv, so close
1069 op->close_container ();
1040 return 1; 1070 return 1;
1041 } 1071 }
1042 1072 else if (!sack->env)
1043 /* It's on the ground, the problems begin */
1044 if (op->container != sack)
1045 {
1046 /* it's closed OR some player has opened it */
1047 if (QUERY_FLAG (sack, FLAG_APPLIED))
1048 {
1049 for (tmp = GET_MAP_OB (sack->map, sack->x, sack->y); tmp && tmp->container != sack; tmp = tmp->above);
1050 if (tmp)
1051 {
1052 /* some other player have opened it */
1053 new_draw_info_format (NDI_UNIQUE, 0, op, "%s is already occupied.", query_name (sack));
1054 return 1;
1055 }
1056 }
1057 } 1073 {
1058 if (QUERY_FLAG (sack, FLAG_APPLIED)) 1074 // active, but not ours: some other player has opened it
1075 op->failmsg (format ("Somebody else is using the %s already.", query_name (sack)));
1076 return 1;
1059 { 1077 }
1060 if (op->container == NULL)
1061 {
1062 tmp = arch_to_object (sack->other_arch);
1063 /* not good, but insert_ob_in_ob() is too smart */
1064 CLEAR_FLAG (tmp, FLAG_REMOVED);
1065 tmp->x = tmp->y = 0;
1066 tmp->map = NULL;
1067 tmp->env = sack;
1068 if (sack->inv)
1069 sack->inv->above = tmp;
1070 tmp->below = sack->inv;
1071 tmp->above = NULL;
1072 sack->inv = tmp;
1073 sack->move_off = MOVE_ALL; /* trying force closing it */
1074 }
1075 else
1076 {
1077 sack->move_off = 0;
1078 tmp = sack->inv;
1079 1078
1080 if (tmp && tmp->type == CLOSE_CON) 1079 // fall through to opening it (active in inv)
1081 tmp->destroy ();
1082 }
1083 }
1084 }
1085
1086 if (QUERY_FLAG (sack, FLAG_APPLIED))
1087 { 1080 }
1081 else if (sack->env)
1082 {
1083 // it is in our env, so activate it, do not open yet
1088 if (op->container) 1084 op->close_container ();
1089 { 1085 sack->flag [FLAG_APPLIED] = 1;
1090 if (op->container != sack) 1086 esrv_update_item (UPD_FLAGS, op, sack);
1091 { 1087 op->statusmsg (format ("You ready %s.", query_name (sack)));
1092 tmp = op->container; 1088 return 1;
1093 apply_container (op, tmp); 1089 }
1094 sprintf (buf, "You close %s and open ", query_name (tmp)); 1090
1095 op->container = sack; 1091 // it's locked?
1096 strcat (buf, query_name (sack)); 1092 if (sack->slaying)
1097 strcat (buf, "."); 1093 {
1098 } 1094 if (object *tmp = find_key (op, op, sack))
1099 else 1095 op->statusmsg (format ("You unlock %s with %s.", query_name (sack), query_name (tmp)));
1100 {
1101 CLEAR_FLAG (sack, FLAG_APPLIED);
1102 op->container = NULL;
1103 sprintf (buf, "You close %s.", query_name (sack));
1104 }
1105 }
1106 else 1096 else
1107 { 1097 {
1108 CLEAR_FLAG (sack, FLAG_APPLIED);
1109 sprintf (buf, "You open %s.", query_name (sack));
1110 SET_FLAG (sack, FLAG_APPLIED);
1111 op->container = sack;
1112 }
1113 }
1114 else
1115 { /* not applied */
1116 if (sack->slaying)
1117 { /* it's locked */
1118 tmp = find_key (op, op, sack);
1119 if (tmp)
1120 {
1121 sprintf (buf, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1122 SET_FLAG (sack, FLAG_APPLIED);
1123
1124 if (sack->env == NULL)
1125 { /* if it's on ground,open it also */
1126 new_draw_info (NDI_UNIQUE, 0, op, buf);
1127 apply_container (op, sack);
1128 return 1;
1129 }
1130 }
1131 else
1132 sprintf (buf, "You don't have the key to unlock %s.", query_name (sack)); 1098 op->statusmsg (format ("You don't have the key to unlock %s.", query_name (sack)));
1133 }
1134 else
1135 {
1136 sprintf (buf, "You readied %s.", query_name (sack));
1137 SET_FLAG (sack, FLAG_APPLIED);
1138
1139 if (sack->env == NULL)
1140 { /* if it's on ground,open it also */
1141 new_draw_info (NDI_UNIQUE, 0, op, buf);
1142 apply_container (op, sack);
1143 return 1; 1099 return 1;
1144 } 1100 }
1145 }
1146 } 1101 }
1147 1102
1148 new_draw_info (NDI_UNIQUE, 0, op, buf); 1103 op->open_container (sack);
1149
1150 if (op->contr)
1151 op->contr->ns->floorbox_update ();
1152 1104
1153 return 1; 1105 return 1;
1154} 1106}
1155
1156/**
1157 * Eneq(@csd.uu.se): Handle apply on containers. This is for containers
1158 * the player has in their inventory, eg, sacks, luggages, etc.
1159 *
1160 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1161 * This version is for client/server mode.
1162 * op is the player, sack is the container the player is opening or closing.
1163 * return 1 if an object is apllied somehow or another, 0 if error/no apply
1164 *
1165 * Reminder - there are three states for any container - closed (non applied),
1166 * applied (not open, but objects that match get tossed into it), and open
1167 * (applied flag set, and op->container points to the open container)
1168 */
1169
1170int
1171esrv_apply_container (object *op, object *sack)
1172{
1173 object *tmp = op->container;
1174
1175 if (op->type != PLAYER)
1176 return 0; /* This might change */
1177
1178 if (sack == NULL || sack->type != CONTAINER)
1179 {
1180 LOG (llevError, "esrv_apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1181 return 0;
1182 }
1183
1184 /* If we have a currently open container, then it needs to be closed in all cases
1185 * if we are opening this one up. We then fall through if appropriate for
1186 * openening the new container.
1187 */
1188
1189 if (op->container && QUERY_FLAG (sack, FLAG_APPLIED))
1190 {
1191 if (op->container->env != op)
1192 { /* if container is on the ground */
1193 op->container->move_off = 0;
1194 }
1195
1196 if (INVOKE_OBJECT (CLOSE, tmp, ARG_OBJECT (op)))
1197 return 1;
1198
1199 new_draw_info_format (NDI_UNIQUE, 0, op, "You close %s.", query_name (op->container));
1200 CLEAR_FLAG (op->container, FLAG_APPLIED);
1201 op->container = NULL;
1202 esrv_update_item (UPD_FLAGS, op, tmp);
1203 if (tmp == sack)
1204 return 1;
1205 }
1206
1207
1208 /* If the player is trying to open it (which he must be doing if we got here),
1209 * and it is locked, check to see if player has the equipment to open it.
1210 */
1211
1212 if (sack->slaying)
1213 { /* it's locked */
1214 tmp = find_key (op, op, sack);
1215 if (tmp)
1216 {
1217 new_draw_info_format (NDI_UNIQUE, 0, op, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1218 }
1219 else
1220 {
1221 new_draw_info_format (NDI_UNIQUE, 0, op, "You don't have the key to unlock %s.", query_name (sack));
1222 return 0;
1223 }
1224 }
1225
1226 /* By the time we get here, we have made sure any other container has been closed and
1227 * if this is a locked container, the player they key to open it.
1228 */
1229
1230 /* There are really two cases - the sack is either on the ground, or the sack is
1231 * part of the players inventory. If on the ground, we assume that the player is
1232 * opening it, since if it was being closed, that would have been taken care of above.
1233 */
1234
1235
1236 if (sack->env != op)
1237 {
1238 /* Hypothetical case - the player is trying to open a sack that belong to someone
1239 * else. This normally should not happen, but a misbehaving client/player could
1240 * try to do it, so lets handle it gracefully.
1241 */
1242 if (sack->env)
1243 {
1244 new_draw_info_format (NDI_UNIQUE, 0, op, "You can't open %s", query_name (sack));
1245 return 0;
1246 }
1247 /* set these so when the player walks off, we can unapply the sack */
1248 sack->move_off = MOVE_ALL; /* trying force closing it */
1249
1250 CLEAR_FLAG (sack, FLAG_APPLIED);
1251 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1252 SET_FLAG (sack, FLAG_APPLIED);
1253 op->container = sack;
1254 esrv_update_item (UPD_FLAGS, op, sack);
1255 esrv_send_inventory (op, sack);
1256
1257 }
1258 else
1259 { /* sack is in players inventory */
1260 if (QUERY_FLAG (sack, FLAG_APPLIED))
1261 { /* readied sack becoming open */
1262 CLEAR_FLAG (sack, FLAG_APPLIED);
1263 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1264 SET_FLAG (sack, FLAG_APPLIED);
1265 op->container = sack;
1266 esrv_update_item (UPD_FLAGS, op, sack);
1267 esrv_send_inventory (op, sack);
1268 }
1269 else
1270 {
1271 CLEAR_FLAG (sack, FLAG_APPLIED);
1272 new_draw_info_format (NDI_UNIQUE, 0, op, "You readied %s.", query_name (sack));
1273 SET_FLAG (sack, FLAG_APPLIED);
1274 esrv_update_item (UPD_FLAGS, op, sack);
1275 }
1276 }
1277 return 1;
1278}
1279
1280 1107
1281/** 1108/**
1282 * Handles dropping things on altar. 1109 * Handles dropping things on altar.
1283 * Returns true if sacrifice was accepted. 1110 * Returns true if sacrifice was accepted.
1284 */ 1111 */
… …
1295 * with an altar. We call it a Potion - altars are stationary - it 1122 * with an altar. We call it a Potion - altars are stationary - it
1296 * is up to map designers to use them properly. 1123 * is up to map designers to use them properly.
1297 */ 1124 */
1298 if (altar->inv && altar->inv->type == SPELL) 1125 if (altar->inv && altar->inv->type == SPELL)
1299 { 1126 {
1300 new_draw_info_format (NDI_BLACK, 0, originator, "The altar casts %s.", &altar->inv->name); 1127 originator->statusmsg (format ("The altar casts %s.", &altar->inv->name));
1301 cast_spell (originator, altar, 0, altar->inv, NULL); 1128 cast_spell (originator, altar, 0, altar->inv, NULL);
1302 /* If it is connected, push the button. Fixes some problems with 1129 /* If it is connected, push the button. Fixes some problems with
1303 * old maps. 1130 * old maps.
1304 */ 1131 */
1305 1132
1306/* push_button (altar);*/ 1133/* push_button (altar);*/
1307 } 1134 }
… …
1331 double opinion; 1158 double opinion;
1332 object *tmp, *next; 1159 object *tmp, *next;
1333 1160
1334 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */ 1161 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */
1335 1162
1163 bool has_unpaid = false;
1164
1165 // quite inefficient to do this here twice, but the api doesn'T lend itself to
1166 // a quick and small change :(
1167 for (object::depth_iterator item = op->begin (); item != op->end (); ++item)
1168 if (item->flag [FLAG_UNPAID])
1169 {
1170 has_unpaid = true;
1171 break;
1172 }
1173
1336 if (op->type != PLAYER) 1174 if (op->type != PLAYER)
1337 { 1175 {
1338 /* Remove all the unpaid objects that may be carried here. 1176 /* Remove all the unpaid objects that may be carried here.
1339 * This could be pets or monsters that are somehow in 1177 * This could be pets or monsters that are somehow in
1340 * the shop. 1178 * the shop.
… …
1366 /* unpaid objects, or non living objects, can't transfer by 1204 /* unpaid objects, or non living objects, can't transfer by
1367 * shop mats. Instead, put it on a nearby space. 1205 * shop mats. Instead, put it on a nearby space.
1368 */ 1206 */
1369 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE)) 1207 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE))
1370 { 1208 {
1371
1372 /* Somebody dropped an unpaid item, just move to an adjacent place. */ 1209 /* Somebody dropped an unpaid item, just move to an adjacent place. */
1373 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1210 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1374 1211
1375 if (i != -1) 1212 if (i != -1)
1376 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat); 1213 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat);
… …
1385 else if (can_pay (op) && get_payment (op)) 1222 else if (can_pay (op) && get_payment (op))
1386 { 1223 {
1387 /* this is only used for players */ 1224 /* this is only used for players */
1388 rv = teleport (shop_mat, SHOP_MAT, op); 1225 rv = teleport (shop_mat, SHOP_MAT, op);
1389 1226
1227 if (has_unpaid)
1228 op->contr->play_sound (sound_find ("shop_buy"));
1229 else if (is_in_shop (op))
1230 op->contr->play_sound (sound_find ("shop_enter"));
1231 else
1232 op->contr->play_sound (sound_find ("shop_leave"));
1233
1390 if (shop_mat->msg) 1234 if (shop_mat->msg)
1391 new_draw_info (NDI_UNIQUE, 0, op, shop_mat->msg); 1235 op->statusmsg (shop_mat->msg);
1392 /* This check below is a bit simplistic - generally it should be correct, 1236 /* This check below is a bit simplistic - generally it should be correct,
1393 * but there is never a guarantee that the bottom space on the map is 1237 * but there is never a guarantee that the bottom space on the map is
1394 * actually the shop floor. 1238 * actually the shop floor.
1395 */ 1239 */
1396 else if (!rv && !is_in_shop (op)) 1240 else if (!rv && !is_in_shop (op))
1397 { 1241 {
1398 opinion = shopkeeper_approval (op->map, op); 1242 opinion = shopkeeper_approval (op->map, op);
1399 1243
1400 if (opinion > 0.9) 1244 op->statusmsg (
1401 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper gives you a friendly wave."); 1245 opinion >= 0.90 ? "The shopkeeper gives you a friendly wave."
1402 else if (opinion > 0.75) 1246 : opinion >= 0.75 ? "The shopkeeper waves to you."
1403 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper waves to you."); 1247 : opinion >= 0.50 ? "The shopkeeper ignores you."
1404 else if (opinion > 0.5) 1248 : "The shopkeeper glares at you with contempt."
1405 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper ignores you.");
1406 else 1249 );
1407 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper glares at you with contempt.");
1408 } 1250 }
1409 } 1251 }
1410 else 1252 else
1411 { 1253 {
1412 /* if we get here, a player tried to leave a shop but was not able 1254 /* if we get here, a player tried to leave a shop but was not able
1413 * to afford the items he has. We try to move the player so that 1255 * to afford the items he has. We try to move the player so that
1414 * they are not on the mat anymore 1256 * they are not on the mat anymore
1415 */ 1257 */
1416 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1258 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1417 1259
1418 if (i == -1) 1260 if (i == -1)
1419 {
1420 LOG (llevError, "Internal shop-mat problem.\n"); 1261 LOG (llevError, "Internal shop-mat problem.\n");
1421 }
1422 else 1262 else
1423 { 1263 {
1424 op->remove (); 1264 op->remove ();
1425 op->x += freearr_x[i]; 1265 op->x += freearr_x[i];
1426 op->y += freearr_y[i]; 1266 op->y += freearr_y[i];
… …
1437 */ 1277 */
1438static void 1278static void
1439apply_sign (object *op, object *sign, int autoapply) 1279apply_sign (object *op, object *sign, int autoapply)
1440{ 1280{
1441 readable_message_type *msgType; 1281 readable_message_type *msgType;
1442 char newbuf[HUGE_BUF];
1443 1282
1444 if (sign->msg == NULL) 1283 if (!sign->msg)
1445 { 1284 {
1446 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it."); 1285 op->statusmsg ("Nothing is written on it.");
1447 return; 1286 return;
1448 } 1287 }
1449 1288
1450 if (sign->stats.food) 1289 if (sign->stats.food)
1451 { 1290 {
1452 if (sign->last_eat >= sign->stats.food) 1291 if (sign->last_eat >= sign->stats.food)
1453 { 1292 {
1454 if (!sign->move_on) 1293 if (!sign->move_on)
1455 new_draw_info (NDI_UNIQUE, 0, op, "You cannot read it anymore."); 1294 op->statusmsg ("You cannot read it anymore.");
1295
1456 return; 1296 return;
1457 } 1297 }
1458 1298
1459 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1299 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1460 sign->last_eat++; 1300 sign->last_eat++;
… …
1465 * move_on is zero, it needs to be manually applied (doesn't talk 1305 * move_on is zero, it needs to be manually applied (doesn't talk
1466 * to us). 1306 * to us).
1467 */ 1307 */
1468 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on) 1308 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on)
1469 { 1309 {
1470 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1310 op->failmsg ("You are unable to read while blind!");
1471 return; 1311 return;
1472 } 1312 }
1313
1314 if (op->contr)
1315 if (client *ns = op->contr->ns)
1316 {
1317 if (sign->sound)
1318 ns->play_sound (sign->sound);
1319 else if (autoapply)
1320 ns->play_sound (sound_find ("msg_say"));
1321
1322 if (ns->can_msg)
1323 op->contr->infobox (MSG_CHANNEL ("examine"), format ("T<%s>\n\n\n\n%s", &sign->name, &sign->msg));
1324 else
1325 {
1473 msgType = get_readable_message_type (sign); 1326 msgType = get_readable_message_type (sign);
1474 snprintf (newbuf, sizeof (newbuf), "%hhu %s", autoapply ? 1 : 0, &sign->msg); 1327 const char *somemsg = format ("%u %s", autoapply ? 1 : 0, &sign->msg);
1475 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg); 1328 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, somemsg, &sign->msg);
1329 }
1330 }
1476} 1331}
1477 1332
1478/** 1333/**
1479 * 'victim' moves onto 'trap' 1334 * 'victim' moves onto 'trap'
1480 * 'victim' leaves 'trap' 1335 * 'victim' leaves 'trap'
… …
1503 * proper. This code was causing needless crashes. 1358 * proper. This code was causing needless crashes.
1504 */ 1359 */
1505 if (recursion_depth >= 500) 1360 if (recursion_depth >= 500)
1506 { 1361 {
1507 LOG (llevDebug, "WARNING: move_apply(): aborting recursion " 1362 LOG (llevDebug, "WARNING: move_apply(): aborting recursion "
1508 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->name, &trap->name, &victim->arch->name, &victim->name); 1363 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->archname, &trap->name, &victim->arch->archname, &victim->name);
1509 return; 1364 return;
1510 } 1365 }
1366
1511 recursion_depth++; 1367 recursion_depth++;
1512 if (trap->head) 1368 if (trap->head)
1513 trap = trap->head; 1369 trap = trap->head;
1514 1370
1515 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator))) 1371 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator)))
… …
1530 1386
1531 /* Just put in some sanity check. I think there is a bug in the 1387 /* Just put in some sanity check. I think there is a bug in the
1532 * above with some objects have zero speed, and thus the player 1388 * above with some objects have zero speed, and thus the player
1533 * getting permanently paralyzed. 1389 * getting permanently paralyzed.
1534 */ 1390 */
1535 if (victim->speed_left < -50.0) 1391 if (victim->speed_left < -50.f)
1536 victim->speed_left = -50.0; 1392 victim->speed_left = -50.f;
1537 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */ 1393 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */
1538 } 1394 }
1539 goto leave; 1395 goto leave;
1540 1396
1541 case SPINNER: 1397 case SPINNER:
… …
1613 1469
1614 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1470 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1615 { 1471 {
1616 if (!sound_was_played) 1472 if (!sound_was_played)
1617 { 1473 {
1618 play_sound_map (trap->map, trap->x, trap->y, SOUND_FALL_HOLE); 1474 trap->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1619 sound_was_played = 1; 1475 sound_was_played = 1;
1620 } 1476 }
1621 new_draw_info (NDI_UNIQUE, 0, ab, "You fall into a trapdoor!"); 1477
1478 ab->statusmsg ("You fall into a trapdoor!", NDI_RED);
1622 transfer_ob (ab, (int) EXIT_X (trap), (int) EXIT_Y (trap), 0, ab); 1479 transfer_ob (ab, EXIT_X (trap), EXIT_Y (trap), 0, ab);
1623 } 1480 }
1624 } 1481 }
1625 goto leave; 1482 goto leave;
1626 } 1483 }
1627 1484
1628
1629 case CONVERTER: 1485 case CONVERTER:
1630 if (convert_item (victim, trap) < 0) 1486 if (convert_item (victim, trap) < 0)
1631 { 1487 {
1632 object *op; 1488 originator->failmsg (format ("The %s seems to be broken!", query_name (trap)));
1633 1489 get_archetype ("burnout")->insert_at (trap, trap);
1634 new_draw_info_format (NDI_UNIQUE, 0, originator, "The %s seems to be broken!", query_name (trap));
1635
1636 op = get_archetype ("burnout");
1637 if (op != NULL)
1638 {
1639 op->x = trap->x;
1640 op->y = trap->y;
1641 insert_ob_in_map (op, trap->map, trap, 0);
1642 }
1643 } 1490 }
1491
1644 goto leave; 1492 goto leave;
1645 1493
1646 case TRIGGER_BUTTON: 1494 case TRIGGER_BUTTON:
1647 case TRIGGER_PEDESTAL: 1495 case TRIGGER_PEDESTAL:
1648 case TRIGGER_ALTAR: 1496 case TRIGGER_ALTAR:
… …
1666 * Processing will happen if the head runs into the pit 1514 * Processing will happen if the head runs into the pit
1667 */ 1515 */
1668 if (victim->head) 1516 if (victim->head)
1669 goto leave; 1517 goto leave;
1670 1518
1671 play_sound_map (victim->map, victim->x, victim->y, SOUND_FALL_HOLE); 1519 victim->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1672 new_draw_info (NDI_UNIQUE, 0, victim, "You fall through the hole!\n"); 1520 victim->statusmsg ("You fall through the hole!", NDI_RED);
1673 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim); 1521 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim);
1674 goto leave; 1522 goto leave;
1675 1523
1676 case EXIT: 1524 case EXIT:
1677 if (victim->type == PLAYER && EXIT_PATH (trap)) 1525 if (victim->type == PLAYER && EXIT_PATH (trap))
1678 { 1526 {
1679 /* Basically, don't show exits leading to random maps the 1527 /* Basically, don't show exits leading to random maps the
1680 * players output. 1528 * players output.
1681 */ 1529 */
1682 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2) && strncmp (EXIT_PATH (trap), "/random/", 8)) 1530 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2))
1683 new_draw_info (NDI_NAVY, 0, victim, trap->msg); 1531 victim->statusmsg (trap->msg, NDI_NAVY);
1532
1533 trap->play_sound (trap->sound);
1684 enter_exit (victim, trap); 1534 victim->enter_exit (trap);
1685 } 1535 }
1686 goto leave; 1536 goto leave;
1687 1537
1688 case ENCOUNTER: 1538 case ENCOUNTER:
1689 /* may be some leftovers on this */ 1539 /* may be some leftovers on this */
… …
1704 1554
1705 apply_sign (victim, trap, 1); 1555 apply_sign (victim, trap, 1);
1706 goto leave; 1556 goto leave;
1707 1557
1708 case CONTAINER: 1558 case CONTAINER:
1709 if (victim->type == PLAYER)
1710 (void) esrv_apply_container (victim, trap);
1711 else
1712 (void) apply_container (victim, trap); 1559 apply_container (victim, trap);
1713 goto leave; 1560 goto leave;
1714 1561
1715 case RUNE: 1562 case RUNE:
1716 case TRAP: 1563 case TRAP:
1717 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE)) 1564 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE))
1718 {
1719 spring_trap (trap, victim); 1565 spring_trap (trap, victim);
1720 }
1721 goto leave; 1566 goto leave;
1722 1567
1723 default: 1568 default:
1724 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not " 1569 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not "
1725 "handled in move_apply()\n", &trap->name, &trap->arch->name, trap->type); 1570 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type);
1726 goto leave; 1571 goto leave;
1727 } 1572 }
1728 1573
1729leave: 1574leave:
1730 recursion_depth--; 1575 recursion_depth--;
… …
1739 int lev_diff; 1584 int lev_diff;
1740 object *skill_ob; 1585 object *skill_ob;
1741 1586
1742 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1587 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1743 { 1588 {
1744 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1589 op->failmsg ("You are unable to read while blind!");
1745 return; 1590 return;
1746 } 1591 }
1592
1747 if (tmp->msg == NULL) 1593 if (!tmp->msg)
1748 { 1594 {
1749 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name); 1595 op->failmsg (format ("You open the %s and find it empty.", &tmp->name));
1750 return; 1596 return;
1751 } 1597 }
1752 1598
1753 /* need a literacy skill to read stuff! */ 1599 /* need a literacy skill to read stuff! */
1754 skill_ob = find_skill_by_name (op, tmp->skill); 1600 skill_ob = find_skill_by_name (op, tmp->skill);
1755 if (!skill_ob) 1601 if (!skill_ob)
1756 { 1602 {
1757 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1603 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill to read this.>", &tmp->skill));
1758 return; 1604 return;
1759 } 1605 }
1606
1760 lev_diff = tmp->level - (skill_ob->level + 5); 1607 lev_diff = tmp->level - (skill_ob->level + 5);
1761 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0) 1608 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0)
1762 { 1609 {
1763 if (lev_diff < 2) 1610 op->failmsg (lev_diff < 2 ? "This book is just barely beyond your comprehension."
1764 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension."); 1611 : lev_diff < 3 ? "This book is slightly beyond your comprehension."
1765 else if (lev_diff < 3) 1612 : lev_diff < 5 ? "This book is beyond your comprehension."
1766 new_draw_info (NDI_UNIQUE, 0, op, "This book is slightly beyond your comprehension."); 1613 : lev_diff < 8 ? "This book is quite a bit beyond your comprehension."
1767 else if (lev_diff < 5) 1614 : lev_diff < 15 ? "This book is way beyond your comprehension."
1768 new_draw_info (NDI_UNIQUE, 0, op, "This book is beyond your comprehension."); 1615 : "This book is totally beyond your comprehension.");
1769 else if (lev_diff < 8) 1616 return;
1770 new_draw_info (NDI_UNIQUE, 0, op, "This book is quite a bit beyond your comprehension."); 1617 }
1771 else if (lev_diff < 15) 1618
1772 new_draw_info (NDI_UNIQUE, 0, op, "This book is way beyond your comprehension."); 1619 readable_message_type *msgType = get_readable_message_type (tmp);
1620
1621 if (player *pl = op->contr)
1622 if (client *ns = pl->ns)
1623 if (ns->can_msg)
1624 pl->infobox (MSG_CHANNEL ("book"), format ("T<%s>\n\n\n\n%s", (char *)long_desc (tmp, op), &tmp->msg));
1773 else 1625 else
1774 new_draw_info (NDI_UNIQUE, 0, op, "This book is totally beyond your comprehension.");
1775 return;
1776 }
1777
1778 readable_message_type *msgType = get_readable_message_type (tmp);
1779
1780 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, 1626 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op,
1781 msgType->message_type, msgType->message_subtype, 1627 msgType->message_type, msgType->message_subtype,
1782 "You open the %s and start reading.\n%s", "%s\n%s", long_desc (tmp, op), &tmp->msg); 1628 "You open the %s and start reading.\n%s", (char *)"%s\n%s",
1629 long_desc (tmp, op), &tmp->msg);
1783 1630
1784 /* gain xp from reading */ 1631 /* gain xp from reading */
1785 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT)) 1632 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT))
1786 { /* only if not read before */ 1633 { /* only if not read before */
1787 int exp_gain = calc_skill_exp (op, tmp, skill_ob); 1634 int exp_gain = calc_skill_exp (op, tmp, skill_ob);
… …
1808 * op is the person learning the skill, tmp is the skill scroll object 1655 * op is the person learning the skill, tmp is the skill scroll object
1809 */ 1656 */
1810static void 1657static void
1811apply_skillscroll (object *op, object *tmp) 1658apply_skillscroll (object *op, object *tmp)
1812{ 1659{
1813 switch ((int) learn_skill (op, tmp)) 1660 switch (learn_skill (op, tmp))
1814 { 1661 {
1815 case 0: 1662 case 0:
1816 new_draw_info (NDI_UNIQUE, 0, op, "You already possess the knowledge "); 1663 op->play_sound (sound_find ("generic_fail"));
1817 new_draw_info_format (NDI_UNIQUE, 0, op, "held within the %s.\n", query_name (tmp)); 1664 op->failmsg (format ("You already possess the knowledge held within the %s.", query_name (tmp)));
1818 return; 1665 break;
1819 1666
1820 case 1: 1667 case 1:
1821 new_draw_info_format (NDI_UNIQUE, 0, op, "You succeed in learning %s", &tmp->skill);
1822 decrease_ob (tmp); 1668 decrease_ob (tmp);
1669 op->play_sound (sound_find ("skill_learn"));
1670 op->statusmsg (format ("You succeed in learning %s", &tmp->skill));
1823 return; 1671 break;
1824 1672
1825 default: 1673 default:
1826 new_draw_info_format (NDI_UNIQUE, 0, op, "You fail to learn the knowledge of the %s.\n", query_name (tmp));
1827 decrease_ob (tmp); 1674 decrease_ob (tmp);
1675 op->play_sound (sound_find ("generic_fail"));
1676 op->failmsg (format ("You fail to learn the knowledge of the %s.\n", query_name (tmp)));
1828 return; 1677 break;
1829 } 1678 }
1830} 1679}
1831 1680
1832/** 1681/**
1833 * Actually makes op learn spell. 1682 * Actually makes op learn spell.
… …
1853 return; 1702 return;
1854 } 1703 }
1855 return; 1704 return;
1856 } 1705 }
1857 1706
1858 play_sound_player_only (op->contr, SOUND_LEARN_SPELL, 0, 0); 1707 op->contr->play_sound (sound_find ("learn_spell"));
1708
1859 tmp = spell->clone (); 1709 tmp = spell->clone ();
1860 insert_ob_in_ob (tmp, op); 1710 insert_ob_in_ob (tmp, op);
1861 1711
1862 if (special_prayer) 1712 if (special_prayer)
1863 SET_FLAG (tmp, FLAG_STARTEQUIP); 1713 SET_FLAG (tmp, FLAG_STARTEQUIP);
… …
1882 { 1732 {
1883 LOG (llevError, "BUG: do_forget_spell(): spell not known\n"); 1733 LOG (llevError, "BUG: do_forget_spell(): spell not known\n");
1884 return; 1734 return;
1885 } 1735 }
1886 1736
1887 new_draw_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, "You lose knowledge of %s.", spell); 1737 op->failmsg (format ("You lose knowledge of %s.", spell));
1888 player_unready_range_ob (op->contr, spob); 1738 player_unready_range_ob (op->contr, spob);
1889 esrv_remove_spell (op->contr, spob); 1739 esrv_remove_spell (op->contr, spob);
1890 spob->destroy (); 1740 spob->destroy ();
1891} 1741}
1892 1742
… …
1900{ 1750{
1901 object *skop, *spell, *spell_skill; 1751 object *skop, *spell, *spell_skill;
1902 1752
1903 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1753 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1904 { 1754 {
1905 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1755 op->failmsg ("You are unable to read while blind.");
1906 return; 1756 return;
1907 } 1757 }
1908 1758
1909 /* artifact_spellbooks have 'slaying' field point to a spell name, 1759 /* artifact_spellbooks have 'slaying' field point to a spell name,
1910 * instead of having their spell stored in stats.sp. These are 1760 * instead of having their spell stored in stats.sp. These are
1911 * legacy spellbooks 1761 * legacy spellbooks
1912 */ 1762 */
1913
1914 if (tmp->slaying != NULL) 1763 if (tmp->slaying)
1915 { 1764 {
1916 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying)); 1765 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying));
1917 if (!spell) 1766 if (!spell)
1918 { 1767 {
1919 new_draw_info_format (NDI_UNIQUE, 0, op, "The book's formula for %s is incomplete", &tmp->slaying); 1768 op->failmsg (format ("The book's formula for %s is incomplete.", &tmp->slaying));
1920 return; 1769 return;
1921 } 1770 }
1922 else 1771 else
1923 insert_ob_in_ob (spell, tmp); 1772 insert_ob_in_ob (spell, tmp);
1773
1924 tmp->slaying = NULL; 1774 tmp->slaying = 0;
1925 } 1775 }
1926 1776
1927 skop = find_skill_by_name (op, tmp->skill); 1777 skop = find_skill_by_name (op, tmp->skill);
1928 1778
1929 /* need a literacy skill to learn spells. Also, having a literacy level 1779 /* need a literacy skill to learn spells. Also, having a literacy level
1930 * lower than the spell will make learning the spell more difficult */ 1780 * lower than the spell will make learning the spell more difficult */
1931 if (!skop) 1781 if (!skop)
1932 { 1782 {
1933 new_draw_info (NDI_UNIQUE, 0, op, "You can't read! Your attempt fails."); 1783 op->failmsg (format ("You can't read! Your attempt fails. H<You lack the %s skill.>", &tmp->skill));
1934 return; 1784 return;
1935 } 1785 }
1936 1786
1937 spell = tmp->inv; 1787 spell = tmp->inv;
1938 1788
1939 if (!spell) 1789 if (!spell)
1940 { 1790 {
1941 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name); 1791 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name);
1942 new_draw_info (NDI_UNIQUE, 0, op, "The spellbook symbols make no sense."); 1792 op->failmsg ("The spellbook symbols make no sense. This is a bug, please report!");
1943 return; 1793 return;
1944 } 1794 }
1945 1795
1946 if (skop->level < int (sqrtf (spell->level) * 1.5f)) 1796 if (skop->level < int (sqrtf (spell->level) * 1.5f))
1947 { 1797 {
1948 new_draw_info (NDI_UNIQUE, 0, op, "It is too hard to read at your level: You are unable to decipher the strange symbols."); 1798 op->failmsg (format ("You are unable to decipher the strange symbols. H<Your %s level is too low.>", &tmp->skill));
1949 return; 1799 return;
1950 } 1800 }
1951 1801
1952 new_draw_info_format (NDI_UNIQUE, 0, op, "The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name); 1802 op->statusmsg (format ("The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name));
1953 1803
1954 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1804 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1955 { 1805 {
1956 identify (tmp); 1806 identify (tmp);
1957 1807
… …
1966 * if the player doesn't know the spell, doesn't make a lot of sense that 1816 * if the player doesn't know the spell, doesn't make a lot of sense that
1967 * they would have a special prayer mark. 1817 * they would have a special prayer mark.
1968 */ 1818 */
1969 if (check_spell_known (op, spell->name)) 1819 if (check_spell_known (op, spell->name))
1970 { 1820 {
1971 new_draw_info (NDI_UNIQUE, 0, op, "You already know that spell.\n"); 1821 op->statusmsg ("You already know that spell. H<It makes no sense to learn spells twice, and would only waste the spellbook.>\n");
1972 return; 1822 return;
1973 } 1823 }
1974 1824
1975 if (spell->skill) 1825 if (spell->skill)
1976 { 1826 {
1977 spell_skill = find_skill_by_name (op, spell->skill); 1827 spell_skill = find_skill_by_name (op, spell->skill);
1978 1828
1979 if (!spell_skill) 1829 if (!spell_skill)
1980 { 1830 {
1981 new_draw_info_format (NDI_UNIQUE, 0, op, "You lack the skill %s to use this spell", &spell->skill); 1831 op->failmsg (format ("You lack the skill %s to use this spell.", &spell->skill));
1982 return; 1832 return;
1983 } 1833 }
1984 1834
1985 if (spell_skill->level < spell->level) 1835 if (spell_skill->level < spell->level)
1986 { 1836 {
1987 new_draw_info_format (NDI_UNIQUE, 0, op, "You need to be level %d in %s to learn this spell.", spell->level, &spell->skill); 1837 op->failmsg (format ("You need to be level %d in %s to learn this spell.", spell->level, &spell->skill));
1988 return; 1838 return;
1989 } 1839 }
1990 } 1840 }
1991 1841
1992 /* Logic as follows 1842 /* Logic as follows
… …
2001 * Overall, chances are the same but a player will find having a high 1851 * Overall, chances are the same but a player will find having a high
2002 * literacy rate very useful! -b.t. 1852 * literacy rate very useful! -b.t.
2003 */ 1853 */
2004 if (QUERY_FLAG (op, FLAG_CONFUSED)) 1854 if (QUERY_FLAG (op, FLAG_CONFUSED))
2005 { 1855 {
2006 new_draw_info (NDI_UNIQUE, 0, op, "In your confused state you flub the wording of the text!"); 1856 op->failmsg ("In your confused state you flub the wording of the text!");
2007 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace)); 1857 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace));
2008 } 1858 }
2009 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || 1859 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) ||
2010 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int]) 1860 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int])
2011 { 1861 {
2012 1862 op->statusmsg ("You succeed in learning the spell!", NDI_GREEN);
2013 new_draw_info (NDI_UNIQUE, 0, op, "You succeed in learning the spell!");
2014 do_learn_spell (op, spell, 0); 1863 do_learn_spell (op, spell, 0);
2015 1864
2016 /* xp gain to literacy for spell learning */ 1865 /* xp gain to literacy for spell learning */
2017 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP)) 1866 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP))
2018 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0); 1867 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0);
2019 } 1868 }
2020 else 1869 else
2021 { 1870 {
2022 play_sound_player_only (op->contr, SOUND_FUMBLE_SPELL, 0, 0); 1871 op->contr->play_sound (sound_find ("fumble_spell"));
2023 new_draw_info (NDI_UNIQUE, 0, op, "You fail to learn the spell.\n"); 1872 op->failmsg ("You fail to learn the spell. H<Wis (priests) or Int (wizards) governs the chance of learning a prayer or spell.>\n");
2024 } 1873 }
1874
2025 decrease_ob (tmp); 1875 decrease_ob (tmp);
2026} 1876}
2027 1877
2028/** 1878/**
2029 * Handles applying a spell scroll. 1879 * Handles applying a spell scroll.
… …
2033{ 1883{
2034 object *skop; 1884 object *skop;
2035 1885
2036 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1886 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
2037 { 1887 {
2038 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1888 op->failmsg ("You are unable to read while blind.");
2039 return; 1889 return;
2040 } 1890 }
2041 1891
2042 if (!tmp->inv || tmp->inv->type != SPELL) 1892 if (!tmp->inv || tmp->inv->type != SPELL)
2043 { 1893 {
2044 new_draw_info (NDI_UNIQUE, 0, op, "The scroll just doesn't make sense!"); 1894 op->failmsg ("The scroll just doesn't make sense! H<...and never will make sense.>");
2045 return; 1895 return;
2046 } 1896 }
2047 1897
2048 if (op->type == PLAYER) 1898 if (op->type == PLAYER)
2049 { 1899 {
… …
2055 */ 1905 */
2056 skop = find_skill_by_name (op, skill_names[SK_LITERACY]); 1906 skop = find_skill_by_name (op, skill_names[SK_LITERACY]);
2057 1907
2058 if (!skop) 1908 if (!skop)
2059 { 1909 {
2060 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1910 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill.>", &skill_names[SK_LITERACY]));
2061 return; 1911 return;
2062 } 1912 }
2063 1913
2064 if ((exp_gain = calc_skill_exp (op, tmp, skop))) 1914 if ((exp_gain = calc_skill_exp (op, tmp, skop)))
2065 change_exp (op, exp_gain, skop->skill, 0); 1915 change_exp (op, exp_gain, skop->skill, 0);
2066 } 1916 }
2067 1917
2068 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1918 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
2069 identify (tmp); 1919 identify (tmp);
2070 1920
2071 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name); 1921 op->statusmsg (format ("The scroll of %s turns to dust.", &tmp->inv->name));
2072
2073 1922
2074 cast_spell (op, tmp, dir, tmp->inv, NULL); 1923 cast_spell (op, tmp, dir, tmp->inv, NULL);
2075 decrease_ob (tmp); 1924 decrease_ob (tmp);
2076} 1925}
2077 1926
… …
2081 * chest. 1930 * chest.
2082 */ 1931 */
2083static void 1932static void
2084apply_treasure (object *op, object *tmp) 1933apply_treasure (object *op, object *tmp)
2085{ 1934{
2086 object *treas;
2087
2088
2089 /* Nice side effect of new treasure creation method is that the treasure 1935 /* Nice side effect of this treasure creation method is that the treasure
2090 * for the chest is done when the chest is created, and put into the chest 1936 * for the chest is done when the chest is created, and put into the chest
2091 * inventory. So that when the chest burns up, the items still exist. Also 1937 * inventory. So that when the chest burns up, the items still exist. Also
2092 * prevents people fromt moving chests to more difficult maps to get better 1938 * prevents people from moving chests to more difficult maps to get better
2093 * treasure 1939 * treasure
2094 */ 1940 */
2095
2096 treas = tmp->inv; 1941 object *treas = tmp->inv;
2097 if (treas == NULL) 1942
1943 if (!treas)
2098 { 1944 {
2099 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty."); 1945 op->statusmsg ("The chest was empty.");
2100 decrease_ob (tmp); 1946 decrease_ob (tmp);
2101 return; 1947 return;
2102 } 1948 }
1949
2103 while (tmp->inv) 1950 while (tmp->inv)
2104 { 1951 {
2105 treas = tmp->inv; 1952 treas = tmp->inv;
2106
2107 treas->remove (); 1953 treas->remove ();
2108 new_draw_info_format (NDI_UNIQUE, 0, op, "You find %s in the chest.", query_name (treas));
2109 1954
2110 treas->x = op->x; 1955 treas->x = op->x;
2111 treas->y = op->y; 1956 treas->y = op->y;
2112 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR); 1957 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR);
2113 1958
2114 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE)) 1959 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE))
2115 spring_trap (treas, op); 1960 spring_trap (treas, op);
2116 1961
2117 /* If either player or container was destroyed, no need to do 1962 /* If either player or container was destroyed, no need to do
2118 * further processing. I think this should be enclused with 1963 * further processing. I think this should be enclused with
2119 * spring trap above, as I don't think there is otherwise 1964 * spring trap above, as I don't think there is otherwise
2120 * any way for the treasure chest or player to get killed 1965 * any way for the treasure chest or player to get killed.
2121 */ 1966 */
2122 if (op->destroyed () || tmp->destroyed ()) 1967 if (op->destroyed () || tmp->destroyed ())
2123 break; 1968 break;
2124 } 1969 }
2125 1970
2126 if (!tmp->destroyed () && tmp->inv == NULL) 1971 if (!tmp->destroyed () && !tmp->inv)
2127 decrease_ob (tmp); 1972 decrease_ob (tmp);
2128
2129} 1973}
2130 1974
2131/** 1975/**
2132 * op eats food. 1976 * op eats food.
2133 * If player, takes care of messages and dragon special food. 1977 * If player, takes care of messages and dragon special food.
… …
2148 { 1992 {
2149 /* usual case - no dragon meal: */ 1993 /* usual case - no dragon meal: */
2150 if (op->stats.food + tmp->stats.food > 999) 1994 if (op->stats.food + tmp->stats.food > 999)
2151 { 1995 {
2152 if (tmp->type == FOOD || tmp->type == FLESH) 1996 if (tmp->type == FOOD || tmp->type == FLESH)
2153 new_draw_info (NDI_UNIQUE, 0, op, "You feel full, but what a waste of food!"); 1997 op->failmsg ("You feel full, but what a waste of food!");
2154 else 1998 else
2155 new_draw_info (NDI_UNIQUE, 0, op, "Most of the drink goes down your face not your throat!"); 1999 op->statusmsg ("Most of the drink goes down your face not your throat!");
2156 } 2000 }
2001
2002 tmp->play_sound (
2003 tmp->sound
2004 ? tmp->sound
2005 : tmp->type == DRINK
2006 ? sound_find ("eat_drink")
2007 : sound_find ("eat_food")
2008 );
2157 2009
2158 if (!QUERY_FLAG (tmp, FLAG_CURSED)) 2010 if (!QUERY_FLAG (tmp, FLAG_CURSED))
2159 { 2011 {
2160 char buf[MAX_BUF]; 2012 const char *buf;
2161 2013
2162 if (!is_dragon_pl (op)) 2014 if (!is_dragon_pl (op))
2163 { 2015 {
2164 /* eating message for normal players */ 2016 /* eating message for normal players */
2165 if (tmp->type == DRINK) 2017 if (tmp->type == DRINK)
2166 sprintf (buf, "Ahhh...that %s tasted good.", &tmp->name); 2018 buf = format ("Ahhh...that %s tasted good.", &tmp->name);
2167 else 2019 else
2168 sprintf (buf, "The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good."); 2020 buf = format ("The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good.");
2169 } 2021 }
2170 else 2022 else
2171 {
2172 /* eating message for dragon players */ 2023 /* eating message for dragon players */
2173 sprintf (buf, "The %s tasted terrible!", &tmp->name); 2024 buf = format ("The %s tasted terrible!", &tmp->name);
2174 }
2175 2025
2176 new_draw_info (NDI_UNIQUE, 0, op, buf); 2026 op->statusmsg (buf);
2027
2177 capacity_remaining = 999 - op->stats.food; 2028 capacity_remaining = 999 - op->stats.food;
2178 op->stats.food += tmp->stats.food; 2029 op->stats.food += tmp->stats.food;
2179 if (capacity_remaining < tmp->stats.food) 2030 if (capacity_remaining < tmp->stats.food)
2180 op->stats.hp += capacity_remaining / 50; 2031 op->stats.hp += capacity_remaining / 50;
2181 else 2032 else
2182 op->stats.hp += tmp->stats.food / 50; 2033 op->stats.hp += tmp->stats.food / 50;
2034
2183 if (op->stats.hp > op->stats.maxhp) 2035 if (op->stats.hp > op->stats.maxhp)
2184 op->stats.hp = op->stats.maxhp; 2036 op->stats.hp = op->stats.maxhp;
2185 if (op->stats.food > 999) 2037 if (op->stats.food > 999)
2186 op->stats.food = 999; 2038 op->stats.food = 999;
2187 } 2039 }
… …
2189 /* special food hack -b.t. */ 2041 /* special food hack -b.t. */
2190 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED)) 2042 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED))
2191 eat_special_food (op, tmp); 2043 eat_special_food (op, tmp);
2192 } 2044 }
2193 } 2045 }
2046
2194 handle_apply_yield (tmp); 2047 handle_apply_yield (tmp);
2195 decrease_ob (tmp); 2048 decrease_ob (tmp);
2196} 2049}
2197 2050
2198/** 2051/**
… …
2210{ 2063{
2211 object *skin = NULL; /* pointer to dragon skin force */ 2064 object *skin = NULL; /* pointer to dragon skin force */
2212 object *abil = NULL; /* pointer to dragon ability force */ 2065 object *abil = NULL; /* pointer to dragon ability force */
2213 object *tmp = NULL; /* tmp. object */ 2066 object *tmp = NULL; /* tmp. object */
2214 2067
2215 char buf[MAX_BUF]; /* tmp. string buffer */
2216 double chance; /* improvement-chance of one resistance type */ 2068 double chance; /* improvement-chance of one resistance type */
2217 double totalchance = 1; /* total chance of gaining one resistance */ 2069 double totalchance = 1; /* total chance of gaining one resistance */
2218 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */ 2070 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */
2219 double mbonus = 0; /* monster bonus */ 2071 double mbonus = 0; /* monster bonus */
2220 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */ 2072 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */
… …
2225 if (meal->type != FLESH || !is_dragon_pl (op)) 2077 if (meal->type != FLESH || !is_dragon_pl (op))
2226 return 0; 2078 return 0;
2227 2079
2228 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces 2080 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces
2229 from the player's inventory */ 2081 from the player's inventory */
2230 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 2082 for (tmp = op->inv; tmp; tmp = tmp->below)
2231 {
2232 if (tmp->type == FORCE) 2083 if (tmp->type == FORCE)
2233 { 2084 if (tmp->arch->archname == shstr_dragon_skin_force)
2234 if (strcmp (tmp->arch->name, "dragon_skin_force") == 0)
2235 skin = tmp; 2085 skin = tmp;
2236 else if (strcmp (tmp->arch->name, "dragon_ability_force") == 0) 2086 else if (tmp->arch->archname == shstr_dragon_ability_force)
2237 abil = tmp; 2087 abil = tmp;
2238 }
2239 }
2240 2088
2241 /* if either skin or ability are missing, this is an old player 2089 /* if either skin or ability are missing, this is an old player
2242 which is not to be considered a dragon -> bail out */ 2090 which is not to be considered a dragon -> bail out */
2243 if (skin == NULL || abil == NULL) 2091 if (skin == NULL || abil == NULL)
2244 return 0; 2092 return 0;
… …
2246 /* now start by filling stomache and health, according to food-value */ 2094 /* now start by filling stomache and health, according to food-value */
2247 if ((999 - op->stats.food) < meal->stats.food) 2095 if ((999 - op->stats.food) < meal->stats.food)
2248 op->stats.hp += (999 - op->stats.food) / 50; 2096 op->stats.hp += (999 - op->stats.food) / 50;
2249 else 2097 else
2250 op->stats.hp += meal->stats.food / 50; 2098 op->stats.hp += meal->stats.food / 50;
2099
2251 if (op->stats.hp > op->stats.maxhp) 2100 if (op->stats.hp > op->stats.maxhp)
2252 op->stats.hp = op->stats.maxhp; 2101 op->stats.hp = op->stats.maxhp;
2253 2102
2254 op->stats.food = MIN (999, op->stats.food + meal->stats.food); 2103 op->stats.food = MIN (999, op->stats.food + meal->stats.food);
2255 2104
… …
2285 /* doubled chance for resistance of ability-focus */ 2134 /* doubled chance for resistance of ability-focus */
2286 if (i == abil->stats.exp) 2135 if (i == abil->stats.exp)
2287 chance = MIN (100., chance * 2.); 2136 chance = MIN (100., chance * 2.);
2288 2137
2289 /* now make the throw and save all winners (Don't insert luck bonus here!) */ 2138 /* now make the throw and save all winners (Don't insert luck bonus here!) */
2290 if (RANDOM () % 10000 < (int) (chance * 100)) 2139 if (rndm (10000) < (unsigned int) (chance * 100))
2291 { 2140 {
2292 atnr_winner[winners] = i; 2141 atnr_winner[winners] = i;
2293 winners++; 2142 winners++;
2294 } 2143 }
2295 2144
… …
2300 } 2149 }
2301 } 2150 }
2302 2151
2303 /* inverse totalchance as until now we have the failure-chance */ 2152 /* inverse totalchance as until now we have the failure-chance */
2304 totalchance = 100 - totalchance * 100; 2153 totalchance = 100 - totalchance * 100;
2154
2305 /* print message according to totalchance */ 2155 /* print message according to totalchance */
2156 const char *buf;
2306 if (totalchance > 50.) 2157 if (totalchance > 50.)
2307 sprintf (buf, "Hmm! The %s tasted delicious!", &meal->name); 2158 buf = format ("Hmm! The %s tasted delicious!", &meal->name);
2308 else if (totalchance > 10.) 2159 else if (totalchance > 10.)
2309 sprintf (buf, "The %s tasted very good.", &meal->name); 2160 buf = format ("The %s tasted very good.", &meal->name);
2310 else if (totalchance > 1.) 2161 else if (totalchance > 1.)
2311 sprintf (buf, "The %s tasted good.", &meal->name); 2162 buf = format ("The %s tasted good.", &meal->name);
2312 else if (totalchance > 0.1) 2163 else if (totalchance > 0.1)
2313 sprintf (buf, "The %s tasted bland.", &meal->name); 2164 buf = format ("The %s tasted bland.", &meal->name);
2314 else if (totalchance >= 0.01) 2165 else if (totalchance >= 0.01)
2315 sprintf (buf, "The %s had a boring taste.", &meal->name); 2166 buf = format ("The %s had a boring taste.", &meal->name);
2316 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat)) 2167 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat))
2317 sprintf (buf, "The %s tasted strange.", &meal->name); 2168 buf = format ("The %s tasted strange.", &meal->name);
2318 else 2169 else
2319 sprintf (buf, "The %s had no taste.", &meal->name); 2170 buf = format ("The %s had no taste.", &meal->name);
2320 new_draw_info (NDI_UNIQUE, 0, op, buf); 2171
2172 op->statusmsg (buf);
2321 2173
2322 /* now choose a winner if we have any */ 2174 /* now choose a winner if we have any */
2323 i = -1; 2175 i = -1;
2324 if (winners > 0) 2176 if (winners > 0)
2325 i = atnr_winner[RANDOM () % winners]; 2177 i = atnr_winner[RANDOM () % winners];
… …
2328 { 2180 {
2329 /* resistance increased! */ 2181 /* resistance increased! */
2330 skin->resist[i]++; 2182 skin->resist[i]++;
2331 op->update_stats (); 2183 op->update_stats ();
2332 2184
2333 sprintf (buf, "Your skin is now more resistant to %s!", change_resist_msg[i]); 2185 op->statusmsg (format ("Your skin is now more resistant to %s!", change_resist_msg[i]));
2334 new_draw_info (NDI_UNIQUE | NDI_RED, 0, op, buf);
2335 } 2186 }
2336 2187
2337 /* if this flesh contains a new ability focus, we mark it 2188 /* if this flesh contains a new ability focus, we mark it
2338 into the ability_force and it will take effect on next level */ 2189 into the ability_force and it will take effect on next level */
2339 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat) 2190 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat)
2340 { 2191 {
2341 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */ 2192 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */
2342 2193
2343 if (meal->last_eat != abil->stats.exp) 2194 if (meal->last_eat != abil->stats.exp)
2195 op->statusmsg (format (
2196 "Your metabolism prepares to focus on %s!\n"
2197 "The change will happen at level %d.",
2198 change_resist_msg[meal->last_eat],
2199 abil->level + 1
2344 { 2200 ));
2345 sprintf (buf, "Your metabolism prepares to focus on %s!", change_resist_msg[meal->last_eat]);
2346 new_draw_info (NDI_UNIQUE, 0, op, buf);
2347 sprintf (buf, "The change will happen at level %d", abil->level + 1);
2348 new_draw_info (NDI_UNIQUE, 0, op, buf);
2349 }
2350 else 2201 else
2351 { 2202 {
2352 sprintf (buf, "Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]); 2203 op->statusmsg (format ("Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]));
2353 new_draw_info (NDI_UNIQUE, 0, op, buf);
2354 abil->last_eat = 0; 2204 abil->last_eat = 0;
2355 } 2205 }
2356 } 2206 }
2207
2357 return 1; 2208 return 1;
2358} 2209}
2359 2210
2360/** 2211/**
2361 * Handles applying an improve armor scroll. 2212 * Handles applying an improve armor scroll.
… …
2364static void 2215static void
2365apply_armour_improver (object *op, object *tmp) 2216apply_armour_improver (object *op, object *tmp)
2366{ 2217{
2367 object *armor; 2218 object *armor;
2368 2219
2369 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 2220 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_NO_MAGIC))
2370 { 2221 {
2371 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 2222 op->failmsg ("Something blocks the magic of the scroll. H<This area prevents magic effects.>");
2372 return; 2223 return;
2373 } 2224 }
2374 2225
2375 armor = find_marked_object (op); 2226 armor = find_marked_object (op);
2376 2227
2377 if (!armor) 2228 if (!armor)
2378 { 2229 {
2379 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark an armor object."); 2230 op->failmsg ("You need to mark an armor object. Use the right mouse button popup or the mark command to do this.");
2380 return; 2231 return;
2381 } 2232 }
2382 2233
2383 if (armor->type != ARMOUR 2234 if (armor->type != ARMOUR
2384 && armor->type != CLOAK 2235 && armor->type != CLOAK
2385 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET) 2236 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET)
2386 { 2237 {
2387 new_draw_info (NDI_UNIQUE, 0, op, "Your marked item is not armour!\n"); 2238 op->failmsg ("Your marked item is not armour!\n");
2388 return; 2239 return;
2389 } 2240 }
2390 2241
2391 new_draw_info (NDI_UNIQUE, 0, op, "Applying armour enchantment."); 2242 op->statusmsg ("Applying armour enchantment.");
2392 improve_armour (op, tmp, armor); 2243 improve_armour (op, tmp, armor);
2393} 2244}
2394 2245
2395extern void 2246extern void
2396apply_poison (object *op, object *tmp) 2247apply_poison (object *op, object *tmp)
2397{ 2248{
2398 if (op->type == PLAYER) 2249 if (op->type == PLAYER)
2399 { 2250 {
2400 play_sound_player_only (op->contr, SOUND_DRINK_POISON, 0, 0); 2251 op->contr->play_sound (sound_find ("drink_poison"));
2401 new_draw_info (NDI_UNIQUE, 0, op, "Yech! That tasted poisonous!"); 2252 op->failmsg ("Yech! That tasted poisonous!");
2402 strcpy (op->contr->killer, "poisonous booze"); 2253 strcpy (op->contr->killer, "poisonous booze");
2403 } 2254 }
2255
2404 if (tmp->stats.hp > 0) 2256 if (tmp->stats.hp > 0)
2405 { 2257 {
2406 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", tmp->stats.hp); 2258 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", tmp->stats.hp);
2407 hit_player (op, tmp->stats.hp, tmp, AT_POISON, 1); 2259 hit_player (op, tmp->stats.hp, tmp, AT_POISON, 1);
2408 } 2260 }
2261
2409 op->stats.food -= op->stats.food / 4; 2262 op->stats.food -= op->stats.food / 4;
2410 handle_apply_yield (tmp); 2263 handle_apply_yield (tmp);
2411 decrease_ob (tmp); 2264 decrease_ob (tmp);
2412} 2265}
2413 2266
2414/** 2267/**
2415 * This fonction return true if the exit is not a 2 ways one or it is 2 ways, valid exit. 2268 * This function return true if the exit is not a 2 ways one or it is 2 ways, valid exit.
2416 * A valid 2 way exit means: 2269 * A valid 2 way exit means:
2417 * -You can come back (there is another exit at the other side) 2270 * -You can come back (there is another exit at the other side)
2418 * -You are 2271 * -You are
2419 * ° the owner of the exit 2272 * ° the owner of the exit
2420 * ° or in the same party as the owner 2273 * ° or in the same party as the owner
… …
2424 * survive in the swapping (in fact the whole exit doesn't survive). 2277 * survive in the swapping (in fact the whole exit doesn't survive).
2425 */ 2278 */
2426int 2279int
2427is_legal_2ways_exit (object *op, object *exit) 2280is_legal_2ways_exit (object *op, object *exit)
2428{ 2281{
2429 object *tmp;
2430 object *exit_owner;
2431 player *pp;
2432 maptile *exitmap;
2433
2434 if (exit->stats.exp != 1) 2282 if (exit->stats.exp != 1)
2435 return 1; /*This is not a 2 way, so it is legal */ 2283 return 1; /*This is not a 2 way, so it is legal */
2284
2285#if 0 //TODO
2436 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race) 2286 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race)
2437 return 0; /* This is a reset town portal */ 2287 return 0; /* This is a reset town portal */
2438 /* To know if an exit has a correspondant, we look at 2288#endif
2439 * all the exits in destination and try to find one with same path as 2289
2440 * the current exit's position */ 2290 LOG (llevError | logBacktrace, "sync map load due to %s\n", exit->debug_desc ());
2441 if (!strncmp (EXIT_PATH (exit), settings.localdir, strlen (settings.localdir))) 2291
2442 exitmap = ready_map_name (EXIT_PATH (exit), MAP_PLAYER_UNIQUE); 2292 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map);
2443 else 2293
2444 exitmap = ready_map_name (EXIT_PATH (exit), 0);
2445 if (exitmap) 2294 if (exitmap)
2446 { 2295 {
2296 exitmap->load_sync ();
2297
2447 tmp = GET_MAP_OB (exitmap, EXIT_X (exit), EXIT_Y (exit)); 2298 object *tmp = exitmap->at (EXIT_X (exit), EXIT_Y (exit)).bot;
2299
2448 if (!tmp) 2300 if (!tmp)
2449 return 0; 2301 return 0;
2450 for ((tmp = GET_MAP_OB (exitmap, EXIT_X (exit), EXIT_Y (exit))); tmp; tmp = tmp->above) 2302
2303 for (; tmp; tmp = tmp->above)
2451 { 2304 {
2452 if (tmp->type != EXIT) 2305 if (tmp->type != EXIT)
2453 continue; /*Not an exit */ 2306 continue; /*Not an exit */
2307
2454 if (!EXIT_PATH (tmp)) 2308 if (!EXIT_PATH (tmp))
2455 continue; /*Not a valid exit */ 2309 continue; /*Not a valid exit */
2310
2456 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y)) 2311 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y))
2457 continue; /*Not in the same place */ 2312 continue; /*Not in the same place */
2313
2458 if (strcmp (exit->map->path, EXIT_PATH (tmp)) != 0) 2314 if (exit->map->path != EXIT_PATH (tmp))
2459 continue; /*Not in the same map */ 2315 continue; /*Not in the same map */
2460 2316
2461 /* From here we have found the exit is valid. However we do 2317 /* From here we have found the exit is valid. However we do
2462 * here the check of the exit owner. It is important for the 2318 * here the check of the exit owner. It is important for the
2463 * town portals to prevent strangers from visiting your appartments 2319 * town portals to prevent strangers from visiting your appartments
2464 */ 2320 */
2465 if (!exit->race) 2321 if (!exit->race)
2466 return 1; /*No owner, free for all! */ 2322 return 1; /*No owner, free for all! */
2323
2467 exit_owner = NULL; 2324 object *exit_owner = 0;
2468 for (pp = first_player; pp; pp = pp->next) 2325
2326 for_all_players (pp)
2469 { 2327 {
2470 if (!pp->ob) 2328 if (!pp->ob)
2471 continue; 2329 continue;
2330
2472 if (pp->ob->name != exit->race) 2331 if (pp->ob->name != exit->race)
2473 continue; 2332 continue;
2333
2474 exit_owner = pp->ob; /*We found a player which correspond to the player name */ 2334 exit_owner = pp->ob; /*We found a player which correspond to the player name */
2475 break; 2335 break;
2476 } 2336 }
2337
2477 if (!exit_owner) 2338 if (!exit_owner)
2478 return 0; /* No more owner */ 2339 return 0; /* No more owner */
2340
2479 if (exit_owner->contr == op->contr) 2341 if (exit_owner->contr == op->contr)
2480 return 1; /*It is your exit */ 2342 return 1; /*It is your exit */
2343
2481 if (exit_owner && /*There is a owner */ 2344 if (exit_owner && /*There is a owner */
2482 (op->contr) && /*A player tries to pass */ 2345 (op->contr) && /*A player tries to pass */
2483 ((exit_owner->contr->party == NULL) || /*No pass if controller has no party */ 2346 ((exit_owner->contr->party == NULL) || /*No pass if controller has no party */
2484 (exit_owner->contr->party != op->contr->party))) /* Or not the same as op */ 2347 (exit_owner->contr->party != op->contr->party))) /* Or not the same as op */
2485 return 0; 2348 return 0;
2349
2486 return 1; 2350 return 1;
2487 } 2351 }
2488 } 2352 }
2353
2489 return 0; 2354 return 0;
2490} 2355}
2491
2492 2356
2493/** 2357/**
2494 * Main apply handler. 2358 * Main apply handler.
2495 * 2359 *
2496 * Checks for unpaid items before applying. 2360 * Checks for unpaid items before applying.
… …
2504 * being applied. 2368 * being applied.
2505 * 2369 *
2506 * aflag is special (always apply/unapply) flags. Nothing is done with 2370 * aflag is special (always apply/unapply) flags. Nothing is done with
2507 * them in this function - they are passed to apply_special 2371 * them in this function - they are passed to apply_special
2508 */ 2372 */
2509
2510int 2373int
2511manual_apply (object *op, object *tmp, int aflag) 2374manual_apply (object *op, object *tmp, int aflag)
2512{ 2375{
2513 if (tmp->head) 2376 if (tmp->head)
2514 tmp = tmp->head; 2377 tmp = tmp->head;
2515 2378
2516 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED)) 2379 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED))
2517 { 2380 {
2518 if (op->type == PLAYER) 2381 if (op->type == PLAYER)
2519 { 2382 {
2520 new_draw_info (NDI_UNIQUE, 0, op, "You should pay for it first."); 2383 op->failmsg ("You should pay for it first! H<You cannot use items marked as unpaid.>");
2521 return 1; 2384 return 1;
2522 } 2385 }
2523 else 2386 else
2524 return 0; /* monsters just skip unpaid items */ 2387 return 0; /* monsters just skip unpaid items */
2525 } 2388 }
… …
2528 return RESULT_INT (0); 2391 return RESULT_INT (0);
2529 2392
2530 switch (tmp->type) 2393 switch (tmp->type)
2531 { 2394 {
2532 case CF_HANDLE: 2395 case CF_HANDLE:
2533 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2396 op->play_sound (sound_find ("turn_handle"));
2534 play_sound_map (op->map, op->x, op->y, SOUND_TURN_HANDLE); 2397 op->statusmsg ("You turn the handle.");
2535 tmp->value = tmp->value ? 0 : 1; 2398 tmp->value = tmp->value ? 0 : 1;
2536 SET_ANIMATION (tmp, tmp->value); 2399 SET_ANIMATION (tmp, tmp->value);
2537 update_object (tmp, UP_OBJ_FACE); 2400 update_object (tmp, UP_OBJ_FACE);
2538 push_button (tmp); 2401 push_button (tmp);
2539 return 1; 2402 return 1;
2540 2403
2541 case TRIGGER: 2404 case TRIGGER:
2542 if (check_trigger (tmp, op)) 2405 if (check_trigger (tmp, op))
2543 { 2406 {
2544 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2407 op->statusmsg ("You turn the handle.");
2545 play_sound_map (tmp->map, tmp->x, tmp->y, SOUND_TURN_HANDLE); 2408 op->play_sound (sound_find ("turn_handle"));
2546 } 2409 }
2547 else 2410 else
2548 { 2411 op->failmsg ("The handle doesn't move.");
2549 new_draw_info (NDI_UNIQUE, 0, op, "The handle doesn't move."); 2412
2550 }
2551 return 1; 2413 return 1;
2552 2414
2553 case EXIT: 2415 case EXIT:
2554 if (op->type != PLAYER) 2416 if (op->type != PLAYER)
2555 return 0; 2417 return 0;
2418
2556 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp)) 2419 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp))
2557 { 2420 op->failmsg (format ("The %s is closed.", query_name (tmp)));
2558 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s is closed.", query_name (tmp));
2559 }
2560 else 2421 else
2561 { 2422 {
2562 /* Don't display messages for random maps. */ 2423 /* Don't display messages for random maps. */
2563 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2) && strncmp (EXIT_PATH (tmp), "/random/", 8)) 2424 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2))
2564 new_draw_info (NDI_NAVY, 0, op, tmp->msg); 2425 op->statusmsg (tmp->msg, NDI_NAVY);
2426
2565 enter_exit (op, tmp); 2427 op->enter_exit (tmp);
2566 } 2428 }
2429
2430 return 1;
2431
2432 case INSCRIBABLE:
2433 op->statusmsg (tmp->msg);
2434 // maybe show a spell menu to chose from or something like that
2567 return 1; 2435 return 1;
2568 2436
2569 case SIGN: 2437 case SIGN:
2570 apply_sign (op, tmp, 0); 2438 apply_sign (op, tmp, 0);
2571 return 1; 2439 return 1;
… …
2575 { 2443 {
2576 apply_book (op, tmp); 2444 apply_book (op, tmp);
2577 return 1; 2445 return 1;
2578 } 2446 }
2579 else 2447 else
2580 {
2581 return 0; 2448 return 0;
2582 }
2583 2449
2584 case SKILLSCROLL: 2450 case SKILLSCROLL:
2585 if (op->type == PLAYER) 2451 if (op->type == PLAYER)
2586 { 2452 {
2587 apply_skillscroll (op, tmp); 2453 apply_skillscroll (op, tmp);
2588 return 1; 2454 return 1;
2589 } 2455 }
2456 else
2590 return 0; 2457 return 0;
2591 2458
2592 case SPELLBOOK: 2459 case SPELLBOOK:
2593 if (op->type == PLAYER) 2460 if (op->type == PLAYER)
2594 { 2461 {
2595 apply_spellbook (op, tmp); 2462 apply_spellbook (op, tmp);
2596 return 1; 2463 return 1;
2597 } 2464 }
2465 else
2598 return 0; 2466 return 0;
2599 2467
2600 case SCROLL: 2468 case SCROLL:
2601 apply_scroll (op, tmp, 0); 2469 apply_scroll (op, tmp, 0);
2602 return 1; 2470 return 1;
2603 2471
2604 case POTION: 2472 case POTION:
2605 (void) apply_potion (op, tmp); 2473 apply_potion (op, tmp);
2606 return 1; 2474 return 1;
2607 2475
2608 /* Eneq(@csd.uu.se): Handle apply on containers. */ 2476 /* Eneq(@csd.uu.se): Handle apply on containers. */
2477 //TODO: remove, as it is unsed?
2609 case CLOSE_CON: 2478 case CLOSE_CON:
2610 if (op->type == PLAYER)
2611 (void) esrv_apply_container (op, tmp->env);
2612 else
2613 (void) apply_container (op, tmp->env); 2479 apply_container (op, tmp->env);
2614 return 1; 2480 return 1;
2615 2481
2616 case CONTAINER: 2482 case CONTAINER:
2617 if (op->type == PLAYER)
2618 (void) esrv_apply_container (op, tmp);
2619 else
2620 (void) apply_container (op, tmp); 2483 apply_container (op, tmp);
2621 return 1; 2484 return 1;
2622 2485
2623 case TREASURE: 2486 case TREASURE:
2624 if (op->type == PLAYER) 2487 if (op->type == PLAYER)
2625 { 2488 {
2626 apply_treasure (op, tmp); 2489 apply_treasure (op, tmp);
2627 return 1; 2490 return 1;
2628 } 2491 }
2629 else 2492 else
2630 {
2631 return 0; 2493 return 0;
2632 }
2633 2494
2634 case WEAPON: 2495 case WEAPON:
2635 case ARMOUR: 2496 case ARMOUR:
2636 case BOOTS: 2497 case BOOTS:
2637 case GLOVES: 2498 case GLOVES:
… …
2650 case LAMP: 2511 case LAMP:
2651 case BUILDER: 2512 case BUILDER:
2652 case SKILL_TOOL: 2513 case SKILL_TOOL:
2653 if (tmp->env != op) 2514 if (tmp->env != op)
2654 return 2; /* not in inventory */ 2515 return 2; /* not in inventory */
2516
2655 (void) apply_special (op, tmp, aflag); 2517 apply_special (op, tmp, aflag);
2656 return 1; 2518 return 1;
2657 2519
2658 case DRINK: 2520 case DRINK:
2659 case FOOD: 2521 case FOOD:
2660 case FLESH: 2522 case FLESH:
… …
2676 } 2538 }
2677 else 2539 else
2678 return 0; 2540 return 0;
2679 2541
2680 case WEAPON_IMPROVER: 2542 case WEAPON_IMPROVER:
2681 (void) check_improve_weapon (op, tmp); 2543 check_improve_weapon (op, tmp);
2682 return 1; 2544 return 1;
2683 2545
2684 case CLOCK: 2546 case CLOCK:
2685 if (op->type == PLAYER) 2547 if (op->type == PLAYER)
2686 { 2548 {
2687 char buf[MAX_BUF]; 2549 char buf[MAX_BUF];
2688 timeofday_t tod; 2550 timeofday_t tod;
2689 2551
2690 get_tod (&tod); 2552 get_tod (&tod);
2553 op->play_sound (sound_find ("sound_clock"));
2554 op->statusmsg (format (
2691 sprintf (buf, "It is %d minute%s past %d o'clock %s", 2555 "It is %d minute%s past %d o'clock %s",
2692 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"), 2556 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"),
2693 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")); 2557 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")
2694 play_sound_player_only (op->contr, SOUND_CLOCK, 0, 0); 2558 ));
2695 new_draw_info (NDI_UNIQUE, 0, op, buf);
2696 return 1; 2559 return 1;
2697 } 2560 }
2698 else 2561 else
2699 {
2700 return 0; 2562 return 0;
2701 }
2702 2563
2703 case MENU: 2564 case MENU:
2704 if (op->type == PLAYER) 2565 if (op->type == PLAYER)
2705 { 2566 {
2706 shop_listing (op); 2567 shop_listing (tmp, op);
2707 return 1; 2568 return 1;
2708 } 2569 }
2709 else 2570 else
2710 {
2711 return 0; 2571 return 0;
2712 }
2713 2572
2714 case POWER_CRYSTAL: 2573 case POWER_CRYSTAL:
2715 apply_power_crystal (op, tmp); /* see egoitem.c */ 2574 apply_power_crystal (op, tmp); /* see egoitem.c */
2716 return 1; 2575 return 1;
2717 2576
… …
2720 { 2579 {
2721 apply_lighter (op, tmp); 2580 apply_lighter (op, tmp);
2722 return 1; 2581 return 1;
2723 } 2582 }
2724 else 2583 else
2725 {
2726 return 0; 2584 return 0;
2727 }
2728 2585
2729 case ITEM_TRANSFORMER: 2586 case ITEM_TRANSFORMER:
2730 apply_item_transformer (op, tmp); 2587 apply_item_transformer (op, tmp);
2731 return 1; 2588 return 1;
2732 2589
… …
2745int 2602int
2746player_apply (object *pl, object *op, int aflag, int quiet) 2603player_apply (object *pl, object *op, int aflag, int quiet)
2747{ 2604{
2748 int tmp; 2605 int tmp;
2749 2606
2750 if (op->env == NULL && (pl->move_type & MOVE_FLYING)) 2607 if (op->env && (pl->move_type & MOVE_FLYING))
2751 { 2608 {
2752 /* player is flying and applying object not in inventory */ 2609 /* player is flying and applying object not in inventory */
2753 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING)) 2610 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING))
2754 { 2611 {
2755 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high " "above the ground!"); 2612 op->failmsg ("But you are floating high above the ground! H<You have to stop levitating first, if you can.>");
2756 return 0; 2613 return 0;
2757 } 2614 }
2758 }
2759
2760 /* Check for PLAYER to avoid a DM to disappear in a puff of smoke if
2761 * applied.
2762 */
2763 if (op->type != PLAYER && QUERY_FLAG (op, FLAG_WAS_WIZ) && !QUERY_FLAG (pl, FLAG_WAS_WIZ))
2764 {
2765 play_sound_map (pl->map, pl->x, pl->y, SOUND_OB_EVAPORATE);
2766 new_draw_info (NDI_UNIQUE, 0, pl, "The object disappears in a puff " "of smoke!");
2767 new_draw_info (NDI_UNIQUE, 0, pl, "It must have been an illusion.");
2768 op->destroy ();
2769 return 1;
2770 } 2615 }
2771 2616
2772 pl->contr->last_used = op; 2617 pl->contr->last_used = op;
2773 2618
2774 tmp = manual_apply (pl, op, aflag); 2619 tmp = manual_apply (pl, op, aflag);
2775 if (!quiet) 2620 if (!quiet)
2776 { 2621 {
2777 if (tmp == 0) 2622 if (tmp == 0)
2778 new_draw_info_format (NDI_UNIQUE, 0, pl, "I don't know how to apply the %s.", query_name (op)); 2623 op->statusmsg (format ("I don't know how to apply the %s.", query_name (op)));
2779 else if (tmp == 2) 2624 else if (tmp == 2)
2780 new_draw_info_format (NDI_UNIQUE, 0, pl, "You must get it first!\n"); 2625 op->failmsg ("You must get it first!\n");
2781 } 2626 }
2627
2782 return tmp; 2628 return tmp;
2783} 2629}
2784 2630
2785/** 2631/**
2786 * player_apply_below attempts to apply the object 'below' the player. 2632 * player_apply_below attempts to apply the object 'below' the player.
2787 * If the player has an open container, we use that for below, otherwise 2633 * If the player has an open container, we use that for below, otherwise
2788 * we use the ground. 2634 * we use the ground.
2789 */ 2635 */
2790
2791void 2636void
2792player_apply_below (object *pl) 2637player_apply_below (object *pl)
2793{ 2638{
2794 object *tmp, *next;
2795 int floors; 2639 int floors = 0;
2796 2640
2797 /* If using a container, set the starting item to be the top 2641 /* If using a container, set the starting item to be the top
2798 * item in the container. Otherwise, use the map. 2642 * item in the container. Otherwise, use the map.
2799 */
2800 tmp = (pl->container != NULL) ? pl->container->inv : pl->below;
2801
2802 /* This is perhaps more complicated. However, I want to make sure that 2643 * This is perhaps more complicated. However, I want to make sure that
2803 * we don't use a corrupt pointer for the next object, so we get the 2644 * we don't use a corrupt pointer for the next object, so we get the
2804 * next object in the stack before applying. This is can only be a 2645 * next object in the stack before applying. This is can only be a
2805 * problem if player_apply() has a bug in that it uses the object but does 2646 * problem if player_apply() has a bug in that it uses the object but does
2806 * not return a proper value. 2647 * not return a proper value.
2807 */ 2648 */
2808 for (floors = 0; tmp != NULL; tmp = next) 2649 for (object *next, *tmp = pl->container ? pl->container->inv : pl->below; tmp; tmp = next)
2809 { 2650 {
2810 next = tmp->below; 2651 next = tmp->below;
2652
2811 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 2653 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
2812 floors++; 2654 floors++;
2813 else if (floors > 0) 2655 else if (floors > 0)
2814 return; /* process only floor objects after first floor object */ 2656 return; /* process only floor objects after first floor object */
2815 2657
… …
2835 * to keep the size of apply_special to a more managable size. 2677 * to keep the size of apply_special to a more managable size.
2836 */ 2678 */
2837static int 2679static int
2838unapply_special (object *who, object *op, int aflags) 2680unapply_special (object *who, object *op, int aflags)
2839{ 2681{
2840 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags)) || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags))) 2682 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags))
2683 || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags)))
2841 return RESULT_INT (0); 2684 return RESULT_INT (0);
2842 2685
2843 object *tmp2;
2844
2845 CLEAR_FLAG (op, FLAG_APPLIED); 2686 CLEAR_FLAG (op, FLAG_APPLIED);
2687
2846 switch (op->type) 2688 switch (op->type)
2847 { 2689 {
2690 case SKILL_TOOL:
2691 // unapplying a skill tool should also unapply the skill it governs
2692 // but this is hard, as it shouldn't do so when the skill can
2693 // be used for other reasons
2694 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2695 if (tmp->skill == op->skill
2696 && tmp->type == SKILL
2697 && tmp->flag [FLAG_APPLIED]
2698 && !tmp->flag [FLAG_CAN_USE_SKILL])
2699 unapply_special (who, tmp, 0);
2700
2701 change_abil (who, op);
2702 break;
2703
2848 case WEAPON: 2704 case WEAPON:
2849 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op)); 2705 if (player *pl = who->contr)
2706 if (op == pl->combat_ob)
2707 {
2708 pl->combat_ob = 0;
2709 who->change_weapon (pl->ranged_ob);
2710 }
2850 2711
2712 who->statusmsg (format ("You unwield %s.", query_name (op)));
2713
2851 (void) change_abil (who, op); 2714 change_abil (who, op);
2852 if (QUERY_FLAG (who, FLAG_READY_WEAPON))
2853 CLEAR_FLAG (who, FLAG_READY_WEAPON); 2715 CLEAR_FLAG (who, FLAG_READY_WEAPON);
2854 clear_skill (who);
2855 break; 2716 break;
2856 2717
2857 case SKILL: /* allows objects to impart skills */
2858 case SKILL_TOOL: 2718 case SKILL:
2859 if (op != who->chosen_skill) 2719 if (who->contr)
2860 { 2720 {
2861 LOG (llevError, "BUG: apply_special(): applied skill is not a chosen skill\n"); 2721 if (!op->invisible)
2722 who->statusmsg (format ("You stop using the %s.", query_name (op)));
2723 else
2724 who->statusmsg (format ("You can no longer use the skill: %s.", &op->skill));
2862 } 2725 }
2863 if (who->type == PLAYER) 2726
2864 {
2865 if (who->contr->shoottype == range_skill)
2866 who->contr->shoottype = range_none;
2867 if (!op->invisible)
2868 {
2869 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op));
2870 }
2871 else
2872 {
2873 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill);
2874 }
2875 }
2876 (void) change_abil (who, op); 2727 change_abil (who, op);
2877 who->chosen_skill = NULL;
2878 CLEAR_FLAG (who, FLAG_READY_SKILL); 2728 CLEAR_FLAG (who, FLAG_READY_SKILL);
2879 break; 2729 break;
2880 2730
2881 case ARMOUR: 2731 case ARMOUR:
2882 case HELMET: 2732 case HELMET:
… …
2886 case GLOVES: 2736 case GLOVES:
2887 case AMULET: 2737 case AMULET:
2888 case GIRDLE: 2738 case GIRDLE:
2889 case BRACERS: 2739 case BRACERS:
2890 case CLOAK: 2740 case CLOAK:
2891 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op)); 2741 who->statusmsg (format ("You unwear %s.", query_name (op)));
2892 (void) change_abil (who, op); 2742 change_abil (who, op);
2893 break; 2743 break;
2744
2894 case LAMP: 2745 case LAMP:
2895 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name); 2746 {
2747 who->statusmsg (format ("You turn off your %s.", &op->name));
2748
2896 tmp2 = arch_to_object (op->other_arch); 2749 object *tmp2 = arch_to_object (op->other_arch);
2897 tmp2->x = op->x; 2750 tmp2->x = op->x;
2898 tmp2->y = op->y; 2751 tmp2->y = op->y;
2899 tmp2->map = op->map; 2752 tmp2->map = op->map;
2900 tmp2->below = op->below; 2753 tmp2->below = op->below;
2901 tmp2->above = op->above; 2754 tmp2->above = op->above;
2902 tmp2->stats.food = op->stats.food; 2755 tmp2->stats.food = op->stats.food;
2903 CLEAR_FLAG (tmp2, FLAG_APPLIED); 2756 CLEAR_FLAG (tmp2, FLAG_APPLIED);
2904 2757
2905 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 2758 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
2906 SET_FLAG (tmp2, FLAG_INV_LOCKED); 2759 SET_FLAG (tmp2, FLAG_INV_LOCKED);
2907 2760
2908 if (who->type == PLAYER) 2761 if (who->contr)
2909 esrv_del_item (who->contr, op->count); 2762 esrv_del_item (who->contr, op->count);
2910 2763
2911 op->destroy (); 2764 op->destroy ();
2912 insert_ob_in_ob (tmp2, who); 2765 insert_ob_in_ob (tmp2, who);
2913 who->update_stats (); 2766 who->update_stats ();
2767
2914 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 2768 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
2915 { 2769 {
2916 if (who->type == PLAYER) 2770 if (who->contr)
2917 { 2771 {
2918 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 2772 who->failmsg ("Oops, it feels deadly cold!");
2919 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 2773 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
2920 } 2774 }
2921 } 2775 }
2922 if (who->type == PLAYER) 2776
2777 if (who->contr)
2923 esrv_send_item (who, tmp2); 2778 esrv_send_item (who, tmp2);
2779 }
2780
2924 return 1; /* otherwise, an attempt to drop causes problems */ 2781 return 1; /* otherwise, an attempt to drop causes problems */
2925 break; 2782
2926 case BOW: 2783 case BOW:
2927 case WAND: 2784 case WAND:
2928 case ROD: 2785 case ROD:
2929 case HORN: 2786 case HORN:
2930 clear_skill (who); 2787 if (player *pl = who->contr)
2931 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op));
2932 if (who->type == PLAYER)
2933 { 2788 {
2934 who->contr->shoottype = range_none; 2789 if (op == pl->ranged_ob)
2790 {
2791 pl->ranged_ob = 0;
2792 who->change_weapon (pl->combat_ob);
2793 }
2794
2795 who->statusmsg (format ("You unready %s.", query_name (op)));
2935 } 2796 }
2936 else 2797 else
2937 { 2798 {
2799 who->change_skill (0);
2800
2938 if (op->type == BOW) 2801 if (op->type == BOW)
2939 CLEAR_FLAG (who, FLAG_READY_BOW); 2802 CLEAR_FLAG (who, FLAG_READY_BOW);
2940 else 2803 else
2941 CLEAR_FLAG (who, FLAG_READY_RANGE); 2804 CLEAR_FLAG (who, FLAG_READY_RANGE);
2942 } 2805 }
2806
2943 break; 2807 break;
2944 2808
2945 case BUILDER: 2809 case BUILDER:
2946 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2810 if (who->contr)
2947 who->contr->shoottype = range_none; 2811 who->statusmsg (format ("You unready %s.", query_name (op)));
2948 who->contr->ranges[range_builder] = NULL;
2949 break; 2812 break;
2950 2813
2951 default: 2814 default:
2952 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op)); 2815 who->statusmsg (format ("You unapply %s.", query_name (op)));
2953 break; 2816 break;
2954 } 2817 }
2955 2818
2956 who->update_stats (); 2819 who->update_stats ();
2957 2820
2958 if (!(aflags & AP_NO_MERGE)) 2821 if (!(aflags & AP_NO_MERGE))
2959 { 2822 {
2960 object *tmp;
2961
2962 tmp = merge_ob (op, NULL); 2823 object *tmp = merge_ob (op, 0);
2963 if (who->type == PLAYER) 2824
2825 if (who->contr)
2964 { 2826 {
2965 if (tmp) 2827 if (tmp)
2966 { /* it was merged */ 2828 { /* it was merged */
2967 esrv_del_item (who->contr, op->count); 2829 esrv_del_item (who->contr, op->count);
2968 op = tmp; 2830 op = tmp;
2969 } 2831 }
2970 2832
2971 esrv_send_item (who, op); 2833 esrv_send_item (who, op);
2972 } 2834 }
2973 } 2835 }
2836
2974 return 0; 2837 return 0;
2975} 2838}
2976 2839
2977/** 2840/**
2978 * Returns the object that is using location 'loc'. 2841 * Returns the object that is using location 'loc'.
2979 * Note that 'start' is the first object to start examing - we 2842 * Note that 'start' is the first object to start examing - we
2980 * then go through the below of this. In this way, you can do 2843 * then go through the below of this. In this way, you can do
2981 * something like: 2844 * something like:
2982 * tmp = get_item_from_body_location(who->inv, 1); 2845 * tmp = get_next_item_from_body_location(who->inv, 1);
2983 * if (tmp) tmp1 = get_item_from_body_location(tmp->below, 1); 2846 * if (tmp) tmp1 = get_next_item_from_body_location(tmp->below, 1);
2984 * to find the second object that may use this location, etc. 2847 * to find the second object that may use this location, etc.
2985 * Returns NULL if no match is found. 2848 * Returns NULL if no match is found.
2986 * loc is the index into the array we are looking for a match. 2849 * loc is the index into the array we are looking for a match.
2987 * don't return invisible objects unless they are skill objects 2850 * don't return invisible objects unless they are skill objects
2988 * invisible other objects that use 2851 * invisible other objects that use
2989 * up body locations can be used as restrictions. 2852 * up body locations can be used as restrictions.
2990 */ 2853 */
2991object * 2854static object *
2992get_item_from_body_location (object *start, int loc) 2855get_next_item_from_body_location (int loc, object *start)
2993{ 2856{
2994 object *tmp;
2995
2996 if (!start)
2997 return NULL;
2998
2999 for (tmp = start; tmp; tmp = tmp->below) 2857 for (object *tmp = start; tmp; tmp = tmp->below)
3000 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->body_info[loc] && (!tmp->invisible || tmp->type == SKILL)) 2858 if (tmp->flag [FLAG_APPLIED]
2859 && tmp->slot[loc].info
2860 && (!tmp->invisible || tmp->type == SKILL))
3001 return tmp; 2861 return tmp;
3002 2862
3003 return NULL; 2863 return 0;
3004} 2864}
3005
3006
3007 2865
3008/** 2866/**
3009 * 'op' wants to apply an object, but can't because of other equipment. 2867 * 'op' wants to apply an object, but can't because of other equipment.
3010 * This should only be called when it is known 2868 * This should only be called when it is known
3011 * that there are objects to unapply. This makes pretty heavy 2869 * that there are objects to unapply. This makes pretty heavy
… …
3014 * Returns 0 on success, returns 1 if there is some problem. 2872 * Returns 0 on success, returns 1 if there is some problem.
3015 * if aflags is AP_PRINT, we instead print out waht to unapply 2873 * if aflags is AP_PRINT, we instead print out waht to unapply
3016 * instead of doing it. This is a lot less code than having 2874 * instead of doing it. This is a lot less code than having
3017 * another function that does just that. 2875 * another function that does just that.
3018 */ 2876 */
2877
2878#define CANNOT_REMOVE_CURSED \
2879 "H<You cannot remove cursed or damned items, you first have to remove the curse. " \
2880 "Praying over an altar, scrolls of remove curse/damnation, " \
2881 "priests or even other players might help.>"
2882
3019int 2883int
3020unapply_for_ob (object *who, object *op, int aflags) 2884unapply_for_ob (object *who, object *op, int aflags)
3021{ 2885{
3022 int i; 2886 if (op->is_range ())
3023 object *tmp = NULL, *last;
3024
3025 /* If we are applying a shield or weapon, unapply any equipped shield
3026 * or weapons first - only allowed to use one weapon/shield at a time.
3027 */
3028 if (op->type == WEAPON || op->type == SHIELD)
3029 {
3030 for (tmp = who->inv; tmp; tmp = tmp->below) 2887 for (object *tmp = who->inv; tmp; tmp = tmp->below)
3031 {
3032 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2888 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ())
3033 {
3034 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))) 2889 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)))
3035 { 2890 {
3036 if (aflags & AP_PRINT) 2891 if (aflags & AP_PRINT)
3037 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2892 who->failmsg (query_name (tmp));
3038 else 2893 else
3039 unapply_special (who, tmp, aflags); 2894 unapply_special (who, tmp, aflags);
3040 } 2895 }
3041 else 2896 else
3042 { 2897 {
3043 /* In this case, we want to try and remove a cursed item. 2898 /* In this case, we want to try and remove a cursed item.
3044 * While we know it won't work, we want unapply_special to 2899 * While we know it won't work, we want unapply_special to
3045 * at least generate the message. 2900 * at least generate the message.
3046 */ 2901 */
3047 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (tmp)); 2902 who->failmsg (format ("No matter how hard you try, you just can't remove the %s." CANNOT_REMOVE_CURSED, query_name (tmp)));
3048 return 1; 2903 return 1;
3049 }
3050
3051 } 2904 }
3052 }
3053 }
3054 2905
3055 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 2906 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3056 { 2907 {
3057 /* this used up a slot that we need to free */ 2908 /* this used up a slot that we need to free */
3058 if (op->body_info[i]) 2909 if (op->slot[i].info)
3059 { 2910 {
3060 last = who->inv; 2911 object *last = who->inv;
3061 2912
3062 /* We do a while loop - may need to remove several items in order 2913 /* We do a while loop - may need to remove several items in order
3063 * to free up enough slots. 2914 * to free up enough slots.
3064 */ 2915 */
3065 while ((who->body_used[i] + op->body_info[i]) < 0) 2916 while ((who->slot[i].used + op->slot[i].info) < 0)
3066 { 2917 {
3067 tmp = get_item_from_body_location (last, i); 2918 object *tmp = get_next_item_from_body_location (i, last);
2919
3068 if (!tmp) 2920 if (!tmp)
3069 { 2921 {
3070#if 0 2922#if 0
3071 /* Not a bug - we'll get this if the player has cursed items 2923 /* Not a bug - we'll get this if the player has cursed items
3072 * equipped. 2924 * equipped.
3073 */ 2925 */
3074 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name); 2926 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name);
3075#endif 2927#endif
3076 return 1; 2928 return 1;
3077 } 2929 }
2930
3078 /* If we are just printing, we don't care about cursed status */ 2931 /* If we are just printing, we don't care about cursed status */
3079 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)))) 2932 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))))
3080 { 2933 {
3081 if (aflags & AP_PRINT) 2934 if (aflags & AP_PRINT)
3082 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2935 who->failmsg (query_name (tmp));
3083 else 2936 else
3084 unapply_special (who, tmp, aflags); 2937 unapply_special (who, tmp, aflags);
3085 } 2938 }
3086 else 2939 else
3087 { 2940 {
3088 /* Cursed item that we can't unequip - tell the player. 2941 /* Cursed item that we can't unequip - tell the player.
3089 * Note this could be annoying if this is just one of a few, 2942 * Note this could be annoying if this is just one of a few,
3090 * so it may not be critical (eg, putting on a ring and you have 2943 * so it may not be critical (eg, putting on a ring and you have
3091 * one cursed ring.) 2944 * one cursed ring.)
3092 */ 2945 */
3093 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s just won't come off", query_name (tmp)); 2946 who->failmsg (format ("The %s just won't come off." CANNOT_REMOVE_CURSED, query_name (tmp)));
3094 } 2947 }
2948
3095 last = tmp->below; 2949 last = tmp->below;
3096 } 2950 }
3097 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the 2951 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the
3098 * return in the !tmp would have kicked in. 2952 * return in the !tmp would have kicked in.
3099 */ 2953 */
3100 } /* if op is using this body location */ 2954 } /* if op is using this body location */
3101 } /* for body lcoations */ 2955 } /* for body lcoations */
2956
3102 return 0; 2957 return 0;
3103} 2958}
3104 2959
3105/** 2960/**
3106 * Checks to see if 'who' can apply object 'op'. 2961 * Checks to see if 'who' can apply object 'op'.
3107 * Returns 0 if apply can be done without anything special. 2962 * Returns 0 if apply can be done without anything special.
3108 * Otherwise returns a bitmask - potentially several of these may be 2963 * Otherwise returns a bitmask - potentially several of these may be
3109 * set, but largely depends on circumstance - in the future, processing 2964 * set, but largely depends on circumstance - in the future, processing
3110 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER 2965 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER
3111 * is set, do we really are what the other flags may be?) 2966 * is set, do we really care what the other flags may be?)
3112 * 2967 *
3113 * See include/define.h for detailed description of the meaning of 2968 * See include/define.h for detailed description of the meaning of
3114 * these return values. 2969 * these return values.
3115 */ 2970 */
3116int 2971int
3117can_apply_object (object *who, object *op) 2972can_apply_object (object *who, object *op)
3118{ 2973{
3119 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op))) 2974 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op)))
3120 return RESULT_INT (0); 2975 return RESULT_INT (0);
3121 2976
3122 int i, retval = 0; 2977 int retval = 0;
3123 object *tmp = NULL, *ws = NULL; 2978 object *tmp = 0, *ws = 0;
3124 2979
3125 /* Players have 2 'arm's, so they could in theory equip 2 shields or 2980 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3126 * 2 weapons, but we don't want to let them do that. So if they are
3127 * trying to equip a weapon or shield, see if they already have one
3128 * in place and store that way.
3129 */
3130 if (op->type == WEAPON || op->type == SHIELD)
3131 { 2981 {
3132 for (tmp = who->inv; tmp && !ws; tmp = tmp->below) 2982 if (op->slot[i].info)
3133 { 2983 {
3134 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2984 /* Item uses more slots than we have */
2985 if (who->slot[i].info + op->slot [i].info < 0)
3135 { 2986 {
3136 retval = CAN_APPLY_UNAPPLY;
3137 ws = tmp;
3138 }
3139 }
3140 }
3141
3142
3143 for (i = 0; i < NUM_BODY_LOCATIONS; i++)
3144 {
3145 if (op->body_info[i])
3146 {
3147 /* Item uses more slots than we have */
3148 if (FABS (op->body_info[i]) > who->body_info[i])
3149 {
3150 /* Could return now for efficiently - rest of info below isn' 2987 /* Could return now for efficiency - rest of info below isn't
3151 * really needed. 2988 * really needed.
3152 */ 2989 */
3153 retval |= CAN_APPLY_NEVER; 2990 retval |= CAN_APPLY_NEVER;
3154 } 2991 }
3155 else if ((who->body_used[i] + op->body_info[i]) < 0) 2992 else if (who->slot[i].used + op->slot[i].info < 0)
3156 { 2993 {
3157 /* in this case, equipping this would use more free spots than 2994 /* in this case, equipping this would use more free spots than
3158 * we have. 2995 * we have.
3159 */ 2996 */
3160 object *tmp1;
3161
3162 2997
3163 /* if we have an applied weapon/shield, and unapply it would free 2998 /* if we have an applied weapon/shield, and unapply it would free
3164 * enough slots to equip the new item, then just set this can 2999 * enough slots to equip the new item, then just set "can
3165 * continue. We don't care about the logic below - if you have 3000 * apply unapply". We don't care about the logic below - if you have a
3166 * shield equipped and try to equip another shield, there is only 3001 * shield equipped and try to equip another shield, there is only
3167 * one choice. However, the check for the number of body locations 3002 * one choice. However, the check for the number of body locations
3168 * does take into the account cases where what is being applied 3003 * does take into the account cases where what is being applied
3169 * may be two handed for example. 3004 * may be two handed for example.
3170 */ 3005 */
3171 if (ws) 3006 if (ws)
3172 { 3007 if ((who->slot[i].used - ws->slot[i].info + op->slot[i].info) >= 0)
3173 if ((who->body_used[i] - ws->body_info[i] + op->body_info[i]) >= 0)
3174 { 3008 {
3175 retval |= CAN_APPLY_UNAPPLY; 3009 retval |= CAN_APPLY_UNAPPLY;
3176 continue; 3010 continue;
3177 } 3011 }
3178 }
3179 3012
3180 tmp1 = get_item_from_body_location (who->inv, i); 3013 object *tmp1 = get_next_item_from_body_location (i, who->inv);
3181 if (!tmp1) 3014 if (!tmp1)
3182 { 3015 {
3183#if 0 3016#if 0
3184 /* This is sort of an error, but happens a lot when old players 3017 /* This is sort of an error, but happens a lot when old players
3185 * join in with more stuff equipped than they are now allowed. 3018 * join in with more stuff equipped than they are now allowed.
… …
3193 /* need to unapply something. However, if this something 3026 /* need to unapply something. However, if this something
3194 * is different than we had found before, it means they need 3027 * is different than we had found before, it means they need
3195 * to apply multiple objects 3028 * to apply multiple objects
3196 */ 3029 */
3197 retval |= CAN_APPLY_UNAPPLY; 3030 retval |= CAN_APPLY_UNAPPLY;
3031
3198 if (!tmp) 3032 if (!tmp)
3199 tmp = tmp1; 3033 tmp = tmp1;
3200 else if (tmp != tmp1) 3034 else if (tmp != tmp1)
3201 {
3202 retval |= CAN_APPLY_UNAPPLY_MULT; 3035 retval |= CAN_APPLY_UNAPPLY_MULT;
3203 } 3036
3204 /* This object isn't using up all the slots, so there must 3037 /* This object isn't using up all the slots, so there must
3205 * be another. If so, and it the new item doesn't need all 3038 * be another. If so, and it the new item doesn't need all
3206 * the slots, the player then has a choice. 3039 * the slots, the player then has a choice.
3207 */ 3040 */
3208 if (((who->body_used[i] - tmp1->body_info[i]) != who->body_info[i]) && (FABS (op->body_info[i]) < who->body_info[i])) 3041 if ((who->slot[i].used - tmp1->slot[i].info != who->slot[i].info)
3042 && abs (op->slot[i].info) < who->slot[i].info)
3209 retval |= CAN_APPLY_UNAPPLY_CHOICE; 3043 retval |= CAN_APPLY_UNAPPLY_CHOICE;
3210 3044
3211 /* Does unequippint 'tmp1' free up enough slots for this to be 3045 /* Does unequippint 'tmp1' free up enough slots for this to be
3212 * equipped? If not, there must be something else to unapply. 3046 * equipped? If not, there must be something else to unapply.
3213 */ 3047 */
3214 if ((who->body_used[i] + op->body_info[i] - tmp1->body_info[i]) < 0) 3048 if (who->slot[i].used + op->slot[i].info < tmp1->slot[i].info)
3215 retval |= CAN_APPLY_UNAPPLY_MULT; 3049 retval |= CAN_APPLY_UNAPPLY_MULT;
3216
3217 } 3050 }
3218 } /* if not enough free slots */ 3051 } /* if not enough free slots */
3219 } /* if this object uses location i */ 3052 } /* if this object uses location i */
3220 } /* for i -> num_body_locations loop */ 3053 } /* for i -> num_body_locations loop */
3221 3054
… …
3226 * and weapons all use the same slot. Similar for horn/rod/wand - they 3059 * and weapons all use the same slot. Similar for horn/rod/wand - they
3227 * all use the same location. 3060 * all use the same location.
3228 */ 3061 */
3229 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON)) 3062 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON))
3230 retval |= CAN_APPLY_RESTRICTION; 3063 retval |= CAN_APPLY_RESTRICTION;
3064
3231 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD)) 3065 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD))
3232 retval |= CAN_APPLY_RESTRICTION; 3066 retval |= CAN_APPLY_RESTRICTION;
3233 3067
3234
3235 if (who->type != PLAYER) 3068 if (who->type != PLAYER)
3236 { 3069 {
3237 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE)) 3070 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE))
3238 retval |= CAN_APPLY_RESTRICTION; 3071 retval |= CAN_APPLY_RESTRICTION;
3072
3239 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3073 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3240 retval |= CAN_APPLY_RESTRICTION; 3074 retval |= CAN_APPLY_RESTRICTION;
3075
3241 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING)) 3076 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING))
3242 retval |= CAN_APPLY_RESTRICTION; 3077 retval |= CAN_APPLY_RESTRICTION;
3078
3243 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3079 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3244 retval |= CAN_APPLY_RESTRICTION; 3080 retval |= CAN_APPLY_RESTRICTION;
3245 } 3081 }
3082
3246 return retval; 3083 return retval;
3247} 3084}
3248
3249
3250 3085
3251/** 3086/**
3252 * who is the object using the object. It can be a monster. 3087 * who is the object using the object. It can be a monster.
3253 * op is the object they are using. op is an equipment type item, 3088 * op is the object they are using. op is an equipment type item,
3254 * eg, one which you put on and keep on for a while, and not something 3089 * eg, one which you put on and keep on for a while, and not something
… …
3263 * AP_UNAPPLY=always unapply). 3098 * AP_UNAPPLY=always unapply).
3264 * 3099 *
3265 * Optional flags: 3100 * Optional flags:
3266 * AP_NO_MERGE: don't merge an unapplied object with other objects 3101 * AP_NO_MERGE: don't merge an unapplied object with other objects
3267 * AP_IGNORE_CURSE: unapply cursed items 3102 * AP_IGNORE_CURSE: unapply cursed items
3103 * AP_NO_READY: do not ready skills when applying skill tools
3268 * 3104 *
3269 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE) 3105 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE)
3270 * 3106 *
3271 * apply_special() doesn't check for unpaid items. 3107 * apply_special() doesn't check for unpaid items.
3272 */ 3108 */
3109
3110#define LACK_ITEM_POWER \
3111 " H<You lack enough unused item power to use this weapon, see the skills command.>"
3112
3273int 3113int
3274apply_special (object *who, object *op, int aflags) 3114apply_special (object *who, object *op, int aflags)
3275{ 3115{
3276 int basic_flag = aflags & AP_BASIC_FLAGS; 3116 int basic_flag = aflags & AP_BASIC_FLAGS;
3277 object *tmp, *tmp2, *skop = NULL; 3117 object *tmp, *tmp2, *skop = NULL;
3278 int i;
3279 3118
3280 if (who == NULL) 3119 if (who == NULL)
3281 { 3120 {
3282 LOG (llevError, "apply_special() from object without environment.\n"); 3121 LOG (llevError, "apply_special() from object without environment.\n");
3283 return 1; 3122 return 1;
… …
3293 if (basic_flag == AP_APPLY) 3132 if (basic_flag == AP_APPLY)
3294 return 0; 3133 return 0;
3295 3134
3296 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))) 3135 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)))
3297 { 3136 {
3298 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (op)); 3137 who->failmsg (format ("No matter how hard you try, you just can't remove %s." CANNOT_REMOVE_CURSED, query_name (op)));
3299 return 1; 3138 return 1;
3300 } 3139 }
3140
3301 return unapply_special (who, op, aflags); 3141 return unapply_special (who, op, aflags);
3302 } 3142 }
3303 3143
3304 if (basic_flag == AP_UNAPPLY) 3144 if (basic_flag == AP_UNAPPLY)
3305 return 0; 3145 return 0;
3306 3146
3307 i = can_apply_object (who, op); 3147 // if the item is combat/ranged, wield the relevant slot first
3148 // to resolve conflicts.
3149 if (player *pl = who->contr)
3150 switch (op->slottype ())
3151 {
3152 case slot_combat: who->change_weapon (pl->combat_ob); break;
3153 case slot_ranged: who->change_weapon (pl->ranged_ob); break;
3154 }
3155
3156 splay (op);
3308 3157
3309 /* Can't just apply this object. Lets see what not and what to do */ 3158 /* Can't just apply this object. Lets see what not and what to do */
3310 if (i) 3159 if (int i = can_apply_object (who, op))
3311 { 3160 {
3312 if (i & CAN_APPLY_NEVER) 3161 if (i & CAN_APPLY_NEVER)
3313 { 3162 {
3314 new_draw_info_format (NDI_UNIQUE, 0, who, "You don't have the body to use a %s\n", query_name (op)); 3163 who->failmsg (format ("You don't have the body to use a %s. H<You can never apply this item.>", query_name (op)));
3315 return 1; 3164 return 1;
3316 } 3165 }
3317 else if (i & CAN_APPLY_RESTRICTION) 3166 else if (i & CAN_APPLY_RESTRICTION)
3318 { 3167 {
3319 new_draw_info_format (NDI_UNIQUE, 0, who, "You have a prohibition against using a %s\n", query_name (op)); 3168 who->failmsg (format (
3169 "You have a prohibition against using a %s. "
3170 "H<Your belief, profession or class prevents you from applying this item.>",
3171 query_name (op)
3172 ));
3320 return 1; 3173 return 1;
3321 } 3174 }
3175
3322 if (who->type != PLAYER) 3176 if (who->type != PLAYER)
3323 { 3177 {
3324 /* Some error, so don't try to equip something more */ 3178 /* Some error, so don't try to equip something more */
3325 if (unapply_for_ob (who, op, aflags)) 3179 if (unapply_for_ob (who, op, aflags))
3326 return 1; 3180 return 1;
3327 } 3181 }
3328 else 3182 else
3329 { 3183 {
3330 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice)) 3184 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice))
3331 { 3185 {
3332 new_draw_info (NDI_UNIQUE, 0, who, "You need to unapply some item(s):"); 3186 who->failmsg ("You need to unapply some of the following item(s) or change your applymode:");
3333 unapply_for_ob (who, op, AP_PRINT); 3187 unapply_for_ob (who, op, AP_PRINT);
3334 return 1; 3188 return 1;
3335 } 3189 }
3336 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE)) 3190 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE))
3337 {
3338 i = unapply_for_ob (who, op, aflags); 3191 if (unapply_for_ob (who, op, aflags))
3339 if (i)
3340 return 1; 3192 return 1;
3341 } 3193 }
3342 }
3343 } 3194 }
3195
3344 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL) 3196 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL)
3345 { 3197 {
3346 skop = find_skill_by_name (who, op->skill); 3198 skop = find_skill_by_name (who, op->skill);
3199
3347 if (!skop) 3200 if (!skop)
3348 { 3201 {
3349 new_draw_info_format (NDI_UNIQUE, 0, who, "You need the %s skill to use this item!", &op->skill); 3202 who->failmsg (format ("You need the %s skill to use this item!", &op->skill));
3350 return 1; 3203 return 1;
3351 } 3204 }
3352 else 3205 else
3353 {
3354 /* While experience will be credited properly, we want to change the 3206 /* While experience will be credited properly, we want to change the
3355 * skill so that the dam and wc get updated 3207 * skill so that the dam and wc get updated
3356 */ 3208 */
3357 change_skill (who, skop, 0); 3209 who->change_skill (skop);
3358 }
3359 }
3360
3361 if (who->type == PLAYER && op->item_power && (op->item_power + who->contr->item_power) > (settings.item_power_factor * who->level))
3362 { 3210 }
3363 new_draw_info (NDI_UNIQUE, 0, who, "Equipping that combined with other items would consume your soul!"); 3211
3212 if (who->type == PLAYER
3213 && op->item_power
3214 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level)
3215 {
3216 who->failmsg ("Equipping that combined with other items would consume your soul!" LACK_ITEM_POWER);
3364 return 1; 3217 return 1;
3365 } 3218 }
3366
3367 3219
3368 /* Ok. We are now at the state where we can apply the new object. 3220 /* Ok. We are now at the state where we can apply the new object.
3369 * Note that we don't have the checks for can_use_... 3221 * Note that we don't have the checks for can_use_...
3370 * below - that is already taken care of by can_apply_object. 3222 * below - that is already taken care of by can_apply_object.
3371 */ 3223 */
3372
3373
3374 if (op->nrof > 1) 3224 if (op->nrof > 1)
3375 tmp = get_split_ob (op, op->nrof - 1); 3225 tmp = get_split_ob (op, op->nrof - 1);
3376 else 3226 else
3377 tmp = NULL; 3227 tmp = 0;
3378 3228
3379 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op))) 3229 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op)))
3380 return RESULT_INT (0); 3230 return RESULT_INT (0);
3381 3231
3382 switch (op->type) 3232 switch (op->type)
3383 { 3233 {
3384 case WEAPON: 3234 case WEAPON:
3385 if (!check_weapon_power (who, op->last_eat)) 3235 if (!check_weapon_power (who, op->last_eat))
3386 { 3236 {
3387 new_draw_info (NDI_UNIQUE, 0, who, "That weapon is too powerful for you to use."); 3237 op->failmsg ("This weapon is too powerful for you to use. It would consume your soul!." LACK_ITEM_POWER);
3388 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3238
3389 if (tmp != NULL) 3239 if (tmp)
3390 (void) insert_ob_in_ob (tmp, who); 3240 insert_ob_in_ob (tmp, who);
3241
3391 return 1; 3242 return 1;
3392 } 3243 }
3244
3245 //TODO: this obviously fails for players using a shorter prefix
3246 // i.e. "R" can use Ragnarok's sword.
3393 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3247 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3394 { 3248 {
3395 /* if the weapon does not have the name as the character, can't use it. */ 3249 /* if the weapon does not have the name as the character, can't use it. */
3396 /* (Ragnarok's sword attempted to be used by Foo: won't work) */ 3250 /* (Ragnarok's sword attempted to be used by Foo: won't work) */
3397 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3251 who->failmsg ("The weapon does not recognize you as its owner. H<Its name indicates that it belongs to somebody else.>");
3252
3398 if (tmp != NULL) 3253 if (tmp)
3399 (void) insert_ob_in_ob (tmp, who); 3254 insert_ob_in_ob (tmp, who);
3255
3400 return 1; 3256 return 1;
3401 } 3257 }
3258
3259 if (!skop)
3260 {
3261 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3262 return 1;
3263 }
3264
3402 SET_FLAG (op, FLAG_APPLIED); 3265 SET_FLAG (op, FLAG_APPLIED);
3403
3404 if (skop)
3405 change_skill (who, skop, 1); 3266 who->change_skill (skop);
3406 if (!QUERY_FLAG (who, FLAG_READY_WEAPON)) 3267
3268 if (who->contr)
3269 who->change_weapon (who->contr->combat_ob = op);
3270
3271 who->statusmsg (format ("You wield %s.", query_name (op)));
3272
3407 SET_FLAG (who, FLAG_READY_WEAPON); 3273 SET_FLAG (who, FLAG_READY_WEAPON);
3408
3409 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op));
3410
3411 (void) change_abil (who, op); 3274 change_abil (who, op);
3412 break; 3275 break;
3413 3276
3414 case ARMOUR: 3277 case ARMOUR:
3415 case HELMET: 3278 case HELMET:
3416 case SHIELD: 3279 case SHIELD:
… …
3420 case BRACERS: 3283 case BRACERS:
3421 case CLOAK: 3284 case CLOAK:
3422 case RING: 3285 case RING:
3423 case AMULET: 3286 case AMULET:
3424 SET_FLAG (op, FLAG_APPLIED); 3287 SET_FLAG (op, FLAG_APPLIED);
3425 new_draw_info_format (NDI_UNIQUE, 0, who, "You wear %s.", query_name (op)); 3288 who->statusmsg (format ("You wear %s.", query_name (op)));
3426 (void) change_abil (who, op); 3289 change_abil (who, op);
3427 break; 3290 break;
3291
3428 case LAMP: 3292 case LAMP:
3429 if (op->stats.food < 1) 3293 if (op->stats.food < 1)
3430 { 3294 {
3431 new_draw_info_format (NDI_UNIQUE, 0, who, "Your %s is out of" " fuel!", &op->name); 3295 who->failmsg (format (
3296 "Your %s is out of fuel! "
3297 "H<Lamps and similar items need fuel. They cannot be refilled.>",
3298 &op->name
3299 ));
3432 return 1; 3300 return 1;
3433 } 3301 }
3434 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn on your %s.", &op->name); 3302
3303 who->statusmsg (format ("You turn on your %s.", &op->name));
3304
3435 tmp2 = arch_to_object (op->other_arch); 3305 tmp2 = arch_to_object (op->other_arch);
3436 tmp2->stats.food = op->stats.food; 3306 tmp2->stats.food = op->stats.food;
3437 SET_FLAG (tmp2, FLAG_APPLIED); 3307 SET_FLAG (tmp2, FLAG_APPLIED);
3308
3438 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 3309 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
3439 SET_FLAG (tmp2, FLAG_INV_LOCKED); 3310 SET_FLAG (tmp2, FLAG_INV_LOCKED);
3311
3440 insert_ob_in_ob (tmp2, who); 3312 insert_ob_in_ob (tmp2, who);
3441 3313
3442 /* Remove the old lantern */ 3314 /* Remove the old lantern */
3443 if (who->type == PLAYER) 3315 if (who->type == PLAYER)
3444 esrv_del_item (who->contr, op->count); 3316 esrv_del_item (who->contr, op->count);
3445 3317
3446 op->destroy (); 3318 op->destroy ();
3447 3319
3448 /* insert the portion that was split off */ 3320 /* insert the portion that was split off */
3449 if (tmp != NULL) 3321 if (tmp)
3450 { 3322 {
3451 (void) insert_ob_in_ob (tmp, who); 3323 insert_ob_in_ob (tmp, who);
3452 if (who->type == PLAYER) 3324 if (who->type == PLAYER)
3453 esrv_send_item (who, tmp); 3325 esrv_send_item (who, tmp);
3454 } 3326 }
3327
3455 who->update_stats (); 3328 who->update_stats ();
3329
3456 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3330 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3457 {
3458 if (who->type == PLAYER) 3331 if (who->type == PLAYER)
3459 { 3332 {
3460 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3333 who->failmsg ("Oops, it feels deadly cold! H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>");
3461 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 3334 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
3462 } 3335 }
3463 } 3336
3464 if (who->type == PLAYER) 3337 if (who->type == PLAYER)
3465 esrv_send_item (who, tmp2); 3338 esrv_send_item (who, tmp2);
3339
3466 return 0; 3340 return 0;
3341
3342 case SKILL_TOOL:
3343 // applying a skill tool also readies the skill
3344 SET_FLAG (op, FLAG_APPLIED);
3345
3346 if (!(aflags & AP_NO_READY))
3347 {
3348 skop = find_skill_by_name (who, op->skill);
3349 if (!skop->flag [FLAG_APPLIED])
3350 apply_special (who, skop, AP_APPLY);
3351 }
3467 break; 3352 break;
3468 3353
3469 /* this part is needed for skill-tools */
3470 case SKILL: 3354 case SKILL:
3471 case SKILL_TOOL: 3355 if (player *pl = who->contr)
3472 if (who->chosen_skill)
3473 { 3356 {
3474 LOG (llevError, "BUG: apply_special(): can't apply two skills\n"); 3357 if (IS_COMBAT_SKILL (op->subtype))
3475 return 1;
3476 }
3477 if (who->type == PLAYER)
3478 { 3358 {
3479 who->contr->shoottype = range_skill; 3359 if (skill_flags [op->subtype] & SF_NEED_WEAPON)
3480 who->contr->ranges[range_skill] = op; 3360 {
3361 for (object *item = who->inv; item; item = item->below)
3362 if (item->type == WEAPON && item->flag [FLAG_APPLIED])
3363 {
3364 if (item->skill == op->skill)
3365 {
3366 who->change_weapon (pl->combat_ob = item);
3367 goto found_weapon;
3368 }
3369 }
3370
3371 who->failmsg (format (
3372 "You need to apply a '%s' melee weapon before readying this skill. "
3373 "H<Some skills need an item, in this case a melee weapon, to function.>",
3374 &op->skill
3375 ));
3376 return 1;
3377
3378 found_weapon:;
3379 }
3380 else
3381 who->change_weapon (pl->combat_ob = op);
3382 }
3383 else if (IS_RANGED_SKILL (op->subtype))
3384 {
3385 if (skill_flags [op->subtype] & SF_NEED_BOW)
3386 {
3387 for (object *item = who->inv; item; item = item->below)
3388 if (item->type == BOW && item->flag [FLAG_APPLIED])
3389 {
3390 //TODO: bows should/must all have skill missile weapon right now
3391 who->change_weapon (pl->ranged_ob = item);
3392 goto found_bow;
3393 }
3394
3395 who->failmsg (
3396 "You need to apply a missile weapon before readying this skill. "
3397 "H<Some skills need an item, in this case a missile weapon, to function.>"
3398 );
3399 return 1;
3400
3401 found_bow:;
3402 }
3403 else
3404 who->change_weapon (pl->ranged_ob = op);
3405 }
3406
3481 if (!op->invisible) 3407 if (!op->invisible)
3482 { 3408 {
3483 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3409 who->statusmsg (format (
3484 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill); 3410 "You ready %s."
3411 "You can now use the skill: %s.",
3412 query_name (op),
3413 &op->skill
3414 ));
3485 } 3415 }
3486 else 3416 else
3487 {
3488 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name); 3417 who->statusmsg (format ("Readied skill: %s.", op->skill ? &op->skill : &op->name));
3489 }
3490 } 3418 }
3419 else
3420 {
3491 SET_FLAG (op, FLAG_APPLIED); 3421 SET_FLAG (op, FLAG_APPLIED);
3492 (void) change_abil (who, op); 3422 change_abil (who, op);
3493 who->chosen_skill = op; 3423 who->chosen_skill = op;
3494 SET_FLAG (who, FLAG_READY_SKILL); 3424 SET_FLAG (who, FLAG_READY_SKILL);
3425 }
3426
3495 break; 3427 break;
3496 3428
3497 case BOW: 3429 case BOW:
3498 if (!check_weapon_power (who, op->last_eat)) 3430 if (!check_weapon_power (who, op->last_eat))
3499 { 3431 {
3500 new_draw_info (NDI_UNIQUE, 0, who, "That item is too powerful for you to use."); 3432 who->failmsg ("That weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3501 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3433
3502 if (tmp != NULL) 3434 if (tmp)
3503 (void) insert_ob_in_ob (tmp, who); 3435 insert_ob_in_ob (tmp, who);
3436
3504 return 1; 3437 return 1;
3505 } 3438 }
3439
3506 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3440 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3507 { 3441 {
3508 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3442 who->failmsg ("The weapon does not recognize you as its owner. "
3443 "H<Its name indicates that it belongs to somebody else.>");
3509 if (tmp != NULL) 3444 if (tmp)
3510 (void) insert_ob_in_ob (tmp, who); 3445 insert_ob_in_ob (tmp, who);
3446
3511 return 1; 3447 return 1;
3512 } 3448 }
3449
3513 /*FALLTHROUGH*/ case WAND: 3450 /*FALLTHROUGH*/
3451 case WAND:
3514 case ROD: 3452 case ROD:
3515 case HORN: 3453 case HORN:
3516 /* check for skill, alter player status */ 3454 /* check for skill, alter player status */
3455
3456 if (!skop)
3457 {
3458 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3459 return 1;
3460 }
3461
3517 SET_FLAG (op, FLAG_APPLIED); 3462 SET_FLAG (op, FLAG_APPLIED);
3518 if (skop)
3519 change_skill (who, skop, 0); 3463 who->change_skill (skop);
3520 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op));
3521 3464
3522 if (who->type == PLAYER) 3465 if (who->contr)
3523 { 3466 {
3467 who->contr->ranged_ob = op;
3468
3469 who->statusmsg (format ("You ready %s.", query_name (op)));
3470
3524 if (op->type == BOW) 3471 if (op->type == BOW)
3525 { 3472 {
3473 who->current_weapon = op;
3526 (void) change_abil (who, op); 3474 change_abil (who, op);
3527 new_draw_info_format (NDI_UNIQUE, 0, who,
3528 "You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)); 3475 who->statusmsg (format ("You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)));
3529 who->contr->shoottype = range_bow;
3530 }
3531 else
3532 {
3533 who->contr->shoottype = range_misc;
3534 } 3476 }
3535 } 3477 }
3536 else 3478 else
3537 { 3479 {
3538 if (op->type == BOW) 3480 if (op->type == BOW)
3539 SET_FLAG (who, FLAG_READY_BOW); 3481 SET_FLAG (who, FLAG_READY_BOW);
3540 else 3482 else
3541 SET_FLAG (who, FLAG_READY_RANGE); 3483 SET_FLAG (who, FLAG_READY_RANGE);
3542 } 3484 }
3485
3543 break; 3486 break;
3544 3487
3545 case BUILDER: 3488 case BUILDER:
3546 if (who->contr->ranges[range_builder]) 3489 if (who->type == PLAYER)
3490 {
3491 //TODO: wtf does this do? shouldn't this be managed automatically (slots?)
3492 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER)
3547 unapply_special (who, who->contr->ranges[range_builder], 0); 3493 unapply_special (who, who->contr->ranged_ob, 0);
3548 who->contr->shoottype = range_builder; 3494
3495 who->statusmsg (format ("You ready your %s.", query_name (op)));
3496
3549 who->contr->ranges[range_builder] = op; 3497 who->contr->ranged_ob = op;
3550 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op)); 3498 }
3551 break; 3499 break;
3552 3500
3553 default: 3501 default:
3554 new_draw_info_format (NDI_UNIQUE, 0, who, "You apply %s.", query_name (op)); 3502 who->statusmsg (format ("You apply %s.", query_name (op)));
3555 } /* end of switch op->type */ 3503 }
3556 3504
3557 SET_FLAG (op, FLAG_APPLIED); 3505 SET_FLAG (op, FLAG_APPLIED);
3558 3506
3559 if (tmp != NULL) 3507 if (tmp)
3560 tmp = insert_ob_in_ob (tmp, who); 3508 tmp = insert_ob_in_ob (tmp, who);
3561 3509
3562 who->update_stats (); 3510 who->update_stats ();
3563 3511
3564 /* We exclude spell casting objects. The fire code will set the 3512 /* We exclude spell casting objects. The fire code will set the
… …
3567 */ 3515 */
3568 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD) 3516 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD)
3569 SET_FLAG (op, FLAG_BEEN_APPLIED); 3517 SET_FLAG (op, FLAG_BEEN_APPLIED);
3570 3518
3571 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3519 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3572 {
3573 if (who->type == PLAYER) 3520 if (who->type == PLAYER)
3574 { 3521 {
3575 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3522 who->failmsg (
3523 "Oops, it feels deadly cold! "
3524 "H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>"
3525 );
3576 SET_FLAG (op, FLAG_KNOWN_CURSED); 3526 SET_FLAG (op, FLAG_KNOWN_CURSED);
3577 } 3527 }
3578 } 3528
3579 if (who->type == PLAYER) 3529 if (who->type == PLAYER)
3580 { 3530 {
3581 /* if multiple objects were applied, update both slots */ 3531 /* if multiple objects were applied, update both slots */
3582 if (tmp) 3532 if (tmp)
3583 esrv_send_item (who, tmp); 3533 esrv_send_item (who, tmp);
3534
3584 esrv_send_item (who, op); 3535 esrv_send_item (who, op);
3585 } 3536 }
3537
3586 return 0; 3538 return 0;
3587} 3539}
3588
3589 3540
3590int 3541int
3591monster_apply_special (object *who, object *op, int aflags) 3542monster_apply_special (object *who, object *op, int aflags)
3592{ 3543{
3593 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED)) 3544 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED))
3594 return 1; 3545 return 1;
3546
3595 return apply_special (who, op, aflags); 3547 return apply_special (who, op, aflags);
3596} 3548}
3597 3549
3598/** 3550/**
3599 * Map was just loaded, handle op's initialisation. 3551 * Map was just loaded, handle op's initialisation.
… …
3637 3589
3638 case TREASURE: 3590 case TREASURE:
3639 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 3591 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
3640 return 0; 3592 return 0;
3641 3593
3642 while ((op->stats.hp--) > 0) 3594 while (op->stats.hp-- > 0)
3643 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0, 3595 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0,
3644 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0); 3596 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0);
3645 3597
3646 /* If we generated an object and put it in this object inventory, 3598 /* If we generated an object and put it in this object inventory,
3647 * move it to the parent object as the current object is about 3599 * move it to the parent object as the current object is about
… …
3664 } 3616 }
3665 return tmp ? 1 : 0; 3617 return tmp ? 1 : 0;
3666} 3618}
3667 3619
3668/** 3620/**
3669 * fix_auto_apply goes through the entire map (only the first time 3621 * fix_auto_apply goes through the entire map every time a map
3670 * when an original map is loaded) and performs special actions for 3622 * is loaded or swapped in and performs special actions for
3671 * certain objects (most initialization of chests and creation of 3623 * certain objects (most initialization of chests and creation of
3672 * treasures and stuff). Calls auto_apply if appropriate. 3624 * treasures and stuff). Calls auto_apply if appropriate.
3673 */ 3625 */
3674void 3626void
3675fix_auto_apply (maptile *m) 3627maptile::fix_auto_apply ()
3676{ 3628{
3677 object *tmp, *above = NULL; 3629 if (!spaces)
3678 int x, y;
3679
3680 if (m == NULL)
3681 return; 3630 return;
3682 3631
3683 for (x = 0; x < MAP_WIDTH (m); x++) 3632 for (mapspace *ms = spaces + size (); ms-- > spaces; )
3684 for (y = 0; y < MAP_HEIGHT (m); y++) 3633 for (object *tmp = ms->bot; tmp; )
3685 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = above)
3686 { 3634 {
3687 above = tmp->above; 3635 object *above = tmp->above;
3688 3636
3689 if (tmp->inv) 3637 if (tmp->inv)
3690 { 3638 {
3691 object *invtmp, *invnext; 3639 object *invtmp, *invnext;
3692 3640
3693 for (invtmp = tmp->inv; invtmp != NULL; invtmp = invnext) 3641 for (invtmp = tmp->inv; invtmp != NULL; invtmp = invnext)
3694 { 3642 {
3695 invnext = invtmp->below; 3643 invnext = invtmp->below;
3696 3644
3697 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY)) 3645 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY))
3698 auto_apply (invtmp); 3646 auto_apply (invtmp);
3699 else if (invtmp->type == TREASURE && invtmp->has_random_items ()) 3647 else if (invtmp->type == TREASURE && invtmp->has_random_items ())
3700 { 3648 {
3701 while ((invtmp->stats.hp--) > 0) 3649 while ((invtmp->stats.hp--) > 0)
3702 create_treasure (invtmp->randomitems, invtmp, 0, m->difficulty, 0); 3650 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0);
3703 3651
3704 invtmp->randomitems = NULL; 3652 invtmp->randomitems = NULL;
3705 } 3653 }
3706 else if (invtmp && invtmp->arch 3654 else if (invtmp && invtmp->arch
3707 && invtmp->type != TREASURE && invtmp->type != SPELL && invtmp->type != CLASS && invtmp->has_random_items ()) 3655 && invtmp->type != TREASURE && invtmp->type != SPELL && invtmp->type != CLASS && invtmp->has_random_items ())
3708 { 3656 {
3709 create_treasure (invtmp->randomitems, invtmp, 0, m->difficulty, 0); 3657 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0);
3710 /* Need to clear this so that we never try to create 3658 /* Need to clear this so that we never try to create
3711 * treasure again for this object 3659 * treasure again for this object
3712 */ 3660 */
3713 invtmp->randomitems = NULL; 3661 invtmp->randomitems = NULL;
3714 } 3662 }
3715 } 3663 }
3716 /* This is really temporary - the code at the bottom will 3664 /* This is really temporary - the code at the bottom will
3717 * also set randomitems to null. The problem is there are bunches 3665 * also set randomitems to null. The problem is there are bunches
3718 * of maps/players already out there with items that have spells 3666 * of maps/players already out there with items that have spells
3719 * which haven't had the randomitems set to null yet. 3667 * which haven't had the randomitems set to null yet.
3720 * MSW 2004-05-13 3668 * MSW 2004-05-13
3721 * 3669 *
3722 * And if it's a spellbook, it's better to set randomitems to NULL too, 3670 * And if it's a spellbook, it's better to set randomitems to NULL too,
3723 * else you get two spells in the book ^_- 3671 * else you get two spells in the book ^_-
3724 * Ryo 2004-08-16 3672 * Ryo 2004-08-16
3725 */ 3673 */
3726 if (tmp->type == WAND || tmp->type == ROD || tmp->type == SCROLL 3674 if (tmp->type == WAND || tmp->type == ROD || tmp->type == SCROLL
3727 || tmp->type == HORN || tmp->type == FIREWALL || tmp->type == POTION || tmp->type == ALTAR || tmp->type == SPELLBOOK) 3675 || tmp->type == HORN || tmp->type == FIREWALL || tmp->type == POTION || tmp->type == ALTAR || tmp->type == SPELLBOOK)
3728 tmp->randomitems = NULL;
3729
3730 }
3731
3732 if (QUERY_FLAG (tmp, FLAG_AUTO_APPLY))
3733 auto_apply (tmp);
3734 else if ((tmp->type == TREASURE || (tmp->type == CONTAINER)) && tmp->has_random_items ())
3735 {
3736 while ((tmp->stats.hp--) > 0)
3737 create_treasure (tmp->randomitems, tmp, 0, m->difficulty, 0);
3738 tmp->randomitems = NULL; 3676 tmp->randomitems = NULL;
3677
3739 } 3678 }
3679
3680 if (QUERY_FLAG (tmp, FLAG_AUTO_APPLY))
3681 auto_apply (tmp);
3682 else if ((tmp->type == TREASURE || (tmp->type == CONTAINER)) && tmp->has_random_items ())
3683 {
3684 while ((tmp->stats.hp--) > 0)
3685 create_treasure (tmp->randomitems, tmp, 0, difficulty, 0);
3686 tmp->randomitems = NULL;
3687 }
3740 else if (tmp->type == TIMED_GATE) 3688 else if (tmp->type == TIMED_GATE)
3741 { 3689 {
3742 object *head = tmp->head != NULL ? tmp->head : tmp; 3690 object *head = tmp->head != NULL ? tmp->head : tmp;
3743 3691
3744 if (QUERY_FLAG (head, FLAG_IS_LINKED)) 3692 if (QUERY_FLAG (head, FLAG_IS_LINKED))
3745 {
3746 tmp->speed = 0; 3693 tmp->set_speed (0);
3747 update_ob_speed (tmp);
3748 }
3749 } 3694 }
3750 /* This function can be called everytime a map is loaded, even when 3695 /* This function can be called everytime a map is loaded, even when
3751 * swapping back in. As such, we don't want to create the treasure 3696 * swapping back in. As such, we don't want to create the treasure
3752 * over and ove again, so after we generate the treasure, blank out 3697 * over and ove again, so after we generate the treasure, blank out
3753 * randomitems so if it is swapped in again, it won't make anything. 3698 * randomitems so if it is swapped in again, it won't make anything.
3754 * This is a problem for the above objects, because they have counters 3699 * This is a problem for the above objects, because they have counters
3755 * which say how many times to make the treasure. 3700 * which say how many times to make the treasure.
3756 */ 3701 */
3757 else if (tmp && tmp->arch && tmp->type != PLAYER 3702 else if (tmp && tmp->arch && tmp->type != PLAYER
3758 && tmp->type != TREASURE && tmp->type != SPELL 3703 && tmp->type != TREASURE && tmp->type != SPELL
3759 && tmp->type != PLAYER_CHANGER && tmp->type != CLASS && tmp->has_random_items ()) 3704 && tmp->type != PLAYER_CHANGER && tmp->type != CLASS && tmp->has_random_items ())
3760 { 3705 {
3761 create_treasure (tmp->randomitems, tmp, GT_APPLY, m->difficulty, 0); 3706 create_treasure (tmp->randomitems, tmp, GT_APPLY, difficulty, 0);
3762 tmp->randomitems = NULL; 3707 tmp->randomitems = NULL;
3763 } 3708 }
3709
3710 // close all containers
3711 else if (tmp->type == CONTAINER)
3712 tmp->flag [FLAG_APPLIED] = 0;
3713
3714 tmp = above;
3764 } 3715 }
3765 3716
3766 for (x = 0; x < MAP_WIDTH (m); x++) 3717 for (mapspace *ms = spaces + size (); ms-- > spaces; )
3767 for (y = 0; y < MAP_HEIGHT (m); y++) 3718 for (object *tmp = ms->bot; tmp; tmp = tmp->above)
3768 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
3769 if (tmp->above && (tmp->type == TRIGGER_BUTTON || tmp->type == TRIGGER_PEDESTAL)) 3719 if (tmp->above && (tmp->type == TRIGGER_BUTTON || tmp->type == TRIGGER_PEDESTAL))
3770 check_trigger (tmp, tmp->above); 3720 check_trigger (tmp, tmp->above);
3771} 3721}
3772 3722
3773/** 3723/**
3774 * Handles player eating food that temporarily changes status (resistances, stats). 3724 * Handles player eating food that temporarily changes status (resistances, stats).
3775 * This used to call cast_change_attr(), but 3725 * This used to call cast_change_attr(), but
3776 * that doesn't work with the new spell code. Since we know what 3726 * that doesn't work with the new spell code. Since we know what
3777 * the food changes, just grab a force and use that instead. 3727 * the food changes, just grab a force and use that instead.
3778 */ 3728 */
3779
3780void 3729void
3781eat_special_food (object *who, object *food) 3730eat_special_food (object *who, object *food)
3782{ 3731{
3783 object *force; 3732 object *force;
3784 int i, did_one = 0; 3733 int i, did_one = 0;
3785 sint8 k;
3786 3734
3787 force = get_archetype (FORCE_NAME); 3735 force = get_archetype (FORCE_NAME);
3788 3736
3789 for (i = 0; i < NUM_STATS; i++) 3737 for (i = 0; i < NUM_STATS; i++)
3790 { 3738 if (sint8 k = food->stats.stat (i))
3791 k = get_attr_value (&food->stats, i);
3792 if (k)
3793 { 3739 {
3794 set_attr_value (&force->stats, i, k); 3740 force->stats.stat (i) = k;
3795 did_one = 1; 3741 did_one = 1;
3796 } 3742 }
3797 }
3798 3743
3799 /* check if we can protect the eater */ 3744 /* check if we can protect the eater */
3800 for (i = 0; i < NROFATTACKS; i++) 3745 for (i = 0; i < NROFATTACKS; i++)
3801 { 3746 {
3802 if (food->resist[i] > 0) 3747 if (food->resist[i] > 0)
… …
3806 } 3751 }
3807 } 3752 }
3808 3753
3809 if (did_one) 3754 if (did_one)
3810 { 3755 {
3811 force->speed = 0.1; 3756 force->set_speed (0.1);
3812 update_ob_speed (force);
3813 /* bigger morsel of food = longer effect time */ 3757 /* bigger morsel of food = longer effect time */
3814 force->duration = food->stats.food / 5; 3758 force->duration = food->stats.food / 5;
3815 SET_FLAG (force, FLAG_APPLIED); 3759 SET_FLAG (force, FLAG_APPLIED);
3816 change_abil (who, force); 3760 change_abil (who, force);
3817 insert_ob_in_ob (force, who); 3761 insert_ob_in_ob (force, who);
… …
3822 /* check for hp, sp change */ 3766 /* check for hp, sp change */
3823 if (food->stats.hp != 0) 3767 if (food->stats.hp != 0)
3824 { 3768 {
3825 if (QUERY_FLAG (food, FLAG_CURSED)) 3769 if (QUERY_FLAG (food, FLAG_CURSED))
3826 { 3770 {
3827 strcpy (who->contr->killer, food->name); 3771 assign (who->contr->killer, food->name);
3828 hit_player (who, food->stats.hp, food, AT_POISON, 1); 3772 hit_player (who, food->stats.hp, food, AT_POISON, 1);
3829 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3773 who->failmsg ("Eck!...that was poisonous!");
3830 } 3774 }
3831 else 3775 else
3832 { 3776 {
3833 if (food->stats.hp > 0) 3777 if (food->stats.hp > 0)
3834 new_draw_info (NDI_UNIQUE, 0, who, "You begin to feel better."); 3778 who->statusmsg ("You begin to feel better.");
3835 else 3779 else
3836 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3780 who->failmsg ("Eck!...that was poisonous!");
3781
3837 who->stats.hp += food->stats.hp; 3782 who->stats.hp += food->stats.hp;
3838 } 3783 }
3839 } 3784 }
3840 if (food->stats.sp != 0) 3785 if (food->stats.sp != 0)
3841 { 3786 {
3842 if (QUERY_FLAG (food, FLAG_CURSED)) 3787 if (QUERY_FLAG (food, FLAG_CURSED))
3843 { 3788 {
3844 new_draw_info (NDI_UNIQUE, 0, who, "You are drained of mana!"); 3789 who->failmsg ("You are drained of mana!");
3845 who->stats.sp -= food->stats.sp; 3790 who->stats.sp -= food->stats.sp;
3846 if (who->stats.sp < 0) 3791 if (who->stats.sp < 0)
3847 who->stats.sp = 0; 3792 who->stats.sp = 0;
3848 } 3793 }
3849 else 3794 else
3850 { 3795 {
3851 new_draw_info (NDI_UNIQUE, 0, who, "You feel a rush of magical energy!"); 3796 who->statusmsg ("You feel a rush of magical energy!");
3852 who->stats.sp += food->stats.sp; 3797 who->stats.sp += food->stats.sp;
3853 /* place limit on max sp from food? */ 3798 /* place limit on max sp from food? */
3854 } 3799 }
3855 } 3800 }
3801
3856 who->update_stats (); 3802 who->update_stats ();
3857} 3803}
3858 3804
3859/** 3805/**
3860 * Designed primarily to light torches/lanterns/etc. 3806 * Designed primarily to light torches/lanterns/etc.
… …
3887 } 3833 }
3888 else 3834 else
3889 lighter->stats.food--; 3835 lighter->stats.food--;
3890 } 3836 }
3891 else if (lighter->last_eat) 3837 else if (lighter->last_eat)
3838 {
3892 { /* no charges left in lighter */ 3839 /* no charges left in lighter */
3893 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with a used up %s.", &item->name, &lighter->name); 3840 who->failmsg (format ("You attempt to light the %s with a used up %s.", &item->name, &lighter->name));
3894 return; 3841 return;
3895 } 3842 }
3896 3843
3897 /* Perhaps we should split what we are trying to light on fire? 3844 /* Perhaps we should split what we are trying to light on fire?
3898 * I can't see many times when you would want to light multiple 3845 * I can't see many times when you would want to light multiple
… …
3904 3851
3905 save_throw_object (item, AT_FIRE, who); 3852 save_throw_object (item, AT_FIRE, who);
3906 3853
3907 if (item->destroyed ()) 3854 if (item->destroyed ())
3908 { 3855 {
3909 new_draw_info_format (NDI_UNIQUE, 0, who, "You light the %s with the %s.", &item->name, &lighter->name); 3856 who->statusmsg (format ("You light the %s with the %s.", &item->name, &lighter->name));
3910 /* Need to update the player so that the players glow radius 3857 /* Need to update the player so that the players glow radius
3911 * gets changed. 3858 * gets changed.
3912 */ 3859 */
3913 if (is_player_env) 3860 if (is_player_env)
3914 who->update_stats (); 3861 who->update_stats ();
3915 } 3862 }
3916 else 3863 else
3917 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with the %s and fail.", &item->name, &lighter->name); 3864 who->failmsg (format ("You attempt to light the %s with the %s and fail.", &item->name, &lighter->name));
3918 } 3865 }
3919 else /* nothing to light */ 3866 else
3920 new_draw_info (NDI_UNIQUE, 0, who, "You need to mark a lightable object."); 3867 who->failmsg ("You need to mark a lightable object.");
3921
3922} 3868}
3923 3869
3924/** 3870/**
3925 * op made some mistake with a scroll, this takes care of punishment. 3871 * op made some mistake with a scroll, this takes care of punishment.
3926 * scroll_failure()- hacked directly from spell_failure 3872 * scroll_failure()- hacked directly from spell_failure
… …
3933 3879
3934 if (failure <= -1 && failure > -15) 3880 if (failure <= -1 && failure > -15)
3935 { /* wonder */ 3881 { /* wonder */
3936 object *tmp; 3882 object *tmp;
3937 3883
3938 new_draw_info (NDI_UNIQUE, 0, op, "Your spell warps!."); 3884 op->failmsg ("Your spell warps!");
3939 tmp = get_archetype (SPELL_WONDER); 3885 tmp = get_archetype (SPELL_WONDER);
3940 cast_wonder (op, op, 0, tmp); 3886 cast_wonder (op, op, 0, tmp);
3941 tmp->destroy (); 3887 tmp->destroy ();
3942 } 3888 }
3943 else if (failure <= -15 && failure > -35) 3889 else if (failure <= -15 && failure > -35)
3944 { /* drain mana */ 3890 { /* drain mana */
3945 new_draw_info (NDI_UNIQUE, 0, op, "Your mana is drained!."); 3891 op->failmsg ("Your mana is drained!");
3946 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW); 3892 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW);
3947 if (op->stats.sp < 0) 3893 if (op->stats.sp < 0)
3948 op->stats.sp = 0; 3894 op->stats.sp = 0;
3949 } 3895 }
3950 else if (settings.spell_failure_effects == TRUE) 3896 else if (settings.spell_failure_effects == TRUE)
3951 { 3897 {
3952 if (failure <= -35 && failure > -60) 3898 if (failure <= -35 && failure > -60)
3953 { /* confusion */ 3899 { /* confusion */
3954 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3900 op->failmsg ("The magic recoils on you!");
3955 confuse_player (op, op, power); 3901 confuse_player (op, op, power);
3956 } 3902 }
3957 else if (failure <= -60 && failure > -70) 3903 else if (failure <= -60 && failure > -70)
3958 { /* paralysis */ 3904 { /* paralysis */
3959 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils and paralyzes " "you!"); 3905 op->failmsg ("The magic recoils and paralyzes you!");
3960 paralyze_player (op, op, power); 3906 paralyze_player (op, op, power);
3961 } 3907 }
3962 else if (failure <= -70 && failure > -80) 3908 else if (failure <= -70 && failure > -80)
3963 { /* blind */ 3909 { /* blind */
3964 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3910 op->failmsg ("The magic recoils on you!");
3965 blind_player (op, op, power); 3911 blind_player (op, op, power);
3966 } 3912 }
3967 else if (failure <= -80) 3913 else if (failure <= -80)
3968 { /* blast the immediate area */ 3914 { /* blast the immediate area */
3969 object *tmp;
3970
3971 tmp = get_archetype (LOOSE_MANA); 3915 object *tmp = get_archetype (LOOSE_MANA);
3972 cast_magic_storm (op, tmp, power); 3916 cast_magic_storm (op, tmp, power);
3973 new_draw_info (NDI_UNIQUE, 0, op, "You unlease uncontrolled mana!"); 3917 op->failmsg ("You unleash uncontrolled mana!");
3974 tmp->destroy (); 3918 tmp->destroy ();
3975 } 3919 }
3976 } 3920 }
3977} 3921}
3978 3922
… …
3998 */ 3942 */
3999 int i, j; 3943 int i, j;
4000 3944
4001 for (i = 0; i < NUM_STATS; i++) 3945 for (i = 0; i < NUM_STATS; i++)
4002 { 3946 {
4003 sint8 stat = get_attr_value (stats, i); 3947 int race_bonus = pl->arch->stats.stat (i);
4004 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i); 3948 sint8 stat = stats->stat (i) + ns->stat (i);
4005 3949
4006 stat += get_attr_value (ns, i);
4007 if (stat > 20 + race_bonus) 3950 if (stat > 20 + race_bonus)
4008 { 3951 {
4009 excess_stat++; 3952 excess_stat++;
4010 stat = 20 + race_bonus; 3953 stat = 20 + race_bonus;
4011 } 3954 }
4012 set_attr_value (stats, i, stat); 3955
3956 stats->stat (i) = stat;
4013 } 3957 }
4014 3958
4015 for (j = 0; excess_stat > 0 && j < 100; j++) 3959 for (j = 0; excess_stat > 0 && j < 100; j++)
4016 { /* try 100 times to assign excess stats */ 3960 { /* try 100 times to assign excess stats */
4017 int i = rndm (0, 6); 3961 int i = rndm (0, 6);
4018 int stat = get_attr_value (stats, i);
4019 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i);
4020 3962
4021 if (i == CHA) 3963 if (i == CHA)
4022 continue; /* exclude cha from this */ 3964 continue; /* exclude cha from this */
3965
3966 int stat = stats->stat (i);
3967 int race_bonus = pl->arch->stats.stat (i);
4023 if (stat < 20 + race_bonus) 3968 if (stat < 20 + race_bonus)
4024 { 3969 {
4025 change_attr_value (stats, i, 1); 3970 change_attr_value (stats, i, 1);
4026 excess_stat--; 3971 excess_stat--;
4027 } 3972 }
… …
4030 /* insert the randomitems from the change's treasurelist into 3975 /* insert the randomitems from the change's treasurelist into
4031 * the player ref: player.c 3976 * the player ref: player.c
4032 */ 3977 */
4033 if (change->randomitems != NULL) 3978 if (change->randomitems != NULL)
4034 give_initial_items (pl, change->randomitems); 3979 give_initial_items (pl, change->randomitems);
4035
4036 3980
4037 /* set up the face, for some races. */ 3981 /* set up the face, for some races. */
4038 3982
4039 /* first, look for the force object banning 3983 /* first, look for the force object banning
4040 * changing the face. Certain races never change face with class. 3984 * changing the face. Certain races never change face with class.
… …
4085 char got[MAX_BUF]; 4029 char got[MAX_BUF];
4086 int len; 4030 int len;
4087 4031
4088 if (!pl || !transformer) 4032 if (!pl || !transformer)
4089 return; 4033 return;
4034
4090 marked = find_marked_object (pl); 4035 marked = find_marked_object (pl);
4036
4091 if (!marked) 4037 if (!marked)
4092 { 4038 {
4093 new_draw_info_format (NDI_UNIQUE, 0, pl, "Use the %s with what item?", query_name (transformer)); 4039 pl->failmsg (format ("Use the %s with what item?", query_name (transformer)));
4094 return; 4040 return;
4095 } 4041 }
4042
4096 if (!marked->slaying) 4043 if (!marked->slaying)
4097 { 4044 {
4098 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 4045 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4099 return; 4046 return;
4100 } 4047 }
4048
4101 /* check whether they are compatible or not */ 4049 /* check whether they are compatible or not */
4102 find = strstr (marked->slaying, transformer->arch->name); 4050 find = strstr (marked->slaying, transformer->arch->archname);
4103 if (!find || (*(find + strlen (transformer->arch->name)) != ':')) 4051 if (!find || (*(find + strlen (transformer->arch->archname)) != ':'))
4104 { 4052 {
4105 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 4053 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4106 return; 4054 return;
4107 } 4055 }
4056
4108 find += strlen (transformer->arch->name) + 1; 4057 find += strlen (transformer->arch->archname) + 1;
4109 /* Item can be used, now find how many and what it yields */ 4058 /* Item can be used, now find how many and what it yields */
4110 if (isdigit (*(find))) 4059 if (isdigit (*(find)))
4111 { 4060 {
4112 yield = atoi (find); 4061 yield = atoi (find);
4113 if (yield < 1) 4062 if (yield < 1)
… …
4119 else 4068 else
4120 yield = 1; 4069 yield = 1;
4121 4070
4122 while (isdigit (*find)) 4071 while (isdigit (*find))
4123 find++; 4072 find++;
4073
4124 while (*find == ' ') 4074 while (*find == ' ')
4125 find++; 4075 find++;
4076
4126 memset (got, 0, MAX_BUF); 4077 memset (got, 0, MAX_BUF);
4078
4127 if ((separator = strchr (find, ';')) != NULL) 4079 if ((separator = strchr (find, ';')) != NULL)
4128 {
4129 len = separator - find; 4080 len = separator - find;
4130 }
4131 else 4081 else
4132 {
4133 len = strlen (find); 4082 len = strlen (find);
4134 } 4083
4135 if (len > MAX_BUF - 1) 4084 if (len > MAX_BUF - 1)
4136 len = MAX_BUF - 1; 4085 len = MAX_BUF - 1;
4086
4137 strcpy (got, find); 4087 strcpy (got, find);
4138 got[len] = '\0'; 4088 got[len] = '\0';
4139 4089
4140 /* Now create new item, remove used ones when required. */ 4090 /* Now create new item, remove used ones when required. */
4141 new_item = get_archetype (got); 4091 new_item = get_archetype (got);
4142 if (!new_item) 4092 if (!new_item)
4143 { 4093 {
4144 new_draw_info_format (NDI_UNIQUE, 0, pl, "This %s is strange, better to not use it.", query_base_name (marked, 0)); 4094 pl->failmsg (format ("This %s is strange, better to not use it.", query_base_name (marked, 0)));
4145 return; 4095 return;
4146 } 4096 }
4147 4097
4148 new_item->nrof = yield; 4098 new_item->nrof = yield;
4099
4149 new_draw_info_format (NDI_UNIQUE, 0, pl, "You %s the %s.", &transformer->slaying, query_base_name (marked, 0)); 4100 pl->statusmsg (format ("You %s the %s.", &transformer->slaying, query_base_name (marked, 0)));
4101
4150 insert_ob_in_ob (new_item, pl); 4102 insert_ob_in_ob (new_item, pl);
4151 esrv_send_inventory (pl, pl); 4103 esrv_send_inventory (pl, pl);
4152 /* Eat up one item */ 4104 /* Eat up one item */
4153 decrease_ob_nr (marked, 1); 4105 decrease_ob_nr (marked, 1);
4106
4154 /* Eat one transformer if needed */ 4107 /* Eat one transformer if needed */
4155 if (transformer->stats.food) 4108 if (transformer->stats.food)
4156 if (--transformer->stats.food == 0) 4109 if (--transformer->stats.food == 0)
4157 decrease_ob_nr (transformer, 1); 4110 decrease_ob_nr (transformer, 1);
4158} 4111}
4112

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines