ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/apply.C
(Generate patch)

Comparing deliantra/server/server/apply.C (file contents):
Revision 1.51 by root, Fri Dec 22 16:34:00 2006 UTC vs.
Revision 1.150 by root, Tue Apr 22 23:50:24 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The authors can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23
24#include <cmath>
23 25
24#include <global.h> 26#include <global.h>
25#include <living.h> 27#include <living.h>
26#include <spells.h> 28#include <spells.h>
27#include <skills.h> 29#include <skills.h>
… …
29 31
30#include <sproto.h> 32#include <sproto.h>
31 33
32/* Want this regardless of rplay. */ 34/* Want this regardless of rplay. */
33#include <sounds.h> 35#include <sounds.h>
34
35/* need math lib for double-precision and pow() in dragon_eat_flesh() */
36#include <math.h>
37 36
38/** 37/**
39 * Check if op should abort moving victim because of it's race or slaying. 38 * Check if op should abort moving victim because of it's race or slaying.
40 * Returns 1 if it should abort, returns 0 if it should continue. 39 * Returns 1 if it should abort, returns 0 if it should continue.
41 */ 40 */
… …
64 { 63 {
65 arch_flag = 1; 64 arch_flag = 1;
66 name_flag = 1; 65 name_flag = 1;
67 race_flag = 1; 66 race_flag = 1;
68 } 67 }
68
69 /* If the director has race set, only affect objects with a arch, 69 /* If the director has race set, only affect objects with a arch,
70 * name or race that matches. 70 * name or race that matches.
71 */ 71 */
72 if ((op->race) && 72 if ((op->race) &&
73 ((!(victim->arch && arch_flag && victim->arch->name) || strcmp (op->race, victim->arch->name))) && 73 ((!(victim->arch && arch_flag && victim->arch->archname) || op->race != victim->arch->archname)) &&
74 ((!(victim->name && name_flag) || strcmp (op->race, victim->name))) && 74 ((!(victim->name && name_flag) || op->race != victim->name)) &&
75 ((!(victim->race && race_flag) || strcmp (op->race, victim->race)))) 75 ((!(victim->race && race_flag) || op->race != victim->race)))
76 {
77 return 1; 76 return 1;
78 } 77
79 /* If the director has slaying set, only affect objects where none 78 /* If the director has slaying set, only affect objects where none
80 * of arch, name, or race match. 79 * of arch, name, or race match.
81 */ 80 */
82 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->name && !strcmp (op->slaying, victim->arch->name))) || 81 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->archname && op->slaying == victim->arch->archname))) ||
83 ((victim->name && name_flag && !strcmp (op->slaying, victim->name))) || 82 ((victim->name && name_flag && op->slaying == victim->name)) ||
84 ((victim->race && race_flag && !strcmp (op->slaying, victim->race))))) 83 ((victim->race && race_flag && op->slaying == victim->race)))
85 {
86 return 1; 84 return 1;
87 } 85
88 return 0; 86 return 0;
89} 87}
90 88
91/** 89/**
92 * This handles a player dropping money on an altar to identify stuff. 90 * This handles a player dropping money on an altar to identify stuff.
… …
94 * Return value: 1 if money was destroyed, 0 if not. 92 * Return value: 1 if money was destroyed, 0 if not.
95 */ 93 */
96static int 94static int
97apply_id_altar (object *money, object *altar, object *pl) 95apply_id_altar (object *money, object *altar, object *pl)
98{ 96{
99 object *id, *marked; 97 dynbuf_text buf;
100 int success = 0;
101 98
102 if (pl == NULL || pl->type != PLAYER) 99 if (!pl || pl->type != PLAYER)
103 return 0; 100 return 0;
104 101
105 /* Check for MONEY type is a special hack - it prevents 'nothing needs 102 /* Check for MONEY type is a special hack - it prevents 'nothing needs
106 * identifying' from being printed out more than it needs to be. 103 * identifying' from being printed out more than it needs to be.
107 */ 104 */
108 if (!check_altar_sacrifice (altar, money) || money->type != MONEY) 105 if (!check_altar_sacrifice (altar, money) || money->type != MONEY)
109 return 0; 106 return 0;
110 107
111 marked = find_marked_object (pl);
112 /* if the player has a marked item, identify that if it needs to be 108 /* if the player has a marked item, identify that if it needs to be
113 * identified. IF it doesn't, then go through the player inventory. 109 * identified. If it doesn't, then go through the player inventory.
114 */ 110 */
111 if (object *marked = find_marked_object (pl))
115 if (marked && !QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked)) 112 if (!QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked))
116 { 113 {
117 if (operate_altar (altar, &money)) 114 if (operate_altar (altar, &money))
118 { 115 {
119 identify (marked); 116 identify (marked);
120 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (marked, pl)); 117
118 buf.printf ("You have %s.\n\n", long_desc (marked, pl));
121 if (marked->msg) 119 if (marked->msg)
122 { 120 buf << "The item has a story:\n\n" << marked->msg << "\n\n";
123 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 121
124 new_draw_info (NDI_UNIQUE, 0, pl, marked->msg); 122 return !money;
125 } 123 }
126 return money == NULL;
127 } 124 }
128 }
129 125
130 for (id = pl->inv; id; id = id->below) 126 for (object *id = pl->inv; id; id = id->below)
131 { 127 {
132 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id)) 128 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id))
133 { 129 {
134 if (operate_altar (altar, &money)) 130 if (operate_altar (altar, &money))
135 { 131 {
136 identify (id); 132 identify (id);
137 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (id, pl)); 133
134 buf.printf ("You have %s.\n\n", long_desc (id, pl));
138 if (id->msg) 135 if (id->msg)
139 { 136 buf << "The item has a story:\n\n" << id->msg << "\n\n";
140 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 137
141 new_draw_info (NDI_UNIQUE, 0, pl, id->msg);
142 }
143 success = 1;
144 /* If no more money, might as well quit now */ 138 /* If no more money, might as well quit now */
145 if (money == NULL || !check_altar_sacrifice (altar, money)) 139 if (!money || !check_altar_sacrifice (altar, money))
146 break; 140 break;
147 } 141 }
148 else 142 else
149 { 143 {
150 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n"); 144 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n");
151 break; 145 break;
152 } 146 }
153 } 147 }
154 } 148 }
155 if (!success) 149
156 new_draw_info (NDI_UNIQUE, 0, pl, "You have nothing that needs identifying"); 150 if (buf.empty ())
151 pl->failmsg ("You have nothing that needs identifying");
152 else
153 pl->contr->infobox (MSG_CHANNEL ("identify"), buf);
154
157 return money == NULL; 155 return !money;
158} 156}
159 157
160/** 158/**
161 * This checks whether the object has a "on_use_yield" field, and if so generated and drops 159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops
162 * matching item. 160 * matching item.
163 **/ 161 **/
164static void 162void
165handle_apply_yield (object *tmp) 163handle_apply_yield (object *tmp)
166{ 164{
167 const char *yield; 165 const char *yield;
168 166
169 yield = get_ob_key_value (tmp, "on_use_yield"); 167 yield = get_ob_key_value (tmp, "on_use_yield");
168
170 if (yield != NULL) 169 if (yield)
171 { 170 get_archetype (yield)->insert_at (tmp, tmp, INS_BELOW_ORIGINATOR);
172 object *drop = get_archetype (yield);
173
174 if (tmp->env)
175 {
176 drop = insert_ob_in_ob (drop, tmp->env);
177 if (tmp->env->type == PLAYER)
178 esrv_send_item (tmp->env, drop);
179 }
180 else
181 {
182 drop->x = tmp->x;
183 drop->y = tmp->y;
184 insert_ob_in_map (drop, tmp->map, tmp, INS_BELOW_ORIGINATOR);
185 }
186 }
187} 171}
188 172
189/** 173/**
190 * Handles applying a potion. 174 * Handles applying a potion.
191 */ 175 */
… …
197 181
198 floor = GET_MAP_OB (op->map, op->x, op->y); 182 floor = GET_MAP_OB (op->map, op->x, op->y);
199 183
200 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE) 184 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE)
201 { 185 {
202 if (op->type == PLAYER)
203 new_draw_info (NDI_UNIQUE, 0, op, "Gods prevent you from using this here, it's sacred ground!"); 186 op->failmsg ("Gods prevent you from using this here, it's sacred ground!");
187
204 CLEAR_FLAG (tmp, FLAG_APPLIED); 188 CLEAR_FLAG (tmp, FLAG_APPLIED);
205 return 0; 189 return 0;
206 } 190 }
207 191
208 if (op->type == PLAYER) 192 if (op->type == PLAYER)
… …
219 203
220 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 204 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
221 { 205 {
222 op->drain_stat (); 206 op->drain_stat ();
223 op->update_stats (); 207 op->update_stats ();
224 decrease_ob (tmp); 208 tmp->decrease ();
225 return 1; 209 return 1;
226 } 210 }
227 211
228 if (!(at = archetype::find (ARCH_DEPLETION))) 212 if (!(at = archetype::find (ARCH_DEPLETION)))
229 { 213 {
230 LOG (llevError, "Could not find archetype depletion\n"); 214 LOG (llevError, "Could not find archetype depletion\n");
231 return 0; 215 return 0;
232 } 216 }
217
233 depl = present_arch_in_ob (at, op); 218 depl = present_arch_in_ob (at, op);
234 219
235 if (depl) 220 if (depl)
236 { 221 {
237 for (i = 0; i < NUM_STATS; i++) 222 for (i = 0; i < NUM_STATS; i++)
238 if (get_attr_value (&depl->stats, i)) 223 if (depl->stats.stat (i))
239 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]); 224 op->statusmsg (restore_msg[i]);
240 225
241 depl->destroy (); 226 depl->destroy ();
242 op->update_stats (); 227 op->update_stats ();
243 } 228 }
244 else 229 else
245 new_draw_info (NDI_UNIQUE, 0, op, "You potion had no effect."); 230 op->statusmsg ("Your potion had no effect.");
246 231
247 decrease_ob (tmp); 232 tmp->decrease ();
248 return 1; 233 return 1;
249 } 234 }
250 235
251 /* improvement potion - only for players */ 236 /* improvement potion - only for players */
252 if (op->type == PLAYER && tmp->attacktype & AT_GODPOWER) 237 if (op->type == PLAYER && (tmp->attacktype & AT_GODPOWER))
253 { 238 {
254 for (i = 1; i < MIN (11, op->level); i++) 239 for (i = 1; i < MIN (11, op->level); i++)
255 { 240 {
256 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 241 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
257 { 242 {
258 if (op->contr->levhp[i] != 1) 243 if (op->contr->levhp[i] != 1)
259 { 244 {
260 op->contr->levhp[i] = 1; 245 op->contr->levhp[i] = 1;
261 break; 246 break;
262 } 247 }
248
263 if (op->contr->levsp[i] != 1) 249 if (op->contr->levsp[i] != 1)
264 { 250 {
265 op->contr->levsp[i] = 1; 251 op->contr->levsp[i] = 1;
266 break; 252 break;
267 } 253 }
254
268 if (op->contr->levgrace[i] != 1) 255 if (op->contr->levgrace[i] != 1)
269 { 256 {
270 op->contr->levgrace[i] = 1; 257 op->contr->levgrace[i] = 1;
271 break; 258 break;
272 } 259 }
… …
276 if (op->contr->levhp[i] < 9) 263 if (op->contr->levhp[i] < 9)
277 { 264 {
278 op->contr->levhp[i] = 9; 265 op->contr->levhp[i] = 9;
279 break; 266 break;
280 } 267 }
268
281 if (op->contr->levsp[i] < 6) 269 if (op->contr->levsp[i] < 6)
282 { 270 {
283 op->contr->levsp[i] = 6; 271 op->contr->levsp[i] = 6;
284 break; 272 break;
285 } 273 }
274
286 if (op->contr->levgrace[i] < 3) 275 if (op->contr->levgrace[i] < 3)
287 { 276 {
288 op->contr->levgrace[i] = 3; 277 op->contr->levgrace[i] = 3;
289 break; 278 break;
290 } 279 }
… …
298 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)) 287 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))
299 { 288 {
300 if (got_one) 289 if (got_one)
301 { 290 {
302 op->update_stats (); 291 op->update_stats ();
303 new_draw_info (NDI_UNIQUE, 0, op, "The Gods smile upon you and remake you"); 292 op->statusmsg ("The Gods smile upon you and remake you "
304 new_draw_info (NDI_UNIQUE, 0, op, "a little more in their image."); 293 "a little more in their image. "
305 new_draw_info (NDI_UNIQUE, 0, op, "You feel a little more perfect."); 294 "You feel a little more perfect.", NDI_GREEN);
306 } 295 }
307 else 296 else
308 new_draw_info (NDI_UNIQUE, 0, op, "The potion had no effect - you are already perfect"); 297 op->statusmsg ("The potion had no effect - you are already perfect.");
309 } 298 }
310 else 299 else
311 { /* cursed potion */ 300 { /* cursed potion */
312 if (got_one) 301 if (got_one)
313 { 302 {
314 op->update_stats (); 303 op->update_stats ();
315 new_draw_info (NDI_UNIQUE, 0, op, "The Gods are angry and punish you."); 304 op->failmsg ("The Gods are angry and punish you.");
316 } 305 }
317 else 306 else
318 new_draw_info (NDI_UNIQUE, 0, op, "You are fortunate that you are so pathetic."); 307 op->statusmsg ("You are fortunate that you are so pathetic.", NDI_DK_ORANGE);
319 } 308 }
320 309
321 decrease_ob (tmp); 310 tmp->decrease ();
322 return 1; 311 return 1;
323 } 312 }
324 313
325 314
326 /* A potion that casts a spell. Healing, restore spellpoint (power potion) 315 /* A potion that casts a spell. Healing, restore spellpoint (power potion)
… …
332 { 321 {
333 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 322 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
334 { 323 {
335 object *fball; 324 object *fball;
336 325
337 new_draw_info (NDI_UNIQUE, 0, op, "Yech! Your lungs are on fire!"); 326 op->failmsg ("Yech! Your lungs are on fire!");
327
338 /* Explodes a fireball centered at player */ 328 /* Explodes a fireball centered at player */
339 fball = get_archetype (EXPLODING_FIREBALL); 329 fball = get_archetype (EXPLODING_FIREBALL);
340 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1; 330 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1;
341 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2; 331 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2;
342 fball->x = op->x; 332 fball->x = op->x;
… …
344 insert_ob_in_map (fball, op->map, NULL, 0); 334 insert_ob_in_map (fball, op->map, NULL, 0);
345 } 335 }
346 else 336 else
347 cast_spell (op, tmp, op->facing, tmp->inv, NULL); 337 cast_spell (op, tmp, op->facing, tmp->inv, NULL);
348 338
349 decrease_ob (tmp); 339 tmp->decrease ();
340
350 /* if youre dead, no point in doing this... */ 341 /* if youre dead, no point in doing this... */
351 if (!QUERY_FLAG (op, FLAG_REMOVED)) 342 if (!QUERY_FLAG (op, FLAG_REMOVED))
352 op->update_stats (); 343 op->update_stats ();
344
353 return 1; 345 return 1;
354 } 346 }
355 347
356 /* Deal with protection potions */ 348 /* Deal with protection potions */
357 force = NULL; 349 force = NULL;
… …
359 { 351 {
360 if (tmp->resist[i]) 352 if (tmp->resist[i])
361 { 353 {
362 if (!force) 354 if (!force)
363 force = get_archetype (FORCE_NAME); 355 force = get_archetype (FORCE_NAME);
356
364 memcpy (force->resist, tmp->resist, sizeof (tmp->resist)); 357 memcpy (force->resist, tmp->resist, sizeof (tmp->resist));
365 force->type = POTION_EFFECT; 358 force->type = POTION_EFFECT;
366 break; /* Only need to find one protection since we copy entire batch */ 359 break; /* Only need to find one protection since we copy entire batch */
367 } 360 }
368 } 361 }
362
369 /* This is a protection potion */ 363 /* This is a protection potion */
370 if (force) 364 if (force)
371 { 365 {
372 /* cursed items last longer */ 366 /* cursed items last longer */
373 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 367 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
… …
375 force->stats.food *= 10; 369 force->stats.food *= 10;
376 for (i = 0; i < NROFATTACKS; i++) 370 for (i = 0; i < NROFATTACKS; i++)
377 if (force->resist[i] > 0) 371 if (force->resist[i] > 0)
378 force->resist[i] = -force->resist[i]; /* prot => vuln */ 372 force->resist[i] = -force->resist[i]; /* prot => vuln */
379 } 373 }
374
380 force->speed_left = -1; 375 force->speed_left = -1;
381 force = insert_ob_in_ob (force, op); 376 force = insert_ob_in_ob (force, op);
382 CLEAR_FLAG (tmp, FLAG_APPLIED); 377 CLEAR_FLAG (tmp, FLAG_APPLIED);
383 SET_FLAG (force, FLAG_APPLIED); 378 SET_FLAG (force, FLAG_APPLIED);
384 change_abil (op, force); 379 change_abil (op, force);
385 decrease_ob (tmp); 380 tmp->decrease ();
386 return 1; 381 return 1;
387 } 382 }
388 383
389 /* Only thing left are the stat potions */ 384 /* Only thing left are the stat potions */
390 if (op->type == PLAYER) 385 if (op->type == PLAYER)
391 { /* only for players */ 386 { /* only for players */
392 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0) 387 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0)
393 CLEAR_FLAG (tmp, FLAG_APPLIED); 388 CLEAR_FLAG (tmp, FLAG_APPLIED);
394 else 389 else
395 SET_FLAG (tmp, FLAG_APPLIED); 390 SET_FLAG (tmp, FLAG_APPLIED);
391
396 if (!change_abil (op, tmp)) 392 if (!change_abil (op, tmp))
397 new_draw_info (NDI_UNIQUE, 0, op, "Nothing happened."); 393 op->statusmsg ("Nothing happened.");
398 } 394 }
399 395
400 /* CLEAR_FLAG is so that if the character has other potions 396 /* CLEAR_FLAG is so that if the character has other potions
401 * that were grouped with the one consumed, his 397 * that were grouped with the one consumed, his
402 * stat will not be raised by them. fix_player just clears 398 * stat will not be raised by them. fix_player just clears
403 * up all the stats. 399 * up all the stats.
404 */ 400 */
405 CLEAR_FLAG (tmp, FLAG_APPLIED); 401 CLEAR_FLAG (tmp, FLAG_APPLIED);
406 op->update_stats (); 402 op->update_stats ();
407 decrease_ob (tmp); 403 tmp->decrease ();
408 return 1; 404 return 1;
409} 405}
410 406
411/**************************************************************************** 407/****************************************************************************
412 * Weapon improvement code follows 408 * Weapon improvement code follows
… …
418static int 414static int
419check_item (object *op, const char *item) 415check_item (object *op, const char *item)
420{ 416{
421 int count = 0; 417 int count = 0;
422 418
423 419 if (!item)
424 if (item == NULL)
425 return 0; 420 return 0;
426 op = op->below; 421
427 while (op != NULL) 422 for (op = op->below; op; op = op->below)
428 { 423 {
429 if (strcmp (op->arch->name, item) == 0) 424 if (strcmp (op->arch->archname, item) == 0)
430 { 425 {
431 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED) 426 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED)
432 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID)) 427 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID))
433 { 428 {
434 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */ 429 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */
435 count++; 430 count++;
436 else 431 else
437 count += op->nrof; 432 count += op->nrof;
438 } 433 }
439 } 434 }
440 op = op->below;
441 } 435 }
436
442 return count; 437 return count;
443} 438}
444 439
445/** 440/**
446 * This removes 'nrof' of what item->slaying says to remove. 441 * This removes 'nrof' of what item->slaying says to remove.
… …
454 object *prev; 449 object *prev;
455 450
456 prev = op; 451 prev = op;
457 op = op->below; 452 op = op->below;
458 453
459 while (op != NULL) 454 while (op)
460 { 455 {
461 if (strcmp (op->arch->name, item) == 0) 456 if (strcmp (op->arch->archname, item) == 0)
462 { 457 {
463 if (op->nrof >= nrof) 458 if (op->nrof >= nrof)
464 { 459 {
465 decrease_ob_nr (op, nrof); 460 op->decrease (nrof);
466 return; 461 return;
467 } 462 }
468 else 463 else
469 { 464 {
470 decrease_ob_nr (op, op->nrof); 465 op->decrease (nrof);
471 nrof -= op->nrof; 466 nrof -= op->nrof;
472 } 467 }
468
473 op = prev; 469 op = prev;
474 } 470 }
471
475 prev = op; 472 prev = op;
476 op = op->below; 473 op = op->below;
477 } 474 }
478} 475}
479 476
… …
485 * we return 1 (true) if the player can use the weapon. 482 * we return 1 (true) if the player can use the weapon.
486 */ 483 */
487static int 484static int
488check_weapon_power (const object *who, int improvs) 485check_weapon_power (const object *who, int improvs)
489{ 486{
490
491/* Old code is below (commented out). Basically, since weapons are the only 487/* Old code is below (commented out). Basically, since weapons are the only
492 * object players really have any control to improve, it's a bit harsh to 488 * object players really have any control to improve, it's a bit harsh to
493 * require high level in some combat skill, so we just use overall level. 489 * require high level in some combat skill, so we just use overall level.
494 */ 490 */
495#if 1 491#if 1
… …
536static int 532static int
537check_sacrifice (object *op, const object *improver) 533check_sacrifice (object *op, const object *improver)
538{ 534{
539 int count = 0; 535 int count = 0;
540 536
541 if (improver->slaying != NULL) 537 if (improver->slaying)
542 { 538 {
543 count = check_item (op, improver->slaying); 539 count = check_item (op, improver->slaying);
544 if (count < 1) 540 if (count < 1)
545 { 541 {
546 char buf[200];
547
548 sprintf (buf, "The gods want more %ss", &improver->slaying); 542 op->failmsg (format ("The gods want more %ss", &improver->slaying));
549 new_draw_info (NDI_UNIQUE, 0, op, buf);
550 return 0; 543 return 0;
551 } 544 }
552 } 545 }
553 else 546 else
554 count = 1; 547 count = 1;
… …
557} 550}
558 551
559/** 552/**
560 * Actually improves the weapon, and tells user. 553 * Actually improves the weapon, and tells user.
561 */ 554 */
562int 555static int
563improve_weapon_stat (object *op, object *improver, object *weapon, signed char *stat, int sacrifice_count, const char *statname) 556improve_weapon_stat (object *op, object *improver, object *weapon, sint8 &stat, int sacrifice_count, const char *statname)
564{ 557{
565
566 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
567 *stat += sacrifice_count; 558 stat += sacrifice_count;
568 weapon->last_eat++; 559 weapon->last_eat++;
569 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon's bonus to %s improved by %d", statname, sacrifice_count); 560 improver->decrease ();
570 decrease_ob (improver);
571 561
572 /* So it updates the players stats and the window */ 562 /* So it updates the players stats and the window */
573 op->update_stats (); 563 op->update_stats ();
564
565 op->statusmsg (format (
566 "Your sacrifice was accepted.\n"
567 "Weapon's bonus to %s improved by %d.",
568 statname, sacrifice_count
569 ));
570
574 return 1; 571 return 1;
575} 572}
576 573
577/* Types of improvements, hidden in the sp field. */ 574/* Types of improvements, hidden in the sp field. */
578#define IMPROVE_PREPARE 1 575#define IMPROVE_PREPARE 1
579#define IMPROVE_DAMAGE 2 576#define IMPROVE_DAMAGE 2
580#define IMPROVE_WEIGHT 3 577#define IMPROVE_WEIGHT 3
581#define IMPROVE_ENCHANT 4 578#define IMPROVE_ENCHANT 4
582#define IMPROVE_STR 5 579#define IMPROVE_STR 5
583#define IMPROVE_DEX 6 580#define IMPROVE_DEX 6
584#define IMPROVE_CON 7 581#define IMPROVE_CON 7
585#define IMPROVE_WIS 8 582#define IMPROVE_WIS 8
586#define IMPROVE_CHA 9 583#define IMPROVE_CHA 9
587#define IMPROVE_INT 10 584#define IMPROVE_INT 10
588#define IMPROVE_POW 11 585#define IMPROVE_POW 11
589
590 586
591/** 587/**
592 * This does the prepare weapon scroll. 588 * This does the prepare weapon scroll.
593 * Checks for sacrifice, and so on. 589 * Checks for sacrifice, and so on.
594 */ 590 */
595
596int 591int
597prepare_weapon (object *op, object *improver, object *weapon) 592prepare_weapon (object *op, object *improver, object *weapon)
598{ 593{
599 int sacrifice_count, i; 594 int sacrifice_count, i;
600 char buf[MAX_BUF]; 595 char buf[MAX_BUF];
601 596
602 if (weapon->level != 0) 597 if (weapon->level != 0)
603 { 598 {
604 new_draw_info (NDI_UNIQUE, 0, op, "Weapon already prepared."); 599 op->failmsg ("Weapon is already prepared!");
605 return 0; 600 return 0;
606 } 601 }
602
607 for (i = 0; i < NROFATTACKS; i++) 603 for (i = 0; i < NROFATTACKS; i++)
608 if (weapon->resist[i]) 604 if (weapon->resist[i])
609 break; 605 break;
610 606
611 /* If we break out, i will be less than nrofattacks, preventing 607 /* If we break out, i will be less than nrofattacks, preventing
… …
614 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */ 610 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */
615 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */ 611 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */
616 weapon->stats.exp || /* speed */ 612 weapon->stats.exp || /* speed */
617 weapon->stats.ac) /* AC - only taifu's I think */ 613 weapon->stats.ac) /* AC - only taifu's I think */
618 { 614 {
619 new_draw_info (NDI_UNIQUE, 0, op, "Cannot prepare magic weapons."); 615 op->failmsg ("You cannot prepare magic weapons. "
616 "H<A weapon is considered magical if it changes regeneration, "
617 "speed or ac.>");
620 return 0; 618 return 0;
621 } 619 }
620
622 sacrifice_count = check_sacrifice (op, improver); 621 sacrifice_count = check_sacrifice (op, improver);
623 if (sacrifice_count <= 0) 622 if (sacrifice_count <= 0)
624 return 0; 623 return 0;
624
625 weapon->level = isqrt (sacrifice_count); 625 weapon->level = isqrt (sacrifice_count);
626 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
627 eat_item (op, improver->slaying, sacrifice_count); 626 eat_item (op, improver->slaying, sacrifice_count);
628 627
629 new_draw_info_format (NDI_UNIQUE, 0, op, "Your *%s may be improved %d times.", &weapon->name, weapon->level); 628 op->statusmsg (format (
629 "Your sacrifice was accepted."
630 "Your *%s may be improved %d times.",
631 &weapon->name, weapon->level
632 ));
630 633
631 sprintf (buf, "%s's %s", &op->name, &weapon->name); 634 sprintf (buf, "%s's %s", &op->name, &weapon->name);
632 weapon->name = weapon->name_pl = buf; 635 weapon->name = weapon->name_pl = buf;
633 weapon->nrof = 0; /* prevents preparing n weapons in the same 636 weapon->nrof = 0; /* prevents preparing n weapons in the same
634 slot at once! */ 637 slot at once! */
635 decrease_ob (improver); 638 improver->decrease ();
636 weapon->last_eat = 0; 639 weapon->last_eat = 0;
637 return 1; 640 return 1;
638} 641}
639
640 642
641/** 643/**
642 * Does the dirty job for 'improve weapon' scroll, prepare or add something. 644 * Does the dirty job for 'improve weapon' scroll, prepare or add something.
643 * This is the new improve weapon code. 645 * This is the new improve weapon code.
644 * Returns 0 if it was not able to work for some reason. 646 * Returns 0 if it was not able to work for some reason.
… …
653improve_weapon (object *op, object *improver, object *weapon) 655improve_weapon (object *op, object *improver, object *weapon)
654{ 656{
655 int sacrifice_count, sacrifice_needed = 0; 657 int sacrifice_count, sacrifice_needed = 0;
656 658
657 if (improver->stats.sp == IMPROVE_PREPARE) 659 if (improver->stats.sp == IMPROVE_PREPARE)
658 {
659 return prepare_weapon (op, improver, weapon); 660 return prepare_weapon (op, improver, weapon);
660 } 661
661 if (weapon->level == 0) 662 if (weapon->level == 0)
662 { 663 {
663 new_draw_info (NDI_UNIQUE, 0, op, "This weapon has not been prepared."); 664 op->failmsg ("This weapon has not been prepared. H<You first ahve to prepare a weapon with a prepare weapon scroll.>");
664 return 0; 665 return 0;
665 } 666 }
667
666 if (weapon->level == weapon->last_eat && weapon->item_power >= 100) 668 if (weapon->level == weapon->last_eat && weapon->item_power >= 100)
667 { 669 {
668 new_draw_info (NDI_UNIQUE, 0, op, "This weapon cannot be improved any more."); 670 op->failmsg ("This weapon cannot be improved any more.");
669 return 0; 671 return 0;
670 } 672 }
673
671 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1)) 674 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1))
672 { 675 {
673 new_draw_info (NDI_UNIQUE, 0, op, "Improving the weapon will make it too"); 676 op->failmsg ("Improving the weapon will make it too "
674 new_draw_info (NDI_UNIQUE, 0, op, "powerful for you to use. Unready it if you"); 677 "powerful for you to use. Unready it if you "
675 new_draw_info (NDI_UNIQUE, 0, op, "really want to improve it."); 678 "really want to improve it.");
676 return 0; 679 return 0;
677 } 680 }
681
678 /* This just increases damage by 5 points, no matter what. No sacrifice 682 /* This just increases damage by 5 points, no matter what. No sacrifice
679 * is needed. Since stats.dam is now a 16 bit value and not 8 bit, 683 * is needed. Since stats.dam is now a 16 bit value and not 8 bit,
680 * don't put any maximum value on damage - the limit is how much the 684 * don't put any maximum value on damage - the limit is how much the
681 * weapon can be improved. 685 * weapon can be improved.
682 */ 686 */
683 if (improver->stats.sp == IMPROVE_DAMAGE) 687 if (improver->stats.sp == IMPROVE_DAMAGE)
684 { 688 {
685 weapon->stats.dam += 5; 689 weapon->stats.dam += 5;
686 weapon->weight += 5000; /* 5 KG's */ 690 weapon->weight += 5000; /* 5 KG's */
687 new_draw_info_format (NDI_UNIQUE, 0, op, "Damage has been increased by 5 to %d", weapon->stats.dam); 691 op->statusmsg (format ("Damage has been increased by 5 to %d.", weapon->stats.dam));
688 weapon->last_eat++; 692 weapon->last_eat++;
689 693
690 weapon->item_power++; 694 weapon->item_power++;
691 decrease_ob (improver); 695 improver->decrease ();
692 return 1; 696 return 1;
693 } 697 }
698
694 if (improver->stats.sp == IMPROVE_WEIGHT) 699 if (improver->stats.sp == IMPROVE_WEIGHT)
695 { 700 {
696 /* Reduce weight by 20% */ 701 /* Reduce weight by 20% */
697 weapon->weight = (weapon->weight * 8) / 10; 702 weapon->weight = (weapon->weight * 8) / 10;
698 if (weapon->weight < 1) 703 if (weapon->weight < 1)
699 weapon->weight = 1; 704 weapon->weight = 1;
705
700 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon weight reduced to %6.1f kg", (float) weapon->weight / 1000.0); 706 op->statusmsg (format ("Weapon weight reduced to %6.1fkg.", (float) weapon->weight / 1000.0));
701 weapon->last_eat++; 707 weapon->last_eat++;
702 weapon->item_power++; 708 weapon->item_power++;
703 decrease_ob (improver); 709 improver->decrease ();
704 return 1; 710 return 1;
705 } 711 }
706 if (improver->stats.sp == IMPROVE_ENCHANT) 712 if (improver->stats.sp == IMPROVE_ENCHANT)
707 { 713 {
708 weapon->magic++; 714 weapon->magic++;
709 weapon->last_eat++; 715 weapon->last_eat++;
710 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon magic increased to %d", weapon->magic); 716 op->statusmsg (format ("Weapon magic increased to %d.", weapon->magic));
711 decrease_ob (improver); 717 improver->decrease ();
712 weapon->item_power++; 718 weapon->item_power++;
713 return 1; 719 return 1;
714 } 720 }
715 721
716 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex + 722 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex +
… …
721 sacrifice_needed *= 2; 727 sacrifice_needed *= 2;
722 728
723 sacrifice_count = check_sacrifice (op, improver); 729 sacrifice_count = check_sacrifice (op, improver);
724 if (sacrifice_count < sacrifice_needed) 730 if (sacrifice_count < sacrifice_needed)
725 { 731 {
726 new_draw_info_format (NDI_UNIQUE, 0, op, "You need at least %d %s", sacrifice_needed, &improver->slaying); 732 op->failmsg (format ("You need at least %d %s.", sacrifice_needed, &improver->slaying));
727 return 0; 733 return 0;
728 } 734 }
735
729 eat_item (op, improver->slaying, sacrifice_needed); 736 eat_item (op, improver->slaying, sacrifice_needed);
730 weapon->item_power++; 737 weapon->item_power++;
731 738
732 switch (improver->stats.sp) 739 switch (improver->stats.sp)
733 { 740 {
734 case IMPROVE_STR:
735 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Str), 1, "strength"); 741 case IMPROVE_STR: return improve_weapon_stat (op, improver, weapon, weapon->stats.Str, 1, "strength");
736 case IMPROVE_DEX:
737 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Dex), 1, "dexterity"); 742 case IMPROVE_DEX: return improve_weapon_stat (op, improver, weapon, weapon->stats.Dex, 1, "dexterity");
738 case IMPROVE_CON:
739 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Con), 1, "constitution"); 743 case IMPROVE_CON: return improve_weapon_stat (op, improver, weapon, weapon->stats.Con, 1, "constitution");
740 case IMPROVE_WIS:
741 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Wis), 1, "wisdom"); 744 case IMPROVE_WIS: return improve_weapon_stat (op, improver, weapon, weapon->stats.Wis, 1, "wisdom");
742 case IMPROVE_CHA:
743 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Cha), 1, "charisma"); 745 case IMPROVE_CHA: return improve_weapon_stat (op, improver, weapon, weapon->stats.Cha, 1, "charisma");
744 case IMPROVE_INT:
745 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Int), 1, "intelligence"); 746 case IMPROVE_INT: return improve_weapon_stat (op, improver, weapon, weapon->stats.Int, 1, "intelligence");
746 case IMPROVE_POW:
747 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Pow), 1, "power"); 747 case IMPROVE_POW: return improve_weapon_stat (op, improver, weapon, weapon->stats.Pow, 1, "power");
748 default: 748 default:
749 new_draw_info (NDI_UNIQUE, 0, op, "Unknown improvement type."); 749 op->failmsg ("Unknown improvement type.");
750 } 750 }
751
751 LOG (llevError, "improve_weapon: Got to end of function\n"); 752 LOG (llevError, "improve_weapon: Got to end of function\n");
752 return 0; 753 return 0;
753} 754}
754 755
755/** 756/**
… …
762{ 763{
763 object *otmp; 764 object *otmp;
764 765
765 if (op->type != PLAYER) 766 if (op->type != PLAYER)
766 return 0; 767 return 0;
768
767 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 769 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC))
768 { 770 {
769 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 771 op->failmsg ("Something blocks the magic of the scroll!");
770 return 0; 772 return 0;
771 } 773 }
774
772 otmp = find_marked_object (op); 775 otmp = find_marked_object (op);
773 if (!otmp) 776 if (!otmp)
774 { 777 {
775 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark a weapon object."); 778 op->failmsg ("You need to mark a weapon object. H<Use the mark command or the mark option from the item popup menu.>");
776 return 0; 779 return 0;
777 } 780 }
781
778 if (otmp->type != WEAPON && otmp->type != BOW) 782 if (otmp->type != WEAPON && otmp->type != BOW)
779 { 783 {
780 new_draw_info (NDI_UNIQUE, 0, op, "Marked item is not a weapon or bow"); 784 op->failmsg ("Marked item is not a weapon or bow!");
781 return 0; 785 return 0;
782 } 786 }
783 new_draw_info (NDI_UNIQUE, 0, op, "Applied weapon builder."); 787
788 op->statusmsg ("Applied weapon builder.");
789
784 improve_weapon (op, tmp, otmp); 790 improve_weapon (op, tmp, otmp);
785 esrv_send_item (op, otmp); 791 esrv_send_item (op, otmp);
786 return 1; 792 return 1;
787} 793}
788 794
… …
813{ 819{
814 object *tmp; 820 object *tmp;
815 821
816 if (armour->magic >= settings.armor_max_enchant) 822 if (armour->magic >= settings.armor_max_enchant)
817 { 823 {
818 new_draw_info (NDI_UNIQUE, 0, op, "This armour can not be enchanted any further."); 824 op->failmsg ("This armour can not be enchanted any further!");
819 return 0; 825 return 0;
820 } 826 }
827
821 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight, 828 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight,
822 * etc), so take the easy way out and don't worry about it. 829 * etc), so take the easy way out and don't worry about it.
823 * Note - maybe add scrolls which make the random artifact versions (eg, armour 830 * Note - maybe add scrolls which make the random artifact versions (eg, armour
824 * of gnarg and what not?) 831 * of gnarg and what not?)
825 */ 832 */
826 if (armour->title) 833 if (armour->title)
827 { 834 {
828 new_draw_info (NDI_UNIQUE, 0, op, "This armour will not accept further enchantment."); 835 op->failmsg ("This armour will not accept further enchantment.");
829 return 0; 836 return 0;
830 } 837 }
831 838
832 /* Split objects if needed. Can't insert tmp until the 839 /* Split objects if needed. Can't insert tmp until the
833 * end of this function - otherwise it will just re-merge. 840 * end of this function - otherwise it will just re-merge.
834 */ 841 */
835 if (armour->nrof > 1) 842 tmp = armour->nrof > 1 ? armour->split (armour->nrof - 1) : 0;
836 tmp = get_split_ob (armour, armour->nrof - 1);
837 else
838 tmp = NULL;
839 843
840 armour->magic++; 844 armour->magic++;
841 845
842 if (!settings.armor_speed_linear) 846 if (!settings.armor_speed_linear)
843 { 847 {
… …
848 { 852 {
849 base = base - (base * settings.armor_speed_improvement) / 100; 853 base = base - (base * settings.armor_speed_improvement) / 100;
850 pow++; 854 pow++;
851 } 855 }
852 856
853 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * base) / 100; 857 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * base) / 100;
854 } 858 }
855 else 859 else
856 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * (100 + armour->magic * settings.armor_speed_improvement)) / 100; 860 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * (100 + armour->magic * settings.armor_speed_improvement)) / 100;
857 861
858 if (!settings.armor_weight_linear) 862 if (!settings.armor_weight_linear)
859 { 863 {
860 int base = 100; 864 int base = 100;
861 int pow = 0; 865 int pow = 0;
… …
864 { 868 {
865 base = base - (base * settings.armor_weight_reduction) / 100; 869 base = base - (base * settings.armor_weight_reduction) / 100;
866 pow++; 870 pow++;
867 } 871 }
868 872
869 armour->weight = (armour->arch->clone.weight * base) / 100; 873 armour->weight = (armour->arch->weight * base) / 100;
870 } 874 }
871 else 875 else
872 armour->weight = (armour->arch->clone.weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100; 876 armour->weight = (armour->arch->weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100;
873 877
874 if (armour->weight <= 0) 878 if (armour->weight <= 0)
875 { 879 {
876 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n."); 880 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n.");
877 armour->weight = 1; 881 armour->weight = 1;
878 } 882 }
879 883
880 armour->item_power = get_power_from_ench (armour->arch->clone.item_power + armour->magic); 884 armour->item_power = get_power_from_ench (armour->arch->item_power + armour->magic);
881 885
882 if (op->type == PLAYER) 886 if (op->type == PLAYER)
883 { 887 {
884 esrv_send_item (op, armour); 888 esrv_send_item (op, armour);
889
885 if (QUERY_FLAG (armour, FLAG_APPLIED)) 890 if (QUERY_FLAG (armour, FLAG_APPLIED))
886 op->update_stats (); 891 op->update_stats ();
887 } 892 }
888 decrease_ob (improver); 893
894 improver->decrease ();
895
889 if (tmp) 896 if (tmp)
890 { 897 op->insert (tmp);
891 insert_ob_in_ob (tmp, op); 898
892 esrv_send_item (op, tmp);
893 }
894 return 1; 899 return 1;
895} 900}
896
897 901
898/* 902/*
899 * convert_item() returns 1 if anything was converted, 0 if the item was not 903 * convert_item() returns 1 if anything was converted, 0 if the item was not
900 * what the converter wants, -1 if the converter is broken. 904 * what the converter wants, -1 if the converter is broken.
901 */ 905 *
902#define CONV_FROM(xyz) xyz->slaying
903#define CONV_TO(xyz) xyz->other_arch
904#define CONV_NR(xyz) xyz->stats.sp
905#define CONV_NEED(xyz) xyz->stats.food
906
907/* Takes one items and makes another. 906 * Takes one type of items and makes another.
908 * converter is the object that is doing the conversion. 907 * converter is the object that is doing the conversion.
909 * item is the object that triggered the converter - if it is not 908 * item is the object that triggered the converter - if it is not
910 * what the converter wants, this will not do anything. 909 * what the converter wants, this will not do anything.
911 */ 910 */
912int 911static int
913convert_item (object *item, object *converter) 912convert_item (object *item, object *converter)
914{ 913{
915 int nr = 0;
916 uint32 price_in; 914 sint64 nr, price_in;
915
916 if (item->flag [FLAG_UNPAID])
917 return 0;
918
919 shstr conv_from = converter->slaying;
920 archetype *conv_to = converter->other_arch;
921 sint64 need = converter->stats.food;
922 sint64 give = converter->stats.sp;
917 923
918 /* We make some assumptions - we assume if it takes money as it type, 924 /* We make some assumptions - we assume if it takes money as it type,
919 * it wants some amount. We don't make change (ie, if something costs 925 * it wants some amount. We don't make change (ie, if something costs
920 * 3 gp and player drops a platinum, tough luck) 926 * 3 gp and player drops a platinum, tough luck)
921 */ 927 */
922 if (!strcmp (CONV_FROM (converter), "money")) 928 if (conv_from == shstr_money)
923 { 929 {
924 int cost;
925
926 if (item->type != MONEY) 930 if (item->type != MONEY)
927 return 0; 931 return 0;
928 932
929 nr = (item->nrof * item->value) / CONV_NEED (converter); 933 nr = sint64 (item->nrof) * item->value / need;
930 if (!nr) 934 if (!nr)
931 return 0; 935 return 0;
932 cost = nr * CONV_NEED (converter) / item->value; 936
933 /* take into account rounding errors */ 937 converter->play_sound (sound_find ("shop_buy"));
934 if (nr * CONV_NEED (converter) % item->value) 938
935 cost++; 939 sint64 cost = (nr * need + item->value - 1) / item->value;
936 decrease_ob_nr (item, cost); 940
941 item->decrease (cost);
937 942
938 price_in = cost * item->value; 943 price_in = cost * item->value;
939 } 944 }
940 else 945 else
941 { 946 {
942 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->name || 947 if (item->type == PLAYER
943 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof)) 948 || conv_from != item->arch->archname
949 || (need && need > (uint16) item->nrof))
944 return 0; 950 return 0;
945 951
946 if (CONV_NEED (converter)) 952 converter->play_sound (sound_find ("convert_item"));
953
954 if (need)
947 { 955 {
948 nr = item->nrof / CONV_NEED (converter); 956 nr = sint64 (item->nrof) / need;
949 decrease_ob_nr (item, nr * CONV_NEED (converter)); 957 item->decrease (nr * need);
950 price_in = nr * CONV_NEED (converter) * item->value; 958 price_in = nr * need * item->value;
951 } 959 }
952 else 960 else
953 { 961 {
954 price_in = item->value; 962 price_in = item->value;
955 item->destroy (); 963 item->destroy ();
956 } 964 }
957 } 965 }
958 966
959 if (converter->inv != NULL) 967 if (converter->inv)
960 { 968 {
961 object *ob; 969 object *ob;
962 int i; 970 int i;
963 object *ob_to_copy; 971 object *ob_to_copy;
964 972
965 /* select random object from inventory to copy */ 973 /* select random object from inventory to copy */
966 ob_to_copy = converter->inv; 974 ob_to_copy = converter->inv;
967 for (ob = converter->inv->below, i = 1; ob != NULL; ob = ob->below, i++) 975 for (ob = converter->inv->below, i = 1; ob; ob = ob->below, i++)
968 {
969 if (rndm (0, i) == 0) 976 if (rndm (0, i) == 0)
970 {
971 ob_to_copy = ob; 977 ob_to_copy = ob;
972 } 978
973 }
974 item = object_create_clone (ob_to_copy); 979 item = object_create_clone (ob_to_copy);
975 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE); 980 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE);
976 unflag_inv (item, FLAG_IS_A_TEMPLATE); 981 unflag_inv (item, FLAG_IS_A_TEMPLATE);
977 } 982 }
978 else 983 else
979 { 984 {
980 if (converter->other_arch == NULL) 985 if (!conv_to)
981 { 986 {
982 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n", 987 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n",
983 &converter->name, converter->map->path, converter->x, converter->y); 988 &converter->name, &converter->map->path, converter->x, converter->y);
984 return -1; 989 return -1;
985 } 990 }
986 991
987 item = object_create_arch (converter->other_arch); 992 item = object_create_arch (conv_to);
988 fix_generated_item (item, converter, 0, 0, GT_MINIMAL); 993 fix_generated_item (item, converter, 0, 0, GT_MINIMAL);
989 } 994 }
990 995
991 if (CONV_NR (converter)) 996 if (give)
992 item->nrof = CONV_NR (converter); 997 item->nrof = give;
998
993 if (nr) 999 if (nr)
994 item->nrof *= nr; 1000 item->nrof *= nr;
1001
995 if (is_in_shop (converter)) 1002 if (is_in_shop (converter))
996 SET_FLAG (item, FLAG_UNPAID); 1003 SET_FLAG (item, FLAG_UNPAID);
997 else if (price_in < item->nrof * item->value) 1004 else if (price_in < sint64 (item->nrof) * item->value)
998 { 1005 {
999 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n", 1006 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n",
1000 &converter->name, converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name); 1007 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name);
1001
1002 /** 1008 /**
1003 * elmex: we are going to let the game continue, as the mapcreator 1009 * elmex: we are going to let the game continue, as the mapcreator
1004 * propably had something in mind when doing this 1010 * hopefully had something in mind when doing this.
1005 */ 1011 */
1006 } 1012 }
1013
1014 SET_FLAG (item, FLAG_IDENTIFIED);
1007 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y); 1015 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y);
1008 return 1; 1016 return 1;
1009} 1017}
1010 1018
1011/** 1019/**
1012 * Handle apply on containers. 1020 * Handle apply on containers.
1013 * By Eneq(@csd.uu.se). 1021 * By Eneq(@csd.uu.se).
1014 * Moved to own function and added many features [Tero.Haatanen@lut.fi] 1022 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1015 * added the alchemical cauldron to the code -b.t. 1023 * added the alchemical cauldron to the code -b.t.
1016 */ 1024 */
1017
1018int 1025int
1019apply_container (object *op, object *sack) 1026apply_container (object *op, object *sack)
1020{ 1027{
1021 char buf[MAX_BUF]; 1028 if (op->type != PLAYER || !op->contr->ns)
1022 object *tmp;
1023
1024 if (op->type != PLAYER)
1025 return 0; /* This might change */ 1029 return 0; /* This might change */
1026 1030
1027 if (sack == NULL || sack->type != CONTAINER) 1031 if (!sack || sack->type != CONTAINER)
1028 { 1032 {
1029 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]"); 1033 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1030 return 0; 1034 return 0;
1031 } 1035 }
1032 1036
1033 op->contr->last_used = 0; 1037 op->contr->last_used = 0;
1034 1038
1035 if (sack->env != op) 1039 if (sack->env && sack->env != op)
1040 {
1041 op->failmsg ("You must put it onto the floor or into your inventory first.");
1042 return 1;
1036 { 1043 }
1037 if (sack->other_arch == NULL || sack->env != NULL) 1044
1045 // already applied == open on ground, or open in inv, or active in inv
1046 if (sack->flag [FLAG_APPLIED])
1047 {
1048 if (op->container == sack)
1038 { 1049 {
1039 new_draw_info (NDI_UNIQUE, 0, op, "You must get it first."); 1050 // open on ground or inv, so close
1051 op->close_container ();
1040 return 1; 1052 return 1;
1041 } 1053 }
1042 1054 else if (!sack->env)
1043 /* It's on the ground, the problems begin */
1044 if (op->container != sack)
1045 {
1046 /* it's closed OR some player has opened it */
1047 if (QUERY_FLAG (sack, FLAG_APPLIED))
1048 {
1049 for (tmp = GET_MAP_OB (sack->map, sack->x, sack->y); tmp && tmp->container != sack; tmp = tmp->above);
1050 if (tmp)
1051 {
1052 /* some other player have opened it */
1053 new_draw_info_format (NDI_UNIQUE, 0, op, "%s is already occupied.", query_name (sack));
1054 return 1;
1055 }
1056 }
1057 } 1055 {
1058 if (QUERY_FLAG (sack, FLAG_APPLIED)) 1056 // active, but not ours: some other player has opened it
1057 op->failmsg (format ("Somebody else is using the %s already.", query_name (sack)));
1058 return 1;
1059 { 1059 }
1060 if (op->container == NULL)
1061 {
1062 tmp = arch_to_object (sack->other_arch);
1063 /* not good, but insert_ob_in_ob() is too smart */
1064 CLEAR_FLAG (tmp, FLAG_REMOVED);
1065 tmp->x = tmp->y = 0;
1066 tmp->map = NULL;
1067 tmp->env = sack;
1068 if (sack->inv)
1069 sack->inv->above = tmp;
1070 tmp->below = sack->inv;
1071 tmp->above = NULL;
1072 sack->inv = tmp;
1073 sack->move_off = MOVE_ALL; /* trying force closing it */
1074 }
1075 else
1076 {
1077 sack->move_off = 0;
1078 tmp = sack->inv;
1079 1060
1080 if (tmp && tmp->type == CLOSE_CON) 1061 // fall through to opening it (active in inv)
1081 tmp->destroy ();
1082 }
1083 }
1084 }
1085
1086 if (QUERY_FLAG (sack, FLAG_APPLIED))
1087 { 1062 }
1063 else if (sack->env)
1064 {
1065 // it is in our env, so activate it, do not open yet
1088 if (op->container) 1066 op->close_container ();
1089 { 1067 sack->flag [FLAG_APPLIED] = 1;
1090 if (op->container != sack) 1068 esrv_update_item (UPD_FLAGS, op, sack);
1091 { 1069 op->statusmsg (format ("You ready %s.", query_name (sack)));
1092 tmp = op->container; 1070 return 1;
1093 apply_container (op, tmp); 1071 }
1094 sprintf (buf, "You close %s and open ", query_name (tmp)); 1072
1095 op->container = sack; 1073 // it's locked?
1096 strcat (buf, query_name (sack)); 1074 if (sack->slaying)
1097 strcat (buf, "."); 1075 {
1098 } 1076 if (object *tmp = find_key (op, op, sack))
1099 else 1077 op->statusmsg (format ("You unlock %s with %s.", query_name (sack), query_name (tmp)));
1100 {
1101 CLEAR_FLAG (sack, FLAG_APPLIED);
1102 op->container = NULL;
1103 sprintf (buf, "You close %s.", query_name (sack));
1104 }
1105 }
1106 else 1078 else
1107 { 1079 {
1108 CLEAR_FLAG (sack, FLAG_APPLIED);
1109 sprintf (buf, "You open %s.", query_name (sack));
1110 SET_FLAG (sack, FLAG_APPLIED);
1111 op->container = sack;
1112 }
1113 }
1114 else
1115 { /* not applied */
1116 if (sack->slaying)
1117 { /* it's locked */
1118 tmp = find_key (op, op, sack);
1119 if (tmp)
1120 {
1121 sprintf (buf, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1122 SET_FLAG (sack, FLAG_APPLIED);
1123
1124 if (sack->env == NULL)
1125 { /* if it's on ground,open it also */
1126 new_draw_info (NDI_UNIQUE, 0, op, buf);
1127 apply_container (op, sack);
1128 return 1;
1129 }
1130 }
1131 else
1132 sprintf (buf, "You don't have the key to unlock %s.", query_name (sack)); 1080 op->statusmsg (format ("You don't have the key to unlock %s.", query_name (sack)));
1133 }
1134 else
1135 {
1136 sprintf (buf, "You readied %s.", query_name (sack));
1137 SET_FLAG (sack, FLAG_APPLIED);
1138
1139 if (sack->env == NULL)
1140 { /* if it's on ground,open it also */
1141 new_draw_info (NDI_UNIQUE, 0, op, buf);
1142 apply_container (op, sack);
1143 return 1; 1081 return 1;
1144 } 1082 }
1145 }
1146 } 1083 }
1147 1084
1148 new_draw_info (NDI_UNIQUE, 0, op, buf); 1085 op->open_container (sack);
1149
1150 if (op->contr)
1151 op->contr->ns->floorbox_update ();
1152 1086
1153 return 1; 1087 return 1;
1154} 1088}
1155
1156/**
1157 * Eneq(@csd.uu.se): Handle apply on containers. This is for containers
1158 * the player has in their inventory, eg, sacks, luggages, etc.
1159 *
1160 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1161 * This version is for client/server mode.
1162 * op is the player, sack is the container the player is opening or closing.
1163 * return 1 if an object is apllied somehow or another, 0 if error/no apply
1164 *
1165 * Reminder - there are three states for any container - closed (non applied),
1166 * applied (not open, but objects that match get tossed into it), and open
1167 * (applied flag set, and op->container points to the open container)
1168 */
1169
1170int
1171esrv_apply_container (object *op, object *sack)
1172{
1173 object *tmp = op->container;
1174
1175 if (op->type != PLAYER)
1176 return 0; /* This might change */
1177
1178 if (sack == NULL || sack->type != CONTAINER)
1179 {
1180 LOG (llevError, "esrv_apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1181 return 0;
1182 }
1183
1184 /* If we have a currently open container, then it needs to be closed in all cases
1185 * if we are opening this one up. We then fall through if appropriate for
1186 * openening the new container.
1187 */
1188
1189 if (op->container && QUERY_FLAG (sack, FLAG_APPLIED))
1190 {
1191 if (op->container->env != op)
1192 { /* if container is on the ground */
1193 op->container->move_off = 0;
1194 }
1195
1196 if (INVOKE_OBJECT (CLOSE, tmp, ARG_OBJECT (op)))
1197 return 1;
1198
1199 new_draw_info_format (NDI_UNIQUE, 0, op, "You close %s.", query_name (op->container));
1200 CLEAR_FLAG (op->container, FLAG_APPLIED);
1201 op->container = NULL;
1202 esrv_update_item (UPD_FLAGS, op, tmp);
1203 if (tmp == sack)
1204 return 1;
1205 }
1206
1207
1208 /* If the player is trying to open it (which he must be doing if we got here),
1209 * and it is locked, check to see if player has the equipment to open it.
1210 */
1211
1212 if (sack->slaying)
1213 { /* it's locked */
1214 tmp = find_key (op, op, sack);
1215 if (tmp)
1216 {
1217 new_draw_info_format (NDI_UNIQUE, 0, op, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1218 }
1219 else
1220 {
1221 new_draw_info_format (NDI_UNIQUE, 0, op, "You don't have the key to unlock %s.", query_name (sack));
1222 return 0;
1223 }
1224 }
1225
1226 /* By the time we get here, we have made sure any other container has been closed and
1227 * if this is a locked container, the player they key to open it.
1228 */
1229
1230 /* There are really two cases - the sack is either on the ground, or the sack is
1231 * part of the players inventory. If on the ground, we assume that the player is
1232 * opening it, since if it was being closed, that would have been taken care of above.
1233 */
1234
1235
1236 if (sack->env != op)
1237 {
1238 /* Hypothetical case - the player is trying to open a sack that belong to someone
1239 * else. This normally should not happen, but a misbehaving client/player could
1240 * try to do it, so lets handle it gracefully.
1241 */
1242 if (sack->env)
1243 {
1244 new_draw_info_format (NDI_UNIQUE, 0, op, "You can't open %s", query_name (sack));
1245 return 0;
1246 }
1247 /* set these so when the player walks off, we can unapply the sack */
1248 sack->move_off = MOVE_ALL; /* trying force closing it */
1249
1250 CLEAR_FLAG (sack, FLAG_APPLIED);
1251 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1252 SET_FLAG (sack, FLAG_APPLIED);
1253 op->container = sack;
1254 esrv_update_item (UPD_FLAGS, op, sack);
1255 esrv_send_inventory (op, sack);
1256
1257 }
1258 else
1259 { /* sack is in players inventory */
1260 if (QUERY_FLAG (sack, FLAG_APPLIED))
1261 { /* readied sack becoming open */
1262 CLEAR_FLAG (sack, FLAG_APPLIED);
1263 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1264 SET_FLAG (sack, FLAG_APPLIED);
1265 op->container = sack;
1266 esrv_update_item (UPD_FLAGS, op, sack);
1267 esrv_send_inventory (op, sack);
1268 }
1269 else
1270 {
1271 CLEAR_FLAG (sack, FLAG_APPLIED);
1272 new_draw_info_format (NDI_UNIQUE, 0, op, "You readied %s.", query_name (sack));
1273 SET_FLAG (sack, FLAG_APPLIED);
1274 esrv_update_item (UPD_FLAGS, op, sack);
1275 }
1276 }
1277 return 1;
1278}
1279
1280 1089
1281/** 1090/**
1282 * Handles dropping things on altar. 1091 * Handles dropping things on altar.
1283 * Returns true if sacrifice was accepted. 1092 * Returns true if sacrifice was accepted.
1284 */ 1093 */
… …
1295 * with an altar. We call it a Potion - altars are stationary - it 1104 * with an altar. We call it a Potion - altars are stationary - it
1296 * is up to map designers to use them properly. 1105 * is up to map designers to use them properly.
1297 */ 1106 */
1298 if (altar->inv && altar->inv->type == SPELL) 1107 if (altar->inv && altar->inv->type == SPELL)
1299 { 1108 {
1300 new_draw_info_format (NDI_BLACK, 0, originator, "The altar casts %s.", &altar->inv->name); 1109 originator->statusmsg (format ("The altar casts %s.", &altar->inv->name));
1301 cast_spell (originator, altar, 0, altar->inv, NULL); 1110 cast_spell (originator, altar, 0, altar->inv, NULL);
1302 /* If it is connected, push the button. Fixes some problems with 1111 /* If it is connected, push the button. Fixes some problems with
1303 * old maps. 1112 * old maps.
1304 */ 1113 */
1305 1114
1306/* push_button (altar);*/ 1115/* push_button (altar);*/
1307 } 1116 }
… …
1331 double opinion; 1140 double opinion;
1332 object *tmp, *next; 1141 object *tmp, *next;
1333 1142
1334 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */ 1143 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */
1335 1144
1145 bool has_unpaid = false;
1146
1147 // quite inefficient to do this here twice, but the api doesn'T lend itself to
1148 // a quick and small change :(
1149 for (object::depth_iterator item = op->begin (); item != op->end (); ++item)
1150 if (item->flag [FLAG_UNPAID])
1151 {
1152 has_unpaid = true;
1153 break;
1154 }
1155
1336 if (op->type != PLAYER) 1156 if (op->type != PLAYER)
1337 { 1157 {
1338 /* Remove all the unpaid objects that may be carried here. 1158 /* Remove all the unpaid objects that may be carried here.
1339 * This could be pets or monsters that are somehow in 1159 * This could be pets or monsters that are somehow in
1340 * the shop. 1160 * the shop.
… …
1366 /* unpaid objects, or non living objects, can't transfer by 1186 /* unpaid objects, or non living objects, can't transfer by
1367 * shop mats. Instead, put it on a nearby space. 1187 * shop mats. Instead, put it on a nearby space.
1368 */ 1188 */
1369 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE)) 1189 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE))
1370 { 1190 {
1371
1372 /* Somebody dropped an unpaid item, just move to an adjacent place. */ 1191 /* Somebody dropped an unpaid item, just move to an adjacent place. */
1373 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1192 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1374 1193
1375 if (i != -1) 1194 if (i != -1)
1376 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat); 1195 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat);
… …
1385 else if (can_pay (op) && get_payment (op)) 1204 else if (can_pay (op) && get_payment (op))
1386 { 1205 {
1387 /* this is only used for players */ 1206 /* this is only used for players */
1388 rv = teleport (shop_mat, SHOP_MAT, op); 1207 rv = teleport (shop_mat, SHOP_MAT, op);
1389 1208
1209 if (has_unpaid)
1210 op->contr->play_sound (sound_find ("shop_buy"));
1211 else if (is_in_shop (op))
1212 op->contr->play_sound (sound_find ("shop_enter"));
1213 else
1214 op->contr->play_sound (sound_find ("shop_leave"));
1215
1390 if (shop_mat->msg) 1216 if (shop_mat->msg)
1391 new_draw_info (NDI_UNIQUE, 0, op, shop_mat->msg); 1217 op->statusmsg (shop_mat->msg);
1392 /* This check below is a bit simplistic - generally it should be correct, 1218 /* This check below is a bit simplistic - generally it should be correct,
1393 * but there is never a guarantee that the bottom space on the map is 1219 * but there is never a guarantee that the bottom space on the map is
1394 * actually the shop floor. 1220 * actually the shop floor.
1395 */ 1221 */
1396 else if (!rv && !is_in_shop (op)) 1222 else if (!rv && !is_in_shop (op))
1397 { 1223 {
1398 opinion = shopkeeper_approval (op->map, op); 1224 opinion = shopkeeper_approval (op->map, op);
1399 1225
1400 if (opinion > 0.9) 1226 op->statusmsg (
1401 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper gives you a friendly wave."); 1227 opinion >= 0.90 ? "The shopkeeper gives you a friendly wave."
1402 else if (opinion > 0.75) 1228 : opinion >= 0.75 ? "The shopkeeper waves to you."
1403 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper waves to you."); 1229 : opinion >= 0.50 ? "The shopkeeper ignores you."
1404 else if (opinion > 0.5) 1230 : "The shopkeeper glares at you with contempt."
1405 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper ignores you.");
1406 else 1231 );
1407 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper glares at you with contempt.");
1408 } 1232 }
1409 } 1233 }
1410 else 1234 else
1411 { 1235 {
1412 /* if we get here, a player tried to leave a shop but was not able 1236 /* if we get here, a player tried to leave a shop but was not able
1413 * to afford the items he has. We try to move the player so that 1237 * to afford the items he has. We try to move the player so that
1414 * they are not on the mat anymore 1238 * they are not on the mat anymore
1415 */ 1239 */
1416 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1240 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1417 1241
1418 if (i == -1) 1242 if (i == -1)
1419 {
1420 LOG (llevError, "Internal shop-mat problem.\n"); 1243 LOG (llevError, "Internal shop-mat problem.\n");
1421 }
1422 else 1244 else
1423 { 1245 {
1424 op->remove (); 1246 op->remove ();
1425 op->x += freearr_x[i]; 1247 op->x += freearr_x[i];
1426 op->y += freearr_y[i]; 1248 op->y += freearr_y[i];
… …
1437 */ 1259 */
1438static void 1260static void
1439apply_sign (object *op, object *sign, int autoapply) 1261apply_sign (object *op, object *sign, int autoapply)
1440{ 1262{
1441 readable_message_type *msgType; 1263 readable_message_type *msgType;
1442 char newbuf[HUGE_BUF];
1443 1264
1444 if (sign->msg == NULL) 1265 if (!sign->msg)
1445 { 1266 {
1446 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it."); 1267 op->statusmsg ("Nothing is written on it.");
1447 return; 1268 return;
1448 } 1269 }
1449 1270
1450 if (sign->stats.food) 1271 if (sign->stats.food)
1451 { 1272 {
1452 if (sign->last_eat >= sign->stats.food) 1273 if (sign->last_eat >= sign->stats.food)
1453 { 1274 {
1454 if (!sign->move_on) 1275 if (!sign->move_on)
1455 new_draw_info (NDI_UNIQUE, 0, op, "You cannot read it anymore."); 1276 op->statusmsg ("You cannot read it anymore.");
1277
1456 return; 1278 return;
1457 } 1279 }
1458 1280
1459 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1281 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1460 sign->last_eat++; 1282 sign->last_eat++;
… …
1465 * move_on is zero, it needs to be manually applied (doesn't talk 1287 * move_on is zero, it needs to be manually applied (doesn't talk
1466 * to us). 1288 * to us).
1467 */ 1289 */
1468 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on) 1290 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on)
1469 { 1291 {
1470 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1292 op->failmsg ("You are unable to read while blind!");
1471 return; 1293 return;
1472 } 1294 }
1295
1296 if (op->contr)
1297 if (client *ns = op->contr->ns)
1298 {
1299 if (sign->sound)
1300 ns->play_sound (sign->sound);
1301 else if (autoapply)
1302 ns->play_sound (sound_find ("msg_voice"));
1303
1304 if (ns->can_msg)
1305 op->contr->infobox (MSG_CHANNEL ("examine"), format ("T<%s>\n\n\n\n%s", &sign->name, &sign->msg));
1306 else
1307 {
1473 msgType = get_readable_message_type (sign); 1308 msgType = get_readable_message_type (sign);
1474 snprintf (newbuf, sizeof (newbuf), "%hhu %s", autoapply ? 1 : 0, &sign->msg); 1309 const char *somemsg = format ("%u %s", autoapply ? 1 : 0, &sign->msg);
1475 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg); 1310 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, somemsg, &sign->msg);
1311 }
1312 }
1476} 1313}
1477 1314
1478/** 1315/**
1479 * 'victim' moves onto 'trap' 1316 * 'victim' moves onto 'trap'
1480 * 'victim' leaves 'trap' 1317 * 'victim' leaves 'trap'
… …
1503 * proper. This code was causing needless crashes. 1340 * proper. This code was causing needless crashes.
1504 */ 1341 */
1505 if (recursion_depth >= 500) 1342 if (recursion_depth >= 500)
1506 { 1343 {
1507 LOG (llevDebug, "WARNING: move_apply(): aborting recursion " 1344 LOG (llevDebug, "WARNING: move_apply(): aborting recursion "
1508 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->name, &trap->name, &victim->arch->name, &victim->name); 1345 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->archname, &trap->name, &victim->arch->archname, &victim->name);
1509 return; 1346 return;
1510 } 1347 }
1348
1511 recursion_depth++; 1349 recursion_depth++;
1512 if (trap->head) 1350 if (trap->head)
1513 trap = trap->head; 1351 trap = trap->head;
1514 1352
1515 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator))) 1353 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator)))
… …
1530 1368
1531 /* Just put in some sanity check. I think there is a bug in the 1369 /* Just put in some sanity check. I think there is a bug in the
1532 * above with some objects have zero speed, and thus the player 1370 * above with some objects have zero speed, and thus the player
1533 * getting permanently paralyzed. 1371 * getting permanently paralyzed.
1534 */ 1372 */
1535 if (victim->speed_left < -50.0) 1373 if (victim->speed_left < -50.f)
1536 victim->speed_left = -50.0; 1374 victim->speed_left = -50.f;
1537 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */ 1375 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */
1538 } 1376 }
1539 goto leave; 1377 goto leave;
1540 1378
1541 case SPINNER: 1379 case SPINNER:
… …
1591 1429
1592 if (!trap->value) 1430 if (!trap->value)
1593 { 1431 {
1594 int tot; 1432 int tot;
1595 1433
1596 for (ab = trap->above, tot = 0; ab != NULL; ab = ab->above) 1434 for (ab = trap->above, tot = 0; ab; ab = ab->above)
1597 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1435 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1598 tot += (ab->nrof ? ab->nrof : 1) * ab->weight + ab->carrying; 1436 tot += ab->head_ ()->total_weight ();
1599 1437
1600 if (!(trap->value = (tot > trap->weight) ? 1 : 0)) 1438 if (!(trap->value = (tot > trap->weight) ? 1 : 0))
1601 goto leave; 1439 goto leave;
1602 1440
1603 SET_ANIMATION (trap, trap->value); 1441 SET_ANIMATION (trap, trap->value);
… …
1613 1451
1614 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1452 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1615 { 1453 {
1616 if (!sound_was_played) 1454 if (!sound_was_played)
1617 { 1455 {
1618 play_sound_map (trap->map, trap->x, trap->y, SOUND_FALL_HOLE); 1456 trap->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1619 sound_was_played = 1; 1457 sound_was_played = 1;
1620 } 1458 }
1621 new_draw_info (NDI_UNIQUE, 0, ab, "You fall into a trapdoor!"); 1459
1460 ab->statusmsg ("You fall into a trapdoor!", NDI_RED);
1622 transfer_ob (ab, (int) EXIT_X (trap), (int) EXIT_Y (trap), 0, ab); 1461 transfer_ob (ab, EXIT_X (trap), EXIT_Y (trap), 0, ab);
1623 } 1462 }
1624 } 1463 }
1625 goto leave; 1464 goto leave;
1626 } 1465 }
1627 1466
1628
1629 case CONVERTER: 1467 case CONVERTER:
1630 if (convert_item (victim, trap) < 0) 1468 if (convert_item (victim, trap) < 0)
1631 { 1469 {
1632 object *op; 1470 originator->failmsg (format ("The %s seems to be broken!", query_name (trap)));
1633 1471 get_archetype ("burnout")->insert_at (trap, trap);
1634 new_draw_info_format (NDI_UNIQUE, 0, originator, "The %s seems to be broken!", query_name (trap));
1635
1636 op = get_archetype ("burnout");
1637 if (op != NULL)
1638 {
1639 op->x = trap->x;
1640 op->y = trap->y;
1641 insert_ob_in_map (op, trap->map, trap, 0);
1642 }
1643 } 1472 }
1473
1644 goto leave; 1474 goto leave;
1645 1475
1646 case TRIGGER_BUTTON: 1476 case TRIGGER_BUTTON:
1647 case TRIGGER_PEDESTAL: 1477 case TRIGGER_PEDESTAL:
1648 case TRIGGER_ALTAR: 1478 case TRIGGER_ALTAR:
… …
1666 * Processing will happen if the head runs into the pit 1496 * Processing will happen if the head runs into the pit
1667 */ 1497 */
1668 if (victim->head) 1498 if (victim->head)
1669 goto leave; 1499 goto leave;
1670 1500
1671 play_sound_map (victim->map, victim->x, victim->y, SOUND_FALL_HOLE); 1501 victim->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1672 new_draw_info (NDI_UNIQUE, 0, victim, "You fall through the hole!\n"); 1502 victim->statusmsg ("You fall through the hole!", NDI_RED);
1673 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim); 1503 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim);
1674 goto leave; 1504 goto leave;
1675 1505
1676 case EXIT: 1506 case EXIT:
1677 if (victim->type == PLAYER && EXIT_PATH (trap)) 1507 if (victim->type == PLAYER && EXIT_PATH (trap))
1678 { 1508 {
1679 /* Basically, don't show exits leading to random maps the 1509 /* Basically, don't show exits leading to random maps the
1680 * players output. 1510 * players output.
1681 */ 1511 */
1682 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2) && strncmp (EXIT_PATH (trap), "/random/", 8)) 1512 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2))
1683 new_draw_info (NDI_NAVY, 0, victim, trap->msg); 1513 victim->statusmsg (trap->msg, NDI_NAVY);
1514
1515 trap->play_sound (trap->sound);
1684 enter_exit (victim, trap); 1516 victim->enter_exit (trap);
1685 } 1517 }
1686 goto leave; 1518 goto leave;
1687 1519
1688 case ENCOUNTER: 1520 case ENCOUNTER:
1689 /* may be some leftovers on this */ 1521 /* may be some leftovers on this */
… …
1704 1536
1705 apply_sign (victim, trap, 1); 1537 apply_sign (victim, trap, 1);
1706 goto leave; 1538 goto leave;
1707 1539
1708 case CONTAINER: 1540 case CONTAINER:
1709 if (victim->type == PLAYER)
1710 (void) esrv_apply_container (victim, trap);
1711 else
1712 (void) apply_container (victim, trap); 1541 apply_container (victim, trap);
1713 goto leave; 1542 goto leave;
1714 1543
1715 case RUNE: 1544 case RUNE:
1716 case TRAP: 1545 case TRAP:
1717 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE)) 1546 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE))
1718 {
1719 spring_trap (trap, victim); 1547 spring_trap (trap, victim);
1720 }
1721 goto leave; 1548 goto leave;
1722 1549
1723 default: 1550 default:
1724 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not " 1551 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not "
1725 "handled in move_apply()\n", &trap->name, &trap->arch->name, trap->type); 1552 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type);
1726 goto leave; 1553 goto leave;
1727 } 1554 }
1728 1555
1729leave: 1556leave:
1730 recursion_depth--; 1557 recursion_depth--;
… …
1739 int lev_diff; 1566 int lev_diff;
1740 object *skill_ob; 1567 object *skill_ob;
1741 1568
1742 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1569 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1743 { 1570 {
1744 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1571 op->failmsg ("You are unable to read while blind!");
1745 return; 1572 return;
1746 } 1573 }
1574
1747 if (tmp->msg == NULL) 1575 if (!tmp->msg)
1748 { 1576 {
1749 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name); 1577 op->failmsg (format ("You open the %s and find it empty.", &tmp->name));
1750 return; 1578 return;
1751 } 1579 }
1752 1580
1753 /* need a literacy skill to read stuff! */ 1581 /* need a literacy skill to read stuff! */
1754 skill_ob = find_skill_by_name (op, tmp->skill); 1582 skill_ob = find_skill_by_name (op, tmp->skill);
1755 if (!skill_ob) 1583 if (!skill_ob)
1756 { 1584 {
1757 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1585 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill to read this.>", &tmp->skill));
1758 return; 1586 return;
1759 } 1587 }
1588
1760 lev_diff = tmp->level - (skill_ob->level + 5); 1589 lev_diff = tmp->level - (skill_ob->level + 5);
1761 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0) 1590 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0)
1762 { 1591 {
1763 if (lev_diff < 2) 1592 op->failmsg (lev_diff < 2 ? "This book is just barely beyond your comprehension."
1764 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension."); 1593 : lev_diff < 3 ? "This book is slightly beyond your comprehension."
1765 else if (lev_diff < 3) 1594 : lev_diff < 5 ? "This book is beyond your comprehension."
1766 new_draw_info (NDI_UNIQUE, 0, op, "This book is slightly beyond your comprehension."); 1595 : lev_diff < 8 ? "This book is quite a bit beyond your comprehension."
1767 else if (lev_diff < 5) 1596 : lev_diff < 15 ? "This book is way beyond your comprehension."
1768 new_draw_info (NDI_UNIQUE, 0, op, "This book is beyond your comprehension."); 1597 : "This book is totally beyond your comprehension.");
1769 else if (lev_diff < 8) 1598 return;
1770 new_draw_info (NDI_UNIQUE, 0, op, "This book is quite a bit beyond your comprehension."); 1599 }
1771 else if (lev_diff < 15) 1600
1772 new_draw_info (NDI_UNIQUE, 0, op, "This book is way beyond your comprehension."); 1601 readable_message_type *msgType = get_readable_message_type (tmp);
1602
1603 if (player *pl = op->contr)
1604 if (client *ns = pl->ns)
1605 if (ns->can_msg)
1606 pl->infobox (MSG_CHANNEL ("book"), format ("T<%s>\n\n\n\n%s", (char *)long_desc (tmp, op), &tmp->msg));
1773 else 1607 else
1774 new_draw_info (NDI_UNIQUE, 0, op, "This book is totally beyond your comprehension.");
1775 return;
1776 }
1777
1778 readable_message_type *msgType = get_readable_message_type (tmp);
1779
1780 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, 1608 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op,
1781 msgType->message_type, msgType->message_subtype, 1609 msgType->message_type, msgType->message_subtype,
1782 "You open the %s and start reading.\n%s", "%s\n%s", long_desc (tmp, op), &tmp->msg); 1610 "You open the %s and start reading.\n%s", (char *)"%s\n%s",
1611 long_desc (tmp, op), &tmp->msg);
1783 1612
1784 /* gain xp from reading */ 1613 /* gain xp from reading */
1785 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT)) 1614 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT))
1786 { /* only if not read before */ 1615 { /* only if not read before */
1787 int exp_gain = calc_skill_exp (op, tmp, skill_ob); 1616 int exp_gain = calc_skill_exp (op, tmp, skill_ob);
… …
1789 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1618 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1790 { 1619 {
1791 /*exp_gain *= 2; because they just identified it too */ 1620 /*exp_gain *= 2; because they just identified it too */
1792 SET_FLAG (tmp, FLAG_IDENTIFIED); 1621 SET_FLAG (tmp, FLAG_IDENTIFIED);
1793 1622
1794 /* If in a container, update how it looks */ 1623 if (object *pl = tmp->visible_to ())
1795 if (tmp->env)
1796 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp); 1624 esrv_update_item (UPD_FLAGS | UPD_NAME, pl, tmp);
1797 else
1798 op->contr->ns->floorbox_update ();
1799 } 1625 }
1800 1626
1801 change_exp (op, exp_gain, skill_ob->skill, 0); 1627 change_exp (op, exp_gain, skill_ob->skill, 0);
1802 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */ 1628 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */
1803 } 1629 }
… …
1808 * op is the person learning the skill, tmp is the skill scroll object 1634 * op is the person learning the skill, tmp is the skill scroll object
1809 */ 1635 */
1810static void 1636static void
1811apply_skillscroll (object *op, object *tmp) 1637apply_skillscroll (object *op, object *tmp)
1812{ 1638{
1813 switch ((int) learn_skill (op, tmp)) 1639 switch (learn_skill (op, tmp))
1814 { 1640 {
1815 case 0: 1641 case 0:
1816 new_draw_info (NDI_UNIQUE, 0, op, "You already possess the knowledge "); 1642 op->play_sound (sound_find ("generic_fail"));
1817 new_draw_info_format (NDI_UNIQUE, 0, op, "held within the %s.\n", query_name (tmp)); 1643 op->failmsg (format ("You already possess the knowledge held within the %s.", query_name (tmp)));
1818 return; 1644 break;
1819 1645
1820 case 1: 1646 case 1:
1821 new_draw_info_format (NDI_UNIQUE, 0, op, "You succeed in learning %s", &tmp->skill);
1822 decrease_ob (tmp); 1647 tmp->decrease ();
1648 op->play_sound (sound_find ("skill_learn"));
1649 op->statusmsg (format ("You succeed in learning %s", &tmp->skill));
1823 return; 1650 break;
1824 1651
1825 default: 1652 default:
1653 tmp->decrease ();
1654 op->play_sound (sound_find ("generic_fail"));
1826 new_draw_info_format (NDI_UNIQUE, 0, op, "You fail to learn the knowledge of the %s.\n", query_name (tmp)); 1655 op->failmsg (format ("You fail to learn the knowledge of the %s.\n", query_name (tmp)));
1827 decrease_ob (tmp);
1828 return; 1656 break;
1829 } 1657 }
1830} 1658}
1831 1659
1832/** 1660/**
1833 * Actually makes op learn spell. 1661 * Actually makes op learn spell.
… …
1853 return; 1681 return;
1854 } 1682 }
1855 return; 1683 return;
1856 } 1684 }
1857 1685
1858 play_sound_player_only (op->contr, SOUND_LEARN_SPELL, 0, 0); 1686 op->contr->play_sound (sound_find ("learn_spell"));
1687
1859 tmp = spell->clone (); 1688 tmp = spell->clone ();
1860 insert_ob_in_ob (tmp, op); 1689 insert_ob_in_ob (tmp, op);
1861 1690
1862 if (special_prayer) 1691 if (special_prayer)
1863 SET_FLAG (tmp, FLAG_STARTEQUIP); 1692 SET_FLAG (tmp, FLAG_STARTEQUIP);
… …
1882 { 1711 {
1883 LOG (llevError, "BUG: do_forget_spell(): spell not known\n"); 1712 LOG (llevError, "BUG: do_forget_spell(): spell not known\n");
1884 return; 1713 return;
1885 } 1714 }
1886 1715
1887 new_draw_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, "You lose knowledge of %s.", spell); 1716 op->failmsg (format ("You lose knowledge of %s.", spell));
1888 player_unready_range_ob (op->contr, spob); 1717 player_unready_range_ob (op->contr, spob);
1889 esrv_remove_spell (op->contr, spob); 1718 esrv_remove_spell (op->contr, spob);
1890 spob->destroy (); 1719 spob->destroy ();
1891} 1720}
1892 1721
… …
1900{ 1729{
1901 object *skop, *spell, *spell_skill; 1730 object *skop, *spell, *spell_skill;
1902 1731
1903 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1732 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1904 { 1733 {
1905 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1734 op->failmsg ("You are unable to read while blind.");
1906 return; 1735 return;
1907 } 1736 }
1908 1737
1909 /* artifact_spellbooks have 'slaying' field point to a spell name, 1738 /* artifact_spellbooks have 'slaying' field point to a spell name,
1910 * instead of having their spell stored in stats.sp. These are 1739 * instead of having their spell stored in stats.sp. These are
1911 * legacy spellbooks 1740 * legacy spellbooks
1912 */ 1741 */
1913
1914 if (tmp->slaying != NULL) 1742 if (tmp->slaying)
1915 { 1743 {
1916 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying)); 1744 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying));
1917 if (!spell) 1745 if (!spell)
1918 { 1746 {
1919 new_draw_info_format (NDI_UNIQUE, 0, op, "The book's formula for %s is incomplete", &tmp->slaying); 1747 op->failmsg (format ("The book's formula for %s is incomplete.", &tmp->slaying));
1920 return; 1748 return;
1921 } 1749 }
1922 else 1750 else
1923 insert_ob_in_ob (spell, tmp); 1751 insert_ob_in_ob (spell, tmp);
1752
1924 tmp->slaying = NULL; 1753 tmp->slaying = 0;
1925 } 1754 }
1926 1755
1927 skop = find_skill_by_name (op, tmp->skill); 1756 skop = find_skill_by_name (op, tmp->skill);
1928 1757
1929 /* need a literacy skill to learn spells. Also, having a literacy level 1758 /* need a literacy skill to learn spells. Also, having a literacy level
1930 * lower than the spell will make learning the spell more difficult */ 1759 * lower than the spell will make learning the spell more difficult */
1931 if (!skop) 1760 if (!skop)
1932 { 1761 {
1933 new_draw_info (NDI_UNIQUE, 0, op, "You can't read! Your attempt fails."); 1762 op->failmsg (format ("You can't read! Your attempt fails. H<You lack the %s skill.>", &tmp->skill));
1934 return; 1763 return;
1935 } 1764 }
1936 1765
1937 spell = tmp->inv; 1766 spell = tmp->inv;
1938 1767
1939 if (!spell) 1768 if (!spell)
1940 { 1769 {
1941 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name); 1770 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name);
1942 new_draw_info (NDI_UNIQUE, 0, op, "The spellbook symbols make no sense."); 1771 op->failmsg ("The spellbook symbols make no sense. This is a bug, please report!");
1943 return; 1772 return;
1944 } 1773 }
1945 1774
1946 if (skop->level < int (sqrtf (spell->level) * 1.5f)) 1775 if (skop->level < int (sqrtf (spell->level) * 1.5f))
1947 { 1776 {
1948 new_draw_info (NDI_UNIQUE, 0, op, "It is too hard to read at your level: You are unable to decipher the strange symbols."); 1777 op->failmsg (format ("You are unable to decipher the strange symbols. H<Your %s level is too low.>", &tmp->skill));
1949 return; 1778 return;
1950 } 1779 }
1951 1780
1952 new_draw_info_format (NDI_UNIQUE, 0, op, "The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name); 1781 op->statusmsg (format ("The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name));
1953 1782
1954 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1783 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1955 {
1956 identify (tmp); 1784 identify (tmp);
1957
1958 if (tmp->env)
1959 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp);
1960 else
1961 op->contr->ns->floorbox_update ();
1962 }
1963 1785
1964 /* I removed the check for special_prayer_mark here - it didn't make 1786 /* I removed the check for special_prayer_mark here - it didn't make
1965 * a lot of sense - special prayers are not found in spellbooks, and 1787 * a lot of sense - special prayers are not found in spellbooks, and
1966 * if the player doesn't know the spell, doesn't make a lot of sense that 1788 * if the player doesn't know the spell, doesn't make a lot of sense that
1967 * they would have a special prayer mark. 1789 * they would have a special prayer mark.
1968 */ 1790 */
1969 if (check_spell_known (op, spell->name)) 1791 if (check_spell_known (op, spell->name))
1970 { 1792 {
1971 new_draw_info (NDI_UNIQUE, 0, op, "You already know that spell.\n"); 1793 op->statusmsg ("You already know that spell. H<It makes no sense to learn spells twice, and would only waste the spellbook.>\n");
1972 return; 1794 return;
1973 } 1795 }
1974 1796
1975 if (spell->skill) 1797 if (spell->skill)
1976 { 1798 {
1977 spell_skill = find_skill_by_name (op, spell->skill); 1799 spell_skill = find_skill_by_name (op, spell->skill);
1978 1800
1979 if (!spell_skill) 1801 if (!spell_skill)
1980 { 1802 {
1981 new_draw_info_format (NDI_UNIQUE, 0, op, "You lack the skill %s to use this spell", &spell->skill); 1803 op->failmsg (format ("You lack the skill %s to use this spell.", &spell->skill));
1982 return; 1804 return;
1983 } 1805 }
1984 1806
1985 if (spell_skill->level < spell->level) 1807 if (spell_skill->level < spell->level)
1986 { 1808 {
1987 new_draw_info_format (NDI_UNIQUE, 0, op, "You need to be level %d in %s to learn this spell.", spell->level, &spell->skill); 1809 op->failmsg (format ("You need to be level %d in %s to learn this spell.", spell->level, &spell->skill));
1988 return; 1810 return;
1989 } 1811 }
1990 } 1812 }
1991 1813
1992 /* Logic as follows 1814 /* Logic as follows
… …
2001 * Overall, chances are the same but a player will find having a high 1823 * Overall, chances are the same but a player will find having a high
2002 * literacy rate very useful! -b.t. 1824 * literacy rate very useful! -b.t.
2003 */ 1825 */
2004 if (QUERY_FLAG (op, FLAG_CONFUSED)) 1826 if (QUERY_FLAG (op, FLAG_CONFUSED))
2005 { 1827 {
2006 new_draw_info (NDI_UNIQUE, 0, op, "In your confused state you flub the wording of the text!"); 1828 op->failmsg ("In your confused state you flub the wording of the text!");
2007 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace)); 1829 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace));
2008 } 1830 }
2009 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || 1831 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) ||
2010 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int]) 1832 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int])
2011 { 1833 {
2012 1834 op->statusmsg ("You succeed in learning the spell!", NDI_GREEN);
2013 new_draw_info (NDI_UNIQUE, 0, op, "You succeed in learning the spell!");
2014 do_learn_spell (op, spell, 0); 1835 do_learn_spell (op, spell, 0);
2015 1836
2016 /* xp gain to literacy for spell learning */ 1837 /* xp gain to literacy for spell learning */
2017 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP)) 1838 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP))
2018 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0); 1839 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0);
2019 } 1840 }
2020 else 1841 else
2021 { 1842 {
2022 play_sound_player_only (op->contr, SOUND_FUMBLE_SPELL, 0, 0); 1843 op->contr->play_sound (sound_find ("fumble_spell"));
2023 new_draw_info (NDI_UNIQUE, 0, op, "You fail to learn the spell.\n"); 1844 op->failmsg ("You fail to learn the spell. H<Wis (priests) or Int (wizards) governs the chance of learning a prayer or spell.>\n");
2024 } 1845 }
2025 decrease_ob (tmp); 1846
1847 tmp->decrease ();
2026} 1848}
2027 1849
2028/** 1850/**
2029 * Handles applying a spell scroll. 1851 * Handles applying a spell scroll.
2030 */ 1852 */
… …
2033{ 1855{
2034 object *skop; 1856 object *skop;
2035 1857
2036 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1858 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
2037 { 1859 {
2038 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1860 op->failmsg ("You are unable to read while blind.");
2039 return; 1861 return;
2040 } 1862 }
2041 1863
2042 if (!tmp->inv || tmp->inv->type != SPELL) 1864 if (!tmp->inv || tmp->inv->type != SPELL)
2043 { 1865 {
2044 new_draw_info (NDI_UNIQUE, 0, op, "The scroll just doesn't make sense!"); 1866 op->failmsg ("The scroll just doesn't make sense! H<...and never will make sense.>");
2045 return; 1867 return;
2046 } 1868 }
2047 1869
2048 if (op->type == PLAYER) 1870 if (op->type == PLAYER)
2049 { 1871 {
… …
2055 */ 1877 */
2056 skop = find_skill_by_name (op, skill_names[SK_LITERACY]); 1878 skop = find_skill_by_name (op, skill_names[SK_LITERACY]);
2057 1879
2058 if (!skop) 1880 if (!skop)
2059 { 1881 {
2060 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1882 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill.>", &skill_names[SK_LITERACY]));
2061 return; 1883 return;
2062 } 1884 }
2063 1885
2064 if ((exp_gain = calc_skill_exp (op, tmp, skop))) 1886 if ((exp_gain = calc_skill_exp (op, tmp, skop)))
2065 change_exp (op, exp_gain, skop->skill, 0); 1887 change_exp (op, exp_gain, skop->skill, 0);
2066 } 1888 }
2067 1889
2068 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1890 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
2069 identify (tmp); 1891 identify (tmp);
2070 1892
2071 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name); 1893 op->statusmsg (format ("The scroll of %s turns to dust.", &tmp->inv->name));
2072
2073 1894
2074 cast_spell (op, tmp, dir, tmp->inv, NULL); 1895 cast_spell (op, tmp, dir, tmp->inv, NULL);
2075 decrease_ob (tmp); 1896 tmp->decrease ();
2076} 1897}
2077 1898
2078/** 1899/**
2079 * Applies a treasure object - by default, chest. op 1900 * Applies a treasure object - by default, chest. op
2080 * is the person doing the applying, tmp is the treasure 1901 * is the person doing the applying, tmp is the treasure
2081 * chest. 1902 * chest.
2082 */ 1903 */
2083static void 1904static void
2084apply_treasure (object *op, object *tmp) 1905apply_treasure (object *op, object *tmp)
2085{ 1906{
2086 object *treas;
2087
2088
2089 /* Nice side effect of new treasure creation method is that the treasure 1907 /* Nice side effect of this treasure creation method is that the treasure
2090 * for the chest is done when the chest is created, and put into the chest 1908 * for the chest is done when the chest is created, and put into the chest
2091 * inventory. So that when the chest burns up, the items still exist. Also 1909 * inventory. So that when the chest burns up, the items still exist. Also
2092 * prevents people fromt moving chests to more difficult maps to get better 1910 * prevents people from moving chests to more difficult maps to get better
2093 * treasure 1911 * treasure
2094 */ 1912 */
2095
2096 treas = tmp->inv; 1913 object *treas = tmp->inv;
2097 if (treas == NULL) 1914
1915 if (!treas)
2098 { 1916 {
2099 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty."); 1917 op->statusmsg ("The chest was empty.");
2100 decrease_ob (tmp); 1918 tmp->decrease ();
2101 return; 1919 return;
2102 } 1920 }
1921
2103 while (tmp->inv) 1922 while (tmp->inv)
2104 { 1923 {
2105 treas = tmp->inv; 1924 treas = tmp->inv;
2106
2107 treas->remove (); 1925 treas->remove ();
2108 new_draw_info_format (NDI_UNIQUE, 0, op, "You find %s in the chest.", query_name (treas));
2109 1926
2110 treas->x = op->x; 1927 treas->x = op->x;
2111 treas->y = op->y; 1928 treas->y = op->y;
2112 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR); 1929 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR);
2113 1930
2114 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE)) 1931 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE))
2115 spring_trap (treas, op); 1932 spring_trap (treas, op);
2116 1933
2117 /* If either player or container was destroyed, no need to do 1934 /* If either player or container was destroyed, no need to do
2118 * further processing. I think this should be enclused with 1935 * further processing. I think this should be enclused with
2119 * spring trap above, as I don't think there is otherwise 1936 * spring trap above, as I don't think there is otherwise
2120 * any way for the treasure chest or player to get killed 1937 * any way for the treasure chest or player to get killed.
2121 */ 1938 */
2122 if (op->destroyed () || tmp->destroyed ()) 1939 if (op->destroyed () || tmp->destroyed ())
2123 break; 1940 break;
2124 } 1941 }
2125 1942
2126 if (!tmp->destroyed () && tmp->inv == NULL) 1943 if (!tmp->destroyed () && !tmp->inv)
2127 decrease_ob (tmp); 1944 tmp->decrease ();
2128
2129} 1945}
2130 1946
2131/** 1947/**
2132 * op eats food. 1948 * op eats food.
2133 * If player, takes care of messages and dragon special food. 1949 * If player, takes care of messages and dragon special food.
… …
2148 { 1964 {
2149 /* usual case - no dragon meal: */ 1965 /* usual case - no dragon meal: */
2150 if (op->stats.food + tmp->stats.food > 999) 1966 if (op->stats.food + tmp->stats.food > 999)
2151 { 1967 {
2152 if (tmp->type == FOOD || tmp->type == FLESH) 1968 if (tmp->type == FOOD || tmp->type == FLESH)
2153 new_draw_info (NDI_UNIQUE, 0, op, "You feel full, but what a waste of food!"); 1969 op->failmsg ("You feel full, but what a waste of food!");
2154 else 1970 else
2155 new_draw_info (NDI_UNIQUE, 0, op, "Most of the drink goes down your face not your throat!"); 1971 op->statusmsg ("Most of the drink goes down your face not your throat!");
2156 } 1972 }
1973
1974 tmp->play_sound (
1975 tmp->sound
1976 ? tmp->sound
1977 : tmp->type == DRINK
1978 ? sound_find ("eat_drink")
1979 : sound_find ("eat_food")
1980 );
2157 1981
2158 if (!QUERY_FLAG (tmp, FLAG_CURSED)) 1982 if (!QUERY_FLAG (tmp, FLAG_CURSED))
2159 { 1983 {
2160 char buf[MAX_BUF]; 1984 const char *buf;
2161 1985
2162 if (!is_dragon_pl (op)) 1986 if (!is_dragon_pl (op))
2163 { 1987 {
2164 /* eating message for normal players */ 1988 /* eating message for normal players */
2165 if (tmp->type == DRINK) 1989 if (tmp->type == DRINK)
2166 sprintf (buf, "Ahhh...that %s tasted good.", &tmp->name); 1990 buf = format ("Ahhh...that %s tasted good.", &tmp->name);
2167 else 1991 else
2168 sprintf (buf, "The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good."); 1992 buf = format ("The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good.");
2169 } 1993 }
2170 else 1994 else
2171 {
2172 /* eating message for dragon players */ 1995 /* eating message for dragon players */
2173 sprintf (buf, "The %s tasted terrible!", &tmp->name); 1996 buf = format ("The %s tasted terrible!", &tmp->name);
2174 }
2175 1997
2176 new_draw_info (NDI_UNIQUE, 0, op, buf); 1998 op->statusmsg (buf);
1999
2177 capacity_remaining = 999 - op->stats.food; 2000 capacity_remaining = 999 - op->stats.food;
2178 op->stats.food += tmp->stats.food; 2001 op->stats.food += tmp->stats.food;
2179 if (capacity_remaining < tmp->stats.food) 2002 if (capacity_remaining < tmp->stats.food)
2180 op->stats.hp += capacity_remaining / 50; 2003 op->stats.hp += capacity_remaining / 50;
2181 else 2004 else
2182 op->stats.hp += tmp->stats.food / 50; 2005 op->stats.hp += tmp->stats.food / 50;
2006
2183 if (op->stats.hp > op->stats.maxhp) 2007 if (op->stats.hp > op->stats.maxhp)
2184 op->stats.hp = op->stats.maxhp; 2008 op->stats.hp = op->stats.maxhp;
2185 if (op->stats.food > 999) 2009 if (op->stats.food > 999)
2186 op->stats.food = 999; 2010 op->stats.food = 999;
2187 } 2011 }
… …
2189 /* special food hack -b.t. */ 2013 /* special food hack -b.t. */
2190 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED)) 2014 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED))
2191 eat_special_food (op, tmp); 2015 eat_special_food (op, tmp);
2192 } 2016 }
2193 } 2017 }
2018
2194 handle_apply_yield (tmp); 2019 handle_apply_yield (tmp);
2195 decrease_ob (tmp); 2020 tmp->decrease ();
2196} 2021}
2197 2022
2198/** 2023/**
2199 * A dragon is eating some flesh. If the flesh contains resistances, 2024 * A dragon is eating some flesh. If the flesh contains resistances,
2200 * there is a chance for the dragon's skin to get improved. 2025 * there is a chance for the dragon's skin to get improved.
… …
2210{ 2035{
2211 object *skin = NULL; /* pointer to dragon skin force */ 2036 object *skin = NULL; /* pointer to dragon skin force */
2212 object *abil = NULL; /* pointer to dragon ability force */ 2037 object *abil = NULL; /* pointer to dragon ability force */
2213 object *tmp = NULL; /* tmp. object */ 2038 object *tmp = NULL; /* tmp. object */
2214 2039
2215 char buf[MAX_BUF]; /* tmp. string buffer */
2216 double chance; /* improvement-chance of one resistance type */ 2040 double chance; /* improvement-chance of one resistance type */
2217 double totalchance = 1; /* total chance of gaining one resistance */ 2041 double totalchance = 1; /* total chance of gaining one resistance */
2218 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */ 2042 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */
2219 double mbonus = 0; /* monster bonus */ 2043 double mbonus = 0; /* monster bonus */
2220 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */ 2044 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */
… …
2225 if (meal->type != FLESH || !is_dragon_pl (op)) 2049 if (meal->type != FLESH || !is_dragon_pl (op))
2226 return 0; 2050 return 0;
2227 2051
2228 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces 2052 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces
2229 from the player's inventory */ 2053 from the player's inventory */
2230 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 2054 for (tmp = op->inv; tmp; tmp = tmp->below)
2231 {
2232 if (tmp->type == FORCE) 2055 if (tmp->type == FORCE)
2233 { 2056 if (tmp->arch->archname == shstr_dragon_skin_force)
2234 if (strcmp (tmp->arch->name, "dragon_skin_force") == 0)
2235 skin = tmp; 2057 skin = tmp;
2236 else if (strcmp (tmp->arch->name, "dragon_ability_force") == 0) 2058 else if (tmp->arch->archname == shstr_dragon_ability_force)
2237 abil = tmp; 2059 abil = tmp;
2238 }
2239 }
2240 2060
2241 /* if either skin or ability are missing, this is an old player 2061 /* if either skin or ability are missing, this is an old player
2242 which is not to be considered a dragon -> bail out */ 2062 which is not to be considered a dragon -> bail out */
2243 if (skin == NULL || abil == NULL) 2063 if (skin == NULL || abil == NULL)
2244 return 0; 2064 return 0;
… …
2246 /* now start by filling stomache and health, according to food-value */ 2066 /* now start by filling stomache and health, according to food-value */
2247 if ((999 - op->stats.food) < meal->stats.food) 2067 if ((999 - op->stats.food) < meal->stats.food)
2248 op->stats.hp += (999 - op->stats.food) / 50; 2068 op->stats.hp += (999 - op->stats.food) / 50;
2249 else 2069 else
2250 op->stats.hp += meal->stats.food / 50; 2070 op->stats.hp += meal->stats.food / 50;
2071
2251 if (op->stats.hp > op->stats.maxhp) 2072 if (op->stats.hp > op->stats.maxhp)
2252 op->stats.hp = op->stats.maxhp; 2073 op->stats.hp = op->stats.maxhp;
2253 2074
2254 op->stats.food = MIN (999, op->stats.food + meal->stats.food); 2075 op->stats.food = MIN (999, op->stats.food + meal->stats.food);
2255 2076
… …
2285 /* doubled chance for resistance of ability-focus */ 2106 /* doubled chance for resistance of ability-focus */
2286 if (i == abil->stats.exp) 2107 if (i == abil->stats.exp)
2287 chance = MIN (100., chance * 2.); 2108 chance = MIN (100., chance * 2.);
2288 2109
2289 /* now make the throw and save all winners (Don't insert luck bonus here!) */ 2110 /* now make the throw and save all winners (Don't insert luck bonus here!) */
2290 if (RANDOM () % 10000 < (int) (chance * 100)) 2111 if (rndm (10000) < (unsigned int) (chance * 100))
2291 { 2112 {
2292 atnr_winner[winners] = i; 2113 atnr_winner[winners] = i;
2293 winners++; 2114 winners++;
2294 } 2115 }
2295 2116
… …
2300 } 2121 }
2301 } 2122 }
2302 2123
2303 /* inverse totalchance as until now we have the failure-chance */ 2124 /* inverse totalchance as until now we have the failure-chance */
2304 totalchance = 100 - totalchance * 100; 2125 totalchance = 100 - totalchance * 100;
2126
2305 /* print message according to totalchance */ 2127 /* print message according to totalchance */
2128 const char *buf;
2306 if (totalchance > 50.) 2129 if (totalchance > 50.)
2307 sprintf (buf, "Hmm! The %s tasted delicious!", &meal->name); 2130 buf = format ("Hmm! The %s tasted delicious!", &meal->name);
2308 else if (totalchance > 10.) 2131 else if (totalchance > 10.)
2309 sprintf (buf, "The %s tasted very good.", &meal->name); 2132 buf = format ("The %s tasted very good.", &meal->name);
2310 else if (totalchance > 1.) 2133 else if (totalchance > 1.)
2311 sprintf (buf, "The %s tasted good.", &meal->name); 2134 buf = format ("The %s tasted good.", &meal->name);
2312 else if (totalchance > 0.1) 2135 else if (totalchance > 0.1)
2313 sprintf (buf, "The %s tasted bland.", &meal->name); 2136 buf = format ("The %s tasted bland.", &meal->name);
2314 else if (totalchance >= 0.01) 2137 else if (totalchance >= 0.01)
2315 sprintf (buf, "The %s had a boring taste.", &meal->name); 2138 buf = format ("The %s had a boring taste.", &meal->name);
2316 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat)) 2139 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat))
2317 sprintf (buf, "The %s tasted strange.", &meal->name); 2140 buf = format ("The %s tasted strange.", &meal->name);
2318 else 2141 else
2319 sprintf (buf, "The %s had no taste.", &meal->name); 2142 buf = format ("The %s had no taste.", &meal->name);
2320 new_draw_info (NDI_UNIQUE, 0, op, buf); 2143
2144 op->statusmsg (buf);
2321 2145
2322 /* now choose a winner if we have any */ 2146 /* now choose a winner if we have any */
2323 i = -1; 2147 i = -1;
2324 if (winners > 0) 2148 if (winners > 0)
2325 i = atnr_winner[RANDOM () % winners]; 2149 i = atnr_winner[RANDOM () % winners];
… …
2328 { 2152 {
2329 /* resistance increased! */ 2153 /* resistance increased! */
2330 skin->resist[i]++; 2154 skin->resist[i]++;
2331 op->update_stats (); 2155 op->update_stats ();
2332 2156
2333 sprintf (buf, "Your skin is now more resistant to %s!", change_resist_msg[i]); 2157 op->statusmsg (format ("Your skin is now more resistant to %s!", change_resist_msg[i]));
2334 new_draw_info (NDI_UNIQUE | NDI_RED, 0, op, buf);
2335 } 2158 }
2336 2159
2337 /* if this flesh contains a new ability focus, we mark it 2160 /* if this flesh contains a new ability focus, we mark it
2338 into the ability_force and it will take effect on next level */ 2161 into the ability_force and it will take effect on next level */
2339 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat) 2162 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat)
2340 { 2163 {
2341 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */ 2164 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */
2342 2165
2343 if (meal->last_eat != abil->stats.exp) 2166 if (meal->last_eat != abil->stats.exp)
2167 op->statusmsg (format (
2168 "Your metabolism prepares to focus on %s!\n"
2169 "The change will happen at level %d.",
2170 change_resist_msg[meal->last_eat],
2171 abil->level + 1
2344 { 2172 ));
2345 sprintf (buf, "Your metabolism prepares to focus on %s!", change_resist_msg[meal->last_eat]);
2346 new_draw_info (NDI_UNIQUE, 0, op, buf);
2347 sprintf (buf, "The change will happen at level %d", abil->level + 1);
2348 new_draw_info (NDI_UNIQUE, 0, op, buf);
2349 }
2350 else 2173 else
2351 { 2174 {
2352 sprintf (buf, "Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]); 2175 op->statusmsg (format ("Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]));
2353 new_draw_info (NDI_UNIQUE, 0, op, buf);
2354 abil->last_eat = 0; 2176 abil->last_eat = 0;
2355 } 2177 }
2356 } 2178 }
2179
2357 return 1; 2180 return 1;
2358} 2181}
2359 2182
2360/** 2183/**
2361 * Handles applying an improve armor scroll. 2184 * Handles applying an improve armor scroll.
… …
2364static void 2187static void
2365apply_armour_improver (object *op, object *tmp) 2188apply_armour_improver (object *op, object *tmp)
2366{ 2189{
2367 object *armor; 2190 object *armor;
2368 2191
2369 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 2192 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_NO_MAGIC))
2370 { 2193 {
2371 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 2194 op->failmsg ("Something blocks the magic of the scroll. H<This area prevents magic effects.>");
2372 return; 2195 return;
2373 } 2196 }
2374 2197
2375 armor = find_marked_object (op); 2198 armor = find_marked_object (op);
2376 2199
2377 if (!armor) 2200 if (!armor)
2378 { 2201 {
2379 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark an armor object."); 2202 op->failmsg ("You need to mark an armor object. Use the right mouse button popup or the mark command to do this.");
2380 return; 2203 return;
2381 } 2204 }
2382 2205
2383 if (armor->type != ARMOUR 2206 if (armor->type != ARMOUR
2384 && armor->type != CLOAK 2207 && armor->type != CLOAK
2385 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET) 2208 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET)
2386 { 2209 {
2387 new_draw_info (NDI_UNIQUE, 0, op, "Your marked item is not armour!\n"); 2210 op->failmsg ("Your marked item is not armour!\n");
2388 return; 2211 return;
2389 } 2212 }
2390 2213
2391 new_draw_info (NDI_UNIQUE, 0, op, "Applying armour enchantment."); 2214 op->statusmsg ("Applying armour enchantment.");
2392 improve_armour (op, tmp, armor); 2215 improve_armour (op, tmp, armor);
2393} 2216}
2394 2217
2395extern void 2218extern void
2396apply_poison (object *op, object *tmp) 2219apply_poison (object *op, object *tmp)
2397{ 2220{
2398 if (op->type == PLAYER) 2221 if (op->type == PLAYER)
2399 { 2222 {
2400 play_sound_player_only (op->contr, SOUND_DRINK_POISON, 0, 0); 2223 op->contr->play_sound (sound_find ("drink_poison"));
2401 new_draw_info (NDI_UNIQUE, 0, op, "Yech! That tasted poisonous!"); 2224 op->failmsg ("Yech! That tasted poisonous!");
2402 strcpy (op->contr->killer, "poisonous booze"); 2225 strcpy (op->contr->killer, "poisonous booze");
2403 } 2226 }
2227
2404 if (tmp->stats.hp > 0) 2228 if (tmp->stats.hp > 0)
2405 { 2229 {
2406 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", tmp->stats.hp); 2230 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", tmp->stats.hp);
2407 hit_player (op, tmp->stats.hp, tmp, AT_POISON, 1); 2231 hit_player (op, tmp->stats.hp, tmp, AT_POISON, 1);
2408 } 2232 }
2233
2409 op->stats.food -= op->stats.food / 4; 2234 op->stats.food -= op->stats.food / 4;
2410 handle_apply_yield (tmp); 2235 handle_apply_yield (tmp);
2411 decrease_ob (tmp); 2236 tmp->decrease ();
2412} 2237}
2413 2238
2414/** 2239/**
2415 * This fonction return true if the exit is not a 2 ways one or it is 2 ways, valid exit. 2240 * This function return true if the exit is not a 2 ways one or it is 2 ways, valid exit.
2416 * A valid 2 way exit means: 2241 * A valid 2 way exit means:
2417 * -You can come back (there is another exit at the other side) 2242 * -You can come back (there is another exit at the other side)
2418 * -You are 2243 * -You are
2419 * ° the owner of the exit 2244 * ° the owner of the exit
2420 * ° or in the same party as the owner 2245 * ° or in the same party as the owner
… …
2424 * survive in the swapping (in fact the whole exit doesn't survive). 2249 * survive in the swapping (in fact the whole exit doesn't survive).
2425 */ 2250 */
2426int 2251int
2427is_legal_2ways_exit (object *op, object *exit) 2252is_legal_2ways_exit (object *op, object *exit)
2428{ 2253{
2429 object *tmp;
2430 object *exit_owner;
2431 player *pp;
2432 maptile *exitmap;
2433
2434 if (exit->stats.exp != 1) 2254 if (exit->stats.exp != 1)
2435 return 1; /*This is not a 2 way, so it is legal */ 2255 return 1; /*This is not a 2 way, so it is legal */
2256
2257#if 0 //TODO
2436 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race) 2258 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race)
2437 return 0; /* This is a reset town portal */ 2259 return 0; /* This is a reset town portal */
2438 /* To know if an exit has a correspondant, we look at 2260#endif
2439 * all the exits in destination and try to find one with same path as 2261
2440 * the current exit's position */ 2262 LOG (llevError | logBacktrace, "sync map load due to %s\n", exit->debug_desc ());
2441 if (!strncmp (EXIT_PATH (exit), settings.localdir, strlen (settings.localdir))) 2263
2442 exitmap = ready_map_name (EXIT_PATH (exit), MAP_PLAYER_UNIQUE); 2264 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map);
2443 else 2265
2444 exitmap = ready_map_name (EXIT_PATH (exit), 0);
2445 if (exitmap) 2266 if (exitmap)
2446 { 2267 {
2268 exitmap->load_sync ();
2269
2447 tmp = GET_MAP_OB (exitmap, EXIT_X (exit), EXIT_Y (exit)); 2270 object *tmp = exitmap->at (EXIT_X (exit), EXIT_Y (exit)).bot;
2271
2448 if (!tmp) 2272 if (!tmp)
2449 return 0; 2273 return 0;
2450 for ((tmp = GET_MAP_OB (exitmap, EXIT_X (exit), EXIT_Y (exit))); tmp; tmp = tmp->above) 2274
2275 for (; tmp; tmp = tmp->above)
2451 { 2276 {
2452 if (tmp->type != EXIT) 2277 if (tmp->type != EXIT)
2453 continue; /*Not an exit */ 2278 continue; /*Not an exit */
2279
2454 if (!EXIT_PATH (tmp)) 2280 if (!EXIT_PATH (tmp))
2455 continue; /*Not a valid exit */ 2281 continue; /*Not a valid exit */
2282
2456 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y)) 2283 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y))
2457 continue; /*Not in the same place */ 2284 continue; /*Not in the same place */
2285
2458 if (strcmp (exit->map->path, EXIT_PATH (tmp)) != 0) 2286 if (exit->map->path != EXIT_PATH (tmp))
2459 continue; /*Not in the same map */ 2287 continue; /*Not in the same map */
2460 2288
2461 /* From here we have found the exit is valid. However we do 2289 /* From here we have found the exit is valid. However we do
2462 * here the check of the exit owner. It is important for the 2290 * here the check of the exit owner. It is important for the
2463 * town portals to prevent strangers from visiting your appartments 2291 * town portals to prevent strangers from visiting your appartments
2464 */ 2292 */
2465 if (!exit->race) 2293 if (!exit->race)
2466 return 1; /*No owner, free for all! */ 2294 return 1; /*No owner, free for all! */
2295
2467 exit_owner = NULL; 2296 object *exit_owner = 0;
2468 for (pp = first_player; pp; pp = pp->next) 2297
2298 for_all_players (pp)
2469 { 2299 {
2470 if (!pp->ob) 2300 if (!pp->ob)
2471 continue; 2301 continue;
2302
2472 if (pp->ob->name != exit->race) 2303 if (pp->ob->name != exit->race)
2473 continue; 2304 continue;
2305
2474 exit_owner = pp->ob; /*We found a player which correspond to the player name */ 2306 exit_owner = pp->ob; /*We found a player which correspond to the player name */
2475 break; 2307 break;
2476 } 2308 }
2309
2477 if (!exit_owner) 2310 if (!exit_owner)
2478 return 0; /* No more owner */ 2311 return 0; /* No more owner */
2312
2479 if (exit_owner->contr == op->contr) 2313 if (exit_owner->contr == op->contr)
2480 return 1; /*It is your exit */ 2314 return 1; /*It is your exit */
2315
2481 if (exit_owner && /*There is a owner */ 2316 if (exit_owner && /*There is a owner */
2482 (op->contr) && /*A player tries to pass */ 2317 (op->contr) && /*A player tries to pass */
2483 ((exit_owner->contr->party == NULL) || /*No pass if controller has no party */ 2318 ((exit_owner->contr->party == NULL) || /*No pass if controller has no party */
2484 (exit_owner->contr->party != op->contr->party))) /* Or not the same as op */ 2319 (exit_owner->contr->party != op->contr->party))) /* Or not the same as op */
2485 return 0; 2320 return 0;
2321
2486 return 1; 2322 return 1;
2487 } 2323 }
2488 } 2324 }
2325
2489 return 0; 2326 return 0;
2490} 2327}
2491
2492 2328
2493/** 2329/**
2494 * Main apply handler. 2330 * Main apply handler.
2495 * 2331 *
2496 * Checks for unpaid items before applying. 2332 * Checks for unpaid items before applying.
… …
2504 * being applied. 2340 * being applied.
2505 * 2341 *
2506 * aflag is special (always apply/unapply) flags. Nothing is done with 2342 * aflag is special (always apply/unapply) flags. Nothing is done with
2507 * them in this function - they are passed to apply_special 2343 * them in this function - they are passed to apply_special
2508 */ 2344 */
2509
2510int 2345int
2511manual_apply (object *op, object *tmp, int aflag) 2346manual_apply (object *op, object *tmp, int aflag)
2512{ 2347{
2513 if (tmp->head) 2348 if (tmp->head)
2514 tmp = tmp->head; 2349 tmp = tmp->head;
2515 2350
2516 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED)) 2351 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED))
2517 { 2352 {
2518 if (op->type == PLAYER) 2353 if (op->type == PLAYER)
2519 { 2354 {
2520 new_draw_info (NDI_UNIQUE, 0, op, "You should pay for it first."); 2355 op->failmsg ("You should pay for it first! H<You cannot use items marked as unpaid.>");
2521 return 1; 2356 return 1;
2522 } 2357 }
2523 else 2358 else
2524 return 0; /* monsters just skip unpaid items */ 2359 return 0; /* monsters just skip unpaid items */
2525 } 2360 }
… …
2528 return RESULT_INT (0); 2363 return RESULT_INT (0);
2529 2364
2530 switch (tmp->type) 2365 switch (tmp->type)
2531 { 2366 {
2532 case CF_HANDLE: 2367 case CF_HANDLE:
2533 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2368 op->play_sound (sound_find ("turn_handle"));
2534 play_sound_map (op->map, op->x, op->y, SOUND_TURN_HANDLE); 2369 op->statusmsg ("You turn the handle.");
2535 tmp->value = tmp->value ? 0 : 1; 2370 tmp->value = tmp->value ? 0 : 1;
2536 SET_ANIMATION (tmp, tmp->value); 2371 SET_ANIMATION (tmp, tmp->value);
2537 update_object (tmp, UP_OBJ_FACE); 2372 update_object (tmp, UP_OBJ_FACE);
2538 push_button (tmp); 2373 push_button (tmp);
2539 return 1; 2374 return 1;
2540 2375
2541 case TRIGGER: 2376 case TRIGGER:
2542 if (check_trigger (tmp, op)) 2377 if (check_trigger (tmp, op))
2543 { 2378 {
2544 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2379 op->statusmsg ("You turn the handle.");
2545 play_sound_map (tmp->map, tmp->x, tmp->y, SOUND_TURN_HANDLE); 2380 op->play_sound (sound_find ("turn_handle"));
2546 } 2381 }
2547 else 2382 else
2548 { 2383 op->failmsg ("The handle doesn't move.");
2549 new_draw_info (NDI_UNIQUE, 0, op, "The handle doesn't move."); 2384
2550 }
2551 return 1; 2385 return 1;
2552 2386
2553 case EXIT: 2387 case EXIT:
2554 if (op->type != PLAYER) 2388 if (op->type != PLAYER)
2555 return 0; 2389 return 0;
2390
2556 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp)) 2391 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp))
2557 { 2392 op->failmsg (format ("The %s is closed.", query_name (tmp)));
2558 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s is closed.", query_name (tmp));
2559 }
2560 else 2393 else
2561 { 2394 {
2562 /* Don't display messages for random maps. */ 2395 /* Don't display messages for random maps. */
2563 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2) && strncmp (EXIT_PATH (tmp), "/random/", 8)) 2396 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2))
2564 new_draw_info (NDI_NAVY, 0, op, tmp->msg); 2397 op->statusmsg (tmp->msg, NDI_NAVY);
2398
2565 enter_exit (op, tmp); 2399 op->enter_exit (tmp);
2566 } 2400 }
2401
2402 return 1;
2403
2404 case INSCRIBABLE:
2405 op->statusmsg (tmp->msg);
2406 // maybe show a spell menu to chose from or something like that
2567 return 1; 2407 return 1;
2568 2408
2569 case SIGN: 2409 case SIGN:
2570 apply_sign (op, tmp, 0); 2410 apply_sign (op, tmp, 0);
2571 return 1; 2411 return 1;
… …
2575 { 2415 {
2576 apply_book (op, tmp); 2416 apply_book (op, tmp);
2577 return 1; 2417 return 1;
2578 } 2418 }
2579 else 2419 else
2580 {
2581 return 0; 2420 return 0;
2582 }
2583 2421
2584 case SKILLSCROLL: 2422 case SKILLSCROLL:
2585 if (op->type == PLAYER) 2423 if (op->type == PLAYER)
2586 { 2424 {
2587 apply_skillscroll (op, tmp); 2425 apply_skillscroll (op, tmp);
2588 return 1; 2426 return 1;
2589 } 2427 }
2428 else
2590 return 0; 2429 return 0;
2591 2430
2592 case SPELLBOOK: 2431 case SPELLBOOK:
2593 if (op->type == PLAYER) 2432 if (op->type == PLAYER)
2594 { 2433 {
2595 apply_spellbook (op, tmp); 2434 apply_spellbook (op, tmp);
2596 return 1; 2435 return 1;
2597 } 2436 }
2437 else
2598 return 0; 2438 return 0;
2599 2439
2600 case SCROLL: 2440 case SCROLL:
2601 apply_scroll (op, tmp, 0); 2441 apply_scroll (op, tmp, 0);
2602 return 1; 2442 return 1;
2603 2443
2604 case POTION: 2444 case POTION:
2605 (void) apply_potion (op, tmp); 2445 apply_potion (op, tmp);
2606 return 1; 2446 return 1;
2607 2447
2608 /* Eneq(@csd.uu.se): Handle apply on containers. */ 2448 /* Eneq(@csd.uu.se): Handle apply on containers. */
2449 //TODO: remove, as it is unsed?
2609 case CLOSE_CON: 2450 case CLOSE_CON:
2610 if (op->type == PLAYER)
2611 (void) esrv_apply_container (op, tmp->env);
2612 else
2613 (void) apply_container (op, tmp->env); 2451 apply_container (op, tmp->env);
2614 return 1; 2452 return 1;
2615 2453
2616 case CONTAINER: 2454 case CONTAINER:
2617 if (op->type == PLAYER)
2618 (void) esrv_apply_container (op, tmp);
2619 else
2620 (void) apply_container (op, tmp); 2455 apply_container (op, tmp);
2621 return 1; 2456 return 1;
2622 2457
2623 case TREASURE: 2458 case TREASURE:
2624 if (op->type == PLAYER) 2459 if (op->type == PLAYER)
2625 { 2460 {
2626 apply_treasure (op, tmp); 2461 apply_treasure (op, tmp);
2627 return 1; 2462 return 1;
2628 } 2463 }
2629 else 2464 else
2630 {
2631 return 0; 2465 return 0;
2632 }
2633 2466
2634 case WEAPON: 2467 case WEAPON:
2635 case ARMOUR: 2468 case ARMOUR:
2636 case BOOTS: 2469 case BOOTS:
2637 case GLOVES: 2470 case GLOVES:
… …
2650 case LAMP: 2483 case LAMP:
2651 case BUILDER: 2484 case BUILDER:
2652 case SKILL_TOOL: 2485 case SKILL_TOOL:
2653 if (tmp->env != op) 2486 if (tmp->env != op)
2654 return 2; /* not in inventory */ 2487 return 2; /* not in inventory */
2488
2655 (void) apply_special (op, tmp, aflag); 2489 apply_special (op, tmp, aflag);
2656 return 1; 2490 return 1;
2657 2491
2658 case DRINK: 2492 case DRINK:
2659 case FOOD: 2493 case FOOD:
2660 case FLESH: 2494 case FLESH:
… …
2676 } 2510 }
2677 else 2511 else
2678 return 0; 2512 return 0;
2679 2513
2680 case WEAPON_IMPROVER: 2514 case WEAPON_IMPROVER:
2681 (void) check_improve_weapon (op, tmp); 2515 check_improve_weapon (op, tmp);
2682 return 1; 2516 return 1;
2683 2517
2684 case CLOCK: 2518 case CLOCK:
2685 if (op->type == PLAYER) 2519 if (op->type == PLAYER)
2686 { 2520 {
2687 char buf[MAX_BUF]; 2521 char buf[MAX_BUF];
2688 timeofday_t tod; 2522 timeofday_t tod;
2689 2523
2690 get_tod (&tod); 2524 get_tod (&tod);
2525 op->play_sound (sound_find ("sound_clock"));
2526 op->statusmsg (format (
2691 sprintf (buf, "It is %d minute%s past %d o'clock %s", 2527 "It is %d minute%s past %d o'clock %s",
2692 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"), 2528 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"),
2693 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")); 2529 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")
2694 play_sound_player_only (op->contr, SOUND_CLOCK, 0, 0); 2530 ));
2695 new_draw_info (NDI_UNIQUE, 0, op, buf);
2696 return 1; 2531 return 1;
2697 } 2532 }
2698 else 2533 else
2699 {
2700 return 0; 2534 return 0;
2701 }
2702 2535
2703 case MENU: 2536 case MENU:
2704 if (op->type == PLAYER) 2537 if (op->type == PLAYER)
2705 { 2538 {
2706 shop_listing (op); 2539 shop_listing (tmp, op);
2707 return 1; 2540 return 1;
2708 } 2541 }
2709 else 2542 else
2710 {
2711 return 0; 2543 return 0;
2712 }
2713 2544
2714 case POWER_CRYSTAL: 2545 case POWER_CRYSTAL:
2715 apply_power_crystal (op, tmp); /* see egoitem.c */ 2546 apply_power_crystal (op, tmp); /* see egoitem.c */
2716 return 1; 2547 return 1;
2717 2548
… …
2720 { 2551 {
2721 apply_lighter (op, tmp); 2552 apply_lighter (op, tmp);
2722 return 1; 2553 return 1;
2723 } 2554 }
2724 else 2555 else
2725 {
2726 return 0; 2556 return 0;
2727 }
2728 2557
2729 case ITEM_TRANSFORMER: 2558 case ITEM_TRANSFORMER:
2730 apply_item_transformer (op, tmp); 2559 apply_item_transformer (op, tmp);
2731 return 1; 2560 return 1;
2732 2561
… …
2745int 2574int
2746player_apply (object *pl, object *op, int aflag, int quiet) 2575player_apply (object *pl, object *op, int aflag, int quiet)
2747{ 2576{
2748 int tmp; 2577 int tmp;
2749 2578
2750 if (op->env == NULL && (pl->move_type & MOVE_FLYING)) 2579 if (op->env && (pl->move_type & MOVE_FLYING))
2751 { 2580 {
2752 /* player is flying and applying object not in inventory */ 2581 /* player is flying and applying object not in inventory */
2753 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING)) 2582 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING))
2754 { 2583 {
2755 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high " "above the ground!"); 2584 pl->failmsg ("But you are floating high above the ground! H<You have to stop levitating first, if you can.>");
2756 return 0; 2585 return 0;
2757 } 2586 }
2758 }
2759
2760 /* Check for PLAYER to avoid a DM to disappear in a puff of smoke if
2761 * applied.
2762 */
2763 if (op->type != PLAYER && QUERY_FLAG (op, FLAG_WAS_WIZ) && !QUERY_FLAG (pl, FLAG_WAS_WIZ))
2764 {
2765 play_sound_map (pl->map, pl->x, pl->y, SOUND_OB_EVAPORATE);
2766 new_draw_info (NDI_UNIQUE, 0, pl, "The object disappears in a puff " "of smoke!");
2767 new_draw_info (NDI_UNIQUE, 0, pl, "It must have been an illusion.");
2768 op->destroy ();
2769 return 1;
2770 } 2587 }
2771 2588
2772 pl->contr->last_used = op; 2589 pl->contr->last_used = op;
2773 2590
2774 tmp = manual_apply (pl, op, aflag); 2591 tmp = manual_apply (pl, op, aflag);
2775 if (!quiet) 2592 if (!quiet)
2776 { 2593 {
2777 if (tmp == 0) 2594 if (tmp == 0)
2778 new_draw_info_format (NDI_UNIQUE, 0, pl, "I don't know how to apply the %s.", query_name (op)); 2595 pl->statusmsg (format ("I don't know how to apply the %s.", query_name (op)));
2779 else if (tmp == 2) 2596 else if (tmp == 2)
2780 new_draw_info_format (NDI_UNIQUE, 0, pl, "You must get it first!\n"); 2597 pl->failmsg ("You must get it first!\n");
2781 } 2598 }
2599
2782 return tmp; 2600 return tmp;
2783} 2601}
2784 2602
2785/** 2603/**
2786 * player_apply_below attempts to apply the object 'below' the player. 2604 * player_apply_below attempts to apply the object 'below' the player.
2787 * If the player has an open container, we use that for below, otherwise 2605 * If the player has an open container, we use that for below, otherwise
2788 * we use the ground. 2606 * we use the ground.
2789 */ 2607 */
2790
2791void 2608void
2792player_apply_below (object *pl) 2609player_apply_below (object *pl)
2793{ 2610{
2794 object *tmp, *next;
2795 int floors; 2611 int floors = 0;
2796 2612
2797 /* If using a container, set the starting item to be the top 2613 /* If using a container, set the starting item to be the top
2798 * item in the container. Otherwise, use the map. 2614 * item in the container. Otherwise, use the map.
2799 */
2800 tmp = (pl->container != NULL) ? pl->container->inv : pl->below;
2801
2802 /* This is perhaps more complicated. However, I want to make sure that 2615 * This is perhaps more complicated. However, I want to make sure that
2803 * we don't use a corrupt pointer for the next object, so we get the 2616 * we don't use a corrupt pointer for the next object, so we get the
2804 * next object in the stack before applying. This is can only be a 2617 * next object in the stack before applying. This is can only be a
2805 * problem if player_apply() has a bug in that it uses the object but does 2618 * problem if player_apply() has a bug in that it uses the object but does
2806 * not return a proper value. 2619 * not return a proper value.
2807 */ 2620 */
2808 for (floors = 0; tmp != NULL; tmp = next) 2621 for (object *next, *tmp = pl->container ? pl->container->inv : pl->below; tmp; tmp = next)
2809 { 2622 {
2810 next = tmp->below; 2623 next = tmp->below;
2624
2811 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 2625 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
2812 floors++; 2626 floors++;
2813 else if (floors > 0) 2627 else if (floors > 0)
2814 return; /* process only floor objects after first floor object */ 2628 return; /* process only floor objects after first floor object */
2815 2629
… …
2835 * to keep the size of apply_special to a more managable size. 2649 * to keep the size of apply_special to a more managable size.
2836 */ 2650 */
2837static int 2651static int
2838unapply_special (object *who, object *op, int aflags) 2652unapply_special (object *who, object *op, int aflags)
2839{ 2653{
2840 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags)) || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags))) 2654 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags))
2655 || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags)))
2841 return RESULT_INT (0); 2656 return RESULT_INT (0);
2842 2657
2843 object *tmp2;
2844
2845 CLEAR_FLAG (op, FLAG_APPLIED); 2658 CLEAR_FLAG (op, FLAG_APPLIED);
2659
2846 switch (op->type) 2660 switch (op->type)
2847 { 2661 {
2662 case SKILL_TOOL:
2663 // unapplying a skill tool should also unapply the skill it governs
2664 // but this is hard, as it shouldn't do so when the skill can
2665 // be used for other reasons
2666 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2667 if (tmp->skill == op->skill
2668 && tmp->type == SKILL
2669 && tmp->flag [FLAG_APPLIED]
2670 && !tmp->flag [FLAG_CAN_USE_SKILL])
2671 unapply_special (who, tmp, 0);
2672
2673 change_abil (who, op);
2674 break;
2675
2848 case WEAPON: 2676 case WEAPON:
2849 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op)); 2677 if (player *pl = who->contr)
2678 if (op == pl->combat_ob)
2679 {
2680 pl->combat_ob = 0;
2681 who->change_weapon (pl->ranged_ob);
2682 }
2850 2683
2684 who->statusmsg (format ("You unwield %s.", query_name (op)));
2685
2851 (void) change_abil (who, op); 2686 change_abil (who, op);
2852 if (QUERY_FLAG (who, FLAG_READY_WEAPON))
2853 CLEAR_FLAG (who, FLAG_READY_WEAPON); 2687 CLEAR_FLAG (who, FLAG_READY_WEAPON);
2854 clear_skill (who);
2855 break; 2688 break;
2856 2689
2857 case SKILL: /* allows objects to impart skills */
2858 case SKILL_TOOL: 2690 case SKILL:
2859 if (op != who->chosen_skill) 2691 if (who->contr)
2860 { 2692 {
2861 LOG (llevError, "BUG: apply_special(): applied skill is not a chosen skill\n"); 2693 if (!op->invisible)
2694 who->statusmsg (format ("You stop using the %s.", query_name (op)));
2695 else
2696 who->statusmsg (format ("You can no longer use the skill: %s.", &op->skill));
2862 } 2697 }
2863 if (who->type == PLAYER) 2698
2864 {
2865 if (who->contr->shoottype == range_skill)
2866 who->contr->shoottype = range_none;
2867 if (!op->invisible)
2868 {
2869 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op));
2870 }
2871 else
2872 {
2873 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill);
2874 }
2875 }
2876 (void) change_abil (who, op); 2699 change_abil (who, op);
2877 who->chosen_skill = NULL;
2878 CLEAR_FLAG (who, FLAG_READY_SKILL); 2700 CLEAR_FLAG (who, FLAG_READY_SKILL);
2879 break; 2701 break;
2880 2702
2881 case ARMOUR: 2703 case ARMOUR:
2882 case HELMET: 2704 case HELMET:
… …
2886 case GLOVES: 2708 case GLOVES:
2887 case AMULET: 2709 case AMULET:
2888 case GIRDLE: 2710 case GIRDLE:
2889 case BRACERS: 2711 case BRACERS:
2890 case CLOAK: 2712 case CLOAK:
2891 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op)); 2713 who->statusmsg (format ("You unwear %s.", query_name (op)));
2892 (void) change_abil (who, op); 2714 change_abil (who, op);
2893 break; 2715 break;
2716
2894 case LAMP: 2717 case LAMP:
2895 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name); 2718 {
2719 who->statusmsg (format ("You turn off your %s.", &op->name));
2720
2896 tmp2 = arch_to_object (op->other_arch); 2721 object *tmp2 = arch_to_object (op->other_arch);
2897 tmp2->x = op->x; 2722 tmp2->x = op->x;
2898 tmp2->y = op->y; 2723 tmp2->y = op->y;
2899 tmp2->map = op->map; 2724 tmp2->map = op->map;
2900 tmp2->below = op->below; 2725 tmp2->below = op->below;
2901 tmp2->above = op->above; 2726 tmp2->above = op->above;
2902 tmp2->stats.food = op->stats.food; 2727 tmp2->stats.food = op->stats.food;
2903 CLEAR_FLAG (tmp2, FLAG_APPLIED); 2728 CLEAR_FLAG (tmp2, FLAG_APPLIED);
2904 2729
2905 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 2730 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
2906 SET_FLAG (tmp2, FLAG_INV_LOCKED); 2731 SET_FLAG (tmp2, FLAG_INV_LOCKED);
2907 2732
2908 if (who->type == PLAYER)
2909 esrv_del_item (who->contr, op->count);
2910
2911 op->destroy (); 2733 op->destroy ();
2912 insert_ob_in_ob (tmp2, who); 2734 who->insert (tmp2);
2913 who->update_stats (); 2735 who->update_stats ();
2736
2737 if (who->contr)
2738 {
2914 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 2739 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
2915 {
2916 if (who->type == PLAYER)
2917 { 2740 {
2918 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 2741 who->failmsg ("Oops, it feels deadly cold!");
2919 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 2742 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
2920 } 2743 }
2921 } 2744 }
2922 if (who->type == PLAYER) 2745 }
2923 esrv_send_item (who, tmp2); 2746
2924 return 1; /* otherwise, an attempt to drop causes problems */ 2747 return 1; /* otherwise, an attempt to drop causes problems */
2925 break; 2748
2926 case BOW: 2749 case BOW:
2927 case WAND: 2750 case WAND:
2928 case ROD: 2751 case ROD:
2929 case HORN: 2752 case HORN:
2930 clear_skill (who); 2753 if (player *pl = who->contr)
2931 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op));
2932 if (who->type == PLAYER)
2933 { 2754 {
2934 who->contr->shoottype = range_none; 2755 if (op == pl->ranged_ob)
2756 {
2757 pl->ranged_ob = 0;
2758 who->change_weapon (pl->combat_ob);
2759 }
2760
2761 who->statusmsg (format ("You unready %s.", query_name (op)));
2935 } 2762 }
2936 else 2763 else
2937 { 2764 {
2765 who->change_skill (0);
2766
2938 if (op->type == BOW) 2767 if (op->type == BOW)
2939 CLEAR_FLAG (who, FLAG_READY_BOW); 2768 CLEAR_FLAG (who, FLAG_READY_BOW);
2940 else 2769 else
2941 CLEAR_FLAG (who, FLAG_READY_RANGE); 2770 CLEAR_FLAG (who, FLAG_READY_RANGE);
2942 } 2771 }
2772
2943 break; 2773 break;
2944 2774
2945 case BUILDER: 2775 case BUILDER:
2946 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2776 if (who->contr)
2947 who->contr->shoottype = range_none; 2777 who->statusmsg (format ("You unready %s.", query_name (op)));
2948 who->contr->ranges[range_builder] = NULL;
2949 break; 2778 break;
2950 2779
2951 default: 2780 default:
2952 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op)); 2781 who->statusmsg (format ("You unapply %s.", query_name (op)));
2953 break; 2782 break;
2954 } 2783 }
2955 2784
2785 if (aflags & AP_NO_MERGE || !merge_ob (op, 0))
2786 if (object *pl = op->visible_to ())
2787 esrv_send_item (pl, op);
2788
2956 who->update_stats (); 2789 who->update_stats ();
2957 2790
2958 if (!(aflags & AP_NO_MERGE))
2959 {
2960 object *tmp;
2961
2962 tmp = merge_ob (op, NULL);
2963 if (who->type == PLAYER)
2964 {
2965 if (tmp)
2966 { /* it was merged */
2967 esrv_del_item (who->contr, op->count);
2968 op = tmp;
2969 }
2970
2971 esrv_send_item (who, op);
2972 }
2973 }
2974 return 0; 2791 return 0;
2975} 2792}
2976 2793
2977/** 2794/**
2978 * Returns the object that is using location 'loc'. 2795 * Returns the object that is using location 'loc'.
2979 * Note that 'start' is the first object to start examing - we 2796 * Note that 'start' is the first object to start examing - we
2980 * then go through the below of this. In this way, you can do 2797 * then go through the below of this. In this way, you can do
2981 * something like: 2798 * something like:
2982 * tmp = get_item_from_body_location(who->inv, 1); 2799 * tmp = get_next_item_from_body_location(who->inv, 1);
2983 * if (tmp) tmp1 = get_item_from_body_location(tmp->below, 1); 2800 * if (tmp) tmp1 = get_next_item_from_body_location(tmp->below, 1);
2984 * to find the second object that may use this location, etc. 2801 * to find the second object that may use this location, etc.
2985 * Returns NULL if no match is found. 2802 * Returns NULL if no match is found.
2986 * loc is the index into the array we are looking for a match. 2803 * loc is the index into the array we are looking for a match.
2987 * don't return invisible objects unless they are skill objects 2804 * don't return invisible objects unless they are skill objects
2988 * invisible other objects that use 2805 * invisible other objects that use
2989 * up body locations can be used as restrictions. 2806 * up body locations can be used as restrictions.
2990 */ 2807 */
2991object * 2808static object *
2992get_item_from_body_location (object *start, int loc) 2809get_next_item_from_body_location (int loc, object *start)
2993{ 2810{
2994 object *tmp;
2995
2996 if (!start)
2997 return NULL;
2998
2999 for (tmp = start; tmp; tmp = tmp->below) 2811 for (object *tmp = start; tmp; tmp = tmp->below)
3000 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->body_info[loc] && (!tmp->invisible || tmp->type == SKILL)) 2812 if (tmp->flag [FLAG_APPLIED]
2813 && tmp->slot[loc].info
2814 && (!tmp->invisible || tmp->type == SKILL))
3001 return tmp; 2815 return tmp;
3002 2816
3003 return NULL; 2817 return 0;
3004} 2818}
3005
3006
3007 2819
3008/** 2820/**
3009 * 'op' wants to apply an object, but can't because of other equipment. 2821 * 'op' wants to apply an object, but can't because of other equipment.
3010 * This should only be called when it is known 2822 * This should only be called when it is known
3011 * that there are objects to unapply. This makes pretty heavy 2823 * that there are objects to unapply. This makes pretty heavy
… …
3014 * Returns 0 on success, returns 1 if there is some problem. 2826 * Returns 0 on success, returns 1 if there is some problem.
3015 * if aflags is AP_PRINT, we instead print out waht to unapply 2827 * if aflags is AP_PRINT, we instead print out waht to unapply
3016 * instead of doing it. This is a lot less code than having 2828 * instead of doing it. This is a lot less code than having
3017 * another function that does just that. 2829 * another function that does just that.
3018 */ 2830 */
2831
2832#define CANNOT_REMOVE_CURSED \
2833 "H<You cannot remove cursed or damned items, you first have to remove the curse. " \
2834 "Praying over an altar, scrolls of remove curse/damnation, " \
2835 "priests or even other players might help.>"
2836
3019int 2837int
3020unapply_for_ob (object *who, object *op, int aflags) 2838unapply_for_ob (object *who, object *op, int aflags)
3021{ 2839{
3022 int i; 2840 if (op->is_range ())
3023 object *tmp = NULL, *last;
3024
3025 /* If we are applying a shield or weapon, unapply any equipped shield
3026 * or weapons first - only allowed to use one weapon/shield at a time.
3027 */
3028 if (op->type == WEAPON || op->type == SHIELD)
3029 {
3030 for (tmp = who->inv; tmp; tmp = tmp->below) 2841 for (object *tmp = who->inv; tmp; tmp = tmp->below)
3031 {
3032 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2842 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ())
3033 {
3034 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))) 2843 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)))
3035 { 2844 {
3036 if (aflags & AP_PRINT) 2845 if (aflags & AP_PRINT)
3037 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2846 who->failmsg (query_name (tmp));
3038 else 2847 else
3039 unapply_special (who, tmp, aflags); 2848 unapply_special (who, tmp, aflags);
3040 } 2849 }
3041 else 2850 else
3042 { 2851 {
3043 /* In this case, we want to try and remove a cursed item. 2852 /* In this case, we want to try and remove a cursed item.
3044 * While we know it won't work, we want unapply_special to 2853 * While we know it won't work, we want unapply_special to
3045 * at least generate the message. 2854 * at least generate the message.
3046 */ 2855 */
3047 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (tmp)); 2856 who->failmsg (format ("No matter how hard you try, you just can't remove the %s." CANNOT_REMOVE_CURSED, query_name (tmp)));
3048 return 1; 2857 return 1;
3049 }
3050
3051 } 2858 }
3052 }
3053 }
3054 2859
3055 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 2860 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3056 { 2861 {
3057 /* this used up a slot that we need to free */ 2862 /* this used up a slot that we need to free */
3058 if (op->body_info[i]) 2863 if (op->slot[i].info)
3059 { 2864 {
3060 last = who->inv; 2865 object *last = who->inv;
3061 2866
3062 /* We do a while loop - may need to remove several items in order 2867 /* We do a while loop - may need to remove several items in order
3063 * to free up enough slots. 2868 * to free up enough slots.
3064 */ 2869 */
3065 while ((who->body_used[i] + op->body_info[i]) < 0) 2870 while ((who->slot[i].used + op->slot[i].info) < 0)
3066 { 2871 {
3067 tmp = get_item_from_body_location (last, i); 2872 object *tmp = get_next_item_from_body_location (i, last);
2873
3068 if (!tmp) 2874 if (!tmp)
3069 { 2875 {
3070#if 0 2876#if 0
3071 /* Not a bug - we'll get this if the player has cursed items 2877 /* Not a bug - we'll get this if the player has cursed items
3072 * equipped. 2878 * equipped.
3073 */ 2879 */
3074 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name); 2880 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name);
3075#endif 2881#endif
3076 return 1; 2882 return 1;
3077 } 2883 }
2884
3078 /* If we are just printing, we don't care about cursed status */ 2885 /* If we are just printing, we don't care about cursed status */
3079 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)))) 2886 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))))
3080 { 2887 {
3081 if (aflags & AP_PRINT) 2888 if (aflags & AP_PRINT)
3082 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2889 who->failmsg (query_name (tmp));
3083 else 2890 else
3084 unapply_special (who, tmp, aflags); 2891 unapply_special (who, tmp, aflags);
3085 } 2892 }
3086 else 2893 else
3087 { 2894 {
3088 /* Cursed item that we can't unequip - tell the player. 2895 /* Cursed item that we can't unequip - tell the player.
3089 * Note this could be annoying if this is just one of a few, 2896 * Note this could be annoying if this is just one of a few,
3090 * so it may not be critical (eg, putting on a ring and you have 2897 * so it may not be critical (eg, putting on a ring and you have
3091 * one cursed ring.) 2898 * one cursed ring.)
3092 */ 2899 */
3093 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s just won't come off", query_name (tmp)); 2900 who->failmsg (format ("The %s just won't come off." CANNOT_REMOVE_CURSED, query_name (tmp)));
3094 } 2901 }
2902
3095 last = tmp->below; 2903 last = tmp->below;
3096 } 2904 }
3097 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the 2905 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the
3098 * return in the !tmp would have kicked in. 2906 * return in the !tmp would have kicked in.
3099 */ 2907 */
3100 } /* if op is using this body location */ 2908 } /* if op is using this body location */
3101 } /* for body lcoations */ 2909 } /* for body lcoations */
2910
3102 return 0; 2911 return 0;
3103} 2912}
3104 2913
3105/** 2914/**
3106 * Checks to see if 'who' can apply object 'op'. 2915 * Checks to see if 'who' can apply object 'op'.
3107 * Returns 0 if apply can be done without anything special. 2916 * Returns 0 if apply can be done without anything special.
3108 * Otherwise returns a bitmask - potentially several of these may be 2917 * Otherwise returns a bitmask - potentially several of these may be
3109 * set, but largely depends on circumstance - in the future, processing 2918 * set, but largely depends on circumstance - in the future, processing
3110 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER 2919 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER
3111 * is set, do we really are what the other flags may be?) 2920 * is set, do we really care what the other flags may be?)
3112 * 2921 *
3113 * See include/define.h for detailed description of the meaning of 2922 * See include/define.h for detailed description of the meaning of
3114 * these return values. 2923 * these return values.
3115 */ 2924 */
3116int 2925int
3117can_apply_object (object *who, object *op) 2926can_apply_object (object *who, object *op)
3118{ 2927{
3119 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op))) 2928 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op)))
3120 return RESULT_INT (0); 2929 return RESULT_INT (0);
3121 2930
3122 int i, retval = 0; 2931 int retval = 0;
3123 object *tmp = NULL, *ws = NULL; 2932 object *tmp = 0, *ws = 0;
3124 2933
3125 /* Players have 2 'arm's, so they could in theory equip 2 shields or 2934 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3126 * 2 weapons, but we don't want to let them do that. So if they are
3127 * trying to equip a weapon or shield, see if they already have one
3128 * in place and store that way.
3129 */
3130 if (op->type == WEAPON || op->type == SHIELD)
3131 { 2935 {
3132 for (tmp = who->inv; tmp && !ws; tmp = tmp->below) 2936 if (op->slot[i].info)
3133 { 2937 {
3134 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2938 /* Item uses more slots than we have */
2939 if (who->slot[i].info + op->slot [i].info < 0)
3135 { 2940 {
3136 retval = CAN_APPLY_UNAPPLY;
3137 ws = tmp;
3138 }
3139 }
3140 }
3141
3142
3143 for (i = 0; i < NUM_BODY_LOCATIONS; i++)
3144 {
3145 if (op->body_info[i])
3146 {
3147 /* Item uses more slots than we have */
3148 if (FABS (op->body_info[i]) > who->body_info[i])
3149 {
3150 /* Could return now for efficiently - rest of info below isn' 2941 /* Could return now for efficiency - rest of info below isn't
3151 * really needed. 2942 * really needed.
3152 */ 2943 */
3153 retval |= CAN_APPLY_NEVER; 2944 retval |= CAN_APPLY_NEVER;
3154 } 2945 }
3155 else if ((who->body_used[i] + op->body_info[i]) < 0) 2946 else if (who->slot[i].used + op->slot[i].info < 0)
3156 { 2947 {
3157 /* in this case, equipping this would use more free spots than 2948 /* in this case, equipping this would use more free spots than
3158 * we have. 2949 * we have.
3159 */ 2950 */
3160 object *tmp1;
3161
3162 2951
3163 /* if we have an applied weapon/shield, and unapply it would free 2952 /* if we have an applied weapon/shield, and unapply it would free
3164 * enough slots to equip the new item, then just set this can 2953 * enough slots to equip the new item, then just set "can
3165 * continue. We don't care about the logic below - if you have 2954 * apply unapply". We don't care about the logic below - if you have a
3166 * shield equipped and try to equip another shield, there is only 2955 * shield equipped and try to equip another shield, there is only
3167 * one choice. However, the check for the number of body locations 2956 * one choice. However, the check for the number of body locations
3168 * does take into the account cases where what is being applied 2957 * does take into the account cases where what is being applied
3169 * may be two handed for example. 2958 * may be two handed for example.
3170 */ 2959 */
3171 if (ws) 2960 if (ws)
3172 { 2961 if ((who->slot[i].used - ws->slot[i].info + op->slot[i].info) >= 0)
3173 if ((who->body_used[i] - ws->body_info[i] + op->body_info[i]) >= 0)
3174 { 2962 {
3175 retval |= CAN_APPLY_UNAPPLY; 2963 retval |= CAN_APPLY_UNAPPLY;
3176 continue; 2964 continue;
3177 } 2965 }
3178 }
3179 2966
3180 tmp1 = get_item_from_body_location (who->inv, i); 2967 object *tmp1 = get_next_item_from_body_location (i, who->inv);
3181 if (!tmp1) 2968 if (!tmp1)
3182 { 2969 {
3183#if 0 2970#if 0
3184 /* This is sort of an error, but happens a lot when old players 2971 /* This is sort of an error, but happens a lot when old players
3185 * join in with more stuff equipped than they are now allowed. 2972 * join in with more stuff equipped than they are now allowed.
… …
3193 /* need to unapply something. However, if this something 2980 /* need to unapply something. However, if this something
3194 * is different than we had found before, it means they need 2981 * is different than we had found before, it means they need
3195 * to apply multiple objects 2982 * to apply multiple objects
3196 */ 2983 */
3197 retval |= CAN_APPLY_UNAPPLY; 2984 retval |= CAN_APPLY_UNAPPLY;
2985
3198 if (!tmp) 2986 if (!tmp)
3199 tmp = tmp1; 2987 tmp = tmp1;
3200 else if (tmp != tmp1) 2988 else if (tmp != tmp1)
3201 {
3202 retval |= CAN_APPLY_UNAPPLY_MULT; 2989 retval |= CAN_APPLY_UNAPPLY_MULT;
3203 } 2990
3204 /* This object isn't using up all the slots, so there must 2991 /* This object isn't using up all the slots, so there must
3205 * be another. If so, and it the new item doesn't need all 2992 * be another. If so, and it the new item doesn't need all
3206 * the slots, the player then has a choice. 2993 * the slots, the player then has a choice.
3207 */ 2994 */
3208 if (((who->body_used[i] - tmp1->body_info[i]) != who->body_info[i]) && (FABS (op->body_info[i]) < who->body_info[i])) 2995 if ((who->slot[i].used - tmp1->slot[i].info != who->slot[i].info)
2996 && abs (op->slot[i].info) < who->slot[i].info)
3209 retval |= CAN_APPLY_UNAPPLY_CHOICE; 2997 retval |= CAN_APPLY_UNAPPLY_CHOICE;
3210 2998
3211 /* Does unequippint 'tmp1' free up enough slots for this to be 2999 /* Does unequippint 'tmp1' free up enough slots for this to be
3212 * equipped? If not, there must be something else to unapply. 3000 * equipped? If not, there must be something else to unapply.
3213 */ 3001 */
3214 if ((who->body_used[i] + op->body_info[i] - tmp1->body_info[i]) < 0) 3002 if (who->slot[i].used + op->slot[i].info < tmp1->slot[i].info)
3215 retval |= CAN_APPLY_UNAPPLY_MULT; 3003 retval |= CAN_APPLY_UNAPPLY_MULT;
3216
3217 } 3004 }
3218 } /* if not enough free slots */ 3005 } /* if not enough free slots */
3219 } /* if this object uses location i */ 3006 } /* if this object uses location i */
3220 } /* for i -> num_body_locations loop */ 3007 } /* for i -> num_body_locations loop */
3221 3008
… …
3226 * and weapons all use the same slot. Similar for horn/rod/wand - they 3013 * and weapons all use the same slot. Similar for horn/rod/wand - they
3227 * all use the same location. 3014 * all use the same location.
3228 */ 3015 */
3229 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON)) 3016 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON))
3230 retval |= CAN_APPLY_RESTRICTION; 3017 retval |= CAN_APPLY_RESTRICTION;
3018
3231 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD)) 3019 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD))
3232 retval |= CAN_APPLY_RESTRICTION; 3020 retval |= CAN_APPLY_RESTRICTION;
3233 3021
3234
3235 if (who->type != PLAYER) 3022 if (who->type != PLAYER)
3236 { 3023 {
3237 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE)) 3024 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE))
3238 retval |= CAN_APPLY_RESTRICTION; 3025 retval |= CAN_APPLY_RESTRICTION;
3026
3239 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3027 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3240 retval |= CAN_APPLY_RESTRICTION; 3028 retval |= CAN_APPLY_RESTRICTION;
3029
3241 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING)) 3030 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING))
3242 retval |= CAN_APPLY_RESTRICTION; 3031 retval |= CAN_APPLY_RESTRICTION;
3032
3243 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3033 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3244 retval |= CAN_APPLY_RESTRICTION; 3034 retval |= CAN_APPLY_RESTRICTION;
3245 } 3035 }
3036
3246 return retval; 3037 return retval;
3247} 3038}
3248
3249
3250 3039
3251/** 3040/**
3252 * who is the object using the object. It can be a monster. 3041 * who is the object using the object. It can be a monster.
3253 * op is the object they are using. op is an equipment type item, 3042 * op is the object they are using. op is an equipment type item,
3254 * eg, one which you put on and keep on for a while, and not something 3043 * eg, one which you put on and keep on for a while, and not something
… …
3263 * AP_UNAPPLY=always unapply). 3052 * AP_UNAPPLY=always unapply).
3264 * 3053 *
3265 * Optional flags: 3054 * Optional flags:
3266 * AP_NO_MERGE: don't merge an unapplied object with other objects 3055 * AP_NO_MERGE: don't merge an unapplied object with other objects
3267 * AP_IGNORE_CURSE: unapply cursed items 3056 * AP_IGNORE_CURSE: unapply cursed items
3057 * AP_NO_READY: do not ready skills when applying skill tools
3268 * 3058 *
3269 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE) 3059 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE)
3270 * 3060 *
3271 * apply_special() doesn't check for unpaid items. 3061 * apply_special() doesn't check for unpaid items.
3272 */ 3062 */
3063
3064#define LACK_ITEM_POWER \
3065 " H<You lack enough unused item power to use this weapon, see the skills command.>"
3066
3273int 3067int
3274apply_special (object *who, object *op, int aflags) 3068apply_special (object *who, object *op, int aflags)
3275{ 3069{
3276 int basic_flag = aflags & AP_BASIC_FLAGS; 3070 int basic_flag = aflags & AP_BASIC_FLAGS;
3277 object *tmp, *tmp2, *skop = NULL; 3071 object *tmp, *tmp2, *skop = NULL;
3278 int i;
3279 3072
3280 if (who == NULL) 3073 if (who == NULL)
3281 { 3074 {
3282 LOG (llevError, "apply_special() from object without environment.\n"); 3075 LOG (llevError, "apply_special() from object without environment.\n");
3283 return 1; 3076 return 1;
… …
3293 if (basic_flag == AP_APPLY) 3086 if (basic_flag == AP_APPLY)
3294 return 0; 3087 return 0;
3295 3088
3296 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))) 3089 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)))
3297 { 3090 {
3298 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (op)); 3091 who->failmsg (format ("No matter how hard you try, you just can't remove %s." CANNOT_REMOVE_CURSED, query_name (op)));
3299 return 1; 3092 return 1;
3300 } 3093 }
3094
3301 return unapply_special (who, op, aflags); 3095 return unapply_special (who, op, aflags);
3302 } 3096 }
3303 3097
3304 if (basic_flag == AP_UNAPPLY) 3098 if (basic_flag == AP_UNAPPLY)
3305 return 0; 3099 return 0;
3306 3100
3307 i = can_apply_object (who, op); 3101 // if the item is combat/ranged, wield the relevant slot first
3102 // to resolve conflicts.
3103 if (player *pl = who->contr)
3104 switch (op->slottype ())
3105 {
3106 case slot_combat: who->change_weapon (pl->combat_ob); break;
3107 case slot_ranged: who->change_weapon (pl->ranged_ob); break;
3108 }
3109
3110 splay (op);
3308 3111
3309 /* Can't just apply this object. Lets see what not and what to do */ 3112 /* Can't just apply this object. Lets see what not and what to do */
3310 if (i) 3113 if (int i = can_apply_object (who, op))
3311 { 3114 {
3312 if (i & CAN_APPLY_NEVER) 3115 if (i & CAN_APPLY_NEVER)
3313 { 3116 {
3314 new_draw_info_format (NDI_UNIQUE, 0, who, "You don't have the body to use a %s\n", query_name (op)); 3117 who->failmsg (format ("You don't have the body to use a %s. H<You can never apply this item.>", query_name (op)));
3315 return 1; 3118 return 1;
3316 } 3119 }
3317 else if (i & CAN_APPLY_RESTRICTION) 3120 else if (i & CAN_APPLY_RESTRICTION)
3318 { 3121 {
3319 new_draw_info_format (NDI_UNIQUE, 0, who, "You have a prohibition against using a %s\n", query_name (op)); 3122 who->failmsg (format (
3123 "You have a prohibition against using a %s. "
3124 "H<Your belief, profession or class prevents you from applying this item.>",
3125 query_name (op)
3126 ));
3320 return 1; 3127 return 1;
3321 } 3128 }
3129
3322 if (who->type != PLAYER) 3130 if (who->type != PLAYER)
3323 { 3131 {
3324 /* Some error, so don't try to equip something more */ 3132 /* Some error, so don't try to equip something more */
3325 if (unapply_for_ob (who, op, aflags)) 3133 if (unapply_for_ob (who, op, aflags))
3326 return 1; 3134 return 1;
3327 } 3135 }
3328 else 3136 else
3329 { 3137 {
3330 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice)) 3138 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice))
3331 { 3139 {
3332 new_draw_info (NDI_UNIQUE, 0, who, "You need to unapply some item(s):"); 3140 who->failmsg ("You need to unapply some of the following item(s) or change your applymode:");
3333 unapply_for_ob (who, op, AP_PRINT); 3141 unapply_for_ob (who, op, AP_PRINT);
3334 return 1; 3142 return 1;
3335 } 3143 }
3336 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE)) 3144 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE))
3337 {
3338 i = unapply_for_ob (who, op, aflags); 3145 if (unapply_for_ob (who, op, aflags))
3339 if (i)
3340 return 1; 3146 return 1;
3341 } 3147 }
3342 }
3343 } 3148 }
3149
3344 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL) 3150 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL)
3345 { 3151 {
3346 skop = find_skill_by_name (who, op->skill); 3152 skop = find_skill_by_name (who, op->skill);
3153
3347 if (!skop) 3154 if (!skop)
3348 { 3155 {
3349 new_draw_info_format (NDI_UNIQUE, 0, who, "You need the %s skill to use this item!", &op->skill); 3156 who->failmsg (format ("You need the %s skill to use this item!", &op->skill));
3350 return 1; 3157 return 1;
3351 } 3158 }
3352 else 3159 else
3353 {
3354 /* While experience will be credited properly, we want to change the 3160 /* While experience will be credited properly, we want to change the
3355 * skill so that the dam and wc get updated 3161 * skill so that the dam and wc get updated
3356 */ 3162 */
3357 change_skill (who, skop, 0); 3163 who->change_skill (skop);
3358 }
3359 }
3360
3361 if (who->type == PLAYER && op->item_power && (op->item_power + who->contr->item_power) > (settings.item_power_factor * who->level))
3362 { 3164 }
3363 new_draw_info (NDI_UNIQUE, 0, who, "Equipping that combined with other items would consume your soul!"); 3165
3166 if (who->type == PLAYER
3167 && op->item_power
3168 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level)
3169 {
3170 who->failmsg ("Equipping that combined with other items would consume your soul!" LACK_ITEM_POWER);
3364 return 1; 3171 return 1;
3365 } 3172 }
3366
3367 3173
3368 /* Ok. We are now at the state where we can apply the new object. 3174 /* Ok. We are now at the state where we can apply the new object.
3369 * Note that we don't have the checks for can_use_... 3175 * Note that we don't have the checks for can_use_...
3370 * below - that is already taken care of by can_apply_object. 3176 * below - that is already taken care of by can_apply_object.
3371 */ 3177 */
3372 3178 tmp = op->nrof > 1 ? op->split (op->nrof - 1) : 0;
3373
3374 if (op->nrof > 1)
3375 tmp = get_split_ob (op, op->nrof - 1);
3376 else
3377 tmp = NULL;
3378 3179
3379 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op))) 3180 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op)))
3380 return RESULT_INT (0); 3181 return RESULT_INT (0);
3381 3182
3382 switch (op->type) 3183 switch (op->type)
3383 { 3184 {
3384 case WEAPON: 3185 case WEAPON:
3385 if (!check_weapon_power (who, op->last_eat)) 3186 if (!check_weapon_power (who, op->last_eat))
3386 { 3187 {
3387 new_draw_info (NDI_UNIQUE, 0, who, "That weapon is too powerful for you to use."); 3188 op->failmsg ("This weapon is too powerful for you to use. It would consume your soul!." LACK_ITEM_POWER);
3388 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3189
3389 if (tmp != NULL) 3190 if (tmp)
3390 (void) insert_ob_in_ob (tmp, who); 3191 insert_ob_in_ob (tmp, who);
3192
3391 return 1; 3193 return 1;
3392 } 3194 }
3195
3196 //TODO: this obviously fails for players using a shorter prefix
3197 // i.e. "R" can use Ragnarok's sword.
3393 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3198 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3394 { 3199 {
3395 /* if the weapon does not have the name as the character, can't use it. */ 3200 /* if the weapon does not have the name as the character, can't use it. */
3396 /* (Ragnarok's sword attempted to be used by Foo: won't work) */ 3201 /* (Ragnarok's sword attempted to be used by Foo: won't work) */
3397 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3202 who->failmsg ("The weapon does not recognize you as its owner. H<Its name indicates that it belongs to somebody else.>");
3203
3398 if (tmp != NULL) 3204 if (tmp)
3399 (void) insert_ob_in_ob (tmp, who); 3205 insert_ob_in_ob (tmp, who);
3206
3400 return 1; 3207 return 1;
3401 } 3208 }
3209
3210 if (!skop)
3211 {
3212 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3213 return 1;
3214 }
3215
3402 SET_FLAG (op, FLAG_APPLIED); 3216 SET_FLAG (op, FLAG_APPLIED);
3403
3404 if (skop)
3405 change_skill (who, skop, 1); 3217 who->change_skill (skop);
3406 if (!QUERY_FLAG (who, FLAG_READY_WEAPON)) 3218
3219 if (who->contr)
3220 who->change_weapon (who->contr->combat_ob = op);
3221
3222 who->statusmsg (format ("You wield %s.", query_name (op)));
3223
3407 SET_FLAG (who, FLAG_READY_WEAPON); 3224 SET_FLAG (who, FLAG_READY_WEAPON);
3408
3409 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op));
3410
3411 (void) change_abil (who, op); 3225 change_abil (who, op);
3412 break; 3226 break;
3413 3227
3414 case ARMOUR: 3228 case ARMOUR:
3415 case HELMET: 3229 case HELMET:
3416 case SHIELD: 3230 case SHIELD:
… …
3420 case BRACERS: 3234 case BRACERS:
3421 case CLOAK: 3235 case CLOAK:
3422 case RING: 3236 case RING:
3423 case AMULET: 3237 case AMULET:
3424 SET_FLAG (op, FLAG_APPLIED); 3238 SET_FLAG (op, FLAG_APPLIED);
3425 new_draw_info_format (NDI_UNIQUE, 0, who, "You wear %s.", query_name (op)); 3239 who->statusmsg (format ("You wear %s.", query_name (op)));
3426 (void) change_abil (who, op); 3240 change_abil (who, op);
3427 break; 3241 break;
3242
3428 case LAMP: 3243 case LAMP:
3429 if (op->stats.food < 1) 3244 if (op->stats.food < 1)
3430 { 3245 {
3431 new_draw_info_format (NDI_UNIQUE, 0, who, "Your %s is out of" " fuel!", &op->name); 3246 who->failmsg (format (
3247 "Your %s is out of fuel! "
3248 "H<Lamps and similar items need fuel. They cannot be refilled.>",
3249 &op->name
3250 ));
3432 return 1; 3251 return 1;
3433 } 3252 }
3434 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn on your %s.", &op->name); 3253
3254 who->statusmsg (format ("You turn on your %s.", &op->name));
3255
3435 tmp2 = arch_to_object (op->other_arch); 3256 tmp2 = arch_to_object (op->other_arch);
3436 tmp2->stats.food = op->stats.food; 3257 tmp2->stats.food = op->stats.food;
3437 SET_FLAG (tmp2, FLAG_APPLIED); 3258 SET_FLAG (tmp2, FLAG_APPLIED);
3259
3438 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 3260 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
3439 SET_FLAG (tmp2, FLAG_INV_LOCKED); 3261 SET_FLAG (tmp2, FLAG_INV_LOCKED);
3440 insert_ob_in_ob (tmp2, who); 3262
3263 who->insert (tmp2);
3441 3264
3442 /* Remove the old lantern */ 3265 /* Remove the old lantern */
3443 if (who->type == PLAYER)
3444 esrv_del_item (who->contr, op->count);
3445
3446 op->destroy (); 3266 op->destroy ();
3447 3267
3448 /* insert the portion that was split off */ 3268 /* insert the portion that was split off */
3449 if (tmp != NULL) 3269 if (tmp)
3270 who->insert (tmp);
3271
3272 who->update_stats ();
3273
3274 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3275 if (who->type == PLAYER)
3276 {
3277 who->failmsg ("Oops, it feels deadly cold! H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>");
3278 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
3279 }
3280
3281 return 0;
3282
3283 case SKILL_TOOL:
3284 // applying a skill tool also readies the skill
3285 SET_FLAG (op, FLAG_APPLIED);
3286
3287 if (!(aflags & AP_NO_READY))
3450 { 3288 {
3451 (void) insert_ob_in_ob (tmp, who); 3289 skop = find_skill_by_name (who, op->skill);
3452 if (who->type == PLAYER) 3290 if (!skop->flag [FLAG_APPLIED])
3453 esrv_send_item (who, tmp); 3291 apply_special (who, skop, AP_APPLY);
3454 } 3292 }
3455 who->update_stats (); 3293 break;
3456 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3294
3295 case SKILL:
3296 if (player *pl = who->contr)
3457 { 3297 {
3458 if (who->type == PLAYER) 3298 if (IS_COMBAT_SKILL (op->subtype))
3459 { 3299 {
3460 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3300 if (skill_flags [op->subtype] & SF_NEED_WEAPON)
3461 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 3301 {
3302 for (object *item = who->inv; item; item = item->below)
3303 if (item->type == WEAPON && item->flag [FLAG_APPLIED])
3304 {
3305 if (item->skill == op->skill)
3306 {
3307 who->change_weapon (pl->combat_ob = item);
3308 goto found_weapon;
3309 }
3310 }
3311
3312 who->failmsg (format (
3313 "You need to apply a '%s' melee weapon before readying this skill. "
3314 "H<Some skills need an item, in this case a melee weapon, to function.>",
3315 &op->skill
3316 ));
3317 return 1;
3318
3319 found_weapon:;
3320 }
3321 else
3322 who->change_weapon (pl->combat_ob = op);
3462 } 3323 }
3463 } 3324 else if (IS_RANGED_SKILL (op->subtype))
3464 if (who->type == PLAYER)
3465 esrv_send_item (who, tmp2);
3466 return 0;
3467 break;
3468
3469 /* this part is needed for skill-tools */
3470 case SKILL:
3471 case SKILL_TOOL:
3472 if (who->chosen_skill)
3473 { 3325 {
3474 LOG (llevError, "BUG: apply_special(): can't apply two skills\n"); 3326 if (skill_flags [op->subtype] & SF_NEED_BOW)
3327 {
3328 for (object *item = who->inv; item; item = item->below)
3329 if (item->type == BOW && item->flag [FLAG_APPLIED])
3330 {
3331 //TODO: bows should/must all have skill missile weapon right now
3332 who->change_weapon (pl->ranged_ob = item);
3333 goto found_bow;
3334 }
3335
3336 who->failmsg (
3337 "You need to apply a missile weapon before readying this skill. "
3338 "H<Some skills need an item, in this case a missile weapon, to function.>"
3339 );
3475 return 1; 3340 return 1;
3341
3342 found_bow:;
3343 }
3344 else
3345 who->change_weapon (pl->ranged_ob = op);
3476 } 3346 }
3477 if (who->type == PLAYER) 3347
3478 {
3479 who->contr->shoottype = range_skill;
3480 who->contr->ranges[range_skill] = op;
3481 if (!op->invisible) 3348 if (!op->invisible)
3482 { 3349 {
3483 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3350 who->statusmsg (format (
3484 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill); 3351 "You ready %s."
3352 "You can now use the skill: %s.",
3353 query_name (op),
3354 &op->skill
3355 ));
3485 } 3356 }
3486 else 3357 else
3487 {
3488 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name); 3358 who->statusmsg (format ("Readied skill: %s.", op->skill ? &op->skill : &op->name));
3489 }
3490 } 3359 }
3360 else
3361 {
3491 SET_FLAG (op, FLAG_APPLIED); 3362 SET_FLAG (op, FLAG_APPLIED);
3492 (void) change_abil (who, op); 3363 change_abil (who, op);
3493 who->chosen_skill = op; 3364 who->chosen_skill = op;
3494 SET_FLAG (who, FLAG_READY_SKILL); 3365 SET_FLAG (who, FLAG_READY_SKILL);
3366 }
3367
3495 break; 3368 break;
3496 3369
3497 case BOW: 3370 case BOW:
3498 if (!check_weapon_power (who, op->last_eat)) 3371 if (!check_weapon_power (who, op->last_eat))
3499 { 3372 {
3500 new_draw_info (NDI_UNIQUE, 0, who, "That item is too powerful for you to use."); 3373 who->failmsg ("That weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3501 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3374
3502 if (tmp != NULL) 3375 if (tmp)
3503 (void) insert_ob_in_ob (tmp, who); 3376 insert_ob_in_ob (tmp, who);
3377
3504 return 1; 3378 return 1;
3505 } 3379 }
3380
3506 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3381 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3507 { 3382 {
3508 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3383 who->failmsg ("The weapon does not recognize you as its owner. "
3384 "H<Its name indicates that it belongs to somebody else.>");
3509 if (tmp != NULL) 3385 if (tmp)
3510 (void) insert_ob_in_ob (tmp, who); 3386 insert_ob_in_ob (tmp, who);
3387
3511 return 1; 3388 return 1;
3512 } 3389 }
3390
3513 /*FALLTHROUGH*/ case WAND: 3391 /*FALLTHROUGH*/
3392 case WAND:
3514 case ROD: 3393 case ROD:
3515 case HORN: 3394 case HORN:
3516 /* check for skill, alter player status */ 3395 /* check for skill, alter player status */
3396
3397 if (!skop)
3398 {
3399 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3400 return 1;
3401 }
3402
3517 SET_FLAG (op, FLAG_APPLIED); 3403 SET_FLAG (op, FLAG_APPLIED);
3518 if (skop)
3519 change_skill (who, skop, 0); 3404 who->change_skill (skop);
3520 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op));
3521 3405
3522 if (who->type == PLAYER) 3406 if (who->contr)
3523 { 3407 {
3408 who->contr->ranged_ob = op;
3409
3410 who->statusmsg (format ("You ready %s.", query_name (op)));
3411
3524 if (op->type == BOW) 3412 if (op->type == BOW)
3525 { 3413 {
3414 who->current_weapon = op;
3526 (void) change_abil (who, op); 3415 change_abil (who, op);
3527 new_draw_info_format (NDI_UNIQUE, 0, who,
3528 "You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)); 3416 who->statusmsg (format ("You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)));
3529 who->contr->shoottype = range_bow;
3530 }
3531 else
3532 {
3533 who->contr->shoottype = range_misc;
3534 } 3417 }
3535 } 3418 }
3536 else 3419 else
3537 { 3420 {
3538 if (op->type == BOW) 3421 if (op->type == BOW)
3539 SET_FLAG (who, FLAG_READY_BOW); 3422 SET_FLAG (who, FLAG_READY_BOW);
3540 else 3423 else
3541 SET_FLAG (who, FLAG_READY_RANGE); 3424 SET_FLAG (who, FLAG_READY_RANGE);
3542 } 3425 }
3426
3543 break; 3427 break;
3544 3428
3545 case BUILDER: 3429 case BUILDER:
3546 if (who->contr->ranges[range_builder]) 3430 if (who->type == PLAYER)
3431 {
3432 //TODO: wtf does this do? shouldn't this be managed automatically (slots?)
3433 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER)
3547 unapply_special (who, who->contr->ranges[range_builder], 0); 3434 unapply_special (who, who->contr->ranged_ob, 0);
3548 who->contr->shoottype = range_builder; 3435
3436 who->statusmsg (format ("You ready your %s.", query_name (op)));
3437
3549 who->contr->ranges[range_builder] = op; 3438 who->contr->ranged_ob = op;
3550 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op)); 3439 }
3551 break; 3440 break;
3552 3441
3553 default: 3442 default:
3554 new_draw_info_format (NDI_UNIQUE, 0, who, "You apply %s.", query_name (op)); 3443 who->statusmsg (format ("You apply %s.", query_name (op)));
3555 } /* end of switch op->type */ 3444 }
3556 3445
3557 SET_FLAG (op, FLAG_APPLIED); 3446 SET_FLAG (op, FLAG_APPLIED);
3558 3447
3559 if (tmp != NULL) 3448 if (tmp)
3560 tmp = insert_ob_in_ob (tmp, who); 3449 who->insert (tmp);
3561 3450
3562 who->update_stats (); 3451 who->update_stats ();
3563 3452
3564 /* We exclude spell casting objects. The fire code will set the 3453 /* We exclude spell casting objects. The fire code will set the
3565 * been applied flag when they are used - until that point, 3454 * been applied flag when they are used - until that point,
… …
3567 */ 3456 */
3568 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD) 3457 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD)
3569 SET_FLAG (op, FLAG_BEEN_APPLIED); 3458 SET_FLAG (op, FLAG_BEEN_APPLIED);
3570 3459
3571 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3460 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3572 {
3573 if (who->type == PLAYER) 3461 if (who->type == PLAYER)
3574 { 3462 {
3575 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3463 who->failmsg (
3464 "Oops, it feels deadly cold! "
3465 "H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>"
3466 );
3576 SET_FLAG (op, FLAG_KNOWN_CURSED); 3467 SET_FLAG (op, FLAG_KNOWN_CURSED);
3577 } 3468 }
3578 } 3469
3579 if (who->type == PLAYER) 3470 if (object *pl = op->visible_to ())
3580 {
3581 /* if multiple objects were applied, update both slots */
3582 if (tmp)
3583 esrv_send_item (who, tmp);
3584 esrv_send_item (who, op); 3471 esrv_send_item (pl, op);
3585 } 3472
3586 return 0; 3473 return 0;
3587} 3474}
3588
3589 3475
3590int 3476int
3591monster_apply_special (object *who, object *op, int aflags) 3477monster_apply_special (object *who, object *op, int aflags)
3592{ 3478{
3593 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED)) 3479 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED))
3594 return 1; 3480 return 1;
3481
3595 return apply_special (who, op, aflags); 3482 return apply_special (who, op, aflags);
3596} 3483}
3597 3484
3598/** 3485/**
3599 * Map was just loaded, handle op's initialisation. 3486 * Map was just loaded, handle op's initialisation.
… …
3637 3524
3638 case TREASURE: 3525 case TREASURE:
3639 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 3526 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
3640 return 0; 3527 return 0;
3641 3528
3642 while ((op->stats.hp--) > 0) 3529 while (op->stats.hp-- > 0)
3643 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0, 3530 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0,
3644 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0); 3531 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0);
3645 3532
3646 /* If we generated an object and put it in this object inventory, 3533 /* If we generated an object and put it in this object inventory,
3647 * move it to the parent object as the current object is about 3534 * move it to the parent object as the current object is about
… …
3664 } 3551 }
3665 return tmp ? 1 : 0; 3552 return tmp ? 1 : 0;
3666} 3553}
3667 3554
3668/** 3555/**
3669 * fix_auto_apply goes through the entire map (only the first time 3556 * fix_auto_apply goes through the entire map every time a map
3670 * when an original map is loaded) and performs special actions for 3557 * is loaded or swapped in and performs special actions for
3671 * certain objects (most initialization of chests and creation of 3558 * certain objects (most initialization of chests and creation of
3672 * treasures and stuff). Calls auto_apply if appropriate. 3559 * treasures and stuff). Calls auto_apply if appropriate.
3673 */ 3560 */
3674void 3561void
3675fix_auto_apply (maptile *m) 3562maptile::fix_auto_apply ()
3676{ 3563{
3677 object *tmp, *above = NULL; 3564 if (!spaces)
3678 int x, y;
3679
3680 if (m == NULL)
3681 return; 3565 return;
3682 3566
3683 for (x = 0; x < MAP_WIDTH (m); x++) 3567 for (mapspace *ms = spaces + size (); ms-- > spaces; )
3684 for (y = 0; y < MAP_HEIGHT (m); y++) 3568 for (object *tmp = ms->bot; tmp; )
3685 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = above)
3686 { 3569 {
3687 above = tmp->above; 3570 object *above = tmp->above;
3688 3571
3689 if (tmp->inv) 3572 if (tmp->inv)
3690 { 3573 {
3691 object *invtmp, *invnext; 3574 object *invtmp, *invnext;
3692 3575
3693 for (invtmp = tmp->inv; invtmp != NULL; invtmp = invnext) 3576 for (invtmp = tmp->inv; invtmp != NULL; invtmp = invnext)
3694 { 3577 {
3695 invnext = invtmp->below; 3578 invnext = invtmp->below;
3696 3579
3697 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY)) 3580 if (QUERY_FLAG (invtmp, FLAG_AUTO_APPLY))
3698 auto_apply (invtmp); 3581 auto_apply (invtmp);
3699 else if (invtmp->type == TREASURE && invtmp->has_random_items ()) 3582 else if (invtmp->type == TREASURE && invtmp->has_random_items ())
3700 { 3583 {
3701 while ((invtmp->stats.hp--) > 0) 3584 while ((invtmp->stats.hp--) > 0)
3702 create_treasure (invtmp->randomitems, invtmp, 0, m->difficulty, 0); 3585 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0);
3703 3586
3704 invtmp->randomitems = NULL; 3587 invtmp->randomitems = NULL;
3705 } 3588 }
3706 else if (invtmp && invtmp->arch 3589 else if (invtmp && invtmp->arch
3707 && invtmp->type != TREASURE && invtmp->type != SPELL && invtmp->type != CLASS && invtmp->has_random_items ()) 3590 && invtmp->type != TREASURE && invtmp->type != SPELL && invtmp->type != CLASS && invtmp->has_random_items ())
3708 { 3591 {
3709 create_treasure (invtmp->randomitems, invtmp, 0, m->difficulty, 0); 3592 create_treasure (invtmp->randomitems, invtmp, 0, difficulty, 0);
3710 /* Need to clear this so that we never try to create 3593 /* Need to clear this so that we never try to create
3711 * treasure again for this object 3594 * treasure again for this object
3712 */ 3595 */
3713 invtmp->randomitems = NULL; 3596 invtmp->randomitems = NULL;
3714 } 3597 }
3715 } 3598 }
3716 /* This is really temporary - the code at the bottom will 3599 /* This is really temporary - the code at the bottom will
3717 * also set randomitems to null. The problem is there are bunches 3600 * also set randomitems to null. The problem is there are bunches
3718 * of maps/players already out there with items that have spells 3601 * of maps/players already out there with items that have spells
3719 * which haven't had the randomitems set to null yet. 3602 * which haven't had the randomitems set to null yet.
3720 * MSW 2004-05-13 3603 * MSW 2004-05-13
3721 * 3604 *
3722 * And if it's a spellbook, it's better to set randomitems to NULL too, 3605 * And if it's a spellbook, it's better to set randomitems to NULL too,
3723 * else you get two spells in the book ^_- 3606 * else you get two spells in the book ^_-
3724 * Ryo 2004-08-16 3607 * Ryo 2004-08-16
3725 */ 3608 */
3726 if (tmp->type == WAND || tmp->type == ROD || tmp->type == SCROLL 3609 if (tmp->type == WAND || tmp->type == ROD || tmp->type == SCROLL
3727 || tmp->type == HORN || tmp->type == FIREWALL || tmp->type == POTION || tmp->type == ALTAR || tmp->type == SPELLBOOK) 3610 || tmp->type == HORN || tmp->type == FIREWALL || tmp->type == POTION || tmp->type == ALTAR || tmp->type == SPELLBOOK)
3728 tmp->randomitems = NULL;
3729
3730 }
3731
3732 if (QUERY_FLAG (tmp, FLAG_AUTO_APPLY))
3733 auto_apply (tmp);
3734 else if ((tmp->type == TREASURE || (tmp->type == CONTAINER)) && tmp->has_random_items ())
3735 {
3736 while ((tmp->stats.hp--) > 0)
3737 create_treasure (tmp->randomitems, tmp, 0, m->difficulty, 0);
3738 tmp->randomitems = NULL; 3611 tmp->randomitems = NULL;
3612
3739 } 3613 }
3614
3615 if (QUERY_FLAG (tmp, FLAG_AUTO_APPLY))
3616 auto_apply (tmp);
3617 else if ((tmp->type == TREASURE || (tmp->type == CONTAINER)) && tmp->has_random_items ())
3618 {
3619 while ((tmp->stats.hp--) > 0)
3620 create_treasure (tmp->randomitems, tmp, 0, difficulty, 0);
3621 tmp->randomitems = NULL;
3622 }
3740 else if (tmp->type == TIMED_GATE) 3623 else if (tmp->type == TIMED_GATE)
3741 { 3624 {
3742 object *head = tmp->head != NULL ? tmp->head : tmp; 3625 object *head = tmp->head != NULL ? tmp->head : tmp;
3743 3626
3744 if (QUERY_FLAG (head, FLAG_IS_LINKED)) 3627 if (QUERY_FLAG (head, FLAG_IS_LINKED))
3745 {
3746 tmp->speed = 0; 3628 tmp->set_speed (0);
3747 update_ob_speed (tmp);
3748 }
3749 } 3629 }
3750 /* This function can be called everytime a map is loaded, even when 3630 /* This function can be called everytime a map is loaded, even when
3751 * swapping back in. As such, we don't want to create the treasure 3631 * swapping back in. As such, we don't want to create the treasure
3752 * over and ove again, so after we generate the treasure, blank out 3632 * over and ove again, so after we generate the treasure, blank out
3753 * randomitems so if it is swapped in again, it won't make anything. 3633 * randomitems so if it is swapped in again, it won't make anything.
3754 * This is a problem for the above objects, because they have counters 3634 * This is a problem for the above objects, because they have counters
3755 * which say how many times to make the treasure. 3635 * which say how many times to make the treasure.
3756 */ 3636 */
3757 else if (tmp && tmp->arch && tmp->type != PLAYER 3637 else if (tmp && tmp->arch && tmp->type != PLAYER
3758 && tmp->type != TREASURE && tmp->type != SPELL 3638 && tmp->type != TREASURE && tmp->type != SPELL
3759 && tmp->type != PLAYER_CHANGER && tmp->type != CLASS && tmp->has_random_items ()) 3639 && tmp->type != PLAYER_CHANGER && tmp->type != CLASS && tmp->has_random_items ())
3760 { 3640 {
3761 create_treasure (tmp->randomitems, tmp, GT_APPLY, m->difficulty, 0); 3641 create_treasure (tmp->randomitems, tmp, GT_APPLY, difficulty, 0);
3762 tmp->randomitems = NULL; 3642 tmp->randomitems = NULL;
3763 } 3643 }
3644
3645 // close all containers
3646 else if (tmp->type == CONTAINER)
3647 tmp->flag [FLAG_APPLIED] = 0;
3648
3649 tmp = above;
3764 } 3650 }
3765 3651
3766 for (x = 0; x < MAP_WIDTH (m); x++) 3652 for (mapspace *ms = spaces + size (); ms-- > spaces; )
3767 for (y = 0; y < MAP_HEIGHT (m); y++) 3653 for (object *tmp = ms->bot; tmp; tmp = tmp->above)
3768 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
3769 if (tmp->above && (tmp->type == TRIGGER_BUTTON || tmp->type == TRIGGER_PEDESTAL)) 3654 if (tmp->above && (tmp->type == TRIGGER_BUTTON || tmp->type == TRIGGER_PEDESTAL))
3770 check_trigger (tmp, tmp->above); 3655 check_trigger (tmp, tmp->above);
3771} 3656}
3772 3657
3773/** 3658/**
3774 * Handles player eating food that temporarily changes status (resistances, stats). 3659 * Handles player eating food that temporarily changes status (resistances, stats).
3775 * This used to call cast_change_attr(), but 3660 * This used to call cast_change_attr(), but
3776 * that doesn't work with the new spell code. Since we know what 3661 * that doesn't work with the new spell code. Since we know what
3777 * the food changes, just grab a force and use that instead. 3662 * the food changes, just grab a force and use that instead.
3778 */ 3663 */
3779
3780void 3664void
3781eat_special_food (object *who, object *food) 3665eat_special_food (object *who, object *food)
3782{ 3666{
3783 object *force; 3667 object *force;
3784 int i, did_one = 0; 3668 int i, did_one = 0;
3785 sint8 k;
3786 3669
3787 force = get_archetype (FORCE_NAME); 3670 force = get_archetype (FORCE_NAME);
3788 3671
3789 for (i = 0; i < NUM_STATS; i++) 3672 for (i = 0; i < NUM_STATS; i++)
3790 { 3673 if (sint8 k = food->stats.stat (i))
3791 k = get_attr_value (&food->stats, i);
3792 if (k)
3793 { 3674 {
3794 set_attr_value (&force->stats, i, k); 3675 force->stats.stat (i) = k;
3795 did_one = 1; 3676 did_one = 1;
3796 } 3677 }
3797 }
3798 3678
3799 /* check if we can protect the eater */ 3679 /* check if we can protect the eater */
3800 for (i = 0; i < NROFATTACKS; i++) 3680 for (i = 0; i < NROFATTACKS; i++)
3801 { 3681 {
3802 if (food->resist[i] > 0) 3682 if (food->resist[i] > 0)
… …
3806 } 3686 }
3807 } 3687 }
3808 3688
3809 if (did_one) 3689 if (did_one)
3810 { 3690 {
3811 force->speed = 0.1; 3691 force->set_speed (0.1);
3812 update_ob_speed (force);
3813 /* bigger morsel of food = longer effect time */ 3692 /* bigger morsel of food = longer effect time */
3814 force->duration = food->stats.food / 5; 3693 force->duration = food->stats.food / 5;
3815 SET_FLAG (force, FLAG_APPLIED); 3694 SET_FLAG (force, FLAG_APPLIED);
3816 change_abil (who, force); 3695 change_abil (who, force);
3817 insert_ob_in_ob (force, who); 3696 insert_ob_in_ob (force, who);
… …
3822 /* check for hp, sp change */ 3701 /* check for hp, sp change */
3823 if (food->stats.hp != 0) 3702 if (food->stats.hp != 0)
3824 { 3703 {
3825 if (QUERY_FLAG (food, FLAG_CURSED)) 3704 if (QUERY_FLAG (food, FLAG_CURSED))
3826 { 3705 {
3827 strcpy (who->contr->killer, food->name); 3706 assign (who->contr->killer, food->name);
3828 hit_player (who, food->stats.hp, food, AT_POISON, 1); 3707 hit_player (who, food->stats.hp, food, AT_POISON, 1);
3829 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3708 who->failmsg ("Eck!...that was poisonous!");
3830 } 3709 }
3831 else 3710 else
3832 { 3711 {
3833 if (food->stats.hp > 0) 3712 if (food->stats.hp > 0)
3834 new_draw_info (NDI_UNIQUE, 0, who, "You begin to feel better."); 3713 who->statusmsg ("You begin to feel better.");
3835 else 3714 else
3836 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3715 who->failmsg ("Eck!...that was poisonous!");
3716
3837 who->stats.hp += food->stats.hp; 3717 who->stats.hp += food->stats.hp;
3838 } 3718 }
3839 } 3719 }
3840 if (food->stats.sp != 0) 3720 if (food->stats.sp != 0)
3841 { 3721 {
3842 if (QUERY_FLAG (food, FLAG_CURSED)) 3722 if (QUERY_FLAG (food, FLAG_CURSED))
3843 { 3723 {
3844 new_draw_info (NDI_UNIQUE, 0, who, "You are drained of mana!"); 3724 who->failmsg ("You are drained of mana!");
3845 who->stats.sp -= food->stats.sp; 3725 who->stats.sp -= food->stats.sp;
3846 if (who->stats.sp < 0) 3726 if (who->stats.sp < 0)
3847 who->stats.sp = 0; 3727 who->stats.sp = 0;
3848 } 3728 }
3849 else 3729 else
3850 { 3730 {
3851 new_draw_info (NDI_UNIQUE, 0, who, "You feel a rush of magical energy!"); 3731 who->statusmsg ("You feel a rush of magical energy!");
3852 who->stats.sp += food->stats.sp; 3732 who->stats.sp += food->stats.sp;
3853 /* place limit on max sp from food? */ 3733 /* place limit on max sp from food? */
3854 } 3734 }
3855 } 3735 }
3736
3856 who->update_stats (); 3737 who->update_stats ();
3857} 3738}
3858 3739
3859/** 3740/**
3860 * Designed primarily to light torches/lanterns/etc. 3741 * Designed primarily to light torches/lanterns/etc.
… …
3870 item = find_marked_object (who); 3751 item = find_marked_object (who);
3871 if (item) 3752 if (item)
3872 { 3753 {
3873 if (lighter->last_eat && lighter->stats.food) 3754 if (lighter->last_eat && lighter->stats.food)
3874 { /* lighter gets used up */ 3755 { /* lighter gets used up */
3875 /* Split multiple lighters if they're being used up. Otherwise *
3876 * one charge from each would be used up. --DAMN */
3877 if (lighter->nrof > 1)
3878 {
3879 object *oneLighter = lighter->clone (); 3756 object *oneLighter = lighter->split ();
3880
3881 lighter->nrof -= 1;
3882 oneLighter->nrof = 1;
3883 oneLighter->stats.food--; 3757 oneLighter->stats.food--;
3884 esrv_send_item (who, lighter); 3758 who->insert (oneLighter);
3885 oneLighter = insert_ob_in_ob (oneLighter, who);
3886 esrv_send_item (who, oneLighter);
3887 }
3888 else
3889 lighter->stats.food--;
3890 } 3759 }
3891 else if (lighter->last_eat) 3760 else if (lighter->last_eat)
3761 {
3892 { /* no charges left in lighter */ 3762 /* no charges left in lighter */
3893 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with a used up %s.", &item->name, &lighter->name); 3763 who->failmsg (format ("You attempt to light the %s with a used up %s.", &item->name, &lighter->name));
3894 return; 3764 return;
3895 } 3765 }
3896 3766
3897 /* Perhaps we should split what we are trying to light on fire? 3767 /* Perhaps we should split what we are trying to light on fire?
3898 * I can't see many times when you would want to light multiple 3768 * I can't see many times when you would want to light multiple
… …
3904 3774
3905 save_throw_object (item, AT_FIRE, who); 3775 save_throw_object (item, AT_FIRE, who);
3906 3776
3907 if (item->destroyed ()) 3777 if (item->destroyed ())
3908 { 3778 {
3909 new_draw_info_format (NDI_UNIQUE, 0, who, "You light the %s with the %s.", &item->name, &lighter->name); 3779 who->statusmsg (format ("You light the %s with the %s.", &item->name, &lighter->name));
3910 /* Need to update the player so that the players glow radius 3780 /* Need to update the player so that the players glow radius
3911 * gets changed. 3781 * gets changed.
3912 */ 3782 */
3913 if (is_player_env) 3783 if (is_player_env)
3914 who->update_stats (); 3784 who->update_stats ();
3915 } 3785 }
3916 else 3786 else
3917 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with the %s and fail.", &item->name, &lighter->name); 3787 who->failmsg (format ("You attempt to light the %s with the %s and fail.", &item->name, &lighter->name));
3918 } 3788 }
3919 else /* nothing to light */ 3789 else
3920 new_draw_info (NDI_UNIQUE, 0, who, "You need to mark a lightable object."); 3790 who->failmsg ("You need to mark a lightable object.");
3921
3922} 3791}
3923 3792
3924/** 3793/**
3925 * op made some mistake with a scroll, this takes care of punishment. 3794 * op made some mistake with a scroll, this takes care of punishment.
3926 * scroll_failure()- hacked directly from spell_failure 3795 * scroll_failure()- hacked directly from spell_failure
… …
3933 3802
3934 if (failure <= -1 && failure > -15) 3803 if (failure <= -1 && failure > -15)
3935 { /* wonder */ 3804 { /* wonder */
3936 object *tmp; 3805 object *tmp;
3937 3806
3938 new_draw_info (NDI_UNIQUE, 0, op, "Your spell warps!."); 3807 op->failmsg ("Your spell warps!");
3939 tmp = get_archetype (SPELL_WONDER); 3808 tmp = get_archetype (SPELL_WONDER);
3940 cast_wonder (op, op, 0, tmp); 3809 cast_wonder (op, op, 0, tmp);
3941 tmp->destroy (); 3810 tmp->destroy ();
3942 } 3811 }
3943 else if (failure <= -15 && failure > -35) 3812 else if (failure <= -15 && failure > -35)
3944 { /* drain mana */ 3813 { /* drain mana */
3945 new_draw_info (NDI_UNIQUE, 0, op, "Your mana is drained!."); 3814 op->failmsg ("Your mana is drained!");
3946 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW); 3815 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW);
3947 if (op->stats.sp < 0) 3816 if (op->stats.sp < 0)
3948 op->stats.sp = 0; 3817 op->stats.sp = 0;
3949 } 3818 }
3950 else if (settings.spell_failure_effects == TRUE) 3819 else if (settings.spell_failure_effects == TRUE)
3951 { 3820 {
3952 if (failure <= -35 && failure > -60) 3821 if (failure <= -35 && failure > -60)
3953 { /* confusion */ 3822 { /* confusion */
3954 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3823 op->failmsg ("The magic recoils on you!");
3955 confuse_player (op, op, power); 3824 confuse_player (op, op, power);
3956 } 3825 }
3957 else if (failure <= -60 && failure > -70) 3826 else if (failure <= -60 && failure > -70)
3958 { /* paralysis */ 3827 { /* paralysis */
3959 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils and paralyzes " "you!"); 3828 op->failmsg ("The magic recoils and paralyzes you!");
3960 paralyze_player (op, op, power); 3829 paralyze_player (op, op, power);
3961 } 3830 }
3962 else if (failure <= -70 && failure > -80) 3831 else if (failure <= -70 && failure > -80)
3963 { /* blind */ 3832 { /* blind */
3964 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3833 op->failmsg ("The magic recoils on you!");
3965 blind_player (op, op, power); 3834 blind_player (op, op, power);
3966 } 3835 }
3967 else if (failure <= -80) 3836 else if (failure <= -80)
3968 { /* blast the immediate area */ 3837 { /* blast the immediate area */
3969 object *tmp;
3970
3971 tmp = get_archetype (LOOSE_MANA); 3838 object *tmp = get_archetype (LOOSE_MANA);
3972 cast_magic_storm (op, tmp, power); 3839 cast_magic_storm (op, tmp, power);
3973 new_draw_info (NDI_UNIQUE, 0, op, "You unlease uncontrolled mana!"); 3840 op->failmsg ("You unleash uncontrolled mana!");
3974 tmp->destroy (); 3841 tmp->destroy ();
3975 } 3842 }
3976 } 3843 }
3977} 3844}
3978 3845
… …
3998 */ 3865 */
3999 int i, j; 3866 int i, j;
4000 3867
4001 for (i = 0; i < NUM_STATS; i++) 3868 for (i = 0; i < NUM_STATS; i++)
4002 { 3869 {
4003 sint8 stat = get_attr_value (stats, i); 3870 int race_bonus = pl->arch->stats.stat (i);
4004 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i); 3871 sint8 stat = stats->stat (i) + ns->stat (i);
4005 3872
4006 stat += get_attr_value (ns, i);
4007 if (stat > 20 + race_bonus) 3873 if (stat > 20 + race_bonus)
4008 { 3874 {
4009 excess_stat++; 3875 excess_stat++;
4010 stat = 20 + race_bonus; 3876 stat = 20 + race_bonus;
4011 } 3877 }
4012 set_attr_value (stats, i, stat); 3878
3879 stats->stat (i) = stat;
4013 } 3880 }
4014 3881
4015 for (j = 0; excess_stat > 0 && j < 100; j++) 3882 for (j = 0; excess_stat > 0 && j < 100; j++)
4016 { /* try 100 times to assign excess stats */ 3883 { /* try 100 times to assign excess stats */
4017 int i = rndm (0, 6); 3884 int i = rndm (0, 6);
4018 int stat = get_attr_value (stats, i);
4019 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i);
4020 3885
4021 if (i == CHA) 3886 if (i == CHA)
4022 continue; /* exclude cha from this */ 3887 continue; /* exclude cha from this */
3888
3889 int stat = stats->stat (i);
3890 int race_bonus = pl->arch->stats.stat (i);
4023 if (stat < 20 + race_bonus) 3891 if (stat < 20 + race_bonus)
4024 { 3892 {
4025 change_attr_value (stats, i, 1); 3893 change_attr_value (stats, i, 1);
4026 excess_stat--; 3894 excess_stat--;
4027 } 3895 }
… …
4030 /* insert the randomitems from the change's treasurelist into 3898 /* insert the randomitems from the change's treasurelist into
4031 * the player ref: player.c 3899 * the player ref: player.c
4032 */ 3900 */
4033 if (change->randomitems != NULL) 3901 if (change->randomitems != NULL)
4034 give_initial_items (pl, change->randomitems); 3902 give_initial_items (pl, change->randomitems);
4035
4036 3903
4037 /* set up the face, for some races. */ 3904 /* set up the face, for some races. */
4038 3905
4039 /* first, look for the force object banning 3906 /* first, look for the force object banning
4040 * changing the face. Certain races never change face with class. 3907 * changing the face. Certain races never change face with class.
… …
4085 char got[MAX_BUF]; 3952 char got[MAX_BUF];
4086 int len; 3953 int len;
4087 3954
4088 if (!pl || !transformer) 3955 if (!pl || !transformer)
4089 return; 3956 return;
3957
4090 marked = find_marked_object (pl); 3958 marked = find_marked_object (pl);
3959
4091 if (!marked) 3960 if (!marked)
4092 { 3961 {
4093 new_draw_info_format (NDI_UNIQUE, 0, pl, "Use the %s with what item?", query_name (transformer)); 3962 pl->failmsg (format ("Use the %s with what item?", query_name (transformer)));
4094 return; 3963 return;
4095 } 3964 }
3965
4096 if (!marked->slaying) 3966 if (!marked->slaying)
4097 { 3967 {
4098 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3968 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4099 return; 3969 return;
4100 } 3970 }
3971
4101 /* check whether they are compatible or not */ 3972 /* check whether they are compatible or not */
4102 find = strstr (marked->slaying, transformer->arch->name); 3973 find = strstr (marked->slaying, transformer->arch->archname);
4103 if (!find || (*(find + strlen (transformer->arch->name)) != ':')) 3974 if (!find || (*(find + strlen (transformer->arch->archname)) != ':'))
4104 { 3975 {
4105 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3976 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4106 return; 3977 return;
4107 } 3978 }
3979
4108 find += strlen (transformer->arch->name) + 1; 3980 find += strlen (transformer->arch->archname) + 1;
4109 /* Item can be used, now find how many and what it yields */ 3981 /* Item can be used, now find how many and what it yields */
4110 if (isdigit (*(find))) 3982 if (isdigit (*(find)))
4111 { 3983 {
4112 yield = atoi (find); 3984 yield = atoi (find);
4113 if (yield < 1) 3985 if (yield < 1)
… …
4119 else 3991 else
4120 yield = 1; 3992 yield = 1;
4121 3993
4122 while (isdigit (*find)) 3994 while (isdigit (*find))
4123 find++; 3995 find++;
3996
4124 while (*find == ' ') 3997 while (*find == ' ')
4125 find++; 3998 find++;
3999
4126 memset (got, 0, MAX_BUF); 4000 memset (got, 0, MAX_BUF);
4001
4127 if ((separator = strchr (find, ';')) != NULL) 4002 if ((separator = strchr (find, ';')) != NULL)
4128 {
4129 len = separator - find; 4003 len = separator - find;
4130 }
4131 else 4004 else
4132 {
4133 len = strlen (find); 4005 len = strlen (find);
4134 } 4006
4135 if (len > MAX_BUF - 1) 4007 if (len > MAX_BUF - 1)
4136 len = MAX_BUF - 1; 4008 len = MAX_BUF - 1;
4009
4137 strcpy (got, find); 4010 strcpy (got, find);
4138 got[len] = '\0'; 4011 got[len] = '\0';
4139 4012
4140 /* Now create new item, remove used ones when required. */ 4013 /* Now create new item, remove used ones when required. */
4141 new_item = get_archetype (got); 4014 new_item = get_archetype (got);
4142 if (!new_item) 4015 if (!new_item)
4143 { 4016 {
4144 new_draw_info_format (NDI_UNIQUE, 0, pl, "This %s is strange, better to not use it.", query_base_name (marked, 0)); 4017 pl->failmsg (format ("This %s is strange, better to not use it.", query_base_name (marked, 0)));
4145 return; 4018 return;
4146 } 4019 }
4147 4020
4148 new_item->nrof = yield; 4021 new_item->nrof = yield;
4022
4149 new_draw_info_format (NDI_UNIQUE, 0, pl, "You %s the %s.", &transformer->slaying, query_base_name (marked, 0)); 4023 pl->statusmsg (format ("You %s the %s.", &transformer->slaying, query_base_name (marked, 0)));
4150 insert_ob_in_ob (new_item, pl); 4024
4151 esrv_send_inventory (pl, pl); 4025 pl->insert (new_item);
4152 /* Eat up one item */ 4026 /* Eat up one item */
4153 decrease_ob_nr (marked, 1); 4027 marked->decrease ();
4028
4154 /* Eat one transformer if needed */ 4029 /* Eat one transformer if needed */
4155 if (transformer->stats.food) 4030 if (transformer->stats.food)
4156 if (--transformer->stats.food == 0) 4031 if (--transformer->stats.food == 0)
4157 decrease_ob_nr (transformer, 1); 4032 transformer->decrease ();
4158} 4033}
4034

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines