ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/apply.C
(Generate patch)

Comparing deliantra/server/server/apply.C (file contents):
Revision 1.59 by pippijn, Sat Jan 6 14:42:30 2007 UTC vs.
Revision 1.151 by root, Wed Apr 30 06:40:28 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 7 *
8 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 (at your option) any later version. 11 * (at your option) any later version.
12 12 *
13 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details. 16 * GNU General Public License for more details.
17 17 *
18 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
21 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 The authors can be reached via e-mail to <crossfire@schmorp.de>
23*/ 22 */
23
24#include <cmath>
24 25
25#include <global.h> 26#include <global.h>
26#include <living.h> 27#include <living.h>
27#include <spells.h> 28#include <spells.h>
28#include <skills.h> 29#include <skills.h>
… …
30 31
31#include <sproto.h> 32#include <sproto.h>
32 33
33/* Want this regardless of rplay. */ 34/* Want this regardless of rplay. */
34#include <sounds.h> 35#include <sounds.h>
35
36/* need math lib for double-precision and pow() in dragon_eat_flesh() */
37#include <math.h>
38 36
39/** 37/**
40 * Check if op should abort moving victim because of it's race or slaying. 38 * Check if op should abort moving victim because of it's race or slaying.
41 * Returns 1 if it should abort, returns 0 if it should continue. 39 * Returns 1 if it should abort, returns 0 if it should continue.
42 */ 40 */
… …
65 { 63 {
66 arch_flag = 1; 64 arch_flag = 1;
67 name_flag = 1; 65 name_flag = 1;
68 race_flag = 1; 66 race_flag = 1;
69 } 67 }
68
70 /* If the director has race set, only affect objects with a arch, 69 /* If the director has race set, only affect objects with a arch,
71 * name or race that matches. 70 * name or race that matches.
72 */ 71 */
73 if ((op->race) && 72 if ((op->race) &&
74 ((!(victim->arch && arch_flag && victim->arch->name) || strcmp (op->race, victim->arch->name))) && 73 ((!(victim->arch && arch_flag && victim->arch->archname) || op->race != victim->arch->archname)) &&
75 ((!(victim->name && name_flag) || strcmp (op->race, victim->name))) && 74 ((!(victim->name && name_flag) || op->race != victim->name)) &&
76 ((!(victim->race && race_flag) || strcmp (op->race, victim->race)))) 75 ((!(victim->race && race_flag) || op->race != victim->race)))
77 {
78 return 1; 76 return 1;
79 } 77
80 /* If the director has slaying set, only affect objects where none 78 /* If the director has slaying set, only affect objects where none
81 * of arch, name, or race match. 79 * of arch, name, or race match.
82 */ 80 */
83 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->name && !strcmp (op->slaying, victim->arch->name))) || 81 if ((op->slaying) && (((victim->arch && arch_flag && victim->arch->archname && op->slaying == victim->arch->archname))) ||
84 ((victim->name && name_flag && !strcmp (op->slaying, victim->name))) || 82 ((victim->name && name_flag && op->slaying == victim->name)) ||
85 ((victim->race && race_flag && !strcmp (op->slaying, victim->race))))) 83 ((victim->race && race_flag && op->slaying == victim->race)))
86 {
87 return 1; 84 return 1;
88 } 85
89 return 0; 86 return 0;
90} 87}
91 88
92/** 89/**
93 * This handles a player dropping money on an altar to identify stuff. 90 * This handles a player dropping money on an altar to identify stuff.
… …
95 * Return value: 1 if money was destroyed, 0 if not. 92 * Return value: 1 if money was destroyed, 0 if not.
96 */ 93 */
97static int 94static int
98apply_id_altar (object *money, object *altar, object *pl) 95apply_id_altar (object *money, object *altar, object *pl)
99{ 96{
100 object *id, *marked; 97 dynbuf_text buf;
101 int success = 0;
102 98
103 if (pl == NULL || pl->type != PLAYER) 99 if (!pl || pl->type != PLAYER)
104 return 0; 100 return 0;
105 101
106 /* Check for MONEY type is a special hack - it prevents 'nothing needs 102 /* Check for MONEY type is a special hack - it prevents 'nothing needs
107 * identifying' from being printed out more than it needs to be. 103 * identifying' from being printed out more than it needs to be.
108 */ 104 */
109 if (!check_altar_sacrifice (altar, money) || money->type != MONEY) 105 if (!check_altar_sacrifice (altar, money) || money->type != MONEY)
110 return 0; 106 return 0;
111 107
112 marked = find_marked_object (pl);
113 /* if the player has a marked item, identify that if it needs to be 108 /* if the player has a marked item, identify that if it needs to be
114 * identified. IF it doesn't, then go through the player inventory. 109 * identified. If it doesn't, then go through the player inventory.
115 */ 110 */
111 if (object *marked = find_marked_object (pl))
116 if (marked && !QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked)) 112 if (!QUERY_FLAG (marked, FLAG_IDENTIFIED) && need_identify (marked))
117 { 113 {
118 if (operate_altar (altar, &money)) 114 if (operate_altar (altar, &money))
119 { 115 {
120 identify (marked); 116 identify (marked);
121 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (marked, pl)); 117
118 buf.printf ("You have %s.\n\n", long_desc (marked, pl));
122 if (marked->msg) 119 if (marked->msg)
123 { 120 buf << "The item has a story:\n\n" << marked->msg << "\n\n";
124 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 121
125 new_draw_info (NDI_UNIQUE, 0, pl, marked->msg); 122 return !money;
126 } 123 }
127 return money == NULL;
128 } 124 }
129 }
130 125
131 for (id = pl->inv; id; id = id->below) 126 for (object *id = pl->inv; id; id = id->below)
132 { 127 {
133 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id)) 128 if (!QUERY_FLAG (id, FLAG_IDENTIFIED) && !id->invisible && need_identify (id))
134 { 129 {
135 if (operate_altar (altar, &money)) 130 if (operate_altar (altar, &money))
136 { 131 {
137 identify (id); 132 identify (id);
138 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have %s.", long_desc (id, pl)); 133
134 buf.printf ("You have %s.\n\n", long_desc (id, pl));
139 if (id->msg) 135 if (id->msg)
140 { 136 buf << "The item has a story:\n\n" << id->msg << "\n\n";
141 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 137
142 new_draw_info (NDI_UNIQUE, 0, pl, id->msg);
143 }
144 success = 1;
145 /* If no more money, might as well quit now */ 138 /* If no more money, might as well quit now */
146 if (money == NULL || !check_altar_sacrifice (altar, money)) 139 if (!money || !check_altar_sacrifice (altar, money))
147 break; 140 break;
148 } 141 }
149 else 142 else
150 { 143 {
151 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n"); 144 LOG (llevError, "check_id_altar: Couldn't do sacrifice when we should have been able to\n");
152 break; 145 break;
153 } 146 }
154 } 147 }
155 } 148 }
156 if (!success) 149
157 new_draw_info (NDI_UNIQUE, 0, pl, "You have nothing that needs identifying"); 150 if (buf.empty ())
151 pl->failmsg ("You have nothing that needs identifying");
152 else
153 pl->contr->infobox (MSG_CHANNEL ("identify"), buf);
154
158 return money == NULL; 155 return !money;
159} 156}
160 157
161/** 158/**
162 * This checks whether the object has a "on_use_yield" field, and if so generated and drops 159 * This checks whether the object has a "on_use_yield" field, and if so generated and drops
163 * matching item. 160 * matching item.
164 **/ 161 **/
165static void 162void
166handle_apply_yield (object *tmp) 163handle_apply_yield (object *tmp)
167{ 164{
168 const char *yield; 165 const char *yield;
169 166
170 yield = get_ob_key_value (tmp, "on_use_yield"); 167 yield = get_ob_key_value (tmp, "on_use_yield");
168
171 if (yield != NULL) 169 if (yield)
172 { 170 get_archetype (yield)->insert_at (tmp, tmp, INS_BELOW_ORIGINATOR);
173 object *drop = get_archetype (yield);
174
175 if (tmp->env)
176 {
177 drop = insert_ob_in_ob (drop, tmp->env);
178 if (tmp->env->type == PLAYER)
179 esrv_send_item (tmp->env, drop);
180 }
181 else
182 {
183 drop->x = tmp->x;
184 drop->y = tmp->y;
185 insert_ob_in_map (drop, tmp->map, tmp, INS_BELOW_ORIGINATOR);
186 }
187 }
188} 171}
189 172
190/** 173/**
191 * Handles applying a potion. 174 * Handles applying a potion.
192 */ 175 */
… …
198 181
199 floor = GET_MAP_OB (op->map, op->x, op->y); 182 floor = GET_MAP_OB (op->map, op->x, op->y);
200 183
201 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE) 184 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_SAFE)
202 { 185 {
203 if (op->type == PLAYER)
204 new_draw_info (NDI_UNIQUE, 0, op, "Gods prevent you from using this here, it's sacred ground!"); 186 op->failmsg ("Gods prevent you from using this here, it's sacred ground!");
187
205 CLEAR_FLAG (tmp, FLAG_APPLIED); 188 CLEAR_FLAG (tmp, FLAG_APPLIED);
206 return 0; 189 return 0;
207 } 190 }
208 191
209 if (op->type == PLAYER) 192 if (op->type == PLAYER)
… …
220 203
221 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 204 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
222 { 205 {
223 op->drain_stat (); 206 op->drain_stat ();
224 op->update_stats (); 207 op->update_stats ();
225 decrease_ob (tmp); 208 tmp->decrease ();
226 return 1; 209 return 1;
227 } 210 }
228 211
229 if (!(at = archetype::find (ARCH_DEPLETION))) 212 if (!(at = archetype::find (ARCH_DEPLETION)))
230 { 213 {
231 LOG (llevError, "Could not find archetype depletion\n"); 214 LOG (llevError, "Could not find archetype depletion\n");
232 return 0; 215 return 0;
233 } 216 }
217
234 depl = present_arch_in_ob (at, op); 218 depl = present_arch_in_ob (at, op);
235 219
236 if (depl) 220 if (depl)
237 { 221 {
238 for (i = 0; i < NUM_STATS; i++) 222 for (i = 0; i < NUM_STATS; i++)
239 if (get_attr_value (&depl->stats, i)) 223 if (depl->stats.stat (i))
240 new_draw_info (NDI_UNIQUE, 0, op, restore_msg[i]); 224 op->statusmsg (restore_msg[i]);
241 225
242 depl->destroy (); 226 depl->destroy ();
243 op->update_stats (); 227 op->update_stats ();
244 } 228 }
245 else 229 else
246 new_draw_info (NDI_UNIQUE, 0, op, "You potion had no effect."); 230 op->statusmsg ("Your potion had no effect.");
247 231
248 decrease_ob (tmp); 232 tmp->decrease ();
249 return 1; 233 return 1;
250 } 234 }
251 235
252 /* improvement potion - only for players */ 236 /* improvement potion - only for players */
253 if (op->type == PLAYER && tmp->attacktype & AT_GODPOWER) 237 if (op->type == PLAYER && (tmp->attacktype & AT_GODPOWER))
254 { 238 {
255 for (i = 1; i < MIN (11, op->level); i++) 239 for (i = 1; i < MIN (11, op->level); i++)
256 { 240 {
257 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 241 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
258 { 242 {
259 if (op->contr->levhp[i] != 1) 243 if (op->contr->levhp[i] != 1)
260 { 244 {
261 op->contr->levhp[i] = 1; 245 op->contr->levhp[i] = 1;
262 break; 246 break;
263 } 247 }
248
264 if (op->contr->levsp[i] != 1) 249 if (op->contr->levsp[i] != 1)
265 { 250 {
266 op->contr->levsp[i] = 1; 251 op->contr->levsp[i] = 1;
267 break; 252 break;
268 } 253 }
254
269 if (op->contr->levgrace[i] != 1) 255 if (op->contr->levgrace[i] != 1)
270 { 256 {
271 op->contr->levgrace[i] = 1; 257 op->contr->levgrace[i] = 1;
272 break; 258 break;
273 } 259 }
… …
277 if (op->contr->levhp[i] < 9) 263 if (op->contr->levhp[i] < 9)
278 { 264 {
279 op->contr->levhp[i] = 9; 265 op->contr->levhp[i] = 9;
280 break; 266 break;
281 } 267 }
268
282 if (op->contr->levsp[i] < 6) 269 if (op->contr->levsp[i] < 6)
283 { 270 {
284 op->contr->levsp[i] = 6; 271 op->contr->levsp[i] = 6;
285 break; 272 break;
286 } 273 }
274
287 if (op->contr->levgrace[i] < 3) 275 if (op->contr->levgrace[i] < 3)
288 { 276 {
289 op->contr->levgrace[i] = 3; 277 op->contr->levgrace[i] = 3;
290 break; 278 break;
291 } 279 }
… …
299 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)) 287 if (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))
300 { 288 {
301 if (got_one) 289 if (got_one)
302 { 290 {
303 op->update_stats (); 291 op->update_stats ();
304 new_draw_info (NDI_UNIQUE, 0, op, "The Gods smile upon you and remake you"); 292 op->statusmsg ("The Gods smile upon you and remake you "
305 new_draw_info (NDI_UNIQUE, 0, op, "a little more in their image."); 293 "a little more in their image. "
306 new_draw_info (NDI_UNIQUE, 0, op, "You feel a little more perfect."); 294 "You feel a little more perfect.", NDI_GREEN);
307 } 295 }
308 else 296 else
309 new_draw_info (NDI_UNIQUE, 0, op, "The potion had no effect - you are already perfect"); 297 op->statusmsg ("The potion had no effect - you are already perfect.");
310 } 298 }
311 else 299 else
312 { /* cursed potion */ 300 { /* cursed potion */
313 if (got_one) 301 if (got_one)
314 { 302 {
315 op->update_stats (); 303 op->update_stats ();
316 new_draw_info (NDI_UNIQUE, 0, op, "The Gods are angry and punish you."); 304 op->failmsg ("The Gods are angry and punish you.");
317 } 305 }
318 else 306 else
319 new_draw_info (NDI_UNIQUE, 0, op, "You are fortunate that you are so pathetic."); 307 op->statusmsg ("You are fortunate that you are so pathetic.", NDI_DK_ORANGE);
320 } 308 }
321 309
322 decrease_ob (tmp); 310 tmp->decrease ();
323 return 1; 311 return 1;
324 } 312 }
325 313
326 314
327 /* A potion that casts a spell. Healing, restore spellpoint (power potion) 315 /* A potion that casts a spell. Healing, restore spellpoint (power potion)
… …
333 { 321 {
334 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 322 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
335 { 323 {
336 object *fball; 324 object *fball;
337 325
338 new_draw_info (NDI_UNIQUE, 0, op, "Yech! Your lungs are on fire!"); 326 op->failmsg ("Yech! Your lungs are on fire!");
327
339 /* Explodes a fireball centered at player */ 328 /* Explodes a fireball centered at player */
340 fball = get_archetype (EXPLODING_FIREBALL); 329 fball = get_archetype (EXPLODING_FIREBALL);
341 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1; 330 fball->dam_modifier = random_roll (1, op->level, op, PREFER_LOW) / 5 + 1;
342 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2; 331 fball->stats.maxhp = random_roll (1, op->level, op, PREFER_LOW) / 10 + 2;
343 fball->x = op->x; 332 fball->x = op->x;
… …
345 insert_ob_in_map (fball, op->map, NULL, 0); 334 insert_ob_in_map (fball, op->map, NULL, 0);
346 } 335 }
347 else 336 else
348 cast_spell (op, tmp, op->facing, tmp->inv, NULL); 337 cast_spell (op, tmp, op->facing, tmp->inv, NULL);
349 338
350 decrease_ob (tmp); 339 tmp->decrease ();
340
351 /* if youre dead, no point in doing this... */ 341 /* if youre dead, no point in doing this... */
352 if (!QUERY_FLAG (op, FLAG_REMOVED)) 342 if (!QUERY_FLAG (op, FLAG_REMOVED))
353 op->update_stats (); 343 op->update_stats ();
344
354 return 1; 345 return 1;
355 } 346 }
356 347
357 /* Deal with protection potions */ 348 /* Deal with protection potions */
358 force = NULL; 349 force = NULL;
… …
360 { 351 {
361 if (tmp->resist[i]) 352 if (tmp->resist[i])
362 { 353 {
363 if (!force) 354 if (!force)
364 force = get_archetype (FORCE_NAME); 355 force = get_archetype (FORCE_NAME);
356
365 memcpy (force->resist, tmp->resist, sizeof (tmp->resist)); 357 memcpy (force->resist, tmp->resist, sizeof (tmp->resist));
366 force->type = POTION_EFFECT; 358 force->type = POTION_EFFECT;
367 break; /* Only need to find one protection since we copy entire batch */ 359 break; /* Only need to find one protection since we copy entire batch */
368 } 360 }
369 } 361 }
362
370 /* This is a protection potion */ 363 /* This is a protection potion */
371 if (force) 364 if (force)
372 { 365 {
373 /* cursed items last longer */ 366 /* cursed items last longer */
374 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) 367 if (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))
… …
376 force->stats.food *= 10; 369 force->stats.food *= 10;
377 for (i = 0; i < NROFATTACKS; i++) 370 for (i = 0; i < NROFATTACKS; i++)
378 if (force->resist[i] > 0) 371 if (force->resist[i] > 0)
379 force->resist[i] = -force->resist[i]; /* prot => vuln */ 372 force->resist[i] = -force->resist[i]; /* prot => vuln */
380 } 373 }
374
381 force->speed_left = -1; 375 force->speed_left = -1;
382 force = insert_ob_in_ob (force, op); 376 force = insert_ob_in_ob (force, op);
383 CLEAR_FLAG (tmp, FLAG_APPLIED); 377 CLEAR_FLAG (tmp, FLAG_APPLIED);
384 SET_FLAG (force, FLAG_APPLIED); 378 SET_FLAG (force, FLAG_APPLIED);
385 change_abil (op, force); 379 change_abil (op, force);
386 decrease_ob (tmp); 380 tmp->decrease ();
387 return 1; 381 return 1;
388 } 382 }
389 383
390 /* Only thing left are the stat potions */ 384 /* Only thing left are the stat potions */
391 if (op->type == PLAYER) 385 if (op->type == PLAYER)
392 { /* only for players */ 386 { /* only for players */
393 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0) 387 if ((QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->value != 0)
394 CLEAR_FLAG (tmp, FLAG_APPLIED); 388 CLEAR_FLAG (tmp, FLAG_APPLIED);
395 else 389 else
396 SET_FLAG (tmp, FLAG_APPLIED); 390 SET_FLAG (tmp, FLAG_APPLIED);
391
397 if (!change_abil (op, tmp)) 392 if (!change_abil (op, tmp))
398 new_draw_info (NDI_UNIQUE, 0, op, "Nothing happened."); 393 op->statusmsg ("Nothing happened.");
399 } 394 }
400 395
401 /* CLEAR_FLAG is so that if the character has other potions 396 /* CLEAR_FLAG is so that if the character has other potions
402 * that were grouped with the one consumed, his 397 * that were grouped with the one consumed, his
403 * stat will not be raised by them. fix_player just clears 398 * stat will not be raised by them. fix_player just clears
404 * up all the stats. 399 * up all the stats.
405 */ 400 */
406 CLEAR_FLAG (tmp, FLAG_APPLIED); 401 CLEAR_FLAG (tmp, FLAG_APPLIED);
407 op->update_stats (); 402 op->update_stats ();
408 decrease_ob (tmp); 403 tmp->decrease ();
409 return 1; 404 return 1;
410} 405}
411 406
412/**************************************************************************** 407/****************************************************************************
413 * Weapon improvement code follows 408 * Weapon improvement code follows
… …
419static int 414static int
420check_item (object *op, const char *item) 415check_item (object *op, const char *item)
421{ 416{
422 int count = 0; 417 int count = 0;
423 418
424 419 if (!item)
425 if (item == NULL)
426 return 0; 420 return 0;
427 op = op->below; 421
428 while (op != NULL) 422 for (op = op->below; op; op = op->below)
429 { 423 {
430 if (strcmp (op->arch->name, item) == 0) 424 if (strcmp (op->arch->archname, item) == 0)
431 { 425 {
432 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED) 426 if (!QUERY_FLAG (op, FLAG_CURSED) && !QUERY_FLAG (op, FLAG_DAMNED)
433 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID)) 427 /* Loophole bug? -FD- */ && !QUERY_FLAG (op, FLAG_UNPAID))
434 { 428 {
435 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */ 429 if (op->nrof == 0) /* this is necessary for artifact sacrifices --FD-- */
436 count++; 430 count++;
437 else 431 else
438 count += op->nrof; 432 count += op->nrof;
439 } 433 }
440 } 434 }
441 op = op->below;
442 } 435 }
436
443 return count; 437 return count;
444} 438}
445 439
446/** 440/**
447 * This removes 'nrof' of what item->slaying says to remove. 441 * This removes 'nrof' of what item->slaying says to remove.
… …
455 object *prev; 449 object *prev;
456 450
457 prev = op; 451 prev = op;
458 op = op->below; 452 op = op->below;
459 453
460 while (op != NULL) 454 while (op)
461 { 455 {
462 if (strcmp (op->arch->name, item) == 0) 456 if (strcmp (op->arch->archname, item) == 0)
463 { 457 {
464 if (op->nrof >= nrof) 458 if (op->nrof >= nrof)
465 { 459 {
466 decrease_ob_nr (op, nrof); 460 op->decrease (nrof);
467 return; 461 return;
468 } 462 }
469 else 463 else
470 { 464 {
471 decrease_ob_nr (op, op->nrof); 465 op->decrease (nrof);
472 nrof -= op->nrof; 466 nrof -= op->nrof;
473 } 467 }
468
474 op = prev; 469 op = prev;
475 } 470 }
471
476 prev = op; 472 prev = op;
477 op = op->below; 473 op = op->below;
478 } 474 }
479} 475}
480 476
… …
486 * we return 1 (true) if the player can use the weapon. 482 * we return 1 (true) if the player can use the weapon.
487 */ 483 */
488static int 484static int
489check_weapon_power (const object *who, int improvs) 485check_weapon_power (const object *who, int improvs)
490{ 486{
491
492/* Old code is below (commented out). Basically, since weapons are the only 487/* Old code is below (commented out). Basically, since weapons are the only
493 * object players really have any control to improve, it's a bit harsh to 488 * object players really have any control to improve, it's a bit harsh to
494 * require high level in some combat skill, so we just use overall level. 489 * require high level in some combat skill, so we just use overall level.
495 */ 490 */
496#if 1 491#if 1
… …
537static int 532static int
538check_sacrifice (object *op, const object *improver) 533check_sacrifice (object *op, const object *improver)
539{ 534{
540 int count = 0; 535 int count = 0;
541 536
542 if (improver->slaying != NULL) 537 if (improver->slaying)
543 { 538 {
544 count = check_item (op, improver->slaying); 539 count = check_item (op, improver->slaying);
545 if (count < 1) 540 if (count < 1)
546 { 541 {
547 char buf[200];
548
549 sprintf (buf, "The gods want more %ss", &improver->slaying); 542 op->failmsg (format ("The gods want more %ss", &improver->slaying));
550 new_draw_info (NDI_UNIQUE, 0, op, buf);
551 return 0; 543 return 0;
552 } 544 }
553 } 545 }
554 else 546 else
555 count = 1; 547 count = 1;
… …
558} 550}
559 551
560/** 552/**
561 * Actually improves the weapon, and tells user. 553 * Actually improves the weapon, and tells user.
562 */ 554 */
563int 555static int
564improve_weapon_stat (object *op, object *improver, object *weapon, signed char *stat, int sacrifice_count, const char *statname) 556improve_weapon_stat (object *op, object *improver, object *weapon, sint8 &stat, int sacrifice_count, const char *statname)
565{ 557{
566
567 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
568 *stat += sacrifice_count; 558 stat += sacrifice_count;
569 weapon->last_eat++; 559 weapon->last_eat++;
570 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon's bonus to %s improved by %d", statname, sacrifice_count); 560 improver->decrease ();
571 decrease_ob (improver);
572 561
573 /* So it updates the players stats and the window */ 562 /* So it updates the players stats and the window */
574 op->update_stats (); 563 op->update_stats ();
564
565 op->statusmsg (format (
566 "Your sacrifice was accepted.\n"
567 "Weapon's bonus to %s improved by %d.",
568 statname, sacrifice_count
569 ));
570
575 return 1; 571 return 1;
576} 572}
577 573
578/* Types of improvements, hidden in the sp field. */ 574/* Types of improvements, hidden in the sp field. */
579#define IMPROVE_PREPARE 1 575#define IMPROVE_PREPARE 1
580#define IMPROVE_DAMAGE 2 576#define IMPROVE_DAMAGE 2
581#define IMPROVE_WEIGHT 3 577#define IMPROVE_WEIGHT 3
582#define IMPROVE_ENCHANT 4 578#define IMPROVE_ENCHANT 4
583#define IMPROVE_STR 5 579#define IMPROVE_STR 5
584#define IMPROVE_DEX 6 580#define IMPROVE_DEX 6
585#define IMPROVE_CON 7 581#define IMPROVE_CON 7
586#define IMPROVE_WIS 8 582#define IMPROVE_WIS 8
587#define IMPROVE_CHA 9 583#define IMPROVE_CHA 9
588#define IMPROVE_INT 10 584#define IMPROVE_INT 10
589#define IMPROVE_POW 11 585#define IMPROVE_POW 11
590
591 586
592/** 587/**
593 * This does the prepare weapon scroll. 588 * This does the prepare weapon scroll.
594 * Checks for sacrifice, and so on. 589 * Checks for sacrifice, and so on.
595 */ 590 */
596
597int 591int
598prepare_weapon (object *op, object *improver, object *weapon) 592prepare_weapon (object *op, object *improver, object *weapon)
599{ 593{
600 int sacrifice_count, i; 594 int sacrifice_count, i;
601 char buf[MAX_BUF]; 595 char buf[MAX_BUF];
602 596
603 if (weapon->level != 0) 597 if (weapon->level != 0)
604 { 598 {
605 new_draw_info (NDI_UNIQUE, 0, op, "Weapon already prepared."); 599 op->failmsg ("Weapon is already prepared!");
606 return 0; 600 return 0;
607 } 601 }
602
608 for (i = 0; i < NROFATTACKS; i++) 603 for (i = 0; i < NROFATTACKS; i++)
609 if (weapon->resist[i]) 604 if (weapon->resist[i])
610 break; 605 break;
611 606
612 /* If we break out, i will be less than nrofattacks, preventing 607 /* If we break out, i will be less than nrofattacks, preventing
… …
615 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */ 610 if (i < NROFATTACKS || weapon->stats.hp || /* regeneration */
616 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */ 611 (weapon->stats.sp && weapon->type == WEAPON) || /* sp regeneration */
617 weapon->stats.exp || /* speed */ 612 weapon->stats.exp || /* speed */
618 weapon->stats.ac) /* AC - only taifu's I think */ 613 weapon->stats.ac) /* AC - only taifu's I think */
619 { 614 {
620 new_draw_info (NDI_UNIQUE, 0, op, "Cannot prepare magic weapons."); 615 op->failmsg ("You cannot prepare magic weapons. "
616 "H<A weapon is considered magical if it changes regeneration, "
617 "speed or ac.>");
621 return 0; 618 return 0;
622 } 619 }
620
623 sacrifice_count = check_sacrifice (op, improver); 621 sacrifice_count = check_sacrifice (op, improver);
624 if (sacrifice_count <= 0) 622 if (sacrifice_count <= 0)
625 return 0; 623 return 0;
624
626 weapon->level = isqrt (sacrifice_count); 625 weapon->level = isqrt (sacrifice_count);
627 new_draw_info (NDI_UNIQUE, 0, op, "Your sacrifice was accepted.");
628 eat_item (op, improver->slaying, sacrifice_count); 626 eat_item (op, improver->slaying, sacrifice_count);
629 627
630 new_draw_info_format (NDI_UNIQUE, 0, op, "Your *%s may be improved %d times.", &weapon->name, weapon->level); 628 op->statusmsg (format (
629 "Your sacrifice was accepted."
630 "Your *%s may be improved %d times.",
631 &weapon->name, weapon->level
632 ));
631 633
632 sprintf (buf, "%s's %s", &op->name, &weapon->name); 634 sprintf (buf, "%s's %s", &op->name, &weapon->name);
633 weapon->name = weapon->name_pl = buf; 635 weapon->name = weapon->name_pl = buf;
634 weapon->nrof = 0; /* prevents preparing n weapons in the same 636 weapon->nrof = 0; /* prevents preparing n weapons in the same
635 slot at once! */ 637 slot at once! */
636 decrease_ob (improver); 638 improver->decrease ();
637 weapon->last_eat = 0; 639 weapon->last_eat = 0;
638 return 1; 640 return 1;
639} 641}
640
641 642
642/** 643/**
643 * Does the dirty job for 'improve weapon' scroll, prepare or add something. 644 * Does the dirty job for 'improve weapon' scroll, prepare or add something.
644 * This is the new improve weapon code. 645 * This is the new improve weapon code.
645 * Returns 0 if it was not able to work for some reason. 646 * Returns 0 if it was not able to work for some reason.
… …
654improve_weapon (object *op, object *improver, object *weapon) 655improve_weapon (object *op, object *improver, object *weapon)
655{ 656{
656 int sacrifice_count, sacrifice_needed = 0; 657 int sacrifice_count, sacrifice_needed = 0;
657 658
658 if (improver->stats.sp == IMPROVE_PREPARE) 659 if (improver->stats.sp == IMPROVE_PREPARE)
659 {
660 return prepare_weapon (op, improver, weapon); 660 return prepare_weapon (op, improver, weapon);
661 } 661
662 if (weapon->level == 0) 662 if (weapon->level == 0)
663 { 663 {
664 new_draw_info (NDI_UNIQUE, 0, op, "This weapon has not been prepared."); 664 op->failmsg ("This weapon has not been prepared. H<You first ahve to prepare a weapon with a prepare weapon scroll.>");
665 return 0; 665 return 0;
666 } 666 }
667
667 if (weapon->level == weapon->last_eat && weapon->item_power >= 100) 668 if (weapon->level == weapon->last_eat && weapon->item_power >= 100)
668 { 669 {
669 new_draw_info (NDI_UNIQUE, 0, op, "This weapon cannot be improved any more."); 670 op->failmsg ("This weapon cannot be improved any more.");
670 return 0; 671 return 0;
671 } 672 }
673
672 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1)) 674 if (QUERY_FLAG (weapon, FLAG_APPLIED) && !check_weapon_power (op, weapon->last_eat + 1))
673 { 675 {
674 new_draw_info (NDI_UNIQUE, 0, op, "Improving the weapon will make it too"); 676 op->failmsg ("Improving the weapon will make it too "
675 new_draw_info (NDI_UNIQUE, 0, op, "powerful for you to use. Unready it if you"); 677 "powerful for you to use. Unready it if you "
676 new_draw_info (NDI_UNIQUE, 0, op, "really want to improve it."); 678 "really want to improve it.");
677 return 0; 679 return 0;
678 } 680 }
681
679 /* This just increases damage by 5 points, no matter what. No sacrifice 682 /* This just increases damage by 5 points, no matter what. No sacrifice
680 * is needed. Since stats.dam is now a 16 bit value and not 8 bit, 683 * is needed. Since stats.dam is now a 16 bit value and not 8 bit,
681 * don't put any maximum value on damage - the limit is how much the 684 * don't put any maximum value on damage - the limit is how much the
682 * weapon can be improved. 685 * weapon can be improved.
683 */ 686 */
684 if (improver->stats.sp == IMPROVE_DAMAGE) 687 if (improver->stats.sp == IMPROVE_DAMAGE)
685 { 688 {
686 weapon->stats.dam += 5; 689 weapon->stats.dam += 5;
687 weapon->weight += 5000; /* 5 KG's */ 690 weapon->weight += 5000; /* 5 KG's */
688 new_draw_info_format (NDI_UNIQUE, 0, op, "Damage has been increased by 5 to %d", weapon->stats.dam); 691 op->statusmsg (format ("Damage has been increased by 5 to %d.", weapon->stats.dam));
689 weapon->last_eat++; 692 weapon->last_eat++;
690 693
691 weapon->item_power++; 694 weapon->item_power++;
692 decrease_ob (improver); 695 improver->decrease ();
693 return 1; 696 return 1;
694 } 697 }
698
695 if (improver->stats.sp == IMPROVE_WEIGHT) 699 if (improver->stats.sp == IMPROVE_WEIGHT)
696 { 700 {
697 /* Reduce weight by 20% */ 701 /* Reduce weight by 20% */
698 weapon->weight = (weapon->weight * 8) / 10; 702 weapon->weight = (weapon->weight * 8) / 10;
699 if (weapon->weight < 1) 703 if (weapon->weight < 1)
700 weapon->weight = 1; 704 weapon->weight = 1;
705
701 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon weight reduced to %6.1f kg", (float) weapon->weight / 1000.0); 706 op->statusmsg (format ("Weapon weight reduced to %6.1fkg.", (float) weapon->weight / 1000.0));
702 weapon->last_eat++; 707 weapon->last_eat++;
703 weapon->item_power++; 708 weapon->item_power++;
704 decrease_ob (improver); 709 improver->decrease ();
705 return 1; 710 return 1;
706 } 711 }
707 if (improver->stats.sp == IMPROVE_ENCHANT) 712 if (improver->stats.sp == IMPROVE_ENCHANT)
708 { 713 {
709 weapon->magic++; 714 weapon->magic++;
710 weapon->last_eat++; 715 weapon->last_eat++;
711 new_draw_info_format (NDI_UNIQUE, 0, op, "Weapon magic increased to %d", weapon->magic); 716 op->statusmsg (format ("Weapon magic increased to %d.", weapon->magic));
712 decrease_ob (improver); 717 improver->decrease ();
713 weapon->item_power++; 718 weapon->item_power++;
714 return 1; 719 return 1;
715 } 720 }
716 721
717 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex + 722 sacrifice_needed = weapon->stats.Str + weapon->stats.Int + weapon->stats.Dex +
… …
722 sacrifice_needed *= 2; 727 sacrifice_needed *= 2;
723 728
724 sacrifice_count = check_sacrifice (op, improver); 729 sacrifice_count = check_sacrifice (op, improver);
725 if (sacrifice_count < sacrifice_needed) 730 if (sacrifice_count < sacrifice_needed)
726 { 731 {
727 new_draw_info_format (NDI_UNIQUE, 0, op, "You need at least %d %s", sacrifice_needed, &improver->slaying); 732 op->failmsg (format ("You need at least %d %s.", sacrifice_needed, &improver->slaying));
728 return 0; 733 return 0;
729 } 734 }
735
730 eat_item (op, improver->slaying, sacrifice_needed); 736 eat_item (op, improver->slaying, sacrifice_needed);
731 weapon->item_power++; 737 weapon->item_power++;
732 738
733 switch (improver->stats.sp) 739 switch (improver->stats.sp)
734 { 740 {
735 case IMPROVE_STR:
736 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Str), 1, "strength"); 741 case IMPROVE_STR: return improve_weapon_stat (op, improver, weapon, weapon->stats.Str, 1, "strength");
737 case IMPROVE_DEX:
738 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Dex), 1, "dexterity"); 742 case IMPROVE_DEX: return improve_weapon_stat (op, improver, weapon, weapon->stats.Dex, 1, "dexterity");
739 case IMPROVE_CON:
740 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Con), 1, "constitution"); 743 case IMPROVE_CON: return improve_weapon_stat (op, improver, weapon, weapon->stats.Con, 1, "constitution");
741 case IMPROVE_WIS:
742 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Wis), 1, "wisdom"); 744 case IMPROVE_WIS: return improve_weapon_stat (op, improver, weapon, weapon->stats.Wis, 1, "wisdom");
743 case IMPROVE_CHA:
744 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Cha), 1, "charisma"); 745 case IMPROVE_CHA: return improve_weapon_stat (op, improver, weapon, weapon->stats.Cha, 1, "charisma");
745 case IMPROVE_INT:
746 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Int), 1, "intelligence"); 746 case IMPROVE_INT: return improve_weapon_stat (op, improver, weapon, weapon->stats.Int, 1, "intelligence");
747 case IMPROVE_POW:
748 return improve_weapon_stat (op, improver, weapon, (signed char *) &(weapon->stats.Pow), 1, "power"); 747 case IMPROVE_POW: return improve_weapon_stat (op, improver, weapon, weapon->stats.Pow, 1, "power");
749 default: 748 default:
750 new_draw_info (NDI_UNIQUE, 0, op, "Unknown improvement type."); 749 op->failmsg ("Unknown improvement type.");
751 } 750 }
751
752 LOG (llevError, "improve_weapon: Got to end of function\n"); 752 LOG (llevError, "improve_weapon: Got to end of function\n");
753 return 0; 753 return 0;
754} 754}
755 755
756/** 756/**
… …
763{ 763{
764 object *otmp; 764 object *otmp;
765 765
766 if (op->type != PLAYER) 766 if (op->type != PLAYER)
767 return 0; 767 return 0;
768
768 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 769 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC))
769 { 770 {
770 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 771 op->failmsg ("Something blocks the magic of the scroll!");
771 return 0; 772 return 0;
772 } 773 }
774
773 otmp = find_marked_object (op); 775 otmp = find_marked_object (op);
774 if (!otmp) 776 if (!otmp)
775 { 777 {
776 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark a weapon object."); 778 op->failmsg ("You need to mark a weapon object. H<Use the mark command or the mark option from the item popup menu.>");
777 return 0; 779 return 0;
778 } 780 }
781
779 if (otmp->type != WEAPON && otmp->type != BOW) 782 if (otmp->type != WEAPON && otmp->type != BOW)
780 { 783 {
781 new_draw_info (NDI_UNIQUE, 0, op, "Marked item is not a weapon or bow"); 784 op->failmsg ("Marked item is not a weapon or bow!");
782 return 0; 785 return 0;
783 } 786 }
784 new_draw_info (NDI_UNIQUE, 0, op, "Applied weapon builder."); 787
788 op->statusmsg ("Applied weapon builder.");
789
785 improve_weapon (op, tmp, otmp); 790 improve_weapon (op, tmp, otmp);
786 esrv_send_item (op, otmp); 791 esrv_send_item (op, otmp);
787 return 1; 792 return 1;
788} 793}
789 794
… …
814{ 819{
815 object *tmp; 820 object *tmp;
816 821
817 if (armour->magic >= settings.armor_max_enchant) 822 if (armour->magic >= settings.armor_max_enchant)
818 { 823 {
819 new_draw_info (NDI_UNIQUE, 0, op, "This armour can not be enchanted any further."); 824 op->failmsg ("This armour can not be enchanted any further!");
820 return 0; 825 return 0;
821 } 826 }
827
822 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight, 828 /* Dealing with random artifact armor is a lot trickier (in terms of value, weight,
823 * etc), so take the easy way out and don't worry about it. 829 * etc), so take the easy way out and don't worry about it.
824 * Note - maybe add scrolls which make the random artifact versions (eg, armour 830 * Note - maybe add scrolls which make the random artifact versions (eg, armour
825 * of gnarg and what not?) 831 * of gnarg and what not?)
826 */ 832 */
827 if (armour->title) 833 if (armour->title)
828 { 834 {
829 new_draw_info (NDI_UNIQUE, 0, op, "This armour will not accept further enchantment."); 835 op->failmsg ("This armour will not accept further enchantment.");
830 return 0; 836 return 0;
831 } 837 }
832 838
833 /* Split objects if needed. Can't insert tmp until the 839 /* Split objects if needed. Can't insert tmp until the
834 * end of this function - otherwise it will just re-merge. 840 * end of this function - otherwise it will just re-merge.
835 */ 841 */
836 if (armour->nrof > 1) 842 tmp = armour->nrof > 1 ? armour->split (armour->nrof - 1) : 0;
837 tmp = get_split_ob (armour, armour->nrof - 1);
838 else
839 tmp = NULL;
840 843
841 armour->magic++; 844 armour->magic++;
842 845
843 if (!settings.armor_speed_linear) 846 if (!settings.armor_speed_linear)
844 { 847 {
… …
849 { 852 {
850 base = base - (base * settings.armor_speed_improvement) / 100; 853 base = base - (base * settings.armor_speed_improvement) / 100;
851 pow++; 854 pow++;
852 } 855 }
853 856
854 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * base) / 100; 857 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * base) / 100;
855 } 858 }
856 else 859 else
857 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (&armour->arch->clone) * (100 + armour->magic * settings.armor_speed_improvement)) / 100; 860 ARMOUR_SPEED (armour) = (ARMOUR_SPEED (armour->arch) * (100 + armour->magic * settings.armor_speed_improvement)) / 100;
858 861
859 if (!settings.armor_weight_linear) 862 if (!settings.armor_weight_linear)
860 { 863 {
861 int base = 100; 864 int base = 100;
862 int pow = 0; 865 int pow = 0;
… …
865 { 868 {
866 base = base - (base * settings.armor_weight_reduction) / 100; 869 base = base - (base * settings.armor_weight_reduction) / 100;
867 pow++; 870 pow++;
868 } 871 }
869 872
870 armour->weight = (armour->arch->clone.weight * base) / 100; 873 armour->weight = (armour->arch->weight * base) / 100;
871 } 874 }
872 else 875 else
873 armour->weight = (armour->arch->clone.weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100; 876 armour->weight = (armour->arch->weight * (100 - armour->magic * settings.armor_weight_reduction)) / 100;
874 877
875 if (armour->weight <= 0) 878 if (armour->weight <= 0)
876 { 879 {
877 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n."); 880 LOG (llevInfo, "Warning: enchanted armours can have negative weight\n.");
878 armour->weight = 1; 881 armour->weight = 1;
879 } 882 }
880 883
881 armour->item_power = get_power_from_ench (armour->arch->clone.item_power + armour->magic); 884 armour->item_power = get_power_from_ench (armour->arch->item_power + armour->magic);
882 885
883 if (op->type == PLAYER) 886 if (op->type == PLAYER)
884 { 887 {
885 esrv_send_item (op, armour); 888 esrv_send_item (op, armour);
889
886 if (QUERY_FLAG (armour, FLAG_APPLIED)) 890 if (QUERY_FLAG (armour, FLAG_APPLIED))
887 op->update_stats (); 891 op->update_stats ();
888 } 892 }
889 decrease_ob (improver); 893
894 improver->decrease ();
895
890 if (tmp) 896 if (tmp)
891 { 897 op->insert (tmp);
892 insert_ob_in_ob (tmp, op); 898
893 esrv_send_item (op, tmp);
894 }
895 return 1; 899 return 1;
896} 900}
897
898 901
899/* 902/*
900 * convert_item() returns 1 if anything was converted, 0 if the item was not 903 * convert_item() returns 1 if anything was converted, 0 if the item was not
901 * what the converter wants, -1 if the converter is broken. 904 * what the converter wants, -1 if the converter is broken.
902 */ 905 *
903#define CONV_FROM(xyz) xyz->slaying
904#define CONV_TO(xyz) xyz->other_arch
905#define CONV_NR(xyz) xyz->stats.sp
906#define CONV_NEED(xyz) xyz->stats.food
907
908/* Takes one items and makes another. 906 * Takes one type of items and makes another.
909 * converter is the object that is doing the conversion. 907 * converter is the object that is doing the conversion.
910 * item is the object that triggered the converter - if it is not 908 * item is the object that triggered the converter - if it is not
911 * what the converter wants, this will not do anything. 909 * what the converter wants, this will not do anything.
912 */ 910 */
913int 911static int
914convert_item (object *item, object *converter) 912convert_item (object *item, object *converter)
915{ 913{
916 int nr = 0;
917 uint32 price_in; 914 sint64 nr, price_in;
915
916 if (item->flag [FLAG_UNPAID])
917 return 0;
918
919 shstr conv_from = converter->slaying;
920 archetype *conv_to = converter->other_arch;
921 sint64 need = converter->stats.food;
922 sint64 give = converter->stats.sp;
918 923
919 /* We make some assumptions - we assume if it takes money as it type, 924 /* We make some assumptions - we assume if it takes money as it type,
920 * it wants some amount. We don't make change (ie, if something costs 925 * it wants some amount. We don't make change (ie, if something costs
921 * 3 gp and player drops a platinum, tough luck) 926 * 3 gp and player drops a platinum, tough luck)
922 */ 927 */
923 if (!strcmp (CONV_FROM (converter), "money")) 928 if (conv_from == shstr_money)
924 { 929 {
925 int cost;
926
927 if (item->type != MONEY) 930 if (item->type != MONEY)
928 return 0; 931 return 0;
929 932
930 nr = (item->nrof * item->value) / CONV_NEED (converter); 933 nr = sint64 (item->nrof) * item->value / need;
931 if (!nr) 934 if (!nr)
932 return 0; 935 return 0;
933 cost = nr * CONV_NEED (converter) / item->value; 936
934 /* take into account rounding errors */ 937 converter->play_sound (sound_find ("shop_buy"));
935 if (nr * CONV_NEED (converter) % item->value) 938
936 cost++; 939 sint64 cost = (nr * need + item->value - 1) / item->value;
937 decrease_ob_nr (item, cost); 940
941 item->decrease (cost);
938 942
939 price_in = cost * item->value; 943 price_in = cost * item->value;
940 } 944 }
941 else 945 else
942 { 946 {
943 if (item->type == PLAYER || CONV_FROM (converter) != item->arch->name || 947 if (item->type == PLAYER
944 (CONV_NEED (converter) && CONV_NEED (converter) > (uint16) item->nrof)) 948 || conv_from != item->arch->archname
949 || (need && need > (uint16) item->nrof))
945 return 0; 950 return 0;
946 951
947 if (CONV_NEED (converter)) 952 converter->play_sound (sound_find ("convert_item"));
953
954 if (need)
948 { 955 {
949 nr = item->nrof / CONV_NEED (converter); 956 nr = sint64 (item->nrof) / need;
950 decrease_ob_nr (item, nr * CONV_NEED (converter)); 957 item->decrease (nr * need);
951 price_in = nr * CONV_NEED (converter) * item->value; 958 price_in = nr * need * item->value;
952 } 959 }
953 else 960 else
954 { 961 {
955 price_in = item->value; 962 price_in = item->value;
956 item->destroy (); 963 item->destroy ();
957 } 964 }
958 } 965 }
959 966
960 if (converter->inv != NULL) 967 if (converter->inv)
961 { 968 {
962 object *ob; 969 object *ob;
963 int i; 970 int i;
964 object *ob_to_copy; 971 object *ob_to_copy;
965 972
966 /* select random object from inventory to copy */ 973 /* select random object from inventory to copy */
967 ob_to_copy = converter->inv; 974 ob_to_copy = converter->inv;
968 for (ob = converter->inv->below, i = 1; ob != NULL; ob = ob->below, i++) 975 for (ob = converter->inv->below, i = 1; ob; ob = ob->below, i++)
969 {
970 if (rndm (0, i) == 0) 976 if (rndm (0, i) == 0)
971 {
972 ob_to_copy = ob; 977 ob_to_copy = ob;
973 } 978
974 }
975 item = object_create_clone (ob_to_copy); 979 item = object_create_clone (ob_to_copy);
976 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE); 980 CLEAR_FLAG (item, FLAG_IS_A_TEMPLATE);
977 unflag_inv (item, FLAG_IS_A_TEMPLATE); 981 unflag_inv (item, FLAG_IS_A_TEMPLATE);
978 } 982 }
979 else 983 else
980 { 984 {
981 if (converter->other_arch == NULL) 985 if (!conv_to)
982 { 986 {
983 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n", 987 LOG (llevError, "move_creator: Converter doesn't have other arch set: %s (%s, %d, %d)\n",
984 &converter->name, &converter->map->path, converter->x, converter->y); 988 &converter->name, &converter->map->path, converter->x, converter->y);
985 return -1; 989 return -1;
986 } 990 }
987 991
988 item = object_create_arch (converter->other_arch); 992 item = object_create_arch (conv_to);
989 fix_generated_item (item, converter, 0, 0, GT_MINIMAL); 993 fix_generated_item (item, converter, 0, 0, GT_MINIMAL);
990 } 994 }
991 995
992 if (CONV_NR (converter)) 996 if (give)
993 item->nrof = CONV_NR (converter); 997 item->nrof = give;
998
994 if (nr) 999 if (nr)
995 item->nrof *= nr; 1000 item->nrof *= nr;
1001
996 if (is_in_shop (converter)) 1002 if (is_in_shop (converter))
997 SET_FLAG (item, FLAG_UNPAID); 1003 SET_FLAG (item, FLAG_UNPAID);
998 else if (price_in < item->nrof * item->value) 1004 else if (price_in < sint64 (item->nrof) * item->value)
999 { 1005 {
1000 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n", 1006 LOG (llevDebug, "converter output price higher than input: %s at %s (%d, %d) in value %d, out value %d for %s\n",
1001 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name); 1007 &converter->name, &converter->map->path, converter->x, converter->y, price_in, item->nrof * item->value, &item->name);
1002
1003 /** 1008 /**
1004 * elmex: we are going to let the game continue, as the mapcreator 1009 * elmex: we are going to let the game continue, as the mapcreator
1005 * propably had something in mind when doing this 1010 * hopefully had something in mind when doing this.
1006 */ 1011 */
1007 } 1012 }
1013
1014 SET_FLAG (item, FLAG_IDENTIFIED);
1008 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y); 1015 insert_ob_in_map_at (item, converter->map, converter, 0, converter->x, converter->y);
1009 return 1; 1016 return 1;
1010} 1017}
1011 1018
1012/** 1019/**
1013 * Handle apply on containers. 1020 * Handle apply on containers.
1014 * By Eneq(@csd.uu.se). 1021 * By Eneq(@csd.uu.se).
1015 * Moved to own function and added many features [Tero.Haatanen@lut.fi] 1022 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1016 * added the alchemical cauldron to the code -b.t. 1023 * added the alchemical cauldron to the code -b.t.
1017 */ 1024 */
1018
1019int 1025int
1020apply_container (object *op, object *sack) 1026apply_container (object *op, object *sack)
1021{ 1027{
1022 char buf[MAX_BUF]; 1028 if (op->type != PLAYER || !op->contr->ns)
1023 object *tmp;
1024
1025 if (op->type != PLAYER)
1026 return 0; /* This might change */ 1029 return 0; /* This might change */
1027 1030
1028 if (sack == NULL || sack->type != CONTAINER) 1031 if (!sack || sack->type != CONTAINER)
1029 { 1032 {
1030 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]"); 1033 LOG (llevError, "apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1031 return 0; 1034 return 0;
1032 } 1035 }
1033 1036
1034 op->contr->last_used = 0; 1037 op->contr->last_used = 0;
1035 1038
1036 if (sack->env != op) 1039 if (sack->env && sack->env != op)
1040 {
1041 op->failmsg ("You must put it onto the floor or into your inventory first.");
1042 return 1;
1037 { 1043 }
1038 if (sack->other_arch == NULL || sack->env != NULL) 1044
1045 // already applied == open on ground, or open in inv, or active in inv
1046 if (sack->flag [FLAG_APPLIED])
1047 {
1048 if (op->container == sack)
1039 { 1049 {
1040 new_draw_info (NDI_UNIQUE, 0, op, "You must get it first."); 1050 // open on ground or inv, so close
1051 op->close_container ();
1041 return 1; 1052 return 1;
1042 } 1053 }
1043 1054 else if (!sack->env)
1044 /* It's on the ground, the problems begin */
1045 if (op->container != sack)
1046 {
1047 /* it's closed OR some player has opened it */
1048 if (QUERY_FLAG (sack, FLAG_APPLIED))
1049 {
1050 for (tmp = GET_MAP_OB (sack->map, sack->x, sack->y); tmp && tmp->container != sack; tmp = tmp->above);
1051 if (tmp)
1052 {
1053 /* some other player have opened it */
1054 new_draw_info_format (NDI_UNIQUE, 0, op, "%s is already occupied.", query_name (sack));
1055 return 1;
1056 }
1057 }
1058 } 1055 {
1059 if (QUERY_FLAG (sack, FLAG_APPLIED)) 1056 // active, but not ours: some other player has opened it
1057 op->failmsg (format ("Somebody else is using the %s already.", query_name (sack)));
1058 return 1;
1060 { 1059 }
1061 if (op->container == NULL)
1062 {
1063 tmp = arch_to_object (sack->other_arch);
1064 /* not good, but insert_ob_in_ob() is too smart */
1065 CLEAR_FLAG (tmp, FLAG_REMOVED);
1066 tmp->x = tmp->y = 0;
1067 tmp->map = NULL;
1068 tmp->env = sack;
1069 if (sack->inv)
1070 sack->inv->above = tmp;
1071 tmp->below = sack->inv;
1072 tmp->above = NULL;
1073 sack->inv = tmp;
1074 sack->move_off = MOVE_ALL; /* trying force closing it */
1075 }
1076 else
1077 {
1078 sack->move_off = 0;
1079 tmp = sack->inv;
1080 1060
1081 if (tmp && tmp->type == CLOSE_CON) 1061 // fall through to opening it (active in inv)
1082 tmp->destroy ();
1083 }
1084 }
1085 }
1086
1087 if (QUERY_FLAG (sack, FLAG_APPLIED))
1088 { 1062 }
1063 else if (sack->env)
1064 {
1065 // it is in our env, so activate it, do not open yet
1089 if (op->container) 1066 op->close_container ();
1090 { 1067 sack->flag [FLAG_APPLIED] = 1;
1091 if (op->container != sack) 1068 esrv_update_item (UPD_FLAGS, op, sack);
1092 { 1069 op->statusmsg (format ("You ready %s.", query_name (sack)));
1093 tmp = op->container; 1070 return 1;
1094 apply_container (op, tmp); 1071 }
1095 sprintf (buf, "You close %s and open ", query_name (tmp)); 1072
1096 op->container = sack; 1073 // it's locked?
1097 strcat (buf, query_name (sack)); 1074 if (sack->slaying)
1098 strcat (buf, "."); 1075 {
1099 } 1076 if (object *tmp = find_key (op, op, sack))
1100 else 1077 op->statusmsg (format ("You unlock %s with %s.", query_name (sack), query_name (tmp)));
1101 {
1102 CLEAR_FLAG (sack, FLAG_APPLIED);
1103 op->container = NULL;
1104 sprintf (buf, "You close %s.", query_name (sack));
1105 }
1106 }
1107 else 1078 else
1108 { 1079 {
1109 CLEAR_FLAG (sack, FLAG_APPLIED);
1110 sprintf (buf, "You open %s.", query_name (sack));
1111 SET_FLAG (sack, FLAG_APPLIED);
1112 op->container = sack;
1113 }
1114 }
1115 else
1116 { /* not applied */
1117 if (sack->slaying)
1118 { /* it's locked */
1119 tmp = find_key (op, op, sack);
1120 if (tmp)
1121 {
1122 sprintf (buf, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1123 SET_FLAG (sack, FLAG_APPLIED);
1124
1125 if (sack->env == NULL)
1126 { /* if it's on ground,open it also */
1127 new_draw_info (NDI_UNIQUE, 0, op, buf);
1128 apply_container (op, sack);
1129 return 1;
1130 }
1131 }
1132 else
1133 sprintf (buf, "You don't have the key to unlock %s.", query_name (sack)); 1080 op->statusmsg (format ("You don't have the key to unlock %s.", query_name (sack)));
1134 }
1135 else
1136 {
1137 sprintf (buf, "You readied %s.", query_name (sack));
1138 SET_FLAG (sack, FLAG_APPLIED);
1139
1140 if (sack->env == NULL)
1141 { /* if it's on ground,open it also */
1142 new_draw_info (NDI_UNIQUE, 0, op, buf);
1143 apply_container (op, sack);
1144 return 1; 1081 return 1;
1145 } 1082 }
1146 }
1147 } 1083 }
1148 1084
1149 new_draw_info (NDI_UNIQUE, 0, op, buf); 1085 op->open_container (sack);
1150
1151 if (op->contr)
1152 op->contr->ns->floorbox_update ();
1153 1086
1154 return 1; 1087 return 1;
1155} 1088}
1156
1157/**
1158 * Eneq(@csd.uu.se): Handle apply on containers. This is for containers
1159 * the player has in their inventory, eg, sacks, luggages, etc.
1160 *
1161 * Moved to own function and added many features [Tero.Haatanen@lut.fi]
1162 * This version is for client/server mode.
1163 * op is the player, sack is the container the player is opening or closing.
1164 * return 1 if an object is apllied somehow or another, 0 if error/no apply
1165 *
1166 * Reminder - there are three states for any container - closed (non applied),
1167 * applied (not open, but objects that match get tossed into it), and open
1168 * (applied flag set, and op->container points to the open container)
1169 */
1170
1171int
1172esrv_apply_container (object *op, object *sack)
1173{
1174 object *tmp = op->container;
1175
1176 if (op->type != PLAYER)
1177 return 0; /* This might change */
1178
1179 if (sack == NULL || sack->type != CONTAINER)
1180 {
1181 LOG (llevError, "esrv_apply_container: %s is not container!\n", sack ? &sack->name : "[nullobject]");
1182 return 0;
1183 }
1184
1185 /* If we have a currently open container, then it needs to be closed in all cases
1186 * if we are opening this one up. We then fall through if appropriate for
1187 * openening the new container.
1188 */
1189
1190 if (op->container && QUERY_FLAG (sack, FLAG_APPLIED))
1191 {
1192 if (op->container->env != op)
1193 { /* if container is on the ground */
1194 op->container->move_off = 0;
1195 }
1196
1197 if (INVOKE_OBJECT (CLOSE, tmp, ARG_OBJECT (op)))
1198 return 1;
1199
1200 new_draw_info_format (NDI_UNIQUE, 0, op, "You close %s.", query_name (op->container));
1201 CLEAR_FLAG (op->container, FLAG_APPLIED);
1202 op->container = NULL;
1203 esrv_update_item (UPD_FLAGS, op, tmp);
1204 if (tmp == sack)
1205 return 1;
1206 }
1207
1208
1209 /* If the player is trying to open it (which he must be doing if we got here),
1210 * and it is locked, check to see if player has the equipment to open it.
1211 */
1212
1213 if (sack->slaying)
1214 { /* it's locked */
1215 tmp = find_key (op, op, sack);
1216 if (tmp)
1217 {
1218 new_draw_info_format (NDI_UNIQUE, 0, op, "You unlock %s with %s.", query_name (sack), query_name (tmp));
1219 }
1220 else
1221 {
1222 new_draw_info_format (NDI_UNIQUE, 0, op, "You don't have the key to unlock %s.", query_name (sack));
1223 return 0;
1224 }
1225 }
1226
1227 /* By the time we get here, we have made sure any other container has been closed and
1228 * if this is a locked container, the player they key to open it.
1229 */
1230
1231 /* There are really two cases - the sack is either on the ground, or the sack is
1232 * part of the players inventory. If on the ground, we assume that the player is
1233 * opening it, since if it was being closed, that would have been taken care of above.
1234 */
1235
1236
1237 if (sack->env != op)
1238 {
1239 /* Hypothetical case - the player is trying to open a sack that belong to someone
1240 * else. This normally should not happen, but a misbehaving client/player could
1241 * try to do it, so lets handle it gracefully.
1242 */
1243 if (sack->env)
1244 {
1245 new_draw_info_format (NDI_UNIQUE, 0, op, "You can't open %s", query_name (sack));
1246 return 0;
1247 }
1248 /* set these so when the player walks off, we can unapply the sack */
1249 sack->move_off = MOVE_ALL; /* trying force closing it */
1250
1251 CLEAR_FLAG (sack, FLAG_APPLIED);
1252 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1253 SET_FLAG (sack, FLAG_APPLIED);
1254 op->container = sack;
1255 esrv_update_item (UPD_FLAGS, op, sack);
1256 esrv_send_inventory (op, sack);
1257
1258 }
1259 else
1260 { /* sack is in players inventory */
1261 if (QUERY_FLAG (sack, FLAG_APPLIED))
1262 { /* readied sack becoming open */
1263 CLEAR_FLAG (sack, FLAG_APPLIED);
1264 new_draw_info_format (NDI_UNIQUE, 0, op, "You open %s.", query_name (sack));
1265 SET_FLAG (sack, FLAG_APPLIED);
1266 op->container = sack;
1267 esrv_update_item (UPD_FLAGS, op, sack);
1268 esrv_send_inventory (op, sack);
1269 }
1270 else
1271 {
1272 CLEAR_FLAG (sack, FLAG_APPLIED);
1273 new_draw_info_format (NDI_UNIQUE, 0, op, "You readied %s.", query_name (sack));
1274 SET_FLAG (sack, FLAG_APPLIED);
1275 esrv_update_item (UPD_FLAGS, op, sack);
1276 }
1277 }
1278 return 1;
1279}
1280
1281 1089
1282/** 1090/**
1283 * Handles dropping things on altar. 1091 * Handles dropping things on altar.
1284 * Returns true if sacrifice was accepted. 1092 * Returns true if sacrifice was accepted.
1285 */ 1093 */
… …
1296 * with an altar. We call it a Potion - altars are stationary - it 1104 * with an altar. We call it a Potion - altars are stationary - it
1297 * is up to map designers to use them properly. 1105 * is up to map designers to use them properly.
1298 */ 1106 */
1299 if (altar->inv && altar->inv->type == SPELL) 1107 if (altar->inv && altar->inv->type == SPELL)
1300 { 1108 {
1301 new_draw_info_format (NDI_BLACK, 0, originator, "The altar casts %s.", &altar->inv->name); 1109 originator->statusmsg (format ("The altar casts %s.", &altar->inv->name));
1302 cast_spell (originator, altar, 0, altar->inv, NULL); 1110 cast_spell (originator, altar, 0, altar->inv, NULL);
1303 /* If it is connected, push the button. Fixes some problems with 1111 /* If it is connected, push the button. Fixes some problems with
1304 * old maps. 1112 * old maps.
1305 */ 1113 */
1306 1114
1307/* push_button (altar);*/ 1115/* push_button (altar);*/
1308 } 1116 }
… …
1332 double opinion; 1140 double opinion;
1333 object *tmp, *next; 1141 object *tmp, *next;
1334 1142
1335 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */ 1143 SET_FLAG (op, FLAG_NO_APPLY); /* prevent loops */
1336 1144
1145 bool has_unpaid = false;
1146
1147 // quite inefficient to do this here twice, but the api doesn'T lend itself to
1148 // a quick and small change :(
1149 for (object::depth_iterator item = op->begin (); item != op->end (); ++item)
1150 if (item->flag [FLAG_UNPAID])
1151 {
1152 has_unpaid = true;
1153 break;
1154 }
1155
1337 if (op->type != PLAYER) 1156 if (op->type != PLAYER)
1338 { 1157 {
1339 /* Remove all the unpaid objects that may be carried here. 1158 /* Remove all the unpaid objects that may be carried here.
1340 * This could be pets or monsters that are somehow in 1159 * This could be pets or monsters that are somehow in
1341 * the shop. 1160 * the shop.
… …
1367 /* unpaid objects, or non living objects, can't transfer by 1186 /* unpaid objects, or non living objects, can't transfer by
1368 * shop mats. Instead, put it on a nearby space. 1187 * shop mats. Instead, put it on a nearby space.
1369 */ 1188 */
1370 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE)) 1189 if (QUERY_FLAG (op, FLAG_UNPAID) || !QUERY_FLAG (op, FLAG_ALIVE))
1371 { 1190 {
1372
1373 /* Somebody dropped an unpaid item, just move to an adjacent place. */ 1191 /* Somebody dropped an unpaid item, just move to an adjacent place. */
1374 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1192 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1375 1193
1376 if (i != -1) 1194 if (i != -1)
1377 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat); 1195 rv = transfer_ob (op, op->x + freearr_x[i], op->y + freearr_y[i], 0, shop_mat);
… …
1386 else if (can_pay (op) && get_payment (op)) 1204 else if (can_pay (op) && get_payment (op))
1387 { 1205 {
1388 /* this is only used for players */ 1206 /* this is only used for players */
1389 rv = teleport (shop_mat, SHOP_MAT, op); 1207 rv = teleport (shop_mat, SHOP_MAT, op);
1390 1208
1209 if (has_unpaid)
1210 op->contr->play_sound (sound_find ("shop_buy"));
1211 else if (is_in_shop (op))
1212 op->contr->play_sound (sound_find ("shop_enter"));
1213 else
1214 op->contr->play_sound (sound_find ("shop_leave"));
1215
1391 if (shop_mat->msg) 1216 if (shop_mat->msg)
1392 new_draw_info (NDI_UNIQUE, 0, op, shop_mat->msg); 1217 op->statusmsg (shop_mat->msg);
1393 /* This check below is a bit simplistic - generally it should be correct, 1218 /* This check below is a bit simplistic - generally it should be correct,
1394 * but there is never a guarantee that the bottom space on the map is 1219 * but there is never a guarantee that the bottom space on the map is
1395 * actually the shop floor. 1220 * actually the shop floor.
1396 */ 1221 */
1397 else if (!rv && !is_in_shop (op)) 1222 else if (!rv && !is_in_shop (op))
1398 { 1223 {
1399 opinion = shopkeeper_approval (op->map, op); 1224 opinion = shopkeeper_approval (op->map, op);
1400 1225
1401 if (opinion > 0.9) 1226 op->statusmsg (
1402 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper gives you a friendly wave."); 1227 opinion >= 0.90 ? "The shopkeeper gives you a friendly wave."
1403 else if (opinion > 0.75) 1228 : opinion >= 0.75 ? "The shopkeeper waves to you."
1404 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper waves to you."); 1229 : opinion >= 0.50 ? "The shopkeeper ignores you."
1405 else if (opinion > 0.5) 1230 : "The shopkeeper glares at you with contempt."
1406 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper ignores you.");
1407 else 1231 );
1408 new_draw_info (NDI_UNIQUE, 0, op, "The shopkeeper glares at you with contempt.");
1409 } 1232 }
1410 } 1233 }
1411 else 1234 else
1412 { 1235 {
1413 /* if we get here, a player tried to leave a shop but was not able 1236 /* if we get here, a player tried to leave a shop but was not able
1414 * to afford the items he has. We try to move the player so that 1237 * to afford the items he has. We try to move the player so that
1415 * they are not on the mat anymore 1238 * they are not on the mat anymore
1416 */ 1239 */
1417 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9); 1240 int i = find_free_spot (op, op->map, op->x, op->y, 1, 9);
1418 1241
1419 if (i == -1) 1242 if (i == -1)
1420 {
1421 LOG (llevError, "Internal shop-mat problem.\n"); 1243 LOG (llevError, "Internal shop-mat problem.\n");
1422 }
1423 else 1244 else
1424 { 1245 {
1425 op->remove (); 1246 op->remove ();
1426 op->x += freearr_x[i]; 1247 op->x += freearr_x[i];
1427 op->y += freearr_y[i]; 1248 op->y += freearr_y[i];
… …
1438 */ 1259 */
1439static void 1260static void
1440apply_sign (object *op, object *sign, int autoapply) 1261apply_sign (object *op, object *sign, int autoapply)
1441{ 1262{
1442 readable_message_type *msgType; 1263 readable_message_type *msgType;
1443 char newbuf[HUGE_BUF];
1444 1264
1445 if (sign->msg == NULL) 1265 if (!sign->msg)
1446 { 1266 {
1447 new_draw_info (NDI_UNIQUE, 0, op, "Nothing is written on it."); 1267 op->statusmsg ("Nothing is written on it.");
1448 return; 1268 return;
1449 } 1269 }
1450 1270
1451 if (sign->stats.food) 1271 if (sign->stats.food)
1452 { 1272 {
1453 if (sign->last_eat >= sign->stats.food) 1273 if (sign->last_eat >= sign->stats.food)
1454 { 1274 {
1455 if (!sign->move_on) 1275 if (!sign->move_on)
1456 new_draw_info (NDI_UNIQUE, 0, op, "You cannot read it anymore."); 1276 op->statusmsg ("You cannot read it anymore.");
1277
1457 return; 1278 return;
1458 } 1279 }
1459 1280
1460 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1281 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1461 sign->last_eat++; 1282 sign->last_eat++;
… …
1466 * move_on is zero, it needs to be manually applied (doesn't talk 1287 * move_on is zero, it needs to be manually applied (doesn't talk
1467 * to us). 1288 * to us).
1468 */ 1289 */
1469 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on) 1290 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ) && !sign->move_on)
1470 { 1291 {
1471 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1292 op->failmsg ("You are unable to read while blind!");
1472 return; 1293 return;
1473 } 1294 }
1295
1296 if (op->contr)
1297 if (client *ns = op->contr->ns)
1298 {
1299 if (sign->sound)
1300 ns->play_sound (sign->sound);
1301 else if (autoapply)
1302 ns->play_sound (sound_find ("msg_voice"));
1303
1304 if (ns->can_msg)
1305 op->contr->infobox (MSG_CHANNEL ("examine"), format ("T<%s>\n\n\n\n%s", &sign->name, &sign->msg));
1306 else
1307 {
1474 msgType = get_readable_message_type (sign); 1308 msgType = get_readable_message_type (sign);
1475 snprintf (newbuf, sizeof (newbuf), "%hhu %s", autoapply ? 1 : 0, &sign->msg); 1309 const char *somemsg = format ("%u %s", autoapply ? 1 : 0, &sign->msg);
1476 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, newbuf, &sign->msg); 1310 draw_ext_info (NDI_UNIQUE | NDI_NAVY, 0, op, msgType->message_type, msgType->message_subtype, somemsg, &sign->msg);
1311 }
1312 }
1477} 1313}
1478 1314
1479/** 1315/**
1480 * 'victim' moves onto 'trap' 1316 * 'victim' moves onto 'trap'
1481 * 'victim' leaves 'trap' 1317 * 'victim' leaves 'trap'
… …
1504 * proper. This code was causing needless crashes. 1340 * proper. This code was causing needless crashes.
1505 */ 1341 */
1506 if (recursion_depth >= 500) 1342 if (recursion_depth >= 500)
1507 { 1343 {
1508 LOG (llevDebug, "WARNING: move_apply(): aborting recursion " 1344 LOG (llevDebug, "WARNING: move_apply(): aborting recursion "
1509 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->name, &trap->name, &victim->arch->name, &victim->name); 1345 "[trap arch %s, name %s; victim arch %s, name %s]\n", &trap->arch->archname, &trap->name, &victim->arch->archname, &victim->name);
1510 return; 1346 return;
1511 } 1347 }
1348
1512 recursion_depth++; 1349 recursion_depth++;
1513 if (trap->head) 1350 if (trap->head)
1514 trap = trap->head; 1351 trap = trap->head;
1515 1352
1516 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator))) 1353 if (INVOKE_OBJECT (MOVE_TRIGGER, trap, ARG_OBJECT (victim), ARG_OBJECT (originator)))
… …
1531 1368
1532 /* Just put in some sanity check. I think there is a bug in the 1369 /* Just put in some sanity check. I think there is a bug in the
1533 * above with some objects have zero speed, and thus the player 1370 * above with some objects have zero speed, and thus the player
1534 * getting permanently paralyzed. 1371 * getting permanently paralyzed.
1535 */ 1372 */
1536 if (victim->speed_left < -50.0) 1373 if (victim->speed_left < -50.f)
1537 victim->speed_left = -50.0; 1374 victim->speed_left = -50.f;
1538 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */ 1375 /* LOG(llevDebug, "apply, playermove, player speed_left=%f\n", victim->speed_left); */
1539 } 1376 }
1540 goto leave; 1377 goto leave;
1541 1378
1542 case SPINNER: 1379 case SPINNER:
… …
1592 1429
1593 if (!trap->value) 1430 if (!trap->value)
1594 { 1431 {
1595 int tot; 1432 int tot;
1596 1433
1597 for (ab = trap->above, tot = 0; ab != NULL; ab = ab->above) 1434 for (ab = trap->above, tot = 0; ab; ab = ab->above)
1598 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1435 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1599 tot += (ab->nrof ? ab->nrof : 1) * ab->weight + ab->carrying; 1436 tot += ab->head_ ()->total_weight ();
1600 1437
1601 if (!(trap->value = (tot > trap->weight) ? 1 : 0)) 1438 if (!(trap->value = (tot > trap->weight) ? 1 : 0))
1602 goto leave; 1439 goto leave;
1603 1440
1604 SET_ANIMATION (trap, trap->value); 1441 SET_ANIMATION (trap, trap->value);
… …
1614 1451
1615 if ((ab->move_type && trap->move_on) || ab->move_type == 0) 1452 if ((ab->move_type && trap->move_on) || ab->move_type == 0)
1616 { 1453 {
1617 if (!sound_was_played) 1454 if (!sound_was_played)
1618 { 1455 {
1619 play_sound_map (trap->map, trap->x, trap->y, SOUND_FALL_HOLE); 1456 trap->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1620 sound_was_played = 1; 1457 sound_was_played = 1;
1621 } 1458 }
1622 new_draw_info (NDI_UNIQUE, 0, ab, "You fall into a trapdoor!"); 1459
1460 ab->statusmsg ("You fall into a trapdoor!", NDI_RED);
1623 transfer_ob (ab, (int) EXIT_X (trap), (int) EXIT_Y (trap), 0, ab); 1461 transfer_ob (ab, EXIT_X (trap), EXIT_Y (trap), 0, ab);
1624 } 1462 }
1625 } 1463 }
1626 goto leave; 1464 goto leave;
1627 } 1465 }
1628 1466
1629
1630 case CONVERTER: 1467 case CONVERTER:
1631 if (convert_item (victim, trap) < 0) 1468 if (convert_item (victim, trap) < 0)
1632 { 1469 {
1633 object *op; 1470 originator->failmsg (format ("The %s seems to be broken!", query_name (trap)));
1634 1471 get_archetype ("burnout")->insert_at (trap, trap);
1635 new_draw_info_format (NDI_UNIQUE, 0, originator, "The %s seems to be broken!", query_name (trap));
1636
1637 op = get_archetype ("burnout");
1638 if (op != NULL)
1639 {
1640 op->x = trap->x;
1641 op->y = trap->y;
1642 insert_ob_in_map (op, trap->map, trap, 0);
1643 }
1644 } 1472 }
1473
1645 goto leave; 1474 goto leave;
1646 1475
1647 case TRIGGER_BUTTON: 1476 case TRIGGER_BUTTON:
1648 case TRIGGER_PEDESTAL: 1477 case TRIGGER_PEDESTAL:
1649 case TRIGGER_ALTAR: 1478 case TRIGGER_ALTAR:
… …
1667 * Processing will happen if the head runs into the pit 1496 * Processing will happen if the head runs into the pit
1668 */ 1497 */
1669 if (victim->head) 1498 if (victim->head)
1670 goto leave; 1499 goto leave;
1671 1500
1672 play_sound_map (victim->map, victim->x, victim->y, SOUND_FALL_HOLE); 1501 victim->play_sound (trap->sound ? trap->sound : sound_find ("fall_hole"));
1673 new_draw_info (NDI_UNIQUE, 0, victim, "You fall through the hole!\n"); 1502 victim->statusmsg ("You fall through the hole!", NDI_RED);
1674 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim); 1503 transfer_ob (victim, EXIT_X (trap), EXIT_Y (trap), 1, victim);
1675 goto leave; 1504 goto leave;
1676 1505
1677 case EXIT: 1506 case EXIT:
1678 if (victim->type == PLAYER && EXIT_PATH (trap)) 1507 if (victim->type == PLAYER && EXIT_PATH (trap))
1679 { 1508 {
1680 /* Basically, don't show exits leading to random maps the 1509 /* Basically, don't show exits leading to random maps the
1681 * players output. 1510 * players output.
1682 */ 1511 */
1683 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2)) 1512 if (trap->msg && strncmp (EXIT_PATH (trap), "/!", 2))
1684 new_draw_info (NDI_NAVY, 0, victim, trap->msg); 1513 victim->statusmsg (trap->msg, NDI_NAVY);
1685 1514
1515 trap->play_sound (trap->sound);
1686 victim->enter_exit (trap); 1516 victim->enter_exit (trap);
1687 } 1517 }
1688 goto leave; 1518 goto leave;
1689 1519
1690 case ENCOUNTER: 1520 case ENCOUNTER:
… …
1706 1536
1707 apply_sign (victim, trap, 1); 1537 apply_sign (victim, trap, 1);
1708 goto leave; 1538 goto leave;
1709 1539
1710 case CONTAINER: 1540 case CONTAINER:
1711 if (victim->type == PLAYER)
1712 (void) esrv_apply_container (victim, trap);
1713 else
1714 (void) apply_container (victim, trap); 1541 apply_container (victim, trap);
1715 goto leave; 1542 goto leave;
1716 1543
1717 case RUNE: 1544 case RUNE:
1718 case TRAP: 1545 case TRAP:
1719 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE)) 1546 if (trap->level && QUERY_FLAG (victim, FLAG_ALIVE))
1720 {
1721 spring_trap (trap, victim); 1547 spring_trap (trap, victim);
1722 }
1723 goto leave; 1548 goto leave;
1724 1549
1725 default: 1550 default:
1726 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not " 1551 LOG (llevDebug, "name %s, arch %s, type %d with fly/walk on/off not "
1727 "handled in move_apply()\n", &trap->name, &trap->arch->name, trap->type); 1552 "handled in move_apply()\n", &trap->name, &trap->arch->archname, trap->type);
1728 goto leave; 1553 goto leave;
1729 } 1554 }
1730 1555
1731leave: 1556leave:
1732 recursion_depth--; 1557 recursion_depth--;
… …
1741 int lev_diff; 1566 int lev_diff;
1742 object *skill_ob; 1567 object *skill_ob;
1743 1568
1744 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1569 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1745 { 1570 {
1746 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1571 op->failmsg ("You are unable to read while blind!");
1747 return; 1572 return;
1748 } 1573 }
1574
1749 if (tmp->msg == NULL) 1575 if (!tmp->msg)
1750 { 1576 {
1751 new_draw_info_format (NDI_UNIQUE, 0, op, "You open the %s and find it empty.", &tmp->name); 1577 op->failmsg (format ("You open the %s and find it empty.", &tmp->name));
1752 return; 1578 return;
1753 } 1579 }
1754 1580
1755 /* need a literacy skill to read stuff! */ 1581 /* need a literacy skill to read stuff! */
1756 skill_ob = find_skill_by_name (op, tmp->skill); 1582 skill_ob = find_skill_by_name (op, tmp->skill);
1757 if (!skill_ob) 1583 if (!skill_ob)
1758 { 1584 {
1759 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1585 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill to read this.>", &tmp->skill));
1760 return; 1586 return;
1761 } 1587 }
1588
1762 lev_diff = tmp->level - (skill_ob->level + 5); 1589 lev_diff = tmp->level - (skill_ob->level + 5);
1763 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0) 1590 if (!QUERY_FLAG (op, FLAG_WIZ) && lev_diff > 0)
1764 { 1591 {
1765 if (lev_diff < 2) 1592 op->failmsg (lev_diff < 2 ? "This book is just barely beyond your comprehension."
1766 new_draw_info (NDI_UNIQUE, 0, op, "This book is just barely beyond your comprehension."); 1593 : lev_diff < 3 ? "This book is slightly beyond your comprehension."
1767 else if (lev_diff < 3) 1594 : lev_diff < 5 ? "This book is beyond your comprehension."
1768 new_draw_info (NDI_UNIQUE, 0, op, "This book is slightly beyond your comprehension."); 1595 : lev_diff < 8 ? "This book is quite a bit beyond your comprehension."
1769 else if (lev_diff < 5) 1596 : lev_diff < 15 ? "This book is way beyond your comprehension."
1770 new_draw_info (NDI_UNIQUE, 0, op, "This book is beyond your comprehension."); 1597 : "This book is totally beyond your comprehension.");
1771 else if (lev_diff < 8) 1598 return;
1772 new_draw_info (NDI_UNIQUE, 0, op, "This book is quite a bit beyond your comprehension."); 1599 }
1773 else if (lev_diff < 15) 1600
1774 new_draw_info (NDI_UNIQUE, 0, op, "This book is way beyond your comprehension."); 1601 readable_message_type *msgType = get_readable_message_type (tmp);
1602
1603 if (player *pl = op->contr)
1604 if (client *ns = pl->ns)
1605 if (ns->can_msg)
1606 pl->infobox (MSG_CHANNEL ("book"), format ("T<%s>\n\n\n\n%s", (char *)long_desc (tmp, op), &tmp->msg));
1775 else 1607 else
1776 new_draw_info (NDI_UNIQUE, 0, op, "This book is totally beyond your comprehension.");
1777 return;
1778 }
1779
1780 readable_message_type *msgType = get_readable_message_type (tmp);
1781
1782 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, 1608 draw_ext_info_format (NDI_UNIQUE | NDI_NAVY, 0, op,
1783 msgType->message_type, msgType->message_subtype, 1609 msgType->message_type, msgType->message_subtype,
1784 "You open the %s and start reading.\n%s", "%s\n%s", long_desc (tmp, op), &tmp->msg); 1610 "You open the %s and start reading.\n%s", (char *)"%s\n%s",
1611 long_desc (tmp, op), &tmp->msg);
1785 1612
1786 /* gain xp from reading */ 1613 /* gain xp from reading */
1787 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT)) 1614 if (!QUERY_FLAG (tmp, FLAG_NO_SKILL_IDENT))
1788 { /* only if not read before */ 1615 { /* only if not read before */
1789 int exp_gain = calc_skill_exp (op, tmp, skill_ob); 1616 int exp_gain = calc_skill_exp (op, tmp, skill_ob);
… …
1791 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1618 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1792 { 1619 {
1793 /*exp_gain *= 2; because they just identified it too */ 1620 /*exp_gain *= 2; because they just identified it too */
1794 SET_FLAG (tmp, FLAG_IDENTIFIED); 1621 SET_FLAG (tmp, FLAG_IDENTIFIED);
1795 1622
1796 /* If in a container, update how it looks */ 1623 if (object *pl = tmp->visible_to ())
1797 if (tmp->env)
1798 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp); 1624 esrv_update_item (UPD_FLAGS | UPD_NAME, pl, tmp);
1799 else
1800 op->contr->ns->floorbox_update ();
1801 } 1625 }
1802 1626
1803 change_exp (op, exp_gain, skill_ob->skill, 0); 1627 change_exp (op, exp_gain, skill_ob->skill, 0);
1804 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */ 1628 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); /* so no more xp gained from this book */
1805 } 1629 }
… …
1810 * op is the person learning the skill, tmp is the skill scroll object 1634 * op is the person learning the skill, tmp is the skill scroll object
1811 */ 1635 */
1812static void 1636static void
1813apply_skillscroll (object *op, object *tmp) 1637apply_skillscroll (object *op, object *tmp)
1814{ 1638{
1815 switch ((int) learn_skill (op, tmp)) 1639 switch (learn_skill (op, tmp))
1816 { 1640 {
1817 case 0: 1641 case 0:
1818 new_draw_info (NDI_UNIQUE, 0, op, "You already possess the knowledge "); 1642 op->play_sound (sound_find ("generic_fail"));
1819 new_draw_info_format (NDI_UNIQUE, 0, op, "held within the %s.\n", query_name (tmp)); 1643 op->failmsg (format ("You already possess the knowledge held within the %s.", query_name (tmp)));
1820 return; 1644 break;
1821 1645
1822 case 1: 1646 case 1:
1823 new_draw_info_format (NDI_UNIQUE, 0, op, "You succeed in learning %s", &tmp->skill);
1824 decrease_ob (tmp); 1647 tmp->decrease ();
1648 op->play_sound (sound_find ("skill_learn"));
1649 op->statusmsg (format ("You succeed in learning %s", &tmp->skill));
1825 return; 1650 break;
1826 1651
1827 default: 1652 default:
1653 tmp->decrease ();
1654 op->play_sound (sound_find ("generic_fail"));
1828 new_draw_info_format (NDI_UNIQUE, 0, op, "You fail to learn the knowledge of the %s.\n", query_name (tmp)); 1655 op->failmsg (format ("You fail to learn the knowledge of the %s.\n", query_name (tmp)));
1829 decrease_ob (tmp);
1830 return; 1656 break;
1831 } 1657 }
1832} 1658}
1833 1659
1834/** 1660/**
1835 * Actually makes op learn spell. 1661 * Actually makes op learn spell.
… …
1855 return; 1681 return;
1856 } 1682 }
1857 return; 1683 return;
1858 } 1684 }
1859 1685
1860 play_sound_player_only (op->contr, SOUND_LEARN_SPELL, 0, 0); 1686 op->contr->play_sound (sound_find ("learn_spell"));
1687
1861 tmp = spell->clone (); 1688 tmp = spell->clone ();
1862 insert_ob_in_ob (tmp, op); 1689 insert_ob_in_ob (tmp, op);
1863 1690
1864 if (special_prayer) 1691 if (special_prayer)
1865 SET_FLAG (tmp, FLAG_STARTEQUIP); 1692 SET_FLAG (tmp, FLAG_STARTEQUIP);
… …
1884 { 1711 {
1885 LOG (llevError, "BUG: do_forget_spell(): spell not known\n"); 1712 LOG (llevError, "BUG: do_forget_spell(): spell not known\n");
1886 return; 1713 return;
1887 } 1714 }
1888 1715
1889 new_draw_info_format (NDI_UNIQUE | NDI_NAVY, 0, op, "You lose knowledge of %s.", spell); 1716 op->failmsg (format ("You lose knowledge of %s.", spell));
1890 player_unready_range_ob (op->contr, spob); 1717 player_unready_range_ob (op->contr, spob);
1891 esrv_remove_spell (op->contr, spob); 1718 esrv_remove_spell (op->contr, spob);
1892 spob->destroy (); 1719 spob->destroy ();
1893} 1720}
1894 1721
… …
1902{ 1729{
1903 object *skop, *spell, *spell_skill; 1730 object *skop, *spell, *spell_skill;
1904 1731
1905 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1732 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
1906 { 1733 {
1907 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1734 op->failmsg ("You are unable to read while blind.");
1908 return; 1735 return;
1909 } 1736 }
1910 1737
1911 /* artifact_spellbooks have 'slaying' field point to a spell name, 1738 /* artifact_spellbooks have 'slaying' field point to a spell name,
1912 * instead of having their spell stored in stats.sp. These are 1739 * instead of having their spell stored in stats.sp. These are
1913 * legacy spellbooks 1740 * legacy spellbooks
1914 */ 1741 */
1915
1916 if (tmp->slaying != NULL) 1742 if (tmp->slaying)
1917 { 1743 {
1918 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying)); 1744 spell = arch_to_object (find_archetype_by_object_name (tmp->slaying));
1919 if (!spell) 1745 if (!spell)
1920 { 1746 {
1921 new_draw_info_format (NDI_UNIQUE, 0, op, "The book's formula for %s is incomplete", &tmp->slaying); 1747 op->failmsg (format ("The book's formula for %s is incomplete.", &tmp->slaying));
1922 return; 1748 return;
1923 } 1749 }
1924 else 1750 else
1925 insert_ob_in_ob (spell, tmp); 1751 insert_ob_in_ob (spell, tmp);
1752
1926 tmp->slaying = NULL; 1753 tmp->slaying = 0;
1927 } 1754 }
1928 1755
1929 skop = find_skill_by_name (op, tmp->skill); 1756 skop = find_skill_by_name (op, tmp->skill);
1930 1757
1931 /* need a literacy skill to learn spells. Also, having a literacy level 1758 /* need a literacy skill to learn spells. Also, having a literacy level
1932 * lower than the spell will make learning the spell more difficult */ 1759 * lower than the spell will make learning the spell more difficult */
1933 if (!skop) 1760 if (!skop)
1934 { 1761 {
1935 new_draw_info (NDI_UNIQUE, 0, op, "You can't read! Your attempt fails."); 1762 op->failmsg (format ("You can't read! Your attempt fails. H<You lack the %s skill.>", &tmp->skill));
1936 return; 1763 return;
1937 } 1764 }
1938 1765
1939 spell = tmp->inv; 1766 spell = tmp->inv;
1940 1767
1941 if (!spell) 1768 if (!spell)
1942 { 1769 {
1943 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name); 1770 LOG (llevError, "apply_spellbook: Book %s has no spell in it!\n", &tmp->name);
1944 new_draw_info (NDI_UNIQUE, 0, op, "The spellbook symbols make no sense."); 1771 op->failmsg ("The spellbook symbols make no sense. This is a bug, please report!");
1945 return; 1772 return;
1946 } 1773 }
1947 1774
1948 if (skop->level < int (sqrtf (spell->level) * 1.5f)) 1775 if (skop->level < int (sqrtf (spell->level) * 1.5f))
1949 { 1776 {
1950 new_draw_info (NDI_UNIQUE, 0, op, "It is too hard to read at your level: You are unable to decipher the strange symbols."); 1777 op->failmsg (format ("You are unable to decipher the strange symbols. H<Your %s level is too low.>", &tmp->skill));
1951 return; 1778 return;
1952 } 1779 }
1953 1780
1954 new_draw_info_format (NDI_UNIQUE, 0, op, "The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name); 1781 op->statusmsg (format ("The spellbook contains the %s level spell %s.", get_levelnumber (spell->level), &spell->name));
1955 1782
1956 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1783 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
1957 {
1958 identify (tmp); 1784 identify (tmp);
1959
1960 if (tmp->env)
1961 esrv_update_item (UPD_FLAGS | UPD_NAME, op, tmp);
1962 else
1963 op->contr->ns->floorbox_update ();
1964 }
1965 1785
1966 /* I removed the check for special_prayer_mark here - it didn't make 1786 /* I removed the check for special_prayer_mark here - it didn't make
1967 * a lot of sense - special prayers are not found in spellbooks, and 1787 * a lot of sense - special prayers are not found in spellbooks, and
1968 * if the player doesn't know the spell, doesn't make a lot of sense that 1788 * if the player doesn't know the spell, doesn't make a lot of sense that
1969 * they would have a special prayer mark. 1789 * they would have a special prayer mark.
1970 */ 1790 */
1971 if (check_spell_known (op, spell->name)) 1791 if (check_spell_known (op, spell->name))
1972 { 1792 {
1973 new_draw_info (NDI_UNIQUE, 0, op, "You already know that spell.\n"); 1793 op->statusmsg ("You already know that spell. H<It makes no sense to learn spells twice, and would only waste the spellbook.>\n");
1974 return; 1794 return;
1975 } 1795 }
1976 1796
1977 if (spell->skill) 1797 if (spell->skill)
1978 { 1798 {
1979 spell_skill = find_skill_by_name (op, spell->skill); 1799 spell_skill = find_skill_by_name (op, spell->skill);
1980 1800
1981 if (!spell_skill) 1801 if (!spell_skill)
1982 { 1802 {
1983 new_draw_info_format (NDI_UNIQUE, 0, op, "You lack the skill %s to use this spell", &spell->skill); 1803 op->failmsg (format ("You lack the skill %s to use this spell.", &spell->skill));
1984 return; 1804 return;
1985 } 1805 }
1986 1806
1987 if (spell_skill->level < spell->level) 1807 if (spell_skill->level < spell->level)
1988 { 1808 {
1989 new_draw_info_format (NDI_UNIQUE, 0, op, "You need to be level %d in %s to learn this spell.", spell->level, &spell->skill); 1809 op->failmsg (format ("You need to be level %d in %s to learn this spell.", spell->level, &spell->skill));
1990 return; 1810 return;
1991 } 1811 }
1992 } 1812 }
1993 1813
1994 /* Logic as follows 1814 /* Logic as follows
… …
2003 * Overall, chances are the same but a player will find having a high 1823 * Overall, chances are the same but a player will find having a high
2004 * literacy rate very useful! -b.t. 1824 * literacy rate very useful! -b.t.
2005 */ 1825 */
2006 if (QUERY_FLAG (op, FLAG_CONFUSED)) 1826 if (QUERY_FLAG (op, FLAG_CONFUSED))
2007 { 1827 {
2008 new_draw_info (NDI_UNIQUE, 0, op, "In your confused state you flub the wording of the text!"); 1828 op->failmsg ("In your confused state you flub the wording of the text!");
2009 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace)); 1829 scroll_failure (op, 0 - random_roll (0, spell->level, op, PREFER_LOW), MAX (spell->stats.sp, spell->stats.grace));
2010 } 1830 }
2011 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || 1831 else if (QUERY_FLAG (tmp, FLAG_STARTEQUIP) ||
2012 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int]) 1832 (random_roll (0, 100, op, PREFER_LOW) - (5 * skop->level)) < learn_spell[spell->stats.grace ? op->stats.Wis : op->stats.Int])
2013 { 1833 {
2014 1834 op->statusmsg ("You succeed in learning the spell!", NDI_GREEN);
2015 new_draw_info (NDI_UNIQUE, 0, op, "You succeed in learning the spell!");
2016 do_learn_spell (op, spell, 0); 1835 do_learn_spell (op, spell, 0);
2017 1836
2018 /* xp gain to literacy for spell learning */ 1837 /* xp gain to literacy for spell learning */
2019 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP)) 1838 if (!QUERY_FLAG (tmp, FLAG_STARTEQUIP))
2020 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0); 1839 change_exp (op, calc_skill_exp (op, tmp, skop), skop->skill, 0);
2021 } 1840 }
2022 else 1841 else
2023 { 1842 {
2024 play_sound_player_only (op->contr, SOUND_FUMBLE_SPELL, 0, 0); 1843 op->contr->play_sound (sound_find ("fumble_spell"));
2025 new_draw_info (NDI_UNIQUE, 0, op, "You fail to learn the spell.\n"); 1844 op->failmsg ("You fail to learn the spell. H<Wis (priests) or Int (wizards) governs the chance of learning a prayer or spell.>\n");
2026 } 1845 }
2027 decrease_ob (tmp); 1846
1847 tmp->decrease ();
2028} 1848}
2029 1849
2030/** 1850/**
2031 * Handles applying a spell scroll. 1851 * Handles applying a spell scroll.
2032 */ 1852 */
… …
2035{ 1855{
2036 object *skop; 1856 object *skop;
2037 1857
2038 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ)) 1858 if (QUERY_FLAG (op, FLAG_BLIND) && !QUERY_FLAG (op, FLAG_WIZ))
2039 { 1859 {
2040 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to read while blind."); 1860 op->failmsg ("You are unable to read while blind.");
2041 return; 1861 return;
2042 } 1862 }
2043 1863
2044 if (!tmp->inv || tmp->inv->type != SPELL) 1864 if (!tmp->inv || tmp->inv->type != SPELL)
2045 { 1865 {
2046 new_draw_info (NDI_UNIQUE, 0, op, "The scroll just doesn't make sense!"); 1866 op->failmsg ("The scroll just doesn't make sense! H<...and never will make sense.>");
2047 return; 1867 return;
2048 } 1868 }
2049 1869
2050 if (op->type == PLAYER) 1870 if (op->type == PLAYER)
2051 { 1871 {
… …
2057 */ 1877 */
2058 skop = find_skill_by_name (op, skill_names[SK_LITERACY]); 1878 skop = find_skill_by_name (op, skill_names[SK_LITERACY]);
2059 1879
2060 if (!skop) 1880 if (!skop)
2061 { 1881 {
2062 new_draw_info (NDI_UNIQUE, 0, op, "You are unable to decipher the strange symbols."); 1882 op->failmsg (format ("You are unable to decipher the strange symbols. H<You lack the %s skill.>", &skill_names[SK_LITERACY]));
2063 return; 1883 return;
2064 } 1884 }
2065 1885
2066 if ((exp_gain = calc_skill_exp (op, tmp, skop))) 1886 if ((exp_gain = calc_skill_exp (op, tmp, skop)))
2067 change_exp (op, exp_gain, skop->skill, 0); 1887 change_exp (op, exp_gain, skop->skill, 0);
2068 } 1888 }
2069 1889
2070 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED)) 1890 if (!QUERY_FLAG (tmp, FLAG_IDENTIFIED))
2071 identify (tmp); 1891 identify (tmp);
2072 1892
2073 new_draw_info_format (NDI_BLACK, 0, op, "The scroll of %s turns to dust.", &tmp->inv->name); 1893 op->statusmsg (format ("The scroll of %s turns to dust.", &tmp->inv->name));
2074
2075 1894
2076 cast_spell (op, tmp, dir, tmp->inv, NULL); 1895 cast_spell (op, tmp, dir, tmp->inv, NULL);
2077 decrease_ob (tmp); 1896 tmp->decrease ();
2078} 1897}
2079 1898
2080/** 1899/**
2081 * Applies a treasure object - by default, chest. op 1900 * Applies a treasure object - by default, chest. op
2082 * is the person doing the applying, tmp is the treasure 1901 * is the person doing the applying, tmp is the treasure
2083 * chest. 1902 * chest.
2084 */ 1903 */
2085static void 1904static void
2086apply_treasure (object *op, object *tmp) 1905apply_treasure (object *op, object *tmp)
2087{ 1906{
2088 object *treas;
2089
2090
2091 /* Nice side effect of new treasure creation method is that the treasure 1907 /* Nice side effect of this treasure creation method is that the treasure
2092 * for the chest is done when the chest is created, and put into the chest 1908 * for the chest is done when the chest is created, and put into the chest
2093 * inventory. So that when the chest burns up, the items still exist. Also 1909 * inventory. So that when the chest burns up, the items still exist. Also
2094 * prevents people fromt moving chests to more difficult maps to get better 1910 * prevents people from moving chests to more difficult maps to get better
2095 * treasure 1911 * treasure
2096 */ 1912 */
2097
2098 treas = tmp->inv; 1913 object *treas = tmp->inv;
2099 if (treas == NULL) 1914
1915 if (!treas)
2100 { 1916 {
2101 new_draw_info (NDI_UNIQUE, 0, op, "The chest was empty."); 1917 op->statusmsg ("The chest was empty.");
2102 decrease_ob (tmp); 1918 tmp->decrease ();
2103 return; 1919 return;
2104 } 1920 }
1921
2105 while (tmp->inv) 1922 while (tmp->inv)
2106 { 1923 {
2107 treas = tmp->inv; 1924 treas = tmp->inv;
2108
2109 treas->remove (); 1925 treas->remove ();
2110 new_draw_info_format (NDI_UNIQUE, 0, op, "You find %s in the chest.", query_name (treas));
2111 1926
2112 treas->x = op->x; 1927 treas->x = op->x;
2113 treas->y = op->y; 1928 treas->y = op->y;
2114 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR); 1929 treas = insert_ob_in_map (treas, op->map, op, INS_BELOW_ORIGINATOR);
2115 1930
2116 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE)) 1931 if (treas && (treas->type == RUNE || treas->type == TRAP) && treas->level && QUERY_FLAG (op, FLAG_ALIVE))
2117 spring_trap (treas, op); 1932 spring_trap (treas, op);
2118 1933
2119 /* If either player or container was destroyed, no need to do 1934 /* If either player or container was destroyed, no need to do
2120 * further processing. I think this should be enclused with 1935 * further processing. I think this should be enclused with
2121 * spring trap above, as I don't think there is otherwise 1936 * spring trap above, as I don't think there is otherwise
2122 * any way for the treasure chest or player to get killed 1937 * any way for the treasure chest or player to get killed.
2123 */ 1938 */
2124 if (op->destroyed () || tmp->destroyed ()) 1939 if (op->destroyed () || tmp->destroyed ())
2125 break; 1940 break;
2126 } 1941 }
2127 1942
2128 if (!tmp->destroyed () && tmp->inv == NULL) 1943 if (!tmp->destroyed () && !tmp->inv)
2129 decrease_ob (tmp); 1944 tmp->decrease ();
2130
2131} 1945}
2132 1946
2133/** 1947/**
2134 * op eats food. 1948 * op eats food.
2135 * If player, takes care of messages and dragon special food. 1949 * If player, takes care of messages and dragon special food.
… …
2150 { 1964 {
2151 /* usual case - no dragon meal: */ 1965 /* usual case - no dragon meal: */
2152 if (op->stats.food + tmp->stats.food > 999) 1966 if (op->stats.food + tmp->stats.food > 999)
2153 { 1967 {
2154 if (tmp->type == FOOD || tmp->type == FLESH) 1968 if (tmp->type == FOOD || tmp->type == FLESH)
2155 new_draw_info (NDI_UNIQUE, 0, op, "You feel full, but what a waste of food!"); 1969 op->failmsg ("You feel full, but what a waste of food!");
2156 else 1970 else
2157 new_draw_info (NDI_UNIQUE, 0, op, "Most of the drink goes down your face not your throat!"); 1971 op->statusmsg ("Most of the drink goes down your face not your throat!");
2158 } 1972 }
1973
1974 tmp->play_sound (
1975 tmp->sound
1976 ? tmp->sound
1977 : tmp->type == DRINK
1978 ? sound_find ("eat_drink")
1979 : sound_find ("eat_food")
1980 );
2159 1981
2160 if (!QUERY_FLAG (tmp, FLAG_CURSED)) 1982 if (!QUERY_FLAG (tmp, FLAG_CURSED))
2161 { 1983 {
2162 char buf[MAX_BUF]; 1984 const char *buf;
2163 1985
2164 if (!is_dragon_pl (op)) 1986 if (!is_dragon_pl (op))
2165 { 1987 {
2166 /* eating message for normal players */ 1988 /* eating message for normal players */
2167 if (tmp->type == DRINK) 1989 if (tmp->type == DRINK)
2168 sprintf (buf, "Ahhh...that %s tasted good.", &tmp->name); 1990 buf = format ("Ahhh...that %s tasted good.", &tmp->name);
2169 else 1991 else
2170 sprintf (buf, "The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good."); 1992 buf = format ("The %s tasted %s", &tmp->name, tmp->type == FLESH ? "terrible!" : "good.");
2171 } 1993 }
2172 else 1994 else
2173 {
2174 /* eating message for dragon players */ 1995 /* eating message for dragon players */
2175 sprintf (buf, "The %s tasted terrible!", &tmp->name); 1996 buf = format ("The %s tasted terrible!", &tmp->name);
2176 }
2177 1997
2178 new_draw_info (NDI_UNIQUE, 0, op, buf); 1998 op->statusmsg (buf);
1999
2179 capacity_remaining = 999 - op->stats.food; 2000 capacity_remaining = 999 - op->stats.food;
2180 op->stats.food += tmp->stats.food; 2001 op->stats.food += tmp->stats.food;
2181 if (capacity_remaining < tmp->stats.food) 2002 if (capacity_remaining < tmp->stats.food)
2182 op->stats.hp += capacity_remaining / 50; 2003 op->stats.hp += capacity_remaining / 50;
2183 else 2004 else
2184 op->stats.hp += tmp->stats.food / 50; 2005 op->stats.hp += tmp->stats.food / 50;
2006
2185 if (op->stats.hp > op->stats.maxhp) 2007 if (op->stats.hp > op->stats.maxhp)
2186 op->stats.hp = op->stats.maxhp; 2008 op->stats.hp = op->stats.maxhp;
2187 if (op->stats.food > 999) 2009 if (op->stats.food > 999)
2188 op->stats.food = 999; 2010 op->stats.food = 999;
2189 } 2011 }
… …
2191 /* special food hack -b.t. */ 2013 /* special food hack -b.t. */
2192 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED)) 2014 if (tmp->title || QUERY_FLAG (tmp, FLAG_CURSED))
2193 eat_special_food (op, tmp); 2015 eat_special_food (op, tmp);
2194 } 2016 }
2195 } 2017 }
2018
2196 handle_apply_yield (tmp); 2019 handle_apply_yield (tmp);
2197 decrease_ob (tmp); 2020 tmp->decrease ();
2198} 2021}
2199 2022
2200/** 2023/**
2201 * A dragon is eating some flesh. If the flesh contains resistances, 2024 * A dragon is eating some flesh. If the flesh contains resistances,
2202 * there is a chance for the dragon's skin to get improved. 2025 * there is a chance for the dragon's skin to get improved.
… …
2212{ 2035{
2213 object *skin = NULL; /* pointer to dragon skin force */ 2036 object *skin = NULL; /* pointer to dragon skin force */
2214 object *abil = NULL; /* pointer to dragon ability force */ 2037 object *abil = NULL; /* pointer to dragon ability force */
2215 object *tmp = NULL; /* tmp. object */ 2038 object *tmp = NULL; /* tmp. object */
2216 2039
2217 char buf[MAX_BUF]; /* tmp. string buffer */
2218 double chance; /* improvement-chance of one resistance type */ 2040 double chance; /* improvement-chance of one resistance type */
2219 double totalchance = 1; /* total chance of gaining one resistance */ 2041 double totalchance = 1; /* total chance of gaining one resistance */
2220 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */ 2042 double bonus = 0; /* level bonus (improvement is easier at lowlevel) */
2221 double mbonus = 0; /* monster bonus */ 2043 double mbonus = 0; /* monster bonus */
2222 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */ 2044 int atnr_winner[NROFATTACKS]; /* winning candidates for resistance improvement */
… …
2227 if (meal->type != FLESH || !is_dragon_pl (op)) 2049 if (meal->type != FLESH || !is_dragon_pl (op))
2228 return 0; 2050 return 0;
2229 2051
2230 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces 2052 /* now grab the 'dragon_skin'- and 'dragon_ability'-forces
2231 from the player's inventory */ 2053 from the player's inventory */
2232 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 2054 for (tmp = op->inv; tmp; tmp = tmp->below)
2233 {
2234 if (tmp->type == FORCE) 2055 if (tmp->type == FORCE)
2235 { 2056 if (tmp->arch->archname == shstr_dragon_skin_force)
2236 if (strcmp (tmp->arch->name, "dragon_skin_force") == 0)
2237 skin = tmp; 2057 skin = tmp;
2238 else if (strcmp (tmp->arch->name, "dragon_ability_force") == 0) 2058 else if (tmp->arch->archname == shstr_dragon_ability_force)
2239 abil = tmp; 2059 abil = tmp;
2240 }
2241 }
2242 2060
2243 /* if either skin or ability are missing, this is an old player 2061 /* if either skin or ability are missing, this is an old player
2244 which is not to be considered a dragon -> bail out */ 2062 which is not to be considered a dragon -> bail out */
2245 if (skin == NULL || abil == NULL) 2063 if (skin == NULL || abil == NULL)
2246 return 0; 2064 return 0;
… …
2248 /* now start by filling stomache and health, according to food-value */ 2066 /* now start by filling stomache and health, according to food-value */
2249 if ((999 - op->stats.food) < meal->stats.food) 2067 if ((999 - op->stats.food) < meal->stats.food)
2250 op->stats.hp += (999 - op->stats.food) / 50; 2068 op->stats.hp += (999 - op->stats.food) / 50;
2251 else 2069 else
2252 op->stats.hp += meal->stats.food / 50; 2070 op->stats.hp += meal->stats.food / 50;
2071
2253 if (op->stats.hp > op->stats.maxhp) 2072 if (op->stats.hp > op->stats.maxhp)
2254 op->stats.hp = op->stats.maxhp; 2073 op->stats.hp = op->stats.maxhp;
2255 2074
2256 op->stats.food = MIN (999, op->stats.food + meal->stats.food); 2075 op->stats.food = MIN (999, op->stats.food + meal->stats.food);
2257 2076
… …
2287 /* doubled chance for resistance of ability-focus */ 2106 /* doubled chance for resistance of ability-focus */
2288 if (i == abil->stats.exp) 2107 if (i == abil->stats.exp)
2289 chance = MIN (100., chance * 2.); 2108 chance = MIN (100., chance * 2.);
2290 2109
2291 /* now make the throw and save all winners (Don't insert luck bonus here!) */ 2110 /* now make the throw and save all winners (Don't insert luck bonus here!) */
2292 if (RANDOM () % 10000 < (int) (chance * 100)) 2111 if (rndm (10000) < (unsigned int) (chance * 100))
2293 { 2112 {
2294 atnr_winner[winners] = i; 2113 atnr_winner[winners] = i;
2295 winners++; 2114 winners++;
2296 } 2115 }
2297 2116
… …
2302 } 2121 }
2303 } 2122 }
2304 2123
2305 /* inverse totalchance as until now we have the failure-chance */ 2124 /* inverse totalchance as until now we have the failure-chance */
2306 totalchance = 100 - totalchance * 100; 2125 totalchance = 100 - totalchance * 100;
2126
2307 /* print message according to totalchance */ 2127 /* print message according to totalchance */
2128 const char *buf;
2308 if (totalchance > 50.) 2129 if (totalchance > 50.)
2309 sprintf (buf, "Hmm! The %s tasted delicious!", &meal->name); 2130 buf = format ("Hmm! The %s tasted delicious!", &meal->name);
2310 else if (totalchance > 10.) 2131 else if (totalchance > 10.)
2311 sprintf (buf, "The %s tasted very good.", &meal->name); 2132 buf = format ("The %s tasted very good.", &meal->name);
2312 else if (totalchance > 1.) 2133 else if (totalchance > 1.)
2313 sprintf (buf, "The %s tasted good.", &meal->name); 2134 buf = format ("The %s tasted good.", &meal->name);
2314 else if (totalchance > 0.1) 2135 else if (totalchance > 0.1)
2315 sprintf (buf, "The %s tasted bland.", &meal->name); 2136 buf = format ("The %s tasted bland.", &meal->name);
2316 else if (totalchance >= 0.01) 2137 else if (totalchance >= 0.01)
2317 sprintf (buf, "The %s had a boring taste.", &meal->name); 2138 buf = format ("The %s had a boring taste.", &meal->name);
2318 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat)) 2139 else if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat))
2319 sprintf (buf, "The %s tasted strange.", &meal->name); 2140 buf = format ("The %s tasted strange.", &meal->name);
2320 else 2141 else
2321 sprintf (buf, "The %s had no taste.", &meal->name); 2142 buf = format ("The %s had no taste.", &meal->name);
2322 new_draw_info (NDI_UNIQUE, 0, op, buf); 2143
2144 op->statusmsg (buf);
2323 2145
2324 /* now choose a winner if we have any */ 2146 /* now choose a winner if we have any */
2325 i = -1; 2147 i = -1;
2326 if (winners > 0) 2148 if (winners > 0)
2327 i = atnr_winner[RANDOM () % winners]; 2149 i = atnr_winner[RANDOM () % winners];
… …
2330 { 2152 {
2331 /* resistance increased! */ 2153 /* resistance increased! */
2332 skin->resist[i]++; 2154 skin->resist[i]++;
2333 op->update_stats (); 2155 op->update_stats ();
2334 2156
2335 sprintf (buf, "Your skin is now more resistant to %s!", change_resist_msg[i]); 2157 op->statusmsg (format ("Your skin is now more resistant to %s!", change_resist_msg[i]));
2336 new_draw_info (NDI_UNIQUE | NDI_RED, 0, op, buf);
2337 } 2158 }
2338 2159
2339 /* if this flesh contains a new ability focus, we mark it 2160 /* if this flesh contains a new ability focus, we mark it
2340 into the ability_force and it will take effect on next level */ 2161 into the ability_force and it will take effect on next level */
2341 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat) 2162 if (meal->last_eat > 0 && atnr_is_dragon_enabled (meal->last_eat) && meal->last_eat != abil->last_eat)
2342 { 2163 {
2343 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */ 2164 abil->last_eat = meal->last_eat; /* write: last_eat <new attnr focus> */
2344 2165
2345 if (meal->last_eat != abil->stats.exp) 2166 if (meal->last_eat != abil->stats.exp)
2167 op->statusmsg (format (
2168 "Your metabolism prepares to focus on %s!\n"
2169 "The change will happen at level %d.",
2170 change_resist_msg[meal->last_eat],
2171 abil->level + 1
2346 { 2172 ));
2347 sprintf (buf, "Your metabolism prepares to focus on %s!", change_resist_msg[meal->last_eat]);
2348 new_draw_info (NDI_UNIQUE, 0, op, buf);
2349 sprintf (buf, "The change will happen at level %d", abil->level + 1);
2350 new_draw_info (NDI_UNIQUE, 0, op, buf);
2351 }
2352 else 2173 else
2353 { 2174 {
2354 sprintf (buf, "Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]); 2175 op->statusmsg (format ("Your metabolism will continue to focus on %s.", change_resist_msg[meal->last_eat]));
2355 new_draw_info (NDI_UNIQUE, 0, op, buf);
2356 abil->last_eat = 0; 2176 abil->last_eat = 0;
2357 } 2177 }
2358 } 2178 }
2179
2359 return 1; 2180 return 1;
2360} 2181}
2361 2182
2362/** 2183/**
2363 * Handles applying an improve armor scroll. 2184 * Handles applying an improve armor scroll.
… …
2366static void 2187static void
2367apply_armour_improver (object *op, object *tmp) 2188apply_armour_improver (object *op, object *tmp)
2368{ 2189{
2369 object *armor; 2190 object *armor;
2370 2191
2371 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)) 2192 if (!QUERY_FLAG (op, FLAG_WIZCAST) && (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_NO_MAGIC))
2372 { 2193 {
2373 new_draw_info (NDI_UNIQUE, 0, op, "Something blocks the magic of the scroll."); 2194 op->failmsg ("Something blocks the magic of the scroll. H<This area prevents magic effects.>");
2374 return; 2195 return;
2375 } 2196 }
2376 2197
2377 armor = find_marked_object (op); 2198 armor = find_marked_object (op);
2378 2199
2379 if (!armor) 2200 if (!armor)
2380 { 2201 {
2381 new_draw_info (NDI_UNIQUE, 0, op, "You need to mark an armor object."); 2202 op->failmsg ("You need to mark an armor object. Use the right mouse button popup or the mark command to do this.");
2382 return; 2203 return;
2383 } 2204 }
2384 2205
2385 if (armor->type != ARMOUR 2206 if (armor->type != ARMOUR
2386 && armor->type != CLOAK 2207 && armor->type != CLOAK
2387 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET) 2208 && armor->type != BOOTS && armor->type != GLOVES && armor->type != BRACERS && armor->type != SHIELD && armor->type != HELMET)
2388 { 2209 {
2389 new_draw_info (NDI_UNIQUE, 0, op, "Your marked item is not armour!\n"); 2210 op->failmsg ("Your marked item is not armour!\n");
2390 return; 2211 return;
2391 } 2212 }
2392 2213
2393 new_draw_info (NDI_UNIQUE, 0, op, "Applying armour enchantment."); 2214 op->statusmsg ("Applying armour enchantment.");
2394 improve_armour (op, tmp, armor); 2215 improve_armour (op, tmp, armor);
2395} 2216}
2396 2217
2397extern void 2218void
2398apply_poison (object *op, object *tmp) 2219apply_poison (object *op, object *tmp)
2399{ 2220{
2221 object *poison = tmp->split (1);
2222
2400 if (op->type == PLAYER) 2223 if (op->type == PLAYER)
2401 { 2224 {
2402 play_sound_player_only (op->contr, SOUND_DRINK_POISON, 0, 0); 2225 op->contr->play_sound (sound_find ("drink_poison"));
2403 new_draw_info (NDI_UNIQUE, 0, op, "Yech! That tasted poisonous!"); 2226 op->failmsg ("Yech! That tasted poisonous!");
2404 strcpy (op->contr->killer, "poisonous booze"); 2227 op->contr->killer = poison;
2405 } 2228 }
2229
2406 if (tmp->stats.hp > 0) 2230 if (poison->stats.hp > 0)
2407 { 2231 {
2408 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", tmp->stats.hp); 2232 LOG (llevDebug, "Trying to poison player/monster for %d hp\n", poison->stats.hp);
2409 hit_player (op, tmp->stats.hp, tmp, AT_POISON, 1); 2233 hit_player (op, poison->stats.hp, tmp, AT_POISON, 1);
2410 } 2234 }
2235
2411 op->stats.food -= op->stats.food / 4; 2236 op->stats.food -= op->stats.food / 4;
2412 handle_apply_yield (tmp); 2237 handle_apply_yield (poison);
2413 decrease_ob (tmp); 2238 poison->destroy ();
2414} 2239}
2415 2240
2416/** 2241/**
2417 * This function return true if the exit is not a 2 ways one or it is 2 ways, valid exit. 2242 * This function return true if the exit is not a 2 ways one or it is 2 ways, valid exit.
2418 * A valid 2 way exit means: 2243 * A valid 2 way exit means:
… …
2434#if 0 //TODO 2259#if 0 //TODO
2435 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race) 2260 if (!has_been_loaded (EXIT_PATH (exit)) && exit->race)
2436 return 0; /* This is a reset town portal */ 2261 return 0; /* This is a reset town portal */
2437#endif 2262#endif
2438 2263
2264 LOG (llevError | logBacktrace, "sync map load due to %s\n", exit->debug_desc ());
2265
2439 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map); 2266 maptile *exitmap = maptile::find_sync (EXIT_PATH (exit), exit->map);
2440 2267
2441 if (exitmap) 2268 if (exitmap)
2442 { 2269 {
2443 exitmap->load_sync (); 2270 exitmap->load_sync ();
… …
2456 continue; /*Not a valid exit */ 2283 continue; /*Not a valid exit */
2457 2284
2458 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y)) 2285 if ((EXIT_X (tmp) != exit->x) || (EXIT_Y (tmp) != exit->y))
2459 continue; /*Not in the same place */ 2286 continue; /*Not in the same place */
2460 2287
2461 if (strcmp (exit->map->path, EXIT_PATH (tmp)) != 0) 2288 if (exit->map->path != EXIT_PATH (tmp))
2462 continue; /*Not in the same map */ 2289 continue; /*Not in the same map */
2463 2290
2464 /* From here we have found the exit is valid. However we do 2291 /* From here we have found the exit is valid. However we do
2465 * here the check of the exit owner. It is important for the 2292 * here the check of the exit owner. It is important for the
2466 * town portals to prevent strangers from visiting your appartments 2293 * town portals to prevent strangers from visiting your appartments
… …
2498 } 2325 }
2499 } 2326 }
2500 2327
2501 return 0; 2328 return 0;
2502} 2329}
2503
2504 2330
2505/** 2331/**
2506 * Main apply handler. 2332 * Main apply handler.
2507 * 2333 *
2508 * Checks for unpaid items before applying. 2334 * Checks for unpaid items before applying.
… …
2516 * being applied. 2342 * being applied.
2517 * 2343 *
2518 * aflag is special (always apply/unapply) flags. Nothing is done with 2344 * aflag is special (always apply/unapply) flags. Nothing is done with
2519 * them in this function - they are passed to apply_special 2345 * them in this function - they are passed to apply_special
2520 */ 2346 */
2521
2522int 2347int
2523manual_apply (object *op, object *tmp, int aflag) 2348manual_apply (object *op, object *tmp, int aflag)
2524{ 2349{
2525 if (tmp->head) 2350 if (tmp->head)
2526 tmp = tmp->head; 2351 tmp = tmp->head;
2527 2352
2528 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED)) 2353 if (QUERY_FLAG (tmp, FLAG_UNPAID) && !QUERY_FLAG (tmp, FLAG_APPLIED))
2529 { 2354 {
2530 if (op->type == PLAYER) 2355 if (op->type == PLAYER)
2531 { 2356 {
2532 new_draw_info (NDI_UNIQUE, 0, op, "You should pay for it first."); 2357 op->failmsg ("You should pay for it first! H<You cannot use items marked as unpaid.>");
2533 return 1; 2358 return 1;
2534 } 2359 }
2535 else 2360 else
2536 return 0; /* monsters just skip unpaid items */ 2361 return 0; /* monsters just skip unpaid items */
2537 } 2362 }
… …
2540 return RESULT_INT (0); 2365 return RESULT_INT (0);
2541 2366
2542 switch (tmp->type) 2367 switch (tmp->type)
2543 { 2368 {
2544 case CF_HANDLE: 2369 case CF_HANDLE:
2545 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2370 op->play_sound (sound_find ("turn_handle"));
2546 play_sound_map (op->map, op->x, op->y, SOUND_TURN_HANDLE); 2371 op->statusmsg ("You turn the handle.");
2547 tmp->value = tmp->value ? 0 : 1; 2372 tmp->value = tmp->value ? 0 : 1;
2548 SET_ANIMATION (tmp, tmp->value); 2373 SET_ANIMATION (tmp, tmp->value);
2549 update_object (tmp, UP_OBJ_FACE); 2374 update_object (tmp, UP_OBJ_FACE);
2550 push_button (tmp); 2375 push_button (tmp);
2551 return 1; 2376 return 1;
2552 2377
2553 case TRIGGER: 2378 case TRIGGER:
2554 if (check_trigger (tmp, op)) 2379 if (check_trigger (tmp, op))
2555 { 2380 {
2556 new_draw_info (NDI_UNIQUE, 0, op, "You turn the handle."); 2381 op->statusmsg ("You turn the handle.");
2557 play_sound_map (tmp->map, tmp->x, tmp->y, SOUND_TURN_HANDLE); 2382 op->play_sound (sound_find ("turn_handle"));
2558 } 2383 }
2559 else 2384 else
2560 new_draw_info (NDI_UNIQUE, 0, op, "The handle doesn't move."); 2385 op->failmsg ("The handle doesn't move.");
2561 2386
2562 return 1; 2387 return 1;
2563 2388
2564 case EXIT: 2389 case EXIT:
2565 if (op->type != PLAYER) 2390 if (op->type != PLAYER)
2566 return 0; 2391 return 0;
2567 2392
2568 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp)) 2393 if (!EXIT_PATH (tmp) || !is_legal_2ways_exit (op, tmp))
2569 { 2394 op->failmsg (format ("The %s is closed.", query_name (tmp)));
2570 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s is closed.", query_name (tmp));
2571 }
2572 else 2395 else
2573 { 2396 {
2574 /* Don't display messages for random maps. */ 2397 /* Don't display messages for random maps. */
2575 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2)) 2398 if (tmp->msg && strncmp (EXIT_PATH (tmp), "/!", 2))
2576 new_draw_info (NDI_NAVY, 0, op, tmp->msg); 2399 op->statusmsg (tmp->msg, NDI_NAVY);
2577 2400
2578 op->enter_exit (tmp); 2401 op->enter_exit (tmp);
2579 } 2402 }
2403
2404 return 1;
2405
2406 case INSCRIBABLE:
2407 op->statusmsg (tmp->msg);
2408 // maybe show a spell menu to chose from or something like that
2580 return 1; 2409 return 1;
2581 2410
2582 case SIGN: 2411 case SIGN:
2583 apply_sign (op, tmp, 0); 2412 apply_sign (op, tmp, 0);
2584 return 1; 2413 return 1;
… …
2588 { 2417 {
2589 apply_book (op, tmp); 2418 apply_book (op, tmp);
2590 return 1; 2419 return 1;
2591 } 2420 }
2592 else 2421 else
2593 {
2594 return 0; 2422 return 0;
2595 }
2596 2423
2597 case SKILLSCROLL: 2424 case SKILLSCROLL:
2598 if (op->type == PLAYER) 2425 if (op->type == PLAYER)
2599 { 2426 {
2600 apply_skillscroll (op, tmp); 2427 apply_skillscroll (op, tmp);
2601 return 1; 2428 return 1;
2602 } 2429 }
2430 else
2603 return 0; 2431 return 0;
2604 2432
2605 case SPELLBOOK: 2433 case SPELLBOOK:
2606 if (op->type == PLAYER) 2434 if (op->type == PLAYER)
2607 { 2435 {
2608 apply_spellbook (op, tmp); 2436 apply_spellbook (op, tmp);
2609 return 1; 2437 return 1;
2610 } 2438 }
2439 else
2611 return 0; 2440 return 0;
2612 2441
2613 case SCROLL: 2442 case SCROLL:
2614 apply_scroll (op, tmp, 0); 2443 apply_scroll (op, tmp, 0);
2615 return 1; 2444 return 1;
2616 2445
2617 case POTION: 2446 case POTION:
2618 (void) apply_potion (op, tmp); 2447 apply_potion (op, tmp);
2619 return 1; 2448 return 1;
2620 2449
2621 /* Eneq(@csd.uu.se): Handle apply on containers. */ 2450 /* Eneq(@csd.uu.se): Handle apply on containers. */
2451 //TODO: remove, as it is unsed?
2622 case CLOSE_CON: 2452 case CLOSE_CON:
2623 if (op->type == PLAYER)
2624 (void) esrv_apply_container (op, tmp->env);
2625 else
2626 (void) apply_container (op, tmp->env); 2453 apply_container (op, tmp->env);
2627 return 1; 2454 return 1;
2628 2455
2629 case CONTAINER: 2456 case CONTAINER:
2630 if (op->type == PLAYER)
2631 (void) esrv_apply_container (op, tmp);
2632 else
2633 (void) apply_container (op, tmp); 2457 apply_container (op, tmp);
2634 return 1; 2458 return 1;
2635 2459
2636 case TREASURE: 2460 case TREASURE:
2637 if (op->type == PLAYER) 2461 if (op->type == PLAYER)
2638 { 2462 {
2639 apply_treasure (op, tmp); 2463 apply_treasure (op, tmp);
2640 return 1; 2464 return 1;
2641 } 2465 }
2642 else 2466 else
2643 {
2644 return 0; 2467 return 0;
2645 }
2646 2468
2647 case WEAPON: 2469 case WEAPON:
2648 case ARMOUR: 2470 case ARMOUR:
2649 case BOOTS: 2471 case BOOTS:
2650 case GLOVES: 2472 case GLOVES:
… …
2663 case LAMP: 2485 case LAMP:
2664 case BUILDER: 2486 case BUILDER:
2665 case SKILL_TOOL: 2487 case SKILL_TOOL:
2666 if (tmp->env != op) 2488 if (tmp->env != op)
2667 return 2; /* not in inventory */ 2489 return 2; /* not in inventory */
2490
2668 (void) apply_special (op, tmp, aflag); 2491 apply_special (op, tmp, aflag);
2669 return 1; 2492 return 1;
2670 2493
2671 case DRINK: 2494 case DRINK:
2672 case FOOD: 2495 case FOOD:
2673 case FLESH: 2496 case FLESH:
… …
2689 } 2512 }
2690 else 2513 else
2691 return 0; 2514 return 0;
2692 2515
2693 case WEAPON_IMPROVER: 2516 case WEAPON_IMPROVER:
2694 (void) check_improve_weapon (op, tmp); 2517 check_improve_weapon (op, tmp);
2695 return 1; 2518 return 1;
2696 2519
2697 case CLOCK: 2520 case CLOCK:
2698 if (op->type == PLAYER) 2521 if (op->type == PLAYER)
2699 { 2522 {
2700 char buf[MAX_BUF]; 2523 char buf[MAX_BUF];
2701 timeofday_t tod; 2524 timeofday_t tod;
2702 2525
2703 get_tod (&tod); 2526 get_tod (&tod);
2527 op->play_sound (sound_find ("sound_clock"));
2528 op->statusmsg (format (
2704 sprintf (buf, "It is %d minute%s past %d o'clock %s", 2529 "It is %d minute%s past %d o'clock %s",
2705 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"), 2530 tod.minute + 1, ((tod.minute + 1 < 2) ? "" : "s"),
2706 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")); 2531 ((tod.hour % 14 == 0) ? 14 : ((tod.hour) % 14)), ((tod.hour >= 14) ? "pm" : "am")
2707 play_sound_player_only (op->contr, SOUND_CLOCK, 0, 0); 2532 ));
2708 new_draw_info (NDI_UNIQUE, 0, op, buf);
2709 return 1; 2533 return 1;
2710 } 2534 }
2711 else 2535 else
2712 {
2713 return 0; 2536 return 0;
2714 }
2715 2537
2716 case MENU: 2538 case MENU:
2717 if (op->type == PLAYER) 2539 if (op->type == PLAYER)
2718 { 2540 {
2719 shop_listing (op); 2541 shop_listing (tmp, op);
2720 return 1; 2542 return 1;
2721 } 2543 }
2722 else 2544 else
2723 {
2724 return 0; 2545 return 0;
2725 }
2726 2546
2727 case POWER_CRYSTAL: 2547 case POWER_CRYSTAL:
2728 apply_power_crystal (op, tmp); /* see egoitem.c */ 2548 apply_power_crystal (op, tmp); /* see egoitem.c */
2729 return 1; 2549 return 1;
2730 2550
… …
2733 { 2553 {
2734 apply_lighter (op, tmp); 2554 apply_lighter (op, tmp);
2735 return 1; 2555 return 1;
2736 } 2556 }
2737 else 2557 else
2738 {
2739 return 0; 2558 return 0;
2740 }
2741 2559
2742 case ITEM_TRANSFORMER: 2560 case ITEM_TRANSFORMER:
2743 apply_item_transformer (op, tmp); 2561 apply_item_transformer (op, tmp);
2744 return 1; 2562 return 1;
2745 2563
… …
2758int 2576int
2759player_apply (object *pl, object *op, int aflag, int quiet) 2577player_apply (object *pl, object *op, int aflag, int quiet)
2760{ 2578{
2761 int tmp; 2579 int tmp;
2762 2580
2763 if (op->env == NULL && (pl->move_type & MOVE_FLYING)) 2581 if (op->env && (pl->move_type & MOVE_FLYING))
2764 { 2582 {
2765 /* player is flying and applying object not in inventory */ 2583 /* player is flying and applying object not in inventory */
2766 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING)) 2584 if (!QUERY_FLAG (pl, FLAG_WIZ) && !(op->move_type & MOVE_FLYING))
2767 { 2585 {
2768 new_draw_info (NDI_UNIQUE, 0, pl, "But you are floating high " "above the ground!"); 2586 pl->failmsg ("But you are floating high above the ground! H<You have to stop levitating first, if you can.>");
2769 return 0; 2587 return 0;
2770 } 2588 }
2771 }
2772
2773 /* Check for PLAYER to avoid a DM to disappear in a puff of smoke if
2774 * applied.
2775 */
2776 if (op->type != PLAYER && QUERY_FLAG (op, FLAG_WAS_WIZ) && !QUERY_FLAG (pl, FLAG_WAS_WIZ))
2777 {
2778 play_sound_map (pl->map, pl->x, pl->y, SOUND_OB_EVAPORATE);
2779 new_draw_info (NDI_UNIQUE, 0, pl, "The object disappears in a puff " "of smoke!");
2780 new_draw_info (NDI_UNIQUE, 0, pl, "It must have been an illusion.");
2781 op->destroy ();
2782 return 1;
2783 } 2589 }
2784 2590
2785 pl->contr->last_used = op; 2591 pl->contr->last_used = op;
2786 2592
2787 tmp = manual_apply (pl, op, aflag); 2593 tmp = manual_apply (pl, op, aflag);
2788 if (!quiet) 2594 if (!quiet)
2789 { 2595 {
2790 if (tmp == 0) 2596 if (tmp == 0)
2791 new_draw_info_format (NDI_UNIQUE, 0, pl, "I don't know how to apply the %s.", query_name (op)); 2597 pl->statusmsg (format ("I don't know how to apply the %s.", query_name (op)));
2792 else if (tmp == 2) 2598 else if (tmp == 2)
2793 new_draw_info_format (NDI_UNIQUE, 0, pl, "You must get it first!\n"); 2599 pl->failmsg ("You must get it first!\n");
2794 } 2600 }
2601
2795 return tmp; 2602 return tmp;
2796} 2603}
2797 2604
2798/** 2605/**
2799 * player_apply_below attempts to apply the object 'below' the player. 2606 * player_apply_below attempts to apply the object 'below' the player.
2800 * If the player has an open container, we use that for below, otherwise 2607 * If the player has an open container, we use that for below, otherwise
2801 * we use the ground. 2608 * we use the ground.
2802 */ 2609 */
2803
2804void 2610void
2805player_apply_below (object *pl) 2611player_apply_below (object *pl)
2806{ 2612{
2807 object *tmp, *next;
2808 int floors; 2613 int floors = 0;
2809 2614
2810 /* If using a container, set the starting item to be the top 2615 /* If using a container, set the starting item to be the top
2811 * item in the container. Otherwise, use the map. 2616 * item in the container. Otherwise, use the map.
2812 */
2813 tmp = (pl->container != NULL) ? pl->container->inv : pl->below;
2814
2815 /* This is perhaps more complicated. However, I want to make sure that 2617 * This is perhaps more complicated. However, I want to make sure that
2816 * we don't use a corrupt pointer for the next object, so we get the 2618 * we don't use a corrupt pointer for the next object, so we get the
2817 * next object in the stack before applying. This is can only be a 2619 * next object in the stack before applying. This is can only be a
2818 * problem if player_apply() has a bug in that it uses the object but does 2620 * problem if player_apply() has a bug in that it uses the object but does
2819 * not return a proper value. 2621 * not return a proper value.
2820 */ 2622 */
2821 for (floors = 0; tmp != NULL; tmp = next) 2623 for (object *next, *tmp = pl->container ? pl->container->inv : pl->below; tmp; tmp = next)
2822 { 2624 {
2823 next = tmp->below; 2625 next = tmp->below;
2626
2824 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 2627 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
2825 floors++; 2628 floors++;
2826 else if (floors > 0) 2629 else if (floors > 0)
2827 return; /* process only floor objects after first floor object */ 2630 return; /* process only floor objects after first floor object */
2828 2631
… …
2848 * to keep the size of apply_special to a more managable size. 2651 * to keep the size of apply_special to a more managable size.
2849 */ 2652 */
2850static int 2653static int
2851unapply_special (object *who, object *op, int aflags) 2654unapply_special (object *who, object *op, int aflags)
2852{ 2655{
2853 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags)) || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags))) 2656 if (INVOKE_OBJECT (BE_UNREADY, op, ARG_OBJECT (who), ARG_INT (aflags))
2657 || INVOKE_OBJECT (UNREADY, who, ARG_OBJECT (op), ARG_INT (aflags)))
2854 return RESULT_INT (0); 2658 return RESULT_INT (0);
2855 2659
2856 object *tmp2;
2857
2858 CLEAR_FLAG (op, FLAG_APPLIED); 2660 CLEAR_FLAG (op, FLAG_APPLIED);
2661
2859 switch (op->type) 2662 switch (op->type)
2860 { 2663 {
2664 case SKILL_TOOL:
2665 // unapplying a skill tool should also unapply the skill it governs
2666 // but this is hard, as it shouldn't do so when the skill can
2667 // be used for other reasons
2668 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2669 if (tmp->skill == op->skill
2670 && tmp->type == SKILL
2671 && tmp->flag [FLAG_APPLIED]
2672 && !tmp->flag [FLAG_CAN_USE_SKILL])
2673 unapply_special (who, tmp, 0);
2674
2675 change_abil (who, op);
2676 break;
2677
2861 case WEAPON: 2678 case WEAPON:
2862 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwield %s.", query_name (op)); 2679 if (player *pl = who->contr)
2680 if (op == pl->combat_ob)
2681 {
2682 pl->combat_ob = 0;
2683 who->change_weapon (pl->ranged_ob);
2684 }
2863 2685
2686 who->statusmsg (format ("You unwield %s.", query_name (op)));
2687
2864 (void) change_abil (who, op); 2688 change_abil (who, op);
2865 if (QUERY_FLAG (who, FLAG_READY_WEAPON))
2866 CLEAR_FLAG (who, FLAG_READY_WEAPON); 2689 CLEAR_FLAG (who, FLAG_READY_WEAPON);
2867 clear_skill (who);
2868 break; 2690 break;
2869 2691
2870 case SKILL: /* allows objects to impart skills */
2871 case SKILL_TOOL: 2692 case SKILL:
2872 if (op != who->chosen_skill) 2693 if (who->contr)
2873 { 2694 {
2874 LOG (llevError, "BUG: apply_special(): applied skill is not a chosen skill\n"); 2695 if (!op->invisible)
2696 who->statusmsg (format ("You stop using the %s.", query_name (op)));
2697 else
2698 who->statusmsg (format ("You can no longer use the skill: %s.", &op->skill));
2875 } 2699 }
2876 if (who->type == PLAYER) 2700
2877 {
2878 if (who->contr->shoottype == range_skill)
2879 who->contr->shoottype = range_none;
2880 if (!op->invisible)
2881 {
2882 new_draw_info_format (NDI_UNIQUE, 0, who, "You stop using the %s.", query_name (op));
2883 }
2884 else
2885 {
2886 new_draw_info_format (NDI_UNIQUE, 0, who, "You can no longer use the skill: %s.", &op->skill);
2887 }
2888 }
2889 (void) change_abil (who, op); 2701 change_abil (who, op);
2890 who->chosen_skill = NULL;
2891 CLEAR_FLAG (who, FLAG_READY_SKILL); 2702 CLEAR_FLAG (who, FLAG_READY_SKILL);
2892 break; 2703 break;
2893 2704
2894 case ARMOUR: 2705 case ARMOUR:
2895 case HELMET: 2706 case HELMET:
… …
2899 case GLOVES: 2710 case GLOVES:
2900 case AMULET: 2711 case AMULET:
2901 case GIRDLE: 2712 case GIRDLE:
2902 case BRACERS: 2713 case BRACERS:
2903 case CLOAK: 2714 case CLOAK:
2904 new_draw_info_format (NDI_UNIQUE, 0, who, "You unwear %s.", query_name (op)); 2715 who->statusmsg (format ("You unwear %s.", query_name (op)));
2905 (void) change_abil (who, op); 2716 change_abil (who, op);
2906 break; 2717 break;
2718
2907 case LAMP: 2719 case LAMP:
2908 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn off your %s.", &op->name); 2720 {
2721 who->statusmsg (format ("You turn off your %s.", &op->name));
2722
2909 tmp2 = arch_to_object (op->other_arch); 2723 object *tmp2 = arch_to_object (op->other_arch);
2910 tmp2->x = op->x; 2724 tmp2->x = op->x;
2911 tmp2->y = op->y; 2725 tmp2->y = op->y;
2912 tmp2->map = op->map; 2726 tmp2->map = op->map;
2913 tmp2->below = op->below; 2727 tmp2->below = op->below;
2914 tmp2->above = op->above; 2728 tmp2->above = op->above;
2915 tmp2->stats.food = op->stats.food; 2729 tmp2->stats.food = op->stats.food;
2916 CLEAR_FLAG (tmp2, FLAG_APPLIED); 2730 CLEAR_FLAG (tmp2, FLAG_APPLIED);
2917 2731
2918 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 2732 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
2919 SET_FLAG (tmp2, FLAG_INV_LOCKED); 2733 SET_FLAG (tmp2, FLAG_INV_LOCKED);
2920 2734
2921 if (who->type == PLAYER)
2922 esrv_del_item (who->contr, op->count);
2923
2924 op->destroy (); 2735 op->destroy ();
2925 insert_ob_in_ob (tmp2, who); 2736 who->insert (tmp2);
2926 who->update_stats (); 2737 who->update_stats ();
2738
2739 if (who->contr)
2740 {
2927 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 2741 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
2928 {
2929 if (who->type == PLAYER)
2930 { 2742 {
2931 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 2743 who->failmsg ("Oops, it feels deadly cold!");
2932 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 2744 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
2933 } 2745 }
2934 } 2746 }
2935 if (who->type == PLAYER) 2747 }
2936 esrv_send_item (who, tmp2); 2748
2937 return 1; /* otherwise, an attempt to drop causes problems */ 2749 return 1; /* otherwise, an attempt to drop causes problems */
2938 break; 2750
2939 case BOW: 2751 case BOW:
2940 case WAND: 2752 case WAND:
2941 case ROD: 2753 case ROD:
2942 case HORN: 2754 case HORN:
2943 clear_skill (who); 2755 if (player *pl = who->contr)
2944 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op));
2945 if (who->type == PLAYER)
2946 { 2756 {
2947 who->contr->shoottype = range_none; 2757 if (op == pl->ranged_ob)
2758 {
2759 pl->ranged_ob = 0;
2760 who->change_weapon (pl->combat_ob);
2761 }
2762
2763 who->statusmsg (format ("You unready %s.", query_name (op)));
2948 } 2764 }
2949 else 2765 else
2950 { 2766 {
2767 who->change_skill (0);
2768
2951 if (op->type == BOW) 2769 if (op->type == BOW)
2952 CLEAR_FLAG (who, FLAG_READY_BOW); 2770 CLEAR_FLAG (who, FLAG_READY_BOW);
2953 else 2771 else
2954 CLEAR_FLAG (who, FLAG_READY_RANGE); 2772 CLEAR_FLAG (who, FLAG_READY_RANGE);
2955 } 2773 }
2774
2956 break; 2775 break;
2957 2776
2958 case BUILDER: 2777 case BUILDER:
2959 new_draw_info_format (NDI_UNIQUE, 0, who, "You unready %s.", query_name (op)); 2778 if (who->contr)
2960 who->contr->shoottype = range_none; 2779 who->statusmsg (format ("You unready %s.", query_name (op)));
2961 who->contr->ranges[range_builder] = NULL;
2962 break; 2780 break;
2963 2781
2964 default: 2782 default:
2965 new_draw_info_format (NDI_UNIQUE, 0, who, "You unapply %s.", query_name (op)); 2783 who->statusmsg (format ("You unapply %s.", query_name (op)));
2966 break; 2784 break;
2967 } 2785 }
2968 2786
2787 if (aflags & AP_NO_MERGE || !merge_ob (op, 0))
2788 if (object *pl = op->visible_to ())
2789 esrv_send_item (pl, op);
2790
2969 who->update_stats (); 2791 who->update_stats ();
2970 2792
2971 if (!(aflags & AP_NO_MERGE))
2972 {
2973 object *tmp;
2974
2975 tmp = merge_ob (op, NULL);
2976 if (who->type == PLAYER)
2977 {
2978 if (tmp)
2979 { /* it was merged */
2980 esrv_del_item (who->contr, op->count);
2981 op = tmp;
2982 }
2983
2984 esrv_send_item (who, op);
2985 }
2986 }
2987 return 0; 2793 return 0;
2988} 2794}
2989 2795
2990/** 2796/**
2991 * Returns the object that is using location 'loc'. 2797 * Returns the object that is using location 'loc'.
2992 * Note that 'start' is the first object to start examing - we 2798 * Note that 'start' is the first object to start examing - we
2993 * then go through the below of this. In this way, you can do 2799 * then go through the below of this. In this way, you can do
2994 * something like: 2800 * something like:
2995 * tmp = get_item_from_body_location(who->inv, 1); 2801 * tmp = get_next_item_from_body_location(who->inv, 1);
2996 * if (tmp) tmp1 = get_item_from_body_location(tmp->below, 1); 2802 * if (tmp) tmp1 = get_next_item_from_body_location(tmp->below, 1);
2997 * to find the second object that may use this location, etc. 2803 * to find the second object that may use this location, etc.
2998 * Returns NULL if no match is found. 2804 * Returns NULL if no match is found.
2999 * loc is the index into the array we are looking for a match. 2805 * loc is the index into the array we are looking for a match.
3000 * don't return invisible objects unless they are skill objects 2806 * don't return invisible objects unless they are skill objects
3001 * invisible other objects that use 2807 * invisible other objects that use
3002 * up body locations can be used as restrictions. 2808 * up body locations can be used as restrictions.
3003 */ 2809 */
3004object * 2810static object *
3005get_item_from_body_location (object *start, int loc) 2811get_next_item_from_body_location (int loc, object *start)
3006{ 2812{
3007 object *tmp;
3008
3009 if (!start)
3010 return NULL;
3011
3012 for (tmp = start; tmp; tmp = tmp->below) 2813 for (object *tmp = start; tmp; tmp = tmp->below)
3013 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->body_info[loc] && (!tmp->invisible || tmp->type == SKILL)) 2814 if (tmp->flag [FLAG_APPLIED]
2815 && tmp->slot[loc].info
2816 && (!tmp->invisible || tmp->type == SKILL))
3014 return tmp; 2817 return tmp;
3015 2818
3016 return NULL; 2819 return 0;
3017} 2820}
3018
3019
3020 2821
3021/** 2822/**
3022 * 'op' wants to apply an object, but can't because of other equipment. 2823 * 'op' wants to apply an object, but can't because of other equipment.
3023 * This should only be called when it is known 2824 * This should only be called when it is known
3024 * that there are objects to unapply. This makes pretty heavy 2825 * that there are objects to unapply. This makes pretty heavy
… …
3027 * Returns 0 on success, returns 1 if there is some problem. 2828 * Returns 0 on success, returns 1 if there is some problem.
3028 * if aflags is AP_PRINT, we instead print out waht to unapply 2829 * if aflags is AP_PRINT, we instead print out waht to unapply
3029 * instead of doing it. This is a lot less code than having 2830 * instead of doing it. This is a lot less code than having
3030 * another function that does just that. 2831 * another function that does just that.
3031 */ 2832 */
2833
2834#define CANNOT_REMOVE_CURSED \
2835 "H<You cannot remove cursed or damned items, you first have to remove the curse. " \
2836 "Praying over an altar, scrolls of remove curse/damnation, " \
2837 "priests or even other players might help.>"
2838
3032int 2839int
3033unapply_for_ob (object *who, object *op, int aflags) 2840unapply_for_ob (object *who, object *op, int aflags)
3034{ 2841{
3035 int i; 2842 if (op->is_range ())
3036 object *tmp = NULL, *last;
3037
3038 /* If we are applying a shield or weapon, unapply any equipped shield
3039 * or weapons first - only allowed to use one weapon/shield at a time.
3040 */
3041 if (op->type == WEAPON || op->type == SHIELD)
3042 {
3043 for (tmp = who->inv; tmp; tmp = tmp->below) 2843 for (object *tmp = who->inv; tmp; tmp = tmp->below)
3044 {
3045 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2844 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->is_range ())
3046 {
3047 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED))) 2845 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!QUERY_FLAG (tmp, FLAG_CURSED) && !QUERY_FLAG (tmp, FLAG_DAMNED)))
3048 { 2846 {
3049 if (aflags & AP_PRINT) 2847 if (aflags & AP_PRINT)
3050 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2848 who->failmsg (query_name (tmp));
3051 else 2849 else
3052 unapply_special (who, tmp, aflags); 2850 unapply_special (who, tmp, aflags);
3053 } 2851 }
3054 else 2852 else
3055 { 2853 {
3056 /* In this case, we want to try and remove a cursed item. 2854 /* In this case, we want to try and remove a cursed item.
3057 * While we know it won't work, we want unapply_special to 2855 * While we know it won't work, we want unapply_special to
3058 * at least generate the message. 2856 * at least generate the message.
3059 */ 2857 */
3060 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (tmp)); 2858 who->failmsg (format ("No matter how hard you try, you just can't remove the %s." CANNOT_REMOVE_CURSED, query_name (tmp)));
3061 return 1; 2859 return 1;
3062 }
3063
3064 } 2860 }
3065 }
3066 }
3067 2861
3068 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 2862 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3069 { 2863 {
3070 /* this used up a slot that we need to free */ 2864 /* this used up a slot that we need to free */
3071 if (op->body_info[i]) 2865 if (op->slot[i].info)
3072 { 2866 {
3073 last = who->inv; 2867 object *last = who->inv;
3074 2868
3075 /* We do a while loop - may need to remove several items in order 2869 /* We do a while loop - may need to remove several items in order
3076 * to free up enough slots. 2870 * to free up enough slots.
3077 */ 2871 */
3078 while ((who->body_used[i] + op->body_info[i]) < 0) 2872 while ((who->slot[i].used + op->slot[i].info) < 0)
3079 { 2873 {
3080 tmp = get_item_from_body_location (last, i); 2874 object *tmp = get_next_item_from_body_location (i, last);
2875
3081 if (!tmp) 2876 if (!tmp)
3082 { 2877 {
3083#if 0 2878#if 0
3084 /* Not a bug - we'll get this if the player has cursed items 2879 /* Not a bug - we'll get this if the player has cursed items
3085 * equipped. 2880 * equipped.
3086 */ 2881 */
3087 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name); 2882 LOG (llevError, "Can't find object using location %d (%s) on %s\n", i, body_locations[i].save_name, who->name);
3088#endif 2883#endif
3089 return 1; 2884 return 1;
3090 } 2885 }
2886
3091 /* If we are just printing, we don't care about cursed status */ 2887 /* If we are just printing, we don't care about cursed status */
3092 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)))) 2888 if ((aflags & AP_IGNORE_CURSE) || (aflags & AP_PRINT) || (!(QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED))))
3093 { 2889 {
3094 if (aflags & AP_PRINT) 2890 if (aflags & AP_PRINT)
3095 new_draw_info (NDI_UNIQUE, 0, who, query_name (tmp)); 2891 who->failmsg (query_name (tmp));
3096 else 2892 else
3097 unapply_special (who, tmp, aflags); 2893 unapply_special (who, tmp, aflags);
3098 } 2894 }
3099 else 2895 else
3100 { 2896 {
3101 /* Cursed item that we can't unequip - tell the player. 2897 /* Cursed item that we can't unequip - tell the player.
3102 * Note this could be annoying if this is just one of a few, 2898 * Note this could be annoying if this is just one of a few,
3103 * so it may not be critical (eg, putting on a ring and you have 2899 * so it may not be critical (eg, putting on a ring and you have
3104 * one cursed ring.) 2900 * one cursed ring.)
3105 */ 2901 */
3106 new_draw_info_format (NDI_UNIQUE, 0, who, "The %s just won't come off", query_name (tmp)); 2902 who->failmsg (format ("The %s just won't come off." CANNOT_REMOVE_CURSED, query_name (tmp)));
3107 } 2903 }
2904
3108 last = tmp->below; 2905 last = tmp->below;
3109 } 2906 }
3110 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the 2907 /* if we got here, this slot is freed up - otherwise, if it wasn't freed up, the
3111 * return in the !tmp would have kicked in. 2908 * return in the !tmp would have kicked in.
3112 */ 2909 */
3113 } /* if op is using this body location */ 2910 } /* if op is using this body location */
3114 } /* for body lcoations */ 2911 } /* for body lcoations */
2912
3115 return 0; 2913 return 0;
3116} 2914}
3117 2915
3118/** 2916/**
3119 * Checks to see if 'who' can apply object 'op'. 2917 * Checks to see if 'who' can apply object 'op'.
3120 * Returns 0 if apply can be done without anything special. 2918 * Returns 0 if apply can be done without anything special.
3121 * Otherwise returns a bitmask - potentially several of these may be 2919 * Otherwise returns a bitmask - potentially several of these may be
3122 * set, but largely depends on circumstance - in the future, processing 2920 * set, but largely depends on circumstance - in the future, processing
3123 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER 2921 * may be pruned once we know some status (eg, once CAN_APPLY_NEVER
3124 * is set, do we really are what the other flags may be?) 2922 * is set, do we really care what the other flags may be?)
3125 * 2923 *
3126 * See include/define.h for detailed description of the meaning of 2924 * See include/define.h for detailed description of the meaning of
3127 * these return values. 2925 * these return values.
3128 */ 2926 */
3129int 2927int
3130can_apply_object (object *who, object *op) 2928can_apply_object (object *who, object *op)
3131{ 2929{
3132 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op))) 2930 if (INVOKE_OBJECT (CAN_BE_APPLIED, op, ARG_OBJECT (who)) || INVOKE_OBJECT (CAN_APPLY, who, ARG_OBJECT (op)))
3133 return RESULT_INT (0); 2931 return RESULT_INT (0);
3134 2932
3135 int i, retval = 0; 2933 int retval = 0;
3136 object *tmp = NULL, *ws = NULL; 2934 object *tmp = 0, *ws = 0;
3137 2935
3138 /* Players have 2 'arm's, so they could in theory equip 2 shields or 2936 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
3139 * 2 weapons, but we don't want to let them do that. So if they are
3140 * trying to equip a weapon or shield, see if they already have one
3141 * in place and store that way.
3142 */
3143 if (op->type == WEAPON || op->type == SHIELD)
3144 { 2937 {
3145 for (tmp = who->inv; tmp && !ws; tmp = tmp->below) 2938 if (op->slot[i].info)
3146 { 2939 {
3147 if (QUERY_FLAG (tmp, FLAG_APPLIED) && tmp->type == op->type) 2940 /* Item uses more slots than we have */
2941 if (who->slot[i].info + op->slot [i].info < 0)
3148 { 2942 {
3149 retval = CAN_APPLY_UNAPPLY;
3150 ws = tmp;
3151 }
3152 }
3153 }
3154
3155
3156 for (i = 0; i < NUM_BODY_LOCATIONS; i++)
3157 {
3158 if (op->body_info[i])
3159 {
3160 /* Item uses more slots than we have */
3161 if (FABS (op->body_info[i]) > who->body_info[i])
3162 {
3163 /* Could return now for efficiently - rest of info below isn' 2943 /* Could return now for efficiency - rest of info below isn't
3164 * really needed. 2944 * really needed.
3165 */ 2945 */
3166 retval |= CAN_APPLY_NEVER; 2946 retval |= CAN_APPLY_NEVER;
3167 } 2947 }
3168 else if ((who->body_used[i] + op->body_info[i]) < 0) 2948 else if (who->slot[i].used + op->slot[i].info < 0)
3169 { 2949 {
3170 /* in this case, equipping this would use more free spots than 2950 /* in this case, equipping this would use more free spots than
3171 * we have. 2951 * we have.
3172 */ 2952 */
3173 object *tmp1;
3174
3175 2953
3176 /* if we have an applied weapon/shield, and unapply it would free 2954 /* if we have an applied weapon/shield, and unapply it would free
3177 * enough slots to equip the new item, then just set this can 2955 * enough slots to equip the new item, then just set "can
3178 * continue. We don't care about the logic below - if you have 2956 * apply unapply". We don't care about the logic below - if you have a
3179 * shield equipped and try to equip another shield, there is only 2957 * shield equipped and try to equip another shield, there is only
3180 * one choice. However, the check for the number of body locations 2958 * one choice. However, the check for the number of body locations
3181 * does take into the account cases where what is being applied 2959 * does take into the account cases where what is being applied
3182 * may be two handed for example. 2960 * may be two handed for example.
3183 */ 2961 */
3184 if (ws) 2962 if (ws)
3185 { 2963 if ((who->slot[i].used - ws->slot[i].info + op->slot[i].info) >= 0)
3186 if ((who->body_used[i] - ws->body_info[i] + op->body_info[i]) >= 0)
3187 { 2964 {
3188 retval |= CAN_APPLY_UNAPPLY; 2965 retval |= CAN_APPLY_UNAPPLY;
3189 continue; 2966 continue;
3190 } 2967 }
3191 }
3192 2968
3193 tmp1 = get_item_from_body_location (who->inv, i); 2969 object *tmp1 = get_next_item_from_body_location (i, who->inv);
3194 if (!tmp1) 2970 if (!tmp1)
3195 { 2971 {
3196#if 0 2972#if 0
3197 /* This is sort of an error, but happens a lot when old players 2973 /* This is sort of an error, but happens a lot when old players
3198 * join in with more stuff equipped than they are now allowed. 2974 * join in with more stuff equipped than they are now allowed.
… …
3206 /* need to unapply something. However, if this something 2982 /* need to unapply something. However, if this something
3207 * is different than we had found before, it means they need 2983 * is different than we had found before, it means they need
3208 * to apply multiple objects 2984 * to apply multiple objects
3209 */ 2985 */
3210 retval |= CAN_APPLY_UNAPPLY; 2986 retval |= CAN_APPLY_UNAPPLY;
2987
3211 if (!tmp) 2988 if (!tmp)
3212 tmp = tmp1; 2989 tmp = tmp1;
3213 else if (tmp != tmp1) 2990 else if (tmp != tmp1)
3214 {
3215 retval |= CAN_APPLY_UNAPPLY_MULT; 2991 retval |= CAN_APPLY_UNAPPLY_MULT;
3216 } 2992
3217 /* This object isn't using up all the slots, so there must 2993 /* This object isn't using up all the slots, so there must
3218 * be another. If so, and it the new item doesn't need all 2994 * be another. If so, and it the new item doesn't need all
3219 * the slots, the player then has a choice. 2995 * the slots, the player then has a choice.
3220 */ 2996 */
3221 if (((who->body_used[i] - tmp1->body_info[i]) != who->body_info[i]) && (FABS (op->body_info[i]) < who->body_info[i])) 2997 if ((who->slot[i].used - tmp1->slot[i].info != who->slot[i].info)
2998 && abs (op->slot[i].info) < who->slot[i].info)
3222 retval |= CAN_APPLY_UNAPPLY_CHOICE; 2999 retval |= CAN_APPLY_UNAPPLY_CHOICE;
3223 3000
3224 /* Does unequippint 'tmp1' free up enough slots for this to be 3001 /* Does unequippint 'tmp1' free up enough slots for this to be
3225 * equipped? If not, there must be something else to unapply. 3002 * equipped? If not, there must be something else to unapply.
3226 */ 3003 */
3227 if ((who->body_used[i] + op->body_info[i] - tmp1->body_info[i]) < 0) 3004 if (who->slot[i].used + op->slot[i].info < tmp1->slot[i].info)
3228 retval |= CAN_APPLY_UNAPPLY_MULT; 3005 retval |= CAN_APPLY_UNAPPLY_MULT;
3229
3230 } 3006 }
3231 } /* if not enough free slots */ 3007 } /* if not enough free slots */
3232 } /* if this object uses location i */ 3008 } /* if this object uses location i */
3233 } /* for i -> num_body_locations loop */ 3009 } /* for i -> num_body_locations loop */
3234 3010
… …
3239 * and weapons all use the same slot. Similar for horn/rod/wand - they 3015 * and weapons all use the same slot. Similar for horn/rod/wand - they
3240 * all use the same location. 3016 * all use the same location.
3241 */ 3017 */
3242 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON)) 3018 if (op->type == WEAPON && !QUERY_FLAG (who, FLAG_USE_WEAPON))
3243 retval |= CAN_APPLY_RESTRICTION; 3019 retval |= CAN_APPLY_RESTRICTION;
3020
3244 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD)) 3021 if (op->type == SHIELD && !QUERY_FLAG (who, FLAG_USE_SHIELD))
3245 retval |= CAN_APPLY_RESTRICTION; 3022 retval |= CAN_APPLY_RESTRICTION;
3246 3023
3247
3248 if (who->type != PLAYER) 3024 if (who->type != PLAYER)
3249 { 3025 {
3250 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE)) 3026 if ((op->type == WAND || op->type == HORN || op->type == ROD) && !QUERY_FLAG (who, FLAG_USE_RANGE))
3251 retval |= CAN_APPLY_RESTRICTION; 3027 retval |= CAN_APPLY_RESTRICTION;
3028
3252 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3029 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3253 retval |= CAN_APPLY_RESTRICTION; 3030 retval |= CAN_APPLY_RESTRICTION;
3031
3254 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING)) 3032 if (op->type == RING && !QUERY_FLAG (who, FLAG_USE_RING))
3255 retval |= CAN_APPLY_RESTRICTION; 3033 retval |= CAN_APPLY_RESTRICTION;
3034
3256 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW)) 3035 if (op->type == BOW && !QUERY_FLAG (who, FLAG_USE_BOW))
3257 retval |= CAN_APPLY_RESTRICTION; 3036 retval |= CAN_APPLY_RESTRICTION;
3258 } 3037 }
3038
3259 return retval; 3039 return retval;
3260} 3040}
3261
3262
3263 3041
3264/** 3042/**
3265 * who is the object using the object. It can be a monster. 3043 * who is the object using the object. It can be a monster.
3266 * op is the object they are using. op is an equipment type item, 3044 * op is the object they are using. op is an equipment type item,
3267 * eg, one which you put on and keep on for a while, and not something 3045 * eg, one which you put on and keep on for a while, and not something
… …
3276 * AP_UNAPPLY=always unapply). 3054 * AP_UNAPPLY=always unapply).
3277 * 3055 *
3278 * Optional flags: 3056 * Optional flags:
3279 * AP_NO_MERGE: don't merge an unapplied object with other objects 3057 * AP_NO_MERGE: don't merge an unapplied object with other objects
3280 * AP_IGNORE_CURSE: unapply cursed items 3058 * AP_IGNORE_CURSE: unapply cursed items
3059 * AP_NO_READY: do not ready skills when applying skill tools
3281 * 3060 *
3282 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE) 3061 * Usage example: apply_special (who, op, AP_UNAPPLY | AP_IGNORE_CURSE)
3283 * 3062 *
3284 * apply_special() doesn't check for unpaid items. 3063 * apply_special() doesn't check for unpaid items.
3285 */ 3064 */
3065
3066#define LACK_ITEM_POWER \
3067 " H<You lack enough unused item power to use this weapon, see the skills command.>"
3068
3286int 3069int
3287apply_special (object *who, object *op, int aflags) 3070apply_special (object *who, object *op, int aflags)
3288{ 3071{
3289 int basic_flag = aflags & AP_BASIC_FLAGS; 3072 int basic_flag = aflags & AP_BASIC_FLAGS;
3290 object *tmp, *tmp2, *skop = NULL; 3073 object *tmp, *tmp2, *skop = NULL;
3291 int i;
3292 3074
3293 if (who == NULL) 3075 if (who == NULL)
3294 { 3076 {
3295 LOG (llevError, "apply_special() from object without environment.\n"); 3077 LOG (llevError, "apply_special() from object without environment.\n");
3296 return 1; 3078 return 1;
… …
3306 if (basic_flag == AP_APPLY) 3088 if (basic_flag == AP_APPLY)
3307 return 0; 3089 return 0;
3308 3090
3309 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))) 3091 if (!(aflags & AP_IGNORE_CURSE) && (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)))
3310 { 3092 {
3311 new_draw_info_format (NDI_UNIQUE, 0, who, "No matter how hard you try, you just can't\nremove %s.", query_name (op)); 3093 who->failmsg (format ("No matter how hard you try, you just can't remove %s." CANNOT_REMOVE_CURSED, query_name (op)));
3312 return 1; 3094 return 1;
3313 } 3095 }
3096
3314 return unapply_special (who, op, aflags); 3097 return unapply_special (who, op, aflags);
3315 } 3098 }
3316 3099
3317 if (basic_flag == AP_UNAPPLY) 3100 if (basic_flag == AP_UNAPPLY)
3318 return 0; 3101 return 0;
3319 3102
3320 i = can_apply_object (who, op); 3103 // if the item is combat/ranged, wield the relevant slot first
3104 // to resolve conflicts.
3105 if (player *pl = who->contr)
3106 switch (op->slottype ())
3107 {
3108 case slot_combat: who->change_weapon (pl->combat_ob); break;
3109 case slot_ranged: who->change_weapon (pl->ranged_ob); break;
3110 }
3111
3112 splay (op);
3321 3113
3322 /* Can't just apply this object. Lets see what not and what to do */ 3114 /* Can't just apply this object. Lets see what not and what to do */
3323 if (i) 3115 if (int i = can_apply_object (who, op))
3324 { 3116 {
3325 if (i & CAN_APPLY_NEVER) 3117 if (i & CAN_APPLY_NEVER)
3326 { 3118 {
3327 new_draw_info_format (NDI_UNIQUE, 0, who, "You don't have the body to use a %s\n", query_name (op)); 3119 who->failmsg (format ("You don't have the body to use a %s. H<You can never apply this item.>", query_name (op)));
3328 return 1; 3120 return 1;
3329 } 3121 }
3330 else if (i & CAN_APPLY_RESTRICTION) 3122 else if (i & CAN_APPLY_RESTRICTION)
3331 { 3123 {
3332 new_draw_info_format (NDI_UNIQUE, 0, who, "You have a prohibition against using a %s\n", query_name (op)); 3124 who->failmsg (format (
3125 "You have a prohibition against using a %s. "
3126 "H<Your belief, profession or class prevents you from applying this item.>",
3127 query_name (op)
3128 ));
3333 return 1; 3129 return 1;
3334 } 3130 }
3131
3335 if (who->type != PLAYER) 3132 if (who->type != PLAYER)
3336 { 3133 {
3337 /* Some error, so don't try to equip something more */ 3134 /* Some error, so don't try to equip something more */
3338 if (unapply_for_ob (who, op, aflags)) 3135 if (unapply_for_ob (who, op, aflags))
3339 return 1; 3136 return 1;
3340 } 3137 }
3341 else 3138 else
3342 { 3139 {
3343 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice)) 3140 if (who->contr->unapply == unapply_never || (i & CAN_APPLY_UNAPPLY_CHOICE && who->contr->unapply == unapply_nochoice))
3344 { 3141 {
3345 new_draw_info (NDI_UNIQUE, 0, who, "You need to unapply some of the following item(s) or change your applymode:"); 3142 who->failmsg ("You need to unapply some of the following item(s) or change your applymode:");
3346 unapply_for_ob (who, op, AP_PRINT); 3143 unapply_for_ob (who, op, AP_PRINT);
3347 return 1; 3144 return 1;
3348 } 3145 }
3349 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE)) 3146 else if (who->contr->unapply == unapply_always || !(i & CAN_APPLY_UNAPPLY_CHOICE))
3350 {
3351 i = unapply_for_ob (who, op, aflags); 3147 if (unapply_for_ob (who, op, aflags))
3352 if (i)
3353 return 1; 3148 return 1;
3354 }
3355 } 3149 }
3356 } 3150 }
3357 3151
3358 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL) 3152 if (op->skill && op->type != SKILL && op->type != SKILL_TOOL)
3359 { 3153 {
3360 skop = find_skill_by_name (who, op->skill); 3154 skop = find_skill_by_name (who, op->skill);
3155
3361 if (!skop) 3156 if (!skop)
3362 { 3157 {
3363 new_draw_info_format (NDI_UNIQUE, 0, who, "You need the %s skill to use this item!", &op->skill); 3158 who->failmsg (format ("You need the %s skill to use this item!", &op->skill));
3364 return 1; 3159 return 1;
3365 } 3160 }
3366 else 3161 else
3367 {
3368 /* While experience will be credited properly, we want to change the 3162 /* While experience will be credited properly, we want to change the
3369 * skill so that the dam and wc get updated 3163 * skill so that the dam and wc get updated
3370 */ 3164 */
3371 change_skill (who, skop, 0); 3165 who->change_skill (skop);
3372 }
3373 }
3374
3375 if (who->type == PLAYER && op->item_power && (op->item_power + who->contr->item_power) > (settings.item_power_factor * who->level))
3376 { 3166 }
3377 new_draw_info (NDI_UNIQUE, 0, who, "Equipping that combined with other items would consume your soul!"); 3167
3168 if (who->type == PLAYER
3169 && op->item_power
3170 && op->item_power + who->contr->item_power > settings.item_power_factor * who->level)
3171 {
3172 who->failmsg ("Equipping that combined with other items would consume your soul!" LACK_ITEM_POWER);
3378 return 1; 3173 return 1;
3379 } 3174 }
3380
3381 3175
3382 /* Ok. We are now at the state where we can apply the new object. 3176 /* Ok. We are now at the state where we can apply the new object.
3383 * Note that we don't have the checks for can_use_... 3177 * Note that we don't have the checks for can_use_...
3384 * below - that is already taken care of by can_apply_object. 3178 * below - that is already taken care of by can_apply_object.
3385 */ 3179 */
3386 3180 tmp = op->nrof > 1 ? op->split (op->nrof - 1) : 0;
3387
3388 if (op->nrof > 1)
3389 tmp = get_split_ob (op, op->nrof - 1);
3390 else
3391 tmp = NULL;
3392 3181
3393 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op))) 3182 if (INVOKE_OBJECT (BE_READY, op, ARG_OBJECT (who)) || INVOKE_OBJECT (READY, who, ARG_OBJECT (op)))
3394 return RESULT_INT (0); 3183 return RESULT_INT (0);
3395 3184
3396 switch (op->type) 3185 switch (op->type)
3397 { 3186 {
3398 case WEAPON: 3187 case WEAPON:
3399 if (!check_weapon_power (who, op->last_eat)) 3188 if (!check_weapon_power (who, op->last_eat))
3400 { 3189 {
3401 new_draw_info (NDI_UNIQUE, 0, who, "That weapon is too powerful for you to use."); 3190 op->failmsg ("This weapon is too powerful for you to use. It would consume your soul!." LACK_ITEM_POWER);
3402 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3191
3403 if (tmp != NULL) 3192 if (tmp)
3404 (void) insert_ob_in_ob (tmp, who); 3193 insert_ob_in_ob (tmp, who);
3194
3405 return 1; 3195 return 1;
3406 } 3196 }
3197
3198 //TODO: this obviously fails for players using a shorter prefix
3199 // i.e. "R" can use Ragnarok's sword.
3407 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3200 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3408 { 3201 {
3409 /* if the weapon does not have the name as the character, can't use it. */ 3202 /* if the weapon does not have the name as the character, can't use it. */
3410 /* (Ragnarok's sword attempted to be used by Foo: won't work) */ 3203 /* (Ragnarok's sword attempted to be used by Foo: won't work) */
3411 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3204 who->failmsg ("The weapon does not recognize you as its owner. H<Its name indicates that it belongs to somebody else.>");
3205
3412 if (tmp != NULL) 3206 if (tmp)
3413 (void) insert_ob_in_ob (tmp, who); 3207 insert_ob_in_ob (tmp, who);
3208
3414 return 1; 3209 return 1;
3415 } 3210 }
3211
3212 if (!skop)
3213 {
3214 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3215 return 1;
3216 }
3217
3416 SET_FLAG (op, FLAG_APPLIED); 3218 SET_FLAG (op, FLAG_APPLIED);
3417
3418 if (skop)
3419 change_skill (who, skop, 1); 3219 who->change_skill (skop);
3420 if (!QUERY_FLAG (who, FLAG_READY_WEAPON)) 3220
3221 if (who->contr)
3222 who->change_weapon (who->contr->combat_ob = op);
3223
3224 who->statusmsg (format ("You wield %s.", query_name (op)));
3225
3421 SET_FLAG (who, FLAG_READY_WEAPON); 3226 SET_FLAG (who, FLAG_READY_WEAPON);
3422
3423 new_draw_info_format (NDI_UNIQUE, 0, who, "You wield %s.", query_name (op));
3424
3425 (void) change_abil (who, op); 3227 change_abil (who, op);
3426 break; 3228 break;
3427 3229
3428 case ARMOUR: 3230 case ARMOUR:
3429 case HELMET: 3231 case HELMET:
3430 case SHIELD: 3232 case SHIELD:
… …
3434 case BRACERS: 3236 case BRACERS:
3435 case CLOAK: 3237 case CLOAK:
3436 case RING: 3238 case RING:
3437 case AMULET: 3239 case AMULET:
3438 SET_FLAG (op, FLAG_APPLIED); 3240 SET_FLAG (op, FLAG_APPLIED);
3439 new_draw_info_format (NDI_UNIQUE, 0, who, "You wear %s.", query_name (op)); 3241 who->statusmsg (format ("You wear %s.", query_name (op)));
3440 (void) change_abil (who, op); 3242 change_abil (who, op);
3441 break; 3243 break;
3244
3442 case LAMP: 3245 case LAMP:
3443 if (op->stats.food < 1) 3246 if (op->stats.food < 1)
3444 { 3247 {
3445 new_draw_info_format (NDI_UNIQUE, 0, who, "Your %s is out of" " fuel!", &op->name); 3248 who->failmsg (format (
3249 "Your %s is out of fuel! "
3250 "H<Lamps and similar items need fuel. They cannot be refilled.>",
3251 &op->name
3252 ));
3446 return 1; 3253 return 1;
3447 } 3254 }
3448 new_draw_info_format (NDI_UNIQUE, 0, who, "You turn on your %s.", &op->name); 3255
3256 who->statusmsg (format ("You turn on your %s.", &op->name));
3257
3449 tmp2 = arch_to_object (op->other_arch); 3258 tmp2 = arch_to_object (op->other_arch);
3450 tmp2->stats.food = op->stats.food; 3259 tmp2->stats.food = op->stats.food;
3451 SET_FLAG (tmp2, FLAG_APPLIED); 3260 SET_FLAG (tmp2, FLAG_APPLIED);
3261
3452 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 3262 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
3453 SET_FLAG (tmp2, FLAG_INV_LOCKED); 3263 SET_FLAG (tmp2, FLAG_INV_LOCKED);
3454 insert_ob_in_ob (tmp2, who); 3264
3265 who->insert (tmp2);
3455 3266
3456 /* Remove the old lantern */ 3267 /* Remove the old lantern */
3457 if (who->type == PLAYER)
3458 esrv_del_item (who->contr, op->count);
3459
3460 op->destroy (); 3268 op->destroy ();
3461 3269
3462 /* insert the portion that was split off */ 3270 /* insert the portion that was split off */
3463 if (tmp != NULL) 3271 if (tmp)
3272 who->insert (tmp);
3273
3274 who->update_stats ();
3275
3276 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3277 if (who->type == PLAYER)
3278 {
3279 who->failmsg ("Oops, it feels deadly cold! H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>");
3280 SET_FLAG (tmp2, FLAG_KNOWN_CURSED);
3281 }
3282
3283 return 0;
3284
3285 case SKILL_TOOL:
3286 // applying a skill tool also readies the skill
3287 SET_FLAG (op, FLAG_APPLIED);
3288
3289 if (!(aflags & AP_NO_READY))
3464 { 3290 {
3465 (void) insert_ob_in_ob (tmp, who); 3291 skop = find_skill_by_name (who, op->skill);
3466 if (who->type == PLAYER) 3292 if (!skop->flag [FLAG_APPLIED])
3467 esrv_send_item (who, tmp); 3293 apply_special (who, skop, AP_APPLY);
3468 } 3294 }
3469 who->update_stats (); 3295 break;
3470 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3296
3297 case SKILL:
3298 if (player *pl = who->contr)
3471 { 3299 {
3472 if (who->type == PLAYER) 3300 if (IS_COMBAT_SKILL (op->subtype))
3473 { 3301 {
3474 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3302 if (skill_flags [op->subtype] & SF_NEED_WEAPON)
3475 SET_FLAG (tmp2, FLAG_KNOWN_CURSED); 3303 {
3304 for (object *item = who->inv; item; item = item->below)
3305 if (item->type == WEAPON && item->flag [FLAG_APPLIED])
3306 {
3307 if (item->skill == op->skill)
3308 {
3309 who->change_weapon (pl->combat_ob = item);
3310 goto found_weapon;
3311 }
3312 }
3313
3314 who->failmsg (format (
3315 "You need to apply a '%s' melee weapon before readying this skill. "
3316 "H<Some skills need an item, in this case a melee weapon, to function.>",
3317 &op->skill
3318 ));
3319 return 1;
3320
3321 found_weapon:;
3322 }
3323 else
3324 who->change_weapon (pl->combat_ob = op);
3476 } 3325 }
3477 } 3326 else if (IS_RANGED_SKILL (op->subtype))
3478 if (who->type == PLAYER)
3479 esrv_send_item (who, tmp2);
3480 return 0;
3481 break;
3482
3483 /* this part is needed for skill-tools */
3484 case SKILL:
3485 case SKILL_TOOL:
3486 if (who->chosen_skill)
3487 { 3327 {
3488 LOG (llevError, "BUG: apply_special(): can't apply two skills\n"); 3328 if (skill_flags [op->subtype] & SF_NEED_BOW)
3329 {
3330 for (object *item = who->inv; item; item = item->below)
3331 if (item->type == BOW && item->flag [FLAG_APPLIED])
3332 {
3333 //TODO: bows should/must all have skill missile weapon right now
3334 who->change_weapon (pl->ranged_ob = item);
3335 goto found_bow;
3336 }
3337
3338 who->failmsg (
3339 "You need to apply a missile weapon before readying this skill. "
3340 "H<Some skills need an item, in this case a missile weapon, to function.>"
3341 );
3489 return 1; 3342 return 1;
3343
3344 found_bow:;
3345 }
3346 else
3347 who->change_weapon (pl->ranged_ob = op);
3490 } 3348 }
3491 if (who->type == PLAYER) 3349
3492 {
3493 who->contr->shoottype = range_skill;
3494 who->contr->ranges[range_skill] = op;
3495 if (!op->invisible) 3350 if (!op->invisible)
3496 { 3351 {
3497 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op)); 3352 who->statusmsg (format (
3498 new_draw_info_format (NDI_UNIQUE, 0, who, "You can now use the skill: %s.", &op->skill); 3353 "You ready %s."
3354 "You can now use the skill: %s.",
3355 query_name (op),
3356 &op->skill
3357 ));
3499 } 3358 }
3500 else 3359 else
3501 {
3502 new_draw_info_format (NDI_UNIQUE, 0, who, "Readied skill: %s.", op->skill ? &op->skill : &op->name); 3360 who->statusmsg (format ("Readied skill: %s.", op->skill ? &op->skill : &op->name));
3503 }
3504 } 3361 }
3362 else
3363 {
3505 SET_FLAG (op, FLAG_APPLIED); 3364 SET_FLAG (op, FLAG_APPLIED);
3506 (void) change_abil (who, op); 3365 change_abil (who, op);
3507 who->chosen_skill = op; 3366 who->chosen_skill = op;
3508 SET_FLAG (who, FLAG_READY_SKILL); 3367 SET_FLAG (who, FLAG_READY_SKILL);
3368 }
3369
3509 break; 3370 break;
3510 3371
3511 case BOW: 3372 case BOW:
3512 if (!check_weapon_power (who, op->last_eat)) 3373 if (!check_weapon_power (who, op->last_eat))
3513 { 3374 {
3514 new_draw_info (NDI_UNIQUE, 0, who, "That item is too powerful for you to use."); 3375 who->failmsg ("That weapon is too powerful for you to use. It would consume your soul!" LACK_ITEM_POWER);
3515 new_draw_info (NDI_UNIQUE, 0, who, "It would consume your soul!."); 3376
3516 if (tmp != NULL) 3377 if (tmp)
3517 (void) insert_ob_in_ob (tmp, who); 3378 insert_ob_in_ob (tmp, who);
3379
3518 return 1; 3380 return 1;
3519 } 3381 }
3382
3520 if (op->level && (strncmp (op->name, who->name, strlen (who->name)))) 3383 if (op->level && (strncmp (op->name, who->name, strlen (who->name))))
3521 { 3384 {
3522 new_draw_info (NDI_UNIQUE, 0, who, "The weapon does not recognize you as its owner."); 3385 who->failmsg ("The weapon does not recognize you as its owner. "
3386 "H<Its name indicates that it belongs to somebody else.>");
3523 if (tmp != NULL) 3387 if (tmp)
3524 (void) insert_ob_in_ob (tmp, who); 3388 insert_ob_in_ob (tmp, who);
3389
3525 return 1; 3390 return 1;
3526 } 3391 }
3392
3527 /*FALLTHROUGH*/ case WAND: 3393 /*FALLTHROUGH*/
3394 case WAND:
3528 case ROD: 3395 case ROD:
3529 case HORN: 3396 case HORN:
3530 /* check for skill, alter player status */ 3397 /* check for skill, alter player status */
3398
3399 if (!skop)
3400 {
3401 who->failmsg (format ("The %s is broken, please report this to the dungeon master!", query_name (op)));//TODO
3402 return 1;
3403 }
3404
3531 SET_FLAG (op, FLAG_APPLIED); 3405 SET_FLAG (op, FLAG_APPLIED);
3532 if (skop)
3533 change_skill (who, skop, 0); 3406 who->change_skill (skop);
3534 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready %s.", query_name (op));
3535 3407
3536 if (who->type == PLAYER) 3408 if (who->contr)
3537 { 3409 {
3410 who->contr->ranged_ob = op;
3411
3412 who->statusmsg (format ("You ready %s.", query_name (op)));
3413
3538 if (op->type == BOW) 3414 if (op->type == BOW)
3539 { 3415 {
3416 who->current_weapon = op;
3540 (void) change_abil (who, op); 3417 change_abil (who, op);
3541 new_draw_info_format (NDI_UNIQUE, 0, who,
3542 "You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)); 3418 who->statusmsg (format ("You will now fire %s with %s.", op->race ? &op->race : "nothing", query_name (op)));
3543 who->contr->shoottype = range_bow;
3544 }
3545 else
3546 {
3547 who->contr->shoottype = range_misc;
3548 } 3419 }
3549 } 3420 }
3550 else 3421 else
3551 { 3422 {
3552 if (op->type == BOW) 3423 if (op->type == BOW)
3553 SET_FLAG (who, FLAG_READY_BOW); 3424 SET_FLAG (who, FLAG_READY_BOW);
3554 else 3425 else
3555 SET_FLAG (who, FLAG_READY_RANGE); 3426 SET_FLAG (who, FLAG_READY_RANGE);
3556 } 3427 }
3428
3557 break; 3429 break;
3558 3430
3559 case BUILDER: 3431 case BUILDER:
3560 if (who->contr->ranges[range_builder]) 3432 if (who->type == PLAYER)
3433 {
3434 //TODO: wtf does this do? shouldn't this be managed automatically (slots?)
3435 if (who->contr->ranged_ob && who->contr->ranged_ob->type == BUILDER)
3561 unapply_special (who, who->contr->ranges[range_builder], 0); 3436 unapply_special (who, who->contr->ranged_ob, 0);
3562 who->contr->shoottype = range_builder; 3437
3438 who->statusmsg (format ("You ready your %s.", query_name (op)));
3439
3563 who->contr->ranges[range_builder] = op; 3440 who->contr->ranged_ob = op;
3564 new_draw_info_format (NDI_UNIQUE, 0, who, "You ready your %s.", query_name (op)); 3441 }
3565 break; 3442 break;
3566 3443
3567 default: 3444 default:
3568 new_draw_info_format (NDI_UNIQUE, 0, who, "You apply %s.", query_name (op)); 3445 who->statusmsg (format ("You apply %s.", query_name (op)));
3569 } /* end of switch op->type */ 3446 }
3570 3447
3571 SET_FLAG (op, FLAG_APPLIED); 3448 SET_FLAG (op, FLAG_APPLIED);
3572 3449
3573 if (tmp != NULL) 3450 if (tmp)
3574 tmp = insert_ob_in_ob (tmp, who); 3451 who->insert (tmp);
3575 3452
3576 who->update_stats (); 3453 who->update_stats ();
3577 3454
3578 /* We exclude spell casting objects. The fire code will set the 3455 /* We exclude spell casting objects. The fire code will set the
3579 * been applied flag when they are used - until that point, 3456 * been applied flag when they are used - until that point,
… …
3581 */ 3458 */
3582 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD) 3459 if (who->type == PLAYER && op->type != WAND && op->type != HORN && op->type != ROD)
3583 SET_FLAG (op, FLAG_BEEN_APPLIED); 3460 SET_FLAG (op, FLAG_BEEN_APPLIED);
3584 3461
3585 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED)) 3462 if (QUERY_FLAG (op, FLAG_CURSED) || QUERY_FLAG (op, FLAG_DAMNED))
3586 {
3587 if (who->type == PLAYER) 3463 if (who->type == PLAYER)
3588 { 3464 {
3589 new_draw_info (NDI_UNIQUE, 0, who, "Oops, it feels deadly cold!"); 3465 who->failmsg (
3466 "Oops, it feels deadly cold! "
3467 "H<Maybe it wasn't such a bright idea to apply this cursed/damned item.>"
3468 );
3590 SET_FLAG (op, FLAG_KNOWN_CURSED); 3469 SET_FLAG (op, FLAG_KNOWN_CURSED);
3591 } 3470 }
3592 } 3471
3593 if (who->type == PLAYER) 3472 if (object *pl = op->visible_to ())
3594 {
3595 /* if multiple objects were applied, update both slots */
3596 if (tmp)
3597 esrv_send_item (who, tmp);
3598 esrv_send_item (who, op); 3473 esrv_send_item (pl, op);
3599 } 3474
3600 return 0; 3475 return 0;
3601} 3476}
3602
3603 3477
3604int 3478int
3605monster_apply_special (object *who, object *op, int aflags) 3479monster_apply_special (object *who, object *op, int aflags)
3606{ 3480{
3607 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED)) 3481 if (QUERY_FLAG (op, FLAG_UNPAID) && !QUERY_FLAG (op, FLAG_APPLIED))
3608 return 1; 3482 return 1;
3483
3609 return apply_special (who, op, aflags); 3484 return apply_special (who, op, aflags);
3610} 3485}
3611 3486
3612/** 3487/**
3613 * Map was just loaded, handle op's initialisation. 3488 * Map was just loaded, handle op's initialisation.
… …
3651 3526
3652 case TREASURE: 3527 case TREASURE:
3653 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 3528 if (QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
3654 return 0; 3529 return 0;
3655 3530
3656 while ((op->stats.hp--) > 0) 3531 while (op->stats.hp-- > 0)
3657 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0, 3532 create_treasure (op->randomitems, op, op->map ? GT_ENVIRONMENT : 0,
3658 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0); 3533 op->stats.exp ? (int) op->stats.exp : op->map == NULL ? 14 : op->map->difficulty, 0);
3659 3534
3660 /* If we generated an object and put it in this object inventory, 3535 /* If we generated an object and put it in this object inventory,
3661 * move it to the parent object as the current object is about 3536 * move it to the parent object as the current object is about
… …
3678 } 3553 }
3679 return tmp ? 1 : 0; 3554 return tmp ? 1 : 0;
3680} 3555}
3681 3556
3682/** 3557/**
3683 * fix_auto_apply goes through the entire map (only the first time 3558 * fix_auto_apply goes through the entire map every time a map
3684 * when an original map is loaded) and performs special actions for 3559 * is loaded or swapped in and performs special actions for
3685 * certain objects (most initialization of chests and creation of 3560 * certain objects (most initialization of chests and creation of
3686 * treasures and stuff). Calls auto_apply if appropriate. 3561 * treasures and stuff). Calls auto_apply if appropriate.
3687 */ 3562 */
3688void 3563void
3689maptile::fix_auto_apply () 3564maptile::fix_auto_apply ()
… …
3767 { 3642 {
3768 create_treasure (tmp->randomitems, tmp, GT_APPLY, difficulty, 0); 3643 create_treasure (tmp->randomitems, tmp, GT_APPLY, difficulty, 0);
3769 tmp->randomitems = NULL; 3644 tmp->randomitems = NULL;
3770 } 3645 }
3771 3646
3647 // close all containers
3648 else if (tmp->type == CONTAINER)
3649 tmp->flag [FLAG_APPLIED] = 0;
3650
3772 tmp = above; 3651 tmp = above;
3773 } 3652 }
3774 3653
3775 for (mapspace *ms = spaces + size (); ms-- > spaces; ) 3654 for (mapspace *ms = spaces + size (); ms-- > spaces; )
3776 for (object *tmp = ms->bot; tmp; tmp = tmp->above) 3655 for (object *tmp = ms->bot; tmp; tmp = tmp->above)
… …
3782 * Handles player eating food that temporarily changes status (resistances, stats). 3661 * Handles player eating food that temporarily changes status (resistances, stats).
3783 * This used to call cast_change_attr(), but 3662 * This used to call cast_change_attr(), but
3784 * that doesn't work with the new spell code. Since we know what 3663 * that doesn't work with the new spell code. Since we know what
3785 * the food changes, just grab a force and use that instead. 3664 * the food changes, just grab a force and use that instead.
3786 */ 3665 */
3787
3788void 3666void
3789eat_special_food (object *who, object *food) 3667eat_special_food (object *who, object *food)
3790{ 3668{
3791 object *force; 3669 object *force;
3792 int i, did_one = 0; 3670 int i, did_one = 0;
3793 sint8 k;
3794 3671
3795 force = get_archetype (FORCE_NAME); 3672 force = get_archetype (FORCE_NAME);
3796 3673
3797 for (i = 0; i < NUM_STATS; i++) 3674 for (i = 0; i < NUM_STATS; i++)
3798 { 3675 if (sint8 k = food->stats.stat (i))
3799 k = get_attr_value (&food->stats, i);
3800 if (k)
3801 { 3676 {
3802 set_attr_value (&force->stats, i, k); 3677 force->stats.stat (i) = k;
3803 did_one = 1; 3678 did_one = 1;
3804 } 3679 }
3805 }
3806 3680
3807 /* check if we can protect the eater */ 3681 /* check if we can protect the eater */
3808 for (i = 0; i < NROFATTACKS; i++) 3682 for (i = 0; i < NROFATTACKS; i++)
3809 { 3683 {
3810 if (food->resist[i] > 0) 3684 if (food->resist[i] > 0)
… …
3829 /* check for hp, sp change */ 3703 /* check for hp, sp change */
3830 if (food->stats.hp != 0) 3704 if (food->stats.hp != 0)
3831 { 3705 {
3832 if (QUERY_FLAG (food, FLAG_CURSED)) 3706 if (QUERY_FLAG (food, FLAG_CURSED))
3833 { 3707 {
3834 strcpy (who->contr->killer, food->name); 3708 who->contr->killer = food;
3835 hit_player (who, food->stats.hp, food, AT_POISON, 1); 3709 hit_player (who, food->stats.hp, food, AT_POISON, 1);
3836 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3710 who->failmsg ("Eck!...that was poisonous!");
3837 } 3711 }
3838 else 3712 else
3839 { 3713 {
3840 if (food->stats.hp > 0) 3714 if (food->stats.hp > 0)
3841 new_draw_info (NDI_UNIQUE, 0, who, "You begin to feel better."); 3715 who->statusmsg ("You begin to feel better.");
3842 else 3716 else
3843 new_draw_info (NDI_UNIQUE, 0, who, "Eck!...that was poisonous!"); 3717 who->failmsg ("Eck!...that was poisonous!");
3718
3844 who->stats.hp += food->stats.hp; 3719 who->stats.hp += food->stats.hp;
3845 } 3720 }
3846 } 3721 }
3722
3847 if (food->stats.sp != 0) 3723 if (food->stats.sp != 0)
3848 { 3724 {
3849 if (QUERY_FLAG (food, FLAG_CURSED)) 3725 if (QUERY_FLAG (food, FLAG_CURSED))
3850 { 3726 {
3851 new_draw_info (NDI_UNIQUE, 0, who, "You are drained of mana!"); 3727 who->failmsg ("You are drained of mana!");
3852 who->stats.sp -= food->stats.sp; 3728 who->stats.sp -= food->stats.sp;
3853 if (who->stats.sp < 0) 3729 if (who->stats.sp < 0)
3854 who->stats.sp = 0; 3730 who->stats.sp = 0;
3855 } 3731 }
3856 else 3732 else
3857 { 3733 {
3858 new_draw_info (NDI_UNIQUE, 0, who, "You feel a rush of magical energy!"); 3734 who->statusmsg ("You feel a rush of magical energy!");
3859 who->stats.sp += food->stats.sp; 3735 who->stats.sp += food->stats.sp;
3860 /* place limit on max sp from food? */ 3736 /* place limit on max sp from food? */
3861 } 3737 }
3862 } 3738 }
3739
3863 who->update_stats (); 3740 who->update_stats ();
3864} 3741}
3865 3742
3866/** 3743/**
3867 * Designed primarily to light torches/lanterns/etc. 3744 * Designed primarily to light torches/lanterns/etc.
… …
3877 item = find_marked_object (who); 3754 item = find_marked_object (who);
3878 if (item) 3755 if (item)
3879 { 3756 {
3880 if (lighter->last_eat && lighter->stats.food) 3757 if (lighter->last_eat && lighter->stats.food)
3881 { /* lighter gets used up */ 3758 { /* lighter gets used up */
3882 /* Split multiple lighters if they're being used up. Otherwise *
3883 * one charge from each would be used up. --DAMN */
3884 if (lighter->nrof > 1)
3885 {
3886 object *oneLighter = lighter->clone (); 3759 object *oneLighter = lighter->split ();
3887
3888 lighter->nrof -= 1;
3889 oneLighter->nrof = 1;
3890 oneLighter->stats.food--; 3760 oneLighter->stats.food--;
3891 esrv_send_item (who, lighter); 3761 who->insert (oneLighter);
3892 oneLighter = insert_ob_in_ob (oneLighter, who);
3893 esrv_send_item (who, oneLighter);
3894 }
3895 else
3896 lighter->stats.food--;
3897 } 3762 }
3898 else if (lighter->last_eat) 3763 else if (lighter->last_eat)
3764 {
3899 { /* no charges left in lighter */ 3765 /* no charges left in lighter */
3900 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with a used up %s.", &item->name, &lighter->name); 3766 who->failmsg (format ("You attempt to light the %s with a used up %s.", &item->name, &lighter->name));
3901 return; 3767 return;
3902 } 3768 }
3903 3769
3904 /* Perhaps we should split what we are trying to light on fire? 3770 /* Perhaps we should split what we are trying to light on fire?
3905 * I can't see many times when you would want to light multiple 3771 * I can't see many times when you would want to light multiple
… …
3911 3777
3912 save_throw_object (item, AT_FIRE, who); 3778 save_throw_object (item, AT_FIRE, who);
3913 3779
3914 if (item->destroyed ()) 3780 if (item->destroyed ())
3915 { 3781 {
3916 new_draw_info_format (NDI_UNIQUE, 0, who, "You light the %s with the %s.", &item->name, &lighter->name); 3782 who->statusmsg (format ("You light the %s with the %s.", &item->name, &lighter->name));
3917 /* Need to update the player so that the players glow radius 3783 /* Need to update the player so that the players glow radius
3918 * gets changed. 3784 * gets changed.
3919 */ 3785 */
3920 if (is_player_env) 3786 if (is_player_env)
3921 who->update_stats (); 3787 who->update_stats ();
3922 } 3788 }
3923 else 3789 else
3924 new_draw_info_format (NDI_UNIQUE, 0, who, "You attempt to light the %s with the %s and fail.", &item->name, &lighter->name); 3790 who->failmsg (format ("You attempt to light the %s with the %s and fail.", &item->name, &lighter->name));
3925 } 3791 }
3926 else /* nothing to light */ 3792 else
3927 new_draw_info (NDI_UNIQUE, 0, who, "You need to mark a lightable object."); 3793 who->failmsg ("You need to mark a lightable object.");
3928
3929} 3794}
3930 3795
3931/** 3796/**
3932 * op made some mistake with a scroll, this takes care of punishment. 3797 * op made some mistake with a scroll, this takes care of punishment.
3933 * scroll_failure()- hacked directly from spell_failure 3798 * scroll_failure()- hacked directly from spell_failure
… …
3940 3805
3941 if (failure <= -1 && failure > -15) 3806 if (failure <= -1 && failure > -15)
3942 { /* wonder */ 3807 { /* wonder */
3943 object *tmp; 3808 object *tmp;
3944 3809
3945 new_draw_info (NDI_UNIQUE, 0, op, "Your spell warps!."); 3810 op->failmsg ("Your spell warps!");
3946 tmp = get_archetype (SPELL_WONDER); 3811 tmp = get_archetype (SPELL_WONDER);
3947 cast_wonder (op, op, 0, tmp); 3812 cast_wonder (op, op, 0, tmp);
3948 tmp->destroy (); 3813 tmp->destroy ();
3949 } 3814 }
3950 else if (failure <= -15 && failure > -35) 3815 else if (failure <= -15 && failure > -35)
3951 { /* drain mana */ 3816 { /* drain mana */
3952 new_draw_info (NDI_UNIQUE, 0, op, "Your mana is drained!."); 3817 op->failmsg ("Your mana is drained!");
3953 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW); 3818 op->stats.sp -= random_roll (0, power - 1, op, PREFER_LOW);
3954 if (op->stats.sp < 0) 3819 if (op->stats.sp < 0)
3955 op->stats.sp = 0; 3820 op->stats.sp = 0;
3956 } 3821 }
3957 else if (settings.spell_failure_effects == TRUE) 3822 else if (settings.spell_failure_effects == TRUE)
3958 { 3823 {
3959 if (failure <= -35 && failure > -60) 3824 if (failure <= -35 && failure > -60)
3960 { /* confusion */ 3825 { /* confusion */
3961 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3826 op->failmsg ("The magic recoils on you!");
3962 confuse_player (op, op, power); 3827 confuse_player (op, op, power);
3963 } 3828 }
3964 else if (failure <= -60 && failure > -70) 3829 else if (failure <= -60 && failure > -70)
3965 { /* paralysis */ 3830 { /* paralysis */
3966 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils and paralyzes " "you!"); 3831 op->failmsg ("The magic recoils and paralyzes you!");
3967 paralyze_player (op, op, power); 3832 paralyze_player (op, op, power);
3968 } 3833 }
3969 else if (failure <= -70 && failure > -80) 3834 else if (failure <= -70 && failure > -80)
3970 { /* blind */ 3835 { /* blind */
3971 new_draw_info (NDI_UNIQUE, 0, op, "The magic recoils on you!"); 3836 op->failmsg ("The magic recoils on you!");
3972 blind_player (op, op, power); 3837 blind_player (op, op, power);
3973 } 3838 }
3974 else if (failure <= -80) 3839 else if (failure <= -80)
3975 { /* blast the immediate area */ 3840 { /* blast the immediate area */
3976 object *tmp;
3977
3978 tmp = get_archetype (LOOSE_MANA); 3841 object *tmp = get_archetype (LOOSE_MANA);
3979 cast_magic_storm (op, tmp, power); 3842 cast_magic_storm (op, tmp, power);
3980 new_draw_info (NDI_UNIQUE, 0, op, "You unlease uncontrolled mana!"); 3843 op->failmsg ("You unleash uncontrolled mana!");
3981 tmp->destroy (); 3844 tmp->destroy ();
3982 } 3845 }
3983 } 3846 }
3984} 3847}
3985 3848
… …
4005 */ 3868 */
4006 int i, j; 3869 int i, j;
4007 3870
4008 for (i = 0; i < NUM_STATS; i++) 3871 for (i = 0; i < NUM_STATS; i++)
4009 { 3872 {
4010 sint8 stat = get_attr_value (stats, i); 3873 int race_bonus = pl->arch->stats.stat (i);
4011 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i); 3874 sint8 stat = stats->stat (i) + ns->stat (i);
4012 3875
4013 stat += get_attr_value (ns, i);
4014 if (stat > 20 + race_bonus) 3876 if (stat > 20 + race_bonus)
4015 { 3877 {
4016 excess_stat++; 3878 excess_stat++;
4017 stat = 20 + race_bonus; 3879 stat = 20 + race_bonus;
4018 } 3880 }
4019 set_attr_value (stats, i, stat); 3881
3882 stats->stat (i) = stat;
4020 } 3883 }
4021 3884
4022 for (j = 0; excess_stat > 0 && j < 100; j++) 3885 for (j = 0; excess_stat > 0 && j < 100; j++)
4023 { /* try 100 times to assign excess stats */ 3886 { /* try 100 times to assign excess stats */
4024 int i = rndm (0, 6); 3887 int i = rndm (0, 6);
4025 int stat = get_attr_value (stats, i);
4026 int race_bonus = get_attr_value (&(pl->arch->clone.stats), i);
4027 3888
4028 if (i == CHA) 3889 if (i == CHA)
4029 continue; /* exclude cha from this */ 3890 continue; /* exclude cha from this */
3891
3892 int stat = stats->stat (i);
3893 int race_bonus = pl->arch->stats.stat (i);
4030 if (stat < 20 + race_bonus) 3894 if (stat < 20 + race_bonus)
4031 { 3895 {
4032 change_attr_value (stats, i, 1); 3896 change_attr_value (stats, i, 1);
4033 excess_stat--; 3897 excess_stat--;
4034 } 3898 }
… …
4037 /* insert the randomitems from the change's treasurelist into 3901 /* insert the randomitems from the change's treasurelist into
4038 * the player ref: player.c 3902 * the player ref: player.c
4039 */ 3903 */
4040 if (change->randomitems != NULL) 3904 if (change->randomitems != NULL)
4041 give_initial_items (pl, change->randomitems); 3905 give_initial_items (pl, change->randomitems);
4042
4043 3906
4044 /* set up the face, for some races. */ 3907 /* set up the face, for some races. */
4045 3908
4046 /* first, look for the force object banning 3909 /* first, look for the force object banning
4047 * changing the face. Certain races never change face with class. 3910 * changing the face. Certain races never change face with class.
… …
4092 char got[MAX_BUF]; 3955 char got[MAX_BUF];
4093 int len; 3956 int len;
4094 3957
4095 if (!pl || !transformer) 3958 if (!pl || !transformer)
4096 return; 3959 return;
3960
4097 marked = find_marked_object (pl); 3961 marked = find_marked_object (pl);
3962
4098 if (!marked) 3963 if (!marked)
4099 { 3964 {
4100 new_draw_info_format (NDI_UNIQUE, 0, pl, "Use the %s with what item?", query_name (transformer)); 3965 pl->failmsg (format ("Use the %s with what item?", query_name (transformer)));
4101 return; 3966 return;
4102 } 3967 }
3968
4103 if (!marked->slaying) 3969 if (!marked->slaying)
4104 { 3970 {
4105 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3971 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4106 return; 3972 return;
4107 } 3973 }
3974
4108 /* check whether they are compatible or not */ 3975 /* check whether they are compatible or not */
4109 find = strstr (marked->slaying, transformer->arch->name); 3976 find = strstr (marked->slaying, transformer->arch->archname);
4110 if (!find || (*(find + strlen (transformer->arch->name)) != ':')) 3977 if (!find || (*(find + strlen (transformer->arch->archname)) != ':'))
4111 { 3978 {
4112 new_draw_info_format (NDI_UNIQUE, 0, pl, "You can't use the %s with your %s!", query_name (transformer), query_name (marked)); 3979 pl->failmsg (format ("You can't use the %s with your %s!", query_name (transformer), query_name (marked)));
4113 return; 3980 return;
4114 } 3981 }
3982
4115 find += strlen (transformer->arch->name) + 1; 3983 find += strlen (transformer->arch->archname) + 1;
4116 /* Item can be used, now find how many and what it yields */ 3984 /* Item can be used, now find how many and what it yields */
4117 if (isdigit (*(find))) 3985 if (isdigit (*(find)))
4118 { 3986 {
4119 yield = atoi (find); 3987 yield = atoi (find);
4120 if (yield < 1) 3988 if (yield < 1)
… …
4126 else 3994 else
4127 yield = 1; 3995 yield = 1;
4128 3996
4129 while (isdigit (*find)) 3997 while (isdigit (*find))
4130 find++; 3998 find++;
3999
4131 while (*find == ' ') 4000 while (*find == ' ')
4132 find++; 4001 find++;
4002
4133 memset (got, 0, MAX_BUF); 4003 memset (got, 0, MAX_BUF);
4004
4134 if ((separator = strchr (find, ';')) != NULL) 4005 if ((separator = strchr (find, ';')) != NULL)
4135 {
4136 len = separator - find; 4006 len = separator - find;
4137 }
4138 else 4007 else
4139 {
4140 len = strlen (find); 4008 len = strlen (find);
4141 } 4009
4142 if (len > MAX_BUF - 1) 4010 if (len > MAX_BUF - 1)
4143 len = MAX_BUF - 1; 4011 len = MAX_BUF - 1;
4012
4144 strcpy (got, find); 4013 strcpy (got, find);
4145 got[len] = '\0'; 4014 got[len] = '\0';
4146 4015
4147 /* Now create new item, remove used ones when required. */ 4016 /* Now create new item, remove used ones when required. */
4148 new_item = get_archetype (got); 4017 new_item = get_archetype (got);
4149 if (!new_item) 4018 if (!new_item)
4150 { 4019 {
4151 new_draw_info_format (NDI_UNIQUE, 0, pl, "This %s is strange, better to not use it.", query_base_name (marked, 0)); 4020 pl->failmsg (format ("This %s is strange, better to not use it.", query_base_name (marked, 0)));
4152 return; 4021 return;
4153 } 4022 }
4154 4023
4155 new_item->nrof = yield; 4024 new_item->nrof = yield;
4025
4156 new_draw_info_format (NDI_UNIQUE, 0, pl, "You %s the %s.", &transformer->slaying, query_base_name (marked, 0)); 4026 pl->statusmsg (format ("You %s the %s.", &transformer->slaying, query_base_name (marked, 0)));
4157 insert_ob_in_ob (new_item, pl); 4027
4158 esrv_send_inventory (pl, pl); 4028 pl->insert (new_item);
4159 /* Eat up one item */ 4029 /* Eat up one item */
4160 decrease_ob_nr (marked, 1); 4030 marked->decrease ();
4031
4161 /* Eat one transformer if needed */ 4032 /* Eat one transformer if needed */
4162 if (transformer->stats.food) 4033 if (transformer->stats.food)
4163 if (--transformer->stats.food == 0) 4034 if (--transformer->stats.food == 0)
4164 decrease_ob_nr (transformer, 1); 4035 transformer->decrease ();
4165} 4036}
4037

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines