ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/attack.C
(Generate patch)

Comparing deliantra/server/server/attack.C (file contents):
Revision 1.15 by root, Thu Sep 14 20:46:10 2006 UTC vs.
Revision 1.107 by elmex, Mon Jan 12 00:17:23 2009 UTC

1
2/* 1/*
3 * static char *rcsid_attack_c = 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
4 * "$Id: attack.C,v 1.15 2006/09/14 20:46:10 root Exp $"; 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 *
8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version.
12 *
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 *
21 * The authors can be reached via e-mail to <support@deliantra.net>
5 */ 22 */
6 23
7/*
8 CrossFire, A Multiplayer game for X-windows
9
10 Copyright (C) 2002 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen
12
13 This program is free software; you can redistribute it and/or modify
14 it under the terms of the GNU General Public License as published by
15 the Free Software Foundation; either version 2 of the License, or
16 (at your option) any later version.
17
18 This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details.
22
23 You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
26
27 The authors can be reached via e-mail to crossfire-devel@real-time.com
28*/
29#include <assert.h> 24#include <assert.h>
30#include <global.h> 25#include <global.h>
31#include <living.h> 26#include <living.h>
32#include <material.h> 27#include <material.h>
33#include <skills.h> 28#include <skills.h>
34
35#ifndef __CEXTRACT__
36# include <sproto.h>
37#endif
38
39#include <sounds.h> 29#include <sounds.h>
30#include <sproto.h>
40 31
41typedef struct att_msg_str 32typedef struct att_msg_str
42{ 33{
43 char *msg1; 34 char *msg1;
44 char *msg2; 35 char *msg2;
… …
50 * its magical benefits. 41 * its magical benefits.
51 */ 42 */
52void 43void
53cancellation (object *op) 44cancellation (object *op)
54{ 45{
55 object *tmp;
56
57 if (op->invisible) 46 if (op->invisible)
58 return; 47 return;
59 48
60 if (QUERY_FLAG (op, FLAG_ALIVE) || op->type == CONTAINER || op->type == THROWN_OBJ) 49 if (QUERY_FLAG (op, FLAG_ALIVE) || op->type == CONTAINER || op->type == THROWN_OBJ)
61 { 50 {
62 /* Recur through the inventory */ 51 /* Recurse through the inventory */
63 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 52 for (object *tmp = op->inv; tmp; tmp = tmp->below)
64 if (!did_make_save_item (tmp, AT_CANCELLATION, op)) 53 if (!did_make_save_item (tmp, AT_CANCELLATION, op))
65 cancellation (tmp); 54 cancellation (tmp);
66 } 55 }
67 else if (FABS (op->magic) <= (rndm (0, 5))) 56 else if (FABS (op->magic) <= rndm (0, 5))
68 { 57 {
69 /* Nullify this object. This code could probably be more complete */ 58 /* Nullify this object. This code could probably be more complete */
70 /* in what abilities it should cancel */ 59 /* in what abilities it should cancel */
71 op->magic = 0; 60 op->magic = 0;
61
72 CLEAR_FLAG (op, FLAG_DAMNED); 62 CLEAR_FLAG (op, FLAG_DAMNED);
73 CLEAR_FLAG (op, FLAG_CURSED); 63 CLEAR_FLAG (op, FLAG_CURSED);
74 CLEAR_FLAG (op, FLAG_KNOWN_MAGICAL); 64 CLEAR_FLAG (op, FLAG_KNOWN_MAGICAL);
75 CLEAR_FLAG (op, FLAG_KNOWN_CURSED); 65 CLEAR_FLAG (op, FLAG_KNOWN_CURSED);
76 if (op->env && op->env->type == PLAYER)
77 {
78 esrv_send_item (op->env, op);
79 }
80 }
81}
82 66
83 67 if (object *pl = op->visible_to ())
68 esrv_update_item (UPD_FLAGS, pl, op);
69 }
70}
84 71
85/* did_make_save_item just checks to make sure the item actually 72/* did_make_save_item just checks to make sure the item actually
86 * made its saving throw based on the tables. It does not take 73 * made its saving throw based on the tables. It does not take
87 * any further action (like destroying the item). 74 * any further action (like destroying the item).
88 */ 75 */
89
90int 76int
91did_make_save_item (object *op, int type, object *originator) 77did_make_save_item (object *op, int type, object *originator)
92{ 78{
93 int i, roll, saves = 0, attacks = 0, number; 79 int i, roll, saves = 0, attacks = 0, number;
94 materialtype_t *mt; 80 materialtype_t *mt;
95 81
96 if (op->materialname == NULL) 82 if (!op->materialname)
97 { 83 {
98 for (mt = materialt; mt != NULL && mt->next != NULL; mt = mt->next) 84 for (mt = materialt; mt; mt = mt->next)
99 {
100 if (op->material & mt->material) 85 if (op->materials & mt->material)
101 break; 86 break;
102 }
103 } 87 }
104 else 88 else
105 mt = name_to_material (op->materialname); 89 mt = name_to_material (op->materialname);
106 if (mt == NULL) 90
91 if (!mt)
107 return TRUE; 92 return TRUE;
93
108 roll = rndm (1, 20); 94 roll = rndm (1, 20);
109 95
110 /* the attacktypes have no meaning for object saves 96 /* the attacktypes have no meaning for object saves
111 * If the type is only magic, don't adjust type - basically, if 97 * If the type is only magic, don't adjust type - basically, if
112 * pure magic is hitting an object, it should save. However, if it 98 * pure magic is hitting an object, it should save. However, if it
… …
118 if (type != AT_MAGIC) 104 if (type != AT_MAGIC)
119 type &= ~(AT_CONFUSION | AT_DRAIN | AT_GHOSTHIT | AT_POISON | AT_SLOW | 105 type &= ~(AT_CONFUSION | AT_DRAIN | AT_GHOSTHIT | AT_POISON | AT_SLOW |
120 AT_PARALYZE | AT_TURN_UNDEAD | AT_FEAR | AT_DEPLETE | AT_DEATH | 106 AT_PARALYZE | AT_TURN_UNDEAD | AT_FEAR | AT_DEPLETE | AT_DEATH |
121 AT_COUNTERSPELL | AT_HOLYWORD | AT_BLIND | AT_LIFE_STEALING | AT_MAGIC); 107 AT_COUNTERSPELL | AT_HOLYWORD | AT_BLIND | AT_LIFE_STEALING | AT_MAGIC);
122 108
123 if (type == 0) 109 if (type == 0) return TRUE;
124 return TRUE; 110
125 if (roll == 20) 111 if (roll == 20) return TRUE;
126 return TRUE; 112 if (roll == 1) return FALSE;
127 if (roll == 1)
128 return FALSE;
129 113
130 for (number = 0; number < NROFATTACKS; number++) 114 for (number = 0; number < NROFATTACKS; number++)
131 { 115 {
132 i = 1 << number; 116 i = 1 << number;
117
133 if (!(i & type)) 118 if (!(i & type))
134 continue; 119 continue;
120
135 attacks++; 121 attacks++;
136 if (op->resist[number] == 100) 122 if (op->resist[number] == 100)
137 saves++; 123 saves++;
138 else if (roll >= mt->save[number] - op->magic - op->resist[number] / 100) 124 else if (roll >= mt->save[number] - op->magic - op->resist[number] / 100)
139 saves++; 125 saves++;
… …
141 saves++; 127 saves++;
142 } 128 }
143 129
144 if (saves == attacks || attacks == 0) 130 if (saves == attacks || attacks == 0)
145 return TRUE; 131 return TRUE;
132
146 if ((saves == 0) || (rndm (1, attacks) > saves)) 133 if (saves == 0 || (rndm (1, attacks) > saves))
147 return FALSE; 134 return FALSE;
135
148 return TRUE; 136 return TRUE;
149} 137}
150 138
151/* This function calls did_make_save_item. It then performs the 139/* This function calls did_make_save_item. It then performs the
152 * appropriate actions to the item (such as burning the item up, 140 * appropriate actions to the item (such as burning the item up,
153 * calling cancellation, etc.) 141 * calling cancellation, etc.)
154 */ 142 */
155
156void 143void
157save_throw_object (object *op, int type, object *originator) 144save_throw_object (object *op, int type, object *originator)
158{ 145{
159 if (!did_make_save_item (op, type, originator)) 146 if (!did_make_save_item (op, type, originator))
160 { 147 {
161 object *env = op->env; 148 object *env = op->env;
162 int x = op->x, y = op->y; 149 int x = op->x, y = op->y;
163 mapstruct *m = op->map; 150 maptile *m = op->map;
164 151
165 op = stop_item (op); 152 op = stop_item (op);
166 if (op == NULL) 153 if (!op)
167 return; 154 return;
168 155
169 /* Hacked the following so that type LIGHTER will work. 156 /* Hacked the following so that type LIGHTER will work.
170 * Also, objects which are potenital "lights" that are hit by 157 * Also, objects which are potential "lights" that are hit by
171 * flame/elect attacks will be set to glow. "lights" are any 158 * flame/elect attacks will be set to glow. "lights" are any
172 * object with +/- glow_radius and an "other_arch" to change to. 159 * object with +/- glow_radius and an "other_arch" to change to.
173 * (and please note that we cant fail our save and reach this 160 * (and please note that we cant fail our save and reach this
174 * function if the object doesnt contain a material that can burn. 161 * function if the object doesnt contain a material that can burn.
175 * So forget lighting magical swords on fire with this!) -b.t. 162 * So forget lighting magical swords on fire with this!) -b.t.
176 */ 163 */
177 if (type & (AT_FIRE | AT_ELECTRICITY) && op->other_arch && QUERY_FLAG (op, FLAG_IS_LIGHTABLE)) 164 if (type & (AT_FIRE | AT_ELECTRICITY)
165 && (QUERY_FLAG (op, FLAG_IS_LIGHTABLE)
166 || op->type == LAMP
167 || op->type == TORCH
178 { 168 ))
179 const char *arch = op->other_arch->name; 169 {
180 170 switch (op->type)
181 op = decrease_ob_nr (op, 1);
182
183 if (op)
184 fix_stopped_item (op, m, originator);
185
186 if ((op = get_archetype (arch)) != NULL)
187 { 171 {
188 if (env) 172 case LAMP:
173 // turn on a lamp
174 apply_lamp (op, true);
175 break;
176
177 default:
178 // for instance icecubes:
179 if (op->other_arch)
189 { 180 {
190 op->x = env->x, op->y = env->y; 181 const char *arch = op->other_arch->archname;
191 insert_ob_in_ob (op, env); 182
183 if (op->decrease ())
184 fix_stopped_item (op, m, originator);
185
186 if ((op = archetype::get (arch)))
187 {
192 if (env->contr) 188 if (env)
193 esrv_send_item (env, op); 189 env->insert (op);
190 else
191 m->insert (op, x, y, originator);
192 }
194 } 193 }
195 else
196 {
197 op->x = x, op->y = y;
198 insert_ob_in_map (op, m, originator, 0);
199 }
200 } 194 }
201
202 return; 195 return;
203 } 196 }
204 197
205 if (type & AT_CANCELLATION) 198 if (type & AT_CANCELLATION)
206 { /* Cancellation. */ 199 { /* Cancellation. */
… …
209 return; 202 return;
210 } 203 }
211 204
212 if (op->nrof > 1) 205 if (op->nrof > 1)
213 { 206 {
214 op = decrease_ob_nr (op, rndm (0, op->nrof - 1)); 207 if (op->decrease (rndm (0, op->nrof - 1)))
215
216 if (op)
217 fix_stopped_item (op, m, originator); 208 fix_stopped_item (op, m, originator);
218 } 209 }
219 else 210 else
220 { 211 {
221 if (op->env) 212 // drop everything to the ground, if possible
222 { 213 op->insert_at (originator);
223 object *tmp = is_player_inv (op->env); 214 op->drop_and_destroy ();
224
225 if (tmp)
226 esrv_del_item (tmp->contr, op->count);
227 }
228
229 if (!QUERY_FLAG (op, FLAG_REMOVED))
230 remove_ob (op);
231
232 free_object (op);
233 } 215 }
234 216
235 if (type & (AT_FIRE | AT_ELECTRICITY)) 217 if (type & (AT_FIRE | AT_ELECTRICITY))
236 if (env) 218 if (env)
237 { 219 {
238 op = get_archetype ("burnout"); 220 op = archetype::get (shstr_burnout);
239 op->x = env->x, op->y = env->y; 221 op->x = env->x, op->y = env->y;
240 insert_ob_in_ob (op, env); 222 env->insert (op);
241 } 223 }
242 else 224 else
243 replace_insert_ob_in_map ("burnout", originator); 225 replace_insert_ob_in_map (shstr_burnout, originator);
244 226
245 return; 227 return;
246 } 228 }
247 229
248 /* The value of 50 is arbitrary. */ 230 /* The value of 50 is arbitrary. */
249 if (type & AT_COLD && (op->resist[ATNR_COLD] < 50) && !QUERY_FLAG (op, FLAG_NO_PICK) && (RANDOM () & 2)) 231 if (type & AT_COLD && (op->resist[ATNR_COLD] < 50) && !QUERY_FLAG (op, FLAG_NO_PICK) && rndm (2))
250 { 232 {
251 object *tmp;
252 archetype *at = find_archetype ("icecube"); 233 archetype *at = archetype::find (shstr_icecube);
253 234
254 if (at == NULL) 235 if (at == NULL)
255 return; 236 return;
256 237
257 op = stop_item (op); 238 op = stop_item (op);
258 if (op == NULL) 239 if (op == NULL)
259 return; 240 return;
260 241
261 if ((tmp = present_arch (at, op->map, op->x, op->y)) == NULL) 242 object *tmp = present_arch (at, op->map, op->x, op->y);
243 if (!tmp)
262 { 244 {
263 tmp = arch_to_object (at); 245 tmp = arch_to_object (at);
264 tmp->x = op->x, tmp->y = op->y; 246 tmp->x = op->x, tmp->y = op->y;
265 /* This was in the old (pre new movement code) - 247 /* This was in the old (pre new movement code) -
266 * icecubes have slow_move set to 1 - don't want 248 * icecubes have slow_move set to 1 - don't want
… …
269 tmp->move_slow_penalty = 0; 251 tmp->move_slow_penalty = 0;
270 tmp->move_slow = 0; 252 tmp->move_slow = 0;
271 insert_ob_in_map (tmp, op->map, originator, 0); 253 insert_ob_in_map (tmp, op->map, originator, 0);
272 } 254 }
273 255
274 if (!QUERY_FLAG (op, FLAG_REMOVED)) 256 tmp->insert (op);
275 remove_ob (op);
276
277 insert_ob_in_ob (op, tmp);
278 return; 257 return;
279 } 258 }
280} 259}
281 260
282/* Object op is hitting the map. 261/* Object op is hitting the map.
283 * op is going in direction 'dir' 262 * op is going in direction 'dir'
284 * type is the attacktype of the object. 263 * type is the attacktype of the object.
285 * full_hit is set if monster area does not matter. 264 * full_hit is set if monster area does not matter.
286 * returns 1 if it hits something, 0 otherwise. 265 * returns 1 if it hits something, 0 otherwise.
287 */ 266 */
288
289int 267int
290hit_map (object *op, int dir, int type, int full_hit) 268hit_map (object *op, int dir, int type, int full_hit)
291{ 269{
292 object *tmp, *next;
293 mapstruct *map; 270 maptile *map;
294 sint16 x, y; 271 sint16 x, y;
295 int retflag = 0; /* added this flag.. will return 1 if it hits a monster */ 272 int retflag = 0; /* added this flag.. will return 1 if it hits a monster */
296 273
297 tag_t op_tag, next_tag = 0;
298
299 if (QUERY_FLAG (op, FLAG_FREED)) 274 if (QUERY_FLAG (op, FLAG_FREED))
300 { 275 {
301 LOG (llevError, "BUG: hit_map(): free object\n"); 276 LOG (llevError, "BUG: hit_map(): free object\n");
302 return 0; 277 return 0;
303 } 278 }
304 279
305 if (QUERY_FLAG (op, FLAG_REMOVED) || op->env != NULL) 280 if (QUERY_FLAG (op, FLAG_REMOVED) || op->env != NULL)
306 { 281 {
307 LOG (llevError, "BUG: hit_map(): hitter (arch %s, name %s) not on a map\n", &op->arch->name, &op->name); 282 LOG (llevError, "BUG: hit_map(): hitter (arch %s, name %s) not on a map\n", &op->arch->archname, &op->name);
308 return 0; 283 return 0;
309 } 284 }
310 285
311 if (!op->map) 286 if (!op->map)
312 { 287 {
… …
315 } 290 }
316 291
317 if (op->head) 292 if (op->head)
318 op = op->head; 293 op = op->head;
319 294
320 op_tag = op->count; 295 mapxy pos (op);
296 pos.move (dir);
321 297
322 map = op->map; 298 if (!pos.normalise ())
323 x = op->x + freearr_x[dir]; 299 return 0;
324 y = op->y + freearr_y[dir];
325
326 int mflags = get_map_flags (map, &map, x, y, &x, &y);
327 300
328 // elmex: a safe map tile can't be hit! 301 // elmex: a safe map tile can't be hit!
329 // this should prevent most harmful effects on items and players there. 302 // this should prevent most harmful effects on items and players there.
330 if (mflags & (P_OUT_OF_MAP | P_SAFE)) 303 mapspace &ms = pos.ms ();
304
305 if (ms.flags () & P_SAFE)
331 return 0; 306 return 0;
332 307
333 /* peterm: a few special cases for special attacktypes --counterspell 308 /* peterm: a few special cases for special attacktypes --counterspell
334 * must be out here because it strikes things which are not alive 309 * must be out here because it strikes things which are not alive
335 */ 310 */
336 311 if (type & (AT_COUNTERSPELL | AT_CHAOS))
312 {
337 if (type & AT_COUNTERSPELL) 313 if (type & AT_COUNTERSPELL)
338 { 314 {
339 counterspell (op, dir); /* see spell_effect.c */ 315 counterspell (op, dir); /* see spell_effect.c */
340 316
341 /* If the only attacktype is counterspell or magic, don't need 317 /* If the only attacktype is counterspell or magic, don't need
342 * to do any further processing. 318 * to do any further processing.
343 */
344 if (!(type & ~(AT_COUNTERSPELL | AT_MAGIC)))
345 return 0;
346
347 type &= ~AT_COUNTERSPELL;
348 }
349
350 if (type & AT_CHAOS)
351 {
352 shuffle_attack (op, 1); /*1 flag tells it to change the face */
353 update_object (op, UP_OBJ_FACE);
354 type &= ~AT_CHAOS;
355 }
356
357 next = get_map_ob (map, x, y);
358 if (next)
359 next_tag = next->count;
360
361 while (next)
362 {
363 if (was_destroyed (next, next_tag))
364 {
365 /* There may still be objects that were above 'next', but there is no
366 * simple way to find out short of copying all object references and
367 * tags into a temporary array before we start processing the first
368 * object. That's why we just abort.
369 *
370 * This happens whenever attack spells (like fire) hit a pile
371 * of objects. This is not a bug - nor an error. The errormessage
372 * below was spamming the logs for absolutely no reason.
373 */ 319 */
374 /* LOG (llevDebug, "hit_map(): next object destroyed\n"); */ 320 if (!(type & ~(AT_COUNTERSPELL | AT_MAGIC)))
375 break; 321 return 0;
322
323 type &= ~AT_COUNTERSPELL;
324 }
325
326 if (type & AT_CHAOS)
376 } 327 {
328 shuffle_attack (op, 1); /* flag tells it to change the face */
329 update_object (op, UP_OBJ_FACE);
330 type &= ~AT_CHAOS;
331 }
332 }
377 333
334 /* There may still be objects that were above 'next', but there is no
335 * simple way to find out short of copying all object references and
336 * tags into a temporary array before we start processing the first
337 * object. That's why we just abort on destroy.
338 *
339 * This happens whenever attack spells (like fire) hit a pile
340 * of objects. This is not a bug - nor an error.
341 */
342 for (object *next = ms.bot; next && !next->destroyed (); )
343 {
378 tmp = next; 344 object *tmp = next;
379 next = tmp->above; 345 next = tmp->above;
380
381 if (next)
382 next_tag = next->count;
383
384 if (QUERY_FLAG (tmp, FLAG_FREED))
385 {
386 LOG (llevError, "BUG: hit_map(): found freed object\n");
387 break;
388 }
389 346
390 /* Something could have happened to 'tmp' while 'tmp->below' was processed. 347 /* Something could have happened to 'tmp' while 'tmp->below' was processed.
391 * For example, 'tmp' was put in an icecube. 348 * For example, 'tmp' was put in an icecube.
392 * This is one of the few cases where on_same_map should not be used. 349 * This is one of the few cases where on_same_map should not be used.
393 */ 350 */
394 if (tmp->map != map || tmp->x != x || tmp->y != y) 351 if (tmp->map != pos.m || tmp->x != pos.x || tmp->y != pos.y)
395 continue; 352 continue;
396 353
397 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 354 if (QUERY_FLAG (tmp, FLAG_ALIVE))
398 { 355 {
399 hit_player (tmp, op->stats.dam, op, type, full_hit); 356 hit_player (tmp, op->stats.dam, op, type, full_hit);
400 retflag |= 1; 357 retflag |= 1;
358
401 if (was_destroyed (op, op_tag)) 359 if (op->destroyed ())
402 break; 360 break;
403 } 361 }
404
405 /* Here we are potentially destroying an object. If the object has 362 /* Here we are potentially destroying an object. If the object has
406 * NO_PASS set, it is also immune - you can't destroy walls. Note 363 * NO_PASS set, it is also immune - you can't destroy walls. Note
407 * that weak walls have is_alive set, which prevent objects from 364 * that weak walls have is_alive set, which prevent objects from
408 * passing over/through them. We don't care what type of movement 365 * passing over/through them. We don't care what type of movement
409 * the wall blocks - if it blocks any type of movement, can't be 366 * the wall blocks - if it blocks any type of movement, can't be
410 * destroyed right now. 367 * destroyed right now.
411 */ 368 */
412 else if ((tmp->material || tmp->materialname) && op->stats.dam > 0 && !tmp->move_block) 369 else if (tmp->materialname && op->stats.dam > 0 && !tmp->move_block)
413 { 370 {
414 save_throw_object (tmp, type, op); 371 save_throw_object (tmp, type, op);
372
415 if (was_destroyed (op, op_tag)) 373 if (op->destroyed ())
416 break; 374 break;
417 } 375 }
418 } 376 }
419 377
420 return 0; 378 return 0;
… …
423void 381void
424attack_message (int dam, int type, object *op, object *hitter) 382attack_message (int dam, int type, object *op, object *hitter)
425{ 383{
426 char buf[MAX_BUF], buf1[MAX_BUF], buf2[MAX_BUF]; 384 char buf[MAX_BUF], buf1[MAX_BUF], buf2[MAX_BUF];
427 int i, found = 0; 385 int i, found = 0;
428 mapstruct *map; 386 maptile *map;
429 object *next, *tmp; 387 object *next, *tmp;
430 388
431 /* put in a few special messages for some of the common attacktypes 389 /* put in a few special messages for some of the common attacktypes
432 * a player might have. For example, fire, electric, cold, etc 390 * a player might have. For example, fire, electric, cold, etc
433 * [garbled 20010919] 391 * [garbled 20010919]
… …
450 sprintf (buf1, "missed %s", &op->name); 408 sprintf (buf1, "missed %s", &op->name);
451 sprintf (buf2, " misses"); 409 sprintf (buf2, " misses");
452 found++; 410 found++;
453 } 411 }
454 else if ((hitter->type == DISEASE || hitter->type == SYMPTOM || 412 else if ((hitter->type == DISEASE || hitter->type == SYMPTOM ||
455 hitter->type == POISONING || (type & AT_POISON && IS_LIVE (op))) && !found) 413 hitter->type == POISONING || (type & AT_POISON && op->is_alive ())) && !found)
456 { 414 {
457 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_SUFFER][i].level != -1; i++) 415 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_SUFFER][i].level != -1; i++)
458 if (dam < attack_mess[ATM_SUFFER][i].level || attack_mess[ATM_SUFFER][i + 1].level == -1) 416 if (dam < attack_mess[ATM_SUFFER][i].level || attack_mess[ATM_SUFFER][i + 1].level == -1)
459 { 417 {
460 sprintf (buf1, "%s %s%s", attack_mess[ATM_SUFFER][i].buf1, &op->name, attack_mess[ATM_SUFFER][i].buf2); 418 sprintf (buf1, "%s %s%s", attack_mess[ATM_SUFFER][i].buf1, &op->name, attack_mess[ATM_SUFFER][i].buf2);
… …
472 strcpy (buf2, attack_mess[ATM_DOOR][i].buf3); 430 strcpy (buf2, attack_mess[ATM_DOOR][i].buf3);
473 found++; 431 found++;
474 break; 432 break;
475 } 433 }
476 } 434 }
477 else if (hitter->type == PLAYER && IS_LIVE (op)) 435 else if (hitter->type == PLAYER && op->is_alive ())
478 { 436 {
479 if (USING_SKILL (hitter, SK_KARATE)) 437 if (USING_SKILL (hitter, SK_KARATE))
480 { 438 {
481 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_KARATE][i].level != -1; i++) 439 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_KARATE][i].level != -1; i++)
482 if (dam < attack_mess[ATM_KARATE][i].level || attack_mess[ATM_KARATE][i + 1].level == -1) 440 if (dam < attack_mess[ATM_KARATE][i].level || attack_mess[ATM_KARATE][i + 1].level == -1)
… …
508 found++; 466 found++;
509 break; 467 break;
510 } 468 }
511 } 469 }
512 } 470 }
471
513 if (found) 472 if (found)
514 { 473 {
515 /* done */ 474 /* done */
516 } 475 }
517 else if (IS_ARROW (hitter) && (type == AT_PHYSICAL || type == AT_MAGIC)) 476 else if (hitter->is_arrow () && (type == AT_PHYSICAL || type == AT_MAGIC))
518 { 477 {
519 sprintf (buf1, "hit"); /* just in case */ 478 sprintf (buf1, "hit"); /* just in case */
520 for (i = 0; i < MAXATTACKMESS; i++) 479 for (i = 0; i < MAXATTACKMESS; i++)
521 if (dam < attack_mess[ATM_ARROW][i].level || attack_mess[ATM_ARROW][i + 1].level == -1) 480 if (dam < attack_mess[ATM_ARROW][i].level || attack_mess[ATM_ARROW][i + 1].level == -1)
522 { 481 {
523 strcpy (buf2, attack_mess[ATM_ARROW][i].buf3); 482 strcpy (buf2, attack_mess[ATM_ARROW][i].buf3);
524 found++; 483 found++;
525 break; 484 break;
526 } 485 }
527 } 486 }
528 else if (type & AT_DRAIN && IS_LIVE (op)) 487 else if (type & AT_DRAIN && op->is_alive ())
529 { 488 {
530 /* drain is first, because some items have multiple attypes */ 489 /* drain is first, because some items have multiple attypes */
531 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_DRAIN][i].level != -1; i++) 490 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_DRAIN][i].level != -1; i++)
532 if (dam < attack_mess[ATM_DRAIN][i].level || attack_mess[ATM_DRAIN][i + 1].level == -1) 491 if (dam < attack_mess[ATM_DRAIN][i].level || attack_mess[ATM_DRAIN][i + 1].level == -1)
533 { 492 {
… …
535 strcpy (buf2, attack_mess[ATM_DRAIN][i].buf3); 494 strcpy (buf2, attack_mess[ATM_DRAIN][i].buf3);
536 found++; 495 found++;
537 break; 496 break;
538 } 497 }
539 } 498 }
540 else if (type & AT_ELECTRICITY && IS_LIVE (op)) 499 else if (type & AT_ELECTRICITY && op->is_alive ())
541 { 500 {
542 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_ELEC][i].level != -1; i++) 501 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_ELEC][i].level != -1; i++)
543 if (dam < attack_mess[ATM_ELEC][i].level || attack_mess[ATM_ELEC][i + 1].level == -1) 502 if (dam < attack_mess[ATM_ELEC][i].level || attack_mess[ATM_ELEC][i + 1].level == -1)
544 { 503 {
545 sprintf (buf1, "%s %s%s", attack_mess[ATM_ELEC][i].buf1, &op->name, attack_mess[ATM_ELEC][i].buf2); 504 sprintf (buf1, "%s %s%s", attack_mess[ATM_ELEC][i].buf1, &op->name, attack_mess[ATM_ELEC][i].buf2);
546 strcpy (buf2, attack_mess[ATM_ELEC][i].buf3); 505 strcpy (buf2, attack_mess[ATM_ELEC][i].buf3);
547 found++; 506 found++;
548 break; 507 break;
549 } 508 }
550 } 509 }
551 else if (type & AT_COLD && IS_LIVE (op)) 510 else if (type & AT_COLD && op->is_alive ())
552 { 511 {
553 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_COLD][i].level != -1; i++) 512 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_COLD][i].level != -1; i++)
554 if (dam < attack_mess[ATM_COLD][i].level || attack_mess[ATM_COLD][i + 1].level == -1) 513 if (dam < attack_mess[ATM_COLD][i].level || attack_mess[ATM_COLD][i + 1].level == -1)
555 { 514 {
556 sprintf (buf1, "%s %s%s", attack_mess[ATM_COLD][i].buf1, &op->name, attack_mess[ATM_COLD][i].buf2); 515 sprintf (buf1, "%s %s%s", attack_mess[ATM_COLD][i].buf1, &op->name, attack_mess[ATM_COLD][i].buf2);
… …
574 { 533 {
575 int mtype; 534 int mtype;
576 535
577 switch (hitter->current_weapon->weapontype) 536 switch (hitter->current_weapon->weapontype)
578 { 537 {
579 case WEAP_HIT: 538 case WEAP_HIT:
580 mtype = ATM_BASIC; 539 mtype = ATM_BASIC;
581 break; 540 break;
582 case WEAP_SLASH: 541 case WEAP_SLASH:
583 mtype = ATM_SLASH; 542 mtype = ATM_SLASH;
584 break; 543 break;
585 case WEAP_PIERCE: 544 case WEAP_PIERCE:
586 mtype = ATM_PIERCE; 545 mtype = ATM_PIERCE;
587 break; 546 break;
588 case WEAP_CLEAVE: 547 case WEAP_CLEAVE:
589 mtype = ATM_CLEAVE; 548 mtype = ATM_CLEAVE;
590 break; 549 break;
591 case WEAP_SLICE: 550 case WEAP_SLICE:
592 mtype = ATM_SLICE; 551 mtype = ATM_SLICE;
593 break; 552 break;
594 case WEAP_STAB: 553 case WEAP_STAB:
595 mtype = ATM_STAB; 554 mtype = ATM_STAB;
596 break; 555 break;
597 case WEAP_WHIP: 556 case WEAP_WHIP:
598 mtype = ATM_WHIP; 557 mtype = ATM_WHIP;
599 break; 558 break;
600 case WEAP_CRUSH: 559 case WEAP_CRUSH:
601 mtype = ATM_CRUSH; 560 mtype = ATM_CRUSH;
602 break; 561 break;
603 case WEAP_BLUD: 562 case WEAP_BLUD:
604 mtype = ATM_BLUD; 563 mtype = ATM_BLUD;
605 break; 564 break;
606 default: 565 default:
607 mtype = ATM_BASIC; 566 mtype = ATM_BASIC;
608 break; 567 break;
609 } 568 }
569
610 for (i = 0; i < MAXATTACKMESS && attack_mess[mtype][i].level != -1; i++) 570 for (i = 0; i < MAXATTACKMESS && attack_mess[mtype][i].level != -1; i++)
611 if (dam < attack_mess[mtype][i].level || attack_mess[mtype][i + 1].level == -1) 571 if (dam < attack_mess[mtype][i].level || attack_mess[mtype][i + 1].level == -1)
612 { 572 {
613 sprintf (buf1, "%s %s%s", attack_mess[mtype][i].buf1, &op->name, attack_mess[mtype][i].buf2); 573 sprintf (buf1, "%s %s%s", attack_mess[mtype][i].buf1, &op->name, attack_mess[mtype][i].buf2);
614 strcpy (buf2, attack_mess[mtype][i].buf3); 574 strcpy (buf2, attack_mess[mtype][i].buf3);
… …
633 strcpy (buf1, "hit"); 593 strcpy (buf1, "hit");
634 strcpy (buf2, " hits"); 594 strcpy (buf2, " hits");
635 } 595 }
636 596
637 /* bail out if a monster is casting spells */ 597 /* bail out if a monster is casting spells */
638 if (!(hitter->type == PLAYER || (get_owner (hitter) != NULL && hitter->owner->type == PLAYER))) 598 if (!(hitter->type == PLAYER || (hitter->owner != NULL && hitter->owner->type == PLAYER)))
639 return; 599 return;
640 600
641 /* scale down magic considerably. */ 601 /* scale down magic considerably. */
642 if (type & AT_MAGIC && rndm (0, 5)) 602 if (type & AT_MAGIC && rndm (0, 5))
643 return; 603 return;
644 604
645 /* Did a player hurt another player? Inform both! */ 605 /* Did a player hurt another player? Inform both! */
646 if (op->type == PLAYER && (get_owner (hitter) == NULL ? hitter->type : hitter->owner->type) == PLAYER) 606 if (op->type == PLAYER && (hitter->owner == NULL ? hitter->type : hitter->owner->type) == PLAYER)
647 { 607 {
648 if (get_owner (hitter) != NULL) 608 if (hitter->owner != NULL)
649 sprintf (buf, "%s's %s%s you.", &hitter->owner->name, &hitter->name, buf2); 609 sprintf (buf, "%s's %s%s you.", &hitter->owner->name, &hitter->name, buf2);
650 else 610 else
651 { 611 {
652 sprintf (buf, "%s%s you.", &hitter->name, buf2); 612 sprintf (buf, "%s%s you.", &hitter->name, buf2);
613
653 if (dam != 0) 614 if (dam != 0)
654 { 615 {
655 if (dam < 10) 616 if (dam < 10)
656 play_sound_player_only (op->contr, SOUND_PLAYER_IS_HIT1, 0, 0); 617 op->contr->play_sound (sound_find ("player_is_hit1"));
657 else if (dam < 20) 618 else if (dam < 20)
658 play_sound_player_only (op->contr, SOUND_PLAYER_IS_HIT2, 0, 0); 619 op->contr->play_sound (sound_find ("player_is_hit2"));
659 else 620 else
660 play_sound_player_only (op->contr, SOUND_PLAYER_IS_HIT3, 0, 0); 621 op->contr->play_sound (sound_find ("player_is_hit3"));
661 } 622 }
662 } 623 }
624
663 new_draw_info (NDI_BLACK, 0, op, buf); 625 new_draw_info (NDI_BLACK, 0, op, buf);
664 } /* end of player hitting player */ 626 } /* end of player hitting player */
665 627
666 if (hitter->type == PLAYER) 628 if (hitter->type == PLAYER)
667 { 629 {
668 sprintf (buf, "You %s.", buf1); 630 sprintf (buf, "You %s.", buf1);
631
669 if (dam != 0) 632 if (dam != 0)
670 { 633 {
671 if (dam < 10) 634 if (dam < 10)
672 play_sound_player_only (hitter->contr, SOUND_PLAYER_HITS1, 0, 0); 635 op->play_sound (sound_find ("player_hits1"));
673 else if (dam < 20) 636 else if (dam < 20)
674 play_sound_player_only (hitter->contr, SOUND_PLAYER_HITS2, 0, 0); 637 op->play_sound (sound_find ("player_hits2"));
675 else 638 else
676 play_sound_player_only (hitter->contr, SOUND_PLAYER_HITS3, 0, 0); 639 op->play_sound (sound_find ("player_hits3"));
677 } 640 }
641
678 new_draw_info (NDI_BLACK, 0, hitter, buf); 642 new_draw_info (NDI_BLACK, 0, hitter, buf);
679 } 643 }
680 else if (get_owner (hitter) != NULL && hitter->owner->type == PLAYER) 644 else if (hitter->owner != NULL && hitter->owner->type == PLAYER)
681 { 645 {
682 /* look for stacked spells and start reducing the message chances */ 646 /* look for stacked spells and start reducing the message chances */
683 if (hitter->type == SPELL_EFFECT && (hitter->subtype == SP_EXPLOSION || hitter->subtype == SP_BULLET || hitter->subtype == SP_CONE)) 647 if (hitter->type == SPELL_EFFECT && (hitter->subtype == SP_EXPLOSION || hitter->subtype == SP_BULLET || hitter->subtype == SP_CONE))
684 { 648 {
685 i = 4; 649 i = 4;
686 map = hitter->map; 650 map = hitter->map;
687 if (out_of_map (map, hitter->x, hitter->y)) 651 if (out_of_map (map, hitter->x, hitter->y))
688 return; 652 return;
653
689 next = get_map_ob (map, hitter->x, hitter->y); 654 next = GET_MAP_OB (map, hitter->x, hitter->y);
690 if (next) 655 if (next)
691 while (next) 656 while (next)
692 { 657 {
693 if (next->type == SPELL_EFFECT && (next->subtype == SP_EXPLOSION || next->subtype == SP_BULLET || next->subtype == SP_CONE)) 658 if (next->type == SPELL_EFFECT && (next->subtype == SP_EXPLOSION || next->subtype == SP_BULLET || next->subtype == SP_CONE))
694 i *= 3; 659 i *= 3;
660
695 tmp = next; 661 tmp = next;
696 next = tmp->above; 662 next = tmp->above;
697 } 663 }
664
698 if (i < 0) 665 if (i < 0)
699 return; 666 return;
667
700 if (rndm (0, i) != 0) 668 if (rndm (0, i) != 0)
701 return; 669 return;
702 } 670 }
703 else if (rndm (0, 5) != 0) 671 else if (rndm (0, 5) != 0)
704 return; 672 return;
673
705 sprintf (buf, "Your %s%s %s.", &hitter->name, buf2, &op->name); 674 sprintf (buf, "Your %s%s %s.", &hitter->name, buf2, &op->name);
706 play_sound_map (op->map, op->x, op->y, SOUND_PLAYER_HITS4); 675 op->play_sound (sound_find ("player_hits4"));
707 new_draw_info (NDI_BLACK, 0, hitter->owner, buf); 676 new_draw_info (NDI_BLACK, 0, hitter->owner, buf);
708 } 677 }
709} 678}
710 679
711 680
… …
715 if (QUERY_FLAG (*target, FLAG_FREED) || QUERY_FLAG (*hitter, FLAG_FREED)) 684 if (QUERY_FLAG (*target, FLAG_FREED) || QUERY_FLAG (*hitter, FLAG_FREED))
716 { 685 {
717 LOG (llevError, "BUG: get_attack_mode(): freed object\n"); 686 LOG (llevError, "BUG: get_attack_mode(): freed object\n");
718 return 1; 687 return 1;
719 } 688 }
689
720 if ((*target)->head) 690 if ((*target)->head)
721 *target = (*target)->head; 691 *target = (*target)->head;
692
722 if ((*hitter)->head) 693 if ((*hitter)->head)
723 *hitter = (*hitter)->head; 694 *hitter = (*hitter)->head;
695
696 if ((*target)->type == LOCKED_DOOR)
697 return 1; // locked doors cannot be hit
698
724 if ((*hitter)->env != NULL || (*target)->env != NULL) 699 if ((*hitter)->env || (*target)->env)
725 { 700 {
726 *simple_attack = 1; 701 *simple_attack = 1;
727 return 0; 702 return 0;
728 } 703 }
704
729 if (QUERY_FLAG (*target, FLAG_REMOVED) 705 if (QUERY_FLAG (*target, FLAG_REMOVED)
730 || QUERY_FLAG (*hitter, FLAG_REMOVED) || (*hitter)->map == NULL || !on_same_map ((*hitter), (*target))) 706 || QUERY_FLAG (*hitter, FLAG_REMOVED)
707 || !(*hitter)->map
708 || !on_same_map (*hitter, *target))
731 { 709 {
732 LOG (llevError, "BUG: hitter (arch %s, name %s) with no relation to " "target\n", &(*hitter)->arch->name, &(*hitter)->name); 710 LOG (llevError | logBacktrace, "BUG: hitter (%s) with no relation to target (%s)\n",
711 (*hitter)->debug_desc (), (*target)->debug_desc ());
733 return 1; 712 return 1;
734 } 713 }
714
735 *simple_attack = 0; 715 *simple_attack = 0;
736 return 0; 716 return 0;
737} 717}
738 718
739static int 719static int
… …
760attack_ob_simple (object *op, object *hitter, int base_dam, int base_wc) 740attack_ob_simple (object *op, object *hitter, int base_dam, int base_wc)
761{ 741{
762 int simple_attack, roll, dam = 0; 742 int simple_attack, roll, dam = 0;
763 uint32 type; 743 uint32 type;
764 shstr op_name; 744 shstr op_name;
765 tag_t op_tag, hitter_tag;
766 745
767 if (get_attack_mode (&op, &hitter, &simple_attack)) 746 if (get_attack_mode (&op, &hitter, &simple_attack))
768 goto error; 747 goto error;
769 748
770 if (hitter->current_weapon) 749 if (hitter->current_weapon)
771 if (INVOKE_OBJECT (WEAPON_ATTACK, hitter->current_weapon, ARG_OBJECT (hitter), ARG_OBJECT (op))) 750 if (INVOKE_OBJECT (WEAPON_ATTACK, hitter->current_weapon, ARG_OBJECT (hitter), ARG_OBJECT (op)))
772 return RESULT_INT (0); 751 return RESULT_INT (0);
773 752
774 if (INVOKE_OBJECT (ATTACK, op, ARG_OBJECT (hitter))) 753 if (INVOKE_OBJECT (ATTACK, op, ARG_OBJECT (hitter)))
775 return RESULT_INT (0); 754 return RESULT_INT (0);
776
777 op_tag = op->count;
778 hitter_tag = hitter->count;
779 755
780 /* 756 /*
781 * A little check to make it more difficult to dance forward and back 757 * A little check to make it more difficult to dance forward and back
782 * to avoid ever being hit by monsters. 758 * to avoid ever being hit by monsters.
783 */ 759 */
784 if (!simple_attack && QUERY_FLAG (op, FLAG_MONSTER) && op->speed_left > -(FABS (op->speed)) * 0.3) 760 if (!simple_attack && QUERY_FLAG (op, FLAG_MONSTER) && op->speed_left > abs (op->speed) * -0.3f)
785 { 761 {
786 /* Decrease speed BEFORE calling process_object. Otherwise, an 762 /* Decrease speed BEFORE calling process_object. Otherwise, an
787 * infinite loop occurs, with process_object calling move_monster, 763 * infinite loop occurs, with process_object calling move_monster,
788 * which then gets here again. By decreasing the speed before 764 * which then gets here again. By decreasing the speed before
789 * we call process_object, the 'if' statement above will fail. 765 * we call process_object, the 'if' statement above will fail.
790 */ 766 */
791 op->speed_left--; 767 --op->speed_left;
792 process_object (op); 768 process_object (op);
769
793 if (was_destroyed (op, op_tag) || was_destroyed (hitter, hitter_tag) || abort_attack (op, hitter, simple_attack)) 770 if (op->destroyed () || hitter->destroyed () || abort_attack (op, hitter, simple_attack))
794 goto error; 771 goto error;
795 } 772 }
796 773
797 op_name = op->name; 774 op_name = op->name;
798 775
… …
805 /* See if we hit the creature */ 782 /* See if we hit the creature */
806 if (roll == 20 || op->stats.ac >= base_wc - roll) 783 if (roll == 20 || op->stats.ac >= base_wc - roll)
807 { 784 {
808 int hitdam = base_dam; 785 int hitdam = base_dam;
809 786
810 if (settings.casting_time == TRUE)
811 {
812 if ((hitter->type == PLAYER) && (hitter->casting_time > -1))
813 {
814 hitter->casting_time = -1;
815 new_draw_info (NDI_UNIQUE, 0, hitter, "You attacked and lost " "your spell!");
816 }
817 if ((op->casting_time > -1) && (hitdam > 0))
818 {
819 op->casting_time = -1;
820 if (op->type == PLAYER)
821 {
822 new_draw_info (NDI_UNIQUE, 0, op, "You were hit and lost " "your spell!");
823 new_draw_info_format (NDI_ALL | NDI_UNIQUE, 5, NULL, "%s was hit by %s and lost a spell.", &op_name, &hitter->name);
824 }
825 }
826 }
827 if (!simple_attack) 787 if (!simple_attack)
828 { 788 {
829 /* If you hit something, the victim should *always* wake up. 789 /* If you hit something, the victim should *always* wake up.
830 * Before, invisible hitters could avoid doing this. 790 * Before, invisible hitters could avoid doing this.
831 * -b.t. */ 791 * -b.t. */
832 if (QUERY_FLAG (op, FLAG_SLEEP)) 792 if (QUERY_FLAG (op, FLAG_SLEEP))
833 CLEAR_FLAG (op, FLAG_SLEEP); 793 CLEAR_FLAG (op, FLAG_SLEEP);
834 794
835 /* If the victim can't see the attacker, it may alert others 795 /* If the victim can't see the attacker, it may alert others
836 * for help. */ 796 * for help. */
837 if (op->type != PLAYER && !can_see_enemy (op, hitter) && !get_owner (op) && rndm (0, op->stats.Int)) 797 if (op->type != PLAYER && !can_see_enemy (op, hitter) && !op->owner && rndm (0, op->stats.Int))
838 npc_call_help (op); 798 npc_call_help (op);
839 799
840 /* if you were hidden and hit by a creature, you are discovered */ 800 /* if you were hidden and hit by a creature, you are discovered */
841 if (op->hide && QUERY_FLAG (hitter, FLAG_ALIVE)) 801 if (op->flag [FLAG_HIDDEN] && hitter->flag [FLAG_ALIVE])
842 { 802 {
843 make_visible (op); 803 make_visible (op);
804
844 if (op->type == PLAYER) 805 if (op->type == PLAYER)
845 new_draw_info (NDI_UNIQUE, 0, op, "You were hit by a wild attack. " "You are no longer hidden!"); 806 new_draw_info (NDI_UNIQUE, 0, op, "You were hit by a wild attack. " "You are no longer hidden!");
846 } 807 }
847 808
848 /* thrown items (hitter) will have various effects 809 /* thrown items (hitter) will have various effects
849 * when they hit the victim. For things like thrown daggers, 810 * when they hit the victim. For things like thrown daggers,
850 * this sets 'hitter' to the actual dagger, and not the 811 * this sets 'hitter' to the actual dagger, and not the
851 * wrapper object. 812 * wrapper object.
852 */ 813 */
853 thrown_item_effect (hitter, op); 814 thrown_item_effect (hitter, op);
815
854 if (was_destroyed (hitter, hitter_tag) || was_destroyed (op, op_tag) || abort_attack (op, hitter, simple_attack)) 816 if (hitter->destroyed () || op->destroyed () || abort_attack (op, hitter, simple_attack))
855 goto leave; 817 goto leave;
856 } 818 }
857 819
858 /* Need to do at least 1 damage, otherwise there is no point 820 /* Need to do at least 1 damage, otherwise there is no point
859 * to go further and it will cause FPE's below. 821 * to go further and it will cause FPE's below.
860 */ 822 */
861 if (hitdam <= 0) 823 if (hitdam <= 0)
862 hitdam = 1; 824 hitdam = 1;
863 825
864 type = hitter->attacktype; 826 type = hitter->attacktype;
827
865 if (!type) 828 if (!type)
866 type = AT_PHYSICAL; 829 type = AT_PHYSICAL;
830
867 /* Handle monsters that hit back */ 831 /* Handle monsters that hit back */
868 if (!simple_attack && QUERY_FLAG (op, FLAG_HITBACK) && QUERY_FLAG (hitter, FLAG_ALIVE)) 832 if (!simple_attack && QUERY_FLAG (op, FLAG_HITBACK) && QUERY_FLAG (hitter, FLAG_ALIVE))
869 { 833 {
870 if (op->attacktype & AT_ACID && hitter->type == PLAYER) 834 if (op->attacktype & AT_ACID && hitter->type == PLAYER)
871 new_draw_info (NDI_UNIQUE, 0, hitter, "You are splashed by acid!\n"); 835 new_draw_info (NDI_UNIQUE, 0, hitter, "You are splashed by acid!\n");
836
872 hit_player (hitter, random_roll (0, (op->stats.dam), hitter, PREFER_LOW), op, op->attacktype, 1); 837 hit_player (hitter, random_roll (0, (op->stats.dam), hitter, PREFER_LOW), op, op->attacktype, 1);
838
873 if (was_destroyed (op, op_tag) || was_destroyed (hitter, hitter_tag) || abort_attack (op, hitter, simple_attack)) 839 if (op->destroyed () || hitter->destroyed () || abort_attack (op, hitter, simple_attack))
874 goto leave; 840 goto leave;
875 } 841 }
876 842
877 /* In the new attack code, it should handle multiple attack 843 /* In the new attack code, it should handle multiple attack
878 * types in its area, so remove it from here. 844 * types in its area, so remove it from here.
879 */ 845 */
880 dam = hit_player (op, random_roll (1, hitdam, hitter, PREFER_HIGH), hitter, type, 1); 846 dam = hit_player (op, random_roll (1, hitdam, hitter, PREFER_HIGH), hitter, type, 1);
847
881 if (was_destroyed (op, op_tag) || was_destroyed (hitter, hitter_tag) || abort_attack (op, hitter, simple_attack)) 848 if (op->destroyed () || hitter->destroyed () || abort_attack (op, hitter, simple_attack))
882 goto leave; 849 goto leave;
883 } /* end of if hitter hit op */ 850 } /* end of if hitter hit op */
884 /* if we missed, dam=0 */ 851 /* if we missed, dam=0 */
885 852
886 /*attack_message(dam, type, op, hitter); */ 853 /*attack_message(dam, type, op, hitter); */
… …
896} 863}
897 864
898int 865int
899attack_ob (object *op, object *hitter) 866attack_ob (object *op, object *hitter)
900{ 867{
901
902 if (hitter->head)
903 hitter = hitter->head; 868 hitter = hitter->head_ ();
869
904 return attack_ob_simple (op, hitter, hitter->stats.dam, hitter->stats.wc); 870 return attack_ob_simple (op, hitter, hitter->stats.dam, hitter->stats.wc);
905} 871}
906 872
907/* op is the arrow, tmp is what is stopping the arrow. 873/* op is the arrow, tmp is what is stopping the arrow.
908 * 874 *
… …
917 * debate - 5000 is 5 kg, so arrows, knives, and other light weapons 883 * debate - 5000 is 5 kg, so arrows, knives, and other light weapons
918 * stick around. 884 * stick around.
919 */ 885 */
920 if (op->weight <= 5000 && tmp->stats.hp >= 0) 886 if (op->weight <= 5000 && tmp->stats.hp >= 0)
921 { 887 {
922 if (tmp->head != NULL) 888 tmp->head_ ()->insert (op);
923 tmp = tmp->head;
924
925 remove_ob (op);
926 op = insert_ob_in_ob (op, tmp);
927
928 if (tmp->type == PLAYER)
929 esrv_send_item (tmp, op);
930
931 return 1; 889 return 1;
932 } 890 }
933 else 891 else
934 return 0; 892 return 0;
935} 893}
… …
943object * 901object *
944hit_with_arrow (object *op, object *victim) 902hit_with_arrow (object *op, object *victim)
945{ 903{
946 object *container, *hitter; 904 object *container, *hitter;
947 int hit_something = 0; 905 int hit_something = 0;
948 tag_t victim_tag, hitter_tag;
949 sint16 victim_x, victim_y;
950 906
951 /* Disassemble missile */ 907 /* Disassemble missile */
952 if (op->inv) 908 if (op->inv)
953 { 909 {
954 container = op; 910 container = op;
955 hitter = op->inv; 911 hitter = op->inv;
956 remove_ob (hitter);
957 insert_ob_in_map (hitter, container->map, hitter, INS_NO_MERGE | INS_NO_WALK_ON); 912 hitter->insert_at (container, hitter, INS_NO_MERGE | INS_NO_WALK_ON);
958 /* Note that we now have an empty THROWN_OBJ on the map. Code that 913 /* Note that we now have an empty THROWN_OBJ on the map. Code that
959 * might be called until this THROWN_OBJ is either reassembled or 914 * might be called until this THROWN_OBJ is either reassembled or
960 * removed at the end of this function must be able to deal with empty 915 * removed at the end of this function must be able to deal with empty
961 * THROWN_OBJs. */ 916 * THROWN_OBJs. */
962 } 917 }
963 else 918 else
964 { 919 {
965 container = NULL; 920 container = 0;
966 hitter = op; 921 hitter = op;
967 } 922 }
968 923
969 /* Try to hit victim */ 924 /* Try to hit victim */
970 victim_x = victim->x;
971 victim_y = victim->y;
972 victim_tag = victim->count;
973 hitter_tag = hitter->count;
974
975 hit_something = attack_ob_simple (victim, hitter, op->stats.dam, op->stats.wc); 925 hit_something = attack_ob_simple (victim, hitter, op->stats.dam, op->stats.wc);
976 926
977 /* Arrow attacks door, rune of summoning is triggered, demon is put on 927 /* Arrow attacks door, rune of summoning is triggered, demon is put on
978 * arrow, move_apply() calls this function, arrow sticks in demon, 928 * arrow, move_apply() calls this function, arrow sticks in demon,
979 * attack_ob_simple() returns, and we've got an arrow that still exists 929 * attack_ob_simple() returns, and we've got an arrow that still exists
980 * but is no longer on the map. Ugh. (Beware: Such things can happen at 930 * but is no longer on the map. Ugh. (Beware: Such things can happen at
981 * other places as well!) 931 * other places as well!)
982 */ 932 */
983 if (was_destroyed (hitter, hitter_tag) || hitter->env != NULL) 933 if (hitter->destroyed () || hitter->env != NULL)
984 { 934 {
985 if (container) 935 if (container)
986 { 936 container->destroy ();
987 remove_ob (container); 937
988 free_object (container);
989 }
990 return NULL; 938 return 0;
991 } 939 }
992 940
993 /* Missile hit victim */ 941 /* Missile hit victim */
994 /* if the speed is > 10, then this is a fast moving arrow, we go straight 942 /* if the speed is > 10, then this is a fast moving arrow, we go straight
995 * through the target 943 * through the target
996 */ 944 */
997 if (hit_something && op->speed <= 10.0) 945 if (hit_something && op->speed <= 10.0)
998 { 946 {
999 /* Stop arrow */ 947 /* Stop arrow */
1000 if (container == NULL) 948 if (!container)
1001 { 949 {
1002 hitter = fix_stopped_arrow (hitter); 950 hitter = fix_stopped_arrow (hitter);
1003 if (hitter == NULL) 951 if (!hitter)
1004 return NULL; 952 return 0;
1005 } 953 }
1006 else 954 else
1007 { 955 container->destroy ();
1008 remove_ob (container);
1009 free_object (container);
1010 }
1011 956
1012 /* Try to stick arrow into victim */ 957 /* Try to stick arrow into victim */
1013 if (!was_destroyed (victim, victim_tag) && stick_arrow (hitter, victim)) 958 if (!victim->destroyed () && stick_arrow (hitter, victim))
1014 return NULL; 959 return 0;
1015 960
1016 /* Else try to put arrow on victim's map square 961 /* Else try to put arrow on victim's map square
1017 * remove check for P_WALL here. If the arrow got to this 962 * remove check for P_WALL here. If the arrow got to this
1018 * space, that is good enough - with the new movement code, 963 * space, that is good enough - with the new movement code,
1019 * there is now the potential for lots of spaces where something 964 * there is now the potential for lots of spaces where something
1020 * can fly over but not otherwise move over. What is the correct 965 * can fly over but not otherwise move over. What is the correct
1021 * way to handle those otherwise? 966 * way to handle those otherwise?
1022 */ 967 */
1023 if (victim_x != hitter->x || victim_y != hitter->y) 968 if (victim->x != hitter->x || victim->y != hitter->y)
969 {
970 if (victim->destroyed ())
971 hitter->destroy ();
972 else
1024 { 973 {
1025 remove_ob (hitter); 974 hitter->remove ();
1026 hitter->x = victim_x; 975 hitter->x = victim->x;
1027 hitter->y = victim_y; 976 hitter->y = victim->y;
1028 insert_ob_in_map (hitter, victim->map, hitter, 0); 977 insert_ob_in_map (hitter, victim->map, hitter, 0);
978 }
1029 } 979 }
1030 else 980 else
1031 {
1032 /* Else leave arrow where it is */ 981 /* Else leave arrow where it is */
1033 merge_ob (hitter, NULL); 982 merge_ob (hitter, NULL);
1034 } 983
1035 return NULL; 984 return 0;
1036 } 985 }
1037 986
1038 if (hit_something && op->speed >= 10.0) 987 if (hit_something && op->speed >= 10.0)
1039 op->speed -= 1.0; 988 op->speed -= 1.0;
1040 989
1041 /* Missile missed victim - reassemble missile */ 990 /* Missile missed victim - reassemble missile */
1042 if (container) 991 if (container)
1043 { 992 {
1044 remove_ob (hitter); 993 hitter->remove ();
1045 insert_ob_in_ob (hitter, container); 994 insert_ob_in_ob (hitter, container);
1046 } 995 }
996
1047 return op; 997 return op;
1048} 998}
1049
1050 999
1051void 1000void
1052tear_down_wall (object *op) 1001tear_down_wall (object *op)
1053{ 1002{
1054 int perc = 0; 1003 int perc = 0;
… …
1060 } 1009 }
1061 else if (!GET_ANIM_ID (op)) 1010 else if (!GET_ANIM_ID (op))
1062 { 1011 {
1063 /* Object has been called - no animations, so remove it */ 1012 /* Object has been called - no animations, so remove it */
1064 if (op->stats.hp < 0) 1013 if (op->stats.hp < 0)
1014 op->destroy ();
1065 { 1015
1066 remove_ob (op); /* Should update LOS */
1067 free_object (op);
1068 /* Don't know why this is here - remove_ob should do it for us */
1069 /*update_position(m, x, y); */
1070 }
1071 return; /* no animations, so nothing more to do */ 1016 return; /* no animations, so nothing more to do */
1072 } 1017 }
1018
1073 perc = NUM_ANIMATIONS (op) - ((int) NUM_ANIMATIONS (op) * op->stats.hp) / op->stats.maxhp; 1019 perc = NUM_ANIMATIONS (op) - ((int) NUM_ANIMATIONS (op) * op->stats.hp) / op->stats.maxhp;
1020
1074 if (perc >= (int) NUM_ANIMATIONS (op)) 1021 if (perc >= (int) NUM_ANIMATIONS (op))
1075 perc = NUM_ANIMATIONS (op) - 1; 1022 perc = NUM_ANIMATIONS (op) - 1;
1076 else if (perc < 1) 1023 else if (perc < 1)
1077 perc = 1; 1024 perc = 1;
1025
1078 SET_ANIMATION (op, perc); 1026 SET_ANIMATION (op, perc);
1079 update_object (op, UP_OBJ_FACE); 1027 update_object (op, UP_OBJ_FACE);
1028
1080 if (perc == NUM_ANIMATIONS (op) - 1) 1029 if (perc == NUM_ANIMATIONS (op) - 1)
1081 { /* Reached the last animation */ 1030 { /* Reached the last animation */
1082 if (op->face == blank_face) 1031 if (op->face == blank_face)
1083 {
1084 /* If the last face is blank, remove the ob */ 1032 /* If the last face is blank, remove the ob */
1085 remove_ob (op); /* Should update LOS */ 1033 op->destroy ();
1086 free_object (op);
1087
1088 /* remove_ob should call update_position for us */
1089 /*update_position(m, x, y); */
1090
1091 }
1092 else 1034 else
1093 { /* The last face was not blank, leave an image */ 1035 { /* The last face was not blank, leave an image */
1094 CLEAR_FLAG (op, FLAG_BLOCKSVIEW); 1036 CLEAR_FLAG (op, FLAG_BLOCKSVIEW);
1095 update_all_los (op->map, op->x, op->y); 1037 update_all_los (op->map, op->x, op->y);
1096 op->move_block = 0; 1038 op->move_block = 0;
… …
1100} 1042}
1101 1043
1102void 1044void
1103scare_creature (object *target, object *hitter) 1045scare_creature (object *target, object *hitter)
1104{ 1046{
1105 object *owner = get_owner (hitter); 1047 object *owner = hitter->owner;
1106 1048
1107 if (!owner) 1049 if (!owner)
1108 owner = hitter; 1050 owner = hitter;
1109 1051
1110 SET_FLAG (target, FLAG_SCARED); 1052 SET_FLAG (target, FLAG_SCARED);
1111 if (!target->enemy) 1053 if (!target->enemy)
1112 target->enemy = owner; 1054 target->enemy = owner;
1113} 1055}
1114
1115 1056
1116/* This returns the amount of damage hitter does to op with the 1057/* This returns the amount of damage hitter does to op with the
1117 * appropriate attacktype. Only 1 attacktype should be set at a time. 1058 * appropriate attacktype. Only 1 attacktype should be set at a time.
1118 * This doesn't damage the player, but returns how much it should 1059 * This doesn't damage the player, but returns how much it should
1119 * take. However, it will do other effects (paralyzation, slow, etc.) 1060 * take. However, it will do other effects (paralyzation, slow, etc.)
1120 * Note - changed for PR code - we now pass the attack number and not 1061 * Note - changed for PR code - we now pass the attack number and not
1121 * the attacktype. Makes it easier for the PR code. */ 1062 * the attacktype. Makes it easier for the PR code. */
1122
1123int 1063int
1124hit_player_attacktype (object *op, object *hitter, int dam, uint32 attacknum, int magic) 1064hit_player_attacktype (object *op, object *hitter, int dam, uint32 attacknum, int magic)
1125{ 1065{
1126
1127 int doesnt_slay = 1; 1066 int doesnt_slay = 1;
1128 1067
1129 /* Catch anyone that may be trying to send us a bitmask instead of the number */ 1068 /* Catch anyone that may be trying to send us a bitmask instead of the number */
1130 if (attacknum >= NROFATTACKS) 1069 if (attacknum >= NROFATTACKS)
1131 { 1070 {
… …
1133 return 0; 1072 return 0;
1134 } 1073 }
1135 1074
1136 if (dam < 0) 1075 if (dam < 0)
1137 { 1076 {
1138 LOG (llevError, "hit_player_attacktype called with negative damage: %d\n", dam); 1077 LOG (llevError, "hit_player_attacktype called with negative damage %d (hitter %s, target %s)\n",
1078 dam, hitter->debug_desc (), op->debug_desc ());
1139 return 0; 1079 return 0;
1140 } 1080 }
1141 1081
1142 /* AT_INTERNAL is supposed to do exactly dam. Put a case here so 1082 /* AT_INTERNAL is supposed to do exactly dam. Put a case here so
1143 * people can't mess with that or it otherwise get confused. */ 1083 * people can't mess with that or it otherwise get confused. */
1144 if (attacknum == ATNR_INTERNAL) 1084 if (attacknum == ATNR_INTERNAL)
1145 return dam; 1085 return dam;
1146 1086
1147 if (hitter->slaying) 1087 if (hitter->slaying)
1148 { 1088 {
1149 if (((op->race != NULL) && strstr (hitter->slaying, op->race)) || 1089 if ((op->race && hitter->slaying.contains (op->race))
1150 (op->arch && (op->arch->name != NULL) && strstr (op->arch->name, hitter->slaying))) 1090 || (op->arch && op->arch->archname.contains (hitter->slaying)))
1151 { 1091 {
1152 doesnt_slay = 0; 1092 doesnt_slay = 0;
1153 dam *= 3; 1093 dam *= 3;
1154 } 1094 }
1155 } 1095 }
… …
1169 /* Special hack. By default, if immune to something, you 1109 /* Special hack. By default, if immune to something, you
1170 * shouldn't need to worry. However, acid is an exception, since 1110 * shouldn't need to worry. However, acid is an exception, since
1171 * it can still damage your items. Only include attacktypes if 1111 * it can still damage your items. Only include attacktypes if
1172 * special processing is needed */ 1112 * special processing is needed */
1173 1113
1174 if ((op->resist[attacknum] >= 100) && doesnt_slay && (attacknum != ATNR_ACID)) 1114 if (op->resist[attacknum] >= 100
1115 && doesnt_slay
1116 && attacknum != ATNR_ACID)
1175 return 0; 1117 return 0;
1176 1118
1177 /* Keep this in order - makes things easier to find */ 1119 /* Keep this in order - makes things easier to find */
1178 1120
1179 switch (attacknum) 1121 switch (attacknum)
1180 { 1122 {
1181 case ATNR_PHYSICAL: 1123 case ATNR_PHYSICAL:
1182 /* here also check for diseases */ 1124 /* here also check for diseases */
1183 check_physically_infect (op, hitter); 1125 check_physically_infect (op, hitter);
1184 break; 1126 break;
1185 1127
1186 /* Don't need to do anything for: 1128 /* Don't need to do anything for:
1187 magic, 1129 magic,
1188 fire, 1130 fire,
1189 electricity, 1131 electricity,
1190 cold */ 1132 cold */
1191 1133
1192 case ATNR_CONFUSION: 1134 case ATNR_CONFUSION:
1193 case ATNR_POISON: 1135 case ATNR_POISON:
1194 case ATNR_SLOW: 1136 case ATNR_SLOW:
1195 case ATNR_PARALYZE: 1137 case ATNR_PARALYZE:
1196 case ATNR_FEAR: 1138 case ATNR_FEAR:
1197 case ATNR_CANCELLATION: 1139 case ATNR_CANCELLATION:
1198 case ATNR_DEPLETE: 1140 case ATNR_DEPLETE:
1199 case ATNR_BLIND: 1141 case ATNR_BLIND:
1200 { 1142 {
1201 /* chance for inflicting a special attack depends on the 1143 /* chance for inflicting a special attack depends on the
1202 * difference between attacker's and defender's level 1144 * difference between attacker's and defender's level
1203 */ 1145 */
1204 int level_diff = MIN (110, MAX (0, op->level - hitter->level)); 1146 int level_diff = MIN (110, MAX (0, op->level - hitter->level));
1205 1147
1206 /* First, only creatures/players with speed can be affected. 1148 /* First, only creatures/players with speed can be affected.
1207 * Second, just getting hit doesn't mean it always affects 1149 * Second, just getting hit doesn't mean it always affects
1208 * you. Third, you still get a saving through against the 1150 * you. Third, you still get a saving through against the
1209 * effect. 1151 * effect.
1210 */ 1152 */
1211 if (op->speed && 1153 if (op->speed &&
1212 (QUERY_FLAG (op, FLAG_MONSTER) || op->type == PLAYER) && 1154 (QUERY_FLAG (op, FLAG_MONSTER) || op->type == PLAYER) &&
1213 !(rndm (0, (attacknum == ATNR_SLOW ? 6 : 3) - 1)) && !did_make_save (op, level_diff, op->resist[attacknum] / 10)) 1155 !(rndm (0, (attacknum == ATNR_SLOW ? 6 : 3) - 1)) && !did_make_save (op, level_diff, op->resist[attacknum] / 10))
1214 { 1156 {
1215 1157
1216 /* Player has been hit by something */ 1158 /* Player has been hit by something */
1217 if (attacknum == ATNR_CONFUSION) 1159 if (attacknum == ATNR_CONFUSION)
1218 confuse_player (op, hitter, dam); 1160 confuse_player (op, hitter, dam);
1219 else if (attacknum == ATNR_POISON) 1161 else if (attacknum == ATNR_POISON)
1220 poison_player (op, hitter, dam); 1162 poison_player (op, hitter, dam);
1221 else if (attacknum == ATNR_SLOW) 1163 else if (attacknum == ATNR_SLOW)
1222 slow_player (op, hitter, dam); 1164 slow_player (op, hitter, dam);
1223 else if (attacknum == ATNR_PARALYZE) 1165 else if (attacknum == ATNR_PARALYZE)
1224 paralyze_player (op, hitter, dam); 1166 paralyze_player (op, hitter, dam);
1225 else if (attacknum == ATNR_FEAR) 1167 else if (attacknum == ATNR_FEAR)
1226 scare_creature (op, hitter); 1168 scare_creature (op, hitter);
1227 else if (attacknum == ATNR_CANCELLATION) 1169 else if (attacknum == ATNR_CANCELLATION)
1228 cancellation (op); 1170 cancellation (op);
1229 else if (attacknum == ATNR_DEPLETE) 1171 else if (attacknum == ATNR_DEPLETE)
1230 drain_stat (op); 1172 op->drain_stat ();
1231 else if (attacknum == ATNR_BLIND && !QUERY_FLAG (op, FLAG_UNDEAD) && !QUERY_FLAG (op, FLAG_GENERATOR)) 1173 else if (attacknum == ATNR_BLIND && !QUERY_FLAG (op, FLAG_UNDEAD) && !QUERY_FLAG (op, FLAG_GENERATOR))
1232 blind_player (op, hitter, dam); 1174 blind_player (op, hitter, dam);
1233 } 1175 }
1176
1234 dam = 0; /* These are all effects and don't do real damage */ 1177 dam = 0; /* These are all effects and don't do real damage */
1235 } 1178 }
1236 break; 1179 break;
1180
1237 case ATNR_ACID: 1181 case ATNR_ACID:
1238 { 1182 {
1239 int flag = 0; 1183 int flag = 0;
1240 1184
1241 /* Items only get corroded if you're not on a battleground and 1185 /* Items only get corroded if you're not on a battleground and
1242 * if your acid resistance is below 50%. */ 1186 * if your acid resistance is below 50%. */
1243 if (!op_on_battleground (op, NULL, NULL) && (op->resist[ATNR_ACID] < 50)) 1187 if (!op_on_battleground (op, NULL, NULL) && (op->resist[ATNR_ACID] < 50))
1244 { 1188 {
1245 object *tmp;
1246
1247 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1189 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1248 { 1190 {
1249 if (tmp->invisible) 1191 if (tmp->invisible)
1250 continue; 1192 continue;
1251 if (!QUERY_FLAG (tmp, FLAG_APPLIED) || (tmp->resist[ATNR_ACID] >= 10)) 1193 if (!QUERY_FLAG (tmp, FLAG_APPLIED) || (tmp->resist[ATNR_ACID] >= 10))
1252 /* >= 10% acid res. on itmes will protect these */ 1194 /* >= 10% acid res. on items will protect these */
1253 continue; 1195 continue;
1254 if (!(tmp->material & M_IRON)) 1196 if (!(tmp->materials & M_IRON))
1255 continue; 1197 continue;
1256 if (tmp->magic < -4) /* Let's stop at -5 */ 1198 if (tmp->magic < -4) /* Let's stop at -5 */
1257 continue; 1199 continue;
1258 if (tmp->type == RING || 1200 if (tmp->type == RING
1259 /* removed boots and gloves from exclusion list in 1201 /* removed boots and gloves from exclusion list in PR */
1260 PR */ 1202 || tmp->type == GIRDLE
1261 tmp->type == GIRDLE || tmp->type == AMULET || tmp->type == WAND || tmp->type == ROD || tmp->type == HORN) 1203 || tmp->type == AMULET
1204 || tmp->type == WAND
1205 || tmp->type == ROD
1206 || tmp->type == HORN)
1262 continue; /* To avoid some strange effects */ 1207 continue; /* To avoid some strange effects */
1263 1208
1264 /* High damage acid has better chance of corroding 1209 /* High damage acid has better chance of corroding
1265 objects */ 1210 objects */
1266 if (rndm (0, dam + 4) > random_roll (0, 39, op, PREFER_HIGH) + 2 * tmp->magic) 1211 if (rndm (0, dam + 4) > random_roll (0, 39, op, PREFER_HIGH) + 2 * tmp->magic)
1212 {
1213 flag = 1;
1214 tmp->magic--;
1215
1216 if (object *pl = tmp->visible_to ())
1267 { 1217 {
1268 if (op->type == PLAYER)
1269 /* Make this more visible */ 1218 /* Make this more visible */
1270 new_draw_info_format (NDI_UNIQUE | NDI_RED, 0, op, 1219 new_draw_info_format (NDI_UNIQUE | NDI_RED, 0, pl,
1271 "The %s's acid corrodes your %s!", query_name (hitter), query_name (tmp)); 1220 "The %s's acid corrodes your %s!", query_name (hitter), query_name (tmp));
1272 flag = 1; 1221
1273 tmp->magic--; 1222 esrv_send_item (op, tmp); //TODO: UPD_NAME should be enough (it's enough in other cases)
1274 if (op->type == PLAYER)
1275 esrv_send_item (op, tmp);
1276 } 1223 }
1277 } 1224 }
1278 if (flag) 1225 }
1279 fix_player (op); /* Something was corroded */
1280 } 1226
1227 if (flag)
1228 op->update_stats (); /* Something was corroded */
1281 } 1229 }
1230 }
1282 break; 1231 break;
1232
1283 case ATNR_DRAIN: 1233 case ATNR_DRAIN:
1284 { 1234 {
1285 /* rate is the proportion of exp drained. High rate means 1235 /* rate is the proportion of exp drained. High rate means
1286 * not much is drained, low rate means a lot is drained. 1236 * not much is drained, low rate means a lot is drained.
1287 */ 1237 */
1288 int rate; 1238 int rate;
1289 1239
1290 if (op->resist[ATNR_DRAIN] >= 0) 1240 if (op->resist[ATNR_DRAIN] >= 0)
1291 rate = 400 + op->resist[ATNR_DRAIN] * 3; 1241 rate = 400 + op->resist[ATNR_DRAIN] * 3;
1292 else 1242 else
1293 rate = 400 * 100 / (100 - op->resist[ATNR_DRAIN]); 1243 rate = 400 * 100 / (100 - op->resist[ATNR_DRAIN]);
1294 1244
1295 if (op->stats.exp <= rate) 1245 if (op->stats.exp <= rate)
1296 { 1246 {
1297 if (op->type == GOLEM) 1247 if (op->type == GOLEM)
1298 dam = 999; /* Its force is "sucked" away. 8) */ 1248 dam = 999; /* Its force is "sucked" away. 8) */
1299 else 1249 else
1300 /* If we can't drain, lets try to do physical damage */ 1250 /* If we can't drain, lets try to do physical damage */
1301 dam = hit_player_attacktype (op, hitter, dam, ATNR_PHYSICAL, magic); 1251 dam = hit_player_attacktype (op, hitter, dam, ATNR_PHYSICAL, magic);
1302 } 1252 }
1303 else 1253 else
1304 { 1254 {
1305 /* Randomly give the hitter some hp */ 1255 /* Randomly give the hitter some hp */
1306 if (hitter->stats.hp < hitter->stats.maxhp && 1256 if (hitter->stats.hp < hitter->stats.maxhp &&
1307 (op->level > hitter->level) && random_roll (0, (op->level - hitter->level + 2), hitter, PREFER_HIGH) > 3) 1257 (op->level > hitter->level) && random_roll (0, (op->level - hitter->level + 2), hitter, PREFER_HIGH) > 3)
1308 hitter->stats.hp++; 1258 hitter->stats.hp++;
1309 1259
1310 /* Can't do drains on battleground spaces. 1260 /* Can't do drains on battleground spaces.
1311 * Move the wiz check up here - before, the hitter wouldn't gain exp 1261 * Move the wiz check up here - before, the hitter wouldn't gain exp
1312 * exp, but the wiz would still lose exp! If drainee is a wiz, 1262 * exp, but the wiz would still lose exp! If drainee is a wiz,
1313 * nothing happens. 1263 * nothing happens.
1314 * Try to credit the owner. We try to display player -> player drain 1264 * Try to credit the owner. We try to display player -> player drain
1315 * attacks, hence all the != PLAYER checks. 1265 * attacks, hence all the != PLAYER checks.
1316 */ 1266 */
1317 if (!op_on_battleground (hitter, NULL, NULL) && !QUERY_FLAG (op, FLAG_WAS_WIZ)) 1267 if (!op_on_battleground (hitter, NULL, NULL) && !QUERY_FLAG (op, FLAG_WIZ))
1318 { 1268 {
1319 object *owner = get_owner (hitter); 1269 object *owner = hitter->owner;
1320 1270
1321 if (owner && owner != hitter) 1271 if (owner && owner != hitter)
1322 { 1272 {
1323 if (op->type != PLAYER || owner->type != PLAYER) 1273 if (op->type != PLAYER || owner->type != PLAYER)
1324 change_exp (owner, op->stats.exp / (rate * 2), 1274 change_exp (owner, op->stats.exp / (rate * 2),
1325 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, SK_EXP_TOTAL); 1275 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, SK_EXP_TOTAL);
1326 } 1276 }
1327 else if (op->type != PLAYER || hitter->type != PLAYER) 1277 else if (op->type != PLAYER || hitter->type != PLAYER)
1328 {
1329 change_exp (hitter, op->stats.exp / (rate * 2), 1278 change_exp (hitter, op->stats.exp / (rate * 2),
1330 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, 0); 1279 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, 0);
1331 } 1280
1332 change_exp (op, -op->stats.exp / rate, NULL, 0); 1281 change_exp (op, -op->stats.exp / rate, NULL, 0);
1333 } 1282 }
1283
1334 dam = 1; /* Drain is an effect. Still return 1 - otherwise, if you have pure 1284 dam = 1; /* Drain is an effect. Still return 1 - otherwise, if you have pure
1335 * drain attack, you won't know that you are actually sucking out EXP, 1285 * drain attack, you won't know that you are actually sucking out EXP,
1336 * as the messages will say you missed 1286 * as the messages will say you missed
1337 */ 1287 */
1338 } 1288 }
1339 } 1289 }
1340 break; 1290 break;
1291
1341 case ATNR_TURN_UNDEAD: 1292 case ATNR_TURN_UNDEAD:
1342 { 1293 {
1343 if (QUERY_FLAG (op, FLAG_UNDEAD)) 1294 if (QUERY_FLAG (op, FLAG_UNDEAD))
1344 { 1295 {
1345 object *owner = hitter->owner ? (object *)hitter->owner : hitter; 1296 object *owner = hitter->owner ? (object *)hitter->owner : hitter;
1346 object *god = find_god (determine_god (owner)); 1297 object *god = find_god (determine_god (owner));
1347 int div = 1; 1298 int div = 1;
1348 1299
1349 /* if undead are not an enemy of your god, you turn them 1300 /* if undead are not an enemy of your god, you turn them
1350 * at half strength */ 1301 * at half strength */
1351 if (!god || !god->slaying || strstr (god->slaying, undead_name) == NULL) 1302 if (!god || !god->slaying.contains (shstr_undead))
1352 div = 2; 1303 div = 2;
1304
1353 /* Give a bonus if you resist turn undead */ 1305 /* Give a bonus if you resist turn undead */
1354 if (op->level * div < (turn_bonus[owner->stats.Wis] + owner->level + (op->resist[ATNR_TURN_UNDEAD] / 100))) 1306 if (op->level * div < (turn_bonus[owner->stats.Wis] + owner->level + (op->resist[ATNR_TURN_UNDEAD] / 100)))
1355 scare_creature (op, owner); 1307 scare_creature (op, owner);
1356 } 1308 }
1357 else 1309 else
1358 dam = 0; /* don't damage non undead - should we damage 1310 dam = 0; /* don't damage non undead - should we damage
1359 undead? */ 1311 undead? */
1360 } 1312 }
1361 break; 1313 break;
1314
1362 case ATNR_DEATH: 1315 case ATNR_DEATH:
1363 deathstrike_player (op, hitter, &dam); 1316 deathstrike_player (op, hitter, &dam);
1364 break; 1317 break;
1318
1365 case ATNR_CHAOS: 1319 case ATNR_CHAOS:
1366 LOG (llevError, "%s was hit by %s with non-specific chaos.\n", query_name (op), query_name (hitter)); 1320 LOG (llevError, "%s was hit by %s with non-specific chaos.\n", op->debug_desc (), hitter->debug_desc ());
1367 dam = 0; 1321 dam = 0;
1368 break; 1322 break;
1323
1369 case ATNR_COUNTERSPELL: 1324 case ATNR_COUNTERSPELL:
1370 LOG (llevError, "%s was hit by %s with counterspell attack.\n", query_name (op), query_name (hitter)); 1325 LOG (llevError, "%s was hit by %s with counterspell attack.\n", op->debug_desc (), hitter->debug_desc ());
1371 dam = 0; 1326 dam = 0;
1372 /* This should never happen. Counterspell is handled 1327 /* This should never happen. Counterspell is handled
1373 * seperately and filtered out. If this does happen, 1328 * seperately and filtered out. If this does happen,
1374 * Counterspell has no effect on anything but spells, so it 1329 * Counterspell has no effect on anything but spells, so it
1375 * does no damage. */ 1330 * does no damage. */
1376 break; 1331 break;
1332
1377 case ATNR_HOLYWORD: 1333 case ATNR_HOLYWORD:
1378 { 1334 {
1379 /* This has already been handled by hit_player, 1335 /* This has already been handled by hit_player,
1380 * no need to check twice -- DAMN */ 1336 * no need to check twice -- DAMN */
1381 object *owner = hitter->owner ? (object *)hitter->owner : hitter; 1337 object *owner = hitter->owner ? (object *)hitter->owner : hitter;
1382 1338
1383 /* As with turn undead above, give a bonus on the saving throw */ 1339 /* As with turn undead above, give a bonus on the saving throw */
1384 if ((op->level + (op->resist[ATNR_HOLYWORD] / 100)) < owner->level + turn_bonus[owner->stats.Wis]) 1340 if ((op->level + (op->resist[ATNR_HOLYWORD] / 100)) < owner->level + turn_bonus[owner->stats.Wis])
1385 scare_creature (op, owner); 1341 scare_creature (op, owner);
1386 } 1342 }
1387 break; 1343 break;
1344
1388 case ATNR_LIFE_STEALING: 1345 case ATNR_LIFE_STEALING:
1389 { 1346 {
1390 int new_hp; 1347 int new_hp;
1391 1348
1392 /* this is replacement to drain for players, instead of taking 1349 /* this is replacement to drain for players, instead of taking
1393 * exp it takes hp. It is geared for players, probably not 1350 * exp it takes hp. It is geared for players, probably not
1394 * much use giving it to monsters 1351 * much use giving it to monsters
1395 * 1352 *
1396 * life stealing doesn't do a lot of damage, but it gives the 1353 * life stealing doesn't do a lot of damage, but it gives the
1397 * damage it does do to the player. Given that, 1354 * damage it does do to the player. Given that,
1398 * it only does 1/10'th normal damage (hence the divide by 1355 * it only does 1/10'th normal damage (hence the divide by
1399 * 1000). 1356 * 1000).
1400 */ 1357 */
1401 /* You can't steal life from something undead */ 1358 /* You can't steal life from something undead */
1402 if ((op->type == GOLEM) || (QUERY_FLAG (op, FLAG_UNDEAD))) 1359 if ((op->type == GOLEM) || (QUERY_FLAG (op, FLAG_UNDEAD)))
1403 return 0; 1360 return 0;
1361
1404 /* If drain protection is higher than life stealing, use that */ 1362 /* If drain protection is higher than life stealing, use that */
1405 if (op->resist[ATNR_DRAIN] >= op->resist[ATNR_LIFE_STEALING]) 1363 if (op->resist[ATNR_DRAIN] >= op->resist[ATNR_LIFE_STEALING])
1406 dam = (dam * (100 - op->resist[ATNR_DRAIN])) / 3000; 1364 dam = (dam * (100 - op->resist[ATNR_DRAIN])) / 3000;
1407 else 1365 else
1408 dam = (dam * (100 - op->resist[ATNR_LIFE_STEALING])) / 3000; 1366 dam = (dam * (100 - op->resist[ATNR_LIFE_STEALING])) / 3000;
1367
1409 /* You die at -1 hp, not zero. */ 1368 /* You die at -1 hp, not zero. */
1410 if (dam > (op->stats.hp + 1)) 1369 if (dam > (op->stats.hp + 1))
1411 dam = op->stats.hp + 1; 1370 dam = op->stats.hp + 1;
1371
1412 new_hp = hitter->stats.hp + dam; 1372 new_hp = hitter->stats.hp + dam;
1413 if (new_hp > hitter->stats.maxhp) 1373 if (new_hp > hitter->stats.maxhp)
1414 new_hp = hitter->stats.maxhp; 1374 new_hp = hitter->stats.maxhp;
1375
1415 if (new_hp > hitter->stats.hp) 1376 if (new_hp > hitter->stats.hp)
1416 hitter->stats.hp = new_hp; 1377 hitter->stats.hp = new_hp;
1417 } 1378 }
1418 } 1379 }
1380
1419 return dam; 1381 return dam;
1420} 1382}
1421
1422 1383
1423/* GROS: This code comes from hit_player. It has been made external to 1384/* GROS: This code comes from hit_player. It has been made external to
1424 * allow script procedures to "kill" objects in a combat-like fashion. 1385 * allow script procedures to "kill" objects in a combat-like fashion.
1425 * It was initially used by (kill-object) developed for the Collector's 1386 * It was initially used by (kill-object) developed for the Collector's
1426 * Sword. Note that nothing has been changed from the original version 1387 * Sword. Note that nothing has been changed from the original version
… …
1437 */ 1398 */
1438int 1399int
1439kill_object (object *op, int dam, object *hitter, int type) 1400kill_object (object *op, int dam, object *hitter, int type)
1440{ 1401{
1441 char buf[MAX_BUF]; 1402 char buf[MAX_BUF];
1442 const char *skill; 1403 shstr skill;
1443 int maxdam = 0; 1404 int maxdam = 0;
1444 int battleg = 0; /* true if op standing on battleground */ 1405 int battleg = 0; /* true if op standing on battleground */
1445 int pk = 0; /* true if op and what controls hitter are both players */ 1406 int pk = 0; /* true if op and what controls hitter are both players */
1446 object *owner = NULL; 1407 object *owner = 0;
1447 object *skop = NULL; 1408 object *skop = 0;
1448 1409
1449 if (op->stats.hp >= 0) 1410 if (op->stats.hp >= 0)
1450 return -1; 1411 return -1;
1451 1412
1452 if (INVOKE_OBJECT (KILL, op, ARG_OBJECT (hitter))) 1413 if (INVOKE_OBJECT (KILL, op, ARG_OBJECT (hitter)))
… …
1461 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW)) 1422 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW))
1462 update_all_los (op->map, op->x, op->y); /* makes sure los will be recalculated */ 1423 update_all_los (op->map, op->x, op->y); /* makes sure los will be recalculated */
1463 1424
1464 if (op->type == DOOR) 1425 if (op->type == DOOR)
1465 { 1426 {
1466 op->speed = 0.1; 1427 op->set_speed (0.1f);
1467 update_ob_speed (op);
1468 op->speed_left = -0.05; 1428 op->speed_left = -0.05f;
1469 return maxdam; 1429 return maxdam;
1470 } 1430 }
1431
1471 if (QUERY_FLAG (op, FLAG_FRIENDLY) && op->type != PLAYER) 1432 if (QUERY_FLAG (op, FLAG_FRIENDLY) && op->type != PLAYER)
1472 { 1433 {
1473 remove_friendly_object (op); 1434 op->drop_and_destroy ();
1474 if (get_owner (op) != NULL && op->owner->type == PLAYER && op->owner->contr->ranges[range_golem] == op)
1475 {
1476 op->owner->contr->ranges[range_golem] = NULL;
1477 op->owner->contr->golem_count = 0;
1478 }
1479
1480 remove_ob (op);
1481 free_object (op);
1482 return maxdam; 1435 return maxdam;
1483 } 1436 }
1484 1437
1485 /* Now lets start dealing with experience we get for killing something */ 1438 /* Now lets start dealing with experience we get for killing something */
1486 1439
1487 owner = get_owner (hitter); 1440 owner = hitter->outer_owner ();
1488 if (owner == NULL) 1441 if (!owner)
1489 owner = hitter; 1442 owner = hitter;
1490 1443
1491 /* is the victim (op) standing on battleground? */ 1444 /* is the victim (op) standing on battleground? */
1492 if (op_on_battleground (op, NULL, NULL)) 1445 if (op_on_battleground (op, NULL, NULL))
1493 battleg = 1; 1446 battleg = 1;
… …
1497 pk = 1; 1450 pk = 1;
1498 1451
1499 /* Player killed something */ 1452 /* Player killed something */
1500 if (owner->type == PLAYER) 1453 if (owner->type == PLAYER)
1501 { 1454 {
1502 Log_Kill (owner->name,
1503 query_name (op), op->type, (owner != hitter) ? query_name (hitter) : NULL, (owner != hitter) ? hitter->type : 0);
1504
1505 /* Log players killing other players - makes it easier to detect 1455 /* Log players killing other players - makes it easier to detect
1506 * and filter out malicious player killers - that is why the 1456 * and filter out malicious player killers - that is why the
1507 * ip address is included. 1457 * ip address is included.
1508 */ 1458 */
1509 if (op->type == PLAYER && !battleg) 1459 if (op->type == PLAYER && !battleg)
… …
1513 char buf[256]; 1463 char buf[256];
1514 1464
1515 tmv = localtime (&t); 1465 tmv = localtime (&t);
1516 strftime (buf, 256, "%a %b %d %H:%M:%S %Y", tmv); 1466 strftime (buf, 256, "%a %b %d %H:%M:%S %Y", tmv);
1517 1467
1518 LOG (llevInfo, "%s PLAYER_KILL_PLAYER: %s (%s) killed %s\n", buf, &owner->name, owner->contr->socket.host, query_name (op)); 1468 LOG (llevInfo, "%s PLAYER_KILL_PLAYER: %s (%s) killed %s\n", buf, &owner->name, owner->contr->ns->host, query_name (op));
1519 } 1469 }
1520 1470
1521 /* try to filter some things out - basically, if you are 1471 /* try to filter some things out - basically, if you are
1522 * killing a level 1 creature and your level 20, you 1472 * killing a level 1 creature and your level 20, you
1523 * probably don't want to see that. 1473 * probably don't want to see that.
1524 */ 1474 */
1525 if (owner->level < op->level * 2 || op->stats.exp > 1000) 1475 if (owner->level < op->level * 2 || op->stats.exp > 1000)
1526 { 1476 {
1527 if (owner != hitter) 1477 if (owner != hitter)
1528 {
1529 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s with %s.", query_name (op), query_name (hitter)); 1478 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s with %s.", query_name (op), query_name (hitter));
1530 }
1531 else 1479 else
1532 {
1533 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s.", query_name (op)); 1480 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s.", query_name (op));
1534 } 1481
1535 /* Only play sounds for melee kills */ 1482 /* Only play sounds for melee kills */
1536 if (hitter->type == PLAYER) 1483 if (hitter->type == PLAYER)
1537 play_sound_map (owner->map, owner->x, owner->y, SOUND_PLAYER_KILLS); 1484 owner->play_sound (sound_find ("player_kills"));
1538 } 1485 }
1539 1486
1540 /* If a player kills another player, not on 1487 /* If a player kills another player, not on
1541 * battleground, the "killer" looses 1 luck. Since this is 1488 * battleground, the "killer" looses 1 luck. Since this is
1542 * not reversible, it's actually quite a pain IMHO. -AV 1489 * not reversible, it's actually quite a pain IMHO. -AV
… …
1544 * player that the object belonged to - so if you killed another player 1491 * player that the object belonged to - so if you killed another player
1545 * with spells, pets, whatever, there was no penalty. 1492 * with spells, pets, whatever, there was no penalty.
1546 * Changed to make luck penalty configurable in settings. 1493 * Changed to make luck penalty configurable in settings.
1547 */ 1494 */
1548 if (op->type == PLAYER && owner != op && !battleg) 1495 if (op->type == PLAYER && owner != op && !battleg)
1549 change_luck (owner, -settings.pk_luck_penalty); 1496 owner->change_luck (-settings.pk_luck_penalty);
1550 1497
1551 /* This code below deals with finding the appropriate skill 1498 /* This code below deals with finding the appropriate skill
1552 * to credit exp to. This is a bit problematic - we should 1499 * to credit exp to. This is a bit problematic - we should
1553 * probably never really have to look at current_weapon->skill 1500 * probably never really have to look at current_weapon->skill
1554 */ 1501 */
1555 skill = NULL;
1556 if (hitter->skill && hitter->type != PLAYER) 1502 if (hitter->skill && hitter->type != PLAYER)
1557 skill = hitter->skill; 1503 skill = hitter->skill;
1558 else if (owner->chosen_skill) 1504 else if (owner->chosen_skill)
1559 { 1505 {
1560 skill = owner->chosen_skill->skill;
1561 skop = owner->chosen_skill; 1506 skop = owner->chosen_skill;
1507 skill = skop->skill;
1562 } 1508 }
1563 else if (QUERY_FLAG (owner, FLAG_READY_WEAPON)) 1509 else if (QUERY_FLAG (owner, FLAG_READY_WEAPON) && owner->current_weapon)
1564 skill = owner->current_weapon->skill; 1510 skill = owner->current_weapon->skill;
1565 else 1511 else
1512 {
1566 LOG (llevError, "kill_object - unable to find skill that killed monster\n"); 1513 LOG (llevError, "BUG: kill_object - unable to find skill that killed monster\n"
1514 "op: %s\n" "hitter: %s\n" "owner: %s\n",
1515 owner->debug_desc (), hitter->debug_desc (), op->debug_desc ());
1516 skill = 0;
1517 }
1567 1518
1568 /* We have the skill we want to credit to - now find the object this goes 1519 /* We have the skill we want to credit to - now find the object this goes
1569 * to. Make sure skop is an actual skill, and not a skill tool! 1520 * to. Make sure skop is an actual skill, and not a skill tool!
1570 */ 1521 */
1571 if ((!skop || skop->type != SKILL) && skill) 1522 skop = owner->contr->find_skill (skill);
1572 {
1573 int i;
1574
1575 for (i = 0; i < NUM_SKILLS; i++)
1576 if (owner->contr->last_skill_ob[i] && !strcmp (owner->contr->last_skill_ob[i]->skill, skill))
1577 {
1578 skop = owner->contr->last_skill_ob[i];
1579 break;
1580 }
1581 }
1582 } /* Was it a player that hit somethign */ 1523 } /* Was it a player that hit somethign */
1583 else 1524 else
1584 {
1585 skill = NULL; 1525 skill = 0;
1586 }
1587 1526
1588 /* Pet (or spell) killed something. */
1589 if (owner != hitter)
1590 {
1591 (void) sprintf (buf, "%s killed %s with %s%s%s.", &owner->name,
1592 query_name (op), query_name (hitter), battleg ? " (duel)" : "", pk ? " (pk)" : "");
1593 }
1594 else
1595 {
1596 (void) sprintf (buf, "%s killed %s%s%s%s.", &hitter->name, &op->name,
1597 (QUERY_FLAG (hitter, FLAG_MONSTER)) || hitter->type == PLAYER ?
1598 " in hand to hand combat" : "", battleg ? " (duel)" : "", pk ? " (pk)" : "");
1599 }
1600 /* These may have been set in the player code section above */ 1527 /* These may have been set in the player code section above */
1601 if (!skop) 1528 if (!skop)
1602 skop = hitter->chosen_skill; 1529 skop = hitter->chosen_skill;
1530
1603 if (!skill && skop) 1531 if (!skill && skop)
1604 skill = skop->skill; 1532 skill = skop->skill;
1605 1533
1606 new_draw_info (NDI_ALL, op->type == PLAYER ? 1 : 10, NULL, buf);
1607
1608
1609 /* If you didn't kill yourself, and your not the wizard */ 1534 /* If you didn't kill yourself, and your not the wizard */
1610 if (owner != op && !QUERY_FLAG (op, FLAG_WAS_WIZ)) 1535 if (owner != op && !QUERY_FLAG (op, FLAG_WIZ))
1611 { 1536 {
1612 int exp; 1537 int exp;
1613 1538
1614 /* Really don't give much experience for killing other players */ 1539 /* Really don't give much experience for killing other players */
1615 // schmorp: temporary? reduce the amount of exp gained for pking enourmously 1540 // schmorp: temporarily? reduce the amount of exp gained for pking enourmously
1616 if (op->type == PLAYER) 1541 if (op->type == PLAYER)
1617 { 1542 {
1618 if (battleg) 1543 if (battleg)
1619 { 1544 {
1620 new_draw_info (NDI_UNIQUE, 0, owner, "Your foe has fallen!"); 1545 new_draw_info (NDI_UNIQUE, 0, owner, "Your foe has fallen!");
… …
1638 1563
1639 if (!settings.simple_exp) 1564 if (!settings.simple_exp)
1640 exp = exp / 2; 1565 exp = exp / 2;
1641 1566
1642 if (owner->type != PLAYER || owner->contr->party == NULL) 1567 if (owner->type != PLAYER || owner->contr->party == NULL)
1643 {
1644 change_exp (owner, exp, skill, 0); 1568 change_exp (owner, exp, skill, 0);
1645 }
1646 else 1569 else
1647 { 1570 {
1648 int shares = 0, count = 0; 1571 int shares = 0, count = 0;
1649
1650 player *pl;
1651
1652 partylist *party = owner->contr->party; 1572 partylist *party = owner->contr->party;
1653 1573
1654#ifdef PARTY_KILL_LOG
1655 add_kill_to_party (party, query_name (owner), query_name (op), exp); 1574 add_kill_to_party (party, query_name (owner), query_name (op), exp);
1656#endif 1575
1657 for (pl = first_player; pl != NULL; pl = pl->next) 1576 for_all_players (pl)
1658 {
1659 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner)) 1577 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner))
1660 { 1578 {
1661 count++; 1579 count++;
1662 shares += (pl->ob->level + 4); 1580 shares += (pl->ob->level + 4);
1663 } 1581 }
1664 } 1582
1665 if (count == 1 || shares > exp) 1583 if (count == 1 || shares > exp || !shares)
1666 change_exp (owner, exp, skill, SK_EXP_TOTAL); 1584 change_exp (owner, exp, skill, SK_EXP_TOTAL);
1667 else 1585 else
1668 { 1586 {
1669 int share = exp / shares, given = 0, nexp; 1587 int share = exp / shares, given = 0, nexp;
1670 1588
1671 for (pl = first_player; pl != NULL; pl = pl->next) 1589 for_all_players (pl)
1672 {
1673 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner)) 1590 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner))
1674 { 1591 {
1675 nexp = (pl->ob->level + 4) * share; 1592 nexp = (pl->ob->level + 4) * share;
1676 change_exp (pl->ob, nexp, skill, SK_EXP_TOTAL); 1593 change_exp (pl->ob, nexp, skill, SK_EXP_TOTAL);
1677 given += nexp; 1594 given += nexp;
1678 } 1595 }
1679 } 1596
1680 exp -= given; 1597 exp -= given;
1681 /* give any remainder to the player */ 1598 /* give any remainder to the player */
1682 change_exp (owner, exp, skill, SK_EXP_ADD_SKILL); 1599 change_exp (owner, exp, skill, SK_EXP_ADD_SKILL);
1683 } 1600 }
1684 } /* else part of a party */ 1601 } /* else part of a party */
1685
1686 } /* end if person didn't kill himself */ 1602 } /* end if person didn't kill himself */
1687 1603
1688 if (op->type != PLAYER) 1604 if (op->type != PLAYER)
1689 { 1605 {
1690 if (QUERY_FLAG (op, FLAG_FRIENDLY)) 1606 if (QUERY_FLAG (op, FLAG_FRIENDLY))
1691 { 1607 {
1692 object *owner1 = get_owner (op); 1608 object *owner1 = op->owner;
1693 1609
1694 if (owner1 != NULL && owner1->type == PLAYER) 1610 if (owner1 && owner1->type == PLAYER)
1695 { 1611 {
1696 play_sound_player_only (owner1->contr, SOUND_PET_IS_KILLED, 0, 0); 1612 owner1->contr->play_sound (sound_find ("pet_is_killed"));
1697 /* Maybe we should include the owner that killed this, maybe not */ 1613 /* Maybe we should include the owner that killed this, maybe not */
1698 new_draw_info_format (NDI_UNIQUE, 0, owner1, "Your pet, the %s, is killed by %s.", &op->name, &hitter->name); 1614 new_draw_info_format (NDI_UNIQUE, 0, owner1, "Your pet, the %s, was killed by %s.", &op->name, &hitter->name);
1699 } 1615 }
1700 1616
1701 remove_friendly_object (op); 1617 remove_friendly_object (op);
1702 } 1618 }
1703 1619
1704 remove_ob (op); 1620 op->drop_and_destroy ();
1705 free_object (op);
1706 } 1621 }
1707 /* Player has been killed! */
1708 else 1622 else
1709 { 1623 /* Player has been killed! */
1710 if (owner->type == PLAYER) 1624 op->contr->killer = owner->type == PLAYER ? owner : hitter;
1711 {
1712 snprintf (op->contr->killer, BIG_NAME, "%s the %s", &owner->name, owner->contr->title);
1713 }
1714 else
1715 assign (op->contr->killer, hitter->name);
1716 }
1717 1625
1718 /* This was return -1 - that doesn't seem correct - if we return -1, process 1626 /* This was return -1 - that doesn't seem correct - if we return -1, process
1719 * continues in the calling function. 1627 * continues in the calling function.
1720 */ 1628 */
1721 return maxdam; 1629 return maxdam;
1722} 1630}
1723 1631
1724/* Find out if this is friendly fire (PVP and attacker is peaceful) or not 1632/* Find out if this is friendly fire (PVP and attacker is peaceful) or not
1725 * Returns 0 this is not friendly fire 1633 * Returns 0 this is not friendly fire
1726 */ 1634 */
1727
1728int 1635int
1729friendly_fire (object *op, object *hitter) 1636friendly_fire (object *op, object *hitter)
1730{ 1637{
1731 object *owner; 1638 object *owner;
1732 int friendlyfire; 1639 int friendlyfire;
… …
1742 return 0; 1649 return 0;
1743 1650
1744 if (hitter->type == PLAYER && hitter->contr->peaceful == 1) 1651 if (hitter->type == PLAYER && hitter->contr->peaceful == 1)
1745 return 1; 1652 return 1;
1746 1653
1747 if ((owner = get_owner (hitter)) != NULL) 1654 if ((owner = hitter->owner) != NULL)
1748 { 1655 {
1749 if (owner->type == PLAYER && owner->contr->peaceful == 1) 1656 if (owner->type == PLAYER && owner->contr->peaceful == 1)
1750 friendlyfire = 2; 1657 friendlyfire = 2;
1751 } 1658 }
1752 1659
1753 if (hitter->type == SPELL || hitter->type == POISONING || hitter->type == DISEASE || hitter->type == RUNE) 1660 if (hitter->type == SPELL || hitter->type == POISONING || hitter->type == DISEASE || hitter->type == RUNE)
1754 friendlyfire = 0; 1661 friendlyfire = 0;
1755 } 1662 }
1663
1756 return friendlyfire; 1664 return friendlyfire;
1757} 1665}
1758
1759 1666
1760/* This isn't used just for players, but in fact most objects. 1667/* This isn't used just for players, but in fact most objects.
1761 * op is the object to be hit, dam is the amount of damage, hitter 1668 * op is the object to be hit, dam is the amount of damage, hitter
1762 * is what is hitting the object, type is the attacktype, and 1669 * is what is hitting the object, type is the attacktype, and
1763 * full_hit is set if monster area does not matter. 1670 * full_hit is set if monster area does not matter.
1764 * dam is base damage - protections/vulnerabilities/slaying matches can 1671 * dam is base damage - protections/vulnerabilities/slaying matches can
1765 * modify it. 1672 * modify it.
1766 */ 1673 */
1767
1768 /* Oct 95 - altered the following slightly for MULTIPLE_GODS hack 1674/* Oct 95 - altered the following slightly for MULTIPLE_GODS hack
1769 * which needs new attacktype AT_HOLYWORD to work . b.t. */ 1675 * which needs new attacktype AT_HOLYWORD to work . b.t. */
1770
1771int 1676int
1772hit_player (object *op, int dam, object *hitter, int type, int full_hit) 1677hit_player (object *op, int dam, object *hitter, int type, int full_hit)
1773{ 1678{
1774 int maxdam = 0, ndam = 0, attacktype = 1, magic = (type & AT_MAGIC); 1679 int maxdam = 0, ndam = 0, attacktype = 1, magic = (type & AT_MAGIC);
1775 int maxattacktype, attacknum; 1680 int maxattacktype, attacknum;
1776 int body_attack = op && op->head; /* Did we hit op's head? */ 1681 int body_attack = op && op->head; /* Did we hit op's head? */
1777 int simple_attack; 1682 int simple_attack;
1778 tag_t op_tag, hitter_tag;
1779 int rtn_kill = 0; 1683 int rtn_kill = 0;
1780 int friendlyfire; 1684 int friendlyfire;
1781 1685
1782 if (get_attack_mode (&op, &hitter, &simple_attack)) 1686 if (get_attack_mode (&op, &hitter, &simple_attack))
1783 return 0; 1687 return 0;
1784 1688
1785 /* very simple: if our target has no_damage 1 set or is wiz, we can't hurt him */ 1689 /* very simple: if our target has no_damage 1 set or is wiz, we can't hurt him */
1786 if (QUERY_FLAG (op, FLAG_WIZ) || QUERY_FLAG (op, FLAG_NO_DAMAGE)) 1690 if (QUERY_FLAG (op, FLAG_WIZ) || QUERY_FLAG (op, FLAG_NO_DAMAGE))
1787 return 0; 1691 return 0;
1788 1692
1789#ifdef PROHIBIT_PLAYERKILL 1693 // only allow pk for hostile players
1790 if (op->type == PLAYER) 1694 if (op->type == PLAYER)
1791 { 1695 {
1792 object *owner = get_owner (hitter); 1696 object *owner = hitter->owner;
1793 1697
1794 if (!owner) 1698 if (!owner)
1795 owner = hitter; 1699 owner = hitter;
1796 if (owner->type == PLAYER && (!op_on_battleground (op, 0, 0) && (op->contr->peaceful || owner->contr->peaceful)) && op != owner) 1700
1797 { 1701 if (owner->type == PLAYER
1702 && (!op_on_battleground (op, 0, 0)
1703 && (op->contr->peaceful || owner->contr->peaceful))
1704 && op != owner)
1798 return 0; 1705 return 0;
1799 }
1800 } 1706 }
1801#endif
1802
1803 op_tag = op->count;
1804 hitter_tag = hitter->count;
1805 1707
1806 if (body_attack) 1708 if (body_attack)
1807 { 1709 {
1808 /* slow and paralyze must hit the head. But we don't want to just 1710 /* slow and paralyze must hit the head. But we don't want to just
1809 * return - we still need to process other attacks the spell still 1711 * return - we still need to process other attacks the spell still
… …
1815 * attack so we don't cancel out things like magic bullet. 1717 * attack so we don't cancel out things like magic bullet.
1816 */ 1718 */
1817 if (type & (AT_PARALYZE | AT_SLOW)) 1719 if (type & (AT_PARALYZE | AT_SLOW))
1818 { 1720 {
1819 type &= ~(AT_PARALYZE | AT_SLOW); 1721 type &= ~(AT_PARALYZE | AT_SLOW);
1722
1820 if (!type || type == AT_MAGIC) 1723 if (!type || type == AT_MAGIC)
1821 return 0; 1724 return 0;
1822 } 1725 }
1823 } 1726 }
1824 1727
1825 if (!simple_attack && op->type == DOOR) 1728 if (!simple_attack && op->type == DOOR)
1826 { 1729 {
1827 object *tmp;
1828
1829 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1730 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1830 if (tmp->type == RUNE || tmp->type == TRAP) 1731 if (tmp->type == RUNE || tmp->type == TRAP)
1831 { 1732 {
1832 spring_trap (tmp, hitter); 1733 spring_trap (tmp, hitter);
1734
1833 if (was_destroyed (hitter, hitter_tag) || was_destroyed (op, op_tag) || abort_attack (op, hitter, simple_attack)) 1735 if (hitter->destroyed () || op->destroyed () || abort_attack (op, hitter, simple_attack))
1834 return 0; 1736 return 0;
1737
1835 break; 1738 break;
1836 } 1739 }
1837 } 1740 }
1838 1741
1839 if (!QUERY_FLAG (op, FLAG_ALIVE) || op->stats.hp < 0) 1742 if (!QUERY_FLAG (op, FLAG_ALIVE) || op->stats.hp < 0)
1840 { 1743 {
1841 /* FIXME: If a player is killed by a rune in a door, the 1744 /* FIXME: If a player is killed by a rune in a door, the
1842 * was_destroyed() check above doesn't return, and might get here. 1745 * destroyed() check above doesn't return, and might get here.
1843 */ 1746 */
1747
1748 /* FIXME: This for example happens when a dead door is on a mover and
1749 gets it's speed_left raised on each mover-tick.
1750 Doors are removed in a kinda funny way by giving them speed and speed_left
1751 and waiting for that to run out.
1752 */
1844 LOG (llevDebug, "victim (arch %s, name %s) already dead in " "hit_player()\n", &op->arch->name, &op->name); 1753 LOG (llevDebug, "victim %s (%d) already dead in hit_player()\n", op->debug_desc (), op->stats.hp);
1845 return 0; 1754 return 0;
1846 } 1755 }
1847 1756
1848#ifdef ATTACK_DEBUG 1757#ifdef ATTACK_DEBUG
1849 LOG (llevDebug, "hit player: attacktype %d, dam %d\n", type, dam); 1758 LOG (llevDebug, "hit player: attacktype %d, dam %d\n", type, dam);
… …
1855 * in case 0>dam>1, we try to "simulate" a float value-effect */ 1764 * in case 0>dam>1, we try to "simulate" a float value-effect */
1856 dam = dam * (100 - op->resist[ATNR_MAGIC]); 1765 dam = dam * (100 - op->resist[ATNR_MAGIC]);
1857 if (dam >= 100) 1766 if (dam >= 100)
1858 dam /= 100; 1767 dam /= 100;
1859 else 1768 else
1860 dam = (dam > (rndm (0, 99))) ? 1 : 0; 1769 dam = (dam > rndm (0, 99)) ? 1 : 0;
1861 } 1770 }
1862 1771
1863 /* AT_CHAOS here is a weapon or monster. Spells are handled by hit_map 1772 /* AT_CHAOS here is a weapon or monster. Spells are handled by hit_map
1864 * If the attacktype still has chaos, shuffle it, then clear the Chaos bit 1773 * If the attacktype still has chaos, shuffle it, then clear the Chaos bit
1865 */ 1774 */
… …
1876 */ 1785 */
1877 if (type & AT_HOLYWORD) 1786 if (type & AT_HOLYWORD)
1878 { 1787 {
1879 object *god; 1788 object *god;
1880 1789
1881 if ((!hitter->slaying || 1790 if ((!hitter->slaying
1882 (!(op->race && strstr (hitter->slaying, op->race)) && 1791 || (!(op->race && hitter->slaying.contains (op->race))
1883 !(op->name && strstr (hitter->slaying, op->name)))) && 1792 && !(op->name && hitter->slaying.contains (op->name))))
1884 (!QUERY_FLAG (op, FLAG_UNDEAD) || 1793 && (!QUERY_FLAG (op, FLAG_UNDEAD)
1885 (hitter->title != NULL 1794 || (hitter->title
1886 && (god = find_god (determine_god (hitter))) != NULL && god->race != NULL && strstr (god->race, undead_name) != NULL))) 1795 && (god = find_god (determine_god (hitter))) != NULL
1796 && god->race.contains (shstr_undead))))
1887 return 0; 1797 return 0;
1888 } 1798 }
1889 1799
1890 maxattacktype = type; /* initialize this to something */ 1800 maxattacktype = type; /* initialise this to something */
1891 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++, attacktype = 1 << attacknum) 1801 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++, attacktype = 1 << attacknum)
1892 { 1802 {
1893 /* Magic isn't really a true attack type - it gets combined with other 1803 /* Magic isn't really a true attack type - it gets combined with other
1894 * attack types. As such, skip it over. However, if magic is 1804 * attack types. As such, skip it over. However, if magic is
1895 * the only attacktype in the group, then still attack with it 1805 * the only attacktype in the group, then still attack with it
… …
1923 */ 1833 */
1924 friendlyfire = friendly_fire (op, hitter); 1834 friendlyfire = friendly_fire (op, hitter);
1925 if (friendlyfire && maxdam) 1835 if (friendlyfire && maxdam)
1926 { 1836 {
1927 maxdam = ((dam * settings.set_friendly_fire) / 100); 1837 maxdam = ((dam * settings.set_friendly_fire) / 100);
1928#ifndef COZY_SERVER
1929 maxdam++;
1930#endif
1931 1838
1932#ifdef ATTACK_DEBUG 1839#ifdef ATTACK_DEBUG
1933 LOG (llevDebug, "Friendly fire (type:%d setting: %d%) did %d damage dropped to %d\n", 1840 LOG (llevDebug, "Friendly fire (type:%d setting: %d%) did %d damage dropped to %d\n",
1934 friendlyfire, settings.set_friendly_fire, dam, maxdam); 1841 friendlyfire, settings.set_friendly_fire, dam, maxdam);
1935#endif 1842#endif
1936 } 1843 }
1937 1844
1938 if (!full_hit) 1845 if (!full_hit)
1939 { 1846 {
1940 archetype *at;
1941 int area; 1847 int area;
1942 int remainder; 1848 int remainder;
1943 1849
1944 area = 0; 1850 area = 0;
1945 for (at = op->arch; at != NULL; at = at->more) 1851
1852 for (archetype *at = op->arch; at; at = (archetype *)at->more)
1946 area++; 1853 area++;
1854
1947 assert (area > 0); 1855 assert (area > 0);
1948 1856
1949 /* basically: maxdam /= area; we try to "simulate" a float 1857 /* basically: maxdam /= area; we try to "simulate" a float
1950 value-effect */ 1858 value-effect */
1951 remainder = 100 * (maxdam % area) / area; 1859 remainder = 100 * (maxdam % area) / area;
1952 maxdam /= area; 1860 maxdam /= area;
1953 if (RANDOM () % 100 < remainder) 1861 if (rndm (100) < remainder)
1954 maxdam++; 1862 maxdam++;
1955 } 1863 }
1956 1864
1957#ifdef ATTACK_DEBUG 1865#ifdef ATTACK_DEBUG
1958 LOG (llevDebug, "Attacktype %d did %d damage\n", type, maxdam); 1866 LOG (llevDebug, "Attacktype %d did %d damage\n", type, maxdam);
1959#endif 1867#endif
1960 1868
1961 if (get_owner (hitter)) 1869 // for now, only do this for active objects, otherwise they
1870 // keep a refcount for a long time and I see no usefulness
1871 // for an non-active objetc to know its enemy.
1872 if (op->active)
1873 if (hitter->owner)
1962 op->enemy = hitter->owner; 1874 op->enemy = hitter->owner;
1963 else if (QUERY_FLAG (hitter, FLAG_ALIVE)) 1875 else if (QUERY_FLAG (hitter, FLAG_ALIVE))
1964 op->enemy = hitter; 1876 op->enemy = hitter;
1965 1877
1966 if (QUERY_FLAG (op, FLAG_UNAGGRESSIVE) && op->type != PLAYER) 1878 if (QUERY_FLAG (op, FLAG_UNAGGRESSIVE) && op->type != PLAYER)
1967 { 1879 {
1968 /* The unaggressives look after themselves 8) */ 1880 /* The unaggressives look after themselves 8) */
1969 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE); 1881 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE);
… …
1991 1903
1992 if (QUERY_FLAG (op, FLAG_TEAR_DOWN)) 1904 if (QUERY_FLAG (op, FLAG_TEAR_DOWN))
1993 { 1905 {
1994 if (maxdam) 1906 if (maxdam)
1995 tear_down_wall (op); 1907 tear_down_wall (op);
1908
1996 return maxdam; /* nothing more to do for wall */ 1909 return maxdam; /* nothing more to do for wall */
1997 } 1910 }
1998 1911
1999 /* See if the creature has been killed */ 1912 /* See if the creature has been killed */
2000 rtn_kill = kill_object (op, maxdam, hitter, type); 1913 rtn_kill = kill_object (op, maxdam, hitter, type);
2001 if (rtn_kill != -1) 1914 if (rtn_kill != -1)
2002 return rtn_kill; 1915 return rtn_kill;
2003
2004 1916
2005 /* Used to be ghosthit removal - we now use the ONE_HIT flag. Note 1917 /* Used to be ghosthit removal - we now use the ONE_HIT flag. Note
2006 * that before if the player was immune to ghosthit, the monster 1918 * that before if the player was immune to ghosthit, the monster
2007 * remained - that is no longer the case. 1919 * remained - that is no longer the case.
2008 */ 1920 */
2009 if (QUERY_FLAG (hitter, FLAG_ONE_HIT)) 1921 if (QUERY_FLAG (hitter, FLAG_ONE_HIT))
2010 { 1922 hitter->drop_and_destroy ();
2011 if (QUERY_FLAG (hitter, FLAG_FRIENDLY))
2012 remove_friendly_object (hitter);
2013 remove_ob (hitter);
2014 free_object (hitter);
2015 }
2016 /* Lets handle creatures that are splitting now */ 1923 /* Lets handle creatures that are splitting now */
2017 else if (type & AT_PHYSICAL && !QUERY_FLAG (op, FLAG_FREED) && QUERY_FLAG (op, FLAG_SPLITTING)) 1924 else if (type & AT_PHYSICAL && !QUERY_FLAG (op, FLAG_FREED) && QUERY_FLAG (op, FLAG_SPLITTING))
2018 { 1925 {
2019 int i; 1926 int i;
2020 int friendly = QUERY_FLAG (op, FLAG_FRIENDLY); 1927 int friendly = QUERY_FLAG (op, FLAG_FRIENDLY);
2021 int unaggressive = QUERY_FLAG (op, FLAG_UNAGGRESSIVE); 1928 int unaggressive = QUERY_FLAG (op, FLAG_UNAGGRESSIVE);
2022 object *owner = get_owner (op); 1929 object *owner = op->owner;
2023 1930
2024 if (!op->other_arch) 1931 if (!op->other_arch)
2025 { 1932 {
2026 LOG (llevError, "SPLITTING without other_arch error.\n"); 1933 LOG (llevError, "SPLITTING without other_arch error.\n");
2027 return maxdam; 1934 return maxdam;
2028 } 1935 }
1936
2029 remove_ob (op); 1937 op->remove ();
2030 for (i = 0; i < NROFNEWOBJS (op); i++) 1938
1939 for (i = 0; i < op->stats.food; i++)
2031 { /* This doesn't handle op->more yet */ 1940 { /* This doesn't handle op->more yet */
2032 object *tmp = arch_to_object (op->other_arch); 1941 object *tmp = arch_to_object (op->other_arch);
2033 int j; 1942 int j;
2034 1943
2035 tmp->stats.hp = op->stats.hp; 1944 tmp->stats.hp = op->stats.hp;
1945
2036 if (friendly) 1946 if (friendly)
2037 { 1947 {
2038 SET_FLAG (tmp, FLAG_FRIENDLY);
2039 add_friendly_object (tmp); 1948 add_friendly_object (tmp);
2040 tmp->attack_movement = PETMOVE; 1949 tmp->attack_movement = PETMOVE;
1950
2041 if (owner != NULL) 1951 if (owner)
2042 set_owner (tmp, owner); 1952 tmp->set_owner (owner);
2043 } 1953 }
1954
2044 if (unaggressive) 1955 if (unaggressive)
2045 SET_FLAG (tmp, FLAG_UNAGGRESSIVE); 1956 SET_FLAG (tmp, FLAG_UNAGGRESSIVE);
1957
2046 j = find_first_free_spot (tmp, op->map, op->x, op->y); 1958 j = find_first_free_spot (tmp, op->map, op->x, op->y);
1959
2047 if (j == -1) /* No spot to put this monster */ 1960 if (j == -1) /* No spot to put this monster */
2048 free_object (tmp); 1961 tmp->destroy ();
2049 else 1962 else
2050 { 1963 {
2051 tmp->x = op->x + freearr_x[j], tmp->y = op->y + freearr_y[j]; 1964 tmp->x = op->x + freearr_x[j], tmp->y = op->y + freearr_y[j];
2052 insert_ob_in_map (tmp, op->map, NULL, 0); 1965 insert_ob_in_map (tmp, op->map, NULL, 0);
2053 } 1966 }
2054 } 1967 }
2055 if (friendly) 1968
2056 remove_friendly_object (op); 1969 op->destroy ();
2057 free_object (op);
2058 } 1970 }
2059 else if (type & AT_DRAIN && hitter->type == GRIMREAPER && hitter->value++ > 10) 1971 else if (type & AT_DRAIN && hitter->type == GRIMREAPER && hitter->value++ > 10)
2060 { 1972 hitter->drop_and_destroy ();
2061 remove_ob (hitter); 1973
2062 free_object (hitter);
2063 }
2064 return maxdam; 1974 return maxdam;
2065} 1975}
2066
2067 1976
2068void 1977void
2069poison_player (object *op, object *hitter, int dam) 1978poison_player (object *op, object *hitter, int dam)
2070{ 1979{
2071 archetype *at = find_archetype ("poisoning"); 1980 archetype *at = archetype::find ("poisoning");
2072 object *tmp = present_arch_in_ob (at, op); 1981 object *tmp = present_arch_in_ob (at, op);
2073 1982
2074 if (tmp == NULL) 1983 if (tmp == NULL)
2075 { 1984 {
2076 if ((tmp = arch_to_object (at)) == NULL) 1985 if ((tmp = arch_to_object (at)) == NULL)
… …
2089 if (QUERY_FLAG (hitter, FLAG_ALIVE)) 1998 if (QUERY_FLAG (hitter, FLAG_ALIVE))
2090 tmp->stats.dam += hitter->level / 2; 1999 tmp->stats.dam += hitter->level / 2;
2091 else 2000 else
2092 tmp->stats.dam = dam; 2001 tmp->stats.dam = dam;
2093 2002
2094 copy_owner (tmp, hitter); /* so we get credit for poisoning kills */ 2003 tmp->set_owner (hitter); /* so we get credit for poisoning kills */
2095 if (hitter->skill && hitter->skill != tmp->skill) 2004 if (hitter->skill && hitter->skill != tmp->skill)
2096 { 2005 {
2097 tmp->skill = hitter->skill; 2006 tmp->skill = hitter->skill;
2098 } 2007 }
2099 2008
… …
2105 tmp->stats.Con = MAX (-(dam / 4 + 1), -10); 2014 tmp->stats.Con = MAX (-(dam / 4 + 1), -10);
2106 tmp->stats.Str = MAX (-(dam / 3 + 2), -10); 2015 tmp->stats.Str = MAX (-(dam / 3 + 2), -10);
2107 tmp->stats.Dex = MAX (-(dam / 6 + 1), -10); 2016 tmp->stats.Dex = MAX (-(dam / 6 + 1), -10);
2108 tmp->stats.Int = MAX (-dam / 7, -10); 2017 tmp->stats.Int = MAX (-dam / 7, -10);
2109 SET_FLAG (tmp, FLAG_APPLIED); 2018 SET_FLAG (tmp, FLAG_APPLIED);
2110 fix_player (op); 2019 op->update_stats ();
2111 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very ill."); 2020 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very ill.");
2021 op->play_sound (tmp->sound);
2112 } 2022 }
2023
2113 if (hitter->type == PLAYER) 2024 if (hitter->type == PLAYER)
2114 new_draw_info_format (NDI_UNIQUE, 0, hitter, "You poison %s.", &op->name); 2025 new_draw_info_format (NDI_UNIQUE, 0, hitter, "You poison %s.", &op->name);
2115 else if (get_owner (hitter) != NULL && hitter->owner->type == PLAYER) 2026 else if (hitter->owner != NULL && hitter->owner->type == PLAYER)
2116 new_draw_info_format (NDI_UNIQUE, 0, hitter->owner, "Your %s poisons %s.", &hitter->name, &op->name); 2027 new_draw_info_format (NDI_UNIQUE, 0, hitter->owner, "Your %s poisons %s.", &hitter->name, &op->name);
2117 } 2028 }
2029
2118 tmp->speed_left = 0; 2030 tmp->speed_left = 0;
2119 } 2031 }
2120 else 2032 else
2121 tmp->stats.food++; 2033 tmp->stats.food++;
2122} 2034}
2123 2035
2124void 2036void
2125slow_player (object *op, object *hitter, int dam) 2037slow_player (object *op, object *hitter, int dam)
2126{ 2038{
2127 archetype *at = find_archetype ("slowness"); 2039 archetype *at = archetype::find ("slowness");
2128 object *tmp; 2040 object *tmp;
2129 2041
2130 if (at == NULL) 2042 if (at == NULL)
2131 {
2132 LOG (llevError, "Can't find slowness archetype.\n"); 2043 LOG (llevError, "Can't find slowness archetype.\n");
2133 } 2044
2134 if ((tmp = present_arch_in_ob (at, op)) == NULL) 2045 if ((tmp = present_arch_in_ob (at, op)) == NULL)
2135 { 2046 {
2136 tmp = arch_to_object (at); 2047 tmp = arch_to_object (at);
2137 tmp = insert_ob_in_ob (tmp, op); 2048 tmp = insert_ob_in_ob (tmp, op);
2138 new_draw_info (NDI_UNIQUE, 0, op, "The world suddenly moves very fast!"); 2049 new_draw_info (NDI_UNIQUE, 0, op, "The world suddenly moves very fast!");
2139 } 2050 }
2140 else 2051 else
2141 tmp->stats.food++; 2052 tmp->stats.food++;
2053
2142 SET_FLAG (tmp, FLAG_APPLIED); 2054 SET_FLAG (tmp, FLAG_APPLIED);
2143 tmp->speed_left = 0; 2055 tmp->speed_left = 0;
2144 fix_player (op); 2056 op->update_stats ();
2145} 2057}
2146 2058
2147void 2059void
2148confuse_player (object *op, object *hitter, int dam) 2060confuse_player (object *op, object *hitter, int dam)
2149{ 2061{
… …
2163 tmp->speed = 0.05; 2075 tmp->speed = 0.05;
2164 tmp->subtype = FORCE_CONFUSION; 2076 tmp->subtype = FORCE_CONFUSION;
2165 tmp->duration = 8 + MAX (1, 5 * (100 - op->resist[ATNR_CONFUSION]) / 100); 2077 tmp->duration = 8 + MAX (1, 5 * (100 - op->resist[ATNR_CONFUSION]) / 100);
2166 tmp->name = "confusion"; 2078 tmp->name = "confusion";
2167 maxduration = MAX (2, 30 * (100 - op->resist[ATNR_CONFUSION]) / 100); 2079 maxduration = MAX (2, 30 * (100 - op->resist[ATNR_CONFUSION]) / 100);
2080
2168 if (tmp->duration > maxduration) 2081 if (tmp->duration > maxduration)
2169 tmp->duration = maxduration; 2082 tmp->duration = maxduration;
2170 2083
2171 if (op->type == PLAYER && !QUERY_FLAG (op, FLAG_CONFUSED)) 2084 if (op->type == PLAYER && !QUERY_FLAG (op, FLAG_CONFUSED))
2172 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very confused!"); 2085 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very confused!");
2086
2173 SET_FLAG (op, FLAG_CONFUSED); 2087 SET_FLAG (op, FLAG_CONFUSED);
2174} 2088}
2175 2089
2176void 2090void
2177blind_player (object *op, object *hitter, int dam) 2091blind_player (object *op, object *hitter, int dam)
… …
2193 */ 2107 */
2194 tmp->speed = tmp->speed * (100.0 - (float) op->resist[ATNR_BLIND]) / 100; 2108 tmp->speed = tmp->speed * (100.0 - (float) op->resist[ATNR_BLIND]) / 100;
2195 2109
2196 tmp = insert_ob_in_ob (tmp, op); 2110 tmp = insert_ob_in_ob (tmp, op);
2197 change_abil (op, tmp); /* Mostly to display any messages */ 2111 change_abil (op, tmp); /* Mostly to display any messages */
2198 fix_player (op); /* This takes care of some other stuff */ 2112 op->update_stats (); /* This takes care of some other stuff */
2199 2113
2200 if (hitter->owner) 2114 if (hitter->owner)
2201 owner = get_owner (hitter); 2115 owner = hitter->owner;
2202 else 2116 else
2203 owner = hitter; 2117 owner = hitter;
2204 2118
2205 new_draw_info_format (NDI_UNIQUE, 0, owner, "Your attack blinds %s!", query_name (op)); 2119 new_draw_info_format (NDI_UNIQUE, 0, owner, "Your attack blinds %s!", query_name (op));
2206 } 2120 }
… …
2243 op->speed_left = (float) -(FABS (op->speed) * max); 2157 op->speed_left = (float) -(FABS (op->speed) * max);
2244 2158
2245/* tmp->stats.food = (signed short) (max/FABS(op->speed)); */ 2159/* tmp->stats.food = (signed short) (max/FABS(op->speed)); */
2246} 2160}
2247 2161
2248
2249/* Attempts to kill 'op'. hitter is the attack object, dam is 2162/* Attempts to kill 'op'. hitter is the attack object, dam is
2250 * the computed damaged. 2163 * the computed damaged.
2251 */ 2164 */
2252void 2165void
2253deathstrike_player (object *op, object *hitter, int *dam) 2166deathstrike_player (object *op, object *hitter, int *dam)
… …
2261 ** field of the deathstriking object */ 2174 ** field of the deathstriking object */
2262 2175
2263 int atk_lev, def_lev, kill_lev; 2176 int atk_lev, def_lev, kill_lev;
2264 2177
2265 if (hitter->slaying) 2178 if (hitter->slaying)
2266 if (!((QUERY_FLAG (op, FLAG_UNDEAD) && strstr (hitter->slaying, undead_name)) || (op->race && strstr (hitter->slaying, op->race)))) 2179 if (!((QUERY_FLAG (op, FLAG_UNDEAD) && hitter->slaying.contains (shstr_undead))
2180 || (op->race && hitter->slaying.contains (op->race))))
2267 return; 2181 return;
2268 2182
2269 def_lev = op->level; 2183 def_lev = op->level;
2270 if (def_lev < 1) 2184 if (def_lev < 1)
2271 { 2185 {
2272 LOG (llevError, "BUG: arch %s, name %s with level < 1\n", &op->arch->name, &op->name); 2186 LOG (llevError, "BUG: arch %s with level < 1 (%s)\n", &op->arch->archname, op->debug_desc ());
2273 def_lev = 1; 2187 def_lev = 1;
2274 } 2188 }
2189
2275 atk_lev = (hitter->chosen_skill ? hitter->chosen_skill->level : hitter->level) / 2; 2190 atk_lev = (hitter->chosen_skill ? hitter->chosen_skill->level : hitter->level) / 2;
2276 /* LOG(llevDebug,"Deathstrike - attack level %d, defender level %d\n", 2191 /* LOG(llevDebug,"Deathstrike - attack level %d, defender level %d\n",
2277 atk_lev, def_lev); */ 2192 atk_lev, def_lev); */
2278 2193
2279 if (atk_lev >= def_lev) 2194 if (atk_lev >= def_lev)
… …
2294 */ 2209 */
2295 *dam *= kill_lev / def_lev; 2210 *dam *= kill_lev / def_lev;
2296 } 2211 }
2297 } 2212 }
2298 else 2213 else
2299 {
2300 *dam = 0; /* no harm done */ 2214 *dam = 0; /* no harm done */
2301 }
2302} 2215}
2303 2216
2304/* thrown_item_effect() - handles any special effects of thrown 2217/* thrown_item_effect() - handles any special effects of thrown
2305 * items (like attacking living creatures--a potion thrown at a 2218 * items (like attacking living creatures--a potion thrown at a
2306 * monster). 2219 * monster).
… …
2335 } 2248 }
2336 } 2249 }
2337} 2250}
2338 2251
2339/* adj_attackroll() - adjustments to attacks by various conditions */ 2252/* adj_attackroll() - adjustments to attacks by various conditions */
2340
2341int 2253int
2342adj_attackroll (object *hitter, object *target) 2254adj_attackroll (object *hitter, object *target)
2343{ 2255{
2344 object *attacker = hitter; 2256 object *attacker = hitter;
2345 int adjust = 0; 2257 int adjust = 0;
… …
2352 } 2264 }
2353 2265
2354 /* aimed missiles use the owning object's sight */ 2266 /* aimed missiles use the owning object's sight */
2355 if (is_aimed_missile (hitter)) 2267 if (is_aimed_missile (hitter))
2356 { 2268 {
2357 if ((attacker = get_owner (hitter)) == NULL) 2269 if ((attacker = hitter->owner) == NULL)
2358 attacker = hitter; 2270 attacker = hitter;
2359 /* A player who saves but hasn't quit still could have objects 2271 /* A player who saves but hasn't quit still could have objects
2360 * owned by him - need to handle that case to avoid crashes. 2272 * owned by him - need to handle that case to avoid crashes.
2361 */ 2273 */
2362 if (QUERY_FLAG (attacker, FLAG_REMOVED)) 2274 if (QUERY_FLAG (attacker, FLAG_REMOVED))
… …
2372 { 2284 {
2373 /* target is unseen */ 2285 /* target is unseen */
2374 if (target->invisible || QUERY_FLAG (attacker, FLAG_BLIND)) 2286 if (target->invisible || QUERY_FLAG (attacker, FLAG_BLIND))
2375 adjust -= 10; 2287 adjust -= 10;
2376 /* dark map penalty for the hitter (lacks infravision if we got here). */ 2288 /* dark map penalty for the hitter (lacks infravision if we got here). */
2377 else if (target->map && target->map->darkness > 0 && !stand_in_light (target)) 2289 else if (!stand_in_light (target))
2378 adjust -= target->map->darkness; 2290 adjust -= target->map->darklevel ();
2379 } 2291 }
2380 2292
2381 if (QUERY_FLAG (attacker, FLAG_SCARED)) 2293 if (QUERY_FLAG (attacker, FLAG_SCARED))
2382 adjust -= 3; 2294 adjust -= 3;
2383 2295
… …
2410#endif 2322#endif
2411 2323
2412 return adjust; 2324 return adjust;
2413} 2325}
2414 2326
2415
2416/* determine if the object is an 'aimed' missile */ 2327/* determine if the object is an 'aimed' missile */
2417int 2328int
2418is_aimed_missile (object *op) 2329is_aimed_missile (object *op)
2419{ 2330{
2420 2331
2421 /* I broke what used to be one big if into a few nested 2332 /* I broke what used to be one big if into a few nested
2422 * ones so that figuring out the logic is at least possible. 2333 * ones so that figuring out the logic is at least possible.
2423 */ 2334 */
2424 if (op && (op->move_type & MOVE_FLYING)) 2335 if (op && (op->move_type & MOVE_FLYING))
2425 {
2426 if (op->type == ARROW || op->type == THROWN_OBJ) 2336 if (op->type == ARROW || op->type == THROWN_OBJ)
2427 return 1; 2337 return 1;
2428 else if (op->type == SPELL_EFFECT && (op->subtype == SP_BULLET || op->subtype == SP_EXPLOSION)) 2338 else if (op->type == SPELL_EFFECT && (op->subtype == SP_BULLET || op->subtype == SP_EXPLOSION))
2429 return 1; 2339 return 1;
2430 } 2340
2431 return 0; 2341 return 0;
2432} 2342}

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines