ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/attack.C
(Generate patch)

Comparing deliantra/server/server/attack.C (file contents):
Revision 1.15 by root, Thu Sep 14 20:46:10 2006 UTC vs.
Revision 1.113 by root, Thu Nov 5 14:27:47 2009 UTC

1
2/* 1/*
3 * static char *rcsid_attack_c = 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
4 * "$Id: attack.C,v 1.15 2006/09/14 20:46:10 root Exp $"; 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 *
8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * the terms of the Affero GNU General Public License as published by the
10 * Free Software Foundation, either version 3 of the License, or (at your
11 * option) any later version.
12 *
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the Affero GNU General Public License
19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
21 *
22 * The authors can be reached via e-mail to <support@deliantra.net>
5 */ 23 */
6 24
7/*
8 CrossFire, A Multiplayer game for X-windows
9
10 Copyright (C) 2002 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen
12
13 This program is free software; you can redistribute it and/or modify
14 it under the terms of the GNU General Public License as published by
15 the Free Software Foundation; either version 2 of the License, or
16 (at your option) any later version.
17
18 This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details.
22
23 You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
26
27 The authors can be reached via e-mail to crossfire-devel@real-time.com
28*/
29#include <assert.h> 25#include <assert.h>
30#include <global.h> 26#include <global.h>
31#include <living.h> 27#include <living.h>
32#include <material.h> 28#include <material.h>
33#include <skills.h> 29#include <skills.h>
34
35#ifndef __CEXTRACT__
36# include <sproto.h>
37#endif
38
39#include <sounds.h> 30#include <sounds.h>
31#include <sproto.h>
40 32
41typedef struct att_msg_str 33typedef struct att_msg_str
42{ 34{
43 char *msg1; 35 char *msg1;
44 char *msg2; 36 char *msg2;
… …
50 * its magical benefits. 42 * its magical benefits.
51 */ 43 */
52void 44void
53cancellation (object *op) 45cancellation (object *op)
54{ 46{
55 object *tmp;
56
57 if (op->invisible) 47 if (op->invisible)
58 return; 48 return;
59 49
60 if (QUERY_FLAG (op, FLAG_ALIVE) || op->type == CONTAINER || op->type == THROWN_OBJ) 50 if (QUERY_FLAG (op, FLAG_ALIVE) || op->type == CONTAINER || op->type == THROWN_OBJ)
61 { 51 {
62 /* Recur through the inventory */ 52 /* Recurse through the inventory */
63 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 53 for (object *tmp = op->inv; tmp; tmp = tmp->below)
64 if (!did_make_save_item (tmp, AT_CANCELLATION, op)) 54 if (!did_make_save_item (tmp, AT_CANCELLATION, op))
65 cancellation (tmp); 55 cancellation (tmp);
66 } 56 }
67 else if (FABS (op->magic) <= (rndm (0, 5))) 57 else if (FABS (op->magic) <= rndm (0, 5))
68 { 58 {
69 /* Nullify this object. This code could probably be more complete */ 59 /* Nullify this object. This code could probably be more complete */
70 /* in what abilities it should cancel */ 60 /* in what abilities it should cancel */
71 op->magic = 0; 61 op->magic = 0;
62
72 CLEAR_FLAG (op, FLAG_DAMNED); 63 CLEAR_FLAG (op, FLAG_DAMNED);
73 CLEAR_FLAG (op, FLAG_CURSED); 64 CLEAR_FLAG (op, FLAG_CURSED);
74 CLEAR_FLAG (op, FLAG_KNOWN_MAGICAL); 65 CLEAR_FLAG (op, FLAG_KNOWN_MAGICAL);
75 CLEAR_FLAG (op, FLAG_KNOWN_CURSED); 66 CLEAR_FLAG (op, FLAG_KNOWN_CURSED);
76 if (op->env && op->env->type == PLAYER)
77 {
78 esrv_send_item (op->env, op);
79 }
80 }
81}
82 67
83 68 if (object *pl = op->visible_to ())
69 esrv_update_item (UPD_FLAGS, pl, op);
70 }
71}
84 72
85/* did_make_save_item just checks to make sure the item actually 73/* did_make_save_item just checks to make sure the item actually
86 * made its saving throw based on the tables. It does not take 74 * made its saving throw based on the tables. It does not take
87 * any further action (like destroying the item). 75 * any further action (like destroying the item).
88 */ 76 */
89
90int 77int
91did_make_save_item (object *op, int type, object *originator) 78did_make_save_item (object *op, int type, object *originator)
92{ 79{
93 int i, roll, saves = 0, attacks = 0, number; 80 int i, roll, saves = 0, attacks = 0, number;
94 materialtype_t *mt; 81 materialtype_t *mt;
95 82
96 if (op->materialname == NULL) 83 if (!op->materialname)
97 { 84 {
98 for (mt = materialt; mt != NULL && mt->next != NULL; mt = mt->next) 85 for (mt = materialt; mt; mt = mt->next)
99 {
100 if (op->material & mt->material) 86 if (op->materials & mt->material)
101 break; 87 break;
102 }
103 } 88 }
104 else 89 else
105 mt = name_to_material (op->materialname); 90 mt = name_to_material (op->materialname);
106 if (mt == NULL) 91
92 if (!mt)
107 return TRUE; 93 return TRUE;
94
108 roll = rndm (1, 20); 95 roll = rndm (1, 20);
109 96
110 /* the attacktypes have no meaning for object saves 97 /* the attacktypes have no meaning for object saves
111 * If the type is only magic, don't adjust type - basically, if 98 * If the type is only magic, don't adjust type - basically, if
112 * pure magic is hitting an object, it should save. However, if it 99 * pure magic is hitting an object, it should save. However, if it
… …
118 if (type != AT_MAGIC) 105 if (type != AT_MAGIC)
119 type &= ~(AT_CONFUSION | AT_DRAIN | AT_GHOSTHIT | AT_POISON | AT_SLOW | 106 type &= ~(AT_CONFUSION | AT_DRAIN | AT_GHOSTHIT | AT_POISON | AT_SLOW |
120 AT_PARALYZE | AT_TURN_UNDEAD | AT_FEAR | AT_DEPLETE | AT_DEATH | 107 AT_PARALYZE | AT_TURN_UNDEAD | AT_FEAR | AT_DEPLETE | AT_DEATH |
121 AT_COUNTERSPELL | AT_HOLYWORD | AT_BLIND | AT_LIFE_STEALING | AT_MAGIC); 108 AT_COUNTERSPELL | AT_HOLYWORD | AT_BLIND | AT_LIFE_STEALING | AT_MAGIC);
122 109
123 if (type == 0) 110 if (type == 0) return TRUE;
124 return TRUE; 111
125 if (roll == 20) 112 if (roll == 20) return TRUE;
126 return TRUE; 113 if (roll == 1) return FALSE;
127 if (roll == 1)
128 return FALSE;
129 114
130 for (number = 0; number < NROFATTACKS; number++) 115 for (number = 0; number < NROFATTACKS; number++)
131 { 116 {
132 i = 1 << number; 117 i = 1 << number;
118
133 if (!(i & type)) 119 if (!(i & type))
134 continue; 120 continue;
121
135 attacks++; 122 attacks++;
136 if (op->resist[number] == 100) 123 if (op->resist[number] == 100)
137 saves++; 124 saves++;
138 else if (roll >= mt->save[number] - op->magic - op->resist[number] / 100) 125 else if (roll >= mt->save[number] - op->magic - op->resist[number] / 100)
139 saves++; 126 saves++;
… …
141 saves++; 128 saves++;
142 } 129 }
143 130
144 if (saves == attacks || attacks == 0) 131 if (saves == attacks || attacks == 0)
145 return TRUE; 132 return TRUE;
133
146 if ((saves == 0) || (rndm (1, attacks) > saves)) 134 if (saves == 0 || (rndm (1, attacks) > saves))
147 return FALSE; 135 return FALSE;
136
148 return TRUE; 137 return TRUE;
149} 138}
150 139
151/* This function calls did_make_save_item. It then performs the 140/* This function calls did_make_save_item. It then performs the
152 * appropriate actions to the item (such as burning the item up, 141 * appropriate actions to the item (such as burning the item up,
153 * calling cancellation, etc.) 142 * calling cancellation, etc.)
154 */ 143 */
155
156void 144void
157save_throw_object (object *op, int type, object *originator) 145save_throw_object (object *op, int type, object *originator)
158{ 146{
159 if (!did_make_save_item (op, type, originator)) 147 if (!did_make_save_item (op, type, originator))
160 { 148 {
161 object *env = op->env; 149 object *env = op->env;
162 int x = op->x, y = op->y; 150 int x = op->x, y = op->y;
163 mapstruct *m = op->map; 151 maptile *m = op->map;
164 152
165 op = stop_item (op); 153 op = stop_item (op);
166 if (op == NULL) 154 if (!op)
167 return; 155 return;
168 156
169 /* Hacked the following so that type LIGHTER will work. 157 /* Hacked the following so that type LIGHTER will work.
170 * Also, objects which are potenital "lights" that are hit by 158 * Also, objects which are potential "lights" that are hit by
171 * flame/elect attacks will be set to glow. "lights" are any 159 * flame/elect attacks will be set to glow. "lights" are any
172 * object with +/- glow_radius and an "other_arch" to change to. 160 * object with +/- glow_radius and an "other_arch" to change to.
173 * (and please note that we cant fail our save and reach this 161 * (and please note that we cant fail our save and reach this
174 * function if the object doesnt contain a material that can burn. 162 * function if the object doesnt contain a material that can burn.
175 * So forget lighting magical swords on fire with this!) -b.t. 163 * So forget lighting magical swords on fire with this!) -b.t.
176 */ 164 */
177 if (type & (AT_FIRE | AT_ELECTRICITY) && op->other_arch && QUERY_FLAG (op, FLAG_IS_LIGHTABLE)) 165 if (type & (AT_FIRE | AT_ELECTRICITY)
166 && (QUERY_FLAG (op, FLAG_IS_LIGHTABLE)
167 || op->type == LAMP
168 || op->type == TORCH
178 { 169 ))
179 const char *arch = op->other_arch->name; 170 {
180 171 switch (op->type)
181 op = decrease_ob_nr (op, 1);
182
183 if (op)
184 fix_stopped_item (op, m, originator);
185
186 if ((op = get_archetype (arch)) != NULL)
187 { 172 {
188 if (env) 173 case LAMP:
174 case TORCH:
175 // turn on a lamp
176 apply_lamp (op, true);
177 break;
178
179 default:
180 // for instance icecubes:
181 if (op->other_arch)
189 { 182 {
190 op->x = env->x, op->y = env->y; 183 const char *arch = op->other_arch->archname;
191 insert_ob_in_ob (op, env); 184
185 if (op->decrease ())
186 fix_stopped_item (op, m, originator);
187
188 if ((op = archetype::get (arch)))
189 {
192 if (env->contr) 190 if (env)
193 esrv_send_item (env, op); 191 env->insert (op);
192 else
193 m->insert (op, x, y, originator);
194 }
194 } 195 }
195 else
196 {
197 op->x = x, op->y = y;
198 insert_ob_in_map (op, m, originator, 0);
199 }
200 } 196 }
201
202 return; 197 return;
203 } 198 }
204 199
205 if (type & AT_CANCELLATION) 200 if (type & AT_CANCELLATION)
206 { /* Cancellation. */ 201 { /* Cancellation. */
… …
209 return; 204 return;
210 } 205 }
211 206
212 if (op->nrof > 1) 207 if (op->nrof > 1)
213 { 208 {
214 op = decrease_ob_nr (op, rndm (0, op->nrof - 1)); 209 if (op->decrease (rndm (0, op->nrof - 1)))
215
216 if (op)
217 fix_stopped_item (op, m, originator); 210 fix_stopped_item (op, m, originator);
218 } 211 }
219 else 212 else
220 { 213 {
221 if (op->env) 214 // drop everything to the ground, if possible
222 { 215 op->insert_at (originator);
223 object *tmp = is_player_inv (op->env); 216 op->drop_and_destroy ();
224
225 if (tmp)
226 esrv_del_item (tmp->contr, op->count);
227 }
228
229 if (!QUERY_FLAG (op, FLAG_REMOVED))
230 remove_ob (op);
231
232 free_object (op);
233 } 217 }
234 218
235 if (type & (AT_FIRE | AT_ELECTRICITY)) 219 if (type & (AT_FIRE | AT_ELECTRICITY))
236 if (env) 220 if (env)
237 { 221 {
238 op = get_archetype ("burnout"); 222 op = archetype::get (shstr_burnout);
239 op->x = env->x, op->y = env->y; 223 op->x = env->x, op->y = env->y;
240 insert_ob_in_ob (op, env); 224 env->insert (op);
241 } 225 }
242 else 226 else
243 replace_insert_ob_in_map ("burnout", originator); 227 replace_insert_ob_in_map (shstr_burnout, originator);
244 228
245 return; 229 return;
246 } 230 }
247 231
248 /* The value of 50 is arbitrary. */ 232 /* The value of 50 is arbitrary. */
249 if (type & AT_COLD && (op->resist[ATNR_COLD] < 50) && !QUERY_FLAG (op, FLAG_NO_PICK) && (RANDOM () & 2)) 233 if (type & AT_COLD && (op->resist[ATNR_COLD] < 50) && !QUERY_FLAG (op, FLAG_NO_PICK) && rndm (2))
250 { 234 {
251 object *tmp;
252 archetype *at = find_archetype ("icecube"); 235 archetype *at = archetype::find (shstr_icecube);
253 236
254 if (at == NULL) 237 if (at == NULL)
255 return; 238 return;
256 239
257 op = stop_item (op); 240 op = stop_item (op);
258 if (op == NULL) 241 if (op == NULL)
259 return; 242 return;
260 243
261 if ((tmp = present_arch (at, op->map, op->x, op->y)) == NULL) 244 object *tmp = present_arch (at, op->map, op->x, op->y);
245 if (!tmp)
262 { 246 {
263 tmp = arch_to_object (at); 247 tmp = arch_to_object (at);
264 tmp->x = op->x, tmp->y = op->y; 248 tmp->x = op->x, tmp->y = op->y;
265 /* This was in the old (pre new movement code) - 249 /* This was in the old (pre new movement code) -
266 * icecubes have slow_move set to 1 - don't want 250 * icecubes have slow_move set to 1 - don't want
… …
269 tmp->move_slow_penalty = 0; 253 tmp->move_slow_penalty = 0;
270 tmp->move_slow = 0; 254 tmp->move_slow = 0;
271 insert_ob_in_map (tmp, op->map, originator, 0); 255 insert_ob_in_map (tmp, op->map, originator, 0);
272 } 256 }
273 257
274 if (!QUERY_FLAG (op, FLAG_REMOVED)) 258 tmp->insert (op);
275 remove_ob (op);
276
277 insert_ob_in_ob (op, tmp);
278 return; 259 return;
279 } 260 }
280} 261}
281 262
282/* Object op is hitting the map. 263/* Object op is hitting the map.
283 * op is going in direction 'dir' 264 * op is going in direction 'dir'
284 * type is the attacktype of the object. 265 * type is the attacktype of the object.
285 * full_hit is set if monster area does not matter. 266 * full_hit is set if monster area does not matter.
286 * returns 1 if it hits something, 0 otherwise. 267 * returns 1 if it hits something, 0 otherwise.
287 */ 268 */
288
289int 269int
290hit_map (object *op, int dir, int type, int full_hit) 270hit_map (object *op, int dir, int type, int full_hit)
291{ 271{
292 object *tmp, *next;
293 mapstruct *map; 272 maptile *map;
294 sint16 x, y; 273 sint16 x, y;
295 int retflag = 0; /* added this flag.. will return 1 if it hits a monster */ 274 int retflag = 0; /* added this flag.. will return 1 if it hits a monster */
296 275
297 tag_t op_tag, next_tag = 0;
298
299 if (QUERY_FLAG (op, FLAG_FREED)) 276 if (QUERY_FLAG (op, FLAG_FREED))
300 { 277 {
301 LOG (llevError, "BUG: hit_map(): free object\n"); 278 LOG (llevError, "BUG: hit_map(): free object\n");
302 return 0; 279 return 0;
303 } 280 }
304 281
305 if (QUERY_FLAG (op, FLAG_REMOVED) || op->env != NULL) 282 if (QUERY_FLAG (op, FLAG_REMOVED) || op->env != NULL)
306 { 283 {
307 LOG (llevError, "BUG: hit_map(): hitter (arch %s, name %s) not on a map\n", &op->arch->name, &op->name); 284 LOG (llevError, "BUG: hit_map(): hitter (arch %s, name %s) not on a map\n", &op->arch->archname, &op->name);
308 return 0; 285 return 0;
309 } 286 }
310 287
311 if (!op->map) 288 if (!op->map)
312 { 289 {
… …
315 } 292 }
316 293
317 if (op->head) 294 if (op->head)
318 op = op->head; 295 op = op->head;
319 296
320 op_tag = op->count; 297 mapxy pos (op);
298 pos.move (dir);
321 299
322 map = op->map; 300 if (!pos.normalise ())
323 x = op->x + freearr_x[dir]; 301 return 0;
324 y = op->y + freearr_y[dir];
325
326 int mflags = get_map_flags (map, &map, x, y, &x, &y);
327 302
328 // elmex: a safe map tile can't be hit! 303 // elmex: a safe map tile can't be hit!
329 // this should prevent most harmful effects on items and players there. 304 // this should prevent most harmful effects on items and players there.
330 if (mflags & (P_OUT_OF_MAP | P_SAFE)) 305 mapspace &ms = pos.ms ();
306
307 if (ms.flags () & P_SAFE)
331 return 0; 308 return 0;
332 309
333 /* peterm: a few special cases for special attacktypes --counterspell 310 /* peterm: a few special cases for special attacktypes --counterspell
334 * must be out here because it strikes things which are not alive 311 * must be out here because it strikes things which are not alive
335 */ 312 */
336 313 if (type & (AT_COUNTERSPELL | AT_CHAOS))
314 {
337 if (type & AT_COUNTERSPELL) 315 if (type & AT_COUNTERSPELL)
338 { 316 {
339 counterspell (op, dir); /* see spell_effect.c */ 317 counterspell (op, dir); /* see spell_effect.c */
340 318
341 /* If the only attacktype is counterspell or magic, don't need 319 /* If the only attacktype is counterspell or magic, don't need
342 * to do any further processing. 320 * to do any further processing.
343 */
344 if (!(type & ~(AT_COUNTERSPELL | AT_MAGIC)))
345 return 0;
346
347 type &= ~AT_COUNTERSPELL;
348 }
349
350 if (type & AT_CHAOS)
351 {
352 shuffle_attack (op, 1); /*1 flag tells it to change the face */
353 update_object (op, UP_OBJ_FACE);
354 type &= ~AT_CHAOS;
355 }
356
357 next = get_map_ob (map, x, y);
358 if (next)
359 next_tag = next->count;
360
361 while (next)
362 {
363 if (was_destroyed (next, next_tag))
364 {
365 /* There may still be objects that were above 'next', but there is no
366 * simple way to find out short of copying all object references and
367 * tags into a temporary array before we start processing the first
368 * object. That's why we just abort.
369 *
370 * This happens whenever attack spells (like fire) hit a pile
371 * of objects. This is not a bug - nor an error. The errormessage
372 * below was spamming the logs for absolutely no reason.
373 */ 321 */
374 /* LOG (llevDebug, "hit_map(): next object destroyed\n"); */ 322 if (!(type & ~(AT_COUNTERSPELL | AT_MAGIC)))
375 break; 323 return 0;
324
325 type &= ~AT_COUNTERSPELL;
326 }
327
328 if (type & AT_CHAOS)
376 } 329 {
330 shuffle_attack (op, 1); /* flag tells it to change the face */
331 update_object (op, UP_OBJ_FACE);
332 type &= ~AT_CHAOS;
333 }
334 }
377 335
336 /* There may still be objects that were above 'next', but there is no
337 * simple way to find out short of copying all object references and
338 * tags into a temporary array before we start processing the first
339 * object. That's why we just abort on destroy.
340 *
341 * This happens whenever attack spells (like fire) hit a pile
342 * of objects. This is not a bug - nor an error.
343 */
344 for (object *next = ms.bot; next && !next->destroyed (); )
345 {
378 tmp = next; 346 object *tmp = next;
379 next = tmp->above; 347 next = tmp->above;
380
381 if (next)
382 next_tag = next->count;
383
384 if (QUERY_FLAG (tmp, FLAG_FREED))
385 {
386 LOG (llevError, "BUG: hit_map(): found freed object\n");
387 break;
388 }
389 348
390 /* Something could have happened to 'tmp' while 'tmp->below' was processed. 349 /* Something could have happened to 'tmp' while 'tmp->below' was processed.
391 * For example, 'tmp' was put in an icecube. 350 * For example, 'tmp' was put in an icecube.
392 * This is one of the few cases where on_same_map should not be used. 351 * This is one of the few cases where on_same_map should not be used.
393 */ 352 */
394 if (tmp->map != map || tmp->x != x || tmp->y != y) 353 if (tmp->map != pos.m || tmp->x != pos.x || tmp->y != pos.y)
395 continue; 354 continue;
396 355
397 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 356 if (QUERY_FLAG (tmp, FLAG_ALIVE))
398 { 357 {
399 hit_player (tmp, op->stats.dam, op, type, full_hit); 358 hit_player (tmp, op->stats.dam, op, type, full_hit);
400 retflag |= 1; 359 retflag |= 1;
360
401 if (was_destroyed (op, op_tag)) 361 if (op->destroyed ())
402 break; 362 break;
403 } 363 }
404
405 /* Here we are potentially destroying an object. If the object has 364 /* Here we are potentially destroying an object. If the object has
406 * NO_PASS set, it is also immune - you can't destroy walls. Note 365 * NO_PASS set, it is also immune - you can't destroy walls. Note
407 * that weak walls have is_alive set, which prevent objects from 366 * that weak walls have is_alive set, which prevent objects from
408 * passing over/through them. We don't care what type of movement 367 * passing over/through them. We don't care what type of movement
409 * the wall blocks - if it blocks any type of movement, can't be 368 * the wall blocks - if it blocks any type of movement, can't be
410 * destroyed right now. 369 * destroyed right now.
411 */ 370 */
412 else if ((tmp->material || tmp->materialname) && op->stats.dam > 0 && !tmp->move_block) 371 else if (tmp->materialname && op->stats.dam > 0 && !tmp->move_block)
413 { 372 {
414 save_throw_object (tmp, type, op); 373 save_throw_object (tmp, type, op);
374
415 if (was_destroyed (op, op_tag)) 375 if (op->destroyed ())
416 break; 376 break;
417 } 377 }
418 } 378 }
419 379
420 return 0; 380 return 0;
… …
423void 383void
424attack_message (int dam, int type, object *op, object *hitter) 384attack_message (int dam, int type, object *op, object *hitter)
425{ 385{
426 char buf[MAX_BUF], buf1[MAX_BUF], buf2[MAX_BUF]; 386 char buf[MAX_BUF], buf1[MAX_BUF], buf2[MAX_BUF];
427 int i, found = 0; 387 int i, found = 0;
428 mapstruct *map; 388 maptile *map;
429 object *next, *tmp; 389 object *next, *tmp;
430 390
431 /* put in a few special messages for some of the common attacktypes 391 /* put in a few special messages for some of the common attacktypes
432 * a player might have. For example, fire, electric, cold, etc 392 * a player might have. For example, fire, electric, cold, etc
433 * [garbled 20010919] 393 * [garbled 20010919]
434 */ 394 */
435
436 if (dam == 9998 && op->type == DOOR) 395 if (dam == 9998 && op->type == DOOR)
437 { 396 {
438 sprintf (buf1, "unlock %s", &op->name); 397 sprintf (buf1, "unlock %s", &op->name);
439 sprintf (buf2, " unlocks"); 398 sprintf (buf2, " unlocks");
440 found++; 399 found++;
441 } 400 }
442 if (dam < 0) 401 else if (dam < 0)
443 { 402 {
444 sprintf (buf1, "hit %s", &op->name); 403 sprintf (buf1, "hit %s", &op->name);
445 sprintf (buf2, " hits"); 404 sprintf (buf2, " hits");
446 found++; 405 found++;
447 } 406 }
… …
450 sprintf (buf1, "missed %s", &op->name); 409 sprintf (buf1, "missed %s", &op->name);
451 sprintf (buf2, " misses"); 410 sprintf (buf2, " misses");
452 found++; 411 found++;
453 } 412 }
454 else if ((hitter->type == DISEASE || hitter->type == SYMPTOM || 413 else if ((hitter->type == DISEASE || hitter->type == SYMPTOM ||
455 hitter->type == POISONING || (type & AT_POISON && IS_LIVE (op))) && !found) 414 hitter->type == POISONING || (type & AT_POISON && op->is_alive ())) && !found)
456 { 415 {
457 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_SUFFER][i].level != -1; i++) 416 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_SUFFER][i].level != -1; i++)
458 if (dam < attack_mess[ATM_SUFFER][i].level || attack_mess[ATM_SUFFER][i + 1].level == -1) 417 if (dam < attack_mess[ATM_SUFFER][i].level || attack_mess[ATM_SUFFER][i + 1].level == -1)
459 { 418 {
460 sprintf (buf1, "%s %s%s", attack_mess[ATM_SUFFER][i].buf1, &op->name, attack_mess[ATM_SUFFER][i].buf2); 419 sprintf (buf1, "%s %s%s", attack_mess[ATM_SUFFER][i].buf1, &op->name, attack_mess[ATM_SUFFER][i].buf2);
… …
472 strcpy (buf2, attack_mess[ATM_DOOR][i].buf3); 431 strcpy (buf2, attack_mess[ATM_DOOR][i].buf3);
473 found++; 432 found++;
474 break; 433 break;
475 } 434 }
476 } 435 }
477 else if (hitter->type == PLAYER && IS_LIVE (op)) 436 else if (hitter->type == PLAYER && op->is_alive ())
478 { 437 {
479 if (USING_SKILL (hitter, SK_KARATE)) 438 if (USING_SKILL (hitter, SK_KARATE))
480 { 439 {
481 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_KARATE][i].level != -1; i++) 440 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_KARATE][i].level != -1; i++)
482 if (dam < attack_mess[ATM_KARATE][i].level || attack_mess[ATM_KARATE][i + 1].level == -1) 441 if (dam < attack_mess[ATM_KARATE][i].level || attack_mess[ATM_KARATE][i + 1].level == -1)
… …
508 found++; 467 found++;
509 break; 468 break;
510 } 469 }
511 } 470 }
512 } 471 }
472
513 if (found) 473 if (found)
514 { 474 {
515 /* done */ 475 /* done */
516 } 476 }
517 else if (IS_ARROW (hitter) && (type == AT_PHYSICAL || type == AT_MAGIC)) 477 else if (hitter->is_arrow () && (type == AT_PHYSICAL || type == AT_MAGIC))
518 { 478 {
519 sprintf (buf1, "hit"); /* just in case */ 479 sprintf (buf1, "hit"); /* just in case */
520 for (i = 0; i < MAXATTACKMESS; i++) 480 for (i = 0; i < MAXATTACKMESS; i++)
521 if (dam < attack_mess[ATM_ARROW][i].level || attack_mess[ATM_ARROW][i + 1].level == -1) 481 if (dam < attack_mess[ATM_ARROW][i].level || attack_mess[ATM_ARROW][i + 1].level == -1)
522 { 482 {
523 strcpy (buf2, attack_mess[ATM_ARROW][i].buf3); 483 strcpy (buf2, attack_mess[ATM_ARROW][i].buf3);
524 found++; 484 found++;
525 break; 485 break;
526 } 486 }
527 } 487 }
528 else if (type & AT_DRAIN && IS_LIVE (op)) 488 else if (type & AT_DRAIN && op->is_alive ())
529 { 489 {
530 /* drain is first, because some items have multiple attypes */ 490 /* drain is first, because some items have multiple attypes */
531 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_DRAIN][i].level != -1; i++) 491 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_DRAIN][i].level != -1; i++)
532 if (dam < attack_mess[ATM_DRAIN][i].level || attack_mess[ATM_DRAIN][i + 1].level == -1) 492 if (dam < attack_mess[ATM_DRAIN][i].level || attack_mess[ATM_DRAIN][i + 1].level == -1)
533 { 493 {
… …
535 strcpy (buf2, attack_mess[ATM_DRAIN][i].buf3); 495 strcpy (buf2, attack_mess[ATM_DRAIN][i].buf3);
536 found++; 496 found++;
537 break; 497 break;
538 } 498 }
539 } 499 }
540 else if (type & AT_ELECTRICITY && IS_LIVE (op)) 500 else if (type & AT_ELECTRICITY && op->is_alive ())
541 { 501 {
542 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_ELEC][i].level != -1; i++) 502 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_ELEC][i].level != -1; i++)
543 if (dam < attack_mess[ATM_ELEC][i].level || attack_mess[ATM_ELEC][i + 1].level == -1) 503 if (dam < attack_mess[ATM_ELEC][i].level || attack_mess[ATM_ELEC][i + 1].level == -1)
544 { 504 {
545 sprintf (buf1, "%s %s%s", attack_mess[ATM_ELEC][i].buf1, &op->name, attack_mess[ATM_ELEC][i].buf2); 505 sprintf (buf1, "%s %s%s", attack_mess[ATM_ELEC][i].buf1, &op->name, attack_mess[ATM_ELEC][i].buf2);
546 strcpy (buf2, attack_mess[ATM_ELEC][i].buf3); 506 strcpy (buf2, attack_mess[ATM_ELEC][i].buf3);
547 found++; 507 found++;
548 break; 508 break;
549 } 509 }
550 } 510 }
551 else if (type & AT_COLD && IS_LIVE (op)) 511 else if (type & AT_COLD && op->is_alive ())
552 { 512 {
553 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_COLD][i].level != -1; i++) 513 for (i = 0; i < MAXATTACKMESS && attack_mess[ATM_COLD][i].level != -1; i++)
554 if (dam < attack_mess[ATM_COLD][i].level || attack_mess[ATM_COLD][i + 1].level == -1) 514 if (dam < attack_mess[ATM_COLD][i].level || attack_mess[ATM_COLD][i + 1].level == -1)
555 { 515 {
556 sprintf (buf1, "%s %s%s", attack_mess[ATM_COLD][i].buf1, &op->name, attack_mess[ATM_COLD][i].buf2); 516 sprintf (buf1, "%s %s%s", attack_mess[ATM_COLD][i].buf1, &op->name, attack_mess[ATM_COLD][i].buf2);
… …
568 strcpy (buf2, attack_mess[ATM_FIRE][i].buf3); 528 strcpy (buf2, attack_mess[ATM_FIRE][i].buf3);
569 found++; 529 found++;
570 break; 530 break;
571 } 531 }
572 } 532 }
573 else if (hitter->current_weapon != NULL) 533 else if (hitter->current_weapon)
574 { 534 {
575 int mtype; 535 int mtype;
576 536
577 switch (hitter->current_weapon->weapontype) 537 switch (hitter->current_weapon->weapontype)
578 { 538 {
579 case WEAP_HIT: 539 case WEAP_HIT:
580 mtype = ATM_BASIC; 540 mtype = ATM_BASIC;
581 break; 541 break;
582 case WEAP_SLASH: 542 case WEAP_SLASH:
583 mtype = ATM_SLASH; 543 mtype = ATM_SLASH;
584 break; 544 break;
585 case WEAP_PIERCE: 545 case WEAP_PIERCE:
586 mtype = ATM_PIERCE; 546 mtype = ATM_PIERCE;
587 break; 547 break;
588 case WEAP_CLEAVE: 548 case WEAP_CLEAVE:
589 mtype = ATM_CLEAVE; 549 mtype = ATM_CLEAVE;
590 break; 550 break;
591 case WEAP_SLICE: 551 case WEAP_SLICE:
592 mtype = ATM_SLICE; 552 mtype = ATM_SLICE;
593 break; 553 break;
594 case WEAP_STAB: 554 case WEAP_STAB:
595 mtype = ATM_STAB; 555 mtype = ATM_STAB;
596 break; 556 break;
597 case WEAP_WHIP: 557 case WEAP_WHIP:
598 mtype = ATM_WHIP; 558 mtype = ATM_WHIP;
599 break; 559 break;
600 case WEAP_CRUSH: 560 case WEAP_CRUSH:
601 mtype = ATM_CRUSH; 561 mtype = ATM_CRUSH;
602 break; 562 break;
603 case WEAP_BLUD: 563 case WEAP_BLUD:
604 mtype = ATM_BLUD; 564 mtype = ATM_BLUD;
605 break; 565 break;
606 default: 566 default:
607 mtype = ATM_BASIC; 567 mtype = ATM_BASIC;
608 break; 568 break;
609 } 569 }
570
610 for (i = 0; i < MAXATTACKMESS && attack_mess[mtype][i].level != -1; i++) 571 for (i = 0; i < MAXATTACKMESS && attack_mess[mtype][i].level != -1; i++)
611 if (dam < attack_mess[mtype][i].level || attack_mess[mtype][i + 1].level == -1) 572 if (dam < attack_mess[mtype][i].level || attack_mess[mtype][i + 1].level == -1)
612 { 573 {
613 sprintf (buf1, "%s %s%s", attack_mess[mtype][i].buf1, &op->name, attack_mess[mtype][i].buf2); 574 sprintf (buf1, "%s %s%s", attack_mess[mtype][i].buf1, &op->name, attack_mess[mtype][i].buf2);
614 strcpy (buf2, attack_mess[mtype][i].buf3); 575 strcpy (buf2, attack_mess[mtype][i].buf3);
… …
633 strcpy (buf1, "hit"); 594 strcpy (buf1, "hit");
634 strcpy (buf2, " hits"); 595 strcpy (buf2, " hits");
635 } 596 }
636 597
637 /* bail out if a monster is casting spells */ 598 /* bail out if a monster is casting spells */
638 if (!(hitter->type == PLAYER || (get_owner (hitter) != NULL && hitter->owner->type == PLAYER))) 599 if (!(hitter->type == PLAYER || (hitter->owner != NULL && hitter->owner->type == PLAYER)))
639 return; 600 return;
640 601
641 /* scale down magic considerably. */ 602 /* scale down magic considerably. */
642 if (type & AT_MAGIC && rndm (0, 5)) 603 if (type & AT_MAGIC && rndm (0, 5))
643 return; 604 return;
644 605
645 /* Did a player hurt another player? Inform both! */ 606 /* Did a player hurt another player? Inform both! */
646 if (op->type == PLAYER && (get_owner (hitter) == NULL ? hitter->type : hitter->owner->type) == PLAYER) 607 if (op->type == PLAYER && (hitter->owner == NULL ? hitter->type : hitter->owner->type) == PLAYER)
647 { 608 {
648 if (get_owner (hitter) != NULL) 609 if (hitter->owner != NULL)
649 sprintf (buf, "%s's %s%s you.", &hitter->owner->name, &hitter->name, buf2); 610 sprintf (buf, "%s's %s%s you.", &hitter->owner->name, &hitter->name, buf2);
650 else 611 else
651 { 612 {
652 sprintf (buf, "%s%s you.", &hitter->name, buf2); 613 sprintf (buf, "%s%s you.", &hitter->name, buf2);
614
653 if (dam != 0) 615 if (dam != 0)
654 { 616 {
655 if (dam < 10) 617 if (dam < 10)
656 play_sound_player_only (op->contr, SOUND_PLAYER_IS_HIT1, 0, 0); 618 op->contr->play_sound (sound_find ("player_is_hit1"));
657 else if (dam < 20) 619 else if (dam < 20)
658 play_sound_player_only (op->contr, SOUND_PLAYER_IS_HIT2, 0, 0); 620 op->contr->play_sound (sound_find ("player_is_hit2"));
659 else 621 else
660 play_sound_player_only (op->contr, SOUND_PLAYER_IS_HIT3, 0, 0); 622 op->contr->play_sound (sound_find ("player_is_hit3"));
661 } 623 }
662 } 624 }
625
663 new_draw_info (NDI_BLACK, 0, op, buf); 626 new_draw_info (NDI_BLACK, 0, op, buf);
664 } /* end of player hitting player */ 627 } /* end of player hitting player */
665 628
666 if (hitter->type == PLAYER) 629 if (hitter->type == PLAYER)
667 { 630 {
668 sprintf (buf, "You %s.", buf1); 631 sprintf (buf, "You %s.", buf1);
632
669 if (dam != 0) 633 if (dam != 0)
670 { 634 {
671 if (dam < 10) 635 if (dam < 10)
672 play_sound_player_only (hitter->contr, SOUND_PLAYER_HITS1, 0, 0); 636 op->play_sound (sound_find ("player_hits1"));
673 else if (dam < 20) 637 else if (dam < 20)
674 play_sound_player_only (hitter->contr, SOUND_PLAYER_HITS2, 0, 0); 638 op->play_sound (sound_find ("player_hits2"));
675 else 639 else
676 play_sound_player_only (hitter->contr, SOUND_PLAYER_HITS3, 0, 0); 640 op->play_sound (sound_find ("player_hits3"));
677 } 641 }
642
678 new_draw_info (NDI_BLACK, 0, hitter, buf); 643 new_draw_info (NDI_BLACK, 0, hitter, buf);
679 } 644 }
680 else if (get_owner (hitter) != NULL && hitter->owner->type == PLAYER) 645 else if (hitter->owner != NULL && hitter->owner->type == PLAYER)
681 { 646 {
682 /* look for stacked spells and start reducing the message chances */ 647 /* look for stacked spells and start reducing the message chances */
683 if (hitter->type == SPELL_EFFECT && (hitter->subtype == SP_EXPLOSION || hitter->subtype == SP_BULLET || hitter->subtype == SP_CONE)) 648 if (hitter->type == SPELL_EFFECT && (hitter->subtype == SP_EXPLOSION || hitter->subtype == SP_BULLET || hitter->subtype == SP_CONE))
684 { 649 {
685 i = 4; 650 i = 4;
686 map = hitter->map; 651 map = hitter->map;
687 if (out_of_map (map, hitter->x, hitter->y)) 652 if (out_of_map (map, hitter->x, hitter->y))
688 return; 653 return;
654
689 next = get_map_ob (map, hitter->x, hitter->y); 655 next = GET_MAP_OB (map, hitter->x, hitter->y);
690 if (next) 656 if (next)
691 while (next) 657 while (next)
692 { 658 {
693 if (next->type == SPELL_EFFECT && (next->subtype == SP_EXPLOSION || next->subtype == SP_BULLET || next->subtype == SP_CONE)) 659 if (next->type == SPELL_EFFECT && (next->subtype == SP_EXPLOSION || next->subtype == SP_BULLET || next->subtype == SP_CONE))
694 i *= 3; 660 i *= 3;
661
695 tmp = next; 662 tmp = next;
696 next = tmp->above; 663 next = tmp->above;
697 } 664 }
665
698 if (i < 0) 666 if (i < 0)
699 return; 667 return;
668
700 if (rndm (0, i) != 0) 669 if (rndm (0, i) != 0)
701 return; 670 return;
702 } 671 }
703 else if (rndm (0, 5) != 0) 672 else if (rndm (0, 5) != 0)
704 return; 673 return;
674
705 sprintf (buf, "Your %s%s %s.", &hitter->name, buf2, &op->name); 675 sprintf (buf, "Your %s%s %s.", &hitter->name, buf2, &op->name);
706 play_sound_map (op->map, op->x, op->y, SOUND_PLAYER_HITS4); 676 op->play_sound (sound_find ("player_hits4"));
707 new_draw_info (NDI_BLACK, 0, hitter->owner, buf); 677 new_draw_info (NDI_BLACK, 0, hitter->owner, buf);
708 } 678 }
709} 679}
710
711 680
712static int 681static int
713get_attack_mode (object **target, object **hitter, int *simple_attack) 682get_attack_mode (object **target, object **hitter, int *simple_attack)
714{ 683{
715 if (QUERY_FLAG (*target, FLAG_FREED) || QUERY_FLAG (*hitter, FLAG_FREED)) 684 if (QUERY_FLAG (*target, FLAG_FREED) || QUERY_FLAG (*hitter, FLAG_FREED))
716 { 685 {
717 LOG (llevError, "BUG: get_attack_mode(): freed object\n"); 686 LOG (llevError, "BUG: get_attack_mode(): freed object\n");
718 return 1; 687 return 1;
719 } 688 }
720 if ((*target)->head) 689
721 *target = (*target)->head; 690 *target = (*target)->head_ ();
722 if ((*hitter)->head)
723 *hitter = (*hitter)->head; 691 *hitter = (*hitter)->head_ ();
692
693 if ((*target)->type == LOCKED_DOOR)
694 return 1; // locked doors cannot be hit
695
724 if ((*hitter)->env != NULL || (*target)->env != NULL) 696 if ((*hitter)->env || (*target)->env)
725 { 697 {
726 *simple_attack = 1; 698 *simple_attack = 1;
727 return 0; 699 return 0;
728 } 700 }
701
729 if (QUERY_FLAG (*target, FLAG_REMOVED) 702 if (QUERY_FLAG (*target, FLAG_REMOVED)
730 || QUERY_FLAG (*hitter, FLAG_REMOVED) || (*hitter)->map == NULL || !on_same_map ((*hitter), (*target))) 703 || QUERY_FLAG (*hitter, FLAG_REMOVED)
704 || !(*hitter)->map
705 || !on_same_map (*hitter, *target))
731 { 706 {
732 LOG (llevError, "BUG: hitter (arch %s, name %s) with no relation to " "target\n", &(*hitter)->arch->name, &(*hitter)->name); 707 LOG (llevError | logBacktrace, "BUG: hitter (%s) with no relation to target (%s)\n",
708 (*hitter)->debug_desc (), (*target)->debug_desc ());
733 return 1; 709 return 1;
734 } 710 }
711
735 *simple_attack = 0; 712 *simple_attack = 0;
736 return 0; 713 return 0;
737} 714}
738 715
739static int 716static int
740abort_attack (object *target, object *hitter, int simple_attack) 717abort_attack (object *target, object *hitter, int simple_attack)
741{ 718{
742
743/* Check if target and hitter are still in a relation similar to the one 719 /* Check if target and hitter are still in a relation similar to the one
744 * determined by get_attack_mode(). Returns true if the relation has changed. 720 * determined by get_attack_mode(). Returns true if the relation has changed.
745 */ 721 */
746 int new_mode; 722 int new_mode;
747 723
748 if (hitter->env == target || target->env == hitter) 724 if (hitter->env == target || target->env == hitter)
749 new_mode = 1; 725 new_mode = 1;
750 else if (QUERY_FLAG (hitter, FLAG_REMOVED) || QUERY_FLAG (target, FLAG_REMOVED) || hitter->map == NULL || !on_same_map (hitter, target)) 726 else if (QUERY_FLAG (hitter, FLAG_REMOVED) || QUERY_FLAG (target, FLAG_REMOVED)
727 || hitter->map == NULL || !on_same_map (hitter, target))
751 return 1; 728 return 1;
752 else 729 else
753 new_mode = 0; 730 new_mode = 0;
731
754 return new_mode != simple_attack; 732 return new_mode != simple_attack;
755} 733}
756 734
757static void thrown_item_effect (object *, object *); 735static void thrown_item_effect (object *, object *);
758 736
… …
760attack_ob_simple (object *op, object *hitter, int base_dam, int base_wc) 738attack_ob_simple (object *op, object *hitter, int base_dam, int base_wc)
761{ 739{
762 int simple_attack, roll, dam = 0; 740 int simple_attack, roll, dam = 0;
763 uint32 type; 741 uint32 type;
764 shstr op_name; 742 shstr op_name;
765 tag_t op_tag, hitter_tag;
766 743
767 if (get_attack_mode (&op, &hitter, &simple_attack)) 744 if (get_attack_mode (&op, &hitter, &simple_attack))
768 goto error; 745 goto error;
769 746
770 if (hitter->current_weapon) 747 if (hitter->current_weapon)
771 if (INVOKE_OBJECT (WEAPON_ATTACK, hitter->current_weapon, ARG_OBJECT (hitter), ARG_OBJECT (op))) 748 if (INVOKE_OBJECT (WEAPON_ATTACK, hitter->current_weapon, ARG_OBJECT (hitter), ARG_OBJECT (op)))
772 return RESULT_INT (0); 749 return RESULT_INT (0);
773 750
774 if (INVOKE_OBJECT (ATTACK, op, ARG_OBJECT (hitter))) 751 if (INVOKE_OBJECT (ATTACK, op, ARG_OBJECT (hitter)))
775 return RESULT_INT (0); 752 return RESULT_INT (0);
776
777 op_tag = op->count;
778 hitter_tag = hitter->count;
779 753
780 /* 754 /*
781 * A little check to make it more difficult to dance forward and back 755 * A little check to make it more difficult to dance forward and back
782 * to avoid ever being hit by monsters. 756 * to avoid ever being hit by monsters.
783 */ 757 */
784 if (!simple_attack && QUERY_FLAG (op, FLAG_MONSTER) && op->speed_left > -(FABS (op->speed)) * 0.3) 758 if (!simple_attack && QUERY_FLAG (op, FLAG_MONSTER) && op->speed_left > abs (op->speed) * -0.3f)
785 { 759 {
786 /* Decrease speed BEFORE calling process_object. Otherwise, an 760 /* Decrease speed BEFORE calling process_object. Otherwise, an
787 * infinite loop occurs, with process_object calling move_monster, 761 * infinite loop occurs, with process_object calling move_monster,
788 * which then gets here again. By decreasing the speed before 762 * which then gets here again. By decreasing the speed before
789 * we call process_object, the 'if' statement above will fail. 763 * we call process_object, the 'if' statement above will fail.
790 */ 764 */
791 op->speed_left--; 765 --op->speed_left;
792 process_object (op); 766 process_object (op);
767
793 if (was_destroyed (op, op_tag) || was_destroyed (hitter, hitter_tag) || abort_attack (op, hitter, simple_attack)) 768 if (op->destroyed () || hitter->destroyed () || abort_attack (op, hitter, simple_attack))
794 goto error; 769 goto error;
795 } 770 }
796 771
797 op_name = op->name; 772 op_name = op->name;
798 773
… …
805 /* See if we hit the creature */ 780 /* See if we hit the creature */
806 if (roll == 20 || op->stats.ac >= base_wc - roll) 781 if (roll == 20 || op->stats.ac >= base_wc - roll)
807 { 782 {
808 int hitdam = base_dam; 783 int hitdam = base_dam;
809 784
810 if (settings.casting_time == TRUE)
811 {
812 if ((hitter->type == PLAYER) && (hitter->casting_time > -1))
813 {
814 hitter->casting_time = -1;
815 new_draw_info (NDI_UNIQUE, 0, hitter, "You attacked and lost " "your spell!");
816 }
817 if ((op->casting_time > -1) && (hitdam > 0))
818 {
819 op->casting_time = -1;
820 if (op->type == PLAYER)
821 {
822 new_draw_info (NDI_UNIQUE, 0, op, "You were hit and lost " "your spell!");
823 new_draw_info_format (NDI_ALL | NDI_UNIQUE, 5, NULL, "%s was hit by %s and lost a spell.", &op_name, &hitter->name);
824 }
825 }
826 }
827 if (!simple_attack) 785 if (!simple_attack)
828 { 786 {
829 /* If you hit something, the victim should *always* wake up. 787 /* If you hit something, the victim should *always* wake up.
830 * Before, invisible hitters could avoid doing this. 788 * Before, invisible hitters could avoid doing this.
831 * -b.t. */ 789 * -b.t. */
832 if (QUERY_FLAG (op, FLAG_SLEEP)) 790 if (QUERY_FLAG (op, FLAG_SLEEP))
833 CLEAR_FLAG (op, FLAG_SLEEP); 791 CLEAR_FLAG (op, FLAG_SLEEP);
834 792
835 /* If the victim can't see the attacker, it may alert others 793 /* If the victim can't see the attacker, it may alert others
836 * for help. */ 794 * for help. */
837 if (op->type != PLAYER && !can_see_enemy (op, hitter) && !get_owner (op) && rndm (0, op->stats.Int)) 795 if (op->type != PLAYER && !can_see_enemy (op, hitter) && !op->owner && rndm (0, op->stats.Int))
838 npc_call_help (op); 796 npc_call_help (op);
839 797
840 /* if you were hidden and hit by a creature, you are discovered */ 798 /* if you were hidden and hit by a creature, you are discovered */
841 if (op->hide && QUERY_FLAG (hitter, FLAG_ALIVE)) 799 if (op->flag [FLAG_HIDDEN] && hitter->flag [FLAG_ALIVE])
842 { 800 {
843 make_visible (op); 801 make_visible (op);
802
844 if (op->type == PLAYER) 803 if (op->type == PLAYER)
845 new_draw_info (NDI_UNIQUE, 0, op, "You were hit by a wild attack. " "You are no longer hidden!"); 804 new_draw_info (NDI_UNIQUE, 0, op, "You were hit by a wild attack. You are no longer hidden!");
846 } 805 }
847 806
848 /* thrown items (hitter) will have various effects 807 /* thrown items (hitter) will have various effects
849 * when they hit the victim. For things like thrown daggers, 808 * when they hit the victim. For things like thrown daggers,
850 * this sets 'hitter' to the actual dagger, and not the 809 * this sets 'hitter' to the actual dagger, and not the
851 * wrapper object. 810 * wrapper object.
852 */ 811 */
853 thrown_item_effect (hitter, op); 812 thrown_item_effect (hitter, op);
813
854 if (was_destroyed (hitter, hitter_tag) || was_destroyed (op, op_tag) || abort_attack (op, hitter, simple_attack)) 814 if (hitter->destroyed () || op->destroyed () || abort_attack (op, hitter, simple_attack))
855 goto leave; 815 goto leave;
856 } 816 }
857 817
858 /* Need to do at least 1 damage, otherwise there is no point 818 /* Need to do at least 1 damage, otherwise there is no point
859 * to go further and it will cause FPE's below. 819 * to go further and it will cause FPE's below.
860 */ 820 */
861 if (hitdam <= 0) 821 if (hitdam <= 0)
862 hitdam = 1; 822 hitdam = 1;
863 823
864 type = hitter->attacktype; 824 type = hitter->attacktype;
825
826 /* Ok, because some of the brainfucks of the good *sigh* old *sigh*
827 * Crossfire we have to default the attacktype here to AT_PHYSICAL.
828 * This check is important for the most simple monsters out there in the
829 * game content (maps, archs). For example orcs: They would have
830 * no attacktype at all.
831 *
832 * Some time in the future someone should just go into the game data
833 * and fix every monster out there ;-/ Until then we will kill some
834 * more trees in the african rain forests with this check.
835 */
865 if (!type) 836 if (!type)
866 type = AT_PHYSICAL; 837 type = AT_PHYSICAL;
838
867 /* Handle monsters that hit back */ 839 /* Handle monsters that hit back */
868 if (!simple_attack && QUERY_FLAG (op, FLAG_HITBACK) && QUERY_FLAG (hitter, FLAG_ALIVE)) 840 if (!simple_attack && QUERY_FLAG (op, FLAG_HITBACK) && QUERY_FLAG (hitter, FLAG_ALIVE))
869 { 841 {
870 if (op->attacktype & AT_ACID && hitter->type == PLAYER) 842 if (op->attacktype & AT_ACID && hitter->type == PLAYER)
871 new_draw_info (NDI_UNIQUE, 0, hitter, "You are splashed by acid!\n"); 843 new_draw_info (NDI_UNIQUE, 0, hitter, "You are splashed by acid!\n");
844
872 hit_player (hitter, random_roll (0, (op->stats.dam), hitter, PREFER_LOW), op, op->attacktype, 1); 845 hit_player (hitter, random_roll (0, (op->stats.dam), hitter, PREFER_LOW), op, op->attacktype, 1);
846
873 if (was_destroyed (op, op_tag) || was_destroyed (hitter, hitter_tag) || abort_attack (op, hitter, simple_attack)) 847 if (op->destroyed () || hitter->destroyed () || abort_attack (op, hitter, simple_attack))
874 goto leave; 848 goto leave;
875 } 849 }
876 850
877 /* In the new attack code, it should handle multiple attack 851 /* In the new attack code, it should handle multiple attack
878 * types in its area, so remove it from here. 852 * types in its area, so remove it from here.
879 */ 853 */
880 dam = hit_player (op, random_roll (1, hitdam, hitter, PREFER_HIGH), hitter, type, 1); 854 dam = hit_player (op, random_roll (1, hitdam, hitter, PREFER_HIGH), hitter, type, 1);
855
881 if (was_destroyed (op, op_tag) || was_destroyed (hitter, hitter_tag) || abort_attack (op, hitter, simple_attack)) 856 if (op->destroyed () || hitter->destroyed () || abort_attack (op, hitter, simple_attack))
882 goto leave; 857 goto leave;
883 } /* end of if hitter hit op */ 858 } /* end of if hitter hit op */
884 /* if we missed, dam=0 */ 859 /* if we missed, dam=0 */
885 860
886 /*attack_message(dam, type, op, hitter); */ 861 /*attack_message(dam, type, op, hitter); */
… …
896} 871}
897 872
898int 873int
899attack_ob (object *op, object *hitter) 874attack_ob (object *op, object *hitter)
900{ 875{
901
902 if (hitter->head)
903 hitter = hitter->head; 876 hitter = hitter->head_ ();
877
904 return attack_ob_simple (op, hitter, hitter->stats.dam, hitter->stats.wc); 878 return attack_ob_simple (op, hitter, hitter->stats.dam, hitter->stats.wc);
905} 879}
906 880
907/* op is the arrow, tmp is what is stopping the arrow. 881/* op is the arrow, tmp is what is stopping the arrow.
908 * 882 *
… …
917 * debate - 5000 is 5 kg, so arrows, knives, and other light weapons 891 * debate - 5000 is 5 kg, so arrows, knives, and other light weapons
918 * stick around. 892 * stick around.
919 */ 893 */
920 if (op->weight <= 5000 && tmp->stats.hp >= 0) 894 if (op->weight <= 5000 && tmp->stats.hp >= 0)
921 { 895 {
922 if (tmp->head != NULL) 896 tmp->head_ ()->insert (op);
923 tmp = tmp->head;
924
925 remove_ob (op);
926 op = insert_ob_in_ob (op, tmp);
927
928 if (tmp->type == PLAYER)
929 esrv_send_item (tmp, op);
930
931 return 1; 897 return 1;
932 } 898 }
933 else 899 else
934 return 0; 900 return 0;
935} 901}
… …
943object * 909object *
944hit_with_arrow (object *op, object *victim) 910hit_with_arrow (object *op, object *victim)
945{ 911{
946 object *container, *hitter; 912 object *container, *hitter;
947 int hit_something = 0; 913 int hit_something = 0;
948 tag_t victim_tag, hitter_tag;
949 sint16 victim_x, victim_y;
950 914
951 /* Disassemble missile */ 915 /* Disassemble missile */
952 if (op->inv) 916 if (op->inv)
953 { 917 {
954 container = op; 918 container = op;
955 hitter = op->inv; 919 hitter = op->inv;
956 remove_ob (hitter);
957 insert_ob_in_map (hitter, container->map, hitter, INS_NO_MERGE | INS_NO_WALK_ON); 920 hitter->insert_at (container, hitter, INS_NO_MERGE | INS_NO_WALK_ON);
958 /* Note that we now have an empty THROWN_OBJ on the map. Code that 921 /* Note that we now have an empty THROWN_OBJ on the map. Code that
959 * might be called until this THROWN_OBJ is either reassembled or 922 * might be called until this THROWN_OBJ is either reassembled or
960 * removed at the end of this function must be able to deal with empty 923 * removed at the end of this function must be able to deal with empty
961 * THROWN_OBJs. */ 924 * THROWN_OBJs. */
962 } 925 }
963 else 926 else
964 { 927 {
965 container = NULL; 928 container = 0;
966 hitter = op; 929 hitter = op;
967 } 930 }
968 931
969 /* Try to hit victim */ 932 /* Try to hit victim */
970 victim_x = victim->x;
971 victim_y = victim->y;
972 victim_tag = victim->count;
973 hitter_tag = hitter->count;
974
975 hit_something = attack_ob_simple (victim, hitter, op->stats.dam, op->stats.wc); 933 hit_something = attack_ob_simple (victim, hitter, op->stats.dam, op->stats.wc);
976 934
977 /* Arrow attacks door, rune of summoning is triggered, demon is put on 935 /* Arrow attacks door, rune of summoning is triggered, demon is put on
978 * arrow, move_apply() calls this function, arrow sticks in demon, 936 * arrow, move_apply() calls this function, arrow sticks in demon,
979 * attack_ob_simple() returns, and we've got an arrow that still exists 937 * attack_ob_simple() returns, and we've got an arrow that still exists
980 * but is no longer on the map. Ugh. (Beware: Such things can happen at 938 * but is no longer on the map. Ugh. (Beware: Such things can happen at
981 * other places as well!) 939 * other places as well!)
982 */ 940 */
983 if (was_destroyed (hitter, hitter_tag) || hitter->env != NULL) 941 if (hitter->destroyed () || hitter->env != NULL)
984 { 942 {
985 if (container) 943 if (container)
986 { 944 container->destroy ();
987 remove_ob (container); 945
988 free_object (container);
989 }
990 return NULL; 946 return 0;
991 } 947 }
992 948
993 /* Missile hit victim */ 949 /* Missile hit victim */
994 /* if the speed is > 10, then this is a fast moving arrow, we go straight 950 /* if the speed is > 10, then this is a fast moving arrow, we go straight
995 * through the target 951 * through the target
996 */ 952 */
997 if (hit_something && op->speed <= 10.0) 953 if (hit_something && op->speed <= 10.0)
998 { 954 {
999 /* Stop arrow */ 955 /* Stop arrow */
1000 if (container == NULL) 956 if (!container)
1001 { 957 {
1002 hitter = fix_stopped_arrow (hitter); 958 hitter = fix_stopped_arrow (hitter);
1003 if (hitter == NULL) 959 if (!hitter)
1004 return NULL; 960 return 0;
1005 } 961 }
1006 else 962 else
1007 { 963 container->destroy ();
1008 remove_ob (container);
1009 free_object (container);
1010 }
1011 964
1012 /* Try to stick arrow into victim */ 965 /* Try to stick arrow into victim */
1013 if (!was_destroyed (victim, victim_tag) && stick_arrow (hitter, victim)) 966 if (!victim->destroyed () && stick_arrow (hitter, victim))
1014 return NULL; 967 return 0;
1015 968
1016 /* Else try to put arrow on victim's map square 969 /* Else try to put arrow on victim's map square
1017 * remove check for P_WALL here. If the arrow got to this 970 * remove check for P_WALL here. If the arrow got to this
1018 * space, that is good enough - with the new movement code, 971 * space, that is good enough - with the new movement code,
1019 * there is now the potential for lots of spaces where something 972 * there is now the potential for lots of spaces where something
1020 * can fly over but not otherwise move over. What is the correct 973 * can fly over but not otherwise move over. What is the correct
1021 * way to handle those otherwise? 974 * way to handle those otherwise?
1022 */ 975 */
1023 if (victim_x != hitter->x || victim_y != hitter->y) 976 if (victim->x != hitter->x || victim->y != hitter->y)
977 {
978 if (victim->destroyed ())
979 hitter->destroy ();
980 else
1024 { 981 {
1025 remove_ob (hitter); 982 hitter->remove ();
1026 hitter->x = victim_x; 983 hitter->x = victim->x;
1027 hitter->y = victim_y; 984 hitter->y = victim->y;
1028 insert_ob_in_map (hitter, victim->map, hitter, 0); 985 insert_ob_in_map (hitter, victim->map, hitter, 0);
986 }
1029 } 987 }
1030 else 988 else
1031 {
1032 /* Else leave arrow where it is */ 989 /* Else leave arrow where it is */
1033 merge_ob (hitter, NULL); 990 merge_ob (hitter, NULL);
1034 } 991
1035 return NULL; 992 return 0;
1036 } 993 }
1037 994
1038 if (hit_something && op->speed >= 10.0) 995 if (hit_something && op->speed >= 10.0)
1039 op->speed -= 1.0; 996 op->speed -= 1.0;
1040 997
1041 /* Missile missed victim - reassemble missile */ 998 /* Missile missed victim - reassemble missile */
1042 if (container) 999 if (container)
1043 { 1000 {
1044 remove_ob (hitter); 1001 hitter->remove ();
1045 insert_ob_in_ob (hitter, container); 1002 insert_ob_in_ob (hitter, container);
1046 } 1003 }
1004
1047 return op; 1005 return op;
1048} 1006}
1049
1050 1007
1051void 1008void
1052tear_down_wall (object *op) 1009tear_down_wall (object *op)
1053{ 1010{
1054 int perc = 0;
1055
1056 if (!op->stats.maxhp) 1011 if (!op->stats.maxhp)
1057 {
1058 LOG (llevError, "TEAR_DOWN wall %s had no maxhp.\n", &op->name); 1012 LOG (llevError, "TEAR_DOWN wall %s had no maxhp.\n", &op->name);
1059 perc = 1; 1013 else if (!op->has_anim ())
1060 }
1061 else if (!GET_ANIM_ID (op))
1062 { 1014 {
1063 /* Object has been called - no animations, so remove it */ 1015 /* Object has been called - no animations, so remove it */
1064 if (op->stats.hp < 0) 1016 if (op->stats.hp < 0)
1017 op->destroy ();
1065 { 1018
1066 remove_ob (op); /* Should update LOS */
1067 free_object (op);
1068 /* Don't know why this is here - remove_ob should do it for us */
1069 /*update_position(m, x, y); */
1070 }
1071 return; /* no animations, so nothing more to do */ 1019 return; /* no animations, so nothing more to do */
1072 } 1020 }
1073 perc = NUM_ANIMATIONS (op) - ((int) NUM_ANIMATIONS (op) * op->stats.hp) / op->stats.maxhp; 1021
1074 if (perc >= (int) NUM_ANIMATIONS (op)) 1022 // we use frames 1..num-2 as intermediate frames, so
1075 perc = NUM_ANIMATIONS (op) - 1; 1023 // the last frame is used only when hp < 0.
1076 else if (perc < 1) 1024 int perc = clamp (
1077 perc = 1; 1025 lerp_ru<int> (op->stats.hp, 0, op->stats.maxhp, op->anim_frames () - 2, 0),
1078 SET_ANIMATION (op, perc); 1026 0, op->anim_frames () - 1
1027 );
1028
1029 op->set_anim_frame (perc);
1079 update_object (op, UP_OBJ_FACE); 1030 update_object (op, UP_OBJ_FACE);
1080 if (perc == NUM_ANIMATIONS (op) - 1) 1031
1032 if (op->stats.hp < 0)
1081 { /* Reached the last animation */ 1033 { /* Reached the last animation */
1082 if (op->face == blank_face) 1034 if (op->face == blank_face)
1083 {
1084 /* If the last face is blank, remove the ob */ 1035 /* If the last face is blank, remove the ob */
1085 remove_ob (op); /* Should update LOS */ 1036 op->destroy ();
1086 free_object (op);
1087
1088 /* remove_ob should call update_position for us */
1089 /*update_position(m, x, y); */
1090
1091 }
1092 else 1037 else
1093 { /* The last face was not blank, leave an image */ 1038 { /* The last face was not blank, leave an image */
1094 CLEAR_FLAG (op, FLAG_BLOCKSVIEW); 1039 op->flag [FLAG_BLOCKSVIEW] = false;
1095 update_all_los (op->map, op->x, op->y); 1040 update_all_los (op->map, op->x, op->y);
1096 op->move_block = 0; 1041 op->move_block = 0;
1097 CLEAR_FLAG (op, FLAG_ALIVE); 1042 op->flag [FLAG_ALIVE] = false;
1098 } 1043 }
1099 } 1044 }
1100} 1045}
1101 1046
1102void 1047void
1103scare_creature (object *target, object *hitter) 1048scare_creature (object *target, object *hitter)
1104{ 1049{
1105 object *owner = get_owner (hitter); 1050 target->flag [FLAG_SCARED] = true;
1106 1051
1107 if (!owner)
1108 owner = hitter;
1109
1110 SET_FLAG (target, FLAG_SCARED);
1111 if (!target->enemy) 1052 if (!target->enemy)
1112 target->enemy = owner; 1053 target->enemy = hitter->outer_owner ();
1113} 1054}
1114
1115 1055
1116/* This returns the amount of damage hitter does to op with the 1056/* This returns the amount of damage hitter does to op with the
1117 * appropriate attacktype. Only 1 attacktype should be set at a time. 1057 * appropriate attacktype. Only 1 attacktype should be set at a time.
1118 * This doesn't damage the player, but returns how much it should 1058 * This doesn't damage the player, but returns how much it should
1119 * take. However, it will do other effects (paralyzation, slow, etc.) 1059 * take. However, it will do other effects (paralyzation, slow, etc.)
1120 * Note - changed for PR code - we now pass the attack number and not 1060 * Note - changed for PR code - we now pass the attack number and not
1121 * the attacktype. Makes it easier for the PR code. */ 1061 * the attacktype. Makes it easier for the PR code. */
1122
1123int 1062int
1124hit_player_attacktype (object *op, object *hitter, int dam, uint32 attacknum, int magic) 1063hit_player_attacktype (object *op, object *hitter, int dam, uint32 attacknum, int magic)
1125{ 1064{
1126
1127 int doesnt_slay = 1; 1065 int doesnt_slay = 1;
1128 1066
1129 /* Catch anyone that may be trying to send us a bitmask instead of the number */ 1067 /* Catch anyone that may be trying to send us a bitmask instead of the number */
1130 if (attacknum >= NROFATTACKS) 1068 if (attacknum >= NROFATTACKS)
1131 { 1069 {
… …
1133 return 0; 1071 return 0;
1134 } 1072 }
1135 1073
1136 if (dam < 0) 1074 if (dam < 0)
1137 { 1075 {
1138 LOG (llevError, "hit_player_attacktype called with negative damage: %d\n", dam); 1076 LOG (llevError, "hit_player_attacktype called with negative damage %d (hitter %s, target %s)\n",
1077 dam, hitter->debug_desc (), op->debug_desc ());
1139 return 0; 1078 return 0;
1140 } 1079 }
1141 1080
1142 /* AT_INTERNAL is supposed to do exactly dam. Put a case here so 1081 /* AT_INTERNAL is supposed to do exactly dam. Put a case here so
1143 * people can't mess with that or it otherwise get confused. */ 1082 * people can't mess with that or it otherwise get confused. */
1144 if (attacknum == ATNR_INTERNAL) 1083 if (attacknum == ATNR_INTERNAL)
1145 return dam; 1084 return dam;
1146 1085
1147 if (hitter->slaying) 1086 if (hitter->slaying)
1148 { 1087 {
1149 if (((op->race != NULL) && strstr (hitter->slaying, op->race)) || 1088 if ((op->race && hitter->slaying.contains (op->race))
1150 (op->arch && (op->arch->name != NULL) && strstr (op->arch->name, hitter->slaying))) 1089 || (op->arch && op->arch->archname.contains (hitter->slaying)))
1151 { 1090 {
1152 doesnt_slay = 0; 1091 doesnt_slay = 0;
1153 dam *= 3; 1092 dam *= 3;
1154 } 1093 }
1155 } 1094 }
… …
1169 /* Special hack. By default, if immune to something, you 1108 /* Special hack. By default, if immune to something, you
1170 * shouldn't need to worry. However, acid is an exception, since 1109 * shouldn't need to worry. However, acid is an exception, since
1171 * it can still damage your items. Only include attacktypes if 1110 * it can still damage your items. Only include attacktypes if
1172 * special processing is needed */ 1111 * special processing is needed */
1173 1112
1174 if ((op->resist[attacknum] >= 100) && doesnt_slay && (attacknum != ATNR_ACID)) 1113 if (op->resist[attacknum] >= 100
1114 && doesnt_slay
1115 && attacknum != ATNR_ACID)
1175 return 0; 1116 return 0;
1176 1117
1177 /* Keep this in order - makes things easier to find */ 1118 /* Keep this in order - makes things easier to find */
1178 1119
1179 switch (attacknum) 1120 switch (attacknum)
1180 { 1121 {
1181 case ATNR_PHYSICAL: 1122 case ATNR_PHYSICAL:
1182 /* here also check for diseases */ 1123 /* here also check for diseases */
1183 check_physically_infect (op, hitter); 1124 check_physically_infect (op, hitter);
1184 break; 1125 break;
1185 1126
1186 /* Don't need to do anything for: 1127 /* Don't need to do anything for:
1187 magic, 1128 magic,
1188 fire, 1129 fire,
1189 electricity, 1130 electricity,
1190 cold */ 1131 cold */
1191 1132
1192 case ATNR_CONFUSION: 1133 case ATNR_CONFUSION:
1193 case ATNR_POISON: 1134 case ATNR_POISON:
1194 case ATNR_SLOW: 1135 case ATNR_SLOW:
1195 case ATNR_PARALYZE: 1136 case ATNR_PARALYZE:
1196 case ATNR_FEAR: 1137 case ATNR_FEAR:
1197 case ATNR_CANCELLATION: 1138 case ATNR_CANCELLATION:
1198 case ATNR_DEPLETE: 1139 case ATNR_DEPLETE:
1199 case ATNR_BLIND: 1140 case ATNR_BLIND:
1200 { 1141 {
1201 /* chance for inflicting a special attack depends on the 1142 /* chance for inflicting a special attack depends on the
1202 * difference between attacker's and defender's level 1143 * difference between attacker's and defender's level
1203 */ 1144 */
1204 int level_diff = MIN (110, MAX (0, op->level - hitter->level)); 1145 int level_diff = MIN (110, MAX (0, op->level - hitter->level));
1205 1146
1206 /* First, only creatures/players with speed can be affected. 1147 /* First, only creatures/players with speed can be affected.
1207 * Second, just getting hit doesn't mean it always affects 1148 * Second, just getting hit doesn't mean it always affects
1208 * you. Third, you still get a saving through against the 1149 * you. Third, you still get a saving through against the
1209 * effect. 1150 * effect.
1210 */ 1151 */
1211 if (op->speed && 1152 if (op->speed &&
1212 (QUERY_FLAG (op, FLAG_MONSTER) || op->type == PLAYER) && 1153 (QUERY_FLAG (op, FLAG_MONSTER) || op->type == PLAYER) &&
1213 !(rndm (0, (attacknum == ATNR_SLOW ? 6 : 3) - 1)) && !did_make_save (op, level_diff, op->resist[attacknum] / 10)) 1154 !(rndm (0, (attacknum == ATNR_SLOW ? 6 : 3) - 1)) && !did_make_save (op, level_diff, op->resist[attacknum] / 10))
1214 { 1155 {
1215 1156
1216 /* Player has been hit by something */ 1157 /* Player has been hit by something */
1217 if (attacknum == ATNR_CONFUSION) 1158 if (attacknum == ATNR_CONFUSION)
1218 confuse_player (op, hitter, dam); 1159 confuse_player (op, hitter, dam);
1219 else if (attacknum == ATNR_POISON) 1160 else if (attacknum == ATNR_POISON)
1220 poison_player (op, hitter, dam); 1161 poison_player (op, hitter, dam);
1221 else if (attacknum == ATNR_SLOW) 1162 else if (attacknum == ATNR_SLOW)
1222 slow_player (op, hitter, dam); 1163 slow_player (op, hitter, dam);
1223 else if (attacknum == ATNR_PARALYZE) 1164 else if (attacknum == ATNR_PARALYZE)
1224 paralyze_player (op, hitter, dam); 1165 paralyze_player (op, hitter, dam);
1225 else if (attacknum == ATNR_FEAR) 1166 else if (attacknum == ATNR_FEAR)
1226 scare_creature (op, hitter); 1167 scare_creature (op, hitter);
1227 else if (attacknum == ATNR_CANCELLATION) 1168 else if (attacknum == ATNR_CANCELLATION)
1228 cancellation (op); 1169 cancellation (op);
1229 else if (attacknum == ATNR_DEPLETE) 1170 else if (attacknum == ATNR_DEPLETE)
1230 drain_stat (op); 1171 op->drain_stat ();
1231 else if (attacknum == ATNR_BLIND && !QUERY_FLAG (op, FLAG_UNDEAD) && !QUERY_FLAG (op, FLAG_GENERATOR)) 1172 else if (attacknum == ATNR_BLIND && !QUERY_FLAG (op, FLAG_UNDEAD) && !QUERY_FLAG (op, FLAG_GENERATOR))
1232 blind_player (op, hitter, dam); 1173 blind_player (op, hitter, dam);
1233 } 1174 }
1175
1234 dam = 0; /* These are all effects and don't do real damage */ 1176 dam = 0; /* These are all effects and don't do real damage */
1235 } 1177 }
1236 break; 1178 break;
1179
1237 case ATNR_ACID: 1180 case ATNR_ACID:
1238 { 1181 {
1239 int flag = 0; 1182 int flag = 0;
1240 1183
1241 /* Items only get corroded if you're not on a battleground and 1184 /* Items only get corroded if you're not on a battleground and
1242 * if your acid resistance is below 50%. */ 1185 * if your acid resistance is below 50%. */
1243 if (!op_on_battleground (op, NULL, NULL) && (op->resist[ATNR_ACID] < 50)) 1186 if (!op_on_battleground (op, NULL, NULL) && (op->resist[ATNR_ACID] < 50))
1244 { 1187 {
1245 object *tmp;
1246
1247 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1188 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1248 { 1189 {
1249 if (tmp->invisible) 1190 if (tmp->invisible)
1250 continue; 1191 continue;
1251 if (!QUERY_FLAG (tmp, FLAG_APPLIED) || (tmp->resist[ATNR_ACID] >= 10)) 1192 if (!QUERY_FLAG (tmp, FLAG_APPLIED) || (tmp->resist[ATNR_ACID] >= 10))
1252 /* >= 10% acid res. on itmes will protect these */ 1193 /* >= 10% acid res. on items will protect these */
1253 continue; 1194 continue;
1254 if (!(tmp->material & M_IRON)) 1195 if (!(tmp->materials & M_IRON))
1255 continue; 1196 continue;
1256 if (tmp->magic < -4) /* Let's stop at -5 */ 1197 if (tmp->magic < -4) /* Let's stop at -5 */
1257 continue; 1198 continue;
1258 if (tmp->type == RING || 1199 if (tmp->type == RING
1259 /* removed boots and gloves from exclusion list in 1200 /* removed boots and gloves from exclusion list in PR */
1260 PR */ 1201 || tmp->type == GIRDLE
1261 tmp->type == GIRDLE || tmp->type == AMULET || tmp->type == WAND || tmp->type == ROD || tmp->type == HORN) 1202 || tmp->type == AMULET
1203 || tmp->type == WAND
1204 || tmp->type == ROD
1205 || tmp->type == HORN)
1262 continue; /* To avoid some strange effects */ 1206 continue; /* To avoid some strange effects */
1263 1207
1264 /* High damage acid has better chance of corroding 1208 /* High damage acid has better chance of corroding
1265 objects */ 1209 objects */
1266 if (rndm (0, dam + 4) > random_roll (0, 39, op, PREFER_HIGH) + 2 * tmp->magic) 1210 if (rndm (0, dam + 4) > random_roll (0, 39, op, PREFER_HIGH) + 2 * tmp->magic)
1211 {
1212 flag = 1;
1213 tmp->magic--;
1214
1215 if (object *pl = tmp->visible_to ())
1267 { 1216 {
1268 if (op->type == PLAYER)
1269 /* Make this more visible */ 1217 /* Make this more visible */
1270 new_draw_info_format (NDI_UNIQUE | NDI_RED, 0, op, 1218 new_draw_info_format (NDI_UNIQUE | NDI_RED, 0, pl,
1271 "The %s's acid corrodes your %s!", query_name (hitter), query_name (tmp)); 1219 "The %s's acid corrodes your %s!", query_name (hitter), query_name (tmp));
1272 flag = 1; 1220
1273 tmp->magic--; 1221 esrv_send_item (op, tmp); //TODO: UPD_NAME should be enough (it's enough in other cases)
1274 if (op->type == PLAYER)
1275 esrv_send_item (op, tmp);
1276 } 1222 }
1277 } 1223 }
1278 if (flag) 1224 }
1279 fix_player (op); /* Something was corroded */
1280 } 1225
1226 if (flag)
1227 op->update_stats (); /* Something was corroded */
1281 } 1228 }
1229 }
1282 break; 1230 break;
1231
1283 case ATNR_DRAIN: 1232 case ATNR_DRAIN:
1284 { 1233 {
1285 /* rate is the proportion of exp drained. High rate means 1234 /* rate is the proportion of exp drained. High rate means
1286 * not much is drained, low rate means a lot is drained. 1235 * not much is drained, low rate means a lot is drained.
1287 */ 1236 */
1288 int rate; 1237 int rate;
1289 1238
1290 if (op->resist[ATNR_DRAIN] >= 0) 1239 if (op->resist[ATNR_DRAIN] >= 0)
1291 rate = 400 + op->resist[ATNR_DRAIN] * 3; 1240 rate = 400 + op->resist[ATNR_DRAIN] * 3;
1292 else 1241 else
1293 rate = 400 * 100 / (100 - op->resist[ATNR_DRAIN]); 1242 rate = 400 * 100 / (100 - op->resist[ATNR_DRAIN]);
1294 1243
1295 if (op->stats.exp <= rate) 1244 if (op->stats.exp <= rate)
1296 { 1245 {
1297 if (op->type == GOLEM) 1246 if (op->type == GOLEM)
1298 dam = 999; /* Its force is "sucked" away. 8) */ 1247 dam = 999; /* Its force is "sucked" away. 8) */
1299 else 1248 else
1300 /* If we can't drain, lets try to do physical damage */ 1249 /* If we can't drain, lets try to do physical damage */
1301 dam = hit_player_attacktype (op, hitter, dam, ATNR_PHYSICAL, magic); 1250 dam = hit_player_attacktype (op, hitter, dam, ATNR_PHYSICAL, magic);
1302 } 1251 }
1303 else 1252 else
1304 { 1253 {
1305 /* Randomly give the hitter some hp */ 1254 /* Randomly give the hitter some hp */
1306 if (hitter->stats.hp < hitter->stats.maxhp && 1255 if (hitter->stats.hp < hitter->stats.maxhp &&
1307 (op->level > hitter->level) && random_roll (0, (op->level - hitter->level + 2), hitter, PREFER_HIGH) > 3) 1256 (op->level > hitter->level) && random_roll (0, (op->level - hitter->level + 2), hitter, PREFER_HIGH) > 3)
1308 hitter->stats.hp++; 1257 hitter->stats.hp++;
1309 1258
1310 /* Can't do drains on battleground spaces. 1259 /* Can't do drains on battleground spaces.
1311 * Move the wiz check up here - before, the hitter wouldn't gain exp 1260 * Move the wiz check up here - before, the hitter wouldn't gain exp
1312 * exp, but the wiz would still lose exp! If drainee is a wiz, 1261 * exp, but the wiz would still lose exp! If drainee is a wiz,
1313 * nothing happens. 1262 * nothing happens.
1314 * Try to credit the owner. We try to display player -> player drain 1263 * Try to credit the owner. We try to display player -> player drain
1315 * attacks, hence all the != PLAYER checks. 1264 * attacks, hence all the != PLAYER checks.
1316 */ 1265 */
1317 if (!op_on_battleground (hitter, NULL, NULL) && !QUERY_FLAG (op, FLAG_WAS_WIZ)) 1266 if (!op_on_battleground (hitter, NULL, NULL) && !QUERY_FLAG (op, FLAG_WIZ))
1318 { 1267 {
1319 object *owner = get_owner (hitter); 1268 object *owner = hitter->owner;
1320 1269
1321 if (owner && owner != hitter) 1270 if (owner && owner != hitter)
1322 { 1271 {
1323 if (op->type != PLAYER || owner->type != PLAYER) 1272 if (op->type != PLAYER || owner->type != PLAYER)
1324 change_exp (owner, op->stats.exp / (rate * 2), 1273 change_exp (owner, op->stats.exp / (rate * 2),
1325 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, SK_EXP_TOTAL); 1274 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, SK_EXP_TOTAL);
1326 } 1275 }
1327 else if (op->type != PLAYER || hitter->type != PLAYER) 1276 else if (op->type != PLAYER || hitter->type != PLAYER)
1328 {
1329 change_exp (hitter, op->stats.exp / (rate * 2), 1277 change_exp (hitter, op->stats.exp / (rate * 2),
1330 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, 0); 1278 hitter->chosen_skill ? hitter->chosen_skill->skill : (const char *) 0, 0);
1331 } 1279
1332 change_exp (op, -op->stats.exp / rate, NULL, 0); 1280 change_exp (op, -op->stats.exp / rate, NULL, 0);
1333 } 1281 }
1282
1334 dam = 1; /* Drain is an effect. Still return 1 - otherwise, if you have pure 1283 dam = 1; /* Drain is an effect. Still return 1 - otherwise, if you have pure
1335 * drain attack, you won't know that you are actually sucking out EXP, 1284 * drain attack, you won't know that you are actually sucking out EXP,
1336 * as the messages will say you missed 1285 * as the messages will say you missed
1337 */ 1286 */
1338 } 1287 }
1339 } 1288 }
1340 break; 1289 break;
1290
1341 case ATNR_TURN_UNDEAD: 1291 case ATNR_TURN_UNDEAD:
1342 { 1292 {
1343 if (QUERY_FLAG (op, FLAG_UNDEAD)) 1293 if (QUERY_FLAG (op, FLAG_UNDEAD))
1344 { 1294 {
1345 object *owner = hitter->owner ? (object *)hitter->owner : hitter; 1295 object *owner = hitter->owner ? (object *)hitter->owner : hitter;
1346 object *god = find_god (determine_god (owner)); 1296 object *god = find_god (determine_god (owner));
1347 int div = 1; 1297 int div = 1;
1348 1298
1349 /* if undead are not an enemy of your god, you turn them 1299 /* if undead are not an enemy of your god, you turn them
1350 * at half strength */ 1300 * at half strength */
1351 if (!god || !god->slaying || strstr (god->slaying, undead_name) == NULL) 1301 if (!god || !god->slaying.contains (shstr_undead))
1352 div = 2; 1302 div = 2;
1303
1353 /* Give a bonus if you resist turn undead */ 1304 /* Give a bonus if you resist turn undead */
1354 if (op->level * div < (turn_bonus[owner->stats.Wis] + owner->level + (op->resist[ATNR_TURN_UNDEAD] / 100))) 1305 if (op->level * div < (turn_bonus[owner->stats.Wis] + owner->level + (op->resist[ATNR_TURN_UNDEAD] / 100)))
1355 scare_creature (op, owner); 1306 scare_creature (op, owner);
1356 } 1307 }
1357 else 1308 else
1358 dam = 0; /* don't damage non undead - should we damage 1309 dam = 0; /* don't damage non undead - should we damage
1359 undead? */ 1310 undead? */
1360 } 1311 }
1361 break; 1312 break;
1313
1362 case ATNR_DEATH: 1314 case ATNR_DEATH:
1363 deathstrike_player (op, hitter, &dam); 1315 deathstrike_player (op, hitter, &dam);
1364 break; 1316 break;
1317
1365 case ATNR_CHAOS: 1318 case ATNR_CHAOS:
1366 LOG (llevError, "%s was hit by %s with non-specific chaos.\n", query_name (op), query_name (hitter)); 1319 LOG (llevError, "%s was hit by %s with non-specific chaos.\n", op->debug_desc (), hitter->debug_desc ());
1367 dam = 0; 1320 dam = 0;
1368 break; 1321 break;
1322
1369 case ATNR_COUNTERSPELL: 1323 case ATNR_COUNTERSPELL:
1370 LOG (llevError, "%s was hit by %s with counterspell attack.\n", query_name (op), query_name (hitter)); 1324 LOG (llevError, "%s was hit by %s with counterspell attack.\n", op->debug_desc (), hitter->debug_desc ());
1371 dam = 0; 1325 dam = 0;
1372 /* This should never happen. Counterspell is handled 1326 /* This should never happen. Counterspell is handled
1373 * seperately and filtered out. If this does happen, 1327 * seperately and filtered out. If this does happen,
1374 * Counterspell has no effect on anything but spells, so it 1328 * Counterspell has no effect on anything but spells, so it
1375 * does no damage. */ 1329 * does no damage. */
1376 break; 1330 break;
1331
1377 case ATNR_HOLYWORD: 1332 case ATNR_HOLYWORD:
1378 { 1333 {
1379 /* This has already been handled by hit_player, 1334 /* This has already been handled by hit_player,
1380 * no need to check twice -- DAMN */ 1335 * no need to check twice -- DAMN */
1381 object *owner = hitter->owner ? (object *)hitter->owner : hitter; 1336 object *owner = hitter->owner ? (object *)hitter->owner : hitter;
1382 1337
1383 /* As with turn undead above, give a bonus on the saving throw */ 1338 /* As with turn undead above, give a bonus on the saving throw */
1384 if ((op->level + (op->resist[ATNR_HOLYWORD] / 100)) < owner->level + turn_bonus[owner->stats.Wis]) 1339 if ((op->level + (op->resist[ATNR_HOLYWORD] / 100)) < owner->level + turn_bonus[owner->stats.Wis])
1385 scare_creature (op, owner); 1340 scare_creature (op, owner);
1386 } 1341 }
1387 break; 1342 break;
1343
1388 case ATNR_LIFE_STEALING: 1344 case ATNR_LIFE_STEALING:
1389 { 1345 {
1390 int new_hp; 1346 int new_hp;
1391 1347
1392 /* this is replacement to drain for players, instead of taking 1348 /* this is replacement to drain for players, instead of taking
1393 * exp it takes hp. It is geared for players, probably not 1349 * exp it takes hp. It is geared for players, probably not
1394 * much use giving it to monsters 1350 * much use giving it to monsters
1395 * 1351 *
1396 * life stealing doesn't do a lot of damage, but it gives the 1352 * life stealing doesn't do a lot of damage, but it gives the
1397 * damage it does do to the player. Given that, 1353 * damage it does do to the player. Given that,
1398 * it only does 1/10'th normal damage (hence the divide by 1354 * it only does 1/10'th normal damage (hence the divide by
1399 * 1000). 1355 * 1000).
1400 */ 1356 */
1401 /* You can't steal life from something undead */ 1357 /* You can't steal life from something undead */
1402 if ((op->type == GOLEM) || (QUERY_FLAG (op, FLAG_UNDEAD))) 1358 if ((op->type == GOLEM) || (QUERY_FLAG (op, FLAG_UNDEAD)))
1403 return 0; 1359 return 0;
1360
1404 /* If drain protection is higher than life stealing, use that */ 1361 /* If drain protection is higher than life stealing, use that */
1405 if (op->resist[ATNR_DRAIN] >= op->resist[ATNR_LIFE_STEALING]) 1362 if (op->resist[ATNR_DRAIN] >= op->resist[ATNR_LIFE_STEALING])
1406 dam = (dam * (100 - op->resist[ATNR_DRAIN])) / 3000; 1363 dam = (dam * (100 - op->resist[ATNR_DRAIN])) / 3000;
1407 else 1364 else
1408 dam = (dam * (100 - op->resist[ATNR_LIFE_STEALING])) / 3000; 1365 dam = (dam * (100 - op->resist[ATNR_LIFE_STEALING])) / 3000;
1366
1409 /* You die at -1 hp, not zero. */ 1367 /* You die at -1 hp, not zero. */
1410 if (dam > (op->stats.hp + 1)) 1368 if (dam > (op->stats.hp + 1))
1411 dam = op->stats.hp + 1; 1369 dam = op->stats.hp + 1;
1370
1412 new_hp = hitter->stats.hp + dam; 1371 new_hp = hitter->stats.hp + dam;
1413 if (new_hp > hitter->stats.maxhp) 1372 if (new_hp > hitter->stats.maxhp)
1414 new_hp = hitter->stats.maxhp; 1373 new_hp = hitter->stats.maxhp;
1374
1415 if (new_hp > hitter->stats.hp) 1375 if (new_hp > hitter->stats.hp)
1416 hitter->stats.hp = new_hp; 1376 hitter->stats.hp = new_hp;
1417 } 1377 }
1418 } 1378 }
1379
1419 return dam; 1380 return dam;
1420} 1381}
1421
1422 1382
1423/* GROS: This code comes from hit_player. It has been made external to 1383/* GROS: This code comes from hit_player. It has been made external to
1424 * allow script procedures to "kill" objects in a combat-like fashion. 1384 * allow script procedures to "kill" objects in a combat-like fashion.
1425 * It was initially used by (kill-object) developed for the Collector's 1385 * It was initially used by (kill-object) developed for the Collector's
1426 * Sword. Note that nothing has been changed from the original version 1386 * Sword. Note that nothing has been changed from the original version
… …
1437 */ 1397 */
1438int 1398int
1439kill_object (object *op, int dam, object *hitter, int type) 1399kill_object (object *op, int dam, object *hitter, int type)
1440{ 1400{
1441 char buf[MAX_BUF]; 1401 char buf[MAX_BUF];
1442 const char *skill; 1402 shstr skill;
1443 int maxdam = 0; 1403 int maxdam = 0;
1444 int battleg = 0; /* true if op standing on battleground */ 1404 int battleg = 0; /* true if op standing on battleground */
1445 int pk = 0; /* true if op and what controls hitter are both players */ 1405 int pk = 0; /* true if op and what controls hitter are both players */
1446 object *owner = NULL; 1406 object *owner = 0;
1447 object *skop = NULL; 1407 object *skop = 0;
1448 1408
1449 if (op->stats.hp >= 0) 1409 if (op->stats.hp >= 0)
1450 return -1; 1410 return -1;
1451 1411
1452 if (INVOKE_OBJECT (KILL, op, ARG_OBJECT (hitter))) 1412 if (INVOKE_OBJECT (KILL, op, ARG_OBJECT (hitter)))
… …
1461 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW)) 1421 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW))
1462 update_all_los (op->map, op->x, op->y); /* makes sure los will be recalculated */ 1422 update_all_los (op->map, op->x, op->y); /* makes sure los will be recalculated */
1463 1423
1464 if (op->type == DOOR) 1424 if (op->type == DOOR)
1465 { 1425 {
1466 op->speed = 0.1; 1426 op->set_speed (0.1f);
1467 update_ob_speed (op);
1468 op->speed_left = -0.05; 1427 op->speed_left = -0.05f;
1469 return maxdam; 1428 return maxdam;
1470 } 1429 }
1430
1471 if (QUERY_FLAG (op, FLAG_FRIENDLY) && op->type != PLAYER) 1431 if (QUERY_FLAG (op, FLAG_FRIENDLY) && op->type != PLAYER)
1472 { 1432 {
1473 remove_friendly_object (op); 1433 op->drop_and_destroy ();
1474 if (get_owner (op) != NULL && op->owner->type == PLAYER && op->owner->contr->ranges[range_golem] == op)
1475 {
1476 op->owner->contr->ranges[range_golem] = NULL;
1477 op->owner->contr->golem_count = 0;
1478 }
1479
1480 remove_ob (op);
1481 free_object (op);
1482 return maxdam; 1434 return maxdam;
1483 } 1435 }
1484 1436
1485 /* Now lets start dealing with experience we get for killing something */ 1437 /* Now lets start dealing with experience we get for killing something */
1486 1438
1487 owner = get_owner (hitter); 1439 owner = hitter->outer_owner ();
1488 if (owner == NULL) 1440 if (!owner)
1489 owner = hitter; 1441 owner = hitter;
1490 1442
1491 /* is the victim (op) standing on battleground? */ 1443 /* is the victim (op) standing on battleground? */
1492 if (op_on_battleground (op, NULL, NULL)) 1444 if (op_on_battleground (op, NULL, NULL))
1493 battleg = 1; 1445 battleg = 1;
… …
1497 pk = 1; 1449 pk = 1;
1498 1450
1499 /* Player killed something */ 1451 /* Player killed something */
1500 if (owner->type == PLAYER) 1452 if (owner->type == PLAYER)
1501 { 1453 {
1502 Log_Kill (owner->name,
1503 query_name (op), op->type, (owner != hitter) ? query_name (hitter) : NULL, (owner != hitter) ? hitter->type : 0);
1504
1505 /* Log players killing other players - makes it easier to detect 1454 /* Log players killing other players - makes it easier to detect
1506 * and filter out malicious player killers - that is why the 1455 * and filter out malicious player killers - that is why the
1507 * ip address is included. 1456 * ip address is included.
1508 */ 1457 */
1509 if (op->type == PLAYER && !battleg) 1458 if (op->type == PLAYER && !battleg)
… …
1513 char buf[256]; 1462 char buf[256];
1514 1463
1515 tmv = localtime (&t); 1464 tmv = localtime (&t);
1516 strftime (buf, 256, "%a %b %d %H:%M:%S %Y", tmv); 1465 strftime (buf, 256, "%a %b %d %H:%M:%S %Y", tmv);
1517 1466
1518 LOG (llevInfo, "%s PLAYER_KILL_PLAYER: %s (%s) killed %s\n", buf, &owner->name, owner->contr->socket.host, query_name (op)); 1467 LOG (llevInfo, "%s PLAYER_KILL_PLAYER: %s (%s) killed %s\n", buf, &owner->name, owner->contr->ns->host, query_name (op));
1519 } 1468 }
1520 1469
1521 /* try to filter some things out - basically, if you are 1470 /* try to filter some things out - basically, if you are
1522 * killing a level 1 creature and your level 20, you 1471 * killing a level 1 creature and your level 20, you
1523 * probably don't want to see that. 1472 * probably don't want to see that.
1524 */ 1473 */
1525 if (owner->level < op->level * 2 || op->stats.exp > 1000) 1474 if (owner->level < op->level * 2 || op->stats.exp > 1000)
1526 { 1475 {
1527 if (owner != hitter) 1476 if (owner != hitter)
1528 {
1529 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s with %s.", query_name (op), query_name (hitter)); 1477 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s with %s.", query_name (op), query_name (hitter));
1530 }
1531 else 1478 else
1532 {
1533 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s.", query_name (op)); 1479 new_draw_info_format (NDI_BLACK, 0, owner, "You killed %s.", query_name (op));
1534 } 1480
1535 /* Only play sounds for melee kills */ 1481 /* Only play sounds for melee kills */
1536 if (hitter->type == PLAYER) 1482 if (hitter->type == PLAYER)
1537 play_sound_map (owner->map, owner->x, owner->y, SOUND_PLAYER_KILLS); 1483 owner->play_sound (sound_find ("player_kills"));
1538 } 1484 }
1539 1485
1540 /* If a player kills another player, not on 1486 /* If a player kills another player, not on
1541 * battleground, the "killer" looses 1 luck. Since this is 1487 * battleground, the "killer" looses 1 luck. Since this is
1542 * not reversible, it's actually quite a pain IMHO. -AV 1488 * not reversible, it's actually quite a pain IMHO. -AV
… …
1544 * player that the object belonged to - so if you killed another player 1490 * player that the object belonged to - so if you killed another player
1545 * with spells, pets, whatever, there was no penalty. 1491 * with spells, pets, whatever, there was no penalty.
1546 * Changed to make luck penalty configurable in settings. 1492 * Changed to make luck penalty configurable in settings.
1547 */ 1493 */
1548 if (op->type == PLAYER && owner != op && !battleg) 1494 if (op->type == PLAYER && owner != op && !battleg)
1549 change_luck (owner, -settings.pk_luck_penalty); 1495 owner->change_luck (-settings.pk_luck_penalty);
1550 1496
1551 /* This code below deals with finding the appropriate skill 1497 /* This code below deals with finding the appropriate skill
1552 * to credit exp to. This is a bit problematic - we should 1498 * to credit exp to. This is a bit problematic - we should
1553 * probably never really have to look at current_weapon->skill 1499 * probably never really have to look at current_weapon->skill
1554 */ 1500 */
1555 skill = NULL;
1556 if (hitter->skill && hitter->type != PLAYER) 1501 if (hitter->skill && hitter->type != PLAYER)
1557 skill = hitter->skill; 1502 skill = hitter->skill;
1558 else if (owner->chosen_skill) 1503 else if (owner->chosen_skill)
1559 { 1504 {
1560 skill = owner->chosen_skill->skill;
1561 skop = owner->chosen_skill; 1505 skop = owner->chosen_skill;
1506 skill = skop->skill;
1562 } 1507 }
1563 else if (QUERY_FLAG (owner, FLAG_READY_WEAPON)) 1508 else if (QUERY_FLAG (owner, FLAG_READY_WEAPON) && owner->current_weapon)
1564 skill = owner->current_weapon->skill; 1509 skill = owner->current_weapon->skill;
1565 else 1510 else
1511 {
1566 LOG (llevError, "kill_object - unable to find skill that killed monster\n"); 1512 LOG (llevError, "BUG: kill_object - unable to find skill that killed monster\n"
1513 "op: %s\n" "hitter: %s\n" "owner: %s\n",
1514 owner->debug_desc (), hitter->debug_desc (), op->debug_desc ());
1515 skill = 0;
1516 }
1567 1517
1568 /* We have the skill we want to credit to - now find the object this goes 1518 /* We have the skill we want to credit to - now find the object this goes
1569 * to. Make sure skop is an actual skill, and not a skill tool! 1519 * to. Make sure skop is an actual skill, and not a skill tool!
1570 */ 1520 */
1571 if ((!skop || skop->type != SKILL) && skill) 1521 skop = owner->contr->find_skill (skill);
1572 {
1573 int i;
1574
1575 for (i = 0; i < NUM_SKILLS; i++)
1576 if (owner->contr->last_skill_ob[i] && !strcmp (owner->contr->last_skill_ob[i]->skill, skill))
1577 {
1578 skop = owner->contr->last_skill_ob[i];
1579 break;
1580 }
1581 }
1582 } /* Was it a player that hit somethign */ 1522 } /* Was it a player that hit somethign */
1583 else 1523 else
1584 {
1585 skill = NULL; 1524 skill = 0;
1586 }
1587 1525
1588 /* Pet (or spell) killed something. */
1589 if (owner != hitter)
1590 {
1591 (void) sprintf (buf, "%s killed %s with %s%s%s.", &owner->name,
1592 query_name (op), query_name (hitter), battleg ? " (duel)" : "", pk ? " (pk)" : "");
1593 }
1594 else
1595 {
1596 (void) sprintf (buf, "%s killed %s%s%s%s.", &hitter->name, &op->name,
1597 (QUERY_FLAG (hitter, FLAG_MONSTER)) || hitter->type == PLAYER ?
1598 " in hand to hand combat" : "", battleg ? " (duel)" : "", pk ? " (pk)" : "");
1599 }
1600 /* These may have been set in the player code section above */ 1526 /* These may have been set in the player code section above */
1601 if (!skop) 1527 if (!skop)
1602 skop = hitter->chosen_skill; 1528 skop = hitter->chosen_skill;
1529
1603 if (!skill && skop) 1530 if (!skill && skop)
1604 skill = skop->skill; 1531 skill = skop->skill;
1605 1532
1606 new_draw_info (NDI_ALL, op->type == PLAYER ? 1 : 10, NULL, buf);
1607
1608
1609 /* If you didn't kill yourself, and your not the wizard */ 1533 /* If you didn't kill yourself, and your not the wizard */
1610 if (owner != op && !QUERY_FLAG (op, FLAG_WAS_WIZ)) 1534 if (owner != op && !QUERY_FLAG (op, FLAG_WIZ))
1611 { 1535 {
1612 int exp; 1536 int exp;
1613 1537
1614 /* Really don't give much experience for killing other players */ 1538 /* Really don't give much experience for killing other players */
1615 // schmorp: temporary? reduce the amount of exp gained for pking enourmously 1539 // schmorp: temporarily? reduce the amount of exp gained for pking enourmously
1616 if (op->type == PLAYER) 1540 if (op->type == PLAYER)
1617 { 1541 {
1618 if (battleg) 1542 if (battleg)
1619 { 1543 {
1620 new_draw_info (NDI_UNIQUE, 0, owner, "Your foe has fallen!"); 1544 new_draw_info (NDI_UNIQUE, 0, owner, "Your foe has fallen!");
… …
1638 1562
1639 if (!settings.simple_exp) 1563 if (!settings.simple_exp)
1640 exp = exp / 2; 1564 exp = exp / 2;
1641 1565
1642 if (owner->type != PLAYER || owner->contr->party == NULL) 1566 if (owner->type != PLAYER || owner->contr->party == NULL)
1643 {
1644 change_exp (owner, exp, skill, 0); 1567 change_exp (owner, exp, skill, 0);
1645 }
1646 else 1568 else
1647 { 1569 {
1648 int shares = 0, count = 0; 1570 int shares = 0, count = 0;
1649
1650 player *pl;
1651
1652 partylist *party = owner->contr->party; 1571 partylist *party = owner->contr->party;
1653 1572
1654#ifdef PARTY_KILL_LOG
1655 add_kill_to_party (party, query_name (owner), query_name (op), exp); 1573 add_kill_to_party (party, query_name (owner), query_name (op), exp);
1656#endif 1574
1657 for (pl = first_player; pl != NULL; pl = pl->next) 1575 for_all_players (pl)
1658 {
1659 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner)) 1576 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner))
1660 { 1577 {
1661 count++; 1578 count++;
1662 shares += (pl->ob->level + 4); 1579 shares += (pl->ob->level + 4);
1663 } 1580 }
1664 } 1581
1665 if (count == 1 || shares > exp) 1582 if (count == 1 || shares > exp || !shares)
1666 change_exp (owner, exp, skill, SK_EXP_TOTAL); 1583 change_exp (owner, exp, skill, SK_EXP_TOTAL);
1667 else 1584 else
1668 { 1585 {
1669 int share = exp / shares, given = 0, nexp; 1586 int share = exp / shares, given = 0, nexp;
1670 1587
1671 for (pl = first_player; pl != NULL; pl = pl->next) 1588 for_all_players (pl)
1672 {
1673 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner)) 1589 if (party && pl->ob->contr->party == party && on_same_map (pl->ob, owner))
1674 { 1590 {
1675 nexp = (pl->ob->level + 4) * share; 1591 nexp = (pl->ob->level + 4) * share;
1676 change_exp (pl->ob, nexp, skill, SK_EXP_TOTAL); 1592 change_exp (pl->ob, nexp, skill, SK_EXP_TOTAL);
1677 given += nexp; 1593 given += nexp;
1678 } 1594 }
1679 } 1595
1680 exp -= given; 1596 exp -= given;
1681 /* give any remainder to the player */ 1597 /* give any remainder to the player */
1682 change_exp (owner, exp, skill, SK_EXP_ADD_SKILL); 1598 change_exp (owner, exp, skill, SK_EXP_ADD_SKILL);
1683 } 1599 }
1684 } /* else part of a party */ 1600 } /* else part of a party */
1685
1686 } /* end if person didn't kill himself */ 1601 } /* end if person didn't kill himself */
1687 1602
1688 if (op->type != PLAYER) 1603 if (op->type != PLAYER)
1689 { 1604 {
1690 if (QUERY_FLAG (op, FLAG_FRIENDLY)) 1605 if (QUERY_FLAG (op, FLAG_FRIENDLY))
1691 { 1606 {
1692 object *owner1 = get_owner (op); 1607 object *owner1 = op->owner;
1693 1608
1694 if (owner1 != NULL && owner1->type == PLAYER) 1609 if (owner1 && owner1->type == PLAYER)
1695 { 1610 {
1696 play_sound_player_only (owner1->contr, SOUND_PET_IS_KILLED, 0, 0); 1611 owner1->contr->play_sound (sound_find ("pet_is_killed"));
1697 /* Maybe we should include the owner that killed this, maybe not */ 1612 /* Maybe we should include the owner that killed this, maybe not */
1698 new_draw_info_format (NDI_UNIQUE, 0, owner1, "Your pet, the %s, is killed by %s.", &op->name, &hitter->name); 1613 new_draw_info_format (NDI_UNIQUE, 0, owner1, "Your pet, the %s, was killed by %s.", &op->name, &hitter->name);
1699 } 1614 }
1700 1615
1701 remove_friendly_object (op); 1616 remove_friendly_object (op);
1702 } 1617 }
1703 1618
1704 remove_ob (op); 1619 op->drop_and_destroy ();
1705 free_object (op);
1706 } 1620 }
1707 /* Player has been killed! */
1708 else 1621 else
1709 { 1622 /* Player has been killed! */
1710 if (owner->type == PLAYER) 1623 op->contr->killer = owner->type == PLAYER ? owner : hitter;
1711 {
1712 snprintf (op->contr->killer, BIG_NAME, "%s the %s", &owner->name, owner->contr->title);
1713 }
1714 else
1715 assign (op->contr->killer, hitter->name);
1716 }
1717 1624
1718 /* This was return -1 - that doesn't seem correct - if we return -1, process 1625 /* This was return -1 - that doesn't seem correct - if we return -1, process
1719 * continues in the calling function. 1626 * continues in the calling function.
1720 */ 1627 */
1721 return maxdam; 1628 return maxdam;
1722} 1629}
1723 1630
1724/* Find out if this is friendly fire (PVP and attacker is peaceful) or not 1631/* Find out if this is friendly fire (PVP and attacker is peaceful) or not
1725 * Returns 0 this is not friendly fire 1632 * Returns 0 this is not friendly fire
1726 */ 1633 */
1727
1728int 1634int
1729friendly_fire (object *op, object *hitter) 1635friendly_fire (object *op, object *hitter)
1730{ 1636{
1731 object *owner; 1637 object *owner;
1732 int friendlyfire; 1638 int friendlyfire;
… …
1742 return 0; 1648 return 0;
1743 1649
1744 if (hitter->type == PLAYER && hitter->contr->peaceful == 1) 1650 if (hitter->type == PLAYER && hitter->contr->peaceful == 1)
1745 return 1; 1651 return 1;
1746 1652
1747 if ((owner = get_owner (hitter)) != NULL) 1653 if ((owner = hitter->owner) != NULL)
1748 { 1654 {
1749 if (owner->type == PLAYER && owner->contr->peaceful == 1) 1655 if (owner->type == PLAYER && owner->contr->peaceful == 1)
1750 friendlyfire = 2; 1656 friendlyfire = 2;
1751 } 1657 }
1752 1658
1753 if (hitter->type == SPELL || hitter->type == POISONING || hitter->type == DISEASE || hitter->type == RUNE) 1659 if (hitter->type == SPELL || hitter->type == POISONING || hitter->type == DISEASE || hitter->type == RUNE)
1754 friendlyfire = 0; 1660 friendlyfire = 0;
1755 } 1661 }
1662
1756 return friendlyfire; 1663 return friendlyfire;
1757} 1664}
1758
1759 1665
1760/* This isn't used just for players, but in fact most objects. 1666/* This isn't used just for players, but in fact most objects.
1761 * op is the object to be hit, dam is the amount of damage, hitter 1667 * op is the object to be hit, dam is the amount of damage, hitter
1762 * is what is hitting the object, type is the attacktype, and 1668 * is what is hitting the object, type is the attacktype, and
1763 * full_hit is set if monster area does not matter. 1669 * full_hit is set if monster area does not matter.
1764 * dam is base damage - protections/vulnerabilities/slaying matches can 1670 * dam is base damage - protections/vulnerabilities/slaying matches can
1765 * modify it. 1671 * modify it.
1766 */ 1672 */
1767
1768 /* Oct 95 - altered the following slightly for MULTIPLE_GODS hack 1673/* Oct 95 - altered the following slightly for MULTIPLE_GODS hack
1769 * which needs new attacktype AT_HOLYWORD to work . b.t. */ 1674 * which needs new attacktype AT_HOLYWORD to work . b.t. */
1770
1771int 1675int
1772hit_player (object *op, int dam, object *hitter, int type, int full_hit) 1676hit_player (object *op, int dam, object *hitter, int type, int full_hit)
1773{ 1677{
1774 int maxdam = 0, ndam = 0, attacktype = 1, magic = (type & AT_MAGIC); 1678 int maxdam = 0, ndam = 0, attacktype = 1, magic = (type & AT_MAGIC);
1775 int maxattacktype, attacknum; 1679 int maxattacktype, attacknum;
1776 int body_attack = op && op->head; /* Did we hit op's head? */ 1680 int body_attack = op && op->head; /* Did we hit op's head? */
1777 int simple_attack; 1681 int simple_attack;
1778 tag_t op_tag, hitter_tag;
1779 int rtn_kill = 0; 1682 int rtn_kill = 0;
1780 int friendlyfire; 1683 int friendlyfire;
1781 1684
1782 if (get_attack_mode (&op, &hitter, &simple_attack)) 1685 if (get_attack_mode (&op, &hitter, &simple_attack))
1783 return 0; 1686 return 0;
1784 1687
1785 /* very simple: if our target has no_damage 1 set or is wiz, we can't hurt him */ 1688 /* very simple: if our target has no_damage 1 set or is wiz, we can't hurt him */
1786 if (QUERY_FLAG (op, FLAG_WIZ) || QUERY_FLAG (op, FLAG_NO_DAMAGE)) 1689 if (QUERY_FLAG (op, FLAG_WIZ) || QUERY_FLAG (op, FLAG_NO_DAMAGE))
1787 return 0; 1690 return 0;
1788 1691
1789#ifdef PROHIBIT_PLAYERKILL 1692 // only allow pk for hostile players
1790 if (op->type == PLAYER) 1693 if (op->type == PLAYER)
1791 { 1694 {
1792 object *owner = get_owner (hitter); 1695 object *owner = hitter->owner;
1793 1696
1794 if (!owner) 1697 if (!owner)
1795 owner = hitter; 1698 owner = hitter;
1796 if (owner->type == PLAYER && (!op_on_battleground (op, 0, 0) && (op->contr->peaceful || owner->contr->peaceful)) && op != owner) 1699
1797 { 1700 if (owner->type == PLAYER
1701 && (!op_on_battleground (op, 0, 0)
1702 && (op->contr->peaceful || owner->contr->peaceful))
1703 && op != owner)
1798 return 0; 1704 return 0;
1799 }
1800 } 1705 }
1801#endif
1802
1803 op_tag = op->count;
1804 hitter_tag = hitter->count;
1805 1706
1806 if (body_attack) 1707 if (body_attack)
1807 { 1708 {
1808 /* slow and paralyze must hit the head. But we don't want to just 1709 /* slow and paralyze must hit the head. But we don't want to just
1809 * return - we still need to process other attacks the spell still 1710 * return - we still need to process other attacks the spell still
… …
1815 * attack so we don't cancel out things like magic bullet. 1716 * attack so we don't cancel out things like magic bullet.
1816 */ 1717 */
1817 if (type & (AT_PARALYZE | AT_SLOW)) 1718 if (type & (AT_PARALYZE | AT_SLOW))
1818 { 1719 {
1819 type &= ~(AT_PARALYZE | AT_SLOW); 1720 type &= ~(AT_PARALYZE | AT_SLOW);
1721
1820 if (!type || type == AT_MAGIC) 1722 if (!type || type == AT_MAGIC)
1821 return 0; 1723 return 0;
1822 } 1724 }
1823 } 1725 }
1824 1726
1825 if (!simple_attack && op->type == DOOR) 1727 if (!simple_attack && op->type == DOOR)
1826 { 1728 {
1827 object *tmp;
1828
1829 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1729 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1830 if (tmp->type == RUNE || tmp->type == TRAP) 1730 if (tmp->type == RUNE || tmp->type == TRAP)
1831 { 1731 {
1832 spring_trap (tmp, hitter); 1732 spring_trap (tmp, hitter);
1733
1833 if (was_destroyed (hitter, hitter_tag) || was_destroyed (op, op_tag) || abort_attack (op, hitter, simple_attack)) 1734 if (hitter->destroyed () || op->destroyed () || abort_attack (op, hitter, simple_attack))
1834 return 0; 1735 return 0;
1736
1835 break; 1737 break;
1836 } 1738 }
1837 } 1739 }
1838 1740
1839 if (!QUERY_FLAG (op, FLAG_ALIVE) || op->stats.hp < 0) 1741 if (!QUERY_FLAG (op, FLAG_ALIVE) || op->stats.hp < 0)
1840 { 1742 {
1841 /* FIXME: If a player is killed by a rune in a door, the 1743 /* FIXME: If a player is killed by a rune in a door, the
1842 * was_destroyed() check above doesn't return, and might get here. 1744 * destroyed() check above doesn't return, and might get here.
1843 */ 1745 */
1746
1747 /* FIXME: This for example happens when a dead door is on a mover and
1748 gets it's speed_left raised on each mover-tick.
1749 Doors are removed in a kinda funny way by giving them speed and speed_left
1750 and waiting for that to run out.
1751 */
1844 LOG (llevDebug, "victim (arch %s, name %s) already dead in " "hit_player()\n", &op->arch->name, &op->name); 1752 LOG (llevDebug, "victim %s (%d) already dead in hit_player()\n", op->debug_desc (), op->stats.hp);
1845 return 0; 1753 return 0;
1846 } 1754 }
1847 1755
1848#ifdef ATTACK_DEBUG 1756#ifdef ATTACK_DEBUG
1849 LOG (llevDebug, "hit player: attacktype %d, dam %d\n", type, dam); 1757 LOG (llevDebug, "hit player: attacktype %d, dam %d\n", type, dam);
… …
1855 * in case 0>dam>1, we try to "simulate" a float value-effect */ 1763 * in case 0>dam>1, we try to "simulate" a float value-effect */
1856 dam = dam * (100 - op->resist[ATNR_MAGIC]); 1764 dam = dam * (100 - op->resist[ATNR_MAGIC]);
1857 if (dam >= 100) 1765 if (dam >= 100)
1858 dam /= 100; 1766 dam /= 100;
1859 else 1767 else
1860 dam = (dam > (rndm (0, 99))) ? 1 : 0; 1768 dam = (dam > rndm (0, 99)) ? 1 : 0;
1861 } 1769 }
1862 1770
1863 /* AT_CHAOS here is a weapon or monster. Spells are handled by hit_map 1771 /* AT_CHAOS here is a weapon or monster. Spells are handled by hit_map
1864 * If the attacktype still has chaos, shuffle it, then clear the Chaos bit 1772 * If the attacktype still has chaos, shuffle it, then clear the Chaos bit
1865 */ 1773 */
… …
1876 */ 1784 */
1877 if (type & AT_HOLYWORD) 1785 if (type & AT_HOLYWORD)
1878 { 1786 {
1879 object *god; 1787 object *god;
1880 1788
1881 if ((!hitter->slaying || 1789 if ((!hitter->slaying
1882 (!(op->race && strstr (hitter->slaying, op->race)) && 1790 || (!(op->race && hitter->slaying.contains (op->race))
1883 !(op->name && strstr (hitter->slaying, op->name)))) && 1791 && !(op->name && hitter->slaying.contains (op->name))))
1884 (!QUERY_FLAG (op, FLAG_UNDEAD) || 1792 && (!QUERY_FLAG (op, FLAG_UNDEAD)
1885 (hitter->title != NULL 1793 || (hitter->title
1886 && (god = find_god (determine_god (hitter))) != NULL && god->race != NULL && strstr (god->race, undead_name) != NULL))) 1794 && (god = find_god (determine_god (hitter))) != NULL
1795 && god->race.contains (shstr_undead))))
1887 return 0; 1796 return 0;
1888 } 1797 }
1889 1798
1890 maxattacktype = type; /* initialize this to something */ 1799 maxattacktype = type; /* initialise this to something */
1891 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++, attacktype = 1 << attacknum) 1800 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++, attacktype = 1 << attacknum)
1892 { 1801 {
1893 /* Magic isn't really a true attack type - it gets combined with other 1802 /* Magic isn't really a true attack type - it gets combined with other
1894 * attack types. As such, skip it over. However, if magic is 1803 * attack types. As such, skip it over. However, if magic is
1895 * the only attacktype in the group, then still attack with it 1804 * the only attacktype in the group, then still attack with it
… …
1923 */ 1832 */
1924 friendlyfire = friendly_fire (op, hitter); 1833 friendlyfire = friendly_fire (op, hitter);
1925 if (friendlyfire && maxdam) 1834 if (friendlyfire && maxdam)
1926 { 1835 {
1927 maxdam = ((dam * settings.set_friendly_fire) / 100); 1836 maxdam = ((dam * settings.set_friendly_fire) / 100);
1928#ifndef COZY_SERVER
1929 maxdam++;
1930#endif
1931 1837
1932#ifdef ATTACK_DEBUG 1838#ifdef ATTACK_DEBUG
1933 LOG (llevDebug, "Friendly fire (type:%d setting: %d%) did %d damage dropped to %d\n", 1839 LOG (llevDebug, "Friendly fire (type:%d setting: %d%) did %d damage dropped to %d\n",
1934 friendlyfire, settings.set_friendly_fire, dam, maxdam); 1840 friendlyfire, settings.set_friendly_fire, dam, maxdam);
1935#endif 1841#endif
1936 } 1842 }
1937 1843
1938 if (!full_hit) 1844 if (!full_hit)
1939 { 1845 {
1940 archetype *at;
1941 int area; 1846 int area;
1942 int remainder; 1847 int remainder;
1943 1848
1944 area = 0; 1849 area = 0;
1945 for (at = op->arch; at != NULL; at = at->more) 1850
1851 for (archetype *at = op->arch; at; at = (archetype *)at->more)
1946 area++; 1852 area++;
1853
1947 assert (area > 0); 1854 assert (area > 0);
1948 1855
1949 /* basically: maxdam /= area; we try to "simulate" a float 1856 /* basically: maxdam /= area; we try to "simulate" a float
1950 value-effect */ 1857 value-effect */
1951 remainder = 100 * (maxdam % area) / area; 1858 remainder = 100 * (maxdam % area) / area;
1952 maxdam /= area; 1859 maxdam /= area;
1953 if (RANDOM () % 100 < remainder) 1860 if (rndm (100) < remainder)
1954 maxdam++; 1861 maxdam++;
1955 } 1862 }
1956 1863
1957#ifdef ATTACK_DEBUG 1864#ifdef ATTACK_DEBUG
1958 LOG (llevDebug, "Attacktype %d did %d damage\n", type, maxdam); 1865 LOG (llevDebug, "Attacktype %d did %d damage\n", type, maxdam);
1959#endif 1866#endif
1960 1867
1961 if (get_owner (hitter)) 1868 // for now, only do this for active objects, otherwise they
1869 // keep a refcount for a long time and I see no usefulness
1870 // for an non-active objetc to know its enemy.
1871 if (op->active)
1872 if (hitter->owner)
1962 op->enemy = hitter->owner; 1873 op->enemy = hitter->owner;
1963 else if (QUERY_FLAG (hitter, FLAG_ALIVE)) 1874 else if (QUERY_FLAG (hitter, FLAG_ALIVE))
1964 op->enemy = hitter; 1875 op->enemy = hitter;
1965 1876
1966 if (QUERY_FLAG (op, FLAG_UNAGGRESSIVE) && op->type != PLAYER) 1877 if (QUERY_FLAG (op, FLAG_UNAGGRESSIVE) && op->type != PLAYER)
1967 { 1878 {
1968 /* The unaggressives look after themselves 8) */ 1879 /* The unaggressives look after themselves 8) */
1969 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE); 1880 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE);
… …
1991 1902
1992 if (QUERY_FLAG (op, FLAG_TEAR_DOWN)) 1903 if (QUERY_FLAG (op, FLAG_TEAR_DOWN))
1993 { 1904 {
1994 if (maxdam) 1905 if (maxdam)
1995 tear_down_wall (op); 1906 tear_down_wall (op);
1907
1996 return maxdam; /* nothing more to do for wall */ 1908 return maxdam; /* nothing more to do for wall */
1997 } 1909 }
1998 1910
1999 /* See if the creature has been killed */ 1911 /* See if the creature has been killed */
2000 rtn_kill = kill_object (op, maxdam, hitter, type); 1912 rtn_kill = kill_object (op, maxdam, hitter, type);
2001 if (rtn_kill != -1) 1913 if (rtn_kill != -1)
2002 return rtn_kill; 1914 return rtn_kill;
2003
2004 1915
2005 /* Used to be ghosthit removal - we now use the ONE_HIT flag. Note 1916 /* Used to be ghosthit removal - we now use the ONE_HIT flag. Note
2006 * that before if the player was immune to ghosthit, the monster 1917 * that before if the player was immune to ghosthit, the monster
2007 * remained - that is no longer the case. 1918 * remained - that is no longer the case.
2008 */ 1919 */
2009 if (QUERY_FLAG (hitter, FLAG_ONE_HIT)) 1920 if (QUERY_FLAG (hitter, FLAG_ONE_HIT))
2010 { 1921 hitter->drop_and_destroy ();
2011 if (QUERY_FLAG (hitter, FLAG_FRIENDLY))
2012 remove_friendly_object (hitter);
2013 remove_ob (hitter);
2014 free_object (hitter);
2015 }
2016 /* Lets handle creatures that are splitting now */ 1922 /* Lets handle creatures that are splitting now */
2017 else if (type & AT_PHYSICAL && !QUERY_FLAG (op, FLAG_FREED) && QUERY_FLAG (op, FLAG_SPLITTING)) 1923 else if (type & AT_PHYSICAL && !QUERY_FLAG (op, FLAG_FREED) && QUERY_FLAG (op, FLAG_SPLITTING))
2018 { 1924 {
2019 int i; 1925 int i;
2020 int friendly = QUERY_FLAG (op, FLAG_FRIENDLY); 1926 int friendly = QUERY_FLAG (op, FLAG_FRIENDLY);
2021 int unaggressive = QUERY_FLAG (op, FLAG_UNAGGRESSIVE); 1927 int unaggressive = QUERY_FLAG (op, FLAG_UNAGGRESSIVE);
2022 object *owner = get_owner (op); 1928 object *owner = op->owner;
2023 1929
2024 if (!op->other_arch) 1930 if (!op->other_arch)
2025 { 1931 {
2026 LOG (llevError, "SPLITTING without other_arch error.\n"); 1932 LOG (llevError, "SPLITTING without other_arch error.\n");
2027 return maxdam; 1933 return maxdam;
2028 } 1934 }
1935
2029 remove_ob (op); 1936 op->remove ();
2030 for (i = 0; i < NROFNEWOBJS (op); i++) 1937
1938 for (i = 0; i < op->stats.food; i++)
2031 { /* This doesn't handle op->more yet */ 1939 { /* This doesn't handle op->more yet */
2032 object *tmp = arch_to_object (op->other_arch); 1940 object *tmp = arch_to_object (op->other_arch);
2033 int j; 1941 int j;
2034 1942
2035 tmp->stats.hp = op->stats.hp; 1943 tmp->stats.hp = op->stats.hp;
1944
2036 if (friendly) 1945 if (friendly)
2037 { 1946 {
2038 SET_FLAG (tmp, FLAG_FRIENDLY);
2039 add_friendly_object (tmp); 1947 add_friendly_object (tmp);
2040 tmp->attack_movement = PETMOVE; 1948 tmp->attack_movement = PETMOVE;
1949
2041 if (owner != NULL) 1950 if (owner)
2042 set_owner (tmp, owner); 1951 tmp->set_owner (owner);
2043 } 1952 }
1953
2044 if (unaggressive) 1954 if (unaggressive)
2045 SET_FLAG (tmp, FLAG_UNAGGRESSIVE); 1955 SET_FLAG (tmp, FLAG_UNAGGRESSIVE);
1956
2046 j = find_first_free_spot (tmp, op->map, op->x, op->y); 1957 j = find_first_free_spot (tmp, op->map, op->x, op->y);
1958
2047 if (j == -1) /* No spot to put this monster */ 1959 if (j == -1) /* No spot to put this monster */
2048 free_object (tmp); 1960 tmp->destroy ();
2049 else 1961 else
2050 { 1962 {
2051 tmp->x = op->x + freearr_x[j], tmp->y = op->y + freearr_y[j]; 1963 tmp->x = op->x + freearr_x[j], tmp->y = op->y + freearr_y[j];
2052 insert_ob_in_map (tmp, op->map, NULL, 0); 1964 insert_ob_in_map (tmp, op->map, NULL, 0);
2053 } 1965 }
2054 } 1966 }
2055 if (friendly) 1967
2056 remove_friendly_object (op); 1968 op->destroy ();
2057 free_object (op);
2058 } 1969 }
2059 else if (type & AT_DRAIN && hitter->type == GRIMREAPER && hitter->value++ > 10) 1970 else if (type & AT_DRAIN && hitter->type == GRIMREAPER && hitter->value++ > 10)
2060 { 1971 hitter->drop_and_destroy ();
2061 remove_ob (hitter); 1972
2062 free_object (hitter);
2063 }
2064 return maxdam; 1973 return maxdam;
2065} 1974}
2066
2067 1975
2068void 1976void
2069poison_player (object *op, object *hitter, int dam) 1977poison_player (object *op, object *hitter, int dam)
2070{ 1978{
2071 archetype *at = find_archetype ("poisoning"); 1979 archetype *at = archetype::find ("poisoning");
2072 object *tmp = present_arch_in_ob (at, op); 1980 object *tmp = present_arch_in_ob (at, op);
2073 1981
2074 if (tmp == NULL) 1982 if (tmp == NULL)
2075 { 1983 {
2076 if ((tmp = arch_to_object (at)) == NULL) 1984 if ((tmp = arch_to_object (at)) == NULL)
… …
2089 if (QUERY_FLAG (hitter, FLAG_ALIVE)) 1997 if (QUERY_FLAG (hitter, FLAG_ALIVE))
2090 tmp->stats.dam += hitter->level / 2; 1998 tmp->stats.dam += hitter->level / 2;
2091 else 1999 else
2092 tmp->stats.dam = dam; 2000 tmp->stats.dam = dam;
2093 2001
2094 copy_owner (tmp, hitter); /* so we get credit for poisoning kills */ 2002 tmp->set_owner (hitter); /* so we get credit for poisoning kills */
2095 if (hitter->skill && hitter->skill != tmp->skill) 2003 if (hitter->skill && hitter->skill != tmp->skill)
2096 { 2004 {
2097 tmp->skill = hitter->skill; 2005 tmp->skill = hitter->skill;
2098 } 2006 }
2099 2007
… …
2105 tmp->stats.Con = MAX (-(dam / 4 + 1), -10); 2013 tmp->stats.Con = MAX (-(dam / 4 + 1), -10);
2106 tmp->stats.Str = MAX (-(dam / 3 + 2), -10); 2014 tmp->stats.Str = MAX (-(dam / 3 + 2), -10);
2107 tmp->stats.Dex = MAX (-(dam / 6 + 1), -10); 2015 tmp->stats.Dex = MAX (-(dam / 6 + 1), -10);
2108 tmp->stats.Int = MAX (-dam / 7, -10); 2016 tmp->stats.Int = MAX (-dam / 7, -10);
2109 SET_FLAG (tmp, FLAG_APPLIED); 2017 SET_FLAG (tmp, FLAG_APPLIED);
2110 fix_player (op); 2018 op->update_stats ();
2111 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very ill."); 2019 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very ill.");
2020 op->play_sound (tmp->sound);
2112 } 2021 }
2022
2113 if (hitter->type == PLAYER) 2023 if (hitter->type == PLAYER)
2114 new_draw_info_format (NDI_UNIQUE, 0, hitter, "You poison %s.", &op->name); 2024 new_draw_info_format (NDI_UNIQUE, 0, hitter, "You poison %s.", &op->name);
2115 else if (get_owner (hitter) != NULL && hitter->owner->type == PLAYER) 2025 else if (hitter->owner != NULL && hitter->owner->type == PLAYER)
2116 new_draw_info_format (NDI_UNIQUE, 0, hitter->owner, "Your %s poisons %s.", &hitter->name, &op->name); 2026 new_draw_info_format (NDI_UNIQUE, 0, hitter->owner, "Your %s poisons %s.", &hitter->name, &op->name);
2117 } 2027 }
2028
2118 tmp->speed_left = 0; 2029 tmp->speed_left = 0;
2119 } 2030 }
2120 else 2031 else
2121 tmp->stats.food++; 2032 tmp->stats.food++;
2122} 2033}
2123 2034
2124void 2035void
2125slow_player (object *op, object *hitter, int dam) 2036slow_player (object *op, object *hitter, int dam)
2126{ 2037{
2127 archetype *at = find_archetype ("slowness"); 2038 archetype *at = archetype::find ("slowness");
2128 object *tmp; 2039 object *tmp;
2129 2040
2130 if (at == NULL) 2041 if (at == NULL)
2131 {
2132 LOG (llevError, "Can't find slowness archetype.\n"); 2042 LOG (llevError, "Can't find slowness archetype.\n");
2133 } 2043
2134 if ((tmp = present_arch_in_ob (at, op)) == NULL) 2044 if ((tmp = present_arch_in_ob (at, op)) == NULL)
2135 { 2045 {
2136 tmp = arch_to_object (at); 2046 tmp = arch_to_object (at);
2137 tmp = insert_ob_in_ob (tmp, op); 2047 tmp = insert_ob_in_ob (tmp, op);
2138 new_draw_info (NDI_UNIQUE, 0, op, "The world suddenly moves very fast!"); 2048 new_draw_info (NDI_UNIQUE, 0, op, "The world suddenly moves very fast!");
2139 } 2049 }
2140 else 2050 else
2141 tmp->stats.food++; 2051 tmp->stats.food++;
2052
2142 SET_FLAG (tmp, FLAG_APPLIED); 2053 SET_FLAG (tmp, FLAG_APPLIED);
2143 tmp->speed_left = 0; 2054 tmp->speed_left = 0;
2144 fix_player (op); 2055 op->update_stats ();
2145} 2056}
2146 2057
2147void 2058void
2148confuse_player (object *op, object *hitter, int dam) 2059confuse_player (object *op, object *hitter, int dam)
2149{ 2060{
… …
2163 tmp->speed = 0.05; 2074 tmp->speed = 0.05;
2164 tmp->subtype = FORCE_CONFUSION; 2075 tmp->subtype = FORCE_CONFUSION;
2165 tmp->duration = 8 + MAX (1, 5 * (100 - op->resist[ATNR_CONFUSION]) / 100); 2076 tmp->duration = 8 + MAX (1, 5 * (100 - op->resist[ATNR_CONFUSION]) / 100);
2166 tmp->name = "confusion"; 2077 tmp->name = "confusion";
2167 maxduration = MAX (2, 30 * (100 - op->resist[ATNR_CONFUSION]) / 100); 2078 maxduration = MAX (2, 30 * (100 - op->resist[ATNR_CONFUSION]) / 100);
2079
2168 if (tmp->duration > maxduration) 2080 if (tmp->duration > maxduration)
2169 tmp->duration = maxduration; 2081 tmp->duration = maxduration;
2170 2082
2171 if (op->type == PLAYER && !QUERY_FLAG (op, FLAG_CONFUSED)) 2083 if (op->type == PLAYER && !QUERY_FLAG (op, FLAG_CONFUSED))
2172 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very confused!"); 2084 new_draw_info (NDI_UNIQUE, 0, op, "You suddenly feel very confused!");
2085
2173 SET_FLAG (op, FLAG_CONFUSED); 2086 SET_FLAG (op, FLAG_CONFUSED);
2174} 2087}
2175 2088
2176void 2089void
2177blind_player (object *op, object *hitter, int dam) 2090blind_player (object *op, object *hitter, int dam)
… …
2193 */ 2106 */
2194 tmp->speed = tmp->speed * (100.0 - (float) op->resist[ATNR_BLIND]) / 100; 2107 tmp->speed = tmp->speed * (100.0 - (float) op->resist[ATNR_BLIND]) / 100;
2195 2108
2196 tmp = insert_ob_in_ob (tmp, op); 2109 tmp = insert_ob_in_ob (tmp, op);
2197 change_abil (op, tmp); /* Mostly to display any messages */ 2110 change_abil (op, tmp); /* Mostly to display any messages */
2198 fix_player (op); /* This takes care of some other stuff */ 2111 op->update_stats (); /* This takes care of some other stuff */
2199 2112
2200 if (hitter->owner) 2113 if (hitter->owner)
2201 owner = get_owner (hitter); 2114 owner = hitter->owner;
2202 else 2115 else
2203 owner = hitter; 2116 owner = hitter;
2204 2117
2205 new_draw_info_format (NDI_UNIQUE, 0, owner, "Your attack blinds %s!", query_name (op)); 2118 new_draw_info_format (NDI_UNIQUE, 0, owner, "Your attack blinds %s!", query_name (op));
2206 } 2119 }
… …
2243 op->speed_left = (float) -(FABS (op->speed) * max); 2156 op->speed_left = (float) -(FABS (op->speed) * max);
2244 2157
2245/* tmp->stats.food = (signed short) (max/FABS(op->speed)); */ 2158/* tmp->stats.food = (signed short) (max/FABS(op->speed)); */
2246} 2159}
2247 2160
2248
2249/* Attempts to kill 'op'. hitter is the attack object, dam is 2161/* Attempts to kill 'op'. hitter is the attack object, dam is
2250 * the computed damaged. 2162 * the computed damaged.
2251 */ 2163 */
2252void 2164void
2253deathstrike_player (object *op, object *hitter, int *dam) 2165deathstrike_player (object *op, object *hitter, int *dam)
… …
2261 ** field of the deathstriking object */ 2173 ** field of the deathstriking object */
2262 2174
2263 int atk_lev, def_lev, kill_lev; 2175 int atk_lev, def_lev, kill_lev;
2264 2176
2265 if (hitter->slaying) 2177 if (hitter->slaying)
2266 if (!((QUERY_FLAG (op, FLAG_UNDEAD) && strstr (hitter->slaying, undead_name)) || (op->race && strstr (hitter->slaying, op->race)))) 2178 if (!((QUERY_FLAG (op, FLAG_UNDEAD) && hitter->slaying.contains (shstr_undead))
2179 || (op->race && hitter->slaying.contains (op->race))))
2267 return; 2180 return;
2268 2181
2269 def_lev = op->level; 2182 def_lev = op->level;
2270 if (def_lev < 1) 2183 if (def_lev < 1)
2271 { 2184 {
2272 LOG (llevError, "BUG: arch %s, name %s with level < 1\n", &op->arch->name, &op->name); 2185 LOG (llevError, "BUG: arch %s with level < 1 (%s)\n", &op->arch->archname, op->debug_desc ());
2273 def_lev = 1; 2186 def_lev = 1;
2274 } 2187 }
2188
2275 atk_lev = (hitter->chosen_skill ? hitter->chosen_skill->level : hitter->level) / 2; 2189 atk_lev = (hitter->chosen_skill ? hitter->chosen_skill->level : hitter->level) / 2;
2276 /* LOG(llevDebug,"Deathstrike - attack level %d, defender level %d\n", 2190 /* LOG(llevDebug,"Deathstrike - attack level %d, defender level %d\n",
2277 atk_lev, def_lev); */ 2191 atk_lev, def_lev); */
2278 2192
2279 if (atk_lev >= def_lev) 2193 if (atk_lev >= def_lev)
… …
2294 */ 2208 */
2295 *dam *= kill_lev / def_lev; 2209 *dam *= kill_lev / def_lev;
2296 } 2210 }
2297 } 2211 }
2298 else 2212 else
2299 {
2300 *dam = 0; /* no harm done */ 2213 *dam = 0; /* no harm done */
2301 }
2302} 2214}
2303 2215
2304/* thrown_item_effect() - handles any special effects of thrown 2216/* thrown_item_effect() - handles any special effects of thrown
2305 * items (like attacking living creatures--a potion thrown at a 2217 * items (like attacking living creatures--a potion thrown at a
2306 * monster). 2218 * monster).
… …
2335 } 2247 }
2336 } 2248 }
2337} 2249}
2338 2250
2339/* adj_attackroll() - adjustments to attacks by various conditions */ 2251/* adj_attackroll() - adjustments to attacks by various conditions */
2340
2341int 2252int
2342adj_attackroll (object *hitter, object *target) 2253adj_attackroll (object *hitter, object *target)
2343{ 2254{
2344 object *attacker = hitter; 2255 object *attacker = hitter;
2345 int adjust = 0; 2256 int adjust = 0;
… …
2352 } 2263 }
2353 2264
2354 /* aimed missiles use the owning object's sight */ 2265 /* aimed missiles use the owning object's sight */
2355 if (is_aimed_missile (hitter)) 2266 if (is_aimed_missile (hitter))
2356 { 2267 {
2357 if ((attacker = get_owner (hitter)) == NULL) 2268 if ((attacker = hitter->owner) == NULL)
2358 attacker = hitter; 2269 attacker = hitter;
2359 /* A player who saves but hasn't quit still could have objects 2270 /* A player who saves but hasn't quit still could have objects
2360 * owned by him - need to handle that case to avoid crashes. 2271 * owned by him - need to handle that case to avoid crashes.
2361 */ 2272 */
2362 if (QUERY_FLAG (attacker, FLAG_REMOVED)) 2273 if (QUERY_FLAG (attacker, FLAG_REMOVED))
… …
2372 { 2283 {
2373 /* target is unseen */ 2284 /* target is unseen */
2374 if (target->invisible || QUERY_FLAG (attacker, FLAG_BLIND)) 2285 if (target->invisible || QUERY_FLAG (attacker, FLAG_BLIND))
2375 adjust -= 10; 2286 adjust -= 10;
2376 /* dark map penalty for the hitter (lacks infravision if we got here). */ 2287 /* dark map penalty for the hitter (lacks infravision if we got here). */
2377 else if (target->map && target->map->darkness > 0 && !stand_in_light (target)) 2288 else if (!stand_in_light (target))
2378 adjust -= target->map->darkness; 2289 adjust -= target->map->darklevel ();
2379 } 2290 }
2380 2291
2381 if (QUERY_FLAG (attacker, FLAG_SCARED)) 2292 if (QUERY_FLAG (attacker, FLAG_SCARED))
2382 adjust -= 3; 2293 adjust -= 3;
2383 2294
… …
2410#endif 2321#endif
2411 2322
2412 return adjust; 2323 return adjust;
2413} 2324}
2414 2325
2415
2416/* determine if the object is an 'aimed' missile */ 2326/* determine if the object is an 'aimed' missile */
2417int 2327int
2418is_aimed_missile (object *op) 2328is_aimed_missile (object *op)
2419{ 2329{
2420 2330
2421 /* I broke what used to be one big if into a few nested 2331 /* I broke what used to be one big if into a few nested
2422 * ones so that figuring out the logic is at least possible. 2332 * ones so that figuring out the logic is at least possible.
2423 */ 2333 */
2424 if (op && (op->move_type & MOVE_FLYING)) 2334 if (op && (op->move_type & MOVE_FLYING))
2425 {
2426 if (op->type == ARROW || op->type == THROWN_OBJ) 2335 if (op->type == ARROW || op->type == THROWN_OBJ)
2427 return 1; 2336 return 1;
2428 else if (op->type == SPELL_EFFECT && (op->subtype == SP_BULLET || op->subtype == SP_EXPLOSION)) 2337 else if (op->type == SPELL_EFFECT && (op->subtype == SP_BULLET || op->subtype == SP_EXPLOSION))
2429 return 1; 2338 return 1;
2430 } 2339
2431 return 0; 2340 return 0;
2432} 2341}

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines