ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.59 by root, Sat Dec 23 07:36:35 2006 UTC vs.
Revision 1.206 by root, Mon Sep 29 10:20:49 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23 23
24#include <global.h> 24#include <global.h>
25#include <pwd.h>
26#include <sproto.h> 25#include <sproto.h>
27#include <sounds.h> 26#include <sounds.h>
28#include <living.h> 27#include <living.h>
29#include <object.h> 28#include <object.h>
30#include <spells.h> 29#include <spells.h>
31#include <skills.h> 30#include <skills.h>
32 31
33#include <algorithm> 32#include <algorithm>
34#include <functional> 33#include <functional>
35 34
36player * 35playervec players;
37find_player (const char *plname)
38{
39 player *pl;
40
41 for (pl = first_player; pl; pl = pl->next)
42 if (pl->ob && !strcmp (query_name (pl->ob), plname))
43 return pl;
44
45 return 0;
46}
47 36
48void 37void
49display_motd (const object *op) 38display_motd (const object *op)
50{ 39{
51 char buf[MAX_BUF]; 40 char buf[MAX_BUF];
… …
125 114
126 news[0] = '\0'; 115 news[0] = '\0';
127 subject[0] = '\0'; 116 subject[0] = '\0';
128 size = 0; 117 size = 0;
129 118
130 while (fgets (buf, MAX_BUF, fp) != NULL) 119 while (fgets (buf, MAX_BUF, fp))
131 { 120 {
132 if (*buf == '#') 121 if (*buf == '#')
133 continue; 122 continue;
134 123
135 if (*buf == '%') 124 if (*buf == '%')
136 { /* send one news */ 125 { /* send one news */
137 if (size > 0) 126 if (size > 0)
138 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s", "%s\n%s", subject, news); /*send previously read news */ 127 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
128 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS,
129 "INFORMATION: %s\n%s", (char *)"%s\n%s",
130 subject, news); /*send previously read news */
131
139 strcpy (subject, buf + 1); 132 strcpy (subject, buf + 1);
140 strip_endline (subject); 133 strip_endline (subject);
141 size = 0; 134 size = 0;
142 news[0] = '\0'; 135 news[0] = '\0';
143 } 136 }
… …
152 size += strlen (buf); 145 size += strlen (buf);
153 } 146 }
154 } 147 }
155 148
156 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, 149 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
157 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", "%s\n%s", subject, news); 150 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", (char *)"%s\n%s", subject, news);
158 close_and_delete (fp, comp); 151 close_and_delete (fp, comp);
159} 152}
160 153
161/* This loads the first map an puts the player on it. */ 154/* This loads the first map an puts the player on it. */
162static void 155static void
163set_first_map (object *op) 156set_first_map (object *op)
164{ 157{
165 strcpy (op->contr->maplevel, first_map_path); 158 op->contr->maplevel = first_map_path;
166 op->x = -1; 159 op->x = -1;
167 op->y = -1; 160 op->y = -1;
168 enter_exit (op, 0); 161}
162
163void
164player::activate ()
165{
166 if (active)
167 return;
168
169 players.insert (this);
170 ob->remove ();
171 ob->map = 0;
172 ob->activate_recursive ();
173 CLEAR_FLAG (ob, FLAG_FRIENDLY);
174 add_friendly_object (ob);
175}
176
177void
178player::deactivate ()
179{
180 if (!active)
181 return;
182
183 terminate_all_pets (ob);
184 remove_friendly_object (ob);
185 ob->deactivate_recursive ();
186
187 if (ob->map)
188 maplevel = ob->map->path;
189
190 ob->remove ();
191 ob->enemy = 0; // sometimes keeps an extra refcount on itself
192 ob->map = 0;
193 party = 0;
194
195 combat_ob = ranged_ob = 0; //TODO, should be special marker, non-refcounted, not this
196
197 players.erase (this);
169} 198}
170 199
171// connect the player with a specific client 200// connect the player with a specific client
172// also changed, rationalises, and fixes some incorrect settings 201// also changes, rationalises, and fixes some incorrect settings
173void 202void
174player::connect (client *ns) 203player::connect (client *ns)
175{ 204{
176 this->ns = ns; 205 this->ns = ns;
177 ns->pl = this; 206 ns->pl = this;
178 207
179 next = first_player; 208 run_on = 0;
180 first_player = this; 209 fire_on = 0;
210 ob->close_container (); //TODO: client-specific
181 211
182 ns->update_look = 0; 212 ns->update_look = 0;
183 ns->look_position = 0; 213 ns->look_position = 0;
184 214
185 clear_los (ob); 215 clear_los (this);
216
217 ns->reset_stats ();
186 218
187 /* make sure he's a player -- needed because of class change. */ 219 /* make sure he's a player -- needed because of class change. */
188 ob->type = PLAYER; // we are paranoid 220 ob->type = PLAYER; // we are paranoid
189 ob->race = ob->arch->clone.race; 221 ob->race = ob->arch->race;
190 222
191 if (!legal_range (ob, shoottype)) 223 ob->update_weight ();
192 shoottype = range_none;
193
194 ob->carrying = sum_weight (ob);
195 link_player_skills (ob); 224 link_skills ();
196 225
197 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER); 226 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
198 ob->update_stats ();
199 update_ob_speed (ob);
200 227
201 assign (title, ob->arch->clone.name); 228 assign (title, ob->arch->object::name);
202
203 /* can_use_shield is a new flag. However, the can_use.. seems to largely come
204 * from the class, and not race. I don't see any way to get the class information
205 * to then update this. I don't think this will actually break anything - anyone
206 * that can use armour should be able to use a shield. What this may 'break'
207 * are features new characters get, eg, if someone starts up with a Q, they
208 * should be able to use a shield. However, old Q's won't get that advantage.
209 */
210 if (QUERY_FLAG (ob, FLAG_USE_ARMOUR))
211 SET_FLAG (ob, FLAG_USE_SHIELD);
212 229
213 /* if it's a dragon player, set the correct title here */ 230 /* if it's a dragon player, set the correct title here */
214 if (is_dragon_pl (ob)) 231 if (is_dragon_pl (ob))
215 { 232 {
216 object *tmp, *abil = 0, *skin = 0; 233 object *tmp, *abil = 0, *skin = 0;
217 234
218 shstr_cmp dragon_ability_force ("dragon_ability_force");
219 shstr_cmp dragon_skin_force ("dragon_skin_force");
220
221 for (tmp = ob->inv; tmp; tmp = tmp->below) 235 for (tmp = ob->inv; tmp; tmp = tmp->below)
222 if (tmp->type == FORCE) 236 if (tmp->type == FORCE)
223 if (tmp->arch->name == dragon_ability_force) 237 if (tmp->arch->archname == shstr_dragon_ability_force)
224 abil = tmp; 238 abil = tmp;
225 else if (tmp->arch->name == dragon_skin_force) 239 else if (tmp->arch->archname == shstr_dragon_skin_force)
226 skin = tmp; 240 skin = tmp;
227 241
228 set_dragon_name (ob, abil, skin); 242 set_dragon_name (ob, abil, skin);
229 } 243 }
230 244
231 CLEAR_FLAG (ob, FLAG_FRIENDLY);
232 add_friendly_object (ob);
233
234 LOG (llevInfo, "LOGIN: Player named %s from ip %s\n", &ob->name, ns->host);
235
236 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 245 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
237 new_draw_info_format (NDI_UNIQUE | NDI_ALL | NDI_DK_ORANGE, 5, NULL, "%s has entered the game.", &ob->name); 246
247 esrv_new_player (this);
248
249 ob->update_stats ();
238 250
239 ns->floorbox_update (); 251 ns->floorbox_update ();
240
241 esrv_new_player (this, ob->weight + ob->carrying);
242 esrv_send_inventory (ob, ob); 252 esrv_send_inventory (ob, ob);
243 esrv_add_spells (this, 0); 253 esrv_add_spells (this, 0);
244 254
245 enter_exit (ob, 0); 255 activate ();
246 256
247 send_rules (ob); 257 send_rules (ob);
248 send_news (ob); 258 send_news (ob);
249 display_motd (ob); 259 display_motd (ob);
260
261 INVOKE_PLAYER (CONNECT, this);
250 INVOKE_PLAYER (LOGIN, this); 262 INVOKE_PLAYER (LOGIN, this);
263}
264
265void
266player::disconnect ()
267{
268 if (ob)
269 {
270 ob->close_container (); //TODO: client-specific
271 ob->drop_unpaid_items ();
272 }
273
274 if (ns)
275 {
276 if (active)
277 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0));
278
279 INVOKE_PLAYER (DISCONNECT, this);
280
281 ns->reset_stats ();
282 ns->pl = 0;
283 ns = 0;
284 }
285
286 observe = ob;
287
288 deactivate ();
251} 289}
252 290
253// the need for this function can be explained 291// the need for this function can be explained
254// by load_object not returning the object 292// by load_object not returning the object
255void 293void
256player::set_object (object *op) 294player::set_object (object *op)
257{ 295{
258 ob = op; 296 ob = observe = op;
259 ob->contr = this; /* this aren't yet in archetype */ 297 ob->contr = this; /* this aren't yet in archetype */
260 298
299 ob->speed = 1.0f;
261 ob->speed_left = 0.5; 300 ob->speed_left = 0.5f;
262 ob->speed = 1.0; 301
263 ob->direction = 5; /* So player faces south */ 302 ob->direction = 5; /* So player faces south */
264 ob->stats.wc = 2;
265 ob->run_away = 25; /* Then we panick... */
266 303
267 set_first_map (ob); 304 ob->flag [FLAG_READY_WEAPON] = false;
305 ob->flag [FLAG_READY_SKILL] = false;
306 ob->flag [FLAG_READY_BOW] = false;
268 307
269 ob->roll_stats (); 308 for (object *op = ob->inv; op; op = op->below)
309 if (op->flag [FLAG_APPLIED])
310 switch (op->type)
311 {
312 case SKILL:
313 ob->flag [FLAG_APPLIED] = false;
314 break;
315
316 case WAND:
317 case ROD:
318 case HORN:
319 case BOW:
320 ranged_ob = op;
321 break;
322
323 case WEAPON:
324 combat_ob = op;
325 break;
326 }
327
328 ob->change_weapon (combat_ob ? combat_ob : ranged_ob);
329 ob->deactivate (); // change_weapon activates, fix this better
330}
331
332void
333player::set_observe (object *op)
334{
335 observe = op ? op : ob;
336 do_los = 1;
270} 337}
271 338
272player::player () 339player::player ()
273{ 340{
274 /* There are some elements we want initialized to non zero value - 341 /* There are some elements we want initialised to non zero value -
275 * we deal with that below this point. 342 * we deal with that below this point.
276 */ 343 */
277 outputs_sync = 16; /* Every 2 seconds */ 344 outputs_sync = 4;
278 outputs_count = 8; /* Keeps present behaviour */ 345 outputs_count = 4;
279 unapply = unapply_nochoice; 346 unapply = unapply_nochoice;
280 347
281 assign (savebed_map, first_map_path); /* Init. respawn position */ 348 savebed_map = first_map_path; /* Init. respawn position */
282 349
283 gen_sp_armour = 10; 350 gen_sp_armour = 10;
284 last_speed = -1;
285 shoottype = range_none;
286 bowtype = bow_normal; 351 bowtype = bow_normal;
287 petmode = pet_normal; 352 petmode = pet_normal;
288 listening = 10;
289 usekeys = containers; 353 usekeys = containers;
290 last_weapon_sp = -1;
291 peaceful = 1; /* default peaceful */ 354 peaceful = 1; /* default peaceful */
292 do_los = 1; 355 do_los = 1;
293 356
294 /* we need to clear these to -1 and not zero - otherwise, 357 weapon_sp = 1.0f;
295 * if a player quits and starts a new character, we wont 358 weapon_sp_left = 0.5f;
296 * send new values to the client, as things like exp start 359}
297 * at zero.
298 */
299 for (int i = 0; i < NUM_SKILLS; i++)
300 last_skill_exp[i] = -1;
301 360
302 for (int i = 0; i < NROFATTACKS; i++) 361void
303 last_resist[i] = -1; 362player::do_destroy ()
363{
364 disconnect ();
304 365
305 last_stats.exp = -1; 366 attachable::do_destroy ();
306 last_weight = (uint32) - 1; 367
368 if (ob)
369 {
370 ob->destroy_inv (false);
371 ob->destroy (true);
372 }
373
374 ob = observe = 0;
307} 375}
308 376
309player::~player () 377player::~player ()
310{ 378{
311 terminate_all_pets (ob);
312
313 if (first_player != this)
314 {
315 player *prev = first_player;
316
317 while (prev && prev->next && prev->next != this)
318 prev = prev->next;
319
320 if (prev->next != this)
321 {
322 LOG (llevError, "Free_player: Can't find previous player.\n");
323 abort ();
324 }
325
326 prev->next = next;
327 }
328 else
329 first_player = next;
330
331 if (ob)
332 {
333 ob->contr = 0;
334 ob->destroy (1);
335 }
336
337 if (ns)
338 {
339 ns->send_packet ("goodbye");
340 ns->flush ();
341 ns->pl = 0;
342 ns->destroy ();
343 }
344
345 /* Clear item stack */ 379 /* Clear item stack */
346 free (stack_items); 380 free (stack_items);
347} 381}
348 382
349/* Tries to add player on the connection passed in ns. 383/* Tries to add player on the connection passed in ns.
… …
354player::create () 388player::create ()
355{ 389{
356 player *pl = new player; 390 player *pl = new player;
357 391
358 pl->set_object (arch_to_object (get_player_archetype (0))); 392 pl->set_object (arch_to_object (get_player_archetype (0)));
393
394 pl->ob->roll_stats ();
395 pl->ob->stats.wc = 2;
396 pl->ob->run_away = 25; /* Then we panick... */
397
398 set_first_map (pl->ob);
359 399
360 return pl; 400 return pl;
361} 401}
362 402
363/* 403/*
… …
366 * Note: there MUST be at least one player archetype! 406 * Note: there MUST be at least one player archetype!
367 */ 407 */
368archetype * 408archetype *
369get_player_archetype (archetype *at) 409get_player_archetype (archetype *at)
370{ 410{
371 archetype *start = at; 411 // archetypes could have been reloaded
412 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
413
414 if (!nat)
415 return at;
416
417 archvec::iterator i = archetypes.find (nat);
372 418
373 for (;;) 419 for (;;)
374 { 420 {
375 if (at == NULL || at->next == NULL) 421 if (++i == archetypes.end ())
376 at = first_archetype; 422 i = archetypes.begin ();
377 else 423 else if (*i == at)
378 at = at->next; 424 cleanup ("not a single player archetype found");
379 425
380 if (at->clone.type == PLAYER) 426 if ((*i)->type == PLAYER)
381 return at; 427 return *i;
382
383 if (at == start)
384 {
385 LOG (llevError, "No Player archetypes\n");
386 exit (-1);
387 }
388 } 428 }
389} 429}
390 430
391object * 431object *
392get_nearest_player (object *mon) 432get_nearest_player (object *mon)
393{ 433{
394 object *op = NULL; 434 object *op = NULL;
395 player *pl = NULL;
396 objectlink *ol; 435 objectlink *ol;
397 unsigned lastdist; 436 unsigned lastdist;
398 rv_vector rv; 437 rv_vector rv;
399 438
400 for (ol = first_friendly_object, lastdist = 1000; ol != NULL; ol = ol->next) 439 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next)
401 { 440 {
402 /* We should not find free objects on this friendly list, but it
403 * does periodically happen. Given that, lets deal with it.
404 * While unlikely, it is possible the next object on the friendly
405 * list is also free, so encapsulate this in a while loop.
406 */
407 while (QUERY_FLAG (ol->ob, FLAG_FREED) || !QUERY_FLAG (ol->ob, FLAG_FRIENDLY))
408 {
409 object *tmp = ol->ob;
410
411 /* Can't do much more other than log the fact, because the object
412 * itself will have been cleared.
413 */
414 LOG (llevDebug, "get_nearest_player: Found free/non friendly object on friendly list\n");
415 ol = ol->next;
416 remove_friendly_object (tmp);
417 if (!ol)
418 return op;
419 }
420
421 /* Remove special check for player from this. First, it looks to cause
422 * some crashes (ol->ob->contr not set properly?), but secondly, a more
423 * complicated method of state checking would be needed in any case -
424 * as it was, a clever player could type quit, and the function would
425 * skip them over while waiting for confirmation. Remove
426 * on_same_map check, as can_detect_enemy also does this
427 */
428 if (!can_detect_enemy (mon, ol->ob, &rv)) 441 if (!can_detect_enemy (mon, ol->ob, &rv))
429 continue; 442 continue;
430 443
431 if (lastdist > rv.distance) 444 if (lastdist > rv.distance)
432 { 445 {
433 op = ol->ob; 446 op = ol->ob;
434 lastdist = rv.distance; 447 lastdist = rv.distance;
435 } 448 }
436 } 449 }
437 for (pl = first_player; pl != NULL; pl = pl->next) 450
438 { 451 for_all_players (pl)
439 if (can_detect_enemy (mon, pl->ob, &rv)) 452 if (can_detect_enemy (mon, pl->ob, &rv))
440 {
441
442 if (lastdist > rv.distance) 453 if (lastdist > rv.distance)
443 { 454 {
444 op = pl->ob; 455 op = pl->ob;
445 lastdist = rv.distance; 456 lastdist = rv.distance;
446 } 457 }
447 } 458
448 }
449#if 0 459#if 0
450 LOG (llevDebug, "get_nearest_player() finds player: %s\n", op ? &op->name : "(null)"); 460 LOG (llevDebug, "get_nearest_player() finds player: %s\n", op ? &op->name : "(null)");
451#endif 461#endif
452 return op; 462 return op;
453} 463}
… …
511 x = mon->x; 521 x = mon->x;
512 y = mon->y; 522 y = mon->y;
513 m = mon->map; 523 m = mon->map;
514 dir = rv.direction; 524 dir = rv.direction;
515 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 525 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
516 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 526 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
527
517 /* If we can't solve it within the search distance, return now. */ 528 /* If we can't solve it within the search distance, return now. */
518 if (diff > max) 529 if (diff > max)
519 return 0; 530 return 0;
531
520 while (diff > 1 && max > 0) 532 while (diff > 1 && max > 0)
521 { 533 {
522 lastx = x; 534 lastx = x;
523 lasty = y; 535 lasty = y;
524 lastmap = m; 536 lastmap = m;
… …
606 max--; 618 max--;
607 lastdir = dir; 619 lastdir = dir;
608 if (!firstdir) 620 if (!firstdir)
609 firstdir = dir; 621 firstdir = dir;
610 } 622 }
623
611 if (diff <= 1) 624 if (diff <= 1)
612 { 625 {
613 /* Recalculate diff (distance) because we may not have actually 626 /* Recalculate diff (distance) because we may not have actually
614 * headed toward player for entire distance. 627 * headed toward player for entire distance.
615 */ 628 */
616 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 629 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0);
617 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 630 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
618 } 631 }
632
619 if (diff > max) 633 if (diff > max)
620 return 0; 634 return 0;
621 } 635 }
636
622 /* If we reached the max, didn't find a direction in time */ 637 /* If we reached the max, didn't find a direction in time */
623 if (!max) 638 if (!max)
624 return 0; 639 return 0;
625 640
626 return firstdir; 641 return firstdir;
627} 642}
628 643
629void 644void
630give_initial_items (object *pl, treasurelist * items) 645give_initial_items (object *pl, treasurelist *items)
631{ 646{
632 object *op, *next = NULL;
633
634 if (pl->randomitems != NULL) 647 if (pl->randomitems)
635 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0); 648 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0);
636 649
637 for (op = pl->inv; op; op = next) 650 for (object *next, *op = pl->inv; op; op = next)
638 { 651 {
639 next = op->below; 652 next = op->below;
640 653
641 /* Forces get applied per default, unless they have the 654 /* Forces get applied per default, unless they have the
642 * flag "neutral" set. Sorry but I can't think of a better way 655 * flag "neutral" set. Sorry but I can't think of a better way
… …
647 /* we never give weapons/armour if these cannot be used 660 /* we never give weapons/armour if these cannot be used
648 * by this player due to race restrictions 661 * by this player due to race restrictions
649 */ 662 */
650 if (pl->type == PLAYER) 663 if (pl->type == PLAYER)
651 { 664 {
652 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) && 665 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR)
666 &&
653 (op->type == ARMOUR || op->type == BOOTS || 667 (op->type == ARMOUR || op->type == BOOTS
654 op->type == CLOAK || op->type == HELMET || 668 || op->type == CLOAK || op->type == HELMET
655 op->type == SHIELD || op->type == GLOVES || 669 || op->type == SHIELD || op->type == GLOVES
670 || op->type == BRACERS || op->type == GIRDLE))
656 op->type == BRACERS || op->type == GIRDLE)) || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 671 || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON))
657 { 672 {
658 op->destroy (); 673 op->destroy (true);
659 continue; 674 continue;
660 } 675 }
661 } 676 }
662 677
663 /* This really needs to be better - we should really give 678 /* This really needs to be better - we should really give
… …
674 if (tmp->type == op->type && tmp->name == op->name) 689 if (tmp->type == op->type && tmp->name == op->name)
675 break; 690 break;
676 691
677 if (tmp) 692 if (tmp)
678 { 693 {
679 op->destroy (); 694 op->destroy (true);
680 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 695 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name);
681 continue; 696 continue;
682 } 697 }
683 698
684 if (op->nrof > 1) 699 if (op->nrof > 1)
685 op->nrof = 1; 700 op->nrof = 1;
686 } 701 }
687 702
688 if (op->type == SPELLBOOK && op->inv) 703 if (op->type == SPELLBOOK && op->inv)
689 {
690 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP); 704 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP);
691 }
692 705
693 /* Give starting characters identified, uncursed, and undamned 706 /* Give starting characters identified, uncursed, and undamned
694 * items. Just don't identify gold or silver, or it won't be 707 * items. Just don't identify gold or silver, or it won't be
695 * merged properly. 708 * merged properly.
696 */ 709 */
697 if (need_identify (op)) 710 if (need_identify (op))
698 { 711 {
699 SET_FLAG (op, FLAG_IDENTIFIED); 712 SET_FLAG (op, FLAG_IDENTIFIED);
700 CLEAR_FLAG (op, FLAG_CURSED); 713 CLEAR_FLAG (op, FLAG_CURSED);
701 CLEAR_FLAG (op, FLAG_DAMNED); 714 CLEAR_FLAG (op, FLAG_DAMNED);
702 } 715 }
716
703 if (op->type == SPELL) 717 if (op->type == SPELL)
704 { 718 {
705 op->destroy (); 719 op->destroy (true);
706 continue; 720 continue;
707 } 721 }
708 else if (op->type == SKILL) 722 else if (op->type == SKILL)
709 { 723 {
710 SET_FLAG (op, FLAG_CAN_USE_SKILL); 724 SET_FLAG (op, FLAG_CAN_USE_SKILL);
711 op->stats.exp = 0; 725 op->stats.exp = 0;
712 op->level = 1; 726 op->level = 1;
713 } 727 }
714 /* lock all 'normal items by default */ 728 else /* lock all 'normal items by default */
715 else
716 SET_FLAG (op, FLAG_INV_LOCKED); 729 SET_FLAG (op, FLAG_INV_LOCKED);
717 } /* for loop of objects in player inv */ 730 } /* for loop of objects in player inv */
718 731
719 /* Need to set up the skill pointers */ 732 /* Need to set up the skill pointers */
720 link_player_skills (pl); 733 pl->contr->link_skills ();
721} 734}
722 735
723void 736void
724get_party_password (object *op, partylist *party) 737get_party_password (object *op, partylist *party)
725{ 738{
… …
740roll_stat (void) 753roll_stat (void)
741{ 754{
742 int a[4], i, j, k; 755 int a[4], i, j, k;
743 756
744 for (i = 0; i < 4; i++) 757 for (i = 0; i < 4; i++)
745 a[i] = (int) RANDOM () % 6 + 1; 758 a[i] = (int) rndm (6) + 1;
746 759
747 for (i = 0, j = 0, k = 7; i < 4; i++) 760 for (i = 0, j = 0, k = 7; i < 4; i++)
748 if (a[i] < k) 761 if (a[i] < k)
749 k = a[i], j = i; 762 k = a[i], j = i;
750 763
… …
756} 769}
757 770
758void 771void
759object::roll_stats () 772object::roll_stats ()
760{ 773{
761 int statsort [7]; 774 int statsort [NUM_STATS];
762 775
763 for (;;) 776 for (;;)
764 { 777 {
765 int sum = 0; 778 int sum = 0;
766 for (int i = 7; i--; ) 779 for (int i = NUM_STATS; i--; )
767 sum += statsort [i] = roll_stat (); 780 sum += statsort [i] = roll_stat ();
768 781
769 if (sum >= 82 && sum <= 116) 782 if (sum >= 82 && sum <= 116)
770 break; 783 break;
771 } 784 }
772 785
773 // Sort the stats so that rerolling is easier... 786 // Sort the stats so that rerolling is easier...
774 std::sort (statsort, statsort + 7, std::greater<int>()); 787 std::sort (statsort, statsort + NUM_STATS, std::greater<int>());
775 788
789 for (int i = 0; i < NUM_STATS; ++i)
776 stats.Str = statsort[0]; 790 stats.stat (i) = statsort [i];
777 stats.Dex = statsort[1];
778 stats.Con = statsort[2];
779 stats.Int = statsort[3];
780 stats.Wis = statsort[4];
781 stats.Pow = statsort[5];
782 stats.Cha = statsort[6];
783 791
784 stats.exp = 0; 792 stats.exp = 0;
785 stats.ac = 0; 793 stats.ac = 0;
786 794
787 stats.hp = stats.maxhp; 795 stats.hp = stats.maxhp;
… …
799} 807}
800 808
801void 809void
802object::swap_stats (int a, int b) 810object::swap_stats (int a, int b)
803{ 811{
804 int tmp = get_attr_value (&contr->orig_stats, a); 812 swap (contr->orig_stats.stat (a), contr->orig_stats.stat (b));
805 set_attr_value (&contr->orig_stats, a, get_attr_value (&contr->orig_stats, b));
806 set_attr_value (&contr->orig_stats, b, tmp);
807 813
814 for (int i = 0; i < NUM_STATS; ++i)
808 stats.Str = contr->orig_stats.Str; 815 stats.stat (i) = contr->orig_stats.stat (i);
809 stats.Dex = contr->orig_stats.Dex;
810 stats.Con = contr->orig_stats.Con;
811 stats.Int = contr->orig_stats.Int;
812 stats.Wis = contr->orig_stats.Wis;
813 stats.Pow = contr->orig_stats.Pow;
814 stats.Cha = contr->orig_stats.Cha;
815 816
816 //TODO: the following code looks so borked and should, at the very least, 817 //TODO: the following code looks so borked and should, at the very least,
817 // be merged with the similar code in roll_stats 818 // be merged with the similar code in roll_stats
818 stats.ac = 0; 819 stats.ac = 0;
819 820
… …
831 contr->levsp[1] = 6; 832 contr->levsp[1] = 6;
832 contr->levgrace[1] = 3; 833 contr->levgrace[1] = 3;
833 834
834 contr->orig_stats = stats; 835 contr->orig_stats = stats;
835 } 836 }
837}
838
839static void
840start_info (object *op)
841{
842 char buf[MAX_BUF];
843
844 sprintf (buf, "Welcome to Deliantra v%s!", VERSION);
845 new_draw_info (NDI_UNIQUE, 0, op, buf);
836} 846}
837 847
838/* This function takes the key that is passed, and does the 848/* This function takes the key that is passed, and does the
839 * appropriate action with it (change race, or other things). 849 * appropriate action with it (change race, or other things).
840 * The function name is for historical reasons - now we have 850 * The function name is for historical reasons - now we have
841 * separate race and class; this actually changes the RACE, 851 * separate race and class; this actually changes the RACE,
842 * not the class. 852 * not the class.
843 */ 853 */
844int 854void
845key_change_class (object *op, char key) 855player::chargen_race_done ()
846{ 856{
847 int tmp_loop;
848
849 if (key == 'd' || key == 'D')
850 {
851 char buf[MAX_BUF];
852
853 /* this must before then initial items are given */ 857 /* this must before then initial items are given */
854 esrv_new_player (op->contr, op->weight + op->carrying); 858 esrv_new_player (ob->contr);
855 859
856 treasurelist *tl = find_treasurelist ("starting_wealth"); 860 treasurelist *tl = treasurelist::find ("starting_wealth");
857 if (tl) 861 if (tl)
858 create_treasure (tl, op, 0, 0, 0); 862 create_treasure (tl, ob, 0, 0, 0);
859 863
860 INVOKE_PLAYER (BIRTH, op->contr); 864 INVOKE_PLAYER (BIRTH, ob->contr);
861 INVOKE_PLAYER (LOGIN, op->contr); 865 INVOKE_PLAYER (LOGIN, ob->contr);
862 866
863 op->contr->ns->state = ST_PLAYING; 867 ob->contr->ns->state = ST_PLAYING;
864 868
865 if (op->msg) 869 if (ob->msg)
866 op->msg = NULL; 870 ob->msg = 0;
867 871
868 /* We create this now because some of the unique maps will need it
869 * to save here.
870 */
871 sprintf (buf, "%s/%s/%s", settings.localdir, settings.playerdir, &op->name);
872 make_path_to_file (buf);
873
874#ifdef AUTOSAVE
875 op->contr->last_save_tick = pticks;
876#endif
877 start_info (op); 872 start_info (ob);
878 CLEAR_FLAG (op, FLAG_WIZ); 873 CLEAR_FLAG (ob, FLAG_WIZ);
879 give_initial_items (op, op->randomitems); 874 give_initial_items (ob, ob->randomitems);
880 link_player_skills (op);
881 esrv_send_inventory (op, op); 875 esrv_send_inventory (ob, ob);
882 op->update_stats (); 876 ob->update_stats ();
883 877
884 /* This moves the player to a different start map, if there 878 /* This moves the player to a different start map, if there
885 * is one for this race 879 * is one for this race
886 */ 880 */
887 if (*first_map_ext_path) 881 if (*first_map_ext_path)
888 { 882 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
889 object *tmp;
890 char mapname[MAX_BUF];
891
892 snprintf (mapname, MAX_BUF - 1, "%s/%s", first_map_ext_path, &op->arch->name);
893 tmp = object::create ();
894 EXIT_PATH (tmp) = mapname;
895 EXIT_X (tmp) = op->x;
896 EXIT_Y (tmp) = op->y;
897 enter_exit (op, tmp); /* we don't really care if it succeeded;
898 * if the map isn't there, then stay on the
899 * default initial map */
900 tmp->destroy ();
901 }
902 else 883 else
903 LOG (llevDebug, "first_map_ext_path not set\n"); 884 LOG (llevDebug, "first_map_ext_path not set\n");
885}
904 886
905 return 0; 887void
906 } 888player::chargen_race_next ()
907 889{
908 /* Following actually changes the race - this is the default command 890 /* Following actually changes the race - this is the default command
909 * if we don't match with one of the options above. 891 * if we don't match with one of the options above.
910 */ 892 */
911 893
912 tmp_loop = 0; 894 do
913 while (!tmp_loop)
914 { 895 {
915 shstr name = op->name; 896 shstr name = ob->name;
916 int x = op->x, y = op->y; 897 int x = ob->x, y = ob->y;
917 898
918 op->remove_statbonus (); 899 ob->remove_statbonus ();
919 op->remove (); 900 ob->remove ();
920 op->arch = get_player_archetype (op->arch); 901 ob->arch = get_player_archetype (ob->arch);
921 op->arch->clone.copy_to (op); 902 ob->arch->copy_to (ob);
922 op->instantiate (); 903 ob->instantiate ();
923 op->stats = op->contr->orig_stats; 904 ob->stats = ob->contr->orig_stats;
924 op->name = op->name_pl = name; 905 ob->name = ob->name_pl = name;
925 op->x = x; 906 ob->x = x;
926 op->y = y; 907 ob->y = y;
927 SET_ANIMATION (op, 2); /* So player faces south */ 908 SET_ANIMATION (ob, 2); /* So player faces south */
928 insert_ob_in_map (op, op->map, op, 0); 909 insert_ob_in_map (ob, ob->map, ob, 0);
929 assign (op->contr->title, op->arch->clone.name); 910 assign (ob->contr->title, ob->arch->object::name);
930 op->add_statbonus (); 911 ob->add_statbonus ();
931 tmp_loop = allowed_class (op);
932 } 912 }
913 while (!allowed_class (ob));
933 914
934 update_object (op, UP_OBJ_FACE); 915 update_object (ob, UP_OBJ_FACE);
935 esrv_update_item (UPD_FACE, op, op); 916 esrv_update_item (UPD_FACE, ob, ob);
936 op->update_stats (); 917 ob->update_stats ();
937 op->stats.hp = op->stats.maxhp; 918 ob->stats.hp = ob->stats.maxhp;
938 op->stats.sp = op->stats.maxsp; 919 ob->stats.sp = ob->stats.maxsp;
939 op->stats.grace = 0; 920 ob->stats.grace = 0;
940
941 if (op->msg)
942 new_draw_info (NDI_BLUE, 0, op, op->msg);
943
944 send_query (op->contr->ns, CS_QUERY_SINGLECHAR, "Press any key for the next race.\nPress `d' to play this race.\n");
945 return 0;
946}
947
948int
949key_confirm_quit (object *op, char key)
950{
951 if (key != 'y' && key != 'Y' && key != 'q' && key != 'Q')
952 {
953 op->contr->ns->state = ST_PLAYING;
954 new_draw_info (NDI_UNIQUE, 0, op, "OK, continuing to play.");
955 return 1;
956 }
957
958 INVOKE_PLAYER (LOGOUT, op->contr);
959 INVOKE_PLAYER (QUIT, op->contr);
960
961 terminate_all_pets (op);
962 leave_map (op);
963 op->direction = 0;
964 new_draw_info_format (NDI_UNIQUE | NDI_ALL, 5, NULL, "%s quits the game.", &op->name);
965
966 strcpy (op->contr->killer, "quit");
967 check_score (op);
968 op->contr->party = 0;
969 op->contr->own_title[0] = '\0';
970
971 object_ptr ob = op;
972
973 delete ob->contr;
974
975 /* We need to hunt for any per player unique maps in memory and
976 * get rid of them. The trailing slash in the path is intentional,
977 * so that players named 'Ab' won't match against players 'Abe' pathname
978 */
979 char buf[MAX_BUF];
980 sprintf (buf, "%s/%s/%s/", settings.localdir, settings.playerdir, &op->name);
981
982 for (maptile *next, *mp = first_map; mp; mp = next)
983 {
984 next = mp->next;
985
986 if (!strncmp (mp->path, buf, strlen (buf)))
987 delete_map (mp);
988 }
989
990 delete_character (ob->name, 1);
991
992 return 1;
993} 921}
994 922
995void 923void
996flee_player (object *op) 924flee_player (object *op)
997{ 925{
… …
1044 /* Cornered, get rid of scared */ 972 /* Cornered, get rid of scared */
1045 CLEAR_FLAG (op, FLAG_SCARED); 973 CLEAR_FLAG (op, FLAG_SCARED);
1046 op->enemy = NULL; 974 op->enemy = NULL;
1047} 975}
1048 976
1049
1050/* check_pick sees if there is stuff to be picked up/picks up stuff. 977/* check_pick sees if there is stuff to be picked up/picks up stuff.
1051 * IT returns 1 if the player should keep on moving, 0 if he should 978 * It returns 1 if the player should keep on moving, 0 if he should
1052 * stop. 979 * stop.
1053 */ 980 */
1054int 981int
1055check_pick (object *op) 982check_pick (object *op)
1056{ 983{
1057 object *tmp, *next; 984 object *tmp, *next;
1058 int stop = 0; 985 int stop = 0;
1059 int j, k, wvratio; 986 int wvratio;
1060 char putstring[128], tmpstr[16]; 987 char putstring[128];
1061 988
1062 /* if you're flying, you cna't pick up anything */ 989 /* if you're flying, you cna't pick up anything */
1063 if (op->move_type & MOVE_FLYING) 990 if (op->move_type & MOVE_FLYING)
1064 return 1; 991 return 1;
1065 992
1066 next = op->below; 993 next = op->below;
1067 994
995 int cnt = MAX_ITEM_PER_DROP;
996#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
997
1068 /* loop while there are items on the floor that are not marked as 998 /* loop while there are items on the floor that are not marked as
1069 * destroyed */ 999 * destroyed */
1070 while (next && !next->destroyed ()) 1000 while (next && !next->destroyed ())
1071 { 1001 {
1072 tmp = next; 1002 tmp = next;
1073 next = tmp->below; 1003 next = tmp->below;
1074 1004
1005 if (cnt <= 0)
1006 {
1007 op->failmsg ("Couldn't pickup all items at once.");
1008 return 0;
1009 }
1010
1075 if (op->destroyed ()) 1011 if (op->destroyed ())
1076 return 0; 1012 return 0;
1077 1013
1078 if (!can_pick (op, tmp)) 1014 if (!can_pick (op, tmp))
1079 continue; 1015 continue;
1080 1016
1081 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 1017 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1082 { 1018 {
1083 if (item_matched_string (op, tmp, op->contr->search_str)) 1019 if (item_matched_string (op, tmp, op->contr->search_str))
1084 pick_up (op, tmp); 1020 CHK_PICK_PICKUP;
1085 continue; 1021 continue;
1086 } 1022 }
1087 1023
1088 /* high not bit set? We're using the old autopickup model */ 1024 /* high not bit set? We're using the old autopickup model */
1089 if (!(op->contr->mode & PU_NEWMODE)) 1025 if (!(op->contr->mode & PU_NEWMODE))
… …
1091 switch (op->contr->mode) 1027 switch (op->contr->mode)
1092 { 1028 {
1093 case 0: 1029 case 0:
1094 return 1; /* don't pick up */ 1030 return 1; /* don't pick up */
1095 case 1: 1031 case 1:
1096 pick_up (op, tmp); 1032 CHK_PICK_PICKUP;
1097 return 1; 1033 return 1;
1098 case 2: 1034 case 2:
1099 pick_up (op, tmp); 1035 CHK_PICK_PICKUP;
1100 return 0; 1036 return 0;
1101 case 3: 1037 case 3:
1102 return 0; /* stop before pickup */ 1038 return 0; /* stop before pickup */
1103 case 4: 1039 case 4:
1104 pick_up (op, tmp); 1040 CHK_PICK_PICKUP;
1105 break; 1041 break;
1106 case 5: 1042 case 5:
1107 pick_up (op, tmp); 1043 CHK_PICK_PICKUP;
1108 stop = 1; 1044 stop = 1;
1109 break; 1045 break;
1110 case 6: 1046 case 6:
1111 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1047 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL)
1112 pick_up (op, tmp); 1048 && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1049 CHK_PICK_PICKUP;
1113 break; 1050 break;
1114 1051
1115 case 7: 1052 case 7:
1116 if (tmp->type == MONEY || tmp->type == GEM) 1053 if (tmp->type == MONEY || tmp->type == GEM)
1117 pick_up (op, tmp); 1054 CHK_PICK_PICKUP;
1118 break; 1055 break;
1119 1056
1120 default: 1057 default:
1121 /* use value density */ 1058 /* use value density */
1122 if (!QUERY_FLAG (tmp, FLAG_UNPAID) 1059 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1123 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode) 1060 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1124 pick_up (op, tmp); 1061 CHK_PICK_PICKUP;
1125 } 1062 }
1126 } 1063 }
1127 else 1064 else
1128 { /* old model */ 1065 { /* old model */
1129 /* NEW pickup handling */ 1066 /* NEW pickup handling */
… …
1133 if (tmp->name != NULL) 1070 if (tmp->name != NULL)
1134 sprintf (putstring, "item name: %s item type: %d weight/value: %d", 1071 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1135 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1072 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1136 else 1073 else
1137 sprintf (putstring, "item name: %s item type: %d weight/value: %d", 1074 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1138 &tmp->arch->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1075 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1139 1076
1140 new_draw_info (NDI_UNIQUE, 0, op, putstring); 1077 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1141 } 1078 }
1142 1079
1143 /* philosophy: 1080 /* philosophy:
… …
1184 /* all food and drink if desired */ 1121 /* all food and drink if desired */
1185 /* question: don't pick up known-poisonous stuff? */ 1122 /* question: don't pick up known-poisonous stuff? */
1186 if (op->contr->mode & PU_FOOD) 1123 if (op->contr->mode & PU_FOOD)
1187 if (tmp->type == FOOD) 1124 if (tmp->type == FOOD)
1188 { 1125 {
1189 pick_up (op, tmp); 1126 CHK_PICK_PICKUP;
1190 continue; 1127 continue;
1191 } 1128 }
1192 1129
1193 if (op->contr->mode & PU_DRINK) 1130 if (op->contr->mode & PU_DRINK)
1194 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1131 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)))
1195 { 1132 {
1196 pick_up (op, tmp); 1133 CHK_PICK_PICKUP;
1197 continue; 1134 continue;
1198 } 1135 }
1199 1136
1200 if (op->contr->mode & PU_POTION) 1137 if (op->contr->mode & PU_POTION)
1201 if (tmp->type == POTION) 1138 if (tmp->type == POTION)
1202 { 1139 {
1203 pick_up (op, tmp); 1140 CHK_PICK_PICKUP;
1204 continue; 1141 continue;
1205 } 1142 }
1206 1143
1207 /* spellbooks, skillscrolls and normal books/scrolls */ 1144 /* spellbooks, skillscrolls and normal books/scrolls */
1208 if (op->contr->mode & PU_SPELLBOOK) 1145 if (op->contr->mode & PU_SPELLBOOK)
1209 if (tmp->type == SPELLBOOK) 1146 if (tmp->type == SPELLBOOK)
1210 { 1147 {
1211 pick_up (op, tmp); 1148 CHK_PICK_PICKUP;
1212 continue; 1149 continue;
1213 } 1150 }
1214 1151
1215 if (op->contr->mode & PU_SKILLSCROLL) 1152 if (op->contr->mode & PU_SKILLSCROLL)
1216 if (tmp->type == SKILLSCROLL) 1153 if (tmp->type == SKILLSCROLL)
1217 { 1154 {
1218 pick_up (op, tmp); 1155 CHK_PICK_PICKUP;
1219 continue; 1156 continue;
1220 } 1157 }
1221 1158
1222 if (op->contr->mode & PU_READABLES) 1159 if (op->contr->mode & PU_READABLES)
1223 if (tmp->type == BOOK || tmp->type == SCROLL) 1160 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
1224 { 1161 {
1225 pick_up (op, tmp); 1162 CHK_PICK_PICKUP;
1226 continue; 1163 continue;
1227 } 1164 }
1228 1165
1229 /* wands/staves/rods/horns */ 1166 /* wands/staves/rods/horns */
1230 if (op->contr->mode & PU_MAGIC_DEVICE) 1167 if (op->contr->mode & PU_MAGIC_DEVICE)
1231 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN) 1168 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1232 { 1169 {
1233 pick_up (op, tmp); 1170 CHK_PICK_PICKUP;
1234 continue; 1171 continue;
1235 } 1172 }
1236 1173
1237 /* pick up all magical items */ 1174 /* pick up all magical items */
1238 if (op->contr->mode & PU_MAGICAL) 1175 if (op->contr->mode & PU_MAGICAL)
1239 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1176 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1240 { 1177 {
1241 pick_up (op, tmp); 1178 CHK_PICK_PICKUP;
1242 continue; 1179 continue;
1243 } 1180 }
1244 1181
1245 if (op->contr->mode & PU_VALUABLES) 1182 if (op->contr->mode & PU_VALUABLES)
1246 { 1183 {
1247 if (tmp->type == MONEY || tmp->type == GEM) 1184 if (tmp->type == MONEY || tmp->type == GEM)
1248 { 1185 {
1249 pick_up (op, tmp); 1186 CHK_PICK_PICKUP;
1250 continue; 1187 continue;
1251 } 1188 }
1252 } 1189 }
1253 1190
1254 /* rings & amulets - talismans seems to be typed AMULET */ 1191 /* rings & amulets - talismans seems to be typed AMULET */
1255 if (op->contr->mode & PU_JEWELS) 1192 if (op->contr->mode & PU_JEWELS)
1256 if (tmp->type == RING || tmp->type == AMULET) 1193 if (tmp->type == RING || tmp->type == AMULET)
1257 { 1194 {
1258 pick_up (op, tmp); 1195 CHK_PICK_PICKUP;
1259 continue; 1196 continue;
1260 } 1197 }
1261 1198
1262 /* we don't forget dragon food */ 1199 /* we don't forget dragon food */
1263 if (op->contr->mode & PU_FLESH) 1200 if (op->contr->mode & PU_FLESH)
1264 if (tmp->type == FLESH) 1201 if (tmp->type == FLESH)
1265 { 1202 {
1266 pick_up (op, tmp); 1203 CHK_PICK_PICKUP;
1267 continue; 1204 continue;
1268 } 1205 }
1269 1206
1270 /* bows and arrows. Bows are good for selling! */ 1207 /* bows and arrows. Bows are good for selling! */
1271 if (op->contr->mode & PU_BOW) 1208 if (op->contr->mode & PU_BOW)
1272 if (tmp->type == BOW) 1209 if (tmp->type == BOW)
1273 { 1210 {
1274 pick_up (op, tmp); 1211 CHK_PICK_PICKUP;
1275 continue; 1212 continue;
1276 } 1213 }
1277 1214
1278 if (op->contr->mode & PU_ARROW) 1215 if (op->contr->mode & PU_ARROW)
1279 if (tmp->type == ARROW) 1216 if (tmp->type == ARROW)
1280 { 1217 {
1281 pick_up (op, tmp); 1218 CHK_PICK_PICKUP;
1282 continue; 1219 continue;
1283 } 1220 }
1284 1221
1285 /* all kinds of armor etc. */ 1222 /* all kinds of armor etc. */
1286 if (op->contr->mode & PU_ARMOUR) 1223 if (op->contr->mode & PU_ARMOUR)
1287 if (tmp->type == ARMOUR) 1224 if (tmp->type == ARMOUR)
1288 { 1225 {
1289 pick_up (op, tmp); 1226 CHK_PICK_PICKUP;
1290 continue; 1227 continue;
1291 } 1228 }
1292 1229
1293 if (op->contr->mode & PU_HELMET) 1230 if (op->contr->mode & PU_HELMET)
1294 if (tmp->type == HELMET) 1231 if (tmp->type == HELMET)
1295 { 1232 {
1296 pick_up (op, tmp); 1233 CHK_PICK_PICKUP;
1297 continue; 1234 continue;
1298 } 1235 }
1299 1236
1300 if (op->contr->mode & PU_SHIELD) 1237 if (op->contr->mode & PU_SHIELD)
1301 if (tmp->type == SHIELD) 1238 if (tmp->type == SHIELD)
1302 { 1239 {
1303 pick_up (op, tmp); 1240 CHK_PICK_PICKUP;
1304 continue; 1241 continue;
1305 } 1242 }
1306 1243
1307 if (op->contr->mode & PU_BOOTS) 1244 if (op->contr->mode & PU_BOOTS)
1308 if (tmp->type == BOOTS) 1245 if (tmp->type == BOOTS)
1309 { 1246 {
1310 pick_up (op, tmp); 1247 CHK_PICK_PICKUP;
1311 continue; 1248 continue;
1312 } 1249 }
1313 1250
1314 if (op->contr->mode & PU_GLOVES) 1251 if (op->contr->mode & PU_GLOVES)
1315 if (tmp->type == GLOVES) 1252 if (tmp->type == GLOVES)
1316 { 1253 {
1317 pick_up (op, tmp); 1254 CHK_PICK_PICKUP;
1318 continue; 1255 continue;
1319 } 1256 }
1320 1257
1321 if (op->contr->mode & PU_CLOAK) 1258 if (op->contr->mode & PU_CLOAK)
1322 if (tmp->type == CLOAK) 1259 if (tmp->type == CLOAK)
1323 { 1260 {
1324 pick_up (op, tmp); 1261 CHK_PICK_PICKUP;
1325 continue; 1262 continue;
1326 } 1263 }
1327 1264
1328 /* hoping to catch throwing daggers here */ 1265 /* hoping to catch throwing daggers here */
1329 if (op->contr->mode & PU_MISSILEWEAPON) 1266 if (op->contr->mode & PU_MISSILEWEAPON)
1330 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN)) 1267 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1331 { 1268 {
1332 pick_up (op, tmp); 1269 CHK_PICK_PICKUP;
1333 continue; 1270 continue;
1334 } 1271 }
1335 1272
1336 /* careful: chairs and tables are weapons! */ 1273 /* careful: chairs and tables are weapons! */
1337 if (op->contr->mode & PU_ALLWEAPON) 1274 if (op->contr->mode & PU_ALLWEAPON)
1338 { 1275 {
1339 if (tmp->type == WEAPON && tmp->name != NULL) 1276 if (tmp->type == WEAPON && tmp->name != NULL)
1340 { 1277 {
1341 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->name, "table") == NULL && 1278 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->archname, "table") == NULL &&
1342 strstr (tmp->name, "chair") && strstr (tmp->arch->name, "chair") == NULL) 1279 strstr (tmp->name, "chair") && strstr (tmp->arch->archname, "chair") == NULL)
1343 { 1280 {
1344 pick_up (op, tmp); 1281 CHK_PICK_PICKUP;
1345 continue; 1282 continue;
1346 } 1283 }
1347 } 1284 }
1348 1285
1349 if (tmp->type == WEAPON && tmp->name == NULL) 1286 if (tmp->type == WEAPON && tmp->name == NULL)
1350 { 1287 {
1351 if (strstr (tmp->arch->name, "table") == NULL && strstr (tmp->arch->name, "chair") == NULL) 1288 if (strstr (tmp->arch->archname, "table") == NULL && strstr (tmp->arch->archname, "chair") == NULL)
1352 { 1289 {
1353 pick_up (op, tmp); 1290 CHK_PICK_PICKUP;
1354 continue; 1291 continue;
1355 } 1292 }
1356 } 1293 }
1357 } 1294 }
1358 1295
1359 /* misc stuff that's useful */ 1296 /* misc stuff that's useful */
1360 if (op->contr->mode & PU_KEY) 1297 if (op->contr->mode & PU_KEY)
1361 if (tmp->type == KEY || tmp->type == SPECIAL_KEY) 1298 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1362 { 1299 {
1363 pick_up (op, tmp); 1300 CHK_PICK_PICKUP;
1364 continue; 1301 continue;
1365 } 1302 }
1366 1303
1367 /* any of the last 4 bits set means we use the ratio for value 1304 /* any of the last 4 bits set means we use the ratio for value
1368 * pickups */ 1305 * pickups */
1369 if (op->contr->mode & PU_RATIO) 1306 if (op->contr->mode & PU_RATIO)
1370 { 1307 {
1371 /* use value density to decide what else to grab */ 1308 /* use value density to decide what else to grab */
1372 /* >=7 was >= op->contr->mode */ 1309 /* >=7 was >= op->contr->mode */
1373 /* >=7 is the old standard setting. Now we take the last 4 bits 1310 /* >=7 is the old standard setting. Now we take the last 4 bits
1374 * and multiply them by 5, giving 0..15*5== 5..75 */ 1311 */
1375 wvratio = (op->contr->mode & PU_RATIO) * 5; 1312 wvratio = op->contr->mode & PU_RATIO;
1376 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio) 1313 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1377 { 1314 {
1378 pick_up (op, tmp); 1315 CHK_PICK_PICKUP;
1379#if 0 1316#if 0
1380 fprintf (stderr, "HIGH WEIGHT/VALUE ["); 1317 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1381 if (tmp->name != NULL) 1318 if (tmp->name != NULL)
1382 { 1319 {
1383 fprintf (stderr, "%s", tmp->name); 1320 fprintf (stderr, "%s", tmp->name);
1384 } 1321 }
1385 else 1322 else
1386 fprintf (stderr, "%s", tmp->arch->name); 1323 fprintf (stderr, "%s", tmp->arch->archname);
1387 fprintf (stderr, ",%d] = ", tmp->type); 1324 fprintf (stderr, ",%d] = ", tmp->type);
1388 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1325 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1389#endif 1326#endif
1390 continue; 1327 continue;
1391 } 1328 }
… …
1402 * found object is returned. 1339 * found object is returned.
1403 */ 1340 */
1404object * 1341object *
1405find_arrow (object *op, const char *type) 1342find_arrow (object *op, const char *type)
1406{ 1343{
1407 object *tmp = NULL;
1408
1409 for (op = op->inv; op; op = op->below) 1344 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1410 if (!tmp && op->type == CONTAINER && op->race == type && QUERY_FLAG (op, FLAG_APPLIED))
1411 tmp = find_arrow (op, type);
1412 else if (op->type == ARROW && op->race == type) 1345 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1346 return splay (tmp);
1347
1348 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1349 if (tmp->type == CONTAINER && QUERY_FLAG (tmp, FLAG_APPLIED) && !strcmp (&tmp->race, type))
1350 if (object *arrow = find_arrow (tmp, type))
1351 {
1352 splay (tmp);
1413 return op; 1353 return arrow;
1354 }
1355
1414 return tmp; 1356 return 0;
1415} 1357}
1416 1358
1417/* 1359/*
1418 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1360 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1419 * against the target. A full test is not performed, simply a basic test 1361 * against the target. A full test is not performed, simply a basic test
1420 * of resistances. The archer is making a quick guess at what he sees down 1362 * of resistances. The archer is making a quick guess at what he sees down
1421 * the hall. Failing that it does it's best to pick the highest plus arrow. 1363 * the hall. Failing that it does it's best to pick the highest plus arrow.
1422 */ 1364 */
1423
1424object * 1365object *
1425find_better_arrow (object *op, object *target, const char *type, int *better) 1366find_better_arrow (object *op, object *target, const char *type, int *better)
1426{ 1367{
1427 object *tmp = NULL, *arrow, *ntmp; 1368 object *tmp = NULL, *arrow, *ntmp;
1428 int attacknum, attacktype, betterby = 0, i; 1369 int attacknum, attacktype, betterby = 0, i;
… …
1443 } 1384 }
1444 } 1385 }
1445 else if (arrow->type == ARROW && arrow->race == type) 1386 else if (arrow->type == ARROW && arrow->race == type)
1446 { 1387 {
1447 /* allways prefer assasination/slaying */ 1388 /* allways prefer assasination/slaying */
1448 if (target->race != NULL && arrow->slaying != NULL && strstr (arrow->slaying, target->race)) 1389 if (target->race && arrow->slaying && strstr (arrow->slaying, target->race))
1449 { 1390 {
1450 if (arrow->attacktype & AT_DEATH) 1391 if (arrow->attacktype & AT_DEATH)
1451 { 1392 {
1452 *better = 100; 1393 *better = 100;
1453 return arrow; 1394 return arrow;
… …
1461 else 1402 else
1462 { 1403 {
1463 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++) 1404 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++)
1464 { 1405 {
1465 attacktype = 1 << attacknum; 1406 attacktype = 1 << attacknum;
1466 if ((arrow->attacktype & attacktype) && (target->arch->clone.resist[attacknum]) < 0) 1407 if ((arrow->attacktype & attacktype) && (target->arch->resist[attacknum]) < 0)
1467 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100) > betterby) 1408 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100) > betterby)
1468 { 1409 {
1469 tmp = arrow; 1410 tmp = arrow;
1470 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100; 1411 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1471 } 1412 }
1472 } 1413 }
1473 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1414 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1474 { 1415 {
1475 tmp = arrow; 1416 tmp = arrow;
… …
1481 betterby = 1 + arrow->magic + arrow->stats.dam; 1422 betterby = 1 + arrow->magic + arrow->stats.dam;
1482 } 1423 }
1483 } 1424 }
1484 } 1425 }
1485 } 1426 }
1427
1486 if (tmp == NULL && arrow == NULL) 1428 if (tmp == NULL && arrow == NULL)
1487 return find_arrow (op, type); 1429 return find_arrow (op, type);
1488 1430
1489 *better = betterby; 1431 *better = betterby;
1490 return tmp; 1432 return tmp;
… …
1494 * find_better_arrow to find a decent arrow to use. 1436 * find_better_arrow to find a decent arrow to use.
1495 * op = the shooter 1437 * op = the shooter
1496 * type = bow->race 1438 * type = bow->race
1497 * dir = fire direction 1439 * dir = fire direction
1498 */ 1440 */
1499
1500object * 1441object *
1501pick_arrow_target (object *op, const char *type, int dir) 1442pick_arrow_target (object *op, const char *type, int dir)
1502{ 1443{
1503 object *tmp = NULL; 1444 object *tmp = NULL;
1504 maptile *m; 1445 maptile *m;
… …
1569 */ 1510 */
1570int 1511int
1571fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy) 1512fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy)
1572{ 1513{
1573 object *left, *bow; 1514 object *left, *bow;
1574 int bowspeed, mflags; 1515 int mflags;
1575 maptile *m; 1516 maptile *m;
1576 1517
1577 if (!dir) 1518 if (!dir)
1578 { 1519 {
1579 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!"); 1520 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!");
1580 return 0; 1521 return 0;
1581 } 1522 }
1582 1523
1583 if (op->type == PLAYER) 1524 if (op->contr)
1584 bow = op->contr->ranges[range_bow]; 1525 bow = op->current_weapon;
1585 else 1526 else
1586 { 1527 {
1587 for (bow = op->inv; bow; bow = bow->below) 1528 for (bow = op->inv; bow; bow = bow->below)
1588 /* Don't check for applied - monsters don't apply bows - in that way, they 1529 /* Don't check for applied - monsters don't apply bows - in that way, they
1589 * don't need to switch back and forth between bows and weapons. 1530 * don't need to switch back and forth between bows and weapons.
… …
1594 if (!bow) 1535 if (!bow)
1595 { 1536 {
1596 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1537 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1597 return 0; 1538 return 0;
1598 } 1539 }
1540
1541 // optimisation: move object to top so we will find it quickly again
1542 if (bow->below)
1543 {
1544 bow->remove ();
1545 op->insert (bow);
1546 }
1547
1599 } 1548 }
1600 1549
1601 if (!bow->race || !bow->skill) 1550 if (!bow->race || !bow->skill)
1602 { 1551 {
1603 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1552 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1604 return 0; 1553 return 0;
1605 } 1554 }
1606
1607 bowspeed = bow->stats.sp + dex_bonus[op->stats.Dex];
1608
1609 /* penalize ROF for bestarrow */
1610 if (op->type == PLAYER && op->contr->bowtype == bow_bestarrow)
1611 bowspeed -= dex_bonus[op->stats.Dex] + 5;
1612
1613 if (bowspeed < 1)
1614 bowspeed = 1;
1615 1555
1616 if (arrow == NULL) 1556 if (arrow == NULL)
1617 { 1557 {
1618 if ((arrow = find_arrow (op, bow->race)) == NULL) 1558 if ((arrow = find_arrow (op, bow->race)) == NULL)
1619 { 1559 {
1620 if (op->type == PLAYER) 1560 if (op->type == PLAYER)
1621 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1561 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1622 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1562 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1623 else 1563 else
1624 CLEAR_FLAG (op, FLAG_READY_BOW); 1564 CLEAR_FLAG (op, FLAG_READY_BOW);
1565
1625 return 0; 1566 return 0;
1626 } 1567 }
1627 } 1568 }
1628 1569
1629 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy); 1570 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy);
… …
1637 } 1578 }
1638 1579
1639 /* this should not happen, but sometimes does */ 1580 /* this should not happen, but sometimes does */
1640 if (arrow->nrof == 0) 1581 if (arrow->nrof == 0)
1641 { 1582 {
1583 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1642 arrow->destroy (); 1584 arrow->destroy (true);
1643 return 0; 1585 return 0;
1644 } 1586 }
1645 1587
1646 left = arrow; /* these are arrows left to the player */ 1588 left = arrow; /* these are arrows left to the player */
1647 arrow = get_split_ob (arrow, 1); 1589 arrow = arrow->split ();
1648 if (!arrow) 1590 if (!arrow)
1649 { 1591 {
1650 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1592 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1651 return 0; 1593 return 0;
1652 } 1594 }
1653 1595
1654 arrow->set_owner (op); 1596 arrow->set_owner (op);
1655 arrow->skill = bow->skill; 1597 arrow->skill = bow->skill;
1656
1657 arrow->direction = dir; 1598 arrow->direction = dir;
1658 arrow->x = sx; 1599
1659 arrow->y = sy; 1600 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1601 arrow->stats.hp = arrow->stats.dam;
1602 arrow->stats.grace = arrow->attacktype;
1603
1604 if (arrow->slaying)
1605 arrow->spellarg = strdup (arrow->slaying);
1606
1607#if 0
1608 if (player *pl = op->contr)
1609 {
1610 float speed = pl->weapon_sp;
1611
1612 /* penalize ROF for bestarrow */
1613 if (pl->bowtype == bow_bestarrow)
1614 speed *= .9f;
1615 else
1616 speed *= 1.f + dex_bonus[op->stats.Dex] * .2f;
1617
1618 op->speed_left += speed - op->speed;
1619 }
1620#endif
1621
1622 SET_ANIMATION (arrow, arrow->direction);
1623
1624 /* update the speed */
1625 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1626 + bow->stats.dam / 7.f;
1627
1628 arrow->set_speed (max (arrow->speed, 2.f));
1629 arrow->speed_left = 0;
1630
1631 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1660 1632
1661 if (op->type == PLAYER) 1633 if (op->type == PLAYER)
1662 { 1634 {
1663 op->speed_left = 0.01 - (float) FABS (op->speed) * 100 / bowspeed;
1664 op->update_stats ();
1665 }
1666
1667 SET_ANIMATION (arrow, arrow->direction);
1668 arrow->stats.sp = arrow->stats.wc; /* save original wc and dam */
1669 arrow->stats.hp = arrow->stats.dam;
1670 arrow->stats.grace = arrow->attacktype;
1671 if (arrow->slaying != NULL)
1672 arrow->spellarg = strdup (arrow->slaying);
1673
1674 /* Note that this was different for monsters - they got their level
1675 * added to the damage. I think the strength bonus is more proper.
1676 */
1677
1678 arrow->stats.dam += (QUERY_FLAG (bow, FLAG_NO_STRENGTH) ? 0 : dam_bonus[op->stats.Str]) + bow->stats.dam + bow->magic + arrow->magic;
1679
1680 /* update the speed */
1681 arrow->speed = (float) ((QUERY_FLAG (bow, FLAG_NO_STRENGTH) ?
1682 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.0 + (float) bow->stats.dam / 7.0;
1683
1684 if (arrow->speed < 1.0)
1685 arrow->speed = 1.0;
1686 update_ob_speed (arrow);
1687 arrow->speed_left = 0;
1688
1689 if (op->type == PLAYER)
1690 {
1691 arrow->stats.wc = 20 - bow->magic - arrow->magic -
1692 (op->chosen_skill ? op->chosen_skill->level : op->level) -
1693 dex_bonus[op->stats.Dex] - thaco_bonus[op->stats.Str] - arrow->stats.wc - bow->stats.wc + wc_mod;
1694
1695 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level; 1635 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level;
1636 wc -= dex_bonus[op->stats.Dex];
1637
1638 if (!arrow->slaying)
1639 arrow->slaying = op->slaying;
1640
1641 arrow->attacktype |= op->attacktype;
1696 } 1642 }
1697 else 1643 else
1698 { 1644 {
1699 arrow->stats.wc = op->stats.wc - bow->magic - arrow->magic - arrow->stats.wc + wc_mod;
1700 arrow->level = op->level; 1645 arrow->level = op->level;
1701 } 1646 arrow->stats.wc -= bow->magic;
1702 1647
1703 if (arrow->attacktype == AT_PHYSICAL) 1648 if (!arrow->slaying)
1649 arrow->slaying = bow->slaying;
1650
1704 arrow->attacktype |= bow->attacktype; 1651 arrow->attacktype |= bow->attacktype;
1652 }
1705 1653
1706 if (bow->slaying) 1654 wc -= arrow->level;
1707 arrow->slaying = bow->slaying; 1655 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1708 1656
1709 arrow->map = m; 1657 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1710 arrow->move_type = MOVE_FLY_LOW; 1658 arrow->move_type = MOVE_FLY_LOW;
1711 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1659 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1712 1660
1713 play_sound_map (op->map, op->x, op->y, SOUND_FIRE_ARROW); 1661 op->play_sound (sound_find ("fire_arrow"));
1714 insert_ob_in_map (arrow, m, op, 0); 1662 m->insert (arrow, sx, sy, op);
1715 1663
1716 if (!arrow->destroyed ()) 1664 if (!arrow->destroyed ())
1717 move_arrow (arrow); 1665 move_arrow (arrow);
1718
1719 if (op->type == PLAYER)
1720 {
1721 if (left->destroyed ())
1722 esrv_del_item (op->contr, left->count);
1723 else
1724 esrv_send_item (op, left);
1725 }
1726 1666
1727 return 1; 1667 return 1;
1728} 1668}
1729 1669
1730/* Special fire code for players - this takes into 1670/* Special fire code for players - this takes into
… …
1739{ 1679{
1740 int ret = 0, wcmod = 0; 1680 int ret = 0, wcmod = 0;
1741 1681
1742 if (op->contr->bowtype == bow_bestarrow) 1682 if (op->contr->bowtype == bow_bestarrow)
1743 { 1683 {
1744 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranges[range_bow]->race, dir), dir, 0, op->x, op->y); 1684 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1745 } 1685 }
1746 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1686 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1747 { 1687 {
1748 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1688 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1))
1749 wcmod = -1; 1689 wcmod = -1;
1690
1750 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1691 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1751 } 1692 }
1752 else if (op->contr->bowtype == bow_threewide) 1693 else if (op->contr->bowtype == bow_threewide)
1753 { 1694 {
1754 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1695 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
… …
1758 else if (op->contr->bowtype == bow_spreadshot) 1699 else if (op->contr->bowtype == bow_spreadshot)
1759 { 1700 {
1760 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1701 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1761 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1702 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1762 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1703 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1763
1764 } 1704 }
1765 else 1705 else
1766 { 1706 {
1767 /* Simple case */ 1707 /* Simple case */
1768 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1708 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1769 } 1709 }
1710
1770 return ret; 1711 return ret;
1771} 1712}
1772
1773 1713
1774/* Fires a misc (wand/rod/horn) object in 'dir'. 1714/* Fires a misc (wand/rod/horn) object in 'dir'.
1775 * Broken apart from 'fire' to keep it more readable. 1715 * Broken apart from 'fire' to keep it more readable.
1776 */ 1716 */
1777void 1717void
1778fire_misc_object (object *op, int dir) 1718fire_misc_object (object *op, int dir)
1779{ 1719{
1780 object *item; 1720 object *item = op->contr->ranged_ob;
1781 1721
1782 if (!op->contr->ranges[range_misc]) 1722 if (!item)
1783 { 1723 {
1784 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied."); 1724 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied.");
1785 return; 1725 return;
1786 } 1726 }
1787 1727
1788 item = op->contr->ranges[range_misc];
1789 if (!item->inv) 1728 if (!item->inv)
1790 { 1729 {
1791 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1730 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1792 return; 1731 return;
1793 } 1732 }
1733
1734 if (!op->change_weapon (item))
1735 return;
1736
1794 if (item->type == WAND) 1737 if (item->type == WAND)
1795 { 1738 {
1796 if (item->stats.food <= 0) 1739 if (item->stats.food <= 0)
1797 { 1740 {
1798 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1741 op->contr->play_sound (sound_find ("wand_poof"));
1799 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0)); 1742 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0));
1743
1800 return; 1744 return;
1801 } 1745 }
1802 } 1746 }
1803 else if (item->type == ROD || item->type == HORN) 1747 else if (item->type == ROD || item->type == HORN)
1804 { 1748 {
1805 if (item->stats.hp < MAX (item->inv->stats.sp, item->inv->stats.grace)) 1749 sint16 spell_sp = MAX (item->inv->stats.sp, item->inv->stats.grace);
1750
1751 // using the maximum of the rods charge allows at least one spell cast
1752 // for a rod or horn, this fixes some broken rods.
1753 if (item->stats.hp < MIN (spell_sp, item->stats.maxhp))
1806 { 1754 {
1807 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1755 op->contr->play_sound (sound_find ("wand_poof"));
1756
1808 if (item->type == ROD) 1757 if (item->type == ROD)
1809 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1758 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1810 else 1759 else
1811 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0)); 1760 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0));
1761
1812 return; 1762 return;
1813 } 1763 }
1814 } 1764 }
1815 1765
1816 if (cast_spell (op, item, dir, item->inv, NULL)) 1766 if (cast_spell (op, item, dir, item->inv, NULL))
… …
1823 object *tmp; 1773 object *tmp;
1824 1774
1825 if (item->arch) 1775 if (item->arch)
1826 { 1776 {
1827 CLEAR_FLAG (item, FLAG_ANIMATE); 1777 CLEAR_FLAG (item, FLAG_ANIMATE);
1828 item->face = item->arch->clone.face; 1778 item->face = item->arch->face;
1829 item->speed = 0; 1779 item->set_speed (0);
1830 update_ob_speed (item);
1831 } 1780 }
1832 if ((tmp = item->in_player ())) 1781
1782 if (object *pl = item->visible_to ())
1833 esrv_update_item (UPD_ANIM, tmp, item); 1783 esrv_update_item (UPD_ANIM, pl, item);
1834 } 1784 }
1835 } 1785 }
1836 else if (item->type == ROD || item->type == HORN) 1786 else if (item->type == ROD || item->type == HORN)
1837 {
1838 drain_rod_charge (item); 1787 drain_rod_charge (item);
1839 }
1840 } 1788 }
1841} 1789}
1842 1790
1843/* Received a fire command for the player - go and do it. 1791/* Received a fire command for the player - go and do it.
1844 */ 1792 */
1845void 1793bool
1846fire (object *op, int dir) 1794fire (object *op, int dir)
1847{ 1795{
1848 int spellcost = 0; 1796 int spellcost = 0;
1849 1797
1850 /* check for loss of invisiblity/hide */ 1798 /* check for loss of invisiblity/hide */
1851 if (action_makes_visible (op)) 1799 if (action_makes_visible (op))
1852 make_visible (op); 1800 make_visible (op);
1853 1801
1854 switch (op->contr->shoottype) 1802 player *pl = op->contr;
1803
1804 if (pl->golem)
1805 {
1806 control_golem (op->contr->golem, dir);
1807 return false;
1855 { 1808 }
1856 case range_none:
1857 return;
1858 1809
1859 case range_bow: 1810 object *ob = pl->ranged_ob;
1811
1812 if (!ob)
1813 return false;
1814
1815 if (!op->change_weapon (ob))
1816 return false;
1817
1818 if (op->speed_left > 0.f)
1819 --op->speed_left;
1820 else
1821 return false;
1822
1823 switch (ob->type)
1824 {
1825 case BOW:
1860 player_fire_bow (op, dir); 1826 player_fire_bow (op, dir);
1861 return; 1827 break;
1862 1828
1863 case range_magic: /* Casting spells */ 1829 case SPELL:
1864 spellcost = (cast_spell (op, op, dir, op->contr->ranges[range_magic], op->contr->spellparam[0] ? op->contr->spellparam : 0)); 1830 spellcost = cast_spell (op, op, dir, ob, pl->spellparam[0] ? pl->spellparam : 0);
1865 return; 1831 break;
1866 1832
1867 case range_misc: 1833 case BUILDER:
1834 apply_map_builder (op, dir);
1835 break;
1836
1837 case SKILL:
1838 do_skill (op, op, ob, dir, 0);
1839 break;
1840
1841 default:
1868 fire_misc_object (op, dir); 1842 fire_misc_object (op, dir);
1869 return; 1843 break;
1870
1871 case range_golem: /* Control summoned monsters from scrolls */
1872 if (QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
1873 {
1874 op->contr->ranges[range_golem] = 0;
1875 op->contr->shoottype = range_none;
1876 }
1877 else
1878 control_golem (op->contr->ranges[range_golem], dir);
1879 return;
1880
1881 case range_skill:
1882 if (!op->chosen_skill)
1883 {
1884 if (op->type == PLAYER)
1885 new_draw_info (NDI_UNIQUE, 0, op, "You have no applicable skill to use.");
1886 return;
1887 }
1888 (void) do_skill (op, op, op->chosen_skill, dir, NULL);
1889 return;
1890 case range_builder:
1891 apply_map_builder (op, dir);
1892 return;
1893 default:
1894 new_draw_info (NDI_UNIQUE, 0, op, "Illegal shoot type.");
1895 return;
1896 } 1844 }
1897}
1898 1845
1899 1846 return true;
1847}
1900 1848
1901/* find_key 1849/* find_key
1902 * We try to find a key for the door as passed. If we find a key 1850 * We try to find a key for the door as passed. If we find a key
1903 * and successfully use it, we return the key, otherwise NULL 1851 * and successfully use it, we return the key, otherwise NULL
1904 * This function merges both normal and locked door, since the logic 1852 * This function merges both normal and locked door, since the logic
… …
1906 * pl is the player, 1854 * pl is the player,
1907 * inv is the objects inventory to searched 1855 * inv is the objects inventory to searched
1908 * door is the door we are trying to match against. 1856 * door is the door we are trying to match against.
1909 * This function can be called recursively to search containers. 1857 * This function can be called recursively to search containers.
1910 */ 1858 */
1911
1912object * 1859object *
1913find_key (object *pl, object *container, object *door) 1860find_key (object *pl, object *container, object *door)
1914{ 1861{
1915 object *tmp, *key; 1862 object *tmp, *key;
1916 1863
1917 /* Should not happen, but sanity checking is never bad */ 1864 /* Should not happen, but sanity checking is never bad */
1918 if (container->inv == NULL) 1865 if (!container->inv)
1919 return NULL; 1866 return 0;
1920 1867
1921 /* First, lets try to find a key in the top level inventory */ 1868 /* First, lets try to find a key in the top level inventory */
1922 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1869 for (tmp = container->inv; tmp; tmp = tmp->below)
1923 { 1870 {
1924 if (door->type == DOOR && tmp->type == KEY) 1871 if (door->type == DOOR && tmp->type == KEY)
1925 break; 1872 break;
1926 /* For sanity, we should really check door type, but other stuff 1873 /* For sanity, we should really check door type, but other stuff
1927 * (like containers) can be locked with special keys 1874 * (like containers) can be locked with special keys
1928 */ 1875 */
1929 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1876 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1930 break; 1877 break;
1931 } 1878 }
1879
1932 /* No key found - lets search inventories now */ 1880 /* No key found - lets search inventories now */
1933 /* If we find and use a key in an inventory, return at that time. 1881 /* If we find and use a key in an inventory, return at that time.
1934 * otherwise, if we search all the inventories and still don't find 1882 * otherwise, if we search all the inventories and still don't find
1935 * a key, return 1883 * a key, return
1936 */ 1884 */
1937 if (!tmp) 1885 if (!tmp)
1938 { 1886 {
1939 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1887 for (tmp = container->inv; tmp; tmp = tmp->below)
1940 { 1888 {
1941 /* No reason to search empty containers */ 1889 /* No reason to search empty containers */
1942 if (tmp->type == CONTAINER && tmp->inv) 1890 if (tmp->type == CONTAINER && tmp->inv)
1943 { 1891 {
1944 if ((key = find_key (pl, tmp, door)) != NULL) 1892 if ((key = find_key (pl, tmp, door)))
1945 return key; 1893 return key;
1946 } 1894 }
1947 } 1895 }
1896
1948 if (!tmp) 1897 if (!tmp)
1949 return NULL; 1898 return NULL;
1950 } 1899 }
1900
1951 /* We get down here if we have found a key. Now if its in a container, 1901 /* We get down here if we have found a key. Now if its in a container,
1952 * see if we actually want to use it 1902 * see if we actually want to use it
1953 */ 1903 */
1954 if (pl != container) 1904 if (pl != container)
1955 { 1905 {
… …
1976 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1926 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1977 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1927 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1978 return NULL; 1928 return NULL;
1979 } 1929 }
1980 } 1930 }
1931
1981 return tmp; 1932 return tmp;
1982} 1933}
1983 1934
1984/* moved door processing out of move_player_attack. 1935/* moved door processing out of move_player_attack.
1985 * returns 1 if player has opened the door with a key 1936 * returns 1 if player has opened the door with a key
… …
1987 * 0 otherwise 1938 * 0 otherwise
1988 */ 1939 */
1989static int 1940static int
1990player_attack_door (object *op, object *door) 1941player_attack_door (object *op, object *door)
1991{ 1942{
1992 /* If its a door, try to find a use a key. If we do destroy the door, 1943 /* If its a door, try to find a key. If we do destroy the door,
1993 * might as well return immediately as there is nothing more to do - 1944 * might as well return immediately as there is nothing more to do -
1994 * otherwise, we fall through to the rest of the code. 1945 * otherwise, we fall through to the rest of the code.
1995 */ 1946 */
1996 object *key = find_key (op, op, door); 1947 object *key = find_key (op, op, door);
1997 1948
1998 /* IF we found a key, do some extra work */ 1949 /* If we found a key, do some extra work */
1999 if (key) 1950 if (key)
2000 { 1951 {
2001 object *container = key->env; 1952 object *container = key->env;
2002 1953
2003 play_sound_map (op->map, op->x, op->y, SOUND_OPEN_DOOR);
2004 if (action_makes_visible (op)) 1954 if (action_makes_visible (op))
2005 make_visible (op); 1955 make_visible (op);
1956
2006 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP)) 1957 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP))
2007 spring_trap (door->inv, op); 1958 spring_trap (door->inv, op);
1959
2008 if (door->type == DOOR) 1960 if (door->type == DOOR)
2009 {
2010 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */ 1961 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */
2011 }
2012 else if (door->type == LOCKED_DOOR) 1962 else if (door->type == LOCKED_DOOR)
2013 { 1963 {
2014 new_draw_info_format (NDI_UNIQUE, NDI_BROWN, op, "You open the door with the %s", query_short_name (key)); 1964 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN);
2015 remove_door2 (door); /* remove door without violence ;-) */ 1965 remove_door2 (door); /* remove door without violence ;-) */
2016 } 1966 }
1967
2017 /* Do this after we print the message */ 1968 /* Do this after we print the message */
2018 decrease_ob (key); /* Use up one of the keys */ 1969 key->decrease (); /* Use up one of the keys */
2019 /* Need to update the weight the container the key was in */ 1970
2020 if (container != op)
2021 esrv_update_item (UPD_WEIGHT, op, container);
2022 return 1; /* Nothing more to do below */ 1971 return 1; /* Nothing more to do below */
2023 } 1972 }
2024 else if (door->type == LOCKED_DOOR) 1973 else if (door->type == LOCKED_DOOR)
2025 { 1974 {
2026 /* Might as well return now - no other way to open this */ 1975 /* Might as well return now - no other way to open this */
2027 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, door->msg); 1976 op->failmsg (door->msg ? &door->msg : "Hmm, you miss the certain something to open this door...");
2028 return 1; 1977 return 1;
2029 } 1978 }
1979
2030 return 0; 1980 return 0;
2031} 1981}
2032 1982
2033/* This function is just part of a breakup from move_player. 1983/* This function is just part of a breakup from move_player.
2034 * It should keep the code cleaner. 1984 * It should keep the code cleaner.
2035 * When this is called, the players direction has been updated 1985 * When this is called, the players direction has been updated
2036 * (taking into account confusion.) The player is also actually 1986 * (taking into account confusion.) The player is also actually
2037 * going to try and move (not fire weapons). 1987 * going to try and move (not fire weapons).
2038 */ 1988 */
2039void 1989bool
2040move_player_attack (object *op, int dir) 1990move_player_attack (object *op, int dir)
2041{ 1991{
2042 object *tmp, *mon;
2043 sint16 nx, ny;
2044 int on_battleground; 1992 int on_battleground;
2045 maptile *m;
2046 1993
2047 nx = freearr_x[dir] + op->x; 1994 sint16 nx = freearr_x[dir] + op->x;
2048 ny = freearr_y[dir] + op->y; 1995 sint16 ny = freearr_y[dir] + op->y;
2049 1996
2050 on_battleground = op_on_battleground (op, 0, 0); 1997 on_battleground = op_on_battleground (op, 0, 0);
1998
1999 if (out_of_map (op->map, nx, ny))
2000 return false;
2001
2002 if (!op->contr->braced && op->speed_left > 0.f && move_ob (op, dir, op))
2003 {
2004 --op->speed_left;
2005 return true;
2006 }
2051 2007
2052 /* If braced, or can't move to the square, and it is not out of the 2008 /* If braced, or can't move to the square, and it is not out of the
2053 * map, attack it. Note order of if statement is important - don't 2009 * map, attack it. Note order of if statement is important - don't
2054 * want to be calling move_ob if braced, because move_ob will move the 2010 * want to be calling move_ob if braced, because move_ob will move the
2055 * player. This is a pretty nasty hack, because if we could 2011 * player. This is a pretty nasty hack, because if we could
2056 * move to some space, it then means that if we are braced, we should 2012 * move to some space, it then means that if we are braced, we should
2057 * do nothing at all. As it is, if we are braced, we go through 2013 * do nothing at all. As it is, if we are braced, we go through
2058 * quite a bit of processing. However, it probably is less than what 2014 * quite a bit of processing. However, it probably is less than what
2059 * move_ob uses. 2015 * move_ob uses.
2060 */ 2016 */
2061 if ((op->contr->braced || !move_ob (op, dir, op)) && !out_of_map (op->map, nx, ny)) 2017 maptile *m = op->map->xy_find (nx, ny);
2062 {
2063 if (OUT_OF_REAL_MAP (op->map, nx, ny))
2064 {
2065 m = get_map_from_coord (op->map, &nx, &ny);
2066 if (!m)
2067 return; /* Don't think this should happen */
2068 }
2069 else
2070 m = op->map;
2071 2018
2072 if ((tmp = GET_MAP_OB (m, nx, ny)) == NULL)
2073 {
2074 /* LOG(llevError,"player_move_attack: GET_MAP_OB returns NULL, but player can not move there.\n"); */
2075 return;
2076 }
2077
2078 mon = 0;
2079 /* Go through all the objects, and find ones of interest. Only stop if 2019 /* Go through all the objects, and find ones of interest. Only stop if
2080 * we find a monster - that is something we know we want to attack. 2020 * we find a monster - that is something we know we want to attack.
2081 * if its a door or barrel (can roll) see if there may be monsters 2021 * if its a door or barrel (can roll) see if there may be monsters
2082 * on the space 2022 * on the space
2083 */ 2023 */
2084 while (tmp) 2024 object *mon;
2085 { 2025 for (mon = m->at (nx, ny).bot; mon; mon = mon->above)
2086 if (tmp == op) 2026 {
2087 { 2027 if ((mon->flag [FLAG_ALIVE]
2088 tmp = tmp->above; 2028 || mon->type == LOCKED_DOOR
2089 continue; 2029 || mon->flag [FLAG_CAN_ROLL])
2090 }
2091
2092 if (QUERY_FLAG (tmp, FLAG_ALIVE))
2093 {
2094 mon = tmp; 2030 && mon != op)
2095 break; 2031 break;
2096 } 2032 }
2097 2033
2098 if (tmp->type == LOCKED_DOOR || QUERY_FLAG (tmp, FLAG_CAN_ROLL))
2099 mon = tmp;
2100
2101 tmp = tmp->above;
2102 }
2103
2104 if (!mon) /* This happens anytime the player tries to move */ 2034 if (!mon) /* This happens anytime the player tries to move */
2105 return; /* into a wall */ 2035 return false; /* into a wall */
2106 2036
2107 if (mon->head)
2108 mon = mon->head; 2037 mon = mon->head_ ();
2109 2038
2110 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR)) 2039 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2040 if (op->contr->weapon_sp_left > 0.f)
2111 if (player_attack_door (op, mon)) 2041 if (player_attack_door (op, mon))
2042 {
2043 --op->contr->weapon_sp_left;
2112 return; 2044 return true;
2045 }
2113 2046
2114 /* The following deals with possibly attacking peaceful 2047 /* The following deals with possibly attacking peaceful
2115 * or frienddly creatures. Basically, all players are considered 2048 * or friendly creatures. Basically, all players are considered
2116 * unaggressive. If the moving player has peaceful set, then the 2049 * unaggressive. If the moving player has peaceful set, then the
2117 * object should be pushed instead of attacked. It is assumed that 2050 * object should be pushed instead of attacked. It is assumed that
2118 * if you are braced, you will not attack friends accidently, 2051 * if you are braced, you will not attack friends accidently,
2119 * and thus will not push them. 2052 * and thus will not push them.
2120 */ 2053 */
2121 2054
2122 /* If the creature is a pet, push it even if the player is not 2055 /* If the creature is a pet, push it even if the player is not
2123 * peaceful. Our assumption is the creature is a pet if the 2056 * peaceful. Our assumption is the creature is a pet if the
2124 * player owns it and it is either friendly or unagressive. 2057 * player owns it and it is either friendly or unagressive.
2125 */ 2058 */
2126 if ((op->type == PLAYER) 2059 if (op->type == PLAYER
2127#if COZY_SERVER
2128 &&
2129 ((mon->owner && mon->owner->contr 2060 && ((mon->owner && mon->owner->contr
2130 && same_party (mon->owner->contr->party, op->contr->party)) || mon->owner == op) 2061 && same_party (mon->owner->contr->party, op->contr->party))
2131#else
2132 && mon->owner == op 2062 || mon->owner == op)
2133#endif
2134 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))) 2063 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
2135 { 2064 {
2136 /* If we're braced, we don't want to switch places with it */ 2065 /* If we're braced, we don't want to switch places with it */
2137 if (op->contr->braced) 2066 if (op->contr->braced)
2138 return; 2067 return false;
2139 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER); 2068
2069 if (op->speed_left > 0.f)
2070 {
2071 --op->speed_left;
2072
2073 op->play_sound (sound_find ("push_player"));
2140 (void) push_ob (mon, dir, op); 2074 push_ob (mon, dir, op);
2075
2141 if (op->contr->tmp_invis || op->hide) 2076 if (op->contr->tmp_invis || op->hide)
2142 make_visible (op); 2077 make_visible (op);
2078
2143 return; 2079 return true;
2144 } 2080 }
2081 else
2082 return false;
2083 }
2145 2084
2146 /* in certain circumstances, you shouldn't attack friendly 2085 /* in certain circumstances, you shouldn't attack friendly
2147 * creatures. Note that if you are braced, you can't push 2086 * creatures. Note that if you are braced, you can't push
2148 * someone, but put it inside this loop so that you won't 2087 * someone, but put it inside this loop so that you won't
2149 * attack them either. 2088 * attack them either.
2150 */ 2089 */
2151 if ((mon->type == PLAYER || mon->enemy != op) && 2090 if ((mon->type == PLAYER || mon->enemy != op)
2152 (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) && ( 2091 && (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))
2153#ifdef PROHIBIT_PLAYERKILL
2154 (op->contr->peaceful 2092 && ((op->contr->peaceful
2155 || (mon->type == PLAYER 2093 || (mon->type == PLAYER && mon->contr->peaceful))
2156 && mon->contr->
2157 peaceful)) &&
2158#else
2159 op->contr->peaceful &&
2160#endif
2161 !on_battleground)) 2094 && !on_battleground))
2095 {
2096 if (op->speed_left > 0.f)
2162 { 2097 {
2098 --op->speed_left;
2099
2163 if (!op->contr->braced) 2100 if (!op->contr->braced)
2164 { 2101 {
2165 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER); 2102 op->play_sound (sound_find ("push_player"));
2166 (void) push_ob (mon, dir, op); 2103 push_ob (mon, dir, op);
2167 } 2104 }
2168 else 2105 else
2169 new_draw_info (0, 0, op, "You withhold your attack"); 2106 op->statusmsg ("You withhold your attack");
2170 2107
2171 if (op->contr->tmp_invis || op->hide) 2108 if (op->contr->tmp_invis || op->hide)
2172 make_visible (op); 2109 make_visible (op);
2173 }
2174 2110
2111 return true;
2112 }
2113 }
2175 /* If the object is a boulder or other rollable object, then 2114 /* If the object is a boulder or other rollable object, then
2176 * roll it if not braced. You can't roll it if you are braced. 2115 * roll it if not braced. You can't roll it if you are braced.
2177 */ 2116 */
2178 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 2117 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced))
2118 {
2119 if (op->speed_left > 0.f)
2179 { 2120 {
2121 --op->speed_left;
2122
2180 recursive_roll (mon, dir, op); 2123 recursive_roll (mon, dir, op);
2181 if (action_makes_visible (op)) 2124 if (action_makes_visible (op))
2182 make_visible (op); 2125 make_visible (op);
2183 }
2184 2126
2127 return true;
2128 }
2129 }
2185 /* Any generic living creature. Including things like doors. 2130 /* Any generic living creature. Including things like doors.
2186 * Way it works is like this: First, it must have some hit points 2131 * Way it works is like this: First, it must have some hit points
2187 * and be living. Then, it must be one of the following: 2132 * and be living. Then, it must be one of the following:
2188 * 1) Not a player, 2) A player, but of a different party. Note 2133 * 1) Not a player, 2) A player, but of a different party. Note
2189 * that party_number -1 is no party, so attacks can still happen. 2134 * that party_number -1 is no party, so attacks can still happen.
2190 */ 2135 */
2191
2192 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 2136 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) &&
2193 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 2137 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2194 { 2138 {
2195 2139 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2196 /* If the player hasn't hit something this tick, and does
2197 * so, give them speed boost based on weapon speed. Doing
2198 * it here is better than process_players2, which basically
2199 * incurred a 1 tick offset.
2200 */
2201 if (!op->contr->has_hit)
2202 { 2140 {
2203 op->speed_left += op->speed / op->contr->weapon_sp; 2141 --op->contr->weapon_sp_left;
2204
2205 op->contr->has_hit = 1; /* The last action was to hit, so use weapon_sp */
2206 }
2207 2142
2208 skill_attack (mon, op, 0, 0, 0); 2143 skill_attack (mon, op, 0, 0, 0);
2209
2210 /* If attacking another player, that player gets automatic
2211 * hitback, and doesn't loose luck either.
2212 * Disable hitback on the battleground or if the target is
2213 * the wiz.
2214 */
2215 if (mon->type == PLAYER && mon->stats.hp >= 0 && !mon->contr->has_hit && !on_battleground && !QUERY_FLAG (mon, FLAG_WIZ))
2216 {
2217 short luck = mon->stats.luck;
2218
2219 mon->contr->has_hit = 1;
2220 skill_attack (op, mon, 0, 0, 0);
2221 mon->stats.luck = luck;
2222 }
2223 2144
2224 if (action_makes_visible (op)) 2145 if (action_makes_visible (op))
2225 make_visible (op); 2146 make_visible (op);
2226 }
2227 } /* if player should attack something */
2228}
2229 2147
2230int 2148 return true;
2149 }
2150 }
2151
2152 return false;
2153}
2154
2155bool
2231move_player (object *op, int dir) 2156move_player (object *op, int dir)
2232{ 2157{
2233 int pick; 2158 int pick;
2234 2159
2235 if (op->map == NULL || op->map->in_memory != MAP_IN_MEMORY) 2160 if (!op->map || op->map->in_memory != MAP_ACTIVE)
2236 return 0; 2161 return 0;
2237 2162
2238 /* Sanity check: make sure dir is valid */ 2163 /* Sanity check: make sure dir is valid */
2239 if ((dir < 0) || (dir >= 9)) 2164 if ((dir < 0) || (dir >= 9))
2240 { 2165 {
2241 LOG (llevError, "move_player: invalid direction %d\n", dir); 2166 LOG (llevError, "move_player: invalid direction %d\n", dir);
2242 return 0; 2167 return 0;
2243 } 2168 }
2244 2169
2245 /* peterm: added following line */ 2170 /* peterm: added following line */
2246 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2171 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir)
2247 dir = absdir (dir + RANDOM () % 3 + RANDOM () % 3 - 2); 2172 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2248 2173
2249 op->facing = dir; 2174 op->facing = dir;
2250 2175
2251 if (op->hide) 2176 if (op->hide)
2252 do_hidden_move (op); 2177 do_hidden_move (op);
2253 2178
2179 bool retval;
2180
2254 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2181 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2255 /*nop */ ; 2182 retval = RESULT_INT (0);
2256 else if (op->contr->fire_on) 2183 else if (op->contr->fire_on)
2257 fire (op, dir); 2184 retval = fire (op, dir);
2258 else 2185 else
2259 { 2186 {
2260 move_player_attack (op, dir); 2187 retval = move_player_attack (op, dir);
2261 pick = check_pick (op); 2188 pick = check_pick (op);
2262 } 2189 }
2263 2190
2264 /* Add special check for newcs players and fire on - this way, the 2191 /* Add special check for newcs players and fire on - this way, the
2265 * server can handle repeat firing. 2192 * server can handle repeat firing.
… …
2272 /* Update how the player looks. Use the facing, so direction may 2199 /* Update how the player looks. Use the facing, so direction may
2273 * get reset to zero. This allows for full animation capabilities 2200 * get reset to zero. This allows for full animation capabilities
2274 * for players. 2201 * for players.
2275 */ 2202 */
2276 animate_object (op, op->facing); 2203 animate_object (op, op->facing);
2277 return 0; 2204
2205 return retval;
2278} 2206}
2279 2207
2280/* This is similar to handle_player, below, but is only used by the 2208/* This is similar to handle_player, below, but is only used by the
2281 * new client/server stuff. 2209 * new client/server stuff.
2282 * This is sort of special, in that the new client/server actually uses 2210 * This is sort of special, in that the new client/server actually uses
2283 * the new speed values for commands. 2211 * the new speed values for commands.
2284 * 2212 *
2285 * Returns true if there are more actions we can do. 2213 * Returns true if there are more actions we can do. Should not do
2214 * many actions in a row, as that would be too unfair to other
2215 * players.
2286 */ 2216 */
2287int 2217bool
2288handle_newcs_player (object *op) 2218handle_newcs_player (object *op)
2289{ 2219{
2290 if (op->contr->hidden)
2291 {
2292 op->invisible = 1000;
2293 /* the socket code flashes the player visible/invisible
2294 * depending on the value of invisible, so we need to
2295 * alternate it here for it to work correctly.
2296 */
2297 if (pticks & 2)
2298 op->invisible--;
2299 }
2300 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2301 {
2302 op->invisible--;
2303 if (!op->invisible)
2304 {
2305 make_visible (op);
2306 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2307 }
2308 }
2309
2310 if (QUERY_FLAG (op, FLAG_SCARED)) 2220 if (QUERY_FLAG (op, FLAG_SCARED))
2311 { 2221 {
2312 flee_player (op); 2222 if (op->speed_left > 0.f)
2313 /* If player is still scared, that is his action for this tick */
2314 if (QUERY_FLAG (op, FLAG_SCARED))
2315 { 2223 {
2316 op->speed_left--; 2224 --op->speed_left;
2225 flee_player (op);
2226
2317 return 0; 2227 return true;
2318 } 2228 }
2229 else
2230 return false;
2319 } 2231 }
2320
2321 /* I've been seeing crashes where the golem has been destroyed, but
2322 * the player object still points to the defunct golem. The code that
2323 * destroys the golem looks correct, and it doesn't always happen, so
2324 * put this in a a workaround to clean up the golem pointer.
2325 */
2326 if (op->contr->ranges[range_golem] && QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
2327 op->contr->ranges[range_golem] = 0;
2328 2232
2329 /* call this here - we also will call this in do_ericserver, but 2233 /* call this here - we also will call this in do_ericserver, but
2330 * the players time has been increased when doericserver has been 2234 * the players time has been increased when doericserver has been
2331 * called, so we recheck it here. 2235 * called, so we recheck it here.
2332 */ 2236 */
2333 //TODO: better than handling 8 commands, use some more intelligent rate-limiting 2237 if (op->contr->ns->handle_command ())
2334 for (int rep = 8; --rep && op->contr->ns->handle_command (); )
2335 ;
2336
2337 if (op->speed_left < 0)
2338 return 0; 2238 return true;
2339 2239
2340 if (op->direction && (op->contr->run_on || op->contr->fire_on)) 2240 if (op->direction && (op->contr->run_on || op->contr->fire_on))
2341 {
2342 /* All move commands take 1 tick, at least for now */
2343 op->speed_left--;
2344
2345 /* Instead of all the stuff below, let move_player take care
2346 * of it. Also, some of the skill stuff is only put in
2347 * there, as well as the confusion stuff.
2348 */
2349 move_player (op, op->direction); 2241 return move_player (op, op->direction);
2350 if (op->speed_left > 0)
2351 return 1;
2352 else
2353 return 0;
2354 }
2355 2242
2356 return 0; 2243 return false;
2357} 2244}
2358 2245
2359int 2246int
2360save_life (object *op) 2247save_life (object *op)
2361{ 2248{
… …
2363 return 0; 2250 return 0;
2364 2251
2365 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2252 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2366 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2253 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE))
2367 { 2254 {
2368 play_sound_map (op->map, op->x, op->y, SOUND_OB_EVAPORATE); 2255 op->play_sound (sound_find ("ob_evaporate"));
2369 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2256 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2370 2257
2371 if (op->contr)
2372 esrv_del_item (op->contr, tmp->count);
2373
2374 tmp->destroy (); 2258 tmp->destroy (true);
2375 CLEAR_FLAG (op, FLAG_LIFESAVE); 2259 CLEAR_FLAG (op, FLAG_LIFESAVE);
2376 2260
2377 if (op->stats.hp < 0) 2261 if (op->stats.hp < 0)
2378 op->stats.hp = op->stats.maxhp; 2262 op->stats.hp = op->stats.maxhp;
2379 2263
… …
2390 return 0; 2274 return 0;
2391} 2275}
2392 2276
2393/* This goes throws the inventory and removes unpaid objects, and puts them 2277/* This goes throws the inventory and removes unpaid objects, and puts them
2394 * back in the map (location and map determined by values of env). This 2278 * back in the map (location and map determined by values of env). This
2395 * function will descend into containers. op is the object to start the search 2279 * function will descend into containers. op is the object to start the search
2396 * from. 2280 * from.
2397 */ 2281 */
2282static void
2283drop_unpaid_items (object *op, object *env)
2284{
2285 while (op)
2286 {
2287 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2288
2289 if (QUERY_FLAG (op, FLAG_UNPAID))
2290 op->insert_at (env);
2291 else if (op->inv)
2292 drop_unpaid_items (op->inv, env);
2293
2294 op = next;
2295 }
2296}
2297
2398void 2298void
2399remove_unpaid_objects (object *op, object *env) 2299object::drop_unpaid_items ()
2400{ 2300{
2401 object *next; 2301 if (!flag [FLAG_REMOVED])
2402 2302 ::drop_unpaid_items (inv, this);
2403 while (op)
2404 {
2405 next = op->below; /* Make sure we have a good value, in case
2406 * we remove object 'op'
2407 */
2408 if (QUERY_FLAG (op, FLAG_UNPAID))
2409 {
2410 op->remove ();
2411 op->x = env->x;
2412 op->y = env->y;
2413 if (env->type == PLAYER)
2414 esrv_del_item (env->contr, op->count);
2415 insert_ob_in_map (op, env->map, NULL, 0);
2416 }
2417 else if (op->inv)
2418 remove_unpaid_objects (op->inv, env);
2419
2420 op = next;
2421 }
2422} 2303}
2423 2304
2424/* 2305/*
2425 * Returns pointer a static string containing gravestone text 2306 * Returns pointer a static string containing gravestone text
2426 * Moved from apply.c to player.c - player.c is what 2307 * Moved from apply.c to player.c - player.c is what
2427 * actually uses this function. player.c may not be quite the 2308 * actually uses this function. player.c may not be quite the
2428 * best, a misc file for object actions is probably better, 2309 * best, a misc file for object actions is probably better,
2429 * but there isn't one in the server directory. 2310 * but there isn't one in the server directory.
2430 */ 2311 */
2431char * 2312const char *
2432gravestone_text (object *op) 2313gravestone_text (object *op)
2433{ 2314{
2434 static char buf2[MAX_BUF]; 2315 static dynbuf_text buf;
2435 char buf[MAX_BUF];
2436 time_t now = time (NULL);
2437 2316
2438 strcpy (buf2, " R.I.P.\n\n"); 2317 buf << "---- R.I.P. ----\n\n"
2318 << op->name;
2319
2439 if (op->type == PLAYER) 2320 if (op->type == PLAYER)
2440 sprintf (buf, "%s the %s\n", &op->name, op->contr->title); 2321 buf << " the " << op->contr->title;
2441 else
2442 sprintf (buf, "%s\n", &op->name);
2443 2322
2444 strncat (buf2, " ", 20 - strlen (buf) / 2); 2323 buf << "\n\n";
2445 strcat (buf2, buf); 2324
2325 buf << "who was level ";
2326 buf << (sint32)op->level << "\n\n" // OO breakdown
2327 << " when " << (op->contr ? "killed" : "died") << "\n\n";
2328
2446 if (op->type == PLAYER) 2329 if (op->type == PLAYER)
2447 sprintf (buf, "who was in level %d when killed\n", op->level); 2330 buf << "by " << op->contr->killer_name () << ".\n\n";
2448 else
2449 sprintf (buf, "who was in level %d when died.\n\n", op->level);
2450 2331
2451 strncat (buf2, " ", 20 - strlen (buf) / 2);
2452 strcat (buf2, buf);
2453 if (op->type == PLAYER)
2454 { 2332 {
2455 sprintf (buf, "by %s.\n\n", op->contr->killer); 2333 static char buf2[128];
2456 strncat (buf2, " ", 21 - strlen (buf) / 2); 2334 time_t now = time (NULL);
2457 strcat (buf2, buf);
2458 }
2459
2460 strftime (buf, MAX_BUF, "%b %d %Y\n", localtime (&now)); 2335 strftime (buf2, 128, "%b %d %Y\n\n", localtime (&now));
2461 strncat (buf2, " ", 20 - strlen (buf) / 2); 2336 buf << buf2;
2462 strcat (buf2, buf); 2337 }
2463 2338
2464 return buf2; 2339 return buf;
2465} 2340}
2466 2341
2467void 2342void
2468do_some_living (object *op) 2343do_some_living (object *op)
2469{ 2344{
… …
2476 int rate_grace = 2000; 2351 int rate_grace = 2000;
2477 const int max_hp = 1; 2352 const int max_hp = 1;
2478 const int max_sp = 1; 2353 const int max_sp = 1;
2479 const int max_grace = 1; 2354 const int max_grace = 1;
2480 2355
2481 if (op->contr->outputs_sync) 2356 if (op->contr->hidden)
2357 {
2358 op->invisible = 1000;
2359 /* the socket code flashes the player visible/invisible
2360 * depending on the value of invisible, so we need to
2361 * alternate it here for it to work correctly.
2362 */
2363 if (pticks & 2)
2364 op->invisible--;
2482 { 2365 }
2483 for (i = 0; i < NUM_OUTPUT_BUFS; i++) 2366 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2484 if (op->contr->outputs[i].buf && (op->contr->outputs[i].first_update + op->contr->outputs_sync) < (uint16) pticks) 2367 {
2485 flush_output_element (op, &op->contr->outputs[i]); 2368 if (!op->invisible--)
2369 {
2370 make_visible (op);
2371 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2372 }
2486 } 2373 }
2487 2374
2488 if (op->contr->ns->state == ST_PLAYING) 2375 if (op->contr->ns->state == ST_PLAYING)
2489 { 2376 {
2490 /* these next three if clauses make it possible to SLOW DOWN 2377 /* these next three if clauses make it possible to SLOW DOWN
… …
2509 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace; 2396 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace;
2510 else 2397 else
2511 { 2398 {
2512 gen_grace = op->stats.maxgrace; 2399 gen_grace = op->stats.maxgrace;
2513 rate_grace -= rate_grace / 2 * op->contr->gen_grace; 2400 rate_grace -= rate_grace / 2 * op->contr->gen_grace;
2514 }
2515
2516 /* Regenerate Spell Points */
2517 if (op->contr->ranges[range_golem] == NULL && --op->last_sp < 0)
2518 {
2519 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2520 if (op->stats.sp < op->stats.maxsp)
2521 {
2522 op->stats.sp++;
2523 /* dms do not consume food */
2524 if (!QUERY_FLAG (op, FLAG_WIZ))
2525 {
2526 op->stats.food--;
2527 if (op->contr->digestion < 0)
2528 op->stats.food += op->contr->digestion;
2529 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2530 op->stats.food = last_food;
2531 }
2532 }
2533
2534 if (max_sp > 1)
2535 {
2536 over_sp = (gen_sp + 10) / rate_sp;
2537 if (over_sp > 0)
2538 {
2539 if (op->stats.sp < op->stats.maxsp)
2540 {
2541 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2542
2543 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2544 op->stats.sp--;
2545
2546 if (op->stats.sp > op->stats.maxsp)
2547 op->stats.sp = op->stats.maxsp;
2548 }
2549 op->last_sp = 0;
2550 }
2551 else
2552 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2553 }
2554 else
2555 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2556 } 2401 }
2557 2402
2558 /* Regenerate Grace */ 2403 /* Regenerate Grace */
2559 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */ 2404 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */
2560 if (--op->last_grace < 0) 2405 if (--op->last_grace < 0)
… …
2581 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2426 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2582 } 2427 }
2583 /* wearing stuff doesn't detract from grace generation. */ 2428 /* wearing stuff doesn't detract from grace generation. */
2584 } 2429 }
2585 2430
2431 if (op->stats.food > 0)
2432 {
2586 /* Regenerate Hit Points */ 2433 /* Regenerate Spell Points */
2587 if (--op->last_heal < 0) 2434 if (!op->contr->golem && --op->last_sp < 0)
2588 {
2589 if (op->stats.hp < op->stats.maxhp)
2590 { 2435 {
2591 op->stats.hp++; 2436 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2592 /* dms do not consume food */ 2437
2593 if (!QUERY_FLAG (op, FLAG_WIZ)) 2438 if (op->stats.sp < op->stats.maxsp)
2594 { 2439 {
2440 op->stats.sp++;
2441
2442 /* dms do not consume food */
2443 if (!QUERY_FLAG (op, FLAG_WIZ))
2444 {
2595 op->stats.food--; 2445 op->stats.food--;
2446
2596 if (op->contr->digestion < 0) 2447 if (op->contr->digestion < 0)
2597 op->stats.food += op->contr->digestion; 2448 op->stats.food += op->contr->digestion;
2598 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2449 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2599 op->stats.food = last_food; 2450 op->stats.food = last_food;
2451 }
2600 } 2452 }
2601 }
2602 2453
2603 if (max_hp > 1) 2454 if (max_sp > 1)
2604 {
2605 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2606 if (over_hp > 0)
2607 { 2455 {
2608 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2456 over_sp = (gen_sp + 10) / rate_sp;
2457 if (over_sp > 0)
2458 {
2459 if (op->stats.sp < op->stats.maxsp)
2460 {
2461 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2462
2463 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2464 op->stats.sp--;
2465
2466 if (op->stats.sp > op->stats.maxsp)
2467 op->stats.sp = op->stats.maxsp;
2468 }
2469
2609 op->last_heal = 0; 2470 op->last_sp = 0;
2471 }
2472 else
2473 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2610 } 2474 }
2611 else 2475 else
2476 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2477 }
2478
2479 /* Regenerate Hit Points */
2480 if (--op->last_heal < 0)
2481 {
2482 if (op->stats.hp < op->stats.maxhp)
2612 { 2483 {
2613 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2484 op->stats.hp++;
2485
2486 /* dms do not consume food */
2487 if (!QUERY_FLAG (op, FLAG_WIZ))
2488 {
2489 op->stats.food--;
2490
2491 if (op->contr->digestion < 0)
2492 op->stats.food += op->contr->digestion;
2493 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2494 op->stats.food = last_food;
2495 }
2614 } 2496 }
2497
2498 if (max_hp > 1)
2499 {
2500 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2501
2502 if (over_hp > 0)
2503 {
2504 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0;
2505 op->last_heal = 0;
2506 }
2507 else
2508 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2615 } 2509 }
2616 else 2510 else
2617 {
2618 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2511 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2619 } 2512 }
2620 } 2513 }
2621 2514
2622 /* Digestion */ 2515 /* Digestion */
2623 if (--op->last_eat < 0) 2516 if (--op->last_eat < 0)
2624 { 2517 {
2625#ifdef COZY_SERVER 2518 int bonus = max (0, op->contr->digestion),
2626 int dg = op->contr->digestion >= 0 && op->contr->digestion < 2 ? 2 : op->contr->digestion; 2519 penalty = max (0, -op->contr->digestion);
2627 int bonus = dg > 0 ? dg : 0, penalty = dg < 0 ? -dg : 0;
2628#else
2629 int bonus = op->contr->digestion > 0 ? op->contr->digestion : 0, penalty = op->contr->digestion < 0 ? -op->contr->digestion : 0;
2630#endif
2631 2520
2632 if (op->contr->gen_hp > 0)
2633 op->last_eat = 25 * (1 + bonus) / (op->contr->gen_hp + penalty + 1); 2521 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2634 else
2635 op->last_eat = 25 * (1 + bonus) / (penalty + 1);
2636 2522
2637 /* dms do not consume food */ 2523 /* dms do not consume food */
2638 if (!QUERY_FLAG (op, FLAG_WIZ)) 2524 if (!QUERY_FLAG (op, FLAG_WIZ))
2639 op->stats.food--; 2525 op->stats.food--;
2640 } 2526 }
2641 2527
2642 if (op->stats.food < 0 && op->stats.hp >= 0) 2528 if (op->stats.food < 0 && op->stats.hp >= 0)
2643 { 2529 {
2644 object *tmp, *flesh = 0; 2530 object *flesh = 0;
2645 2531
2646 for (tmp = op->inv; tmp; tmp = tmp->below) 2532 for_inv_removable (op, tmp)
2647 { 2533 {
2648 if (!QUERY_FLAG (tmp, FLAG_UNPAID)) 2534 if (QUERY_FLAG (tmp, FLAG_UNPAID))
2535 continue;
2536
2537 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2649 { 2538 {
2650 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2539 op->statusmsg ("You blindly grab for a bite of food. "
2651 { 2540 "H<To prevent you from starving, you ate some random item from your backpack.>");
2652 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food.");
2653 manual_apply (op, tmp, 0); 2541 manual_apply (op, tmp, 0);
2542
2654 if (op->stats.food >= 0 || op->stats.hp < 0) 2543 if (op->stats.food >= 0 || op->stats.hp < 0)
2655 break; 2544 break;
2656 } 2545 }
2657 else if (tmp->type == FLESH) 2546 else if (tmp->type == FLESH)
2658 flesh = tmp; 2547 flesh = tmp;
2659 } /* End if paid for object */ 2548 }
2660 } /* end of for loop */
2661 2549
2662 /* If player is still starving, it means they don't have any food, so 2550 /* If player is still starving, it means they don't have any food, so
2663 * eat flesh instead. 2551 * eat flesh instead.
2664 */ 2552 */
2665 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2553 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2666 { 2554 {
2667 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2555 op->statusmsg ("You blindly grab for a bite of food. "
2556 "H<To prevent you from starving, you ate some random item from your backpack.>");
2668 manual_apply (op, flesh, 0); 2557 manual_apply (op, flesh, 0);
2669 } 2558 }
2559
2560 // If player is still starving, alert him!
2561 if (op->stats.food < 0)
2562 op->failmsg ("You are starving! "
2563 "H<Eat some food to increase your food and prevent you from an untimely death.>");
2564 }
2565
2566 if (op->stats.food < 0)
2670 } 2567 {
2568 op->stats.hp += op->stats.food;
2569 op->stats.food = 0;
2671 2570
2672 while (op->stats.food < 0 && op->stats.hp >= 0) 2571 if (op->stats.hp < 0)
2673 op->stats.food++, op->stats.hp--; 2572 {
2573 op->contr->killer = archetype::get ("killer_starvation");
2574 op->contr->killer->destroy (true);
2575 }
2576 }
2674 2577
2578 /* killer should be set here already */
2675 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2579 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ))
2676 kill_player (op); 2580 kill_player (op);
2677 } 2581 }
2678} 2582}
2679 2583
… …
2683 * file. 2587 * file.
2684 */ 2588 */
2685void 2589void
2686kill_player (object *op) 2590kill_player (object *op)
2687{ 2591{
2592 int x, y;
2688 char buf[MAX_BUF]; 2593 char buf[MAX_BUF];
2689 int x, y;
2690
2691 //int i;
2692 maptile *map; /* this is for resurrection */ 2594 maptile *map; /* this is for resurrection */
2693
2694 /* int z;
2695 int num_stats_lose;
2696 int lost_a_stat;
2697 int lose_this_stat;
2698 int this_stat; */
2699 int will_kill_again; 2595 int will_kill_again;
2700 archetype *at; 2596 archetype *at;
2701 object *tmp; 2597 object *tmp;
2702 2598
2703 if (save_life (op)) 2599 if (save_life (op))
2704 return; 2600 return;
2705
2706 2601
2707 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2602 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2708 * in cities ONLY!!! It is very important that this doesn't get abused. 2603 * in cities ONLY!!! It is very important that this doesn't get abused.
2709 * Look at op_on_battleground() for more info --AndreasV 2604 * Look at op_on_battleground() for more info --AndreasV
2710 */ 2605 */
… …
2713 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2608 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!");
2714 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life..."); 2609 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2715 2610
2716 /* restore player */ 2611 /* restore player */
2717 at = archetype::find ("poisoning"); 2612 at = archetype::find ("poisoning");
2718 tmp = present_arch_in_ob (at, op); 2613 if (object *tmp = present_arch_in_ob (at, op))
2719 if (tmp)
2720 { 2614 {
2721 tmp->destroy (); 2615 tmp->destroy (true);
2722 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed"); 2616 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2723 } 2617 }
2724 2618
2725 at = archetype::find ("confusion"); 2619 at = archetype::find ("confusion");
2726 tmp = present_arch_in_ob (at, op); 2620 if (object *tmp = present_arch_in_ob (at, op))
2727 if (tmp)
2728 { 2621 {
2729 tmp->destroy (); 2622 tmp->destroy (true);
2730 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer"); 2623 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2731 } 2624 }
2732 2625
2733 cure_disease (op, 0); /* remove any disease */ 2626 cure_disease (op, 0, 0); /* remove any disease */
2734 op->stats.hp = op->stats.maxhp; 2627 op->stats.hp = op->stats.maxhp;
2735 if (op->stats.food <= 0) 2628 if (op->stats.food <= 0)
2736 op->stats.food = 999; 2629 op->stats.food = 999;
2737 2630
2738 /* create a bodypart-trophy to make the winner happy */ 2631 /* create a bodypart-trophy to make the winner happy */
2739 tmp = arch_to_object (archetype::find ("finger")); 2632 if (object *tmp = arch_to_object (archetype::find ("finger")))
2740 if (tmp != NULL)
2741 { 2633 {
2742 sprintf (buf, "%s's finger", &op->name); 2634 tmp->name = format ("%s's finger" , &op->name);
2743 tmp->name = buf; 2635 tmp->name_pl = format ("%s's fingers", &op->name);
2744 sprintf (buf, " This finger has been cut off %s\n"
2745 " the %s, when he was defeated at\n level %d by %s.\n",
2746 &op->name, op->contr->title, (int) (op->level), op->contr->killer);
2747 tmp->msg = buf; 2636 tmp->msg = format (
2637 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2638 &op->name, op->contr->title,
2639 (int)op->level,
2640 op->contr->killer_name ()
2641 );
2748 tmp->value = 0, tmp->material = 0, tmp->type = 0; 2642 tmp->value = 0, tmp->type = 0;
2749 tmp->materialname = NULL; 2643 tmp->materialname = "organics";
2750 tmp->x = op->x, tmp->y = op->y; 2644 tmp->insert_at (op, tmp);
2751 insert_ob_in_map (tmp, op->map, op, 0);
2752 } 2645 }
2753 2646
2754 /* teleport defeated player to new destination */ 2647 /* teleport defeated player to new destination */
2755 transfer_ob (op, x, y, 0, NULL); 2648 transfer_ob (op, x, y, 0, NULL);
2756 op->contr->braced = 0; 2649 op->contr->braced = 0;
… …
2759 2652
2760 INVOKE_PLAYER (DEATH, op->contr); 2653 INVOKE_PLAYER (DEATH, op->contr);
2761 2654
2762 command_kill_pets (op, 0); 2655 command_kill_pets (op, 0);
2763 2656
2764 if (op->stats.food < 0) 2657 op->contr->play_sound (sound_find ("player_dies"));
2765 {
2766 if (op->contr->explore)
2767 {
2768 new_draw_info (NDI_UNIQUE, 0, op, "You would have starved, but you are");
2769 new_draw_info (NDI_UNIQUE, 0, op, "in explore mode, so...");
2770 op->stats.food = 999;
2771 return;
2772 }
2773 sprintf (buf, "%s starved to death.", &op->name);
2774 strcpy (op->contr->killer, "starvation");
2775 }
2776 else
2777 {
2778 if (op->contr->explore)
2779 {
2780 new_draw_info (NDI_UNIQUE, 0, op, "You would have died, but you are");
2781 new_draw_info (NDI_UNIQUE, 0, op, "in explore mode, so...");
2782 op->stats.hp = op->stats.maxhp;
2783 return;
2784 }
2785 sprintf (buf, "%s died.", &op->name);
2786 }
2787 play_sound_player_only (op->contr, SOUND_PLAYER_DIES, 0, 0);
2788 2658
2789 /* save the map location for corpse, gravestone */ 2659 /* save the map location for corpse, gravestone */
2790 x = op->x; 2660 x = op->x;
2791 y = op->y; 2661 y = op->y;
2792 map = op->map; 2662 map = op->map;
2793
2794 2663
2795 /* NOT_PERMADEATH code. This basically brings the character back to 2664 /* NOT_PERMADEATH code. This basically brings the character back to
2796 * life if they are dead - it takes some exp and a random stat. 2665 * life if they are dead - it takes some exp and a random stat.
2797 * See the config.h file for a little more in depth detail about this. 2666 * See the config.h file for a little more in depth detail about this.
2798 */ 2667 */
… …
2815 num_stats_lose = 1; 2684 num_stats_lose = 1;
2816 else 2685 else
2817 num_stats_lose = 1 + op->level / BALSL_NUMBER_LOSSES_RATIO; 2686 num_stats_lose = 1 + op->level / BALSL_NUMBER_LOSSES_RATIO;
2818 } 2687 }
2819 else 2688 else
2820 {
2821 num_stats_lose = 1; 2689 num_stats_lose = 1;
2822 } 2690
2823 lost_a_stat = 0; 2691 lost_a_stat = 0;
2824 2692
2825 for (z = 0; z < num_stats_lose; z++) 2693 for (z = 0; z < num_stats_lose; z++)
2826 { 2694 {
2827 i = RANDOM () % NUM_STATS; 2695 i = RANDOM () % NUM_STATS;
… …
2901 lost_a_stat = 1; 2769 lost_a_stat = 1;
2902 } 2770 }
2903 } 2771 }
2904 } 2772 }
2905 } 2773 }
2774
2906 /* If no stat lost, tell the player. */ 2775 /* If no stat lost, tell the player. */
2907 if (!lost_a_stat) 2776 if (!lost_a_stat)
2908 { 2777 {
2909 /* determine_god() seems to not work sometimes... why is this? 2778 /* determine_god() seems to not work sometimes... why is this?
2910 Should I be using something else? GD */ 2779 Should I be using something else? GD */
… …
2914 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2783 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god);
2915 else 2784 else
2916 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2785 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you.");
2917 } 2786 }
2918#else 2787#else
2919 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you" " feel a holy presence protecting you from losing yourself completely."); 2788 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you from losing yourself completely.");
2920#endif 2789#endif
2921 2790
2922 /* Put a gravestone up where the character 'almost' died. List the 2791 /* Put a gravestone up where the character 'almost' died. List the
2923 * exp loss on the stone. 2792 * exp loss on the stone.
2924 */ 2793 */
2925 tmp = arch_to_object (archetype::find ("gravestone")); 2794 tmp = arch_to_object (archetype::find ("gravestone"));
2926 sprintf (buf, "%s's gravestone", &op->name); 2795 tmp->name = format ("%s's gravestone", &op->name);
2927 tmp->name = buf; 2796 tmp->name_pl = format ("%s's gravestones", &op->name);
2928 sprintf (buf, "%s's gravestones", &op->name); 2797 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2929 tmp->name_pl = buf; 2798 &op->name, op->contr->title, op->contr->killer_name ());
2930 sprintf (buf, "RIP\nHere rests the hero %s the %s,\n" "who was killed\n" "by %s.\n", &op->name, op->contr->title, op->contr->killer);
2931 tmp->msg = buf;
2932 tmp->x = op->x, tmp->y = op->y; 2799 tmp->x = op->x, tmp->y = op->y;
2933 insert_ob_in_map (tmp, op->map, NULL, 0); 2800 insert_ob_in_map (tmp, op->map, NULL, 0);
2934 2801
2935 /**************************************/ 2802 /**************************************/
2936 /* */ 2803 /* */
… …
2945 at = archetype::find ("poisoning"); 2812 at = archetype::find ("poisoning");
2946 tmp = present_arch_in_ob (at, op); 2813 tmp = present_arch_in_ob (at, op);
2947 2814
2948 if (tmp) 2815 if (tmp)
2949 { 2816 {
2950 tmp->destroy (); 2817 tmp->destroy (true);
2951 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed"); 2818 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2952 } 2819 }
2953 2820
2954 at = archetype::find ("confusion"); 2821 at = archetype::find ("confusion");
2955 tmp = present_arch_in_ob (at, op); 2822 tmp = present_arch_in_ob (at, op);
2956 if (tmp) 2823 if (tmp)
2957 { 2824 {
2958 tmp->destroy (); 2825 tmp->destroy (true);
2959 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer"); 2826 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2960 } 2827 }
2961 2828
2962 cure_disease (op, 0); /* remove any disease */ 2829 cure_disease (op, 0, 0); /* remove any disease */
2830
2831 // remove all spell effects that are active
2832 // to avoid long-term effects such as word-of-recall
2833 for (object *item = op->inv; item; )
2834 {
2835 object *next = item->below;
2836
2837 if (item->type == SPELL_EFFECT && item->active)
2838 item->destroy (true);
2839
2840 item = next;
2841 }
2963 2842
2964 /*add_exp(op, (op->stats.exp * -0.20)); */ 2843 /*add_exp(op, (op->stats.exp * -0.20)); */
2965 apply_death_exp_penalty (op); 2844 apply_death_exp_penalty (op);
2845
2966 if (op->stats.food < 100) 2846 if (op->stats.food < 100)
2967 op->stats.food = 900; 2847 op->stats.food = 900;
2848
2968 op->stats.hp = op->stats.maxhp; 2849 op->stats.hp = op->stats.maxhp;
2969 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp); 2850 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2970 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace); 2851 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2971 2852
2972 /* 2853 /*
2973 * Check to see if the player is in a shop. IF so, then check to see if
2974 * the player has any unpaid items. If so, remove them and put them back 2854 * Check to see if the player has any unpaid items. If so, remove them
2975 * in the map. 2855 * and put them back in the map.
2976 */ 2856 */
2977 2857 op->drop_unpaid_items ();
2978 if (is_in_shop (op))
2979 remove_unpaid_objects (op->inv, op);
2980 2858
2981 /****************************************/ 2859 /****************************************/
2982 /* */ 2860 /* */
2983 /* Move player to his current respawn- */ 2861 /* Move player to his current respawn- */
2984 /* position (usually last savebed) */ 2862 /* position (usually last savebed) */
2985 /* */ 2863 /* */
2986 /****************************************/ 2864 /****************************************/
2987 2865
2988 enter_player_savebed (op); 2866 enter_player_savebed (op);
2989 2867
2990 /* Save the player before inserting the force to reduce
2991 * chance of abuse.
2992 */
2993 op->contr->braced = 0; 2868 op->contr->braced = 0;
2994 op->contr->save ();
2995 2869
2996 /* it is possible that the player has blown something up 2870 /* it is possible that the player has blown something up
2997 * at his savebed location, and that can have long lasting 2871 * at his savebed location, and that can have long lasting
2998 * spell effects. So first see if there is a spell effect 2872 * spell effects. So first see if there is a spell effect
2999 * on the space that might harm the player. 2873 * on the space that might harm the player.
… …
3008 object *force; 2882 object *force;
3009 int at; 2883 int at;
3010 2884
3011 force = get_archetype (FORCE_NAME); 2885 force = get_archetype (FORCE_NAME);
3012 /* 50 ticks should be enough time for the spell to abate */ 2886 /* 50 ticks should be enough time for the spell to abate */
3013 force->speed = 0.1; 2887 force->speed = 0.1f;
3014 force->speed_left = -5.0; 2888 force->speed_left = -5.f;
3015 SET_FLAG (force, FLAG_APPLIED); 2889 SET_FLAG (force, FLAG_APPLIED);
3016 for (at = 0; at < NROFATTACKS; at++) 2890 for (at = 0; at < NROFATTACKS; at++)
3017 if (will_kill_again & (1 << at)) 2891 if (will_kill_again & (1 << at))
3018 force->resist[at] = 100; 2892 force->resist[at] = 100;
3019 2893
3020 insert_ob_in_ob (force, op); 2894 insert_ob_in_ob (force, op);
3021 op->update_stats (); 2895 op->update_stats ();
3022
3023 } 2896 }
3024 2897
3025 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2898 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED.");
3026} 2899}
3027 2900
3028void 2901void
3029loot_object (object *op) 2902loot_object (object *op)
3030{ /* Grab and destroy some treasure */ 2903{ /* Grab and destroy some treasure */
3031 object *tmp, *tmp2, *next; 2904 object *tmp, *tmp2, *next;
3032 2905
3033 if (op->container) 2906 op->close_container (); /* close open sack first */
3034 esrv_apply_container (op, op->container); /* close open sack first */
3035 2907
3036 for (tmp = op->inv; tmp; tmp = next) 2908 for (tmp = op->inv; tmp; tmp = next)
3037 { 2909 {
3038 next = tmp->below; 2910 next = tmp->below;
3039 2911
3040 if (tmp->invisible) 2912 if (tmp->invisible)
3041 continue; 2913 continue;
3042 2914
3043 tmp->remove (); 2915 tmp->remove ();
3044 tmp->x = op->x, tmp->y = op->y; 2916 tmp->x = op->x, tmp->y = op->y;
2917
3045 if (tmp->type == CONTAINER) 2918 if (tmp->type == CONTAINER)
3046 { /* empty container to ground */ 2919 loot_object (tmp); /* empty container to ground */
3047 loot_object (tmp); 2920
3048 }
3049 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(RANDOM () % 3))) 2921 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3))))
3050 { 2922 {
3051 if (tmp->nrof > 1) 2923 if (tmp->nrof > 1)
3052 { 2924 {
3053 tmp2 = get_split_ob (tmp, 1 + RANDOM () % (tmp->nrof - 1)); 2925 tmp->decrease (rndm (1, tmp->nrof - 1));
3054 tmp2->destroy ();
3055 insert_ob_in_map (tmp, op->map, NULL, 0); 2926 insert_ob_in_map (tmp, op->map, NULL, 0);
3056 } 2927 }
3057 else 2928 else
3058 tmp->destroy (); 2929 tmp->destroy (true);
3059 } 2930 }
3060 else 2931 else
3061 insert_ob_in_map (tmp, op->map, NULL, 0); 2932 insert_ob_in_map (tmp, op->map, NULL, 0);
3062 } 2933 }
3063} 2934}
… …
3065/* 2936/*
3066 * fix_weight(): Check recursively the weight of all players, and fix 2937 * fix_weight(): Check recursively the weight of all players, and fix
3067 * what needs to be fixed. Refresh windows and fix speed if anything 2938 * what needs to be fixed. Refresh windows and fix speed if anything
3068 * was changed. 2939 * was changed.
3069 */ 2940 */
3070
3071void 2941void
3072fix_weight (void) 2942fix_weight (void)
3073{ 2943{
3074 for (player *pl = first_player; pl; pl = pl->next) 2944 for_all_players (pl)
3075 { 2945 {
3076 int old = pl->ob->carrying, sum = sum_weight (pl->ob); 2946 sint32 old = pl->ob->carrying;
3077 2947
3078 if (old == sum) 2948 pl->ob->update_weight ();
3079 continue; 2949
2950 if (old != pl->ob->carrying)
2951 {
3080 pl->ob->update_stats (); 2952 pl->ob->update_stats ();
3081 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, old, sum); 2953 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, (int)old, (int)pl->ob->carrying);
2954 }
3082 } 2955 }
3083} 2956}
3084 2957
3085void 2958void
3086fix_luck (void) 2959fix_luck (void)
3087{ 2960{
3088 for (player *pl = first_player; pl; pl = pl->next) 2961 for_all_players (pl)
3089 if (!pl->ob->contr->ns->state) 2962 if (!pl->ob->contr->ns->state)
3090 pl->ob->change_luck (0); 2963 pl->ob->change_luck (0);
3091} 2964}
3092 2965
3093/* cast_dust() - handles op throwing objects of type 'DUST'. 2966/* cast_dust() - handles op throwing objects of type 'DUST'.
… …
3122 if (op->type == PLAYER) 2995 if (op->type == PLAYER)
3123 new_draw_info_format (NDI_UNIQUE, 0, op, "You cast %s.", &spob->name); 2996 new_draw_info_format (NDI_UNIQUE, 0, op, "You cast %s.", &spob->name);
3124 2997
3125 cast_spell (op, throw_ob, dir, spob, NULL); 2998 cast_spell (op, throw_ob, dir, spob, NULL);
3126 2999
3127 throw_ob->destroy (); 3000 throw_ob->destroy (true);
3128} 3001}
3129 3002
3130void 3003void
3131make_visible (object *op) 3004make_visible (object *op)
3132{ 3005{
3133 op->hide = 0; 3006 op->hide = 0;
3134 op->invisible = 0; 3007 op->invisible = 0;
3008
3135 if (op->type == PLAYER) 3009 if (op->type == PLAYER)
3136 { 3010 {
3137 op->contr->tmp_invis = 0; 3011 op->contr->tmp_invis = 0;
3138 op->contr->invis_race = 0; 3012 op->contr->invis_race = 0;
3139 } 3013 }
3014
3140 update_object (op, UP_OBJ_FACE); 3015 update_object (op, UP_OBJ_CHANGE);
3141} 3016}
3142 3017
3143int 3018int
3144is_true_undead (object *op) 3019is_true_undead (object *op)
3145{ 3020{
3146 object *tmp = NULL;
3147
3148 if (QUERY_FLAG (&op->arch->clone, FLAG_UNDEAD)) 3021 if (QUERY_FLAG (op->arch, FLAG_UNDEAD))
3149 return 1; 3022 return 1;
3150 3023
3151 return 0; 3024 return 0;
3152} 3025}
3153 3026
3154/* look at the surrounding terrain to determine 3027/* look at the surrounding terrain to determine
3155 * the hideability of this object. Positive levels 3028 * the hideability of this object. Positive levels
3156 * indicate greater hideability. 3029 * indicate greater hideability.
3157 */ 3030 */
3158
3159int 3031int
3160hideability (object *ob) 3032hideability (object *ob)
3161{ 3033{
3162 int i, level = 0, mflag; 3034 int i, level = 0, mflag;
3163 sint16 x, y; 3035 sint16 x, y;
… …
3173 * as bad as carrying a light on a pitch dark map */ 3045 * as bad as carrying a light on a pitch dark map */
3174 if (has_carried_lights (ob)) 3046 if (has_carried_lights (ob))
3175 level = -(10 + (2 * ob->map->darkness)); 3047 level = -(10 + (2 * ob->map->darkness));
3176 3048
3177 /* scan through all nearby squares for terrain to hide in */ 3049 /* scan through all nearby squares for terrain to hide in */
3178 for (i = 0, x = ob->x, y = ob->y; i < 9; i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 3050 for (i = 0, x = ob->x, y = ob->y;
3051 i <= SIZEOFFREE1;
3052 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
3179 { 3053 {
3180 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 3054 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3181 if (mflag & P_OUT_OF_MAP) 3055 if (mflag & P_OUT_OF_MAP)
3182 {
3183 continue; 3056 continue;
3184 } 3057
3185 if (mflag & P_BLOCKSVIEW) /* something to hide near! */ 3058 if (mflag & P_BLOCKSVIEW) /* something to hide near! */
3186 level += 2; 3059 level += 2;
3187 else /* open terrain! */ 3060 else /* open terrain! */
3188 level -= 1; 3061 level -= 1;
3189 } 3062 }
… …
3197/* For Hidden creatures - a chance of becoming 'unhidden' 3070/* For Hidden creatures - a chance of becoming 'unhidden'
3198 * every time they move - as we subtract off 'invisibility' 3071 * every time they move - as we subtract off 'invisibility'
3199 * AND, for players, if they move into a ridiculously unhideable 3072 * AND, for players, if they move into a ridiculously unhideable
3200 * spot (surrounded by clear terrain in broad daylight). -b.t. 3073 * spot (surrounded by clear terrain in broad daylight). -b.t.
3201 */ 3074 */
3202
3203void 3075void
3204do_hidden_move (object *op) 3076do_hidden_move (object *op)
3205{ 3077{
3206 int hide = 0, num = random_roll (0, 19, op, PREFER_LOW); 3078 int hide = 0;
3207 object *skop;
3208 3079
3209 if (!op || !op->map) 3080 if (!op || !op->map)
3210 return; 3081 return;
3211 3082
3212 skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING); 3083 object *skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING);
3084 int num = random_roll (0, 19, op, PREFER_LOW);
3213 3085
3214 /* its *extremely* hard to run and sneak/hide at the same time! */ 3086 /* its *extremely* hard to run and sneak/hide at the same time! */
3215 if (op->type == PLAYER && op->contr->run_on) 3087 if (op->type == PLAYER && op->contr->run_on)
3216 {
3217 if (!skop || num >= skop->level) 3088 if (!skop || num >= skop->level)
3218 { 3089 {
3219 new_draw_info (NDI_UNIQUE, 0, op, "You ran too much! You are no longer hidden!"); 3090 new_draw_info (NDI_UNIQUE, 0, op, "You ran too much! You are no longer hidden!");
3220 make_visible (op); 3091 make_visible (op);
3221 return; 3092 return;
3222 } 3093 }
3223 else 3094 else
3224 num += 20; 3095 num += 20;
3225 } 3096
3226 num += op->map->difficulty; 3097 num += op->map->difficulty;
3227 hide = hideability (op); /* modify by terrain hidden level */ 3098 hide = hideability (op); /* modify by terrain hidden level */
3228 num -= hide; 3099 num -= hide;
3100
3229 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0)) 3101 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0))
3230 { 3102 {
3231 make_visible (op); 3103 make_visible (op);
3104
3232 if (op->type == PLAYER) 3105 if (op->type == PLAYER)
3233 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!"); 3106 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!");
3234 } 3107 }
3235 else if (op->type == PLAYER && skop) 3108 else if (op->type == PLAYER && skop)
3236 {
3237 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0); 3109 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0);
3238 }
3239} 3110}
3240 3111
3241/* determine if who is standing near a hostile creature. */ 3112/* determine if who is standing near a hostile creature. */
3242 3113
3243int 3114int
… …
3291 * object op. This function works fine for monsters, 3162 * object op. This function works fine for monsters,
3292 * but we dont worry if the object isnt the top one in 3163 * but we dont worry if the object isnt the top one in
3293 * a pile (say a coin under a table would return "viewable" 3164 * a pile (say a coin under a table would return "viewable"
3294 * by this routine). Another question, should we be 3165 * by this routine). Another question, should we be
3295 * concerned with the direction the player is looking 3166 * concerned with the direction the player is looking
3296 * in? Realistically, most of use cant see stuff behind 3167 * in? Realistically, most of us can't see stuff behind
3297 * our backs...on the other hand, does the "facing" direction 3168 * our backs...on the other hand, does the "facing" direction
3298 * imply the way your head, or body is facing? Its possible 3169 * imply the way your head, or body is facing? It's possible
3299 * for them to differ. Sigh, this fctn could get a bit more complex. 3170 * for them to differ. Sigh, this fctn could get a bit more complex.
3300 * -b.t. 3171 * -b.t.
3301 * This function is now map tiling safe. 3172 * This function is now map tiling safe.
3302 */ 3173 */
3303
3304int 3174int
3305player_can_view (object *pl, object *op) 3175player_can_view (object *pl, object *op)
3306{ 3176{
3307 rv_vector rv; 3177 rv_vector rv;
3308 int dx, dy; 3178 int dx, dy;
… …
3310 if (pl->type != PLAYER) 3180 if (pl->type != PLAYER)
3311 { 3181 {
3312 LOG (llevError, "player_can_view() called for non-player object\n"); 3182 LOG (llevError, "player_can_view() called for non-player object\n");
3313 return -1; 3183 return -1;
3314 } 3184 }
3185
3315 if (!pl || !op) 3186 if (!pl || !op)
3316 return 0; 3187 return 0;
3317 3188
3318 if (op->head)
3319 {
3320 op = op->head; 3189 op = op->head_ ();
3321 } 3190
3322 get_rangevector (pl, op, &rv, 0x1); 3191 get_rangevector (pl, op, &rv, 0x1);
3323 3192
3324 /* starting with the 'head' part, lets loop 3193 /* starting with the 'head' part, lets loop
3325 * through the object and find if it has any 3194 * through the object and find if it has any
3326 * part that is in the los array but isnt on 3195 * part that is in the los array but isn't on
3327 * a blocked los square. 3196 * a blocked los square.
3328 * we use the archetype to figure out offsets. 3197 * we use the archetype to figure out offsets.
3329 */ 3198 */
3330 while (op) 3199 while (op)
3331 { 3200 {
3332 dx = rv.distance_x + op->arch->clone.x; 3201 dx = rv.distance_x + op->arch->x;
3333 dy = rv.distance_y + op->arch->clone.y; 3202 dy = rv.distance_y + op->arch->y;
3334 3203
3335 /* only the viewable area the player sees is updated by LOS 3204 /* only the viewable area the player sees is updated by LOS
3336 * code, so we need to restrict ourselves to that range of values 3205 * code, so we need to restrict ourselves to that range of values
3337 * for any meaningful values. 3206 * for any meaningful values.
3338 */ 3207 */
3339 if (FABS (dx) <= (pl->contr->ns->mapx / 2) && 3208 if (abs (dx) <= (pl->contr->ns->mapx / 2) &&
3340 FABS (dy) <= (pl->contr->ns->mapy / 2) && 3209 abs (dy) <= (pl->contr->ns->mapy / 2) &&
3341 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)]) 3210 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3342 return 1; 3211 return 1;
3212
3343 op = op->more; 3213 op = op->more;
3344 } 3214 }
3215
3345 return 0; 3216 return 0;
3346} 3217}
3347 3218
3348/* routine for both players and monsters. We call this when 3219/* routine for both players and monsters. We call this when
3349 * there is a possibility for our action distrubing our hiding 3220 * there is a possibility for our action distrubing our hiding
… …
3352 * return 0. 3223 * return 0.
3353 */ 3224 */
3354int 3225int
3355action_makes_visible (object *op) 3226action_makes_visible (object *op)
3356{ 3227{
3357
3358 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE)) 3228 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3359 { 3229 {
3360 if (QUERY_FLAG (op, FLAG_MAKE_INVIS)) 3230 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3361 return 0; 3231 return 0;
3362 3232
… …
3368 { 3238 {
3369 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible"); 3239 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible");
3370 return 1; 3240 return 1;
3371 } 3241 }
3372 } 3242 }
3243
3373 return 0; 3244 return 0;
3374} 3245}
3375 3246
3376/* op_on_battleground - checks if the given object op (usually 3247/* op_on_battleground - checks if the given object op (usually
3377 * a player) is standing on a valid battleground-tile, 3248 * a player) is standing on a valid battleground-tile,
… …
3382 * Default is to do the same as before, so only people wanting to have different points need worry about this 3253 * Default is to do the same as before, so only people wanting to have different points need worry about this
3383 */ 3254 */
3384int 3255int
3385op_on_battleground (object *op, int *x, int *y) 3256op_on_battleground (object *op, int *x, int *y)
3386{ 3257{
3387 object *tmp;
3388
3389 /* A battleground-tile needs the following attributes to be valid: 3258 /* A battleground-tile needs the following attributes to be valid:
3390 * is_floor 1 (has to be the FIRST floor beneath the player's feet), 3259 * is_floor 1 (has to be the FIRST floor beneath the player's feet),
3391 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND) 3260 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND)
3392 * and the exit-coordinates sp/hp must both be > 0. 3261 * and the exit-coordinates sp/hp must both be > 0.
3393 * => The intention here is to prevent abuse of the battleground- 3262 * => The intention here is to prevent abuse of the battleground-
3394 * feature (like pickable or hidden battleground tiles). */ 3263 * feature (like pickable or hidden battleground tiles). */
3395 for (tmp = op->below; tmp != NULL; tmp = tmp->below) 3264 for (object *tmp = op->below; tmp; tmp = tmp->below)
3396 { 3265 {
3397 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3266 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
3398 { 3267 {
3399 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && 3268 if (QUERY_FLAG (tmp, FLAG_NO_PICK)
3400 strcmp (tmp->name, "battleground") == 0 && tmp->type == BATTLEGROUND && EXIT_X (tmp) && EXIT_Y (tmp)) 3269 && tmp->type == BATTLEGROUND
3270 && tmp->name == shstr_battleground
3271 && EXIT_X (tmp) && EXIT_Y (tmp))
3401 { 3272 {
3402 /*before we assign the exit, check if this is a teambattle */ 3273 /* before we assign the exit, check if this is a teambattle */
3403 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3274 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3404 { 3275 {
3405 object *invtmp;
3406
3407 for (invtmp = op->inv; invtmp != NULL; invtmp = invtmp->below) 3276 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3408 { 3277 {
3409 if (invtmp->type == FORCE && invtmp->slaying && !strcmp (EXIT_PATH (tmp), invtmp->slaying)) 3278 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3410 { 3279 {
3411 if (x != NULL && y != NULL) 3280 if (x && y)
3412 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3281 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3282
3413 return 1; 3283 return 1;
3414 } 3284 }
3415 } 3285 }
3416 } 3286 }
3287
3417 if (x != NULL && y != NULL) 3288 if (x && y)
3418 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3289 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3290
3419 return 1; 3291 return 1;
3420 } 3292 }
3421 } 3293 }
3422 } 3294 }
3295
3423 /* If we got here, did not find a battleground */ 3296 /* If we got here, did not find a battleground */
3424 return 0; 3297 return 0;
3425} 3298}
3426 3299
3427/* 3300/*
… …
3443 char buf[MAX_BUF]; /* tmp. string buffer */ 3316 char buf[MAX_BUF]; /* tmp. string buffer */
3444 int i = 0, j = 0; 3317 int i = 0, j = 0;
3445 3318
3446 /* get the appropriate treasurelist */ 3319 /* get the appropriate treasurelist */
3447 if (atnr == ATNR_FIRE) 3320 if (atnr == ATNR_FIRE)
3448 trlist = find_treasurelist ("dragon_ability_fire"); 3321 trlist = treasurelist::find (shstr_dragon_ability_fire);
3449 else if (atnr == ATNR_COLD) 3322 else if (atnr == ATNR_COLD)
3450 trlist = find_treasurelist ("dragon_ability_cold"); 3323 trlist = treasurelist::find (shstr_dragon_ability_cold);
3451 else if (atnr == ATNR_ELECTRICITY) 3324 else if (atnr == ATNR_ELECTRICITY)
3452 trlist = find_treasurelist ("dragon_ability_elec"); 3325 trlist = treasurelist::find (shstr_dragon_ability_elec);
3453 else if (atnr == ATNR_POISON) 3326 else if (atnr == ATNR_POISON)
3454 trlist = find_treasurelist ("dragon_ability_poison"); 3327 trlist = treasurelist::find (shstr_dragon_ability_poison);
3455 3328
3456 if (trlist == NULL || who->type != PLAYER) 3329 if (trlist == NULL || who->type != PLAYER)
3457 return; 3330 return;
3458 3331
3459 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++); 3332 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++);
3460 3333
3461 if (tr == NULL || tr->item == NULL) 3334 if (!tr || !tr->item)
3462 { 3335 {
3463 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */ 3336 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */
3464 return; 3337 return;
3465 } 3338 }
3466 3339
3467 /* everything seems okay - now bring on the gift: */ 3340 /* everything seems okay - now bring on the gift: */
3468 item = &(tr->item->clone); 3341 item = tr->item;
3469 3342
3470 if (item->type == SPELL) 3343 if (item->type == SPELL)
3471 { 3344 {
3472 if (check_spell_known (who, item->name)) 3345 if (check_spell_known (who, item->name))
3473 return; 3346 return;
… …
3532 { 3405 {
3533 /* forces in the treasurelist can alter the player's stats */ 3406 /* forces in the treasurelist can alter the player's stats */
3534 object *skin; 3407 object *skin;
3535 3408
3536 /* first get the dragon skin force */ 3409 /* first get the dragon skin force */
3537 shstr_cmp dragon_skin_force ("dragon_skin_force");
3538 for (skin = who->inv; skin && !(skin->arch->name == dragon_skin_force); skin = skin->below) 3410 for (skin = who->inv; skin && !(skin->arch->archname == shstr_dragon_skin_force); skin = skin->below)
3539 ; 3411 ;
3540 3412
3541 if (!skin) 3413 if (!skin)
3542 return; 3414 return;
3543 3415
… …
3578 else 3450 else
3579 { 3451 {
3580 /* generate misc. treasure */ 3452 /* generate misc. treasure */
3581 tmp = arch_to_object (tr->item); 3453 tmp = arch_to_object (tr->item);
3582 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3454 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3583 tmp = insert_ob_in_ob (tmp, who); 3455 who->insert (tmp);
3584 if (who->type == PLAYER)
3585 esrv_send_item (who, tmp);
3586 } 3456 }
3587} 3457}
3588 3458
3589/** 3459/**
3590 * Unready an object for a player. This function does nothing if the object was 3460 * Unready an object for a player. This function does nothing if the object was
3591 * not readied. 3461 * not readied.
3592 */ 3462 */
3593void 3463void
3594player_unready_range_ob (player *pl, object *ob) 3464player_unready_range_ob (player *pl, object *ob)
3595{ 3465{
3596 rangetype i; 3466 if (pl->ob->current_weapon == ob)
3467 pl->ob->current_weapon = 0;
3597 3468
3598 for (i = (rangetype) 0; i < range_size; i = (rangetype) ((int) i + 1)) 3469 if (pl->combat_ob == ob)
3599 { 3470 pl->combat_ob = 0;
3471
3600 if (pl->ranges[i] == ob) 3472 if (pl->ranged_ob == ob)
3601 { 3473 pl->ranged_ob = 0;
3602 pl->ranges[i] = NULL;
3603 if (pl->shoottype == i)
3604 {
3605 pl->shoottype = range_none;
3606 }
3607 }
3608 }
3609} 3474}
3475
3476sint8
3477player::visibility_at (maptile *map, int x, int y) const
3478{
3479 if (!ns)
3480 return 0;
3481
3482 int dx, dy;
3483 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3484 return 0;
3485
3486 x += dx - ns->current_x + ns->mapx / 2;
3487 y += dy - ns->current_y + ns->mapy / 2;
3488
3489 if (!IN_RANGE_EXC (x, 0, ns->mapx) || !IN_RANGE_EXC (y, 0, ns->mapy))
3490 return 0;
3491
3492 return 100 - blocked_los [x][y];
3493}
3494
3495void
3496player::infobox (const char *title, const char *msg, int color)
3497{
3498 send_msg (color | NDI_DEF | NDI_REPLY | NDI_CLEAR, title, msg);
3499}
3500
3501void
3502player::statusmsg (const char *msg, int color)
3503{
3504 send_msg (color | NDI_REPLY, INFO_CHANNEL, msg);
3505}
3506
3507void
3508player::failmsg (const char *msg, int color)
3509{
3510 play_sound (sound_find ("generic_failure"));
3511 statusmsg (msg, color);
3512}
3513

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines