ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.209 by root, Thu Dec 18 05:13:38 2008 UTC vs.
Revision 1.300 by root, Sat Sep 16 22:17:42 2017 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
24
25//+GPL
26
27#include <algorithm>
28#include <functional>
23 29
24#include <global.h> 30#include <global.h>
25#include <sproto.h> 31#include <sproto.h>
26#include <sounds.h> 32#include <sounds.h>
27#include <living.h> 33#include <living.h>
28#include <object.h> 34#include <object.h>
29#include <spells.h> 35#include <spells.h>
30#include <skills.h> 36#include <skills.h>
31 37
32#include <algorithm>
33#include <functional>
34
35playervec players; 38playervec players;
36
37void
38display_motd (const object *op)
39{
40 char buf[MAX_BUF];
41 char motd[HUGE_BUF];
42 FILE *fp;
43 int comp;
44 int size;
45
46 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
47 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
48 return;
49
50 motd[0] = '\0';
51 size = 0;
52
53 while (fgets (buf, MAX_BUF, fp))
54 {
55 if (*buf == '#')
56 continue;
57
58 strncat (motd + size, buf, HUGE_BUF - size);
59 size += strlen (buf);
60 }
61
62 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
63 close_and_delete (fp, comp);
64}
65
66void
67send_rules (const object *op)
68{
69 char buf[MAX_BUF];
70 char rules[HUGE_BUF];
71 FILE *fp;
72 int comp;
73 int size;
74
75 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
76 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
77 return;
78
79 rules[0] = '\0';
80 size = 0;
81
82 while (fgets (buf, MAX_BUF, fp))
83 {
84 if (*buf == '#')
85 continue;
86
87 if (size + strlen (buf) >= HUGE_BUF)
88 {
89 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
90 break;
91 }
92
93 strncat (rules + size, buf, HUGE_BUF - size);
94 size += strlen (buf);
95 }
96
97 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
98 close_and_delete (fp, comp);
99}
100
101void
102send_news (const object *op)
103{
104 char buf[MAX_BUF];
105 char news[HUGE_BUF];
106 char subject[MAX_BUF];
107 FILE *fp;
108 int comp;
109 int size;
110
111 sprintf (buf, "%s/%s", settings.confdir, settings.news);
112 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
113 return;
114
115 news[0] = '\0';
116 subject[0] = '\0';
117 size = 0;
118
119 while (fgets (buf, MAX_BUF, fp))
120 {
121 if (*buf == '#')
122 continue;
123
124 if (*buf == '%')
125 { /* send one news */
126 if (size > 0)
127 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
128 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS,
129 "INFORMATION: %s\n%s", (char *)"%s\n%s",
130 subject, news); /*send previously read news */
131
132 strcpy (subject, buf + 1);
133 strip_endline (subject);
134 size = 0;
135 news[0] = '\0';
136 }
137 else
138 {
139 if (size + strlen (buf) >= HUGE_BUF)
140 {
141 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
142 break;
143 }
144 strncat (news + size, buf, HUGE_BUF - size);
145 size += strlen (buf);
146 }
147 }
148
149 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
150 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", (char *)"%s\n%s", subject, news);
151 close_and_delete (fp, comp);
152}
153 39
154/* This loads the first map an puts the player on it. */ 40/* This loads the first map an puts the player on it. */
155static void 41static void
156set_first_map (object *op) 42set_first_map (object *op)
157{ 43{
168 54
169 players.insert (this); 55 players.insert (this);
170 ob->remove (); 56 ob->remove ();
171 ob->map = 0; 57 ob->map = 0;
172 ob->activate_recursive (); 58 ob->activate_recursive ();
173 CLEAR_FLAG (ob, FLAG_FRIENDLY); 59 ob->clr_flag (FLAG_FRIENDLY);
174 add_friendly_object (ob); 60 add_friendly_object (ob);
175} 61}
176 62
177void 63void
178player::deactivate () 64player::deactivate ()
190 ob->remove (); 76 ob->remove ();
191 ob->enemy = 0; // sometimes keeps an extra refcount on itself 77 ob->enemy = 0; // sometimes keeps an extra refcount on itself
192 ob->map = 0; 78 ob->map = 0;
193 party = 0; 79 party = 0;
194 80
195 combat_ob = ranged_ob = 0; //TODO, should be special marker, non-refcounted, not this
196
197 players.erase (this); 81 players.erase (this);
198} 82}
199 83
200// connect the player with a specific client 84// connect the player with a specific client
201// also changes, rationalises, and fixes some incorrect settings 85// also changes, rationalises, and fixes some incorrect settings
210 ob->close_container (); //TODO: client-specific 94 ob->close_container (); //TODO: client-specific
211 95
212 ns->update_look = 0; 96 ns->update_look = 0;
213 ns->look_position = 0; 97 ns->look_position = 0;
214 98
215 clear_los (this); 99 clear_los ();
216 100
217 ns->reset_stats (); 101 ns->reset_stats ();
218 102
219 /* make sure he's a player -- needed because of class change. */ 103 /* make sure he's a player -- needed because of class change. */
220 ob->type = PLAYER; // we are paranoid 104 ob->type = PLAYER; // we are paranoid
221 ob->race = ob->arch->race; 105 ob->race = ob->arch->race;
222 106
223 ob->update_weight (); 107 ob->update_weight ();
224 link_skills (); 108 link_skills ();
225 109
226 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
227
228 assign (title, ob->arch->object::name); 110 assign (title, ob->arch->object::name);
229 111
230 /* if it's a dragon player, set the correct title here */ 112 /* if it's a dragon player, set the correct title here */
231 if (is_dragon_pl (ob)) 113 if (ob->is_dragon ())
232 { 114 {
233 object *tmp, *abil = 0, *skin = 0; 115 object *tmp, *abil = 0, *skin = 0;
234 116
235 for (tmp = ob->inv; tmp; tmp = tmp->below) 117 for (tmp = ob->inv; tmp; tmp = tmp->below)
236 if (tmp->type == FORCE) 118 if (tmp->type == FORCE)
244 126
245 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 127 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
246 128
247 esrv_new_player (this); 129 esrv_new_player (this);
248 130
131 ob->flag [FLAG_READY_WEAPON] = false;
132 ob->flag [FLAG_READY_SKILL] = false;
133 ob->flag [FLAG_READY_RANGE] = false;
134 ob->flag [FLAG_READY_BOW] = false;
135
249 ob->update_stats (); 136 ob->update_stats ();
250 137
251 ns->floorbox_update (); 138 ns->floorbox_update ();
252 esrv_send_inventory (ob, ob); 139 esrv_send_inventory (ob, ob);
253 esrv_add_spells (this, 0); 140 esrv_add_spells (this, 0);
254 141
255 activate (); 142 activate ();
256 143
257 send_rules (ob);
258 send_news (ob);
259 display_motd (ob);
260
261 INVOKE_PLAYER (CONNECT, this); 144 INVOKE_PLAYER (CONNECT, this);
262 INVOKE_PLAYER (LOGIN, this); 145 INVOKE_PLAYER (LOGIN, this);
263} 146}
264 147
265void 148void
281 ns->reset_stats (); 164 ns->reset_stats ();
282 ns->pl = 0; 165 ns->pl = 0;
283 ns = 0; 166 ns = 0;
284 } 167 }
285 168
286 observe = ob; 169 // this is important for the player scheduler to get the correct refcount
170 // when ns = 0
171 observe = viewpoint = ob;
287 172
288 deactivate (); 173 deactivate ();
289} 174}
175
176//-GPL
290 177
291// the need for this function can be explained 178// the need for this function can be explained
292// by load_object not returning the object 179// by load_object not returning the object
293void 180void
294player::set_object (object *op) 181player::set_object (object *op)
295{ 182{
296 ob = observe = op; 183 ob = observe = viewpoint = op;
297 ob->contr = this; /* this aren't yet in archetype */ 184 ob->contr = this; /* this aren't yet in archetype */
298 185
299 ob->speed = 1.0f; 186 ob->speed = 1.0f; // object still inactive, keep it that way
300 ob->speed_left = 0.5f; 187 ob->speed_left = 0.5f;
301 188
302 ob->direction = 5; /* So player faces south */ 189 ob->direction = 5; /* So player faces south */
303
304 ob->flag [FLAG_READY_WEAPON] = false;
305 ob->flag [FLAG_READY_SKILL] = false;
306 ob->flag [FLAG_READY_BOW] = false;
307
308 for (object *op = ob->inv; op; op = op->below)
309 if (op->flag [FLAG_APPLIED])
310 switch (op->type)
311 {
312 case SKILL:
313 ob->flag [FLAG_APPLIED] = false;
314 break;
315
316 case WAND:
317 case ROD:
318 case HORN:
319 case BOW:
320 ranged_ob = op;
321 break;
322
323 case WEAPON:
324 combat_ob = op;
325 break;
326 }
327
328 ob->change_weapon (combat_ob ? combat_ob : ranged_ob);
329 ob->deactivate (); // change_weapon activates, fix this better
330} 190}
331 191
332void 192void
333player::set_observe (object *op) 193player::set_observe (object *op)
334{ 194{
335 observe = op ? op : ob; 195 observe = viewpoint = op ? op : ob;
336 do_los = 1; 196 do_los = 1;
337} 197}
198
199void
200player::set_viewpoint (object *op)
201{
202 viewpoint = op ? op : (object *)observe;
203 do_los = 1;
204}
205
206//+GPL
338 207
339player::player () 208player::player ()
340{ 209{
341 /* There are some elements we want initialised to non zero value - 210 /* There are some elements we want initialised to non zero value -
342 * we deal with that below this point. 211 * we deal with that below this point.
365 234
366 attachable::do_destroy (); 235 attachable::do_destroy ();
367 236
368 if (ob) 237 if (ob)
369 { 238 {
370 ob->destroy_inv (false); 239 // potentially fix a bug where ob->contr is non-null while ob->contr->ob is null, causing a segfault.
240 // temporarily backed out patchset 4025 to see if THIS change causes crashes
241 //ob->contr = 0;
371 ob->destroy (); 242 ob->destroy ();
372 } 243 }
373 244
374 ob = observe = 0; 245 ob = observe = viewpoint = 0;
375} 246}
376 247
377player::~player () 248player::~player ()
378{ 249{
379 /* Clear item stack */ 250 /* Clear item stack */
380 free (stack_items); 251 free (stack_items);
252}
253
254/*
255 * get_player_archetype() return next player archetype from archetype
256 * list. Not very efficient routine, but used only creating new players.
257 * Note: there MUST be at least one player archetype!
258 */
259static archetype *
260get_player_archetype (archetype *at)
261{
262 // archetypes could have been reloaded
263 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
264
265 if (!nat)
266 return at;
267
268 archvec::iterator i = archetypes.find (nat);
269
270 for (;;)
271 {
272 if (++i == archetypes.end ())
273 i = archetypes.begin ();
274 else if (*i == at)
275 cleanup ("not a single player archetype found");
276
277 if ((*i)->type == PLAYER)
278 return *i;
279 }
381} 280}
382 281
383/* Tries to add player on the connection passed in ns. 282/* Tries to add player on the connection passed in ns.
384 * All we can really get in this is some settings like host and display 283 * All we can really get in this is some settings like host and display
385 * mode. 284 * mode.
387player * 286player *
388player::create () 287player::create ()
389{ 288{
390 player *pl = new player; 289 player *pl = new player;
391 290
392 pl->set_object (arch_to_object (get_player_archetype (0))); 291 pl->set_object (get_player_archetype (0)->instance ());
393 292
394 pl->ob->roll_stats (); 293 pl->ob->roll_stats ();
395 pl->ob->stats.wc = 2; 294 pl->ob->stats.wc = 2;
396 pl->ob->run_away = 25; /* Then we panick... */ 295 pl->ob->run_away = 25; /* Then we panick... */
397 296
398 set_first_map (pl->ob); 297 set_first_map (pl->ob);
399 298
400 return pl; 299 return pl;
401}
402
403/*
404 * get_player_archetype() return next player archetype from archetype
405 * list. Not very efficient routine, but used only creating new players.
406 * Note: there MUST be at least one player archetype!
407 */
408archetype *
409get_player_archetype (archetype *at)
410{
411 // archetypes could have been reloaded
412 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
413
414 if (!nat)
415 return at;
416
417 archvec::iterator i = archetypes.find (nat);
418
419 for (;;)
420 {
421 if (++i == archetypes.end ())
422 i = archetypes.begin ();
423 else if (*i == at)
424 cleanup ("not a single player archetype found");
425
426 if ((*i)->type == PLAYER)
427 return *i;
428 }
429} 300}
430 301
431object * 302object *
432get_nearest_player (object *mon) 303get_nearest_player (object *mon)
433{ 304{
461#endif 332#endif
462 return op; 333 return op;
463} 334}
464 335
465/* I believe this can safely go to 2, 3 is questionable, 4 will likely 336/* I believe this can safely go to 2, 3 is questionable, 4 will likely
466 * result in a monster paths backtracking. It basically determines how large a 337 * result in a monster paths backtracking. It basically determines how large a
467 * detour a monster will take from the direction path when looking 338 * detour a monster will take from the direction path when looking
468 * for a path to the player. The values are in the amount of direction 339 * for a path to the player. The values are in the amount of direction
469 * the deviation is 340 * the deviation is
470 */ 341 */
471#define DETOUR_AMOUNT 2 342#define DETOUR_AMOUNT 2
507 */ 378 */
508int 379int
509path_to_player (object *mon, object *pl, unsigned mindiff) 380path_to_player (object *mon, object *pl, unsigned mindiff)
510{ 381{
511 rv_vector rv; 382 rv_vector rv;
512 sint16 x, y;
513 int lastx, lasty, dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES, mflags, blocked; 383 int dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES;
514 maptile *m, *lastmap;
515 384
516 get_rangevector (mon, pl, &rv, 0); 385 get_rangevector (mon, pl, &rv, 0);
517 386
518 if (rv.distance < mindiff) 387 if (rv.distance < mindiff)
519 return 0; 388 return 0;
520 389
521 x = mon->x; 390 mapxy pos (mon);
522 y = mon->y;
523 m = mon->map;
524 dir = rv.direction; 391 dir = rv.direction;
525 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 392 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
526 diff = ::max (abs (rv.distance_x), abs (rv.distance_y)); 393 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
527 394
528 /* If we can't solve it within the search distance, return now. */ 395 /* If we can't solve it within the search distance, return now. */
529 if (diff > max) 396 if (diff > max)
530 return 0; 397 return 0;
531 398
532 while (diff > 1 && max > 0) 399 while (diff > 1 && max > 0)
533 { 400 {
534 lastx = x; 401 mapxy lastpos = pos;
535 lasty = y;
536 lastmap = m;
537 x = lastx + freearr_x[dir];
538 y = lasty + freearr_y[dir];
539 402
540 mflags = get_map_flags (m, &m, x, y, &x, &y); 403 pos.move (dir);
541 blocked = (mflags & P_OUT_OF_MAP) ? MOVE_ALL : GET_MAP_MOVE_BLOCK (m, x, y);
542 404
543 /* Space is blocked - try changing direction a little */ 405 /* Space is blocked - try changing direction a little */
544 if ((mflags & P_OUT_OF_MAP) || ((OB_TYPE_MOVE_BLOCK (mon, blocked) || (mflags & P_BLOCKSVIEW)) 406 if (!pos.normalise ()
545 && (m == mon->map && blocked_link (mon, m, x, y)))) 407 || (((pos->flags () & P_BLOCKSVIEW) || OB_TYPE_MOVE_BLOCK (mon, pos->move_block))
408 && blocked_link (mon, pos.m, pos.x, pos.y)))
546 { 409 {
547 /* recalculate direction from last good location. Possible 410 /* recalculate direction from last good location. Possible
548 * we were not traversing ideal location before. 411 * we were not traversing ideal location before.
549 */ 412 */
550 get_rangevector_from_mapcoord (lastmap, lastx, lasty, pl, &rv, 0); 413 get_rangevector_from_mapcoord (lastpos.m, lastpos.x, lastpos.y, pl, &rv, 0);
551 if (rv.direction != dir) 414 if (rv.direction != dir)
552 { 415 {
553 /* OK - says direction should be different - lets reset the 416 /* OK - says direction should be different - lets reset the
554 * the values so it will try again. 417 * the values so it will try again.
555 */ 418 */
556 x = lastx;
557 y = lasty;
558 m = lastmap; 419 pos = lastpos;
559 dir = firstdir = rv.direction; 420 dir = firstdir = rv.direction;
560 } 421 }
561 else 422 else
562 { 423 {
563 /* direct path is blocked - try taking a side step to 424 /* direct path is blocked - try taking a side step to
564 * either the left or right. 425 * either the left or right.
565 * Note increase the values in the loop below to be 426 * Note increase the values in the loop below to be
566 * more than -1/1 respectively will mean the monster takes 427 * more than -1/1 respectively will mean the monster takes
567 * bigger detour. Have to be careful about these values getting 428 * bigger detour. Have to be careful about these values getting
568 * too big (3 or maybe 4 or higher) as the monster may just try 429 * too big (3 or maybe 4 or higher) as the monster may just try
569 * stepping back and forth 430 * stepping back and forth
570 */ 431 */
571 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++) 432 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++)
572 { 433 {
573 if (i == 0) 434 if (i == 0)
574 continue; /* already did this, so skip it */ 435 continue; /* already did this, so skip it */
436
575 /* Use lastdir here - otherwise, 437 /* Use lastdir here - otherwise,
576 * since the direction that the creature should move in 438 * since the direction that the creature should move in
577 * may change, you could get infinite loops. 439 * may change, you could get infinite loops.
578 * ie, player is northwest, but monster can only 440 * ie, player is northwest, but monster can only
579 * move west, so it does that. It goes some distance, 441 * move west, so it does that. It goes some distance,
581 * can't do that, but now finds it can move east, and 443 * can't do that, but now finds it can move east, and
582 * gets back to its original point. lastdir contains 444 * gets back to its original point. lastdir contains
583 * the last direction the creature has successfully 445 * the last direction the creature has successfully
584 * moved. 446 * moved.
585 */ 447 */
586
587 x = lastx + freearr_x[absdir (lastdir + i)];
588 y = lasty + freearr_y[absdir (lastdir + i)];
589 m = lastmap; 448 pos = lastpos;
590 mflags = get_map_flags (m, &m, x, y, &x, &y); 449 pos.move (absdir (lastdir + i));
591 if (mflags & P_OUT_OF_MAP) 450
451 if (!pos.normalise ())
592 continue; 452 continue;
593 blocked = GET_MAP_MOVE_BLOCK (m, x, y); 453
594 if (OB_TYPE_MOVE_BLOCK (mon, blocked)) 454 mapspace &ms = *pos;
455
456 if (ms.flags () & P_BLOCKSVIEW)
595 continue; 457 continue;
596 if (mflags & P_BLOCKSVIEW) 458
459 if (OB_TYPE_MOVE_BLOCK (mon, ms.move_block))
597 continue; 460 continue;
598 461
599 if (m == mon->map && blocked_link (mon, m, x, y)) 462 if (blocked_link (mon, pos.m, pos.x, pos.y))
600 break; 463 break;
601 } 464 }
465
602 /* go through entire loop without finding a valid 466 /* go through entire loop without finding a valid
603 * sidestep to take - thus, no valid path. 467 * sidestep to take - thus, no valid path.
604 */ 468 */
605 if (i == (DETOUR_AMOUNT + 1)) 469 if (i == DETOUR_AMOUNT + 1)
606 return 0; 470 return 0;
471
607 diff--; 472 diff--;
608 lastdir = dir; 473 lastdir = dir;
609 max--; 474 max--;
610 if (!firstdir) 475 if (!firstdir)
611 firstdir = dir + i; 476 firstdir = dir + i;
615 { 480 {
616 /* we moved towards creature, so diff is less */ 481 /* we moved towards creature, so diff is less */
617 diff--; 482 diff--;
618 max--; 483 max--;
619 lastdir = dir; 484 lastdir = dir;
485
620 if (!firstdir) 486 if (!firstdir)
621 firstdir = dir; 487 firstdir = dir;
622 } 488 }
623 489
624 if (diff <= 1) 490 if (diff <= 1)
625 { 491 {
626 /* Recalculate diff (distance) because we may not have actually 492 /* Recalculate diff (distance) because we may not have actually
627 * headed toward player for entire distance. 493 * headed toward player for entire distance.
628 */ 494 */
629 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 495 get_rangevector_from_mapcoord (pos.m, pos.x, pos.y, pl, &rv, 0);
630 diff = ::max (abs (rv.distance_x), abs (rv.distance_y)); 496 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
631 } 497 }
632 498
633 if (diff > max) 499 if (diff > max)
634 return 0; 500 return 0;
650 for (object *next, *op = pl->inv; op; op = next) 516 for (object *next, *op = pl->inv; op; op = next)
651 { 517 {
652 next = op->below; 518 next = op->below;
653 519
654 /* Forces get applied per default, unless they have the 520 /* Forces get applied per default, unless they have the
655 * flag "neutral" set. Sorry but I can't think of a better way 521 * flag "neutral" set. Sorry but I can't think of a better way
656 */ 522 */
657 if (op->type == FORCE && !QUERY_FLAG (op, FLAG_NEUTRAL)) 523 if (op->type == FORCE && !op->flag [FLAG_NEUTRAL])
658 SET_FLAG (op, FLAG_APPLIED); 524 op->set_flag (FLAG_APPLIED);
659 525
660 /* we never give weapons/armour if these cannot be used 526 /* we never give weapons/armour if these cannot be used
661 * by this player due to race restrictions 527 * by this player due to race restrictions
662 */ 528 */
663 if (pl->type == PLAYER) 529 if (pl->type == PLAYER)
664 { 530 {
665 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) 531 if ((!pl->flag [FLAG_USE_ARMOUR]
666 && 532 &&
667 (op->type == ARMOUR || op->type == BOOTS 533 (op->type == ARMOUR || op->type == BOOTS
668 || op->type == CLOAK || op->type == HELMET 534 || op->type == CLOAK || op->type == HELMET
669 || op->type == SHIELD || op->type == GLOVES 535 || op->type == SHIELD || op->type == GLOVES
670 || op->type == BRACERS || op->type == GIRDLE)) 536 || op->type == BRACERS || op->type == GIRDLE))
671 || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 537 || (!pl->flag [FLAG_USE_WEAPON] && op->type == WEAPON))
672 { 538 {
673 op->destroy (); 539 op->destroy ();
674 continue; 540 continue;
675 } 541 }
676 } 542 }
677 543
678 /* This really needs to be better - we should really give 544 /* Here we remove duplicated skills (as duplicated spell objects have
679 * a substitute spellbook. The problem is that we don't really 545 * _very_ confusing effects for players), which could for instance be
680 * have a good idea what to replace it with (need something like 546 * generated by multiple treasurelists specifying the same skills.
681 * a first level treasurelist for each skill.)
682 * remove duplicate skills also
683 */ 547 */
684 if (op->type == SPELLBOOK || op->type == SKILL) 548 if (op->type == SKILL)
685 { 549 {
686 object *tmp;
687
688 for (tmp = op->below; tmp; tmp = tmp->below) 550 for (object *tmp = op->below; tmp; tmp = tmp->below)
689 if (tmp->type == op->type && tmp->name == op->name) 551 if (tmp->type == op->type && tmp->name == op->name)
690 break;
691
692 if (tmp)
693 { 552 {
694 op->destroy (); 553 op->destroy ();
695 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 554 break;
696 continue;
697 } 555 }
698 556
699 if (op->nrof > 1) 557 if (op->nrof > 1)
700 op->nrof = 1; 558 op->nrof = 1;
701 } 559 }
702 560
703 if (op->type == SPELLBOOK && op->inv) 561 if (op->type == SPELLBOOK && op->inv)
704 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP); 562 op->inv->clr_flag (FLAG_STARTEQUIP);
705 563
706 /* Give starting characters identified, uncursed, and undamned 564 /* Give starting characters identified, uncursed, and undamned
707 * items. Just don't identify gold or silver, or it won't be 565 * items. Just don't identify gold or silver, or it won't be
708 * merged properly. 566 * merged properly.
709 */ 567 */
710 if (need_identify (op)) 568 if (op->need_identify ())
711 { 569 {
712 SET_FLAG (op, FLAG_IDENTIFIED); 570 op->set_flag (FLAG_IDENTIFIED);
713 CLEAR_FLAG (op, FLAG_CURSED); 571 op->clr_flag (FLAG_CURSED);
714 CLEAR_FLAG (op, FLAG_DAMNED); 572 op->clr_flag (FLAG_DAMNED);
715 } 573 }
716 574
717 if (op->type == SPELL) 575 if (op->type == SPELL)
718 { 576 {
719 op->destroy (); 577 op->destroy ();
720 continue; 578 continue;
721 } 579 }
722 else if (op->type == SKILL) 580 else if (op->type == SKILL)
723 { 581 {
724 SET_FLAG (op, FLAG_CAN_USE_SKILL); 582 op->set_flag (FLAG_CAN_USE_SKILL);
725 op->stats.exp = 0; 583 op->stats.exp = 0;
726 op->level = 1; 584 op->level = 1;
727 } 585 }
728 else /* lock all 'normal items by default */ 586 else /* lock all 'normal items by default */
729 SET_FLAG (op, FLAG_INV_LOCKED); 587 op->set_flag (FLAG_INV_LOCKED);
730 } /* for loop of objects in player inv */ 588 } /* for loop of objects in player inv */
731 589
732 /* Need to set up the skill pointers */ 590 /* Need to set up the skill pointers */
733 pl->contr->link_skills (); 591 pl->contr->link_skills ();
734} 592}
748 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:"); 606 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:");
749} 607}
750 608
751/* This rolls four 1-6 rolls and sums the best 3 of the 4. */ 609/* This rolls four 1-6 rolls and sums the best 3 of the 4. */
752static int 610static int
753roll_stat (void) 611roll_stat ()
754{ 612{
755 int a[4], i, j, k; 613 int a[4], i, j, k;
756 614
757 for (i = 0; i < 4; i++) 615 for (i = 0; i < 4; i++)
758 a[i] = (int) rndm (6) + 1; 616 a[i] = rndm (1, 6);
759 617
760 for (i = 0, j = 0, k = 7; i < 4; i++) 618 for (i = 0, j = 0, k = 7; i < 4; i++)
761 if (a[i] < k) 619 if (a[i] < k)
762 k = a[i], j = i; 620 k = a[i], j = i;
763 621
855player::chargen_race_done () 713player::chargen_race_done ()
856{ 714{
857 /* this must before then initial items are given */ 715 /* this must before then initial items are given */
858 esrv_new_player (ob->contr); 716 esrv_new_player (ob->contr);
859 717
860 treasurelist *tl = treasurelist::find ("starting_wealth"); 718 treasurelist *tl = treasurelist::find (shstr_starting_wealth);
861 if (tl) 719 if (tl)
862 create_treasure (tl, ob, 0, 0, 0); 720 create_treasure (tl, ob, 0, 0, 0);
863 721
864 INVOKE_PLAYER (BIRTH, ob->contr); 722 INVOKE_PLAYER (BIRTH, ob->contr);
865 INVOKE_PLAYER (LOGIN, ob->contr);
866 723
867 ob->contr->ns->state = ST_PLAYING; 724 ob->contr->ns->state = ST_PLAYING;
868 725
869 if (ob->msg) 726 if (ob->msg)
870 ob->msg = 0; 727 ob->msg = 0;
871 728
872 start_info (ob); 729 start_info (ob);
873 CLEAR_FLAG (ob, FLAG_WIZ); 730 ob->clr_flag (FLAG_WIZ);
874 give_initial_items (ob, ob->randomitems); 731 give_initial_items (ob, ob->randomitems);
875 esrv_send_inventory (ob, ob); 732 esrv_send_inventory (ob, ob);
876 ob->update_stats (); 733 ob->update_stats ();
877 734
878 /* This moves the player to a different start map, if there 735 /* This moves the player to a different start map, if there
880 */ 737 */
881 if (*first_map_ext_path) 738 if (*first_map_ext_path)
882 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y); 739 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
883 else 740 else
884 LOG (llevDebug, "first_map_ext_path not set\n"); 741 LOG (llevDebug, "first_map_ext_path not set\n");
742}
743
744/*
745 * Returns true if the given player is a legal class.
746 * The function to add and remove class-bonuses to the stats doesn't
747 * check if the stat becomes negative, thus this function
748 * merely checks that all stats are 1 or more, and returns
749 * false otherwise.
750 */
751static int
752allowed_class (const object *op)
753{
754 return op->stats.Dex > 0
755 && op->stats.Str > 0
756 && op->stats.Con > 0
757 && op->stats.Int > 0
758 && op->stats.Wis > 0
759 && op->stats.Pow > 0
760 && op->stats.Cha > 0;
885} 761}
886 762
887void 763void
888player::chargen_race_next () 764player::chargen_race_next ()
889{ 765{
918 ob->stats.hp = ob->stats.maxhp; 794 ob->stats.hp = ob->stats.maxhp;
919 ob->stats.sp = ob->stats.maxsp; 795 ob->stats.sp = ob->stats.maxsp;
920 ob->stats.grace = 0; 796 ob->stats.grace = 0;
921} 797}
922 798
923void 799static void
924flee_player (object *op) 800flee_player (object *op)
925{ 801{
926 int dir, diff; 802 int dir, diff;
927 rv_vector rv; 803 rv_vector rv;
928 804
929 if (op->stats.hp < 0) 805 if (op->stats.hp < 0)
930 { 806 {
931 LOG (llevDebug, "Fleeing player is dead.\n"); 807 LOG (llevDebug, "Fleeing player is dead.\n");
932 CLEAR_FLAG (op, FLAG_SCARED); 808 op->clr_flag (FLAG_SCARED);
933 return; 809 return;
934 } 810 }
935 811
936 if (op->enemy == NULL) 812 if (!op->enemy)
937 { 813 {
938 LOG (llevDebug, "Fleeing player had no enemy.\n"); 814 LOG (llevDebug, "Fleeing player had no enemy.\n");
939 CLEAR_FLAG (op, FLAG_SCARED); 815 op->clr_flag (FLAG_SCARED);
940 return; 816 return;
941 } 817 }
942 818
943 /* Seen some crashes here. Since we don't store an 819 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
944 * op->enemy_count, it is possible that something destroys the
945 * actual enemy, and the object is recycled.
946 */
947 if (op->enemy->map == NULL)
948 { 820 {
949 CLEAR_FLAG (op, FLAG_SCARED);
950 op->enemy = NULL; 821 op->enemy = NULL;
951 return; 822 op->clr_flag (FLAG_SCARED);
952 }
953
954 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
955 {
956 op->enemy = NULL;
957 CLEAR_FLAG (op, FLAG_SCARED);
958 return; 823 return;
959 } 824 }
960 825
961 get_rangevector (op, op->enemy, &rv, 0); 826 get_rangevector (op, op->enemy, &rv, 0);
962 827
963 dir = absdir (4 + rv.direction); 828 dir = absdir (4 + rv.direction);
964 for (diff = 0; diff < 3; diff++) 829 for (diff = 0; diff < 3; diff++)
965 { 830 {
966 int m = 1 - (RANDOM () & 2); 831 int m = 1 - rndm (2) * 2;
967 832
968 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 833 if (op->move (absdir (dir + diff * m)) || (diff == 0 && op->move (absdir (dir - diff * m))))
969 return; 834 return;
970 } 835 }
971 836
972 /* Cornered, get rid of scared */ 837 /* Cornered, get rid of scared */
973 CLEAR_FLAG (op, FLAG_SCARED); 838 op->clr_flag (FLAG_SCARED);
974 op->enemy = NULL; 839 op->enemy = NULL;
975} 840}
976 841
977/* check_pick sees if there is stuff to be picked up/picks up stuff. 842/* check_pick sees if there is stuff to be picked up/picks up stuff.
978 * It returns 1 if the player should keep on moving, 0 if he should 843 * It returns 1 if the player should keep on moving, 0 if he should
982check_pick (object *op) 847check_pick (object *op)
983{ 848{
984 object *tmp, *next; 849 object *tmp, *next;
985 int stop = 0; 850 int stop = 0;
986 int wvratio; 851 int wvratio;
987 char putstring[128];
988 852
989 /* if you're flying, you cna't pick up anything */ 853 /* if you're flying, you can't pick up anything */
990 if (op->move_type & MOVE_FLYING) 854 if (op->move_type & MOVE_FLYING)
991 return 1; 855 return 1;
992 856
993 next = op->below; 857 next = op->below;
994 858
995 int cnt = MAX_ITEM_PER_DROP; 859 int cnt = MAX_ITEM_PER_ACTION;
996#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0) 860#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
997 861
998 /* loop while there are items on the floor that are not marked as 862 /* loop while there are items on the floor that are not marked as
999 * destroyed */ 863 * destroyed */
1000 while (next && !next->destroyed ()) 864 while (next && !next->destroyed ())
1016 880
1017 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 881 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1018 { 882 {
1019 if (item_matched_string (op, tmp, op->contr->search_str)) 883 if (item_matched_string (op, tmp, op->contr->search_str))
1020 CHK_PICK_PICKUP; 884 CHK_PICK_PICKUP;
885
1021 continue; 886 continue;
1022 } 887 }
1023 888
1024 /* high not bit set? We're using the old autopickup model */ 889 /* pickup handling */
890 if (op->contr->mode & PU_DEBUG)
891 {
892 /* some debugging code to figure out item information */
893 const char *str = tmp->name
894 ? format ("item name: %s item type: %d weight/value: %d",
895 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))))
896 : format ("item name: %s item type: %d weight/value: %d",
897 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
898
899 new_draw_info (NDI_UNIQUE, 0, op, str);
900 }
901
902 if (op->contr->mode & PU_INHIBIT)
903 return 1;
904
905 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
906 return 1;
907
908 /* philosophy:
909 * It's easy to grab an item type from a pile, as long as it's
910 * generic. This takes no game-time. For more detailed pickups
911 * and selections, select-items should be used. This is a
912 * grab-as-you-run type mode that's really useful for arrows for
913 * example.
914 * The drawback: right now it has no frontend, so you need to
915 * stick the bits you want into a calculator in hex mode and then
916 * convert to decimal and then 'pickup <#>
917 */
918
919 /* the first two modes are exclusive: if NOTHING we return, if
920 * STOP then we stop. All the rest are applied sequentially,
921 * meaning if any test passes, the item gets picked up. */
922
923 /* if mode is set to pick nothing up, return */
924 if (op->contr->mode == PU_NOTHING)
925 return 1;
926
927 /* if mode is set to stop when encountering objects, return */
928 /* take STOP before INHIBIT since it doesn't actually pick
929 * anything up */
930 if (op->contr->mode & PU_STOP)
931 return 0;
932
933 /* useful for going into stores and not losing your settings... */
934 /* and for battles wher you don't want to get loaded down while
935 * fighting */
936 if (op->contr->mode & PU_INHIBIT)
937 return 1;
938
939 /* prevent us from turning into auto-thieves :) */
940 if (tmp->flag [FLAG_UNPAID])
941 continue;
942
943 /* ignore known cursed objects */
944 if (tmp->flag [FLAG_KNOWN_CURSED] && op->contr->mode & PU_NOT_CURSED)
945 continue;
946
947 /* all food and drink if desired */
948 /* question: don't pick up known-poisonous stuff? */
1025 if (!(op->contr->mode & PU_NEWMODE)) 949 if (op->contr->mode & PU_FOOD)
950 if (tmp->type == FOOD)
1026 { 951 {
1027 switch (op->contr->mode) 952 CHK_PICK_PICKUP;
953 continue;
954 }
955
956 if (op->contr->mode & PU_DRINK)
957 if (tmp->type == DRINK || (tmp->type == POISON && !tmp->flag [FLAG_KNOWN_CURSED]))
958 {
959 CHK_PICK_PICKUP;
960 continue;
961 }
962
963 if (op->contr->mode & PU_POTION)
964 if (tmp->type == POTION)
965 {
966 CHK_PICK_PICKUP;
967 continue;
968 }
969
970 /* spellbooks, skillscrolls and normal books/scrolls */
971 if (op->contr->mode & PU_SPELLBOOK)
972 if (tmp->type == SPELLBOOK)
973 {
974 CHK_PICK_PICKUP;
975 continue;
976 }
977
978 if (op->contr->mode & PU_SKILLSCROLL)
979 if (tmp->type == SKILLSCROLL)
980 {
981 CHK_PICK_PICKUP;
982 continue;
983 }
984
985 if (op->contr->mode & PU_READABLES)
986 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
987 {
988 CHK_PICK_PICKUP;
989 continue;
990 }
991
992 /* wands/staves/rods/horns */
993 if (op->contr->mode & PU_MAGIC_DEVICE)
994 if (tmp->type == WAND
995 || tmp->type == ROD
996 || tmp->type == HORN
997 || tmp->type == POWER_CRYSTAL)
998 {
999 CHK_PICK_PICKUP;
1000 continue;
1001 }
1002
1003 /* pick up all magical items */
1004 if (op->contr->mode & PU_MAGICAL)
1005 if (tmp->flag [FLAG_KNOWN_MAGICAL]
1006 && !tmp->flag [FLAG_KNOWN_CURSED])
1007 {
1008 CHK_PICK_PICKUP;
1009 continue;
1010 }
1011
1012 if (op->contr->mode & PU_VALUABLES)
1013 {
1014 if (tmp->type == MONEY || tmp->type == GEM)
1028 { 1015 {
1029 case 0:
1030 return 1; /* don't pick up */
1031 case 1:
1032 CHK_PICK_PICKUP; 1016 CHK_PICK_PICKUP;
1033 return 1; 1017 continue;
1034 case 2:
1035 CHK_PICK_PICKUP;
1036 return 0;
1037 case 3:
1038 return 0; /* stop before pickup */
1039 case 4:
1040 CHK_PICK_PICKUP;
1041 break;
1042 case 5:
1043 CHK_PICK_PICKUP;
1044 stop = 1;
1045 break;
1046 case 6:
1047 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL)
1048 && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1049 CHK_PICK_PICKUP;
1050 break;
1051
1052 case 7:
1053 if (tmp->type == MONEY || tmp->type == GEM)
1054 CHK_PICK_PICKUP;
1055 break;
1056
1057 default:
1058 /* use value density */
1059 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1060 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1061 CHK_PICK_PICKUP;
1062 } 1018 }
1063 } 1019 }
1064 else 1020
1065 { /* old model */ 1021 /* rings & amulets - talismans seems to be typed AMULET */
1066 /* NEW pickup handling */
1067 if (op->contr->mode & PU_DEBUG) 1022 if (op->contr->mode & PU_JEWELS)
1023 if (tmp->type == RING
1024 || tmp->type == AMULET
1025 || tmp->type == GIRDLE
1026 || tmp->type == SKILL_TOOL)
1068 { 1027 {
1069 /* some debugging code to figure out item information */ 1028 CHK_PICK_PICKUP;
1070 if (tmp->name != NULL)
1071 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1072 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1073 else
1074 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1075 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1076
1077 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1078 }
1079
1080 /* philosophy:
1081 * It's easy to grab an item type from a pile, as long as it's
1082 * generic. This takes no game-time. For more detailed pickups
1083 * and selections, select-items should be used. This is a
1084 * grab-as-you-run type mode that's really useful for arrows for
1085 * example.
1086 * The drawback: right now it has no frontend, so you need to
1087 * stick the bits you want into a calculator in hex mode and then
1088 * convert to decimal and then 'pickup <#>
1089 */
1090
1091 /* the first two modes are exclusive: if NOTHING we return, if
1092 * STOP then we stop. All the rest are applied sequentially,
1093 * meaning if any test passes, the item gets picked up. */
1094
1095 /* if mode is set to pick nothing up, return */
1096
1097 if (op->contr->mode & PU_NOTHING)
1098 return 1;
1099
1100 /* if mode is set to stop when encountering objects, return */
1101 /* take STOP before INHIBIT since it doesn't actually pick
1102 * anything up */
1103
1104 if (op->contr->mode & PU_STOP)
1105 return 0;
1106
1107 /* useful for going into stores and not losing your settings... */
1108 /* and for battles wher you don't want to get loaded down while
1109 * fighting */
1110 if (op->contr->mode & PU_INHIBIT)
1111 return 1;
1112
1113 /* prevent us from turning into auto-thieves :) */
1114 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1115 continue; 1029 continue;
1030 }
1116 1031
1117 /* ignore known cursed objects */ 1032 /* we don't forget dragon food */
1118 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1033 if (op->contr->mode & PU_FLESH)
1034 if (tmp->type == FLESH)
1035 {
1036 CHK_PICK_PICKUP;
1119 continue; 1037 continue;
1038 }
1120 1039
1121 /* all food and drink if desired */ 1040 /* bows and arrows. Bows are good for selling! */
1122 /* question: don't pick up known-poisonous stuff? */ 1041 if (op->contr->mode & PU_BOW)
1042 if (tmp->type == BOW)
1043 {
1044 CHK_PICK_PICKUP;
1045 continue;
1046 }
1047
1048 if (op->contr->mode & PU_ARROW)
1049 if (tmp->type == ARROW)
1050 {
1051 CHK_PICK_PICKUP;
1052 continue;
1053 }
1054
1055 /* all kinds of armor etc. */
1056 if (op->contr->mode & PU_ARMOUR)
1057 if (tmp->type == ARMOUR)
1058 {
1059 CHK_PICK_PICKUP;
1060 continue;
1061 }
1062
1063 if (op->contr->mode & PU_HELMET)
1064 if (tmp->type == HELMET)
1065 {
1066 CHK_PICK_PICKUP;
1067 continue;
1068 }
1069
1070 if (op->contr->mode & PU_SHIELD)
1071 if (tmp->type == SHIELD)
1072 {
1073 CHK_PICK_PICKUP;
1074 continue;
1075 }
1076
1123 if (op->contr->mode & PU_FOOD) 1077 if (op->contr->mode & PU_BOOTS)
1124 if (tmp->type == FOOD) 1078 if (tmp->type == BOOTS)
1079 {
1080 CHK_PICK_PICKUP;
1081 continue;
1082 }
1083
1084 if (op->contr->mode & PU_GLOVES)
1085 if (tmp->type == GLOVES || tmp->type == BRACERS)
1086 {
1087 CHK_PICK_PICKUP;
1088 continue;
1089 }
1090
1091 if (op->contr->mode & PU_CLOAK)
1092 if (tmp->type == CLOAK)
1093 {
1094 CHK_PICK_PICKUP;
1095 continue;
1096 }
1097
1098 /* hoping to catch throwing daggers here */
1099 if (op->contr->mode & PU_MISSILEWEAPON)
1100 if (tmp->type == WEAPON && tmp->flag [FLAG_IS_THROWN])
1101 {
1102 CHK_PICK_PICKUP;
1103 continue;
1104 }
1105
1106 /* careful: chairs and tables are weapons! */
1107 if (op->contr->mode & PU_ALLWEAPON)
1108 {
1109 if (tmp->type == WEAPON)
1110 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1125 { 1111 {
1126 CHK_PICK_PICKUP; 1112 CHK_PICK_PICKUP;
1127 continue; 1113 continue;
1128 } 1114 }
1115 }
1129 1116
1117 /* misc stuff that's useful */
1130 if (op->contr->mode & PU_DRINK) 1118 if (op->contr->mode & PU_KEY)
1131 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1119 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1132 { 1120 {
1133 CHK_PICK_PICKUP; 1121 CHK_PICK_PICKUP;
1134 continue; 1122 continue;
1135 } 1123 }
1136 1124
1125 /* any of the last 4 bits set means we use the ratio for value
1126 * pickups */
1137 if (op->contr->mode & PU_POTION) 1127 if (op->contr->mode & PU_RATIO)
1138 if (tmp->type == POTION) 1128 {
1129 /* use value density to decide what else to grab */
1130 /* >=7 was >= op->contr->mode */
1131 /* >=7 is the old standard setting. Now we take the last 4 bits
1139 { 1132 */
1140 CHK_PICK_PICKUP;
1141 continue;
1142 }
1143
1144 /* spellbooks, skillscrolls and normal books/scrolls */
1145 if (op->contr->mode & PU_SPELLBOOK)
1146 if (tmp->type == SPELLBOOK)
1147 {
1148 CHK_PICK_PICKUP;
1149 continue;
1150 }
1151
1152 if (op->contr->mode & PU_SKILLSCROLL)
1153 if (tmp->type == SKILLSCROLL)
1154 {
1155 CHK_PICK_PICKUP;
1156 continue;
1157 }
1158
1159 if (op->contr->mode & PU_READABLES)
1160 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
1161 {
1162 CHK_PICK_PICKUP;
1163 continue;
1164 }
1165
1166 /* wands/staves/rods/horns */
1167 if (op->contr->mode & PU_MAGIC_DEVICE)
1168 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1169 {
1170 CHK_PICK_PICKUP;
1171 continue;
1172 }
1173
1174 /* pick up all magical items */
1175 if (op->contr->mode & PU_MAGICAL) 1133 wvratio = op->contr->mode & PU_RATIO;
1176 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1134 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1177 {
1178 CHK_PICK_PICKUP;
1179 continue;
1180 }
1181
1182 if (op->contr->mode & PU_VALUABLES)
1183 { 1135 {
1184 if (tmp->type == MONEY || tmp->type == GEM) 1136#if 0
1137 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1138 if (tmp->name != NULL)
1185 { 1139 {
1186 CHK_PICK_PICKUP; 1140 fprintf (stderr, "%s", tmp->name);
1187 continue;
1188 } 1141 }
1189 }
1190
1191 /* rings & amulets - talismans seems to be typed AMULET */
1192 if (op->contr->mode & PU_JEWELS)
1193 if (tmp->type == RING || tmp->type == AMULET)
1194 {
1195 CHK_PICK_PICKUP;
1196 continue;
1197 }
1198
1199 /* we don't forget dragon food */
1200 if (op->contr->mode & PU_FLESH)
1201 if (tmp->type == FLESH)
1202 {
1203 CHK_PICK_PICKUP;
1204 continue;
1205 }
1206
1207 /* bows and arrows. Bows are good for selling! */
1208 if (op->contr->mode & PU_BOW)
1209 if (tmp->type == BOW)
1210 {
1211 CHK_PICK_PICKUP;
1212 continue;
1213 }
1214
1215 if (op->contr->mode & PU_ARROW)
1216 if (tmp->type == ARROW)
1217 {
1218 CHK_PICK_PICKUP;
1219 continue;
1220 }
1221
1222 /* all kinds of armor etc. */
1223 if (op->contr->mode & PU_ARMOUR)
1224 if (tmp->type == ARMOUR)
1225 {
1226 CHK_PICK_PICKUP;
1227 continue;
1228 }
1229
1230 if (op->contr->mode & PU_HELMET)
1231 if (tmp->type == HELMET)
1232 {
1233 CHK_PICK_PICKUP;
1234 continue;
1235 }
1236
1237 if (op->contr->mode & PU_SHIELD)
1238 if (tmp->type == SHIELD)
1239 {
1240 CHK_PICK_PICKUP;
1241 continue;
1242 }
1243
1244 if (op->contr->mode & PU_BOOTS)
1245 if (tmp->type == BOOTS)
1246 {
1247 CHK_PICK_PICKUP;
1248 continue;
1249 }
1250
1251 if (op->contr->mode & PU_GLOVES)
1252 if (tmp->type == GLOVES)
1253 {
1254 CHK_PICK_PICKUP;
1255 continue;
1256 }
1257
1258 if (op->contr->mode & PU_CLOAK)
1259 if (tmp->type == CLOAK)
1260 {
1261 CHK_PICK_PICKUP;
1262 continue;
1263 }
1264
1265 /* hoping to catch throwing daggers here */
1266 if (op->contr->mode & PU_MISSILEWEAPON)
1267 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1268 {
1269 CHK_PICK_PICKUP;
1270 continue;
1271 }
1272
1273 /* careful: chairs and tables are weapons! */
1274 if (op->contr->mode & PU_ALLWEAPON)
1275 {
1276 if (tmp->type == WEAPON && tmp->name != NULL)
1277 {
1278 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->archname, "table") == NULL &&
1279 strstr (tmp->name, "chair") && strstr (tmp->arch->archname, "chair") == NULL)
1280 {
1281 CHK_PICK_PICKUP;
1282 continue;
1283 }
1284 }
1285
1286 if (tmp->type == WEAPON && tmp->name == NULL)
1287 {
1288 if (strstr (tmp->arch->archname, "table") == NULL && strstr (tmp->arch->archname, "chair") == NULL)
1289 {
1290 CHK_PICK_PICKUP;
1291 continue;
1292 }
1293 }
1294 }
1295
1296 /* misc stuff that's useful */
1297 if (op->contr->mode & PU_KEY)
1298 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1299 {
1300 CHK_PICK_PICKUP;
1301 continue;
1302 }
1303
1304 /* any of the last 4 bits set means we use the ratio for value
1305 * pickups */
1306 if (op->contr->mode & PU_RATIO)
1307 {
1308 /* use value density to decide what else to grab */
1309 /* >=7 was >= op->contr->mode */
1310 /* >=7 is the old standard setting. Now we take the last 4 bits
1311 */
1312 wvratio = op->contr->mode & PU_RATIO;
1313 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1314 {
1315 CHK_PICK_PICKUP;
1316#if 0
1317 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1318 if (tmp->name != NULL)
1319 {
1320 fprintf (stderr, "%s", tmp->name);
1321 }
1322 else 1142 else
1323 fprintf (stderr, "%s", tmp->arch->archname); 1143 fprintf (stderr, "%s", tmp->arch->archname);
1324 fprintf (stderr, ",%d] = ", tmp->type); 1144 fprintf (stderr, ",%d] = ", tmp->type);
1325 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1145 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
1326#endif 1146#endif
1147 CHK_PICK_PICKUP;
1327 continue; 1148 continue;
1328 }
1329 } 1149 }
1330 } /* the new pickup model */ 1150 } /* the new pickup model */
1331 } 1151 }
1332 1152
1333 return !stop; 1153 return !stop;
1334} 1154}
1335 1155
1156/* routine for both players and monsters. We call this when
1157 * there is a possibility for our action distrubing our hiding
1158 * place or invisiblity spell. Artefact invisiblity causes
1159 * "noise" instead. If we arent invisible to begin with, we
1160 * return 0.
1161 */
1162static int
1163action_makes_visible (object *op)
1164{
1165 if (op->invisible && op->flag [FLAG_ALIVE])
1166 {
1167 if (op->flag [FLAG_MAKE_INVIS])
1168 {
1169 // artefact invisibility is permanent, but we still make noise
1170 // this is important for game-balance.
1171 if (op->contr)
1172 op->make_noise ();
1173
1174 return 0;
1175 }
1176
1177 if (op->contr && op->contr->tmp_invis == 0)
1178 return 0;
1179
1180 /* If monsters, they should become visible */
1181 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
1182 {
1183 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
1184 return 1;
1185 }
1186 }
1187
1188 return 0;
1189}
1190
1336/* 1191/*
1337 * Find an arrow in the inventory and after that 1192 * Find an arrow in the inventory and after that
1338 * in the right type container (quiver). Pointer to the 1193 * in the right type container (quiver). Pointer to the
1339 * found object is returned. 1194 * found object is returned.
1340 */ 1195 */
1341object * 1196static object *
1342find_arrow (object *op, const char *type) 1197find_arrow (object *op, const char *type)
1343{ 1198{
1344 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1199 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1345 if (tmp->type == ARROW && !strcmp (&tmp->race, type)) 1200 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1346 return splay (tmp); 1201 return splay (tmp);
1347 1202
1348 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1203 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1349 if (tmp->type == CONTAINER && QUERY_FLAG (tmp, FLAG_APPLIED) && !strcmp (&tmp->race, type)) 1204 if (tmp->type == CONTAINER && tmp->flag [FLAG_APPLIED] && !strcmp (&tmp->race, type))
1350 if (object *arrow = find_arrow (tmp, type)) 1205 if (object *arrow = find_arrow (tmp, type))
1351 { 1206 {
1352 splay (tmp); 1207 splay (tmp);
1353 return arrow; 1208 return arrow;
1354 } 1209 }
1360 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1215 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1361 * against the target. A full test is not performed, simply a basic test 1216 * against the target. A full test is not performed, simply a basic test
1362 * of resistances. The archer is making a quick guess at what he sees down 1217 * of resistances. The archer is making a quick guess at what he sees down
1363 * the hall. Failing that it does it's best to pick the highest plus arrow. 1218 * the hall. Failing that it does it's best to pick the highest plus arrow.
1364 */ 1219 */
1365object * 1220static object *
1366find_better_arrow (object *op, object *target, const char *type, int *better) 1221find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1367{ 1222{
1368 object *tmp = NULL, *arrow, *ntmp; 1223 object *tmp = NULL, *arrow, *ntmp;
1369 int attacknum, attacktype, betterby = 0, i; 1224 int attacknum, attacktype, betterby = 0, i;
1370 1225
1371 if (!type) 1226 if (!type)
1372 return NULL; 1227 return NULL;
1373 1228
1374 for (arrow = op->inv; arrow; arrow = arrow->below) 1229 for (arrow = op->inv; arrow; arrow = arrow->below)
1375 { 1230 {
1376 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1231 if (arrow->type == CONTAINER && arrow->race == type && arrow->flag [FLAG_APPLIED])
1377 { 1232 {
1378 i = 0; 1233 i = 0;
1379 ntmp = find_better_arrow (arrow, target, type, &i); 1234 ntmp = find_better_arrow (arrow, target, type, &i);
1235
1380 if (i > betterby) 1236 if (i > betterby)
1381 { 1237 {
1382 tmp = ntmp; 1238 tmp = ntmp;
1383 betterby = i; 1239 betterby = i;
1384 } 1240 }
1385 } 1241 }
1386 else if (arrow->type == ARROW && arrow->race == type) 1242 else if (arrow->type == ARROW && arrow->race == type)
1387 { 1243 {
1388 /* allways prefer assasination/slaying */ 1244 /* allways prefer assasination/slaying */
1389 if (target->race && arrow->slaying && strstr (arrow->slaying, target->race)) 1245 if (target->race && arrow->slaying.contains (target->race))
1390 { 1246 {
1391 if (arrow->attacktype & AT_DEATH) 1247 if (arrow->attacktype & AT_DEATH)
1392 { 1248 {
1393 *better = 100; 1249 *better = 100;
1394 return arrow; 1250 return arrow;
1409 { 1265 {
1410 tmp = arrow; 1266 tmp = arrow;
1411 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100; 1267 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1412 } 1268 }
1413 } 1269 }
1270
1414 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1271 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1415 { 1272 {
1416 tmp = arrow; 1273 tmp = arrow;
1417 betterby = 2 + arrow->magic + arrow->stats.dam; 1274 betterby = 2 + arrow->magic + arrow->stats.dam;
1418 } 1275 }
1276
1419 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1277 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1420 { 1278 {
1421 tmp = arrow; 1279 tmp = arrow;
1422 betterby = 1 + arrow->magic + arrow->stats.dam; 1280 betterby = 1 + arrow->magic + arrow->stats.dam;
1423 } 1281 }
1436 * find_better_arrow to find a decent arrow to use. 1294 * find_better_arrow to find a decent arrow to use.
1437 * op = the shooter 1295 * op = the shooter
1438 * type = bow->race 1296 * type = bow->race
1439 * dir = fire direction 1297 * dir = fire direction
1440 */ 1298 */
1441object * 1299static object *
1442pick_arrow_target (object *op, const char *type, int dir) 1300pick_arrow_target (object *op, shstr_cmp type, int dir)
1443{ 1301{
1444 object *tmp = NULL; 1302 object *tmp = NULL;
1445 maptile *m; 1303 maptile *m;
1446 int i, mflags, found, number; 1304 int i, mflags, found, number;
1447 sint16 x, y; 1305 sint16 x, y;
1459 y = op->y; 1317 y = op->y;
1460 1318
1461 /* find the first target */ 1319 /* find the first target */
1462 for (i = 0, found = 0; i < 20; i++) 1320 for (i = 0, found = 0; i < 20; i++)
1463 { 1321 {
1464 x += freearr_x[dir]; 1322 x += DIRX (dir);
1465 y += freearr_y[dir]; 1323 y += DIRY (dir);
1466 mflags = get_map_flags (m, &m, x, y, &x, &y); 1324 mflags = get_map_flags (m, &m, x, y, &x, &y);
1325
1467 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1326 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1468 { 1327 {
1469 tmp = NULL; 1328 tmp = 0;
1470 break; 1329 break;
1471 } 1330 }
1472 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1331 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1473 { 1332 {
1474 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1333 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1475 * perhaps a bad assumption. 1334 * perhaps a bad assumption.
1476 */ 1335 */
1477 tmp = NULL; 1336 tmp = 0;
1478 break; 1337 break;
1479 } 1338 }
1339
1480 if (mflags & P_IS_ALIVE) 1340 if (mflags & P_IS_ALIVE)
1481 {
1482 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1341 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1483 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1342 if (tmp->flag [FLAG_ALIVE])
1484 {
1485 found++;
1486 break;
1487 }
1488 if (found)
1489 break; 1343 break;
1490 }
1491 } 1344 }
1492 if (tmp == NULL) 1345
1346 if (!tmp)
1493 return find_arrow (op, type); 1347 return find_arrow (op, type);
1494 1348
1495 if (tmp->head) 1349 if (tmp->head)
1496 tmp = tmp->head; 1350 tmp = tmp->head;
1497 1351
1498 return find_better_arrow (op, tmp, type, &i); 1352 return find_better_arrow (op, tmp, type, &i);
1499} 1353}
1500 1354
1501/* 1355/*
1502 * Creature fires a bow - op can be monster or player. Returns 1356 * Creature fires a bow - op can be monster or player. Returns
1503 * 1 if bow was actually fired, 0 otherwise. 1357 * 1 if bow was actually fired, 0 otherwise.
1504 * op is the object firing the bow. 1358 * op is the object firing the bow.
1505 * part is for multipart creatures - the part firing the bow. 1359 * part is for multipart creatures - the part firing the bow.
1506 * dir is the direction of fire. 1360 * dir is the direction of fire.
1507 * wc_mod is any special modifier to give (used in special player fire modes) 1361 * wc_mod is any special modifier to give (used in special player fire modes)
1537 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1391 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1538 return 0; 1392 return 0;
1539 } 1393 }
1540 1394
1541 // optimisation: move object to top so we will find it quickly again 1395 // optimisation: move object to top so we will find it quickly again
1542 if (bow->below) 1396 splay (bow);
1543 {
1544 bow->remove ();
1545 op->insert (bow);
1546 }
1547
1548 } 1397 }
1549 1398
1550 if (!bow->race || !bow->skill) 1399 if (!bow->race || !bow->skill)
1551 { 1400 {
1552 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1401 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1559 { 1408 {
1560 if (op->type == PLAYER) 1409 if (op->type == PLAYER)
1561 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1410 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1562 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1411 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1563 else 1412 else
1564 CLEAR_FLAG (op, FLAG_READY_BOW); 1413 op->clr_flag (FLAG_READY_BOW);
1565 1414
1566 return 0; 1415 return 0;
1567 } 1416 }
1568 } 1417 }
1569 1418
1598 arrow->direction = dir; 1447 arrow->direction = dir;
1599 1448
1600 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */ 1449 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1601 arrow->stats.hp = arrow->stats.dam; 1450 arrow->stats.hp = arrow->stats.dam;
1602 arrow->stats.grace = arrow->attacktype; 1451 arrow->stats.grace = arrow->attacktype;
1603 1452 arrow->custom_name = arrow->slaying;
1604 if (arrow->slaying)
1605 arrow->spellarg = strdup (arrow->slaying);
1606 1453
1607#if 0 1454#if 0
1608 if (player *pl = op->contr) 1455 if (player *pl = op->contr)
1609 { 1456 {
1610 float speed = pl->weapon_sp; 1457 float speed = pl->weapon_sp;
1620#endif 1467#endif
1621 1468
1622 SET_ANIMATION (arrow, arrow->direction); 1469 SET_ANIMATION (arrow, arrow->direction);
1623 1470
1624 /* update the speed */ 1471 /* update the speed */
1625 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1626 + bow->stats.dam / 7.f;
1627 1472
1628 arrow->set_speed (max (arrow->speed, 2.f));
1629 arrow->speed_left = 0; 1473 arrow->speed_left = 0;
1474 arrow->set_speed (max (2.f,
1475 ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1476 + bow->stats.dam / 7.f
1477 ));
1630 1478
1631 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc; 1479 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1632 1480
1633 if (op->type == PLAYER) 1481 if (op->type == PLAYER)
1634 { 1482 {
1655 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM); 1503 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1656 1504
1657 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC); 1505 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1658 arrow->move_type = MOVE_FLY_LOW; 1506 arrow->move_type = MOVE_FLY_LOW;
1659 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1507 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1508 arrow->set_flag (FLAG_NO_PICK);
1660 1509
1661 op->play_sound (sound_find ("fire_arrow")); 1510 op->play_sound (sound_find ("fire_arrow"));
1662 m->insert (arrow, sx, sy, op); 1511 m->insert (arrow, sx, sy, op);
1663 1512
1664 if (!arrow->destroyed ()) 1513 if (!arrow->destroyed ())
1672 * but monsters can't. Putting that code here 1521 * but monsters can't. Putting that code here
1673 * makes the fire_bow code much cleaner. 1522 * makes the fire_bow code much cleaner.
1674 * this function should only be called if 'op' is a player, 1523 * this function should only be called if 'op' is a player,
1675 * hence the function name. 1524 * hence the function name.
1676 */ 1525 */
1677int 1526static int
1678player_fire_bow (object *op, int dir) 1527player_fire_bow (object *op, int dir)
1679{ 1528{
1680 int ret = 0, wcmod = 0; 1529 int ret;
1681 1530
1682 if (op->contr->bowtype == bow_bestarrow) 1531 if (op->contr->bowtype == bow_bestarrow)
1683 { 1532 {
1684 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y); 1533 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1685 } 1534 }
1686 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1535 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1687 { 1536 {
1688 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1537 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1689 wcmod = -1;
1690
1691 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1538 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1692 } 1539 }
1693 else if (op->contr->bowtype == bow_threewide) 1540 else if (op->contr->bowtype == bow_threewide)
1694 { 1541 {
1695 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1542 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1696 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1543 ret |= fire_bow (op, op, NULL, dir, -5, op->x + DIRX (absdir (dir + 2)), op->y + DIRY (absdir (dir + 2)));
1697 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1544 ret |= fire_bow (op, op, NULL, dir, -5, op->x + DIRX (absdir (dir - 2)), op->y + DIRY (absdir (dir - 2)));
1698 } 1545 }
1699 else if (op->contr->bowtype == bow_spreadshot) 1546 else if (op->contr->bowtype == bow_spreadshot)
1700 { 1547 {
1701 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1548 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1702 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1549 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1703 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1550 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1704 } 1551 }
1705 else 1552 else
1706 { 1553 {
1712} 1559}
1713 1560
1714/* Fires a misc (wand/rod/horn) object in 'dir'. 1561/* Fires a misc (wand/rod/horn) object in 'dir'.
1715 * Broken apart from 'fire' to keep it more readable. 1562 * Broken apart from 'fire' to keep it more readable.
1716 */ 1563 */
1717void 1564static void
1718fire_misc_object (object *op, int dir) 1565fire_misc_object (object *op, int dir)
1719{ 1566{
1720 object *item = op->contr->ranged_ob; 1567 object *item = op->contr->ranged_ob;
1721 1568
1722 if (!item) 1569 if (!item)
1729 { 1576 {
1730 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1577 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1731 return; 1578 return;
1732 } 1579 }
1733 1580
1734 if (!op->change_weapon (item)) 1581 if (!op->apply (item))
1735 return; 1582 return;
1736 1583
1737 if (item->type == WAND) 1584 if (item->type == WAND)
1738 { 1585 {
1739 if (item->stats.food <= 0) 1586 if (item->stats.food <= 0)
1744 return; 1591 return;
1745 } 1592 }
1746 } 1593 }
1747 else if (item->type == ROD || item->type == HORN) 1594 else if (item->type == ROD || item->type == HORN)
1748 { 1595 {
1749 sint16 spell_sp = MAX (item->inv->stats.sp, item->inv->stats.grace); 1596 sint16 spell_sp = max (item->inv->stats.sp, item->inv->stats.grace);
1750 1597
1751 // using the maximum of the rods charge allows at least one spell cast 1598 // using the maximum of the rods charge allows at least one spell cast
1752 // for a rod or horn, this fixes some broken rods. 1599 // for a rod or horn, this fixes some broken rods.
1753 if (item->stats.hp < MIN (spell_sp, item->stats.maxhp)) 1600 if (item->stats.hp < min (spell_sp, item->stats.maxhp))
1754 { 1601 {
1755 op->contr->play_sound (sound_find ("wand_poof")); 1602 op->contr->play_sound (sound_find ("wand_poof"));
1756 1603
1757 if (item->type == ROD) 1604 if (item->type == ROD)
1758 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1605 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1763 } 1610 }
1764 } 1611 }
1765 1612
1766 if (cast_spell (op, item, dir, item->inv, NULL)) 1613 if (cast_spell (op, item, dir, item->inv, NULL))
1767 { 1614 {
1768 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1615 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1616
1769 if (item->type == WAND) 1617 if (item->type == WAND)
1770 { 1618 {
1771 if (!(--item->stats.food)) 1619 if (!(--item->stats.food))
1772 { 1620 {
1773 object *tmp;
1774
1775 if (item->arch) 1621 if (item->arch)
1776 { 1622 {
1777 CLEAR_FLAG (item, FLAG_ANIMATE); 1623 item->clr_flag (FLAG_ANIMATE);
1778 item->face = item->arch->face; 1624 item->face = item->arch->face;
1779 item->set_speed (0); 1625 item->set_speed (0);
1780 } 1626 }
1781 1627
1782 if (object *pl = item->visible_to ()) 1628 if (object *pl = item->visible_to ())
1789} 1635}
1790 1636
1791/* Received a fire command for the player - go and do it. 1637/* Received a fire command for the player - go and do it.
1792 */ 1638 */
1793bool 1639bool
1794fire (object *op, int dir) 1640fire (object *who, int dir)
1795{ 1641{
1796 int spellcost = 0; 1642 int spellcost = 0;
1797 1643
1798 player *pl = op->contr; 1644 player *pl = who->contr;
1799 1645
1800 if (pl->golem) 1646 if (pl->golem)
1801 { 1647 {
1802 control_golem (op->contr->golem, dir); 1648 control_golem (who->contr->golem, dir);
1803 return false; 1649 return false;
1804 } 1650 }
1805 1651
1806 object *ob = pl->ranged_ob; 1652 object *ob = pl->ranged_ob;
1807 1653
1808 if (!ob) 1654 if (!ob)
1809 return false; 1655 return false;
1810 1656
1811 if (op->speed_left > 0.f) 1657 if (who->speed_left > 0.f)
1812 --op->speed_left; 1658 --who->speed_left;
1813 else 1659 else
1814 return false; 1660 return false;
1815 1661
1816 if (!op->change_weapon (ob)) 1662 if (!who->apply (ob))
1817 return false; 1663 return false;
1818 1664
1819 /* check for loss of invisiblity/hide */ 1665 /* check for loss of invisiblity/hide */
1820 if (action_makes_visible (op)) 1666 if (action_makes_visible (who))
1821 make_visible (op); 1667 make_visible (who);
1822 1668
1823 switch (ob->type) 1669 switch (ob->type)
1824 { 1670 {
1825 case BOW: 1671 case BOW:
1826 player_fire_bow (op, dir); 1672 player_fire_bow (who, dir);
1827 break; 1673 break;
1828 1674
1829 case SPELL: 1675 case SPELL:
1830 spellcost = cast_spell (op, op, dir, ob, pl->spellparam[0] ? pl->spellparam : 0); 1676 spellcost = cast_spell (who, who, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1831 break; 1677 break;
1832 1678
1833 case BUILDER: 1679 case BUILDER:
1834 apply_map_builder (op, dir); 1680 apply_map_builder (who, dir);
1835 break; 1681 break;
1836 1682
1837 case SKILL: 1683 case SKILL:
1838 do_skill (op, op, ob, dir, 0); 1684 do_skill (who, who, ob, dir, 0);
1839 break; 1685 break;
1840 1686
1687 case RANGED:
1688 do_skill (who, ob, who->chosen_skill, dir, 0);
1689 break;
1690
1841 default: 1691 default:
1842 fire_misc_object (op, dir); 1692 fire_misc_object (who, dir);
1843 break; 1693 break;
1844 } 1694 }
1845 1695
1846 return true; 1696 return true;
1847} 1697}
1848 1698
1849/* find_key 1699static object *
1850 * We try to find a key for the door as passed. If we find a key
1851 * and successfully use it, we return the key, otherwise NULL
1852 * This function merges both normal and locked door, since the logic
1853 * for both is the same - just the specific key is different.
1854 * pl is the player,
1855 * inv is the objects inventory to searched
1856 * door is the door we are trying to match against.
1857 * This function can be called recursively to search containers.
1858 */
1859object *
1860find_key (object *pl, object *container, object *door) 1700find_key_ (object *pl, object *container, object *door)
1861{ 1701{
1862 object *tmp, *key; 1702 object *tmp, *key;
1863 1703
1864 /* Should not happen, but sanity checking is never bad */ 1704 /* Should not happen, but sanity checking is never bad */
1865 if (!container->inv) 1705 if (!container->inv)
1868 /* First, lets try to find a key in the top level inventory */ 1708 /* First, lets try to find a key in the top level inventory */
1869 for (tmp = container->inv; tmp; tmp = tmp->below) 1709 for (tmp = container->inv; tmp; tmp = tmp->below)
1870 { 1710 {
1871 if (door->type == DOOR && tmp->type == KEY) 1711 if (door->type == DOOR && tmp->type == KEY)
1872 break; 1712 break;
1713
1873 /* For sanity, we should really check door type, but other stuff 1714 /* For sanity, we should really check door type, but other stuff
1874 * (like containers) can be locked with special keys 1715 * (like containers) can be locked with special keys
1875 */ 1716 */
1876 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1717 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1877 break; 1718 break;
1878 } 1719 }
1883 * a key, return 1724 * a key, return
1884 */ 1725 */
1885 if (!tmp) 1726 if (!tmp)
1886 { 1727 {
1887 for (tmp = container->inv; tmp; tmp = tmp->below) 1728 for (tmp = container->inv; tmp; tmp = tmp->below)
1888 {
1889 /* No reason to search empty containers */ 1729 /* No reason to search empty containers */
1890 if (tmp->type == CONTAINER && tmp->inv) 1730 if (tmp->type == CONTAINER && tmp->inv)
1891 {
1892 if ((key = find_key (pl, tmp, door))) 1731 if ((key = find_key_ (pl, tmp, door)))
1893 return key; 1732 return key;
1894 }
1895 }
1896 1733
1897 if (!tmp) 1734 if (!tmp)
1898 return NULL; 1735 return 0;
1899 } 1736 }
1900 1737
1901 /* We get down here if we have found a key. Now if its in a container, 1738 /* We get down here if we have found a key. Now if its in a container,
1902 * see if we actually want to use it 1739 * see if we actually want to use it
1903 */ 1740 */
1904 if (pl != container) 1741 if (pl != container)
1905 { 1742 {
1906 /* Only let players use keys in containers */ 1743 /* Only let players use keys in containers */
1907 if (!pl->contr) 1744 if (!pl->contr)
1908 return NULL; 1745 return 0;
1746
1909 /* cases where this fails: 1747 /* cases where this fails:
1910 * If we only search the player inventory, return now since we 1748 * If we only search the player inventory, return now since we
1911 * are not in the players inventory. 1749 * are not in the players inventory.
1912 * If the container is not active, return now since only active 1750 * If the container is not active, return now since only active
1913 * containers can be used. 1751 * containers can be used.
1917 * inv must have been an container and must have been active. 1755 * inv must have been an container and must have been active.
1918 * 1756 *
1919 * Change the color so that the message doesn't disappear with 1757 * Change the color so that the message doesn't disappear with
1920 * all the others. 1758 * all the others.
1921 */ 1759 */
1922 if (pl->contr->usekeys == key_inventory || 1760 if (pl->contr->usekeys == key_inventory
1923 !QUERY_FLAG (container, FLAG_APPLIED) || 1761 || !container->flag [FLAG_APPLIED]
1924 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1762 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
1925 { 1763 {
1926 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1764 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1927 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1765 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1928 return NULL; 1766 return NULL;
1929 } 1767 }
1930 } 1768 }
1931 1769
1932 return tmp; 1770 return tmp;
1771}
1772
1773/* find_key
1774 * We try to find a key for the door as passed. If we find a key
1775 * and successfully use it, we return the key, otherwise NULL
1776 * This function merges both normal and locked door, since the logic
1777 * for both is the same - just the specific key is different.
1778 * pl is the player,
1779 * inv is the objects inventory to searched
1780 * door is the door we are trying to match against.
1781 * This function can be called recursively to search containers.
1782 */
1783object *
1784find_key (object *pl, object *container, object *door)
1785{
1786 if (door->slaying && is_match_expr (door->slaying))
1787 {
1788 // for match expressions, we try to find the key by applying the match
1789 // to the op itself, which is supposed to find the "key", instead
1790 // of searching through containers ourselves.
1791
1792 return match_one (door->slaying, container, door, pl, pl);
1793 }
1794 else
1795 return find_key_ (pl, container, door);
1933} 1796}
1934 1797
1935/* moved door processing out of move_player_attack. 1798/* moved door processing out of move_player_attack.
1936 * returns 1 if player has opened the door with a key 1799 * returns 1 if player has opened the door with a key
1937 * such that the caller should not do anything more, 1800 * such that the caller should not do anything more,
1987 * going to try and move (not fire weapons). 1850 * going to try and move (not fire weapons).
1988 */ 1851 */
1989bool 1852bool
1990move_player_attack (object *op, int dir) 1853move_player_attack (object *op, int dir)
1991{ 1854{
1992 int on_battleground; 1855 if (!op->contr->braced && op->speed_left > 0.f && op->move (dir))
1856 {
1857 --op->speed_left;
1858 return true;
1859 }
1993 1860
1994 sint16 nx = freearr_x[dir] + op->x; 1861 sint16 nx = DIRX (dir) + op->x;
1995 sint16 ny = freearr_y[dir] + op->y; 1862 sint16 ny = DIRY (dir) + op->y;
1996
1997 on_battleground = op_on_battleground (op, 0, 0);
1998 1863
1999 if (out_of_map (op->map, nx, ny)) 1864 if (out_of_map (op->map, nx, ny))
2000 return false; 1865 return false;
2001
2002 if (!op->contr->braced && op->speed_left > 0.f && move_ob (op, dir, op))
2003 {
2004 --op->speed_left;
2005 return true;
2006 }
2007 1866
2008 /* If braced, or can't move to the square, and it is not out of the 1867 /* If braced, or can't move to the square, and it is not out of the
2009 * map, attack it. Note order of if statement is important - don't 1868 * map, attack it. Note order of if statement is important - don't
2010 * want to be calling move_ob if braced, because move_ob will move the 1869 * want to be calling move_ob if braced, because move_ob will move the
2011 * player. This is a pretty nasty hack, because if we could 1870 * player. This is a pretty nasty hack, because if we could
2029 || mon->flag [FLAG_CAN_ROLL]) 1888 || mon->flag [FLAG_CAN_ROLL])
2030 && mon != op) 1889 && mon != op)
2031 break; 1890 break;
2032 } 1891 }
2033 1892
2034 if (!mon) /* This happens anytime the player tries to move */ 1893 /* no monster == player tries to move into a wall or so */
2035 return false; /* into a wall */ 1894 if (!mon)
1895 {
1896 for (object *ob = m->at (nx, ny).top; ob; ob = ob->below)
1897 if (op->move_type & ob->move_block)
1898 {
1899 if (ob->move_block == MOVE_ALL)
1900 move_into_wall (op, ob);
1901 else
1902 {
1903 if (op->contr->ns->bumpmsg)
1904 {
1905 op->play_sound (sound_find ("blocked_move"));
1906
1907 op->statusmsg (ob->invisible
1908 ? "Something blocks you."
1909 : format ("Something blocks you from entering the %s.", query_name (ob))
1910 );
1911 }
1912 }
1913
1914 break;
1915 }
1916
1917 return false;
1918 }
2036 1919
2037 mon = mon->head_ (); 1920 mon = mon->head_ ();
2038 1921
2039 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR)) 1922 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2040 if (op->contr->weapon_sp_left > 0.f) 1923 if (op->contr->weapon_sp_left > 0.f)
2058 */ 1941 */
2059 if (op->type == PLAYER 1942 if (op->type == PLAYER
2060 && ((mon->owner && mon->owner->contr 1943 && ((mon->owner && mon->owner->contr
2061 && same_party (mon->owner->contr->party, op->contr->party)) 1944 && same_party (mon->owner->contr->party, op->contr->party))
2062 || mon->owner == op) 1945 || mon->owner == op)
2063 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))) 1946 && (mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY]))
2064 { 1947 {
2065 /* If we're braced, we don't want to switch places with it */ 1948 /* If we're braced, we don't want to switch places with it */
2066 if (op->contr->braced) 1949 if (op->contr->braced)
2067 return false; 1950 return false;
2068 1951
2071 --op->speed_left; 1954 --op->speed_left;
2072 1955
2073 op->play_sound (sound_find ("push_player")); 1956 op->play_sound (sound_find ("push_player"));
2074 push_ob (mon, dir, op); 1957 push_ob (mon, dir, op);
2075 1958
2076 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN]) 1959 if (action_makes_visible (op))
2077 make_visible (op); 1960 make_visible (op);
2078 1961
2079 return true; 1962 return true;
2080 } 1963 }
2081 else 1964 else
2082 return false; 1965 return false;
2083 } 1966 }
1967
1968 bool on_battleground = op_on_battleground (op, 0, 0);
2084 1969
2085 /* in certain circumstances, you shouldn't attack friendly 1970 /* in certain circumstances, you shouldn't attack friendly
2086 * creatures. Note that if you are braced, you can't push 1971 * creatures. Note that if you are braced, you can't push
2087 * someone, but put it inside this loop so that you won't 1972 * someone, but put it inside this loop so that you won't
2088 * attack them either. 1973 * attack them either.
2089 */ 1974 */
2090 if ((mon->type == PLAYER || mon->enemy != op) 1975 if ((mon->type == PLAYER || mon->enemy != op)
2091 && (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) 1976 && (mon->type == PLAYER || mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY])
2092 && ((op->contr->peaceful 1977 && ((op->contr->peaceful
2093 || (mon->type == PLAYER && mon->contr->peaceful)) 1978 || (mon->type == PLAYER && mon->contr->peaceful))
2094 && !on_battleground)) 1979 && !on_battleground))
2095 { 1980 {
2096 if (op->speed_left > 0.f) 1981 if (op->speed_left > 0.f)
2112 } 1997 }
2113 } 1998 }
2114 /* If the object is a boulder or other rollable object, then 1999 /* If the object is a boulder or other rollable object, then
2115 * roll it if not braced. You can't roll it if you are braced. 2000 * roll it if not braced. You can't roll it if you are braced.
2116 */ 2001 */
2117 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 2002 else if (mon->flag [FLAG_CAN_ROLL] && (!op->contr->braced))
2118 { 2003 {
2119 if (op->speed_left > 0.f) 2004 if (op->speed_left > 0.f)
2120 { 2005 {
2121 --op->speed_left; 2006 --op->speed_left;
2122 2007
2131 * Way it works is like this: First, it must have some hit points 2016 * Way it works is like this: First, it must have some hit points
2132 * and be living. Then, it must be one of the following: 2017 * and be living. Then, it must be one of the following:
2133 * 1) Not a player, 2) A player, but of a different party. Note 2018 * 1) Not a player, 2) A player, but of a different party. Note
2134 * that party_number -1 is no party, so attacks can still happen. 2019 * that party_number -1 is no party, so attacks can still happen.
2135 */ 2020 */
2136 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 2021 else if ((mon->stats.hp >= 0) && mon->flag [FLAG_ALIVE] &&
2137 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 2022 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2138 { 2023 {
2139 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS]) 2024 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2140 { 2025 {
2141 --op->contr->weapon_sp_left; 2026 --op->contr->weapon_sp_left;
2153} 2038}
2154 2039
2155bool 2040bool
2156move_player (object *op, int dir) 2041move_player (object *op, int dir)
2157{ 2042{
2158 int pick;
2159
2160 if (!op->map || op->map->in_memory != MAP_ACTIVE) 2043 if (!op->map || op->map->state != MAP_ACTIVE)
2161 return 0; 2044 return 0;
2162 2045
2163 /* Sanity check: make sure dir is valid */ 2046 /* Sanity check: make sure dir is valid */
2164 if ((dir < 0) || (dir >= 9)) 2047 if (dir < 0 || dir > 8)
2165 { 2048 {
2166 LOG (llevError, "move_player: invalid direction %d\n", dir); 2049 LOG (llevError, "move_player: invalid direction %d\n", dir);
2167 return 0; 2050 return 0;
2168 } 2051 }
2169 2052
2170 /* peterm: added following line */ 2053 /* peterm: added following line */
2171 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2054 if (op->flag [FLAG_CONFUSED] && dir)
2172 dir = absdir (dir + rndm (3) + rndm (3) - 2); 2055 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2173 2056
2174 op->facing = dir; 2057 op->facing = dir;
2175 2058
2176 if (op->flag [FLAG_HIDDEN]) 2059 if (op->flag [FLAG_HIDDEN])
2177 do_hidden_move (op); 2060 do_hidden_move (op);
2178 2061
2179 bool retval; 2062 bool retval;
2063 int pick = 0;
2180 2064
2181 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2065 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2182 retval = RESULT_INT (0); 2066 retval = RESULT_INT (0);
2183 else if (op->contr->fire_on) 2067 else if (op->contr->fire_on)
2184 retval = fire (op, dir); 2068 retval = fire (op, dir);
2215 * players. 2099 * players.
2216 */ 2100 */
2217bool 2101bool
2218handle_newcs_player (object *op) 2102handle_newcs_player (object *op)
2219{ 2103{
2220 if (QUERY_FLAG (op, FLAG_SCARED)) 2104 if (op->flag [FLAG_SCARED])
2221 { 2105 {
2222 if (op->speed_left > 0.f) 2106 if (op->speed_left > 0.f)
2223 { 2107 {
2224 --op->speed_left; 2108 --op->speed_left;
2225 flee_player (op); 2109 flee_player (op);
2241 return move_player (op, op->direction); 2125 return move_player (op, op->direction);
2242 2126
2243 return false; 2127 return false;
2244} 2128}
2245 2129
2246int 2130static int
2247save_life (object *op) 2131save_life (object *op)
2248{ 2132{
2249 if (!QUERY_FLAG (op, FLAG_LIFESAVE)) 2133 if (!op->flag [FLAG_LIFESAVE])
2250 return 0; 2134 return 0;
2251 2135
2252 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2136 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2253 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2137 if (tmp->flag [FLAG_APPLIED] && tmp->flag [FLAG_LIFESAVE])
2254 { 2138 {
2255 op->play_sound (sound_find ("ob_evaporate")); 2139 op->play_sound (sound_find ("ob_evaporate"));
2256 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2140 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2257 2141
2258 tmp->destroy (); 2142 tmp->destroy ();
2259 CLEAR_FLAG (op, FLAG_LIFESAVE); 2143 op->clr_flag (FLAG_LIFESAVE);
2260 2144
2261 if (op->stats.hp < 0) 2145 if (op->stats.hp < 0)
2262 op->stats.hp = op->stats.maxhp; 2146 op->stats.hp = op->stats.maxhp;
2263 2147
2264 if (op->stats.food < 0) 2148 if (op->stats.food < 0)
2265 op->stats.food = 999; 2149 op->stats.food = MAX_FOOD;
2266 2150
2267 op->update_stats (); 2151 op->update_stats ();
2268 return 1; 2152 return 1;
2269 } 2153 }
2270 2154
2271 LOG (llevError, "Error: LIFESAVE set without applied object.\n"); 2155 LOG (llevError, "Error: LIFESAVE set without applied object.\n");
2272 CLEAR_FLAG (op, FLAG_LIFESAVE); 2156 op->clr_flag (FLAG_LIFESAVE);
2273 enter_player_savebed (op); /* bring him home. */ 2157 enter_player_savebed (op); /* bring him home. */
2274 return 0; 2158 return 0;
2275} 2159}
2276 2160
2277/* This goes throws the inventory and removes unpaid objects, and puts them 2161/* This goes throws the inventory and removes unpaid objects, and puts them
2284{ 2168{
2285 while (op) 2169 while (op)
2286 { 2170 {
2287 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */ 2171 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2288 2172
2289 if (QUERY_FLAG (op, FLAG_UNPAID)) 2173 if (op->flag [FLAG_UNPAID])
2290 op->insert_at (env); 2174 op->insert_at (env);
2291 else if (op->inv) 2175 else if (op->inv)
2292 drop_unpaid_items (op->inv, env); 2176 drop_unpaid_items (op->inv, env);
2293 2177
2294 op = next; 2178 op = next;
2300{ 2184{
2301 if (!flag [FLAG_REMOVED]) 2185 if (!flag [FLAG_REMOVED])
2302 ::drop_unpaid_items (inv, this); 2186 ::drop_unpaid_items (inv, this);
2303} 2187}
2304 2188
2305/*
2306 * Returns pointer a static string containing gravestone text
2307 * Moved from apply.c to player.c - player.c is what
2308 * actually uses this function. player.c may not be quite the
2309 * best, a misc file for object actions is probably better,
2310 * but there isn't one in the server directory.
2311 */
2312const char *
2313gravestone_text (object *op)
2314{
2315 static dynbuf_text buf;
2316
2317 buf << "---- R.I.P. ----\n\n"
2318 << op->name;
2319
2320 if (op->type == PLAYER)
2321 buf << " the " << op->contr->title;
2322
2323 buf << "\n\n";
2324
2325 buf << "who was level ";
2326 buf << (sint32)op->level << "\n\n" // OO breakdown
2327 << " when " << (op->contr ? "killed" : "died") << "\n\n";
2328
2329 if (op->type == PLAYER)
2330 buf << "by " << op->contr->killer_name () << ".\n\n";
2331
2332 {
2333 static char buf2[128];
2334 time_t now = time (NULL);
2335 strftime (buf2, 128, "%b %d %Y\n\n", localtime (&now));
2336 buf << buf2;
2337 }
2338
2339 return buf;
2340}
2341
2342void 2189void
2343do_some_living (object *op) 2190do_some_living (object *op)
2344{ 2191{
2345 int last_food = op->stats.food; 2192 int last_food = op->stats.food;
2346 int gen_hp, gen_sp, gen_grace; 2193 int gen_hp, gen_sp, gen_grace;
2347 int over_hp, over_sp, over_grace;
2348 int i;
2349 int rate_hp = 1200; 2194 int rate_hp = 1200;
2350 int rate_sp = 2500; 2195 int rate_sp = 2500;
2351 int rate_grace = 2000; 2196 int rate_grace = 2000;
2352 const int max_hp = 1; 2197 const int max_hp = 1;
2353 const int max_sp = 1; 2198 const int max_sp = 1;
2354 const int max_grace = 1; 2199 const int max_grace = 1;
2355 2200
2201#if 0
2356 if (op->contr->hidden) 2202 if (op->contr->hidden)
2357 { 2203 {
2358 op->invisible = 1000; 2204 op->invisible = 1000;
2359 /* the socket code flashes the player visible/invisible 2205 /* the socket code flashes the player visible/invisible
2360 * depending on the value of invisible, so we need to 2206 * depending on the value of invisible, so we need to
2361 * alternate it here for it to work correctly. 2207 * alternate it here for it to work correctly.
2362 */ 2208 */
2363 if (pticks & 2) 2209 if (server_tick & 2)
2364 op->invisible--; 2210 op->invisible--;
2365 } 2211 }
2212 else
2213#endif
2366 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS))) 2214 if (op->invisible && !(op->flag [FLAG_MAKE_INVIS]))
2367 { 2215 {
2368 if (!op->invisible--) 2216 if (!op->invisible--)
2369 { 2217 {
2370 make_visible (op); 2218 make_visible (op);
2371 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out."); 2219 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2405 if (--op->last_grace < 0) 2253 if (--op->last_grace < 0)
2406 { 2254 {
2407 if (op->stats.grace < op->stats.maxgrace / 2) 2255 if (op->stats.grace < op->stats.maxgrace / 2)
2408 op->stats.grace++; /* no penalty in food for regaining grace */ 2256 op->stats.grace++; /* no penalty in food for regaining grace */
2409 2257
2258 int temp = gen_grace < 20 ? 30 : gen_grace + 10;
2259
2410 if (max_grace > 1) 2260 if (max_grace > 1)
2411 { 2261 {
2412 over_grace = (gen_grace < 20 ? 30 : gen_grace + 10) / rate_grace; 2262 int over_grace = temp / rate_grace;
2263
2413 if (over_grace > 0) 2264 if (over_grace > 0)
2414 { 2265 {
2415 op->stats.sp += over_grace 2266 op->stats.sp += over_grace + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > (temp % rate_grace)) ? -1 : 0;
2416 + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > ((gen_grace < 20 ? 30 : gen_grace + 10) % rate_grace)) ? -1 : 0;
2417 op->last_grace = 0; 2267 op->last_grace = 0;
2418 } 2268 }
2419 else 2269 else
2420 { 2270 op->last_grace = rate_grace / temp;
2421 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2422 }
2423 } 2271 }
2424 else 2272 else
2425 { 2273 op->last_grace = rate_grace / temp;
2426 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2274
2427 }
2428 /* wearing stuff doesn't detract from grace generation. */ 2275 /* wearing stuff doesn't detract from grace generation. */
2429 } 2276 }
2430 2277
2431 if (op->stats.food > 0) 2278 if (op->stats.food > 0)
2432 { 2279 {
2438 if (op->stats.sp < op->stats.maxsp) 2285 if (op->stats.sp < op->stats.maxsp)
2439 { 2286 {
2440 op->stats.sp++; 2287 op->stats.sp++;
2441 2288
2442 /* dms do not consume food */ 2289 /* dms do not consume food */
2443 if (!QUERY_FLAG (op, FLAG_WIZ)) 2290 if (!op->flag [FLAG_WIZ])
2444 { 2291 {
2445 op->stats.food--; 2292 op->stats.food--;
2446 2293
2447 if (op->contr->digestion < 0) 2294 if (op->contr->digestion < 0)
2448 op->stats.food += op->contr->digestion; 2295 op->stats.food += op->contr->digestion;
2451 } 2298 }
2452 } 2299 }
2453 2300
2454 if (max_sp > 1) 2301 if (max_sp > 1)
2455 { 2302 {
2456 over_sp = (gen_sp + 10) / rate_sp; 2303 int over_sp = (gen_sp + 10) / rate_sp;
2457 if (over_sp > 0) 2304 if (over_sp > 0)
2458 { 2305 {
2459 if (op->stats.sp < op->stats.maxsp) 2306 if (op->stats.sp < op->stats.maxsp)
2460 { 2307 {
2461 op->stats.sp += over_sp > max_sp ? max_sp : over_sp; 2308 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2482 if (op->stats.hp < op->stats.maxhp) 2329 if (op->stats.hp < op->stats.maxhp)
2483 { 2330 {
2484 op->stats.hp++; 2331 op->stats.hp++;
2485 2332
2486 /* dms do not consume food */ 2333 /* dms do not consume food */
2487 if (!QUERY_FLAG (op, FLAG_WIZ)) 2334 if (!op->flag [FLAG_WIZ])
2488 { 2335 {
2489 op->stats.food--; 2336 op->stats.food--;
2490 2337
2491 if (op->contr->digestion < 0) 2338 if (op->contr->digestion < 0)
2492 op->stats.food += op->contr->digestion; 2339 op->stats.food += op->contr->digestion;
2493 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2340 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2494 op->stats.food = last_food; 2341 op->stats.food = last_food;
2495 } 2342 }
2496 } 2343 }
2497 2344
2345 int temp = gen_hp < 20 ? 30 : gen_hp + 10;
2346
2498 if (max_hp > 1) 2347 if (max_hp > 1)
2499 { 2348 {
2500 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp; 2349 int over_hp = temp / rate_hp;
2501 2350
2502 if (over_hp > 0) 2351 if (over_hp > 0)
2503 { 2352 {
2504 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2353 op->stats.sp += over_hp + (random_roll (0, rate_hp - 1, op, PREFER_HIGH) > (temp % rate_hp)) ? -1 : 0;
2505 op->last_heal = 0; 2354 op->last_heal = 0;
2506 } 2355 }
2507 else 2356 else
2508 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2357 op->last_heal = rate_hp / temp;
2509 } 2358 }
2510 else 2359 else
2511 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2360 op->last_heal = rate_hp / temp;
2512 } 2361 }
2513 } 2362 }
2514 2363
2515 /* Digestion */ 2364 /* Digestion */
2516 if (--op->last_eat < 0) 2365 if (--op->last_eat < 0)
2519 penalty = max (0, -op->contr->digestion); 2368 penalty = max (0, -op->contr->digestion);
2520 2369
2521 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1); 2370 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2522 2371
2523 /* dms do not consume food */ 2372 /* dms do not consume food */
2524 if (!QUERY_FLAG (op, FLAG_WIZ)) 2373 if (!op->flag [FLAG_WIZ])
2525 op->stats.food--; 2374 op->stats.food--;
2526 } 2375 }
2527 2376
2528 if (op->stats.food < 0 && op->stats.hp >= 0) 2377 if (op->stats.food < 0 && op->stats.hp >= 0)
2529 { 2378 {
2530 object *flesh = 0; 2379 object *flesh = 0;
2531 2380
2532 for_inv_removable (op, tmp) 2381 for_inv_removable (op, tmp)
2533 { 2382 {
2534 if (QUERY_FLAG (tmp, FLAG_UNPAID)) 2383 if (tmp->flag [FLAG_UNPAID])
2535 continue; 2384 continue;
2536 2385
2537 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2386 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2538 { 2387 {
2539 op->statusmsg ("You blindly grab for a bite of food. " 2388 op->statusmsg ("You blindly grab for a bite of food. "
2540 "H<To prevent you from starving, you ate some random item from your backpack.>"); 2389 "H<To prevent you from starving, you ate some random item from your backpack.>");
2541 manual_apply (op, tmp, 0); 2390 op->apply (tmp);
2542 2391
2543 if (op->stats.food >= 0 || op->stats.hp < 0) 2392 if (op->stats.food >= 0 || op->stats.hp < 0)
2544 break; 2393 break;
2545 } 2394 }
2546 else if (tmp->type == FLESH) 2395 else if (tmp->type == FLESH)
2552 */ 2401 */
2553 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2402 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2554 { 2403 {
2555 op->statusmsg ("You blindly grab for a bite of food. " 2404 op->statusmsg ("You blindly grab for a bite of food. "
2556 "H<To prevent you from starving, you ate some random item from your backpack.>"); 2405 "H<To prevent you from starving, you ate some random item from your backpack.>");
2557 manual_apply (op, flesh, 0); 2406 op->apply (flesh);
2558 } 2407 }
2559 2408
2560 // If player is still starving, alert him! 2409 // If player is still starving, alert him!
2561 if (op->stats.food < 0) 2410 if (op->stats.food < 0)
2562 op->failmsg ("You are starving! " 2411 op->failmsg ("You are starving! "
2574 op->contr->killer->destroy (); 2423 op->contr->killer->destroy ();
2575 } 2424 }
2576 } 2425 }
2577 2426
2578 /* killer should be set here already */ 2427 /* killer should be set here already */
2579 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2428 if (op->stats.hp < 0 && !op->flag [FLAG_WIZ])
2580 kill_player (op); 2429 kill_player (op);
2581 } 2430 }
2582} 2431}
2583 2432
2584/* If the player should die (lack of hp, food, etc), we call this. 2433/* If the player should die (lack of hp, food, etc), we call this.
2588 */ 2437 */
2589void 2438void
2590kill_player (object *op) 2439kill_player (object *op)
2591{ 2440{
2592 int x, y; 2441 int x, y;
2593 char buf[MAX_BUF];
2594 maptile *map; /* this is for resurrection */ 2442 maptile *map; /* this is for resurrection */
2595 int will_kill_again; 2443 int will_kill_again;
2596 archetype *at; 2444 archetype *at;
2597 object *tmp; 2445 object *tmp;
2598 2446
2599 if (save_life (op)) 2447 if (save_life (op))
2600 return; 2448 return;
2449
2450 dynbuf_text deathtab;
2451
2452 /* restore player */
2453 at = archetype::find (shstr_poisoning);
2454 if (object *tmp = present_arch_in_ob (at, op))
2455 {
2456 tmp->destroy ();
2457 deathtab << "Your body feels cleansed...\r";
2458 }
2459
2460 at = archetype::find (shstr_confusion);
2461 if (object *tmp = present_arch_in_ob (at, op))
2462 {
2463 tmp->destroy ();
2464 deathtab << "Your mind feels clearer...\r";
2465 }
2466
2467 cure_disease (op, 0, 0); /* remove any disease */
2468
2469 max_it (op->stats.hp , op->stats.maxhp);
2470 max_it (op->stats.sp , op->stats.maxsp);
2471 max_it (op->stats.grace, op->stats.maxgrace);
2472 max_it (op->stats.food , 200);
2473
2474 // remove all spell effects that are active
2475 // to avoid long-term effects such as word-of-recall
2476 for (object *item = op->inv; item; )
2477 {
2478 object *next = item->below;
2479
2480 if (item->type == SPELL_EFFECT && item->active)
2481 item->destroy ();
2482
2483 item = next;
2484 }
2601 2485
2602 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2486 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2603 * in cities ONLY!!! It is very important that this doesn't get abused. 2487 * in cities ONLY!!! It is very important that this doesn't get abused.
2604 * Look at op_on_battleground() for more info --AndreasV 2488 * Look at op_on_battleground() for more info --AndreasV
2605 */ 2489 */
2606 if (op_on_battleground (op, &x, &y)) 2490 if (op_on_battleground (op, &x, &y))
2607 { 2491 {
2608 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2492 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2609 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2610
2611 /* restore player */
2612 at = archetype::find ("poisoning");
2613 if (object *tmp = present_arch_in_ob (at, op))
2614 {
2615 tmp->destroy ();
2616 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2617 }
2618
2619 at = archetype::find ("confusion");
2620 if (object *tmp = present_arch_in_ob (at, op))
2621 {
2622 tmp->destroy ();
2623 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2624 }
2625
2626 cure_disease (op, 0, 0); /* remove any disease */
2627 op->stats.hp = op->stats.maxhp;
2628 if (op->stats.food <= 0)
2629 op->stats.food = 999;
2630 2493
2631 /* create a bodypart-trophy to make the winner happy */ 2494 /* create a bodypart-trophy to make the winner happy */
2632 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2495 object *tmp = archetype::find (shstr_finger)->instance ();
2633 { 2496
2634 tmp->name = format ("%s's finger" , &op->name); 2497 tmp->name = format ("%s's finger" , &op->name);
2635 tmp->name_pl = format ("%s's fingers", &op->name); 2498 tmp->name_pl = format ("%s's fingers", &op->name);
2636 tmp->msg = format ( 2499 tmp->msg = format (
2637 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n", 2500 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2638 &op->name, op->contr->title, 2501 &op->name, op->contr->title,
2639 (int)op->level, 2502 (int)op->level,
2640 op->contr->killer_name () 2503 op->contr->killer_name ()
2641 ); 2504 );
2642 tmp->value = 0, tmp->type = 0; 2505 tmp->value = 0, tmp->type = 0;
2643 tmp->materialname = "organics"; 2506 tmp->material = name_to_material (shstr_organic);
2644 tmp->insert_at (op, tmp); 2507 tmp->insert_at (op, tmp);
2645 }
2646 2508
2647 /* teleport defeated player to new destination */ 2509 /* teleport defeated player to new destination */
2648 transfer_ob (op, x, y, 0, NULL); 2510 transfer_ob (op, x, y, 0, NULL);
2649 op->contr->braced = 0; 2511 op->contr->braced = 0;
2512
2513 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2650 return; 2514 return;
2651 } 2515 }
2516
2517 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2518 deathtab << "T<YOU HAVE DIED>\n\n";
2652 2519
2653 INVOKE_PLAYER (DEATH, op->contr); 2520 INVOKE_PLAYER (DEATH, op->contr);
2654 2521
2655 command_kill_pets (op, 0); 2522 command_kill_pets (op, 0);
2656 2523
2690 2557
2691 lost_a_stat = 0; 2558 lost_a_stat = 0;
2692 2559
2693 for (z = 0; z < num_stats_lose; z++) 2560 for (z = 0; z < num_stats_lose; z++)
2694 { 2561 {
2695 i = RANDOM () % NUM_STATS; 2562 i = rndm (NUM_STATS);
2696 2563
2697 if (settings.stat_loss_on_death) 2564 if (settings.stat_loss_on_death)
2698 { 2565 {
2699 /* Pick a random stat and take a point off it. Tell the player 2566 /* Pick a random stat and take a point off it. Tell the player
2700 * what he lost. 2567 * what he lost.
2707 lost_a_stat = 1; 2574 lost_a_stat = 1;
2708 } 2575 }
2709 else 2576 else
2710 { 2577 {
2711 /* deplete a stat */ 2578 /* deplete a stat */
2712 archetype *deparch = archetype::find ("depletion"); 2579 archetype *deparch = archetype::find (shstr_depletion);
2713 object *dep; 2580 object *dep;
2714 2581
2715 dep = present_arch_in_ob (deparch, op); 2582 dep = present_arch_in_ob (deparch, op);
2716 if (!dep) 2583 if (!dep)
2717 { 2584 {
2718 dep = arch_to_object (deparch); 2585 dep = deparch->instance ();
2719 insert_ob_in_ob (dep, op); 2586 insert_ob_in_ob (dep, op);
2720 } 2587 }
2721 lose_this_stat = 1; 2588 lose_this_stat = 1;
2722 if (settings.balanced_stat_loss) 2589 if (settings.balanced_stat_loss)
2723 { 2590 {
2735 2602
2736 /* There is a maximum depletion total per level. */ 2603 /* There is a maximum depletion total per level. */
2737 if (this_stat < -1 - op->level / BALSL_MAX_LOSS_RATIO) 2604 if (this_stat < -1 - op->level / BALSL_MAX_LOSS_RATIO)
2738 { 2605 {
2739 lose_this_stat = 0; 2606 lose_this_stat = 0;
2740 /* Take loss chance vs keep chance to see if we 2607 /* Take loss chance vs keep chance to see if we
2741 retain the stat. */ 2608 retain the stat. */
2742 } 2609 }
2743 else 2610 else
2744 { 2611 {
2745 if (random_roll (0, loss_chance + keep_chance - 1, op, PREFER_LOW) < keep_chance) 2612 if (random_roll (0, loss_chance + keep_chance - 1, op, PREFER_LOW) < keep_chance)
2751 } 2618 }
2752 } 2619 }
2753 2620
2754 if (lose_this_stat) 2621 if (lose_this_stat)
2755 { 2622 {
2756 this_stat = get_attr_value (&(dep->stats), i); 2623 this_stat = get_attr_value (&dep->stats, i);
2757 /* We could try to do something clever like find another 2624 /* We could try to do something clever like find another
2758 * stat to reduce if this fails. But chances are, if 2625 * stat to reduce if this fails. But chances are, if
2759 * stats have been depleted to -50, all are pretty low 2626 * stats have been depleted to -50, all are pretty low
2760 * and should be roughly the same, so it shouldn't make a 2627 * and should be roughly the same, so it shouldn't make a
2761 * difference. 2628 * difference.
2762 */ 2629 */
2763 if (this_stat >= -50) 2630 if (this_stat >= -50)
2764 { 2631 {
2765 change_attr_value (&(dep->stats), i, -1); 2632 change_attr_value (&(dep->stats), i, -1);
2766 SET_FLAG (dep, FLAG_APPLIED); 2633 dep->set_flag (FLAG_APPLIED);
2767 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]); 2634 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]);
2768 op->update_stats (); 2635 op->update_stats ();
2769 lost_a_stat = 1; 2636 lost_a_stat = 1;
2770 } 2637 }
2771 } 2638 }
2775 /* If no stat lost, tell the player. */ 2642 /* If no stat lost, tell the player. */
2776 if (!lost_a_stat) 2643 if (!lost_a_stat)
2777 { 2644 {
2778 /* determine_god() seems to not work sometimes... why is this? 2645 /* determine_god() seems to not work sometimes... why is this?
2779 Should I be using something else? GD */ 2646 Should I be using something else? GD */
2780 const char *god = determine_god (op); 2647 shstr_tmp god = determine_god (op);
2781 2648
2782 if (god && (strcmp (god, "none"))) 2649 if (god != shstr_none)
2783 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2650 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2784 else 2651 else
2785 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2652 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2786 } 2653 }
2787#else 2654#else
2788 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you from losing yourself completely."); 2655 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2789#endif 2656#endif
2790 2657
2791 /* Put a gravestone up where the character 'almost' died. List the 2658 /* Put a gravestone up where the character 'almost' died. List the
2792 * exp loss on the stone. 2659 * exp loss on the stone.
2793 */ 2660 */
2794 tmp = arch_to_object (archetype::find ("gravestone")); 2661 tmp = archetype::find (shstr_gravestone)->instance ();
2795 tmp->name = format ("%s's gravestone", &op->name); 2662 tmp->name = format ("%s's gravestone", &op->name);
2796 tmp->name_pl = format ("%s's gravestones", &op->name); 2663 tmp->name_pl = format ("%s's gravestones", &op->name);
2797 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n", 2664 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2798 &op->name, op->contr->title, op->contr->killer_name ()); 2665 &op->name, op->contr->title, op->contr->killer_name ());
2799 tmp->x = op->x, tmp->y = op->y; 2666 tmp->x = op->x, tmp->y = op->y;
2800 insert_ob_in_map (tmp, op->map, NULL, 0); 2667 insert_ob_in_map (tmp, op->map, NULL, 0);
2801 2668
2802 /**************************************/ 2669 /**************************************/
2803 /* */ 2670 /* */
2804 /* Subtract the experience points, */ 2671 /* Subtract the experience points, */
2805 /* if we died cause of food, give us */
2806 /* food, and reset HP's... */
2807 /* */ 2672 /* */
2808 /**************************************/ 2673 /**************************************/
2809 2674
2810 /* remove any poisoning and confusion the character may be suffering. */
2811 /* restore player */
2812 at = archetype::find ("poisoning");
2813 tmp = present_arch_in_ob (at, op);
2814
2815 if (tmp)
2816 {
2817 tmp->destroy ();
2818 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2819 }
2820
2821 at = archetype::find ("confusion");
2822 tmp = present_arch_in_ob (at, op);
2823 if (tmp)
2824 {
2825 tmp->destroy ();
2826 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2827 }
2828
2829 cure_disease (op, 0, 0); /* remove any disease */
2830
2831 // remove all spell effects that are active
2832 // to avoid long-term effects such as word-of-recall
2833 for (object *item = op->inv; item; )
2834 {
2835 object *next = item->below;
2836
2837 if (item->type == SPELL_EFFECT && item->active)
2838 item->destroy ();
2839
2840 item = next;
2841 }
2842
2843 /*add_exp(op, (op->stats.exp * -0.20)); */ 2675 /*add_exp(op, (op->stats.exp * -0.20)); */
2844 apply_death_exp_penalty (op); 2676 apply_death_exp_penalty (op);
2845
2846 if (op->stats.food < 100)
2847 op->stats.food = 900;
2848
2849 op->stats.hp = op->stats.maxhp;
2850 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2851 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2852 2677
2853 /* 2678 /*
2854 * Check to see if the player has any unpaid items. If so, remove them 2679 * Check to see if the player has any unpaid items. If so, remove them
2855 * and put them back in the map. 2680 * and put them back in the map.
2856 */ 2681 */
2880 if (will_kill_again) 2705 if (will_kill_again)
2881 { 2706 {
2882 object *force; 2707 object *force;
2883 int at; 2708 int at;
2884 2709
2885 force = get_archetype (FORCE_NAME); 2710 force = archetype::get (FORCE_NAME);
2886 /* 50 ticks should be enough time for the spell to abate */ 2711 /* 50 ticks should be enough time for the spell to abate */
2887 force->speed = 0.1f;
2888 force->speed_left = -5.f; 2712 force->speed_left = -5.f;
2889 SET_FLAG (force, FLAG_APPLIED); 2713 force->set_speed (0.1f);
2714 force->set_flag (FLAG_APPLIED);
2715
2890 for (at = 0; at < NROFATTACKS; at++) 2716 for (at = 0; at < NROFATTACKS; at++)
2891 if (will_kill_again & (1 << at)) 2717 if (will_kill_again & (1 << at))
2892 force->resist[at] = 100; 2718 force->resist[at] = 100;
2893 2719
2894 insert_ob_in_ob (force, op); 2720 insert_ob_in_ob (force, op);
2895 op->update_stats (); 2721 op->update_stats ();
2896 } 2722 }
2897 2723
2898 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2724 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2899} 2725}
2900 2726
2901void 2727static void
2902loot_object (object *op) 2728loot_object (object *op)
2903{ /* Grab and destroy some treasure */ 2729{ /* Grab and destroy some treasure */
2904 object *tmp, *tmp2, *next; 2730 object *tmp, *next;
2905 2731
2906 op->close_container (); /* close open sack first */ 2732 op->close_container (); /* close open sack first */
2907 2733
2908 for (tmp = op->inv; tmp; tmp = next) 2734 for (tmp = op->inv; tmp; tmp = next)
2909 { 2735 {
2916 tmp->x = op->x, tmp->y = op->y; 2742 tmp->x = op->x, tmp->y = op->y;
2917 2743
2918 if (tmp->type == CONTAINER) 2744 if (tmp->type == CONTAINER)
2919 loot_object (tmp); /* empty container to ground */ 2745 loot_object (tmp); /* empty container to ground */
2920 2746
2921 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3)))) 2747 if (!tmp->flag [FLAG_UNIQUE] && (tmp->flag [FLAG_STARTEQUIP] || tmp->flag [FLAG_NO_DROP] || !(rndm (3))))
2922 { 2748 {
2923 if (tmp->nrof > 1) 2749 if (tmp->nrof > 1)
2924 { 2750 {
2925 tmp->decrease (rndm (1, tmp->nrof - 1)); 2751 tmp->decrease (rndm (1, tmp->nrof - 1));
2926 insert_ob_in_map (tmp, op->map, NULL, 0); 2752 insert_ob_in_map (tmp, op->map, NULL, 0);
2937 * fix_weight(): Check recursively the weight of all players, and fix 2763 * fix_weight(): Check recursively the weight of all players, and fix
2938 * what needs to be fixed. Refresh windows and fix speed if anything 2764 * what needs to be fixed. Refresh windows and fix speed if anything
2939 * was changed. 2765 * was changed.
2940 */ 2766 */
2941void 2767void
2942fix_weight (void) 2768fix_weight ()
2943{ 2769{
2944 for_all_players (pl) 2770 for_all_players (pl)
2945 { 2771 {
2946 sint32 old = pl->ob->carrying; 2772 weight_t old = pl->ob->carrying;
2947 2773
2948 pl->ob->update_weight (); 2774 pl->ob->update_weight ();
2949 2775
2950 if (old != pl->ob->carrying) 2776 if (old != pl->ob->carrying)
2951 { 2777 {
2954 } 2780 }
2955 } 2781 }
2956} 2782}
2957 2783
2958void 2784void
2959fix_luck (void) 2785fix_luck ()
2960{ 2786{
2961 for_all_players (pl) 2787 for_all_players (pl)
2962 if (!pl->ob->contr->ns->state) 2788 if (!pl->ob->contr->ns->state)
2963 pl->ob->change_luck (0); 2789 pl->ob->change_luck (0);
2964} 2790}
3016} 2842}
3017 2843
3018int 2844int
3019is_true_undead (object *op) 2845is_true_undead (object *op)
3020{ 2846{
3021 if (QUERY_FLAG (op->arch, FLAG_UNDEAD)) 2847 if (op->arch->flag [FLAG_UNDEAD])
3022 return 1; 2848 return 1;
3023 2849
3024 return 0; 2850 return 0;
3025} 2851}
3026 2852
3036 2862
3037 if (!ob || !ob->map) 2863 if (!ob || !ob->map)
3038 return 0; 2864 return 0;
3039 2865
3040 /* so, on normal lighted maps, its hard to hide */ 2866 /* so, on normal lighted maps, its hard to hide */
3041 level = ob->map->darkness - 2; 2867 level = ob->map->darklevel () - 2;
3042 2868
3043 /* this also picks up whether the object is glowing. 2869 /* this also picks up whether the object is glowing.
3044 * If you carry a light on a non-dark map, its not 2870 * If you carry a light on a non-dark map, its not
3045 * as bad as carrying a light on a pitch dark map */ 2871 * as bad as carrying a light on a pitch dark map */
3046 if (has_carried_lights (ob)) 2872 if (ob->has_carried_lights ())
3047 level = -(10 + (2 * ob->map->darkness)); 2873 level = -(10 + (2 * ob->map->darklevel ()));
3048 2874
3049 /* scan through all nearby squares for terrain to hide in */ 2875 /* scan through all nearby squares for terrain to hide in */
3050 for (i = 0, x = ob->x, y = ob->y; 2876 for (i = 0, x = ob->x, y = ob->y;
3051 i <= SIZEOFFREE1; 2877 i <= SIZEOFFREE1;
3052 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2878 i++, x = ob->x + DIRX (i), y = ob->y + DIRY (i))
3053 { 2879 {
3054 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 2880 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3055 if (mflag & P_OUT_OF_MAP) 2881 if (mflag & P_OUT_OF_MAP)
3056 continue; 2882 continue;
3057 2883
3124 2950
3125 if (who->type == PLAYER) 2951 if (who->type == PLAYER)
3126 player = 1; 2952 player = 1;
3127 2953
3128 else 2954 else
3129 friendly = QUERY_FLAG (who, FLAG_FRIENDLY); 2955 friendly = who->flag [FLAG_FRIENDLY];
3130 2956
3131 /* search adjacent squares */ 2957 /* search adjacent squares */
3132 for (i = 1; i < 9; i++) 2958 for (i = 1; i < 9; i++)
3133 { 2959 {
3134 x = who->x + freearr_x[i]; 2960 x = who->x + DIRX (i);
3135 y = who->y + freearr_y[i]; 2961 y = who->y + DIRY (i);
3136 m = who->map; 2962 m = who->map;
3137 mflags = get_map_flags (m, &m, x, y, &x, &y); 2963 mflags = get_map_flags (m, &m, x, y, &x, &y);
3138 /* space must be blocked if there is a monster. If not 2964 /* space must be blocked if there is a monster. If not
3139 * blocked, don't need to check this space. 2965 * blocked, don't need to check this space.
3140 */ 2966 */
3143 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y))) 2969 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y)))
3144 continue; 2970 continue;
3145 2971
3146 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 2972 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
3147 { 2973 {
3148 if ((player ||friendly) &&QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_UNAGGRESSIVE)) 2974 if ((player ||friendly) &&tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_UNAGGRESSIVE])
3149 return 1; 2975 return 1;
3150 else if (tmp->type == PLAYER) 2976 else if (tmp->type == PLAYER)
3151 {
3152 /*don't let a hidden DM prevent you from hiding */
3153 if (!QUERY_FLAG (tmp, FLAG_WIZ) || tmp->contr->hidden == 0)
3154 return 1; 2977 return 1;
3155 }
3156 } 2978 }
3157 } 2979 }
3158 return 0; 2980 return 0;
3159} 2981}
3160 2982
3161/* check the player los field for viewability of the 2983/* check the player los field for viewability of the
3162 * object op. This function works fine for monsters, 2984 * object op. This function works fine for monsters,
3163 * but we dont worry if the object isnt the top one in 2985 * but we dont worry if the object isnt the top one in
3164 * a pile (say a coin under a table would return "viewable" 2986 * a pile (say a coin under a table would return "viewable"
3165 * by this routine). Another question, should we be 2987 * by this routine). Another question, should we be
3166 * concerned with the direction the player is looking 2988 * concerned with the direction the player is looking
3167 * in? Realistically, most of us can't see stuff behind 2989 * in? Realistically, most of us can't see stuff behind
3168 * our backs...on the other hand, does the "facing" direction 2990 * our backs...on the other hand, does the "facing" direction
3169 * imply the way your head, or body is facing? It's possible 2991 * imply the way your head, or body is facing? It's possible
3170 * for them to differ. Sigh, this fctn could get a bit more complex. 2992 * for them to differ. Sigh, this fctn could get a bit more complex.
3171 * -b.t. 2993 * -b.t.
3172 * This function is now map tiling safe. 2994 * This function is now map tiling safe.
3173 */ 2995 */
3174int 2996int
3175player_can_view (object *pl, object *op) 2997player_can_view (object *pl, object *op)
3176{ 2998{
3190 3012
3191 get_rangevector (pl, op, &rv, 0x1); 3013 get_rangevector (pl, op, &rv, 0x1);
3192 3014
3193 /* starting with the 'head' part, lets loop 3015 /* starting with the 'head' part, lets loop
3194 * through the object and find if it has any 3016 * through the object and find if it has any
3195 * part that is in the los array but isn't on 3017 * part that is in the los array but isn't on
3196 * a blocked los square. 3018 * a blocked los square.
3197 * we use the archetype to figure out offsets. 3019 * we use the archetype to figure out offsets.
3198 */ 3020 */
3199 while (op) 3021 while (op)
3200 { 3022 {
3201 dx = rv.distance_x + op->arch->x; 3023 dx = rv.distance_x + op->arch->x;
3202 dy = rv.distance_y + op->arch->y; 3024 dy = rv.distance_y + op->arch->y;
3203 3025
3204 /* only the viewable area the player sees is updated by LOS 3026 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3205 * code, so we need to restrict ourselves to that range of values
3206 * for any meaningful values.
3207 */
3208 if (abs (dx) <= (pl->contr->ns->mapx / 2) &&
3209 abs (dy) <= (pl->contr->ns->mapy / 2) &&
3210 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3211 return 1; 3027 return 1;
3212 3028
3213 op = op->more; 3029 op = op->more;
3214 }
3215
3216 return 0;
3217}
3218
3219/* routine for both players and monsters. We call this when
3220 * there is a possibility for our action distrubing our hiding
3221 * place or invisiblity spell. Artefact invisiblity is not
3222 * effected by this. If we arent invisible to begin with, we
3223 * return 0.
3224 */
3225int
3226action_makes_visible (object *op)
3227{
3228 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3229 {
3230 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3231 return 0;
3232
3233 if (op->contr && op->contr->tmp_invis == 0)
3234 return 0;
3235
3236 /* If monsters, they should become visible */
3237 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
3238 {
3239 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
3240 return 1;
3241 }
3242 } 3030 }
3243 3031
3244 return 0; 3032 return 0;
3245} 3033}
3246 3034
3261 * and the exit-coordinates sp/hp must both be > 0. 3049 * and the exit-coordinates sp/hp must both be > 0.
3262 * => The intention here is to prevent abuse of the battleground- 3050 * => The intention here is to prevent abuse of the battleground-
3263 * feature (like pickable or hidden battleground tiles). */ 3051 * feature (like pickable or hidden battleground tiles). */
3264 for (object *tmp = op->below; tmp; tmp = tmp->below) 3052 for (object *tmp = op->below; tmp; tmp = tmp->below)
3265 { 3053 {
3266 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3054 if (tmp->flag [FLAG_IS_FLOOR])
3267 { 3055 {
3268 if (QUERY_FLAG (tmp, FLAG_NO_PICK) 3056 if (tmp->flag [FLAG_NO_PICK]
3269 && tmp->type == BATTLEGROUND 3057 && tmp->type == BATTLEGROUND
3270 && tmp->name == shstr_battleground 3058 && tmp->name == shstr_battleground
3271 && EXIT_X (tmp) && EXIT_Y (tmp)) 3059 && EXIT_X (tmp) && EXIT_Y (tmp))
3272 { 3060 {
3273 /* before we assign the exit, check if this is a teambattle */ 3061 /* before we assign the exit, check if this is a teambattle */
3274 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3062 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3275 {
3276 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below) 3063 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3064 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3277 { 3065 {
3278 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3279 {
3280 if (x && y) 3066 if (x && y)
3281 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3067 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3282 3068
3283 return 1; 3069 return 1;
3284 }
3285 } 3070 }
3286 }
3287 3071
3288 if (x && y) 3072 if (x && y)
3289 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3073 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3290 3074
3291 return 1; 3075 return 1;
3429 else 3213 else
3430 j = 1; 3214 j = 1;
3431 strcat (buf, spellpathnames[i]); 3215 strcat (buf, spellpathnames[i]);
3432 } 3216 }
3433 } 3217 }
3218
3434 strcat (buf, "."); 3219 strcat (buf, ".");
3435 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf); 3220 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf);
3436 } 3221 }
3437 3222
3438 /* evtl. adding flags: */ 3223 /* evtl. adding flags: */
3439 if (QUERY_FLAG (item, FLAG_XRAYS)) 3224 if (item->flag [FLAG_XRAYS])
3440 SET_FLAG (skin, FLAG_XRAYS); 3225 skin->set_flag (FLAG_XRAYS);
3441 if (QUERY_FLAG (item, FLAG_STEALTH)) 3226 if (item->flag [FLAG_STEALTH])
3442 SET_FLAG (skin, FLAG_STEALTH); 3227 skin->set_flag (FLAG_STEALTH);
3443 if (QUERY_FLAG (item, FLAG_SEE_IN_DARK)) 3228 if (item->flag [FLAG_SEE_IN_DARK])
3444 SET_FLAG (skin, FLAG_SEE_IN_DARK); 3229 skin->set_flag (FLAG_SEE_IN_DARK);
3445 3230
3446 /* print message if there is one */ 3231 /* print message if there is one */
3447 if (item->msg != NULL) 3232 if (item->msg != NULL)
3448 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg); 3233 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg);
3449 } 3234 }
3450 else 3235 else
3451 { 3236 {
3452 /* generate misc. treasure */ 3237 /* generate misc. treasure */
3453 tmp = arch_to_object (tr->item); 3238 tmp = tr->item->instance ();
3454 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3239 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3455 who->insert (tmp); 3240 who->insert (tmp);
3456 } 3241 }
3457} 3242}
3458 3243
3459/** 3244//-GPL
3460 * Unready an object for a player. This function does nothing if the object was
3461 * not readied.
3462 */
3463void
3464player_unready_range_ob (player *pl, object *ob)
3465{
3466 if (pl->ob->current_weapon == ob)
3467 pl->ob->current_weapon = 0;
3468
3469 if (pl->combat_ob == ob)
3470 pl->combat_ob = 0;
3471
3472 if (pl->ranged_ob == ob)
3473 pl->ranged_ob = 0;
3474}
3475 3245
3476sint8 3246sint8
3477player::visibility_at (maptile *map, int x, int y) const 3247player::darkness_at (maptile *map, int x, int y) const
3478{ 3248{
3479 if (!ns) 3249 if (!ns)
3480 return 0; 3250 return LOS_BLOCKED;
3481 3251
3482 int dx, dy; 3252 int dx, dy;
3483 if (!adjacent_map (map, ns->current_map, &dx, &dy)) 3253 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3484 return 0; 3254 return LOS_BLOCKED;
3485 3255
3486 x += dx - ns->current_x + ns->mapx / 2; 3256 x += dx - ns->current_x;
3487 y += dy - ns->current_y + ns->mapy / 2; 3257 y += dy - ns->current_y;
3488 3258
3489 if (!IN_RANGE_EXC (x, 0, ns->mapx) || !IN_RANGE_EXC (y, 0, ns->mapy))
3490 return 0;
3491
3492 return 100 - blocked_los [x][y]; 3259 return blocked_los (x, y);
3493} 3260}
3494 3261
3495void 3262void
3496player::infobox (const char *title, const char *msg, int color) 3263player::infobox (const char *title, const char *msg, int color)
3497{ 3264{
3509{ 3276{
3510 play_sound (sound_find ("generic_failure")); 3277 play_sound (sound_find ("generic_failure"));
3511 statusmsg (msg, color); 3278 statusmsg (msg, color);
3512} 3279}
3513 3280
3281void
3282object::failmsgf (const char *format, ...)
3283{
3284 if (!contr)
3285 return;
3286
3287 va_list ap;
3288 va_start (ap, format);
3289 contr->failmsg (vformat (format, ap));
3290 va_end (ap);
3291}
3292
3293void
3294player::failmsgf (const char *format, ...)
3295{
3296 va_list ap;
3297 va_start (ap, format);
3298 failmsg (vformat (format, ap));
3299 va_end (ap);
3300}
3301

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines