ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.199 by root, Sat May 17 14:57:23 2008 UTC vs.
Revision 1.268 by root, Wed Apr 7 19:54:45 2010 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
24
25//+GPL
23 26
24#include <global.h> 27#include <global.h>
25#include <sproto.h> 28#include <sproto.h>
26#include <sounds.h> 29#include <sounds.h>
27#include <living.h> 30#include <living.h>
32#include <algorithm> 35#include <algorithm>
33#include <functional> 36#include <functional>
34 37
35playervec players; 38playervec players;
36 39
37void
38display_motd (const object *op)
39{
40 char buf[MAX_BUF];
41 char motd[HUGE_BUF];
42 FILE *fp;
43 int comp;
44 int size;
45
46 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
47 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
48 return;
49
50 motd[0] = '\0';
51 size = 0;
52
53 while (fgets (buf, MAX_BUF, fp))
54 {
55 if (*buf == '#')
56 continue;
57
58 strncat (motd + size, buf, HUGE_BUF - size);
59 size += strlen (buf);
60 }
61
62 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
63 close_and_delete (fp, comp);
64}
65
66void
67send_rules (const object *op)
68{
69 char buf[MAX_BUF];
70 char rules[HUGE_BUF];
71 FILE *fp;
72 int comp;
73 int size;
74
75 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
76 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
77 return;
78
79 rules[0] = '\0';
80 size = 0;
81
82 while (fgets (buf, MAX_BUF, fp))
83 {
84 if (*buf == '#')
85 continue;
86
87 if (size + strlen (buf) >= HUGE_BUF)
88 {
89 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
90 break;
91 }
92
93 strncat (rules + size, buf, HUGE_BUF - size);
94 size += strlen (buf);
95 }
96
97 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
98 close_and_delete (fp, comp);
99}
100
101void
102send_news (const object *op)
103{
104 char buf[MAX_BUF];
105 char news[HUGE_BUF];
106 char subject[MAX_BUF];
107 FILE *fp;
108 int comp;
109 int size;
110
111 sprintf (buf, "%s/%s", settings.confdir, settings.news);
112 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
113 return;
114
115 news[0] = '\0';
116 subject[0] = '\0';
117 size = 0;
118
119 while (fgets (buf, MAX_BUF, fp))
120 {
121 if (*buf == '#')
122 continue;
123
124 if (*buf == '%')
125 { /* send one news */
126 if (size > 0)
127 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
128 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS,
129 "INFORMATION: %s\n%s", (char *)"%s\n%s",
130 subject, news); /*send previously read news */
131
132 strcpy (subject, buf + 1);
133 strip_endline (subject);
134 size = 0;
135 news[0] = '\0';
136 }
137 else
138 {
139 if (size + strlen (buf) >= HUGE_BUF)
140 {
141 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
142 break;
143 }
144 strncat (news + size, buf, HUGE_BUF - size);
145 size += strlen (buf);
146 }
147 }
148
149 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
150 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", (char *)"%s\n%s", subject, news);
151 close_and_delete (fp, comp);
152}
153
154/* This loads the first map an puts the player on it. */ 40/* This loads the first map an puts the player on it. */
155static void 41static void
156set_first_map (object *op) 42set_first_map (object *op)
157{ 43{
158 op->contr->maplevel = first_map_path; 44 op->contr->maplevel = first_map_path;
190 ob->remove (); 76 ob->remove ();
191 ob->enemy = 0; // sometimes keeps an extra refcount on itself 77 ob->enemy = 0; // sometimes keeps an extra refcount on itself
192 ob->map = 0; 78 ob->map = 0;
193 party = 0; 79 party = 0;
194 80
195 combat_ob = ranged_ob = 0; //TODO, should be special marker, non-refcounted, not this
196
197 players.erase (this); 81 players.erase (this);
198} 82}
199 83
200// connect the player with a specific client 84// connect the player with a specific client
201// also changes, rationalises, and fixes some incorrect settings 85// also changes, rationalises, and fixes some incorrect settings
210 ob->close_container (); //TODO: client-specific 94 ob->close_container (); //TODO: client-specific
211 95
212 ns->update_look = 0; 96 ns->update_look = 0;
213 ns->look_position = 0; 97 ns->look_position = 0;
214 98
215 clear_los (this); 99 clear_los ();
216 100
217 ns->reset_stats (); 101 ns->reset_stats ();
218 102
219 /* make sure he's a player -- needed because of class change. */ 103 /* make sure he's a player -- needed because of class change. */
220 ob->type = PLAYER; // we are paranoid 104 ob->type = PLAYER; // we are paranoid
221 ob->race = ob->arch->race; 105 ob->race = ob->arch->race;
222 106
223 ob->update_weight (); 107 ob->update_weight ();
224 link_player_skills (ob); 108 link_skills ();
225
226 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
227 109
228 assign (title, ob->arch->object::name); 110 assign (title, ob->arch->object::name);
229 111
230 /* if it's a dragon player, set the correct title here */ 112 /* if it's a dragon player, set the correct title here */
231 if (is_dragon_pl (ob)) 113 if (ob->is_dragon ())
232 { 114 {
233 object *tmp, *abil = 0, *skin = 0; 115 object *tmp, *abil = 0, *skin = 0;
234 116
235 for (tmp = ob->inv; tmp; tmp = tmp->below) 117 for (tmp = ob->inv; tmp; tmp = tmp->below)
236 if (tmp->type == FORCE) 118 if (tmp->type == FORCE)
250 132
251 ns->floorbox_update (); 133 ns->floorbox_update ();
252 esrv_send_inventory (ob, ob); 134 esrv_send_inventory (ob, ob);
253 esrv_add_spells (this, 0); 135 esrv_add_spells (this, 0);
254 136
137 ob->flag [FLAG_READY_WEAPON] = false;
138 ob->flag [FLAG_READY_SKILL] = false;
139 ob->flag [FLAG_READY_RANGE] = false;
140 ob->flag [FLAG_READY_BOW] = false;
141
142 ob->update_stats (); // we unapplied stuff above
255 activate (); 143 activate ();
256
257 send_rules (ob);
258 send_news (ob);
259 display_motd (ob);
260 144
261 INVOKE_PLAYER (CONNECT, this); 145 INVOKE_PLAYER (CONNECT, this);
262 INVOKE_PLAYER (LOGIN, this); 146 INVOKE_PLAYER (LOGIN, this);
263} 147}
264 148
281 ns->reset_stats (); 165 ns->reset_stats ();
282 ns->pl = 0; 166 ns->pl = 0;
283 ns = 0; 167 ns = 0;
284 } 168 }
285 169
286 observe = ob; 170 // this is important for the player scheduler to get the correct refcount
171 // when ns = 0
172 observe = viewpoint = ob;
287 173
288 deactivate (); 174 deactivate ();
289} 175}
176
177//-GPL
290 178
291// the need for this function can be explained 179// the need for this function can be explained
292// by load_object not returning the object 180// by load_object not returning the object
293void 181void
294player::set_object (object *op) 182player::set_object (object *op)
295{ 183{
296 ob = observe = op; 184 ob = observe = viewpoint = op;
297 ob->contr = this; /* this aren't yet in archetype */ 185 ob->contr = this; /* this aren't yet in archetype */
298 186
299 ob->speed = 1.0f; 187 ob->speed = 1.0f;
300 ob->speed_left = 0.5f; 188 ob->speed_left = 0.5f;
301 189
302 ob->direction = 5; /* So player faces south */ 190 ob->direction = 5; /* So player faces south */
303
304 ob->flag [FLAG_READY_WEAPON] = false;
305 ob->flag [FLAG_READY_SKILL] = false;
306 ob->flag [FLAG_READY_BOW] = false;
307
308 for (object *op = ob->inv; op; op = op->below)
309 if (op->flag [FLAG_APPLIED])
310 switch (op->type)
311 {
312 case SKILL:
313 ob->flag [FLAG_APPLIED] = false;
314 break;
315
316 case WAND:
317 case ROD:
318 case HORN:
319 case BOW:
320 ranged_ob = op;
321 break;
322
323 case WEAPON:
324 combat_ob = op;
325 break;
326 }
327
328 ob->change_weapon (combat_ob ? combat_ob : ranged_ob);
329 ob->deactivate (); // change_weapon activates, fix this better
330} 191}
331 192
332void 193void
333player::set_observe (object *op) 194player::set_observe (object *op)
334{ 195{
335 observe = op ? op : ob; 196 observe = viewpoint = op ? op : ob;
336 do_los = 1; 197 do_los = 1;
337} 198}
199
200void
201player::set_viewpoint (object *op)
202{
203 viewpoint = op ? op : (object *)observe;
204 do_los = 1;
205}
206
207//+GPL
338 208
339player::player () 209player::player ()
340{ 210{
341 /* There are some elements we want initialised to non zero value - 211 /* There are some elements we want initialised to non zero value -
342 * we deal with that below this point. 212 * we deal with that below this point.
348 savebed_map = first_map_path; /* Init. respawn position */ 218 savebed_map = first_map_path; /* Init. respawn position */
349 219
350 gen_sp_armour = 10; 220 gen_sp_armour = 10;
351 bowtype = bow_normal; 221 bowtype = bow_normal;
352 petmode = pet_normal; 222 petmode = pet_normal;
353 listening = 10;
354 usekeys = containers; 223 usekeys = containers;
355 peaceful = 1; /* default peaceful */ 224 peaceful = 1; /* default peaceful */
356 do_los = 1; 225 do_los = 1;
357 226
358 weapon_sp = 1.0f; 227 weapon_sp = 1.0f;
365 disconnect (); 234 disconnect ();
366 235
367 attachable::do_destroy (); 236 attachable::do_destroy ();
368 237
369 if (ob) 238 if (ob)
370 {
371 ob->destroy_inv (false);
372 ob->destroy (); 239 ob->destroy ();
373 }
374 240
375 ob = observe = 0; 241 ob = observe = viewpoint = 0;
376} 242}
377 243
378player::~player () 244player::~player ()
379{ 245{
380 /* Clear item stack */ 246 /* Clear item stack */
381 free (stack_items); 247 free (stack_items);
248}
249
250/*
251 * get_player_archetype() return next player archetype from archetype
252 * list. Not very efficient routine, but used only creating new players.
253 * Note: there MUST be at least one player archetype!
254 */
255static archetype *
256get_player_archetype (archetype *at)
257{
258 // archetypes could have been reloaded
259 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
260
261 if (!nat)
262 return at;
263
264 archvec::iterator i = archetypes.find (nat);
265
266 for (;;)
267 {
268 if (++i == archetypes.end ())
269 i = archetypes.begin ();
270 else if (*i == at)
271 cleanup ("not a single player archetype found");
272
273 if ((*i)->type == PLAYER)
274 return *i;
275 }
382} 276}
383 277
384/* Tries to add player on the connection passed in ns. 278/* Tries to add player on the connection passed in ns.
385 * All we can really get in this is some settings like host and display 279 * All we can really get in this is some settings like host and display
386 * mode. 280 * mode.
388player * 282player *
389player::create () 283player::create ()
390{ 284{
391 player *pl = new player; 285 player *pl = new player;
392 286
393 pl->set_object (arch_to_object (get_player_archetype (0))); 287 pl->set_object (get_player_archetype (0)->instance ());
394 288
395 pl->ob->roll_stats (); 289 pl->ob->roll_stats ();
396 pl->ob->stats.wc = 2; 290 pl->ob->stats.wc = 2;
397 pl->ob->run_away = 25; /* Then we panick... */ 291 pl->ob->run_away = 25; /* Then we panick... */
398 292
399 set_first_map (pl->ob); 293 set_first_map (pl->ob);
400 294
401 return pl; 295 return pl;
402}
403
404/*
405 * get_player_archetype() return next player archetype from archetype
406 * list. Not very efficient routine, but used only creating new players.
407 * Note: there MUST be at least one player archetype!
408 */
409archetype *
410get_player_archetype (archetype *at)
411{
412 // archetypes could have been reloaded
413 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
414
415 if (!nat)
416 return at;
417
418 archvec::iterator i = archetypes.find (nat);
419
420 for (;;)
421 {
422 if (++i == archetypes.end ())
423 i = archetypes.begin ();
424 else if (*i == at)
425 cleanup ("not a single player archetype found");
426
427 if ((*i)->type == PLAYER)
428 return *i;
429 }
430} 296}
431 297
432object * 298object *
433get_nearest_player (object *mon) 299get_nearest_player (object *mon)
434{ 300{
674 op->destroy (); 540 op->destroy ();
675 continue; 541 continue;
676 } 542 }
677 } 543 }
678 544
679 /* This really needs to be better - we should really give 545 /* Here we remove duplicated skills (as duplicated spell objects have
680 * a substitute spellbook. The problem is that we don't really 546 * _very_ confusing effects for players), which could for instance be
681 * have a good idea what to replace it with (need something like 547 * generated by bad treasurelists. - elmex
682 * a first level treasurelist for each skill.)
683 * remove duplicate skills also
684 */ 548 */
685 if (op->type == SPELLBOOK || op->type == SKILL) 549 if (op->type == SKILL)
686 { 550 {
687 object *tmp;
688
689 for (tmp = op->below; tmp; tmp = tmp->below) 551 for (object *tmp = op->below; tmp; tmp = tmp->below)
690 if (tmp->type == op->type && tmp->name == op->name) 552 if (tmp->type == op->type && tmp->name == op->name)
691 break;
692
693 if (tmp)
694 { 553 {
695 op->destroy (); 554 op->destroy ();
555 LOG (llevError,
696 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 556 "give_initial_items: Removing duplicate skill %s\n", &tmp->name);
697 continue; 557 break;
698 } 558 }
699 559
700 if (op->nrof > 1) 560 if (op->nrof > 1)
701 op->nrof = 1; 561 op->nrof = 1;
702 } 562 }
703 563
729 else /* lock all 'normal items by default */ 589 else /* lock all 'normal items by default */
730 SET_FLAG (op, FLAG_INV_LOCKED); 590 SET_FLAG (op, FLAG_INV_LOCKED);
731 } /* for loop of objects in player inv */ 591 } /* for loop of objects in player inv */
732 592
733 /* Need to set up the skill pointers */ 593 /* Need to set up the skill pointers */
734 link_player_skills (pl); 594 pl->contr->link_skills ();
735} 595}
736 596
737void 597void
738get_party_password (object *op, partylist *party) 598get_party_password (object *op, partylist *party)
739{ 599{
749 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:"); 609 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:");
750} 610}
751 611
752/* This rolls four 1-6 rolls and sums the best 3 of the 4. */ 612/* This rolls four 1-6 rolls and sums the best 3 of the 4. */
753static int 613static int
754roll_stat (void) 614roll_stat ()
755{ 615{
756 int a[4], i, j, k; 616 int a[4], i, j, k;
757 617
758 for (i = 0; i < 4; i++) 618 for (i = 0; i < 4; i++)
759 a[i] = (int) rndm (6) + 1; 619 a[i] = (int) rndm (6) + 1;
856player::chargen_race_done () 716player::chargen_race_done ()
857{ 717{
858 /* this must before then initial items are given */ 718 /* this must before then initial items are given */
859 esrv_new_player (ob->contr); 719 esrv_new_player (ob->contr);
860 720
861 treasurelist *tl = treasurelist::find ("starting_wealth"); 721 treasurelist *tl = treasurelist::find (shstr_starting_wealth);
862 if (tl) 722 if (tl)
863 create_treasure (tl, ob, 0, 0, 0); 723 create_treasure (tl, ob, 0, 0, 0);
864 724
865 INVOKE_PLAYER (BIRTH, ob->contr); 725 INVOKE_PLAYER (BIRTH, ob->contr);
866 INVOKE_PLAYER (LOGIN, ob->contr); 726 INVOKE_PLAYER (LOGIN, ob->contr);
871 ob->msg = 0; 731 ob->msg = 0;
872 732
873 start_info (ob); 733 start_info (ob);
874 CLEAR_FLAG (ob, FLAG_WIZ); 734 CLEAR_FLAG (ob, FLAG_WIZ);
875 give_initial_items (ob, ob->randomitems); 735 give_initial_items (ob, ob->randomitems);
876 link_player_skills (ob);
877 esrv_send_inventory (ob, ob); 736 esrv_send_inventory (ob, ob);
878 ob->update_stats (); 737 ob->update_stats ();
879 738
880 /* This moves the player to a different start map, if there 739 /* This moves the player to a different start map, if there
881 * is one for this race 740 * is one for this race
920 ob->stats.hp = ob->stats.maxhp; 779 ob->stats.hp = ob->stats.maxhp;
921 ob->stats.sp = ob->stats.maxsp; 780 ob->stats.sp = ob->stats.maxsp;
922 ob->stats.grace = 0; 781 ob->stats.grace = 0;
923} 782}
924 783
925void 784static void
926flee_player (object *op) 785flee_player (object *op)
927{ 786{
928 int dir, diff; 787 int dir, diff;
929 rv_vector rv; 788 rv_vector rv;
930 789
933 LOG (llevDebug, "Fleeing player is dead.\n"); 792 LOG (llevDebug, "Fleeing player is dead.\n");
934 CLEAR_FLAG (op, FLAG_SCARED); 793 CLEAR_FLAG (op, FLAG_SCARED);
935 return; 794 return;
936 } 795 }
937 796
938 if (op->enemy == NULL) 797 if (!op->enemy)
939 { 798 {
940 LOG (llevDebug, "Fleeing player had no enemy.\n"); 799 LOG (llevDebug, "Fleeing player had no enemy.\n");
941 CLEAR_FLAG (op, FLAG_SCARED); 800 CLEAR_FLAG (op, FLAG_SCARED);
942 return; 801 return;
943 } 802 }
944 803
945 /* Seen some crashes here. Since we don't store an
946 * op->enemy_count, it is possible that something destroys the
947 * actual enemy, and the object is recycled.
948 */
949 if (op->enemy->map == NULL)
950 {
951 CLEAR_FLAG (op, FLAG_SCARED);
952 op->enemy = NULL;
953 return;
954 }
955
956 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0)) 804 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
957 { 805 {
958 op->enemy = NULL; 806 op->enemy = NULL;
959 CLEAR_FLAG (op, FLAG_SCARED); 807 CLEAR_FLAG (op, FLAG_SCARED);
960 return; 808 return;
963 get_rangevector (op, op->enemy, &rv, 0); 811 get_rangevector (op, op->enemy, &rv, 0);
964 812
965 dir = absdir (4 + rv.direction); 813 dir = absdir (4 + rv.direction);
966 for (diff = 0; diff < 3; diff++) 814 for (diff = 0; diff < 3; diff++)
967 { 815 {
968 int m = 1 - (RANDOM () & 2); 816 int m = 1 - rndm (2) * 2;
969 817
970 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 818 if (op->move (absdir (dir + diff * m)) || (diff == 0 && op->move (absdir (dir - diff * m))))
971 return; 819 return;
972 } 820 }
973 821
974 /* Cornered, get rid of scared */ 822 /* Cornered, get rid of scared */
975 CLEAR_FLAG (op, FLAG_SCARED); 823 CLEAR_FLAG (op, FLAG_SCARED);
984check_pick (object *op) 832check_pick (object *op)
985{ 833{
986 object *tmp, *next; 834 object *tmp, *next;
987 int stop = 0; 835 int stop = 0;
988 int wvratio; 836 int wvratio;
989 char putstring[128];
990 837
991 /* if you're flying, you cna't pick up anything */ 838 /* if you're flying, you can't pick up anything */
992 if (op->move_type & MOVE_FLYING) 839 if (op->move_type & MOVE_FLYING)
993 return 1; 840 return 1;
994 841
995 next = op->below; 842 next = op->below;
996 843
997 int cnt = MAX_ITEM_PER_DROP; 844 int cnt = MAX_ITEM_PER_ACTION;
998#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0) 845#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
999 846
1000 /* loop while there are items on the floor that are not marked as 847 /* loop while there are items on the floor that are not marked as
1001 * destroyed */ 848 * destroyed */
1002 while (next && !next->destroyed ()) 849 while (next && !next->destroyed ())
1018 865
1019 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 866 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1020 { 867 {
1021 if (item_matched_string (op, tmp, op->contr->search_str)) 868 if (item_matched_string (op, tmp, op->contr->search_str))
1022 CHK_PICK_PICKUP; 869 CHK_PICK_PICKUP;
870
1023 continue; 871 continue;
1024 } 872 }
1025 873
1026 /* high not bit set? We're using the old autopickup model */ 874 /* pickup handling */
875 if (op->contr->mode & PU_DEBUG)
876 {
877 /* some debugging code to figure out item information */
878 const char *str = tmp->name
879 ? format ("item name: %s item type: %d weight/value: %d",
880 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))))
881 : format ("item name: %s item type: %d weight/value: %d",
882 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
883
884 new_draw_info (NDI_UNIQUE, 0, op, str);
885 }
886
887 if (op->contr->mode & PU_INHIBIT)
888 return 1;
889
890 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
891 return 1;
892
893 /* philosophy:
894 * It's easy to grab an item type from a pile, as long as it's
895 * generic. This takes no game-time. For more detailed pickups
896 * and selections, select-items should be used. This is a
897 * grab-as-you-run type mode that's really useful for arrows for
898 * example.
899 * The drawback: right now it has no frontend, so you need to
900 * stick the bits you want into a calculator in hex mode and then
901 * convert to decimal and then 'pickup <#>
902 */
903
904 /* the first two modes are exclusive: if NOTHING we return, if
905 * STOP then we stop. All the rest are applied sequentially,
906 * meaning if any test passes, the item gets picked up. */
907
908 /* if mode is set to pick nothing up, return */
909 if (op->contr->mode == PU_NOTHING)
910 return 1;
911
912 /* if mode is set to stop when encountering objects, return */
913 /* take STOP before INHIBIT since it doesn't actually pick
914 * anything up */
915 if (op->contr->mode & PU_STOP)
916 return 0;
917
918 /* useful for going into stores and not losing your settings... */
919 /* and for battles wher you don't want to get loaded down while
920 * fighting */
921 if (op->contr->mode & PU_INHIBIT)
922 return 1;
923
924 /* prevent us from turning into auto-thieves :) */
925 if (QUERY_FLAG (tmp, FLAG_UNPAID))
926 continue;
927
928 /* ignore known cursed objects */
929 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED)
930 continue;
931
932 /* all food and drink if desired */
933 /* question: don't pick up known-poisonous stuff? */
1027 if (!(op->contr->mode & PU_NEWMODE)) 934 if (op->contr->mode & PU_FOOD)
935 if (tmp->type == FOOD)
1028 { 936 {
1029 switch (op->contr->mode) 937 CHK_PICK_PICKUP;
938 continue;
939 }
940
941 if (op->contr->mode & PU_DRINK)
942 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)))
943 {
944 CHK_PICK_PICKUP;
945 continue;
946 }
947
948 if (op->contr->mode & PU_POTION)
949 if (tmp->type == POTION)
950 {
951 CHK_PICK_PICKUP;
952 continue;
953 }
954
955 /* spellbooks, skillscrolls and normal books/scrolls */
956 if (op->contr->mode & PU_SPELLBOOK)
957 if (tmp->type == SPELLBOOK)
958 {
959 CHK_PICK_PICKUP;
960 continue;
961 }
962
963 if (op->contr->mode & PU_SKILLSCROLL)
964 if (tmp->type == SKILLSCROLL)
965 {
966 CHK_PICK_PICKUP;
967 continue;
968 }
969
970 if (op->contr->mode & PU_READABLES)
971 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
972 {
973 CHK_PICK_PICKUP;
974 continue;
975 }
976
977 /* wands/staves/rods/horns */
978 if (op->contr->mode & PU_MAGIC_DEVICE)
979 if (tmp->type == WAND
980 || tmp->type == ROD
981 || tmp->type == HORN
982 || tmp->type == POWER_CRYSTAL)
983 {
984 CHK_PICK_PICKUP;
985 continue;
986 }
987
988 /* pick up all magical items */
989 if (op->contr->mode & PU_MAGICAL)
990 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL)
991 && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
992 {
993 CHK_PICK_PICKUP;
994 continue;
995 }
996
997 if (op->contr->mode & PU_VALUABLES)
998 {
999 if (tmp->type == MONEY || tmp->type == GEM)
1030 { 1000 {
1031 case 0:
1032 return 1; /* don't pick up */
1033 case 1:
1034 CHK_PICK_PICKUP; 1001 CHK_PICK_PICKUP;
1035 return 1; 1002 continue;
1036 case 2:
1037 CHK_PICK_PICKUP;
1038 return 0;
1039 case 3:
1040 return 0; /* stop before pickup */
1041 case 4:
1042 CHK_PICK_PICKUP;
1043 break;
1044 case 5:
1045 CHK_PICK_PICKUP;
1046 stop = 1;
1047 break;
1048 case 6:
1049 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL)
1050 && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1051 CHK_PICK_PICKUP;
1052 break;
1053
1054 case 7:
1055 if (tmp->type == MONEY || tmp->type == GEM)
1056 CHK_PICK_PICKUP;
1057 break;
1058
1059 default:
1060 /* use value density */
1061 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1062 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1063 CHK_PICK_PICKUP;
1064 } 1003 }
1065 } 1004 }
1066 else 1005
1067 { /* old model */ 1006 /* rings & amulets - talismans seems to be typed AMULET */
1068 /* NEW pickup handling */
1069 if (op->contr->mode & PU_DEBUG) 1007 if (op->contr->mode & PU_JEWELS)
1008 if (tmp->type == RING
1009 || tmp->type == AMULET
1010 || tmp->type == GIRDLE
1011 || tmp->type == SKILL_TOOL)
1070 { 1012 {
1071 /* some debugging code to figure out item information */ 1013 CHK_PICK_PICKUP;
1072 if (tmp->name != NULL)
1073 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1074 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1075 else
1076 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1077 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1078
1079 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1080 }
1081
1082 /* philosophy:
1083 * It's easy to grab an item type from a pile, as long as it's
1084 * generic. This takes no game-time. For more detailed pickups
1085 * and selections, select-items should be used. This is a
1086 * grab-as-you-run type mode that's really useful for arrows for
1087 * example.
1088 * The drawback: right now it has no frontend, so you need to
1089 * stick the bits you want into a calculator in hex mode and then
1090 * convert to decimal and then 'pickup <#>
1091 */
1092
1093 /* the first two modes are exclusive: if NOTHING we return, if
1094 * STOP then we stop. All the rest are applied sequentially,
1095 * meaning if any test passes, the item gets picked up. */
1096
1097 /* if mode is set to pick nothing up, return */
1098
1099 if (op->contr->mode & PU_NOTHING)
1100 return 1;
1101
1102 /* if mode is set to stop when encountering objects, return */
1103 /* take STOP before INHIBIT since it doesn't actually pick
1104 * anything up */
1105
1106 if (op->contr->mode & PU_STOP)
1107 return 0;
1108
1109 /* useful for going into stores and not losing your settings... */
1110 /* and for battles wher you don't want to get loaded down while
1111 * fighting */
1112 if (op->contr->mode & PU_INHIBIT)
1113 return 1;
1114
1115 /* prevent us from turning into auto-thieves :) */
1116 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1117 continue; 1014 continue;
1015 }
1118 1016
1119 /* ignore known cursed objects */ 1017 /* we don't forget dragon food */
1120 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1018 if (op->contr->mode & PU_FLESH)
1019 if (tmp->type == FLESH)
1020 {
1021 CHK_PICK_PICKUP;
1121 continue; 1022 continue;
1023 }
1122 1024
1123 /* all food and drink if desired */ 1025 /* bows and arrows. Bows are good for selling! */
1124 /* question: don't pick up known-poisonous stuff? */ 1026 if (op->contr->mode & PU_BOW)
1027 if (tmp->type == BOW)
1028 {
1029 CHK_PICK_PICKUP;
1030 continue;
1031 }
1032
1033 if (op->contr->mode & PU_ARROW)
1034 if (tmp->type == ARROW)
1035 {
1036 CHK_PICK_PICKUP;
1037 continue;
1038 }
1039
1040 /* all kinds of armor etc. */
1041 if (op->contr->mode & PU_ARMOUR)
1042 if (tmp->type == ARMOUR)
1043 {
1044 CHK_PICK_PICKUP;
1045 continue;
1046 }
1047
1048 if (op->contr->mode & PU_HELMET)
1049 if (tmp->type == HELMET)
1050 {
1051 CHK_PICK_PICKUP;
1052 continue;
1053 }
1054
1055 if (op->contr->mode & PU_SHIELD)
1056 if (tmp->type == SHIELD)
1057 {
1058 CHK_PICK_PICKUP;
1059 continue;
1060 }
1061
1125 if (op->contr->mode & PU_FOOD) 1062 if (op->contr->mode & PU_BOOTS)
1126 if (tmp->type == FOOD) 1063 if (tmp->type == BOOTS)
1064 {
1065 CHK_PICK_PICKUP;
1066 continue;
1067 }
1068
1069 if (op->contr->mode & PU_GLOVES)
1070 if (tmp->type == GLOVES || tmp->type == BRACERS)
1071 {
1072 CHK_PICK_PICKUP;
1073 continue;
1074 }
1075
1076 if (op->contr->mode & PU_CLOAK)
1077 if (tmp->type == CLOAK)
1078 {
1079 CHK_PICK_PICKUP;
1080 continue;
1081 }
1082
1083 /* hoping to catch throwing daggers here */
1084 if (op->contr->mode & PU_MISSILEWEAPON)
1085 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1086 {
1087 CHK_PICK_PICKUP;
1088 continue;
1089 }
1090
1091 /* careful: chairs and tables are weapons! */
1092 if (op->contr->mode & PU_ALLWEAPON)
1093 {
1094 if (tmp->type == WEAPON)
1095 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1127 { 1096 {
1128 CHK_PICK_PICKUP; 1097 CHK_PICK_PICKUP;
1129 continue; 1098 continue;
1130 } 1099 }
1100 }
1131 1101
1102 /* misc stuff that's useful */
1132 if (op->contr->mode & PU_DRINK) 1103 if (op->contr->mode & PU_KEY)
1133 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1104 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1134 { 1105 {
1135 CHK_PICK_PICKUP; 1106 CHK_PICK_PICKUP;
1136 continue; 1107 continue;
1137 } 1108 }
1138 1109
1110 /* any of the last 4 bits set means we use the ratio for value
1111 * pickups */
1139 if (op->contr->mode & PU_POTION) 1112 if (op->contr->mode & PU_RATIO)
1140 if (tmp->type == POTION) 1113 {
1114 /* use value density to decide what else to grab */
1115 /* >=7 was >= op->contr->mode */
1116 /* >=7 is the old standard setting. Now we take the last 4 bits
1141 { 1117 */
1142 CHK_PICK_PICKUP;
1143 continue;
1144 }
1145
1146 /* spellbooks, skillscrolls and normal books/scrolls */
1147 if (op->contr->mode & PU_SPELLBOOK)
1148 if (tmp->type == SPELLBOOK)
1149 {
1150 CHK_PICK_PICKUP;
1151 continue;
1152 }
1153
1154 if (op->contr->mode & PU_SKILLSCROLL)
1155 if (tmp->type == SKILLSCROLL)
1156 {
1157 CHK_PICK_PICKUP;
1158 continue;
1159 }
1160
1161 if (op->contr->mode & PU_READABLES)
1162 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
1163 {
1164 CHK_PICK_PICKUP;
1165 continue;
1166 }
1167
1168 /* wands/staves/rods/horns */
1169 if (op->contr->mode & PU_MAGIC_DEVICE)
1170 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1171 {
1172 CHK_PICK_PICKUP;
1173 continue;
1174 }
1175
1176 /* pick up all magical items */
1177 if (op->contr->mode & PU_MAGICAL) 1118 wvratio = op->contr->mode & PU_RATIO;
1178 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1119 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1179 {
1180 CHK_PICK_PICKUP;
1181 continue;
1182 }
1183
1184 if (op->contr->mode & PU_VALUABLES)
1185 { 1120 {
1186 if (tmp->type == MONEY || tmp->type == GEM) 1121#if 0
1122 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1123 if (tmp->name != NULL)
1187 { 1124 {
1188 CHK_PICK_PICKUP; 1125 fprintf (stderr, "%s", tmp->name);
1189 continue;
1190 } 1126 }
1191 }
1192
1193 /* rings & amulets - talismans seems to be typed AMULET */
1194 if (op->contr->mode & PU_JEWELS)
1195 if (tmp->type == RING || tmp->type == AMULET)
1196 {
1197 CHK_PICK_PICKUP;
1198 continue;
1199 }
1200
1201 /* we don't forget dragon food */
1202 if (op->contr->mode & PU_FLESH)
1203 if (tmp->type == FLESH)
1204 {
1205 CHK_PICK_PICKUP;
1206 continue;
1207 }
1208
1209 /* bows and arrows. Bows are good for selling! */
1210 if (op->contr->mode & PU_BOW)
1211 if (tmp->type == BOW)
1212 {
1213 CHK_PICK_PICKUP;
1214 continue;
1215 }
1216
1217 if (op->contr->mode & PU_ARROW)
1218 if (tmp->type == ARROW)
1219 {
1220 CHK_PICK_PICKUP;
1221 continue;
1222 }
1223
1224 /* all kinds of armor etc. */
1225 if (op->contr->mode & PU_ARMOUR)
1226 if (tmp->type == ARMOUR)
1227 {
1228 CHK_PICK_PICKUP;
1229 continue;
1230 }
1231
1232 if (op->contr->mode & PU_HELMET)
1233 if (tmp->type == HELMET)
1234 {
1235 CHK_PICK_PICKUP;
1236 continue;
1237 }
1238
1239 if (op->contr->mode & PU_SHIELD)
1240 if (tmp->type == SHIELD)
1241 {
1242 CHK_PICK_PICKUP;
1243 continue;
1244 }
1245
1246 if (op->contr->mode & PU_BOOTS)
1247 if (tmp->type == BOOTS)
1248 {
1249 CHK_PICK_PICKUP;
1250 continue;
1251 }
1252
1253 if (op->contr->mode & PU_GLOVES)
1254 if (tmp->type == GLOVES)
1255 {
1256 CHK_PICK_PICKUP;
1257 continue;
1258 }
1259
1260 if (op->contr->mode & PU_CLOAK)
1261 if (tmp->type == CLOAK)
1262 {
1263 CHK_PICK_PICKUP;
1264 continue;
1265 }
1266
1267 /* hoping to catch throwing daggers here */
1268 if (op->contr->mode & PU_MISSILEWEAPON)
1269 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1270 {
1271 CHK_PICK_PICKUP;
1272 continue;
1273 }
1274
1275 /* careful: chairs and tables are weapons! */
1276 if (op->contr->mode & PU_ALLWEAPON)
1277 {
1278 if (tmp->type == WEAPON && tmp->name != NULL)
1279 {
1280 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->archname, "table") == NULL &&
1281 strstr (tmp->name, "chair") && strstr (tmp->arch->archname, "chair") == NULL)
1282 {
1283 CHK_PICK_PICKUP;
1284 continue;
1285 }
1286 }
1287
1288 if (tmp->type == WEAPON && tmp->name == NULL)
1289 {
1290 if (strstr (tmp->arch->archname, "table") == NULL && strstr (tmp->arch->archname, "chair") == NULL)
1291 {
1292 CHK_PICK_PICKUP;
1293 continue;
1294 }
1295 }
1296 }
1297
1298 /* misc stuff that's useful */
1299 if (op->contr->mode & PU_KEY)
1300 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1301 {
1302 CHK_PICK_PICKUP;
1303 continue;
1304 }
1305
1306 /* any of the last 4 bits set means we use the ratio for value
1307 * pickups */
1308 if (op->contr->mode & PU_RATIO)
1309 {
1310 /* use value density to decide what else to grab */
1311 /* >=7 was >= op->contr->mode */
1312 /* >=7 is the old standard setting. Now we take the last 4 bits
1313 * and multiply them by 5, giving 0..15*5== 5..75 */
1314 wvratio = (op->contr->mode & PU_RATIO) * 5;
1315 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio)
1316 {
1317 CHK_PICK_PICKUP;
1318#if 0
1319 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1320 if (tmp->name != NULL)
1321 {
1322 fprintf (stderr, "%s", tmp->name);
1323 }
1324 else 1127 else
1325 fprintf (stderr, "%s", tmp->arch->archname); 1128 fprintf (stderr, "%s", tmp->arch->archname);
1326 fprintf (stderr, ",%d] = ", tmp->type); 1129 fprintf (stderr, ",%d] = ", tmp->type);
1327 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1130 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
1328#endif 1131#endif
1132 CHK_PICK_PICKUP;
1329 continue; 1133 continue;
1330 }
1331 } 1134 }
1332 } /* the new pickup model */ 1135 } /* the new pickup model */
1333 } 1136 }
1334 1137
1335 return !stop; 1138 return !stop;
1139}
1140
1141/* routine for both players and monsters. We call this when
1142 * there is a possibility for our action distrubing our hiding
1143 * place or invisiblity spell. Artefact invisiblity causes
1144 * "noise" instead. If we arent invisible to begin with, we
1145 * return 0.
1146 */
1147static int
1148action_makes_visible (object *op)
1149{
1150 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
1151 {
1152 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
1153 {
1154 // artefact invisibility is permanent, but we still make noise
1155 // this is important for game-balance.
1156 if (op->contr)
1157 op->make_noise ();
1158
1159 return 0;
1160 }
1161
1162 if (op->contr && op->contr->tmp_invis == 0)
1163 return 0;
1164
1165 /* If monsters, they should become visible */
1166 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
1167 {
1168 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
1169 return 1;
1170 }
1171 }
1172
1173 return 0;
1336} 1174}
1337 1175
1338/* 1176/*
1339 * Find an arrow in the inventory and after that 1177 * Find an arrow in the inventory and after that
1340 * in the right type container (quiver). Pointer to the 1178 * in the right type container (quiver). Pointer to the
1341 * found object is returned. 1179 * found object is returned.
1342 */ 1180 */
1343object * 1181static object *
1344find_arrow (object *op, const char *type) 1182find_arrow (object *op, const char *type)
1345{ 1183{
1346 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1184 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1347 if (tmp->type == ARROW && !strcmp (&tmp->race, type)) 1185 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1348 return splay (tmp); 1186 return splay (tmp);
1362 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1200 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1363 * against the target. A full test is not performed, simply a basic test 1201 * against the target. A full test is not performed, simply a basic test
1364 * of resistances. The archer is making a quick guess at what he sees down 1202 * of resistances. The archer is making a quick guess at what he sees down
1365 * the hall. Failing that it does it's best to pick the highest plus arrow. 1203 * the hall. Failing that it does it's best to pick the highest plus arrow.
1366 */ 1204 */
1367object * 1205static object *
1368find_better_arrow (object *op, object *target, const char *type, int *better) 1206find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1369{ 1207{
1370 object *tmp = NULL, *arrow, *ntmp; 1208 object *tmp = NULL, *arrow, *ntmp;
1371 int attacknum, attacktype, betterby = 0, i; 1209 int attacknum, attacktype, betterby = 0, i;
1372 1210
1373 if (!type) 1211 if (!type)
1377 { 1215 {
1378 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1216 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED))
1379 { 1217 {
1380 i = 0; 1218 i = 0;
1381 ntmp = find_better_arrow (arrow, target, type, &i); 1219 ntmp = find_better_arrow (arrow, target, type, &i);
1220
1382 if (i > betterby) 1221 if (i > betterby)
1383 { 1222 {
1384 tmp = ntmp; 1223 tmp = ntmp;
1385 betterby = i; 1224 betterby = i;
1386 } 1225 }
1387 } 1226 }
1388 else if (arrow->type == ARROW && arrow->race == type) 1227 else if (arrow->type == ARROW && arrow->race == type)
1389 { 1228 {
1390 /* allways prefer assasination/slaying */ 1229 /* allways prefer assasination/slaying */
1391 if (target->race && arrow->slaying && strstr (arrow->slaying, target->race)) 1230 if (target->race && arrow->slaying.contains (target->race))
1392 { 1231 {
1393 if (arrow->attacktype & AT_DEATH) 1232 if (arrow->attacktype & AT_DEATH)
1394 { 1233 {
1395 *better = 100; 1234 *better = 100;
1396 return arrow; 1235 return arrow;
1411 { 1250 {
1412 tmp = arrow; 1251 tmp = arrow;
1413 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100; 1252 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1414 } 1253 }
1415 } 1254 }
1255
1416 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1256 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1417 { 1257 {
1418 tmp = arrow; 1258 tmp = arrow;
1419 betterby = 2 + arrow->magic + arrow->stats.dam; 1259 betterby = 2 + arrow->magic + arrow->stats.dam;
1420 } 1260 }
1261
1421 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1262 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1422 { 1263 {
1423 tmp = arrow; 1264 tmp = arrow;
1424 betterby = 1 + arrow->magic + arrow->stats.dam; 1265 betterby = 1 + arrow->magic + arrow->stats.dam;
1425 } 1266 }
1438 * find_better_arrow to find a decent arrow to use. 1279 * find_better_arrow to find a decent arrow to use.
1439 * op = the shooter 1280 * op = the shooter
1440 * type = bow->race 1281 * type = bow->race
1441 * dir = fire direction 1282 * dir = fire direction
1442 */ 1283 */
1443object * 1284static object *
1444pick_arrow_target (object *op, const char *type, int dir) 1285pick_arrow_target (object *op, shstr_cmp type, int dir)
1445{ 1286{
1446 object *tmp = NULL; 1287 object *tmp = NULL;
1447 maptile *m; 1288 maptile *m;
1448 int i, mflags, found, number; 1289 int i, mflags, found, number;
1449 sint16 x, y; 1290 sint16 x, y;
1464 for (i = 0, found = 0; i < 20; i++) 1305 for (i = 0, found = 0; i < 20; i++)
1465 { 1306 {
1466 x += freearr_x[dir]; 1307 x += freearr_x[dir];
1467 y += freearr_y[dir]; 1308 y += freearr_y[dir];
1468 mflags = get_map_flags (m, &m, x, y, &x, &y); 1309 mflags = get_map_flags (m, &m, x, y, &x, &y);
1310
1469 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1311 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1470 { 1312 {
1471 tmp = NULL; 1313 tmp = 0;
1472 break; 1314 break;
1473 } 1315 }
1474 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1316 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1475 { 1317 {
1476 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1318 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1477 * perhaps a bad assumption. 1319 * perhaps a bad assumption.
1478 */ 1320 */
1479 tmp = NULL; 1321 tmp = 0;
1480 break; 1322 break;
1481 } 1323 }
1324
1482 if (mflags & P_IS_ALIVE) 1325 if (mflags & P_IS_ALIVE)
1483 {
1484 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1326 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1485 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1327 if (QUERY_FLAG (tmp, FLAG_ALIVE))
1486 {
1487 found++;
1488 break;
1489 }
1490 if (found)
1491 break; 1328 break;
1492 }
1493 } 1329 }
1494 if (tmp == NULL) 1330
1331 if (!tmp)
1495 return find_arrow (op, type); 1332 return find_arrow (op, type);
1496 1333
1497 if (tmp->head) 1334 if (tmp->head)
1498 tmp = tmp->head; 1335 tmp = tmp->head;
1499 1336
1539 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1376 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1540 return 0; 1377 return 0;
1541 } 1378 }
1542 1379
1543 // optimisation: move object to top so we will find it quickly again 1380 // optimisation: move object to top so we will find it quickly again
1544 if (bow->below) 1381 splay (bow);
1545 {
1546 bow->remove ();
1547 op->insert (bow);
1548 }
1549
1550 } 1382 }
1551 1383
1552 if (!bow->race || !bow->skill) 1384 if (!bow->race || !bow->skill)
1553 { 1385 {
1554 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1386 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1580 } 1412 }
1581 1413
1582 /* this should not happen, but sometimes does */ 1414 /* this should not happen, but sometimes does */
1583 if (arrow->nrof == 0) 1415 if (arrow->nrof == 0)
1584 { 1416 {
1417 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1585 arrow->destroy (); 1418 arrow->destroy ();
1586 return 0; 1419 return 0;
1587 } 1420 }
1588 1421
1589 left = arrow; /* these are arrows left to the player */ 1422 left = arrow; /* these are arrows left to the player */
1599 arrow->direction = dir; 1432 arrow->direction = dir;
1600 1433
1601 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */ 1434 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1602 arrow->stats.hp = arrow->stats.dam; 1435 arrow->stats.hp = arrow->stats.dam;
1603 arrow->stats.grace = arrow->attacktype; 1436 arrow->stats.grace = arrow->attacktype;
1604 1437 arrow->custom_name = arrow->slaying;
1605 if (arrow->slaying)
1606 arrow->spellarg = strdup (arrow->slaying);
1607 1438
1608#if 0 1439#if 0
1609 if (player *pl = op->contr) 1440 if (player *pl = op->contr)
1610 { 1441 {
1611 float speed = pl->weapon_sp; 1442 float speed = pl->weapon_sp;
1673 * but monsters can't. Putting that code here 1504 * but monsters can't. Putting that code here
1674 * makes the fire_bow code much cleaner. 1505 * makes the fire_bow code much cleaner.
1675 * this function should only be called if 'op' is a player, 1506 * this function should only be called if 'op' is a player,
1676 * hence the function name. 1507 * hence the function name.
1677 */ 1508 */
1678int 1509static int
1679player_fire_bow (object *op, int dir) 1510player_fire_bow (object *op, int dir)
1680{ 1511{
1681 int ret = 0, wcmod = 0; 1512 int ret;
1682 1513
1683 if (op->contr->bowtype == bow_bestarrow) 1514 if (op->contr->bowtype == bow_bestarrow)
1684 { 1515 {
1685 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y); 1516 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1686 } 1517 }
1687 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1518 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1688 { 1519 {
1689 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1520 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1690 wcmod = -1;
1691
1692 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1521 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1693 } 1522 }
1694 else if (op->contr->bowtype == bow_threewide) 1523 else if (op->contr->bowtype == bow_threewide)
1695 { 1524 {
1696 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1525 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1697 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1526 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]);
1698 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1527 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]);
1699 } 1528 }
1700 else if (op->contr->bowtype == bow_spreadshot) 1529 else if (op->contr->bowtype == bow_spreadshot)
1701 { 1530 {
1702 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1531 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1703 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1532 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1704 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1533 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1705 } 1534 }
1706 else 1535 else
1707 { 1536 {
1713} 1542}
1714 1543
1715/* Fires a misc (wand/rod/horn) object in 'dir'. 1544/* Fires a misc (wand/rod/horn) object in 'dir'.
1716 * Broken apart from 'fire' to keep it more readable. 1545 * Broken apart from 'fire' to keep it more readable.
1717 */ 1546 */
1718void 1547static void
1719fire_misc_object (object *op, int dir) 1548fire_misc_object (object *op, int dir)
1720{ 1549{
1721 object *item = op->contr->ranged_ob; 1550 object *item = op->contr->ranged_ob;
1722 1551
1723 if (!item) 1552 if (!item)
1730 { 1559 {
1731 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1560 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1732 return; 1561 return;
1733 } 1562 }
1734 1563
1735 if (!op->change_weapon (item)) 1564 if (!op->apply (item))
1736 return; 1565 return;
1737 1566
1738 if (item->type == WAND) 1567 if (item->type == WAND)
1739 { 1568 {
1740 if (item->stats.food <= 0) 1569 if (item->stats.food <= 0)
1745 return; 1574 return;
1746 } 1575 }
1747 } 1576 }
1748 else if (item->type == ROD || item->type == HORN) 1577 else if (item->type == ROD || item->type == HORN)
1749 { 1578 {
1750 sint16 spell_sp = MAX (item->inv->stats.sp, item->inv->stats.grace); 1579 sint16 spell_sp = max (item->inv->stats.sp, item->inv->stats.grace);
1751 1580
1752 // using the maximum of the rods charge allows at least one spell cast 1581 // using the maximum of the rods charge allows at least one spell cast
1753 // for a rod or horn, this fixes some broken rods. 1582 // for a rod or horn, this fixes some broken rods.
1754 if (item->stats.hp < MIN (spell_sp, item->stats.maxhp)) 1583 if (item->stats.hp < min (spell_sp, item->stats.maxhp))
1755 { 1584 {
1756 op->contr->play_sound (sound_find ("wand_poof")); 1585 op->contr->play_sound (sound_find ("wand_poof"));
1757 1586
1758 if (item->type == ROD) 1587 if (item->type == ROD)
1759 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1588 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1764 } 1593 }
1765 } 1594 }
1766 1595
1767 if (cast_spell (op, item, dir, item->inv, NULL)) 1596 if (cast_spell (op, item, dir, item->inv, NULL))
1768 { 1597 {
1769 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1598 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1599
1770 if (item->type == WAND) 1600 if (item->type == WAND)
1771 { 1601 {
1772 if (!(--item->stats.food)) 1602 if (!(--item->stats.food))
1773 { 1603 {
1774 object *tmp; 1604 object *tmp;
1790} 1620}
1791 1621
1792/* Received a fire command for the player - go and do it. 1622/* Received a fire command for the player - go and do it.
1793 */ 1623 */
1794bool 1624bool
1795fire (object *op, int dir) 1625fire (object *who, int dir)
1796{ 1626{
1797 int spellcost = 0; 1627 int spellcost = 0;
1798 1628
1799 /* check for loss of invisiblity/hide */
1800 if (action_makes_visible (op))
1801 make_visible (op);
1802
1803 player *pl = op->contr; 1629 player *pl = who->contr;
1804 1630
1805 if (pl->golem) 1631 if (pl->golem)
1806 { 1632 {
1807 control_golem (op->contr->golem, dir); 1633 control_golem (who->contr->golem, dir);
1808 return false; 1634 return false;
1809 } 1635 }
1810 1636
1811 object *ob = pl->ranged_ob; 1637 object *ob = pl->ranged_ob;
1812 1638
1813 if (!ob) 1639 if (!ob)
1814 return false; 1640 return false;
1815 1641
1816 if (!op->change_weapon (ob))
1817 return false;
1818
1819 if (op->speed_left > 0.f) 1642 if (who->speed_left > 0.f)
1820 --op->speed_left; 1643 --who->speed_left;
1821 else 1644 else
1822 return false; 1645 return false;
1823 1646
1647 if (!who->apply (ob))
1648 return false;
1649
1650 /* check for loss of invisiblity/hide */
1651 if (action_makes_visible (who))
1652 make_visible (who);
1653
1824 switch (ob->type) 1654 switch (ob->type)
1825 { 1655 {
1826 case BOW: 1656 case BOW:
1827 player_fire_bow (op, dir); 1657 player_fire_bow (who, dir);
1828 break; 1658 break;
1829 1659
1830 case SPELL: 1660 case SPELL:
1831 spellcost = cast_spell (op, op, dir, ob, pl->spellparam[0] ? pl->spellparam : 0); 1661 spellcost = cast_spell (who, who, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1832 break; 1662 break;
1833 1663
1834 case BUILDER: 1664 case BUILDER:
1835 apply_map_builder (op, dir); 1665 apply_map_builder (who, dir);
1836 break; 1666 break;
1837 1667
1838 case SKILL: 1668 case SKILL:
1839 do_skill (op, op, ob, dir, 0); 1669 do_skill (who, who, ob, dir, 0);
1840 break; 1670 break;
1841 1671
1672 case RANGED:
1673 do_skill (who, ob, who->chosen_skill, dir, 0);
1674 break;
1675
1842 default: 1676 default:
1843 fire_misc_object (op, dir); 1677 fire_misc_object (who, dir);
1844 break; 1678 break;
1845 } 1679 }
1846 1680
1847 return true; 1681 return true;
1848} 1682}
1849 1683
1850/* find_key 1684static object *
1851 * We try to find a key for the door as passed. If we find a key
1852 * and successfully use it, we return the key, otherwise NULL
1853 * This function merges both normal and locked door, since the logic
1854 * for both is the same - just the specific key is different.
1855 * pl is the player,
1856 * inv is the objects inventory to searched
1857 * door is the door we are trying to match against.
1858 * This function can be called recursively to search containers.
1859 */
1860object *
1861find_key (object *pl, object *container, object *door) 1685find_key_ (object *pl, object *container, object *door)
1862{ 1686{
1863 object *tmp, *key; 1687 object *tmp, *key;
1864 1688
1865 /* Should not happen, but sanity checking is never bad */ 1689 /* Should not happen, but sanity checking is never bad */
1866 if (!container->inv) 1690 if (!container->inv)
1869 /* First, lets try to find a key in the top level inventory */ 1693 /* First, lets try to find a key in the top level inventory */
1870 for (tmp = container->inv; tmp; tmp = tmp->below) 1694 for (tmp = container->inv; tmp; tmp = tmp->below)
1871 { 1695 {
1872 if (door->type == DOOR && tmp->type == KEY) 1696 if (door->type == DOOR && tmp->type == KEY)
1873 break; 1697 break;
1698
1874 /* For sanity, we should really check door type, but other stuff 1699 /* For sanity, we should really check door type, but other stuff
1875 * (like containers) can be locked with special keys 1700 * (like containers) can be locked with special keys
1876 */ 1701 */
1877 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1702 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1878 break; 1703 break;
1884 * a key, return 1709 * a key, return
1885 */ 1710 */
1886 if (!tmp) 1711 if (!tmp)
1887 { 1712 {
1888 for (tmp = container->inv; tmp; tmp = tmp->below) 1713 for (tmp = container->inv; tmp; tmp = tmp->below)
1889 {
1890 /* No reason to search empty containers */ 1714 /* No reason to search empty containers */
1891 if (tmp->type == CONTAINER && tmp->inv) 1715 if (tmp->type == CONTAINER && tmp->inv)
1892 {
1893 if ((key = find_key (pl, tmp, door))) 1716 if ((key = find_key_ (pl, tmp, door)))
1894 return key; 1717 return key;
1895 }
1896 }
1897 1718
1898 if (!tmp) 1719 if (!tmp)
1899 return NULL; 1720 return 0;
1900 } 1721 }
1901 1722
1902 /* We get down here if we have found a key. Now if its in a container, 1723 /* We get down here if we have found a key. Now if its in a container,
1903 * see if we actually want to use it 1724 * see if we actually want to use it
1904 */ 1725 */
1905 if (pl != container) 1726 if (pl != container)
1906 { 1727 {
1907 /* Only let players use keys in containers */ 1728 /* Only let players use keys in containers */
1908 if (!pl->contr) 1729 if (!pl->contr)
1909 return NULL; 1730 return 0;
1731
1910 /* cases where this fails: 1732 /* cases where this fails:
1911 * If we only search the player inventory, return now since we 1733 * If we only search the player inventory, return now since we
1912 * are not in the players inventory. 1734 * are not in the players inventory.
1913 * If the container is not active, return now since only active 1735 * If the container is not active, return now since only active
1914 * containers can be used. 1736 * containers can be used.
1918 * inv must have been an container and must have been active. 1740 * inv must have been an container and must have been active.
1919 * 1741 *
1920 * Change the color so that the message doesn't disappear with 1742 * Change the color so that the message doesn't disappear with
1921 * all the others. 1743 * all the others.
1922 */ 1744 */
1923 if (pl->contr->usekeys == key_inventory || 1745 if (pl->contr->usekeys == key_inventory
1924 !QUERY_FLAG (container, FLAG_APPLIED) || 1746 || !QUERY_FLAG (container, FLAG_APPLIED)
1925 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1747 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
1926 { 1748 {
1927 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1749 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1928 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1750 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1929 return NULL; 1751 return NULL;
1930 } 1752 }
1931 } 1753 }
1932 1754
1933 return tmp; 1755 return tmp;
1756}
1757
1758/* find_key
1759 * We try to find a key for the door as passed. If we find a key
1760 * and successfully use it, we return the key, otherwise NULL
1761 * This function merges both normal and locked door, since the logic
1762 * for both is the same - just the specific key is different.
1763 * pl is the player,
1764 * inv is the objects inventory to searched
1765 * door is the door we are trying to match against.
1766 * This function can be called recursively to search containers.
1767 */
1768object *
1769find_key (object *pl, object *container, object *door)
1770{
1771 if (door->slaying && is_match_expr (door->slaying))
1772 {
1773 // for match expressions, we try to find the key by applying the match
1774 // to the op itself, which is supposed to find the "key", instead
1775 // of searching through containers ourselves.
1776
1777 return match_one (door->slaying, container, door, pl, pl);
1778 }
1779 else
1780 return find_key_ (pl, container, door);
1934} 1781}
1935 1782
1936/* moved door processing out of move_player_attack. 1783/* moved door processing out of move_player_attack.
1937 * returns 1 if player has opened the door with a key 1784 * returns 1 if player has opened the door with a key
1938 * such that the caller should not do anything more, 1785 * such that the caller should not do anything more,
1988 * going to try and move (not fire weapons). 1835 * going to try and move (not fire weapons).
1989 */ 1836 */
1990bool 1837bool
1991move_player_attack (object *op, int dir) 1838move_player_attack (object *op, int dir)
1992{ 1839{
1993 int on_battleground; 1840 if (!op->contr->braced && op->speed_left > 0.f && op->move (dir))
1841 {
1842 --op->speed_left;
1843 return true;
1844 }
1994 1845
1995 sint16 nx = freearr_x[dir] + op->x; 1846 sint16 nx = freearr_x[dir] + op->x;
1996 sint16 ny = freearr_y[dir] + op->y; 1847 sint16 ny = freearr_y[dir] + op->y;
1997 1848
1998 on_battleground = op_on_battleground (op, 0, 0);
1999
2000 if (out_of_map (op->map, nx, ny)) 1849 if (out_of_map (op->map, nx, ny))
2001 return false; 1850 return false;
2002
2003 if (!op->contr->braced && op->speed_left > 0.f && move_ob (op, dir, op))
2004 {
2005 --op->speed_left;
2006 return true;
2007 }
2008 1851
2009 /* If braced, or can't move to the square, and it is not out of the 1852 /* If braced, or can't move to the square, and it is not out of the
2010 * map, attack it. Note order of if statement is important - don't 1853 * map, attack it. Note order of if statement is important - don't
2011 * want to be calling move_ob if braced, because move_ob will move the 1854 * want to be calling move_ob if braced, because move_ob will move the
2012 * player. This is a pretty nasty hack, because if we could 1855 * player. This is a pretty nasty hack, because if we could
2072 --op->speed_left; 1915 --op->speed_left;
2073 1916
2074 op->play_sound (sound_find ("push_player")); 1917 op->play_sound (sound_find ("push_player"));
2075 push_ob (mon, dir, op); 1918 push_ob (mon, dir, op);
2076 1919
2077 if (op->contr->tmp_invis || op->hide) 1920 if (action_makes_visible (op))
2078 make_visible (op); 1921 make_visible (op);
2079 1922
2080 return true; 1923 return true;
2081 } 1924 }
2082 else 1925 else
2083 return false; 1926 return false;
2084 } 1927 }
1928
1929 bool on_battleground = op_on_battleground (op, 0, 0);
2085 1930
2086 /* in certain circumstances, you shouldn't attack friendly 1931 /* in certain circumstances, you shouldn't attack friendly
2087 * creatures. Note that if you are braced, you can't push 1932 * creatures. Note that if you are braced, you can't push
2088 * someone, but put it inside this loop so that you won't 1933 * someone, but put it inside this loop so that you won't
2089 * attack them either. 1934 * attack them either.
2104 push_ob (mon, dir, op); 1949 push_ob (mon, dir, op);
2105 } 1950 }
2106 else 1951 else
2107 op->statusmsg ("You withhold your attack"); 1952 op->statusmsg ("You withhold your attack");
2108 1953
2109 if (op->contr->tmp_invis || op->hide) 1954 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN])
2110 make_visible (op); 1955 make_visible (op);
2111 1956
2112 return true; 1957 return true;
2113 } 1958 }
2114 } 1959 }
2154} 1999}
2155 2000
2156bool 2001bool
2157move_player (object *op, int dir) 2002move_player (object *op, int dir)
2158{ 2003{
2159 int pick;
2160
2161 if (!op->map || op->map->in_memory != MAP_ACTIVE) 2004 if (!op->map || op->map->in_memory != MAP_ACTIVE)
2162 return 0; 2005 return 0;
2163 2006
2164 /* Sanity check: make sure dir is valid */ 2007 /* Sanity check: make sure dir is valid */
2165 if ((dir < 0) || (dir >= 9)) 2008 if (dir < 0 || dir >= 9)
2166 { 2009 {
2167 LOG (llevError, "move_player: invalid direction %d\n", dir); 2010 LOG (llevError, "move_player: invalid direction %d\n", dir);
2168 return 0; 2011 return 0;
2169 } 2012 }
2170 2013
2172 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2015 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir)
2173 dir = absdir (dir + rndm (3) + rndm (3) - 2); 2016 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2174 2017
2175 op->facing = dir; 2018 op->facing = dir;
2176 2019
2177 if (op->hide) 2020 if (op->flag [FLAG_HIDDEN])
2178 do_hidden_move (op); 2021 do_hidden_move (op);
2179 2022
2180 bool retval; 2023 bool retval;
2024 int pick = 0;
2181 2025
2182 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2026 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2183 retval = RESULT_INT (0); 2027 retval = RESULT_INT (0);
2184 else if (op->contr->fire_on) 2028 else if (op->contr->fire_on)
2185 retval = fire (op, dir); 2029 retval = fire (op, dir);
2242 return move_player (op, op->direction); 2086 return move_player (op, op->direction);
2243 2087
2244 return false; 2088 return false;
2245} 2089}
2246 2090
2247int 2091static int
2248save_life (object *op) 2092save_life (object *op)
2249{ 2093{
2250 if (!QUERY_FLAG (op, FLAG_LIFESAVE)) 2094 if (!QUERY_FLAG (op, FLAG_LIFESAVE))
2251 return 0; 2095 return 0;
2252 2096
2261 2105
2262 if (op->stats.hp < 0) 2106 if (op->stats.hp < 0)
2263 op->stats.hp = op->stats.maxhp; 2107 op->stats.hp = op->stats.maxhp;
2264 2108
2265 if (op->stats.food < 0) 2109 if (op->stats.food < 0)
2266 op->stats.food = 999; 2110 op->stats.food = MAX_FOOD;
2267 2111
2268 op->update_stats (); 2112 op->update_stats ();
2269 return 1; 2113 return 1;
2270 } 2114 }
2271 2115
2299void 2143void
2300object::drop_unpaid_items () 2144object::drop_unpaid_items ()
2301{ 2145{
2302 if (!flag [FLAG_REMOVED]) 2146 if (!flag [FLAG_REMOVED])
2303 ::drop_unpaid_items (inv, this); 2147 ::drop_unpaid_items (inv, this);
2304}
2305
2306/*
2307 * Returns pointer a static string containing gravestone text
2308 * Moved from apply.c to player.c - player.c is what
2309 * actually uses this function. player.c may not be quite the
2310 * best, a misc file for object actions is probably better,
2311 * but there isn't one in the server directory.
2312 */
2313const char *
2314gravestone_text (object *op)
2315{
2316 static dynbuf_text buf;
2317
2318 buf << "---- R.I.P. ----\n\n";
2319 op->name;
2320
2321 if (op->type == PLAYER)
2322 buf << " the " << op->contr->title;
2323
2324 buf << "\n\n";
2325
2326 buf << "who was level ";
2327 buf << (sint32)op->level << "\n\n" // OO breakdown
2328 << " when " << (op->contr ? "killed" : "died") << "\n\n";
2329
2330 if (op->type == PLAYER)
2331 buf << "by " << op->contr->killer_name () << ".\n\n";
2332
2333 {
2334 static char buf2[128];
2335 time_t now = time (NULL);
2336 strftime (buf2, 128, "%b %d %Y\n\n", localtime (&now));
2337 buf << buf2;
2338 }
2339
2340 return buf;
2341} 2148}
2342 2149
2343void 2150void
2344do_some_living (object *op) 2151do_some_living (object *op)
2345{ 2152{
2500 { 2307 {
2501 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp; 2308 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2502 2309
2503 if (over_hp > 0) 2310 if (over_hp > 0)
2504 { 2311 {
2505 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2312 op->stats.sp += over_hp + (rndm (rate_hp) > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0;
2506 op->last_heal = 0; 2313 op->last_heal = 0;
2507 } 2314 }
2508 else 2315 else
2509 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2316 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2510 } 2317 }
2537 2344
2538 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2345 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2539 { 2346 {
2540 op->statusmsg ("You blindly grab for a bite of food. " 2347 op->statusmsg ("You blindly grab for a bite of food. "
2541 "H<To prevent you from starving, you ate some random item from your backpack.>"); 2348 "H<To prevent you from starving, you ate some random item from your backpack.>");
2542 manual_apply (op, tmp, 0); 2349 op->apply (tmp);
2543 2350
2544 if (op->stats.food >= 0 || op->stats.hp < 0) 2351 if (op->stats.food >= 0 || op->stats.hp < 0)
2545 break; 2352 break;
2546 } 2353 }
2547 else if (tmp->type == FLESH) 2354 else if (tmp->type == FLESH)
2553 */ 2360 */
2554 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2361 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2555 { 2362 {
2556 op->statusmsg ("You blindly grab for a bite of food. " 2363 op->statusmsg ("You blindly grab for a bite of food. "
2557 "H<To prevent you from starving, you ate some random item from your backpack.>"); 2364 "H<To prevent you from starving, you ate some random item from your backpack.>");
2558 manual_apply (op, flesh, 0); 2365 op->apply (flesh);
2559 } 2366 }
2560 2367
2561 // If player is still starving, alert him! 2368 // If player is still starving, alert him!
2562 if (op->stats.food < 0) 2369 if (op->stats.food < 0)
2563 op->failmsg ("You are starving! " 2370 op->failmsg ("You are starving! "
2566 2373
2567 if (op->stats.food < 0) 2374 if (op->stats.food < 0)
2568 { 2375 {
2569 op->stats.hp += op->stats.food; 2376 op->stats.hp += op->stats.food;
2570 op->stats.food = 0; 2377 op->stats.food = 0;
2378
2379 if (op->stats.hp < 0)
2380 {
2381 op->contr->killer = archetype::get ("killer_starvation");
2382 op->contr->killer->destroy ();
2571 } 2383 }
2384 }
2572 2385
2386 /* killer should be set here already */
2573 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2387 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ))
2574 kill_player (op); 2388 kill_player (op);
2575 } 2389 }
2576} 2390}
2577 2391
2582 */ 2396 */
2583void 2397void
2584kill_player (object *op) 2398kill_player (object *op)
2585{ 2399{
2586 int x, y; 2400 int x, y;
2587 char buf[MAX_BUF];
2588 maptile *map; /* this is for resurrection */ 2401 maptile *map; /* this is for resurrection */
2589 int will_kill_again; 2402 int will_kill_again;
2590 archetype *at; 2403 archetype *at;
2591 object *tmp; 2404 object *tmp;
2592 2405
2593 if (save_life (op)) 2406 if (save_life (op))
2594 return; 2407 return;
2408
2409 dynbuf_text deathtab;
2410
2411 /* restore player */
2412 at = archetype::find (shstr_poisoning);
2413 if (object *tmp = present_arch_in_ob (at, op))
2414 {
2415 tmp->destroy ();
2416 deathtab << "Your body feels cleansed...\r";
2417 }
2418
2419 at = archetype::find (shstr_confusion);
2420 if (object *tmp = present_arch_in_ob (at, op))
2421 {
2422 tmp->destroy ();
2423 deathtab << "Your mind feels clearer...\r";
2424 }
2425
2426 cure_disease (op, 0, 0); /* remove any disease */
2427
2428 max_it (op->stats.hp , op->stats.maxhp);
2429 max_it (op->stats.sp , op->stats.maxsp);
2430 max_it (op->stats.grace, op->stats.maxgrace);
2431 max_it (op->stats.food , 200);
2432
2433 // remove all spell effects that are active
2434 // to avoid long-term effects such as word-of-recall
2435 for (object *item = op->inv; item; )
2436 {
2437 object *next = item->below;
2438
2439 if (item->type == SPELL_EFFECT && item->active)
2440 item->destroy ();
2441
2442 item = next;
2443 }
2595 2444
2596 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2445 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2597 * in cities ONLY!!! It is very important that this doesn't get abused. 2446 * in cities ONLY!!! It is very important that this doesn't get abused.
2598 * Look at op_on_battleground() for more info --AndreasV 2447 * Look at op_on_battleground() for more info --AndreasV
2599 */ 2448 */
2600 if (op_on_battleground (op, &x, &y)) 2449 if (op_on_battleground (op, &x, &y))
2601 { 2450 {
2602 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2451 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2603 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2604
2605 /* restore player */
2606 at = archetype::find ("poisoning");
2607 if (object *tmp = present_arch_in_ob (at, op))
2608 {
2609 tmp->destroy ();
2610 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2611 }
2612
2613 at = archetype::find ("confusion");
2614 if (object *tmp = present_arch_in_ob (at, op))
2615 {
2616 tmp->destroy ();
2617 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2618 }
2619
2620 cure_disease (op, 0, 0); /* remove any disease */
2621 op->stats.hp = op->stats.maxhp;
2622 if (op->stats.food <= 0)
2623 op->stats.food = 999;
2624 2452
2625 /* create a bodypart-trophy to make the winner happy */ 2453 /* create a bodypart-trophy to make the winner happy */
2626 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2454 object *tmp = archetype::find (shstr_finger)->instance ();
2627 { 2455
2628 tmp->name = format ("%s's finger" , &op->name); 2456 tmp->name = format ("%s's finger" , &op->name);
2629 tmp->name_pl = format ("%s's fingers", &op->name); 2457 tmp->name_pl = format ("%s's fingers", &op->name);
2630 tmp->msg = format ( 2458 tmp->msg = format (
2631 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n", 2459 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2632 &op->name, op->contr->title, 2460 &op->name, op->contr->title,
2633 (int)op->level, 2461 (int)op->level,
2634 op->contr->killer_name () 2462 op->contr->killer_name ()
2635 ); 2463 );
2636 tmp->value = 0, tmp->type = 0; 2464 tmp->value = 0, tmp->type = 0;
2637 tmp->materialname = "organics"; 2465 tmp->material = name_to_material (shstr_organic);
2638 tmp->insert_at (op, tmp); 2466 tmp->insert_at (op, tmp);
2639 }
2640 2467
2641 /* teleport defeated player to new destination */ 2468 /* teleport defeated player to new destination */
2642 transfer_ob (op, x, y, 0, NULL); 2469 transfer_ob (op, x, y, 0, NULL);
2643 op->contr->braced = 0; 2470 op->contr->braced = 0;
2471
2472 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2644 return; 2473 return;
2645 } 2474 }
2646 2475
2476 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2477 deathtab << "T<YOU HAVE DIED>\n\n";
2478
2647 INVOKE_PLAYER (DEATH, op->contr); 2479 INVOKE_PLAYER (DEATH, op->contr);
2648 2480
2649 command_kill_pets (op, 0); 2481 command_kill_pets (op, 0);
2650
2651 if (op->stats.food < 0)
2652 {
2653 op->contr->killer = archetype::get ("killer_starvation");
2654 op->contr->killer->destroy ();
2655 }
2656 2482
2657 op->contr->play_sound (sound_find ("player_dies")); 2483 op->contr->play_sound (sound_find ("player_dies"));
2658 2484
2659 /* save the map location for corpse, gravestone */ 2485 /* save the map location for corpse, gravestone */
2660 x = op->x; 2486 x = op->x;
2690 2516
2691 lost_a_stat = 0; 2517 lost_a_stat = 0;
2692 2518
2693 for (z = 0; z < num_stats_lose; z++) 2519 for (z = 0; z < num_stats_lose; z++)
2694 { 2520 {
2695 i = RANDOM () % NUM_STATS; 2521 i = rndm (NUM_STATS);
2696 2522
2697 if (settings.stat_loss_on_death) 2523 if (settings.stat_loss_on_death)
2698 { 2524 {
2699 /* Pick a random stat and take a point off it. Tell the player 2525 /* Pick a random stat and take a point off it. Tell the player
2700 * what he lost. 2526 * what he lost.
2707 lost_a_stat = 1; 2533 lost_a_stat = 1;
2708 } 2534 }
2709 else 2535 else
2710 { 2536 {
2711 /* deplete a stat */ 2537 /* deplete a stat */
2712 archetype *deparch = archetype::find ("depletion"); 2538 archetype *deparch = archetype::find (shstr_depletion);
2713 object *dep; 2539 object *dep;
2714 2540
2715 dep = present_arch_in_ob (deparch, op); 2541 dep = present_arch_in_ob (deparch, op);
2716 if (!dep) 2542 if (!dep)
2717 { 2543 {
2718 dep = arch_to_object (deparch); 2544 dep = deparch->instance ();
2719 insert_ob_in_ob (dep, op); 2545 insert_ob_in_ob (dep, op);
2720 } 2546 }
2721 lose_this_stat = 1; 2547 lose_this_stat = 1;
2722 if (settings.balanced_stat_loss) 2548 if (settings.balanced_stat_loss)
2723 { 2549 {
2751 } 2577 }
2752 } 2578 }
2753 2579
2754 if (lose_this_stat) 2580 if (lose_this_stat)
2755 { 2581 {
2756 this_stat = get_attr_value (&(dep->stats), i); 2582 this_stat = get_attr_value (&dep->stats, i);
2757 /* We could try to do something clever like find another 2583 /* We could try to do something clever like find another
2758 * stat to reduce if this fails. But chances are, if 2584 * stat to reduce if this fails. But chances are, if
2759 * stats have been depleted to -50, all are pretty low 2585 * stats have been depleted to -50, all are pretty low
2760 * and should be roughly the same, so it shouldn't make a 2586 * and should be roughly the same, so it shouldn't make a
2761 * difference. 2587 * difference.
2775 /* If no stat lost, tell the player. */ 2601 /* If no stat lost, tell the player. */
2776 if (!lost_a_stat) 2602 if (!lost_a_stat)
2777 { 2603 {
2778 /* determine_god() seems to not work sometimes... why is this? 2604 /* determine_god() seems to not work sometimes... why is this?
2779 Should I be using something else? GD */ 2605 Should I be using something else? GD */
2780 const char *god = determine_god (op); 2606 shstr_tmp god = determine_god (op);
2781 2607
2782 if (god && (strcmp (god, "none"))) 2608 if (god != shstr_none)
2783 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2609 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2784 else 2610 else
2785 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2611 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2786 } 2612 }
2787#else 2613#else
2788 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you from losing yourself completely."); 2614 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2789#endif 2615#endif
2790 2616
2791 /* Put a gravestone up where the character 'almost' died. List the 2617 /* Put a gravestone up where the character 'almost' died. List the
2792 * exp loss on the stone. 2618 * exp loss on the stone.
2793 */ 2619 */
2794 tmp = arch_to_object (archetype::find ("gravestone")); 2620 tmp = archetype::find (shstr_gravestone)->instance ();
2795 tmp->name = format ("%s's gravestone", &op->name); 2621 tmp->name = format ("%s's gravestone", &op->name);
2796 tmp->name_pl = format ("%s's gravestones", &op->name); 2622 tmp->name_pl = format ("%s's gravestones", &op->name);
2797 tmp->msg = format ("RIP\nHere rests the hero %s the %s,\nwho was killed\nby %s.\n", &op->name, op->contr->title, op->contr->killer_name ()); 2623 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2624 &op->name, op->contr->title, op->contr->killer_name ());
2798 tmp->x = op->x, tmp->y = op->y; 2625 tmp->x = op->x, tmp->y = op->y;
2799 insert_ob_in_map (tmp, op->map, NULL, 0); 2626 insert_ob_in_map (tmp, op->map, NULL, 0);
2800 2627
2801 /**************************************/ 2628 /**************************************/
2802 /* */ 2629 /* */
2803 /* Subtract the experience points, */ 2630 /* Subtract the experience points, */
2804 /* if we died cause of food, give us */
2805 /* food, and reset HP's... */
2806 /* */ 2631 /* */
2807 /**************************************/ 2632 /**************************************/
2808 2633
2809 /* remove any poisoning and confusion the character may be suffering. */
2810 /* restore player */
2811 at = archetype::find ("poisoning");
2812 tmp = present_arch_in_ob (at, op);
2813
2814 if (tmp)
2815 {
2816 tmp->destroy ();
2817 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2818 }
2819
2820 at = archetype::find ("confusion");
2821 tmp = present_arch_in_ob (at, op);
2822 if (tmp)
2823 {
2824 tmp->destroy ();
2825 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2826 }
2827
2828 cure_disease (op, 0, 0); /* remove any disease */
2829
2830 // remove all spell effects that are active
2831 // to avoid long-term effects such as word-of-recall
2832 for (object *item = op->inv; item; )
2833 {
2834 object *next = item->below;
2835
2836 if (item->type == SPELL_EFFECT && item->active)
2837 item->destroy ();
2838
2839 item = next;
2840 }
2841
2842 /*add_exp(op, (op->stats.exp * -0.20)); */ 2634 /*add_exp(op, (op->stats.exp * -0.20)); */
2843 apply_death_exp_penalty (op); 2635 apply_death_exp_penalty (op);
2844
2845 if (op->stats.food < 100)
2846 op->stats.food = 900;
2847
2848 op->stats.hp = op->stats.maxhp;
2849 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2850 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2851 2636
2852 /* 2637 /*
2853 * Check to see if the player has any unpaid items. If so, remove them 2638 * Check to see if the player has any unpaid items. If so, remove them
2854 * and put them back in the map. 2639 * and put them back in the map.
2855 */ 2640 */
2890 if (will_kill_again & (1 << at)) 2675 if (will_kill_again & (1 << at))
2891 force->resist[at] = 100; 2676 force->resist[at] = 100;
2892 2677
2893 insert_ob_in_ob (force, op); 2678 insert_ob_in_ob (force, op);
2894 op->update_stats (); 2679 op->update_stats ();
2895
2896 } 2680 }
2897 2681
2898 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2682 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2899} 2683}
2900 2684
2901void 2685static void
2902loot_object (object *op) 2686loot_object (object *op)
2903{ /* Grab and destroy some treasure */ 2687{ /* Grab and destroy some treasure */
2904 object *tmp, *tmp2, *next; 2688 object *tmp, *tmp2, *next;
2905 2689
2906 op->close_container (); /* close open sack first */ 2690 op->close_container (); /* close open sack first */
2937 * fix_weight(): Check recursively the weight of all players, and fix 2721 * fix_weight(): Check recursively the weight of all players, and fix
2938 * what needs to be fixed. Refresh windows and fix speed if anything 2722 * what needs to be fixed. Refresh windows and fix speed if anything
2939 * was changed. 2723 * was changed.
2940 */ 2724 */
2941void 2725void
2942fix_weight (void) 2726fix_weight ()
2943{ 2727{
2944 for_all_players (pl) 2728 for_all_players (pl)
2945 { 2729 {
2946 sint32 old = pl->ob->carrying; 2730 sint32 old = pl->ob->carrying;
2947 2731
2954 } 2738 }
2955 } 2739 }
2956} 2740}
2957 2741
2958void 2742void
2959fix_luck (void) 2743fix_luck ()
2960{ 2744{
2961 for_all_players (pl) 2745 for_all_players (pl)
2962 if (!pl->ob->contr->ns->state) 2746 if (!pl->ob->contr->ns->state)
2963 pl->ob->change_luck (0); 2747 pl->ob->change_luck (0);
2964} 2748}
3001} 2785}
3002 2786
3003void 2787void
3004make_visible (object *op) 2788make_visible (object *op)
3005{ 2789{
3006 op->hide = 0; 2790 op->flag [FLAG_HIDDEN] = 0;
3007 op->invisible = 0; 2791 op->invisible = 0;
3008 2792
3009 if (op->type == PLAYER) 2793 if (op->type == PLAYER)
3010 { 2794 {
3011 op->contr->tmp_invis = 0; 2795 op->contr->tmp_invis = 0;
3036 2820
3037 if (!ob || !ob->map) 2821 if (!ob || !ob->map)
3038 return 0; 2822 return 0;
3039 2823
3040 /* so, on normal lighted maps, its hard to hide */ 2824 /* so, on normal lighted maps, its hard to hide */
3041 level = ob->map->darkness - 2; 2825 level = ob->map->darklevel () - 2;
3042 2826
3043 /* this also picks up whether the object is glowing. 2827 /* this also picks up whether the object is glowing.
3044 * If you carry a light on a non-dark map, its not 2828 * If you carry a light on a non-dark map, its not
3045 * as bad as carrying a light on a pitch dark map */ 2829 * as bad as carrying a light on a pitch dark map */
3046 if (has_carried_lights (ob)) 2830 if (ob->has_carried_lights ())
3047 level = -(10 + (2 * ob->map->darkness)); 2831 level = -(10 + (2 * ob->map->darklevel ()));
3048 2832
3049 /* scan through all nearby squares for terrain to hide in */ 2833 /* scan through all nearby squares for terrain to hide in */
3050 for (i = 0, x = ob->x, y = ob->y; 2834 for (i = 0, x = ob->x, y = ob->y;
3051 i <= SIZEOFFREE1; 2835 i <= SIZEOFFREE1;
3052 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2836 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
3199 while (op) 2983 while (op)
3200 { 2984 {
3201 dx = rv.distance_x + op->arch->x; 2985 dx = rv.distance_x + op->arch->x;
3202 dy = rv.distance_y + op->arch->y; 2986 dy = rv.distance_y + op->arch->y;
3203 2987
3204 /* only the viewable area the player sees is updated by LOS 2988 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3205 * code, so we need to restrict ourselves to that range of values
3206 * for any meaningful values.
3207 */
3208 if (abs (dx) <= (pl->contr->ns->mapx / 2) &&
3209 abs (dy) <= (pl->contr->ns->mapy / 2) &&
3210 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3211 return 1; 2989 return 1;
3212 2990
3213 op = op->more; 2991 op = op->more;
3214 }
3215
3216 return 0;
3217}
3218
3219/* routine for both players and monsters. We call this when
3220 * there is a possibility for our action distrubing our hiding
3221 * place or invisiblity spell. Artefact invisiblity is not
3222 * effected by this. If we arent invisible to begin with, we
3223 * return 0.
3224 */
3225int
3226action_makes_visible (object *op)
3227{
3228 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3229 {
3230 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3231 return 0;
3232
3233 if (op->contr && op->contr->tmp_invis == 0)
3234 return 0;
3235
3236 /* If monsters, they should become visible */
3237 if (op->hide || !op->contr || (op->contr && op->contr->tmp_invis))
3238 {
3239 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible");
3240 return 1;
3241 }
3242 } 2992 }
3243 2993
3244 return 0; 2994 return 0;
3245} 2995}
3246 2996
3270 && tmp->name == shstr_battleground 3020 && tmp->name == shstr_battleground
3271 && EXIT_X (tmp) && EXIT_Y (tmp)) 3021 && EXIT_X (tmp) && EXIT_Y (tmp))
3272 { 3022 {
3273 /* before we assign the exit, check if this is a teambattle */ 3023 /* before we assign the exit, check if this is a teambattle */
3274 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3024 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3275 {
3276 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below) 3025 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3026 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3277 { 3027 {
3278 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3279 {
3280 if (x && y) 3028 if (x && y)
3281 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3029 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3282 3030
3283 return 1; 3031 return 1;
3284 }
3285 } 3032 }
3286 }
3287 3033
3288 if (x && y) 3034 if (x && y)
3289 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3035 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3290 3036
3291 return 1; 3037 return 1;
3429 else 3175 else
3430 j = 1; 3176 j = 1;
3431 strcat (buf, spellpathnames[i]); 3177 strcat (buf, spellpathnames[i]);
3432 } 3178 }
3433 } 3179 }
3180
3434 strcat (buf, "."); 3181 strcat (buf, ".");
3435 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf); 3182 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf);
3436 } 3183 }
3437 3184
3438 /* evtl. adding flags: */ 3185 /* evtl. adding flags: */
3448 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg); 3195 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg);
3449 } 3196 }
3450 else 3197 else
3451 { 3198 {
3452 /* generate misc. treasure */ 3199 /* generate misc. treasure */
3453 tmp = arch_to_object (tr->item); 3200 tmp = tr->item->instance ();
3454 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3201 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3455 who->insert (tmp); 3202 who->insert (tmp);
3456 } 3203 }
3457} 3204}
3458 3205
3459/** 3206//-GPL
3460 * Unready an object for a player. This function does nothing if the object was
3461 * not readied.
3462 */
3463void
3464player_unready_range_ob (player *pl, object *ob)
3465{
3466 if (pl->ob->current_weapon == ob)
3467 pl->ob->current_weapon = 0;
3468
3469 if (pl->combat_ob == ob)
3470 pl->combat_ob = 0;
3471
3472 if (pl->ranged_ob == ob)
3473 pl->ranged_ob = 0;
3474}
3475 3207
3476sint8 3208sint8
3477player::visibility_at (maptile *map, int x, int y) const 3209player::darkness_at (maptile *map, int x, int y) const
3478{ 3210{
3479 if (!ns) 3211 if (!ns)
3480 return 0; 3212 return LOS_BLOCKED;
3481 3213
3482 int dx, dy; 3214 int dx, dy;
3483 if (!adjacent_map (map, ns->current_map, &dx, &dy)) 3215 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3484 return 0; 3216 return LOS_BLOCKED;
3485 3217
3486 x += dx - ns->current_x + ns->mapx / 2; 3218 x += dx - ns->current_x;
3487 y += dy - ns->current_y + ns->mapy / 2; 3219 y += dy - ns->current_y;
3488 3220
3489 if (!IN_RANGE_EXC (x, 0, ns->mapx) || !IN_RANGE_EXC (y, 0, ns->mapy))
3490 return 0;
3491
3492 return 100 - blocked_los [x][y]; 3221 return blocked_los (x, y);
3493} 3222}
3494 3223
3495void 3224void
3496player::infobox (const char *title, const char *msg, int color) 3225player::infobox (const char *title, const char *msg, int color)
3497{ 3226{

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines