ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.56 by root, Sat Dec 23 05:25:18 2006 UTC vs.
Revision 1.268 by root, Wed Apr 7 19:54:45 2010 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
8 it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
9 the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
10 (at your option) any later version. 11 * option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
18 along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
20 21 *
21 The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22*/ 23 */
24
25//+GPL
23 26
24#include <global.h> 27#include <global.h>
25#include <pwd.h>
26#include <sproto.h> 28#include <sproto.h>
27#include <sounds.h> 29#include <sounds.h>
28#include <living.h> 30#include <living.h>
29#include <object.h> 31#include <object.h>
30#include <spells.h> 32#include <spells.h>
31#include <skills.h> 33#include <skills.h>
32 34
33#include <algorithm> 35#include <algorithm>
34#include <functional> 36#include <functional>
35 37
36player * 38playervec players;
37find_player (const char *plname)
38{
39 player *pl;
40
41 for (pl = first_player; pl; pl = pl->next)
42 if (pl->ob && !strcmp (query_name (pl->ob), plname))
43 return pl;
44
45 return 0;
46}
47
48void
49display_motd (const object *op)
50{
51 char buf[MAX_BUF];
52 char motd[HUGE_BUF];
53 FILE *fp;
54 int comp;
55 int size;
56
57 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
58 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
59 return;
60
61 motd[0] = '\0';
62 size = 0;
63
64 while (fgets (buf, MAX_BUF, fp))
65 {
66 if (*buf == '#')
67 continue;
68
69 strncat (motd + size, buf, HUGE_BUF - size);
70 size += strlen (buf);
71 }
72
73 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
74 close_and_delete (fp, comp);
75}
76
77void
78send_rules (const object *op)
79{
80 char buf[MAX_BUF];
81 char rules[HUGE_BUF];
82 FILE *fp;
83 int comp;
84 int size;
85
86 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
87 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
88 return;
89
90 rules[0] = '\0';
91 size = 0;
92
93 while (fgets (buf, MAX_BUF, fp))
94 {
95 if (*buf == '#')
96 continue;
97
98 if (size + strlen (buf) >= HUGE_BUF)
99 {
100 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
101 break;
102 }
103
104 strncat (rules + size, buf, HUGE_BUF - size);
105 size += strlen (buf);
106 }
107
108 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
109 close_and_delete (fp, comp);
110}
111
112void
113send_news (const object *op)
114{
115 char buf[MAX_BUF];
116 char news[HUGE_BUF];
117 char subject[MAX_BUF];
118 FILE *fp;
119 int comp;
120 int size;
121
122 sprintf (buf, "%s/%s", settings.confdir, settings.news);
123 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
124 return;
125
126 news[0] = '\0';
127 subject[0] = '\0';
128 size = 0;
129
130 while (fgets (buf, MAX_BUF, fp) != NULL)
131 {
132 if (*buf == '#')
133 continue;
134
135 if (*buf == '%')
136 { /* send one news */
137 if (size > 0)
138 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s", "%s\n%s", subject, news); /*send previously read news */
139 strcpy (subject, buf + 1);
140 strip_endline (subject);
141 size = 0;
142 news[0] = '\0';
143 }
144 else
145 {
146 if (size + strlen (buf) >= HUGE_BUF)
147 {
148 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
149 break;
150 }
151 strncat (news + size, buf, HUGE_BUF - size);
152 size += strlen (buf);
153 }
154 }
155
156 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
157 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", "%s\n%s", subject, news);
158 close_and_delete (fp, comp);
159}
160 39
161/* This loads the first map an puts the player on it. */ 40/* This loads the first map an puts the player on it. */
162static void 41static void
163set_first_map (object *op) 42set_first_map (object *op)
164{ 43{
165 strcpy (op->contr->maplevel, first_map_path); 44 op->contr->maplevel = first_map_path;
166 op->x = -1; 45 op->x = -1;
167 op->y = -1; 46 op->y = -1;
168 enter_exit (op, 0); 47}
48
49void
50player::activate ()
51{
52 if (active)
53 return;
54
55 players.insert (this);
56 ob->remove ();
57 ob->map = 0;
58 ob->activate_recursive ();
59 CLEAR_FLAG (ob, FLAG_FRIENDLY);
60 add_friendly_object (ob);
61}
62
63void
64player::deactivate ()
65{
66 if (!active)
67 return;
68
69 terminate_all_pets (ob);
70 remove_friendly_object (ob);
71 ob->deactivate_recursive ();
72
73 if (ob->map)
74 maplevel = ob->map->path;
75
76 ob->remove ();
77 ob->enemy = 0; // sometimes keeps an extra refcount on itself
78 ob->map = 0;
79 party = 0;
80
81 players.erase (this);
169} 82}
170 83
171// connect the player with a specific client 84// connect the player with a specific client
172// also changed, rationalises, and fixes some incorrect settings 85// also changes, rationalises, and fixes some incorrect settings
173void 86void
174player::connect (client *ns) 87player::connect (client *ns)
175{ 88{
176 this->ns = ns; 89 this->ns = ns;
177 ns->pl = this; 90 ns->pl = this;
178 91
179 next = first_player; 92 run_on = 0;
180 first_player = this; 93 fire_on = 0;
94 ob->close_container (); //TODO: client-specific
181 95
182 ns->update_look = 0; 96 ns->update_look = 0;
183 ns->look_position = 0; 97 ns->look_position = 0;
184 98
185 clear_los (ob); 99 clear_los ();
186 100
101 ns->reset_stats ();
102
103 /* make sure he's a player -- needed because of class change. */
187 ob->type = PLAYER; // we are paranoid 104 ob->type = PLAYER; // we are paranoid
188 ob->race = ob->arch->clone.race; 105 ob->race = ob->arch->race;
189 106
190 if (!legal_range (ob, shoottype))
191 shoottype = range_none;
192
193 ob->carrying = sum_weight (ob);
194 link_player_skills (ob);
195
196 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
197 ob->update_stats (); 107 ob->update_weight ();
198 update_ob_speed (ob); 108 link_skills ();
199 109
200 assign (title, ob->arch->clone.name); 110 assign (title, ob->arch->object::name);
201
202 /* can_use_shield is a new flag. However, the can_use.. seems to largely come
203 * from the class, and not race. I don't see any way to get the class information
204 * to then update this. I don't think this will actually break anything - anyone
205 * that can use armour should be able to use a shield. What this may 'break'
206 * are features new characters get, eg, if someone starts up with a Q, they
207 * should be able to use a shield. However, old Q's won't get that advantage.
208 */
209 if (QUERY_FLAG (ob, FLAG_USE_ARMOUR))
210 SET_FLAG (ob, FLAG_USE_SHIELD);
211 111
212 /* if it's a dragon player, set the correct title here */ 112 /* if it's a dragon player, set the correct title here */
213 if (is_dragon_pl (ob)) 113 if (ob->is_dragon ())
214 { 114 {
215 object *tmp, *abil = 0, *skin = 0; 115 object *tmp, *abil = 0, *skin = 0;
216
217 shstr_cmp dragon_ability_force ("dragon_ability_force");
218 shstr_cmp dragon_skin_force ("dragon_skin_force");
219 116
220 for (tmp = ob->inv; tmp; tmp = tmp->below) 117 for (tmp = ob->inv; tmp; tmp = tmp->below)
221 if (tmp->type == FORCE) 118 if (tmp->type == FORCE)
222 if (tmp->arch->name == dragon_ability_force) 119 if (tmp->arch->archname == shstr_dragon_ability_force)
223 abil = tmp; 120 abil = tmp;
224 else if (tmp->arch->name == dragon_skin_force) 121 else if (tmp->arch->archname == shstr_dragon_skin_force)
225 skin = tmp; 122 skin = tmp;
226 123
227 set_dragon_name (ob, abil, skin); 124 set_dragon_name (ob, abil, skin);
228 } 125 }
229 126
230 CLEAR_FLAG (ob, FLAG_FRIENDLY);
231 add_friendly_object (ob);
232
233 LOG (llevInfo, "LOGIN: Player named %s from ip %s\n", &ob->name, ns->host);
234
235 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 127 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
236 new_draw_info_format (NDI_UNIQUE | NDI_ALL | NDI_DK_ORANGE, 5, NULL, "%s has entered the game.", &ob->name); 128
129 esrv_new_player (this);
130
131 ob->update_stats ();
237 132
238 ns->floorbox_update (); 133 ns->floorbox_update ();
239
240 esrv_new_player (this, ob->weight + ob->carrying);
241 esrv_send_inventory (ob, ob); 134 esrv_send_inventory (ob, ob);
242 esrv_add_spells (this, 0); 135 esrv_add_spells (this, 0);
243 136
244 enter_exit (ob, 0); 137 ob->flag [FLAG_READY_WEAPON] = false;
138 ob->flag [FLAG_READY_SKILL] = false;
139 ob->flag [FLAG_READY_RANGE] = false;
140 ob->flag [FLAG_READY_BOW] = false;
245 141
246// send_rules (ob);//TODO 142 ob->update_stats (); // we unapplied stuff above
247// send_news (ob);//TODO 143 activate ();
248// display_motd (ob);//TODO 144
145 INVOKE_PLAYER (CONNECT, this);
249 INVOKE_PLAYER (LOGIN, this); 146 INVOKE_PLAYER (LOGIN, this);
250} 147}
148
149void
150player::disconnect ()
151{
152 if (ob)
153 {
154 ob->close_container (); //TODO: client-specific
155 ob->drop_unpaid_items ();
156 }
157
158 if (ns)
159 {
160 if (active)
161 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0));
162
163 INVOKE_PLAYER (DISCONNECT, this);
164
165 ns->reset_stats ();
166 ns->pl = 0;
167 ns = 0;
168 }
169
170 // this is important for the player scheduler to get the correct refcount
171 // when ns = 0
172 observe = viewpoint = ob;
173
174 deactivate ();
175}
176
177//-GPL
251 178
252// the need for this function can be explained 179// the need for this function can be explained
253// by load_object not returning the object 180// by load_object not returning the object
254void 181void
255player::set_object (object *op) 182player::set_object (object *op)
256{ 183{
257 ob = op; 184 ob = observe = viewpoint = op;
258 ob->contr = this; /* this aren't yet in archetype */ 185 ob->contr = this; /* this aren't yet in archetype */
259 186
187 ob->speed = 1.0f;
260 ob->speed_left = 0.5; 188 ob->speed_left = 0.5f;
261 ob->speed = 1.0; 189
262 ob->direction = 5; /* So player faces south */ 190 ob->direction = 5; /* So player faces south */
263 ob->stats.wc = 2;
264 ob->run_away = 25; /* Then we panick... */
265
266 set_first_map (ob);
267
268 ob->roll_stats ();
269} 191}
192
193void
194player::set_observe (object *op)
195{
196 observe = viewpoint = op ? op : ob;
197 do_los = 1;
198}
199
200void
201player::set_viewpoint (object *op)
202{
203 viewpoint = op ? op : (object *)observe;
204 do_los = 1;
205}
206
207//+GPL
270 208
271player::player () 209player::player ()
272{ 210{
273 /* There are some elements we want initialized to non zero value - 211 /* There are some elements we want initialised to non zero value -
274 * we deal with that below this point. 212 * we deal with that below this point.
275 */ 213 */
276 outputs_sync = 16; /* Every 2 seconds */ 214 outputs_sync = 4;
277 outputs_count = 8; /* Keeps present behaviour */ 215 outputs_count = 4;
278 unapply = unapply_nochoice; 216 unapply = unapply_nochoice;
279 217
280 assign (savebed_map, first_map_path); /* Init. respawn position */ 218 savebed_map = first_map_path; /* Init. respawn position */
281 219
282 gen_sp_armour = 10; 220 gen_sp_armour = 10;
283 last_speed = -1;
284 shoottype = range_none;
285 bowtype = bow_normal; 221 bowtype = bow_normal;
286 petmode = pet_normal; 222 petmode = pet_normal;
287 listening = 10;
288 usekeys = containers; 223 usekeys = containers;
289 last_weapon_sp = -1;
290 peaceful = 1; /* default peaceful */ 224 peaceful = 1; /* default peaceful */
291 do_los = 1; 225 do_los = 1;
292 226
293 /* we need to clear these to -1 and not zero - otherwise, 227 weapon_sp = 1.0f;
294 * if a player quits and starts a new character, we wont 228 weapon_sp_left = 0.5f;
295 * send new values to the client, as things like exp start 229}
296 * at zero.
297 */
298 for (int i = 0; i < NUM_SKILLS; i++)
299 last_skill_exp[i] = -1;
300 230
301 for (int i = 0; i < NROFATTACKS; i++) 231void
302 last_resist[i] = -1; 232player::do_destroy ()
233{
234 disconnect ();
303 235
304 last_stats.exp = -1; 236 attachable::do_destroy ();
305 last_weight = (uint32) - 1; 237
238 if (ob)
239 ob->destroy ();
240
241 ob = observe = viewpoint = 0;
306} 242}
307 243
308player::~player () 244player::~player ()
309{ 245{
310 terminate_all_pets (ob);
311
312 if (first_player != this)
313 {
314 player *prev = first_player;
315
316 while (prev && prev->next && prev->next != this)
317 prev = prev->next;
318
319 if (prev->next != this)
320 {
321 LOG (llevError, "Free_player: Can't find previous player.\n");
322 abort ();
323 }
324
325 prev->next = next;
326 }
327 else
328 first_player = next;
329
330 if (ob)
331 {
332 ob->contr = 0;
333 ob->destroy (1);
334 }
335
336 if (ns)
337 {
338 ns->send_packet ("goodbye");
339 ns->flush ();
340 ns->pl = 0;
341 ns->destroy ();
342 }
343
344 /* Clear item stack */ 246 /* Clear item stack */
345 free (stack_items); 247 free (stack_items);
248}
249
250/*
251 * get_player_archetype() return next player archetype from archetype
252 * list. Not very efficient routine, but used only creating new players.
253 * Note: there MUST be at least one player archetype!
254 */
255static archetype *
256get_player_archetype (archetype *at)
257{
258 // archetypes could have been reloaded
259 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
260
261 if (!nat)
262 return at;
263
264 archvec::iterator i = archetypes.find (nat);
265
266 for (;;)
267 {
268 if (++i == archetypes.end ())
269 i = archetypes.begin ();
270 else if (*i == at)
271 cleanup ("not a single player archetype found");
272
273 if ((*i)->type == PLAYER)
274 return *i;
275 }
346} 276}
347 277
348/* Tries to add player on the connection passed in ns. 278/* Tries to add player on the connection passed in ns.
349 * All we can really get in this is some settings like host and display 279 * All we can really get in this is some settings like host and display
350 * mode. 280 * mode.
352player * 282player *
353player::create () 283player::create ()
354{ 284{
355 player *pl = new player; 285 player *pl = new player;
356 286
357 pl->set_object (arch_to_object (get_player_archetype (0))); 287 pl->set_object (get_player_archetype (0)->instance ());
288
289 pl->ob->roll_stats ();
290 pl->ob->stats.wc = 2;
291 pl->ob->run_away = 25; /* Then we panick... */
292
293 set_first_map (pl->ob);
358 294
359 return pl; 295 return pl;
360}
361
362/*
363 * get_player_archetype() return next player archetype from archetype
364 * list. Not very efficient routine, but used only creating new players.
365 * Note: there MUST be at least one player archetype!
366 */
367archetype *
368get_player_archetype (archetype *at)
369{
370 archetype *start = at;
371
372 for (;;)
373 {
374 if (at == NULL || at->next == NULL)
375 at = first_archetype;
376 else
377 at = at->next;
378
379 if (at->clone.type == PLAYER)
380 return at;
381
382 if (at == start)
383 {
384 LOG (llevError, "No Player archetypes\n");
385 exit (-1);
386 }
387 }
388} 296}
389 297
390object * 298object *
391get_nearest_player (object *mon) 299get_nearest_player (object *mon)
392{ 300{
393 object *op = NULL; 301 object *op = NULL;
394 player *pl = NULL;
395 objectlink *ol; 302 objectlink *ol;
396 unsigned lastdist; 303 unsigned lastdist;
397 rv_vector rv; 304 rv_vector rv;
398 305
399 for (ol = first_friendly_object, lastdist = 1000; ol != NULL; ol = ol->next) 306 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next)
400 { 307 {
401 /* We should not find free objects on this friendly list, but it
402 * does periodically happen. Given that, lets deal with it.
403 * While unlikely, it is possible the next object on the friendly
404 * list is also free, so encapsulate this in a while loop.
405 */
406 while (QUERY_FLAG (ol->ob, FLAG_FREED) || !QUERY_FLAG (ol->ob, FLAG_FRIENDLY))
407 {
408 object *tmp = ol->ob;
409
410 /* Can't do much more other than log the fact, because the object
411 * itself will have been cleared.
412 */
413 LOG (llevDebug, "get_nearest_player: Found free/non friendly object on friendly list\n");
414 ol = ol->next;
415 remove_friendly_object (tmp);
416 if (!ol)
417 return op;
418 }
419
420 /* Remove special check for player from this. First, it looks to cause
421 * some crashes (ol->ob->contr not set properly?), but secondly, a more
422 * complicated method of state checking would be needed in any case -
423 * as it was, a clever player could type quit, and the function would
424 * skip them over while waiting for confirmation. Remove
425 * on_same_map check, as can_detect_enemy also does this
426 */
427 if (!can_detect_enemy (mon, ol->ob, &rv)) 308 if (!can_detect_enemy (mon, ol->ob, &rv))
428 continue; 309 continue;
429 310
430 if (lastdist > rv.distance) 311 if (lastdist > rv.distance)
431 { 312 {
432 op = ol->ob; 313 op = ol->ob;
433 lastdist = rv.distance; 314 lastdist = rv.distance;
434 } 315 }
435 } 316 }
436 for (pl = first_player; pl != NULL; pl = pl->next) 317
437 { 318 for_all_players (pl)
438 if (can_detect_enemy (mon, pl->ob, &rv)) 319 if (can_detect_enemy (mon, pl->ob, &rv))
439 {
440
441 if (lastdist > rv.distance) 320 if (lastdist > rv.distance)
442 { 321 {
443 op = pl->ob; 322 op = pl->ob;
444 lastdist = rv.distance; 323 lastdist = rv.distance;
445 } 324 }
446 } 325
447 }
448#if 0 326#if 0
449 LOG (llevDebug, "get_nearest_player() finds player: %s\n", op ? &op->name : "(null)"); 327 LOG (llevDebug, "get_nearest_player() finds player: %s\n", op ? &op->name : "(null)");
450#endif 328#endif
451 return op; 329 return op;
452} 330}
510 x = mon->x; 388 x = mon->x;
511 y = mon->y; 389 y = mon->y;
512 m = mon->map; 390 m = mon->map;
513 dir = rv.direction; 391 dir = rv.direction;
514 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 392 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
515 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 393 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
394
516 /* If we can't solve it within the search distance, return now. */ 395 /* If we can't solve it within the search distance, return now. */
517 if (diff > max) 396 if (diff > max)
518 return 0; 397 return 0;
398
519 while (diff > 1 && max > 0) 399 while (diff > 1 && max > 0)
520 { 400 {
521 lastx = x; 401 lastx = x;
522 lasty = y; 402 lasty = y;
523 lastmap = m; 403 lastmap = m;
605 max--; 485 max--;
606 lastdir = dir; 486 lastdir = dir;
607 if (!firstdir) 487 if (!firstdir)
608 firstdir = dir; 488 firstdir = dir;
609 } 489 }
490
610 if (diff <= 1) 491 if (diff <= 1)
611 { 492 {
612 /* Recalculate diff (distance) because we may not have actually 493 /* Recalculate diff (distance) because we may not have actually
613 * headed toward player for entire distance. 494 * headed toward player for entire distance.
614 */ 495 */
615 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 496 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0);
616 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 497 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
617 } 498 }
499
618 if (diff > max) 500 if (diff > max)
619 return 0; 501 return 0;
620 } 502 }
503
621 /* If we reached the max, didn't find a direction in time */ 504 /* If we reached the max, didn't find a direction in time */
622 if (!max) 505 if (!max)
623 return 0; 506 return 0;
624 507
625 return firstdir; 508 return firstdir;
626} 509}
627 510
628void 511void
629give_initial_items (object *pl, treasurelist * items) 512give_initial_items (object *pl, treasurelist *items)
630{ 513{
631 object *op, *next = NULL;
632
633 if (pl->randomitems != NULL) 514 if (pl->randomitems)
634 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0); 515 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0);
635 516
636 for (op = pl->inv; op; op = next) 517 for (object *next, *op = pl->inv; op; op = next)
637 { 518 {
638 next = op->below; 519 next = op->below;
639 520
640 /* Forces get applied per default, unless they have the 521 /* Forces get applied per default, unless they have the
641 * flag "neutral" set. Sorry but I can't think of a better way 522 * flag "neutral" set. Sorry but I can't think of a better way
646 /* we never give weapons/armour if these cannot be used 527 /* we never give weapons/armour if these cannot be used
647 * by this player due to race restrictions 528 * by this player due to race restrictions
648 */ 529 */
649 if (pl->type == PLAYER) 530 if (pl->type == PLAYER)
650 { 531 {
651 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) && 532 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR)
533 &&
652 (op->type == ARMOUR || op->type == BOOTS || 534 (op->type == ARMOUR || op->type == BOOTS
653 op->type == CLOAK || op->type == HELMET || 535 || op->type == CLOAK || op->type == HELMET
654 op->type == SHIELD || op->type == GLOVES || 536 || op->type == SHIELD || op->type == GLOVES
537 || op->type == BRACERS || op->type == GIRDLE))
655 op->type == BRACERS || op->type == GIRDLE)) || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 538 || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON))
656 { 539 {
657 op->destroy (); 540 op->destroy ();
658 continue; 541 continue;
659 } 542 }
660 } 543 }
661 544
662 /* This really needs to be better - we should really give 545 /* Here we remove duplicated skills (as duplicated spell objects have
663 * a substitute spellbook. The problem is that we don't really 546 * _very_ confusing effects for players), which could for instance be
664 * have a good idea what to replace it with (need something like 547 * generated by bad treasurelists. - elmex
665 * a first level treasurelist for each skill.)
666 * remove duplicate skills also
667 */ 548 */
668 if (op->type == SPELLBOOK || op->type == SKILL) 549 if (op->type == SKILL)
669 { 550 {
670 object *tmp;
671
672 for (tmp = op->below; tmp; tmp = tmp->below) 551 for (object *tmp = op->below; tmp; tmp = tmp->below)
673 if (tmp->type == op->type && tmp->name == op->name) 552 if (tmp->type == op->type && tmp->name == op->name)
674 break;
675
676 if (tmp)
677 { 553 {
678 op->destroy (); 554 op->destroy ();
555 LOG (llevError,
679 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 556 "give_initial_items: Removing duplicate skill %s\n", &tmp->name);
680 continue; 557 break;
681 } 558 }
682 559
683 if (op->nrof > 1) 560 if (op->nrof > 1)
684 op->nrof = 1; 561 op->nrof = 1;
685 } 562 }
686 563
687 if (op->type == SPELLBOOK && op->inv) 564 if (op->type == SPELLBOOK && op->inv)
688 {
689 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP); 565 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP);
690 }
691 566
692 /* Give starting characters identified, uncursed, and undamned 567 /* Give starting characters identified, uncursed, and undamned
693 * items. Just don't identify gold or silver, or it won't be 568 * items. Just don't identify gold or silver, or it won't be
694 * merged properly. 569 * merged properly.
695 */ 570 */
696 if (need_identify (op)) 571 if (need_identify (op))
697 { 572 {
698 SET_FLAG (op, FLAG_IDENTIFIED); 573 SET_FLAG (op, FLAG_IDENTIFIED);
699 CLEAR_FLAG (op, FLAG_CURSED); 574 CLEAR_FLAG (op, FLAG_CURSED);
700 CLEAR_FLAG (op, FLAG_DAMNED); 575 CLEAR_FLAG (op, FLAG_DAMNED);
701 } 576 }
577
702 if (op->type == SPELL) 578 if (op->type == SPELL)
703 { 579 {
704 op->destroy (); 580 op->destroy ();
705 continue; 581 continue;
706 } 582 }
708 { 584 {
709 SET_FLAG (op, FLAG_CAN_USE_SKILL); 585 SET_FLAG (op, FLAG_CAN_USE_SKILL);
710 op->stats.exp = 0; 586 op->stats.exp = 0;
711 op->level = 1; 587 op->level = 1;
712 } 588 }
713 /* lock all 'normal items by default */ 589 else /* lock all 'normal items by default */
714 else
715 SET_FLAG (op, FLAG_INV_LOCKED); 590 SET_FLAG (op, FLAG_INV_LOCKED);
716 } /* for loop of objects in player inv */ 591 } /* for loop of objects in player inv */
717 592
718 /* Need to set up the skill pointers */ 593 /* Need to set up the skill pointers */
719 link_player_skills (pl); 594 pl->contr->link_skills ();
720} 595}
721 596
722void 597void
723get_party_password (object *op, partylist *party) 598get_party_password (object *op, partylist *party)
724{ 599{
734 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:"); 609 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:");
735} 610}
736 611
737/* This rolls four 1-6 rolls and sums the best 3 of the 4. */ 612/* This rolls four 1-6 rolls and sums the best 3 of the 4. */
738static int 613static int
739roll_stat (void) 614roll_stat ()
740{ 615{
741 int a[4], i, j, k; 616 int a[4], i, j, k;
742 617
743 for (i = 0; i < 4; i++) 618 for (i = 0; i < 4; i++)
744 a[i] = (int) RANDOM () % 6 + 1; 619 a[i] = (int) rndm (6) + 1;
745 620
746 for (i = 0, j = 0, k = 7; i < 4; i++) 621 for (i = 0, j = 0, k = 7; i < 4; i++)
747 if (a[i] < k) 622 if (a[i] < k)
748 k = a[i], j = i; 623 k = a[i], j = i;
749 624
755} 630}
756 631
757void 632void
758object::roll_stats () 633object::roll_stats ()
759{ 634{
760 int statsort [7]; 635 int statsort [NUM_STATS];
761 636
762 for (;;) 637 for (;;)
763 { 638 {
764 int sum = 0; 639 int sum = 0;
765 for (int i = 7; i--; ) 640 for (int i = NUM_STATS; i--; )
766 sum += statsort [i] = roll_stat (); 641 sum += statsort [i] = roll_stat ();
767 642
768 if (sum >= 82 && sum <= 116) 643 if (sum >= 82 && sum <= 116)
769 break; 644 break;
770 } 645 }
771 646
772 // Sort the stats so that rerolling is easier... 647 // Sort the stats so that rerolling is easier...
773 std::sort (statsort, statsort + 7, std::greater<int>()); 648 std::sort (statsort, statsort + NUM_STATS, std::greater<int>());
774 649
650 for (int i = 0; i < NUM_STATS; ++i)
775 stats.Str = statsort[0]; 651 stats.stat (i) = statsort [i];
776 stats.Dex = statsort[1];
777 stats.Con = statsort[2];
778 stats.Int = statsort[3];
779 stats.Wis = statsort[4];
780 stats.Pow = statsort[5];
781 stats.Cha = statsort[6];
782 652
783 stats.exp = 0; 653 stats.exp = 0;
784 stats.ac = 0; 654 stats.ac = 0;
785 655
786 stats.hp = stats.maxhp; 656 stats.hp = stats.maxhp;
798} 668}
799 669
800void 670void
801object::swap_stats (int a, int b) 671object::swap_stats (int a, int b)
802{ 672{
803 int tmp = get_attr_value (&contr->orig_stats, a); 673 swap (contr->orig_stats.stat (a), contr->orig_stats.stat (b));
804 set_attr_value (&contr->orig_stats, a, get_attr_value (&contr->orig_stats, b));
805 set_attr_value (&contr->orig_stats, b, tmp);
806 674
675 for (int i = 0; i < NUM_STATS; ++i)
807 stats.Str = contr->orig_stats.Str; 676 stats.stat (i) = contr->orig_stats.stat (i);
808 stats.Dex = contr->orig_stats.Dex;
809 stats.Con = contr->orig_stats.Con;
810 stats.Int = contr->orig_stats.Int;
811 stats.Wis = contr->orig_stats.Wis;
812 stats.Pow = contr->orig_stats.Pow;
813 stats.Cha = contr->orig_stats.Cha;
814 677
815 //TODO: the following code looks so borked and should, at the very least, 678 //TODO: the following code looks so borked and should, at the very least,
816 // be merged with the similar code in roll_stats 679 // be merged with the similar code in roll_stats
817 stats.ac = 0; 680 stats.ac = 0;
818 681
830 contr->levsp[1] = 6; 693 contr->levsp[1] = 6;
831 contr->levgrace[1] = 3; 694 contr->levgrace[1] = 3;
832 695
833 contr->orig_stats = stats; 696 contr->orig_stats = stats;
834 } 697 }
698}
699
700static void
701start_info (object *op)
702{
703 char buf[MAX_BUF];
704
705 sprintf (buf, "Welcome to Deliantra v%s!", VERSION);
706 new_draw_info (NDI_UNIQUE, 0, op, buf);
835} 707}
836 708
837/* This function takes the key that is passed, and does the 709/* This function takes the key that is passed, and does the
838 * appropriate action with it (change race, or other things). 710 * appropriate action with it (change race, or other things).
839 * The function name is for historical reasons - now we have 711 * The function name is for historical reasons - now we have
840 * separate race and class; this actually changes the RACE, 712 * separate race and class; this actually changes the RACE,
841 * not the class. 713 * not the class.
842 */ 714 */
843int 715void
844key_change_class (object *op, char key) 716player::chargen_race_done ()
845{ 717{
846 int tmp_loop;
847
848 if (key == 'd' || key == 'D')
849 {
850 char buf[MAX_BUF];
851
852 /* this must before then initial items are given */ 718 /* this must before then initial items are given */
853 esrv_new_player (op->contr, op->weight + op->carrying); 719 esrv_new_player (ob->contr);
854 720
855 treasurelist *tl = find_treasurelist ("starting_wealth"); 721 treasurelist *tl = treasurelist::find (shstr_starting_wealth);
856 if (tl) 722 if (tl)
857 create_treasure (tl, op, 0, 0, 0); 723 create_treasure (tl, ob, 0, 0, 0);
858 724
859 INVOKE_PLAYER (BIRTH, op->contr); 725 INVOKE_PLAYER (BIRTH, ob->contr);
860 INVOKE_PLAYER (LOGIN, op->contr); 726 INVOKE_PLAYER (LOGIN, ob->contr);
861 727
862 op->contr->ns->state = ST_PLAYING; 728 ob->contr->ns->state = ST_PLAYING;
863 729
864 if (op->msg) 730 if (ob->msg)
865 op->msg = NULL; 731 ob->msg = 0;
866 732
867 /* We create this now because some of the unique maps will need it
868 * to save here.
869 */
870 sprintf (buf, "%s/%s/%s", settings.localdir, settings.playerdir, &op->name);
871 make_path_to_file (buf);
872
873#ifdef AUTOSAVE
874 op->contr->last_save_tick = pticks;
875#endif
876 start_info (op); 733 start_info (ob);
877 CLEAR_FLAG (op, FLAG_WIZ); 734 CLEAR_FLAG (ob, FLAG_WIZ);
878 give_initial_items (op, op->randomitems); 735 give_initial_items (ob, ob->randomitems);
879 link_player_skills (op);
880 esrv_send_inventory (op, op); 736 esrv_send_inventory (ob, ob);
881 op->update_stats (); 737 ob->update_stats ();
882 738
883 /* This moves the player to a different start map, if there 739 /* This moves the player to a different start map, if there
884 * is one for this race 740 * is one for this race
885 */ 741 */
886 if (*first_map_ext_path) 742 if (*first_map_ext_path)
887 { 743 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
888 object *tmp;
889 char mapname[MAX_BUF];
890
891 snprintf (mapname, MAX_BUF - 1, "%s/%s", first_map_ext_path, &op->arch->name);
892 tmp = object::create ();
893 EXIT_PATH (tmp) = mapname;
894 EXIT_X (tmp) = op->x;
895 EXIT_Y (tmp) = op->y;
896 enter_exit (op, tmp); /* we don't really care if it succeeded;
897 * if the map isn't there, then stay on the
898 * default initial map */
899 tmp->destroy ();
900 }
901 else 744 else
902 LOG (llevDebug, "first_map_ext_path not set\n"); 745 LOG (llevDebug, "first_map_ext_path not set\n");
746}
903 747
904 return 0; 748void
905 } 749player::chargen_race_next ()
906 750{
907 /* Following actually changes the race - this is the default command 751 /* Following actually changes the race - this is the default command
908 * if we don't match with one of the options above. 752 * if we don't match with one of the options above.
909 */ 753 */
910 754
911 tmp_loop = 0; 755 do
912 while (!tmp_loop)
913 { 756 {
914 shstr name = op->name; 757 shstr name = ob->name;
915 int x = op->x, y = op->y; 758 int x = ob->x, y = ob->y;
916 759
917 op->remove_statbonus (); 760 ob->remove_statbonus ();
918 op->remove (); 761 ob->remove ();
919 op->arch = get_player_archetype (op->arch); 762 ob->arch = get_player_archetype (ob->arch);
920 op->arch->clone.copy_to (op); 763 ob->arch->copy_to (ob);
921 op->instantiate (); 764 ob->instantiate ();
922 op->stats = op->contr->orig_stats; 765 ob->stats = ob->contr->orig_stats;
923 op->name = op->name_pl = name; 766 ob->name = ob->name_pl = name;
924 op->x = x; 767 ob->x = x;
925 op->y = y; 768 ob->y = y;
926 SET_ANIMATION (op, 2); /* So player faces south */ 769 SET_ANIMATION (ob, 2); /* So player faces south */
927 insert_ob_in_map (op, op->map, op, 0); 770 insert_ob_in_map (ob, ob->map, ob, 0);
928 assign (op->contr->title, op->arch->clone.name); 771 assign (ob->contr->title, ob->arch->object::name);
929 op->add_statbonus (); 772 ob->add_statbonus ();
930 tmp_loop = allowed_class (op);
931 } 773 }
774 while (!allowed_class (ob));
932 775
933 update_object (op, UP_OBJ_FACE); 776 update_object (ob, UP_OBJ_FACE);
934 esrv_update_item (UPD_FACE, op, op); 777 esrv_update_item (UPD_FACE, ob, ob);
935 op->update_stats (); 778 ob->update_stats ();
936 op->stats.hp = op->stats.maxhp; 779 ob->stats.hp = ob->stats.maxhp;
937 op->stats.sp = op->stats.maxsp; 780 ob->stats.sp = ob->stats.maxsp;
938 op->stats.grace = 0; 781 ob->stats.grace = 0;
939
940 if (op->msg)
941 new_draw_info (NDI_BLUE, 0, op, op->msg);
942
943 send_query (op->contr->ns, CS_QUERY_SINGLECHAR, "Press any key for the next race.\nPress `d' to play this race.\n");
944 return 0;
945} 782}
946 783
947int 784static void
948key_confirm_quit (object *op, char key)
949{
950 if (key != 'y' && key != 'Y' && key != 'q' && key != 'Q')
951 {
952 op->contr->ns->state = ST_PLAYING;
953 new_draw_info (NDI_UNIQUE, 0, op, "OK, continuing to play.");
954 return 1;
955 }
956
957 INVOKE_PLAYER (LOGOUT, op->contr);
958 INVOKE_PLAYER (QUIT, op->contr);
959
960 terminate_all_pets (op);
961 leave_map (op);
962 op->direction = 0;
963 new_draw_info_format (NDI_UNIQUE | NDI_ALL, 5, NULL, "%s quits the game.", &op->name);
964
965 strcpy (op->contr->killer, "quit");
966 check_score (op);
967 op->contr->party = 0;
968 op->contr->own_title[0] = '\0';
969
970 object_ptr ob = op;
971
972 delete ob->contr;
973
974 /* We need to hunt for any per player unique maps in memory and
975 * get rid of them. The trailing slash in the path is intentional,
976 * so that players named 'Ab' won't match against players 'Abe' pathname
977 */
978 char buf[MAX_BUF];
979 sprintf (buf, "%s/%s/%s/", settings.localdir, settings.playerdir, &op->name);
980
981 for (maptile *next, *mp = first_map; mp; mp = next)
982 {
983 next = mp->next;
984
985 if (!strncmp (mp->path, buf, strlen (buf)))
986 delete_map (mp);
987 }
988
989 delete_character (ob->name, 1);
990
991 return 1;
992}
993
994void
995flee_player (object *op) 785flee_player (object *op)
996{ 786{
997 int dir, diff; 787 int dir, diff;
998 rv_vector rv; 788 rv_vector rv;
999 789
1002 LOG (llevDebug, "Fleeing player is dead.\n"); 792 LOG (llevDebug, "Fleeing player is dead.\n");
1003 CLEAR_FLAG (op, FLAG_SCARED); 793 CLEAR_FLAG (op, FLAG_SCARED);
1004 return; 794 return;
1005 } 795 }
1006 796
1007 if (op->enemy == NULL) 797 if (!op->enemy)
1008 { 798 {
1009 LOG (llevDebug, "Fleeing player had no enemy.\n"); 799 LOG (llevDebug, "Fleeing player had no enemy.\n");
1010 CLEAR_FLAG (op, FLAG_SCARED); 800 CLEAR_FLAG (op, FLAG_SCARED);
1011 return; 801 return;
1012 } 802 }
1013 803
1014 /* Seen some crashes here. Since we don't store an
1015 * op->enemy_count, it is possible that something destroys the
1016 * actual enemy, and the object is recycled.
1017 */
1018 if (op->enemy->map == NULL)
1019 {
1020 CLEAR_FLAG (op, FLAG_SCARED);
1021 op->enemy = NULL;
1022 return;
1023 }
1024
1025 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0)) 804 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
1026 { 805 {
1027 op->enemy = NULL; 806 op->enemy = NULL;
1028 CLEAR_FLAG (op, FLAG_SCARED); 807 CLEAR_FLAG (op, FLAG_SCARED);
1029 return; 808 return;
1032 get_rangevector (op, op->enemy, &rv, 0); 811 get_rangevector (op, op->enemy, &rv, 0);
1033 812
1034 dir = absdir (4 + rv.direction); 813 dir = absdir (4 + rv.direction);
1035 for (diff = 0; diff < 3; diff++) 814 for (diff = 0; diff < 3; diff++)
1036 { 815 {
1037 int m = 1 - (RANDOM () & 2); 816 int m = 1 - rndm (2) * 2;
1038 817
1039 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 818 if (op->move (absdir (dir + diff * m)) || (diff == 0 && op->move (absdir (dir - diff * m))))
1040 return; 819 return;
1041 } 820 }
1042 821
1043 /* Cornered, get rid of scared */ 822 /* Cornered, get rid of scared */
1044 CLEAR_FLAG (op, FLAG_SCARED); 823 CLEAR_FLAG (op, FLAG_SCARED);
1045 op->enemy = NULL; 824 op->enemy = NULL;
1046} 825}
1047 826
1048
1049/* check_pick sees if there is stuff to be picked up/picks up stuff. 827/* check_pick sees if there is stuff to be picked up/picks up stuff.
1050 * IT returns 1 if the player should keep on moving, 0 if he should 828 * It returns 1 if the player should keep on moving, 0 if he should
1051 * stop. 829 * stop.
1052 */ 830 */
1053int 831int
1054check_pick (object *op) 832check_pick (object *op)
1055{ 833{
1056 object *tmp, *next; 834 object *tmp, *next;
1057 int stop = 0; 835 int stop = 0;
1058 int j, k, wvratio; 836 int wvratio;
1059 char putstring[128], tmpstr[16];
1060 837
1061 /* if you're flying, you cna't pick up anything */ 838 /* if you're flying, you can't pick up anything */
1062 if (op->move_type & MOVE_FLYING) 839 if (op->move_type & MOVE_FLYING)
1063 return 1; 840 return 1;
1064 841
1065 next = op->below; 842 next = op->below;
843
844 int cnt = MAX_ITEM_PER_ACTION;
845#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
1066 846
1067 /* loop while there are items on the floor that are not marked as 847 /* loop while there are items on the floor that are not marked as
1068 * destroyed */ 848 * destroyed */
1069 while (next && !next->destroyed ()) 849 while (next && !next->destroyed ())
1070 { 850 {
1071 tmp = next; 851 tmp = next;
1072 next = tmp->below; 852 next = tmp->below;
1073 853
854 if (cnt <= 0)
855 {
856 op->failmsg ("Couldn't pickup all items at once.");
857 return 0;
858 }
859
1074 if (op->destroyed ()) 860 if (op->destroyed ())
1075 return 0; 861 return 0;
1076 862
1077 if (!can_pick (op, tmp)) 863 if (!can_pick (op, tmp))
1078 continue; 864 continue;
1079 865
1080 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 866 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1081 { 867 {
1082 if (item_matched_string (op, tmp, op->contr->search_str)) 868 if (item_matched_string (op, tmp, op->contr->search_str))
1083 pick_up (op, tmp); 869 CHK_PICK_PICKUP;
870
1084 continue; 871 continue;
1085 } 872 }
1086 873
1087 /* high not bit set? We're using the old autopickup model */ 874 /* pickup handling */
875 if (op->contr->mode & PU_DEBUG)
876 {
877 /* some debugging code to figure out item information */
878 const char *str = tmp->name
879 ? format ("item name: %s item type: %d weight/value: %d",
880 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))))
881 : format ("item name: %s item type: %d weight/value: %d",
882 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
883
884 new_draw_info (NDI_UNIQUE, 0, op, str);
885 }
886
887 if (op->contr->mode & PU_INHIBIT)
888 return 1;
889
890 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
891 return 1;
892
893 /* philosophy:
894 * It's easy to grab an item type from a pile, as long as it's
895 * generic. This takes no game-time. For more detailed pickups
896 * and selections, select-items should be used. This is a
897 * grab-as-you-run type mode that's really useful for arrows for
898 * example.
899 * The drawback: right now it has no frontend, so you need to
900 * stick the bits you want into a calculator in hex mode and then
901 * convert to decimal and then 'pickup <#>
902 */
903
904 /* the first two modes are exclusive: if NOTHING we return, if
905 * STOP then we stop. All the rest are applied sequentially,
906 * meaning if any test passes, the item gets picked up. */
907
908 /* if mode is set to pick nothing up, return */
909 if (op->contr->mode == PU_NOTHING)
910 return 1;
911
912 /* if mode is set to stop when encountering objects, return */
913 /* take STOP before INHIBIT since it doesn't actually pick
914 * anything up */
915 if (op->contr->mode & PU_STOP)
916 return 0;
917
918 /* useful for going into stores and not losing your settings... */
919 /* and for battles wher you don't want to get loaded down while
920 * fighting */
921 if (op->contr->mode & PU_INHIBIT)
922 return 1;
923
924 /* prevent us from turning into auto-thieves :) */
925 if (QUERY_FLAG (tmp, FLAG_UNPAID))
926 continue;
927
928 /* ignore known cursed objects */
929 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED)
930 continue;
931
932 /* all food and drink if desired */
933 /* question: don't pick up known-poisonous stuff? */
1088 if (!(op->contr->mode & PU_NEWMODE)) 934 if (op->contr->mode & PU_FOOD)
935 if (tmp->type == FOOD)
1089 { 936 {
1090 switch (op->contr->mode) 937 CHK_PICK_PICKUP;
938 continue;
939 }
940
941 if (op->contr->mode & PU_DRINK)
942 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)))
943 {
944 CHK_PICK_PICKUP;
945 continue;
946 }
947
948 if (op->contr->mode & PU_POTION)
949 if (tmp->type == POTION)
950 {
951 CHK_PICK_PICKUP;
952 continue;
953 }
954
955 /* spellbooks, skillscrolls and normal books/scrolls */
956 if (op->contr->mode & PU_SPELLBOOK)
957 if (tmp->type == SPELLBOOK)
958 {
959 CHK_PICK_PICKUP;
960 continue;
961 }
962
963 if (op->contr->mode & PU_SKILLSCROLL)
964 if (tmp->type == SKILLSCROLL)
965 {
966 CHK_PICK_PICKUP;
967 continue;
968 }
969
970 if (op->contr->mode & PU_READABLES)
971 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
972 {
973 CHK_PICK_PICKUP;
974 continue;
975 }
976
977 /* wands/staves/rods/horns */
978 if (op->contr->mode & PU_MAGIC_DEVICE)
979 if (tmp->type == WAND
980 || tmp->type == ROD
981 || tmp->type == HORN
982 || tmp->type == POWER_CRYSTAL)
983 {
984 CHK_PICK_PICKUP;
985 continue;
986 }
987
988 /* pick up all magical items */
989 if (op->contr->mode & PU_MAGICAL)
990 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL)
991 && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
992 {
993 CHK_PICK_PICKUP;
994 continue;
995 }
996
997 if (op->contr->mode & PU_VALUABLES)
998 {
999 if (tmp->type == MONEY || tmp->type == GEM)
1091 { 1000 {
1092 case 0: 1001 CHK_PICK_PICKUP;
1093 return 1; /* don't pick up */ 1002 continue;
1094 case 1:
1095 pick_up (op, tmp);
1096 return 1;
1097 case 2:
1098 pick_up (op, tmp);
1099 return 0;
1100 case 3:
1101 return 0; /* stop before pickup */
1102 case 4:
1103 pick_up (op, tmp);
1104 break;
1105 case 5:
1106 pick_up (op, tmp);
1107 stop = 1;
1108 break;
1109 case 6:
1110 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1111 pick_up (op, tmp);
1112 break;
1113
1114 case 7:
1115 if (tmp->type == MONEY || tmp->type == GEM)
1116 pick_up (op, tmp);
1117 break;
1118
1119 default:
1120 /* use value density */
1121 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1122 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1123 pick_up (op, tmp);
1124 } 1003 }
1125 } 1004 }
1126 else 1005
1127 { /* old model */ 1006 /* rings & amulets - talismans seems to be typed AMULET */
1128 /* NEW pickup handling */
1129 if (op->contr->mode & PU_DEBUG) 1007 if (op->contr->mode & PU_JEWELS)
1008 if (tmp->type == RING
1009 || tmp->type == AMULET
1010 || tmp->type == GIRDLE
1011 || tmp->type == SKILL_TOOL)
1130 { 1012 {
1131 /* some debugging code to figure out item information */ 1013 CHK_PICK_PICKUP;
1132 if (tmp->name != NULL)
1133 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1134 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1135 else
1136 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1137 &tmp->arch->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1138 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1139
1140 sprintf (putstring, "...flags: ");
1141 for (k = 0; k < 4; k++)
1142 {
1143 for (j = 0; j < 32; j++)
1144 {
1145 if ((tmp->flags[k] >> j) & 0x01)
1146 {
1147 sprintf (tmpstr, "%d ", k * 32 + j);
1148 strcat (putstring, tmpstr);
1149 }
1150 }
1151 }
1152 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1153
1154#if 0
1155 /* print the flags too */
1156 for (k = 0; k < 4; k++)
1157 {
1158 fprintf (stderr, "%d [%d] ", k, k * 32 + 31);
1159 for (j = 0; j < 32; j++)
1160 {
1161 fprintf (stderr, "%d", tmp->flags[k] >> (31 - j) & 0x01);
1162 if (!((j + 1) % 4))
1163 fprintf (stderr, " ");
1164 }
1165 fprintf (stderr, " [%d]\n", k * 32);
1166 }
1167#endif
1168 }
1169 /* philosophy:
1170 * It's easy to grab an item type from a pile, as long as it's
1171 * generic. This takes no game-time. For more detailed pickups
1172 * and selections, select-items shoul dbe used. This is a
1173 * grab-as-you-run type mode that's really useful for arrows for
1174 * example.
1175 * The drawback: right now it has no frontend, so you need to
1176 * stick the bits you want into a calculator in hex mode and then
1177 * convert to decimal and then 'pickup <#>
1178 */
1179
1180 /* the first two modes are exclusive: if NOTHING we return, if
1181 * STOP then we stop. All the rest are applied sequentially,
1182 * meaning if any test passes, the item gets picked up. */
1183
1184 /* if mode is set to pick nothing up, return */
1185
1186 if (op->contr->mode & PU_NOTHING)
1187 return 1;
1188
1189 /* if mode is set to stop when encountering objects, return */
1190 /* take STOP before INHIBIT since it doesn't actually pick
1191 * anything up */
1192
1193 if (op->contr->mode & PU_STOP)
1194 return 0;
1195
1196 /* useful for going into stores and not losing your settings... */
1197 /* and for battles wher you don't want to get loaded down while
1198 * fighting */
1199 if (op->contr->mode & PU_INHIBIT)
1200 return 1;
1201
1202 /* prevent us from turning into auto-thieves :) */
1203 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1204 continue; 1014 continue;
1015 }
1205 1016
1206 /* ignore known cursed objects */ 1017 /* we don't forget dragon food */
1207 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1018 if (op->contr->mode & PU_FLESH)
1019 if (tmp->type == FLESH)
1020 {
1021 CHK_PICK_PICKUP;
1208 continue; 1022 continue;
1023 }
1209 1024
1210 /* all food and drink if desired */ 1025 /* bows and arrows. Bows are good for selling! */
1211 /* question: don't pick up known-poisonous stuff? */ 1026 if (op->contr->mode & PU_BOW)
1027 if (tmp->type == BOW)
1028 {
1029 CHK_PICK_PICKUP;
1030 continue;
1031 }
1032
1033 if (op->contr->mode & PU_ARROW)
1034 if (tmp->type == ARROW)
1035 {
1036 CHK_PICK_PICKUP;
1037 continue;
1038 }
1039
1040 /* all kinds of armor etc. */
1041 if (op->contr->mode & PU_ARMOUR)
1042 if (tmp->type == ARMOUR)
1043 {
1044 CHK_PICK_PICKUP;
1045 continue;
1046 }
1047
1048 if (op->contr->mode & PU_HELMET)
1049 if (tmp->type == HELMET)
1050 {
1051 CHK_PICK_PICKUP;
1052 continue;
1053 }
1054
1055 if (op->contr->mode & PU_SHIELD)
1056 if (tmp->type == SHIELD)
1057 {
1058 CHK_PICK_PICKUP;
1059 continue;
1060 }
1061
1212 if (op->contr->mode & PU_FOOD) 1062 if (op->contr->mode & PU_BOOTS)
1213 if (tmp->type == FOOD) 1063 if (tmp->type == BOOTS)
1064 {
1065 CHK_PICK_PICKUP;
1066 continue;
1067 }
1068
1069 if (op->contr->mode & PU_GLOVES)
1070 if (tmp->type == GLOVES || tmp->type == BRACERS)
1071 {
1072 CHK_PICK_PICKUP;
1073 continue;
1074 }
1075
1076 if (op->contr->mode & PU_CLOAK)
1077 if (tmp->type == CLOAK)
1078 {
1079 CHK_PICK_PICKUP;
1080 continue;
1081 }
1082
1083 /* hoping to catch throwing daggers here */
1084 if (op->contr->mode & PU_MISSILEWEAPON)
1085 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1086 {
1087 CHK_PICK_PICKUP;
1088 continue;
1089 }
1090
1091 /* careful: chairs and tables are weapons! */
1092 if (op->contr->mode & PU_ALLWEAPON)
1093 {
1094 if (tmp->type == WEAPON)
1095 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1214 { 1096 {
1215 pick_up (op, tmp); 1097 CHK_PICK_PICKUP;
1216 continue; 1098 continue;
1217 } 1099 }
1100 }
1218 1101
1102 /* misc stuff that's useful */
1219 if (op->contr->mode & PU_DRINK) 1103 if (op->contr->mode & PU_KEY)
1220 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1104 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1221 { 1105 {
1222 pick_up (op, tmp); 1106 CHK_PICK_PICKUP;
1223 continue; 1107 continue;
1224 } 1108 }
1225 1109
1110 /* any of the last 4 bits set means we use the ratio for value
1111 * pickups */
1226 if (op->contr->mode & PU_POTION) 1112 if (op->contr->mode & PU_RATIO)
1227 if (tmp->type == POTION) 1113 {
1114 /* use value density to decide what else to grab */
1115 /* >=7 was >= op->contr->mode */
1116 /* >=7 is the old standard setting. Now we take the last 4 bits
1228 { 1117 */
1229 pick_up (op, tmp);
1230 continue;
1231 }
1232
1233 /* spellbooks, skillscrolls and normal books/scrolls */
1234 if (op->contr->mode & PU_SPELLBOOK)
1235 if (tmp->type == SPELLBOOK)
1236 {
1237 pick_up (op, tmp);
1238 continue;
1239 }
1240
1241 if (op->contr->mode & PU_SKILLSCROLL)
1242 if (tmp->type == SKILLSCROLL)
1243 {
1244 pick_up (op, tmp);
1245 continue;
1246 }
1247
1248 if (op->contr->mode & PU_READABLES)
1249 if (tmp->type == BOOK || tmp->type == SCROLL)
1250 {
1251 pick_up (op, tmp);
1252 continue;
1253 }
1254
1255 /* wands/staves/rods/horns */
1256 if (op->contr->mode & PU_MAGIC_DEVICE)
1257 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1258 {
1259 pick_up (op, tmp);
1260 continue;
1261 }
1262
1263 /* pick up all magical items */
1264 if (op->contr->mode & PU_MAGICAL) 1118 wvratio = op->contr->mode & PU_RATIO;
1265 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1119 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1266 {
1267 pick_up (op, tmp);
1268 continue;
1269 }
1270
1271 if (op->contr->mode & PU_VALUABLES)
1272 { 1120 {
1273 if (tmp->type == MONEY || tmp->type == GEM) 1121#if 0
1122 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1123 if (tmp->name != NULL)
1274 { 1124 {
1275 pick_up (op, tmp); 1125 fprintf (stderr, "%s", tmp->name);
1276 continue;
1277 } 1126 }
1278 }
1279
1280 /* rings & amulets - talismans seems to be typed AMULET */
1281 if (op->contr->mode & PU_JEWELS)
1282 if (tmp->type == RING || tmp->type == AMULET)
1283 {
1284 pick_up (op, tmp);
1285 continue;
1286 }
1287
1288 /* we don't forget dragon food */
1289 if (op->contr->mode & PU_FLESH)
1290 if (tmp->type == FLESH)
1291 {
1292 pick_up (op, tmp);
1293 continue;
1294 }
1295
1296 /* bows and arrows. Bows are good for selling! */
1297 if (op->contr->mode & PU_BOW)
1298 if (tmp->type == BOW)
1299 {
1300 pick_up (op, tmp);
1301 continue;
1302 }
1303
1304 if (op->contr->mode & PU_ARROW)
1305 if (tmp->type == ARROW)
1306 {
1307 pick_up (op, tmp);
1308 continue;
1309 }
1310
1311 /* all kinds of armor etc. */
1312 if (op->contr->mode & PU_ARMOUR)
1313 if (tmp->type == ARMOUR)
1314 {
1315 pick_up (op, tmp);
1316 continue;
1317 }
1318
1319 if (op->contr->mode & PU_HELMET)
1320 if (tmp->type == HELMET)
1321 {
1322 pick_up (op, tmp);
1323 continue;
1324 }
1325
1326 if (op->contr->mode & PU_SHIELD)
1327 if (tmp->type == SHIELD)
1328 {
1329 pick_up (op, tmp);
1330 continue;
1331 }
1332
1333 if (op->contr->mode & PU_BOOTS)
1334 if (tmp->type == BOOTS)
1335 {
1336 pick_up (op, tmp);
1337 continue;
1338 }
1339
1340 if (op->contr->mode & PU_GLOVES)
1341 if (tmp->type == GLOVES)
1342 {
1343 pick_up (op, tmp);
1344 continue;
1345 }
1346
1347 if (op->contr->mode & PU_CLOAK)
1348 if (tmp->type == CLOAK)
1349 {
1350 pick_up (op, tmp);
1351 continue;
1352 }
1353
1354 /* hoping to catch throwing daggers here */
1355 if (op->contr->mode & PU_MISSILEWEAPON)
1356 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1357 {
1358 pick_up (op, tmp);
1359 continue;
1360 }
1361
1362 /* careful: chairs and tables are weapons! */
1363 if (op->contr->mode & PU_ALLWEAPON)
1364 {
1365 if (tmp->type == WEAPON && tmp->name != NULL)
1366 {
1367 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->name, "table") == NULL &&
1368 strstr (tmp->name, "chair") && strstr (tmp->arch->name, "chair") == NULL)
1369 {
1370 pick_up (op, tmp);
1371 continue;
1372 }
1373 }
1374
1375 if (tmp->type == WEAPON && tmp->name == NULL)
1376 {
1377 if (strstr (tmp->arch->name, "table") == NULL && strstr (tmp->arch->name, "chair") == NULL)
1378 {
1379 pick_up (op, tmp);
1380 continue;
1381 }
1382 }
1383 }
1384
1385 /* misc stuff that's useful */
1386 if (op->contr->mode & PU_KEY)
1387 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1388 {
1389 pick_up (op, tmp);
1390 continue;
1391 }
1392
1393 /* any of the last 4 bits set means we use the ratio for value
1394 * pickups */
1395 if (op->contr->mode & PU_RATIO)
1396 {
1397 /* use value density to decide what else to grab */
1398 /* >=7 was >= op->contr->mode */
1399 /* >=7 is the old standard setting. Now we take the last 4 bits
1400 * and multiply them by 5, giving 0..15*5== 5..75 */
1401 wvratio = (op->contr->mode & PU_RATIO) * 5;
1402 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio)
1403 {
1404 pick_up (op, tmp);
1405#if 0
1406 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1407 if (tmp->name != NULL)
1408 {
1409 fprintf (stderr, "%s", tmp->name);
1410 }
1411 else 1127 else
1412 fprintf (stderr, "%s", tmp->arch->name); 1128 fprintf (stderr, "%s", tmp->arch->archname);
1413 fprintf (stderr, ",%d] = ", tmp->type); 1129 fprintf (stderr, ",%d] = ", tmp->type);
1414 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1130 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
1415#endif 1131#endif
1132 CHK_PICK_PICKUP;
1416 continue; 1133 continue;
1417 }
1418 } 1134 }
1419 } /* the new pickup model */ 1135 } /* the new pickup model */
1420 } 1136 }
1421 1137
1422 return !stop; 1138 return !stop;
1139}
1140
1141/* routine for both players and monsters. We call this when
1142 * there is a possibility for our action distrubing our hiding
1143 * place or invisiblity spell. Artefact invisiblity causes
1144 * "noise" instead. If we arent invisible to begin with, we
1145 * return 0.
1146 */
1147static int
1148action_makes_visible (object *op)
1149{
1150 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
1151 {
1152 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
1153 {
1154 // artefact invisibility is permanent, but we still make noise
1155 // this is important for game-balance.
1156 if (op->contr)
1157 op->make_noise ();
1158
1159 return 0;
1160 }
1161
1162 if (op->contr && op->contr->tmp_invis == 0)
1163 return 0;
1164
1165 /* If monsters, they should become visible */
1166 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
1167 {
1168 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
1169 return 1;
1170 }
1171 }
1172
1173 return 0;
1423} 1174}
1424 1175
1425/* 1176/*
1426 * Find an arrow in the inventory and after that 1177 * Find an arrow in the inventory and after that
1427 * in the right type container (quiver). Pointer to the 1178 * in the right type container (quiver). Pointer to the
1428 * found object is returned. 1179 * found object is returned.
1429 */ 1180 */
1430object * 1181static object *
1431find_arrow (object *op, const char *type) 1182find_arrow (object *op, const char *type)
1432{ 1183{
1433 object *tmp = NULL;
1434
1435 for (op = op->inv; op; op = op->below) 1184 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1436 if (!tmp && op->type == CONTAINER && op->race == type && QUERY_FLAG (op, FLAG_APPLIED))
1437 tmp = find_arrow (op, type);
1438 else if (op->type == ARROW && op->race == type) 1185 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1186 return splay (tmp);
1187
1188 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1189 if (tmp->type == CONTAINER && QUERY_FLAG (tmp, FLAG_APPLIED) && !strcmp (&tmp->race, type))
1190 if (object *arrow = find_arrow (tmp, type))
1191 {
1192 splay (tmp);
1439 return op; 1193 return arrow;
1194 }
1195
1440 return tmp; 1196 return 0;
1441} 1197}
1442 1198
1443/* 1199/*
1444 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1200 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1445 * against the target. A full test is not performed, simply a basic test 1201 * against the target. A full test is not performed, simply a basic test
1446 * of resistances. The archer is making a quick guess at what he sees down 1202 * of resistances. The archer is making a quick guess at what he sees down
1447 * the hall. Failing that it does it's best to pick the highest plus arrow. 1203 * the hall. Failing that it does it's best to pick the highest plus arrow.
1448 */ 1204 */
1449 1205static object *
1450object *
1451find_better_arrow (object *op, object *target, const char *type, int *better) 1206find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1452{ 1207{
1453 object *tmp = NULL, *arrow, *ntmp; 1208 object *tmp = NULL, *arrow, *ntmp;
1454 int attacknum, attacktype, betterby = 0, i; 1209 int attacknum, attacktype, betterby = 0, i;
1455 1210
1456 if (!type) 1211 if (!type)
1460 { 1215 {
1461 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1216 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED))
1462 { 1217 {
1463 i = 0; 1218 i = 0;
1464 ntmp = find_better_arrow (arrow, target, type, &i); 1219 ntmp = find_better_arrow (arrow, target, type, &i);
1220
1465 if (i > betterby) 1221 if (i > betterby)
1466 { 1222 {
1467 tmp = ntmp; 1223 tmp = ntmp;
1468 betterby = i; 1224 betterby = i;
1469 } 1225 }
1470 } 1226 }
1471 else if (arrow->type == ARROW && arrow->race == type) 1227 else if (arrow->type == ARROW && arrow->race == type)
1472 { 1228 {
1473 /* allways prefer assasination/slaying */ 1229 /* allways prefer assasination/slaying */
1474 if (target->race != NULL && arrow->slaying != NULL && strstr (arrow->slaying, target->race)) 1230 if (target->race && arrow->slaying.contains (target->race))
1475 { 1231 {
1476 if (arrow->attacktype & AT_DEATH) 1232 if (arrow->attacktype & AT_DEATH)
1477 { 1233 {
1478 *better = 100; 1234 *better = 100;
1479 return arrow; 1235 return arrow;
1487 else 1243 else
1488 { 1244 {
1489 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++) 1245 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++)
1490 { 1246 {
1491 attacktype = 1 << attacknum; 1247 attacktype = 1 << attacknum;
1492 if ((arrow->attacktype & attacktype) && (target->arch->clone.resist[attacknum]) < 0) 1248 if ((arrow->attacktype & attacktype) && (target->arch->resist[attacknum]) < 0)
1493 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100) > betterby) 1249 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100) > betterby)
1494 { 1250 {
1495 tmp = arrow; 1251 tmp = arrow;
1496 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100; 1252 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1497 } 1253 }
1498 } 1254 }
1255
1499 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1256 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1500 { 1257 {
1501 tmp = arrow; 1258 tmp = arrow;
1502 betterby = 2 + arrow->magic + arrow->stats.dam; 1259 betterby = 2 + arrow->magic + arrow->stats.dam;
1503 } 1260 }
1261
1504 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1262 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1505 { 1263 {
1506 tmp = arrow; 1264 tmp = arrow;
1507 betterby = 1 + arrow->magic + arrow->stats.dam; 1265 betterby = 1 + arrow->magic + arrow->stats.dam;
1508 } 1266 }
1509 } 1267 }
1510 } 1268 }
1511 } 1269 }
1270
1512 if (tmp == NULL && arrow == NULL) 1271 if (tmp == NULL && arrow == NULL)
1513 return find_arrow (op, type); 1272 return find_arrow (op, type);
1514 1273
1515 *better = betterby; 1274 *better = betterby;
1516 return tmp; 1275 return tmp;
1520 * find_better_arrow to find a decent arrow to use. 1279 * find_better_arrow to find a decent arrow to use.
1521 * op = the shooter 1280 * op = the shooter
1522 * type = bow->race 1281 * type = bow->race
1523 * dir = fire direction 1282 * dir = fire direction
1524 */ 1283 */
1525 1284static object *
1526object *
1527pick_arrow_target (object *op, const char *type, int dir) 1285pick_arrow_target (object *op, shstr_cmp type, int dir)
1528{ 1286{
1529 object *tmp = NULL; 1287 object *tmp = NULL;
1530 maptile *m; 1288 maptile *m;
1531 int i, mflags, found, number; 1289 int i, mflags, found, number;
1532 sint16 x, y; 1290 sint16 x, y;
1547 for (i = 0, found = 0; i < 20; i++) 1305 for (i = 0, found = 0; i < 20; i++)
1548 { 1306 {
1549 x += freearr_x[dir]; 1307 x += freearr_x[dir];
1550 y += freearr_y[dir]; 1308 y += freearr_y[dir];
1551 mflags = get_map_flags (m, &m, x, y, &x, &y); 1309 mflags = get_map_flags (m, &m, x, y, &x, &y);
1310
1552 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1311 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1553 { 1312 {
1554 tmp = NULL; 1313 tmp = 0;
1555 break; 1314 break;
1556 } 1315 }
1557 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1316 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1558 { 1317 {
1559 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1318 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1560 * perhaps a bad assumption. 1319 * perhaps a bad assumption.
1561 */ 1320 */
1562 tmp = NULL; 1321 tmp = 0;
1563 break; 1322 break;
1564 } 1323 }
1324
1565 if (mflags & P_IS_ALIVE) 1325 if (mflags & P_IS_ALIVE)
1566 {
1567 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1326 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1568 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1327 if (QUERY_FLAG (tmp, FLAG_ALIVE))
1569 {
1570 found++;
1571 break;
1572 }
1573 if (found)
1574 break; 1328 break;
1575 }
1576 } 1329 }
1577 if (tmp == NULL) 1330
1331 if (!tmp)
1578 return find_arrow (op, type); 1332 return find_arrow (op, type);
1579 1333
1580 if (tmp->head) 1334 if (tmp->head)
1581 tmp = tmp->head; 1335 tmp = tmp->head;
1582 1336
1595 */ 1349 */
1596int 1350int
1597fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy) 1351fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy)
1598{ 1352{
1599 object *left, *bow; 1353 object *left, *bow;
1600 int bowspeed, mflags; 1354 int mflags;
1601 maptile *m; 1355 maptile *m;
1602 1356
1603 if (!dir) 1357 if (!dir)
1604 { 1358 {
1605 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!"); 1359 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!");
1606 return 0; 1360 return 0;
1607 } 1361 }
1608 1362
1609 if (op->type == PLAYER) 1363 if (op->contr)
1610 bow = op->contr->ranges[range_bow]; 1364 bow = op->current_weapon;
1611 else 1365 else
1612 { 1366 {
1613 for (bow = op->inv; bow; bow = bow->below) 1367 for (bow = op->inv; bow; bow = bow->below)
1614 /* Don't check for applied - monsters don't apply bows - in that way, they 1368 /* Don't check for applied - monsters don't apply bows - in that way, they
1615 * don't need to switch back and forth between bows and weapons. 1369 * don't need to switch back and forth between bows and weapons.
1620 if (!bow) 1374 if (!bow)
1621 { 1375 {
1622 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1376 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1623 return 0; 1377 return 0;
1624 } 1378 }
1379
1380 // optimisation: move object to top so we will find it quickly again
1381 splay (bow);
1625 } 1382 }
1626 1383
1627 if (!bow->race || !bow->skill) 1384 if (!bow->race || !bow->skill)
1628 { 1385 {
1629 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1386 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1630 return 0; 1387 return 0;
1631 } 1388 }
1632
1633 bowspeed = bow->stats.sp + dex_bonus[op->stats.Dex];
1634
1635 /* penalize ROF for bestarrow */
1636 if (op->type == PLAYER && op->contr->bowtype == bow_bestarrow)
1637 bowspeed -= dex_bonus[op->stats.Dex] + 5;
1638
1639 if (bowspeed < 1)
1640 bowspeed = 1;
1641 1389
1642 if (arrow == NULL) 1390 if (arrow == NULL)
1643 { 1391 {
1644 if ((arrow = find_arrow (op, bow->race)) == NULL) 1392 if ((arrow = find_arrow (op, bow->race)) == NULL)
1645 { 1393 {
1646 if (op->type == PLAYER) 1394 if (op->type == PLAYER)
1647 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1395 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1648 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1396 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1649 else 1397 else
1650 CLEAR_FLAG (op, FLAG_READY_BOW); 1398 CLEAR_FLAG (op, FLAG_READY_BOW);
1399
1651 return 0; 1400 return 0;
1652 } 1401 }
1653 } 1402 }
1654 1403
1655 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy); 1404 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy);
1663 } 1412 }
1664 1413
1665 /* this should not happen, but sometimes does */ 1414 /* this should not happen, but sometimes does */
1666 if (arrow->nrof == 0) 1415 if (arrow->nrof == 0)
1667 { 1416 {
1417 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1668 arrow->destroy (); 1418 arrow->destroy ();
1669 return 0; 1419 return 0;
1670 } 1420 }
1671 1421
1672 left = arrow; /* these are arrows left to the player */ 1422 left = arrow; /* these are arrows left to the player */
1673 arrow = get_split_ob (arrow, 1); 1423 arrow = arrow->split ();
1674 if (!arrow) 1424 if (!arrow)
1675 { 1425 {
1676 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1426 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1677 return 0; 1427 return 0;
1678 } 1428 }
1679 1429
1680 arrow->set_owner (op); 1430 arrow->set_owner (op);
1681 arrow->skill = bow->skill; 1431 arrow->skill = bow->skill;
1682
1683 arrow->direction = dir; 1432 arrow->direction = dir;
1684 arrow->x = sx; 1433
1685 arrow->y = sy; 1434 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1435 arrow->stats.hp = arrow->stats.dam;
1436 arrow->stats.grace = arrow->attacktype;
1437 arrow->custom_name = arrow->slaying;
1438
1439#if 0
1440 if (player *pl = op->contr)
1441 {
1442 float speed = pl->weapon_sp;
1443
1444 /* penalize ROF for bestarrow */
1445 if (pl->bowtype == bow_bestarrow)
1446 speed *= .9f;
1447 else
1448 speed *= 1.f + dex_bonus[op->stats.Dex] * .2f;
1449
1450 op->speed_left += speed - op->speed;
1451 }
1452#endif
1453
1454 SET_ANIMATION (arrow, arrow->direction);
1455
1456 /* update the speed */
1457 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1458 + bow->stats.dam / 7.f;
1459
1460 arrow->set_speed (max (arrow->speed, 2.f));
1461 arrow->speed_left = 0;
1462
1463 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1686 1464
1687 if (op->type == PLAYER) 1465 if (op->type == PLAYER)
1688 { 1466 {
1689 op->speed_left = 0.01 - (float) FABS (op->speed) * 100 / bowspeed;
1690 op->update_stats ();
1691 }
1692
1693 SET_ANIMATION (arrow, arrow->direction);
1694 arrow->stats.sp = arrow->stats.wc; /* save original wc and dam */
1695 arrow->stats.hp = arrow->stats.dam;
1696 arrow->stats.grace = arrow->attacktype;
1697 if (arrow->slaying != NULL)
1698 arrow->spellarg = strdup (arrow->slaying);
1699
1700 /* Note that this was different for monsters - they got their level
1701 * added to the damage. I think the strength bonus is more proper.
1702 */
1703
1704 arrow->stats.dam += (QUERY_FLAG (bow, FLAG_NO_STRENGTH) ? 0 : dam_bonus[op->stats.Str]) + bow->stats.dam + bow->magic + arrow->magic;
1705
1706 /* update the speed */
1707 arrow->speed = (float) ((QUERY_FLAG (bow, FLAG_NO_STRENGTH) ?
1708 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.0 + (float) bow->stats.dam / 7.0;
1709
1710 if (arrow->speed < 1.0)
1711 arrow->speed = 1.0;
1712 update_ob_speed (arrow);
1713 arrow->speed_left = 0;
1714
1715 if (op->type == PLAYER)
1716 {
1717 arrow->stats.wc = 20 - bow->magic - arrow->magic -
1718 (op->chosen_skill ? op->chosen_skill->level : op->level) -
1719 dex_bonus[op->stats.Dex] - thaco_bonus[op->stats.Str] - arrow->stats.wc - bow->stats.wc + wc_mod;
1720
1721 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level; 1467 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level;
1468 wc -= dex_bonus[op->stats.Dex];
1469
1470 if (!arrow->slaying)
1471 arrow->slaying = op->slaying;
1472
1473 arrow->attacktype |= op->attacktype;
1722 } 1474 }
1723 else 1475 else
1724 { 1476 {
1725 arrow->stats.wc = op->stats.wc - bow->magic - arrow->magic - arrow->stats.wc + wc_mod;
1726 arrow->level = op->level; 1477 arrow->level = op->level;
1727 } 1478 arrow->stats.wc -= bow->magic;
1728 1479
1729 if (arrow->attacktype == AT_PHYSICAL) 1480 if (!arrow->slaying)
1481 arrow->slaying = bow->slaying;
1482
1730 arrow->attacktype |= bow->attacktype; 1483 arrow->attacktype |= bow->attacktype;
1484 }
1731 1485
1732 if (bow->slaying) 1486 wc -= arrow->level;
1733 arrow->slaying = bow->slaying; 1487 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1734 1488
1735 arrow->map = m; 1489 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1736 arrow->move_type = MOVE_FLY_LOW; 1490 arrow->move_type = MOVE_FLY_LOW;
1737 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1491 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1738 1492
1739 play_sound_map (op->map, op->x, op->y, SOUND_FIRE_ARROW); 1493 op->play_sound (sound_find ("fire_arrow"));
1740 insert_ob_in_map (arrow, m, op, 0); 1494 m->insert (arrow, sx, sy, op);
1741 1495
1742 if (!arrow->destroyed ()) 1496 if (!arrow->destroyed ())
1743 move_arrow (arrow); 1497 move_arrow (arrow);
1744
1745 if (op->type == PLAYER)
1746 {
1747 if (left->destroyed ())
1748 esrv_del_item (op->contr, left->count);
1749 else
1750 esrv_send_item (op, left);
1751 }
1752 1498
1753 return 1; 1499 return 1;
1754} 1500}
1755 1501
1756/* Special fire code for players - this takes into 1502/* Special fire code for players - this takes into
1758 * but monsters can't. Putting that code here 1504 * but monsters can't. Putting that code here
1759 * makes the fire_bow code much cleaner. 1505 * makes the fire_bow code much cleaner.
1760 * this function should only be called if 'op' is a player, 1506 * this function should only be called if 'op' is a player,
1761 * hence the function name. 1507 * hence the function name.
1762 */ 1508 */
1763int 1509static int
1764player_fire_bow (object *op, int dir) 1510player_fire_bow (object *op, int dir)
1765{ 1511{
1766 int ret = 0, wcmod = 0; 1512 int ret;
1767 1513
1768 if (op->contr->bowtype == bow_bestarrow) 1514 if (op->contr->bowtype == bow_bestarrow)
1769 { 1515 {
1770 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranges[range_bow]->race, dir), dir, 0, op->x, op->y); 1516 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1771 } 1517 }
1772 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1518 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1773 { 1519 {
1774 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1520 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1775 wcmod = -1;
1776 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1521 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1777 } 1522 }
1778 else if (op->contr->bowtype == bow_threewide) 1523 else if (op->contr->bowtype == bow_threewide)
1779 { 1524 {
1780 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1525 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1781 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1526 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]);
1782 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1527 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]);
1783 } 1528 }
1784 else if (op->contr->bowtype == bow_spreadshot) 1529 else if (op->contr->bowtype == bow_spreadshot)
1785 { 1530 {
1786 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1531 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1787 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1532 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1788 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1533 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1789
1790 } 1534 }
1791 else 1535 else
1792 { 1536 {
1793 /* Simple case */ 1537 /* Simple case */
1794 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1538 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1795 } 1539 }
1540
1796 return ret; 1541 return ret;
1797} 1542}
1798
1799 1543
1800/* Fires a misc (wand/rod/horn) object in 'dir'. 1544/* Fires a misc (wand/rod/horn) object in 'dir'.
1801 * Broken apart from 'fire' to keep it more readable. 1545 * Broken apart from 'fire' to keep it more readable.
1802 */ 1546 */
1803void 1547static void
1804fire_misc_object (object *op, int dir) 1548fire_misc_object (object *op, int dir)
1805{ 1549{
1806 object *item; 1550 object *item = op->contr->ranged_ob;
1807 1551
1808 if (!op->contr->ranges[range_misc]) 1552 if (!item)
1809 { 1553 {
1810 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied."); 1554 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied.");
1811 return; 1555 return;
1812 } 1556 }
1813 1557
1814 item = op->contr->ranges[range_misc];
1815 if (!item->inv) 1558 if (!item->inv)
1816 { 1559 {
1817 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1560 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1818 return; 1561 return;
1819 } 1562 }
1563
1564 if (!op->apply (item))
1565 return;
1566
1820 if (item->type == WAND) 1567 if (item->type == WAND)
1821 { 1568 {
1822 if (item->stats.food <= 0) 1569 if (item->stats.food <= 0)
1823 { 1570 {
1824 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1571 op->contr->play_sound (sound_find ("wand_poof"));
1825 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0)); 1572 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0));
1573
1826 return; 1574 return;
1827 } 1575 }
1828 } 1576 }
1829 else if (item->type == ROD || item->type == HORN) 1577 else if (item->type == ROD || item->type == HORN)
1830 { 1578 {
1831 if (item->stats.hp < MAX (item->inv->stats.sp, item->inv->stats.grace)) 1579 sint16 spell_sp = max (item->inv->stats.sp, item->inv->stats.grace);
1580
1581 // using the maximum of the rods charge allows at least one spell cast
1582 // for a rod or horn, this fixes some broken rods.
1583 if (item->stats.hp < min (spell_sp, item->stats.maxhp))
1832 { 1584 {
1833 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1585 op->contr->play_sound (sound_find ("wand_poof"));
1586
1834 if (item->type == ROD) 1587 if (item->type == ROD)
1835 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1588 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1836 else 1589 else
1837 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0)); 1590 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0));
1591
1838 return; 1592 return;
1839 } 1593 }
1840 } 1594 }
1841 1595
1842 if (cast_spell (op, item, dir, item->inv, NULL)) 1596 if (cast_spell (op, item, dir, item->inv, NULL))
1843 { 1597 {
1844 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1598 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1599
1845 if (item->type == WAND) 1600 if (item->type == WAND)
1846 { 1601 {
1847 if (!(--item->stats.food)) 1602 if (!(--item->stats.food))
1848 { 1603 {
1849 object *tmp; 1604 object *tmp;
1850 1605
1851 if (item->arch) 1606 if (item->arch)
1852 { 1607 {
1853 CLEAR_FLAG (item, FLAG_ANIMATE); 1608 CLEAR_FLAG (item, FLAG_ANIMATE);
1854 item->face = item->arch->clone.face; 1609 item->face = item->arch->face;
1855 item->speed = 0; 1610 item->set_speed (0);
1856 update_ob_speed (item);
1857 } 1611 }
1858 if ((tmp = item->in_player ())) 1612
1613 if (object *pl = item->visible_to ())
1859 esrv_update_item (UPD_ANIM, tmp, item); 1614 esrv_update_item (UPD_ANIM, pl, item);
1860 } 1615 }
1861 } 1616 }
1862 else if (item->type == ROD || item->type == HORN) 1617 else if (item->type == ROD || item->type == HORN)
1863 {
1864 drain_rod_charge (item); 1618 drain_rod_charge (item);
1865 }
1866 } 1619 }
1867} 1620}
1868 1621
1869/* Received a fire command for the player - go and do it. 1622/* Received a fire command for the player - go and do it.
1870 */ 1623 */
1871void 1624bool
1872fire (object *op, int dir) 1625fire (object *who, int dir)
1873{ 1626{
1874 int spellcost = 0; 1627 int spellcost = 0;
1875 1628
1629 player *pl = who->contr;
1630
1631 if (pl->golem)
1632 {
1633 control_golem (who->contr->golem, dir);
1634 return false;
1635 }
1636
1637 object *ob = pl->ranged_ob;
1638
1639 if (!ob)
1640 return false;
1641
1642 if (who->speed_left > 0.f)
1643 --who->speed_left;
1644 else
1645 return false;
1646
1647 if (!who->apply (ob))
1648 return false;
1649
1876 /* check for loss of invisiblity/hide */ 1650 /* check for loss of invisiblity/hide */
1877 if (action_makes_visible (op)) 1651 if (action_makes_visible (who))
1878 make_visible (op); 1652 make_visible (who);
1879 1653
1880 switch (op->contr->shoottype) 1654 switch (ob->type)
1881 { 1655 {
1882 case range_none: 1656 case BOW:
1883 return;
1884
1885 case range_bow:
1886 player_fire_bow (op, dir); 1657 player_fire_bow (who, dir);
1887 return; 1658 break;
1888 1659
1889 case range_magic: /* Casting spells */ 1660 case SPELL:
1890 spellcost = (cast_spell (op, op, dir, op->contr->ranges[range_magic], op->contr->spellparam[0] ? op->contr->spellparam : 0)); 1661 spellcost = cast_spell (who, who, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1891 return; 1662 break;
1892 1663
1893 case range_misc: 1664 case BUILDER:
1894 fire_misc_object (op, dir);
1895 return;
1896
1897 case range_golem: /* Control summoned monsters from scrolls */
1898 if (QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
1899 {
1900 op->contr->ranges[range_golem] = 0;
1901 op->contr->shoottype = range_none;
1902 }
1903 else
1904 control_golem (op->contr->ranges[range_golem], dir);
1905 return;
1906
1907 case range_skill:
1908 if (!op->chosen_skill)
1909 {
1910 if (op->type == PLAYER)
1911 new_draw_info (NDI_UNIQUE, 0, op, "You have no applicable skill to use.");
1912 return;
1913 }
1914 (void) do_skill (op, op, op->chosen_skill, dir, NULL);
1915 return;
1916 case range_builder:
1917 apply_map_builder (op, dir); 1665 apply_map_builder (who, dir);
1918 return; 1666 break;
1667
1668 case SKILL:
1669 do_skill (who, who, ob, dir, 0);
1670 break;
1671
1672 case RANGED:
1673 do_skill (who, ob, who->chosen_skill, dir, 0);
1674 break;
1675
1919 default: 1676 default:
1920 new_draw_info (NDI_UNIQUE, 0, op, "Illegal shoot type."); 1677 fire_misc_object (who, dir);
1921 return; 1678 break;
1922 } 1679 }
1923}
1924 1680
1681 return true;
1682}
1925 1683
1926 1684static object *
1927/* find_key
1928 * We try to find a key for the door as passed. If we find a key
1929 * and successfully use it, we return the key, otherwise NULL
1930 * This function merges both normal and locked door, since the logic
1931 * for both is the same - just the specific key is different.
1932 * pl is the player,
1933 * inv is the objects inventory to searched
1934 * door is the door we are trying to match against.
1935 * This function can be called recursively to search containers.
1936 */
1937
1938object *
1939find_key (object *pl, object *container, object *door) 1685find_key_ (object *pl, object *container, object *door)
1940{ 1686{
1941 object *tmp, *key; 1687 object *tmp, *key;
1942 1688
1943 /* Should not happen, but sanity checking is never bad */ 1689 /* Should not happen, but sanity checking is never bad */
1944 if (container->inv == NULL) 1690 if (!container->inv)
1945 return NULL; 1691 return 0;
1946 1692
1947 /* First, lets try to find a key in the top level inventory */ 1693 /* First, lets try to find a key in the top level inventory */
1948 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1694 for (tmp = container->inv; tmp; tmp = tmp->below)
1949 { 1695 {
1950 if (door->type == DOOR && tmp->type == KEY) 1696 if (door->type == DOOR && tmp->type == KEY)
1951 break; 1697 break;
1698
1952 /* For sanity, we should really check door type, but other stuff 1699 /* For sanity, we should really check door type, but other stuff
1953 * (like containers) can be locked with special keys 1700 * (like containers) can be locked with special keys
1954 */ 1701 */
1955 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1702 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1956 break; 1703 break;
1957 } 1704 }
1705
1958 /* No key found - lets search inventories now */ 1706 /* No key found - lets search inventories now */
1959 /* If we find and use a key in an inventory, return at that time. 1707 /* If we find and use a key in an inventory, return at that time.
1960 * otherwise, if we search all the inventories and still don't find 1708 * otherwise, if we search all the inventories and still don't find
1961 * a key, return 1709 * a key, return
1962 */ 1710 */
1963 if (!tmp) 1711 if (!tmp)
1964 { 1712 {
1965 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1713 for (tmp = container->inv; tmp; tmp = tmp->below)
1966 {
1967 /* No reason to search empty containers */ 1714 /* No reason to search empty containers */
1968 if (tmp->type == CONTAINER && tmp->inv) 1715 if (tmp->type == CONTAINER && tmp->inv)
1969 {
1970 if ((key = find_key (pl, tmp, door)) != NULL) 1716 if ((key = find_key_ (pl, tmp, door)))
1971 return key; 1717 return key;
1972 } 1718
1973 }
1974 if (!tmp) 1719 if (!tmp)
1975 return NULL; 1720 return 0;
1976 } 1721 }
1722
1977 /* We get down here if we have found a key. Now if its in a container, 1723 /* We get down here if we have found a key. Now if its in a container,
1978 * see if we actually want to use it 1724 * see if we actually want to use it
1979 */ 1725 */
1980 if (pl != container) 1726 if (pl != container)
1981 { 1727 {
1982 /* Only let players use keys in containers */ 1728 /* Only let players use keys in containers */
1983 if (!pl->contr) 1729 if (!pl->contr)
1984 return NULL; 1730 return 0;
1731
1985 /* cases where this fails: 1732 /* cases where this fails:
1986 * If we only search the player inventory, return now since we 1733 * If we only search the player inventory, return now since we
1987 * are not in the players inventory. 1734 * are not in the players inventory.
1988 * If the container is not active, return now since only active 1735 * If the container is not active, return now since only active
1989 * containers can be used. 1736 * containers can be used.
1993 * inv must have been an container and must have been active. 1740 * inv must have been an container and must have been active.
1994 * 1741 *
1995 * Change the color so that the message doesn't disappear with 1742 * Change the color so that the message doesn't disappear with
1996 * all the others. 1743 * all the others.
1997 */ 1744 */
1998 if (pl->contr->usekeys == key_inventory || 1745 if (pl->contr->usekeys == key_inventory
1999 !QUERY_FLAG (container, FLAG_APPLIED) || 1746 || !QUERY_FLAG (container, FLAG_APPLIED)
2000 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1747 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
2001 { 1748 {
2002 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1749 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
2003 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1750 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
2004 return NULL; 1751 return NULL;
2005 } 1752 }
2006 } 1753 }
1754
2007 return tmp; 1755 return tmp;
1756}
1757
1758/* find_key
1759 * We try to find a key for the door as passed. If we find a key
1760 * and successfully use it, we return the key, otherwise NULL
1761 * This function merges both normal and locked door, since the logic
1762 * for both is the same - just the specific key is different.
1763 * pl is the player,
1764 * inv is the objects inventory to searched
1765 * door is the door we are trying to match against.
1766 * This function can be called recursively to search containers.
1767 */
1768object *
1769find_key (object *pl, object *container, object *door)
1770{
1771 if (door->slaying && is_match_expr (door->slaying))
1772 {
1773 // for match expressions, we try to find the key by applying the match
1774 // to the op itself, which is supposed to find the "key", instead
1775 // of searching through containers ourselves.
1776
1777 return match_one (door->slaying, container, door, pl, pl);
1778 }
1779 else
1780 return find_key_ (pl, container, door);
2008} 1781}
2009 1782
2010/* moved door processing out of move_player_attack. 1783/* moved door processing out of move_player_attack.
2011 * returns 1 if player has opened the door with a key 1784 * returns 1 if player has opened the door with a key
2012 * such that the caller should not do anything more, 1785 * such that the caller should not do anything more,
2013 * 0 otherwise 1786 * 0 otherwise
2014 */ 1787 */
2015static int 1788static int
2016player_attack_door (object *op, object *door) 1789player_attack_door (object *op, object *door)
2017{ 1790{
2018 /* If its a door, try to find a use a key. If we do destroy the door, 1791 /* If its a door, try to find a key. If we do destroy the door,
2019 * might as well return immediately as there is nothing more to do - 1792 * might as well return immediately as there is nothing more to do -
2020 * otherwise, we fall through to the rest of the code. 1793 * otherwise, we fall through to the rest of the code.
2021 */ 1794 */
2022 object *key = find_key (op, op, door); 1795 object *key = find_key (op, op, door);
2023 1796
2024 /* IF we found a key, do some extra work */ 1797 /* If we found a key, do some extra work */
2025 if (key) 1798 if (key)
2026 { 1799 {
2027 object *container = key->env; 1800 object *container = key->env;
2028 1801
2029 play_sound_map (op->map, op->x, op->y, SOUND_OPEN_DOOR);
2030 if (action_makes_visible (op)) 1802 if (action_makes_visible (op))
2031 make_visible (op); 1803 make_visible (op);
1804
2032 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP)) 1805 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP))
2033 spring_trap (door->inv, op); 1806 spring_trap (door->inv, op);
1807
2034 if (door->type == DOOR) 1808 if (door->type == DOOR)
2035 {
2036 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */ 1809 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */
2037 }
2038 else if (door->type == LOCKED_DOOR) 1810 else if (door->type == LOCKED_DOOR)
2039 { 1811 {
2040 new_draw_info_format (NDI_UNIQUE, NDI_BROWN, op, "You open the door with the %s", query_short_name (key)); 1812 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN);
2041 remove_door2 (door); /* remove door without violence ;-) */ 1813 remove_door2 (door); /* remove door without violence ;-) */
2042 } 1814 }
1815
2043 /* Do this after we print the message */ 1816 /* Do this after we print the message */
2044 decrease_ob (key); /* Use up one of the keys */ 1817 key->decrease (); /* Use up one of the keys */
2045 /* Need to update the weight the container the key was in */ 1818
2046 if (container != op)
2047 esrv_update_item (UPD_WEIGHT, op, container);
2048 return 1; /* Nothing more to do below */ 1819 return 1; /* Nothing more to do below */
2049 } 1820 }
2050 else if (door->type == LOCKED_DOOR) 1821 else if (door->type == LOCKED_DOOR)
2051 { 1822 {
2052 /* Might as well return now - no other way to open this */ 1823 /* Might as well return now - no other way to open this */
2053 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, door->msg); 1824 op->failmsg (door->msg ? &door->msg : "Hmm, you miss the certain something to open this door...");
2054 return 1; 1825 return 1;
2055 } 1826 }
1827
2056 return 0; 1828 return 0;
2057} 1829}
2058 1830
2059/* This function is just part of a breakup from move_player. 1831/* This function is just part of a breakup from move_player.
2060 * It should keep the code cleaner. 1832 * It should keep the code cleaner.
2061 * When this is called, the players direction has been updated 1833 * When this is called, the players direction has been updated
2062 * (taking into account confusion.) The player is also actually 1834 * (taking into account confusion.) The player is also actually
2063 * going to try and move (not fire weapons). 1835 * going to try and move (not fire weapons).
2064 */ 1836 */
2065void 1837bool
2066move_player_attack (object *op, int dir) 1838move_player_attack (object *op, int dir)
2067{ 1839{
2068 object *tmp, *mon; 1840 if (!op->contr->braced && op->speed_left > 0.f && op->move (dir))
2069 sint16 nx, ny; 1841 {
2070 int on_battleground; 1842 --op->speed_left;
2071 maptile *m; 1843 return true;
1844 }
2072 1845
2073 nx = freearr_x[dir] + op->x; 1846 sint16 nx = freearr_x[dir] + op->x;
2074 ny = freearr_y[dir] + op->y; 1847 sint16 ny = freearr_y[dir] + op->y;
2075 1848
2076 on_battleground = op_on_battleground (op, 0, 0); 1849 if (out_of_map (op->map, nx, ny))
1850 return false;
2077 1851
2078 /* If braced, or can't move to the square, and it is not out of the 1852 /* If braced, or can't move to the square, and it is not out of the
2079 * map, attack it. Note order of if statement is important - don't 1853 * map, attack it. Note order of if statement is important - don't
2080 * want to be calling move_ob if braced, because move_ob will move the 1854 * want to be calling move_ob if braced, because move_ob will move the
2081 * player. This is a pretty nasty hack, because if we could 1855 * player. This is a pretty nasty hack, because if we could
2082 * move to some space, it then means that if we are braced, we should 1856 * move to some space, it then means that if we are braced, we should
2083 * do nothing at all. As it is, if we are braced, we go through 1857 * do nothing at all. As it is, if we are braced, we go through
2084 * quite a bit of processing. However, it probably is less than what 1858 * quite a bit of processing. However, it probably is less than what
2085 * move_ob uses. 1859 * move_ob uses.
2086 */ 1860 */
2087 if ((op->contr->braced || !move_ob (op, dir, op)) && !out_of_map (op->map, nx, ny)) 1861 maptile *m = op->map->xy_find (nx, ny);
1862
1863 /* Go through all the objects, and find ones of interest. Only stop if
1864 * we find a monster - that is something we know we want to attack.
1865 * if its a door or barrel (can roll) see if there may be monsters
1866 * on the space
1867 */
1868 object *mon;
1869 for (mon = m->at (nx, ny).bot; mon; mon = mon->above)
1870 {
1871 if ((mon->flag [FLAG_ALIVE]
1872 || mon->type == LOCKED_DOOR
1873 || mon->flag [FLAG_CAN_ROLL])
1874 && mon != op)
1875 break;
2088 { 1876 }
2089 if (OUT_OF_REAL_MAP (op->map, nx, ny)) 1877
1878 if (!mon) /* This happens anytime the player tries to move */
1879 return false; /* into a wall */
1880
1881 mon = mon->head_ ();
1882
1883 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
1884 if (op->contr->weapon_sp_left > 0.f)
1885 if (player_attack_door (op, mon))
1886 {
1887 --op->contr->weapon_sp_left;
1888 return true;
2090 { 1889 }
2091 m = get_map_from_coord (op->map, &nx, &ny); 1890
2092 if (!m) 1891 /* The following deals with possibly attacking peaceful
2093 return; /* Don't think this should happen */ 1892 * or friendly creatures. Basically, all players are considered
1893 * unaggressive. If the moving player has peaceful set, then the
1894 * object should be pushed instead of attacked. It is assumed that
1895 * if you are braced, you will not attack friends accidently,
1896 * and thus will not push them.
1897 */
1898
1899 /* If the creature is a pet, push it even if the player is not
1900 * peaceful. Our assumption is the creature is a pet if the
1901 * player owns it and it is either friendly or unagressive.
1902 */
1903 if (op->type == PLAYER
1904 && ((mon->owner && mon->owner->contr
1905 && same_party (mon->owner->contr->party, op->contr->party))
1906 || mon->owner == op)
1907 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
1908 {
1909 /* If we're braced, we don't want to switch places with it */
1910 if (op->contr->braced)
1911 return false;
1912
1913 if (op->speed_left > 0.f)
1914 {
1915 --op->speed_left;
1916
1917 op->play_sound (sound_find ("push_player"));
1918 push_ob (mon, dir, op);
1919
1920 if (action_makes_visible (op))
1921 make_visible (op);
1922
1923 return true;
2094 } 1924 }
2095 else 1925 else
2096 m = op->map;
2097
2098 if ((tmp = GET_MAP_OB (m, nx, ny)) == NULL)
2099 {
2100 /* LOG(llevError,"player_move_attack: GET_MAP_OB returns NULL, but player can not move there.\n"); */
2101 return; 1926 return false;
2102 } 1927 }
2103 1928
2104 mon = 0; 1929 bool on_battleground = op_on_battleground (op, 0, 0);
2105 /* Go through all the objects, and find ones of interest. Only stop if
2106 * we find a monster - that is something we know we want to attack.
2107 * if its a door or barrel (can roll) see if there may be monsters
2108 * on the space
2109 */
2110 while (tmp)
2111 {
2112 if (tmp == op)
2113 {
2114 tmp = tmp->above;
2115 continue;
2116 }
2117 1930
2118 if (QUERY_FLAG (tmp, FLAG_ALIVE))
2119 {
2120 mon = tmp;
2121 break;
2122 }
2123
2124 if (tmp->type == LOCKED_DOOR || QUERY_FLAG (tmp, FLAG_CAN_ROLL))
2125 mon = tmp;
2126
2127 tmp = tmp->above;
2128 }
2129
2130 if (!mon) /* This happens anytime the player tries to move */
2131 return; /* into a wall */
2132
2133 if (mon->head)
2134 mon = mon->head;
2135
2136 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2137 if (player_attack_door (op, mon))
2138 return;
2139
2140 /* The following deals with possibly attacking peaceful
2141 * or frienddly creatures. Basically, all players are considered
2142 * unaggressive. If the moving player has peaceful set, then the
2143 * object should be pushed instead of attacked. It is assumed that
2144 * if you are braced, you will not attack friends accidently,
2145 * and thus will not push them.
2146 */
2147
2148 /* If the creature is a pet, push it even if the player is not
2149 * peaceful. Our assumption is the creature is a pet if the
2150 * player owns it and it is either friendly or unagressive.
2151 */
2152 if ((op->type == PLAYER)
2153#if COZY_SERVER
2154 &&
2155 ((mon->owner && mon->owner->contr
2156 && same_party (mon->owner->contr->party, op->contr->party)) || mon->owner == op)
2157#else
2158 && mon->owner == op
2159#endif
2160 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
2161 {
2162 /* If we're braced, we don't want to switch places with it */
2163 if (op->contr->braced)
2164 return;
2165 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER);
2166 (void) push_ob (mon, dir, op);
2167 if (op->contr->tmp_invis || op->hide)
2168 make_visible (op);
2169 return;
2170 }
2171
2172 /* in certain circumstances, you shouldn't attack friendly 1931 /* in certain circumstances, you shouldn't attack friendly
2173 * creatures. Note that if you are braced, you can't push 1932 * creatures. Note that if you are braced, you can't push
2174 * someone, but put it inside this loop so that you won't 1933 * someone, but put it inside this loop so that you won't
2175 * attack them either. 1934 * attack them either.
2176 */ 1935 */
2177 if ((mon->type == PLAYER || mon->enemy != op) && 1936 if ((mon->type == PLAYER || mon->enemy != op)
2178 (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) && ( 1937 && (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))
2179#ifdef PROHIBIT_PLAYERKILL
2180 (op->contr->peaceful 1938 && ((op->contr->peaceful
2181 || (mon->type == PLAYER 1939 || (mon->type == PLAYER && mon->contr->peaceful))
2182 && mon->contr->
2183 peaceful)) &&
2184#else
2185 op->contr->peaceful &&
2186#endif
2187 !on_battleground)) 1940 && !on_battleground))
1941 {
1942 if (op->speed_left > 0.f)
2188 { 1943 {
1944 --op->speed_left;
1945
2189 if (!op->contr->braced) 1946 if (!op->contr->braced)
2190 { 1947 {
2191 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER); 1948 op->play_sound (sound_find ("push_player"));
2192 (void) push_ob (mon, dir, op); 1949 push_ob (mon, dir, op);
2193 } 1950 }
2194 else 1951 else
2195 new_draw_info (0, 0, op, "You withhold your attack"); 1952 op->statusmsg ("You withhold your attack");
2196 1953
2197 if (op->contr->tmp_invis || op->hide) 1954 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN])
2198 make_visible (op); 1955 make_visible (op);
2199 }
2200 1956
1957 return true;
1958 }
1959 }
2201 /* If the object is a boulder or other rollable object, then 1960 /* If the object is a boulder or other rollable object, then
2202 * roll it if not braced. You can't roll it if you are braced. 1961 * roll it if not braced. You can't roll it if you are braced.
2203 */ 1962 */
2204 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 1963 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced))
1964 {
1965 if (op->speed_left > 0.f)
2205 { 1966 {
1967 --op->speed_left;
1968
2206 recursive_roll (mon, dir, op); 1969 recursive_roll (mon, dir, op);
2207 if (action_makes_visible (op)) 1970 if (action_makes_visible (op))
2208 make_visible (op); 1971 make_visible (op);
2209 }
2210 1972
1973 return true;
1974 }
1975 }
2211 /* Any generic living creature. Including things like doors. 1976 /* Any generic living creature. Including things like doors.
2212 * Way it works is like this: First, it must have some hit points 1977 * Way it works is like this: First, it must have some hit points
2213 * and be living. Then, it must be one of the following: 1978 * and be living. Then, it must be one of the following:
2214 * 1) Not a player, 2) A player, but of a different party. Note 1979 * 1) Not a player, 2) A player, but of a different party. Note
2215 * that party_number -1 is no party, so attacks can still happen. 1980 * that party_number -1 is no party, so attacks can still happen.
2216 */ 1981 */
2217
2218 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 1982 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) &&
2219 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 1983 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2220 { 1984 {
2221 1985 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2222 /* If the player hasn't hit something this tick, and does
2223 * so, give them speed boost based on weapon speed. Doing
2224 * it here is better than process_players2, which basically
2225 * incurred a 1 tick offset.
2226 */
2227 if (!op->contr->has_hit)
2228 { 1986 {
2229 op->speed_left += op->speed / op->contr->weapon_sp; 1987 --op->contr->weapon_sp_left;
2230
2231 op->contr->has_hit = 1; /* The last action was to hit, so use weapon_sp */
2232 }
2233 1988
2234 skill_attack (mon, op, 0, 0, 0); 1989 skill_attack (mon, op, 0, 0, 0);
2235
2236 /* If attacking another player, that player gets automatic
2237 * hitback, and doesn't loose luck either.
2238 * Disable hitback on the battleground or if the target is
2239 * the wiz.
2240 */
2241 if (mon->type == PLAYER && mon->stats.hp >= 0 && !mon->contr->has_hit && !on_battleground && !QUERY_FLAG (mon, FLAG_WIZ))
2242 {
2243 short luck = mon->stats.luck;
2244
2245 mon->contr->has_hit = 1;
2246 skill_attack (op, mon, 0, 0, 0);
2247 mon->stats.luck = luck;
2248 }
2249 1990
2250 if (action_makes_visible (op)) 1991 if (action_makes_visible (op))
2251 make_visible (op); 1992 make_visible (op);
2252 }
2253 } /* if player should attack something */
2254}
2255 1993
2256int 1994 return true;
1995 }
1996 }
1997
1998 return false;
1999}
2000
2001bool
2257move_player (object *op, int dir) 2002move_player (object *op, int dir)
2258{ 2003{
2259 int pick;
2260
2261 if (op->map == NULL || op->map->in_memory != MAP_IN_MEMORY) 2004 if (!op->map || op->map->in_memory != MAP_ACTIVE)
2262 return 0; 2005 return 0;
2263 2006
2264 /* Sanity check: make sure dir is valid */ 2007 /* Sanity check: make sure dir is valid */
2265 if ((dir < 0) || (dir >= 9)) 2008 if (dir < 0 || dir >= 9)
2266 { 2009 {
2267 LOG (llevError, "move_player: invalid direction %d\n", dir); 2010 LOG (llevError, "move_player: invalid direction %d\n", dir);
2268 return 0; 2011 return 0;
2269 } 2012 }
2270 2013
2271 /* peterm: added following line */ 2014 /* peterm: added following line */
2272 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2015 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir)
2273 dir = absdir (dir + RANDOM () % 3 + RANDOM () % 3 - 2); 2016 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2274 2017
2275 op->facing = dir; 2018 op->facing = dir;
2276 2019
2277 if (op->hide) 2020 if (op->flag [FLAG_HIDDEN])
2278 do_hidden_move (op); 2021 do_hidden_move (op);
2279 2022
2023 bool retval;
2024 int pick = 0;
2025
2280 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2026 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2281 /*nop */ ; 2027 retval = RESULT_INT (0);
2282 else if (op->contr->fire_on) 2028 else if (op->contr->fire_on)
2283 fire (op, dir); 2029 retval = fire (op, dir);
2284 else 2030 else
2285 { 2031 {
2286 move_player_attack (op, dir); 2032 retval = move_player_attack (op, dir);
2287 pick = check_pick (op); 2033 pick = check_pick (op);
2288 } 2034 }
2289 2035
2290 /* Add special check for newcs players and fire on - this way, the 2036 /* Add special check for newcs players and fire on - this way, the
2291 * server can handle repeat firing. 2037 * server can handle repeat firing.
2298 /* Update how the player looks. Use the facing, so direction may 2044 /* Update how the player looks. Use the facing, so direction may
2299 * get reset to zero. This allows for full animation capabilities 2045 * get reset to zero. This allows for full animation capabilities
2300 * for players. 2046 * for players.
2301 */ 2047 */
2302 animate_object (op, op->facing); 2048 animate_object (op, op->facing);
2303 return 0; 2049
2050 return retval;
2304} 2051}
2305 2052
2306/* This is similar to handle_player, below, but is only used by the 2053/* This is similar to handle_player, below, but is only used by the
2307 * new client/server stuff. 2054 * new client/server stuff.
2308 * This is sort of special, in that the new client/server actually uses 2055 * This is sort of special, in that the new client/server actually uses
2309 * the new speed values for commands. 2056 * the new speed values for commands.
2310 * 2057 *
2311 * Returns true if there are more actions we can do. 2058 * Returns true if there are more actions we can do. Should not do
2059 * many actions in a row, as that would be too unfair to other
2060 * players.
2312 */ 2061 */
2313int 2062bool
2314handle_newcs_player (object *op) 2063handle_newcs_player (object *op)
2315{ 2064{
2316 if (op->contr->hidden)
2317 {
2318 op->invisible = 1000;
2319 /* the socket code flashes the player visible/invisible
2320 * depending on the value of invisible, so we need to
2321 * alternate it here for it to work correctly.
2322 */
2323 if (pticks & 2)
2324 op->invisible--;
2325 }
2326 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2327 {
2328 op->invisible--;
2329 if (!op->invisible)
2330 {
2331 make_visible (op);
2332 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2333 }
2334 }
2335
2336 if (QUERY_FLAG (op, FLAG_SCARED)) 2065 if (QUERY_FLAG (op, FLAG_SCARED))
2337 { 2066 {
2338 flee_player (op); 2067 if (op->speed_left > 0.f)
2339 /* If player is still scared, that is his action for this tick */
2340 if (QUERY_FLAG (op, FLAG_SCARED))
2341 { 2068 {
2342 op->speed_left--; 2069 --op->speed_left;
2070 flee_player (op);
2071
2343 return 0; 2072 return true;
2344 } 2073 }
2074 else
2075 return false;
2345 } 2076 }
2346
2347 /* I've been seeing crashes where the golem has been destroyed, but
2348 * the player object still points to the defunct golem. The code that
2349 * destroys the golem looks correct, and it doesn't always happen, so
2350 * put this in a a workaround to clean up the golem pointer.
2351 */
2352 if (op->contr->ranges[range_golem] && QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
2353 op->contr->ranges[range_golem] = 0;
2354 2077
2355 /* call this here - we also will call this in do_ericserver, but 2078 /* call this here - we also will call this in do_ericserver, but
2356 * the players time has been increased when doericserver has been 2079 * the players time has been increased when doericserver has been
2357 * called, so we recheck it here. 2080 * called, so we recheck it here.
2358 */ 2081 */
2359 //TODO: better than handling 8 commands, use some more intelligent rate-limiting 2082 if (op->contr->ns->handle_command ())
2360 for (int rep = 8; --rep && op->contr->ns->handle_command (); )
2361 ;
2362
2363 if (op->speed_left < 0)
2364 return 0; 2083 return true;
2365 2084
2366 if (op->direction && (op->contr->run_on || op->contr->fire_on)) 2085 if (op->direction && (op->contr->run_on || op->contr->fire_on))
2367 {
2368 /* All move commands take 1 tick, at least for now */
2369 op->speed_left--;
2370
2371 /* Instead of all the stuff below, let move_player take care
2372 * of it. Also, some of the skill stuff is only put in
2373 * there, as well as the confusion stuff.
2374 */
2375 move_player (op, op->direction); 2086 return move_player (op, op->direction);
2376 if (op->speed_left > 0)
2377 return 1;
2378 else
2379 return 0;
2380 }
2381 2087
2382 return 0; 2088 return false;
2383} 2089}
2384 2090
2385int 2091static int
2386save_life (object *op) 2092save_life (object *op)
2387{ 2093{
2388 if (!QUERY_FLAG (op, FLAG_LIFESAVE)) 2094 if (!QUERY_FLAG (op, FLAG_LIFESAVE))
2389 return 0; 2095 return 0;
2390 2096
2391 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2097 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2392 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2098 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE))
2393 { 2099 {
2394 play_sound_map (op->map, op->x, op->y, SOUND_OB_EVAPORATE); 2100 op->play_sound (sound_find ("ob_evaporate"));
2395 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2101 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2396
2397 if (op->contr)
2398 esrv_del_item (op->contr, tmp->count);
2399 2102
2400 tmp->destroy (); 2103 tmp->destroy ();
2401 CLEAR_FLAG (op, FLAG_LIFESAVE); 2104 CLEAR_FLAG (op, FLAG_LIFESAVE);
2402 2105
2403 if (op->stats.hp < 0) 2106 if (op->stats.hp < 0)
2404 op->stats.hp = op->stats.maxhp; 2107 op->stats.hp = op->stats.maxhp;
2405 2108
2406 if (op->stats.food < 0) 2109 if (op->stats.food < 0)
2407 op->stats.food = 999; 2110 op->stats.food = MAX_FOOD;
2408 2111
2409 op->update_stats (); 2112 op->update_stats ();
2410 return 1; 2113 return 1;
2411 } 2114 }
2412 2115
2416 return 0; 2119 return 0;
2417} 2120}
2418 2121
2419/* This goes throws the inventory and removes unpaid objects, and puts them 2122/* This goes throws the inventory and removes unpaid objects, and puts them
2420 * back in the map (location and map determined by values of env). This 2123 * back in the map (location and map determined by values of env). This
2421 * function will descend into containers. op is the object to start the search 2124 * function will descend into containers. op is the object to start the search
2422 * from. 2125 * from.
2423 */ 2126 */
2127static void
2128drop_unpaid_items (object *op, object *env)
2129{
2130 while (op)
2131 {
2132 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2133
2134 if (QUERY_FLAG (op, FLAG_UNPAID))
2135 op->insert_at (env);
2136 else if (op->inv)
2137 drop_unpaid_items (op->inv, env);
2138
2139 op = next;
2140 }
2141}
2142
2424void 2143void
2425remove_unpaid_objects (object *op, object *env) 2144object::drop_unpaid_items ()
2426{ 2145{
2427 object *next; 2146 if (!flag [FLAG_REMOVED])
2428 2147 ::drop_unpaid_items (inv, this);
2429 while (op)
2430 {
2431 next = op->below; /* Make sure we have a good value, in case
2432 * we remove object 'op'
2433 */
2434 if (QUERY_FLAG (op, FLAG_UNPAID))
2435 {
2436 op->remove ();
2437 op->x = env->x;
2438 op->y = env->y;
2439 if (env->type == PLAYER)
2440 esrv_del_item (env->contr, op->count);
2441 insert_ob_in_map (op, env->map, NULL, 0);
2442 }
2443 else if (op->inv)
2444 remove_unpaid_objects (op->inv, env);
2445
2446 op = next;
2447 }
2448}
2449
2450/*
2451 * Returns pointer a static string containing gravestone text
2452 * Moved from apply.c to player.c - player.c is what
2453 * actually uses this function. player.c may not be quite the
2454 * best, a misc file for object actions is probably better,
2455 * but there isn't one in the server directory.
2456 */
2457char *
2458gravestone_text (object *op)
2459{
2460 static char buf2[MAX_BUF];
2461 char buf[MAX_BUF];
2462 time_t now = time (NULL);
2463
2464 strcpy (buf2, " R.I.P.\n\n");
2465 if (op->type == PLAYER)
2466 sprintf (buf, "%s the %s\n", &op->name, op->contr->title);
2467 else
2468 sprintf (buf, "%s\n", &op->name);
2469
2470 strncat (buf2, " ", 20 - strlen (buf) / 2);
2471 strcat (buf2, buf);
2472 if (op->type == PLAYER)
2473 sprintf (buf, "who was in level %d when killed\n", op->level);
2474 else
2475 sprintf (buf, "who was in level %d when died.\n\n", op->level);
2476
2477 strncat (buf2, " ", 20 - strlen (buf) / 2);
2478 strcat (buf2, buf);
2479 if (op->type == PLAYER)
2480 {
2481 sprintf (buf, "by %s.\n\n", op->contr->killer);
2482 strncat (buf2, " ", 21 - strlen (buf) / 2);
2483 strcat (buf2, buf);
2484 }
2485
2486 strftime (buf, MAX_BUF, "%b %d %Y\n", localtime (&now));
2487 strncat (buf2, " ", 20 - strlen (buf) / 2);
2488 strcat (buf2, buf);
2489
2490 return buf2;
2491} 2148}
2492 2149
2493void 2150void
2494do_some_living (object *op) 2151do_some_living (object *op)
2495{ 2152{
2502 int rate_grace = 2000; 2159 int rate_grace = 2000;
2503 const int max_hp = 1; 2160 const int max_hp = 1;
2504 const int max_sp = 1; 2161 const int max_sp = 1;
2505 const int max_grace = 1; 2162 const int max_grace = 1;
2506 2163
2507 if (op->contr->outputs_sync) 2164 if (op->contr->hidden)
2165 {
2166 op->invisible = 1000;
2167 /* the socket code flashes the player visible/invisible
2168 * depending on the value of invisible, so we need to
2169 * alternate it here for it to work correctly.
2170 */
2171 if (pticks & 2)
2172 op->invisible--;
2508 { 2173 }
2509 for (i = 0; i < NUM_OUTPUT_BUFS; i++) 2174 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2510 if (op->contr->outputs[i].buf && (op->contr->outputs[i].first_update + op->contr->outputs_sync) < (uint16) pticks) 2175 {
2511 flush_output_element (op, &op->contr->outputs[i]); 2176 if (!op->invisible--)
2177 {
2178 make_visible (op);
2179 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2180 }
2512 } 2181 }
2513 2182
2514 if (op->contr->ns->state == ST_PLAYING) 2183 if (op->contr->ns->state == ST_PLAYING)
2515 { 2184 {
2516 /* these next three if clauses make it possible to SLOW DOWN 2185 /* these next three if clauses make it possible to SLOW DOWN
2535 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace; 2204 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace;
2536 else 2205 else
2537 { 2206 {
2538 gen_grace = op->stats.maxgrace; 2207 gen_grace = op->stats.maxgrace;
2539 rate_grace -= rate_grace / 2 * op->contr->gen_grace; 2208 rate_grace -= rate_grace / 2 * op->contr->gen_grace;
2540 }
2541
2542 /* Regenerate Spell Points */
2543 if (op->contr->ranges[range_golem] == NULL && --op->last_sp < 0)
2544 {
2545 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2546 if (op->stats.sp < op->stats.maxsp)
2547 {
2548 op->stats.sp++;
2549 /* dms do not consume food */
2550 if (!QUERY_FLAG (op, FLAG_WIZ))
2551 {
2552 op->stats.food--;
2553 if (op->contr->digestion < 0)
2554 op->stats.food += op->contr->digestion;
2555 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2556 op->stats.food = last_food;
2557 }
2558 }
2559
2560 if (max_sp > 1)
2561 {
2562 over_sp = (gen_sp + 10) / rate_sp;
2563 if (over_sp > 0)
2564 {
2565 if (op->stats.sp < op->stats.maxsp)
2566 {
2567 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2568
2569 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2570 op->stats.sp--;
2571
2572 if (op->stats.sp > op->stats.maxsp)
2573 op->stats.sp = op->stats.maxsp;
2574 }
2575 op->last_sp = 0;
2576 }
2577 else
2578 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2579 }
2580 else
2581 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2582 } 2209 }
2583 2210
2584 /* Regenerate Grace */ 2211 /* Regenerate Grace */
2585 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */ 2212 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */
2586 if (--op->last_grace < 0) 2213 if (--op->last_grace < 0)
2607 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2234 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2608 } 2235 }
2609 /* wearing stuff doesn't detract from grace generation. */ 2236 /* wearing stuff doesn't detract from grace generation. */
2610 } 2237 }
2611 2238
2239 if (op->stats.food > 0)
2240 {
2612 /* Regenerate Hit Points */ 2241 /* Regenerate Spell Points */
2613 if (--op->last_heal < 0) 2242 if (!op->contr->golem && --op->last_sp < 0)
2614 {
2615 if (op->stats.hp < op->stats.maxhp)
2616 { 2243 {
2617 op->stats.hp++; 2244 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2618 /* dms do not consume food */ 2245
2619 if (!QUERY_FLAG (op, FLAG_WIZ)) 2246 if (op->stats.sp < op->stats.maxsp)
2620 { 2247 {
2248 op->stats.sp++;
2249
2250 /* dms do not consume food */
2251 if (!QUERY_FLAG (op, FLAG_WIZ))
2252 {
2621 op->stats.food--; 2253 op->stats.food--;
2254
2622 if (op->contr->digestion < 0) 2255 if (op->contr->digestion < 0)
2623 op->stats.food += op->contr->digestion; 2256 op->stats.food += op->contr->digestion;
2624 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2257 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2625 op->stats.food = last_food; 2258 op->stats.food = last_food;
2259 }
2626 } 2260 }
2627 }
2628 2261
2629 if (max_hp > 1) 2262 if (max_sp > 1)
2630 {
2631 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2632 if (over_hp > 0)
2633 { 2263 {
2634 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2264 over_sp = (gen_sp + 10) / rate_sp;
2265 if (over_sp > 0)
2266 {
2267 if (op->stats.sp < op->stats.maxsp)
2268 {
2269 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2270
2271 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2272 op->stats.sp--;
2273
2274 if (op->stats.sp > op->stats.maxsp)
2275 op->stats.sp = op->stats.maxsp;
2276 }
2277
2635 op->last_heal = 0; 2278 op->last_sp = 0;
2279 }
2280 else
2281 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2636 } 2282 }
2637 else 2283 else
2284 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2285 }
2286
2287 /* Regenerate Hit Points */
2288 if (--op->last_heal < 0)
2289 {
2290 if (op->stats.hp < op->stats.maxhp)
2638 { 2291 {
2639 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2292 op->stats.hp++;
2293
2294 /* dms do not consume food */
2295 if (!QUERY_FLAG (op, FLAG_WIZ))
2296 {
2297 op->stats.food--;
2298
2299 if (op->contr->digestion < 0)
2300 op->stats.food += op->contr->digestion;
2301 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2302 op->stats.food = last_food;
2303 }
2640 } 2304 }
2305
2306 if (max_hp > 1)
2307 {
2308 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2309
2310 if (over_hp > 0)
2311 {
2312 op->stats.sp += over_hp + (rndm (rate_hp) > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0;
2313 op->last_heal = 0;
2314 }
2315 else
2316 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2641 } 2317 }
2642 else 2318 else
2643 {
2644 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2319 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2645 } 2320 }
2646 } 2321 }
2647 2322
2648 /* Digestion */ 2323 /* Digestion */
2649 if (--op->last_eat < 0) 2324 if (--op->last_eat < 0)
2650 { 2325 {
2651#ifdef COZY_SERVER 2326 int bonus = max (0, op->contr->digestion),
2652 int dg = op->contr->digestion >= 0 && op->contr->digestion < 2 ? 2 : op->contr->digestion; 2327 penalty = max (0, -op->contr->digestion);
2653 int bonus = dg > 0 ? dg : 0, penalty = dg < 0 ? -dg : 0;
2654#else
2655 int bonus = op->contr->digestion > 0 ? op->contr->digestion : 0, penalty = op->contr->digestion < 0 ? -op->contr->digestion : 0;
2656#endif
2657 2328
2658 if (op->contr->gen_hp > 0)
2659 op->last_eat = 25 * (1 + bonus) / (op->contr->gen_hp + penalty + 1); 2329 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2660 else
2661 op->last_eat = 25 * (1 + bonus) / (penalty + 1);
2662 2330
2663 /* dms do not consume food */ 2331 /* dms do not consume food */
2664 if (!QUERY_FLAG (op, FLAG_WIZ)) 2332 if (!QUERY_FLAG (op, FLAG_WIZ))
2665 op->stats.food--; 2333 op->stats.food--;
2666 } 2334 }
2667 2335
2668 if (op->stats.food < 0 && op->stats.hp >= 0) 2336 if (op->stats.food < 0 && op->stats.hp >= 0)
2669 { 2337 {
2670 object *tmp, *flesh = 0; 2338 object *flesh = 0;
2671 2339
2672 for (tmp = op->inv; tmp; tmp = tmp->below) 2340 for_inv_removable (op, tmp)
2673 { 2341 {
2674 if (!QUERY_FLAG (tmp, FLAG_UNPAID)) 2342 if (QUERY_FLAG (tmp, FLAG_UNPAID))
2343 continue;
2344
2345 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2675 { 2346 {
2676 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2347 op->statusmsg ("You blindly grab for a bite of food. "
2677 { 2348 "H<To prevent you from starving, you ate some random item from your backpack.>");
2678 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2349 op->apply (tmp);
2679 manual_apply (op, tmp, 0); 2350
2680 if (op->stats.food >= 0 || op->stats.hp < 0) 2351 if (op->stats.food >= 0 || op->stats.hp < 0)
2681 break; 2352 break;
2682 } 2353 }
2683 else if (tmp->type == FLESH) 2354 else if (tmp->type == FLESH)
2684 flesh = tmp; 2355 flesh = tmp;
2685 } /* End if paid for object */ 2356 }
2686 } /* end of for loop */
2687 2357
2688 /* If player is still starving, it means they don't have any food, so 2358 /* If player is still starving, it means they don't have any food, so
2689 * eat flesh instead. 2359 * eat flesh instead.
2690 */ 2360 */
2691 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2361 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2692 { 2362 {
2693 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2363 op->statusmsg ("You blindly grab for a bite of food. "
2364 "H<To prevent you from starving, you ate some random item from your backpack.>");
2694 manual_apply (op, flesh, 0); 2365 op->apply (flesh);
2695 } 2366 }
2367
2368 // If player is still starving, alert him!
2369 if (op->stats.food < 0)
2370 op->failmsg ("You are starving! "
2371 "H<Eat some food to increase your food and prevent you from an untimely death.>");
2372 }
2373
2374 if (op->stats.food < 0)
2696 } 2375 {
2376 op->stats.hp += op->stats.food;
2377 op->stats.food = 0;
2697 2378
2698 while (op->stats.food < 0 && op->stats.hp >= 0) 2379 if (op->stats.hp < 0)
2699 op->stats.food++, op->stats.hp--; 2380 {
2381 op->contr->killer = archetype::get ("killer_starvation");
2382 op->contr->killer->destroy ();
2383 }
2384 }
2700 2385
2386 /* killer should be set here already */
2701 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2387 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ))
2702 kill_player (op); 2388 kill_player (op);
2703 } 2389 }
2704} 2390}
2705 2391
2709 * file. 2395 * file.
2710 */ 2396 */
2711void 2397void
2712kill_player (object *op) 2398kill_player (object *op)
2713{ 2399{
2714 char buf[MAX_BUF];
2715 int x, y; 2400 int x, y;
2716
2717 //int i;
2718 maptile *map; /* this is for resurrection */ 2401 maptile *map; /* this is for resurrection */
2719
2720 /* int z;
2721 int num_stats_lose;
2722 int lost_a_stat;
2723 int lose_this_stat;
2724 int this_stat; */
2725 int will_kill_again; 2402 int will_kill_again;
2726 archetype *at; 2403 archetype *at;
2727 object *tmp; 2404 object *tmp;
2728 2405
2729 if (save_life (op)) 2406 if (save_life (op))
2730 return; 2407 return;
2731 2408
2409 dynbuf_text deathtab;
2410
2411 /* restore player */
2412 at = archetype::find (shstr_poisoning);
2413 if (object *tmp = present_arch_in_ob (at, op))
2414 {
2415 tmp->destroy ();
2416 deathtab << "Your body feels cleansed...\r";
2417 }
2418
2419 at = archetype::find (shstr_confusion);
2420 if (object *tmp = present_arch_in_ob (at, op))
2421 {
2422 tmp->destroy ();
2423 deathtab << "Your mind feels clearer...\r";
2424 }
2425
2426 cure_disease (op, 0, 0); /* remove any disease */
2427
2428 max_it (op->stats.hp , op->stats.maxhp);
2429 max_it (op->stats.sp , op->stats.maxsp);
2430 max_it (op->stats.grace, op->stats.maxgrace);
2431 max_it (op->stats.food , 200);
2432
2433 // remove all spell effects that are active
2434 // to avoid long-term effects such as word-of-recall
2435 for (object *item = op->inv; item; )
2436 {
2437 object *next = item->below;
2438
2439 if (item->type == SPELL_EFFECT && item->active)
2440 item->destroy ();
2441
2442 item = next;
2443 }
2732 2444
2733 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2445 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2734 * in cities ONLY!!! It is very important that this doesn't get abused. 2446 * in cities ONLY!!! It is very important that this doesn't get abused.
2735 * Look at op_on_battleground() for more info --AndreasV 2447 * Look at op_on_battleground() for more info --AndreasV
2736 */ 2448 */
2737 if (op_on_battleground (op, &x, &y)) 2449 if (op_on_battleground (op, &x, &y))
2738 { 2450 {
2739 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2451 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2740 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2741
2742 /* restore player */
2743 at = archetype::find ("poisoning");
2744 tmp = present_arch_in_ob (at, op);
2745 if (tmp)
2746 {
2747 tmp->destroy ();
2748 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2749 }
2750
2751 at = archetype::find ("confusion");
2752 tmp = present_arch_in_ob (at, op);
2753 if (tmp)
2754 {
2755 tmp->destroy ();
2756 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2757 }
2758
2759 cure_disease (op, 0); /* remove any disease */
2760 op->stats.hp = op->stats.maxhp;
2761 if (op->stats.food <= 0)
2762 op->stats.food = 999;
2763 2452
2764 /* create a bodypart-trophy to make the winner happy */ 2453 /* create a bodypart-trophy to make the winner happy */
2765 tmp = arch_to_object (archetype::find ("finger")); 2454 object *tmp = archetype::find (shstr_finger)->instance ();
2766 if (tmp != NULL) 2455
2767 { 2456 tmp->name = format ("%s's finger" , &op->name);
2768 sprintf (buf, "%s's finger", &op->name); 2457 tmp->name_pl = format ("%s's fingers", &op->name);
2769 tmp->name = buf; 2458 tmp->msg = format (
2770 sprintf (buf, " This finger has been cut off %s\n" 2459 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2771 " the %s, when he was defeated at\n level %d by %s.\n", 2460 &op->name, op->contr->title,
2772 &op->name, op->contr->title, (int) (op->level), op->contr->killer); 2461 (int)op->level,
2773 tmp->msg = buf; 2462 op->contr->killer_name ()
2463 );
2774 tmp->value = 0, tmp->material = 0, tmp->type = 0; 2464 tmp->value = 0, tmp->type = 0;
2775 tmp->materialname = NULL; 2465 tmp->material = name_to_material (shstr_organic);
2776 tmp->x = op->x, tmp->y = op->y; 2466 tmp->insert_at (op, tmp);
2777 insert_ob_in_map (tmp, op->map, op, 0);
2778 }
2779 2467
2780 /* teleport defeated player to new destination */ 2468 /* teleport defeated player to new destination */
2781 transfer_ob (op, x, y, 0, NULL); 2469 transfer_ob (op, x, y, 0, NULL);
2782 op->contr->braced = 0; 2470 op->contr->braced = 0;
2471
2472 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2783 return; 2473 return;
2784 } 2474 }
2785 2475
2476 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2477 deathtab << "T<YOU HAVE DIED>\n\n";
2478
2786 INVOKE_PLAYER (DEATH, op->contr); 2479 INVOKE_PLAYER (DEATH, op->contr);
2787 2480
2788 command_kill_pets (op, 0); 2481 command_kill_pets (op, 0);
2789 2482
2790 if (op->stats.food < 0) 2483 op->contr->play_sound (sound_find ("player_dies"));
2791 {
2792 if (op->contr->explore)
2793 {
2794 new_draw_info (NDI_UNIQUE, 0, op, "You would have starved, but you are");
2795 new_draw_info (NDI_UNIQUE, 0, op, "in explore mode, so...");
2796 op->stats.food = 999;
2797 return;
2798 }
2799 sprintf (buf, "%s starved to death.", &op->name);
2800 strcpy (op->contr->killer, "starvation");
2801 }
2802 else
2803 {
2804 if (op->contr->explore)
2805 {
2806 new_draw_info (NDI_UNIQUE, 0, op, "You would have died, but you are");
2807 new_draw_info (NDI_UNIQUE, 0, op, "in explore mode, so...");
2808 op->stats.hp = op->stats.maxhp;
2809 return;
2810 }
2811 sprintf (buf, "%s died.", &op->name);
2812 }
2813 play_sound_player_only (op->contr, SOUND_PLAYER_DIES, 0, 0);
2814 2484
2815 /* save the map location for corpse, gravestone */ 2485 /* save the map location for corpse, gravestone */
2816 x = op->x; 2486 x = op->x;
2817 y = op->y; 2487 y = op->y;
2818 map = op->map; 2488 map = op->map;
2819
2820 2489
2821 /* NOT_PERMADEATH code. This basically brings the character back to 2490 /* NOT_PERMADEATH code. This basically brings the character back to
2822 * life if they are dead - it takes some exp and a random stat. 2491 * life if they are dead - it takes some exp and a random stat.
2823 * See the config.h file for a little more in depth detail about this. 2492 * See the config.h file for a little more in depth detail about this.
2824 */ 2493 */
2841 num_stats_lose = 1; 2510 num_stats_lose = 1;
2842 else 2511 else
2843 num_stats_lose = 1 + op->level / BALSL_NUMBER_LOSSES_RATIO; 2512 num_stats_lose = 1 + op->level / BALSL_NUMBER_LOSSES_RATIO;
2844 } 2513 }
2845 else 2514 else
2846 {
2847 num_stats_lose = 1; 2515 num_stats_lose = 1;
2848 } 2516
2849 lost_a_stat = 0; 2517 lost_a_stat = 0;
2850 2518
2851 for (z = 0; z < num_stats_lose; z++) 2519 for (z = 0; z < num_stats_lose; z++)
2852 { 2520 {
2853 i = RANDOM () % NUM_STATS; 2521 i = rndm (NUM_STATS);
2854 2522
2855 if (settings.stat_loss_on_death) 2523 if (settings.stat_loss_on_death)
2856 { 2524 {
2857 /* Pick a random stat and take a point off it. Tell the player 2525 /* Pick a random stat and take a point off it. Tell the player
2858 * what he lost. 2526 * what he lost.
2865 lost_a_stat = 1; 2533 lost_a_stat = 1;
2866 } 2534 }
2867 else 2535 else
2868 { 2536 {
2869 /* deplete a stat */ 2537 /* deplete a stat */
2870 archetype *deparch = archetype::find ("depletion"); 2538 archetype *deparch = archetype::find (shstr_depletion);
2871 object *dep; 2539 object *dep;
2872 2540
2873 dep = present_arch_in_ob (deparch, op); 2541 dep = present_arch_in_ob (deparch, op);
2874 if (!dep) 2542 if (!dep)
2875 { 2543 {
2876 dep = arch_to_object (deparch); 2544 dep = deparch->instance ();
2877 insert_ob_in_ob (dep, op); 2545 insert_ob_in_ob (dep, op);
2878 } 2546 }
2879 lose_this_stat = 1; 2547 lose_this_stat = 1;
2880 if (settings.balanced_stat_loss) 2548 if (settings.balanced_stat_loss)
2881 { 2549 {
2909 } 2577 }
2910 } 2578 }
2911 2579
2912 if (lose_this_stat) 2580 if (lose_this_stat)
2913 { 2581 {
2914 this_stat = get_attr_value (&(dep->stats), i); 2582 this_stat = get_attr_value (&dep->stats, i);
2915 /* We could try to do something clever like find another 2583 /* We could try to do something clever like find another
2916 * stat to reduce if this fails. But chances are, if 2584 * stat to reduce if this fails. But chances are, if
2917 * stats have been depleted to -50, all are pretty low 2585 * stats have been depleted to -50, all are pretty low
2918 * and should be roughly the same, so it shouldn't make a 2586 * and should be roughly the same, so it shouldn't make a
2919 * difference. 2587 * difference.
2927 lost_a_stat = 1; 2595 lost_a_stat = 1;
2928 } 2596 }
2929 } 2597 }
2930 } 2598 }
2931 } 2599 }
2600
2932 /* If no stat lost, tell the player. */ 2601 /* If no stat lost, tell the player. */
2933 if (!lost_a_stat) 2602 if (!lost_a_stat)
2934 { 2603 {
2935 /* determine_god() seems to not work sometimes... why is this? 2604 /* determine_god() seems to not work sometimes... why is this?
2936 Should I be using something else? GD */ 2605 Should I be using something else? GD */
2937 const char *god = determine_god (op); 2606 shstr_tmp god = determine_god (op);
2938 2607
2939 if (god && (strcmp (god, "none"))) 2608 if (god != shstr_none)
2940 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2609 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2941 else 2610 else
2942 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2611 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2943 } 2612 }
2944#else 2613#else
2945 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you" " feel a holy presence protecting you from losing yourself completely."); 2614 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2946#endif 2615#endif
2947 2616
2948 /* Put a gravestone up where the character 'almost' died. List the 2617 /* Put a gravestone up where the character 'almost' died. List the
2949 * exp loss on the stone. 2618 * exp loss on the stone.
2950 */ 2619 */
2951 tmp = arch_to_object (archetype::find ("gravestone")); 2620 tmp = archetype::find (shstr_gravestone)->instance ();
2952 sprintf (buf, "%s's gravestone", &op->name); 2621 tmp->name = format ("%s's gravestone", &op->name);
2953 tmp->name = buf; 2622 tmp->name_pl = format ("%s's gravestones", &op->name);
2954 sprintf (buf, "%s's gravestones", &op->name); 2623 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2955 tmp->name_pl = buf; 2624 &op->name, op->contr->title, op->contr->killer_name ());
2956 sprintf (buf, "RIP\nHere rests the hero %s the %s,\n" "who was killed\n" "by %s.\n", &op->name, op->contr->title, op->contr->killer);
2957 tmp->msg = buf;
2958 tmp->x = op->x, tmp->y = op->y; 2625 tmp->x = op->x, tmp->y = op->y;
2959 insert_ob_in_map (tmp, op->map, NULL, 0); 2626 insert_ob_in_map (tmp, op->map, NULL, 0);
2960 2627
2961 /**************************************/ 2628 /**************************************/
2962 /* */ 2629 /* */
2963 /* Subtract the experience points, */ 2630 /* Subtract the experience points, */
2964 /* if we died cause of food, give us */
2965 /* food, and reset HP's... */
2966 /* */ 2631 /* */
2967 /**************************************/ 2632 /**************************************/
2968 2633
2969 /* remove any poisoning and confusion the character may be suffering. */
2970 /* restore player */
2971 at = archetype::find ("poisoning");
2972 tmp = present_arch_in_ob (at, op);
2973
2974 if (tmp)
2975 {
2976 tmp->destroy ();
2977 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2978 }
2979
2980 at = archetype::find ("confusion");
2981 tmp = present_arch_in_ob (at, op);
2982 if (tmp)
2983 {
2984 tmp->destroy ();
2985 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2986 }
2987
2988 cure_disease (op, 0); /* remove any disease */
2989
2990 /*add_exp(op, (op->stats.exp * -0.20)); */ 2634 /*add_exp(op, (op->stats.exp * -0.20)); */
2991 apply_death_exp_penalty (op); 2635 apply_death_exp_penalty (op);
2992 if (op->stats.food < 100)
2993 op->stats.food = 900;
2994 op->stats.hp = op->stats.maxhp;
2995 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2996 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2997 2636
2998 /* 2637 /*
2999 * Check to see if the player is in a shop. IF so, then check to see if
3000 * the player has any unpaid items. If so, remove them and put them back 2638 * Check to see if the player has any unpaid items. If so, remove them
3001 * in the map. 2639 * and put them back in the map.
3002 */ 2640 */
3003 2641 op->drop_unpaid_items ();
3004 if (is_in_shop (op))
3005 remove_unpaid_objects (op->inv, op);
3006 2642
3007 /****************************************/ 2643 /****************************************/
3008 /* */ 2644 /* */
3009 /* Move player to his current respawn- */ 2645 /* Move player to his current respawn- */
3010 /* position (usually last savebed) */ 2646 /* position (usually last savebed) */
3011 /* */ 2647 /* */
3012 /****************************************/ 2648 /****************************************/
3013 2649
3014 enter_player_savebed (op); 2650 enter_player_savebed (op);
3015 2651
3016 /* Save the player before inserting the force to reduce
3017 * chance of abuse.
3018 */
3019 op->contr->braced = 0; 2652 op->contr->braced = 0;
3020 op->contr->save ();
3021 2653
3022 /* it is possible that the player has blown something up 2654 /* it is possible that the player has blown something up
3023 * at his savebed location, and that can have long lasting 2655 * at his savebed location, and that can have long lasting
3024 * spell effects. So first see if there is a spell effect 2656 * spell effects. So first see if there is a spell effect
3025 * on the space that might harm the player. 2657 * on the space that might harm the player.
3034 object *force; 2666 object *force;
3035 int at; 2667 int at;
3036 2668
3037 force = get_archetype (FORCE_NAME); 2669 force = get_archetype (FORCE_NAME);
3038 /* 50 ticks should be enough time for the spell to abate */ 2670 /* 50 ticks should be enough time for the spell to abate */
3039 force->speed = 0.1; 2671 force->speed = 0.1f;
3040 force->speed_left = -5.0; 2672 force->speed_left = -5.f;
3041 SET_FLAG (force, FLAG_APPLIED); 2673 SET_FLAG (force, FLAG_APPLIED);
3042 for (at = 0; at < NROFATTACKS; at++) 2674 for (at = 0; at < NROFATTACKS; at++)
3043 if (will_kill_again & (1 << at)) 2675 if (will_kill_again & (1 << at))
3044 force->resist[at] = 100; 2676 force->resist[at] = 100;
3045 2677
3046 insert_ob_in_ob (force, op); 2678 insert_ob_in_ob (force, op);
3047 op->update_stats (); 2679 op->update_stats ();
3048
3049 } 2680 }
3050 2681
3051 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2682 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
3052} 2683}
3053 2684
3054void 2685static void
3055loot_object (object *op) 2686loot_object (object *op)
3056{ /* Grab and destroy some treasure */ 2687{ /* Grab and destroy some treasure */
3057 object *tmp, *tmp2, *next; 2688 object *tmp, *tmp2, *next;
3058 2689
3059 if (op->container) 2690 op->close_container (); /* close open sack first */
3060 esrv_apply_container (op, op->container); /* close open sack first */
3061 2691
3062 for (tmp = op->inv; tmp; tmp = next) 2692 for (tmp = op->inv; tmp; tmp = next)
3063 { 2693 {
3064 next = tmp->below; 2694 next = tmp->below;
3065 2695
3066 if (tmp->invisible) 2696 if (tmp->invisible)
3067 continue; 2697 continue;
3068 2698
3069 tmp->remove (); 2699 tmp->remove ();
3070 tmp->x = op->x, tmp->y = op->y; 2700 tmp->x = op->x, tmp->y = op->y;
2701
3071 if (tmp->type == CONTAINER) 2702 if (tmp->type == CONTAINER)
3072 { /* empty container to ground */ 2703 loot_object (tmp); /* empty container to ground */
3073 loot_object (tmp); 2704
3074 }
3075 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(RANDOM () % 3))) 2705 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3))))
3076 { 2706 {
3077 if (tmp->nrof > 1) 2707 if (tmp->nrof > 1)
3078 { 2708 {
3079 tmp2 = get_split_ob (tmp, 1 + RANDOM () % (tmp->nrof - 1)); 2709 tmp->decrease (rndm (1, tmp->nrof - 1));
3080 tmp2->destroy ();
3081 insert_ob_in_map (tmp, op->map, NULL, 0); 2710 insert_ob_in_map (tmp, op->map, NULL, 0);
3082 } 2711 }
3083 else 2712 else
3084 tmp->destroy (); 2713 tmp->destroy ();
3085 } 2714 }
3091/* 2720/*
3092 * fix_weight(): Check recursively the weight of all players, and fix 2721 * fix_weight(): Check recursively the weight of all players, and fix
3093 * what needs to be fixed. Refresh windows and fix speed if anything 2722 * what needs to be fixed. Refresh windows and fix speed if anything
3094 * was changed. 2723 * was changed.
3095 */ 2724 */
3096
3097void 2725void
3098fix_weight (void) 2726fix_weight ()
3099{ 2727{
3100 for (player *pl = first_player; pl; pl = pl->next) 2728 for_all_players (pl)
3101 { 2729 {
3102 int old = pl->ob->carrying, sum = sum_weight (pl->ob); 2730 sint32 old = pl->ob->carrying;
3103 2731
3104 if (old == sum) 2732 pl->ob->update_weight ();
3105 continue; 2733
2734 if (old != pl->ob->carrying)
2735 {
3106 pl->ob->update_stats (); 2736 pl->ob->update_stats ();
3107 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, old, sum); 2737 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, (int)old, (int)pl->ob->carrying);
2738 }
3108 } 2739 }
3109} 2740}
3110 2741
3111void 2742void
3112fix_luck (void) 2743fix_luck ()
3113{ 2744{
3114 for (player *pl = first_player; pl; pl = pl->next) 2745 for_all_players (pl)
3115 if (!pl->ob->contr->ns->state) 2746 if (!pl->ob->contr->ns->state)
3116 pl->ob->change_luck (0); 2747 pl->ob->change_luck (0);
3117} 2748}
3118 2749
3119/* cast_dust() - handles op throwing objects of type 'DUST'. 2750/* cast_dust() - handles op throwing objects of type 'DUST'.
3154} 2785}
3155 2786
3156void 2787void
3157make_visible (object *op) 2788make_visible (object *op)
3158{ 2789{
3159 op->hide = 0; 2790 op->flag [FLAG_HIDDEN] = 0;
3160 op->invisible = 0; 2791 op->invisible = 0;
2792
3161 if (op->type == PLAYER) 2793 if (op->type == PLAYER)
3162 { 2794 {
3163 op->contr->tmp_invis = 0; 2795 op->contr->tmp_invis = 0;
3164 op->contr->invis_race = 0; 2796 op->contr->invis_race = 0;
3165 } 2797 }
2798
3166 update_object (op, UP_OBJ_FACE); 2799 update_object (op, UP_OBJ_CHANGE);
3167} 2800}
3168 2801
3169int 2802int
3170is_true_undead (object *op) 2803is_true_undead (object *op)
3171{ 2804{
3172 object *tmp = NULL;
3173
3174 if (QUERY_FLAG (&op->arch->clone, FLAG_UNDEAD)) 2805 if (QUERY_FLAG (op->arch, FLAG_UNDEAD))
3175 return 1; 2806 return 1;
3176 2807
3177 return 0; 2808 return 0;
3178} 2809}
3179 2810
3180/* look at the surrounding terrain to determine 2811/* look at the surrounding terrain to determine
3181 * the hideability of this object. Positive levels 2812 * the hideability of this object. Positive levels
3182 * indicate greater hideability. 2813 * indicate greater hideability.
3183 */ 2814 */
3184
3185int 2815int
3186hideability (object *ob) 2816hideability (object *ob)
3187{ 2817{
3188 int i, level = 0, mflag; 2818 int i, level = 0, mflag;
3189 sint16 x, y; 2819 sint16 x, y;
3190 2820
3191 if (!ob || !ob->map) 2821 if (!ob || !ob->map)
3192 return 0; 2822 return 0;
3193 2823
3194 /* so, on normal lighted maps, its hard to hide */ 2824 /* so, on normal lighted maps, its hard to hide */
3195 level = ob->map->darkness - 2; 2825 level = ob->map->darklevel () - 2;
3196 2826
3197 /* this also picks up whether the object is glowing. 2827 /* this also picks up whether the object is glowing.
3198 * If you carry a light on a non-dark map, its not 2828 * If you carry a light on a non-dark map, its not
3199 * as bad as carrying a light on a pitch dark map */ 2829 * as bad as carrying a light on a pitch dark map */
3200 if (has_carried_lights (ob)) 2830 if (ob->has_carried_lights ())
3201 level = -(10 + (2 * ob->map->darkness)); 2831 level = -(10 + (2 * ob->map->darklevel ()));
3202 2832
3203 /* scan through all nearby squares for terrain to hide in */ 2833 /* scan through all nearby squares for terrain to hide in */
3204 for (i = 0, x = ob->x, y = ob->y; i < 9; i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2834 for (i = 0, x = ob->x, y = ob->y;
2835 i <= SIZEOFFREE1;
2836 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
3205 { 2837 {
3206 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 2838 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3207 if (mflag & P_OUT_OF_MAP) 2839 if (mflag & P_OUT_OF_MAP)
3208 {
3209 continue; 2840 continue;
3210 } 2841
3211 if (mflag & P_BLOCKSVIEW) /* something to hide near! */ 2842 if (mflag & P_BLOCKSVIEW) /* something to hide near! */
3212 level += 2; 2843 level += 2;
3213 else /* open terrain! */ 2844 else /* open terrain! */
3214 level -= 1; 2845 level -= 1;
3215 } 2846 }
3223/* For Hidden creatures - a chance of becoming 'unhidden' 2854/* For Hidden creatures - a chance of becoming 'unhidden'
3224 * every time they move - as we subtract off 'invisibility' 2855 * every time they move - as we subtract off 'invisibility'
3225 * AND, for players, if they move into a ridiculously unhideable 2856 * AND, for players, if they move into a ridiculously unhideable
3226 * spot (surrounded by clear terrain in broad daylight). -b.t. 2857 * spot (surrounded by clear terrain in broad daylight). -b.t.
3227 */ 2858 */
3228
3229void 2859void
3230do_hidden_move (object *op) 2860do_hidden_move (object *op)
3231{ 2861{
3232 int hide = 0, num = random_roll (0, 19, op, PREFER_LOW); 2862 int hide = 0;
3233 object *skop;
3234 2863
3235 if (!op || !op->map) 2864 if (!op || !op->map)
3236 return; 2865 return;
3237 2866
3238 skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING); 2867 object *skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING);
2868 int num = random_roll (0, 19, op, PREFER_LOW);
3239 2869
3240 /* its *extremely* hard to run and sneak/hide at the same time! */ 2870 /* its *extremely* hard to run and sneak/hide at the same time! */
3241 if (op->type == PLAYER && op->contr->run_on) 2871 if (op->type == PLAYER && op->contr->run_on)
3242 {
3243 if (!skop || num >= skop->level) 2872 if (!skop || num >= skop->level)
3244 { 2873 {
3245 new_draw_info (NDI_UNIQUE, 0, op, "You ran too much! You are no longer hidden!"); 2874 new_draw_info (NDI_UNIQUE, 0, op, "You ran too much! You are no longer hidden!");
3246 make_visible (op); 2875 make_visible (op);
3247 return; 2876 return;
3248 } 2877 }
3249 else 2878 else
3250 num += 20; 2879 num += 20;
3251 } 2880
3252 num += op->map->difficulty; 2881 num += op->map->difficulty;
3253 hide = hideability (op); /* modify by terrain hidden level */ 2882 hide = hideability (op); /* modify by terrain hidden level */
3254 num -= hide; 2883 num -= hide;
2884
3255 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0)) 2885 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0))
3256 { 2886 {
3257 make_visible (op); 2887 make_visible (op);
2888
3258 if (op->type == PLAYER) 2889 if (op->type == PLAYER)
3259 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!"); 2890 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!");
3260 } 2891 }
3261 else if (op->type == PLAYER && skop) 2892 else if (op->type == PLAYER && skop)
3262 {
3263 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0); 2893 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0);
3264 }
3265} 2894}
3266 2895
3267/* determine if who is standing near a hostile creature. */ 2896/* determine if who is standing near a hostile creature. */
3268 2897
3269int 2898int
3317 * object op. This function works fine for monsters, 2946 * object op. This function works fine for monsters,
3318 * but we dont worry if the object isnt the top one in 2947 * but we dont worry if the object isnt the top one in
3319 * a pile (say a coin under a table would return "viewable" 2948 * a pile (say a coin under a table would return "viewable"
3320 * by this routine). Another question, should we be 2949 * by this routine). Another question, should we be
3321 * concerned with the direction the player is looking 2950 * concerned with the direction the player is looking
3322 * in? Realistically, most of use cant see stuff behind 2951 * in? Realistically, most of us can't see stuff behind
3323 * our backs...on the other hand, does the "facing" direction 2952 * our backs...on the other hand, does the "facing" direction
3324 * imply the way your head, or body is facing? Its possible 2953 * imply the way your head, or body is facing? It's possible
3325 * for them to differ. Sigh, this fctn could get a bit more complex. 2954 * for them to differ. Sigh, this fctn could get a bit more complex.
3326 * -b.t. 2955 * -b.t.
3327 * This function is now map tiling safe. 2956 * This function is now map tiling safe.
3328 */ 2957 */
3329
3330int 2958int
3331player_can_view (object *pl, object *op) 2959player_can_view (object *pl, object *op)
3332{ 2960{
3333 rv_vector rv; 2961 rv_vector rv;
3334 int dx, dy; 2962 int dx, dy;
3336 if (pl->type != PLAYER) 2964 if (pl->type != PLAYER)
3337 { 2965 {
3338 LOG (llevError, "player_can_view() called for non-player object\n"); 2966 LOG (llevError, "player_can_view() called for non-player object\n");
3339 return -1; 2967 return -1;
3340 } 2968 }
2969
3341 if (!pl || !op) 2970 if (!pl || !op)
3342 return 0; 2971 return 0;
3343 2972
3344 if (op->head)
3345 {
3346 op = op->head; 2973 op = op->head_ ();
3347 } 2974
3348 get_rangevector (pl, op, &rv, 0x1); 2975 get_rangevector (pl, op, &rv, 0x1);
3349 2976
3350 /* starting with the 'head' part, lets loop 2977 /* starting with the 'head' part, lets loop
3351 * through the object and find if it has any 2978 * through the object and find if it has any
3352 * part that is in the los array but isnt on 2979 * part that is in the los array but isn't on
3353 * a blocked los square. 2980 * a blocked los square.
3354 * we use the archetype to figure out offsets. 2981 * we use the archetype to figure out offsets.
3355 */ 2982 */
3356 while (op) 2983 while (op)
3357 { 2984 {
3358 dx = rv.distance_x + op->arch->clone.x; 2985 dx = rv.distance_x + op->arch->x;
3359 dy = rv.distance_y + op->arch->clone.y; 2986 dy = rv.distance_y + op->arch->y;
3360 2987
3361 /* only the viewable area the player sees is updated by LOS 2988 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3362 * code, so we need to restrict ourselves to that range of values
3363 * for any meaningful values.
3364 */
3365 if (FABS (dx) <= (pl->contr->ns->mapx / 2) &&
3366 FABS (dy) <= (pl->contr->ns->mapy / 2) &&
3367 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3368 return 1; 2989 return 1;
2990
3369 op = op->more; 2991 op = op->more;
3370 } 2992 }
3371 return 0;
3372}
3373 2993
3374/* routine for both players and monsters. We call this when
3375 * there is a possibility for our action distrubing our hiding
3376 * place or invisiblity spell. Artefact invisiblity is not
3377 * effected by this. If we arent invisible to begin with, we
3378 * return 0.
3379 */
3380int
3381action_makes_visible (object *op)
3382{
3383
3384 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3385 {
3386 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3387 return 0;
3388
3389 if (op->contr && op->contr->tmp_invis == 0)
3390 return 0;
3391
3392 /* If monsters, they should become visible */
3393 if (op->hide || !op->contr || (op->contr && op->contr->tmp_invis))
3394 {
3395 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible");
3396 return 1;
3397 }
3398 }
3399 return 0; 2994 return 0;
3400} 2995}
3401 2996
3402/* op_on_battleground - checks if the given object op (usually 2997/* op_on_battleground - checks if the given object op (usually
3403 * a player) is standing on a valid battleground-tile, 2998 * a player) is standing on a valid battleground-tile,
3408 * Default is to do the same as before, so only people wanting to have different points need worry about this 3003 * Default is to do the same as before, so only people wanting to have different points need worry about this
3409 */ 3004 */
3410int 3005int
3411op_on_battleground (object *op, int *x, int *y) 3006op_on_battleground (object *op, int *x, int *y)
3412{ 3007{
3413 object *tmp;
3414
3415 /* A battleground-tile needs the following attributes to be valid: 3008 /* A battleground-tile needs the following attributes to be valid:
3416 * is_floor 1 (has to be the FIRST floor beneath the player's feet), 3009 * is_floor 1 (has to be the FIRST floor beneath the player's feet),
3417 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND) 3010 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND)
3418 * and the exit-coordinates sp/hp must both be > 0. 3011 * and the exit-coordinates sp/hp must both be > 0.
3419 * => The intention here is to prevent abuse of the battleground- 3012 * => The intention here is to prevent abuse of the battleground-
3420 * feature (like pickable or hidden battleground tiles). */ 3013 * feature (like pickable or hidden battleground tiles). */
3421 for (tmp = op->below; tmp != NULL; tmp = tmp->below) 3014 for (object *tmp = op->below; tmp; tmp = tmp->below)
3422 { 3015 {
3423 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3016 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
3424 { 3017 {
3425 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && 3018 if (QUERY_FLAG (tmp, FLAG_NO_PICK)
3426 strcmp (tmp->name, "battleground") == 0 && tmp->type == BATTLEGROUND && EXIT_X (tmp) && EXIT_Y (tmp)) 3019 && tmp->type == BATTLEGROUND
3020 && tmp->name == shstr_battleground
3021 && EXIT_X (tmp) && EXIT_Y (tmp))
3427 { 3022 {
3428 /*before we assign the exit, check if this is a teambattle */ 3023 /* before we assign the exit, check if this is a teambattle */
3429 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3024 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3430 {
3431 object *invtmp;
3432
3433 for (invtmp = op->inv; invtmp != NULL; invtmp = invtmp->below) 3025 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3026 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3434 { 3027 {
3435 if (invtmp->type == FORCE && invtmp->slaying && !strcmp (EXIT_PATH (tmp), invtmp->slaying))
3436 {
3437 if (x != NULL && y != NULL) 3028 if (x && y)
3438 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3029 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3030
3439 return 1; 3031 return 1;
3440 }
3441 } 3032 }
3442 } 3033
3443 if (x != NULL && y != NULL) 3034 if (x && y)
3444 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3035 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3036
3445 return 1; 3037 return 1;
3446 } 3038 }
3447 } 3039 }
3448 } 3040 }
3041
3449 /* If we got here, did not find a battleground */ 3042 /* If we got here, did not find a battleground */
3450 return 0; 3043 return 0;
3451} 3044}
3452 3045
3453/* 3046/*
3469 char buf[MAX_BUF]; /* tmp. string buffer */ 3062 char buf[MAX_BUF]; /* tmp. string buffer */
3470 int i = 0, j = 0; 3063 int i = 0, j = 0;
3471 3064
3472 /* get the appropriate treasurelist */ 3065 /* get the appropriate treasurelist */
3473 if (atnr == ATNR_FIRE) 3066 if (atnr == ATNR_FIRE)
3474 trlist = find_treasurelist ("dragon_ability_fire"); 3067 trlist = treasurelist::find (shstr_dragon_ability_fire);
3475 else if (atnr == ATNR_COLD) 3068 else if (atnr == ATNR_COLD)
3476 trlist = find_treasurelist ("dragon_ability_cold"); 3069 trlist = treasurelist::find (shstr_dragon_ability_cold);
3477 else if (atnr == ATNR_ELECTRICITY) 3070 else if (atnr == ATNR_ELECTRICITY)
3478 trlist = find_treasurelist ("dragon_ability_elec"); 3071 trlist = treasurelist::find (shstr_dragon_ability_elec);
3479 else if (atnr == ATNR_POISON) 3072 else if (atnr == ATNR_POISON)
3480 trlist = find_treasurelist ("dragon_ability_poison"); 3073 trlist = treasurelist::find (shstr_dragon_ability_poison);
3481 3074
3482 if (trlist == NULL || who->type != PLAYER) 3075 if (trlist == NULL || who->type != PLAYER)
3483 return; 3076 return;
3484 3077
3485 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++); 3078 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++);
3486 3079
3487 if (tr == NULL || tr->item == NULL) 3080 if (!tr || !tr->item)
3488 { 3081 {
3489 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */ 3082 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */
3490 return; 3083 return;
3491 } 3084 }
3492 3085
3493 /* everything seems okay - now bring on the gift: */ 3086 /* everything seems okay - now bring on the gift: */
3494 item = &(tr->item->clone); 3087 item = tr->item;
3495 3088
3496 if (item->type == SPELL) 3089 if (item->type == SPELL)
3497 { 3090 {
3498 if (check_spell_known (who, item->name)) 3091 if (check_spell_known (who, item->name))
3499 return; 3092 return;
3558 { 3151 {
3559 /* forces in the treasurelist can alter the player's stats */ 3152 /* forces in the treasurelist can alter the player's stats */
3560 object *skin; 3153 object *skin;
3561 3154
3562 /* first get the dragon skin force */ 3155 /* first get the dragon skin force */
3563 shstr_cmp dragon_skin_force ("dragon_skin_force");
3564 for (skin = who->inv; skin && !(skin->arch->name == dragon_skin_force); skin = skin->below) 3156 for (skin = who->inv; skin && !(skin->arch->archname == shstr_dragon_skin_force); skin = skin->below)
3565 ; 3157 ;
3566 3158
3567 if (!skin) 3159 if (!skin)
3568 return; 3160 return;
3569 3161
3583 else 3175 else
3584 j = 1; 3176 j = 1;
3585 strcat (buf, spellpathnames[i]); 3177 strcat (buf, spellpathnames[i]);
3586 } 3178 }
3587 } 3179 }
3180
3588 strcat (buf, "."); 3181 strcat (buf, ".");
3589 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf); 3182 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf);
3590 } 3183 }
3591 3184
3592 /* evtl. adding flags: */ 3185 /* evtl. adding flags: */
3602 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg); 3195 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg);
3603 } 3196 }
3604 else 3197 else
3605 { 3198 {
3606 /* generate misc. treasure */ 3199 /* generate misc. treasure */
3607 tmp = arch_to_object (tr->item); 3200 tmp = tr->item->instance ();
3608 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3201 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3609 tmp = insert_ob_in_ob (tmp, who); 3202 who->insert (tmp);
3610 if (who->type == PLAYER)
3611 esrv_send_item (who, tmp);
3612 } 3203 }
3613} 3204}
3614 3205
3615/** 3206//-GPL
3616 * Unready an object for a player. This function does nothing if the object was 3207
3617 * not readied. 3208sint8
3618 */ 3209player::darkness_at (maptile *map, int x, int y) const
3210{
3211 if (!ns)
3212 return LOS_BLOCKED;
3213
3214 int dx, dy;
3215 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3216 return LOS_BLOCKED;
3217
3218 x += dx - ns->current_x;
3219 y += dy - ns->current_y;
3220
3221 return blocked_los (x, y);
3222}
3223
3619void 3224void
3620player_unready_range_ob (player *pl, object *ob) 3225player::infobox (const char *title, const char *msg, int color)
3621{ 3226{
3622 rangetype i; 3227 send_msg (color | NDI_DEF | NDI_REPLY | NDI_CLEAR, title, msg);
3623
3624 for (i = (rangetype) 0; i < range_size; i = (rangetype) ((int) i + 1))
3625 {
3626 if (pl->ranges[i] == ob)
3627 {
3628 pl->ranges[i] = NULL;
3629 if (pl->shoottype == i)
3630 {
3631 pl->shoottype = range_none;
3632 }
3633 }
3634 }
3635} 3228}
3229
3230void
3231player::statusmsg (const char *msg, int color)
3232{
3233 send_msg (color | NDI_REPLY, INFO_CHANNEL, msg);
3234}
3235
3236void
3237player::failmsg (const char *msg, int color)
3238{
3239 play_sound (sound_find ("generic_failure"));
3240 statusmsg (msg, color);
3241}
3242

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines