ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.99 by root, Thu Jan 18 19:42:10 2007 UTC vs.
Revision 1.274 by root, Wed Apr 21 06:40:57 2010 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
21 * 21 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24 24
25//+GPL
26
25#include <global.h> 27#include <global.h>
26#include <pwd.h>
27#include <sproto.h> 28#include <sproto.h>
28#include <sounds.h> 29#include <sounds.h>
29#include <living.h> 30#include <living.h>
30#include <object.h> 31#include <object.h>
31#include <spells.h> 32#include <spells.h>
34#include <algorithm> 35#include <algorithm>
35#include <functional> 36#include <functional>
36 37
37playervec players; 38playervec players;
38 39
39void
40display_motd (const object *op)
41{
42 char buf[MAX_BUF];
43 char motd[HUGE_BUF];
44 FILE *fp;
45 int comp;
46 int size;
47
48 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
49 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
50 return;
51
52 motd[0] = '\0';
53 size = 0;
54
55 while (fgets (buf, MAX_BUF, fp))
56 {
57 if (*buf == '#')
58 continue;
59
60 strncat (motd + size, buf, HUGE_BUF - size);
61 size += strlen (buf);
62 }
63
64 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
65 close_and_delete (fp, comp);
66}
67
68void
69send_rules (const object *op)
70{
71 char buf[MAX_BUF];
72 char rules[HUGE_BUF];
73 FILE *fp;
74 int comp;
75 int size;
76
77 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
78 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
79 return;
80
81 rules[0] = '\0';
82 size = 0;
83
84 while (fgets (buf, MAX_BUF, fp))
85 {
86 if (*buf == '#')
87 continue;
88
89 if (size + strlen (buf) >= HUGE_BUF)
90 {
91 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
92 break;
93 }
94
95 strncat (rules + size, buf, HUGE_BUF - size);
96 size += strlen (buf);
97 }
98
99 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
100 close_and_delete (fp, comp);
101}
102
103void
104send_news (const object *op)
105{
106 char buf[MAX_BUF];
107 char news[HUGE_BUF];
108 char subject[MAX_BUF];
109 FILE *fp;
110 int comp;
111 int size;
112
113 sprintf (buf, "%s/%s", settings.confdir, settings.news);
114 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
115 return;
116
117 news[0] = '\0';
118 subject[0] = '\0';
119 size = 0;
120
121 while (fgets (buf, MAX_BUF, fp) != NULL)
122 {
123 if (*buf == '#')
124 continue;
125
126 if (*buf == '%')
127 { /* send one news */
128 if (size > 0)
129 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s", "%s\n%s", subject, news); /*send previously read news */
130
131 strcpy (subject, buf + 1);
132 strip_endline (subject);
133 size = 0;
134 news[0] = '\0';
135 }
136 else
137 {
138 if (size + strlen (buf) >= HUGE_BUF)
139 {
140 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
141 break;
142 }
143 strncat (news + size, buf, HUGE_BUF - size);
144 size += strlen (buf);
145 }
146 }
147
148 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
149 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", "%s\n%s", subject, news);
150 close_and_delete (fp, comp);
151}
152
153/* This loads the first map an puts the player on it. */ 40/* This loads the first map an puts the player on it. */
154static void 41static void
155set_first_map (object *op) 42set_first_map (object *op)
156{ 43{
157 op->contr->maplevel = first_map_path; 44 op->contr->maplevel = first_map_path;
158 op->x = -1; 45 op->x = -1;
159 op->y = -1; 46 op->y = -1;
160}
161
162void
163player::enter_map ()
164{
165 object *tmp = object::create ();
166
167 EXIT_PATH (tmp) = maplevel;
168 EXIT_X (tmp) = ob->x;
169 EXIT_Y (tmp) = ob->y;
170 ob->enter_exit (tmp);
171
172 tmp->destroy ();
173} 47}
174 48
175void 49void
176player::activate () 50player::activate ()
177{ 51{
180 54
181 players.insert (this); 55 players.insert (this);
182 ob->remove (); 56 ob->remove ();
183 ob->map = 0; 57 ob->map = 0;
184 ob->activate_recursive (); 58 ob->activate_recursive ();
185 CLEAR_FLAG (ob, FLAG_FRIENDLY); 59 ob->clr_flag (FLAG_FRIENDLY);
186 add_friendly_object (ob); 60 add_friendly_object (ob);
187 enter_map ();
188} 61}
189 62
190void 63void
191player::deactivate () 64player::deactivate ()
192{ 65{
194 return; 67 return;
195 68
196 terminate_all_pets (ob); 69 terminate_all_pets (ob);
197 remove_friendly_object (ob); 70 remove_friendly_object (ob);
198 ob->deactivate_recursive (); 71 ob->deactivate_recursive ();
72
73 if (ob->map)
199 maplevel = ob->map->path; 74 maplevel = ob->map->path;
75
200 ob->remove (); 76 ob->remove ();
77 ob->enemy = 0; // sometimes keeps an extra refcount on itself
201 ob->map = 0; 78 ob->map = 0;
202 79 party = 0;
203 // for weird reasons, this is often "ob", keeping a circular reference
204 ranges [range_skill] = 0;
205 80
206 players.erase (this); 81 players.erase (this);
207} 82}
208 83
209// connect the player with a specific client 84// connect the player with a specific client
210// also changed, rationalises, and fixes some incorrect settings 85// also changes, rationalises, and fixes some incorrect settings
211void 86void
212player::connect (client *ns) 87player::connect (client *ns)
213{ 88{
214 this->ns = ns; 89 this->ns = ns;
215 ns->pl = this; 90 ns->pl = this;
216 91
217 run_on = 0; 92 run_on = 0;
218 fire_on = 0; 93 fire_on = 0;
219 ob->container = 0; //TODO: client-specific 94 ob->close_container (); //TODO: client-specific
220 95
221 ns->update_look = 0; 96 ns->update_look = 0;
222 ns->look_position = 0; 97 ns->look_position = 0;
223 98
224 clear_los (ob); 99 clear_los ();
225 100
226 ns->reset_stats (); 101 ns->reset_stats ();
227 102
228 /* make sure he's a player -- needed because of class change. */ 103 /* make sure he's a player -- needed because of class change. */
229 ob->type = PLAYER; // we are paranoid 104 ob->type = PLAYER; // we are paranoid
230 ob->race = ob->arch->clone.race; 105 ob->race = ob->arch->race;
231 106
232 if (!legal_range (ob, shoottype)) 107 ob->update_weight ();
233 shoottype = range_none;
234
235 ob->carrying = sum_weight (ob);
236 link_player_skills (ob); 108 link_skills ();
237 109
238 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
239
240 assign (title, ob->arch->clone.name); 110 assign (title, ob->arch->object::name);
241
242 /* can_use_shield is a new flag. However, the can_use.. seems to largely come
243 * from the class, and not race. I don't see any way to get the class information
244 * to then update this. I don't think this will actually break anything - anyone
245 * that can use armour should be able to use a shield. What this may 'break'
246 * are features new characters get, eg, if someone starts up with a Q, they
247 * should be able to use a shield. However, old Q's won't get that advantage.
248 */
249 if (QUERY_FLAG (ob, FLAG_USE_ARMOUR))
250 SET_FLAG (ob, FLAG_USE_SHIELD);
251 111
252 /* if it's a dragon player, set the correct title here */ 112 /* if it's a dragon player, set the correct title here */
253 if (is_dragon_pl (ob)) 113 if (ob->is_dragon ())
254 { 114 {
255 object *tmp, *abil = 0, *skin = 0; 115 object *tmp, *abil = 0, *skin = 0;
256
257 shstr_cmp dragon_ability_force ("dragon_ability_force");
258 shstr_cmp dragon_skin_force ("dragon_skin_force");
259 116
260 for (tmp = ob->inv; tmp; tmp = tmp->below) 117 for (tmp = ob->inv; tmp; tmp = tmp->below)
261 if (tmp->type == FORCE) 118 if (tmp->type == FORCE)
262 if (tmp->arch->name == dragon_ability_force) 119 if (tmp->arch->archname == shstr_dragon_ability_force)
263 abil = tmp; 120 abil = tmp;
264 else if (tmp->arch->name == dragon_skin_force) 121 else if (tmp->arch->archname == shstr_dragon_skin_force)
265 skin = tmp; 122 skin = tmp;
266 123
267 set_dragon_name (ob, abil, skin); 124 set_dragon_name (ob, abil, skin);
268 } 125 }
269 126
270 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 127 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
271 128
272 esrv_new_player (this, ob->weight + ob->carrying); 129 esrv_new_player (this);
273 130
274 ob->update_stats (); 131 ob->update_stats ();
132
275 ns->floorbox_update (); 133 ns->floorbox_update ();
276
277 esrv_send_inventory (ob, ob); 134 esrv_send_inventory (ob, ob);
278 esrv_add_spells (this, 0); 135 esrv_add_spells (this, 0);
279 136
137 ob->flag [FLAG_READY_WEAPON] = false;
138 ob->flag [FLAG_READY_SKILL] = false;
139 ob->flag [FLAG_READY_RANGE] = false;
140 ob->flag [FLAG_READY_BOW] = false;
141
142 ob->update_stats (); // we unapplied stuff above
280 activate (); 143 activate ();
281
282 send_rules (ob);
283 send_news (ob);
284 display_motd (ob);
285 144
286 INVOKE_PLAYER (CONNECT, this); 145 INVOKE_PLAYER (CONNECT, this);
287 INVOKE_PLAYER (LOGIN, this); 146 INVOKE_PLAYER (LOGIN, this);
288} 147}
289 148
290void 149void
291player::disconnect () 150player::disconnect ()
292{ 151{
152 if (ob)
153 {
154 ob->close_container (); //TODO: client-specific
155 ob->drop_unpaid_items ();
156 }
157
293 if (ns) 158 if (ns)
294 { 159 {
295 if (active) 160 if (active)
296 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0)); 161 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0));
297 162
298 INVOKE_PLAYER (DISCONNECT, this); 163 INVOKE_PLAYER (DISCONNECT, this);
299 164
300 ns->reset_stats (); 165 ns->reset_stats ();
301 ns->pl = 0; 166 ns->pl = 0;
302 this->ns = 0; 167 ns = 0;
303 } 168 }
304 169
305 ob->container = 0; //TODO: client-specific 170 // this is important for the player scheduler to get the correct refcount
171 // when ns = 0
172 observe = viewpoint = ob;
173
306 deactivate (); 174 deactivate ();
307} 175}
176
177//-GPL
308 178
309// the need for this function can be explained 179// the need for this function can be explained
310// by load_object not returning the object 180// by load_object not returning the object
311void 181void
312player::set_object (object *op) 182player::set_object (object *op)
313{ 183{
314 ob = op; 184 ob = observe = viewpoint = op;
315 ob->contr = this; /* this aren't yet in archetype */ 185 ob->contr = this; /* this aren't yet in archetype */
316 186
187 ob->speed = 1.0f;
317 ob->speed_left = 0.5; 188 ob->speed_left = 0.5f;
318 ob->speed = 1.0; 189
319 ob->direction = 5; /* So player faces south */ 190 ob->direction = 5; /* So player faces south */
320 ob->stats.wc = 2;
321 ob->run_away = 25; /* Then we panick... */
322
323 ob->roll_stats ();
324} 191}
192
193void
194player::set_observe (object *op)
195{
196 observe = viewpoint = op ? op : ob;
197 do_los = 1;
198}
199
200void
201player::set_viewpoint (object *op)
202{
203 viewpoint = op ? op : (object *)observe;
204 do_los = 1;
205}
206
207//+GPL
325 208
326player::player () 209player::player ()
327{ 210{
328 /* There are some elements we want initialised to non zero value - 211 /* There are some elements we want initialised to non zero value -
329 * we deal with that below this point. 212 * we deal with that below this point.
330 */ 213 */
331 outputs_sync = 16; /* Every 2 seconds */ 214 outputs_sync = 4;
332 outputs_count = 8; /* Keeps present behaviour */ 215 outputs_count = 4;
333 unapply = unapply_nochoice; 216 unapply = unapply_nochoice;
334 217
335 savebed_map = first_map_path; /* Init. respawn position */ 218 savebed_map = first_map_path; /* Init. respawn position */
336 219
337 gen_sp_armour = 10; 220 gen_sp_armour = 10;
338 shoottype = range_none;
339 bowtype = bow_normal; 221 bowtype = bow_normal;
340 petmode = pet_normal; 222 petmode = pet_normal;
341 listening = 10;
342 usekeys = containers; 223 usekeys = containers;
343 peaceful = 1; /* default peaceful */ 224 peaceful = 1; /* default peaceful */
344 do_los = 1; 225 do_los = 1;
226
227 weapon_sp = 1.0f;
228 weapon_sp_left = 0.5f;
345} 229}
346 230
347void 231void
348player::do_destroy () 232player::do_destroy ()
349{ 233{
350 disconnect (); 234 disconnect ();
351 235
352 attachable::do_destroy (); 236 attachable::do_destroy ();
353 237
354 if (ob) 238 if (ob)
355 {
356 ob->destroy_inv (false);
357 ob->destroy (); 239 ob->destroy ();
358 } 240
241 ob = observe = viewpoint = 0;
359} 242}
360 243
361player::~player () 244player::~player ()
362{ 245{
363 /* Clear item stack */ 246 /* Clear item stack */
364 free (stack_items); 247 free (stack_items);
248}
249
250/*
251 * get_player_archetype() return next player archetype from archetype
252 * list. Not very efficient routine, but used only creating new players.
253 * Note: there MUST be at least one player archetype!
254 */
255static archetype *
256get_player_archetype (archetype *at)
257{
258 // archetypes could have been reloaded
259 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
260
261 if (!nat)
262 return at;
263
264 archvec::iterator i = archetypes.find (nat);
265
266 for (;;)
267 {
268 if (++i == archetypes.end ())
269 i = archetypes.begin ();
270 else if (*i == at)
271 cleanup ("not a single player archetype found");
272
273 if ((*i)->type == PLAYER)
274 return *i;
275 }
365} 276}
366 277
367/* Tries to add player on the connection passed in ns. 278/* Tries to add player on the connection passed in ns.
368 * All we can really get in this is some settings like host and display 279 * All we can really get in this is some settings like host and display
369 * mode. 280 * mode.
371player * 282player *
372player::create () 283player::create ()
373{ 284{
374 player *pl = new player; 285 player *pl = new player;
375 286
376 pl->set_object (arch_to_object (get_player_archetype (0))); 287 pl->set_object (get_player_archetype (0)->instance ());
288
289 pl->ob->roll_stats ();
290 pl->ob->stats.wc = 2;
291 pl->ob->run_away = 25; /* Then we panick... */
292
377 set_first_map (pl->ob); 293 set_first_map (pl->ob);
378 294
379 return pl; 295 return pl;
380}
381
382/*
383 * get_player_archetype() return next player archetype from archetype
384 * list. Not very efficient routine, but used only creating new players.
385 * Note: there MUST be at least one player archetype!
386 */
387archetype *
388get_player_archetype (archetype *at)
389{
390 archetype *start = at;
391
392 for (;;)
393 {
394 if (at == NULL || at->next == NULL)
395 at = first_archetype;
396 else
397 at = at->next;
398
399 if (at->clone.type == PLAYER)
400 return at;
401
402 if (at == start)
403 {
404 LOG (llevError, "No Player archetypes\n");
405 exit (-1);
406 }
407 }
408} 296}
409 297
410object * 298object *
411get_nearest_player (object *mon) 299get_nearest_player (object *mon)
412{ 300{
415 unsigned lastdist; 303 unsigned lastdist;
416 rv_vector rv; 304 rv_vector rv;
417 305
418 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next) 306 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next)
419 { 307 {
420 /* We should not find free objects on this friendly list, but it
421 * does periodically happen. Given that, lets deal with it.
422 * While unlikely, it is possible the next object on the friendly
423 * list is also free, so encapsulate this in a while loop.
424 */
425 while (QUERY_FLAG (ol->ob, FLAG_FREED) || !QUERY_FLAG (ol->ob, FLAG_FRIENDLY))
426 {
427 object *tmp = ol->ob;
428
429 /* Can't do much more other than log the fact, because the object
430 * itself will have been cleared.
431 */
432 LOG (llevDebug, "get_nearest_player: Found free/non friendly object '%s' on friendly list\n",
433 tmp->debug_desc ());
434 ol = ol->next;
435 remove_friendly_object (tmp);
436 if (!ol)
437 return op;
438 }
439
440 /* Remove special check for player from this. First, it looks to cause
441 * some crashes (ol->ob->contr not set properly?), but secondly, a more
442 * complicated method of state checking would be needed in any case -
443 * as it was, a clever player could type quit, and the function would
444 * skip them over while waiting for confirmation. Remove
445 * on_same_map check, as can_detect_enemy also does this
446 */
447 if (!can_detect_enemy (mon, ol->ob, &rv)) 308 if (!can_detect_enemy (mon, ol->ob, &rv))
448 continue; 309 continue;
449 310
450 if (lastdist > rv.distance) 311 if (lastdist > rv.distance)
451 { 312 {
513 */ 374 */
514int 375int
515path_to_player (object *mon, object *pl, unsigned mindiff) 376path_to_player (object *mon, object *pl, unsigned mindiff)
516{ 377{
517 rv_vector rv; 378 rv_vector rv;
518 sint16 x, y;
519 int lastx, lasty, dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES, mflags, blocked; 379 int dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES, mflags, blocked;
520 maptile *m, *lastmap;
521 380
522 get_rangevector (mon, pl, &rv, 0); 381 get_rangevector (mon, pl, &rv, 0);
523 382
524 if (rv.distance < mindiff) 383 if (rv.distance < mindiff)
525 return 0; 384 return 0;
526 385
527 x = mon->x; 386 mapxy pos (mon);
528 y = mon->y;
529 m = mon->map;
530 dir = rv.direction; 387 dir = rv.direction;
531 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 388 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
532 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 389 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
390
533 /* If we can't solve it within the search distance, return now. */ 391 /* If we can't solve it within the search distance, return now. */
534 if (diff > max) 392 if (diff > max)
535 return 0; 393 return 0;
394
536 while (diff > 1 && max > 0) 395 while (diff > 1 && max > 0)
537 { 396 {
538 lastx = x; 397 mapxy lastpos = pos;
539 lasty = y;
540 lastmap = m;
541 x = lastx + freearr_x[dir];
542 y = lasty + freearr_y[dir];
543 398
544 mflags = get_map_flags (m, &m, x, y, &x, &y); 399 pos.move (dir);
545 blocked = (mflags & P_OUT_OF_MAP) ? MOVE_ALL : GET_MAP_MOVE_BLOCK (m, x, y);
546 400
547 /* Space is blocked - try changing direction a little */ 401 /* Space is blocked - try changing direction a little */
548 if ((mflags & P_OUT_OF_MAP) || ((OB_TYPE_MOVE_BLOCK (mon, blocked) || (mflags & P_BLOCKSVIEW)) 402 if (!pos.normalise ()
549 && (m == mon->map && blocked_link (mon, m, x, y)))) 403 || (((pos->flags () & P_BLOCKSVIEW) || OB_TYPE_MOVE_BLOCK (mon, pos->move_block))
404 && blocked_link (mon, pos.m, pos.x, pos.y)))
550 { 405 {
551 /* recalculate direction from last good location. Possible 406 /* recalculate direction from last good location. Possible
552 * we were not traversing ideal location before. 407 * we were not traversing ideal location before.
553 */ 408 */
554 get_rangevector_from_mapcoord (lastmap, lastx, lasty, pl, &rv, 0); 409 get_rangevector_from_mapcoord (lastpos.m, lastpos.x, lastpos.y, pl, &rv, 0);
555 if (rv.direction != dir) 410 if (rv.direction != dir)
556 { 411 {
557 /* OK - says direction should be different - lets reset the 412 /* OK - says direction should be different - lets reset the
558 * the values so it will try again. 413 * the values so it will try again.
559 */ 414 */
560 x = lastx;
561 y = lasty;
562 m = lastmap; 415 pos = lastpos;
563 dir = firstdir = rv.direction; 416 dir = firstdir = rv.direction;
564 } 417 }
565 else 418 else
566 { 419 {
567 /* direct path is blocked - try taking a side step to 420 /* direct path is blocked - try taking a side step to
574 */ 427 */
575 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++) 428 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++)
576 { 429 {
577 if (i == 0) 430 if (i == 0)
578 continue; /* already did this, so skip it */ 431 continue; /* already did this, so skip it */
432
579 /* Use lastdir here - otherwise, 433 /* Use lastdir here - otherwise,
580 * since the direction that the creature should move in 434 * since the direction that the creature should move in
581 * may change, you could get infinite loops. 435 * may change, you could get infinite loops.
582 * ie, player is northwest, but monster can only 436 * ie, player is northwest, but monster can only
583 * move west, so it does that. It goes some distance, 437 * move west, so it does that. It goes some distance,
585 * can't do that, but now finds it can move east, and 439 * can't do that, but now finds it can move east, and
586 * gets back to its original point. lastdir contains 440 * gets back to its original point. lastdir contains
587 * the last direction the creature has successfully 441 * the last direction the creature has successfully
588 * moved. 442 * moved.
589 */ 443 */
590
591 x = lastx + freearr_x[absdir (lastdir + i)];
592 y = lasty + freearr_y[absdir (lastdir + i)];
593 m = lastmap; 444 pos = lastpos;
594 mflags = get_map_flags (m, &m, x, y, &x, &y); 445 pos.move (absdir (lastdir + i));
595 if (mflags & P_OUT_OF_MAP) 446
447 if (!pos.normalise ())
596 continue; 448 continue;
597 blocked = GET_MAP_MOVE_BLOCK (m, x, y); 449
598 if (OB_TYPE_MOVE_BLOCK (mon, blocked)) 450 mapspace &ms = *pos;
451
452 if (ms.flags () & P_BLOCKSVIEW)
599 continue; 453 continue;
600 if (mflags & P_BLOCKSVIEW) 454
455 if (OB_TYPE_MOVE_BLOCK (mon, ms.move_block))
601 continue; 456 continue;
602 457
603 if (m == mon->map && blocked_link (mon, m, x, y)) 458 if (blocked_link (mon, pos.m, pos.x, pos.y))
604 break; 459 break;
605 } 460 }
461
606 /* go through entire loop without finding a valid 462 /* go through entire loop without finding a valid
607 * sidestep to take - thus, no valid path. 463 * sidestep to take - thus, no valid path.
608 */ 464 */
609 if (i == (DETOUR_AMOUNT + 1)) 465 if (i == DETOUR_AMOUNT + 1)
610 return 0; 466 return 0;
467
611 diff--; 468 diff--;
612 lastdir = dir; 469 lastdir = dir;
613 max--; 470 max--;
614 if (!firstdir) 471 if (!firstdir)
615 firstdir = dir + i; 472 firstdir = dir + i;
619 { 476 {
620 /* we moved towards creature, so diff is less */ 477 /* we moved towards creature, so diff is less */
621 diff--; 478 diff--;
622 max--; 479 max--;
623 lastdir = dir; 480 lastdir = dir;
481
624 if (!firstdir) 482 if (!firstdir)
625 firstdir = dir; 483 firstdir = dir;
626 } 484 }
485
627 if (diff <= 1) 486 if (diff <= 1)
628 { 487 {
629 /* Recalculate diff (distance) because we may not have actually 488 /* Recalculate diff (distance) because we may not have actually
630 * headed toward player for entire distance. 489 * headed toward player for entire distance.
631 */ 490 */
632 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 491 get_rangevector_from_mapcoord (pos.m, pos.x, pos.y, pl, &rv, 0);
633 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 492 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
634 } 493 }
494
635 if (diff > max) 495 if (diff > max)
636 return 0; 496 return 0;
637 } 497 }
498
638 /* If we reached the max, didn't find a direction in time */ 499 /* If we reached the max, didn't find a direction in time */
639 if (!max) 500 if (!max)
640 return 0; 501 return 0;
641 502
642 return firstdir; 503 return firstdir;
643} 504}
644 505
645void 506void
646give_initial_items (object *pl, treasurelist * items) 507give_initial_items (object *pl, treasurelist *items)
647{ 508{
648 object *op, *next = NULL;
649
650 if (pl->randomitems != NULL) 509 if (pl->randomitems)
651 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0); 510 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0);
652 511
653 for (op = pl->inv; op; op = next) 512 for (object *next, *op = pl->inv; op; op = next)
654 { 513 {
655 next = op->below; 514 next = op->below;
656 515
657 /* Forces get applied per default, unless they have the 516 /* Forces get applied per default, unless they have the
658 * flag "neutral" set. Sorry but I can't think of a better way 517 * flag "neutral" set. Sorry but I can't think of a better way
659 */ 518 */
660 if (op->type == FORCE && !QUERY_FLAG (op, FLAG_NEUTRAL)) 519 if (op->type == FORCE && !op->flag [FLAG_NEUTRAL])
661 SET_FLAG (op, FLAG_APPLIED); 520 op->set_flag (FLAG_APPLIED);
662 521
663 /* we never give weapons/armour if these cannot be used 522 /* we never give weapons/armour if these cannot be used
664 * by this player due to race restrictions 523 * by this player due to race restrictions
665 */ 524 */
666 if (pl->type == PLAYER) 525 if (pl->type == PLAYER)
667 { 526 {
668 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) && 527 if ((!pl->flag [FLAG_USE_ARMOUR]
528 &&
669 (op->type == ARMOUR || op->type == BOOTS || 529 (op->type == ARMOUR || op->type == BOOTS
670 op->type == CLOAK || op->type == HELMET || 530 || op->type == CLOAK || op->type == HELMET
671 op->type == SHIELD || op->type == GLOVES || 531 || op->type == SHIELD || op->type == GLOVES
672 op->type == BRACERS || op->type == GIRDLE)) || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 532 || op->type == BRACERS || op->type == GIRDLE))
533 || (!pl->flag [FLAG_USE_WEAPON] && op->type == WEAPON))
673 { 534 {
674 op->destroy (); 535 op->destroy ();
675 continue; 536 continue;
676 } 537 }
677 } 538 }
678 539
679 /* This really needs to be better - we should really give 540 /* Here we remove duplicated skills (as duplicated spell objects have
680 * a substitute spellbook. The problem is that we don't really 541 * _very_ confusing effects for players), which could for instance be
681 * have a good idea what to replace it with (need something like 542 * generated by bad treasurelists. - elmex
682 * a first level treasurelist for each skill.)
683 * remove duplicate skills also
684 */ 543 */
685 if (op->type == SPELLBOOK || op->type == SKILL) 544 if (op->type == SKILL)
686 { 545 {
687 object *tmp;
688
689 for (tmp = op->below; tmp; tmp = tmp->below) 546 for (object *tmp = op->below; tmp; tmp = tmp->below)
690 if (tmp->type == op->type && tmp->name == op->name) 547 if (tmp->type == op->type && tmp->name == op->name)
691 break;
692
693 if (tmp)
694 { 548 {
695 op->destroy (); 549 op->destroy ();
550 LOG (llevError,
696 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 551 "give_initial_items: Removing duplicate skill %s\n", &tmp->name);
697 continue; 552 break;
698 } 553 }
699 554
700 if (op->nrof > 1) 555 if (op->nrof > 1)
701 op->nrof = 1; 556 op->nrof = 1;
702 } 557 }
703 558
704 if (op->type == SPELLBOOK && op->inv) 559 if (op->type == SPELLBOOK && op->inv)
705 { 560 op->inv->clr_flag (FLAG_STARTEQUIP);
706 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP);
707 }
708 561
709 /* Give starting characters identified, uncursed, and undamned 562 /* Give starting characters identified, uncursed, and undamned
710 * items. Just don't identify gold or silver, or it won't be 563 * items. Just don't identify gold or silver, or it won't be
711 * merged properly. 564 * merged properly.
712 */ 565 */
713 if (need_identify (op)) 566 if (op->need_identify ())
714 {
715 SET_FLAG (op, FLAG_IDENTIFIED);
716 CLEAR_FLAG (op, FLAG_CURSED);
717 CLEAR_FLAG (op, FLAG_DAMNED);
718 } 567 {
568 op->set_flag (FLAG_IDENTIFIED);
569 op->clr_flag (FLAG_CURSED);
570 op->clr_flag (FLAG_DAMNED);
571 }
572
719 if (op->type == SPELL) 573 if (op->type == SPELL)
720 { 574 {
721 op->destroy (); 575 op->destroy ();
722 continue; 576 continue;
723 } 577 }
724 else if (op->type == SKILL) 578 else if (op->type == SKILL)
725 { 579 {
726 SET_FLAG (op, FLAG_CAN_USE_SKILL); 580 op->set_flag (FLAG_CAN_USE_SKILL);
727 op->stats.exp = 0; 581 op->stats.exp = 0;
728 op->level = 1; 582 op->level = 1;
729 } 583 }
730 /* lock all 'normal items by default */ 584 else /* lock all 'normal items by default */
731 else 585 op->set_flag (FLAG_INV_LOCKED);
732 SET_FLAG (op, FLAG_INV_LOCKED);
733 } /* for loop of objects in player inv */ 586 } /* for loop of objects in player inv */
734 587
735 /* Need to set up the skill pointers */ 588 /* Need to set up the skill pointers */
736 link_player_skills (pl); 589 pl->contr->link_skills ();
737} 590}
738 591
739void 592void
740get_party_password (object *op, partylist *party) 593get_party_password (object *op, partylist *party)
741{ 594{
751 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:"); 604 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:");
752} 605}
753 606
754/* This rolls four 1-6 rolls and sums the best 3 of the 4. */ 607/* This rolls four 1-6 rolls and sums the best 3 of the 4. */
755static int 608static int
756roll_stat (void) 609roll_stat ()
757{ 610{
758 int a[4], i, j, k; 611 int a[4], i, j, k;
759 612
760 for (i = 0; i < 4; i++) 613 for (i = 0; i < 4; i++)
761 a[i] = (int) rndm (6) + 1; 614 a[i] = (int) rndm (6) + 1;
772} 625}
773 626
774void 627void
775object::roll_stats () 628object::roll_stats ()
776{ 629{
777 int statsort [7]; 630 int statsort [NUM_STATS];
778 631
779 for (;;) 632 for (;;)
780 { 633 {
781 int sum = 0; 634 int sum = 0;
782 for (int i = 7; i--; ) 635 for (int i = NUM_STATS; i--; )
783 sum += statsort [i] = roll_stat (); 636 sum += statsort [i] = roll_stat ();
784 637
785 if (sum >= 82 && sum <= 116) 638 if (sum >= 82 && sum <= 116)
786 break; 639 break;
787 } 640 }
788 641
789 // Sort the stats so that rerolling is easier... 642 // Sort the stats so that rerolling is easier...
790 std::sort (statsort, statsort + 7, std::greater<int>()); 643 std::sort (statsort, statsort + NUM_STATS, std::greater<int>());
791 644
645 for (int i = 0; i < NUM_STATS; ++i)
792 stats.Str = statsort[0]; 646 stats.stat (i) = statsort [i];
793 stats.Dex = statsort[1];
794 stats.Con = statsort[2];
795 stats.Int = statsort[3];
796 stats.Wis = statsort[4];
797 stats.Pow = statsort[5];
798 stats.Cha = statsort[6];
799 647
800 stats.exp = 0; 648 stats.exp = 0;
801 stats.ac = 0; 649 stats.ac = 0;
802 650
803 stats.hp = stats.maxhp; 651 stats.hp = stats.maxhp;
815} 663}
816 664
817void 665void
818object::swap_stats (int a, int b) 666object::swap_stats (int a, int b)
819{ 667{
820 int tmp = get_attr_value (&contr->orig_stats, a); 668 swap (contr->orig_stats.stat (a), contr->orig_stats.stat (b));
821 set_attr_value (&contr->orig_stats, a, get_attr_value (&contr->orig_stats, b));
822 set_attr_value (&contr->orig_stats, b, tmp);
823 669
670 for (int i = 0; i < NUM_STATS; ++i)
824 stats.Str = contr->orig_stats.Str; 671 stats.stat (i) = contr->orig_stats.stat (i);
825 stats.Dex = contr->orig_stats.Dex;
826 stats.Con = contr->orig_stats.Con;
827 stats.Int = contr->orig_stats.Int;
828 stats.Wis = contr->orig_stats.Wis;
829 stats.Pow = contr->orig_stats.Pow;
830 stats.Cha = contr->orig_stats.Cha;
831 672
832 //TODO: the following code looks so borked and should, at the very least, 673 //TODO: the following code looks so borked and should, at the very least,
833 // be merged with the similar code in roll_stats 674 // be merged with the similar code in roll_stats
834 stats.ac = 0; 675 stats.ac = 0;
835 676
854static void 695static void
855start_info (object *op) 696start_info (object *op)
856{ 697{
857 char buf[MAX_BUF]; 698 char buf[MAX_BUF];
858 699
859 sprintf (buf, "Welcome to Crossfire v%s!", VERSION); 700 sprintf (buf, "Welcome to Deliantra v%s!", VERSION);
860 new_draw_info (NDI_UNIQUE, 0, op, buf); 701 new_draw_info (NDI_UNIQUE, 0, op, buf);
861 //new_draw_info (NDI_UNIQUE, 0, op, "Press `?' for help");
862 //new_draw_info (NDI_UNIQUE, 0, op, " ");
863} 702}
864 703
865/* This function takes the key that is passed, and does the 704/* This function takes the key that is passed, and does the
866 * appropriate action with it (change race, or other things). 705 * appropriate action with it (change race, or other things).
867 * The function name is for historical reasons - now we have 706 * The function name is for historical reasons - now we have
868 * separate race and class; this actually changes the RACE, 707 * separate race and class; this actually changes the RACE,
869 * not the class. 708 * not the class.
870 */ 709 */
871int 710void
872key_change_class (object *op, char key) 711player::chargen_race_done ()
873{ 712{
874 int tmp_loop;
875
876 if (key == 'd' || key == 'D')
877 {
878 char buf[MAX_BUF];
879
880 /* this must before then initial items are given */ 713 /* this must before then initial items are given */
881 esrv_new_player (op->contr, op->weight + op->carrying); 714 esrv_new_player (ob->contr);
882 715
883 treasurelist *tl = find_treasurelist ("starting_wealth"); 716 treasurelist *tl = treasurelist::find (shstr_starting_wealth);
884 if (tl) 717 if (tl)
885 create_treasure (tl, op, 0, 0, 0); 718 create_treasure (tl, ob, 0, 0, 0);
886 719
887 INVOKE_PLAYER (BIRTH, op->contr); 720 INVOKE_PLAYER (BIRTH, ob->contr);
888 INVOKE_PLAYER (LOGIN, op->contr); 721 INVOKE_PLAYER (LOGIN, ob->contr);
889 722
890 op->contr->ns->state = ST_PLAYING; 723 ob->contr->ns->state = ST_PLAYING;
891 724
892 if (op->msg) 725 if (ob->msg)
893 op->msg = NULL; 726 ob->msg = 0;
894 727
895 /* We create this now because some of the unique maps will need it
896 * to save here.
897 */
898 sprintf (buf, "%s/%s/%s", settings.localdir, settings.playerdir, &op->name);
899 make_path_to_file (buf);
900
901 start_info (op); 728 start_info (ob);
902 CLEAR_FLAG (op, FLAG_WIZ); 729 ob->clr_flag (FLAG_WIZ);
903 give_initial_items (op, op->randomitems); 730 give_initial_items (ob, ob->randomitems);
904 link_player_skills (op);
905 esrv_send_inventory (op, op); 731 esrv_send_inventory (ob, ob);
906 op->update_stats (); 732 ob->update_stats ();
907 733
908 /* This moves the player to a different start map, if there 734 /* This moves the player to a different start map, if there
909 * is one for this race 735 * is one for this race
910 */ 736 */
911 if (*first_map_ext_path) 737 if (*first_map_ext_path)
912 { 738 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
913 object *tmp;
914 char mapname[MAX_BUF];
915
916 snprintf (mapname, MAX_BUF - 1, "%s/%s", &first_map_ext_path, &op->arch->name);
917 tmp = object::create ();
918 EXIT_PATH (tmp) = mapname;
919 EXIT_X (tmp) = op->x;
920 EXIT_Y (tmp) = op->y;
921 op->enter_exit (tmp); /* we don't really care if it succeeded;
922 * if the map isn't there, then stay on the
923 * default initial map */
924 tmp->destroy ();
925 }
926 else 739 else
927 LOG (llevDebug, "first_map_ext_path not set\n"); 740 LOG (llevDebug, "first_map_ext_path not set\n");
741}
928 742
929 return 0; 743void
930 } 744player::chargen_race_next ()
931 745{
932 /* Following actually changes the race - this is the default command 746 /* Following actually changes the race - this is the default command
933 * if we don't match with one of the options above. 747 * if we don't match with one of the options above.
934 */ 748 */
935 749
936 tmp_loop = 0; 750 do
937 while (!tmp_loop)
938 { 751 {
939 shstr name = op->name; 752 shstr name = ob->name;
940 int x = op->x, y = op->y; 753 int x = ob->x, y = ob->y;
941 754
942 op->remove_statbonus (); 755 ob->remove_statbonus ();
943 op->remove (); 756 ob->remove ();
944 op->arch = get_player_archetype (op->arch); 757 ob->arch = get_player_archetype (ob->arch);
945 op->arch->clone.copy_to (op); 758 ob->arch->copy_to (ob);
946 op->instantiate (); 759 ob->instantiate ();
947 op->stats = op->contr->orig_stats; 760 ob->stats = ob->contr->orig_stats;
948 op->name = op->name_pl = name; 761 ob->name = ob->name_pl = name;
949 op->x = x; 762 ob->x = x;
950 op->y = y; 763 ob->y = y;
951 SET_ANIMATION (op, 2); /* So player faces south */ 764 SET_ANIMATION (ob, 2); /* So player faces south */
952 insert_ob_in_map (op, op->map, op, 0); 765 insert_ob_in_map (ob, ob->map, ob, 0);
953 assign (op->contr->title, op->arch->clone.name); 766 assign (ob->contr->title, ob->arch->object::name);
954 op->add_statbonus (); 767 ob->add_statbonus ();
955 tmp_loop = allowed_class (op);
956 } 768 }
769 while (!allowed_class (ob));
957 770
958 update_object (op, UP_OBJ_FACE); 771 update_object (ob, UP_OBJ_FACE);
959 esrv_update_item (UPD_FACE, op, op); 772 esrv_update_item (UPD_FACE, ob, ob);
960 op->update_stats (); 773 ob->update_stats ();
961 op->stats.hp = op->stats.maxhp; 774 ob->stats.hp = ob->stats.maxhp;
962 op->stats.sp = op->stats.maxsp; 775 ob->stats.sp = ob->stats.maxsp;
963 op->stats.grace = 0; 776 ob->stats.grace = 0;
964
965 if (op->msg)
966 new_draw_info (NDI_BLUE, 0, op, op->msg);
967
968 send_query (op->contr->ns, CS_QUERY_SINGLECHAR, "Press any key for the next race.\nPress `d' to play this race.\n");
969 return 0;
970} 777}
971 778
972void 779static void
973flee_player (object *op) 780flee_player (object *op)
974{ 781{
975 int dir, diff; 782 int dir, diff;
976 rv_vector rv; 783 rv_vector rv;
977 784
978 if (op->stats.hp < 0) 785 if (op->stats.hp < 0)
979 { 786 {
980 LOG (llevDebug, "Fleeing player is dead.\n"); 787 LOG (llevDebug, "Fleeing player is dead.\n");
981 CLEAR_FLAG (op, FLAG_SCARED); 788 op->clr_flag (FLAG_SCARED);
982 return; 789 return;
983 } 790 }
984 791
985 if (op->enemy == NULL) 792 if (!op->enemy)
986 { 793 {
987 LOG (llevDebug, "Fleeing player had no enemy.\n"); 794 LOG (llevDebug, "Fleeing player had no enemy.\n");
988 CLEAR_FLAG (op, FLAG_SCARED); 795 op->clr_flag (FLAG_SCARED);
989 return; 796 return;
990 } 797 }
991 798
992 /* Seen some crashes here. Since we don't store an 799 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
993 * op->enemy_count, it is possible that something destroys the
994 * actual enemy, and the object is recycled.
995 */
996 if (op->enemy->map == NULL)
997 { 800 {
998 CLEAR_FLAG (op, FLAG_SCARED);
999 op->enemy = NULL; 801 op->enemy = NULL;
1000 return; 802 op->clr_flag (FLAG_SCARED);
1001 }
1002
1003 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
1004 {
1005 op->enemy = NULL;
1006 CLEAR_FLAG (op, FLAG_SCARED);
1007 return; 803 return;
1008 } 804 }
1009 805
1010 get_rangevector (op, op->enemy, &rv, 0); 806 get_rangevector (op, op->enemy, &rv, 0);
1011 807
1012 dir = absdir (4 + rv.direction); 808 dir = absdir (4 + rv.direction);
1013 for (diff = 0; diff < 3; diff++) 809 for (diff = 0; diff < 3; diff++)
1014 { 810 {
1015 int m = 1 - (RANDOM () & 2); 811 int m = 1 - rndm (2) * 2;
1016 812
1017 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 813 if (op->move (absdir (dir + diff * m)) || (diff == 0 && op->move (absdir (dir - diff * m))))
1018 return; 814 return;
1019 } 815 }
1020 816
1021 /* Cornered, get rid of scared */ 817 /* Cornered, get rid of scared */
1022 CLEAR_FLAG (op, FLAG_SCARED); 818 op->clr_flag (FLAG_SCARED);
1023 op->enemy = NULL; 819 op->enemy = NULL;
1024} 820}
1025 821
1026
1027/* check_pick sees if there is stuff to be picked up/picks up stuff. 822/* check_pick sees if there is stuff to be picked up/picks up stuff.
1028 * IT returns 1 if the player should keep on moving, 0 if he should 823 * It returns 1 if the player should keep on moving, 0 if he should
1029 * stop. 824 * stop.
1030 */ 825 */
1031int 826int
1032check_pick (object *op) 827check_pick (object *op)
1033{ 828{
1034 object *tmp, *next; 829 object *tmp, *next;
1035 int stop = 0; 830 int stop = 0;
1036 int j, k, wvratio; 831 int wvratio;
1037 char putstring[128], tmpstr[16];
1038 832
1039 /* if you're flying, you cna't pick up anything */ 833 /* if you're flying, you can't pick up anything */
1040 if (op->move_type & MOVE_FLYING) 834 if (op->move_type & MOVE_FLYING)
1041 return 1; 835 return 1;
1042 836
1043 next = op->below; 837 next = op->below;
838
839 int cnt = MAX_ITEM_PER_ACTION;
840#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
1044 841
1045 /* loop while there are items on the floor that are not marked as 842 /* loop while there are items on the floor that are not marked as
1046 * destroyed */ 843 * destroyed */
1047 while (next && !next->destroyed ()) 844 while (next && !next->destroyed ())
1048 { 845 {
1049 tmp = next; 846 tmp = next;
1050 next = tmp->below; 847 next = tmp->below;
1051 848
849 if (cnt <= 0)
850 {
851 op->failmsg ("Couldn't pickup all items at once.");
852 return 0;
853 }
854
1052 if (op->destroyed ()) 855 if (op->destroyed ())
1053 return 0; 856 return 0;
1054 857
1055 if (!can_pick (op, tmp)) 858 if (!can_pick (op, tmp))
1056 continue; 859 continue;
1057 860
1058 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 861 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1059 { 862 {
1060 if (item_matched_string (op, tmp, op->contr->search_str)) 863 if (item_matched_string (op, tmp, op->contr->search_str))
1061 pick_up (op, tmp); 864 CHK_PICK_PICKUP;
865
1062 continue; 866 continue;
1063 } 867 }
1064 868
1065 /* high not bit set? We're using the old autopickup model */ 869 /* pickup handling */
870 if (op->contr->mode & PU_DEBUG)
871 {
872 /* some debugging code to figure out item information */
873 const char *str = tmp->name
874 ? format ("item name: %s item type: %d weight/value: %d",
875 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))))
876 : format ("item name: %s item type: %d weight/value: %d",
877 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
878
879 new_draw_info (NDI_UNIQUE, 0, op, str);
880 }
881
882 if (op->contr->mode & PU_INHIBIT)
883 return 1;
884
885 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
886 return 1;
887
888 /* philosophy:
889 * It's easy to grab an item type from a pile, as long as it's
890 * generic. This takes no game-time. For more detailed pickups
891 * and selections, select-items should be used. This is a
892 * grab-as-you-run type mode that's really useful for arrows for
893 * example.
894 * The drawback: right now it has no frontend, so you need to
895 * stick the bits you want into a calculator in hex mode and then
896 * convert to decimal and then 'pickup <#>
897 */
898
899 /* the first two modes are exclusive: if NOTHING we return, if
900 * STOP then we stop. All the rest are applied sequentially,
901 * meaning if any test passes, the item gets picked up. */
902
903 /* if mode is set to pick nothing up, return */
904 if (op->contr->mode == PU_NOTHING)
905 return 1;
906
907 /* if mode is set to stop when encountering objects, return */
908 /* take STOP before INHIBIT since it doesn't actually pick
909 * anything up */
910 if (op->contr->mode & PU_STOP)
911 return 0;
912
913 /* useful for going into stores and not losing your settings... */
914 /* and for battles wher you don't want to get loaded down while
915 * fighting */
916 if (op->contr->mode & PU_INHIBIT)
917 return 1;
918
919 /* prevent us from turning into auto-thieves :) */
920 if (tmp->flag [FLAG_UNPAID])
921 continue;
922
923 /* ignore known cursed objects */
924 if (tmp->flag [FLAG_KNOWN_CURSED] && op->contr->mode & PU_NOT_CURSED)
925 continue;
926
927 /* all food and drink if desired */
928 /* question: don't pick up known-poisonous stuff? */
1066 if (!(op->contr->mode & PU_NEWMODE)) 929 if (op->contr->mode & PU_FOOD)
930 if (tmp->type == FOOD)
1067 { 931 {
1068 switch (op->contr->mode) 932 CHK_PICK_PICKUP;
933 continue;
934 }
935
936 if (op->contr->mode & PU_DRINK)
937 if (tmp->type == DRINK || (tmp->type == POISON && !tmp->flag [FLAG_KNOWN_CURSED]))
938 {
939 CHK_PICK_PICKUP;
940 continue;
941 }
942
943 if (op->contr->mode & PU_POTION)
944 if (tmp->type == POTION)
945 {
946 CHK_PICK_PICKUP;
947 continue;
948 }
949
950 /* spellbooks, skillscrolls and normal books/scrolls */
951 if (op->contr->mode & PU_SPELLBOOK)
952 if (tmp->type == SPELLBOOK)
953 {
954 CHK_PICK_PICKUP;
955 continue;
956 }
957
958 if (op->contr->mode & PU_SKILLSCROLL)
959 if (tmp->type == SKILLSCROLL)
960 {
961 CHK_PICK_PICKUP;
962 continue;
963 }
964
965 if (op->contr->mode & PU_READABLES)
966 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
967 {
968 CHK_PICK_PICKUP;
969 continue;
970 }
971
972 /* wands/staves/rods/horns */
973 if (op->contr->mode & PU_MAGIC_DEVICE)
974 if (tmp->type == WAND
975 || tmp->type == ROD
976 || tmp->type == HORN
977 || tmp->type == POWER_CRYSTAL)
978 {
979 CHK_PICK_PICKUP;
980 continue;
981 }
982
983 /* pick up all magical items */
984 if (op->contr->mode & PU_MAGICAL)
985 if (tmp->flag [FLAG_KNOWN_MAGICAL]
986 && !tmp->flag [FLAG_KNOWN_CURSED])
987 {
988 CHK_PICK_PICKUP;
989 continue;
990 }
991
992 if (op->contr->mode & PU_VALUABLES)
993 {
994 if (tmp->type == MONEY || tmp->type == GEM)
1069 { 995 {
1070 case 0: 996 CHK_PICK_PICKUP;
1071 return 1; /* don't pick up */ 997 continue;
1072 case 1:
1073 pick_up (op, tmp);
1074 return 1;
1075 case 2:
1076 pick_up (op, tmp);
1077 return 0;
1078 case 3:
1079 return 0; /* stop before pickup */
1080 case 4:
1081 pick_up (op, tmp);
1082 break;
1083 case 5:
1084 pick_up (op, tmp);
1085 stop = 1;
1086 break;
1087 case 6:
1088 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1089 pick_up (op, tmp);
1090 break;
1091
1092 case 7:
1093 if (tmp->type == MONEY || tmp->type == GEM)
1094 pick_up (op, tmp);
1095 break;
1096
1097 default:
1098 /* use value density */
1099 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1100 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1101 pick_up (op, tmp);
1102 } 998 }
1103 } 999 }
1104 else 1000
1105 { /* old model */ 1001 /* rings & amulets - talismans seems to be typed AMULET */
1106 /* NEW pickup handling */
1107 if (op->contr->mode & PU_DEBUG) 1002 if (op->contr->mode & PU_JEWELS)
1003 if (tmp->type == RING
1004 || tmp->type == AMULET
1005 || tmp->type == GIRDLE
1006 || tmp->type == SKILL_TOOL)
1108 { 1007 {
1109 /* some debugging code to figure out item information */ 1008 CHK_PICK_PICKUP;
1110 if (tmp->name != NULL)
1111 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1112 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1113 else
1114 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1115 &tmp->arch->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1116
1117 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1118 }
1119
1120 /* philosophy:
1121 * It's easy to grab an item type from a pile, as long as it's
1122 * generic. This takes no game-time. For more detailed pickups
1123 * and selections, select-items should be used. This is a
1124 * grab-as-you-run type mode that's really useful for arrows for
1125 * example.
1126 * The drawback: right now it has no frontend, so you need to
1127 * stick the bits you want into a calculator in hex mode and then
1128 * convert to decimal and then 'pickup <#>
1129 */
1130
1131 /* the first two modes are exclusive: if NOTHING we return, if
1132 * STOP then we stop. All the rest are applied sequentially,
1133 * meaning if any test passes, the item gets picked up. */
1134
1135 /* if mode is set to pick nothing up, return */
1136
1137 if (op->contr->mode & PU_NOTHING)
1138 return 1;
1139
1140 /* if mode is set to stop when encountering objects, return */
1141 /* take STOP before INHIBIT since it doesn't actually pick
1142 * anything up */
1143
1144 if (op->contr->mode & PU_STOP)
1145 return 0;
1146
1147 /* useful for going into stores and not losing your settings... */
1148 /* and for battles wher you don't want to get loaded down while
1149 * fighting */
1150 if (op->contr->mode & PU_INHIBIT)
1151 return 1;
1152
1153 /* prevent us from turning into auto-thieves :) */
1154 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1155 continue; 1009 continue;
1010 }
1156 1011
1157 /* ignore known cursed objects */ 1012 /* we don't forget dragon food */
1158 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1013 if (op->contr->mode & PU_FLESH)
1014 if (tmp->type == FLESH)
1015 {
1016 CHK_PICK_PICKUP;
1159 continue; 1017 continue;
1018 }
1160 1019
1161 /* all food and drink if desired */ 1020 /* bows and arrows. Bows are good for selling! */
1162 /* question: don't pick up known-poisonous stuff? */ 1021 if (op->contr->mode & PU_BOW)
1022 if (tmp->type == BOW)
1023 {
1024 CHK_PICK_PICKUP;
1025 continue;
1026 }
1027
1028 if (op->contr->mode & PU_ARROW)
1029 if (tmp->type == ARROW)
1030 {
1031 CHK_PICK_PICKUP;
1032 continue;
1033 }
1034
1035 /* all kinds of armor etc. */
1036 if (op->contr->mode & PU_ARMOUR)
1037 if (tmp->type == ARMOUR)
1038 {
1039 CHK_PICK_PICKUP;
1040 continue;
1041 }
1042
1043 if (op->contr->mode & PU_HELMET)
1044 if (tmp->type == HELMET)
1045 {
1046 CHK_PICK_PICKUP;
1047 continue;
1048 }
1049
1050 if (op->contr->mode & PU_SHIELD)
1051 if (tmp->type == SHIELD)
1052 {
1053 CHK_PICK_PICKUP;
1054 continue;
1055 }
1056
1163 if (op->contr->mode & PU_FOOD) 1057 if (op->contr->mode & PU_BOOTS)
1164 if (tmp->type == FOOD) 1058 if (tmp->type == BOOTS)
1059 {
1060 CHK_PICK_PICKUP;
1061 continue;
1062 }
1063
1064 if (op->contr->mode & PU_GLOVES)
1065 if (tmp->type == GLOVES || tmp->type == BRACERS)
1066 {
1067 CHK_PICK_PICKUP;
1068 continue;
1069 }
1070
1071 if (op->contr->mode & PU_CLOAK)
1072 if (tmp->type == CLOAK)
1073 {
1074 CHK_PICK_PICKUP;
1075 continue;
1076 }
1077
1078 /* hoping to catch throwing daggers here */
1079 if (op->contr->mode & PU_MISSILEWEAPON)
1080 if (tmp->type == WEAPON && tmp->flag [FLAG_IS_THROWN])
1081 {
1082 CHK_PICK_PICKUP;
1083 continue;
1084 }
1085
1086 /* careful: chairs and tables are weapons! */
1087 if (op->contr->mode & PU_ALLWEAPON)
1088 {
1089 if (tmp->type == WEAPON)
1090 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1165 { 1091 {
1166 pick_up (op, tmp); 1092 CHK_PICK_PICKUP;
1167 continue; 1093 continue;
1168 } 1094 }
1095 }
1169 1096
1097 /* misc stuff that's useful */
1170 if (op->contr->mode & PU_DRINK) 1098 if (op->contr->mode & PU_KEY)
1171 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1099 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1172 { 1100 {
1173 pick_up (op, tmp); 1101 CHK_PICK_PICKUP;
1174 continue; 1102 continue;
1175 } 1103 }
1176 1104
1105 /* any of the last 4 bits set means we use the ratio for value
1106 * pickups */
1177 if (op->contr->mode & PU_POTION) 1107 if (op->contr->mode & PU_RATIO)
1178 if (tmp->type == POTION) 1108 {
1109 /* use value density to decide what else to grab */
1110 /* >=7 was >= op->contr->mode */
1111 /* >=7 is the old standard setting. Now we take the last 4 bits
1179 { 1112 */
1180 pick_up (op, tmp);
1181 continue;
1182 }
1183
1184 /* spellbooks, skillscrolls and normal books/scrolls */
1185 if (op->contr->mode & PU_SPELLBOOK)
1186 if (tmp->type == SPELLBOOK)
1187 {
1188 pick_up (op, tmp);
1189 continue;
1190 }
1191
1192 if (op->contr->mode & PU_SKILLSCROLL)
1193 if (tmp->type == SKILLSCROLL)
1194 {
1195 pick_up (op, tmp);
1196 continue;
1197 }
1198
1199 if (op->contr->mode & PU_READABLES)
1200 if (tmp->type == BOOK || tmp->type == SCROLL)
1201 {
1202 pick_up (op, tmp);
1203 continue;
1204 }
1205
1206 /* wands/staves/rods/horns */
1207 if (op->contr->mode & PU_MAGIC_DEVICE)
1208 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1209 {
1210 pick_up (op, tmp);
1211 continue;
1212 }
1213
1214 /* pick up all magical items */
1215 if (op->contr->mode & PU_MAGICAL) 1113 wvratio = op->contr->mode & PU_RATIO;
1216 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1114 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1217 {
1218 pick_up (op, tmp);
1219 continue;
1220 }
1221
1222 if (op->contr->mode & PU_VALUABLES)
1223 { 1115 {
1224 if (tmp->type == MONEY || tmp->type == GEM) 1116#if 0
1117 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1118 if (tmp->name != NULL)
1225 { 1119 {
1226 pick_up (op, tmp); 1120 fprintf (stderr, "%s", tmp->name);
1227 continue;
1228 } 1121 }
1229 }
1230
1231 /* rings & amulets - talismans seems to be typed AMULET */
1232 if (op->contr->mode & PU_JEWELS)
1233 if (tmp->type == RING || tmp->type == AMULET)
1234 {
1235 pick_up (op, tmp);
1236 continue;
1237 }
1238
1239 /* we don't forget dragon food */
1240 if (op->contr->mode & PU_FLESH)
1241 if (tmp->type == FLESH)
1242 {
1243 pick_up (op, tmp);
1244 continue;
1245 }
1246
1247 /* bows and arrows. Bows are good for selling! */
1248 if (op->contr->mode & PU_BOW)
1249 if (tmp->type == BOW)
1250 {
1251 pick_up (op, tmp);
1252 continue;
1253 }
1254
1255 if (op->contr->mode & PU_ARROW)
1256 if (tmp->type == ARROW)
1257 {
1258 pick_up (op, tmp);
1259 continue;
1260 }
1261
1262 /* all kinds of armor etc. */
1263 if (op->contr->mode & PU_ARMOUR)
1264 if (tmp->type == ARMOUR)
1265 {
1266 pick_up (op, tmp);
1267 continue;
1268 }
1269
1270 if (op->contr->mode & PU_HELMET)
1271 if (tmp->type == HELMET)
1272 {
1273 pick_up (op, tmp);
1274 continue;
1275 }
1276
1277 if (op->contr->mode & PU_SHIELD)
1278 if (tmp->type == SHIELD)
1279 {
1280 pick_up (op, tmp);
1281 continue;
1282 }
1283
1284 if (op->contr->mode & PU_BOOTS)
1285 if (tmp->type == BOOTS)
1286 {
1287 pick_up (op, tmp);
1288 continue;
1289 }
1290
1291 if (op->contr->mode & PU_GLOVES)
1292 if (tmp->type == GLOVES)
1293 {
1294 pick_up (op, tmp);
1295 continue;
1296 }
1297
1298 if (op->contr->mode & PU_CLOAK)
1299 if (tmp->type == CLOAK)
1300 {
1301 pick_up (op, tmp);
1302 continue;
1303 }
1304
1305 /* hoping to catch throwing daggers here */
1306 if (op->contr->mode & PU_MISSILEWEAPON)
1307 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1308 {
1309 pick_up (op, tmp);
1310 continue;
1311 }
1312
1313 /* careful: chairs and tables are weapons! */
1314 if (op->contr->mode & PU_ALLWEAPON)
1315 {
1316 if (tmp->type == WEAPON && tmp->name != NULL)
1317 {
1318 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->name, "table") == NULL &&
1319 strstr (tmp->name, "chair") && strstr (tmp->arch->name, "chair") == NULL)
1320 {
1321 pick_up (op, tmp);
1322 continue;
1323 }
1324 }
1325
1326 if (tmp->type == WEAPON && tmp->name == NULL)
1327 {
1328 if (strstr (tmp->arch->name, "table") == NULL && strstr (tmp->arch->name, "chair") == NULL)
1329 {
1330 pick_up (op, tmp);
1331 continue;
1332 }
1333 }
1334 }
1335
1336 /* misc stuff that's useful */
1337 if (op->contr->mode & PU_KEY)
1338 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1339 {
1340 pick_up (op, tmp);
1341 continue;
1342 }
1343
1344 /* any of the last 4 bits set means we use the ratio for value
1345 * pickups */
1346 if (op->contr->mode & PU_RATIO)
1347 {
1348 /* use value density to decide what else to grab */
1349 /* >=7 was >= op->contr->mode */
1350 /* >=7 is the old standard setting. Now we take the last 4 bits
1351 * and multiply them by 5, giving 0..15*5== 5..75 */
1352 wvratio = (op->contr->mode & PU_RATIO) * 5;
1353 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio)
1354 {
1355 pick_up (op, tmp);
1356#if 0
1357 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1358 if (tmp->name != NULL)
1359 {
1360 fprintf (stderr, "%s", tmp->name);
1361 }
1362 else 1122 else
1363 fprintf (stderr, "%s", tmp->arch->name); 1123 fprintf (stderr, "%s", tmp->arch->archname);
1364 fprintf (stderr, ",%d] = ", tmp->type); 1124 fprintf (stderr, ",%d] = ", tmp->type);
1365 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1125 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
1366#endif 1126#endif
1127 CHK_PICK_PICKUP;
1367 continue; 1128 continue;
1368 }
1369 } 1129 }
1370 } /* the new pickup model */ 1130 } /* the new pickup model */
1371 } 1131 }
1372 1132
1373 return !stop; 1133 return !stop;
1134}
1135
1136/* routine for both players and monsters. We call this when
1137 * there is a possibility for our action distrubing our hiding
1138 * place or invisiblity spell. Artefact invisiblity causes
1139 * "noise" instead. If we arent invisible to begin with, we
1140 * return 0.
1141 */
1142static int
1143action_makes_visible (object *op)
1144{
1145 if (op->invisible && op->flag [FLAG_ALIVE])
1146 {
1147 if (op->flag [FLAG_MAKE_INVIS])
1148 {
1149 // artefact invisibility is permanent, but we still make noise
1150 // this is important for game-balance.
1151 if (op->contr)
1152 op->make_noise ();
1153
1154 return 0;
1155 }
1156
1157 if (op->contr && op->contr->tmp_invis == 0)
1158 return 0;
1159
1160 /* If monsters, they should become visible */
1161 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
1162 {
1163 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
1164 return 1;
1165 }
1166 }
1167
1168 return 0;
1374} 1169}
1375 1170
1376/* 1171/*
1377 * Find an arrow in the inventory and after that 1172 * Find an arrow in the inventory and after that
1378 * in the right type container (quiver). Pointer to the 1173 * in the right type container (quiver). Pointer to the
1379 * found object is returned. 1174 * found object is returned.
1380 */ 1175 */
1381object * 1176static object *
1382find_arrow (object *op, const char *type) 1177find_arrow (object *op, const char *type)
1383{ 1178{
1384 object *tmp = NULL;
1385
1386 for (op = op->inv; op; op = op->below) 1179 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1387 if (!tmp && op->type == CONTAINER && op->race == type && QUERY_FLAG (op, FLAG_APPLIED))
1388 tmp = find_arrow (op, type);
1389 else if (op->type == ARROW && op->race == type) 1180 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1181 return splay (tmp);
1182
1183 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1184 if (tmp->type == CONTAINER && tmp->flag [FLAG_APPLIED] && !strcmp (&tmp->race, type))
1185 if (object *arrow = find_arrow (tmp, type))
1186 {
1187 splay (tmp);
1390 return op; 1188 return arrow;
1189 }
1190
1391 return tmp; 1191 return 0;
1392} 1192}
1393 1193
1394/* 1194/*
1395 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1195 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1396 * against the target. A full test is not performed, simply a basic test 1196 * against the target. A full test is not performed, simply a basic test
1397 * of resistances. The archer is making a quick guess at what he sees down 1197 * of resistances. The archer is making a quick guess at what he sees down
1398 * the hall. Failing that it does it's best to pick the highest plus arrow. 1198 * the hall. Failing that it does it's best to pick the highest plus arrow.
1399 */ 1199 */
1400 1200static object *
1401object *
1402find_better_arrow (object *op, object *target, const char *type, int *better) 1201find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1403{ 1202{
1404 object *tmp = NULL, *arrow, *ntmp; 1203 object *tmp = NULL, *arrow, *ntmp;
1405 int attacknum, attacktype, betterby = 0, i; 1204 int attacknum, attacktype, betterby = 0, i;
1406 1205
1407 if (!type) 1206 if (!type)
1408 return NULL; 1207 return NULL;
1409 1208
1410 for (arrow = op->inv; arrow; arrow = arrow->below) 1209 for (arrow = op->inv; arrow; arrow = arrow->below)
1411 { 1210 {
1412 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1211 if (arrow->type == CONTAINER && arrow->race == type && arrow->flag [FLAG_APPLIED])
1413 { 1212 {
1414 i = 0; 1213 i = 0;
1415 ntmp = find_better_arrow (arrow, target, type, &i); 1214 ntmp = find_better_arrow (arrow, target, type, &i);
1215
1416 if (i > betterby) 1216 if (i > betterby)
1417 { 1217 {
1418 tmp = ntmp; 1218 tmp = ntmp;
1419 betterby = i; 1219 betterby = i;
1420 } 1220 }
1421 } 1221 }
1422 else if (arrow->type == ARROW && arrow->race == type) 1222 else if (arrow->type == ARROW && arrow->race == type)
1423 { 1223 {
1424 /* allways prefer assasination/slaying */ 1224 /* allways prefer assasination/slaying */
1425 if (target->race != NULL && arrow->slaying != NULL && strstr (arrow->slaying, target->race)) 1225 if (target->race && arrow->slaying.contains (target->race))
1426 { 1226 {
1427 if (arrow->attacktype & AT_DEATH) 1227 if (arrow->attacktype & AT_DEATH)
1428 { 1228 {
1429 *better = 100; 1229 *better = 100;
1430 return arrow; 1230 return arrow;
1438 else 1238 else
1439 { 1239 {
1440 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++) 1240 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++)
1441 { 1241 {
1442 attacktype = 1 << attacknum; 1242 attacktype = 1 << attacknum;
1443 if ((arrow->attacktype & attacktype) && (target->arch->clone.resist[attacknum]) < 0) 1243 if ((arrow->attacktype & attacktype) && (target->arch->resist[attacknum]) < 0)
1444 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100) > betterby) 1244 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100) > betterby)
1445 { 1245 {
1446 tmp = arrow; 1246 tmp = arrow;
1447 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100; 1247 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1448 } 1248 }
1449 } 1249 }
1250
1450 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1251 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1451 { 1252 {
1452 tmp = arrow; 1253 tmp = arrow;
1453 betterby = 2 + arrow->magic + arrow->stats.dam; 1254 betterby = 2 + arrow->magic + arrow->stats.dam;
1454 } 1255 }
1256
1455 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1257 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1456 { 1258 {
1457 tmp = arrow; 1259 tmp = arrow;
1458 betterby = 1 + arrow->magic + arrow->stats.dam; 1260 betterby = 1 + arrow->magic + arrow->stats.dam;
1459 } 1261 }
1460 } 1262 }
1461 } 1263 }
1462 } 1264 }
1265
1463 if (tmp == NULL && arrow == NULL) 1266 if (tmp == NULL && arrow == NULL)
1464 return find_arrow (op, type); 1267 return find_arrow (op, type);
1465 1268
1466 *better = betterby; 1269 *better = betterby;
1467 return tmp; 1270 return tmp;
1471 * find_better_arrow to find a decent arrow to use. 1274 * find_better_arrow to find a decent arrow to use.
1472 * op = the shooter 1275 * op = the shooter
1473 * type = bow->race 1276 * type = bow->race
1474 * dir = fire direction 1277 * dir = fire direction
1475 */ 1278 */
1476 1279static object *
1477object *
1478pick_arrow_target (object *op, const char *type, int dir) 1280pick_arrow_target (object *op, shstr_cmp type, int dir)
1479{ 1281{
1480 object *tmp = NULL; 1282 object *tmp = NULL;
1481 maptile *m; 1283 maptile *m;
1482 int i, mflags, found, number; 1284 int i, mflags, found, number;
1483 sint16 x, y; 1285 sint16 x, y;
1498 for (i = 0, found = 0; i < 20; i++) 1300 for (i = 0, found = 0; i < 20; i++)
1499 { 1301 {
1500 x += freearr_x[dir]; 1302 x += freearr_x[dir];
1501 y += freearr_y[dir]; 1303 y += freearr_y[dir];
1502 mflags = get_map_flags (m, &m, x, y, &x, &y); 1304 mflags = get_map_flags (m, &m, x, y, &x, &y);
1305
1503 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1306 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1504 { 1307 {
1505 tmp = NULL; 1308 tmp = 0;
1506 break; 1309 break;
1507 } 1310 }
1508 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1311 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1509 { 1312 {
1510 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1313 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1511 * perhaps a bad assumption. 1314 * perhaps a bad assumption.
1512 */ 1315 */
1513 tmp = NULL; 1316 tmp = 0;
1514 break; 1317 break;
1515 } 1318 }
1319
1516 if (mflags & P_IS_ALIVE) 1320 if (mflags & P_IS_ALIVE)
1517 {
1518 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1321 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1519 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1322 if (tmp->flag [FLAG_ALIVE])
1520 {
1521 found++;
1522 break;
1523 }
1524 if (found)
1525 break; 1323 break;
1526 }
1527 } 1324 }
1528 if (tmp == NULL) 1325
1326 if (!tmp)
1529 return find_arrow (op, type); 1327 return find_arrow (op, type);
1530 1328
1531 if (tmp->head) 1329 if (tmp->head)
1532 tmp = tmp->head; 1330 tmp = tmp->head;
1533 1331
1546 */ 1344 */
1547int 1345int
1548fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy) 1346fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy)
1549{ 1347{
1550 object *left, *bow; 1348 object *left, *bow;
1551 int bowspeed, mflags; 1349 int mflags;
1552 maptile *m; 1350 maptile *m;
1553 1351
1554 if (!dir) 1352 if (!dir)
1555 { 1353 {
1556 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!"); 1354 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!");
1557 return 0; 1355 return 0;
1558 } 1356 }
1559 1357
1560 if (op->type == PLAYER) 1358 if (op->contr)
1561 bow = op->contr->ranges[range_bow]; 1359 bow = op->current_weapon;
1562 else 1360 else
1563 { 1361 {
1564 for (bow = op->inv; bow; bow = bow->below) 1362 for (bow = op->inv; bow; bow = bow->below)
1565 /* Don't check for applied - monsters don't apply bows - in that way, they 1363 /* Don't check for applied - monsters don't apply bows - in that way, they
1566 * don't need to switch back and forth between bows and weapons. 1364 * don't need to switch back and forth between bows and weapons.
1571 if (!bow) 1369 if (!bow)
1572 { 1370 {
1573 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1371 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1574 return 0; 1372 return 0;
1575 } 1373 }
1374
1375 // optimisation: move object to top so we will find it quickly again
1376 splay (bow);
1576 } 1377 }
1577 1378
1578 if (!bow->race || !bow->skill) 1379 if (!bow->race || !bow->skill)
1579 { 1380 {
1580 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1381 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1581 return 0; 1382 return 0;
1582 } 1383 }
1583
1584 bowspeed = bow->stats.sp + dex_bonus[op->stats.Dex];
1585
1586 /* penalize ROF for bestarrow */
1587 if (op->type == PLAYER && op->contr->bowtype == bow_bestarrow)
1588 bowspeed -= dex_bonus[op->stats.Dex] + 5;
1589
1590 if (bowspeed < 1)
1591 bowspeed = 1;
1592 1384
1593 if (arrow == NULL) 1385 if (arrow == NULL)
1594 { 1386 {
1595 if ((arrow = find_arrow (op, bow->race)) == NULL) 1387 if ((arrow = find_arrow (op, bow->race)) == NULL)
1596 { 1388 {
1597 if (op->type == PLAYER) 1389 if (op->type == PLAYER)
1598 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1390 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1599 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1391 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1600 else 1392 else
1601 CLEAR_FLAG (op, FLAG_READY_BOW); 1393 op->clr_flag (FLAG_READY_BOW);
1394
1602 return 0; 1395 return 0;
1603 } 1396 }
1604 } 1397 }
1605 1398
1606 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy); 1399 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy);
1614 } 1407 }
1615 1408
1616 /* this should not happen, but sometimes does */ 1409 /* this should not happen, but sometimes does */
1617 if (arrow->nrof == 0) 1410 if (arrow->nrof == 0)
1618 { 1411 {
1412 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1619 arrow->destroy (); 1413 arrow->destroy ();
1620 return 0; 1414 return 0;
1621 } 1415 }
1622 1416
1623 left = arrow; /* these are arrows left to the player */ 1417 left = arrow; /* these are arrows left to the player */
1624 arrow = get_split_ob (arrow, 1); 1418 arrow = arrow->split ();
1625 if (!arrow) 1419 if (!arrow)
1626 { 1420 {
1627 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1421 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1628 return 0; 1422 return 0;
1629 } 1423 }
1630 1424
1631 arrow->set_owner (op); 1425 arrow->set_owner (op);
1632 arrow->skill = bow->skill; 1426 arrow->skill = bow->skill;
1633 arrow->direction = dir; 1427 arrow->direction = dir;
1634 1428
1429 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1430 arrow->stats.hp = arrow->stats.dam;
1431 arrow->stats.grace = arrow->attacktype;
1432 arrow->custom_name = arrow->slaying;
1433
1434#if 0
1435 if (player *pl = op->contr)
1436 {
1437 float speed = pl->weapon_sp;
1438
1439 /* penalize ROF for bestarrow */
1440 if (pl->bowtype == bow_bestarrow)
1441 speed *= .9f;
1442 else
1443 speed *= 1.f + dex_bonus[op->stats.Dex] * .2f;
1444
1445 op->speed_left += speed - op->speed;
1446 }
1447#endif
1448
1449 SET_ANIMATION (arrow, arrow->direction);
1450
1451 /* update the speed */
1452 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1453 + bow->stats.dam / 7.f;
1454
1455 arrow->set_speed (max (arrow->speed, 2.f));
1456 arrow->speed_left = 0;
1457
1458 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1459
1635 if (op->type == PLAYER) 1460 if (op->type == PLAYER)
1636 { 1461 {
1637 op->speed_left = 0.01 - (float) FABS (op->speed) * 100 / bowspeed;
1638 op->update_stats ();
1639 }
1640
1641 SET_ANIMATION (arrow, arrow->direction);
1642 arrow->stats.sp = arrow->stats.wc; /* save original wc and dam */
1643 arrow->stats.hp = arrow->stats.dam;
1644 arrow->stats.grace = arrow->attacktype;
1645 if (arrow->slaying != NULL)
1646 arrow->spellarg = strdup (arrow->slaying);
1647
1648 /* Note that this was different for monsters - they got their level
1649 * added to the damage. I think the strength bonus is more proper.
1650 */
1651
1652 arrow->stats.dam += (QUERY_FLAG (bow, FLAG_NO_STRENGTH) ? 0 : dam_bonus[op->stats.Str]) + bow->stats.dam + bow->magic + arrow->magic;
1653
1654 /* update the speed */
1655 arrow->speed = (float) ((QUERY_FLAG (bow, FLAG_NO_STRENGTH) ?
1656 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.0 + (float) bow->stats.dam / 7.0;
1657
1658 arrow->set_speed (max (arrow->speed, 1.0));
1659 arrow->speed_left = 0;
1660
1661 if (op->type == PLAYER)
1662 {
1663 arrow->stats.wc = 20 - bow->magic - arrow->magic -
1664 (op->chosen_skill ? op->chosen_skill->level : op->level) -
1665 dex_bonus[op->stats.Dex] - thaco_bonus[op->stats.Str] - arrow->stats.wc - bow->stats.wc + wc_mod;
1666
1667 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level; 1462 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level;
1463 wc -= dex_bonus[op->stats.Dex];
1464
1465 if (!arrow->slaying)
1466 arrow->slaying = op->slaying;
1467
1468 arrow->attacktype |= op->attacktype;
1668 } 1469 }
1669 else 1470 else
1670 { 1471 {
1671 arrow->stats.wc = op->stats.wc - bow->magic - arrow->magic - arrow->stats.wc + wc_mod;
1672 arrow->level = op->level; 1472 arrow->level = op->level;
1673 } 1473 arrow->stats.wc -= bow->magic;
1674 1474
1675 if (arrow->attacktype == AT_PHYSICAL) 1475 if (!arrow->slaying)
1476 arrow->slaying = bow->slaying;
1477
1676 arrow->attacktype |= bow->attacktype; 1478 arrow->attacktype |= bow->attacktype;
1479 }
1677 1480
1678 if (bow->slaying) 1481 wc -= arrow->level;
1679 arrow->slaying = bow->slaying; 1482 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1680 1483
1484 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1681 arrow->move_type = MOVE_FLY_LOW; 1485 arrow->move_type = MOVE_FLY_LOW;
1682 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1486 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1683 1487
1684 play_sound_map (op->map, op->x, op->y, SOUND_FIRE_ARROW); 1488 op->play_sound (sound_find ("fire_arrow"));
1685 m->insert (arrow, sx, sy, op); 1489 m->insert (arrow, sx, sy, op);
1686 1490
1687 if (!arrow->destroyed ()) 1491 if (!arrow->destroyed ())
1688 move_arrow (arrow); 1492 move_arrow (arrow);
1689
1690 if (op->type == PLAYER)
1691 {
1692 if (left->destroyed ())
1693 esrv_del_item (op->contr, left->count);
1694 else
1695 esrv_send_item (op, left);
1696 }
1697 1493
1698 return 1; 1494 return 1;
1699} 1495}
1700 1496
1701/* Special fire code for players - this takes into 1497/* Special fire code for players - this takes into
1703 * but monsters can't. Putting that code here 1499 * but monsters can't. Putting that code here
1704 * makes the fire_bow code much cleaner. 1500 * makes the fire_bow code much cleaner.
1705 * this function should only be called if 'op' is a player, 1501 * this function should only be called if 'op' is a player,
1706 * hence the function name. 1502 * hence the function name.
1707 */ 1503 */
1708int 1504static int
1709player_fire_bow (object *op, int dir) 1505player_fire_bow (object *op, int dir)
1710{ 1506{
1711 int ret = 0, wcmod = 0; 1507 int ret;
1712 1508
1713 if (op->contr->bowtype == bow_bestarrow) 1509 if (op->contr->bowtype == bow_bestarrow)
1714 { 1510 {
1715 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranges[range_bow]->race, dir), dir, 0, op->x, op->y); 1511 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1716 } 1512 }
1717 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1513 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1718 { 1514 {
1719 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1515 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1720 wcmod = -1;
1721
1722 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1516 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1723 } 1517 }
1724 else if (op->contr->bowtype == bow_threewide) 1518 else if (op->contr->bowtype == bow_threewide)
1725 { 1519 {
1726 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1520 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1727 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1521 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]);
1728 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1522 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]);
1729 } 1523 }
1730 else if (op->contr->bowtype == bow_spreadshot) 1524 else if (op->contr->bowtype == bow_spreadshot)
1731 { 1525 {
1732 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1526 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1733 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1527 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1734 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1528 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1735
1736 } 1529 }
1737 else 1530 else
1738 { 1531 {
1739 /* Simple case */ 1532 /* Simple case */
1740 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1533 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1741 } 1534 }
1535
1742 return ret; 1536 return ret;
1743} 1537}
1744
1745 1538
1746/* Fires a misc (wand/rod/horn) object in 'dir'. 1539/* Fires a misc (wand/rod/horn) object in 'dir'.
1747 * Broken apart from 'fire' to keep it more readable. 1540 * Broken apart from 'fire' to keep it more readable.
1748 */ 1541 */
1749void 1542static void
1750fire_misc_object (object *op, int dir) 1543fire_misc_object (object *op, int dir)
1751{ 1544{
1752 object *item; 1545 object *item = op->contr->ranged_ob;
1753 1546
1754 if (!op->contr->ranges[range_misc]) 1547 if (!item)
1755 { 1548 {
1756 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied."); 1549 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied.");
1757 return; 1550 return;
1758 } 1551 }
1759 1552
1760 item = op->contr->ranges[range_misc];
1761 if (!item->inv) 1553 if (!item->inv)
1762 { 1554 {
1763 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1555 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1764 return; 1556 return;
1765 } 1557 }
1558
1559 if (!op->apply (item))
1560 return;
1561
1766 if (item->type == WAND) 1562 if (item->type == WAND)
1767 { 1563 {
1768 if (item->stats.food <= 0) 1564 if (item->stats.food <= 0)
1769 { 1565 {
1770 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1566 op->contr->play_sound (sound_find ("wand_poof"));
1771 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0)); 1567 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0));
1568
1772 return; 1569 return;
1773 } 1570 }
1774 } 1571 }
1775 else if (item->type == ROD || item->type == HORN) 1572 else if (item->type == ROD || item->type == HORN)
1776 { 1573 {
1777 if (item->stats.hp < MAX (item->inv->stats.sp, item->inv->stats.grace)) 1574 sint16 spell_sp = max (item->inv->stats.sp, item->inv->stats.grace);
1575
1576 // using the maximum of the rods charge allows at least one spell cast
1577 // for a rod or horn, this fixes some broken rods.
1578 if (item->stats.hp < min (spell_sp, item->stats.maxhp))
1778 { 1579 {
1779 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1580 op->contr->play_sound (sound_find ("wand_poof"));
1581
1780 if (item->type == ROD) 1582 if (item->type == ROD)
1781 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1583 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1782 else 1584 else
1783 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0)); 1585 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0));
1586
1784 return; 1587 return;
1785 } 1588 }
1786 } 1589 }
1787 1590
1788 if (cast_spell (op, item, dir, item->inv, NULL)) 1591 if (cast_spell (op, item, dir, item->inv, NULL))
1789 { 1592 {
1790 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1593 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1594
1791 if (item->type == WAND) 1595 if (item->type == WAND)
1792 { 1596 {
1793 if (!(--item->stats.food)) 1597 if (!(--item->stats.food))
1794 { 1598 {
1795 object *tmp; 1599 object *tmp;
1796 1600
1797 if (item->arch) 1601 if (item->arch)
1798 { 1602 {
1799 CLEAR_FLAG (item, FLAG_ANIMATE); 1603 item->clr_flag (FLAG_ANIMATE);
1800 item->face = item->arch->clone.face; 1604 item->face = item->arch->face;
1801 item->set_speed (0); 1605 item->set_speed (0);
1802 } 1606 }
1803 1607
1804 if ((tmp = item->in_player ())) 1608 if (object *pl = item->visible_to ())
1805 esrv_update_item (UPD_ANIM, tmp, item); 1609 esrv_update_item (UPD_ANIM, pl, item);
1806 } 1610 }
1807 } 1611 }
1808 else if (item->type == ROD || item->type == HORN) 1612 else if (item->type == ROD || item->type == HORN)
1809 drain_rod_charge (item); 1613 drain_rod_charge (item);
1810 } 1614 }
1811} 1615}
1812 1616
1813/* Received a fire command for the player - go and do it. 1617/* Received a fire command for the player - go and do it.
1814 */ 1618 */
1815void 1619bool
1816fire (object *op, int dir) 1620fire (object *who, int dir)
1817{ 1621{
1818 int spellcost = 0; 1622 int spellcost = 0;
1819 1623
1624 player *pl = who->contr;
1625
1626 if (pl->golem)
1627 {
1628 control_golem (who->contr->golem, dir);
1629 return false;
1630 }
1631
1632 object *ob = pl->ranged_ob;
1633
1634 if (!ob)
1635 return false;
1636
1637 if (who->speed_left > 0.f)
1638 --who->speed_left;
1639 else
1640 return false;
1641
1642 if (!who->apply (ob))
1643 return false;
1644
1820 /* check for loss of invisiblity/hide */ 1645 /* check for loss of invisiblity/hide */
1821 if (action_makes_visible (op)) 1646 if (action_makes_visible (who))
1822 make_visible (op); 1647 make_visible (who);
1823 1648
1824 switch (op->contr->shoottype) 1649 switch (ob->type)
1825 { 1650 {
1826 case range_none: 1651 case BOW:
1827 return;
1828
1829 case range_bow:
1830 player_fire_bow (op, dir); 1652 player_fire_bow (who, dir);
1831 return; 1653 break;
1832 1654
1833 case range_magic: /* Casting spells */ 1655 case SPELL:
1834 spellcost = (cast_spell (op, op, dir, op->contr->ranges[range_magic], op->contr->spellparam[0] ? op->contr->spellparam : 0)); 1656 spellcost = cast_spell (who, who, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1835 return; 1657 break;
1836 1658
1837 case range_misc: 1659 case BUILDER:
1838 fire_misc_object (op, dir);
1839 return;
1840
1841 case range_golem: /* Control summoned monsters from scrolls */
1842 if (QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
1843 {
1844 op->contr->ranges[range_golem] = 0;
1845 op->contr->shoottype = range_none;
1846 }
1847 else
1848 control_golem (op->contr->ranges[range_golem], dir);
1849 return;
1850
1851 case range_skill:
1852 if (!op->chosen_skill)
1853 {
1854 if (op->type == PLAYER)
1855 new_draw_info (NDI_UNIQUE, 0, op, "You have no applicable skill to use.");
1856 return;
1857 }
1858
1859 do_skill (op, op, op->chosen_skill, dir, NULL);
1860 return;
1861 case range_builder:
1862 apply_map_builder (op, dir); 1660 apply_map_builder (who, dir);
1863 return; 1661 break;
1662
1663 case SKILL:
1664 do_skill (who, who, ob, dir, 0);
1665 break;
1666
1667 case RANGED:
1668 do_skill (who, ob, who->chosen_skill, dir, 0);
1669 break;
1670
1864 default: 1671 default:
1865 new_draw_info (NDI_UNIQUE, 0, op, "Illegal shoot type."); 1672 fire_misc_object (who, dir);
1866 return; 1673 break;
1867 } 1674 }
1868}
1869 1675
1676 return true;
1677}
1870 1678
1871 1679static object *
1872/* find_key
1873 * We try to find a key for the door as passed. If we find a key
1874 * and successfully use it, we return the key, otherwise NULL
1875 * This function merges both normal and locked door, since the logic
1876 * for both is the same - just the specific key is different.
1877 * pl is the player,
1878 * inv is the objects inventory to searched
1879 * door is the door we are trying to match against.
1880 * This function can be called recursively to search containers.
1881 */
1882
1883object *
1884find_key (object *pl, object *container, object *door) 1680find_key_ (object *pl, object *container, object *door)
1885{ 1681{
1886 object *tmp, *key; 1682 object *tmp, *key;
1887 1683
1888 /* Should not happen, but sanity checking is never bad */ 1684 /* Should not happen, but sanity checking is never bad */
1889 if (container->inv == NULL) 1685 if (!container->inv)
1890 return NULL; 1686 return 0;
1891 1687
1892 /* First, lets try to find a key in the top level inventory */ 1688 /* First, lets try to find a key in the top level inventory */
1893 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1689 for (tmp = container->inv; tmp; tmp = tmp->below)
1894 { 1690 {
1895 if (door->type == DOOR && tmp->type == KEY) 1691 if (door->type == DOOR && tmp->type == KEY)
1896 break; 1692 break;
1693
1897 /* For sanity, we should really check door type, but other stuff 1694 /* For sanity, we should really check door type, but other stuff
1898 * (like containers) can be locked with special keys 1695 * (like containers) can be locked with special keys
1899 */ 1696 */
1900 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1697 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1901 break; 1698 break;
1902 } 1699 }
1700
1903 /* No key found - lets search inventories now */ 1701 /* No key found - lets search inventories now */
1904 /* If we find and use a key in an inventory, return at that time. 1702 /* If we find and use a key in an inventory, return at that time.
1905 * otherwise, if we search all the inventories and still don't find 1703 * otherwise, if we search all the inventories and still don't find
1906 * a key, return 1704 * a key, return
1907 */ 1705 */
1908 if (!tmp) 1706 if (!tmp)
1909 { 1707 {
1910 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1708 for (tmp = container->inv; tmp; tmp = tmp->below)
1911 {
1912 /* No reason to search empty containers */ 1709 /* No reason to search empty containers */
1913 if (tmp->type == CONTAINER && tmp->inv) 1710 if (tmp->type == CONTAINER && tmp->inv)
1914 {
1915 if ((key = find_key (pl, tmp, door)) != NULL) 1711 if ((key = find_key_ (pl, tmp, door)))
1916 return key; 1712 return key;
1917 } 1713
1918 }
1919 if (!tmp) 1714 if (!tmp)
1920 return NULL; 1715 return 0;
1921 } 1716 }
1717
1922 /* We get down here if we have found a key. Now if its in a container, 1718 /* We get down here if we have found a key. Now if its in a container,
1923 * see if we actually want to use it 1719 * see if we actually want to use it
1924 */ 1720 */
1925 if (pl != container) 1721 if (pl != container)
1926 { 1722 {
1927 /* Only let players use keys in containers */ 1723 /* Only let players use keys in containers */
1928 if (!pl->contr) 1724 if (!pl->contr)
1929 return NULL; 1725 return 0;
1726
1930 /* cases where this fails: 1727 /* cases where this fails:
1931 * If we only search the player inventory, return now since we 1728 * If we only search the player inventory, return now since we
1932 * are not in the players inventory. 1729 * are not in the players inventory.
1933 * If the container is not active, return now since only active 1730 * If the container is not active, return now since only active
1934 * containers can be used. 1731 * containers can be used.
1938 * inv must have been an container and must have been active. 1735 * inv must have been an container and must have been active.
1939 * 1736 *
1940 * Change the color so that the message doesn't disappear with 1737 * Change the color so that the message doesn't disappear with
1941 * all the others. 1738 * all the others.
1942 */ 1739 */
1943 if (pl->contr->usekeys == key_inventory || 1740 if (pl->contr->usekeys == key_inventory
1944 !QUERY_FLAG (container, FLAG_APPLIED) || 1741 || !container->flag [FLAG_APPLIED]
1945 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1742 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
1946 { 1743 {
1947 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1744 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1948 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1745 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1949 return NULL; 1746 return NULL;
1950 } 1747 }
1951 } 1748 }
1749
1952 return tmp; 1750 return tmp;
1751}
1752
1753/* find_key
1754 * We try to find a key for the door as passed. If we find a key
1755 * and successfully use it, we return the key, otherwise NULL
1756 * This function merges both normal and locked door, since the logic
1757 * for both is the same - just the specific key is different.
1758 * pl is the player,
1759 * inv is the objects inventory to searched
1760 * door is the door we are trying to match against.
1761 * This function can be called recursively to search containers.
1762 */
1763object *
1764find_key (object *pl, object *container, object *door)
1765{
1766 if (door->slaying && is_match_expr (door->slaying))
1767 {
1768 // for match expressions, we try to find the key by applying the match
1769 // to the op itself, which is supposed to find the "key", instead
1770 // of searching through containers ourselves.
1771
1772 return match_one (door->slaying, container, door, pl, pl);
1773 }
1774 else
1775 return find_key_ (pl, container, door);
1953} 1776}
1954 1777
1955/* moved door processing out of move_player_attack. 1778/* moved door processing out of move_player_attack.
1956 * returns 1 if player has opened the door with a key 1779 * returns 1 if player has opened the door with a key
1957 * such that the caller should not do anything more, 1780 * such that the caller should not do anything more,
1958 * 0 otherwise 1781 * 0 otherwise
1959 */ 1782 */
1960static int 1783static int
1961player_attack_door (object *op, object *door) 1784player_attack_door (object *op, object *door)
1962{ 1785{
1963 /* If its a door, try to find a use a key. If we do destroy the door, 1786 /* If its a door, try to find a key. If we do destroy the door,
1964 * might as well return immediately as there is nothing more to do - 1787 * might as well return immediately as there is nothing more to do -
1965 * otherwise, we fall through to the rest of the code. 1788 * otherwise, we fall through to the rest of the code.
1966 */ 1789 */
1967 object *key = find_key (op, op, door); 1790 object *key = find_key (op, op, door);
1968 1791
1969 /* IF we found a key, do some extra work */ 1792 /* If we found a key, do some extra work */
1970 if (key) 1793 if (key)
1971 { 1794 {
1972 object *container = key->env; 1795 object *container = key->env;
1973 1796
1974 play_sound_map (op->map, op->x, op->y, SOUND_OPEN_DOOR);
1975 if (action_makes_visible (op)) 1797 if (action_makes_visible (op))
1976 make_visible (op); 1798 make_visible (op);
1799
1977 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP)) 1800 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP))
1978 spring_trap (door->inv, op); 1801 spring_trap (door->inv, op);
1802
1979 if (door->type == DOOR) 1803 if (door->type == DOOR)
1980 {
1981 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */ 1804 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */
1982 }
1983 else if (door->type == LOCKED_DOOR) 1805 else if (door->type == LOCKED_DOOR)
1984 { 1806 {
1985 new_draw_info_format (NDI_UNIQUE, NDI_BROWN, op, "You open the door with the %s", query_short_name (key)); 1807 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN);
1986 remove_door2 (door); /* remove door without violence ;-) */ 1808 remove_door2 (door); /* remove door without violence ;-) */
1987 } 1809 }
1810
1988 /* Do this after we print the message */ 1811 /* Do this after we print the message */
1989 decrease_ob (key); /* Use up one of the keys */ 1812 key->decrease (); /* Use up one of the keys */
1990 /* Need to update the weight the container the key was in */ 1813
1991 if (container != op)
1992 esrv_update_item (UPD_WEIGHT, op, container);
1993 return 1; /* Nothing more to do below */ 1814 return 1; /* Nothing more to do below */
1994 } 1815 }
1995 else if (door->type == LOCKED_DOOR) 1816 else if (door->type == LOCKED_DOOR)
1996 { 1817 {
1997 /* Might as well return now - no other way to open this */ 1818 /* Might as well return now - no other way to open this */
1998 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, door->msg); 1819 op->failmsg (door->msg ? &door->msg : "Hmm, you miss the certain something to open this door...");
1999 return 1; 1820 return 1;
2000 } 1821 }
1822
2001 return 0; 1823 return 0;
2002} 1824}
2003 1825
2004/* This function is just part of a breakup from move_player. 1826/* This function is just part of a breakup from move_player.
2005 * It should keep the code cleaner. 1827 * It should keep the code cleaner.
2006 * When this is called, the players direction has been updated 1828 * When this is called, the players direction has been updated
2007 * (taking into account confusion.) The player is also actually 1829 * (taking into account confusion.) The player is also actually
2008 * going to try and move (not fire weapons). 1830 * going to try and move (not fire weapons).
2009 */ 1831 */
2010void 1832bool
2011move_player_attack (object *op, int dir) 1833move_player_attack (object *op, int dir)
2012{ 1834{
2013 object *tmp, *mon; 1835 if (!op->contr->braced && op->speed_left > 0.f && op->move (dir))
2014 sint16 nx, ny; 1836 {
2015 int on_battleground; 1837 --op->speed_left;
2016 maptile *m; 1838 return true;
1839 }
2017 1840
2018 nx = freearr_x[dir] + op->x; 1841 sint16 nx = freearr_x[dir] + op->x;
2019 ny = freearr_y[dir] + op->y; 1842 sint16 ny = freearr_y[dir] + op->y;
2020 1843
2021 on_battleground = op_on_battleground (op, 0, 0); 1844 if (out_of_map (op->map, nx, ny))
1845 return false;
2022 1846
2023 /* If braced, or can't move to the square, and it is not out of the 1847 /* If braced, or can't move to the square, and it is not out of the
2024 * map, attack it. Note order of if statement is important - don't 1848 * map, attack it. Note order of if statement is important - don't
2025 * want to be calling move_ob if braced, because move_ob will move the 1849 * want to be calling move_ob if braced, because move_ob will move the
2026 * player. This is a pretty nasty hack, because if we could 1850 * player. This is a pretty nasty hack, because if we could
2027 * move to some space, it then means that if we are braced, we should 1851 * move to some space, it then means that if we are braced, we should
2028 * do nothing at all. As it is, if we are braced, we go through 1852 * do nothing at all. As it is, if we are braced, we go through
2029 * quite a bit of processing. However, it probably is less than what 1853 * quite a bit of processing. However, it probably is less than what
2030 * move_ob uses. 1854 * move_ob uses.
2031 */ 1855 */
2032 if ((op->contr->braced || !move_ob (op, dir, op)) && !out_of_map (op->map, nx, ny)) 1856 maptile *m = op->map->xy_find (nx, ny);
1857
1858 /* Go through all the objects, and find ones of interest. Only stop if
1859 * we find a monster - that is something we know we want to attack.
1860 * if its a door or barrel (can roll) see if there may be monsters
1861 * on the space
1862 */
1863 object *mon;
1864 for (mon = m->at (nx, ny).bot; mon; mon = mon->above)
1865 {
1866 if ((mon->flag [FLAG_ALIVE]
1867 || mon->type == LOCKED_DOOR
1868 || mon->flag [FLAG_CAN_ROLL])
1869 && mon != op)
1870 break;
2033 { 1871 }
2034 if (OUT_OF_REAL_MAP (op->map, nx, ny)) 1872
1873 if (!mon) /* This happens anytime the player tries to move */
1874 return false; /* into a wall */
1875
1876 mon = mon->head_ ();
1877
1878 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
1879 if (op->contr->weapon_sp_left > 0.f)
1880 if (player_attack_door (op, mon))
1881 {
1882 --op->contr->weapon_sp_left;
1883 return true;
2035 { 1884 }
2036 m = op->map->xy_find (nx, ny); 1885
2037 if (!m) 1886 /* The following deals with possibly attacking peaceful
2038 return; /* Don't think this should happen */ 1887 * or friendly creatures. Basically, all players are considered
1888 * unaggressive. If the moving player has peaceful set, then the
1889 * object should be pushed instead of attacked. It is assumed that
1890 * if you are braced, you will not attack friends accidently,
1891 * and thus will not push them.
1892 */
1893
1894 /* If the creature is a pet, push it even if the player is not
1895 * peaceful. Our assumption is the creature is a pet if the
1896 * player owns it and it is either friendly or unagressive.
1897 */
1898 if (op->type == PLAYER
1899 && ((mon->owner && mon->owner->contr
1900 && same_party (mon->owner->contr->party, op->contr->party))
1901 || mon->owner == op)
1902 && (mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY]))
1903 {
1904 /* If we're braced, we don't want to switch places with it */
1905 if (op->contr->braced)
1906 return false;
1907
1908 if (op->speed_left > 0.f)
1909 {
1910 --op->speed_left;
1911
1912 op->play_sound (sound_find ("push_player"));
1913 push_ob (mon, dir, op);
1914
1915 if (action_makes_visible (op))
1916 make_visible (op);
1917
1918 return true;
2039 } 1919 }
2040 else 1920 else
2041 m = op->map;
2042
2043 if (!(tmp = m->at (nx, ny).bot))
2044 return; 1921 return false;
1922 }
2045 1923
2046 mon = 0; 1924 bool on_battleground = op_on_battleground (op, 0, 0);
2047 /* Go through all the objects, and find ones of interest. Only stop if
2048 * we find a monster - that is something we know we want to attack.
2049 * if its a door or barrel (can roll) see if there may be monsters
2050 * on the space
2051 */
2052 while (tmp)
2053 {
2054 if (tmp == op)
2055 {
2056 tmp = tmp->above;
2057 continue;
2058 }
2059 1925
2060 if (QUERY_FLAG (tmp, FLAG_ALIVE))
2061 {
2062 mon = tmp;
2063 break;
2064 }
2065
2066 if (tmp->type == LOCKED_DOOR || QUERY_FLAG (tmp, FLAG_CAN_ROLL))
2067 mon = tmp;
2068
2069 tmp = tmp->above;
2070 }
2071
2072 if (!mon) /* This happens anytime the player tries to move */
2073 return; /* into a wall */
2074
2075 if (mon->head)
2076 mon = mon->head;
2077
2078 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2079 if (player_attack_door (op, mon))
2080 return;
2081
2082 /* The following deals with possibly attacking peaceful
2083 * or frienddly creatures. Basically, all players are considered
2084 * unaggressive. If the moving player has peaceful set, then the
2085 * object should be pushed instead of attacked. It is assumed that
2086 * if you are braced, you will not attack friends accidently,
2087 * and thus will not push them.
2088 */
2089
2090 /* If the creature is a pet, push it even if the player is not
2091 * peaceful. Our assumption is the creature is a pet if the
2092 * player owns it and it is either friendly or unagressive.
2093 */
2094 if ((op->type == PLAYER)
2095#if COZY_SERVER
2096 &&
2097 ((mon->owner && mon->owner->contr
2098 && same_party (mon->owner->contr->party, op->contr->party)) || mon->owner == op)
2099#else
2100 && mon->owner == op
2101#endif
2102 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
2103 {
2104 /* If we're braced, we don't want to switch places with it */
2105 if (op->contr->braced)
2106 return;
2107
2108 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER);
2109 (void) push_ob (mon, dir, op);
2110 if (op->contr->tmp_invis || op->hide)
2111 make_visible (op);
2112
2113 return;
2114 }
2115
2116 /* in certain circumstances, you shouldn't attack friendly 1926 /* in certain circumstances, you shouldn't attack friendly
2117 * creatures. Note that if you are braced, you can't push 1927 * creatures. Note that if you are braced, you can't push
2118 * someone, but put it inside this loop so that you won't 1928 * someone, but put it inside this loop so that you won't
2119 * attack them either. 1929 * attack them either.
2120 */ 1930 */
2121 if ((mon->type == PLAYER || mon->enemy != op) && 1931 if ((mon->type == PLAYER || mon->enemy != op)
2122 (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) && ( 1932 && (mon->type == PLAYER || mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY])
2123#ifdef PROHIBIT_PLAYERKILL
2124 (op->contr->peaceful 1933 && ((op->contr->peaceful
2125 || (mon->type == PLAYER 1934 || (mon->type == PLAYER && mon->contr->peaceful))
2126 && mon->contr->
2127 peaceful)) &&
2128#else
2129 op->contr->peaceful &&
2130#endif
2131 !on_battleground)) 1935 && !on_battleground))
1936 {
1937 if (op->speed_left > 0.f)
2132 { 1938 {
1939 --op->speed_left;
1940
2133 if (!op->contr->braced) 1941 if (!op->contr->braced)
2134 { 1942 {
2135 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER); 1943 op->play_sound (sound_find ("push_player"));
2136 push_ob (mon, dir, op); 1944 push_ob (mon, dir, op);
2137 } 1945 }
2138 else 1946 else
2139 new_draw_info (0, 0, op, "You withhold your attack"); 1947 op->statusmsg ("You withhold your attack");
2140 1948
2141 if (op->contr->tmp_invis || op->hide) 1949 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN])
2142 make_visible (op); 1950 make_visible (op);
2143 }
2144 1951
1952 return true;
1953 }
1954 }
2145 /* If the object is a boulder or other rollable object, then 1955 /* If the object is a boulder or other rollable object, then
2146 * roll it if not braced. You can't roll it if you are braced. 1956 * roll it if not braced. You can't roll it if you are braced.
2147 */ 1957 */
2148 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 1958 else if (mon->flag [FLAG_CAN_ROLL] && (!op->contr->braced))
1959 {
1960 if (op->speed_left > 0.f)
2149 { 1961 {
1962 --op->speed_left;
1963
2150 recursive_roll (mon, dir, op); 1964 recursive_roll (mon, dir, op);
2151 if (action_makes_visible (op)) 1965 if (action_makes_visible (op))
2152 make_visible (op); 1966 make_visible (op);
2153 }
2154 1967
1968 return true;
1969 }
1970 }
2155 /* Any generic living creature. Including things like doors. 1971 /* Any generic living creature. Including things like doors.
2156 * Way it works is like this: First, it must have some hit points 1972 * Way it works is like this: First, it must have some hit points
2157 * and be living. Then, it must be one of the following: 1973 * and be living. Then, it must be one of the following:
2158 * 1) Not a player, 2) A player, but of a different party. Note 1974 * 1) Not a player, 2) A player, but of a different party. Note
2159 * that party_number -1 is no party, so attacks can still happen. 1975 * that party_number -1 is no party, so attacks can still happen.
2160 */ 1976 */
2161 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 1977 else if ((mon->stats.hp >= 0) && mon->flag [FLAG_ALIVE] &&
2162 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 1978 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2163 { 1979 {
2164 1980 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2165 /* If the player hasn't hit something this tick, and does
2166 * so, give them speed boost based on weapon speed. Doing
2167 * it here is better than process_players2, which basically
2168 * incurred a 1 tick offset.
2169 */
2170 if (!op->contr->has_hit)
2171 { 1981 {
2172 op->speed_left += op->speed / op->contr->weapon_sp; 1982 --op->contr->weapon_sp_left;
2173
2174 op->contr->has_hit = 1; /* The last action was to hit, so use weapon_sp */
2175 }
2176 1983
2177 skill_attack (mon, op, 0, 0, 0); 1984 skill_attack (mon, op, 0, 0, 0);
2178
2179 /* If attacking another player, that player gets automatic
2180 * hitback, and doesn't loose luck either.
2181 * Disable hitback on the battleground or if the target is
2182 * the wiz.
2183 */
2184 if (mon->type == PLAYER && mon->stats.hp >= 0 && !mon->contr->has_hit && !on_battleground && !QUERY_FLAG (mon, FLAG_WIZ))
2185 {
2186 short luck = mon->stats.luck;
2187
2188 mon->contr->has_hit = 1;
2189 skill_attack (op, mon, 0, 0, 0);
2190 mon->stats.luck = luck;
2191 }
2192 1985
2193 if (action_makes_visible (op)) 1986 if (action_makes_visible (op))
2194 make_visible (op); 1987 make_visible (op);
2195 }
2196 } /* if player should attack something */
2197}
2198 1988
2199int 1989 return true;
1990 }
1991 }
1992
1993 return false;
1994}
1995
1996bool
2200move_player (object *op, int dir) 1997move_player (object *op, int dir)
2201{ 1998{
2202 int pick;
2203
2204 if (!op->map || op->map->in_memory != MAP_IN_MEMORY) 1999 if (!op->map || op->map->in_memory != MAP_ACTIVE)
2205 return 0; 2000 return 0;
2206 2001
2207 /* Sanity check: make sure dir is valid */ 2002 /* Sanity check: make sure dir is valid */
2208 if ((dir < 0) || (dir >= 9)) 2003 if (dir < 0 || dir > 8)
2209 { 2004 {
2210 LOG (llevError, "move_player: invalid direction %d\n", dir); 2005 LOG (llevError, "move_player: invalid direction %d\n", dir);
2211 return 0; 2006 return 0;
2212 } 2007 }
2213 2008
2214 /* peterm: added following line */ 2009 /* peterm: added following line */
2215 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2010 if (op->flag [FLAG_CONFUSED] && dir)
2216 dir = absdir (dir + rndm (3) + rndm (3) - 2); 2011 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2217 2012
2218 op->facing = dir; 2013 op->facing = dir;
2219 2014
2220 if (op->hide) 2015 if (op->flag [FLAG_HIDDEN])
2221 do_hidden_move (op); 2016 do_hidden_move (op);
2222 2017
2018 bool retval;
2019 int pick = 0;
2020
2223 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2021 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2224 /*nop */ ; 2022 retval = RESULT_INT (0);
2225 else if (op->contr->fire_on) 2023 else if (op->contr->fire_on)
2226 fire (op, dir); 2024 retval = fire (op, dir);
2227 else 2025 else
2228 { 2026 {
2229 move_player_attack (op, dir); 2027 retval = move_player_attack (op, dir);
2230 pick = check_pick (op); 2028 pick = check_pick (op);
2231 } 2029 }
2232 2030
2233 /* Add special check for newcs players and fire on - this way, the 2031 /* Add special check for newcs players and fire on - this way, the
2234 * server can handle repeat firing. 2032 * server can handle repeat firing.
2241 /* Update how the player looks. Use the facing, so direction may 2039 /* Update how the player looks. Use the facing, so direction may
2242 * get reset to zero. This allows for full animation capabilities 2040 * get reset to zero. This allows for full animation capabilities
2243 * for players. 2041 * for players.
2244 */ 2042 */
2245 animate_object (op, op->facing); 2043 animate_object (op, op->facing);
2246 return 0; 2044
2045 return retval;
2247} 2046}
2248 2047
2249/* This is similar to handle_player, below, but is only used by the 2048/* This is similar to handle_player, below, but is only used by the
2250 * new client/server stuff. 2049 * new client/server stuff.
2251 * This is sort of special, in that the new client/server actually uses 2050 * This is sort of special, in that the new client/server actually uses
2252 * the new speed values for commands. 2051 * the new speed values for commands.
2253 * 2052 *
2254 * Returns true if there are more actions we can do. 2053 * Returns true if there are more actions we can do. Should not do
2054 * many actions in a row, as that would be too unfair to other
2055 * players.
2255 */ 2056 */
2256int 2057bool
2257handle_newcs_player (object *op) 2058handle_newcs_player (object *op)
2258{ 2059{
2259 if (op->contr->hidden) 2060 if (op->flag [FLAG_SCARED])
2260 {
2261 op->invisible = 1000;
2262 /* the socket code flashes the player visible/invisible
2263 * depending on the value of invisible, so we need to
2264 * alternate it here for it to work correctly.
2265 */
2266 if (pticks & 2)
2267 op->invisible--;
2268 } 2061 {
2269 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS))) 2062 if (op->speed_left > 0.f)
2270 {
2271 op->invisible--;
2272 if (!op->invisible)
2273 {
2274 make_visible (op);
2275 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2276 } 2063 {
2277 }
2278
2279 if (QUERY_FLAG (op, FLAG_SCARED))
2280 {
2281 flee_player (op);
2282 /* If player is still scared, that is his action for this tick */
2283 if (QUERY_FLAG (op, FLAG_SCARED))
2284 {
2285 op->speed_left--; 2064 --op->speed_left;
2065 flee_player (op);
2066
2286 return 0; 2067 return true;
2287 } 2068 }
2069 else
2070 return false;
2288 } 2071 }
2289
2290 /* I've been seeing crashes where the golem has been destroyed, but
2291 * the player object still points to the defunct golem. The code that
2292 * destroys the golem looks correct, and it doesn't always happen, so
2293 * put this in a a workaround to clean up the golem pointer.
2294 */
2295 if (op->contr->ranges[range_golem] && QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
2296 op->contr->ranges[range_golem] = 0;
2297 2072
2298 /* call this here - we also will call this in do_ericserver, but 2073 /* call this here - we also will call this in do_ericserver, but
2299 * the players time has been increased when doericserver has been 2074 * the players time has been increased when doericserver has been
2300 * called, so we recheck it here. 2075 * called, so we recheck it here.
2301 */ 2076 */
2302 if (op->contr->ns->handle_command ()) 2077 if (op->contr->ns->handle_command ())
2303 return 1; 2078 return true;
2304 2079
2305 if (op->speed_left > 0)
2306 {
2307 if (op->direction && (op->contr->run_on || op->contr->fire_on)) 2080 if (op->direction && (op->contr->run_on || op->contr->fire_on))
2308 {
2309 /* All move commands take 1 tick, at least for now */
2310 op->speed_left--;
2311
2312 /* Instead of all the stuff below, let move_player take care
2313 * of it. Also, some of the skill stuff is only put in
2314 * there, as well as the confusion stuff.
2315 */
2316 move_player (op, op->direction); 2081 return move_player (op, op->direction);
2317 2082
2318 return op->speed_left > 0;
2319 }
2320 }
2321
2322 return 0; 2083 return false;
2323} 2084}
2324 2085
2325int 2086static int
2326save_life (object *op) 2087save_life (object *op)
2327{ 2088{
2328 if (!QUERY_FLAG (op, FLAG_LIFESAVE)) 2089 if (!op->flag [FLAG_LIFESAVE])
2329 return 0; 2090 return 0;
2330 2091
2331 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2092 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2332 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2093 if (tmp->flag [FLAG_APPLIED] && tmp->flag [FLAG_LIFESAVE])
2333 { 2094 {
2334 play_sound_map (op->map, op->x, op->y, SOUND_OB_EVAPORATE); 2095 op->play_sound (sound_find ("ob_evaporate"));
2335 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2096 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2336 2097
2337 if (op->contr)
2338 esrv_del_item (op->contr, tmp->count);
2339
2340 tmp->destroy (); 2098 tmp->destroy ();
2341 CLEAR_FLAG (op, FLAG_LIFESAVE); 2099 op->clr_flag (FLAG_LIFESAVE);
2342 2100
2343 if (op->stats.hp < 0) 2101 if (op->stats.hp < 0)
2344 op->stats.hp = op->stats.maxhp; 2102 op->stats.hp = op->stats.maxhp;
2345 2103
2346 if (op->stats.food < 0) 2104 if (op->stats.food < 0)
2347 op->stats.food = 999; 2105 op->stats.food = MAX_FOOD;
2348 2106
2349 op->update_stats (); 2107 op->update_stats ();
2350 return 1; 2108 return 1;
2351 } 2109 }
2352 2110
2353 LOG (llevError, "Error: LIFESAVE set without applied object.\n"); 2111 LOG (llevError, "Error: LIFESAVE set without applied object.\n");
2354 CLEAR_FLAG (op, FLAG_LIFESAVE); 2112 op->clr_flag (FLAG_LIFESAVE);
2355 enter_player_savebed (op); /* bring him home. */ 2113 enter_player_savebed (op); /* bring him home. */
2356 return 0; 2114 return 0;
2357} 2115}
2358 2116
2359/* This goes throws the inventory and removes unpaid objects, and puts them 2117/* This goes throws the inventory and removes unpaid objects, and puts them
2360 * back in the map (location and map determined by values of env). This 2118 * back in the map (location and map determined by values of env). This
2361 * function will descend into containers. op is the object to start the search 2119 * function will descend into containers. op is the object to start the search
2362 * from. 2120 * from.
2363 */ 2121 */
2122static void
2123drop_unpaid_items (object *op, object *env)
2124{
2125 while (op)
2126 {
2127 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2128
2129 if (op->flag [FLAG_UNPAID])
2130 op->insert_at (env);
2131 else if (op->inv)
2132 drop_unpaid_items (op->inv, env);
2133
2134 op = next;
2135 }
2136}
2137
2364void 2138void
2365remove_unpaid_objects (object *op, object *env) 2139object::drop_unpaid_items ()
2366{ 2140{
2367 object *next; 2141 if (!flag [FLAG_REMOVED])
2368 2142 ::drop_unpaid_items (inv, this);
2369 while (op)
2370 {
2371 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2372
2373 if (QUERY_FLAG (op, FLAG_UNPAID))
2374 {
2375 if (env->type == PLAYER)
2376 esrv_del_item (env->contr, op->count);
2377
2378 op->insert_at (env);
2379 }
2380 else if (op->inv)
2381 remove_unpaid_objects (op->inv, env);
2382
2383 op = next;
2384 }
2385}
2386
2387/*
2388 * Returns pointer a static string containing gravestone text
2389 * Moved from apply.c to player.c - player.c is what
2390 * actually uses this function. player.c may not be quite the
2391 * best, a misc file for object actions is probably better,
2392 * but there isn't one in the server directory.
2393 */
2394char *
2395gravestone_text (object *op)
2396{
2397 static char buf2[MAX_BUF];
2398 char buf[MAX_BUF];
2399 time_t now = time (NULL);
2400
2401 strcpy (buf2, " R.I.P.\n\n");
2402 if (op->type == PLAYER)
2403 sprintf (buf, "%s the %s\n", &op->name, op->contr->title);
2404 else
2405 sprintf (buf, "%s\n", &op->name);
2406
2407 strncat (buf2, " ", 20 - strlen (buf) / 2);
2408 strcat (buf2, buf);
2409 if (op->type == PLAYER)
2410 sprintf (buf, "who was in level %d when killed\n", op->level);
2411 else
2412 sprintf (buf, "who was in level %d when died.\n\n", op->level);
2413
2414 strncat (buf2, " ", 20 - strlen (buf) / 2);
2415 strcat (buf2, buf);
2416 if (op->type == PLAYER)
2417 {
2418 sprintf (buf, "by %s.\n\n", op->contr->killer);
2419 strncat (buf2, " ", 21 - strlen (buf) / 2);
2420 strcat (buf2, buf);
2421 }
2422
2423 strftime (buf, MAX_BUF, "%b %d %Y\n", localtime (&now));
2424 strncat (buf2, " ", 20 - strlen (buf) / 2);
2425 strcat (buf2, buf);
2426
2427 return buf2;
2428} 2143}
2429 2144
2430void 2145void
2431do_some_living (object *op) 2146do_some_living (object *op)
2432{ 2147{
2439 int rate_grace = 2000; 2154 int rate_grace = 2000;
2440 const int max_hp = 1; 2155 const int max_hp = 1;
2441 const int max_sp = 1; 2156 const int max_sp = 1;
2442 const int max_grace = 1; 2157 const int max_grace = 1;
2443 2158
2444 if (op->contr->outputs_sync) 2159 if (op->contr->hidden)
2160 {
2161 op->invisible = 1000;
2162 /* the socket code flashes the player visible/invisible
2163 * depending on the value of invisible, so we need to
2164 * alternate it here for it to work correctly.
2165 */
2166 if (pticks & 2)
2167 op->invisible--;
2445 { 2168 }
2446 for (i = 0; i < NUM_OUTPUT_BUFS; i++) 2169 else if (op->invisible && !(op->flag [FLAG_MAKE_INVIS]))
2447 if (op->contr->outputs[i].buf && (op->contr->outputs[i].first_update + op->contr->outputs_sync) < (uint16) pticks) 2170 {
2448 flush_output_element (op, &op->contr->outputs[i]); 2171 if (!op->invisible--)
2172 {
2173 make_visible (op);
2174 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2175 }
2449 } 2176 }
2450 2177
2451 if (op->contr->ns->state == ST_PLAYING) 2178 if (op->contr->ns->state == ST_PLAYING)
2452 { 2179 {
2453 /* these next three if clauses make it possible to SLOW DOWN 2180 /* these next three if clauses make it possible to SLOW DOWN
2472 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace; 2199 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace;
2473 else 2200 else
2474 { 2201 {
2475 gen_grace = op->stats.maxgrace; 2202 gen_grace = op->stats.maxgrace;
2476 rate_grace -= rate_grace / 2 * op->contr->gen_grace; 2203 rate_grace -= rate_grace / 2 * op->contr->gen_grace;
2477 }
2478
2479 /* Regenerate Spell Points */
2480 if (op->contr->ranges[range_golem] == NULL && --op->last_sp < 0)
2481 {
2482 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2483 if (op->stats.sp < op->stats.maxsp)
2484 {
2485 op->stats.sp++;
2486 /* dms do not consume food */
2487 if (!QUERY_FLAG (op, FLAG_WIZ))
2488 {
2489 op->stats.food--;
2490 if (op->contr->digestion < 0)
2491 op->stats.food += op->contr->digestion;
2492 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2493 op->stats.food = last_food;
2494 }
2495 }
2496
2497 if (max_sp > 1)
2498 {
2499 over_sp = (gen_sp + 10) / rate_sp;
2500 if (over_sp > 0)
2501 {
2502 if (op->stats.sp < op->stats.maxsp)
2503 {
2504 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2505
2506 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2507 op->stats.sp--;
2508
2509 if (op->stats.sp > op->stats.maxsp)
2510 op->stats.sp = op->stats.maxsp;
2511 }
2512 op->last_sp = 0;
2513 }
2514 else
2515 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2516 }
2517 else
2518 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2519 } 2204 }
2520 2205
2521 /* Regenerate Grace */ 2206 /* Regenerate Grace */
2522 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */ 2207 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */
2523 if (--op->last_grace < 0) 2208 if (--op->last_grace < 0)
2544 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2229 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2545 } 2230 }
2546 /* wearing stuff doesn't detract from grace generation. */ 2231 /* wearing stuff doesn't detract from grace generation. */
2547 } 2232 }
2548 2233
2234 if (op->stats.food > 0)
2235 {
2549 /* Regenerate Hit Points */ 2236 /* Regenerate Spell Points */
2550 if (--op->last_heal < 0) 2237 if (!op->contr->golem && --op->last_sp < 0)
2551 {
2552 if (op->stats.hp < op->stats.maxhp)
2553 { 2238 {
2554 op->stats.hp++; 2239 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2555 /* dms do not consume food */ 2240
2556 if (!QUERY_FLAG (op, FLAG_WIZ)) 2241 if (op->stats.sp < op->stats.maxsp)
2557 { 2242 {
2243 op->stats.sp++;
2244
2245 /* dms do not consume food */
2246 if (!op->flag [FLAG_WIZ])
2247 {
2558 op->stats.food--; 2248 op->stats.food--;
2249
2559 if (op->contr->digestion < 0) 2250 if (op->contr->digestion < 0)
2560 op->stats.food += op->contr->digestion; 2251 op->stats.food += op->contr->digestion;
2561 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2252 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2562 op->stats.food = last_food; 2253 op->stats.food = last_food;
2254 }
2563 } 2255 }
2564 }
2565 2256
2566 if (max_hp > 1) 2257 if (max_sp > 1)
2567 {
2568 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2569 if (over_hp > 0)
2570 { 2258 {
2571 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2259 over_sp = (gen_sp + 10) / rate_sp;
2260 if (over_sp > 0)
2261 {
2262 if (op->stats.sp < op->stats.maxsp)
2263 {
2264 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2265
2266 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2267 op->stats.sp--;
2268
2269 if (op->stats.sp > op->stats.maxsp)
2270 op->stats.sp = op->stats.maxsp;
2271 }
2272
2572 op->last_heal = 0; 2273 op->last_sp = 0;
2274 }
2275 else
2276 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2573 } 2277 }
2574 else 2278 else
2279 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2280 }
2281
2282 /* Regenerate Hit Points */
2283 if (--op->last_heal < 0)
2284 {
2285 if (op->stats.hp < op->stats.maxhp)
2575 { 2286 {
2576 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2287 op->stats.hp++;
2288
2289 /* dms do not consume food */
2290 if (!op->flag [FLAG_WIZ])
2291 {
2292 op->stats.food--;
2293
2294 if (op->contr->digestion < 0)
2295 op->stats.food += op->contr->digestion;
2296 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2297 op->stats.food = last_food;
2298 }
2577 } 2299 }
2300
2301 if (max_hp > 1)
2302 {
2303 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2304
2305 if (over_hp > 0)
2306 {
2307 op->stats.sp += over_hp + (rndm (rate_hp) > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0;
2308 op->last_heal = 0;
2309 }
2310 else
2311 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2578 } 2312 }
2579 else 2313 else
2580 {
2581 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2314 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2582 } 2315 }
2583 } 2316 }
2584 2317
2585 /* Digestion */ 2318 /* Digestion */
2586 if (--op->last_eat < 0) 2319 if (--op->last_eat < 0)
2587 { 2320 {
2588#ifdef COZY_SERVER 2321 int bonus = max (0, op->contr->digestion),
2589 int dg = op->contr->digestion >= 0 && op->contr->digestion < 2 ? 2 : op->contr->digestion; 2322 penalty = max (0, -op->contr->digestion);
2590 int bonus = dg > 0 ? dg : 0, penalty = dg < 0 ? -dg : 0;
2591#else
2592 int bonus = op->contr->digestion > 0 ? op->contr->digestion : 0, penalty = op->contr->digestion < 0 ? -op->contr->digestion : 0;
2593#endif
2594 2323
2595 if (op->contr->gen_hp > 0)
2596 op->last_eat = 25 * (1 + bonus) / (op->contr->gen_hp + penalty + 1); 2324 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2597 else
2598 op->last_eat = 25 * (1 + bonus) / (penalty + 1);
2599 2325
2600 /* dms do not consume food */ 2326 /* dms do not consume food */
2601 if (!QUERY_FLAG (op, FLAG_WIZ)) 2327 if (!op->flag [FLAG_WIZ])
2602 op->stats.food--; 2328 op->stats.food--;
2603 } 2329 }
2604 2330
2605 if (op->stats.food < 0 && op->stats.hp >= 0) 2331 if (op->stats.food < 0 && op->stats.hp >= 0)
2606 { 2332 {
2607 object *tmp, *flesh = 0; 2333 object *flesh = 0;
2608 2334
2609 for (tmp = op->inv; tmp; tmp = tmp->below) 2335 for_inv_removable (op, tmp)
2610 { 2336 {
2611 if (!QUERY_FLAG (tmp, FLAG_UNPAID)) 2337 if (tmp->flag [FLAG_UNPAID])
2338 continue;
2339
2340 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2612 { 2341 {
2613 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2342 op->statusmsg ("You blindly grab for a bite of food. "
2614 { 2343 "H<To prevent you from starving, you ate some random item from your backpack.>");
2615 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2344 op->apply (tmp);
2616 manual_apply (op, tmp, 0); 2345
2617 if (op->stats.food >= 0 || op->stats.hp < 0) 2346 if (op->stats.food >= 0 || op->stats.hp < 0)
2618 break; 2347 break;
2619 } 2348 }
2620 else if (tmp->type == FLESH) 2349 else if (tmp->type == FLESH)
2621 flesh = tmp; 2350 flesh = tmp;
2622 } /* End if paid for object */ 2351 }
2623 } /* end of for loop */
2624 2352
2625 /* If player is still starving, it means they don't have any food, so 2353 /* If player is still starving, it means they don't have any food, so
2626 * eat flesh instead. 2354 * eat flesh instead.
2627 */ 2355 */
2628 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2356 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2629 { 2357 {
2630 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2358 op->statusmsg ("You blindly grab for a bite of food. "
2359 "H<To prevent you from starving, you ate some random item from your backpack.>");
2631 manual_apply (op, flesh, 0); 2360 op->apply (flesh);
2632 } 2361 }
2362
2363 // If player is still starving, alert him!
2364 if (op->stats.food < 0)
2365 op->failmsg ("You are starving! "
2366 "H<Eat some food to increase your food and prevent you from an untimely death.>");
2367 }
2368
2369 if (op->stats.food < 0)
2633 } 2370 {
2371 op->stats.hp += op->stats.food;
2372 op->stats.food = 0;
2634 2373
2635 while (op->stats.food < 0 && op->stats.hp >= 0) 2374 if (op->stats.hp < 0)
2636 op->stats.food++, op->stats.hp--; 2375 {
2376 op->contr->killer = archetype::get ("killer_starvation");
2377 op->contr->killer->destroy ();
2378 }
2379 }
2637 2380
2381 /* killer should be set here already */
2638 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2382 if (op->stats.hp < 0 && !op->flag [FLAG_WIZ])
2639 kill_player (op); 2383 kill_player (op);
2640 } 2384 }
2641} 2385}
2642 2386
2643/* If the player should die (lack of hp, food, etc), we call this. 2387/* If the player should die (lack of hp, food, etc), we call this.
2646 * file. 2390 * file.
2647 */ 2391 */
2648void 2392void
2649kill_player (object *op) 2393kill_player (object *op)
2650{ 2394{
2651 char buf[MAX_BUF];
2652 int x, y; 2395 int x, y;
2653
2654 //int i;
2655 maptile *map; /* this is for resurrection */ 2396 maptile *map; /* this is for resurrection */
2656
2657 /* int z;
2658 int num_stats_lose;
2659 int lost_a_stat;
2660 int lose_this_stat;
2661 int this_stat; */
2662 int will_kill_again; 2397 int will_kill_again;
2663 archetype *at; 2398 archetype *at;
2664 object *tmp; 2399 object *tmp;
2665 2400
2666 if (save_life (op)) 2401 if (save_life (op))
2667 return; 2402 return;
2668 2403
2404 dynbuf_text deathtab;
2405
2406 /* restore player */
2407 at = archetype::find (shstr_poisoning);
2408 if (object *tmp = present_arch_in_ob (at, op))
2409 {
2410 tmp->destroy ();
2411 deathtab << "Your body feels cleansed...\r";
2412 }
2413
2414 at = archetype::find (shstr_confusion);
2415 if (object *tmp = present_arch_in_ob (at, op))
2416 {
2417 tmp->destroy ();
2418 deathtab << "Your mind feels clearer...\r";
2419 }
2420
2421 cure_disease (op, 0, 0); /* remove any disease */
2422
2423 max_it (op->stats.hp , op->stats.maxhp);
2424 max_it (op->stats.sp , op->stats.maxsp);
2425 max_it (op->stats.grace, op->stats.maxgrace);
2426 max_it (op->stats.food , 200);
2427
2428 // remove all spell effects that are active
2429 // to avoid long-term effects such as word-of-recall
2430 for (object *item = op->inv; item; )
2431 {
2432 object *next = item->below;
2433
2434 if (item->type == SPELL_EFFECT && item->active)
2435 item->destroy ();
2436
2437 item = next;
2438 }
2669 2439
2670 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2440 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2671 * in cities ONLY!!! It is very important that this doesn't get abused. 2441 * in cities ONLY!!! It is very important that this doesn't get abused.
2672 * Look at op_on_battleground() for more info --AndreasV 2442 * Look at op_on_battleground() for more info --AndreasV
2673 */ 2443 */
2674 if (op_on_battleground (op, &x, &y)) 2444 if (op_on_battleground (op, &x, &y))
2675 { 2445 {
2676 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2446 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2677 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2678
2679 /* restore player */
2680 at = archetype::find ("poisoning");
2681 if (object *tmp = present_arch_in_ob (at, op))
2682 {
2683 tmp->destroy ();
2684 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2685 }
2686
2687 at = archetype::find ("confusion");
2688 if (object *tmp = present_arch_in_ob (at, op))
2689 {
2690 tmp->destroy ();
2691 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2692 }
2693
2694 cure_disease (op, 0); /* remove any disease */
2695 op->stats.hp = op->stats.maxhp;
2696 if (op->stats.food <= 0)
2697 op->stats.food = 999;
2698 2447
2699 /* create a bodypart-trophy to make the winner happy */ 2448 /* create a bodypart-trophy to make the winner happy */
2700 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2449 object *tmp = archetype::find (shstr_finger)->instance ();
2701 { 2450
2702 sprintf (buf, "%s's finger", &op->name); 2451 tmp->name = format ("%s's finger" , &op->name);
2703 tmp->name = buf; 2452 tmp->name_pl = format ("%s's fingers", &op->name);
2704 sprintf (buf, " This finger has been cut off %s\n" 2453 tmp->msg = format (
2705 " the %s, when he was defeated at\n level %d by %s.\n", 2454 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2706 &op->name, op->contr->title, (int) (op->level), op->contr->killer); 2455 &op->name, op->contr->title,
2707 tmp->msg = buf; 2456 (int)op->level,
2457 op->contr->killer_name ()
2458 );
2708 tmp->value = 0, tmp->material = 0, tmp->type = 0; 2459 tmp->value = 0, tmp->type = 0;
2709 tmp->materialname = NULL; 2460 tmp->material = name_to_material (shstr_organic);
2710 tmp->insert_at (op, tmp); 2461 tmp->insert_at (op, tmp);
2711 }
2712 2462
2713 /* teleport defeated player to new destination */ 2463 /* teleport defeated player to new destination */
2714 transfer_ob (op, x, y, 0, NULL); 2464 transfer_ob (op, x, y, 0, NULL);
2715 op->contr->braced = 0; 2465 op->contr->braced = 0;
2466
2467 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2716 return; 2468 return;
2717 } 2469 }
2718 2470
2471 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2472 deathtab << "T<YOU HAVE DIED>\n\n";
2473
2719 INVOKE_PLAYER (DEATH, op->contr); 2474 INVOKE_PLAYER (DEATH, op->contr);
2720 2475
2721 command_kill_pets (op, 0); 2476 command_kill_pets (op, 0);
2722 2477
2723 if (op->stats.food < 0) 2478 op->contr->play_sound (sound_find ("player_dies"));
2724 {
2725 sprintf (buf, "%s starved to death.", &op->name);
2726 strcpy (op->contr->killer, "starvation");
2727 }
2728 else
2729 sprintf (buf, "%s died.", &op->name);
2730
2731 play_sound_player_only (op->contr, SOUND_PLAYER_DIES, 0, 0);
2732 2479
2733 /* save the map location for corpse, gravestone */ 2480 /* save the map location for corpse, gravestone */
2734 x = op->x; 2481 x = op->x;
2735 y = op->y; 2482 y = op->y;
2736 map = op->map; 2483 map = op->map;
2764 2511
2765 lost_a_stat = 0; 2512 lost_a_stat = 0;
2766 2513
2767 for (z = 0; z < num_stats_lose; z++) 2514 for (z = 0; z < num_stats_lose; z++)
2768 { 2515 {
2769 i = RANDOM () % NUM_STATS; 2516 i = rndm (NUM_STATS);
2770 2517
2771 if (settings.stat_loss_on_death) 2518 if (settings.stat_loss_on_death)
2772 { 2519 {
2773 /* Pick a random stat and take a point off it. Tell the player 2520 /* Pick a random stat and take a point off it. Tell the player
2774 * what he lost. 2521 * what he lost.
2781 lost_a_stat = 1; 2528 lost_a_stat = 1;
2782 } 2529 }
2783 else 2530 else
2784 { 2531 {
2785 /* deplete a stat */ 2532 /* deplete a stat */
2786 archetype *deparch = archetype::find ("depletion"); 2533 archetype *deparch = archetype::find (shstr_depletion);
2787 object *dep; 2534 object *dep;
2788 2535
2789 dep = present_arch_in_ob (deparch, op); 2536 dep = present_arch_in_ob (deparch, op);
2790 if (!dep) 2537 if (!dep)
2791 { 2538 {
2792 dep = arch_to_object (deparch); 2539 dep = deparch->instance ();
2793 insert_ob_in_ob (dep, op); 2540 insert_ob_in_ob (dep, op);
2794 } 2541 }
2795 lose_this_stat = 1; 2542 lose_this_stat = 1;
2796 if (settings.balanced_stat_loss) 2543 if (settings.balanced_stat_loss)
2797 { 2544 {
2825 } 2572 }
2826 } 2573 }
2827 2574
2828 if (lose_this_stat) 2575 if (lose_this_stat)
2829 { 2576 {
2830 this_stat = get_attr_value (&(dep->stats), i); 2577 this_stat = get_attr_value (&dep->stats, i);
2831 /* We could try to do something clever like find another 2578 /* We could try to do something clever like find another
2832 * stat to reduce if this fails. But chances are, if 2579 * stat to reduce if this fails. But chances are, if
2833 * stats have been depleted to -50, all are pretty low 2580 * stats have been depleted to -50, all are pretty low
2834 * and should be roughly the same, so it shouldn't make a 2581 * and should be roughly the same, so it shouldn't make a
2835 * difference. 2582 * difference.
2836 */ 2583 */
2837 if (this_stat >= -50) 2584 if (this_stat >= -50)
2838 { 2585 {
2839 change_attr_value (&(dep->stats), i, -1); 2586 change_attr_value (&(dep->stats), i, -1);
2840 SET_FLAG (dep, FLAG_APPLIED); 2587 dep->set_flag (FLAG_APPLIED);
2841 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]); 2588 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]);
2842 op->update_stats (); 2589 op->update_stats ();
2843 lost_a_stat = 1; 2590 lost_a_stat = 1;
2844 } 2591 }
2845 } 2592 }
2846 } 2593 }
2847 } 2594 }
2595
2848 /* If no stat lost, tell the player. */ 2596 /* If no stat lost, tell the player. */
2849 if (!lost_a_stat) 2597 if (!lost_a_stat)
2850 { 2598 {
2851 /* determine_god() seems to not work sometimes... why is this? 2599 /* determine_god() seems to not work sometimes... why is this?
2852 Should I be using something else? GD */ 2600 Should I be using something else? GD */
2853 const char *god = determine_god (op); 2601 shstr_tmp god = determine_god (op);
2854 2602
2855 if (god && (strcmp (god, "none"))) 2603 if (god != shstr_none)
2856 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2604 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2857 else 2605 else
2858 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2606 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2859 } 2607 }
2860#else 2608#else
2861 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you" " feel a holy presence protecting you from losing yourself completely."); 2609 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2862#endif 2610#endif
2863 2611
2864 /* Put a gravestone up where the character 'almost' died. List the 2612 /* Put a gravestone up where the character 'almost' died. List the
2865 * exp loss on the stone. 2613 * exp loss on the stone.
2866 */ 2614 */
2867 tmp = arch_to_object (archetype::find ("gravestone")); 2615 tmp = archetype::find (shstr_gravestone)->instance ();
2868 sprintf (buf, "%s's gravestone", &op->name); 2616 tmp->name = format ("%s's gravestone", &op->name);
2869 tmp->name = buf; 2617 tmp->name_pl = format ("%s's gravestones", &op->name);
2870 sprintf (buf, "%s's gravestones", &op->name); 2618 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2871 tmp->name_pl = buf; 2619 &op->name, op->contr->title, op->contr->killer_name ());
2872 sprintf (buf, "RIP\nHere rests the hero %s the %s,\n" "who was killed\n" "by %s.\n", &op->name, op->contr->title, op->contr->killer);
2873 tmp->msg = buf;
2874 tmp->x = op->x, tmp->y = op->y; 2620 tmp->x = op->x, tmp->y = op->y;
2875 insert_ob_in_map (tmp, op->map, NULL, 0); 2621 insert_ob_in_map (tmp, op->map, NULL, 0);
2876 2622
2877 /**************************************/ 2623 /**************************************/
2878 /* */ 2624 /* */
2879 /* Subtract the experience points, */ 2625 /* Subtract the experience points, */
2880 /* if we died cause of food, give us */
2881 /* food, and reset HP's... */
2882 /* */ 2626 /* */
2883 /**************************************/ 2627 /**************************************/
2884 2628
2885 /* remove any poisoning and confusion the character may be suffering. */
2886 /* restore player */
2887 at = archetype::find ("poisoning");
2888 tmp = present_arch_in_ob (at, op);
2889
2890 if (tmp)
2891 {
2892 tmp->destroy ();
2893 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2894 }
2895
2896 at = archetype::find ("confusion");
2897 tmp = present_arch_in_ob (at, op);
2898 if (tmp)
2899 {
2900 tmp->destroy ();
2901 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2902 }
2903
2904 cure_disease (op, 0); /* remove any disease */
2905
2906 /*add_exp(op, (op->stats.exp * -0.20)); */ 2629 /*add_exp(op, (op->stats.exp * -0.20)); */
2907 apply_death_exp_penalty (op); 2630 apply_death_exp_penalty (op);
2908 if (op->stats.food < 100)
2909 op->stats.food = 900;
2910 op->stats.hp = op->stats.maxhp;
2911 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2912 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2913 2631
2914 /* 2632 /*
2915 * Check to see if the player is in a shop. IF so, then check to see if
2916 * the player has any unpaid items. If so, remove them and put them back 2633 * Check to see if the player has any unpaid items. If so, remove them
2917 * in the map. 2634 * and put them back in the map.
2918 */ 2635 */
2919 2636 op->drop_unpaid_items ();
2920 if (is_in_shop (op))
2921 remove_unpaid_objects (op->inv, op);
2922 2637
2923 /****************************************/ 2638 /****************************************/
2924 /* */ 2639 /* */
2925 /* Move player to his current respawn- */ 2640 /* Move player to his current respawn- */
2926 /* position (usually last savebed) */ 2641 /* position (usually last savebed) */
2946 object *force; 2661 object *force;
2947 int at; 2662 int at;
2948 2663
2949 force = get_archetype (FORCE_NAME); 2664 force = get_archetype (FORCE_NAME);
2950 /* 50 ticks should be enough time for the spell to abate */ 2665 /* 50 ticks should be enough time for the spell to abate */
2951 force->speed = 0.1; 2666 force->speed = 0.1f;
2952 force->speed_left = -5.0; 2667 force->speed_left = -5.f;
2953 SET_FLAG (force, FLAG_APPLIED); 2668 force->set_flag (FLAG_APPLIED);
2954 for (at = 0; at < NROFATTACKS; at++) 2669 for (at = 0; at < NROFATTACKS; at++)
2955 if (will_kill_again & (1 << at)) 2670 if (will_kill_again & (1 << at))
2956 force->resist[at] = 100; 2671 force->resist[at] = 100;
2957 2672
2958 insert_ob_in_ob (force, op); 2673 insert_ob_in_ob (force, op);
2959 op->update_stats (); 2674 op->update_stats ();
2960
2961 } 2675 }
2962 2676
2963 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2677 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2964} 2678}
2965 2679
2966void 2680static void
2967loot_object (object *op) 2681loot_object (object *op)
2968{ /* Grab and destroy some treasure */ 2682{ /* Grab and destroy some treasure */
2969 object *tmp, *tmp2, *next; 2683 object *tmp, *tmp2, *next;
2970 2684
2971 if (op->container) 2685 op->close_container (); /* close open sack first */
2972 esrv_apply_container (op, op->container); /* close open sack first */
2973 2686
2974 for (tmp = op->inv; tmp; tmp = next) 2687 for (tmp = op->inv; tmp; tmp = next)
2975 { 2688 {
2976 next = tmp->below; 2689 next = tmp->below;
2977 2690
2978 if (tmp->invisible) 2691 if (tmp->invisible)
2979 continue; 2692 continue;
2980 2693
2981 tmp->remove (); 2694 tmp->remove ();
2982 tmp->x = op->x, tmp->y = op->y; 2695 tmp->x = op->x, tmp->y = op->y;
2696
2983 if (tmp->type == CONTAINER) 2697 if (tmp->type == CONTAINER)
2984 { /* empty container to ground */ 2698 loot_object (tmp); /* empty container to ground */
2985 loot_object (tmp); 2699
2986 } 2700 if (!tmp->flag [FLAG_UNIQUE] && (tmp->flag [FLAG_STARTEQUIP] || tmp->flag [FLAG_NO_DROP] || !(rndm (3))))
2987 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3))))
2988 { 2701 {
2989 if (tmp->nrof > 1) 2702 if (tmp->nrof > 1)
2990 { 2703 {
2991 tmp2 = get_split_ob (tmp, 1 + RANDOM () % (tmp->nrof - 1)); 2704 tmp->decrease (rndm (1, tmp->nrof - 1));
2992 tmp2->destroy ();
2993 insert_ob_in_map (tmp, op->map, NULL, 0); 2705 insert_ob_in_map (tmp, op->map, NULL, 0);
2994 } 2706 }
2995 else 2707 else
2996 tmp->destroy (); 2708 tmp->destroy ();
2997 } 2709 }
3003/* 2715/*
3004 * fix_weight(): Check recursively the weight of all players, and fix 2716 * fix_weight(): Check recursively the weight of all players, and fix
3005 * what needs to be fixed. Refresh windows and fix speed if anything 2717 * what needs to be fixed. Refresh windows and fix speed if anything
3006 * was changed. 2718 * was changed.
3007 */ 2719 */
3008
3009void 2720void
3010fix_weight (void) 2721fix_weight ()
3011{ 2722{
3012 for_all_players (pl) 2723 for_all_players (pl)
3013 { 2724 {
3014 int old = pl->ob->carrying, sum = sum_weight (pl->ob); 2725 sint32 old = pl->ob->carrying;
3015 2726
3016 if (old == sum) 2727 pl->ob->update_weight ();
3017 continue; 2728
2729 if (old != pl->ob->carrying)
2730 {
3018 pl->ob->update_stats (); 2731 pl->ob->update_stats ();
3019 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, old, sum); 2732 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, (int)old, (int)pl->ob->carrying);
2733 }
3020 } 2734 }
3021} 2735}
3022 2736
3023void 2737void
3024fix_luck (void) 2738fix_luck ()
3025{ 2739{
3026 for_all_players (pl) 2740 for_all_players (pl)
3027 if (!pl->ob->contr->ns->state) 2741 if (!pl->ob->contr->ns->state)
3028 pl->ob->change_luck (0); 2742 pl->ob->change_luck (0);
3029} 2743}
3066} 2780}
3067 2781
3068void 2782void
3069make_visible (object *op) 2783make_visible (object *op)
3070{ 2784{
3071 op->hide = 0; 2785 op->flag [FLAG_HIDDEN] = 0;
3072 op->invisible = 0; 2786 op->invisible = 0;
2787
3073 if (op->type == PLAYER) 2788 if (op->type == PLAYER)
3074 { 2789 {
3075 op->contr->tmp_invis = 0; 2790 op->contr->tmp_invis = 0;
3076 op->contr->invis_race = 0; 2791 op->contr->invis_race = 0;
3077 } 2792 }
2793
3078 update_object (op, UP_OBJ_FACE); 2794 update_object (op, UP_OBJ_CHANGE);
3079} 2795}
3080 2796
3081int 2797int
3082is_true_undead (object *op) 2798is_true_undead (object *op)
3083{ 2799{
3084 object *tmp = NULL; 2800 if (op->arch->flag [FLAG_UNDEAD])
3085
3086 if (QUERY_FLAG (&op->arch->clone, FLAG_UNDEAD))
3087 return 1; 2801 return 1;
3088 2802
3089 return 0; 2803 return 0;
3090} 2804}
3091 2805
3092/* look at the surrounding terrain to determine 2806/* look at the surrounding terrain to determine
3093 * the hideability of this object. Positive levels 2807 * the hideability of this object. Positive levels
3094 * indicate greater hideability. 2808 * indicate greater hideability.
3095 */ 2809 */
3096
3097int 2810int
3098hideability (object *ob) 2811hideability (object *ob)
3099{ 2812{
3100 int i, level = 0, mflag; 2813 int i, level = 0, mflag;
3101 sint16 x, y; 2814 sint16 x, y;
3102 2815
3103 if (!ob || !ob->map) 2816 if (!ob || !ob->map)
3104 return 0; 2817 return 0;
3105 2818
3106 /* so, on normal lighted maps, its hard to hide */ 2819 /* so, on normal lighted maps, its hard to hide */
3107 level = ob->map->darkness - 2; 2820 level = ob->map->darklevel () - 2;
3108 2821
3109 /* this also picks up whether the object is glowing. 2822 /* this also picks up whether the object is glowing.
3110 * If you carry a light on a non-dark map, its not 2823 * If you carry a light on a non-dark map, its not
3111 * as bad as carrying a light on a pitch dark map */ 2824 * as bad as carrying a light on a pitch dark map */
3112 if (has_carried_lights (ob)) 2825 if (ob->has_carried_lights ())
3113 level = -(10 + (2 * ob->map->darkness)); 2826 level = -(10 + (2 * ob->map->darklevel ()));
3114 2827
3115 /* scan through all nearby squares for terrain to hide in */ 2828 /* scan through all nearby squares for terrain to hide in */
3116 for (i = 0, x = ob->x, y = ob->y; i < 9; i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2829 for (i = 0, x = ob->x, y = ob->y;
2830 i <= SIZEOFFREE1;
2831 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
3117 { 2832 {
3118 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 2833 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3119 if (mflag & P_OUT_OF_MAP) 2834 if (mflag & P_OUT_OF_MAP)
3120 {
3121 continue; 2835 continue;
3122 } 2836
3123 if (mflag & P_BLOCKSVIEW) /* something to hide near! */ 2837 if (mflag & P_BLOCKSVIEW) /* something to hide near! */
3124 level += 2; 2838 level += 2;
3125 else /* open terrain! */ 2839 else /* open terrain! */
3126 level -= 1; 2840 level -= 1;
3127 } 2841 }
3135/* For Hidden creatures - a chance of becoming 'unhidden' 2849/* For Hidden creatures - a chance of becoming 'unhidden'
3136 * every time they move - as we subtract off 'invisibility' 2850 * every time they move - as we subtract off 'invisibility'
3137 * AND, for players, if they move into a ridiculously unhideable 2851 * AND, for players, if they move into a ridiculously unhideable
3138 * spot (surrounded by clear terrain in broad daylight). -b.t. 2852 * spot (surrounded by clear terrain in broad daylight). -b.t.
3139 */ 2853 */
3140
3141void 2854void
3142do_hidden_move (object *op) 2855do_hidden_move (object *op)
3143{ 2856{
3144 int hide = 0, num = random_roll (0, 19, op, PREFER_LOW); 2857 int hide = 0;
3145 object *skop;
3146 2858
3147 if (!op || !op->map) 2859 if (!op || !op->map)
3148 return; 2860 return;
3149 2861
3150 skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING); 2862 object *skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING);
2863 int num = random_roll (0, 19, op, PREFER_LOW);
3151 2864
3152 /* its *extremely* hard to run and sneak/hide at the same time! */ 2865 /* its *extremely* hard to run and sneak/hide at the same time! */
3153 if (op->type == PLAYER && op->contr->run_on) 2866 if (op->type == PLAYER && op->contr->run_on)
3154 if (!skop || num >= skop->level) 2867 if (!skop || num >= skop->level)
3155 { 2868 {
3165 num -= hide; 2878 num -= hide;
3166 2879
3167 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0)) 2880 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0))
3168 { 2881 {
3169 make_visible (op); 2882 make_visible (op);
2883
3170 if (op->type == PLAYER) 2884 if (op->type == PLAYER)
3171 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!"); 2885 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!");
3172 } 2886 }
3173 else if (op->type == PLAYER && skop) 2887 else if (op->type == PLAYER && skop)
3174 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0); 2888 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0);
3189 2903
3190 if (who->type == PLAYER) 2904 if (who->type == PLAYER)
3191 player = 1; 2905 player = 1;
3192 2906
3193 else 2907 else
3194 friendly = QUERY_FLAG (who, FLAG_FRIENDLY); 2908 friendly = who->flag [FLAG_FRIENDLY];
3195 2909
3196 /* search adjacent squares */ 2910 /* search adjacent squares */
3197 for (i = 1; i < 9; i++) 2911 for (i = 1; i < 9; i++)
3198 { 2912 {
3199 x = who->x + freearr_x[i]; 2913 x = who->x + freearr_x[i];
3208 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y))) 2922 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y)))
3209 continue; 2923 continue;
3210 2924
3211 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 2925 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
3212 { 2926 {
3213 if ((player ||friendly) &&QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_UNAGGRESSIVE)) 2927 if ((player ||friendly) &&tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_UNAGGRESSIVE])
3214 return 1; 2928 return 1;
3215 else if (tmp->type == PLAYER) 2929 else if (tmp->type == PLAYER)
3216 { 2930 {
3217 /*don't let a hidden DM prevent you from hiding */ 2931 /*don't let a hidden DM prevent you from hiding */
3218 if (!QUERY_FLAG (tmp, FLAG_WIZ) || tmp->contr->hidden == 0) 2932 if (!tmp->flag [FLAG_WIZ] || tmp->contr->hidden == 0)
3219 return 1; 2933 return 1;
3220 } 2934 }
3221 } 2935 }
3222 } 2936 }
3223 return 0; 2937 return 0;
3227 * object op. This function works fine for monsters, 2941 * object op. This function works fine for monsters,
3228 * but we dont worry if the object isnt the top one in 2942 * but we dont worry if the object isnt the top one in
3229 * a pile (say a coin under a table would return "viewable" 2943 * a pile (say a coin under a table would return "viewable"
3230 * by this routine). Another question, should we be 2944 * by this routine). Another question, should we be
3231 * concerned with the direction the player is looking 2945 * concerned with the direction the player is looking
3232 * in? Realistically, most of use cant see stuff behind 2946 * in? Realistically, most of us can't see stuff behind
3233 * our backs...on the other hand, does the "facing" direction 2947 * our backs...on the other hand, does the "facing" direction
3234 * imply the way your head, or body is facing? Its possible 2948 * imply the way your head, or body is facing? It's possible
3235 * for them to differ. Sigh, this fctn could get a bit more complex. 2949 * for them to differ. Sigh, this fctn could get a bit more complex.
3236 * -b.t. 2950 * -b.t.
3237 * This function is now map tiling safe. 2951 * This function is now map tiling safe.
3238 */ 2952 */
3239
3240int 2953int
3241player_can_view (object *pl, object *op) 2954player_can_view (object *pl, object *op)
3242{ 2955{
3243 rv_vector rv; 2956 rv_vector rv;
3244 int dx, dy; 2957 int dx, dy;
3256 2969
3257 get_rangevector (pl, op, &rv, 0x1); 2970 get_rangevector (pl, op, &rv, 0x1);
3258 2971
3259 /* starting with the 'head' part, lets loop 2972 /* starting with the 'head' part, lets loop
3260 * through the object and find if it has any 2973 * through the object and find if it has any
3261 * part that is in the los array but isnt on 2974 * part that is in the los array but isn't on
3262 * a blocked los square. 2975 * a blocked los square.
3263 * we use the archetype to figure out offsets. 2976 * we use the archetype to figure out offsets.
3264 */ 2977 */
3265 while (op) 2978 while (op)
3266 { 2979 {
3267 dx = rv.distance_x + op->arch->clone.x; 2980 dx = rv.distance_x + op->arch->x;
3268 dy = rv.distance_y + op->arch->clone.y; 2981 dy = rv.distance_y + op->arch->y;
3269 2982
3270 /* only the viewable area the player sees is updated by LOS 2983 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3271 * code, so we need to restrict ourselves to that range of values
3272 * for any meaningful values.
3273 */
3274 if (FABS (dx) <= (pl->contr->ns->mapx / 2) &&
3275 FABS (dy) <= (pl->contr->ns->mapy / 2) &&
3276 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3277 return 1; 2984 return 1;
2985
3278 op = op->more; 2986 op = op->more;
3279 } 2987 }
3280 return 0;
3281}
3282 2988
3283/* routine for both players and monsters. We call this when
3284 * there is a possibility for our action distrubing our hiding
3285 * place or invisiblity spell. Artefact invisiblity is not
3286 * effected by this. If we arent invisible to begin with, we
3287 * return 0.
3288 */
3289int
3290action_makes_visible (object *op)
3291{
3292
3293 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3294 {
3295 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3296 return 0;
3297
3298 if (op->contr && op->contr->tmp_invis == 0)
3299 return 0;
3300
3301 /* If monsters, they should become visible */
3302 if (op->hide || !op->contr || (op->contr && op->contr->tmp_invis))
3303 {
3304 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible");
3305 return 1;
3306 }
3307 }
3308 return 0; 2989 return 0;
3309} 2990}
3310 2991
3311/* op_on_battleground - checks if the given object op (usually 2992/* op_on_battleground - checks if the given object op (usually
3312 * a player) is standing on a valid battleground-tile, 2993 * a player) is standing on a valid battleground-tile,
3317 * Default is to do the same as before, so only people wanting to have different points need worry about this 2998 * Default is to do the same as before, so only people wanting to have different points need worry about this
3318 */ 2999 */
3319int 3000int
3320op_on_battleground (object *op, int *x, int *y) 3001op_on_battleground (object *op, int *x, int *y)
3321{ 3002{
3322 object *tmp;
3323
3324 /* A battleground-tile needs the following attributes to be valid: 3003 /* A battleground-tile needs the following attributes to be valid:
3325 * is_floor 1 (has to be the FIRST floor beneath the player's feet), 3004 * is_floor 1 (has to be the FIRST floor beneath the player's feet),
3326 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND) 3005 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND)
3327 * and the exit-coordinates sp/hp must both be > 0. 3006 * and the exit-coordinates sp/hp must both be > 0.
3328 * => The intention here is to prevent abuse of the battleground- 3007 * => The intention here is to prevent abuse of the battleground-
3329 * feature (like pickable or hidden battleground tiles). */ 3008 * feature (like pickable or hidden battleground tiles). */
3330 for (tmp = op->below; tmp != NULL; tmp = tmp->below) 3009 for (object *tmp = op->below; tmp; tmp = tmp->below)
3331 { 3010 {
3332 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3011 if (tmp->flag [FLAG_IS_FLOOR])
3333 { 3012 {
3334 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && 3013 if (tmp->flag [FLAG_NO_PICK]
3335 strcmp (tmp->name, "battleground") == 0 && tmp->type == BATTLEGROUND && EXIT_X (tmp) && EXIT_Y (tmp)) 3014 && tmp->type == BATTLEGROUND
3015 && tmp->name == shstr_battleground
3016 && EXIT_X (tmp) && EXIT_Y (tmp))
3336 { 3017 {
3337 /*before we assign the exit, check if this is a teambattle */ 3018 /* before we assign the exit, check if this is a teambattle */
3338 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3019 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3339 {
3340 object *invtmp;
3341
3342 for (invtmp = op->inv; invtmp != NULL; invtmp = invtmp->below) 3020 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3021 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3343 { 3022 {
3344 if (invtmp->type == FORCE && invtmp->slaying && !strcmp (EXIT_PATH (tmp), invtmp->slaying))
3345 {
3346 if (x != NULL && y != NULL) 3023 if (x && y)
3347 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3024 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3025
3348 return 1; 3026 return 1;
3349 }
3350 } 3027 }
3351 } 3028
3352 if (x != NULL && y != NULL) 3029 if (x && y)
3353 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3030 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3031
3354 return 1; 3032 return 1;
3355 } 3033 }
3356 } 3034 }
3357 } 3035 }
3036
3358 /* If we got here, did not find a battleground */ 3037 /* If we got here, did not find a battleground */
3359 return 0; 3038 return 0;
3360} 3039}
3361 3040
3362/* 3041/*
3378 char buf[MAX_BUF]; /* tmp. string buffer */ 3057 char buf[MAX_BUF]; /* tmp. string buffer */
3379 int i = 0, j = 0; 3058 int i = 0, j = 0;
3380 3059
3381 /* get the appropriate treasurelist */ 3060 /* get the appropriate treasurelist */
3382 if (atnr == ATNR_FIRE) 3061 if (atnr == ATNR_FIRE)
3383 trlist = find_treasurelist ("dragon_ability_fire"); 3062 trlist = treasurelist::find (shstr_dragon_ability_fire);
3384 else if (atnr == ATNR_COLD) 3063 else if (atnr == ATNR_COLD)
3385 trlist = find_treasurelist ("dragon_ability_cold"); 3064 trlist = treasurelist::find (shstr_dragon_ability_cold);
3386 else if (atnr == ATNR_ELECTRICITY) 3065 else if (atnr == ATNR_ELECTRICITY)
3387 trlist = find_treasurelist ("dragon_ability_elec"); 3066 trlist = treasurelist::find (shstr_dragon_ability_elec);
3388 else if (atnr == ATNR_POISON) 3067 else if (atnr == ATNR_POISON)
3389 trlist = find_treasurelist ("dragon_ability_poison"); 3068 trlist = treasurelist::find (shstr_dragon_ability_poison);
3390 3069
3391 if (trlist == NULL || who->type != PLAYER) 3070 if (trlist == NULL || who->type != PLAYER)
3392 return; 3071 return;
3393 3072
3394 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++); 3073 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++);
3398 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */ 3077 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */
3399 return; 3078 return;
3400 } 3079 }
3401 3080
3402 /* everything seems okay - now bring on the gift: */ 3081 /* everything seems okay - now bring on the gift: */
3403 item = &(tr->item->clone); 3082 item = tr->item;
3404 3083
3405 if (item->type == SPELL) 3084 if (item->type == SPELL)
3406 { 3085 {
3407 if (check_spell_known (who, item->name)) 3086 if (check_spell_known (who, item->name))
3408 return; 3087 return;
3467 { 3146 {
3468 /* forces in the treasurelist can alter the player's stats */ 3147 /* forces in the treasurelist can alter the player's stats */
3469 object *skin; 3148 object *skin;
3470 3149
3471 /* first get the dragon skin force */ 3150 /* first get the dragon skin force */
3472 shstr_cmp dragon_skin_force ("dragon_skin_force");
3473 for (skin = who->inv; skin && !(skin->arch->name == dragon_skin_force); skin = skin->below) 3151 for (skin = who->inv; skin && !(skin->arch->archname == shstr_dragon_skin_force); skin = skin->below)
3474 ; 3152 ;
3475 3153
3476 if (!skin) 3154 if (!skin)
3477 return; 3155 return;
3478 3156
3492 else 3170 else
3493 j = 1; 3171 j = 1;
3494 strcat (buf, spellpathnames[i]); 3172 strcat (buf, spellpathnames[i]);
3495 } 3173 }
3496 } 3174 }
3175
3497 strcat (buf, "."); 3176 strcat (buf, ".");
3498 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf); 3177 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf);
3499 } 3178 }
3500 3179
3501 /* evtl. adding flags: */ 3180 /* evtl. adding flags: */
3502 if (QUERY_FLAG (item, FLAG_XRAYS)) 3181 if (item->flag [FLAG_XRAYS])
3503 SET_FLAG (skin, FLAG_XRAYS); 3182 skin->set_flag (FLAG_XRAYS);
3504 if (QUERY_FLAG (item, FLAG_STEALTH)) 3183 if (item->flag [FLAG_STEALTH])
3505 SET_FLAG (skin, FLAG_STEALTH); 3184 skin->set_flag (FLAG_STEALTH);
3506 if (QUERY_FLAG (item, FLAG_SEE_IN_DARK)) 3185 if (item->flag [FLAG_SEE_IN_DARK])
3507 SET_FLAG (skin, FLAG_SEE_IN_DARK); 3186 skin->set_flag (FLAG_SEE_IN_DARK);
3508 3187
3509 /* print message if there is one */ 3188 /* print message if there is one */
3510 if (item->msg != NULL) 3189 if (item->msg != NULL)
3511 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg); 3190 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg);
3512 } 3191 }
3513 else 3192 else
3514 { 3193 {
3515 /* generate misc. treasure */ 3194 /* generate misc. treasure */
3516 tmp = arch_to_object (tr->item); 3195 tmp = tr->item->instance ();
3517 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3196 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3518 tmp = insert_ob_in_ob (tmp, who); 3197 who->insert (tmp);
3519 if (who->type == PLAYER)
3520 esrv_send_item (who, tmp);
3521 } 3198 }
3522} 3199}
3523 3200
3524/** 3201//-GPL
3525 * Unready an object for a player. This function does nothing if the object was 3202
3526 * not readied. 3203sint8
3527 */ 3204player::darkness_at (maptile *map, int x, int y) const
3205{
3206 if (!ns)
3207 return LOS_BLOCKED;
3208
3209 int dx, dy;
3210 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3211 return LOS_BLOCKED;
3212
3213 x += dx - ns->current_x;
3214 y += dy - ns->current_y;
3215
3216 return blocked_los (x, y);
3217}
3218
3528void 3219void
3529player_unready_range_ob (player *pl, object *ob) 3220player::infobox (const char *title, const char *msg, int color)
3530{ 3221{
3531 for (rangetype i = (rangetype) 0; i < range_size; i = (rangetype) ((int) i + 1)) 3222 send_msg (color | NDI_DEF | NDI_REPLY | NDI_CLEAR, title, msg);
3532 if (pl->ranges[i] == ob)
3533 {
3534 pl->ranges[i] = 0;
3535 if (pl->shoottype == i)
3536 pl->shoottype = range_none;
3537 }
3538} 3223}
3224
3225void
3226player::statusmsg (const char *msg, int color)
3227{
3228 send_msg (color | NDI_REPLY, INFO_CHANNEL, msg);
3229}
3230
3231void
3232player::failmsg (const char *msg, int color)
3233{
3234 play_sound (sound_find ("generic_failure"));
3235 statusmsg (msg, color);
3236}
3237
3238void
3239object::failmsgf (const char *format, ...)
3240{
3241 if (!contr)
3242 return;
3243
3244 va_list ap;
3245 va_start (ap, format);
3246 contr->failmsg (vformat (format, ap));
3247 va_end (ap);
3248}
3249
3250void
3251player::failmsgf (const char *format, ...)
3252{
3253 va_list ap;
3254 va_start (ap, format);
3255 failmsg (vformat (format, ap));
3256 va_end (ap);
3257}
3258

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines