ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.212 by root, Tue Dec 23 00:39:48 2008 UTC vs.
Revision 1.296 by root, Thu Nov 17 04:59:33 2016 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
24
25//+GPL
26
27#include <algorithm>
28#include <functional>
23 29
24#include <global.h> 30#include <global.h>
25#include <sproto.h> 31#include <sproto.h>
26#include <sounds.h> 32#include <sounds.h>
27#include <living.h> 33#include <living.h>
28#include <object.h> 34#include <object.h>
29#include <spells.h> 35#include <spells.h>
30#include <skills.h> 36#include <skills.h>
31 37
32#include <algorithm>
33#include <functional>
34
35playervec players; 38playervec players;
36
37void
38display_motd (const object *op)
39{
40 char buf[MAX_BUF];
41 char motd[HUGE_BUF];
42 FILE *fp;
43 int comp;
44 int size;
45
46 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
47 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
48 return;
49
50 motd[0] = '\0';
51 size = 0;
52
53 while (fgets (buf, MAX_BUF, fp))
54 {
55 if (*buf == '#')
56 continue;
57
58 strncat (motd + size, buf, HUGE_BUF - size);
59 size += strlen (buf);
60 }
61
62 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
63 close_and_delete (fp, comp);
64}
65
66void
67send_rules (const object *op)
68{
69 char buf[MAX_BUF];
70 char rules[HUGE_BUF];
71 FILE *fp;
72 int comp;
73 int size;
74
75 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
76 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
77 return;
78
79 rules[0] = '\0';
80 size = 0;
81
82 while (fgets (buf, MAX_BUF, fp))
83 {
84 if (*buf == '#')
85 continue;
86
87 if (size + strlen (buf) >= HUGE_BUF)
88 {
89 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
90 break;
91 }
92
93 strncat (rules + size, buf, HUGE_BUF - size);
94 size += strlen (buf);
95 }
96
97 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
98 close_and_delete (fp, comp);
99}
100
101void
102send_news (const object *op)
103{
104 char buf[MAX_BUF];
105 char news[HUGE_BUF];
106 char subject[MAX_BUF];
107 FILE *fp;
108 int comp;
109 int size;
110
111 sprintf (buf, "%s/%s", settings.confdir, settings.news);
112 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
113 return;
114
115 news[0] = '\0';
116 subject[0] = '\0';
117 size = 0;
118
119 while (fgets (buf, MAX_BUF, fp))
120 {
121 if (*buf == '#')
122 continue;
123
124 if (*buf == '%')
125 { /* send one news */
126 if (size > 0)
127 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
128 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS,
129 "INFORMATION: %s\n%s", (char *)"%s\n%s",
130 subject, news); /*send previously read news */
131
132 strcpy (subject, buf + 1);
133 strip_endline (subject);
134 size = 0;
135 news[0] = '\0';
136 }
137 else
138 {
139 if (size + strlen (buf) >= HUGE_BUF)
140 {
141 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
142 break;
143 }
144 strncat (news + size, buf, HUGE_BUF - size);
145 size += strlen (buf);
146 }
147 }
148
149 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
150 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", (char *)"%s\n%s", subject, news);
151 close_and_delete (fp, comp);
152}
153 39
154/* This loads the first map an puts the player on it. */ 40/* This loads the first map an puts the player on it. */
155static void 41static void
156set_first_map (object *op) 42set_first_map (object *op)
157{ 43{
… …
168 54
169 players.insert (this); 55 players.insert (this);
170 ob->remove (); 56 ob->remove ();
171 ob->map = 0; 57 ob->map = 0;
172 ob->activate_recursive (); 58 ob->activate_recursive ();
173 CLEAR_FLAG (ob, FLAG_FRIENDLY); 59 ob->clr_flag (FLAG_FRIENDLY);
174 add_friendly_object (ob); 60 add_friendly_object (ob);
175} 61}
176 62
177void 63void
178player::deactivate () 64player::deactivate ()
… …
190 ob->remove (); 76 ob->remove ();
191 ob->enemy = 0; // sometimes keeps an extra refcount on itself 77 ob->enemy = 0; // sometimes keeps an extra refcount on itself
192 ob->map = 0; 78 ob->map = 0;
193 party = 0; 79 party = 0;
194 80
195 combat_ob = ranged_ob = 0; //TODO, should be special marker, non-refcounted, not this
196
197 players.erase (this); 81 players.erase (this);
198} 82}
199 83
200// connect the player with a specific client 84// connect the player with a specific client
201// also changes, rationalises, and fixes some incorrect settings 85// also changes, rationalises, and fixes some incorrect settings
… …
221 ob->race = ob->arch->race; 105 ob->race = ob->arch->race;
222 106
223 ob->update_weight (); 107 ob->update_weight ();
224 link_skills (); 108 link_skills ();
225 109
226 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
227
228 assign (title, ob->arch->object::name); 110 assign (title, ob->arch->object::name);
229 111
230 /* if it's a dragon player, set the correct title here */ 112 /* if it's a dragon player, set the correct title here */
231 if (is_dragon_pl (ob)) 113 if (ob->is_dragon ())
232 { 114 {
233 object *tmp, *abil = 0, *skin = 0; 115 object *tmp, *abil = 0, *skin = 0;
234 116
235 for (tmp = ob->inv; tmp; tmp = tmp->below) 117 for (tmp = ob->inv; tmp; tmp = tmp->below)
236 if (tmp->type == FORCE) 118 if (tmp->type == FORCE)
… …
244 126
245 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 127 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
246 128
247 esrv_new_player (this); 129 esrv_new_player (this);
248 130
131 ob->flag [FLAG_READY_WEAPON] = false;
132 ob->flag [FLAG_READY_SKILL] = false;
133 ob->flag [FLAG_READY_RANGE] = false;
134 ob->flag [FLAG_READY_BOW] = false;
135
249 ob->update_stats (); 136 ob->update_stats ();
250 137
251 ns->floorbox_update (); 138 ns->floorbox_update ();
252 esrv_send_inventory (ob, ob); 139 esrv_send_inventory (ob, ob);
253 esrv_add_spells (this, 0); 140 esrv_add_spells (this, 0);
254 141
255 activate (); 142 activate ();
256 143
257 send_rules (ob);
258 send_news (ob);
259 display_motd (ob);
260
261 INVOKE_PLAYER (CONNECT, this); 144 INVOKE_PLAYER (CONNECT, this);
262 INVOKE_PLAYER (LOGIN, this); 145 INVOKE_PLAYER (LOGIN, this);
263} 146}
264 147
265void 148void
… …
281 ns->reset_stats (); 164 ns->reset_stats ();
282 ns->pl = 0; 165 ns->pl = 0;
283 ns = 0; 166 ns = 0;
284 } 167 }
285 168
286 observe = ob; 169 // this is important for the player scheduler to get the correct refcount
170 // when ns = 0
171 observe = viewpoint = ob;
287 172
288 deactivate (); 173 deactivate ();
289} 174}
175
176//-GPL
290 177
291// the need for this function can be explained 178// the need for this function can be explained
292// by load_object not returning the object 179// by load_object not returning the object
293void 180void
294player::set_object (object *op) 181player::set_object (object *op)
295{ 182{
296 ob = observe = op; 183 ob = observe = viewpoint = op;
297 ob->contr = this; /* this aren't yet in archetype */ 184 ob->contr = this; /* this aren't yet in archetype */
298 185
299 ob->speed = 1.0f; 186 ob->speed = 1.0f; // object still inactive, keep it that way
300 ob->speed_left = 0.5f; 187 ob->speed_left = 0.5f;
301 188
302 ob->direction = 5; /* So player faces south */ 189 ob->direction = 5; /* So player faces south */
303
304 ob->flag [FLAG_READY_WEAPON] = false;
305 ob->flag [FLAG_READY_SKILL] = false;
306 ob->flag [FLAG_READY_BOW] = false;
307
308 for (object *op = ob->inv; op; op = op->below)
309 if (op->flag [FLAG_APPLIED])
310 switch (op->type)
311 {
312 case SKILL:
313 ob->flag [FLAG_APPLIED] = false;
314 break;
315
316 case WAND:
317 case ROD:
318 case HORN:
319 case BOW:
320 ranged_ob = op;
321 break;
322
323 case WEAPON:
324 combat_ob = op;
325 break;
326 }
327
328 ob->change_weapon (combat_ob ? combat_ob : ranged_ob);
329 ob->deactivate (); // change_weapon activates, fix this better
330} 190}
331 191
332void 192void
333player::set_observe (object *op) 193player::set_observe (object *op)
334{ 194{
335 observe = op ? op : ob; 195 observe = viewpoint = op ? op : ob;
336 do_los = 1; 196 do_los = 1;
337} 197}
198
199void
200player::set_viewpoint (object *op)
201{
202 viewpoint = op ? op : (object *)observe;
203 do_los = 1;
204}
205
206//+GPL
338 207
339player::player () 208player::player ()
340{ 209{
341 /* There are some elements we want initialised to non zero value - 210 /* There are some elements we want initialised to non zero value -
342 * we deal with that below this point. 211 * we deal with that below this point.
… …
364 disconnect (); 233 disconnect ();
365 234
366 attachable::do_destroy (); 235 attachable::do_destroy ();
367 236
368 if (ob) 237 if (ob)
369 {
370 ob->destroy_inv (false);
371 ob->destroy (); 238 ob->destroy ();
372 }
373 239
374 ob = observe = 0; 240 ob = observe = viewpoint = 0;
375} 241}
376 242
377player::~player () 243player::~player ()
378{ 244{
379 /* Clear item stack */ 245 /* Clear item stack */
380 free (stack_items); 246 free (stack_items);
247}
248
249/*
250 * get_player_archetype() return next player archetype from archetype
251 * list. Not very efficient routine, but used only creating new players.
252 * Note: there MUST be at least one player archetype!
253 */
254static archetype *
255get_player_archetype (archetype *at)
256{
257 // archetypes could have been reloaded
258 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
259
260 if (!nat)
261 return at;
262
263 archvec::iterator i = archetypes.find (nat);
264
265 for (;;)
266 {
267 if (++i == archetypes.end ())
268 i = archetypes.begin ();
269 else if (*i == at)
270 cleanup ("not a single player archetype found");
271
272 if ((*i)->type == PLAYER)
273 return *i;
274 }
381} 275}
382 276
383/* Tries to add player on the connection passed in ns. 277/* Tries to add player on the connection passed in ns.
384 * All we can really get in this is some settings like host and display 278 * All we can really get in this is some settings like host and display
385 * mode. 279 * mode.
… …
387player * 281player *
388player::create () 282player::create ()
389{ 283{
390 player *pl = new player; 284 player *pl = new player;
391 285
392 pl->set_object (arch_to_object (get_player_archetype (0))); 286 pl->set_object (get_player_archetype (0)->instance ());
393 287
394 pl->ob->roll_stats (); 288 pl->ob->roll_stats ();
395 pl->ob->stats.wc = 2; 289 pl->ob->stats.wc = 2;
396 pl->ob->run_away = 25; /* Then we panick... */ 290 pl->ob->run_away = 25; /* Then we panick... */
397 291
398 set_first_map (pl->ob); 292 set_first_map (pl->ob);
399 293
400 return pl; 294 return pl;
401}
402
403/*
404 * get_player_archetype() return next player archetype from archetype
405 * list. Not very efficient routine, but used only creating new players.
406 * Note: there MUST be at least one player archetype!
407 */
408archetype *
409get_player_archetype (archetype *at)
410{
411 // archetypes could have been reloaded
412 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
413
414 if (!nat)
415 return at;
416
417 archvec::iterator i = archetypes.find (nat);
418
419 for (;;)
420 {
421 if (++i == archetypes.end ())
422 i = archetypes.begin ();
423 else if (*i == at)
424 cleanup ("not a single player archetype found");
425
426 if ((*i)->type == PLAYER)
427 return *i;
428 }
429} 295}
430 296
431object * 297object *
432get_nearest_player (object *mon) 298get_nearest_player (object *mon)
433{ 299{
… …
507 */ 373 */
508int 374int
509path_to_player (object *mon, object *pl, unsigned mindiff) 375path_to_player (object *mon, object *pl, unsigned mindiff)
510{ 376{
511 rv_vector rv; 377 rv_vector rv;
512 sint16 x, y;
513 int lastx, lasty, dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES, mflags, blocked; 378 int dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES;
514 maptile *m, *lastmap;
515 379
516 get_rangevector (mon, pl, &rv, 0); 380 get_rangevector (mon, pl, &rv, 0);
517 381
518 if (rv.distance < mindiff) 382 if (rv.distance < mindiff)
519 return 0; 383 return 0;
520 384
521 x = mon->x; 385 mapxy pos (mon);
522 y = mon->y;
523 m = mon->map;
524 dir = rv.direction; 386 dir = rv.direction;
525 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 387 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
526 diff = ::max (abs (rv.distance_x), abs (rv.distance_y)); 388 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
527 389
528 /* If we can't solve it within the search distance, return now. */ 390 /* If we can't solve it within the search distance, return now. */
529 if (diff > max) 391 if (diff > max)
530 return 0; 392 return 0;
531 393
532 while (diff > 1 && max > 0) 394 while (diff > 1 && max > 0)
533 { 395 {
534 lastx = x; 396 mapxy lastpos = pos;
535 lasty = y;
536 lastmap = m;
537 x = lastx + freearr_x[dir];
538 y = lasty + freearr_y[dir];
539 397
540 mflags = get_map_flags (m, &m, x, y, &x, &y); 398 pos.move (dir);
541 blocked = (mflags & P_OUT_OF_MAP) ? MOVE_ALL : GET_MAP_MOVE_BLOCK (m, x, y);
542 399
543 /* Space is blocked - try changing direction a little */ 400 /* Space is blocked - try changing direction a little */
544 if ((mflags & P_OUT_OF_MAP) || ((OB_TYPE_MOVE_BLOCK (mon, blocked) || (mflags & P_BLOCKSVIEW)) 401 if (!pos.normalise ()
545 && (m == mon->map && blocked_link (mon, m, x, y)))) 402 || (((pos->flags () & P_BLOCKSVIEW) || OB_TYPE_MOVE_BLOCK (mon, pos->move_block))
403 && blocked_link (mon, pos.m, pos.x, pos.y)))
546 { 404 {
547 /* recalculate direction from last good location. Possible 405 /* recalculate direction from last good location. Possible
548 * we were not traversing ideal location before. 406 * we were not traversing ideal location before.
549 */ 407 */
550 get_rangevector_from_mapcoord (lastmap, lastx, lasty, pl, &rv, 0); 408 get_rangevector_from_mapcoord (lastpos.m, lastpos.x, lastpos.y, pl, &rv, 0);
551 if (rv.direction != dir) 409 if (rv.direction != dir)
552 { 410 {
553 /* OK - says direction should be different - lets reset the 411 /* OK - says direction should be different - lets reset the
554 * the values so it will try again. 412 * the values so it will try again.
555 */ 413 */
556 x = lastx;
557 y = lasty;
558 m = lastmap; 414 pos = lastpos;
559 dir = firstdir = rv.direction; 415 dir = firstdir = rv.direction;
560 } 416 }
561 else 417 else
562 { 418 {
563 /* direct path is blocked - try taking a side step to 419 /* direct path is blocked - try taking a side step to
… …
570 */ 426 */
571 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++) 427 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++)
572 { 428 {
573 if (i == 0) 429 if (i == 0)
574 continue; /* already did this, so skip it */ 430 continue; /* already did this, so skip it */
431
575 /* Use lastdir here - otherwise, 432 /* Use lastdir here - otherwise,
576 * since the direction that the creature should move in 433 * since the direction that the creature should move in
577 * may change, you could get infinite loops. 434 * may change, you could get infinite loops.
578 * ie, player is northwest, but monster can only 435 * ie, player is northwest, but monster can only
579 * move west, so it does that. It goes some distance, 436 * move west, so it does that. It goes some distance,
… …
581 * can't do that, but now finds it can move east, and 438 * can't do that, but now finds it can move east, and
582 * gets back to its original point. lastdir contains 439 * gets back to its original point. lastdir contains
583 * the last direction the creature has successfully 440 * the last direction the creature has successfully
584 * moved. 441 * moved.
585 */ 442 */
586
587 x = lastx + freearr_x[absdir (lastdir + i)];
588 y = lasty + freearr_y[absdir (lastdir + i)];
589 m = lastmap; 443 pos = lastpos;
590 mflags = get_map_flags (m, &m, x, y, &x, &y); 444 pos.move (absdir (lastdir + i));
591 if (mflags & P_OUT_OF_MAP) 445
446 if (!pos.normalise ())
592 continue; 447 continue;
593 blocked = GET_MAP_MOVE_BLOCK (m, x, y); 448
594 if (OB_TYPE_MOVE_BLOCK (mon, blocked)) 449 mapspace &ms = *pos;
450
451 if (ms.flags () & P_BLOCKSVIEW)
595 continue; 452 continue;
596 if (mflags & P_BLOCKSVIEW) 453
454 if (OB_TYPE_MOVE_BLOCK (mon, ms.move_block))
597 continue; 455 continue;
598 456
599 if (m == mon->map && blocked_link (mon, m, x, y)) 457 if (blocked_link (mon, pos.m, pos.x, pos.y))
600 break; 458 break;
601 } 459 }
460
602 /* go through entire loop without finding a valid 461 /* go through entire loop without finding a valid
603 * sidestep to take - thus, no valid path. 462 * sidestep to take - thus, no valid path.
604 */ 463 */
605 if (i == (DETOUR_AMOUNT + 1)) 464 if (i == DETOUR_AMOUNT + 1)
606 return 0; 465 return 0;
466
607 diff--; 467 diff--;
608 lastdir = dir; 468 lastdir = dir;
609 max--; 469 max--;
610 if (!firstdir) 470 if (!firstdir)
611 firstdir = dir + i; 471 firstdir = dir + i;
… …
615 { 475 {
616 /* we moved towards creature, so diff is less */ 476 /* we moved towards creature, so diff is less */
617 diff--; 477 diff--;
618 max--; 478 max--;
619 lastdir = dir; 479 lastdir = dir;
480
620 if (!firstdir) 481 if (!firstdir)
621 firstdir = dir; 482 firstdir = dir;
622 } 483 }
623 484
624 if (diff <= 1) 485 if (diff <= 1)
625 { 486 {
626 /* Recalculate diff (distance) because we may not have actually 487 /* Recalculate diff (distance) because we may not have actually
627 * headed toward player for entire distance. 488 * headed toward player for entire distance.
628 */ 489 */
629 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 490 get_rangevector_from_mapcoord (pos.m, pos.x, pos.y, pl, &rv, 0);
630 diff = ::max (abs (rv.distance_x), abs (rv.distance_y)); 491 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
631 } 492 }
632 493
633 if (diff > max) 494 if (diff > max)
634 return 0; 495 return 0;
… …
652 next = op->below; 513 next = op->below;
653 514
654 /* Forces get applied per default, unless they have the 515 /* Forces get applied per default, unless they have the
655 * flag "neutral" set. Sorry but I can't think of a better way 516 * flag "neutral" set. Sorry but I can't think of a better way
656 */ 517 */
657 if (op->type == FORCE && !QUERY_FLAG (op, FLAG_NEUTRAL)) 518 if (op->type == FORCE && !op->flag [FLAG_NEUTRAL])
658 SET_FLAG (op, FLAG_APPLIED); 519 op->set_flag (FLAG_APPLIED);
659 520
660 /* we never give weapons/armour if these cannot be used 521 /* we never give weapons/armour if these cannot be used
661 * by this player due to race restrictions 522 * by this player due to race restrictions
662 */ 523 */
663 if (pl->type == PLAYER) 524 if (pl->type == PLAYER)
664 { 525 {
665 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) 526 if ((!pl->flag [FLAG_USE_ARMOUR]
666 && 527 &&
667 (op->type == ARMOUR || op->type == BOOTS 528 (op->type == ARMOUR || op->type == BOOTS
668 || op->type == CLOAK || op->type == HELMET 529 || op->type == CLOAK || op->type == HELMET
669 || op->type == SHIELD || op->type == GLOVES 530 || op->type == SHIELD || op->type == GLOVES
670 || op->type == BRACERS || op->type == GIRDLE)) 531 || op->type == BRACERS || op->type == GIRDLE))
671 || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 532 || (!pl->flag [FLAG_USE_WEAPON] && op->type == WEAPON))
672 { 533 {
673 op->destroy (); 534 op->destroy ();
674 continue; 535 continue;
675 } 536 }
676 } 537 }
677 538
678 /* This really needs to be better - we should really give 539 /* Here we remove duplicated skills (as duplicated spell objects have
679 * a substitute spellbook. The problem is that we don't really 540 * _very_ confusing effects for players), which could for instance be
680 * have a good idea what to replace it with (need something like 541 * generated by multiple treasurelists specifying the same skills.
681 * a first level treasurelist for each skill.)
682 * remove duplicate skills also
683 */ 542 */
684 if (op->type == SPELLBOOK || op->type == SKILL) 543 if (op->type == SKILL)
685 { 544 {
686 object *tmp;
687
688 for (tmp = op->below; tmp; tmp = tmp->below) 545 for (object *tmp = op->below; tmp; tmp = tmp->below)
689 if (tmp->type == op->type && tmp->name == op->name) 546 if (tmp->type == op->type && tmp->name == op->name)
690 break;
691
692 if (tmp)
693 { 547 {
694 op->destroy (); 548 op->destroy ();
695 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 549 break;
696 continue;
697 } 550 }
698 551
699 if (op->nrof > 1) 552 if (op->nrof > 1)
700 op->nrof = 1; 553 op->nrof = 1;
701 } 554 }
702 555
703 if (op->type == SPELLBOOK && op->inv) 556 if (op->type == SPELLBOOK && op->inv)
704 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP); 557 op->inv->clr_flag (FLAG_STARTEQUIP);
705 558
706 /* Give starting characters identified, uncursed, and undamned 559 /* Give starting characters identified, uncursed, and undamned
707 * items. Just don't identify gold or silver, or it won't be 560 * items. Just don't identify gold or silver, or it won't be
708 * merged properly. 561 * merged properly.
709 */ 562 */
710 if (need_identify (op)) 563 if (op->need_identify ())
711 { 564 {
712 SET_FLAG (op, FLAG_IDENTIFIED); 565 op->set_flag (FLAG_IDENTIFIED);
713 CLEAR_FLAG (op, FLAG_CURSED); 566 op->clr_flag (FLAG_CURSED);
714 CLEAR_FLAG (op, FLAG_DAMNED); 567 op->clr_flag (FLAG_DAMNED);
715 } 568 }
716 569
717 if (op->type == SPELL) 570 if (op->type == SPELL)
718 { 571 {
719 op->destroy (); 572 op->destroy ();
720 continue; 573 continue;
721 } 574 }
722 else if (op->type == SKILL) 575 else if (op->type == SKILL)
723 { 576 {
724 SET_FLAG (op, FLAG_CAN_USE_SKILL); 577 op->set_flag (FLAG_CAN_USE_SKILL);
725 op->stats.exp = 0; 578 op->stats.exp = 0;
726 op->level = 1; 579 op->level = 1;
727 } 580 }
728 else /* lock all 'normal items by default */ 581 else /* lock all 'normal items by default */
729 SET_FLAG (op, FLAG_INV_LOCKED); 582 op->set_flag (FLAG_INV_LOCKED);
730 } /* for loop of objects in player inv */ 583 } /* for loop of objects in player inv */
731 584
732 /* Need to set up the skill pointers */ 585 /* Need to set up the skill pointers */
733 pl->contr->link_skills (); 586 pl->contr->link_skills ();
734} 587}
… …
748 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:"); 601 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:");
749} 602}
750 603
751/* This rolls four 1-6 rolls and sums the best 3 of the 4. */ 604/* This rolls four 1-6 rolls and sums the best 3 of the 4. */
752static int 605static int
753roll_stat (void) 606roll_stat ()
754{ 607{
755 int a[4], i, j, k; 608 int a[4], i, j, k;
756 609
757 for (i = 0; i < 4; i++) 610 for (i = 0; i < 4; i++)
758 a[i] = (int) rndm (6) + 1; 611 a[i] = rndm (1, 6);
759 612
760 for (i = 0, j = 0, k = 7; i < 4; i++) 613 for (i = 0, j = 0, k = 7; i < 4; i++)
761 if (a[i] < k) 614 if (a[i] < k)
762 k = a[i], j = i; 615 k = a[i], j = i;
763 616
… …
855player::chargen_race_done () 708player::chargen_race_done ()
856{ 709{
857 /* this must before then initial items are given */ 710 /* this must before then initial items are given */
858 esrv_new_player (ob->contr); 711 esrv_new_player (ob->contr);
859 712
860 treasurelist *tl = treasurelist::find ("starting_wealth"); 713 treasurelist *tl = treasurelist::find (shstr_starting_wealth);
861 if (tl) 714 if (tl)
862 create_treasure (tl, ob, 0, 0, 0); 715 create_treasure (tl, ob, 0, 0, 0);
863 716
864 INVOKE_PLAYER (BIRTH, ob->contr); 717 INVOKE_PLAYER (BIRTH, ob->contr);
865 INVOKE_PLAYER (LOGIN, ob->contr);
866 718
867 ob->contr->ns->state = ST_PLAYING; 719 ob->contr->ns->state = ST_PLAYING;
868 720
869 if (ob->msg) 721 if (ob->msg)
870 ob->msg = 0; 722 ob->msg = 0;
871 723
872 start_info (ob); 724 start_info (ob);
873 CLEAR_FLAG (ob, FLAG_WIZ); 725 ob->clr_flag (FLAG_WIZ);
874 give_initial_items (ob, ob->randomitems); 726 give_initial_items (ob, ob->randomitems);
875 esrv_send_inventory (ob, ob); 727 esrv_send_inventory (ob, ob);
876 ob->update_stats (); 728 ob->update_stats ();
877 729
878 /* This moves the player to a different start map, if there 730 /* This moves the player to a different start map, if there
… …
880 */ 732 */
881 if (*first_map_ext_path) 733 if (*first_map_ext_path)
882 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y); 734 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
883 else 735 else
884 LOG (llevDebug, "first_map_ext_path not set\n"); 736 LOG (llevDebug, "first_map_ext_path not set\n");
737}
738
739/*
740 * Returns true if the given player is a legal class.
741 * The function to add and remove class-bonuses to the stats doesn't
742 * check if the stat becomes negative, thus this function
743 * merely checks that all stats are 1 or more, and returns
744 * false otherwise.
745 */
746static int
747allowed_class (const object *op)
748{
749 return op->stats.Dex > 0
750 && op->stats.Str > 0
751 && op->stats.Con > 0
752 && op->stats.Int > 0
753 && op->stats.Wis > 0
754 && op->stats.Pow > 0
755 && op->stats.Cha > 0;
885} 756}
886 757
887void 758void
888player::chargen_race_next () 759player::chargen_race_next ()
889{ 760{
… …
918 ob->stats.hp = ob->stats.maxhp; 789 ob->stats.hp = ob->stats.maxhp;
919 ob->stats.sp = ob->stats.maxsp; 790 ob->stats.sp = ob->stats.maxsp;
920 ob->stats.grace = 0; 791 ob->stats.grace = 0;
921} 792}
922 793
923void 794static void
924flee_player (object *op) 795flee_player (object *op)
925{ 796{
926 int dir, diff; 797 int dir, diff;
927 rv_vector rv; 798 rv_vector rv;
928 799
929 if (op->stats.hp < 0) 800 if (op->stats.hp < 0)
930 { 801 {
931 LOG (llevDebug, "Fleeing player is dead.\n"); 802 LOG (llevDebug, "Fleeing player is dead.\n");
932 CLEAR_FLAG (op, FLAG_SCARED); 803 op->clr_flag (FLAG_SCARED);
933 return; 804 return;
934 } 805 }
935 806
936 if (!op->enemy) 807 if (!op->enemy)
937 { 808 {
938 LOG (llevDebug, "Fleeing player had no enemy.\n"); 809 LOG (llevDebug, "Fleeing player had no enemy.\n");
939 CLEAR_FLAG (op, FLAG_SCARED); 810 op->clr_flag (FLAG_SCARED);
940 return; 811 return;
941 } 812 }
942 813
943 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0)) 814 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
944 { 815 {
945 op->enemy = NULL; 816 op->enemy = NULL;
946 CLEAR_FLAG (op, FLAG_SCARED); 817 op->clr_flag (FLAG_SCARED);
947 return; 818 return;
948 } 819 }
949 820
950 get_rangevector (op, op->enemy, &rv, 0); 821 get_rangevector (op, op->enemy, &rv, 0);
951 822
952 dir = absdir (4 + rv.direction); 823 dir = absdir (4 + rv.direction);
953 for (diff = 0; diff < 3; diff++) 824 for (diff = 0; diff < 3; diff++)
954 { 825 {
955 int m = 1 - (RANDOM () & 2); 826 int m = 1 - rndm (2) * 2;
956 827
957 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 828 if (op->move (absdir (dir + diff * m)) || (diff == 0 && op->move (absdir (dir - diff * m))))
958 return; 829 return;
959 } 830 }
960 831
961 /* Cornered, get rid of scared */ 832 /* Cornered, get rid of scared */
962 CLEAR_FLAG (op, FLAG_SCARED); 833 op->clr_flag (FLAG_SCARED);
963 op->enemy = NULL; 834 op->enemy = NULL;
964} 835}
965 836
966/* check_pick sees if there is stuff to be picked up/picks up stuff. 837/* check_pick sees if there is stuff to be picked up/picks up stuff.
967 * It returns 1 if the player should keep on moving, 0 if he should 838 * It returns 1 if the player should keep on moving, 0 if he should
… …
971check_pick (object *op) 842check_pick (object *op)
972{ 843{
973 object *tmp, *next; 844 object *tmp, *next;
974 int stop = 0; 845 int stop = 0;
975 int wvratio; 846 int wvratio;
976 char putstring[128];
977 847
978 /* if you're flying, you cna't pick up anything */ 848 /* if you're flying, you can't pick up anything */
979 if (op->move_type & MOVE_FLYING) 849 if (op->move_type & MOVE_FLYING)
980 return 1; 850 return 1;
981 851
982 next = op->below; 852 next = op->below;
983 853
984 int cnt = MAX_ITEM_PER_DROP; 854 int cnt = MAX_ITEM_PER_ACTION;
985#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0) 855#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
986 856
987 /* loop while there are items on the floor that are not marked as 857 /* loop while there are items on the floor that are not marked as
988 * destroyed */ 858 * destroyed */
989 while (next && !next->destroyed ()) 859 while (next && !next->destroyed ())
… …
1009 CHK_PICK_PICKUP; 879 CHK_PICK_PICKUP;
1010 880
1011 continue; 881 continue;
1012 } 882 }
1013 883
1014 /* high not bit set? We're using the old autopickup model */ 884 /* pickup handling */
885 if (op->contr->mode & PU_DEBUG)
886 {
887 /* some debugging code to figure out item information */
888 const char *str = tmp->name
889 ? format ("item name: %s item type: %d weight/value: %d",
890 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))))
891 : format ("item name: %s item type: %d weight/value: %d",
892 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
893
894 new_draw_info (NDI_UNIQUE, 0, op, str);
895 }
896
897 if (op->contr->mode & PU_INHIBIT)
898 return 1;
899
900 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
901 return 1;
902
903 /* philosophy:
904 * It's easy to grab an item type from a pile, as long as it's
905 * generic. This takes no game-time. For more detailed pickups
906 * and selections, select-items should be used. This is a
907 * grab-as-you-run type mode that's really useful for arrows for
908 * example.
909 * The drawback: right now it has no frontend, so you need to
910 * stick the bits you want into a calculator in hex mode and then
911 * convert to decimal and then 'pickup <#>
912 */
913
914 /* the first two modes are exclusive: if NOTHING we return, if
915 * STOP then we stop. All the rest are applied sequentially,
916 * meaning if any test passes, the item gets picked up. */
917
918 /* if mode is set to pick nothing up, return */
919 if (op->contr->mode == PU_NOTHING)
920 return 1;
921
922 /* if mode is set to stop when encountering objects, return */
923 /* take STOP before INHIBIT since it doesn't actually pick
924 * anything up */
925 if (op->contr->mode & PU_STOP)
926 return 0;
927
928 /* useful for going into stores and not losing your settings... */
929 /* and for battles wher you don't want to get loaded down while
930 * fighting */
931 if (op->contr->mode & PU_INHIBIT)
932 return 1;
933
934 /* prevent us from turning into auto-thieves :) */
935 if (tmp->flag [FLAG_UNPAID])
936 continue;
937
938 /* ignore known cursed objects */
939 if (tmp->flag [FLAG_KNOWN_CURSED] && op->contr->mode & PU_NOT_CURSED)
940 continue;
941
942 /* all food and drink if desired */
943 /* question: don't pick up known-poisonous stuff? */
1015 if (!(op->contr->mode & PU_NEWMODE)) 944 if (op->contr->mode & PU_FOOD)
945 if (tmp->type == FOOD)
1016 { 946 {
1017 switch (op->contr->mode) 947 CHK_PICK_PICKUP;
948 continue;
949 }
950
951 if (op->contr->mode & PU_DRINK)
952 if (tmp->type == DRINK || (tmp->type == POISON && !tmp->flag [FLAG_KNOWN_CURSED]))
953 {
954 CHK_PICK_PICKUP;
955 continue;
956 }
957
958 if (op->contr->mode & PU_POTION)
959 if (tmp->type == POTION)
960 {
961 CHK_PICK_PICKUP;
962 continue;
963 }
964
965 /* spellbooks, skillscrolls and normal books/scrolls */
966 if (op->contr->mode & PU_SPELLBOOK)
967 if (tmp->type == SPELLBOOK)
968 {
969 CHK_PICK_PICKUP;
970 continue;
971 }
972
973 if (op->contr->mode & PU_SKILLSCROLL)
974 if (tmp->type == SKILLSCROLL)
975 {
976 CHK_PICK_PICKUP;
977 continue;
978 }
979
980 if (op->contr->mode & PU_READABLES)
981 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
982 {
983 CHK_PICK_PICKUP;
984 continue;
985 }
986
987 /* wands/staves/rods/horns */
988 if (op->contr->mode & PU_MAGIC_DEVICE)
989 if (tmp->type == WAND
990 || tmp->type == ROD
991 || tmp->type == HORN
992 || tmp->type == POWER_CRYSTAL)
993 {
994 CHK_PICK_PICKUP;
995 continue;
996 }
997
998 /* pick up all magical items */
999 if (op->contr->mode & PU_MAGICAL)
1000 if (tmp->flag [FLAG_KNOWN_MAGICAL]
1001 && !tmp->flag [FLAG_KNOWN_CURSED])
1002 {
1003 CHK_PICK_PICKUP;
1004 continue;
1005 }
1006
1007 if (op->contr->mode & PU_VALUABLES)
1008 {
1009 if (tmp->type == MONEY || tmp->type == GEM)
1018 { 1010 {
1019 case 0:
1020 return 1; /* don't pick up */
1021 case 1:
1022 CHK_PICK_PICKUP; 1011 CHK_PICK_PICKUP;
1023 return 1; 1012 continue;
1024 case 2:
1025 CHK_PICK_PICKUP;
1026 return 0;
1027 case 3:
1028 return 0; /* stop before pickup */
1029 case 4:
1030 CHK_PICK_PICKUP;
1031 break;
1032 case 5:
1033 CHK_PICK_PICKUP;
1034 stop = 1;
1035 break;
1036 case 6:
1037 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL)
1038 && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1039 CHK_PICK_PICKUP;
1040 break;
1041
1042 case 7:
1043 if (tmp->type == MONEY || tmp->type == GEM)
1044 CHK_PICK_PICKUP;
1045 break;
1046
1047 default:
1048 /* use value density */
1049 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1050 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1051 CHK_PICK_PICKUP;
1052 } 1013 }
1053 } 1014 }
1054 else 1015
1055 { /* old model */ 1016 /* rings & amulets - talismans seems to be typed AMULET */
1056 /* NEW pickup handling */
1057 if (op->contr->mode & PU_DEBUG) 1017 if (op->contr->mode & PU_JEWELS)
1018 if (tmp->type == RING
1019 || tmp->type == AMULET
1020 || tmp->type == GIRDLE
1021 || tmp->type == SKILL_TOOL)
1058 { 1022 {
1059 /* some debugging code to figure out item information */ 1023 CHK_PICK_PICKUP;
1060 if (tmp->name != NULL)
1061 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1062 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1063 else
1064 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1065 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1066
1067 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1068 }
1069
1070 /* philosophy:
1071 * It's easy to grab an item type from a pile, as long as it's
1072 * generic. This takes no game-time. For more detailed pickups
1073 * and selections, select-items should be used. This is a
1074 * grab-as-you-run type mode that's really useful for arrows for
1075 * example.
1076 * The drawback: right now it has no frontend, so you need to
1077 * stick the bits you want into a calculator in hex mode and then
1078 * convert to decimal and then 'pickup <#>
1079 */
1080
1081 /* the first two modes are exclusive: if NOTHING we return, if
1082 * STOP then we stop. All the rest are applied sequentially,
1083 * meaning if any test passes, the item gets picked up. */
1084
1085 /* if mode is set to pick nothing up, return */
1086
1087 if (op->contr->mode & PU_NOTHING)
1088 return 1;
1089
1090 /* if mode is set to stop when encountering objects, return */
1091 /* take STOP before INHIBIT since it doesn't actually pick
1092 * anything up */
1093
1094 if (op->contr->mode & PU_STOP)
1095 return 0;
1096
1097 /* useful for going into stores and not losing your settings... */
1098 /* and for battles wher you don't want to get loaded down while
1099 * fighting */
1100 if (op->contr->mode & PU_INHIBIT)
1101 return 1;
1102
1103 /* prevent us from turning into auto-thieves :) */
1104 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1105 continue; 1024 continue;
1025 }
1106 1026
1107 /* ignore known cursed objects */ 1027 /* we don't forget dragon food */
1108 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1028 if (op->contr->mode & PU_FLESH)
1029 if (tmp->type == FLESH)
1030 {
1031 CHK_PICK_PICKUP;
1109 continue; 1032 continue;
1033 }
1110 1034
1111 /* all food and drink if desired */ 1035 /* bows and arrows. Bows are good for selling! */
1112 /* question: don't pick up known-poisonous stuff? */ 1036 if (op->contr->mode & PU_BOW)
1037 if (tmp->type == BOW)
1038 {
1039 CHK_PICK_PICKUP;
1040 continue;
1041 }
1042
1043 if (op->contr->mode & PU_ARROW)
1044 if (tmp->type == ARROW)
1045 {
1046 CHK_PICK_PICKUP;
1047 continue;
1048 }
1049
1050 /* all kinds of armor etc. */
1051 if (op->contr->mode & PU_ARMOUR)
1052 if (tmp->type == ARMOUR)
1053 {
1054 CHK_PICK_PICKUP;
1055 continue;
1056 }
1057
1058 if (op->contr->mode & PU_HELMET)
1059 if (tmp->type == HELMET)
1060 {
1061 CHK_PICK_PICKUP;
1062 continue;
1063 }
1064
1065 if (op->contr->mode & PU_SHIELD)
1066 if (tmp->type == SHIELD)
1067 {
1068 CHK_PICK_PICKUP;
1069 continue;
1070 }
1071
1113 if (op->contr->mode & PU_FOOD) 1072 if (op->contr->mode & PU_BOOTS)
1114 if (tmp->type == FOOD) 1073 if (tmp->type == BOOTS)
1074 {
1075 CHK_PICK_PICKUP;
1076 continue;
1077 }
1078
1079 if (op->contr->mode & PU_GLOVES)
1080 if (tmp->type == GLOVES || tmp->type == BRACERS)
1081 {
1082 CHK_PICK_PICKUP;
1083 continue;
1084 }
1085
1086 if (op->contr->mode & PU_CLOAK)
1087 if (tmp->type == CLOAK)
1088 {
1089 CHK_PICK_PICKUP;
1090 continue;
1091 }
1092
1093 /* hoping to catch throwing daggers here */
1094 if (op->contr->mode & PU_MISSILEWEAPON)
1095 if (tmp->type == WEAPON && tmp->flag [FLAG_IS_THROWN])
1096 {
1097 CHK_PICK_PICKUP;
1098 continue;
1099 }
1100
1101 /* careful: chairs and tables are weapons! */
1102 if (op->contr->mode & PU_ALLWEAPON)
1103 {
1104 if (tmp->type == WEAPON)
1105 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1115 { 1106 {
1116 CHK_PICK_PICKUP; 1107 CHK_PICK_PICKUP;
1117 continue; 1108 continue;
1118 } 1109 }
1110 }
1119 1111
1112 /* misc stuff that's useful */
1120 if (op->contr->mode & PU_DRINK) 1113 if (op->contr->mode & PU_KEY)
1121 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1114 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1122 { 1115 {
1123 CHK_PICK_PICKUP; 1116 CHK_PICK_PICKUP;
1124 continue; 1117 continue;
1125 } 1118 }
1126 1119
1120 /* any of the last 4 bits set means we use the ratio for value
1121 * pickups */
1127 if (op->contr->mode & PU_POTION) 1122 if (op->contr->mode & PU_RATIO)
1128 if (tmp->type == POTION) 1123 {
1124 /* use value density to decide what else to grab */
1125 /* >=7 was >= op->contr->mode */
1126 /* >=7 is the old standard setting. Now we take the last 4 bits
1129 { 1127 */
1130 CHK_PICK_PICKUP;
1131 continue;
1132 }
1133
1134 /* spellbooks, skillscrolls and normal books/scrolls */
1135 if (op->contr->mode & PU_SPELLBOOK)
1136 if (tmp->type == SPELLBOOK)
1137 {
1138 CHK_PICK_PICKUP;
1139 continue;
1140 }
1141
1142 if (op->contr->mode & PU_SKILLSCROLL)
1143 if (tmp->type == SKILLSCROLL)
1144 {
1145 CHK_PICK_PICKUP;
1146 continue;
1147 }
1148
1149 if (op->contr->mode & PU_READABLES)
1150 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
1151 {
1152 CHK_PICK_PICKUP;
1153 continue;
1154 }
1155
1156 /* wands/staves/rods/horns */
1157 if (op->contr->mode & PU_MAGIC_DEVICE)
1158 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1159 {
1160 CHK_PICK_PICKUP;
1161 continue;
1162 }
1163
1164 /* pick up all magical items */
1165 if (op->contr->mode & PU_MAGICAL) 1128 wvratio = op->contr->mode & PU_RATIO;
1166 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1129 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1167 {
1168 CHK_PICK_PICKUP;
1169 continue;
1170 }
1171
1172 if (op->contr->mode & PU_VALUABLES)
1173 { 1130 {
1174 if (tmp->type == MONEY || tmp->type == GEM) 1131#if 0
1132 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1133 if (tmp->name != NULL)
1175 { 1134 {
1176 CHK_PICK_PICKUP; 1135 fprintf (stderr, "%s", tmp->name);
1177 continue;
1178 } 1136 }
1179 }
1180
1181 /* rings & amulets - talismans seems to be typed AMULET */
1182 if (op->contr->mode & PU_JEWELS)
1183 if (tmp->type == RING || tmp->type == AMULET)
1184 {
1185 CHK_PICK_PICKUP;
1186 continue;
1187 }
1188
1189 /* we don't forget dragon food */
1190 if (op->contr->mode & PU_FLESH)
1191 if (tmp->type == FLESH)
1192 {
1193 CHK_PICK_PICKUP;
1194 continue;
1195 }
1196
1197 /* bows and arrows. Bows are good for selling! */
1198 if (op->contr->mode & PU_BOW)
1199 if (tmp->type == BOW)
1200 {
1201 CHK_PICK_PICKUP;
1202 continue;
1203 }
1204
1205 if (op->contr->mode & PU_ARROW)
1206 if (tmp->type == ARROW)
1207 {
1208 CHK_PICK_PICKUP;
1209 continue;
1210 }
1211
1212 /* all kinds of armor etc. */
1213 if (op->contr->mode & PU_ARMOUR)
1214 if (tmp->type == ARMOUR)
1215 {
1216 CHK_PICK_PICKUP;
1217 continue;
1218 }
1219
1220 if (op->contr->mode & PU_HELMET)
1221 if (tmp->type == HELMET)
1222 {
1223 CHK_PICK_PICKUP;
1224 continue;
1225 }
1226
1227 if (op->contr->mode & PU_SHIELD)
1228 if (tmp->type == SHIELD)
1229 {
1230 CHK_PICK_PICKUP;
1231 continue;
1232 }
1233
1234 if (op->contr->mode & PU_BOOTS)
1235 if (tmp->type == BOOTS)
1236 {
1237 CHK_PICK_PICKUP;
1238 continue;
1239 }
1240
1241 if (op->contr->mode & PU_GLOVES)
1242 if (tmp->type == GLOVES)
1243 {
1244 CHK_PICK_PICKUP;
1245 continue;
1246 }
1247
1248 if (op->contr->mode & PU_CLOAK)
1249 if (tmp->type == CLOAK)
1250 {
1251 CHK_PICK_PICKUP;
1252 continue;
1253 }
1254
1255 /* hoping to catch throwing daggers here */
1256 if (op->contr->mode & PU_MISSILEWEAPON)
1257 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1258 {
1259 CHK_PICK_PICKUP;
1260 continue;
1261 }
1262
1263 /* careful: chairs and tables are weapons! */
1264 if (op->contr->mode & PU_ALLWEAPON)
1265 {
1266 if (tmp->type == WEAPON && tmp->name != NULL)
1267 {
1268 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->archname, "table") == NULL &&
1269 strstr (tmp->name, "chair") && strstr (tmp->arch->archname, "chair") == NULL)
1270 {
1271 CHK_PICK_PICKUP;
1272 continue;
1273 }
1274 }
1275
1276 if (tmp->type == WEAPON && tmp->name == NULL)
1277 {
1278 if (strstr (tmp->arch->archname, "table") == NULL && strstr (tmp->arch->archname, "chair") == NULL)
1279 {
1280 CHK_PICK_PICKUP;
1281 continue;
1282 }
1283 }
1284 }
1285
1286 /* misc stuff that's useful */
1287 if (op->contr->mode & PU_KEY)
1288 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1289 {
1290 CHK_PICK_PICKUP;
1291 continue;
1292 }
1293
1294 /* any of the last 4 bits set means we use the ratio for value
1295 * pickups */
1296 if (op->contr->mode & PU_RATIO)
1297 {
1298 /* use value density to decide what else to grab */
1299 /* >=7 was >= op->contr->mode */
1300 /* >=7 is the old standard setting. Now we take the last 4 bits
1301 */
1302 wvratio = op->contr->mode & PU_RATIO;
1303 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1304 {
1305 CHK_PICK_PICKUP;
1306#if 0
1307 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1308 if (tmp->name != NULL)
1309 {
1310 fprintf (stderr, "%s", tmp->name);
1311 }
1312 else 1137 else
1313 fprintf (stderr, "%s", tmp->arch->archname); 1138 fprintf (stderr, "%s", tmp->arch->archname);
1314 fprintf (stderr, ",%d] = ", tmp->type); 1139 fprintf (stderr, ",%d] = ", tmp->type);
1315 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1140 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
1316#endif 1141#endif
1142 CHK_PICK_PICKUP;
1317 continue; 1143 continue;
1318 }
1319 } 1144 }
1320 } /* the new pickup model */ 1145 } /* the new pickup model */
1321 } 1146 }
1322 1147
1323 return !stop; 1148 return !stop;
1149}
1150
1151/* routine for both players and monsters. We call this when
1152 * there is a possibility for our action distrubing our hiding
1153 * place or invisiblity spell. Artefact invisiblity causes
1154 * "noise" instead. If we arent invisible to begin with, we
1155 * return 0.
1156 */
1157static int
1158action_makes_visible (object *op)
1159{
1160 if (op->invisible && op->flag [FLAG_ALIVE])
1161 {
1162 if (op->flag [FLAG_MAKE_INVIS])
1163 {
1164 // artefact invisibility is permanent, but we still make noise
1165 // this is important for game-balance.
1166 if (op->contr)
1167 op->make_noise ();
1168
1169 return 0;
1170 }
1171
1172 if (op->contr && op->contr->tmp_invis == 0)
1173 return 0;
1174
1175 /* If monsters, they should become visible */
1176 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
1177 {
1178 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
1179 return 1;
1180 }
1181 }
1182
1183 return 0;
1324} 1184}
1325 1185
1326/* 1186/*
1327 * Find an arrow in the inventory and after that 1187 * Find an arrow in the inventory and after that
1328 * in the right type container (quiver). Pointer to the 1188 * in the right type container (quiver). Pointer to the
1329 * found object is returned. 1189 * found object is returned.
1330 */ 1190 */
1331object * 1191static object *
1332find_arrow (object *op, const char *type) 1192find_arrow (object *op, const char *type)
1333{ 1193{
1334 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1194 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1335 if (tmp->type == ARROW && !strcmp (&tmp->race, type)) 1195 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1336 return splay (tmp); 1196 return splay (tmp);
1337 1197
1338 for (object *tmp = op->inv; tmp; tmp = tmp->below) 1198 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1339 if (tmp->type == CONTAINER && QUERY_FLAG (tmp, FLAG_APPLIED) && !strcmp (&tmp->race, type)) 1199 if (tmp->type == CONTAINER && tmp->flag [FLAG_APPLIED] && !strcmp (&tmp->race, type))
1340 if (object *arrow = find_arrow (tmp, type)) 1200 if (object *arrow = find_arrow (tmp, type))
1341 { 1201 {
1342 splay (tmp); 1202 splay (tmp);
1343 return arrow; 1203 return arrow;
1344 } 1204 }
… …
1350 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1210 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1351 * against the target. A full test is not performed, simply a basic test 1211 * against the target. A full test is not performed, simply a basic test
1352 * of resistances. The archer is making a quick guess at what he sees down 1212 * of resistances. The archer is making a quick guess at what he sees down
1353 * the hall. Failing that it does it's best to pick the highest plus arrow. 1213 * the hall. Failing that it does it's best to pick the highest plus arrow.
1354 */ 1214 */
1355object * 1215static object *
1356find_better_arrow (object *op, object *target, const char *type, int *better) 1216find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1357{ 1217{
1358 object *tmp = NULL, *arrow, *ntmp; 1218 object *tmp = NULL, *arrow, *ntmp;
1359 int attacknum, attacktype, betterby = 0, i; 1219 int attacknum, attacktype, betterby = 0, i;
1360 1220
1361 if (!type) 1221 if (!type)
1362 return NULL; 1222 return NULL;
1363 1223
1364 for (arrow = op->inv; arrow; arrow = arrow->below) 1224 for (arrow = op->inv; arrow; arrow = arrow->below)
1365 { 1225 {
1366 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1226 if (arrow->type == CONTAINER && arrow->race == type && arrow->flag [FLAG_APPLIED])
1367 { 1227 {
1368 i = 0; 1228 i = 0;
1369 ntmp = find_better_arrow (arrow, target, type, &i); 1229 ntmp = find_better_arrow (arrow, target, type, &i);
1230
1370 if (i > betterby) 1231 if (i > betterby)
1371 { 1232 {
1372 tmp = ntmp; 1233 tmp = ntmp;
1373 betterby = i; 1234 betterby = i;
1374 } 1235 }
1375 } 1236 }
1376 else if (arrow->type == ARROW && arrow->race == type) 1237 else if (arrow->type == ARROW && arrow->race == type)
1377 { 1238 {
1378 /* allways prefer assasination/slaying */ 1239 /* allways prefer assasination/slaying */
1379 if (target->race && arrow->slaying && strstr (arrow->slaying, target->race)) 1240 if (target->race && arrow->slaying.contains (target->race))
1380 { 1241 {
1381 if (arrow->attacktype & AT_DEATH) 1242 if (arrow->attacktype & AT_DEATH)
1382 { 1243 {
1383 *better = 100; 1244 *better = 100;
1384 return arrow; 1245 return arrow;
… …
1399 { 1260 {
1400 tmp = arrow; 1261 tmp = arrow;
1401 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100; 1262 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1402 } 1263 }
1403 } 1264 }
1265
1404 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1266 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1405 { 1267 {
1406 tmp = arrow; 1268 tmp = arrow;
1407 betterby = 2 + arrow->magic + arrow->stats.dam; 1269 betterby = 2 + arrow->magic + arrow->stats.dam;
1408 } 1270 }
1271
1409 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1272 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1410 { 1273 {
1411 tmp = arrow; 1274 tmp = arrow;
1412 betterby = 1 + arrow->magic + arrow->stats.dam; 1275 betterby = 1 + arrow->magic + arrow->stats.dam;
1413 } 1276 }
… …
1426 * find_better_arrow to find a decent arrow to use. 1289 * find_better_arrow to find a decent arrow to use.
1427 * op = the shooter 1290 * op = the shooter
1428 * type = bow->race 1291 * type = bow->race
1429 * dir = fire direction 1292 * dir = fire direction
1430 */ 1293 */
1431object * 1294static object *
1432pick_arrow_target (object *op, const char *type, int dir) 1295pick_arrow_target (object *op, shstr_cmp type, int dir)
1433{ 1296{
1434 object *tmp = NULL; 1297 object *tmp = NULL;
1435 maptile *m; 1298 maptile *m;
1436 int i, mflags, found, number; 1299 int i, mflags, found, number;
1437 sint16 x, y; 1300 sint16 x, y;
… …
1469 break; 1332 break;
1470 } 1333 }
1471 1334
1472 if (mflags & P_IS_ALIVE) 1335 if (mflags & P_IS_ALIVE)
1473 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1336 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1474 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1337 if (tmp->flag [FLAG_ALIVE])
1475 break; 1338 break;
1476 } 1339 }
1477 1340
1478 if (!tmp) 1341 if (!tmp)
1479 return find_arrow (op, type); 1342 return find_arrow (op, type);
… …
1523 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1386 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1524 return 0; 1387 return 0;
1525 } 1388 }
1526 1389
1527 // optimisation: move object to top so we will find it quickly again 1390 // optimisation: move object to top so we will find it quickly again
1528 if (bow->below) 1391 splay (bow);
1529 {
1530 bow->remove ();
1531 op->insert (bow);
1532 }
1533 } 1392 }
1534 1393
1535 if (!bow->race || !bow->skill) 1394 if (!bow->race || !bow->skill)
1536 { 1395 {
1537 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1396 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
… …
1544 { 1403 {
1545 if (op->type == PLAYER) 1404 if (op->type == PLAYER)
1546 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1405 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1547 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1406 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1548 else 1407 else
1549 CLEAR_FLAG (op, FLAG_READY_BOW); 1408 op->clr_flag (FLAG_READY_BOW);
1550 1409
1551 return 0; 1410 return 0;
1552 } 1411 }
1553 } 1412 }
1554 1413
… …
1583 arrow->direction = dir; 1442 arrow->direction = dir;
1584 1443
1585 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */ 1444 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1586 arrow->stats.hp = arrow->stats.dam; 1445 arrow->stats.hp = arrow->stats.dam;
1587 arrow->stats.grace = arrow->attacktype; 1446 arrow->stats.grace = arrow->attacktype;
1588 1447 arrow->custom_name = arrow->slaying;
1589 if (arrow->slaying)
1590 arrow->spellarg = strdup (arrow->slaying);
1591 1448
1592#if 0 1449#if 0
1593 if (player *pl = op->contr) 1450 if (player *pl = op->contr)
1594 { 1451 {
1595 float speed = pl->weapon_sp; 1452 float speed = pl->weapon_sp;
… …
1605#endif 1462#endif
1606 1463
1607 SET_ANIMATION (arrow, arrow->direction); 1464 SET_ANIMATION (arrow, arrow->direction);
1608 1465
1609 /* update the speed */ 1466 /* update the speed */
1610 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1611 + bow->stats.dam / 7.f;
1612 1467
1613 arrow->set_speed (max (arrow->speed, 2.f));
1614 arrow->speed_left = 0; 1468 arrow->speed_left = 0;
1469 arrow->set_speed (max (2.f,
1470 ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1471 + bow->stats.dam / 7.f
1472 ));
1615 1473
1616 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc; 1474 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1617 1475
1618 if (op->type == PLAYER) 1476 if (op->type == PLAYER)
1619 { 1477 {
… …
1640 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM); 1498 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1641 1499
1642 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC); 1500 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1643 arrow->move_type = MOVE_FLY_LOW; 1501 arrow->move_type = MOVE_FLY_LOW;
1644 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1502 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1503 arrow->set_flag (FLAG_NO_PICK);
1645 1504
1646 op->play_sound (sound_find ("fire_arrow")); 1505 op->play_sound (sound_find ("fire_arrow"));
1647 m->insert (arrow, sx, sy, op); 1506 m->insert (arrow, sx, sy, op);
1648 1507
1649 if (!arrow->destroyed ()) 1508 if (!arrow->destroyed ())
… …
1657 * but monsters can't. Putting that code here 1516 * but monsters can't. Putting that code here
1658 * makes the fire_bow code much cleaner. 1517 * makes the fire_bow code much cleaner.
1659 * this function should only be called if 'op' is a player, 1518 * this function should only be called if 'op' is a player,
1660 * hence the function name. 1519 * hence the function name.
1661 */ 1520 */
1662int 1521static int
1663player_fire_bow (object *op, int dir) 1522player_fire_bow (object *op, int dir)
1664{ 1523{
1665 int ret; 1524 int ret;
1666 1525
1667 if (op->contr->bowtype == bow_bestarrow) 1526 if (op->contr->bowtype == bow_bestarrow)
… …
1695} 1554}
1696 1555
1697/* Fires a misc (wand/rod/horn) object in 'dir'. 1556/* Fires a misc (wand/rod/horn) object in 'dir'.
1698 * Broken apart from 'fire' to keep it more readable. 1557 * Broken apart from 'fire' to keep it more readable.
1699 */ 1558 */
1700void 1559static void
1701fire_misc_object (object *op, int dir) 1560fire_misc_object (object *op, int dir)
1702{ 1561{
1703 object *item = op->contr->ranged_ob; 1562 object *item = op->contr->ranged_ob;
1704 1563
1705 if (!item) 1564 if (!item)
… …
1712 { 1571 {
1713 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1572 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1714 return; 1573 return;
1715 } 1574 }
1716 1575
1717 if (!op->change_weapon (item)) 1576 if (!op->apply (item))
1718 return; 1577 return;
1719 1578
1720 if (item->type == WAND) 1579 if (item->type == WAND)
1721 { 1580 {
1722 if (item->stats.food <= 0) 1581 if (item->stats.food <= 0)
… …
1727 return; 1586 return;
1728 } 1587 }
1729 } 1588 }
1730 else if (item->type == ROD || item->type == HORN) 1589 else if (item->type == ROD || item->type == HORN)
1731 { 1590 {
1732 sint16 spell_sp = MAX (item->inv->stats.sp, item->inv->stats.grace); 1591 sint16 spell_sp = max (item->inv->stats.sp, item->inv->stats.grace);
1733 1592
1734 // using the maximum of the rods charge allows at least one spell cast 1593 // using the maximum of the rods charge allows at least one spell cast
1735 // for a rod or horn, this fixes some broken rods. 1594 // for a rod or horn, this fixes some broken rods.
1736 if (item->stats.hp < MIN (spell_sp, item->stats.maxhp)) 1595 if (item->stats.hp < min (spell_sp, item->stats.maxhp))
1737 { 1596 {
1738 op->contr->play_sound (sound_find ("wand_poof")); 1597 op->contr->play_sound (sound_find ("wand_poof"));
1739 1598
1740 if (item->type == ROD) 1599 if (item->type == ROD)
1741 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1600 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
… …
1752 1611
1753 if (item->type == WAND) 1612 if (item->type == WAND)
1754 { 1613 {
1755 if (!(--item->stats.food)) 1614 if (!(--item->stats.food))
1756 { 1615 {
1757 object *tmp;
1758
1759 if (item->arch) 1616 if (item->arch)
1760 { 1617 {
1761 CLEAR_FLAG (item, FLAG_ANIMATE); 1618 item->clr_flag (FLAG_ANIMATE);
1762 item->face = item->arch->face; 1619 item->face = item->arch->face;
1763 item->set_speed (0); 1620 item->set_speed (0);
1764 } 1621 }
1765 1622
1766 if (object *pl = item->visible_to ()) 1623 if (object *pl = item->visible_to ())
… …
1773} 1630}
1774 1631
1775/* Received a fire command for the player - go and do it. 1632/* Received a fire command for the player - go and do it.
1776 */ 1633 */
1777bool 1634bool
1778fire (object *op, int dir) 1635fire (object *who, int dir)
1779{ 1636{
1780 int spellcost = 0; 1637 int spellcost = 0;
1781 1638
1782 player *pl = op->contr; 1639 player *pl = who->contr;
1783 1640
1784 if (pl->golem) 1641 if (pl->golem)
1785 { 1642 {
1786 control_golem (op->contr->golem, dir); 1643 control_golem (who->contr->golem, dir);
1787 return false; 1644 return false;
1788 } 1645 }
1789 1646
1790 object *ob = pl->ranged_ob; 1647 object *ob = pl->ranged_ob;
1791 1648
1792 if (!ob) 1649 if (!ob)
1793 return false; 1650 return false;
1794 1651
1795 if (op->speed_left > 0.f) 1652 if (who->speed_left > 0.f)
1796 --op->speed_left; 1653 --who->speed_left;
1797 else 1654 else
1798 return false; 1655 return false;
1799 1656
1800 if (!op->change_weapon (ob)) 1657 if (!who->apply (ob))
1801 return false; 1658 return false;
1802 1659
1803 /* check for loss of invisiblity/hide */ 1660 /* check for loss of invisiblity/hide */
1804 if (action_makes_visible (op)) 1661 if (action_makes_visible (who))
1805 make_visible (op); 1662 make_visible (who);
1806 1663
1807 switch (ob->type) 1664 switch (ob->type)
1808 { 1665 {
1809 case BOW: 1666 case BOW:
1810 player_fire_bow (op, dir); 1667 player_fire_bow (who, dir);
1811 break; 1668 break;
1812 1669
1813 case SPELL: 1670 case SPELL:
1814 spellcost = cast_spell (op, op, dir, ob, pl->spellparam[0] ? pl->spellparam : 0); 1671 spellcost = cast_spell (who, who, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1815 break; 1672 break;
1816 1673
1817 case BUILDER: 1674 case BUILDER:
1818 apply_map_builder (op, dir); 1675 apply_map_builder (who, dir);
1819 break; 1676 break;
1820 1677
1821 case SKILL: 1678 case SKILL:
1822 do_skill (op, op, ob, dir, 0); 1679 do_skill (who, who, ob, dir, 0);
1823 break; 1680 break;
1824 1681
1682 case RANGED:
1683 do_skill (who, ob, who->chosen_skill, dir, 0);
1684 break;
1685
1825 default: 1686 default:
1826 fire_misc_object (op, dir); 1687 fire_misc_object (who, dir);
1827 break; 1688 break;
1828 } 1689 }
1829 1690
1830 return true; 1691 return true;
1831} 1692}
1832 1693
1833/* find_key 1694static object *
1834 * We try to find a key for the door as passed. If we find a key
1835 * and successfully use it, we return the key, otherwise NULL
1836 * This function merges both normal and locked door, since the logic
1837 * for both is the same - just the specific key is different.
1838 * pl is the player,
1839 * inv is the objects inventory to searched
1840 * door is the door we are trying to match against.
1841 * This function can be called recursively to search containers.
1842 */
1843object *
1844find_key (object *pl, object *container, object *door) 1695find_key_ (object *pl, object *container, object *door)
1845{ 1696{
1846 object *tmp, *key; 1697 object *tmp, *key;
1847 1698
1848 /* Should not happen, but sanity checking is never bad */ 1699 /* Should not happen, but sanity checking is never bad */
1849 if (!container->inv) 1700 if (!container->inv)
… …
1852 /* First, lets try to find a key in the top level inventory */ 1703 /* First, lets try to find a key in the top level inventory */
1853 for (tmp = container->inv; tmp; tmp = tmp->below) 1704 for (tmp = container->inv; tmp; tmp = tmp->below)
1854 { 1705 {
1855 if (door->type == DOOR && tmp->type == KEY) 1706 if (door->type == DOOR && tmp->type == KEY)
1856 break; 1707 break;
1708
1857 /* For sanity, we should really check door type, but other stuff 1709 /* For sanity, we should really check door type, but other stuff
1858 * (like containers) can be locked with special keys 1710 * (like containers) can be locked with special keys
1859 */ 1711 */
1860 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1712 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1861 break; 1713 break;
… …
1867 * a key, return 1719 * a key, return
1868 */ 1720 */
1869 if (!tmp) 1721 if (!tmp)
1870 { 1722 {
1871 for (tmp = container->inv; tmp; tmp = tmp->below) 1723 for (tmp = container->inv; tmp; tmp = tmp->below)
1872 {
1873 /* No reason to search empty containers */ 1724 /* No reason to search empty containers */
1874 if (tmp->type == CONTAINER && tmp->inv) 1725 if (tmp->type == CONTAINER && tmp->inv)
1875 {
1876 if ((key = find_key (pl, tmp, door))) 1726 if ((key = find_key_ (pl, tmp, door)))
1877 return key; 1727 return key;
1878 }
1879 }
1880 1728
1881 if (!tmp) 1729 if (!tmp)
1882 return NULL; 1730 return 0;
1883 } 1731 }
1884 1732
1885 /* We get down here if we have found a key. Now if its in a container, 1733 /* We get down here if we have found a key. Now if its in a container,
1886 * see if we actually want to use it 1734 * see if we actually want to use it
1887 */ 1735 */
1888 if (pl != container) 1736 if (pl != container)
1889 { 1737 {
1890 /* Only let players use keys in containers */ 1738 /* Only let players use keys in containers */
1891 if (!pl->contr) 1739 if (!pl->contr)
1892 return NULL; 1740 return 0;
1741
1893 /* cases where this fails: 1742 /* cases where this fails:
1894 * If we only search the player inventory, return now since we 1743 * If we only search the player inventory, return now since we
1895 * are not in the players inventory. 1744 * are not in the players inventory.
1896 * If the container is not active, return now since only active 1745 * If the container is not active, return now since only active
1897 * containers can be used. 1746 * containers can be used.
… …
1901 * inv must have been an container and must have been active. 1750 * inv must have been an container and must have been active.
1902 * 1751 *
1903 * Change the color so that the message doesn't disappear with 1752 * Change the color so that the message doesn't disappear with
1904 * all the others. 1753 * all the others.
1905 */ 1754 */
1906 if (pl->contr->usekeys == key_inventory || 1755 if (pl->contr->usekeys == key_inventory
1907 !QUERY_FLAG (container, FLAG_APPLIED) || 1756 || !container->flag [FLAG_APPLIED]
1908 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1757 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
1909 { 1758 {
1910 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1759 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1911 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1760 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1912 return NULL; 1761 return NULL;
1913 } 1762 }
1914 } 1763 }
1915 1764
1916 return tmp; 1765 return tmp;
1766}
1767
1768/* find_key
1769 * We try to find a key for the door as passed. If we find a key
1770 * and successfully use it, we return the key, otherwise NULL
1771 * This function merges both normal and locked door, since the logic
1772 * for both is the same - just the specific key is different.
1773 * pl is the player,
1774 * inv is the objects inventory to searched
1775 * door is the door we are trying to match against.
1776 * This function can be called recursively to search containers.
1777 */
1778object *
1779find_key (object *pl, object *container, object *door)
1780{
1781 if (door->slaying && is_match_expr (door->slaying))
1782 {
1783 // for match expressions, we try to find the key by applying the match
1784 // to the op itself, which is supposed to find the "key", instead
1785 // of searching through containers ourselves.
1786
1787 return match_one (door->slaying, container, door, pl, pl);
1788 }
1789 else
1790 return find_key_ (pl, container, door);
1917} 1791}
1918 1792
1919/* moved door processing out of move_player_attack. 1793/* moved door processing out of move_player_attack.
1920 * returns 1 if player has opened the door with a key 1794 * returns 1 if player has opened the door with a key
1921 * such that the caller should not do anything more, 1795 * such that the caller should not do anything more,
… …
1971 * going to try and move (not fire weapons). 1845 * going to try and move (not fire weapons).
1972 */ 1846 */
1973bool 1847bool
1974move_player_attack (object *op, int dir) 1848move_player_attack (object *op, int dir)
1975{ 1849{
1976 int on_battleground; 1850 if (!op->contr->braced && op->speed_left > 0.f && op->move (dir))
1851 {
1852 --op->speed_left;
1853 return true;
1854 }
1977 1855
1978 sint16 nx = freearr_x[dir] + op->x; 1856 sint16 nx = freearr_x[dir] + op->x;
1979 sint16 ny = freearr_y[dir] + op->y; 1857 sint16 ny = freearr_y[dir] + op->y;
1980 1858
1981 on_battleground = op_on_battleground (op, 0, 0);
1982
1983 if (out_of_map (op->map, nx, ny)) 1859 if (out_of_map (op->map, nx, ny))
1984 return false; 1860 return false;
1985
1986 if (!op->contr->braced && op->speed_left > 0.f && move_ob (op, dir, op))
1987 {
1988 --op->speed_left;
1989 return true;
1990 }
1991 1861
1992 /* If braced, or can't move to the square, and it is not out of the 1862 /* If braced, or can't move to the square, and it is not out of the
1993 * map, attack it. Note order of if statement is important - don't 1863 * map, attack it. Note order of if statement is important - don't
1994 * want to be calling move_ob if braced, because move_ob will move the 1864 * want to be calling move_ob if braced, because move_ob will move the
1995 * player. This is a pretty nasty hack, because if we could 1865 * player. This is a pretty nasty hack, because if we could
… …
2013 || mon->flag [FLAG_CAN_ROLL]) 1883 || mon->flag [FLAG_CAN_ROLL])
2014 && mon != op) 1884 && mon != op)
2015 break; 1885 break;
2016 } 1886 }
2017 1887
2018 if (!mon) /* This happens anytime the player tries to move */ 1888 /* no monster == player tries to move into a wall or so */
2019 return false; /* into a wall */ 1889 if (!mon)
1890 {
1891 for (object *ob = m->at (nx, ny).top; ob; ob = ob->below)
1892 if (op->move_type & ob->move_block)
1893 {
1894 if (ob->move_block == MOVE_ALL)
1895 move_into_wall (op, ob);
1896 else
1897 {
1898 if (op->contr->ns->bumpmsg)
1899 {
1900 op->play_sound (sound_find ("blocked_move"));
1901
1902 op->statusmsg (ob->invisible
1903 ? "Something blocks you."
1904 : format ("Something blocks you from entering the %s.", query_name (ob))
1905 );
1906 }
1907 }
1908
1909 break;
1910 }
1911
1912 return false;
1913 }
2020 1914
2021 mon = mon->head_ (); 1915 mon = mon->head_ ();
2022 1916
2023 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR)) 1917 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2024 if (op->contr->weapon_sp_left > 0.f) 1918 if (op->contr->weapon_sp_left > 0.f)
… …
2042 */ 1936 */
2043 if (op->type == PLAYER 1937 if (op->type == PLAYER
2044 && ((mon->owner && mon->owner->contr 1938 && ((mon->owner && mon->owner->contr
2045 && same_party (mon->owner->contr->party, op->contr->party)) 1939 && same_party (mon->owner->contr->party, op->contr->party))
2046 || mon->owner == op) 1940 || mon->owner == op)
2047 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))) 1941 && (mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY]))
2048 { 1942 {
2049 /* If we're braced, we don't want to switch places with it */ 1943 /* If we're braced, we don't want to switch places with it */
2050 if (op->contr->braced) 1944 if (op->contr->braced)
2051 return false; 1945 return false;
2052 1946
… …
2063 return true; 1957 return true;
2064 } 1958 }
2065 else 1959 else
2066 return false; 1960 return false;
2067 } 1961 }
1962
1963 bool on_battleground = op_on_battleground (op, 0, 0);
2068 1964
2069 /* in certain circumstances, you shouldn't attack friendly 1965 /* in certain circumstances, you shouldn't attack friendly
2070 * creatures. Note that if you are braced, you can't push 1966 * creatures. Note that if you are braced, you can't push
2071 * someone, but put it inside this loop so that you won't 1967 * someone, but put it inside this loop so that you won't
2072 * attack them either. 1968 * attack them either.
2073 */ 1969 */
2074 if ((mon->type == PLAYER || mon->enemy != op) 1970 if ((mon->type == PLAYER || mon->enemy != op)
2075 && (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) 1971 && (mon->type == PLAYER || mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY])
2076 && ((op->contr->peaceful 1972 && ((op->contr->peaceful
2077 || (mon->type == PLAYER && mon->contr->peaceful)) 1973 || (mon->type == PLAYER && mon->contr->peaceful))
2078 && !on_battleground)) 1974 && !on_battleground))
2079 { 1975 {
2080 if (op->speed_left > 0.f) 1976 if (op->speed_left > 0.f)
… …
2096 } 1992 }
2097 } 1993 }
2098 /* If the object is a boulder or other rollable object, then 1994 /* If the object is a boulder or other rollable object, then
2099 * roll it if not braced. You can't roll it if you are braced. 1995 * roll it if not braced. You can't roll it if you are braced.
2100 */ 1996 */
2101 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 1997 else if (mon->flag [FLAG_CAN_ROLL] && (!op->contr->braced))
2102 { 1998 {
2103 if (op->speed_left > 0.f) 1999 if (op->speed_left > 0.f)
2104 { 2000 {
2105 --op->speed_left; 2001 --op->speed_left;
2106 2002
… …
2115 * Way it works is like this: First, it must have some hit points 2011 * Way it works is like this: First, it must have some hit points
2116 * and be living. Then, it must be one of the following: 2012 * and be living. Then, it must be one of the following:
2117 * 1) Not a player, 2) A player, but of a different party. Note 2013 * 1) Not a player, 2) A player, but of a different party. Note
2118 * that party_number -1 is no party, so attacks can still happen. 2014 * that party_number -1 is no party, so attacks can still happen.
2119 */ 2015 */
2120 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 2016 else if ((mon->stats.hp >= 0) && mon->flag [FLAG_ALIVE] &&
2121 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 2017 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2122 { 2018 {
2123 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS]) 2019 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2124 { 2020 {
2125 --op->contr->weapon_sp_left; 2021 --op->contr->weapon_sp_left;
… …
2137} 2033}
2138 2034
2139bool 2035bool
2140move_player (object *op, int dir) 2036move_player (object *op, int dir)
2141{ 2037{
2142 int pick;
2143
2144 if (!op->map || op->map->in_memory != MAP_ACTIVE) 2038 if (!op->map || op->map->state != MAP_ACTIVE)
2145 return 0; 2039 return 0;
2146 2040
2147 /* Sanity check: make sure dir is valid */ 2041 /* Sanity check: make sure dir is valid */
2148 if ((dir < 0) || (dir >= 9)) 2042 if (dir < 0 || dir > 8)
2149 { 2043 {
2150 LOG (llevError, "move_player: invalid direction %d\n", dir); 2044 LOG (llevError, "move_player: invalid direction %d\n", dir);
2151 return 0; 2045 return 0;
2152 } 2046 }
2153 2047
2154 /* peterm: added following line */ 2048 /* peterm: added following line */
2155 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2049 if (op->flag [FLAG_CONFUSED] && dir)
2156 dir = absdir (dir + rndm (3) + rndm (3) - 2); 2050 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2157 2051
2158 op->facing = dir; 2052 op->facing = dir;
2159 2053
2160 if (op->flag [FLAG_HIDDEN]) 2054 if (op->flag [FLAG_HIDDEN])
2161 do_hidden_move (op); 2055 do_hidden_move (op);
2162 2056
2163 bool retval; 2057 bool retval;
2058 int pick = 0;
2164 2059
2165 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2060 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2166 retval = RESULT_INT (0); 2061 retval = RESULT_INT (0);
2167 else if (op->contr->fire_on) 2062 else if (op->contr->fire_on)
2168 retval = fire (op, dir); 2063 retval = fire (op, dir);
… …
2199 * players. 2094 * players.
2200 */ 2095 */
2201bool 2096bool
2202handle_newcs_player (object *op) 2097handle_newcs_player (object *op)
2203{ 2098{
2204 if (QUERY_FLAG (op, FLAG_SCARED)) 2099 if (op->flag [FLAG_SCARED])
2205 { 2100 {
2206 if (op->speed_left > 0.f) 2101 if (op->speed_left > 0.f)
2207 { 2102 {
2208 --op->speed_left; 2103 --op->speed_left;
2209 flee_player (op); 2104 flee_player (op);
… …
2225 return move_player (op, op->direction); 2120 return move_player (op, op->direction);
2226 2121
2227 return false; 2122 return false;
2228} 2123}
2229 2124
2230int 2125static int
2231save_life (object *op) 2126save_life (object *op)
2232{ 2127{
2233 if (!QUERY_FLAG (op, FLAG_LIFESAVE)) 2128 if (!op->flag [FLAG_LIFESAVE])
2234 return 0; 2129 return 0;
2235 2130
2236 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2131 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2237 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2132 if (tmp->flag [FLAG_APPLIED] && tmp->flag [FLAG_LIFESAVE])
2238 { 2133 {
2239 op->play_sound (sound_find ("ob_evaporate")); 2134 op->play_sound (sound_find ("ob_evaporate"));
2240 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2135 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2241 2136
2242 tmp->destroy (); 2137 tmp->destroy ();
2243 CLEAR_FLAG (op, FLAG_LIFESAVE); 2138 op->clr_flag (FLAG_LIFESAVE);
2244 2139
2245 if (op->stats.hp < 0) 2140 if (op->stats.hp < 0)
2246 op->stats.hp = op->stats.maxhp; 2141 op->stats.hp = op->stats.maxhp;
2247 2142
2248 if (op->stats.food < 0) 2143 if (op->stats.food < 0)
2249 op->stats.food = 999; 2144 op->stats.food = MAX_FOOD;
2250 2145
2251 op->update_stats (); 2146 op->update_stats ();
2252 return 1; 2147 return 1;
2253 } 2148 }
2254 2149
2255 LOG (llevError, "Error: LIFESAVE set without applied object.\n"); 2150 LOG (llevError, "Error: LIFESAVE set without applied object.\n");
2256 CLEAR_FLAG (op, FLAG_LIFESAVE); 2151 op->clr_flag (FLAG_LIFESAVE);
2257 enter_player_savebed (op); /* bring him home. */ 2152 enter_player_savebed (op); /* bring him home. */
2258 return 0; 2153 return 0;
2259} 2154}
2260 2155
2261/* This goes throws the inventory and removes unpaid objects, and puts them 2156/* This goes throws the inventory and removes unpaid objects, and puts them
… …
2268{ 2163{
2269 while (op) 2164 while (op)
2270 { 2165 {
2271 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */ 2166 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2272 2167
2273 if (QUERY_FLAG (op, FLAG_UNPAID)) 2168 if (op->flag [FLAG_UNPAID])
2274 op->insert_at (env); 2169 op->insert_at (env);
2275 else if (op->inv) 2170 else if (op->inv)
2276 drop_unpaid_items (op->inv, env); 2171 drop_unpaid_items (op->inv, env);
2277 2172
2278 op = next; 2173 op = next;
… …
2284{ 2179{
2285 if (!flag [FLAG_REMOVED]) 2180 if (!flag [FLAG_REMOVED])
2286 ::drop_unpaid_items (inv, this); 2181 ::drop_unpaid_items (inv, this);
2287} 2182}
2288 2183
2289/*
2290 * Returns pointer a static string containing gravestone text
2291 * Moved from apply.c to player.c - player.c is what
2292 * actually uses this function. player.c may not be quite the
2293 * best, a misc file for object actions is probably better,
2294 * but there isn't one in the server directory.
2295 */
2296const char *
2297gravestone_text (object *op)
2298{
2299 static dynbuf_text buf;
2300
2301 buf << "---- R.I.P. ----\n\n"
2302 << op->name;
2303
2304 if (op->type == PLAYER)
2305 buf << " the " << op->contr->title;
2306
2307 buf << "\n\n";
2308
2309 buf << "who was level ";
2310 buf << (sint32)op->level << "\n\n" // OO breakdown
2311 << " when " << (op->contr ? "killed" : "died") << "\n\n";
2312
2313 if (op->type == PLAYER)
2314 buf << "by " << op->contr->killer_name () << ".\n\n";
2315
2316 {
2317 static char buf2[128];
2318 time_t now = time (NULL);
2319 strftime (buf2, 128, "%b %d %Y\n\n", localtime (&now));
2320 buf << buf2;
2321 }
2322
2323 return buf;
2324}
2325
2326void 2184void
2327do_some_living (object *op) 2185do_some_living (object *op)
2328{ 2186{
2329 int last_food = op->stats.food; 2187 int last_food = op->stats.food;
2330 int gen_hp, gen_sp, gen_grace; 2188 int gen_hp, gen_sp, gen_grace;
2331 int over_hp, over_sp, over_grace;
2332 int i;
2333 int rate_hp = 1200; 2189 int rate_hp = 1200;
2334 int rate_sp = 2500; 2190 int rate_sp = 2500;
2335 int rate_grace = 2000; 2191 int rate_grace = 2000;
2336 const int max_hp = 1; 2192 const int max_hp = 1;
2337 const int max_sp = 1; 2193 const int max_sp = 1;
2338 const int max_grace = 1; 2194 const int max_grace = 1;
2339 2195
2196#if 0
2340 if (op->contr->hidden) 2197 if (op->contr->hidden)
2341 { 2198 {
2342 op->invisible = 1000; 2199 op->invisible = 1000;
2343 /* the socket code flashes the player visible/invisible 2200 /* the socket code flashes the player visible/invisible
2344 * depending on the value of invisible, so we need to 2201 * depending on the value of invisible, so we need to
2345 * alternate it here for it to work correctly. 2202 * alternate it here for it to work correctly.
2346 */ 2203 */
2347 if (pticks & 2) 2204 if (server_tick & 2)
2348 op->invisible--; 2205 op->invisible--;
2349 } 2206 }
2207 else
2208#endif
2350 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS))) 2209 if (op->invisible && !(op->flag [FLAG_MAKE_INVIS]))
2351 { 2210 {
2352 if (!op->invisible--) 2211 if (!op->invisible--)
2353 { 2212 {
2354 make_visible (op); 2213 make_visible (op);
2355 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out."); 2214 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
… …
2389 if (--op->last_grace < 0) 2248 if (--op->last_grace < 0)
2390 { 2249 {
2391 if (op->stats.grace < op->stats.maxgrace / 2) 2250 if (op->stats.grace < op->stats.maxgrace / 2)
2392 op->stats.grace++; /* no penalty in food for regaining grace */ 2251 op->stats.grace++; /* no penalty in food for regaining grace */
2393 2252
2253 int temp = gen_grace < 20 ? 30 : gen_grace + 10;
2254
2394 if (max_grace > 1) 2255 if (max_grace > 1)
2395 { 2256 {
2396 over_grace = (gen_grace < 20 ? 30 : gen_grace + 10) / rate_grace; 2257 int over_grace = temp / rate_grace;
2258
2397 if (over_grace > 0) 2259 if (over_grace > 0)
2398 { 2260 {
2399 op->stats.sp += over_grace 2261 op->stats.sp += over_grace + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > (temp % rate_grace)) ? -1 : 0;
2400 + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > ((gen_grace < 20 ? 30 : gen_grace + 10) % rate_grace)) ? -1 : 0;
2401 op->last_grace = 0; 2262 op->last_grace = 0;
2402 } 2263 }
2403 else 2264 else
2404 { 2265 op->last_grace = rate_grace / temp;
2405 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2406 }
2407 } 2266 }
2408 else 2267 else
2409 { 2268 op->last_grace = rate_grace / temp;
2410 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2269
2411 }
2412 /* wearing stuff doesn't detract from grace generation. */ 2270 /* wearing stuff doesn't detract from grace generation. */
2413 } 2271 }
2414 2272
2415 if (op->stats.food > 0) 2273 if (op->stats.food > 0)
2416 { 2274 {
… …
2422 if (op->stats.sp < op->stats.maxsp) 2280 if (op->stats.sp < op->stats.maxsp)
2423 { 2281 {
2424 op->stats.sp++; 2282 op->stats.sp++;
2425 2283
2426 /* dms do not consume food */ 2284 /* dms do not consume food */
2427 if (!QUERY_FLAG (op, FLAG_WIZ)) 2285 if (!op->flag [FLAG_WIZ])
2428 { 2286 {
2429 op->stats.food--; 2287 op->stats.food--;
2430 2288
2431 if (op->contr->digestion < 0) 2289 if (op->contr->digestion < 0)
2432 op->stats.food += op->contr->digestion; 2290 op->stats.food += op->contr->digestion;
… …
2435 } 2293 }
2436 } 2294 }
2437 2295
2438 if (max_sp > 1) 2296 if (max_sp > 1)
2439 { 2297 {
2440 over_sp = (gen_sp + 10) / rate_sp; 2298 int over_sp = (gen_sp + 10) / rate_sp;
2441 if (over_sp > 0) 2299 if (over_sp > 0)
2442 { 2300 {
2443 if (op->stats.sp < op->stats.maxsp) 2301 if (op->stats.sp < op->stats.maxsp)
2444 { 2302 {
2445 op->stats.sp += over_sp > max_sp ? max_sp : over_sp; 2303 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
… …
2466 if (op->stats.hp < op->stats.maxhp) 2324 if (op->stats.hp < op->stats.maxhp)
2467 { 2325 {
2468 op->stats.hp++; 2326 op->stats.hp++;
2469 2327
2470 /* dms do not consume food */ 2328 /* dms do not consume food */
2471 if (!QUERY_FLAG (op, FLAG_WIZ)) 2329 if (!op->flag [FLAG_WIZ])
2472 { 2330 {
2473 op->stats.food--; 2331 op->stats.food--;
2474 2332
2475 if (op->contr->digestion < 0) 2333 if (op->contr->digestion < 0)
2476 op->stats.food += op->contr->digestion; 2334 op->stats.food += op->contr->digestion;
2477 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2335 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2478 op->stats.food = last_food; 2336 op->stats.food = last_food;
2479 } 2337 }
2480 } 2338 }
2481 2339
2340 int temp = gen_hp < 20 ? 30 : gen_hp + 10;
2341
2482 if (max_hp > 1) 2342 if (max_hp > 1)
2483 { 2343 {
2484 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp; 2344 int over_hp = temp / rate_hp;
2485 2345
2486 if (over_hp > 0) 2346 if (over_hp > 0)
2487 { 2347 {
2488 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2348 op->stats.sp += over_hp + (random_roll (0, rate_hp - 1, op, PREFER_HIGH) > (temp % rate_hp)) ? -1 : 0;
2489 op->last_heal = 0; 2349 op->last_heal = 0;
2490 } 2350 }
2491 else 2351 else
2492 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2352 op->last_heal = rate_hp / temp;
2493 } 2353 }
2494 else 2354 else
2495 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2355 op->last_heal = rate_hp / temp;
2496 } 2356 }
2497 } 2357 }
2498 2358
2499 /* Digestion */ 2359 /* Digestion */
2500 if (--op->last_eat < 0) 2360 if (--op->last_eat < 0)
… …
2503 penalty = max (0, -op->contr->digestion); 2363 penalty = max (0, -op->contr->digestion);
2504 2364
2505 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1); 2365 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2506 2366
2507 /* dms do not consume food */ 2367 /* dms do not consume food */
2508 if (!QUERY_FLAG (op, FLAG_WIZ)) 2368 if (!op->flag [FLAG_WIZ])
2509 op->stats.food--; 2369 op->stats.food--;
2510 } 2370 }
2511 2371
2512 if (op->stats.food < 0 && op->stats.hp >= 0) 2372 if (op->stats.food < 0 && op->stats.hp >= 0)
2513 { 2373 {
2514 object *flesh = 0; 2374 object *flesh = 0;
2515 2375
2516 for_inv_removable (op, tmp) 2376 for_inv_removable (op, tmp)
2517 { 2377 {
2518 if (QUERY_FLAG (tmp, FLAG_UNPAID)) 2378 if (tmp->flag [FLAG_UNPAID])
2519 continue; 2379 continue;
2520 2380
2521 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2381 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2522 { 2382 {
2523 op->statusmsg ("You blindly grab for a bite of food. " 2383 op->statusmsg ("You blindly grab for a bite of food. "
2524 "H<To prevent you from starving, you ate some random item from your backpack.>"); 2384 "H<To prevent you from starving, you ate some random item from your backpack.>");
2525 manual_apply (op, tmp, 0); 2385 op->apply (tmp);
2526 2386
2527 if (op->stats.food >= 0 || op->stats.hp < 0) 2387 if (op->stats.food >= 0 || op->stats.hp < 0)
2528 break; 2388 break;
2529 } 2389 }
2530 else if (tmp->type == FLESH) 2390 else if (tmp->type == FLESH)
… …
2536 */ 2396 */
2537 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2397 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2538 { 2398 {
2539 op->statusmsg ("You blindly grab for a bite of food. " 2399 op->statusmsg ("You blindly grab for a bite of food. "
2540 "H<To prevent you from starving, you ate some random item from your backpack.>"); 2400 "H<To prevent you from starving, you ate some random item from your backpack.>");
2541 manual_apply (op, flesh, 0); 2401 op->apply (flesh);
2542 } 2402 }
2543 2403
2544 // If player is still starving, alert him! 2404 // If player is still starving, alert him!
2545 if (op->stats.food < 0) 2405 if (op->stats.food < 0)
2546 op->failmsg ("You are starving! " 2406 op->failmsg ("You are starving! "
… …
2558 op->contr->killer->destroy (); 2418 op->contr->killer->destroy ();
2559 } 2419 }
2560 } 2420 }
2561 2421
2562 /* killer should be set here already */ 2422 /* killer should be set here already */
2563 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2423 if (op->stats.hp < 0 && !op->flag [FLAG_WIZ])
2564 kill_player (op); 2424 kill_player (op);
2565 } 2425 }
2566} 2426}
2567 2427
2568/* If the player should die (lack of hp, food, etc), we call this. 2428/* If the player should die (lack of hp, food, etc), we call this.
… …
2572 */ 2432 */
2573void 2433void
2574kill_player (object *op) 2434kill_player (object *op)
2575{ 2435{
2576 int x, y; 2436 int x, y;
2577 char buf[MAX_BUF];
2578 maptile *map; /* this is for resurrection */ 2437 maptile *map; /* this is for resurrection */
2579 int will_kill_again; 2438 int will_kill_again;
2580 archetype *at; 2439 archetype *at;
2581 object *tmp; 2440 object *tmp;
2582 2441
2583 if (save_life (op)) 2442 if (save_life (op))
2584 return; 2443 return;
2444
2445 dynbuf_text deathtab;
2446
2447 /* restore player */
2448 at = archetype::find (shstr_poisoning);
2449 if (object *tmp = present_arch_in_ob (at, op))
2450 {
2451 tmp->destroy ();
2452 deathtab << "Your body feels cleansed...\r";
2453 }
2454
2455 at = archetype::find (shstr_confusion);
2456 if (object *tmp = present_arch_in_ob (at, op))
2457 {
2458 tmp->destroy ();
2459 deathtab << "Your mind feels clearer...\r";
2460 }
2461
2462 cure_disease (op, 0, 0); /* remove any disease */
2463
2464 max_it (op->stats.hp , op->stats.maxhp);
2465 max_it (op->stats.sp , op->stats.maxsp);
2466 max_it (op->stats.grace, op->stats.maxgrace);
2467 max_it (op->stats.food , 200);
2468
2469 // remove all spell effects that are active
2470 // to avoid long-term effects such as word-of-recall
2471 for (object *item = op->inv; item; )
2472 {
2473 object *next = item->below;
2474
2475 if (item->type == SPELL_EFFECT && item->active)
2476 item->destroy ();
2477
2478 item = next;
2479 }
2585 2480
2586 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2481 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2587 * in cities ONLY!!! It is very important that this doesn't get abused. 2482 * in cities ONLY!!! It is very important that this doesn't get abused.
2588 * Look at op_on_battleground() for more info --AndreasV 2483 * Look at op_on_battleground() for more info --AndreasV
2589 */ 2484 */
2590 if (op_on_battleground (op, &x, &y)) 2485 if (op_on_battleground (op, &x, &y))
2591 { 2486 {
2592 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2487 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2593 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2594
2595 /* restore player */
2596 at = archetype::find ("poisoning");
2597 if (object *tmp = present_arch_in_ob (at, op))
2598 {
2599 tmp->destroy ();
2600 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2601 }
2602
2603 at = archetype::find ("confusion");
2604 if (object *tmp = present_arch_in_ob (at, op))
2605 {
2606 tmp->destroy ();
2607 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2608 }
2609
2610 cure_disease (op, 0, 0); /* remove any disease */
2611 op->stats.hp = op->stats.maxhp;
2612 if (op->stats.food <= 0)
2613 op->stats.food = 999;
2614 2488
2615 /* create a bodypart-trophy to make the winner happy */ 2489 /* create a bodypart-trophy to make the winner happy */
2616 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2490 object *tmp = archetype::find (shstr_finger)->instance ();
2617 { 2491
2618 tmp->name = format ("%s's finger" , &op->name); 2492 tmp->name = format ("%s's finger" , &op->name);
2619 tmp->name_pl = format ("%s's fingers", &op->name); 2493 tmp->name_pl = format ("%s's fingers", &op->name);
2620 tmp->msg = format ( 2494 tmp->msg = format (
2621 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n", 2495 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2622 &op->name, op->contr->title, 2496 &op->name, op->contr->title,
2623 (int)op->level, 2497 (int)op->level,
2624 op->contr->killer_name () 2498 op->contr->killer_name ()
2625 ); 2499 );
2626 tmp->value = 0, tmp->type = 0; 2500 tmp->value = 0, tmp->type = 0;
2627 tmp->materialname = "organics"; 2501 tmp->material = name_to_material (shstr_organic);
2628 tmp->insert_at (op, tmp); 2502 tmp->insert_at (op, tmp);
2629 }
2630 2503
2631 /* teleport defeated player to new destination */ 2504 /* teleport defeated player to new destination */
2632 transfer_ob (op, x, y, 0, NULL); 2505 transfer_ob (op, x, y, 0, NULL);
2633 op->contr->braced = 0; 2506 op->contr->braced = 0;
2507
2508 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2634 return; 2509 return;
2635 } 2510 }
2511
2512 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2513 deathtab << "T<YOU HAVE DIED>\n\n";
2636 2514
2637 INVOKE_PLAYER (DEATH, op->contr); 2515 INVOKE_PLAYER (DEATH, op->contr);
2638 2516
2639 command_kill_pets (op, 0); 2517 command_kill_pets (op, 0);
2640 2518
… …
2674 2552
2675 lost_a_stat = 0; 2553 lost_a_stat = 0;
2676 2554
2677 for (z = 0; z < num_stats_lose; z++) 2555 for (z = 0; z < num_stats_lose; z++)
2678 { 2556 {
2679 i = RANDOM () % NUM_STATS; 2557 i = rndm (NUM_STATS);
2680 2558
2681 if (settings.stat_loss_on_death) 2559 if (settings.stat_loss_on_death)
2682 { 2560 {
2683 /* Pick a random stat and take a point off it. Tell the player 2561 /* Pick a random stat and take a point off it. Tell the player
2684 * what he lost. 2562 * what he lost.
… …
2691 lost_a_stat = 1; 2569 lost_a_stat = 1;
2692 } 2570 }
2693 else 2571 else
2694 { 2572 {
2695 /* deplete a stat */ 2573 /* deplete a stat */
2696 archetype *deparch = archetype::find ("depletion"); 2574 archetype *deparch = archetype::find (shstr_depletion);
2697 object *dep; 2575 object *dep;
2698 2576
2699 dep = present_arch_in_ob (deparch, op); 2577 dep = present_arch_in_ob (deparch, op);
2700 if (!dep) 2578 if (!dep)
2701 { 2579 {
2702 dep = arch_to_object (deparch); 2580 dep = deparch->instance ();
2703 insert_ob_in_ob (dep, op); 2581 insert_ob_in_ob (dep, op);
2704 } 2582 }
2705 lose_this_stat = 1; 2583 lose_this_stat = 1;
2706 if (settings.balanced_stat_loss) 2584 if (settings.balanced_stat_loss)
2707 { 2585 {
… …
2735 } 2613 }
2736 } 2614 }
2737 2615
2738 if (lose_this_stat) 2616 if (lose_this_stat)
2739 { 2617 {
2740 this_stat = get_attr_value (&(dep->stats), i); 2618 this_stat = get_attr_value (&dep->stats, i);
2741 /* We could try to do something clever like find another 2619 /* We could try to do something clever like find another
2742 * stat to reduce if this fails. But chances are, if 2620 * stat to reduce if this fails. But chances are, if
2743 * stats have been depleted to -50, all are pretty low 2621 * stats have been depleted to -50, all are pretty low
2744 * and should be roughly the same, so it shouldn't make a 2622 * and should be roughly the same, so it shouldn't make a
2745 * difference. 2623 * difference.
2746 */ 2624 */
2747 if (this_stat >= -50) 2625 if (this_stat >= -50)
2748 { 2626 {
2749 change_attr_value (&(dep->stats), i, -1); 2627 change_attr_value (&(dep->stats), i, -1);
2750 SET_FLAG (dep, FLAG_APPLIED); 2628 dep->set_flag (FLAG_APPLIED);
2751 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]); 2629 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]);
2752 op->update_stats (); 2630 op->update_stats ();
2753 lost_a_stat = 1; 2631 lost_a_stat = 1;
2754 } 2632 }
2755 } 2633 }
… …
2759 /* If no stat lost, tell the player. */ 2637 /* If no stat lost, tell the player. */
2760 if (!lost_a_stat) 2638 if (!lost_a_stat)
2761 { 2639 {
2762 /* determine_god() seems to not work sometimes... why is this? 2640 /* determine_god() seems to not work sometimes... why is this?
2763 Should I be using something else? GD */ 2641 Should I be using something else? GD */
2764 const char *god = determine_god (op); 2642 shstr_tmp god = determine_god (op);
2765 2643
2766 if (god && (strcmp (god, "none"))) 2644 if (god != shstr_none)
2767 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2645 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2768 else 2646 else
2769 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2647 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2770 } 2648 }
2771#else 2649#else
2772 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you from losing yourself completely."); 2650 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2773#endif 2651#endif
2774 2652
2775 /* Put a gravestone up where the character 'almost' died. List the 2653 /* Put a gravestone up where the character 'almost' died. List the
2776 * exp loss on the stone. 2654 * exp loss on the stone.
2777 */ 2655 */
2778 tmp = arch_to_object (archetype::find ("gravestone")); 2656 tmp = archetype::find (shstr_gravestone)->instance ();
2779 tmp->name = format ("%s's gravestone", &op->name); 2657 tmp->name = format ("%s's gravestone", &op->name);
2780 tmp->name_pl = format ("%s's gravestones", &op->name); 2658 tmp->name_pl = format ("%s's gravestones", &op->name);
2781 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n", 2659 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2782 &op->name, op->contr->title, op->contr->killer_name ()); 2660 &op->name, op->contr->title, op->contr->killer_name ());
2783 tmp->x = op->x, tmp->y = op->y; 2661 tmp->x = op->x, tmp->y = op->y;
2784 insert_ob_in_map (tmp, op->map, NULL, 0); 2662 insert_ob_in_map (tmp, op->map, NULL, 0);
2785 2663
2786 /**************************************/ 2664 /**************************************/
2787 /* */ 2665 /* */
2788 /* Subtract the experience points, */ 2666 /* Subtract the experience points, */
2789 /* if we died cause of food, give us */
2790 /* food, and reset HP's... */
2791 /* */ 2667 /* */
2792 /**************************************/ 2668 /**************************************/
2793 2669
2794 /* remove any poisoning and confusion the character may be suffering. */
2795 /* restore player */
2796 at = archetype::find ("poisoning");
2797 tmp = present_arch_in_ob (at, op);
2798
2799 if (tmp)
2800 {
2801 tmp->destroy ();
2802 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2803 }
2804
2805 at = archetype::find ("confusion");
2806 tmp = present_arch_in_ob (at, op);
2807 if (tmp)
2808 {
2809 tmp->destroy ();
2810 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2811 }
2812
2813 cure_disease (op, 0, 0); /* remove any disease */
2814
2815 // remove all spell effects that are active
2816 // to avoid long-term effects such as word-of-recall
2817 for (object *item = op->inv; item; )
2818 {
2819 object *next = item->below;
2820
2821 if (item->type == SPELL_EFFECT && item->active)
2822 item->destroy ();
2823
2824 item = next;
2825 }
2826
2827 /*add_exp(op, (op->stats.exp * -0.20)); */ 2670 /*add_exp(op, (op->stats.exp * -0.20)); */
2828 apply_death_exp_penalty (op); 2671 apply_death_exp_penalty (op);
2829
2830 if (op->stats.food < 100)
2831 op->stats.food = 900;
2832
2833 op->stats.hp = op->stats.maxhp;
2834 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2835 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2836 2672
2837 /* 2673 /*
2838 * Check to see if the player has any unpaid items. If so, remove them 2674 * Check to see if the player has any unpaid items. If so, remove them
2839 * and put them back in the map. 2675 * and put them back in the map.
2840 */ 2676 */
… …
2864 if (will_kill_again) 2700 if (will_kill_again)
2865 { 2701 {
2866 object *force; 2702 object *force;
2867 int at; 2703 int at;
2868 2704
2869 force = get_archetype (FORCE_NAME); 2705 force = archetype::get (FORCE_NAME);
2870 /* 50 ticks should be enough time for the spell to abate */ 2706 /* 50 ticks should be enough time for the spell to abate */
2871 force->speed = 0.1f;
2872 force->speed_left = -5.f; 2707 force->speed_left = -5.f;
2873 SET_FLAG (force, FLAG_APPLIED); 2708 force->set_speed (0.1f);
2709 force->set_flag (FLAG_APPLIED);
2710
2874 for (at = 0; at < NROFATTACKS; at++) 2711 for (at = 0; at < NROFATTACKS; at++)
2875 if (will_kill_again & (1 << at)) 2712 if (will_kill_again & (1 << at))
2876 force->resist[at] = 100; 2713 force->resist[at] = 100;
2877 2714
2878 insert_ob_in_ob (force, op); 2715 insert_ob_in_ob (force, op);
2879 op->update_stats (); 2716 op->update_stats ();
2880 } 2717 }
2881 2718
2882 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2719 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2883} 2720}
2884 2721
2885void 2722static void
2886loot_object (object *op) 2723loot_object (object *op)
2887{ /* Grab and destroy some treasure */ 2724{ /* Grab and destroy some treasure */
2888 object *tmp, *tmp2, *next; 2725 object *tmp, *next;
2889 2726
2890 op->close_container (); /* close open sack first */ 2727 op->close_container (); /* close open sack first */
2891 2728
2892 for (tmp = op->inv; tmp; tmp = next) 2729 for (tmp = op->inv; tmp; tmp = next)
2893 { 2730 {
… …
2900 tmp->x = op->x, tmp->y = op->y; 2737 tmp->x = op->x, tmp->y = op->y;
2901 2738
2902 if (tmp->type == CONTAINER) 2739 if (tmp->type == CONTAINER)
2903 loot_object (tmp); /* empty container to ground */ 2740 loot_object (tmp); /* empty container to ground */
2904 2741
2905 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3)))) 2742 if (!tmp->flag [FLAG_UNIQUE] && (tmp->flag [FLAG_STARTEQUIP] || tmp->flag [FLAG_NO_DROP] || !(rndm (3))))
2906 { 2743 {
2907 if (tmp->nrof > 1) 2744 if (tmp->nrof > 1)
2908 { 2745 {
2909 tmp->decrease (rndm (1, tmp->nrof - 1)); 2746 tmp->decrease (rndm (1, tmp->nrof - 1));
2910 insert_ob_in_map (tmp, op->map, NULL, 0); 2747 insert_ob_in_map (tmp, op->map, NULL, 0);
… …
2921 * fix_weight(): Check recursively the weight of all players, and fix 2758 * fix_weight(): Check recursively the weight of all players, and fix
2922 * what needs to be fixed. Refresh windows and fix speed if anything 2759 * what needs to be fixed. Refresh windows and fix speed if anything
2923 * was changed. 2760 * was changed.
2924 */ 2761 */
2925void 2762void
2926fix_weight (void) 2763fix_weight ()
2927{ 2764{
2928 for_all_players (pl) 2765 for_all_players (pl)
2929 { 2766 {
2930 sint32 old = pl->ob->carrying; 2767 weight_t old = pl->ob->carrying;
2931 2768
2932 pl->ob->update_weight (); 2769 pl->ob->update_weight ();
2933 2770
2934 if (old != pl->ob->carrying) 2771 if (old != pl->ob->carrying)
2935 { 2772 {
… …
2938 } 2775 }
2939 } 2776 }
2940} 2777}
2941 2778
2942void 2779void
2943fix_luck (void) 2780fix_luck ()
2944{ 2781{
2945 for_all_players (pl) 2782 for_all_players (pl)
2946 if (!pl->ob->contr->ns->state) 2783 if (!pl->ob->contr->ns->state)
2947 pl->ob->change_luck (0); 2784 pl->ob->change_luck (0);
2948} 2785}
… …
3000} 2837}
3001 2838
3002int 2839int
3003is_true_undead (object *op) 2840is_true_undead (object *op)
3004{ 2841{
3005 if (QUERY_FLAG (op->arch, FLAG_UNDEAD)) 2842 if (op->arch->flag [FLAG_UNDEAD])
3006 return 1; 2843 return 1;
3007 2844
3008 return 0; 2845 return 0;
3009} 2846}
3010 2847
… …
3020 2857
3021 if (!ob || !ob->map) 2858 if (!ob || !ob->map)
3022 return 0; 2859 return 0;
3023 2860
3024 /* so, on normal lighted maps, its hard to hide */ 2861 /* so, on normal lighted maps, its hard to hide */
3025 level = ob->map->darkness - 2; 2862 level = ob->map->darklevel () - 2;
3026 2863
3027 /* this also picks up whether the object is glowing. 2864 /* this also picks up whether the object is glowing.
3028 * If you carry a light on a non-dark map, its not 2865 * If you carry a light on a non-dark map, its not
3029 * as bad as carrying a light on a pitch dark map */ 2866 * as bad as carrying a light on a pitch dark map */
3030 if (has_carried_lights (ob)) 2867 if (ob->has_carried_lights ())
3031 level = -(10 + (2 * ob->map->darkness)); 2868 level = -(10 + (2 * ob->map->darklevel ()));
3032 2869
3033 /* scan through all nearby squares for terrain to hide in */ 2870 /* scan through all nearby squares for terrain to hide in */
3034 for (i = 0, x = ob->x, y = ob->y; 2871 for (i = 0, x = ob->x, y = ob->y;
3035 i <= SIZEOFFREE1; 2872 i <= SIZEOFFREE1;
3036 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2873 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
… …
3108 2945
3109 if (who->type == PLAYER) 2946 if (who->type == PLAYER)
3110 player = 1; 2947 player = 1;
3111 2948
3112 else 2949 else
3113 friendly = QUERY_FLAG (who, FLAG_FRIENDLY); 2950 friendly = who->flag [FLAG_FRIENDLY];
3114 2951
3115 /* search adjacent squares */ 2952 /* search adjacent squares */
3116 for (i = 1; i < 9; i++) 2953 for (i = 1; i < 9; i++)
3117 { 2954 {
3118 x = who->x + freearr_x[i]; 2955 x = who->x + freearr_x[i];
… …
3127 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y))) 2964 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y)))
3128 continue; 2965 continue;
3129 2966
3130 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 2967 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
3131 { 2968 {
3132 if ((player ||friendly) &&QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_UNAGGRESSIVE)) 2969 if ((player ||friendly) &&tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_UNAGGRESSIVE])
3133 return 1; 2970 return 1;
3134 else if (tmp->type == PLAYER) 2971 else if (tmp->type == PLAYER)
3135 {
3136 /*don't let a hidden DM prevent you from hiding */
3137 if (!QUERY_FLAG (tmp, FLAG_WIZ) || tmp->contr->hidden == 0)
3138 return 1; 2972 return 1;
3139 }
3140 } 2973 }
3141 } 2974 }
3142 return 0; 2975 return 0;
3143} 2976}
3144 2977
3145/* check the player los field for viewability of the 2978/* check the player los field for viewability of the
3146 * object op. This function works fine for monsters, 2979 * object op. This function works fine for monsters,
3147 * but we dont worry if the object isnt the top one in 2980 * but we dont worry if the object isnt the top one in
3148 * a pile (say a coin under a table would return "viewable" 2981 * a pile (say a coin under a table would return "viewable"
3149 * by this routine). Another question, should we be 2982 * by this routine). Another question, should we be
3150 * concerned with the direction the player is looking 2983 * concerned with the direction the player is looking
3151 * in? Realistically, most of us can't see stuff behind 2984 * in? Realistically, most of us can't see stuff behind
3152 * our backs...on the other hand, does the "facing" direction 2985 * our backs...on the other hand, does the "facing" direction
3153 * imply the way your head, or body is facing? It's possible 2986 * imply the way your head, or body is facing? It's possible
3154 * for them to differ. Sigh, this fctn could get a bit more complex. 2987 * for them to differ. Sigh, this fctn could get a bit more complex.
3155 * -b.t. 2988 * -b.t.
3156 * This function is now map tiling safe. 2989 * This function is now map tiling safe.
3157 */ 2990 */
3158int 2991int
3159player_can_view (object *pl, object *op) 2992player_can_view (object *pl, object *op)
3160{ 2993{
… …
3183 while (op) 3016 while (op)
3184 { 3017 {
3185 dx = rv.distance_x + op->arch->x; 3018 dx = rv.distance_x + op->arch->x;
3186 dy = rv.distance_y + op->arch->y; 3019 dy = rv.distance_y + op->arch->y;
3187 3020
3188 /* only the viewable area the player sees is updated by LOS
3189 * code, so we need to restrict ourselves to that range of values
3190 * for any meaningful values.
3191 */
3192 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED) 3021 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3193 return 1; 3022 return 1;
3194 3023
3195 op = op->more; 3024 op = op->more;
3196 }
3197
3198 return 0;
3199}
3200
3201/* routine for both players and monsters. We call this when
3202 * there is a possibility for our action distrubing our hiding
3203 * place or invisiblity spell. Artefact invisiblity causes
3204 * "noise" instead. If we arent invisible to begin with, we
3205 * return 0.
3206 */
3207int
3208action_makes_visible (object *op)
3209{
3210 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3211 {
3212 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3213 {
3214 // artefact invisibility is permanent, but we still make noise
3215 // this is important for game-balance.
3216 if (op->contr)
3217 op->make_noise ();
3218
3219 return 0;
3220 }
3221
3222 if (op->contr && op->contr->tmp_invis == 0)
3223 return 0;
3224
3225 /* If monsters, they should become visible */
3226 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
3227 {
3228 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
3229 return 1;
3230 }
3231 } 3025 }
3232 3026
3233 return 0; 3027 return 0;
3234} 3028}
3235 3029
… …
3250 * and the exit-coordinates sp/hp must both be > 0. 3044 * and the exit-coordinates sp/hp must both be > 0.
3251 * => The intention here is to prevent abuse of the battleground- 3045 * => The intention here is to prevent abuse of the battleground-
3252 * feature (like pickable or hidden battleground tiles). */ 3046 * feature (like pickable or hidden battleground tiles). */
3253 for (object *tmp = op->below; tmp; tmp = tmp->below) 3047 for (object *tmp = op->below; tmp; tmp = tmp->below)
3254 { 3048 {
3255 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3049 if (tmp->flag [FLAG_IS_FLOOR])
3256 { 3050 {
3257 if (QUERY_FLAG (tmp, FLAG_NO_PICK) 3051 if (tmp->flag [FLAG_NO_PICK]
3258 && tmp->type == BATTLEGROUND 3052 && tmp->type == BATTLEGROUND
3259 && tmp->name == shstr_battleground 3053 && tmp->name == shstr_battleground
3260 && EXIT_X (tmp) && EXIT_Y (tmp)) 3054 && EXIT_X (tmp) && EXIT_Y (tmp))
3261 { 3055 {
3262 /* before we assign the exit, check if this is a teambattle */ 3056 /* before we assign the exit, check if this is a teambattle */
3263 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3057 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3264 {
3265 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below) 3058 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3059 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3266 { 3060 {
3267 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3268 {
3269 if (x && y) 3061 if (x && y)
3270 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3062 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3271 3063
3272 return 1; 3064 return 1;
3273 }
3274 } 3065 }
3275 }
3276 3066
3277 if (x && y) 3067 if (x && y)
3278 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3068 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3279 3069
3280 return 1; 3070 return 1;
… …
3418 else 3208 else
3419 j = 1; 3209 j = 1;
3420 strcat (buf, spellpathnames[i]); 3210 strcat (buf, spellpathnames[i]);
3421 } 3211 }
3422 } 3212 }
3213
3423 strcat (buf, "."); 3214 strcat (buf, ".");
3424 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf); 3215 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf);
3425 } 3216 }
3426 3217
3427 /* evtl. adding flags: */ 3218 /* evtl. adding flags: */
3428 if (QUERY_FLAG (item, FLAG_XRAYS)) 3219 if (item->flag [FLAG_XRAYS])
3429 SET_FLAG (skin, FLAG_XRAYS); 3220 skin->set_flag (FLAG_XRAYS);
3430 if (QUERY_FLAG (item, FLAG_STEALTH)) 3221 if (item->flag [FLAG_STEALTH])
3431 SET_FLAG (skin, FLAG_STEALTH); 3222 skin->set_flag (FLAG_STEALTH);
3432 if (QUERY_FLAG (item, FLAG_SEE_IN_DARK)) 3223 if (item->flag [FLAG_SEE_IN_DARK])
3433 SET_FLAG (skin, FLAG_SEE_IN_DARK); 3224 skin->set_flag (FLAG_SEE_IN_DARK);
3434 3225
3435 /* print message if there is one */ 3226 /* print message if there is one */
3436 if (item->msg != NULL) 3227 if (item->msg != NULL)
3437 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg); 3228 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg);
3438 } 3229 }
3439 else 3230 else
3440 { 3231 {
3441 /* generate misc. treasure */ 3232 /* generate misc. treasure */
3442 tmp = arch_to_object (tr->item); 3233 tmp = tr->item->instance ();
3443 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3234 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3444 who->insert (tmp); 3235 who->insert (tmp);
3445 } 3236 }
3446} 3237}
3447 3238
3448/** 3239//-GPL
3449 * Unready an object for a player. This function does nothing if the object was
3450 * not readied.
3451 */
3452void
3453player_unready_range_ob (player *pl, object *ob)
3454{
3455 if (pl->ob->current_weapon == ob)
3456 pl->ob->current_weapon = 0;
3457
3458 if (pl->combat_ob == ob)
3459 pl->combat_ob = 0;
3460
3461 if (pl->ranged_ob == ob)
3462 pl->ranged_ob = 0;
3463}
3464 3240
3465sint8 3241sint8
3466player::visibility_at (maptile *map, int x, int y) const 3242player::darkness_at (maptile *map, int x, int y) const
3467{ 3243{
3468 if (!ns) 3244 if (!ns)
3469 return 0; 3245 return LOS_BLOCKED;
3470 3246
3471 int dx, dy; 3247 int dx, dy;
3472 if (!adjacent_map (map, ns->current_map, &dx, &dy)) 3248 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3473 return 0; 3249 return LOS_BLOCKED;
3474 3250
3475 x += dx - ns->current_x; 3251 x += dx - ns->current_x;
3476 y += dy - ns->current_y; 3252 y += dy - ns->current_y;
3477 3253
3478 return 100 - blocked_los (x, y); 3254 return blocked_los (x, y);
3479} 3255}
3480 3256
3481void 3257void
3482player::infobox (const char *title, const char *msg, int color) 3258player::infobox (const char *title, const char *msg, int color)
3483{ 3259{
… …
3495{ 3271{
3496 play_sound (sound_find ("generic_failure")); 3272 play_sound (sound_find ("generic_failure"));
3497 statusmsg (msg, color); 3273 statusmsg (msg, color);
3498} 3274}
3499 3275
3276void
3277object::failmsgf (const char *format, ...)
3278{
3279 if (!contr)
3280 return;
3281
3282 va_list ap;
3283 va_start (ap, format);
3284 contr->failmsg (vformat (format, ap));
3285 va_end (ap);
3286}
3287
3288void
3289player::failmsgf (const char *format, ...)
3290{
3291 va_list ap;
3292 va_start (ap, format);
3293 failmsg (vformat (format, ap));
3294 va_end (ap);
3295}
3296

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines