ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.172 by root, Tue Oct 16 00:30:24 2007 UTC vs.
Revision 1.301 by root, Sat Nov 17 23:40:04 2018 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2017,2018 Marc Alexander Lehmann / the Deliantra team
5 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 6 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 7 * Copyright (©) 1992 Frank Tore Johansen
7 * 8 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 9 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 10 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 11 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 12 * option) any later version.
12 * 13 *
13 * This program is distributed in the hope that it will be useful, 14 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 17 * GNU General Public License for more details.
17 * 18 *
18 * You should have received a copy of the GNU General Public License 19 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 20 * and the GNU General Public License along with this program. If not, see
21 * <http://www.gnu.org/licenses/>.
20 * 22 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 23 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 24 */
25
26//+GPL
27
28#include <algorithm>
29#include <functional>
23 30
24#include <global.h> 31#include <global.h>
25#include <sproto.h> 32#include <sproto.h>
26#include <sounds.h> 33#include <sounds.h>
27#include <living.h> 34#include <living.h>
28#include <object.h> 35#include <object.h>
29#include <spells.h> 36#include <spells.h>
30#include <skills.h> 37#include <skills.h>
31 38
32#include <algorithm>
33#include <functional>
34
35playervec players; 39playervec players;
36
37void
38display_motd (const object *op)
39{
40 char buf[MAX_BUF];
41 char motd[HUGE_BUF];
42 FILE *fp;
43 int comp;
44 int size;
45
46 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
47 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
48 return;
49
50 motd[0] = '\0';
51 size = 0;
52
53 while (fgets (buf, MAX_BUF, fp))
54 {
55 if (*buf == '#')
56 continue;
57
58 strncat (motd + size, buf, HUGE_BUF - size);
59 size += strlen (buf);
60 }
61
62 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
63 close_and_delete (fp, comp);
64}
65
66void
67send_rules (const object *op)
68{
69 char buf[MAX_BUF];
70 char rules[HUGE_BUF];
71 FILE *fp;
72 int comp;
73 int size;
74
75 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
76 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
77 return;
78
79 rules[0] = '\0';
80 size = 0;
81
82 while (fgets (buf, MAX_BUF, fp))
83 {
84 if (*buf == '#')
85 continue;
86
87 if (size + strlen (buf) >= HUGE_BUF)
88 {
89 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
90 break;
91 }
92
93 strncat (rules + size, buf, HUGE_BUF - size);
94 size += strlen (buf);
95 }
96
97 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
98 close_and_delete (fp, comp);
99}
100
101void
102send_news (const object *op)
103{
104 char buf[MAX_BUF];
105 char news[HUGE_BUF];
106 char subject[MAX_BUF];
107 FILE *fp;
108 int comp;
109 int size;
110
111 sprintf (buf, "%s/%s", settings.confdir, settings.news);
112 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
113 return;
114
115 news[0] = '\0';
116 subject[0] = '\0';
117 size = 0;
118
119 while (fgets (buf, MAX_BUF, fp))
120 {
121 if (*buf == '#')
122 continue;
123
124 if (*buf == '%')
125 { /* send one news */
126 if (size > 0)
127 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s", (char *)"%s\n%s", subject, news); /*send previously read news */
128
129 strcpy (subject, buf + 1);
130 strip_endline (subject);
131 size = 0;
132 news[0] = '\0';
133 }
134 else
135 {
136 if (size + strlen (buf) >= HUGE_BUF)
137 {
138 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
139 break;
140 }
141 strncat (news + size, buf, HUGE_BUF - size);
142 size += strlen (buf);
143 }
144 }
145
146 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
147 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", (char *)"%s\n%s", subject, news);
148 close_and_delete (fp, comp);
149}
150 40
151/* This loads the first map an puts the player on it. */ 41/* This loads the first map an puts the player on it. */
152static void 42static void
153set_first_map (object *op) 43set_first_map (object *op)
154{ 44{
165 55
166 players.insert (this); 56 players.insert (this);
167 ob->remove (); 57 ob->remove ();
168 ob->map = 0; 58 ob->map = 0;
169 ob->activate_recursive (); 59 ob->activate_recursive ();
170 CLEAR_FLAG (ob, FLAG_FRIENDLY); 60 ob->clr_flag (FLAG_FRIENDLY);
171 add_friendly_object (ob); 61 add_friendly_object (ob);
172} 62}
173 63
174void 64void
175player::deactivate () 65player::deactivate ()
187 ob->remove (); 77 ob->remove ();
188 ob->enemy = 0; // sometimes keeps an extra refcount on itself 78 ob->enemy = 0; // sometimes keeps an extra refcount on itself
189 ob->map = 0; 79 ob->map = 0;
190 party = 0; 80 party = 0;
191 81
192 combat_ob = ranged_ob = 0; //TODO, should be special marker, non-refcounted, not this
193
194 players.erase (this); 82 players.erase (this);
195} 83}
196 84
197// connect the player with a specific client 85// connect the player with a specific client
198// also changes, rationalises, and fixes some incorrect settings 86// also changes, rationalises, and fixes some incorrect settings
207 ob->close_container (); //TODO: client-specific 95 ob->close_container (); //TODO: client-specific
208 96
209 ns->update_look = 0; 97 ns->update_look = 0;
210 ns->look_position = 0; 98 ns->look_position = 0;
211 99
212 clear_los (this); 100 clear_los ();
213 101
214 ns->reset_stats (); 102 ns->reset_stats ();
215 103
216 /* make sure he's a player -- needed because of class change. */ 104 /* make sure he's a player -- needed because of class change. */
217 ob->type = PLAYER; // we are paranoid 105 ob->type = PLAYER; // we are paranoid
218 ob->race = ob->arch->race; 106 ob->race = ob->arch->race;
219 107
220 ob->carrying = sum_weight (ob); 108 ob->update_weight ();
221 link_player_skills (ob); 109 link_skills ();
222
223 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
224 110
225 assign (title, ob->arch->object::name); 111 assign (title, ob->arch->object::name);
226 112
227 /* if it's a dragon player, set the correct title here */ 113 /* if it's a dragon player, set the correct title here */
228 if (is_dragon_pl (ob)) 114 if (ob->is_dragon ())
229 { 115 {
230 object *tmp, *abil = 0, *skin = 0; 116 object *tmp, *abil = 0, *skin = 0;
231 117
232 for (tmp = ob->inv; tmp; tmp = tmp->below) 118 for (tmp = ob->inv; tmp; tmp = tmp->below)
233 if (tmp->type == FORCE) 119 if (tmp->type == FORCE)
239 set_dragon_name (ob, abil, skin); 125 set_dragon_name (ob, abil, skin);
240 } 126 }
241 127
242 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 128 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
243 129
244 esrv_new_player (this, ob->weight + ob->carrying); 130 esrv_new_player (this);
245 131
246 ob->flag [FLAG_READY_WEAPON] = false; 132 ob->flag [FLAG_READY_WEAPON] = false;
247 ob->flag [FLAG_READY_SKILL] = false; 133 ob->flag [FLAG_READY_SKILL] = false;
134 ob->flag [FLAG_READY_RANGE] = false;
248 ob->flag [FLAG_READY_BOW] = false; 135 ob->flag [FLAG_READY_BOW] = false;
249 136
250 for (object *op = ob->inv; op; op = op->below)
251 if (op->flag [FLAG_APPLIED])
252 switch (op->type)
253 {
254 case SKILL:
255 ob->flag [FLAG_APPLIED] = false;
256 break;
257
258 case WAND:
259 case ROD:
260 case HORN:
261 case BOW:
262 ranged_ob = op;
263 break;
264
265 case WEAPON:
266 combat_ob = op;
267 break;
268 }
269
270 ob->change_weapon (combat_ob ? combat_ob : ranged_ob);
271 ob->update_stats (); 137 ob->update_stats ();
272 138
273 ns->floorbox_update (); 139 ns->floorbox_update ();
274 esrv_send_inventory (ob, ob); 140 esrv_send_inventory (ob, ob);
275 esrv_add_spells (this, 0); 141 esrv_add_spells (this, 0);
276 142
277 activate (); 143 activate ();
278 144
279 send_rules (ob);
280 send_news (ob);
281 display_motd (ob);
282
283 INVOKE_PLAYER (CONNECT, this); 145 INVOKE_PLAYER (CONNECT, this);
284 INVOKE_PLAYER (LOGIN, this); 146 INVOKE_PLAYER (LOGIN, this);
285} 147}
286 148
287void 149void
303 ns->reset_stats (); 165 ns->reset_stats ();
304 ns->pl = 0; 166 ns->pl = 0;
305 ns = 0; 167 ns = 0;
306 } 168 }
307 169
308 observe = ob; 170 // this is important for the player scheduler to get the correct refcount
171 // when ns = 0
172 observe = viewpoint = ob;
309 173
310 deactivate (); 174 deactivate ();
311} 175}
176
177//-GPL
312 178
313// the need for this function can be explained 179// the need for this function can be explained
314// by load_object not returning the object 180// by load_object not returning the object
315void 181void
316player::set_object (object *op) 182player::set_object (object *op)
317{ 183{
318 ob = observe = op; 184 ob = observe = viewpoint = op;
319 ob->contr = this; /* this aren't yet in archetype */ 185 ob->contr = this; /* this aren't yet in archetype */
320 186
321 ob->speed = 1.0f; 187 ob->speed = 1.0f; // object still inactive, keep it that way
322 ob->speed_left = 0.5f; 188 ob->speed_left = 0.5f;
323 189
324 ob->direction = 5; /* So player faces south */ 190 ob->direction = 5; /* So player faces south */
325} 191}
326 192
327void 193void
328player::set_observe (object *op) 194player::set_observe (object *op)
329{ 195{
330 observe = op ? op : ob; 196 observe = viewpoint = op ? op : ob;
331 do_los = 1; 197 do_los = 1;
332} 198}
199
200void
201player::set_viewpoint (object *op)
202{
203 viewpoint = op ? op : (object *)observe;
204 do_los = 1;
205}
206
207//+GPL
333 208
334player::player () 209player::player ()
335{ 210{
336 /* There are some elements we want initialised to non zero value - 211 /* There are some elements we want initialised to non zero value -
337 * we deal with that below this point. 212 * we deal with that below this point.
343 savebed_map = first_map_path; /* Init. respawn position */ 218 savebed_map = first_map_path; /* Init. respawn position */
344 219
345 gen_sp_armour = 10; 220 gen_sp_armour = 10;
346 bowtype = bow_normal; 221 bowtype = bow_normal;
347 petmode = pet_normal; 222 petmode = pet_normal;
348 listening = 10;
349 usekeys = containers; 223 usekeys = containers;
350 peaceful = 1; /* default peaceful */ 224 peaceful = 1; /* default peaceful */
351 do_los = 1; 225 do_los = 1;
352 226
353 weapon_sp = 1.0f; 227 weapon_sp = 1.0f;
361 235
362 attachable::do_destroy (); 236 attachable::do_destroy ();
363 237
364 if (ob) 238 if (ob)
365 { 239 {
366 ob->destroy_inv (false); 240 // potentially fix a bug where ob->contr is non-null while ob->contr->ob is null, causing a segfault.
241 // temporarily backed out patchset 4025 to see if THIS change causes crashes
242 //ob->contr = 0;
367 ob->destroy (); 243 ob->destroy ();
368 } 244 }
369 245
370 ob = observe = 0; 246 ob = observe = viewpoint = 0;
371} 247}
372 248
373player::~player () 249player::~player ()
374{ 250{
375 /* Clear item stack */ 251 /* Clear item stack */
376 free (stack_items); 252 free (stack_items);
253}
254
255/*
256 * get_player_archetype() return next player archetype from archetype
257 * list. Not very efficient routine, but used only creating new players.
258 * Note: there MUST be at least one player archetype!
259 */
260static archetype *
261get_player_archetype (archetype *at)
262{
263 // archetypes could have been reloaded
264 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
265
266 if (!nat)
267 return at;
268
269 archvec::iterator i = archetypes.find (nat);
270
271 for (;;)
272 {
273 if (++i == archetypes.end ())
274 i = archetypes.begin ();
275 else if (*i == at)
276 cleanup ("not a single player archetype found");
277
278 if ((*i)->type == PLAYER)
279 return *i;
280 }
377} 281}
378 282
379/* Tries to add player on the connection passed in ns. 283/* Tries to add player on the connection passed in ns.
380 * All we can really get in this is some settings like host and display 284 * All we can really get in this is some settings like host and display
381 * mode. 285 * mode.
383player * 287player *
384player::create () 288player::create ()
385{ 289{
386 player *pl = new player; 290 player *pl = new player;
387 291
388 pl->set_object (arch_to_object (get_player_archetype (0))); 292 pl->set_object (get_player_archetype (0)->instance ());
389 293
390 pl->ob->roll_stats (); 294 pl->ob->roll_stats ();
391 pl->ob->stats.wc = 2; 295 pl->ob->stats.wc = 2;
392 pl->ob->run_away = 25; /* Then we panick... */ 296 pl->ob->run_away = 25; /* Then we panick... */
393 297
394 set_first_map (pl->ob); 298 set_first_map (pl->ob);
395 299
396 return pl; 300 return pl;
397}
398
399/*
400 * get_player_archetype() return next player archetype from archetype
401 * list. Not very efficient routine, but used only creating new players.
402 * Note: there MUST be at least one player archetype!
403 */
404archetype *
405get_player_archetype (archetype *at)
406{
407 archvec::iterator i = at ? archetypes.find (at) : archetypes.begin ();
408
409 for (;;)
410 {
411 if (++i == archetypes.end ())
412 i = archetypes.begin ();
413 else if (*i == at)
414 cleanup ("not a single player archetype found");
415
416 if ((*i)->type == PLAYER)
417 return *i;
418 }
419} 301}
420 302
421object * 303object *
422get_nearest_player (object *mon) 304get_nearest_player (object *mon)
423{ 305{
451#endif 333#endif
452 return op; 334 return op;
453} 335}
454 336
455/* I believe this can safely go to 2, 3 is questionable, 4 will likely 337/* I believe this can safely go to 2, 3 is questionable, 4 will likely
456 * result in a monster paths backtracking. It basically determines how large a 338 * result in a monster paths backtracking. It basically determines how large a
457 * detour a monster will take from the direction path when looking 339 * detour a monster will take from the direction path when looking
458 * for a path to the player. The values are in the amount of direction 340 * for a path to the player. The values are in the amount of direction
459 * the deviation is 341 * the deviation is
460 */ 342 */
461#define DETOUR_AMOUNT 2 343#define DETOUR_AMOUNT 2
497 */ 379 */
498int 380int
499path_to_player (object *mon, object *pl, unsigned mindiff) 381path_to_player (object *mon, object *pl, unsigned mindiff)
500{ 382{
501 rv_vector rv; 383 rv_vector rv;
502 sint16 x, y;
503 int lastx, lasty, dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES, mflags, blocked; 384 int dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES;
504 maptile *m, *lastmap;
505 385
506 get_rangevector (mon, pl, &rv, 0); 386 get_rangevector (mon, pl, &rv, 0);
507 387
508 if (rv.distance < mindiff) 388 if (rv.distance < mindiff)
509 return 0; 389 return 0;
510 390
511 x = mon->x; 391 mapxy pos (mon);
512 y = mon->y;
513 m = mon->map;
514 dir = rv.direction; 392 dir = rv.direction;
515 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 393 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
516 diff = ::max (abs (rv.distance_x), abs (rv.distance_y)); 394 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
517 395
518 /* If we can't solve it within the search distance, return now. */ 396 /* If we can't solve it within the search distance, return now. */
519 if (diff > max) 397 if (diff > max)
520 return 0; 398 return 0;
521 399
522 while (diff > 1 && max > 0) 400 while (diff > 1 && max > 0)
523 { 401 {
524 lastx = x; 402 mapxy lastpos = pos;
525 lasty = y;
526 lastmap = m;
527 x = lastx + freearr_x[dir];
528 y = lasty + freearr_y[dir];
529 403
530 mflags = get_map_flags (m, &m, x, y, &x, &y); 404 pos.move (dir);
531 blocked = (mflags & P_OUT_OF_MAP) ? MOVE_ALL : GET_MAP_MOVE_BLOCK (m, x, y);
532 405
533 /* Space is blocked - try changing direction a little */ 406 /* Space is blocked - try changing direction a little */
534 if ((mflags & P_OUT_OF_MAP) || ((OB_TYPE_MOVE_BLOCK (mon, blocked) || (mflags & P_BLOCKSVIEW)) 407 if (!pos.normalise ()
535 && (m == mon->map && blocked_link (mon, m, x, y)))) 408 || (((pos->flags () & P_BLOCKSVIEW) || OB_TYPE_MOVE_BLOCK (mon, pos->move_block))
409 && blocked_link (mon, pos.m, pos.x, pos.y)))
536 { 410 {
537 /* recalculate direction from last good location. Possible 411 /* recalculate direction from last good location. Possible
538 * we were not traversing ideal location before. 412 * we were not traversing ideal location before.
539 */ 413 */
540 get_rangevector_from_mapcoord (lastmap, lastx, lasty, pl, &rv, 0); 414 get_rangevector_from_mapcoord (lastpos.m, lastpos.x, lastpos.y, pl, &rv, 0);
541 if (rv.direction != dir) 415 if (rv.direction != dir)
542 { 416 {
543 /* OK - says direction should be different - lets reset the 417 /* OK - says direction should be different - lets reset the
544 * the values so it will try again. 418 * the values so it will try again.
545 */ 419 */
546 x = lastx;
547 y = lasty;
548 m = lastmap; 420 pos = lastpos;
549 dir = firstdir = rv.direction; 421 dir = firstdir = rv.direction;
550 } 422 }
551 else 423 else
552 { 424 {
553 /* direct path is blocked - try taking a side step to 425 /* direct path is blocked - try taking a side step to
554 * either the left or right. 426 * either the left or right.
555 * Note increase the values in the loop below to be 427 * Note increase the values in the loop below to be
556 * more than -1/1 respectively will mean the monster takes 428 * more than -1/1 respectively will mean the monster takes
557 * bigger detour. Have to be careful about these values getting 429 * bigger detour. Have to be careful about these values getting
558 * too big (3 or maybe 4 or higher) as the monster may just try 430 * too big (3 or maybe 4 or higher) as the monster may just try
559 * stepping back and forth 431 * stepping back and forth
560 */ 432 */
561 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++) 433 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++)
562 { 434 {
563 if (i == 0) 435 if (i == 0)
564 continue; /* already did this, so skip it */ 436 continue; /* already did this, so skip it */
437
565 /* Use lastdir here - otherwise, 438 /* Use lastdir here - otherwise,
566 * since the direction that the creature should move in 439 * since the direction that the creature should move in
567 * may change, you could get infinite loops. 440 * may change, you could get infinite loops.
568 * ie, player is northwest, but monster can only 441 * ie, player is northwest, but monster can only
569 * move west, so it does that. It goes some distance, 442 * move west, so it does that. It goes some distance,
571 * can't do that, but now finds it can move east, and 444 * can't do that, but now finds it can move east, and
572 * gets back to its original point. lastdir contains 445 * gets back to its original point. lastdir contains
573 * the last direction the creature has successfully 446 * the last direction the creature has successfully
574 * moved. 447 * moved.
575 */ 448 */
576
577 x = lastx + freearr_x[absdir (lastdir + i)];
578 y = lasty + freearr_y[absdir (lastdir + i)];
579 m = lastmap; 449 pos = lastpos;
580 mflags = get_map_flags (m, &m, x, y, &x, &y); 450 pos.move (absdir (lastdir + i));
581 if (mflags & P_OUT_OF_MAP) 451
452 if (!pos.normalise ())
582 continue; 453 continue;
583 blocked = GET_MAP_MOVE_BLOCK (m, x, y); 454
584 if (OB_TYPE_MOVE_BLOCK (mon, blocked)) 455 mapspace &ms = *pos;
456
457 if (ms.flags () & P_BLOCKSVIEW)
585 continue; 458 continue;
586 if (mflags & P_BLOCKSVIEW) 459
460 if (OB_TYPE_MOVE_BLOCK (mon, ms.move_block))
587 continue; 461 continue;
588 462
589 if (m == mon->map && blocked_link (mon, m, x, y)) 463 if (blocked_link (mon, pos.m, pos.x, pos.y))
590 break; 464 break;
591 } 465 }
466
592 /* go through entire loop without finding a valid 467 /* go through entire loop without finding a valid
593 * sidestep to take - thus, no valid path. 468 * sidestep to take - thus, no valid path.
594 */ 469 */
595 if (i == (DETOUR_AMOUNT + 1)) 470 if (i == DETOUR_AMOUNT + 1)
596 return 0; 471 return 0;
472
597 diff--; 473 diff--;
598 lastdir = dir; 474 lastdir = dir;
599 max--; 475 max--;
600 if (!firstdir) 476 if (!firstdir)
601 firstdir = dir + i; 477 firstdir = dir + i;
605 { 481 {
606 /* we moved towards creature, so diff is less */ 482 /* we moved towards creature, so diff is less */
607 diff--; 483 diff--;
608 max--; 484 max--;
609 lastdir = dir; 485 lastdir = dir;
486
610 if (!firstdir) 487 if (!firstdir)
611 firstdir = dir; 488 firstdir = dir;
612 } 489 }
613 490
614 if (diff <= 1) 491 if (diff <= 1)
615 { 492 {
616 /* Recalculate diff (distance) because we may not have actually 493 /* Recalculate diff (distance) because we may not have actually
617 * headed toward player for entire distance. 494 * headed toward player for entire distance.
618 */ 495 */
619 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 496 get_rangevector_from_mapcoord (pos.m, pos.x, pos.y, pl, &rv, 0);
620 diff = ::max (abs (rv.distance_x), abs (rv.distance_y)); 497 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
621 } 498 }
622 499
623 if (diff > max) 500 if (diff > max)
624 return 0; 501 return 0;
630 507
631 return firstdir; 508 return firstdir;
632} 509}
633 510
634void 511void
635give_initial_items (object *pl, treasurelist * items) 512give_initial_items (object *pl, treasurelist *items)
636{ 513{
637 object *op, *next = NULL;
638
639 if (pl->randomitems != NULL) 514 if (pl->randomitems)
640 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0); 515 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0);
641 516
642 for (op = pl->inv; op; op = next) 517 for (object *next, *op = pl->inv; op; op = next)
643 { 518 {
644 next = op->below; 519 next = op->below;
645 520
646 /* Forces get applied per default, unless they have the 521 /* Forces get applied per default, unless they have the
647 * flag "neutral" set. Sorry but I can't think of a better way 522 * flag "neutral" set. Sorry but I can't think of a better way
648 */ 523 */
649 if (op->type == FORCE && !QUERY_FLAG (op, FLAG_NEUTRAL)) 524 if (op->type == FORCE && !op->flag [FLAG_NEUTRAL])
650 SET_FLAG (op, FLAG_APPLIED); 525 op->set_flag (FLAG_APPLIED);
651 526
652 /* we never give weapons/armour if these cannot be used 527 /* we never give weapons/armour if these cannot be used
653 * by this player due to race restrictions 528 * by this player due to race restrictions
654 */ 529 */
655 if (pl->type == PLAYER) 530 if (pl->type == PLAYER)
656 { 531 {
657 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) && 532 if ((!pl->flag [FLAG_USE_ARMOUR]
533 &&
658 (op->type == ARMOUR || op->type == BOOTS || 534 (op->type == ARMOUR || op->type == BOOTS
659 op->type == CLOAK || op->type == HELMET || 535 || op->type == CLOAK || op->type == HELMET
660 op->type == SHIELD || op->type == GLOVES || 536 || op->type == SHIELD || op->type == GLOVES
661 op->type == BRACERS || op->type == GIRDLE)) || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 537 || op->type == BRACERS || op->type == GIRDLE))
538 || (!pl->flag [FLAG_USE_WEAPON] && op->type == WEAPON))
662 { 539 {
663 op->destroy (); 540 op->destroy ();
664 continue; 541 continue;
665 } 542 }
666 } 543 }
667 544
668 /* This really needs to be better - we should really give 545 /* Here we remove duplicated skills (as duplicated spell objects have
669 * a substitute spellbook. The problem is that we don't really 546 * _very_ confusing effects for players), which could for instance be
670 * have a good idea what to replace it with (need something like 547 * generated by multiple treasurelists specifying the same skills.
671 * a first level treasurelist for each skill.)
672 * remove duplicate skills also
673 */ 548 */
674 if (op->type == SPELLBOOK || op->type == SKILL) 549 if (op->type == SKILL)
675 { 550 {
676 object *tmp;
677
678 for (tmp = op->below; tmp; tmp = tmp->below) 551 for (object *tmp = op->below; tmp; tmp = tmp->below)
679 if (tmp->type == op->type && tmp->name == op->name) 552 if (tmp->type == op->type && tmp->name == op->name)
680 break;
681
682 if (tmp)
683 { 553 {
684 op->destroy (); 554 op->destroy ();
685 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 555 break;
686 continue;
687 } 556 }
688 557
689 if (op->nrof > 1) 558 if (op->nrof > 1)
690 op->nrof = 1; 559 op->nrof = 1;
691 } 560 }
692 561
693 if (op->type == SPELLBOOK && op->inv) 562 if (op->type == SPELLBOOK && op->inv)
694 { 563 op->inv->clr_flag (FLAG_STARTEQUIP);
695 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP);
696 }
697 564
698 /* Give starting characters identified, uncursed, and undamned 565 /* Give starting characters identified, uncursed, and undamned
699 * items. Just don't identify gold or silver, or it won't be 566 * items. Just don't identify gold or silver, or it won't be
700 * merged properly. 567 * merged properly.
701 */ 568 */
702 if (need_identify (op)) 569 if (op->need_identify ())
703 {
704 SET_FLAG (op, FLAG_IDENTIFIED);
705 CLEAR_FLAG (op, FLAG_CURSED);
706 CLEAR_FLAG (op, FLAG_DAMNED);
707 } 570 {
571 op->set_flag (FLAG_IDENTIFIED);
572 op->clr_flag (FLAG_CURSED);
573 op->clr_flag (FLAG_DAMNED);
574 }
575
708 if (op->type == SPELL) 576 if (op->type == SPELL)
709 { 577 {
710 op->destroy (); 578 op->destroy ();
711 continue; 579 continue;
712 } 580 }
713 else if (op->type == SKILL) 581 else if (op->type == SKILL)
714 { 582 {
715 SET_FLAG (op, FLAG_CAN_USE_SKILL); 583 op->set_flag (FLAG_CAN_USE_SKILL);
716 op->stats.exp = 0; 584 op->stats.exp = 0;
717 op->level = 1; 585 op->level = 1;
718 } 586 }
719 /* lock all 'normal items by default */ 587 else /* lock all 'normal items by default */
720 else 588 op->set_flag (FLAG_INV_LOCKED);
721 SET_FLAG (op, FLAG_INV_LOCKED);
722 } /* for loop of objects in player inv */ 589 } /* for loop of objects in player inv */
723 590
724 /* Need to set up the skill pointers */ 591 /* Need to set up the skill pointers */
725 link_player_skills (pl); 592 pl->contr->link_skills ();
726} 593}
727 594
728void 595void
729get_party_password (object *op, partylist *party) 596get_party_password (object *op, partylist *party)
730{ 597{
740 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:"); 607 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:");
741} 608}
742 609
743/* This rolls four 1-6 rolls and sums the best 3 of the 4. */ 610/* This rolls four 1-6 rolls and sums the best 3 of the 4. */
744static int 611static int
745roll_stat (void) 612roll_stat ()
746{ 613{
747 int a[4], i, j, k; 614 int a[4], i, j, k;
748 615
749 for (i = 0; i < 4; i++) 616 for (i = 0; i < 4; i++)
750 a[i] = (int) rndm (6) + 1; 617 a[i] = rndm (1, 6);
751 618
752 for (i = 0, j = 0, k = 7; i < 4; i++) 619 for (i = 0, j = 0, k = 7; i < 4; i++)
753 if (a[i] < k) 620 if (a[i] < k)
754 k = a[i], j = i; 621 k = a[i], j = i;
755 622
831static void 698static void
832start_info (object *op) 699start_info (object *op)
833{ 700{
834 char buf[MAX_BUF]; 701 char buf[MAX_BUF];
835 702
836 sprintf (buf, "Welcome to Crossfire v%s!", VERSION); 703 sprintf (buf, "Welcome to Deliantra v%s!", VERSION);
837 new_draw_info (NDI_UNIQUE, 0, op, buf); 704 new_draw_info (NDI_UNIQUE, 0, op, buf);
838 //new_draw_info (NDI_UNIQUE, 0, op, "Press `?' for help");
839 //new_draw_info (NDI_UNIQUE, 0, op, " ");
840} 705}
841 706
842/* This function takes the key that is passed, and does the 707/* This function takes the key that is passed, and does the
843 * appropriate action with it (change race, or other things). 708 * appropriate action with it (change race, or other things).
844 * The function name is for historical reasons - now we have 709 * The function name is for historical reasons - now we have
847 */ 712 */
848void 713void
849player::chargen_race_done () 714player::chargen_race_done ()
850{ 715{
851 /* this must before then initial items are given */ 716 /* this must before then initial items are given */
852 esrv_new_player (ob->contr, ob->weight + ob->carrying); 717 esrv_new_player (ob->contr);
853 718
854 treasurelist *tl = treasurelist::find ("starting_wealth"); 719 treasurelist *tl = treasurelist::find (shstr_starting_wealth);
855 if (tl) 720 if (tl)
856 create_treasure (tl, ob, 0, 0, 0); 721 create_treasure (tl, ob, 0, 0, 0);
857 722
858 INVOKE_PLAYER (BIRTH, ob->contr); 723 INVOKE_PLAYER (BIRTH, ob->contr);
859 INVOKE_PLAYER (LOGIN, ob->contr);
860 724
861 ob->contr->ns->state = ST_PLAYING; 725 ob->contr->ns->state = ST_PLAYING;
862 726
863 if (ob->msg) 727 if (ob->msg)
864 ob->msg = 0; 728 ob->msg = 0;
865 729
866 /* We create this now because some of the unique maps will need it
867 * to save here.
868 */
869 {
870 char buf[MAX_BUF];
871 sprintf (buf, "%s/%s/%s", settings.localdir, settings.playerdir, &ob->name);
872 make_path_to_file (buf);
873 }
874
875 start_info (ob); 730 start_info (ob);
876 CLEAR_FLAG (ob, FLAG_WIZ); 731 ob->clr_flag (FLAG_WIZ);
877 give_initial_items (ob, ob->randomitems); 732 give_initial_items (ob, ob->randomitems);
878 link_player_skills (ob);
879 esrv_send_inventory (ob, ob); 733 esrv_send_inventory (ob, ob);
880 ob->update_stats (); 734 ob->update_stats ();
881 735
882 /* This moves the player to a different start map, if there 736 /* This moves the player to a different start map, if there
883 * is one for this race 737 * is one for this race
884 */ 738 */
885 if (*first_map_ext_path) 739 if (*first_map_ext_path)
886 { 740 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
887 object *tmp;
888 char mapname[MAX_BUF];
889
890 snprintf (mapname, MAX_BUF - 1, "%s/%s", &first_map_ext_path, &ob->arch->archname);
891 tmp = object::create ();
892 EXIT_PATH (tmp) = mapname;
893 EXIT_X (tmp) = ob->x;
894 EXIT_Y (tmp) = ob->y;
895 ob->enter_exit (tmp); /* we don't really care if it succeeded;
896 * if the map isn't there, then stay on the
897 * default initial map */
898 tmp->destroy ();
899 }
900 else 741 else
901 LOG (llevDebug, "first_map_ext_path not set\n"); 742 LOG (llevDebug, "first_map_ext_path not set\n");
743}
744
745/*
746 * Returns true if the given player is a legal class.
747 * The function to add and remove class-bonuses to the stats doesn't
748 * check if the stat becomes negative, thus this function
749 * merely checks that all stats are 1 or more, and returns
750 * false otherwise.
751 */
752static int
753allowed_class (const object *op)
754{
755 return op->stats.Dex > 0
756 && op->stats.Str > 0
757 && op->stats.Con > 0
758 && op->stats.Int > 0
759 && op->stats.Wis > 0
760 && op->stats.Pow > 0
761 && op->stats.Cha > 0;
902} 762}
903 763
904void 764void
905player::chargen_race_next () 765player::chargen_race_next ()
906{ 766{
935 ob->stats.hp = ob->stats.maxhp; 795 ob->stats.hp = ob->stats.maxhp;
936 ob->stats.sp = ob->stats.maxsp; 796 ob->stats.sp = ob->stats.maxsp;
937 ob->stats.grace = 0; 797 ob->stats.grace = 0;
938} 798}
939 799
940void 800static void
941flee_player (object *op) 801flee_player (object *op)
942{ 802{
943 int dir, diff; 803 int dir, diff;
944 rv_vector rv; 804 rv_vector rv;
945 805
946 if (op->stats.hp < 0) 806 if (op->stats.hp < 0)
947 { 807 {
948 LOG (llevDebug, "Fleeing player is dead.\n"); 808 LOG (llevDebug, "Fleeing player is dead.\n");
949 CLEAR_FLAG (op, FLAG_SCARED); 809 op->clr_flag (FLAG_SCARED);
950 return; 810 return;
951 } 811 }
952 812
953 if (op->enemy == NULL) 813 if (!op->enemy)
954 { 814 {
955 LOG (llevDebug, "Fleeing player had no enemy.\n"); 815 LOG (llevDebug, "Fleeing player had no enemy.\n");
956 CLEAR_FLAG (op, FLAG_SCARED); 816 op->clr_flag (FLAG_SCARED);
957 return; 817 return;
958 } 818 }
959 819
960 /* Seen some crashes here. Since we don't store an 820 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
961 * op->enemy_count, it is possible that something destroys the
962 * actual enemy, and the object is recycled.
963 */
964 if (op->enemy->map == NULL)
965 { 821 {
966 CLEAR_FLAG (op, FLAG_SCARED);
967 op->enemy = NULL; 822 op->enemy = NULL;
968 return; 823 op->clr_flag (FLAG_SCARED);
969 }
970
971 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
972 {
973 op->enemy = NULL;
974 CLEAR_FLAG (op, FLAG_SCARED);
975 return; 824 return;
976 } 825 }
977 826
978 get_rangevector (op, op->enemy, &rv, 0); 827 get_rangevector (op, op->enemy, &rv, 0);
979 828
980 dir = absdir (4 + rv.direction); 829 dir = absdir (4 + rv.direction);
981 for (diff = 0; diff < 3; diff++) 830 for (diff = 0; diff < 3; diff++)
982 { 831 {
983 int m = 1 - (RANDOM () & 2); 832 int m = 1 - rndm (2) * 2;
984 833
985 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 834 if (op->move (absdir (dir + diff * m)) || (diff == 0 && op->move (absdir (dir - diff * m))))
986 return; 835 return;
987 } 836 }
988 837
989 /* Cornered, get rid of scared */ 838 /* Cornered, get rid of scared */
990 CLEAR_FLAG (op, FLAG_SCARED); 839 op->clr_flag (FLAG_SCARED);
991 op->enemy = NULL; 840 op->enemy = NULL;
992} 841}
993 842
994/* check_pick sees if there is stuff to be picked up/picks up stuff. 843/* check_pick sees if there is stuff to be picked up/picks up stuff.
995 * It returns 1 if the player should keep on moving, 0 if he should 844 * It returns 1 if the player should keep on moving, 0 if he should
999check_pick (object *op) 848check_pick (object *op)
1000{ 849{
1001 object *tmp, *next; 850 object *tmp, *next;
1002 int stop = 0; 851 int stop = 0;
1003 int wvratio; 852 int wvratio;
1004 char putstring[128];
1005 853
1006 /* if you're flying, you cna't pick up anything */ 854 /* if you're flying, you can't pick up anything */
1007 if (op->move_type & MOVE_FLYING) 855 if (op->move_type & MOVE_FLYING)
1008 return 1; 856 return 1;
1009 857
1010 next = op->below; 858 next = op->below;
859
860 int cnt = MAX_ITEM_PER_ACTION;
861#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
1011 862
1012 /* loop while there are items on the floor that are not marked as 863 /* loop while there are items on the floor that are not marked as
1013 * destroyed */ 864 * destroyed */
1014 while (next && !next->destroyed ()) 865 while (next && !next->destroyed ())
1015 { 866 {
1016 tmp = next; 867 tmp = next;
1017 next = tmp->below; 868 next = tmp->below;
1018 869
870 if (cnt <= 0)
871 {
872 op->failmsg ("Couldn't pickup all items at once.");
873 return 0;
874 }
875
1019 if (op->destroyed ()) 876 if (op->destroyed ())
1020 return 0; 877 return 0;
1021 878
1022 if (!can_pick (op, tmp)) 879 if (!can_pick (op, tmp))
1023 continue; 880 continue;
1024 881
1025 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 882 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1026 { 883 {
1027 if (item_matched_string (op, tmp, op->contr->search_str)) 884 if (item_matched_string (op, tmp, op->contr->search_str))
1028 pick_up (op, tmp); 885 CHK_PICK_PICKUP;
886
1029 continue; 887 continue;
1030 } 888 }
1031 889
1032 /* high not bit set? We're using the old autopickup model */ 890 /* pickup handling */
891 if (op->contr->mode & PU_DEBUG)
892 {
893 /* some debugging code to figure out item information */
894 const char *str = tmp->name
895 ? format ("item name: %s item type: %d weight/value: %d",
896 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))))
897 : format ("item name: %s item type: %d weight/value: %d",
898 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
899
900 new_draw_info (NDI_UNIQUE, 0, op, str);
901 }
902
903 if (op->contr->mode & PU_INHIBIT)
904 return 1;
905
906 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
907 return 1;
908
909 /* philosophy:
910 * It's easy to grab an item type from a pile, as long as it's
911 * generic. This takes no game-time. For more detailed pickups
912 * and selections, select-items should be used. This is a
913 * grab-as-you-run type mode that's really useful for arrows for
914 * example.
915 * The drawback: right now it has no frontend, so you need to
916 * stick the bits you want into a calculator in hex mode and then
917 * convert to decimal and then 'pickup <#>
918 */
919
920 /* the first two modes are exclusive: if NOTHING we return, if
921 * STOP then we stop. All the rest are applied sequentially,
922 * meaning if any test passes, the item gets picked up. */
923
924 /* if mode is set to pick nothing up, return */
925 if (op->contr->mode == PU_NOTHING)
926 return 1;
927
928 /* if mode is set to stop when encountering objects, return */
929 /* take STOP before INHIBIT since it doesn't actually pick
930 * anything up */
931 if (op->contr->mode & PU_STOP)
932 return 0;
933
934 /* useful for going into stores and not losing your settings... */
935 /* and for battles wher you don't want to get loaded down while
936 * fighting */
937 if (op->contr->mode & PU_INHIBIT)
938 return 1;
939
940 /* prevent us from turning into auto-thieves :) */
941 if (tmp->flag [FLAG_UNPAID])
942 continue;
943
944 /* ignore known cursed objects */
945 if (tmp->flag [FLAG_KNOWN_CURSED] && op->contr->mode & PU_NOT_CURSED)
946 continue;
947
948 /* all food and drink if desired */
949 /* question: don't pick up known-poisonous stuff? */
1033 if (!(op->contr->mode & PU_NEWMODE)) 950 if (op->contr->mode & PU_FOOD)
951 if (tmp->type == FOOD)
1034 { 952 {
1035 switch (op->contr->mode) 953 CHK_PICK_PICKUP;
954 continue;
955 }
956
957 if (op->contr->mode & PU_DRINK)
958 if (tmp->type == DRINK || (tmp->type == POISON && !tmp->flag [FLAG_KNOWN_CURSED]))
959 {
960 CHK_PICK_PICKUP;
961 continue;
962 }
963
964 if (op->contr->mode & PU_POTION)
965 if (tmp->type == POTION)
966 {
967 CHK_PICK_PICKUP;
968 continue;
969 }
970
971 /* spellbooks, skillscrolls and normal books/scrolls */
972 if (op->contr->mode & PU_SPELLBOOK)
973 if (tmp->type == SPELLBOOK)
974 {
975 CHK_PICK_PICKUP;
976 continue;
977 }
978
979 if (op->contr->mode & PU_SKILLSCROLL)
980 if (tmp->type == SKILLSCROLL)
981 {
982 CHK_PICK_PICKUP;
983 continue;
984 }
985
986 if (op->contr->mode & PU_READABLES)
987 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
988 {
989 CHK_PICK_PICKUP;
990 continue;
991 }
992
993 /* wands/staves/rods/horns */
994 if (op->contr->mode & PU_MAGIC_DEVICE)
995 if (tmp->type == WAND
996 || tmp->type == ROD
997 || tmp->type == HORN
998 || tmp->type == POWER_CRYSTAL)
999 {
1000 CHK_PICK_PICKUP;
1001 continue;
1002 }
1003
1004 /* pick up all magical items */
1005 if (op->contr->mode & PU_MAGICAL)
1006 if (tmp->flag [FLAG_KNOWN_MAGICAL]
1007 && !tmp->flag [FLAG_KNOWN_CURSED])
1008 {
1009 CHK_PICK_PICKUP;
1010 continue;
1011 }
1012
1013 if (op->contr->mode & PU_VALUABLES)
1014 {
1015 if (tmp->type == MONEY || tmp->type == GEM)
1036 { 1016 {
1037 case 0: 1017 CHK_PICK_PICKUP;
1038 return 1; /* don't pick up */ 1018 continue;
1039 case 1:
1040 pick_up (op, tmp);
1041 return 1;
1042 case 2:
1043 pick_up (op, tmp);
1044 return 0;
1045 case 3:
1046 return 0; /* stop before pickup */
1047 case 4:
1048 pick_up (op, tmp);
1049 break;
1050 case 5:
1051 pick_up (op, tmp);
1052 stop = 1;
1053 break;
1054 case 6:
1055 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1056 pick_up (op, tmp);
1057 break;
1058
1059 case 7:
1060 if (tmp->type == MONEY || tmp->type == GEM)
1061 pick_up (op, tmp);
1062 break;
1063
1064 default:
1065 /* use value density */
1066 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1067 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1068 pick_up (op, tmp);
1069 } 1019 }
1070 } 1020 }
1071 else 1021
1072 { /* old model */ 1022 /* rings & amulets - talismans seems to be typed AMULET */
1073 /* NEW pickup handling */
1074 if (op->contr->mode & PU_DEBUG) 1023 if (op->contr->mode & PU_JEWELS)
1024 if (tmp->type == RING
1025 || tmp->type == AMULET
1026 || tmp->type == GIRDLE
1027 || tmp->type == SKILL_TOOL)
1075 { 1028 {
1076 /* some debugging code to figure out item information */ 1029 CHK_PICK_PICKUP;
1077 if (tmp->name != NULL)
1078 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1079 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1080 else
1081 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1082 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1083
1084 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1085 }
1086
1087 /* philosophy:
1088 * It's easy to grab an item type from a pile, as long as it's
1089 * generic. This takes no game-time. For more detailed pickups
1090 * and selections, select-items should be used. This is a
1091 * grab-as-you-run type mode that's really useful for arrows for
1092 * example.
1093 * The drawback: right now it has no frontend, so you need to
1094 * stick the bits you want into a calculator in hex mode and then
1095 * convert to decimal and then 'pickup <#>
1096 */
1097
1098 /* the first two modes are exclusive: if NOTHING we return, if
1099 * STOP then we stop. All the rest are applied sequentially,
1100 * meaning if any test passes, the item gets picked up. */
1101
1102 /* if mode is set to pick nothing up, return */
1103
1104 if (op->contr->mode & PU_NOTHING)
1105 return 1;
1106
1107 /* if mode is set to stop when encountering objects, return */
1108 /* take STOP before INHIBIT since it doesn't actually pick
1109 * anything up */
1110
1111 if (op->contr->mode & PU_STOP)
1112 return 0;
1113
1114 /* useful for going into stores and not losing your settings... */
1115 /* and for battles wher you don't want to get loaded down while
1116 * fighting */
1117 if (op->contr->mode & PU_INHIBIT)
1118 return 1;
1119
1120 /* prevent us from turning into auto-thieves :) */
1121 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1122 continue; 1030 continue;
1031 }
1123 1032
1124 /* ignore known cursed objects */ 1033 /* we don't forget dragon food */
1125 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1034 if (op->contr->mode & PU_FLESH)
1035 if (tmp->type == FLESH)
1036 {
1037 CHK_PICK_PICKUP;
1126 continue; 1038 continue;
1039 }
1127 1040
1128 /* all food and drink if desired */ 1041 /* bows and arrows. Bows are good for selling! */
1129 /* question: don't pick up known-poisonous stuff? */ 1042 if (op->contr->mode & PU_BOW)
1043 if (tmp->type == BOW)
1044 {
1045 CHK_PICK_PICKUP;
1046 continue;
1047 }
1048
1049 if (op->contr->mode & PU_ARROW)
1050 if (tmp->type == ARROW)
1051 {
1052 CHK_PICK_PICKUP;
1053 continue;
1054 }
1055
1056 /* all kinds of armor etc. */
1057 if (op->contr->mode & PU_ARMOUR)
1058 if (tmp->type == ARMOUR)
1059 {
1060 CHK_PICK_PICKUP;
1061 continue;
1062 }
1063
1064 if (op->contr->mode & PU_HELMET)
1065 if (tmp->type == HELMET)
1066 {
1067 CHK_PICK_PICKUP;
1068 continue;
1069 }
1070
1071 if (op->contr->mode & PU_SHIELD)
1072 if (tmp->type == SHIELD)
1073 {
1074 CHK_PICK_PICKUP;
1075 continue;
1076 }
1077
1130 if (op->contr->mode & PU_FOOD) 1078 if (op->contr->mode & PU_BOOTS)
1131 if (tmp->type == FOOD) 1079 if (tmp->type == BOOTS)
1080 {
1081 CHK_PICK_PICKUP;
1082 continue;
1083 }
1084
1085 if (op->contr->mode & PU_GLOVES)
1086 if (tmp->type == GLOVES || tmp->type == BRACERS)
1087 {
1088 CHK_PICK_PICKUP;
1089 continue;
1090 }
1091
1092 if (op->contr->mode & PU_CLOAK)
1093 if (tmp->type == CLOAK)
1094 {
1095 CHK_PICK_PICKUP;
1096 continue;
1097 }
1098
1099 /* hoping to catch throwing daggers here */
1100 if (op->contr->mode & PU_MISSILEWEAPON)
1101 if (tmp->type == WEAPON && tmp->flag [FLAG_IS_THROWN])
1102 {
1103 CHK_PICK_PICKUP;
1104 continue;
1105 }
1106
1107 /* careful: chairs and tables are weapons! */
1108 if (op->contr->mode & PU_ALLWEAPON)
1109 {
1110 if (tmp->type == WEAPON)
1111 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1132 { 1112 {
1133 pick_up (op, tmp); 1113 CHK_PICK_PICKUP;
1134 continue; 1114 continue;
1135 } 1115 }
1116 }
1136 1117
1118 /* misc stuff that's useful */
1137 if (op->contr->mode & PU_DRINK) 1119 if (op->contr->mode & PU_KEY)
1138 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1120 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1139 { 1121 {
1140 pick_up (op, tmp); 1122 CHK_PICK_PICKUP;
1141 continue; 1123 continue;
1142 } 1124 }
1143 1125
1126 /* any of the last 4 bits set means we use the ratio for value
1127 * pickups */
1144 if (op->contr->mode & PU_POTION) 1128 if (op->contr->mode & PU_RATIO)
1145 if (tmp->type == POTION) 1129 {
1130 /* use value density to decide what else to grab */
1131 /* >=7 was >= op->contr->mode */
1132 /* >=7 is the old standard setting. Now we take the last 4 bits
1146 { 1133 */
1147 pick_up (op, tmp);
1148 continue;
1149 }
1150
1151 /* spellbooks, skillscrolls and normal books/scrolls */
1152 if (op->contr->mode & PU_SPELLBOOK)
1153 if (tmp->type == SPELLBOOK)
1154 {
1155 pick_up (op, tmp);
1156 continue;
1157 }
1158
1159 if (op->contr->mode & PU_SKILLSCROLL)
1160 if (tmp->type == SKILLSCROLL)
1161 {
1162 pick_up (op, tmp);
1163 continue;
1164 }
1165
1166 if (op->contr->mode & PU_READABLES)
1167 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
1168 {
1169 pick_up (op, tmp);
1170 continue;
1171 }
1172
1173 /* wands/staves/rods/horns */
1174 if (op->contr->mode & PU_MAGIC_DEVICE)
1175 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1176 {
1177 pick_up (op, tmp);
1178 continue;
1179 }
1180
1181 /* pick up all magical items */
1182 if (op->contr->mode & PU_MAGICAL) 1134 wvratio = op->contr->mode & PU_RATIO;
1183 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1135 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1184 {
1185 pick_up (op, tmp);
1186 continue;
1187 }
1188
1189 if (op->contr->mode & PU_VALUABLES)
1190 { 1136 {
1191 if (tmp->type == MONEY || tmp->type == GEM) 1137#if 0
1138 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1139 if (tmp->name != NULL)
1192 { 1140 {
1193 pick_up (op, tmp); 1141 fprintf (stderr, "%s", tmp->name);
1194 continue;
1195 } 1142 }
1196 }
1197
1198 /* rings & amulets - talismans seems to be typed AMULET */
1199 if (op->contr->mode & PU_JEWELS)
1200 if (tmp->type == RING || tmp->type == AMULET)
1201 {
1202 pick_up (op, tmp);
1203 continue;
1204 }
1205
1206 /* we don't forget dragon food */
1207 if (op->contr->mode & PU_FLESH)
1208 if (tmp->type == FLESH)
1209 {
1210 pick_up (op, tmp);
1211 continue;
1212 }
1213
1214 /* bows and arrows. Bows are good for selling! */
1215 if (op->contr->mode & PU_BOW)
1216 if (tmp->type == BOW)
1217 {
1218 pick_up (op, tmp);
1219 continue;
1220 }
1221
1222 if (op->contr->mode & PU_ARROW)
1223 if (tmp->type == ARROW)
1224 {
1225 pick_up (op, tmp);
1226 continue;
1227 }
1228
1229 /* all kinds of armor etc. */
1230 if (op->contr->mode & PU_ARMOUR)
1231 if (tmp->type == ARMOUR)
1232 {
1233 pick_up (op, tmp);
1234 continue;
1235 }
1236
1237 if (op->contr->mode & PU_HELMET)
1238 if (tmp->type == HELMET)
1239 {
1240 pick_up (op, tmp);
1241 continue;
1242 }
1243
1244 if (op->contr->mode & PU_SHIELD)
1245 if (tmp->type == SHIELD)
1246 {
1247 pick_up (op, tmp);
1248 continue;
1249 }
1250
1251 if (op->contr->mode & PU_BOOTS)
1252 if (tmp->type == BOOTS)
1253 {
1254 pick_up (op, tmp);
1255 continue;
1256 }
1257
1258 if (op->contr->mode & PU_GLOVES)
1259 if (tmp->type == GLOVES)
1260 {
1261 pick_up (op, tmp);
1262 continue;
1263 }
1264
1265 if (op->contr->mode & PU_CLOAK)
1266 if (tmp->type == CLOAK)
1267 {
1268 pick_up (op, tmp);
1269 continue;
1270 }
1271
1272 /* hoping to catch throwing daggers here */
1273 if (op->contr->mode & PU_MISSILEWEAPON)
1274 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1275 {
1276 pick_up (op, tmp);
1277 continue;
1278 }
1279
1280 /* careful: chairs and tables are weapons! */
1281 if (op->contr->mode & PU_ALLWEAPON)
1282 {
1283 if (tmp->type == WEAPON && tmp->name != NULL)
1284 {
1285 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->archname, "table") == NULL &&
1286 strstr (tmp->name, "chair") && strstr (tmp->arch->archname, "chair") == NULL)
1287 {
1288 pick_up (op, tmp);
1289 continue;
1290 }
1291 }
1292
1293 if (tmp->type == WEAPON && tmp->name == NULL)
1294 {
1295 if (strstr (tmp->arch->archname, "table") == NULL && strstr (tmp->arch->archname, "chair") == NULL)
1296 {
1297 pick_up (op, tmp);
1298 continue;
1299 }
1300 }
1301 }
1302
1303 /* misc stuff that's useful */
1304 if (op->contr->mode & PU_KEY)
1305 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1306 {
1307 pick_up (op, tmp);
1308 continue;
1309 }
1310
1311 /* any of the last 4 bits set means we use the ratio for value
1312 * pickups */
1313 if (op->contr->mode & PU_RATIO)
1314 {
1315 /* use value density to decide what else to grab */
1316 /* >=7 was >= op->contr->mode */
1317 /* >=7 is the old standard setting. Now we take the last 4 bits
1318 * and multiply them by 5, giving 0..15*5== 5..75 */
1319 wvratio = (op->contr->mode & PU_RATIO) * 5;
1320 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio)
1321 {
1322 pick_up (op, tmp);
1323#if 0
1324 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1325 if (tmp->name != NULL)
1326 {
1327 fprintf (stderr, "%s", tmp->name);
1328 }
1329 else 1143 else
1330 fprintf (stderr, "%s", tmp->arch->archname); 1144 fprintf (stderr, "%s", tmp->arch->archname);
1331 fprintf (stderr, ",%d] = ", tmp->type); 1145 fprintf (stderr, ",%d] = ", tmp->type);
1332 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1146 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
1333#endif 1147#endif
1148 CHK_PICK_PICKUP;
1334 continue; 1149 continue;
1335 }
1336 } 1150 }
1337 } /* the new pickup model */ 1151 } /* the new pickup model */
1338 } 1152 }
1339 1153
1340 return !stop; 1154 return !stop;
1341} 1155}
1342 1156
1157/* routine for both players and monsters. We call this when
1158 * there is a possibility for our action distrubing our hiding
1159 * place or invisiblity spell. Artefact invisiblity causes
1160 * "noise" instead. If we arent invisible to begin with, we
1161 * return 0.
1162 */
1163static int
1164action_makes_visible (object *op)
1165{
1166 if (op->invisible && op->flag [FLAG_ALIVE])
1167 {
1168 if (op->flag [FLAG_MAKE_INVIS])
1169 {
1170 // artefact invisibility is permanent, but we still make noise
1171 // this is important for game-balance.
1172 if (op->contr)
1173 op->make_noise ();
1174
1175 return 0;
1176 }
1177
1178 if (op->contr && op->contr->tmp_invis == 0)
1179 return 0;
1180
1181 /* If monsters, they should become visible */
1182 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
1183 {
1184 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
1185 return 1;
1186 }
1187 }
1188
1189 return 0;
1190}
1191
1343/* 1192/*
1344 * Find an arrow in the inventory and after that 1193 * Find an arrow in the inventory and after that
1345 * in the right type container (quiver). Pointer to the 1194 * in the right type container (quiver). Pointer to the
1346 * found object is returned. 1195 * found object is returned.
1347 */ 1196 */
1348object * 1197static object *
1349find_arrow (object *op, const char *type) 1198find_arrow (object *op, const char *type)
1350{ 1199{
1351 object *tmp = 0;
1352
1353 for (op = op->inv; op; op = op->below) 1200 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1354 if (!tmp && op->type == CONTAINER && op->race == type && QUERY_FLAG (op, FLAG_APPLIED))
1355 tmp = find_arrow (splay (op), type);
1356 else if (op->type == ARROW && op->race == type) 1201 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1357 return splay (op); 1202 return splay (tmp);
1358 1203
1204 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1205 if (tmp->type == CONTAINER && tmp->flag [FLAG_APPLIED] && !strcmp (&tmp->race, type))
1206 if (object *arrow = find_arrow (tmp, type))
1207 {
1208 splay (tmp);
1209 return arrow;
1210 }
1211
1359 return tmp; 1212 return 0;
1360} 1213}
1361 1214
1362/* 1215/*
1363 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1216 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1364 * against the target. A full test is not performed, simply a basic test 1217 * against the target. A full test is not performed, simply a basic test
1365 * of resistances. The archer is making a quick guess at what he sees down 1218 * of resistances. The archer is making a quick guess at what he sees down
1366 * the hall. Failing that it does it's best to pick the highest plus arrow. 1219 * the hall. Failing that it does it's best to pick the highest plus arrow.
1367 */ 1220 */
1368object * 1221static object *
1369find_better_arrow (object *op, object *target, const char *type, int *better) 1222find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1370{ 1223{
1371 object *tmp = NULL, *arrow, *ntmp; 1224 object *tmp = NULL, *arrow, *ntmp;
1372 int attacknum, attacktype, betterby = 0, i; 1225 int attacknum, attacktype, betterby = 0, i;
1373 1226
1374 if (!type) 1227 if (!type)
1375 return NULL; 1228 return NULL;
1376 1229
1377 for (arrow = op->inv; arrow; arrow = arrow->below) 1230 for (arrow = op->inv; arrow; arrow = arrow->below)
1378 { 1231 {
1379 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1232 if (arrow->type == CONTAINER && arrow->race == type && arrow->flag [FLAG_APPLIED])
1380 { 1233 {
1381 i = 0; 1234 i = 0;
1382 ntmp = find_better_arrow (arrow, target, type, &i); 1235 ntmp = find_better_arrow (arrow, target, type, &i);
1236
1383 if (i > betterby) 1237 if (i > betterby)
1384 { 1238 {
1385 tmp = ntmp; 1239 tmp = ntmp;
1386 betterby = i; 1240 betterby = i;
1387 } 1241 }
1388 } 1242 }
1389 else if (arrow->type == ARROW && arrow->race == type) 1243 else if (arrow->type == ARROW && arrow->race == type)
1390 { 1244 {
1391 /* allways prefer assasination/slaying */ 1245 /* allways prefer assasination/slaying */
1392 if (target->race != NULL && arrow->slaying != NULL && strstr (arrow->slaying, target->race)) 1246 if (target->race && arrow->slaying.contains (target->race))
1393 { 1247 {
1394 if (arrow->attacktype & AT_DEATH) 1248 if (arrow->attacktype & AT_DEATH)
1395 { 1249 {
1396 *better = 100; 1250 *better = 100;
1397 return arrow; 1251 return arrow;
1412 { 1266 {
1413 tmp = arrow; 1267 tmp = arrow;
1414 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100; 1268 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1415 } 1269 }
1416 } 1270 }
1271
1417 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1272 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1418 { 1273 {
1419 tmp = arrow; 1274 tmp = arrow;
1420 betterby = 2 + arrow->magic + arrow->stats.dam; 1275 betterby = 2 + arrow->magic + arrow->stats.dam;
1421 } 1276 }
1277
1422 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1278 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1423 { 1279 {
1424 tmp = arrow; 1280 tmp = arrow;
1425 betterby = 1 + arrow->magic + arrow->stats.dam; 1281 betterby = 1 + arrow->magic + arrow->stats.dam;
1426 } 1282 }
1427 } 1283 }
1428 } 1284 }
1429 } 1285 }
1286
1430 if (tmp == NULL && arrow == NULL) 1287 if (tmp == NULL && arrow == NULL)
1431 return find_arrow (op, type); 1288 return find_arrow (op, type);
1432 1289
1433 *better = betterby; 1290 *better = betterby;
1434 return tmp; 1291 return tmp;
1438 * find_better_arrow to find a decent arrow to use. 1295 * find_better_arrow to find a decent arrow to use.
1439 * op = the shooter 1296 * op = the shooter
1440 * type = bow->race 1297 * type = bow->race
1441 * dir = fire direction 1298 * dir = fire direction
1442 */ 1299 */
1443object * 1300static object *
1444pick_arrow_target (object *op, const char *type, int dir) 1301pick_arrow_target (object *op, shstr_cmp type, int dir)
1445{ 1302{
1446 object *tmp = NULL; 1303 object *tmp = NULL;
1447 maptile *m; 1304 maptile *m;
1448 int i, mflags, found, number; 1305 int i, mflags, found, number;
1449 sint16 x, y; 1306 sint16 x, y;
1461 y = op->y; 1318 y = op->y;
1462 1319
1463 /* find the first target */ 1320 /* find the first target */
1464 for (i = 0, found = 0; i < 20; i++) 1321 for (i = 0, found = 0; i < 20; i++)
1465 { 1322 {
1466 x += freearr_x[dir]; 1323 x += DIRX (dir);
1467 y += freearr_y[dir]; 1324 y += DIRY (dir);
1468 mflags = get_map_flags (m, &m, x, y, &x, &y); 1325 mflags = get_map_flags (m, &m, x, y, &x, &y);
1326
1469 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1327 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1470 { 1328 {
1471 tmp = NULL; 1329 tmp = 0;
1472 break; 1330 break;
1473 } 1331 }
1474 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1332 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1475 { 1333 {
1476 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1334 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1477 * perhaps a bad assumption. 1335 * perhaps a bad assumption.
1478 */ 1336 */
1479 tmp = NULL; 1337 tmp = 0;
1480 break; 1338 break;
1481 } 1339 }
1340
1482 if (mflags & P_IS_ALIVE) 1341 if (mflags & P_IS_ALIVE)
1483 {
1484 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1342 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1485 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1343 if (tmp->flag [FLAG_ALIVE])
1486 {
1487 found++;
1488 break;
1489 }
1490 if (found)
1491 break; 1344 break;
1492 }
1493 } 1345 }
1494 if (tmp == NULL) 1346
1347 if (!tmp)
1495 return find_arrow (op, type); 1348 return find_arrow (op, type);
1496 1349
1497 if (tmp->head) 1350 if (tmp->head)
1498 tmp = tmp->head; 1351 tmp = tmp->head;
1499 1352
1500 return find_better_arrow (op, tmp, type, &i); 1353 return find_better_arrow (op, tmp, type, &i);
1501} 1354}
1502 1355
1503/* 1356/*
1504 * Creature fires a bow - op can be monster or player. Returns 1357 * Creature fires a bow - op can be monster or player. Returns
1505 * 1 if bow was actually fired, 0 otherwise. 1358 * 1 if bow was actually fired, 0 otherwise.
1506 * op is the object firing the bow. 1359 * op is the object firing the bow.
1507 * part is for multipart creatures - the part firing the bow. 1360 * part is for multipart creatures - the part firing the bow.
1508 * dir is the direction of fire. 1361 * dir is the direction of fire.
1509 * wc_mod is any special modifier to give (used in special player fire modes) 1362 * wc_mod is any special modifier to give (used in special player fire modes)
1539 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1392 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1540 return 0; 1393 return 0;
1541 } 1394 }
1542 1395
1543 // optimisation: move object to top so we will find it quickly again 1396 // optimisation: move object to top so we will find it quickly again
1544 if (bow->below) 1397 splay (bow);
1545 {
1546 bow->remove ();
1547 op->insert (bow);
1548 }
1549
1550 } 1398 }
1551 1399
1552 if (!bow->race || !bow->skill) 1400 if (!bow->race || !bow->skill)
1553 { 1401 {
1554 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1402 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1561 { 1409 {
1562 if (op->type == PLAYER) 1410 if (op->type == PLAYER)
1563 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1411 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1564 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1412 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1565 else 1413 else
1566 CLEAR_FLAG (op, FLAG_READY_BOW); 1414 op->clr_flag (FLAG_READY_BOW);
1567 1415
1568 return 0; 1416 return 0;
1569 } 1417 }
1570 } 1418 }
1571 1419
1580 } 1428 }
1581 1429
1582 /* this should not happen, but sometimes does */ 1430 /* this should not happen, but sometimes does */
1583 if (arrow->nrof == 0) 1431 if (arrow->nrof == 0)
1584 { 1432 {
1433 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1585 arrow->destroy (); 1434 arrow->destroy ();
1586 return 0; 1435 return 0;
1587 } 1436 }
1588 1437
1589 left = arrow; /* these are arrows left to the player */ 1438 left = arrow; /* these are arrows left to the player */
1590 arrow = get_split_ob (arrow, 1); 1439 arrow = arrow->split ();
1591 if (!arrow) 1440 if (!arrow)
1592 { 1441 {
1593 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1442 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1594 return 0; 1443 return 0;
1595 } 1444 }
1599 arrow->direction = dir; 1448 arrow->direction = dir;
1600 1449
1601 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */ 1450 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1602 arrow->stats.hp = arrow->stats.dam; 1451 arrow->stats.hp = arrow->stats.dam;
1603 arrow->stats.grace = arrow->attacktype; 1452 arrow->stats.grace = arrow->attacktype;
1604 1453 arrow->custom_name = arrow->slaying;
1605 if (arrow->slaying)
1606 arrow->spellarg = strdup (arrow->slaying);
1607 1454
1608#if 0 1455#if 0
1609 if (player *pl = op->contr) 1456 if (player *pl = op->contr)
1610 { 1457 {
1611 float speed = pl->weapon_sp; 1458 float speed = pl->weapon_sp;
1621#endif 1468#endif
1622 1469
1623 SET_ANIMATION (arrow, arrow->direction); 1470 SET_ANIMATION (arrow, arrow->direction);
1624 1471
1625 /* update the speed */ 1472 /* update the speed */
1626 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1627 + bow->stats.dam / 7.f;
1628 1473
1629 arrow->set_speed (max (arrow->speed, 2.f));
1630 arrow->speed_left = 0; 1474 arrow->speed_left = 0;
1475 arrow->set_speed (max (2.f,
1476 ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1477 + bow->stats.dam / 7.f
1478 ));
1631 1479
1632 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc; 1480 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1633 1481
1634 if (op->type == PLAYER) 1482 if (op->type == PLAYER)
1635 { 1483 {
1656 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM); 1504 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1657 1505
1658 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC); 1506 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1659 arrow->move_type = MOVE_FLY_LOW; 1507 arrow->move_type = MOVE_FLY_LOW;
1660 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1508 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1509 arrow->set_flag (FLAG_NO_PICK);
1661 1510
1662 op->play_sound (sound_find ("fire_arrow")); 1511 op->play_sound (sound_find ("fire_arrow"));
1663 m->insert (arrow, sx, sy, op); 1512 m->insert (arrow, sx, sy, op);
1664 1513
1665 if (!arrow->destroyed ()) 1514 if (!arrow->destroyed ())
1666 move_arrow (arrow); 1515 move_arrow (arrow);
1667
1668 if (op->type == PLAYER)
1669 {
1670 if (left->destroyed ())
1671 esrv_del_item (op->contr, left->count);
1672 else
1673 esrv_send_item (op, left);
1674 }
1675 1516
1676 return 1; 1517 return 1;
1677} 1518}
1678 1519
1679/* Special fire code for players - this takes into 1520/* Special fire code for players - this takes into
1681 * but monsters can't. Putting that code here 1522 * but monsters can't. Putting that code here
1682 * makes the fire_bow code much cleaner. 1523 * makes the fire_bow code much cleaner.
1683 * this function should only be called if 'op' is a player, 1524 * this function should only be called if 'op' is a player,
1684 * hence the function name. 1525 * hence the function name.
1685 */ 1526 */
1686int 1527static int
1687player_fire_bow (object *op, int dir) 1528player_fire_bow (object *op, int dir)
1688{ 1529{
1689 int ret = 0, wcmod = 0; 1530 int ret;
1690 1531
1691 if (op->contr->bowtype == bow_bestarrow) 1532 if (op->contr->bowtype == bow_bestarrow)
1692 { 1533 {
1693 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y); 1534 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1694 } 1535 }
1695 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1536 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1696 { 1537 {
1697 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1538 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1698 wcmod = -1;
1699
1700 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1539 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1701 } 1540 }
1702 else if (op->contr->bowtype == bow_threewide) 1541 else if (op->contr->bowtype == bow_threewide)
1703 { 1542 {
1704 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1543 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1705 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1544 ret |= fire_bow (op, op, NULL, dir, -5, op->x + DIRX (absdir (dir + 2)), op->y + DIRY (absdir (dir + 2)));
1706 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1545 ret |= fire_bow (op, op, NULL, dir, -5, op->x + DIRX (absdir (dir - 2)), op->y + DIRY (absdir (dir - 2)));
1707 } 1546 }
1708 else if (op->contr->bowtype == bow_spreadshot) 1547 else if (op->contr->bowtype == bow_spreadshot)
1709 { 1548 {
1710 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1549 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1711 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1550 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1712 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1551 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1713 } 1552 }
1714 else 1553 else
1715 { 1554 {
1721} 1560}
1722 1561
1723/* Fires a misc (wand/rod/horn) object in 'dir'. 1562/* Fires a misc (wand/rod/horn) object in 'dir'.
1724 * Broken apart from 'fire' to keep it more readable. 1563 * Broken apart from 'fire' to keep it more readable.
1725 */ 1564 */
1726void 1565static void
1727fire_misc_object (object *op, int dir) 1566fire_misc_object (object *op, int dir)
1728{ 1567{
1729 object *item = op->contr->ranged_ob; 1568 object *item = op->contr->ranged_ob;
1730 1569
1731 if (!item) 1570 if (!item)
1738 { 1577 {
1739 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1578 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1740 return; 1579 return;
1741 } 1580 }
1742 1581
1743 if (!op->change_weapon (item)) 1582 if (!op->apply (item))
1744 return; 1583 return;
1745 1584
1746 if (item->type == WAND) 1585 if (item->type == WAND)
1747 { 1586 {
1748 if (item->stats.food <= 0) 1587 if (item->stats.food <= 0)
1753 return; 1592 return;
1754 } 1593 }
1755 } 1594 }
1756 else if (item->type == ROD || item->type == HORN) 1595 else if (item->type == ROD || item->type == HORN)
1757 { 1596 {
1758 if (item->stats.hp < MAX (item->inv->stats.sp, item->inv->stats.grace)) 1597 sint16 spell_sp = max (item->inv->stats.sp, item->inv->stats.grace);
1598
1599 // using the maximum of the rods charge allows at least one spell cast
1600 // for a rod or horn, this fixes some broken rods.
1601 if (item->stats.hp < min (spell_sp, item->stats.maxhp))
1759 { 1602 {
1760 op->contr->play_sound (sound_find ("wand_poof")); 1603 op->contr->play_sound (sound_find ("wand_poof"));
1761 1604
1762 if (item->type == ROD) 1605 if (item->type == ROD)
1763 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1606 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1768 } 1611 }
1769 } 1612 }
1770 1613
1771 if (cast_spell (op, item, dir, item->inv, NULL)) 1614 if (cast_spell (op, item, dir, item->inv, NULL))
1772 { 1615 {
1773 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1616 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1617
1774 if (item->type == WAND) 1618 if (item->type == WAND)
1775 { 1619 {
1776 if (!(--item->stats.food)) 1620 if (!(--item->stats.food))
1777 { 1621 {
1778 object *tmp;
1779
1780 if (item->arch) 1622 if (item->arch)
1781 { 1623 {
1782 CLEAR_FLAG (item, FLAG_ANIMATE); 1624 item->clr_flag (FLAG_ANIMATE);
1783 item->face = item->arch->face; 1625 item->face = item->arch->face;
1784 item->set_speed (0); 1626 item->set_speed (0);
1785 } 1627 }
1786 1628
1787 if ((tmp = item->in_player ())) 1629 if (object *pl = item->visible_to ())
1788 esrv_update_item (UPD_ANIM, tmp, item); 1630 esrv_update_item (UPD_ANIM, pl, item);
1789 } 1631 }
1790 } 1632 }
1791 else if (item->type == ROD || item->type == HORN) 1633 else if (item->type == ROD || item->type == HORN)
1792 drain_rod_charge (item); 1634 drain_rod_charge (item);
1793 } 1635 }
1794} 1636}
1795 1637
1796/* Received a fire command for the player - go and do it. 1638/* Received a fire command for the player - go and do it.
1797 */ 1639 */
1798bool 1640bool
1799fire (object *op, int dir) 1641fire (object *who, int dir)
1800{ 1642{
1801 int spellcost = 0; 1643 int spellcost = 0;
1802 1644
1803 /* check for loss of invisiblity/hide */
1804 if (action_makes_visible (op))
1805 make_visible (op);
1806
1807 player *pl = op->contr; 1645 player *pl = who->contr;
1808 1646
1809 if (pl->golem) 1647 if (pl->golem)
1810 { 1648 {
1811 control_golem (op->contr->golem, dir); 1649 control_golem (who->contr->golem, dir);
1812 return false; 1650 return false;
1813 } 1651 }
1814 1652
1815 object *ob = pl->ranged_ob; 1653 object *ob = pl->ranged_ob;
1816 1654
1817 if (!ob) 1655 if (!ob)
1818 return false; 1656 return false;
1819 1657
1820 if (!op->change_weapon (ob))
1821 return false;
1822
1823 if (op->speed_left > 0.f) 1658 if (who->speed_left > 0.f)
1824 --op->speed_left; 1659 --who->speed_left;
1825 else 1660 else
1826 return false; 1661 return false;
1827 1662
1663 if (!who->apply (ob))
1664 return false;
1665
1666 /* check for loss of invisiblity/hide */
1667 if (action_makes_visible (who))
1668 make_visible (who);
1669
1828 switch (ob->type) 1670 switch (ob->type)
1829 { 1671 {
1830 case BOW: 1672 case BOW:
1831 player_fire_bow (op, dir); 1673 player_fire_bow (who, dir);
1832 break; 1674 break;
1833 1675
1834 case SPELL: 1676 case SPELL:
1835 spellcost = cast_spell (op, op, dir, ob, pl->spellparam[0] ? pl->spellparam : 0); 1677 spellcost = cast_spell (who, who, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1836 break; 1678 break;
1837 1679
1838 case BUILDER: 1680 case BUILDER:
1839 apply_map_builder (op, dir); 1681 apply_map_builder (who, dir);
1840 break; 1682 break;
1841 1683
1842 case SKILL: 1684 case SKILL:
1843 do_skill (op, op, ob, dir, 0); 1685 do_skill (who, who, ob, dir, 0);
1844 break; 1686 break;
1845 1687
1688 case RANGED:
1689 do_skill (who, ob, who->chosen_skill, dir, 0);
1690 break;
1691
1846 default: 1692 default:
1847 fire_misc_object (op, dir); 1693 fire_misc_object (who, dir);
1848 break; 1694 break;
1849 } 1695 }
1850 1696
1851 return true; 1697 return true;
1852} 1698}
1853 1699
1854/* find_key 1700static object *
1855 * We try to find a key for the door as passed. If we find a key
1856 * and successfully use it, we return the key, otherwise NULL
1857 * This function merges both normal and locked door, since the logic
1858 * for both is the same - just the specific key is different.
1859 * pl is the player,
1860 * inv is the objects inventory to searched
1861 * door is the door we are trying to match against.
1862 * This function can be called recursively to search containers.
1863 */
1864object *
1865find_key (object *pl, object *container, object *door) 1701find_key_ (object *pl, object *container, object *door)
1866{ 1702{
1867 object *tmp, *key; 1703 object *tmp, *key;
1868 1704
1869 /* Should not happen, but sanity checking is never bad */ 1705 /* Should not happen, but sanity checking is never bad */
1870 if (!container->inv) 1706 if (!container->inv)
1873 /* First, lets try to find a key in the top level inventory */ 1709 /* First, lets try to find a key in the top level inventory */
1874 for (tmp = container->inv; tmp; tmp = tmp->below) 1710 for (tmp = container->inv; tmp; tmp = tmp->below)
1875 { 1711 {
1876 if (door->type == DOOR && tmp->type == KEY) 1712 if (door->type == DOOR && tmp->type == KEY)
1877 break; 1713 break;
1714
1878 /* For sanity, we should really check door type, but other stuff 1715 /* For sanity, we should really check door type, but other stuff
1879 * (like containers) can be locked with special keys 1716 * (like containers) can be locked with special keys
1880 */ 1717 */
1881 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1718 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1882 break; 1719 break;
1883 } 1720 }
1888 * a key, return 1725 * a key, return
1889 */ 1726 */
1890 if (!tmp) 1727 if (!tmp)
1891 { 1728 {
1892 for (tmp = container->inv; tmp; tmp = tmp->below) 1729 for (tmp = container->inv; tmp; tmp = tmp->below)
1893 {
1894 /* No reason to search empty containers */ 1730 /* No reason to search empty containers */
1895 if (tmp->type == CONTAINER && tmp->inv) 1731 if (tmp->type == CONTAINER && tmp->inv)
1896 {
1897 if ((key = find_key (pl, tmp, door))) 1732 if ((key = find_key_ (pl, tmp, door)))
1898 return key; 1733 return key;
1899 }
1900 }
1901 1734
1902 if (!tmp) 1735 if (!tmp)
1903 return NULL; 1736 return 0;
1904 } 1737 }
1905 1738
1906 /* We get down here if we have found a key. Now if its in a container, 1739 /* We get down here if we have found a key. Now if its in a container,
1907 * see if we actually want to use it 1740 * see if we actually want to use it
1908 */ 1741 */
1909 if (pl != container) 1742 if (pl != container)
1910 { 1743 {
1911 /* Only let players use keys in containers */ 1744 /* Only let players use keys in containers */
1912 if (!pl->contr) 1745 if (!pl->contr)
1913 return NULL; 1746 return 0;
1747
1914 /* cases where this fails: 1748 /* cases where this fails:
1915 * If we only search the player inventory, return now since we 1749 * If we only search the player inventory, return now since we
1916 * are not in the players inventory. 1750 * are not in the players inventory.
1917 * If the container is not active, return now since only active 1751 * If the container is not active, return now since only active
1918 * containers can be used. 1752 * containers can be used.
1922 * inv must have been an container and must have been active. 1756 * inv must have been an container and must have been active.
1923 * 1757 *
1924 * Change the color so that the message doesn't disappear with 1758 * Change the color so that the message doesn't disappear with
1925 * all the others. 1759 * all the others.
1926 */ 1760 */
1927 if (pl->contr->usekeys == key_inventory || 1761 if (pl->contr->usekeys == key_inventory
1928 !QUERY_FLAG (container, FLAG_APPLIED) || 1762 || !container->flag [FLAG_APPLIED]
1929 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1763 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
1930 { 1764 {
1931 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1765 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1932 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1766 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1933 return NULL; 1767 return NULL;
1934 } 1768 }
1935 } 1769 }
1936 1770
1937 return tmp; 1771 return tmp;
1772}
1773
1774/* find_key
1775 * We try to find a key for the door as passed. If we find a key
1776 * and successfully use it, we return the key, otherwise NULL
1777 * This function merges both normal and locked door, since the logic
1778 * for both is the same - just the specific key is different.
1779 * pl is the player,
1780 * inv is the objects inventory to searched
1781 * door is the door we are trying to match against.
1782 * This function can be called recursively to search containers.
1783 */
1784object *
1785find_key (object *pl, object *container, object *door)
1786{
1787 if (door->slaying && is_match_expr (door->slaying))
1788 {
1789 // for match expressions, we try to find the key by applying the match
1790 // to the op itself, which is supposed to find the "key", instead
1791 // of searching through containers ourselves.
1792
1793 return match_one (door->slaying, container, door, pl, pl);
1794 }
1795 else
1796 return find_key_ (pl, container, door);
1938} 1797}
1939 1798
1940/* moved door processing out of move_player_attack. 1799/* moved door processing out of move_player_attack.
1941 * returns 1 if player has opened the door with a key 1800 * returns 1 if player has opened the door with a key
1942 * such that the caller should not do anything more, 1801 * such that the caller should not do anything more,
1969 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN); 1828 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN);
1970 remove_door2 (door); /* remove door without violence ;-) */ 1829 remove_door2 (door); /* remove door without violence ;-) */
1971 } 1830 }
1972 1831
1973 /* Do this after we print the message */ 1832 /* Do this after we print the message */
1974 decrease_ob (key); /* Use up one of the keys */ 1833 key->decrease (); /* Use up one of the keys */
1975 /* Need to update the weight the container the key was in */
1976 if (container != op)
1977 esrv_update_item (UPD_WEIGHT, op, container);
1978 1834
1979 return 1; /* Nothing more to do below */ 1835 return 1; /* Nothing more to do below */
1980 } 1836 }
1981 else if (door->type == LOCKED_DOOR) 1837 else if (door->type == LOCKED_DOOR)
1982 { 1838 {
1995 * going to try and move (not fire weapons). 1851 * going to try and move (not fire weapons).
1996 */ 1852 */
1997bool 1853bool
1998move_player_attack (object *op, int dir) 1854move_player_attack (object *op, int dir)
1999{ 1855{
2000 int on_battleground; 1856 if (!op->contr->braced && op->speed_left > 0.f && op->move (dir))
1857 {
1858 --op->speed_left;
1859 return true;
1860 }
2001 1861
2002 sint16 nx = freearr_x[dir] + op->x; 1862 sint16 nx = DIRX (dir) + op->x;
2003 sint16 ny = freearr_y[dir] + op->y; 1863 sint16 ny = DIRY (dir) + op->y;
2004
2005 on_battleground = op_on_battleground (op, 0, 0);
2006 1864
2007 if (out_of_map (op->map, nx, ny)) 1865 if (out_of_map (op->map, nx, ny))
2008 return false; 1866 return false;
2009
2010 if (!op->contr->braced && op->speed_left > 0.f && move_ob (op, dir, op))
2011 {
2012 --op->speed_left;
2013 return true;
2014 }
2015 1867
2016 /* If braced, or can't move to the square, and it is not out of the 1868 /* If braced, or can't move to the square, and it is not out of the
2017 * map, attack it. Note order of if statement is important - don't 1869 * map, attack it. Note order of if statement is important - don't
2018 * want to be calling move_ob if braced, because move_ob will move the 1870 * want to be calling move_ob if braced, because move_ob will move the
2019 * player. This is a pretty nasty hack, because if we could 1871 * player. This is a pretty nasty hack, because if we could
2037 || mon->flag [FLAG_CAN_ROLL]) 1889 || mon->flag [FLAG_CAN_ROLL])
2038 && mon != op) 1890 && mon != op)
2039 break; 1891 break;
2040 } 1892 }
2041 1893
2042 if (!mon) /* This happens anytime the player tries to move */ 1894 /* no monster == player tries to move into a wall or so */
2043 return false; /* into a wall */ 1895 if (!mon)
1896 {
1897 for (object *ob = m->at (nx, ny).top; ob; ob = ob->below)
1898 if (op->move_type & ob->move_block)
1899 {
1900 if (ob->move_block == MOVE_ALL)
1901 move_into_wall (op, ob);
1902 else
1903 {
1904 if (op->contr->ns->bumpmsg)
1905 {
1906 op->play_sound (sound_find ("blocked_move"));
1907
1908 op->statusmsg (ob->invisible
1909 ? "Something blocks you."
1910 : format ("Something blocks you from entering the %s.", query_name (ob))
1911 );
1912 }
1913 }
1914
1915 break;
1916 }
1917
1918 return false;
1919 }
2044 1920
2045 mon = mon->head_ (); 1921 mon = mon->head_ ();
2046 1922
2047 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR)) 1923 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2048 if (op->contr->weapon_sp_left > 0.f) 1924 if (op->contr->weapon_sp_left > 0.f)
2066 */ 1942 */
2067 if (op->type == PLAYER 1943 if (op->type == PLAYER
2068 && ((mon->owner && mon->owner->contr 1944 && ((mon->owner && mon->owner->contr
2069 && same_party (mon->owner->contr->party, op->contr->party)) 1945 && same_party (mon->owner->contr->party, op->contr->party))
2070 || mon->owner == op) 1946 || mon->owner == op)
2071 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))) 1947 && (mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY]))
2072 { 1948 {
2073 /* If we're braced, we don't want to switch places with it */ 1949 /* If we're braced, we don't want to switch places with it */
2074 if (op->contr->braced) 1950 if (op->contr->braced)
2075 return false; 1951 return false;
2076 1952
2079 --op->speed_left; 1955 --op->speed_left;
2080 1956
2081 op->play_sound (sound_find ("push_player")); 1957 op->play_sound (sound_find ("push_player"));
2082 push_ob (mon, dir, op); 1958 push_ob (mon, dir, op);
2083 1959
2084 if (op->contr->tmp_invis || op->hide) 1960 if (action_makes_visible (op))
2085 make_visible (op); 1961 make_visible (op);
2086 1962
2087 return true; 1963 return true;
2088 } 1964 }
2089 else 1965 else
2090 return false; 1966 return false;
2091 } 1967 }
1968
1969 bool on_battleground = op_on_battleground (op, 0, 0);
2092 1970
2093 /* in certain circumstances, you shouldn't attack friendly 1971 /* in certain circumstances, you shouldn't attack friendly
2094 * creatures. Note that if you are braced, you can't push 1972 * creatures. Note that if you are braced, you can't push
2095 * someone, but put it inside this loop so that you won't 1973 * someone, but put it inside this loop so that you won't
2096 * attack them either. 1974 * attack them either.
2097 */ 1975 */
2098 if ((mon->type == PLAYER || mon->enemy != op) 1976 if ((mon->type == PLAYER || mon->enemy != op)
2099 && (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) 1977 && (mon->type == PLAYER || mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY])
2100 && ((op->contr->peaceful 1978 && ((op->contr->peaceful
2101 || (mon->type == PLAYER && mon->contr->peaceful)) 1979 || (mon->type == PLAYER && mon->contr->peaceful))
2102 && !on_battleground)) 1980 && !on_battleground))
2103 { 1981 {
2104 if (op->speed_left > 0.f) 1982 if (op->speed_left > 0.f)
2111 push_ob (mon, dir, op); 1989 push_ob (mon, dir, op);
2112 } 1990 }
2113 else 1991 else
2114 op->statusmsg ("You withhold your attack"); 1992 op->statusmsg ("You withhold your attack");
2115 1993
2116 if (op->contr->tmp_invis || op->hide) 1994 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN])
2117 make_visible (op); 1995 make_visible (op);
2118 1996
2119 return true; 1997 return true;
2120 } 1998 }
2121 } 1999 }
2122 /* If the object is a boulder or other rollable object, then 2000 /* If the object is a boulder or other rollable object, then
2123 * roll it if not braced. You can't roll it if you are braced. 2001 * roll it if not braced. You can't roll it if you are braced.
2124 */ 2002 */
2125 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 2003 else if (mon->flag [FLAG_CAN_ROLL] && (!op->contr->braced))
2126 { 2004 {
2127 if (op->speed_left > 0.f) 2005 if (op->speed_left > 0.f)
2128 { 2006 {
2129 --op->speed_left; 2007 --op->speed_left;
2130 2008
2139 * Way it works is like this: First, it must have some hit points 2017 * Way it works is like this: First, it must have some hit points
2140 * and be living. Then, it must be one of the following: 2018 * and be living. Then, it must be one of the following:
2141 * 1) Not a player, 2) A player, but of a different party. Note 2019 * 1) Not a player, 2) A player, but of a different party. Note
2142 * that party_number -1 is no party, so attacks can still happen. 2020 * that party_number -1 is no party, so attacks can still happen.
2143 */ 2021 */
2144 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 2022 else if ((mon->stats.hp >= 0) && mon->flag [FLAG_ALIVE] &&
2145 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 2023 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2146 { 2024 {
2147 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS]) 2025 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2148 { 2026 {
2149 --op->contr->weapon_sp_left; 2027 --op->contr->weapon_sp_left;
2161} 2039}
2162 2040
2163bool 2041bool
2164move_player (object *op, int dir) 2042move_player (object *op, int dir)
2165{ 2043{
2166 int pick;
2167
2168 if (!op->map || op->map->in_memory != MAP_IN_MEMORY) 2044 if (!op->map || op->map->state != MAP_ACTIVE)
2169 return 0; 2045 return 0;
2170 2046
2171 /* Sanity check: make sure dir is valid */ 2047 /* Sanity check: make sure dir is valid */
2172 if ((dir < 0) || (dir >= 9)) 2048 if (dir < 0 || dir > 8)
2173 { 2049 {
2174 LOG (llevError, "move_player: invalid direction %d\n", dir); 2050 LOG (llevError, "move_player: invalid direction %d\n", dir);
2175 return 0; 2051 return 0;
2176 } 2052 }
2177 2053
2178 /* peterm: added following line */ 2054 /* peterm: added following line */
2179 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2055 if (op->flag [FLAG_CONFUSED] && dir)
2180 dir = absdir (dir + rndm (3) + rndm (3) - 2); 2056 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2181 2057
2182 op->facing = dir; 2058 op->facing = dir;
2183 2059
2184 if (op->hide) 2060 if (op->flag [FLAG_HIDDEN])
2185 do_hidden_move (op); 2061 do_hidden_move (op);
2186 2062
2187 bool retval; 2063 bool retval;
2064 int pick = 0;
2188 2065
2189 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2066 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2190 retval = RESULT_INT (0); 2067 retval = RESULT_INT (0);
2191 else if (op->contr->fire_on) 2068 else if (op->contr->fire_on)
2192 retval = fire (op, dir); 2069 retval = fire (op, dir);
2223 * players. 2100 * players.
2224 */ 2101 */
2225bool 2102bool
2226handle_newcs_player (object *op) 2103handle_newcs_player (object *op)
2227{ 2104{
2228 if (QUERY_FLAG (op, FLAG_SCARED)) 2105 if (op->flag [FLAG_SCARED])
2229 { 2106 {
2230 if (op->speed_left > 0.f) 2107 if (op->speed_left > 0.f)
2231 { 2108 {
2232 --op->speed_left; 2109 --op->speed_left;
2233 flee_player (op); 2110 flee_player (op);
2249 return move_player (op, op->direction); 2126 return move_player (op, op->direction);
2250 2127
2251 return false; 2128 return false;
2252} 2129}
2253 2130
2254int 2131static int
2255save_life (object *op) 2132save_life (object *op)
2256{ 2133{
2257 if (!QUERY_FLAG (op, FLAG_LIFESAVE)) 2134 if (!op->flag [FLAG_LIFESAVE])
2258 return 0; 2135 return 0;
2259 2136
2260 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2137 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2261 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2138 if (tmp->flag [FLAG_APPLIED] && tmp->flag [FLAG_LIFESAVE])
2262 { 2139 {
2263 op->play_sound (sound_find ("ob_evaporate")); 2140 op->play_sound (sound_find ("ob_evaporate"));
2264 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2141 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2265 2142
2266 if (op->contr)
2267 esrv_del_item (op->contr, tmp->count);
2268
2269 tmp->destroy (); 2143 tmp->destroy ();
2270 CLEAR_FLAG (op, FLAG_LIFESAVE); 2144 op->clr_flag (FLAG_LIFESAVE);
2271 2145
2272 if (op->stats.hp < 0) 2146 if (op->stats.hp < 0)
2273 op->stats.hp = op->stats.maxhp; 2147 op->stats.hp = op->stats.maxhp;
2274 2148
2275 if (op->stats.food < 0) 2149 if (op->stats.food < 0)
2276 op->stats.food = 999; 2150 op->stats.food = MAX_FOOD;
2277 2151
2278 op->update_stats (); 2152 op->update_stats ();
2279 return 1; 2153 return 1;
2280 } 2154 }
2281 2155
2282 LOG (llevError, "Error: LIFESAVE set without applied object.\n"); 2156 LOG (llevError, "Error: LIFESAVE set without applied object.\n");
2283 CLEAR_FLAG (op, FLAG_LIFESAVE); 2157 op->clr_flag (FLAG_LIFESAVE);
2284 enter_player_savebed (op); /* bring him home. */ 2158 enter_player_savebed (op); /* bring him home. */
2285 return 0; 2159 return 0;
2286} 2160}
2287 2161
2288/* This goes throws the inventory and removes unpaid objects, and puts them 2162/* This goes throws the inventory and removes unpaid objects, and puts them
2289 * back in the map (location and map determined by values of env). This 2163 * back in the map (location and map determined by values of env). This
2290 * function will descend into containers. op is the object to start the search 2164 * function will descend into containers. op is the object to start the search
2291 * from. 2165 * from.
2292 */ 2166 */
2293static void 2167static void
2294drop_unpaid_items (object *op, object *env) 2168drop_unpaid_items (object *op, object *env)
2295{ 2169{
2296 while (op) 2170 while (op)
2297 { 2171 {
2298 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */ 2172 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2299 2173
2300 if (QUERY_FLAG (op, FLAG_UNPAID)) 2174 if (op->flag [FLAG_UNPAID])
2301 {
2302 if (env->type == PLAYER)
2303 esrv_del_item (env->contr, op->count);
2304
2305 op->insert_at (env); 2175 op->insert_at (env);
2306 }
2307 else if (op->inv) 2176 else if (op->inv)
2308 drop_unpaid_items (op->inv, env); 2177 drop_unpaid_items (op->inv, env);
2309 2178
2310 op = next; 2179 op = next;
2311 } 2180 }
2316{ 2185{
2317 if (!flag [FLAG_REMOVED]) 2186 if (!flag [FLAG_REMOVED])
2318 ::drop_unpaid_items (inv, this); 2187 ::drop_unpaid_items (inv, this);
2319} 2188}
2320 2189
2321/*
2322 * Returns pointer a static string containing gravestone text
2323 * Moved from apply.c to player.c - player.c is what
2324 * actually uses this function. player.c may not be quite the
2325 * best, a misc file for object actions is probably better,
2326 * but there isn't one in the server directory.
2327 */
2328char *
2329gravestone_text (object *op)
2330{
2331 static char buf2[MAX_BUF];
2332 char buf[MAX_BUF];
2333 time_t now = time (NULL);
2334
2335 strcpy (buf2, " R.I.P.\n\n");
2336 if (op->type == PLAYER)
2337 sprintf (buf, "%s the %s\n", &op->name, op->contr->title);
2338 else
2339 sprintf (buf, "%s\n", &op->name);
2340
2341 strncat (buf2, " ", 20 - strlen (buf) / 2);
2342 strcat (buf2, buf);
2343 if (op->type == PLAYER)
2344 sprintf (buf, "who was in level %d when killed\n", op->level);
2345 else
2346 sprintf (buf, "who was in level %d when died.\n\n", op->level);
2347
2348 strncat (buf2, " ", 20 - strlen (buf) / 2);
2349 strcat (buf2, buf);
2350 if (op->type == PLAYER)
2351 {
2352 sprintf (buf, "by %s.\n\n", op->contr->killer);
2353 strncat (buf2, " ", 21 - strlen (buf) / 2);
2354 strcat (buf2, buf);
2355 }
2356
2357 strftime (buf, MAX_BUF, "%b %d %Y\n", localtime (&now));
2358 strncat (buf2, " ", 20 - strlen (buf) / 2);
2359 strcat (buf2, buf);
2360
2361 return buf2;
2362}
2363
2364void 2190void
2365do_some_living (object *op) 2191do_some_living (object *op)
2366{ 2192{
2367 int last_food = op->stats.food; 2193 int last_food = op->stats.food;
2368 int gen_hp, gen_sp, gen_grace; 2194 int gen_hp, gen_sp, gen_grace;
2369 int over_hp, over_sp, over_grace;
2370 int i;
2371 int rate_hp = 1200; 2195 int rate_hp = 1200;
2372 int rate_sp = 2500; 2196 int rate_sp = 2500;
2373 int rate_grace = 2000; 2197 int rate_grace = 2000;
2374 const int max_hp = 1; 2198 const int max_hp = 1;
2375 const int max_sp = 1; 2199 const int max_sp = 1;
2376 const int max_grace = 1; 2200 const int max_grace = 1;
2377 2201
2202#if 0
2378 if (op->contr->hidden) 2203 if (op->contr->hidden)
2379 { 2204 {
2380 op->invisible = 1000; 2205 op->invisible = 1000;
2381 /* the socket code flashes the player visible/invisible 2206 /* the socket code flashes the player visible/invisible
2382 * depending on the value of invisible, so we need to 2207 * depending on the value of invisible, so we need to
2383 * alternate it here for it to work correctly. 2208 * alternate it here for it to work correctly.
2384 */ 2209 */
2385 if (pticks & 2) 2210 if (server_tick & 2)
2386 op->invisible--; 2211 op->invisible--;
2387 } 2212 }
2213 else
2214#endif
2388 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS))) 2215 if (op->invisible && !(op->flag [FLAG_MAKE_INVIS]))
2389 { 2216 {
2390 if (!op->invisible--) 2217 if (!op->invisible--)
2391 { 2218 {
2392 make_visible (op); 2219 make_visible (op);
2393 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out."); 2220 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2427 if (--op->last_grace < 0) 2254 if (--op->last_grace < 0)
2428 { 2255 {
2429 if (op->stats.grace < op->stats.maxgrace / 2) 2256 if (op->stats.grace < op->stats.maxgrace / 2)
2430 op->stats.grace++; /* no penalty in food for regaining grace */ 2257 op->stats.grace++; /* no penalty in food for regaining grace */
2431 2258
2259 int temp = gen_grace < 20 ? 30 : gen_grace + 10;
2260
2432 if (max_grace > 1) 2261 if (max_grace > 1)
2433 { 2262 {
2434 over_grace = (gen_grace < 20 ? 30 : gen_grace + 10) / rate_grace; 2263 int over_grace = temp / rate_grace;
2264
2435 if (over_grace > 0) 2265 if (over_grace > 0)
2436 { 2266 {
2437 op->stats.sp += over_grace 2267 op->stats.sp += over_grace + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > (temp % rate_grace)) ? -1 : 0;
2438 + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > ((gen_grace < 20 ? 30 : gen_grace + 10) % rate_grace)) ? -1 : 0;
2439 op->last_grace = 0; 2268 op->last_grace = 0;
2440 } 2269 }
2441 else 2270 else
2442 { 2271 op->last_grace = rate_grace / temp;
2443 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2444 }
2445 } 2272 }
2446 else 2273 else
2447 { 2274 op->last_grace = rate_grace / temp;
2448 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2275
2449 }
2450 /* wearing stuff doesn't detract from grace generation. */ 2276 /* wearing stuff doesn't detract from grace generation. */
2451 } 2277 }
2452 2278
2453 if (op->stats.food > 0) 2279 if (op->stats.food > 0)
2454 { 2280 {
2460 if (op->stats.sp < op->stats.maxsp) 2286 if (op->stats.sp < op->stats.maxsp)
2461 { 2287 {
2462 op->stats.sp++; 2288 op->stats.sp++;
2463 2289
2464 /* dms do not consume food */ 2290 /* dms do not consume food */
2465 if (!QUERY_FLAG (op, FLAG_WIZ)) 2291 if (!op->flag [FLAG_WIZ])
2466 { 2292 {
2467 op->stats.food--; 2293 op->stats.food--;
2468 2294
2469 if (op->contr->digestion < 0) 2295 if (op->contr->digestion < 0)
2470 op->stats.food += op->contr->digestion; 2296 op->stats.food += op->contr->digestion;
2473 } 2299 }
2474 } 2300 }
2475 2301
2476 if (max_sp > 1) 2302 if (max_sp > 1)
2477 { 2303 {
2478 over_sp = (gen_sp + 10) / rate_sp; 2304 int over_sp = (gen_sp + 10) / rate_sp;
2479 if (over_sp > 0) 2305 if (over_sp > 0)
2480 { 2306 {
2481 if (op->stats.sp < op->stats.maxsp) 2307 if (op->stats.sp < op->stats.maxsp)
2482 { 2308 {
2483 op->stats.sp += over_sp > max_sp ? max_sp : over_sp; 2309 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2504 if (op->stats.hp < op->stats.maxhp) 2330 if (op->stats.hp < op->stats.maxhp)
2505 { 2331 {
2506 op->stats.hp++; 2332 op->stats.hp++;
2507 2333
2508 /* dms do not consume food */ 2334 /* dms do not consume food */
2509 if (!QUERY_FLAG (op, FLAG_WIZ)) 2335 if (!op->flag [FLAG_WIZ])
2510 { 2336 {
2511 op->stats.food--; 2337 op->stats.food--;
2512 2338
2513 if (op->contr->digestion < 0) 2339 if (op->contr->digestion < 0)
2514 op->stats.food += op->contr->digestion; 2340 op->stats.food += op->contr->digestion;
2515 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2341 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2516 op->stats.food = last_food; 2342 op->stats.food = last_food;
2517 } 2343 }
2518 } 2344 }
2519 2345
2346 int temp = gen_hp < 20 ? 30 : gen_hp + 10;
2347
2520 if (max_hp > 1) 2348 if (max_hp > 1)
2521 { 2349 {
2522 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp; 2350 int over_hp = temp / rate_hp;
2523 2351
2524 if (over_hp > 0) 2352 if (over_hp > 0)
2525 { 2353 {
2526 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2354 op->stats.sp += over_hp + (random_roll (0, rate_hp - 1, op, PREFER_HIGH) > (temp % rate_hp)) ? -1 : 0;
2527 op->last_heal = 0; 2355 op->last_heal = 0;
2528 } 2356 }
2529 else 2357 else
2530 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2358 op->last_heal = rate_hp / temp;
2531 } 2359 }
2532 else 2360 else
2533 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2361 op->last_heal = rate_hp / temp;
2534 } 2362 }
2535 } 2363 }
2536 2364
2537 /* Digestion */ 2365 /* Digestion */
2538 if (--op->last_eat < 0) 2366 if (--op->last_eat < 0)
2541 penalty = max (0, -op->contr->digestion); 2369 penalty = max (0, -op->contr->digestion);
2542 2370
2543 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1); 2371 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2544 2372
2545 /* dms do not consume food */ 2373 /* dms do not consume food */
2546 if (!QUERY_FLAG (op, FLAG_WIZ)) 2374 if (!op->flag [FLAG_WIZ])
2547 op->stats.food--; 2375 op->stats.food--;
2548 } 2376 }
2549 2377
2550 if (op->stats.food < 0 && op->stats.hp >= 0) 2378 if (op->stats.food < 0 && op->stats.hp >= 0)
2551 { 2379 {
2552 object *tmp, *flesh = 0; 2380 object *flesh = 0;
2553 2381
2554 for (tmp = op->inv; tmp; tmp = tmp->below) 2382 for_inv_removable (op, tmp)
2555 { 2383 {
2556 if (!QUERY_FLAG (tmp, FLAG_UNPAID)) 2384 if (tmp->flag [FLAG_UNPAID])
2385 continue;
2386
2387 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2557 { 2388 {
2558 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2389 op->statusmsg ("You blindly grab for a bite of food. "
2559 { 2390 "H<To prevent you from starving, you ate some random item from your backpack.>");
2560 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2391 op->apply (tmp);
2561 manual_apply (op, tmp, 0); 2392
2562 if (op->stats.food >= 0 || op->stats.hp < 0) 2393 if (op->stats.food >= 0 || op->stats.hp < 0)
2563 break; 2394 break;
2564 } 2395 }
2565 else if (tmp->type == FLESH) 2396 else if (tmp->type == FLESH)
2566 flesh = tmp; 2397 flesh = tmp;
2567 } /* End if paid for object */ 2398 }
2568 } /* end of for loop */
2569 2399
2570 /* If player is still starving, it means they don't have any food, so 2400 /* If player is still starving, it means they don't have any food, so
2571 * eat flesh instead. 2401 * eat flesh instead.
2572 */ 2402 */
2573 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2403 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2574 { 2404 {
2575 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2405 op->statusmsg ("You blindly grab for a bite of food. "
2406 "H<To prevent you from starving, you ate some random item from your backpack.>");
2576 manual_apply (op, flesh, 0); 2407 op->apply (flesh);
2577 } 2408 }
2409
2410 // If player is still starving, alert him!
2411 if (op->stats.food < 0)
2412 op->failmsg ("You are starving! "
2413 "H<Eat some food to increase your food and prevent you from an untimely death.>");
2578 } 2414 }
2579 2415
2580 if (op->stats.food < 0) 2416 if (op->stats.food < 0)
2581 { 2417 {
2582 op->stats.hp += op->stats.food; 2418 op->stats.hp += op->stats.food;
2583 op->stats.food = 0; 2419 op->stats.food = 0;
2420
2421 if (op->stats.hp < 0)
2422 {
2423 op->contr->killer = archetype::get ("killer_starvation");
2424 op->contr->killer->destroy ();
2584 } 2425 }
2426 }
2585 2427
2428 /* killer should be set here already */
2586 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2429 if (op->stats.hp < 0 && !op->flag [FLAG_WIZ])
2587 kill_player (op); 2430 kill_player (op);
2588 } 2431 }
2589} 2432}
2590 2433
2591/* If the player should die (lack of hp, food, etc), we call this. 2434/* If the player should die (lack of hp, food, etc), we call this.
2595 */ 2438 */
2596void 2439void
2597kill_player (object *op) 2440kill_player (object *op)
2598{ 2441{
2599 int x, y; 2442 int x, y;
2600 char buf[MAX_BUF];
2601 maptile *map; /* this is for resurrection */ 2443 maptile *map; /* this is for resurrection */
2602 int will_kill_again; 2444 int will_kill_again;
2603 archetype *at; 2445 archetype *at;
2604 object *tmp; 2446 object *tmp;
2605 2447
2606 if (save_life (op)) 2448 if (save_life (op))
2607 return; 2449 return;
2450
2451 dynbuf_text deathtab;
2452
2453 /* restore player */
2454 at = archetype::find (shstr_poisoning);
2455 if (object *tmp = present_arch_in_ob (at, op))
2456 {
2457 tmp->destroy ();
2458 deathtab << "Your body feels cleansed...\r";
2459 }
2460
2461 at = archetype::find (shstr_confusion);
2462 if (object *tmp = present_arch_in_ob (at, op))
2463 {
2464 tmp->destroy ();
2465 deathtab << "Your mind feels clearer...\r";
2466 }
2467
2468 cure_disease (op, 0, 0); /* remove any disease */
2469
2470 max_it (op->stats.hp , op->stats.maxhp);
2471 max_it (op->stats.sp , op->stats.maxsp);
2472 max_it (op->stats.grace, op->stats.maxgrace);
2473 max_it (op->stats.food , 200);
2474
2475 // remove all spell effects that are active
2476 // to avoid long-term effects such as word-of-recall
2477 for (object *item = op->inv; item; )
2478 {
2479 object *next = item->below;
2480
2481 if (item->type == SPELL_EFFECT && item->active)
2482 item->destroy ();
2483
2484 item = next;
2485 }
2608 2486
2609 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2487 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2610 * in cities ONLY!!! It is very important that this doesn't get abused. 2488 * in cities ONLY!!! It is very important that this doesn't get abused.
2611 * Look at op_on_battleground() for more info --AndreasV 2489 * Look at op_on_battleground() for more info --AndreasV
2612 */ 2490 */
2613 if (op_on_battleground (op, &x, &y)) 2491 if (op_on_battleground (op, &x, &y))
2614 { 2492 {
2615 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2493 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2616 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2617
2618 /* restore player */
2619 at = archetype::find ("poisoning");
2620 if (object *tmp = present_arch_in_ob (at, op))
2621 {
2622 tmp->destroy ();
2623 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2624 }
2625
2626 at = archetype::find ("confusion");
2627 if (object *tmp = present_arch_in_ob (at, op))
2628 {
2629 tmp->destroy ();
2630 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2631 }
2632
2633 cure_disease (op, 0, 0); /* remove any disease */
2634 op->stats.hp = op->stats.maxhp;
2635 if (op->stats.food <= 0)
2636 op->stats.food = 999;
2637 2494
2638 /* create a bodypart-trophy to make the winner happy */ 2495 /* create a bodypart-trophy to make the winner happy */
2639 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2496 object *tmp = archetype::find (shstr_finger)->instance ();
2640 { 2497
2641 tmp->name = format ("%s's finger" , &op->name); 2498 tmp->name = format ("%s's finger" , &op->name);
2642 tmp->name_pl = format ("%s's fingers", &op->name); 2499 tmp->name_pl = format ("%s's fingers", &op->name);
2643 tmp->msg = format ( 2500 tmp->msg = format (
2644 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n", 2501 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2645 &op->name, op->contr->title, (int) (op->level), op->contr->killer 2502 &op->name, op->contr->title,
2503 (int)op->level,
2504 op->contr->killer_name ()
2646 ); 2505 );
2647 tmp->value = 0, tmp->type = 0; 2506 tmp->value = 0, tmp->type = 0;
2648 tmp->materialname = "organics"; 2507 tmp->material = name_to_material (shstr_organic);
2649 tmp->insert_at (op, tmp); 2508 tmp->insert_at (op, tmp);
2650 }
2651 2509
2652 /* teleport defeated player to new destination */ 2510 /* teleport defeated player to new destination */
2653 transfer_ob (op, x, y, 0, NULL); 2511 transfer_ob (op, x, y, 0, NULL);
2654 op->contr->braced = 0; 2512 op->contr->braced = 0;
2513
2514 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2655 return; 2515 return;
2656 } 2516 }
2657 2517
2518 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2519 deathtab << "T<YOU HAVE DIED>\n\n";
2520
2658 INVOKE_PLAYER (DEATH, op->contr); 2521 INVOKE_PLAYER (DEATH, op->contr);
2659 2522
2660 command_kill_pets (op, 0); 2523 command_kill_pets (op, 0);
2661
2662 if (op->stats.food < 0)
2663 strcpy (op->contr->killer, "starvation");
2664 2524
2665 op->contr->play_sound (sound_find ("player_dies")); 2525 op->contr->play_sound (sound_find ("player_dies"));
2666 2526
2667 /* save the map location for corpse, gravestone */ 2527 /* save the map location for corpse, gravestone */
2668 x = op->x; 2528 x = op->x;
2698 2558
2699 lost_a_stat = 0; 2559 lost_a_stat = 0;
2700 2560
2701 for (z = 0; z < num_stats_lose; z++) 2561 for (z = 0; z < num_stats_lose; z++)
2702 { 2562 {
2703 i = RANDOM () % NUM_STATS; 2563 i = rndm (NUM_STATS);
2704 2564
2705 if (settings.stat_loss_on_death) 2565 if (settings.stat_loss_on_death)
2706 { 2566 {
2707 /* Pick a random stat and take a point off it. Tell the player 2567 /* Pick a random stat and take a point off it. Tell the player
2708 * what he lost. 2568 * what he lost.
2715 lost_a_stat = 1; 2575 lost_a_stat = 1;
2716 } 2576 }
2717 else 2577 else
2718 { 2578 {
2719 /* deplete a stat */ 2579 /* deplete a stat */
2720 archetype *deparch = archetype::find ("depletion"); 2580 archetype *deparch = archetype::find (shstr_depletion);
2721 object *dep; 2581 object *dep;
2722 2582
2723 dep = present_arch_in_ob (deparch, op); 2583 dep = present_arch_in_ob (deparch, op);
2724 if (!dep) 2584 if (!dep)
2725 { 2585 {
2726 dep = arch_to_object (deparch); 2586 dep = deparch->instance ();
2727 insert_ob_in_ob (dep, op); 2587 insert_ob_in_ob (dep, op);
2728 } 2588 }
2729 lose_this_stat = 1; 2589 lose_this_stat = 1;
2730 if (settings.balanced_stat_loss) 2590 if (settings.balanced_stat_loss)
2731 { 2591 {
2743 2603
2744 /* There is a maximum depletion total per level. */ 2604 /* There is a maximum depletion total per level. */
2745 if (this_stat < -1 - op->level / BALSL_MAX_LOSS_RATIO) 2605 if (this_stat < -1 - op->level / BALSL_MAX_LOSS_RATIO)
2746 { 2606 {
2747 lose_this_stat = 0; 2607 lose_this_stat = 0;
2748 /* Take loss chance vs keep chance to see if we 2608 /* Take loss chance vs keep chance to see if we
2749 retain the stat. */ 2609 retain the stat. */
2750 } 2610 }
2751 else 2611 else
2752 { 2612 {
2753 if (random_roll (0, loss_chance + keep_chance - 1, op, PREFER_LOW) < keep_chance) 2613 if (random_roll (0, loss_chance + keep_chance - 1, op, PREFER_LOW) < keep_chance)
2759 } 2619 }
2760 } 2620 }
2761 2621
2762 if (lose_this_stat) 2622 if (lose_this_stat)
2763 { 2623 {
2764 this_stat = get_attr_value (&(dep->stats), i); 2624 this_stat = get_attr_value (&dep->stats, i);
2765 /* We could try to do something clever like find another 2625 /* We could try to do something clever like find another
2766 * stat to reduce if this fails. But chances are, if 2626 * stat to reduce if this fails. But chances are, if
2767 * stats have been depleted to -50, all are pretty low 2627 * stats have been depleted to -50, all are pretty low
2768 * and should be roughly the same, so it shouldn't make a 2628 * and should be roughly the same, so it shouldn't make a
2769 * difference. 2629 * difference.
2770 */ 2630 */
2771 if (this_stat >= -50) 2631 if (this_stat >= -50)
2772 { 2632 {
2773 change_attr_value (&(dep->stats), i, -1); 2633 change_attr_value (&(dep->stats), i, -1);
2774 SET_FLAG (dep, FLAG_APPLIED); 2634 dep->set_flag (FLAG_APPLIED);
2775 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]); 2635 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]);
2776 op->update_stats (); 2636 op->update_stats ();
2777 lost_a_stat = 1; 2637 lost_a_stat = 1;
2778 } 2638 }
2779 } 2639 }
2780 } 2640 }
2781 } 2641 }
2642
2782 /* If no stat lost, tell the player. */ 2643 /* If no stat lost, tell the player. */
2783 if (!lost_a_stat) 2644 if (!lost_a_stat)
2784 { 2645 {
2785 /* determine_god() seems to not work sometimes... why is this? 2646 /* determine_god() seems to not work sometimes... why is this?
2786 Should I be using something else? GD */ 2647 Should I be using something else? GD */
2787 const char *god = determine_god (op); 2648 shstr_tmp god = determine_god (op);
2788 2649
2789 if (god && (strcmp (god, "none"))) 2650 if (god != shstr_none)
2790 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2651 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2791 else 2652 else
2792 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2653 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2793 } 2654 }
2794#else 2655#else
2795 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you" " feel a holy presence protecting you from losing yourself completely."); 2656 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2796#endif 2657#endif
2797 2658
2798 /* Put a gravestone up where the character 'almost' died. List the 2659 /* Put a gravestone up where the character 'almost' died. List the
2799 * exp loss on the stone. 2660 * exp loss on the stone.
2800 */ 2661 */
2801 tmp = arch_to_object (archetype::find ("gravestone")); 2662 tmp = archetype::find (shstr_gravestone)->instance ();
2802 sprintf (buf, "%s's gravestone", &op->name); 2663 tmp->name = format ("%s's gravestone", &op->name);
2803 tmp->name = buf; 2664 tmp->name_pl = format ("%s's gravestones", &op->name);
2804 sprintf (buf, "%s's gravestones", &op->name); 2665 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2805 tmp->name_pl = buf; 2666 &op->name, op->contr->title, op->contr->killer_name ());
2806 sprintf (buf, "RIP\nHere rests the hero %s the %s,\n" "who was killed\n" "by %s.\n", &op->name, op->contr->title, op->contr->killer);
2807 tmp->msg = buf;
2808 tmp->x = op->x, tmp->y = op->y; 2667 tmp->x = op->x, tmp->y = op->y;
2809 insert_ob_in_map (tmp, op->map, NULL, 0); 2668 insert_ob_in_map (tmp, op->map, NULL, 0);
2810 2669
2811 /**************************************/ 2670 /**************************************/
2812 /* */ 2671 /* */
2813 /* Subtract the experience points, */ 2672 /* Subtract the experience points, */
2814 /* if we died cause of food, give us */
2815 /* food, and reset HP's... */
2816 /* */ 2673 /* */
2817 /**************************************/ 2674 /**************************************/
2818 2675
2819 /* remove any poisoning and confusion the character may be suffering. */
2820 /* restore player */
2821 at = archetype::find ("poisoning");
2822 tmp = present_arch_in_ob (at, op);
2823
2824 if (tmp)
2825 {
2826 tmp->destroy ();
2827 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2828 }
2829
2830 at = archetype::find ("confusion");
2831 tmp = present_arch_in_ob (at, op);
2832 if (tmp)
2833 {
2834 tmp->destroy ();
2835 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2836 }
2837
2838 cure_disease (op, 0, 0); /* remove any disease */
2839
2840 /*add_exp(op, (op->stats.exp * -0.20)); */ 2676 /*add_exp(op, (op->stats.exp * -0.20)); */
2841 apply_death_exp_penalty (op); 2677 apply_death_exp_penalty (op);
2842 if (op->stats.food < 100)
2843 op->stats.food = 900;
2844 op->stats.hp = op->stats.maxhp;
2845 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2846 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2847 2678
2848 /* 2679 /*
2849 * Check to see if the player has any unpaid items. If so, remove them 2680 * Check to see if the player has any unpaid items. If so, remove them
2850 * and put them back in the map. 2681 * and put them back in the map.
2851 */ 2682 */
2875 if (will_kill_again) 2706 if (will_kill_again)
2876 { 2707 {
2877 object *force; 2708 object *force;
2878 int at; 2709 int at;
2879 2710
2880 force = get_archetype (FORCE_NAME); 2711 force = archetype::get (FORCE_NAME);
2881 /* 50 ticks should be enough time for the spell to abate */ 2712 /* 50 ticks should be enough time for the spell to abate */
2882 force->speed = 0.1f;
2883 force->speed_left = -5.f; 2713 force->speed_left = -5.f;
2884 SET_FLAG (force, FLAG_APPLIED); 2714 force->set_speed (0.1f);
2715 force->set_flag (FLAG_APPLIED);
2716
2885 for (at = 0; at < NROFATTACKS; at++) 2717 for (at = 0; at < NROFATTACKS; at++)
2886 if (will_kill_again & (1 << at)) 2718 if (will_kill_again & (1 << at))
2887 force->resist[at] = 100; 2719 force->resist[at] = 100;
2888 2720
2889 insert_ob_in_ob (force, op); 2721 insert_ob_in_ob (force, op);
2890 op->update_stats (); 2722 op->update_stats ();
2891
2892 } 2723 }
2893 2724
2894 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2725 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2895} 2726}
2896 2727
2897void 2728static void
2898loot_object (object *op) 2729loot_object (object *op)
2899{ /* Grab and destroy some treasure */ 2730{ /* Grab and destroy some treasure */
2900 object *tmp, *tmp2, *next; 2731 object *tmp, *next;
2901 2732
2902 op->close_container (); /* close open sack first */ 2733 op->close_container (); /* close open sack first */
2903 2734
2904 for (tmp = op->inv; tmp; tmp = next) 2735 for (tmp = op->inv; tmp; tmp = next)
2905 { 2736 {
2912 tmp->x = op->x, tmp->y = op->y; 2743 tmp->x = op->x, tmp->y = op->y;
2913 2744
2914 if (tmp->type == CONTAINER) 2745 if (tmp->type == CONTAINER)
2915 loot_object (tmp); /* empty container to ground */ 2746 loot_object (tmp); /* empty container to ground */
2916 2747
2917 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3)))) 2748 if (!tmp->flag [FLAG_UNIQUE] && (tmp->flag [FLAG_STARTEQUIP] || tmp->flag [FLAG_NO_DROP] || !(rndm (3))))
2918 { 2749 {
2919 if (tmp->nrof > 1) 2750 if (tmp->nrof > 1)
2920 { 2751 {
2921 tmp2 = get_split_ob (tmp, 1 + RANDOM () % (tmp->nrof - 1)); 2752 tmp->decrease (rndm (1, tmp->nrof - 1));
2922 tmp2->destroy ();
2923 insert_ob_in_map (tmp, op->map, NULL, 0); 2753 insert_ob_in_map (tmp, op->map, NULL, 0);
2924 } 2754 }
2925 else 2755 else
2926 tmp->destroy (); 2756 tmp->destroy ();
2927 } 2757 }
2934 * fix_weight(): Check recursively the weight of all players, and fix 2764 * fix_weight(): Check recursively the weight of all players, and fix
2935 * what needs to be fixed. Refresh windows and fix speed if anything 2765 * what needs to be fixed. Refresh windows and fix speed if anything
2936 * was changed. 2766 * was changed.
2937 */ 2767 */
2938void 2768void
2939fix_weight (void) 2769fix_weight ()
2940{ 2770{
2941 for_all_players (pl) 2771 for_all_players (pl)
2942 { 2772 {
2943 int old = pl->ob->carrying, sum = sum_weight (pl->ob); 2773 weight_t old = pl->ob->carrying;
2944 2774
2945 if (old == sum) 2775 pl->ob->update_weight ();
2946 continue; 2776
2777 if (old != pl->ob->carrying)
2778 {
2947 pl->ob->update_stats (); 2779 pl->ob->update_stats ();
2948 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, old, sum); 2780 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, (int)old, (int)pl->ob->carrying);
2781 }
2949 } 2782 }
2950} 2783}
2951 2784
2952void 2785void
2953fix_luck (void) 2786fix_luck ()
2954{ 2787{
2955 for_all_players (pl) 2788 for_all_players (pl)
2956 if (!pl->ob->contr->ns->state) 2789 if (!pl->ob->contr->ns->state)
2957 pl->ob->change_luck (0); 2790 pl->ob->change_luck (0);
2958} 2791}
2995} 2828}
2996 2829
2997void 2830void
2998make_visible (object *op) 2831make_visible (object *op)
2999{ 2832{
3000 op->hide = 0; 2833 op->flag [FLAG_HIDDEN] = 0;
3001 op->invisible = 0; 2834 op->invisible = 0;
3002 2835
3003 if (op->type == PLAYER) 2836 if (op->type == PLAYER)
3004 { 2837 {
3005 op->contr->tmp_invis = 0; 2838 op->contr->tmp_invis = 0;
3010} 2843}
3011 2844
3012int 2845int
3013is_true_undead (object *op) 2846is_true_undead (object *op)
3014{ 2847{
3015 if (QUERY_FLAG (op->arch, FLAG_UNDEAD)) 2848 if (op->arch->flag [FLAG_UNDEAD])
3016 return 1; 2849 return 1;
3017 2850
3018 return 0; 2851 return 0;
3019} 2852}
3020 2853
3030 2863
3031 if (!ob || !ob->map) 2864 if (!ob || !ob->map)
3032 return 0; 2865 return 0;
3033 2866
3034 /* so, on normal lighted maps, its hard to hide */ 2867 /* so, on normal lighted maps, its hard to hide */
3035 level = ob->map->darkness - 2; 2868 level = ob->map->darklevel () - 2;
3036 2869
3037 /* this also picks up whether the object is glowing. 2870 /* this also picks up whether the object is glowing.
3038 * If you carry a light on a non-dark map, its not 2871 * If you carry a light on a non-dark map, its not
3039 * as bad as carrying a light on a pitch dark map */ 2872 * as bad as carrying a light on a pitch dark map */
3040 if (has_carried_lights (ob)) 2873 if (ob->has_carried_lights ())
3041 level = -(10 + (2 * ob->map->darkness)); 2874 level = -(10 + (2 * ob->map->darklevel ()));
3042 2875
3043 /* scan through all nearby squares for terrain to hide in */ 2876 /* scan through all nearby squares for terrain to hide in */
3044 for (i = 0, x = ob->x, y = ob->y; i < 9; i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2877 for (i = 0, x = ob->x, y = ob->y;
2878 i <= SIZEOFFREE1;
2879 i++, x = ob->x + DIRX (i), y = ob->y + DIRY (i))
3045 { 2880 {
3046 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 2881 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3047 if (mflag & P_OUT_OF_MAP) 2882 if (mflag & P_OUT_OF_MAP)
3048 {
3049 continue; 2883 continue;
3050 } 2884
3051 if (mflag & P_BLOCKSVIEW) /* something to hide near! */ 2885 if (mflag & P_BLOCKSVIEW) /* something to hide near! */
3052 level += 2; 2886 level += 2;
3053 else /* open terrain! */ 2887 else /* open terrain! */
3054 level -= 1; 2888 level -= 1;
3055 } 2889 }
3066 * spot (surrounded by clear terrain in broad daylight). -b.t. 2900 * spot (surrounded by clear terrain in broad daylight). -b.t.
3067 */ 2901 */
3068void 2902void
3069do_hidden_move (object *op) 2903do_hidden_move (object *op)
3070{ 2904{
3071 int hide = 0, num = random_roll (0, 19, op, PREFER_LOW); 2905 int hide = 0;
3072 object *skop;
3073 2906
3074 if (!op || !op->map) 2907 if (!op || !op->map)
3075 return; 2908 return;
3076 2909
3077 skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING); 2910 object *skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING);
2911 int num = random_roll (0, 19, op, PREFER_LOW);
3078 2912
3079 /* its *extremely* hard to run and sneak/hide at the same time! */ 2913 /* its *extremely* hard to run and sneak/hide at the same time! */
3080 if (op->type == PLAYER && op->contr->run_on) 2914 if (op->type == PLAYER && op->contr->run_on)
3081 if (!skop || num >= skop->level) 2915 if (!skop || num >= skop->level)
3082 { 2916 {
3092 num -= hide; 2926 num -= hide;
3093 2927
3094 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0)) 2928 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0))
3095 { 2929 {
3096 make_visible (op); 2930 make_visible (op);
2931
3097 if (op->type == PLAYER) 2932 if (op->type == PLAYER)
3098 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!"); 2933 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!");
3099 } 2934 }
3100 else if (op->type == PLAYER && skop) 2935 else if (op->type == PLAYER && skop)
3101 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0); 2936 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0);
3116 2951
3117 if (who->type == PLAYER) 2952 if (who->type == PLAYER)
3118 player = 1; 2953 player = 1;
3119 2954
3120 else 2955 else
3121 friendly = QUERY_FLAG (who, FLAG_FRIENDLY); 2956 friendly = who->flag [FLAG_FRIENDLY];
3122 2957
3123 /* search adjacent squares */ 2958 /* search adjacent squares */
3124 for (i = 1; i < 9; i++) 2959 for (i = 1; i < 9; i++)
3125 { 2960 {
3126 x = who->x + freearr_x[i]; 2961 x = who->x + DIRX (i);
3127 y = who->y + freearr_y[i]; 2962 y = who->y + DIRY (i);
3128 m = who->map; 2963 m = who->map;
3129 mflags = get_map_flags (m, &m, x, y, &x, &y); 2964 mflags = get_map_flags (m, &m, x, y, &x, &y);
3130 /* space must be blocked if there is a monster. If not 2965 /* space must be blocked if there is a monster. If not
3131 * blocked, don't need to check this space. 2966 * blocked, don't need to check this space.
3132 */ 2967 */
3135 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y))) 2970 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y)))
3136 continue; 2971 continue;
3137 2972
3138 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 2973 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
3139 { 2974 {
3140 if ((player ||friendly) &&QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_UNAGGRESSIVE)) 2975 if ((player ||friendly) &&tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_UNAGGRESSIVE])
3141 return 1; 2976 return 1;
3142 else if (tmp->type == PLAYER) 2977 else if (tmp->type == PLAYER)
3143 {
3144 /*don't let a hidden DM prevent you from hiding */
3145 if (!QUERY_FLAG (tmp, FLAG_WIZ) || tmp->contr->hidden == 0)
3146 return 1; 2978 return 1;
3147 }
3148 } 2979 }
3149 } 2980 }
3150 return 0; 2981 return 0;
3151} 2982}
3152 2983
3153/* check the player los field for viewability of the 2984/* check the player los field for viewability of the
3154 * object op. This function works fine for monsters, 2985 * object op. This function works fine for monsters,
3155 * but we dont worry if the object isnt the top one in 2986 * but we dont worry if the object isnt the top one in
3156 * a pile (say a coin under a table would return "viewable" 2987 * a pile (say a coin under a table would return "viewable"
3157 * by this routine). Another question, should we be 2988 * by this routine). Another question, should we be
3158 * concerned with the direction the player is looking 2989 * concerned with the direction the player is looking
3159 * in? Realistically, most of us can't see stuff behind 2990 * in? Realistically, most of us can't see stuff behind
3160 * our backs...on the other hand, does the "facing" direction 2991 * our backs...on the other hand, does the "facing" direction
3161 * imply the way your head, or body is facing? It's possible 2992 * imply the way your head, or body is facing? It's possible
3162 * for them to differ. Sigh, this fctn could get a bit more complex. 2993 * for them to differ. Sigh, this fctn could get a bit more complex.
3163 * -b.t. 2994 * -b.t.
3164 * This function is now map tiling safe. 2995 * This function is now map tiling safe.
3165 */ 2996 */
3166int 2997int
3167player_can_view (object *pl, object *op) 2998player_can_view (object *pl, object *op)
3168{ 2999{
3182 3013
3183 get_rangevector (pl, op, &rv, 0x1); 3014 get_rangevector (pl, op, &rv, 0x1);
3184 3015
3185 /* starting with the 'head' part, lets loop 3016 /* starting with the 'head' part, lets loop
3186 * through the object and find if it has any 3017 * through the object and find if it has any
3187 * part that is in the los array but isn't on 3018 * part that is in the los array but isn't on
3188 * a blocked los square. 3019 * a blocked los square.
3189 * we use the archetype to figure out offsets. 3020 * we use the archetype to figure out offsets.
3190 */ 3021 */
3191 while (op) 3022 while (op)
3192 { 3023 {
3193 dx = rv.distance_x + op->arch->x; 3024 dx = rv.distance_x + op->arch->x;
3194 dy = rv.distance_y + op->arch->y; 3025 dy = rv.distance_y + op->arch->y;
3195 3026
3196 /* only the viewable area the player sees is updated by LOS 3027 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3197 * code, so we need to restrict ourselves to that range of values
3198 * for any meaningful values.
3199 */
3200 if (abs (dx) <= (pl->contr->ns->mapx / 2) &&
3201 abs (dy) <= (pl->contr->ns->mapy / 2) &&
3202 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3203 return 1; 3028 return 1;
3204 3029
3205 op = op->more; 3030 op = op->more;
3206 }
3207
3208 return 0;
3209}
3210
3211/* routine for both players and monsters. We call this when
3212 * there is a possibility for our action distrubing our hiding
3213 * place or invisiblity spell. Artefact invisiblity is not
3214 * effected by this. If we arent invisible to begin with, we
3215 * return 0.
3216 */
3217int
3218action_makes_visible (object *op)
3219{
3220 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3221 {
3222 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3223 return 0;
3224
3225 if (op->contr && op->contr->tmp_invis == 0)
3226 return 0;
3227
3228 /* If monsters, they should become visible */
3229 if (op->hide || !op->contr || (op->contr && op->contr->tmp_invis))
3230 {
3231 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible");
3232 return 1;
3233 }
3234 } 3031 }
3235 3032
3236 return 0; 3033 return 0;
3237} 3034}
3238 3035
3253 * and the exit-coordinates sp/hp must both be > 0. 3050 * and the exit-coordinates sp/hp must both be > 0.
3254 * => The intention here is to prevent abuse of the battleground- 3051 * => The intention here is to prevent abuse of the battleground-
3255 * feature (like pickable or hidden battleground tiles). */ 3052 * feature (like pickable or hidden battleground tiles). */
3256 for (object *tmp = op->below; tmp; tmp = tmp->below) 3053 for (object *tmp = op->below; tmp; tmp = tmp->below)
3257 { 3054 {
3258 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3055 if (tmp->flag [FLAG_IS_FLOOR])
3259 { 3056 {
3260 if (QUERY_FLAG (tmp, FLAG_NO_PICK) 3057 if (tmp->flag [FLAG_NO_PICK]
3261 && tmp->type == BATTLEGROUND 3058 && tmp->type == BATTLEGROUND
3262 && tmp->name == shstr_battleground 3059 && tmp->name == shstr_battleground
3263 && EXIT_X (tmp) && EXIT_Y (tmp)) 3060 && EXIT_X (tmp) && EXIT_Y (tmp))
3264 { 3061 {
3265 /* before we assign the exit, check if this is a teambattle */ 3062 /* before we assign the exit, check if this is a teambattle */
3266 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3063 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3267 {
3268 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below) 3064 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3065 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3269 { 3066 {
3270 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3271 {
3272 if (x && y) 3067 if (x && y)
3273 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3068 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3274 3069
3275 return 1; 3070 return 1;
3276 }
3277 } 3071 }
3278 }
3279 3072
3280 if (x && y) 3073 if (x && y)
3281 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3074 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3282 3075
3283 return 1; 3076 return 1;
3421 else 3214 else
3422 j = 1; 3215 j = 1;
3423 strcat (buf, spellpathnames[i]); 3216 strcat (buf, spellpathnames[i]);
3424 } 3217 }
3425 } 3218 }
3219
3426 strcat (buf, "."); 3220 strcat (buf, ".");
3427 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf); 3221 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf);
3428 } 3222 }
3429 3223
3430 /* evtl. adding flags: */ 3224 /* evtl. adding flags: */
3431 if (QUERY_FLAG (item, FLAG_XRAYS)) 3225 if (item->flag [FLAG_XRAYS])
3432 SET_FLAG (skin, FLAG_XRAYS); 3226 skin->set_flag (FLAG_XRAYS);
3433 if (QUERY_FLAG (item, FLAG_STEALTH)) 3227 if (item->flag [FLAG_STEALTH])
3434 SET_FLAG (skin, FLAG_STEALTH); 3228 skin->set_flag (FLAG_STEALTH);
3435 if (QUERY_FLAG (item, FLAG_SEE_IN_DARK)) 3229 if (item->flag [FLAG_SEE_IN_DARK])
3436 SET_FLAG (skin, FLAG_SEE_IN_DARK); 3230 skin->set_flag (FLAG_SEE_IN_DARK);
3437 3231
3438 /* print message if there is one */ 3232 /* print message if there is one */
3439 if (item->msg != NULL) 3233 if (item->msg != NULL)
3440 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg); 3234 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg);
3441 } 3235 }
3442 else 3236 else
3443 { 3237 {
3444 /* generate misc. treasure */ 3238 /* generate misc. treasure */
3445 tmp = arch_to_object (tr->item); 3239 tmp = tr->item->instance ();
3446 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3240 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3447 tmp = insert_ob_in_ob (tmp, who); 3241 who->insert (tmp);
3448 if (who->type == PLAYER)
3449 esrv_send_item (who, tmp);
3450 } 3242 }
3451} 3243}
3452 3244
3453/** 3245//-GPL
3454 * Unready an object for a player. This function does nothing if the object was
3455 * not readied.
3456 */
3457void
3458player_unready_range_ob (player *pl, object *ob)
3459{
3460 if (pl->ob->current_weapon == ob)
3461 pl->ob->current_weapon = 0;
3462
3463 if (pl->combat_ob == ob)
3464 pl->combat_ob = 0;
3465
3466 if (pl->ranged_ob == ob)
3467 pl->ranged_ob = 0;
3468}
3469 3246
3470sint8 3247sint8
3471player::visibility_at (maptile *map, int x, int y) const 3248player::darkness_at (maptile *map, int x, int y) const
3472{ 3249{
3473 if (!ns) 3250 if (!ns)
3474 return 0; 3251 return LOS_BLOCKED;
3475 3252
3476 int dx, dy; 3253 int dx, dy;
3477 if (!adjacent_map (map, ns->current_map, &dx, &dy)) 3254 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3478 return 0; 3255 return LOS_BLOCKED;
3479 3256
3480 x += dx - ns->current_x + ns->mapx / 2; 3257 x += dx - ns->current_x;
3481 y += dy - ns->current_y + ns->mapy / 2; 3258 y += dy - ns->current_y;
3482 3259
3483 if (!IN_RANGE_EXC (x, 0, ns->mapx) || !IN_RANGE_EXC (y, 0, ns->mapy))
3484 return 0;
3485
3486 return 100 - blocked_los [x][y]; 3260 return blocked_los (x, y);
3487} 3261}
3488 3262
3489void 3263void
3490player::infobox (const char *title, const char *msg, int color) 3264player::infobox (const char *title, const char *msg, int color)
3491{ 3265{
3503{ 3277{
3504 play_sound (sound_find ("generic_failure")); 3278 play_sound (sound_find ("generic_failure"));
3505 statusmsg (msg, color); 3279 statusmsg (msg, color);
3506} 3280}
3507 3281
3282void
3283object::failmsgf (const char *format, ...)
3284{
3285 if (!contr)
3286 return;
3287
3288 va_list ap;
3289 va_start (ap, format);
3290 contr->failmsg (vformat (format, ap));
3291 va_end (ap);
3292}
3293
3294void
3295player::failmsgf (const char *format, ...)
3296{
3297 va_list ap;
3298 va_start (ap, format);
3299 failmsg (vformat (format, ap));
3300 va_end (ap);
3301}
3302

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines