ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.94 by root, Mon Jan 8 14:29:05 2007 UTC vs.
Revision 1.217 by root, Sun Dec 28 08:56:44 2008 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25#include <global.h> 24#include <global.h>
26#include <pwd.h>
27#include <sproto.h> 25#include <sproto.h>
28#include <sounds.h> 26#include <sounds.h>
29#include <living.h> 27#include <living.h>
30#include <object.h> 28#include <object.h>
31#include <spells.h> 29#include <spells.h>
… …
116 114
117 news[0] = '\0'; 115 news[0] = '\0';
118 subject[0] = '\0'; 116 subject[0] = '\0';
119 size = 0; 117 size = 0;
120 118
121 while (fgets (buf, MAX_BUF, fp) != NULL) 119 while (fgets (buf, MAX_BUF, fp))
122 { 120 {
123 if (*buf == '#') 121 if (*buf == '#')
124 continue; 122 continue;
125 123
126 if (*buf == '%') 124 if (*buf == '%')
127 { /* send one news */ 125 { /* send one news */
128 if (size > 0) 126 if (size > 0)
129 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s", "%s\n%s", subject, news); /*send previously read news */ 127 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
128 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS,
129 "INFORMATION: %s\n%s", (char *)"%s\n%s",
130 subject, news); /*send previously read news */
130 131
131 strcpy (subject, buf + 1); 132 strcpy (subject, buf + 1);
132 strip_endline (subject); 133 strip_endline (subject);
133 size = 0; 134 size = 0;
134 news[0] = '\0'; 135 news[0] = '\0';
… …
144 size += strlen (buf); 145 size += strlen (buf);
145 } 146 }
146 } 147 }
147 148
148 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, 149 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
149 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", "%s\n%s", subject, news); 150 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", (char *)"%s\n%s", subject, news);
150 close_and_delete (fp, comp); 151 close_and_delete (fp, comp);
151} 152}
152 153
153/* This loads the first map an puts the player on it. */ 154/* This loads the first map an puts the player on it. */
154static void 155static void
155set_first_map (object *op) 156set_first_map (object *op)
156{ 157{
157 op->contr->maplevel = first_map_path; 158 op->contr->maplevel = first_map_path;
158 op->x = -1; 159 op->x = -1;
159 op->y = -1; 160 op->y = -1;
160}
161
162void
163player::enter_map ()
164{
165 object *tmp = object::create ();
166
167 EXIT_PATH (tmp) = maplevel;
168 EXIT_X (tmp) = ob->x;
169 EXIT_Y (tmp) = ob->y;
170 ob->enter_exit (tmp);
171
172 tmp->destroy ();
173} 161}
174 162
175void 163void
176player::activate () 164player::activate ()
177{ 165{
… …
182 ob->remove (); 170 ob->remove ();
183 ob->map = 0; 171 ob->map = 0;
184 ob->activate_recursive (); 172 ob->activate_recursive ();
185 CLEAR_FLAG (ob, FLAG_FRIENDLY); 173 CLEAR_FLAG (ob, FLAG_FRIENDLY);
186 add_friendly_object (ob); 174 add_friendly_object (ob);
187 enter_map ();
188} 175}
189 176
190void 177void
191player::deactivate () 178player::deactivate ()
192{ 179{
… …
194 return; 181 return;
195 182
196 terminate_all_pets (ob); 183 terminate_all_pets (ob);
197 remove_friendly_object (ob); 184 remove_friendly_object (ob);
198 ob->deactivate_recursive (); 185 ob->deactivate_recursive ();
186
187 if (ob->map)
188 maplevel = ob->map->path;
189
199 ob->remove (); 190 ob->remove ();
191 ob->enemy = 0; // sometimes keeps an extra refcount on itself
200 ob->map = 0; 192 ob->map = 0;
193 party = 0;
201 194
202 // for weird reasons, this is often "ob", keeping a circular reference 195 combat_ob = ranged_ob = 0; //TODO, should be special marker, non-refcounted, not this
203 ranges [range_skill] = 0;
204 196
205 players.erase (this); 197 players.erase (this);
206} 198}
207 199
208// connect the player with a specific client 200// connect the player with a specific client
209// also changed, rationalises, and fixes some incorrect settings 201// also changes, rationalises, and fixes some incorrect settings
210void 202void
211player::connect (client *ns) 203player::connect (client *ns)
212{ 204{
213 this->ns = ns; 205 this->ns = ns;
214 ns->pl = this; 206 ns->pl = this;
215 207
208 run_on = 0;
209 fire_on = 0;
210 ob->close_container (); //TODO: client-specific
211
216 ns->update_look = 0; 212 ns->update_look = 0;
217 ns->look_position = 0; 213 ns->look_position = 0;
218 214
219 clear_los (ob); 215 clear_los ();
220 216
221//TODO: must move into client 217 ns->reset_stats ();
222/* we need to clear these to -1 and not zero - otherwise,
223 * if a player quits and starts a new character, we wont
224 * send new values to the client, as things like exp start
225 * at zero.
226 */
227for (int i = 0; i < NUM_SKILLS; i++)
228 last_skill_exp[i] = -1;
229
230for (int i = 0; i < NROFATTACKS; i++)
231 last_resist[i] = -1;
232
233last_weapon_sp = -1;
234last_level = -1;
235last_stats.exp = -1;
236last_weight = (uint32) - 1;
237last_flags = 0;
238last_weight = 0;
239last_weight_limit = 0;
240last_path_attuned = 0;
241last_path_repelled = 0;
242last_path_denied = 0;
243last_speed = 0;
244run_on = 0;
245fire_on = 0;
246memset (&last_stats, 0, sizeof (living)); //TODO dirty
247 218
248 /* make sure he's a player -- needed because of class change. */ 219 /* make sure he's a player -- needed because of class change. */
249 ob->type = PLAYER; // we are paranoid 220 ob->type = PLAYER; // we are paranoid
250 ob->race = ob->arch->clone.race; 221 ob->race = ob->arch->race;
251 222
252 if (!legal_range (ob, shoottype)) 223 ob->update_weight ();
253 shoottype = range_none;
254
255 ob->carrying = sum_weight (ob);
256 link_player_skills (ob); 224 link_skills ();
257 225
258 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER); 226 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
259 227
260 assign (title, ob->arch->clone.name); 228 assign (title, ob->arch->object::name);
261
262 /* can_use_shield is a new flag. However, the can_use.. seems to largely come
263 * from the class, and not race. I don't see any way to get the class information
264 * to then update this. I don't think this will actually break anything - anyone
265 * that can use armour should be able to use a shield. What this may 'break'
266 * are features new characters get, eg, if someone starts up with a Q, they
267 * should be able to use a shield. However, old Q's won't get that advantage.
268 */
269 if (QUERY_FLAG (ob, FLAG_USE_ARMOUR))
270 SET_FLAG (ob, FLAG_USE_SHIELD);
271 229
272 /* if it's a dragon player, set the correct title here */ 230 /* if it's a dragon player, set the correct title here */
273 if (is_dragon_pl (ob)) 231 if (is_dragon_pl (ob))
274 { 232 {
275 object *tmp, *abil = 0, *skin = 0; 233 object *tmp, *abil = 0, *skin = 0;
276 234
277 shstr_cmp dragon_ability_force ("dragon_ability_force");
278 shstr_cmp dragon_skin_force ("dragon_skin_force");
279
280 for (tmp = ob->inv; tmp; tmp = tmp->below) 235 for (tmp = ob->inv; tmp; tmp = tmp->below)
281 if (tmp->type == FORCE) 236 if (tmp->type == FORCE)
282 if (tmp->arch->name == dragon_ability_force) 237 if (tmp->arch->archname == shstr_dragon_ability_force)
283 abil = tmp; 238 abil = tmp;
284 else if (tmp->arch->name == dragon_skin_force) 239 else if (tmp->arch->archname == shstr_dragon_skin_force)
285 skin = tmp; 240 skin = tmp;
286 241
287 set_dragon_name (ob, abil, skin); 242 set_dragon_name (ob, abil, skin);
288 } 243 }
289 244
290 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 245 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
291 246
292 esrv_new_player (this, ob->weight + ob->carrying); 247 esrv_new_player (this);
293 248
294 ob->update_stats (); 249 ob->update_stats ();
250
295 ns->floorbox_update (); 251 ns->floorbox_update ();
296
297 esrv_send_inventory (ob, ob); 252 esrv_send_inventory (ob, ob);
298 esrv_add_spells (this, 0); 253 esrv_add_spells (this, 0);
299 254
300 activate (); 255 activate ();
301 256
… …
308} 263}
309 264
310void 265void
311player::disconnect () 266player::disconnect ()
312{ 267{
268 if (ob)
269 {
270 ob->close_container (); //TODO: client-specific
271 ob->drop_unpaid_items ();
272 }
273
313 if (ns) 274 if (ns)
314 { 275 {
315 if (active) 276 if (active)
316 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0)); 277 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0));
317 278
318 INVOKE_PLAYER (DISCONNECT, this); 279 INVOKE_PLAYER (DISCONNECT, this);
319 280
281 ns->reset_stats ();
320 ns->pl = 0; 282 ns->pl = 0;
321 this->ns = 0; 283 ns = 0;
322 } 284 }
285
286 observe = ob;
323 287
324 deactivate (); 288 deactivate ();
325} 289}
326 290
327// the need for this function can be explained 291// the need for this function can be explained
328// by load_object not returning the object 292// by load_object not returning the object
329void 293void
330player::set_object (object *op) 294player::set_object (object *op)
331{ 295{
332 ob = op; 296 ob = observe = op;
333 ob->contr = this; /* this aren't yet in archetype */ 297 ob->contr = this; /* this aren't yet in archetype */
334 298
299 ob->speed = 1.0f;
335 ob->speed_left = 0.5; 300 ob->speed_left = 0.5f;
336 ob->speed = 1.0; 301
337 ob->direction = 5; /* So player faces south */ 302 ob->direction = 5; /* So player faces south */
338 ob->stats.wc = 2;
339 ob->run_away = 25; /* Then we panick... */
340 303
341 ob->roll_stats (); 304 ob->flag [FLAG_READY_WEAPON] = false;
305 ob->flag [FLAG_READY_SKILL] = false;
306 ob->flag [FLAG_READY_BOW] = false;
307
308 for (object *op = ob->inv; op; op = op->below)
309 if (op->flag [FLAG_APPLIED])
310 switch (op->type)
311 {
312 case SKILL:
313 ob->flag [FLAG_APPLIED] = false;
314 break;
315
316 case WAND:
317 case ROD:
318 case HORN:
319 case BOW:
320 ranged_ob = op;
321 break;
322
323 case WEAPON:
324 combat_ob = op;
325 break;
326 }
327
328 ob->change_weapon (combat_ob ? combat_ob : ranged_ob);
329 ob->deactivate (); // change_weapon activates, fix this better
330}
331
332void
333player::set_observe (object *op)
334{
335 observe = op ? op : ob;
336 do_los = 1;
342} 337}
343 338
344player::player () 339player::player ()
345{ 340{
346 /* There are some elements we want initialised to non zero value - 341 /* There are some elements we want initialised to non zero value -
347 * we deal with that below this point. 342 * we deal with that below this point.
348 */ 343 */
349 outputs_sync = 16; /* Every 2 seconds */ 344 outputs_sync = 4;
350 outputs_count = 8; /* Keeps present behaviour */ 345 outputs_count = 4;
351 unapply = unapply_nochoice; 346 unapply = unapply_nochoice;
352 347
353 savebed_map = first_map_path; /* Init. respawn position */ 348 savebed_map = first_map_path; /* Init. respawn position */
354 349
355 gen_sp_armour = 10; 350 gen_sp_armour = 10;
356 shoottype = range_none;
357 bowtype = bow_normal; 351 bowtype = bow_normal;
358 petmode = pet_normal; 352 petmode = pet_normal;
359 listening = 10;
360 usekeys = containers; 353 usekeys = containers;
361 peaceful = 1; /* default peaceful */ 354 peaceful = 1; /* default peaceful */
362 do_los = 1; 355 do_los = 1;
356
357 weapon_sp = 1.0f;
358 weapon_sp_left = 0.5f;
363} 359}
364 360
365void 361void
366player::do_destroy () 362player::do_destroy ()
367{ 363{
… …
372 if (ob) 368 if (ob)
373 { 369 {
374 ob->destroy_inv (false); 370 ob->destroy_inv (false);
375 ob->destroy (); 371 ob->destroy ();
376 } 372 }
373
374 ob = observe = 0;
377} 375}
378 376
379player::~player () 377player::~player ()
380{ 378{
381 /* Clear item stack */ 379 /* Clear item stack */
… …
390player::create () 388player::create ()
391{ 389{
392 player *pl = new player; 390 player *pl = new player;
393 391
394 pl->set_object (arch_to_object (get_player_archetype (0))); 392 pl->set_object (arch_to_object (get_player_archetype (0)));
393
394 pl->ob->roll_stats ();
395 pl->ob->stats.wc = 2;
396 pl->ob->run_away = 25; /* Then we panick... */
397
395 set_first_map (pl->ob); 398 set_first_map (pl->ob);
396 399
397 return pl; 400 return pl;
398} 401}
399 402
… …
403 * Note: there MUST be at least one player archetype! 406 * Note: there MUST be at least one player archetype!
404 */ 407 */
405archetype * 408archetype *
406get_player_archetype (archetype *at) 409get_player_archetype (archetype *at)
407{ 410{
408 archetype *start = at; 411 // archetypes could have been reloaded
412 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
413
414 if (!nat)
415 return at;
416
417 archvec::iterator i = archetypes.find (nat);
409 418
410 for (;;) 419 for (;;)
411 { 420 {
412 if (at == NULL || at->next == NULL) 421 if (++i == archetypes.end ())
413 at = first_archetype; 422 i = archetypes.begin ();
414 else 423 else if (*i == at)
415 at = at->next; 424 cleanup ("not a single player archetype found");
416 425
417 if (at->clone.type == PLAYER) 426 if ((*i)->type == PLAYER)
418 return at; 427 return *i;
419
420 if (at == start)
421 {
422 LOG (llevError, "No Player archetypes\n");
423 exit (-1);
424 }
425 } 428 }
426} 429}
427 430
428object * 431object *
429get_nearest_player (object *mon) 432get_nearest_player (object *mon)
… …
433 unsigned lastdist; 436 unsigned lastdist;
434 rv_vector rv; 437 rv_vector rv;
435 438
436 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next) 439 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next)
437 { 440 {
438 /* We should not find free objects on this friendly list, but it
439 * does periodically happen. Given that, lets deal with it.
440 * While unlikely, it is possible the next object on the friendly
441 * list is also free, so encapsulate this in a while loop.
442 */
443 while (QUERY_FLAG (ol->ob, FLAG_FREED) || !QUERY_FLAG (ol->ob, FLAG_FRIENDLY))
444 {
445 object *tmp = ol->ob;
446
447 /* Can't do much more other than log the fact, because the object
448 * itself will have been cleared.
449 */
450 LOG (llevDebug, "get_nearest_player: Found free/non friendly object '%s' on friendly list\n",
451 tmp->debug_desc ());
452 ol = ol->next;
453 remove_friendly_object (tmp);
454 if (!ol)
455 return op;
456 }
457
458 /* Remove special check for player from this. First, it looks to cause
459 * some crashes (ol->ob->contr not set properly?), but secondly, a more
460 * complicated method of state checking would be needed in any case -
461 * as it was, a clever player could type quit, and the function would
462 * skip them over while waiting for confirmation. Remove
463 * on_same_map check, as can_detect_enemy also does this
464 */
465 if (!can_detect_enemy (mon, ol->ob, &rv)) 441 if (!can_detect_enemy (mon, ol->ob, &rv))
466 continue; 442 continue;
467 443
468 if (lastdist > rv.distance) 444 if (lastdist > rv.distance)
469 { 445 {
… …
545 x = mon->x; 521 x = mon->x;
546 y = mon->y; 522 y = mon->y;
547 m = mon->map; 523 m = mon->map;
548 dir = rv.direction; 524 dir = rv.direction;
549 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 525 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
550 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 526 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
527
551 /* If we can't solve it within the search distance, return now. */ 528 /* If we can't solve it within the search distance, return now. */
552 if (diff > max) 529 if (diff > max)
553 return 0; 530 return 0;
531
554 while (diff > 1 && max > 0) 532 while (diff > 1 && max > 0)
555 { 533 {
556 lastx = x; 534 lastx = x;
557 lasty = y; 535 lasty = y;
558 lastmap = m; 536 lastmap = m;
… …
640 max--; 618 max--;
641 lastdir = dir; 619 lastdir = dir;
642 if (!firstdir) 620 if (!firstdir)
643 firstdir = dir; 621 firstdir = dir;
644 } 622 }
623
645 if (diff <= 1) 624 if (diff <= 1)
646 { 625 {
647 /* Recalculate diff (distance) because we may not have actually 626 /* Recalculate diff (distance) because we may not have actually
648 * headed toward player for entire distance. 627 * headed toward player for entire distance.
649 */ 628 */
650 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 629 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0);
651 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 630 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
652 } 631 }
632
653 if (diff > max) 633 if (diff > max)
654 return 0; 634 return 0;
655 } 635 }
636
656 /* If we reached the max, didn't find a direction in time */ 637 /* If we reached the max, didn't find a direction in time */
657 if (!max) 638 if (!max)
658 return 0; 639 return 0;
659 640
660 return firstdir; 641 return firstdir;
661} 642}
662 643
663void 644void
664give_initial_items (object *pl, treasurelist * items) 645give_initial_items (object *pl, treasurelist *items)
665{ 646{
666 object *op, *next = NULL;
667
668 if (pl->randomitems != NULL) 647 if (pl->randomitems)
669 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0); 648 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0);
670 649
671 for (op = pl->inv; op; op = next) 650 for (object *next, *op = pl->inv; op; op = next)
672 { 651 {
673 next = op->below; 652 next = op->below;
674 653
675 /* Forces get applied per default, unless they have the 654 /* Forces get applied per default, unless they have the
676 * flag "neutral" set. Sorry but I can't think of a better way 655 * flag "neutral" set. Sorry but I can't think of a better way
… …
681 /* we never give weapons/armour if these cannot be used 660 /* we never give weapons/armour if these cannot be used
682 * by this player due to race restrictions 661 * by this player due to race restrictions
683 */ 662 */
684 if (pl->type == PLAYER) 663 if (pl->type == PLAYER)
685 { 664 {
686 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) && 665 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR)
666 &&
687 (op->type == ARMOUR || op->type == BOOTS || 667 (op->type == ARMOUR || op->type == BOOTS
688 op->type == CLOAK || op->type == HELMET || 668 || op->type == CLOAK || op->type == HELMET
689 op->type == SHIELD || op->type == GLOVES || 669 || op->type == SHIELD || op->type == GLOVES
670 || op->type == BRACERS || op->type == GIRDLE))
690 op->type == BRACERS || op->type == GIRDLE)) || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 671 || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON))
691 { 672 {
692 op->destroy (); 673 op->destroy ();
693 continue; 674 continue;
694 } 675 }
695 } 676 }
… …
718 if (op->nrof > 1) 699 if (op->nrof > 1)
719 op->nrof = 1; 700 op->nrof = 1;
720 } 701 }
721 702
722 if (op->type == SPELLBOOK && op->inv) 703 if (op->type == SPELLBOOK && op->inv)
723 {
724 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP); 704 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP);
725 }
726 705
727 /* Give starting characters identified, uncursed, and undamned 706 /* Give starting characters identified, uncursed, and undamned
728 * items. Just don't identify gold or silver, or it won't be 707 * items. Just don't identify gold or silver, or it won't be
729 * merged properly. 708 * merged properly.
730 */ 709 */
731 if (need_identify (op)) 710 if (need_identify (op))
732 { 711 {
733 SET_FLAG (op, FLAG_IDENTIFIED); 712 SET_FLAG (op, FLAG_IDENTIFIED);
734 CLEAR_FLAG (op, FLAG_CURSED); 713 CLEAR_FLAG (op, FLAG_CURSED);
735 CLEAR_FLAG (op, FLAG_DAMNED); 714 CLEAR_FLAG (op, FLAG_DAMNED);
736 } 715 }
716
737 if (op->type == SPELL) 717 if (op->type == SPELL)
738 { 718 {
739 op->destroy (); 719 op->destroy ();
740 continue; 720 continue;
741 } 721 }
… …
743 { 723 {
744 SET_FLAG (op, FLAG_CAN_USE_SKILL); 724 SET_FLAG (op, FLAG_CAN_USE_SKILL);
745 op->stats.exp = 0; 725 op->stats.exp = 0;
746 op->level = 1; 726 op->level = 1;
747 } 727 }
748 /* lock all 'normal items by default */ 728 else /* lock all 'normal items by default */
749 else
750 SET_FLAG (op, FLAG_INV_LOCKED); 729 SET_FLAG (op, FLAG_INV_LOCKED);
751 } /* for loop of objects in player inv */ 730 } /* for loop of objects in player inv */
752 731
753 /* Need to set up the skill pointers */ 732 /* Need to set up the skill pointers */
754 link_player_skills (pl); 733 pl->contr->link_skills ();
755} 734}
756 735
757void 736void
758get_party_password (object *op, partylist *party) 737get_party_password (object *op, partylist *party)
759{ 738{
… …
774roll_stat (void) 753roll_stat (void)
775{ 754{
776 int a[4], i, j, k; 755 int a[4], i, j, k;
777 756
778 for (i = 0; i < 4; i++) 757 for (i = 0; i < 4; i++)
779 a[i] = (int) RANDOM () % 6 + 1; 758 a[i] = (int) rndm (6) + 1;
780 759
781 for (i = 0, j = 0, k = 7; i < 4; i++) 760 for (i = 0, j = 0, k = 7; i < 4; i++)
782 if (a[i] < k) 761 if (a[i] < k)
783 k = a[i], j = i; 762 k = a[i], j = i;
784 763
… …
790} 769}
791 770
792void 771void
793object::roll_stats () 772object::roll_stats ()
794{ 773{
795 int statsort [7]; 774 int statsort [NUM_STATS];
796 775
797 for (;;) 776 for (;;)
798 { 777 {
799 int sum = 0; 778 int sum = 0;
800 for (int i = 7; i--; ) 779 for (int i = NUM_STATS; i--; )
801 sum += statsort [i] = roll_stat (); 780 sum += statsort [i] = roll_stat ();
802 781
803 if (sum >= 82 && sum <= 116) 782 if (sum >= 82 && sum <= 116)
804 break; 783 break;
805 } 784 }
806 785
807 // Sort the stats so that rerolling is easier... 786 // Sort the stats so that rerolling is easier...
808 std::sort (statsort, statsort + 7, std::greater<int>()); 787 std::sort (statsort, statsort + NUM_STATS, std::greater<int>());
809 788
789 for (int i = 0; i < NUM_STATS; ++i)
810 stats.Str = statsort[0]; 790 stats.stat (i) = statsort [i];
811 stats.Dex = statsort[1];
812 stats.Con = statsort[2];
813 stats.Int = statsort[3];
814 stats.Wis = statsort[4];
815 stats.Pow = statsort[5];
816 stats.Cha = statsort[6];
817 791
818 stats.exp = 0; 792 stats.exp = 0;
819 stats.ac = 0; 793 stats.ac = 0;
820 794
821 stats.hp = stats.maxhp; 795 stats.hp = stats.maxhp;
… …
833} 807}
834 808
835void 809void
836object::swap_stats (int a, int b) 810object::swap_stats (int a, int b)
837{ 811{
838 int tmp = get_attr_value (&contr->orig_stats, a); 812 swap (contr->orig_stats.stat (a), contr->orig_stats.stat (b));
839 set_attr_value (&contr->orig_stats, a, get_attr_value (&contr->orig_stats, b));
840 set_attr_value (&contr->orig_stats, b, tmp);
841 813
814 for (int i = 0; i < NUM_STATS; ++i)
842 stats.Str = contr->orig_stats.Str; 815 stats.stat (i) = contr->orig_stats.stat (i);
843 stats.Dex = contr->orig_stats.Dex;
844 stats.Con = contr->orig_stats.Con;
845 stats.Int = contr->orig_stats.Int;
846 stats.Wis = contr->orig_stats.Wis;
847 stats.Pow = contr->orig_stats.Pow;
848 stats.Cha = contr->orig_stats.Cha;
849 816
850 //TODO: the following code looks so borked and should, at the very least, 817 //TODO: the following code looks so borked and should, at the very least,
851 // be merged with the similar code in roll_stats 818 // be merged with the similar code in roll_stats
852 stats.ac = 0; 819 stats.ac = 0;
853 820
… …
872static void 839static void
873start_info (object *op) 840start_info (object *op)
874{ 841{
875 char buf[MAX_BUF]; 842 char buf[MAX_BUF];
876 843
877 sprintf (buf, "Welcome to Crossfire v%s!", VERSION); 844 sprintf (buf, "Welcome to Deliantra v%s!", VERSION);
878 new_draw_info (NDI_UNIQUE, 0, op, buf); 845 new_draw_info (NDI_UNIQUE, 0, op, buf);
879 //new_draw_info (NDI_UNIQUE, 0, op, "Press `?' for help");
880 //new_draw_info (NDI_UNIQUE, 0, op, " ");
881} 846}
882 847
883/* This function takes the key that is passed, and does the 848/* This function takes the key that is passed, and does the
884 * appropriate action with it (change race, or other things). 849 * appropriate action with it (change race, or other things).
885 * The function name is for historical reasons - now we have 850 * The function name is for historical reasons - now we have
886 * separate race and class; this actually changes the RACE, 851 * separate race and class; this actually changes the RACE,
887 * not the class. 852 * not the class.
888 */ 853 */
889int 854void
890key_change_class (object *op, char key) 855player::chargen_race_done ()
891{ 856{
892 int tmp_loop;
893
894 if (key == 'd' || key == 'D')
895 {
896 char buf[MAX_BUF];
897
898 /* this must before then initial items are given */ 857 /* this must before then initial items are given */
899 esrv_new_player (op->contr, op->weight + op->carrying); 858 esrv_new_player (ob->contr);
900 859
901 treasurelist *tl = find_treasurelist ("starting_wealth"); 860 treasurelist *tl = treasurelist::find ("starting_wealth");
902 if (tl) 861 if (tl)
903 create_treasure (tl, op, 0, 0, 0); 862 create_treasure (tl, ob, 0, 0, 0);
904 863
905 INVOKE_PLAYER (BIRTH, op->contr); 864 INVOKE_PLAYER (BIRTH, ob->contr);
906 INVOKE_PLAYER (LOGIN, op->contr); 865 INVOKE_PLAYER (LOGIN, ob->contr);
907 866
908 op->contr->ns->state = ST_PLAYING; 867 ob->contr->ns->state = ST_PLAYING;
909 868
910 if (op->msg) 869 if (ob->msg)
911 op->msg = NULL; 870 ob->msg = 0;
912 871
913 /* We create this now because some of the unique maps will need it
914 * to save here.
915 */
916 sprintf (buf, "%s/%s/%s", settings.localdir, settings.playerdir, &op->name);
917 make_path_to_file (buf);
918
919#ifdef AUTOSAVE
920 op->contr->last_save_tick = pticks;
921#endif
922 start_info (op); 872 start_info (ob);
923 CLEAR_FLAG (op, FLAG_WIZ); 873 CLEAR_FLAG (ob, FLAG_WIZ);
924 give_initial_items (op, op->randomitems); 874 give_initial_items (ob, ob->randomitems);
925 link_player_skills (op);
926 esrv_send_inventory (op, op); 875 esrv_send_inventory (ob, ob);
927 op->update_stats (); 876 ob->update_stats ();
928 877
929 /* This moves the player to a different start map, if there 878 /* This moves the player to a different start map, if there
930 * is one for this race 879 * is one for this race
931 */ 880 */
932 if (*first_map_ext_path) 881 if (*first_map_ext_path)
933 { 882 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
934 object *tmp;
935 char mapname[MAX_BUF];
936
937 snprintf (mapname, MAX_BUF - 1, "%s/%s", &first_map_ext_path, &op->arch->name);
938 tmp = object::create ();
939 EXIT_PATH (tmp) = mapname;
940 EXIT_X (tmp) = op->x;
941 EXIT_Y (tmp) = op->y;
942 op->enter_exit (tmp); /* we don't really care if it succeeded;
943 * if the map isn't there, then stay on the
944 * default initial map */
945 tmp->destroy ();
946 }
947 else 883 else
948 LOG (llevDebug, "first_map_ext_path not set\n"); 884 LOG (llevDebug, "first_map_ext_path not set\n");
885}
949 886
950 return 0; 887void
951 } 888player::chargen_race_next ()
952 889{
953 /* Following actually changes the race - this is the default command 890 /* Following actually changes the race - this is the default command
954 * if we don't match with one of the options above. 891 * if we don't match with one of the options above.
955 */ 892 */
956 893
957 tmp_loop = 0; 894 do
958 while (!tmp_loop)
959 { 895 {
960 shstr name = op->name; 896 shstr name = ob->name;
961 int x = op->x, y = op->y; 897 int x = ob->x, y = ob->y;
962 898
963 op->remove_statbonus (); 899 ob->remove_statbonus ();
964 op->remove (); 900 ob->remove ();
965 op->arch = get_player_archetype (op->arch); 901 ob->arch = get_player_archetype (ob->arch);
966 op->arch->clone.copy_to (op); 902 ob->arch->copy_to (ob);
967 op->instantiate (); 903 ob->instantiate ();
968 op->stats = op->contr->orig_stats; 904 ob->stats = ob->contr->orig_stats;
969 op->name = op->name_pl = name; 905 ob->name = ob->name_pl = name;
970 op->x = x; 906 ob->x = x;
971 op->y = y; 907 ob->y = y;
972 SET_ANIMATION (op, 2); /* So player faces south */ 908 SET_ANIMATION (ob, 2); /* So player faces south */
973 insert_ob_in_map (op, op->map, op, 0); 909 insert_ob_in_map (ob, ob->map, ob, 0);
974 assign (op->contr->title, op->arch->clone.name); 910 assign (ob->contr->title, ob->arch->object::name);
975 op->add_statbonus (); 911 ob->add_statbonus ();
976 tmp_loop = allowed_class (op);
977 } 912 }
913 while (!allowed_class (ob));
978 914
979 update_object (op, UP_OBJ_FACE); 915 update_object (ob, UP_OBJ_FACE);
980 esrv_update_item (UPD_FACE, op, op); 916 esrv_update_item (UPD_FACE, ob, ob);
981 op->update_stats (); 917 ob->update_stats ();
982 op->stats.hp = op->stats.maxhp; 918 ob->stats.hp = ob->stats.maxhp;
983 op->stats.sp = op->stats.maxsp; 919 ob->stats.sp = ob->stats.maxsp;
984 op->stats.grace = 0; 920 ob->stats.grace = 0;
985
986 if (op->msg)
987 new_draw_info (NDI_BLUE, 0, op, op->msg);
988
989 send_query (op->contr->ns, CS_QUERY_SINGLECHAR, "Press any key for the next race.\nPress `d' to play this race.\n");
990 return 0;
991} 921}
992 922
993void 923void
994flee_player (object *op) 924flee_player (object *op)
995{ 925{
… …
1001 LOG (llevDebug, "Fleeing player is dead.\n"); 931 LOG (llevDebug, "Fleeing player is dead.\n");
1002 CLEAR_FLAG (op, FLAG_SCARED); 932 CLEAR_FLAG (op, FLAG_SCARED);
1003 return; 933 return;
1004 } 934 }
1005 935
1006 if (op->enemy == NULL) 936 if (!op->enemy)
1007 { 937 {
1008 LOG (llevDebug, "Fleeing player had no enemy.\n"); 938 LOG (llevDebug, "Fleeing player had no enemy.\n");
1009 CLEAR_FLAG (op, FLAG_SCARED); 939 CLEAR_FLAG (op, FLAG_SCARED);
1010 return; 940 return;
1011 } 941 }
1012 942
1013 /* Seen some crashes here. Since we don't store an
1014 * op->enemy_count, it is possible that something destroys the
1015 * actual enemy, and the object is recycled.
1016 */
1017 if (op->enemy->map == NULL)
1018 {
1019 CLEAR_FLAG (op, FLAG_SCARED);
1020 op->enemy = NULL;
1021 return;
1022 }
1023
1024 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0)) 943 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
1025 { 944 {
1026 op->enemy = NULL; 945 op->enemy = NULL;
1027 CLEAR_FLAG (op, FLAG_SCARED); 946 CLEAR_FLAG (op, FLAG_SCARED);
1028 return; 947 return;
… …
1031 get_rangevector (op, op->enemy, &rv, 0); 950 get_rangevector (op, op->enemy, &rv, 0);
1032 951
1033 dir = absdir (4 + rv.direction); 952 dir = absdir (4 + rv.direction);
1034 for (diff = 0; diff < 3; diff++) 953 for (diff = 0; diff < 3; diff++)
1035 { 954 {
1036 int m = 1 - (RANDOM () & 2); 955 int m = 1 - rndm (2) * 2;
1037 956
1038 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 957 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op)))
1039 return; 958 return;
1040 } 959 }
1041 960
1042 /* Cornered, get rid of scared */ 961 /* Cornered, get rid of scared */
1043 CLEAR_FLAG (op, FLAG_SCARED); 962 CLEAR_FLAG (op, FLAG_SCARED);
1044 op->enemy = NULL; 963 op->enemy = NULL;
1045} 964}
1046 965
1047
1048/* check_pick sees if there is stuff to be picked up/picks up stuff. 966/* check_pick sees if there is stuff to be picked up/picks up stuff.
1049 * IT returns 1 if the player should keep on moving, 0 if he should 967 * It returns 1 if the player should keep on moving, 0 if he should
1050 * stop. 968 * stop.
1051 */ 969 */
1052int 970int
1053check_pick (object *op) 971check_pick (object *op)
1054{ 972{
1055 object *tmp, *next; 973 object *tmp, *next;
1056 int stop = 0; 974 int stop = 0;
1057 int j, k, wvratio; 975 int wvratio;
1058 char putstring[128], tmpstr[16]; 976 char putstring[128];
1059 977
1060 /* if you're flying, you cna't pick up anything */ 978 /* if you're flying, you cna't pick up anything */
1061 if (op->move_type & MOVE_FLYING) 979 if (op->move_type & MOVE_FLYING)
1062 return 1; 980 return 1;
1063 981
1064 next = op->below; 982 next = op->below;
1065 983
984 int cnt = MAX_ITEM_PER_DROP;
985#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
986
1066 /* loop while there are items on the floor that are not marked as 987 /* loop while there are items on the floor that are not marked as
1067 * destroyed */ 988 * destroyed */
1068 while (next && !next->destroyed ()) 989 while (next && !next->destroyed ())
1069 { 990 {
1070 tmp = next; 991 tmp = next;
1071 next = tmp->below; 992 next = tmp->below;
1072 993
994 if (cnt <= 0)
995 {
996 op->failmsg ("Couldn't pickup all items at once.");
997 return 0;
998 }
999
1073 if (op->destroyed ()) 1000 if (op->destroyed ())
1074 return 0; 1001 return 0;
1075 1002
1076 if (!can_pick (op, tmp)) 1003 if (!can_pick (op, tmp))
1077 continue; 1004 continue;
1078 1005
1079 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 1006 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1080 { 1007 {
1081 if (item_matched_string (op, tmp, op->contr->search_str)) 1008 if (item_matched_string (op, tmp, op->contr->search_str))
1082 pick_up (op, tmp); 1009 CHK_PICK_PICKUP;
1010
1083 continue; 1011 continue;
1084 } 1012 }
1085 1013
1086 /* high not bit set? We're using the old autopickup model */ 1014 /* high not bit set? We're using the old autopickup model */
1087 if (!(op->contr->mode & PU_NEWMODE)) 1015 if (!(op->contr->mode & PU_NEWMODE))
… …
1089 switch (op->contr->mode) 1017 switch (op->contr->mode)
1090 { 1018 {
1091 case 0: 1019 case 0:
1092 return 1; /* don't pick up */ 1020 return 1; /* don't pick up */
1093 case 1: 1021 case 1:
1094 pick_up (op, tmp); 1022 CHK_PICK_PICKUP;
1095 return 1; 1023 return 1;
1096 case 2: 1024 case 2:
1097 pick_up (op, tmp); 1025 CHK_PICK_PICKUP;
1098 return 0; 1026 return 0;
1099 case 3: 1027 case 3:
1100 return 0; /* stop before pickup */ 1028 return 0; /* stop before pickup */
1101 case 4: 1029 case 4:
1102 pick_up (op, tmp); 1030 CHK_PICK_PICKUP;
1103 break; 1031 break;
1104 case 5: 1032 case 5:
1105 pick_up (op, tmp); 1033 CHK_PICK_PICKUP;
1106 stop = 1; 1034 stop = 1;
1107 break; 1035 break;
1108 case 6: 1036 case 6:
1109 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1037 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL)
1110 pick_up (op, tmp); 1038 && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1039 CHK_PICK_PICKUP;
1111 break; 1040 break;
1112 1041
1113 case 7: 1042 case 7:
1114 if (tmp->type == MONEY || tmp->type == GEM) 1043 if (tmp->type == MONEY || tmp->type == GEM)
1115 pick_up (op, tmp); 1044 CHK_PICK_PICKUP;
1116 break; 1045 break;
1117 1046
1118 default: 1047 default:
1119 /* use value density */ 1048 /* use value density */
1120 if (!QUERY_FLAG (tmp, FLAG_UNPAID) 1049 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1121 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode) 1050 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1122 pick_up (op, tmp); 1051 CHK_PICK_PICKUP;
1123 } 1052 }
1124 } 1053 }
1125 else 1054 else
1126 { /* old model */ 1055 { /* old model */
1127 /* NEW pickup handling */ 1056 /* NEW pickup handling */
… …
1131 if (tmp->name != NULL) 1060 if (tmp->name != NULL)
1132 sprintf (putstring, "item name: %s item type: %d weight/value: %d", 1061 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1133 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1062 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1134 else 1063 else
1135 sprintf (putstring, "item name: %s item type: %d weight/value: %d", 1064 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1136 &tmp->arch->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1065 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1137 1066
1138 new_draw_info (NDI_UNIQUE, 0, op, putstring); 1067 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1139 } 1068 }
1140 1069
1141 /* philosophy: 1070 /* philosophy:
… …
1182 /* all food and drink if desired */ 1111 /* all food and drink if desired */
1183 /* question: don't pick up known-poisonous stuff? */ 1112 /* question: don't pick up known-poisonous stuff? */
1184 if (op->contr->mode & PU_FOOD) 1113 if (op->contr->mode & PU_FOOD)
1185 if (tmp->type == FOOD) 1114 if (tmp->type == FOOD)
1186 { 1115 {
1187 pick_up (op, tmp); 1116 CHK_PICK_PICKUP;
1188 continue; 1117 continue;
1189 } 1118 }
1190 1119
1191 if (op->contr->mode & PU_DRINK) 1120 if (op->contr->mode & PU_DRINK)
1192 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1121 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)))
1193 { 1122 {
1194 pick_up (op, tmp); 1123 CHK_PICK_PICKUP;
1195 continue; 1124 continue;
1196 } 1125 }
1197 1126
1198 if (op->contr->mode & PU_POTION) 1127 if (op->contr->mode & PU_POTION)
1199 if (tmp->type == POTION) 1128 if (tmp->type == POTION)
1200 { 1129 {
1201 pick_up (op, tmp); 1130 CHK_PICK_PICKUP;
1202 continue; 1131 continue;
1203 } 1132 }
1204 1133
1205 /* spellbooks, skillscrolls and normal books/scrolls */ 1134 /* spellbooks, skillscrolls and normal books/scrolls */
1206 if (op->contr->mode & PU_SPELLBOOK) 1135 if (op->contr->mode & PU_SPELLBOOK)
1207 if (tmp->type == SPELLBOOK) 1136 if (tmp->type == SPELLBOOK)
1208 { 1137 {
1209 pick_up (op, tmp); 1138 CHK_PICK_PICKUP;
1210 continue; 1139 continue;
1211 } 1140 }
1212 1141
1213 if (op->contr->mode & PU_SKILLSCROLL) 1142 if (op->contr->mode & PU_SKILLSCROLL)
1214 if (tmp->type == SKILLSCROLL) 1143 if (tmp->type == SKILLSCROLL)
1215 { 1144 {
1216 pick_up (op, tmp); 1145 CHK_PICK_PICKUP;
1217 continue; 1146 continue;
1218 } 1147 }
1219 1148
1220 if (op->contr->mode & PU_READABLES) 1149 if (op->contr->mode & PU_READABLES)
1221 if (tmp->type == BOOK || tmp->type == SCROLL) 1150 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
1222 { 1151 {
1223 pick_up (op, tmp); 1152 CHK_PICK_PICKUP;
1224 continue; 1153 continue;
1225 } 1154 }
1226 1155
1227 /* wands/staves/rods/horns */ 1156 /* wands/staves/rods/horns */
1228 if (op->contr->mode & PU_MAGIC_DEVICE) 1157 if (op->contr->mode & PU_MAGIC_DEVICE)
1229 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN) 1158 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1230 { 1159 {
1231 pick_up (op, tmp); 1160 CHK_PICK_PICKUP;
1232 continue; 1161 continue;
1233 } 1162 }
1234 1163
1235 /* pick up all magical items */ 1164 /* pick up all magical items */
1236 if (op->contr->mode & PU_MAGICAL) 1165 if (op->contr->mode & PU_MAGICAL)
1237 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1166 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1238 { 1167 {
1239 pick_up (op, tmp); 1168 CHK_PICK_PICKUP;
1240 continue; 1169 continue;
1241 } 1170 }
1242 1171
1243 if (op->contr->mode & PU_VALUABLES) 1172 if (op->contr->mode & PU_VALUABLES)
1244 { 1173 {
1245 if (tmp->type == MONEY || tmp->type == GEM) 1174 if (tmp->type == MONEY || tmp->type == GEM)
1246 { 1175 {
1247 pick_up (op, tmp); 1176 CHK_PICK_PICKUP;
1248 continue; 1177 continue;
1249 } 1178 }
1250 } 1179 }
1251 1180
1252 /* rings & amulets - talismans seems to be typed AMULET */ 1181 /* rings & amulets - talismans seems to be typed AMULET */
1253 if (op->contr->mode & PU_JEWELS) 1182 if (op->contr->mode & PU_JEWELS)
1254 if (tmp->type == RING || tmp->type == AMULET) 1183 if (tmp->type == RING || tmp->type == AMULET)
1255 { 1184 {
1256 pick_up (op, tmp); 1185 CHK_PICK_PICKUP;
1257 continue; 1186 continue;
1258 } 1187 }
1259 1188
1260 /* we don't forget dragon food */ 1189 /* we don't forget dragon food */
1261 if (op->contr->mode & PU_FLESH) 1190 if (op->contr->mode & PU_FLESH)
1262 if (tmp->type == FLESH) 1191 if (tmp->type == FLESH)
1263 { 1192 {
1264 pick_up (op, tmp); 1193 CHK_PICK_PICKUP;
1265 continue; 1194 continue;
1266 } 1195 }
1267 1196
1268 /* bows and arrows. Bows are good for selling! */ 1197 /* bows and arrows. Bows are good for selling! */
1269 if (op->contr->mode & PU_BOW) 1198 if (op->contr->mode & PU_BOW)
1270 if (tmp->type == BOW) 1199 if (tmp->type == BOW)
1271 { 1200 {
1272 pick_up (op, tmp); 1201 CHK_PICK_PICKUP;
1273 continue; 1202 continue;
1274 } 1203 }
1275 1204
1276 if (op->contr->mode & PU_ARROW) 1205 if (op->contr->mode & PU_ARROW)
1277 if (tmp->type == ARROW) 1206 if (tmp->type == ARROW)
1278 { 1207 {
1279 pick_up (op, tmp); 1208 CHK_PICK_PICKUP;
1280 continue; 1209 continue;
1281 } 1210 }
1282 1211
1283 /* all kinds of armor etc. */ 1212 /* all kinds of armor etc. */
1284 if (op->contr->mode & PU_ARMOUR) 1213 if (op->contr->mode & PU_ARMOUR)
1285 if (tmp->type == ARMOUR) 1214 if (tmp->type == ARMOUR)
1286 { 1215 {
1287 pick_up (op, tmp); 1216 CHK_PICK_PICKUP;
1288 continue; 1217 continue;
1289 } 1218 }
1290 1219
1291 if (op->contr->mode & PU_HELMET) 1220 if (op->contr->mode & PU_HELMET)
1292 if (tmp->type == HELMET) 1221 if (tmp->type == HELMET)
1293 { 1222 {
1294 pick_up (op, tmp); 1223 CHK_PICK_PICKUP;
1295 continue; 1224 continue;
1296 } 1225 }
1297 1226
1298 if (op->contr->mode & PU_SHIELD) 1227 if (op->contr->mode & PU_SHIELD)
1299 if (tmp->type == SHIELD) 1228 if (tmp->type == SHIELD)
1300 { 1229 {
1301 pick_up (op, tmp); 1230 CHK_PICK_PICKUP;
1302 continue; 1231 continue;
1303 } 1232 }
1304 1233
1305 if (op->contr->mode & PU_BOOTS) 1234 if (op->contr->mode & PU_BOOTS)
1306 if (tmp->type == BOOTS) 1235 if (tmp->type == BOOTS)
1307 { 1236 {
1308 pick_up (op, tmp); 1237 CHK_PICK_PICKUP;
1309 continue; 1238 continue;
1310 } 1239 }
1311 1240
1312 if (op->contr->mode & PU_GLOVES) 1241 if (op->contr->mode & PU_GLOVES)
1313 if (tmp->type == GLOVES) 1242 if (tmp->type == GLOVES)
1314 { 1243 {
1315 pick_up (op, tmp); 1244 CHK_PICK_PICKUP;
1316 continue; 1245 continue;
1317 } 1246 }
1318 1247
1319 if (op->contr->mode & PU_CLOAK) 1248 if (op->contr->mode & PU_CLOAK)
1320 if (tmp->type == CLOAK) 1249 if (tmp->type == CLOAK)
1321 { 1250 {
1322 pick_up (op, tmp); 1251 CHK_PICK_PICKUP;
1323 continue; 1252 continue;
1324 } 1253 }
1325 1254
1326 /* hoping to catch throwing daggers here */ 1255 /* hoping to catch throwing daggers here */
1327 if (op->contr->mode & PU_MISSILEWEAPON) 1256 if (op->contr->mode & PU_MISSILEWEAPON)
1328 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN)) 1257 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1329 { 1258 {
1330 pick_up (op, tmp); 1259 CHK_PICK_PICKUP;
1331 continue; 1260 continue;
1332 } 1261 }
1333 1262
1334 /* careful: chairs and tables are weapons! */ 1263 /* careful: chairs and tables are weapons! */
1335 if (op->contr->mode & PU_ALLWEAPON) 1264 if (op->contr->mode & PU_ALLWEAPON)
1336 { 1265 {
1337 if (tmp->type == WEAPON && tmp->name != NULL) 1266 if (tmp->type == WEAPON && tmp->name != NULL)
1338 { 1267 {
1339 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->name, "table") == NULL && 1268 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->archname, "table") == NULL &&
1340 strstr (tmp->name, "chair") && strstr (tmp->arch->name, "chair") == NULL) 1269 strstr (tmp->name, "chair") && strstr (tmp->arch->archname, "chair") == NULL)
1341 { 1270 {
1342 pick_up (op, tmp); 1271 CHK_PICK_PICKUP;
1343 continue; 1272 continue;
1344 } 1273 }
1345 } 1274 }
1346 1275
1347 if (tmp->type == WEAPON && tmp->name == NULL) 1276 if (tmp->type == WEAPON && tmp->name == NULL)
1348 { 1277 {
1349 if (strstr (tmp->arch->name, "table") == NULL && strstr (tmp->arch->name, "chair") == NULL) 1278 if (strstr (tmp->arch->archname, "table") == NULL && strstr (tmp->arch->archname, "chair") == NULL)
1350 { 1279 {
1351 pick_up (op, tmp); 1280 CHK_PICK_PICKUP;
1352 continue; 1281 continue;
1353 } 1282 }
1354 } 1283 }
1355 } 1284 }
1356 1285
1357 /* misc stuff that's useful */ 1286 /* misc stuff that's useful */
1358 if (op->contr->mode & PU_KEY) 1287 if (op->contr->mode & PU_KEY)
1359 if (tmp->type == KEY || tmp->type == SPECIAL_KEY) 1288 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1360 { 1289 {
1361 pick_up (op, tmp); 1290 CHK_PICK_PICKUP;
1362 continue; 1291 continue;
1363 } 1292 }
1364 1293
1365 /* any of the last 4 bits set means we use the ratio for value 1294 /* any of the last 4 bits set means we use the ratio for value
1366 * pickups */ 1295 * pickups */
1367 if (op->contr->mode & PU_RATIO) 1296 if (op->contr->mode & PU_RATIO)
1368 { 1297 {
1369 /* use value density to decide what else to grab */ 1298 /* use value density to decide what else to grab */
1370 /* >=7 was >= op->contr->mode */ 1299 /* >=7 was >= op->contr->mode */
1371 /* >=7 is the old standard setting. Now we take the last 4 bits 1300 /* >=7 is the old standard setting. Now we take the last 4 bits
1372 * and multiply them by 5, giving 0..15*5== 5..75 */ 1301 */
1373 wvratio = (op->contr->mode & PU_RATIO) * 5; 1302 wvratio = op->contr->mode & PU_RATIO;
1374 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio) 1303 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1375 { 1304 {
1376 pick_up (op, tmp); 1305 CHK_PICK_PICKUP;
1377#if 0 1306#if 0
1378 fprintf (stderr, "HIGH WEIGHT/VALUE ["); 1307 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1379 if (tmp->name != NULL) 1308 if (tmp->name != NULL)
1380 { 1309 {
1381 fprintf (stderr, "%s", tmp->name); 1310 fprintf (stderr, "%s", tmp->name);
1382 } 1311 }
1383 else 1312 else
1384 fprintf (stderr, "%s", tmp->arch->name); 1313 fprintf (stderr, "%s", tmp->arch->archname);
1385 fprintf (stderr, ",%d] = ", tmp->type); 1314 fprintf (stderr, ",%d] = ", tmp->type);
1386 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1315 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1387#endif 1316#endif
1388 continue; 1317 continue;
1389 } 1318 }
… …
1400 * found object is returned. 1329 * found object is returned.
1401 */ 1330 */
1402object * 1331object *
1403find_arrow (object *op, const char *type) 1332find_arrow (object *op, const char *type)
1404{ 1333{
1405 object *tmp = NULL;
1406
1407 for (op = op->inv; op; op = op->below) 1334 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1408 if (!tmp && op->type == CONTAINER && op->race == type && QUERY_FLAG (op, FLAG_APPLIED))
1409 tmp = find_arrow (op, type);
1410 else if (op->type == ARROW && op->race == type) 1335 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1336 return splay (tmp);
1337
1338 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1339 if (tmp->type == CONTAINER && QUERY_FLAG (tmp, FLAG_APPLIED) && !strcmp (&tmp->race, type))
1340 if (object *arrow = find_arrow (tmp, type))
1341 {
1342 splay (tmp);
1411 return op; 1343 return arrow;
1344 }
1345
1412 return tmp; 1346 return 0;
1413} 1347}
1414 1348
1415/* 1349/*
1416 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1350 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1417 * against the target. A full test is not performed, simply a basic test 1351 * against the target. A full test is not performed, simply a basic test
1418 * of resistances. The archer is making a quick guess at what he sees down 1352 * of resistances. The archer is making a quick guess at what he sees down
1419 * the hall. Failing that it does it's best to pick the highest plus arrow. 1353 * the hall. Failing that it does it's best to pick the highest plus arrow.
1420 */ 1354 */
1421
1422object * 1355object *
1423find_better_arrow (object *op, object *target, const char *type, int *better) 1356find_better_arrow (object *op, object *target, const char *type, int *better)
1424{ 1357{
1425 object *tmp = NULL, *arrow, *ntmp; 1358 object *tmp = NULL, *arrow, *ntmp;
1426 int attacknum, attacktype, betterby = 0, i; 1359 int attacknum, attacktype, betterby = 0, i;
… …
1441 } 1374 }
1442 } 1375 }
1443 else if (arrow->type == ARROW && arrow->race == type) 1376 else if (arrow->type == ARROW && arrow->race == type)
1444 { 1377 {
1445 /* allways prefer assasination/slaying */ 1378 /* allways prefer assasination/slaying */
1446 if (target->race != NULL && arrow->slaying != NULL && strstr (arrow->slaying, target->race)) 1379 if (target->race && arrow->slaying && strstr (arrow->slaying, target->race))
1447 { 1380 {
1448 if (arrow->attacktype & AT_DEATH) 1381 if (arrow->attacktype & AT_DEATH)
1449 { 1382 {
1450 *better = 100; 1383 *better = 100;
1451 return arrow; 1384 return arrow;
… …
1459 else 1392 else
1460 { 1393 {
1461 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++) 1394 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++)
1462 { 1395 {
1463 attacktype = 1 << attacknum; 1396 attacktype = 1 << attacknum;
1464 if ((arrow->attacktype & attacktype) && (target->arch->clone.resist[attacknum]) < 0) 1397 if ((arrow->attacktype & attacktype) && (target->arch->resist[attacknum]) < 0)
1465 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100) > betterby) 1398 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100) > betterby)
1466 { 1399 {
1467 tmp = arrow; 1400 tmp = arrow;
1468 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100; 1401 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1469 } 1402 }
1470 } 1403 }
1471 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1404 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1472 { 1405 {
1473 tmp = arrow; 1406 tmp = arrow;
… …
1479 betterby = 1 + arrow->magic + arrow->stats.dam; 1412 betterby = 1 + arrow->magic + arrow->stats.dam;
1480 } 1413 }
1481 } 1414 }
1482 } 1415 }
1483 } 1416 }
1417
1484 if (tmp == NULL && arrow == NULL) 1418 if (tmp == NULL && arrow == NULL)
1485 return find_arrow (op, type); 1419 return find_arrow (op, type);
1486 1420
1487 *better = betterby; 1421 *better = betterby;
1488 return tmp; 1422 return tmp;
… …
1492 * find_better_arrow to find a decent arrow to use. 1426 * find_better_arrow to find a decent arrow to use.
1493 * op = the shooter 1427 * op = the shooter
1494 * type = bow->race 1428 * type = bow->race
1495 * dir = fire direction 1429 * dir = fire direction
1496 */ 1430 */
1497
1498object * 1431object *
1499pick_arrow_target (object *op, const char *type, int dir) 1432pick_arrow_target (object *op, const char *type, int dir)
1500{ 1433{
1501 object *tmp = NULL; 1434 object *tmp = NULL;
1502 maptile *m; 1435 maptile *m;
… …
1519 for (i = 0, found = 0; i < 20; i++) 1452 for (i = 0, found = 0; i < 20; i++)
1520 { 1453 {
1521 x += freearr_x[dir]; 1454 x += freearr_x[dir];
1522 y += freearr_y[dir]; 1455 y += freearr_y[dir];
1523 mflags = get_map_flags (m, &m, x, y, &x, &y); 1456 mflags = get_map_flags (m, &m, x, y, &x, &y);
1457
1524 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1458 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1525 { 1459 {
1526 tmp = NULL; 1460 tmp = 0;
1527 break; 1461 break;
1528 } 1462 }
1529 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1463 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1530 { 1464 {
1531 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1465 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1532 * perhaps a bad assumption. 1466 * perhaps a bad assumption.
1533 */ 1467 */
1534 tmp = NULL; 1468 tmp = 0;
1535 break; 1469 break;
1536 } 1470 }
1471
1537 if (mflags & P_IS_ALIVE) 1472 if (mflags & P_IS_ALIVE)
1538 {
1539 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1473 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1540 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1474 if (QUERY_FLAG (tmp, FLAG_ALIVE))
1541 {
1542 found++;
1543 break;
1544 }
1545 if (found)
1546 break; 1475 break;
1547 }
1548 } 1476 }
1549 if (tmp == NULL) 1477
1478 if (!tmp)
1550 return find_arrow (op, type); 1479 return find_arrow (op, type);
1551 1480
1552 if (tmp->head) 1481 if (tmp->head)
1553 tmp = tmp->head; 1482 tmp = tmp->head;
1554 1483
… …
1567 */ 1496 */
1568int 1497int
1569fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy) 1498fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy)
1570{ 1499{
1571 object *left, *bow; 1500 object *left, *bow;
1572 int bowspeed, mflags; 1501 int mflags;
1573 maptile *m; 1502 maptile *m;
1574 1503
1575 if (!dir) 1504 if (!dir)
1576 { 1505 {
1577 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!"); 1506 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!");
1578 return 0; 1507 return 0;
1579 } 1508 }
1580 1509
1581 if (op->type == PLAYER) 1510 if (op->contr)
1582 bow = op->contr->ranges[range_bow]; 1511 bow = op->current_weapon;
1583 else 1512 else
1584 { 1513 {
1585 for (bow = op->inv; bow; bow = bow->below) 1514 for (bow = op->inv; bow; bow = bow->below)
1586 /* Don't check for applied - monsters don't apply bows - in that way, they 1515 /* Don't check for applied - monsters don't apply bows - in that way, they
1587 * don't need to switch back and forth between bows and weapons. 1516 * don't need to switch back and forth between bows and weapons.
… …
1592 if (!bow) 1521 if (!bow)
1593 { 1522 {
1594 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1523 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1595 return 0; 1524 return 0;
1596 } 1525 }
1526
1527 // optimisation: move object to top so we will find it quickly again
1528 if (bow->below)
1529 {
1530 bow->remove ();
1531 op->insert (bow);
1532 }
1597 } 1533 }
1598 1534
1599 if (!bow->race || !bow->skill) 1535 if (!bow->race || !bow->skill)
1600 { 1536 {
1601 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1537 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1602 return 0; 1538 return 0;
1603 } 1539 }
1604
1605 bowspeed = bow->stats.sp + dex_bonus[op->stats.Dex];
1606
1607 /* penalize ROF for bestarrow */
1608 if (op->type == PLAYER && op->contr->bowtype == bow_bestarrow)
1609 bowspeed -= dex_bonus[op->stats.Dex] + 5;
1610
1611 if (bowspeed < 1)
1612 bowspeed = 1;
1613 1540
1614 if (arrow == NULL) 1541 if (arrow == NULL)
1615 { 1542 {
1616 if ((arrow = find_arrow (op, bow->race)) == NULL) 1543 if ((arrow = find_arrow (op, bow->race)) == NULL)
1617 { 1544 {
1618 if (op->type == PLAYER) 1545 if (op->type == PLAYER)
1619 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1546 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1620 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1547 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1621 else 1548 else
1622 CLEAR_FLAG (op, FLAG_READY_BOW); 1549 CLEAR_FLAG (op, FLAG_READY_BOW);
1550
1623 return 0; 1551 return 0;
1624 } 1552 }
1625 } 1553 }
1626 1554
1627 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy); 1555 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy);
… …
1635 } 1563 }
1636 1564
1637 /* this should not happen, but sometimes does */ 1565 /* this should not happen, but sometimes does */
1638 if (arrow->nrof == 0) 1566 if (arrow->nrof == 0)
1639 { 1567 {
1568 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1640 arrow->destroy (); 1569 arrow->destroy ();
1641 return 0; 1570 return 0;
1642 } 1571 }
1643 1572
1644 left = arrow; /* these are arrows left to the player */ 1573 left = arrow; /* these are arrows left to the player */
1645 arrow = get_split_ob (arrow, 1); 1574 arrow = arrow->split ();
1646 if (!arrow) 1575 if (!arrow)
1647 { 1576 {
1648 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1577 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1649 return 0; 1578 return 0;
1650 } 1579 }
1651 1580
1652 arrow->set_owner (op); 1581 arrow->set_owner (op);
1653 arrow->skill = bow->skill; 1582 arrow->skill = bow->skill;
1654 arrow->direction = dir; 1583 arrow->direction = dir;
1655 1584
1585 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1586 arrow->stats.hp = arrow->stats.dam;
1587 arrow->stats.grace = arrow->attacktype;
1588
1589 if (arrow->slaying)
1590 arrow->spellarg = strdup (arrow->slaying);
1591
1592#if 0
1593 if (player *pl = op->contr)
1594 {
1595 float speed = pl->weapon_sp;
1596
1597 /* penalize ROF for bestarrow */
1598 if (pl->bowtype == bow_bestarrow)
1599 speed *= .9f;
1600 else
1601 speed *= 1.f + dex_bonus[op->stats.Dex] * .2f;
1602
1603 op->speed_left += speed - op->speed;
1604 }
1605#endif
1606
1607 SET_ANIMATION (arrow, arrow->direction);
1608
1609 /* update the speed */
1610 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1611 + bow->stats.dam / 7.f;
1612
1613 arrow->set_speed (max (arrow->speed, 2.f));
1614 arrow->speed_left = 0;
1615
1616 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1617
1656 if (op->type == PLAYER) 1618 if (op->type == PLAYER)
1657 { 1619 {
1658 op->speed_left = 0.01 - (float) FABS (op->speed) * 100 / bowspeed;
1659 op->update_stats ();
1660 }
1661
1662 SET_ANIMATION (arrow, arrow->direction);
1663 arrow->stats.sp = arrow->stats.wc; /* save original wc and dam */
1664 arrow->stats.hp = arrow->stats.dam;
1665 arrow->stats.grace = arrow->attacktype;
1666 if (arrow->slaying != NULL)
1667 arrow->spellarg = strdup (arrow->slaying);
1668
1669 /* Note that this was different for monsters - they got their level
1670 * added to the damage. I think the strength bonus is more proper.
1671 */
1672
1673 arrow->stats.dam += (QUERY_FLAG (bow, FLAG_NO_STRENGTH) ? 0 : dam_bonus[op->stats.Str]) + bow->stats.dam + bow->magic + arrow->magic;
1674
1675 /* update the speed */
1676 arrow->speed = (float) ((QUERY_FLAG (bow, FLAG_NO_STRENGTH) ?
1677 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.0 + (float) bow->stats.dam / 7.0;
1678
1679 arrow->set_speed (max (arrow->speed, 1.0));
1680 arrow->speed_left = 0;
1681
1682 if (op->type == PLAYER)
1683 {
1684 arrow->stats.wc = 20 - bow->magic - arrow->magic -
1685 (op->chosen_skill ? op->chosen_skill->level : op->level) -
1686 dex_bonus[op->stats.Dex] - thaco_bonus[op->stats.Str] - arrow->stats.wc - bow->stats.wc + wc_mod;
1687
1688 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level; 1620 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level;
1621 wc -= dex_bonus[op->stats.Dex];
1622
1623 if (!arrow->slaying)
1624 arrow->slaying = op->slaying;
1625
1626 arrow->attacktype |= op->attacktype;
1689 } 1627 }
1690 else 1628 else
1691 { 1629 {
1692 arrow->stats.wc = op->stats.wc - bow->magic - arrow->magic - arrow->stats.wc + wc_mod;
1693 arrow->level = op->level; 1630 arrow->level = op->level;
1694 } 1631 arrow->stats.wc -= bow->magic;
1695 1632
1696 if (arrow->attacktype == AT_PHYSICAL) 1633 if (!arrow->slaying)
1634 arrow->slaying = bow->slaying;
1635
1697 arrow->attacktype |= bow->attacktype; 1636 arrow->attacktype |= bow->attacktype;
1637 }
1698 1638
1699 if (bow->slaying) 1639 wc -= arrow->level;
1700 arrow->slaying = bow->slaying; 1640 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1701 1641
1642 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1702 arrow->move_type = MOVE_FLY_LOW; 1643 arrow->move_type = MOVE_FLY_LOW;
1703 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1644 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1704 1645
1705 play_sound_map (op->map, op->x, op->y, SOUND_FIRE_ARROW); 1646 op->play_sound (sound_find ("fire_arrow"));
1706 m->insert (arrow, sx, sy, op); 1647 m->insert (arrow, sx, sy, op);
1707 1648
1708 if (!arrow->destroyed ()) 1649 if (!arrow->destroyed ())
1709 move_arrow (arrow); 1650 move_arrow (arrow);
1710
1711 if (op->type == PLAYER)
1712 {
1713 if (left->destroyed ())
1714 esrv_del_item (op->contr, left->count);
1715 else
1716 esrv_send_item (op, left);
1717 }
1718 1651
1719 return 1; 1652 return 1;
1720} 1653}
1721 1654
1722/* Special fire code for players - this takes into 1655/* Special fire code for players - this takes into
… …
1727 * hence the function name. 1660 * hence the function name.
1728 */ 1661 */
1729int 1662int
1730player_fire_bow (object *op, int dir) 1663player_fire_bow (object *op, int dir)
1731{ 1664{
1732 int ret = 0, wcmod = 0; 1665 int ret;
1733 1666
1734 if (op->contr->bowtype == bow_bestarrow) 1667 if (op->contr->bowtype == bow_bestarrow)
1735 { 1668 {
1736 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranges[range_bow]->race, dir), dir, 0, op->x, op->y); 1669 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1737 } 1670 }
1738 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1671 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1739 { 1672 {
1740 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1673 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1741 wcmod = -1;
1742
1743 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1674 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1744 } 1675 }
1745 else if (op->contr->bowtype == bow_threewide) 1676 else if (op->contr->bowtype == bow_threewide)
1746 { 1677 {
1747 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1678 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1748 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1679 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]);
1749 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1680 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]);
1750 } 1681 }
1751 else if (op->contr->bowtype == bow_spreadshot) 1682 else if (op->contr->bowtype == bow_spreadshot)
1752 { 1683 {
1753 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1684 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1754 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1685 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1755 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1686 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1756
1757 } 1687 }
1758 else 1688 else
1759 { 1689 {
1760 /* Simple case */ 1690 /* Simple case */
1761 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1691 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1762 } 1692 }
1693
1763 return ret; 1694 return ret;
1764} 1695}
1765
1766 1696
1767/* Fires a misc (wand/rod/horn) object in 'dir'. 1697/* Fires a misc (wand/rod/horn) object in 'dir'.
1768 * Broken apart from 'fire' to keep it more readable. 1698 * Broken apart from 'fire' to keep it more readable.
1769 */ 1699 */
1770void 1700void
1771fire_misc_object (object *op, int dir) 1701fire_misc_object (object *op, int dir)
1772{ 1702{
1773 object *item; 1703 object *item = op->contr->ranged_ob;
1774 1704
1775 if (!op->contr->ranges[range_misc]) 1705 if (!item)
1776 { 1706 {
1777 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied."); 1707 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied.");
1778 return; 1708 return;
1779 } 1709 }
1780 1710
1781 item = op->contr->ranges[range_misc];
1782 if (!item->inv) 1711 if (!item->inv)
1783 { 1712 {
1784 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1713 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1785 return; 1714 return;
1786 } 1715 }
1716
1717 if (!op->change_weapon (item))
1718 return;
1719
1787 if (item->type == WAND) 1720 if (item->type == WAND)
1788 { 1721 {
1789 if (item->stats.food <= 0) 1722 if (item->stats.food <= 0)
1790 { 1723 {
1791 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1724 op->contr->play_sound (sound_find ("wand_poof"));
1792 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0)); 1725 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0));
1726
1793 return; 1727 return;
1794 } 1728 }
1795 } 1729 }
1796 else if (item->type == ROD || item->type == HORN) 1730 else if (item->type == ROD || item->type == HORN)
1797 { 1731 {
1798 if (item->stats.hp < MAX (item->inv->stats.sp, item->inv->stats.grace)) 1732 sint16 spell_sp = MAX (item->inv->stats.sp, item->inv->stats.grace);
1733
1734 // using the maximum of the rods charge allows at least one spell cast
1735 // for a rod or horn, this fixes some broken rods.
1736 if (item->stats.hp < MIN (spell_sp, item->stats.maxhp))
1799 { 1737 {
1800 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1738 op->contr->play_sound (sound_find ("wand_poof"));
1739
1801 if (item->type == ROD) 1740 if (item->type == ROD)
1802 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1741 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1803 else 1742 else
1804 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0)); 1743 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0));
1744
1805 return; 1745 return;
1806 } 1746 }
1807 } 1747 }
1808 1748
1809 if (cast_spell (op, item, dir, item->inv, NULL)) 1749 if (cast_spell (op, item, dir, item->inv, NULL))
1810 { 1750 {
1811 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1751 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1752
1812 if (item->type == WAND) 1753 if (item->type == WAND)
1813 { 1754 {
1814 if (!(--item->stats.food)) 1755 if (!(--item->stats.food))
1815 { 1756 {
1816 object *tmp; 1757 object *tmp;
1817 1758
1818 if (item->arch) 1759 if (item->arch)
1819 { 1760 {
1820 CLEAR_FLAG (item, FLAG_ANIMATE); 1761 CLEAR_FLAG (item, FLAG_ANIMATE);
1821 item->face = item->arch->clone.face; 1762 item->face = item->arch->face;
1822 item->set_speed (0); 1763 item->set_speed (0);
1823 } 1764 }
1824 1765
1825 if ((tmp = item->in_player ())) 1766 if (object *pl = item->visible_to ())
1826 esrv_update_item (UPD_ANIM, tmp, item); 1767 esrv_update_item (UPD_ANIM, pl, item);
1827 } 1768 }
1828 } 1769 }
1829 else if (item->type == ROD || item->type == HORN) 1770 else if (item->type == ROD || item->type == HORN)
1830 drain_rod_charge (item); 1771 drain_rod_charge (item);
1831 } 1772 }
1832} 1773}
1833 1774
1834/* Received a fire command for the player - go and do it. 1775/* Received a fire command for the player - go and do it.
1835 */ 1776 */
1836void 1777bool
1837fire (object *op, int dir) 1778fire (object *op, int dir)
1838{ 1779{
1839 int spellcost = 0; 1780 int spellcost = 0;
1781
1782 player *pl = op->contr;
1783
1784 if (pl->golem)
1785 {
1786 control_golem (op->contr->golem, dir);
1787 return false;
1788 }
1789
1790 object *ob = pl->ranged_ob;
1791
1792 if (!ob)
1793 return false;
1794
1795 if (op->speed_left > 0.f)
1796 --op->speed_left;
1797 else
1798 return false;
1799
1800 if (!op->change_weapon (ob))
1801 return false;
1840 1802
1841 /* check for loss of invisiblity/hide */ 1803 /* check for loss of invisiblity/hide */
1842 if (action_makes_visible (op)) 1804 if (action_makes_visible (op))
1843 make_visible (op); 1805 make_visible (op);
1844 1806
1845 switch (op->contr->shoottype) 1807 switch (ob->type)
1846 { 1808 {
1847 case range_none: 1809 case BOW:
1848 return;
1849
1850 case range_bow:
1851 player_fire_bow (op, dir); 1810 player_fire_bow (op, dir);
1852 return; 1811 break;
1853 1812
1854 case range_magic: /* Casting spells */ 1813 case SPELL:
1855 spellcost = (cast_spell (op, op, dir, op->contr->ranges[range_magic], op->contr->spellparam[0] ? op->contr->spellparam : 0)); 1814 spellcost = cast_spell (op, op, dir, ob, pl->spellparam[0] ? pl->spellparam : 0);
1856 return; 1815 break;
1857 1816
1858 case range_misc: 1817 case BUILDER:
1818 apply_map_builder (op, dir);
1819 break;
1820
1821 case SKILL:
1822 do_skill (op, op, ob, dir, 0);
1823 break;
1824
1825 default:
1859 fire_misc_object (op, dir); 1826 fire_misc_object (op, dir);
1860 return; 1827 break;
1861
1862 case range_golem: /* Control summoned monsters from scrolls */
1863 if (QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
1864 {
1865 op->contr->ranges[range_golem] = 0;
1866 op->contr->shoottype = range_none;
1867 }
1868 else
1869 control_golem (op->contr->ranges[range_golem], dir);
1870 return;
1871
1872 case range_skill:
1873 if (!op->chosen_skill)
1874 {
1875 if (op->type == PLAYER)
1876 new_draw_info (NDI_UNIQUE, 0, op, "You have no applicable skill to use.");
1877 return;
1878 }
1879
1880 do_skill (op, op, op->chosen_skill, dir, NULL);
1881 return;
1882 case range_builder:
1883 apply_map_builder (op, dir);
1884 return;
1885 default:
1886 new_draw_info (NDI_UNIQUE, 0, op, "Illegal shoot type.");
1887 return;
1888 } 1828 }
1889}
1890 1829
1891 1830 return true;
1831}
1892 1832
1893/* find_key 1833/* find_key
1894 * We try to find a key for the door as passed. If we find a key 1834 * We try to find a key for the door as passed. If we find a key
1895 * and successfully use it, we return the key, otherwise NULL 1835 * and successfully use it, we return the key, otherwise NULL
1896 * This function merges both normal and locked door, since the logic 1836 * This function merges both normal and locked door, since the logic
… …
1898 * pl is the player, 1838 * pl is the player,
1899 * inv is the objects inventory to searched 1839 * inv is the objects inventory to searched
1900 * door is the door we are trying to match against. 1840 * door is the door we are trying to match against.
1901 * This function can be called recursively to search containers. 1841 * This function can be called recursively to search containers.
1902 */ 1842 */
1903
1904object * 1843object *
1905find_key (object *pl, object *container, object *door) 1844find_key (object *pl, object *container, object *door)
1906{ 1845{
1907 object *tmp, *key; 1846 object *tmp, *key;
1908 1847
1909 /* Should not happen, but sanity checking is never bad */ 1848 /* Should not happen, but sanity checking is never bad */
1910 if (container->inv == NULL) 1849 if (!container->inv)
1911 return NULL; 1850 return 0;
1912 1851
1913 /* First, lets try to find a key in the top level inventory */ 1852 /* First, lets try to find a key in the top level inventory */
1914 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1853 for (tmp = container->inv; tmp; tmp = tmp->below)
1915 { 1854 {
1916 if (door->type == DOOR && tmp->type == KEY) 1855 if (door->type == DOOR && tmp->type == KEY)
1917 break; 1856 break;
1918 /* For sanity, we should really check door type, but other stuff 1857 /* For sanity, we should really check door type, but other stuff
1919 * (like containers) can be locked with special keys 1858 * (like containers) can be locked with special keys
1920 */ 1859 */
1921 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1860 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1922 break; 1861 break;
1923 } 1862 }
1863
1924 /* No key found - lets search inventories now */ 1864 /* No key found - lets search inventories now */
1925 /* If we find and use a key in an inventory, return at that time. 1865 /* If we find and use a key in an inventory, return at that time.
1926 * otherwise, if we search all the inventories and still don't find 1866 * otherwise, if we search all the inventories and still don't find
1927 * a key, return 1867 * a key, return
1928 */ 1868 */
1929 if (!tmp) 1869 if (!tmp)
1930 { 1870 {
1931 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1871 for (tmp = container->inv; tmp; tmp = tmp->below)
1932 { 1872 {
1933 /* No reason to search empty containers */ 1873 /* No reason to search empty containers */
1934 if (tmp->type == CONTAINER && tmp->inv) 1874 if (tmp->type == CONTAINER && tmp->inv)
1935 { 1875 {
1936 if ((key = find_key (pl, tmp, door)) != NULL) 1876 if ((key = find_key (pl, tmp, door)))
1937 return key; 1877 return key;
1938 } 1878 }
1939 } 1879 }
1880
1940 if (!tmp) 1881 if (!tmp)
1941 return NULL; 1882 return NULL;
1942 } 1883 }
1884
1943 /* We get down here if we have found a key. Now if its in a container, 1885 /* We get down here if we have found a key. Now if its in a container,
1944 * see if we actually want to use it 1886 * see if we actually want to use it
1945 */ 1887 */
1946 if (pl != container) 1888 if (pl != container)
1947 { 1889 {
… …
1968 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1910 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1969 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1911 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1970 return NULL; 1912 return NULL;
1971 } 1913 }
1972 } 1914 }
1915
1973 return tmp; 1916 return tmp;
1974} 1917}
1975 1918
1976/* moved door processing out of move_player_attack. 1919/* moved door processing out of move_player_attack.
1977 * returns 1 if player has opened the door with a key 1920 * returns 1 if player has opened the door with a key
… …
1979 * 0 otherwise 1922 * 0 otherwise
1980 */ 1923 */
1981static int 1924static int
1982player_attack_door (object *op, object *door) 1925player_attack_door (object *op, object *door)
1983{ 1926{
1984 /* If its a door, try to find a use a key. If we do destroy the door, 1927 /* If its a door, try to find a key. If we do destroy the door,
1985 * might as well return immediately as there is nothing more to do - 1928 * might as well return immediately as there is nothing more to do -
1986 * otherwise, we fall through to the rest of the code. 1929 * otherwise, we fall through to the rest of the code.
1987 */ 1930 */
1988 object *key = find_key (op, op, door); 1931 object *key = find_key (op, op, door);
1989 1932
1990 /* IF we found a key, do some extra work */ 1933 /* If we found a key, do some extra work */
1991 if (key) 1934 if (key)
1992 { 1935 {
1993 object *container = key->env; 1936 object *container = key->env;
1994 1937
1995 play_sound_map (op->map, op->x, op->y, SOUND_OPEN_DOOR);
1996 if (action_makes_visible (op)) 1938 if (action_makes_visible (op))
1997 make_visible (op); 1939 make_visible (op);
1940
1998 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP)) 1941 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP))
1999 spring_trap (door->inv, op); 1942 spring_trap (door->inv, op);
1943
2000 if (door->type == DOOR) 1944 if (door->type == DOOR)
2001 {
2002 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */ 1945 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */
2003 }
2004 else if (door->type == LOCKED_DOOR) 1946 else if (door->type == LOCKED_DOOR)
2005 { 1947 {
2006 new_draw_info_format (NDI_UNIQUE, NDI_BROWN, op, "You open the door with the %s", query_short_name (key)); 1948 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN);
2007 remove_door2 (door); /* remove door without violence ;-) */ 1949 remove_door2 (door); /* remove door without violence ;-) */
2008 } 1950 }
1951
2009 /* Do this after we print the message */ 1952 /* Do this after we print the message */
2010 decrease_ob (key); /* Use up one of the keys */ 1953 key->decrease (); /* Use up one of the keys */
2011 /* Need to update the weight the container the key was in */ 1954
2012 if (container != op)
2013 esrv_update_item (UPD_WEIGHT, op, container);
2014 return 1; /* Nothing more to do below */ 1955 return 1; /* Nothing more to do below */
2015 } 1956 }
2016 else if (door->type == LOCKED_DOOR) 1957 else if (door->type == LOCKED_DOOR)
2017 { 1958 {
2018 /* Might as well return now - no other way to open this */ 1959 /* Might as well return now - no other way to open this */
2019 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, door->msg); 1960 op->failmsg (door->msg ? &door->msg : "Hmm, you miss the certain something to open this door...");
2020 return 1; 1961 return 1;
2021 } 1962 }
1963
2022 return 0; 1964 return 0;
2023} 1965}
2024 1966
2025/* This function is just part of a breakup from move_player. 1967/* This function is just part of a breakup from move_player.
2026 * It should keep the code cleaner. 1968 * It should keep the code cleaner.
2027 * When this is called, the players direction has been updated 1969 * When this is called, the players direction has been updated
2028 * (taking into account confusion.) The player is also actually 1970 * (taking into account confusion.) The player is also actually
2029 * going to try and move (not fire weapons). 1971 * going to try and move (not fire weapons).
2030 */ 1972 */
2031void 1973bool
2032move_player_attack (object *op, int dir) 1974move_player_attack (object *op, int dir)
2033{ 1975{
2034 object *tmp, *mon;
2035 sint16 nx, ny;
2036 int on_battleground; 1976 int on_battleground;
2037 maptile *m;
2038 1977
2039 nx = freearr_x[dir] + op->x; 1978 sint16 nx = freearr_x[dir] + op->x;
2040 ny = freearr_y[dir] + op->y; 1979 sint16 ny = freearr_y[dir] + op->y;
2041 1980
2042 on_battleground = op_on_battleground (op, 0, 0); 1981 on_battleground = op_on_battleground (op, 0, 0);
1982
1983 if (out_of_map (op->map, nx, ny))
1984 return false;
1985
1986 if (!op->contr->braced && op->speed_left > 0.f && move_ob (op, dir, op))
1987 {
1988 --op->speed_left;
1989 return true;
1990 }
2043 1991
2044 /* If braced, or can't move to the square, and it is not out of the 1992 /* If braced, or can't move to the square, and it is not out of the
2045 * map, attack it. Note order of if statement is important - don't 1993 * map, attack it. Note order of if statement is important - don't
2046 * want to be calling move_ob if braced, because move_ob will move the 1994 * want to be calling move_ob if braced, because move_ob will move the
2047 * player. This is a pretty nasty hack, because if we could 1995 * player. This is a pretty nasty hack, because if we could
2048 * move to some space, it then means that if we are braced, we should 1996 * move to some space, it then means that if we are braced, we should
2049 * do nothing at all. As it is, if we are braced, we go through 1997 * do nothing at all. As it is, if we are braced, we go through
2050 * quite a bit of processing. However, it probably is less than what 1998 * quite a bit of processing. However, it probably is less than what
2051 * move_ob uses. 1999 * move_ob uses.
2052 */ 2000 */
2053 if ((op->contr->braced || !move_ob (op, dir, op)) && !out_of_map (op->map, nx, ny)) 2001 maptile *m = op->map->xy_find (nx, ny);
2002
2003 /* Go through all the objects, and find ones of interest. Only stop if
2004 * we find a monster - that is something we know we want to attack.
2005 * if its a door or barrel (can roll) see if there may be monsters
2006 * on the space
2007 */
2008 object *mon;
2009 for (mon = m->at (nx, ny).bot; mon; mon = mon->above)
2010 {
2011 if ((mon->flag [FLAG_ALIVE]
2012 || mon->type == LOCKED_DOOR
2013 || mon->flag [FLAG_CAN_ROLL])
2014 && mon != op)
2015 break;
2054 { 2016 }
2055 if (OUT_OF_REAL_MAP (op->map, nx, ny)) 2017
2018 if (!mon) /* This happens anytime the player tries to move */
2019 return false; /* into a wall */
2020
2021 mon = mon->head_ ();
2022
2023 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2024 if (op->contr->weapon_sp_left > 0.f)
2025 if (player_attack_door (op, mon))
2026 {
2027 --op->contr->weapon_sp_left;
2028 return true;
2056 { 2029 }
2057 m = op->map->xy_find (nx, ny); 2030
2058 if (!m) 2031 /* The following deals with possibly attacking peaceful
2059 return; /* Don't think this should happen */ 2032 * or friendly creatures. Basically, all players are considered
2033 * unaggressive. If the moving player has peaceful set, then the
2034 * object should be pushed instead of attacked. It is assumed that
2035 * if you are braced, you will not attack friends accidently,
2036 * and thus will not push them.
2037 */
2038
2039 /* If the creature is a pet, push it even if the player is not
2040 * peaceful. Our assumption is the creature is a pet if the
2041 * player owns it and it is either friendly or unagressive.
2042 */
2043 if (op->type == PLAYER
2044 && ((mon->owner && mon->owner->contr
2045 && same_party (mon->owner->contr->party, op->contr->party))
2046 || mon->owner == op)
2047 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
2048 {
2049 /* If we're braced, we don't want to switch places with it */
2050 if (op->contr->braced)
2051 return false;
2052
2053 if (op->speed_left > 0.f)
2054 {
2055 --op->speed_left;
2056
2057 op->play_sound (sound_find ("push_player"));
2058 push_ob (mon, dir, op);
2059
2060 if (action_makes_visible (op))
2061 make_visible (op);
2062
2063 return true;
2060 } 2064 }
2061 else 2065 else
2062 m = op->map;
2063
2064 if (!(tmp = m->at (nx, ny).bot))
2065 return; 2066 return false;
2067 }
2066 2068
2067 mon = 0;
2068 /* Go through all the objects, and find ones of interest. Only stop if
2069 * we find a monster - that is something we know we want to attack.
2070 * if its a door or barrel (can roll) see if there may be monsters
2071 * on the space
2072 */
2073 while (tmp)
2074 {
2075 if (tmp == op)
2076 {
2077 tmp = tmp->above;
2078 continue;
2079 }
2080
2081 if (QUERY_FLAG (tmp, FLAG_ALIVE))
2082 {
2083 mon = tmp;
2084 break;
2085 }
2086
2087 if (tmp->type == LOCKED_DOOR || QUERY_FLAG (tmp, FLAG_CAN_ROLL))
2088 mon = tmp;
2089
2090 tmp = tmp->above;
2091 }
2092
2093 if (!mon) /* This happens anytime the player tries to move */
2094 return; /* into a wall */
2095
2096 if (mon->head)
2097 mon = mon->head;
2098
2099 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2100 if (player_attack_door (op, mon))
2101 return;
2102
2103 /* The following deals with possibly attacking peaceful
2104 * or frienddly creatures. Basically, all players are considered
2105 * unaggressive. If the moving player has peaceful set, then the
2106 * object should be pushed instead of attacked. It is assumed that
2107 * if you are braced, you will not attack friends accidently,
2108 * and thus will not push them.
2109 */
2110
2111 /* If the creature is a pet, push it even if the player is not
2112 * peaceful. Our assumption is the creature is a pet if the
2113 * player owns it and it is either friendly or unagressive.
2114 */
2115 if ((op->type == PLAYER)
2116#if COZY_SERVER
2117 &&
2118 ((mon->owner && mon->owner->contr
2119 && same_party (mon->owner->contr->party, op->contr->party)) || mon->owner == op)
2120#else
2121 && mon->owner == op
2122#endif
2123 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
2124 {
2125 /* If we're braced, we don't want to switch places with it */
2126 if (op->contr->braced)
2127 return;
2128
2129 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER);
2130 (void) push_ob (mon, dir, op);
2131 if (op->contr->tmp_invis || op->hide)
2132 make_visible (op);
2133
2134 return;
2135 }
2136
2137 /* in certain circumstances, you shouldn't attack friendly 2069 /* in certain circumstances, you shouldn't attack friendly
2138 * creatures. Note that if you are braced, you can't push 2070 * creatures. Note that if you are braced, you can't push
2139 * someone, but put it inside this loop so that you won't 2071 * someone, but put it inside this loop so that you won't
2140 * attack them either. 2072 * attack them either.
2141 */ 2073 */
2142 if ((mon->type == PLAYER || mon->enemy != op) && 2074 if ((mon->type == PLAYER || mon->enemy != op)
2143 (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) && ( 2075 && (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))
2144#ifdef PROHIBIT_PLAYERKILL
2145 (op->contr->peaceful 2076 && ((op->contr->peaceful
2146 || (mon->type == PLAYER 2077 || (mon->type == PLAYER && mon->contr->peaceful))
2147 && mon->contr->
2148 peaceful)) &&
2149#else
2150 op->contr->peaceful &&
2151#endif
2152 !on_battleground)) 2078 && !on_battleground))
2079 {
2080 if (op->speed_left > 0.f)
2153 { 2081 {
2082 --op->speed_left;
2083
2154 if (!op->contr->braced) 2084 if (!op->contr->braced)
2155 { 2085 {
2156 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER); 2086 op->play_sound (sound_find ("push_player"));
2157 push_ob (mon, dir, op); 2087 push_ob (mon, dir, op);
2158 } 2088 }
2159 else 2089 else
2160 new_draw_info (0, 0, op, "You withhold your attack"); 2090 op->statusmsg ("You withhold your attack");
2161 2091
2162 if (op->contr->tmp_invis || op->hide) 2092 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN])
2163 make_visible (op); 2093 make_visible (op);
2164 }
2165 2094
2095 return true;
2096 }
2097 }
2166 /* If the object is a boulder or other rollable object, then 2098 /* If the object is a boulder or other rollable object, then
2167 * roll it if not braced. You can't roll it if you are braced. 2099 * roll it if not braced. You can't roll it if you are braced.
2168 */ 2100 */
2169 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 2101 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced))
2102 {
2103 if (op->speed_left > 0.f)
2170 { 2104 {
2105 --op->speed_left;
2106
2171 recursive_roll (mon, dir, op); 2107 recursive_roll (mon, dir, op);
2172 if (action_makes_visible (op)) 2108 if (action_makes_visible (op))
2173 make_visible (op); 2109 make_visible (op);
2174 }
2175 2110
2111 return true;
2112 }
2113 }
2176 /* Any generic living creature. Including things like doors. 2114 /* Any generic living creature. Including things like doors.
2177 * Way it works is like this: First, it must have some hit points 2115 * Way it works is like this: First, it must have some hit points
2178 * and be living. Then, it must be one of the following: 2116 * and be living. Then, it must be one of the following:
2179 * 1) Not a player, 2) A player, but of a different party. Note 2117 * 1) Not a player, 2) A player, but of a different party. Note
2180 * that party_number -1 is no party, so attacks can still happen. 2118 * that party_number -1 is no party, so attacks can still happen.
2181 */ 2119 */
2182 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 2120 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) &&
2183 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 2121 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2184 { 2122 {
2185 2123 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2186 /* If the player hasn't hit something this tick, and does
2187 * so, give them speed boost based on weapon speed. Doing
2188 * it here is better than process_players2, which basically
2189 * incurred a 1 tick offset.
2190 */
2191 if (!op->contr->has_hit)
2192 { 2124 {
2193 op->speed_left += op->speed / op->contr->weapon_sp; 2125 --op->contr->weapon_sp_left;
2194
2195 op->contr->has_hit = 1; /* The last action was to hit, so use weapon_sp */
2196 }
2197 2126
2198 skill_attack (mon, op, 0, 0, 0); 2127 skill_attack (mon, op, 0, 0, 0);
2199
2200 /* If attacking another player, that player gets automatic
2201 * hitback, and doesn't loose luck either.
2202 * Disable hitback on the battleground or if the target is
2203 * the wiz.
2204 */
2205 if (mon->type == PLAYER && mon->stats.hp >= 0 && !mon->contr->has_hit && !on_battleground && !QUERY_FLAG (mon, FLAG_WIZ))
2206 {
2207 short luck = mon->stats.luck;
2208
2209 mon->contr->has_hit = 1;
2210 skill_attack (op, mon, 0, 0, 0);
2211 mon->stats.luck = luck;
2212 }
2213 2128
2214 if (action_makes_visible (op)) 2129 if (action_makes_visible (op))
2215 make_visible (op); 2130 make_visible (op);
2216 }
2217 } /* if player should attack something */
2218}
2219 2131
2220int 2132 return true;
2133 }
2134 }
2135
2136 return false;
2137}
2138
2139bool
2221move_player (object *op, int dir) 2140move_player (object *op, int dir)
2222{ 2141{
2223 int pick; 2142 int pick;
2224 2143
2225 if (!op->map || op->map->in_memory != MAP_IN_MEMORY) 2144 if (!op->map || op->map->in_memory != MAP_ACTIVE)
2226 return 0; 2145 return 0;
2227 2146
2228 /* Sanity check: make sure dir is valid */ 2147 /* Sanity check: make sure dir is valid */
2229 if ((dir < 0) || (dir >= 9)) 2148 if ((dir < 0) || (dir >= 9))
2230 { 2149 {
… …
2232 return 0; 2151 return 0;
2233 } 2152 }
2234 2153
2235 /* peterm: added following line */ 2154 /* peterm: added following line */
2236 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2155 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir)
2237 dir = absdir (dir + RANDOM () % 3 + RANDOM () % 3 - 2); 2156 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2238 2157
2239 op->facing = dir; 2158 op->facing = dir;
2240 2159
2241 if (op->hide) 2160 if (op->flag [FLAG_HIDDEN])
2242 do_hidden_move (op); 2161 do_hidden_move (op);
2243 2162
2163 bool retval;
2164
2244 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2165 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2245 /*nop */ ; 2166 retval = RESULT_INT (0);
2246 else if (op->contr->fire_on) 2167 else if (op->contr->fire_on)
2247 fire (op, dir); 2168 retval = fire (op, dir);
2248 else 2169 else
2249 { 2170 {
2250 move_player_attack (op, dir); 2171 retval = move_player_attack (op, dir);
2251 pick = check_pick (op); 2172 pick = check_pick (op);
2252 } 2173 }
2253 2174
2254 /* Add special check for newcs players and fire on - this way, the 2175 /* Add special check for newcs players and fire on - this way, the
2255 * server can handle repeat firing. 2176 * server can handle repeat firing.
… …
2262 /* Update how the player looks. Use the facing, so direction may 2183 /* Update how the player looks. Use the facing, so direction may
2263 * get reset to zero. This allows for full animation capabilities 2184 * get reset to zero. This allows for full animation capabilities
2264 * for players. 2185 * for players.
2265 */ 2186 */
2266 animate_object (op, op->facing); 2187 animate_object (op, op->facing);
2267 return 0; 2188
2189 return retval;
2268} 2190}
2269 2191
2270/* This is similar to handle_player, below, but is only used by the 2192/* This is similar to handle_player, below, but is only used by the
2271 * new client/server stuff. 2193 * new client/server stuff.
2272 * This is sort of special, in that the new client/server actually uses 2194 * This is sort of special, in that the new client/server actually uses
2273 * the new speed values for commands. 2195 * the new speed values for commands.
2274 * 2196 *
2275 * Returns true if there are more actions we can do. 2197 * Returns true if there are more actions we can do. Should not do
2198 * many actions in a row, as that would be too unfair to other
2199 * players.
2276 */ 2200 */
2277int 2201bool
2278handle_newcs_player (object *op) 2202handle_newcs_player (object *op)
2279{ 2203{
2280 if (op->contr->hidden)
2281 {
2282 op->invisible = 1000;
2283 /* the socket code flashes the player visible/invisible
2284 * depending on the value of invisible, so we need to
2285 * alternate it here for it to work correctly.
2286 */
2287 if (pticks & 2)
2288 op->invisible--;
2289 }
2290 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2291 {
2292 op->invisible--;
2293 if (!op->invisible)
2294 {
2295 make_visible (op);
2296 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2297 }
2298 }
2299
2300 if (QUERY_FLAG (op, FLAG_SCARED)) 2204 if (QUERY_FLAG (op, FLAG_SCARED))
2301 { 2205 {
2302 flee_player (op); 2206 if (op->speed_left > 0.f)
2303 /* If player is still scared, that is his action for this tick */
2304 if (QUERY_FLAG (op, FLAG_SCARED))
2305 { 2207 {
2306 op->speed_left--; 2208 --op->speed_left;
2209 flee_player (op);
2210
2307 return 0; 2211 return true;
2308 } 2212 }
2213 else
2214 return false;
2309 } 2215 }
2310
2311 /* I've been seeing crashes where the golem has been destroyed, but
2312 * the player object still points to the defunct golem. The code that
2313 * destroys the golem looks correct, and it doesn't always happen, so
2314 * put this in a a workaround to clean up the golem pointer.
2315 */
2316 if (op->contr->ranges[range_golem] && QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
2317 op->contr->ranges[range_golem] = 0;
2318 2216
2319 /* call this here - we also will call this in do_ericserver, but 2217 /* call this here - we also will call this in do_ericserver, but
2320 * the players time has been increased when doericserver has been 2218 * the players time has been increased when doericserver has been
2321 * called, so we recheck it here. 2219 * called, so we recheck it here.
2322 */ 2220 */
2323 if (op->contr->ns->handle_command ()) 2221 if (op->contr->ns->handle_command ())
2324 return 1; 2222 return true;
2325 2223
2326 if (op->speed_left > 0)
2327 {
2328 if (op->direction && (op->contr->run_on || op->contr->fire_on)) 2224 if (op->direction && (op->contr->run_on || op->contr->fire_on))
2329 {
2330 /* All move commands take 1 tick, at least for now */
2331 op->speed_left--;
2332
2333 /* Instead of all the stuff below, let move_player take care
2334 * of it. Also, some of the skill stuff is only put in
2335 * there, as well as the confusion stuff.
2336 */
2337 move_player (op, op->direction); 2225 return move_player (op, op->direction);
2338 2226
2339 return op->speed_left > 0;
2340 }
2341 }
2342
2343 return 0; 2227 return false;
2344} 2228}
2345 2229
2346int 2230int
2347save_life (object *op) 2231save_life (object *op)
2348{ 2232{
… …
2350 return 0; 2234 return 0;
2351 2235
2352 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2236 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2353 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2237 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE))
2354 { 2238 {
2355 play_sound_map (op->map, op->x, op->y, SOUND_OB_EVAPORATE); 2239 op->play_sound (sound_find ("ob_evaporate"));
2356 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2240 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2357
2358 if (op->contr)
2359 esrv_del_item (op->contr, tmp->count);
2360 2241
2361 tmp->destroy (); 2242 tmp->destroy ();
2362 CLEAR_FLAG (op, FLAG_LIFESAVE); 2243 CLEAR_FLAG (op, FLAG_LIFESAVE);
2363 2244
2364 if (op->stats.hp < 0) 2245 if (op->stats.hp < 0)
… …
2377 return 0; 2258 return 0;
2378} 2259}
2379 2260
2380/* This goes throws the inventory and removes unpaid objects, and puts them 2261/* This goes throws the inventory and removes unpaid objects, and puts them
2381 * back in the map (location and map determined by values of env). This 2262 * back in the map (location and map determined by values of env). This
2382 * function will descend into containers. op is the object to start the search 2263 * function will descend into containers. op is the object to start the search
2383 * from. 2264 * from.
2384 */ 2265 */
2266static void
2267drop_unpaid_items (object *op, object *env)
2268{
2269 while (op)
2270 {
2271 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2272
2273 if (QUERY_FLAG (op, FLAG_UNPAID))
2274 op->insert_at (env);
2275 else if (op->inv)
2276 drop_unpaid_items (op->inv, env);
2277
2278 op = next;
2279 }
2280}
2281
2385void 2282void
2386remove_unpaid_objects (object *op, object *env) 2283object::drop_unpaid_items ()
2387{ 2284{
2388 object *next; 2285 if (!flag [FLAG_REMOVED])
2389 2286 ::drop_unpaid_items (inv, this);
2390 while (op)
2391 {
2392 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2393
2394 if (QUERY_FLAG (op, FLAG_UNPAID))
2395 {
2396 if (env->type == PLAYER)
2397 esrv_del_item (env->contr, op->count);
2398
2399 op->insert_at (env);
2400 }
2401 else if (op->inv)
2402 remove_unpaid_objects (op->inv, env);
2403
2404 op = next;
2405 }
2406} 2287}
2407 2288
2408/* 2289/*
2409 * Returns pointer a static string containing gravestone text 2290 * Returns pointer a static string containing gravestone text
2410 * Moved from apply.c to player.c - player.c is what 2291 * Moved from apply.c to player.c - player.c is what
2411 * actually uses this function. player.c may not be quite the 2292 * actually uses this function. player.c may not be quite the
2412 * best, a misc file for object actions is probably better, 2293 * best, a misc file for object actions is probably better,
2413 * but there isn't one in the server directory. 2294 * but there isn't one in the server directory.
2414 */ 2295 */
2415char * 2296const char *
2416gravestone_text (object *op) 2297gravestone_text (object *op)
2417{ 2298{
2418 static char buf2[MAX_BUF]; 2299 static dynbuf_text buf;
2419 char buf[MAX_BUF];
2420 time_t now = time (NULL);
2421 2300
2422 strcpy (buf2, " R.I.P.\n\n"); 2301 buf << "---- R.I.P. ----\n\n"
2302 << op->name;
2303
2423 if (op->type == PLAYER) 2304 if (op->type == PLAYER)
2424 sprintf (buf, "%s the %s\n", &op->name, op->contr->title); 2305 buf << " the " << op->contr->title;
2425 else
2426 sprintf (buf, "%s\n", &op->name);
2427 2306
2428 strncat (buf2, " ", 20 - strlen (buf) / 2); 2307 buf << "\n\n";
2429 strcat (buf2, buf); 2308
2309 buf << "who was level ";
2310 buf << (sint32)op->level << "\n\n" // OO breakdown
2311 << " when " << (op->contr ? "killed" : "died") << "\n\n";
2312
2430 if (op->type == PLAYER) 2313 if (op->type == PLAYER)
2431 sprintf (buf, "who was in level %d when killed\n", op->level); 2314 buf << "by " << op->contr->killer_name () << ".\n\n";
2432 else
2433 sprintf (buf, "who was in level %d when died.\n\n", op->level);
2434 2315
2435 strncat (buf2, " ", 20 - strlen (buf) / 2);
2436 strcat (buf2, buf);
2437 if (op->type == PLAYER)
2438 { 2316 {
2439 sprintf (buf, "by %s.\n\n", op->contr->killer); 2317 static char buf2[128];
2440 strncat (buf2, " ", 21 - strlen (buf) / 2); 2318 time_t now = time (NULL);
2441 strcat (buf2, buf);
2442 }
2443
2444 strftime (buf, MAX_BUF, "%b %d %Y\n", localtime (&now)); 2319 strftime (buf2, 128, "%b %d %Y\n\n", localtime (&now));
2445 strncat (buf2, " ", 20 - strlen (buf) / 2); 2320 buf << buf2;
2446 strcat (buf2, buf); 2321 }
2447 2322
2448 return buf2; 2323 return buf;
2449} 2324}
2450 2325
2451void 2326void
2452do_some_living (object *op) 2327do_some_living (object *op)
2453{ 2328{
… …
2460 int rate_grace = 2000; 2335 int rate_grace = 2000;
2461 const int max_hp = 1; 2336 const int max_hp = 1;
2462 const int max_sp = 1; 2337 const int max_sp = 1;
2463 const int max_grace = 1; 2338 const int max_grace = 1;
2464 2339
2465 if (op->contr->outputs_sync) 2340 if (op->contr->hidden)
2341 {
2342 op->invisible = 1000;
2343 /* the socket code flashes the player visible/invisible
2344 * depending on the value of invisible, so we need to
2345 * alternate it here for it to work correctly.
2346 */
2347 if (pticks & 2)
2348 op->invisible--;
2466 { 2349 }
2467 for (i = 0; i < NUM_OUTPUT_BUFS; i++) 2350 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2468 if (op->contr->outputs[i].buf && (op->contr->outputs[i].first_update + op->contr->outputs_sync) < (uint16) pticks) 2351 {
2469 flush_output_element (op, &op->contr->outputs[i]); 2352 if (!op->invisible--)
2353 {
2354 make_visible (op);
2355 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2356 }
2470 } 2357 }
2471 2358
2472 if (op->contr->ns->state == ST_PLAYING) 2359 if (op->contr->ns->state == ST_PLAYING)
2473 { 2360 {
2474 /* these next three if clauses make it possible to SLOW DOWN 2361 /* these next three if clauses make it possible to SLOW DOWN
… …
2493 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace; 2380 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace;
2494 else 2381 else
2495 { 2382 {
2496 gen_grace = op->stats.maxgrace; 2383 gen_grace = op->stats.maxgrace;
2497 rate_grace -= rate_grace / 2 * op->contr->gen_grace; 2384 rate_grace -= rate_grace / 2 * op->contr->gen_grace;
2498 }
2499
2500 /* Regenerate Spell Points */
2501 if (op->contr->ranges[range_golem] == NULL && --op->last_sp < 0)
2502 {
2503 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2504 if (op->stats.sp < op->stats.maxsp)
2505 {
2506 op->stats.sp++;
2507 /* dms do not consume food */
2508 if (!QUERY_FLAG (op, FLAG_WIZ))
2509 {
2510 op->stats.food--;
2511 if (op->contr->digestion < 0)
2512 op->stats.food += op->contr->digestion;
2513 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2514 op->stats.food = last_food;
2515 }
2516 }
2517
2518 if (max_sp > 1)
2519 {
2520 over_sp = (gen_sp + 10) / rate_sp;
2521 if (over_sp > 0)
2522 {
2523 if (op->stats.sp < op->stats.maxsp)
2524 {
2525 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2526
2527 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2528 op->stats.sp--;
2529
2530 if (op->stats.sp > op->stats.maxsp)
2531 op->stats.sp = op->stats.maxsp;
2532 }
2533 op->last_sp = 0;
2534 }
2535 else
2536 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2537 }
2538 else
2539 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2540 } 2385 }
2541 2386
2542 /* Regenerate Grace */ 2387 /* Regenerate Grace */
2543 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */ 2388 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */
2544 if (--op->last_grace < 0) 2389 if (--op->last_grace < 0)
… …
2565 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2410 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2566 } 2411 }
2567 /* wearing stuff doesn't detract from grace generation. */ 2412 /* wearing stuff doesn't detract from grace generation. */
2568 } 2413 }
2569 2414
2415 if (op->stats.food > 0)
2416 {
2570 /* Regenerate Hit Points */ 2417 /* Regenerate Spell Points */
2571 if (--op->last_heal < 0) 2418 if (!op->contr->golem && --op->last_sp < 0)
2572 {
2573 if (op->stats.hp < op->stats.maxhp)
2574 { 2419 {
2575 op->stats.hp++; 2420 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2576 /* dms do not consume food */ 2421
2577 if (!QUERY_FLAG (op, FLAG_WIZ)) 2422 if (op->stats.sp < op->stats.maxsp)
2578 { 2423 {
2424 op->stats.sp++;
2425
2426 /* dms do not consume food */
2427 if (!QUERY_FLAG (op, FLAG_WIZ))
2428 {
2579 op->stats.food--; 2429 op->stats.food--;
2430
2580 if (op->contr->digestion < 0) 2431 if (op->contr->digestion < 0)
2581 op->stats.food += op->contr->digestion; 2432 op->stats.food += op->contr->digestion;
2582 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2433 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2583 op->stats.food = last_food; 2434 op->stats.food = last_food;
2435 }
2584 } 2436 }
2585 }
2586 2437
2587 if (max_hp > 1) 2438 if (max_sp > 1)
2588 {
2589 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2590 if (over_hp > 0)
2591 { 2439 {
2592 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2440 over_sp = (gen_sp + 10) / rate_sp;
2441 if (over_sp > 0)
2442 {
2443 if (op->stats.sp < op->stats.maxsp)
2444 {
2445 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2446
2447 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2448 op->stats.sp--;
2449
2450 if (op->stats.sp > op->stats.maxsp)
2451 op->stats.sp = op->stats.maxsp;
2452 }
2453
2593 op->last_heal = 0; 2454 op->last_sp = 0;
2455 }
2456 else
2457 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2594 } 2458 }
2595 else 2459 else
2460 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2461 }
2462
2463 /* Regenerate Hit Points */
2464 if (--op->last_heal < 0)
2465 {
2466 if (op->stats.hp < op->stats.maxhp)
2596 { 2467 {
2597 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2468 op->stats.hp++;
2469
2470 /* dms do not consume food */
2471 if (!QUERY_FLAG (op, FLAG_WIZ))
2472 {
2473 op->stats.food--;
2474
2475 if (op->contr->digestion < 0)
2476 op->stats.food += op->contr->digestion;
2477 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2478 op->stats.food = last_food;
2479 }
2598 } 2480 }
2481
2482 if (max_hp > 1)
2483 {
2484 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2485
2486 if (over_hp > 0)
2487 {
2488 op->stats.sp += over_hp + (rndm (rate_hp) > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0;
2489 op->last_heal = 0;
2490 }
2491 else
2492 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2599 } 2493 }
2600 else 2494 else
2601 {
2602 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2495 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2603 } 2496 }
2604 } 2497 }
2605 2498
2606 /* Digestion */ 2499 /* Digestion */
2607 if (--op->last_eat < 0) 2500 if (--op->last_eat < 0)
2608 { 2501 {
2609#ifdef COZY_SERVER 2502 int bonus = max (0, op->contr->digestion),
2610 int dg = op->contr->digestion >= 0 && op->contr->digestion < 2 ? 2 : op->contr->digestion; 2503 penalty = max (0, -op->contr->digestion);
2611 int bonus = dg > 0 ? dg : 0, penalty = dg < 0 ? -dg : 0;
2612#else
2613 int bonus = op->contr->digestion > 0 ? op->contr->digestion : 0, penalty = op->contr->digestion < 0 ? -op->contr->digestion : 0;
2614#endif
2615 2504
2616 if (op->contr->gen_hp > 0)
2617 op->last_eat = 25 * (1 + bonus) / (op->contr->gen_hp + penalty + 1); 2505 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2618 else
2619 op->last_eat = 25 * (1 + bonus) / (penalty + 1);
2620 2506
2621 /* dms do not consume food */ 2507 /* dms do not consume food */
2622 if (!QUERY_FLAG (op, FLAG_WIZ)) 2508 if (!QUERY_FLAG (op, FLAG_WIZ))
2623 op->stats.food--; 2509 op->stats.food--;
2624 } 2510 }
2625 2511
2626 if (op->stats.food < 0 && op->stats.hp >= 0) 2512 if (op->stats.food < 0 && op->stats.hp >= 0)
2627 { 2513 {
2628 object *tmp, *flesh = 0; 2514 object *flesh = 0;
2629 2515
2630 for (tmp = op->inv; tmp; tmp = tmp->below) 2516 for_inv_removable (op, tmp)
2631 { 2517 {
2632 if (!QUERY_FLAG (tmp, FLAG_UNPAID)) 2518 if (QUERY_FLAG (tmp, FLAG_UNPAID))
2519 continue;
2520
2521 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2633 { 2522 {
2634 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2523 op->statusmsg ("You blindly grab for a bite of food. "
2635 { 2524 "H<To prevent you from starving, you ate some random item from your backpack.>");
2636 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food.");
2637 manual_apply (op, tmp, 0); 2525 manual_apply (op, tmp, 0);
2526
2638 if (op->stats.food >= 0 || op->stats.hp < 0) 2527 if (op->stats.food >= 0 || op->stats.hp < 0)
2639 break; 2528 break;
2640 } 2529 }
2641 else if (tmp->type == FLESH) 2530 else if (tmp->type == FLESH)
2642 flesh = tmp; 2531 flesh = tmp;
2643 } /* End if paid for object */ 2532 }
2644 } /* end of for loop */
2645 2533
2646 /* If player is still starving, it means they don't have any food, so 2534 /* If player is still starving, it means they don't have any food, so
2647 * eat flesh instead. 2535 * eat flesh instead.
2648 */ 2536 */
2649 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2537 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2650 { 2538 {
2651 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2539 op->statusmsg ("You blindly grab for a bite of food. "
2540 "H<To prevent you from starving, you ate some random item from your backpack.>");
2652 manual_apply (op, flesh, 0); 2541 manual_apply (op, flesh, 0);
2653 } 2542 }
2543
2544 // If player is still starving, alert him!
2545 if (op->stats.food < 0)
2546 op->failmsg ("You are starving! "
2547 "H<Eat some food to increase your food and prevent you from an untimely death.>");
2548 }
2549
2550 if (op->stats.food < 0)
2654 } 2551 {
2552 op->stats.hp += op->stats.food;
2553 op->stats.food = 0;
2655 2554
2656 while (op->stats.food < 0 && op->stats.hp >= 0) 2555 if (op->stats.hp < 0)
2657 op->stats.food++, op->stats.hp--; 2556 {
2557 op->contr->killer = archetype::get ("killer_starvation");
2558 op->contr->killer->destroy ();
2559 }
2560 }
2658 2561
2562 /* killer should be set here already */
2659 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2563 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ))
2660 kill_player (op); 2564 kill_player (op);
2661 } 2565 }
2662} 2566}
2663 2567
… …
2667 * file. 2571 * file.
2668 */ 2572 */
2669void 2573void
2670kill_player (object *op) 2574kill_player (object *op)
2671{ 2575{
2576 int x, y;
2672 char buf[MAX_BUF]; 2577 char buf[MAX_BUF];
2673 int x, y;
2674
2675 //int i;
2676 maptile *map; /* this is for resurrection */ 2578 maptile *map; /* this is for resurrection */
2677
2678 /* int z;
2679 int num_stats_lose;
2680 int lost_a_stat;
2681 int lose_this_stat;
2682 int this_stat; */
2683 int will_kill_again; 2579 int will_kill_again;
2684 archetype *at; 2580 archetype *at;
2685 object *tmp; 2581 object *tmp;
2686 2582
2687 if (save_life (op)) 2583 if (save_life (op))
2688 return; 2584 return;
2689
2690 2585
2691 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2586 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2692 * in cities ONLY!!! It is very important that this doesn't get abused. 2587 * in cities ONLY!!! It is very important that this doesn't get abused.
2693 * Look at op_on_battleground() for more info --AndreasV 2588 * Look at op_on_battleground() for more info --AndreasV
2694 */ 2589 */
… …
2710 { 2605 {
2711 tmp->destroy (); 2606 tmp->destroy ();
2712 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer"); 2607 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2713 } 2608 }
2714 2609
2715 cure_disease (op, 0); /* remove any disease */ 2610 cure_disease (op, 0, 0); /* remove any disease */
2716 op->stats.hp = op->stats.maxhp; 2611 op->stats.hp = op->stats.maxhp;
2717 if (op->stats.food <= 0) 2612 if (op->stats.food <= 0)
2718 op->stats.food = 999; 2613 op->stats.food = 999;
2719 2614
2720 /* create a bodypart-trophy to make the winner happy */ 2615 /* create a bodypart-trophy to make the winner happy */
2721 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2616 if (object *tmp = arch_to_object (archetype::find ("finger")))
2722 { 2617 {
2723 sprintf (buf, "%s's finger", &op->name); 2618 tmp->name = format ("%s's finger" , &op->name);
2724 tmp->name = buf; 2619 tmp->name_pl = format ("%s's fingers", &op->name);
2725 sprintf (buf, " This finger has been cut off %s\n"
2726 " the %s, when he was defeated at\n level %d by %s.\n",
2727 &op->name, op->contr->title, (int) (op->level), op->contr->killer);
2728 tmp->msg = buf; 2620 tmp->msg = format (
2621 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2622 &op->name, op->contr->title,
2623 (int)op->level,
2624 op->contr->killer_name ()
2625 );
2729 tmp->value = 0, tmp->material = 0, tmp->type = 0; 2626 tmp->value = 0, tmp->type = 0;
2730 tmp->materialname = NULL; 2627 tmp->materialname = "organics";
2731 tmp->insert_at (op, tmp); 2628 tmp->insert_at (op, tmp);
2732 } 2629 }
2733 2630
2734 /* teleport defeated player to new destination */ 2631 /* teleport defeated player to new destination */
2735 transfer_ob (op, x, y, 0, NULL); 2632 transfer_ob (op, x, y, 0, NULL);
… …
2739 2636
2740 INVOKE_PLAYER (DEATH, op->contr); 2637 INVOKE_PLAYER (DEATH, op->contr);
2741 2638
2742 command_kill_pets (op, 0); 2639 command_kill_pets (op, 0);
2743 2640
2744 if (op->stats.food < 0) 2641 op->contr->play_sound (sound_find ("player_dies"));
2745 {
2746 sprintf (buf, "%s starved to death.", &op->name);
2747 strcpy (op->contr->killer, "starvation");
2748 }
2749 else
2750 sprintf (buf, "%s died.", &op->name);
2751
2752 play_sound_player_only (op->contr, SOUND_PLAYER_DIES, 0, 0);
2753 2642
2754 /* save the map location for corpse, gravestone */ 2643 /* save the map location for corpse, gravestone */
2755 x = op->x; 2644 x = op->x;
2756 y = op->y; 2645 y = op->y;
2757 map = op->map; 2646 map = op->map;
… …
2785 2674
2786 lost_a_stat = 0; 2675 lost_a_stat = 0;
2787 2676
2788 for (z = 0; z < num_stats_lose; z++) 2677 for (z = 0; z < num_stats_lose; z++)
2789 { 2678 {
2790 i = RANDOM () % NUM_STATS; 2679 i = rndm (NUM_STATS);
2791 2680
2792 if (settings.stat_loss_on_death) 2681 if (settings.stat_loss_on_death)
2793 { 2682 {
2794 /* Pick a random stat and take a point off it. Tell the player 2683 /* Pick a random stat and take a point off it. Tell the player
2795 * what he lost. 2684 * what he lost.
… …
2864 lost_a_stat = 1; 2753 lost_a_stat = 1;
2865 } 2754 }
2866 } 2755 }
2867 } 2756 }
2868 } 2757 }
2758
2869 /* If no stat lost, tell the player. */ 2759 /* If no stat lost, tell the player. */
2870 if (!lost_a_stat) 2760 if (!lost_a_stat)
2871 { 2761 {
2872 /* determine_god() seems to not work sometimes... why is this? 2762 /* determine_god() seems to not work sometimes... why is this?
2873 Should I be using something else? GD */ 2763 Should I be using something else? GD */
… …
2877 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2767 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god);
2878 else 2768 else
2879 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2769 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you.");
2880 } 2770 }
2881#else 2771#else
2882 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you" " feel a holy presence protecting you from losing yourself completely."); 2772 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you from losing yourself completely.");
2883#endif 2773#endif
2884 2774
2885 /* Put a gravestone up where the character 'almost' died. List the 2775 /* Put a gravestone up where the character 'almost' died. List the
2886 * exp loss on the stone. 2776 * exp loss on the stone.
2887 */ 2777 */
2888 tmp = arch_to_object (archetype::find ("gravestone")); 2778 tmp = arch_to_object (archetype::find ("gravestone"));
2889 sprintf (buf, "%s's gravestone", &op->name); 2779 tmp->name = format ("%s's gravestone", &op->name);
2890 tmp->name = buf; 2780 tmp->name_pl = format ("%s's gravestones", &op->name);
2891 sprintf (buf, "%s's gravestones", &op->name); 2781 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2892 tmp->name_pl = buf; 2782 &op->name, op->contr->title, op->contr->killer_name ());
2893 sprintf (buf, "RIP\nHere rests the hero %s the %s,\n" "who was killed\n" "by %s.\n", &op->name, op->contr->title, op->contr->killer);
2894 tmp->msg = buf;
2895 tmp->x = op->x, tmp->y = op->y; 2783 tmp->x = op->x, tmp->y = op->y;
2896 insert_ob_in_map (tmp, op->map, NULL, 0); 2784 insert_ob_in_map (tmp, op->map, NULL, 0);
2897 2785
2898 /**************************************/ 2786 /**************************************/
2899 /* */ 2787 /* */
… …
2920 { 2808 {
2921 tmp->destroy (); 2809 tmp->destroy ();
2922 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer"); 2810 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2923 } 2811 }
2924 2812
2925 cure_disease (op, 0); /* remove any disease */ 2813 cure_disease (op, 0, 0); /* remove any disease */
2814
2815 // remove all spell effects that are active
2816 // to avoid long-term effects such as word-of-recall
2817 for (object *item = op->inv; item; )
2818 {
2819 object *next = item->below;
2820
2821 if (item->type == SPELL_EFFECT && item->active)
2822 item->destroy ();
2823
2824 item = next;
2825 }
2926 2826
2927 /*add_exp(op, (op->stats.exp * -0.20)); */ 2827 /*add_exp(op, (op->stats.exp * -0.20)); */
2928 apply_death_exp_penalty (op); 2828 apply_death_exp_penalty (op);
2829
2929 if (op->stats.food < 100) 2830 if (op->stats.food < 100)
2930 op->stats.food = 900; 2831 op->stats.food = 900;
2832
2931 op->stats.hp = op->stats.maxhp; 2833 op->stats.hp = op->stats.maxhp;
2932 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp); 2834 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2933 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace); 2835 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2934 2836
2935 /* 2837 /*
2936 * Check to see if the player is in a shop. IF so, then check to see if
2937 * the player has any unpaid items. If so, remove them and put them back 2838 * Check to see if the player has any unpaid items. If so, remove them
2938 * in the map. 2839 * and put them back in the map.
2939 */ 2840 */
2940 2841 op->drop_unpaid_items ();
2941 if (is_in_shop (op))
2942 remove_unpaid_objects (op->inv, op);
2943 2842
2944 /****************************************/ 2843 /****************************************/
2945 /* */ 2844 /* */
2946 /* Move player to his current respawn- */ 2845 /* Move player to his current respawn- */
2947 /* position (usually last savebed) */ 2846 /* position (usually last savebed) */
… …
2967 object *force; 2866 object *force;
2968 int at; 2867 int at;
2969 2868
2970 force = get_archetype (FORCE_NAME); 2869 force = get_archetype (FORCE_NAME);
2971 /* 50 ticks should be enough time for the spell to abate */ 2870 /* 50 ticks should be enough time for the spell to abate */
2972 force->speed = 0.1; 2871 force->speed = 0.1f;
2973 force->speed_left = -5.0; 2872 force->speed_left = -5.f;
2974 SET_FLAG (force, FLAG_APPLIED); 2873 SET_FLAG (force, FLAG_APPLIED);
2975 for (at = 0; at < NROFATTACKS; at++) 2874 for (at = 0; at < NROFATTACKS; at++)
2976 if (will_kill_again & (1 << at)) 2875 if (will_kill_again & (1 << at))
2977 force->resist[at] = 100; 2876 force->resist[at] = 100;
2978 2877
2979 insert_ob_in_ob (force, op); 2878 insert_ob_in_ob (force, op);
2980 op->update_stats (); 2879 op->update_stats ();
2981
2982 } 2880 }
2983 2881
2984 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2882 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED.");
2985} 2883}
2986 2884
2987void 2885void
2988loot_object (object *op) 2886loot_object (object *op)
2989{ /* Grab and destroy some treasure */ 2887{ /* Grab and destroy some treasure */
2990 object *tmp, *tmp2, *next; 2888 object *tmp, *tmp2, *next;
2991 2889
2992 if (op->container) 2890 op->close_container (); /* close open sack first */
2993 esrv_apply_container (op, op->container); /* close open sack first */
2994 2891
2995 for (tmp = op->inv; tmp; tmp = next) 2892 for (tmp = op->inv; tmp; tmp = next)
2996 { 2893 {
2997 next = tmp->below; 2894 next = tmp->below;
2998 2895
2999 if (tmp->invisible) 2896 if (tmp->invisible)
3000 continue; 2897 continue;
3001 2898
3002 tmp->remove (); 2899 tmp->remove ();
3003 tmp->x = op->x, tmp->y = op->y; 2900 tmp->x = op->x, tmp->y = op->y;
2901
3004 if (tmp->type == CONTAINER) 2902 if (tmp->type == CONTAINER)
3005 { /* empty container to ground */ 2903 loot_object (tmp); /* empty container to ground */
3006 loot_object (tmp); 2904
3007 }
3008 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(RANDOM () % 3))) 2905 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3))))
3009 { 2906 {
3010 if (tmp->nrof > 1) 2907 if (tmp->nrof > 1)
3011 { 2908 {
3012 tmp2 = get_split_ob (tmp, 1 + RANDOM () % (tmp->nrof - 1)); 2909 tmp->decrease (rndm (1, tmp->nrof - 1));
3013 tmp2->destroy ();
3014 insert_ob_in_map (tmp, op->map, NULL, 0); 2910 insert_ob_in_map (tmp, op->map, NULL, 0);
3015 } 2911 }
3016 else 2912 else
3017 tmp->destroy (); 2913 tmp->destroy ();
3018 } 2914 }
… …
3024/* 2920/*
3025 * fix_weight(): Check recursively the weight of all players, and fix 2921 * fix_weight(): Check recursively the weight of all players, and fix
3026 * what needs to be fixed. Refresh windows and fix speed if anything 2922 * what needs to be fixed. Refresh windows and fix speed if anything
3027 * was changed. 2923 * was changed.
3028 */ 2924 */
3029
3030void 2925void
3031fix_weight (void) 2926fix_weight (void)
3032{ 2927{
3033 for_all_players (pl) 2928 for_all_players (pl)
3034 { 2929 {
3035 int old = pl->ob->carrying, sum = sum_weight (pl->ob); 2930 sint32 old = pl->ob->carrying;
3036 2931
3037 if (old == sum) 2932 pl->ob->update_weight ();
3038 continue; 2933
2934 if (old != pl->ob->carrying)
2935 {
3039 pl->ob->update_stats (); 2936 pl->ob->update_stats ();
3040 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, old, sum); 2937 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, (int)old, (int)pl->ob->carrying);
2938 }
3041 } 2939 }
3042} 2940}
3043 2941
3044void 2942void
3045fix_luck (void) 2943fix_luck (void)
… …
3087} 2985}
3088 2986
3089void 2987void
3090make_visible (object *op) 2988make_visible (object *op)
3091{ 2989{
3092 op->hide = 0; 2990 op->flag [FLAG_HIDDEN] = 0;
3093 op->invisible = 0; 2991 op->invisible = 0;
2992
3094 if (op->type == PLAYER) 2993 if (op->type == PLAYER)
3095 { 2994 {
3096 op->contr->tmp_invis = 0; 2995 op->contr->tmp_invis = 0;
3097 op->contr->invis_race = 0; 2996 op->contr->invis_race = 0;
3098 } 2997 }
2998
3099 update_object (op, UP_OBJ_FACE); 2999 update_object (op, UP_OBJ_CHANGE);
3100} 3000}
3101 3001
3102int 3002int
3103is_true_undead (object *op) 3003is_true_undead (object *op)
3104{ 3004{
3105 object *tmp = NULL;
3106
3107 if (QUERY_FLAG (&op->arch->clone, FLAG_UNDEAD)) 3005 if (QUERY_FLAG (op->arch, FLAG_UNDEAD))
3108 return 1; 3006 return 1;
3109 3007
3110 return 0; 3008 return 0;
3111} 3009}
3112 3010
3113/* look at the surrounding terrain to determine 3011/* look at the surrounding terrain to determine
3114 * the hideability of this object. Positive levels 3012 * the hideability of this object. Positive levels
3115 * indicate greater hideability. 3013 * indicate greater hideability.
3116 */ 3014 */
3117
3118int 3015int
3119hideability (object *ob) 3016hideability (object *ob)
3120{ 3017{
3121 int i, level = 0, mflag; 3018 int i, level = 0, mflag;
3122 sint16 x, y; 3019 sint16 x, y;
3123 3020
3124 if (!ob || !ob->map) 3021 if (!ob || !ob->map)
3125 return 0; 3022 return 0;
3126 3023
3127 /* so, on normal lighted maps, its hard to hide */ 3024 /* so, on normal lighted maps, its hard to hide */
3128 level = ob->map->darkness - 2; 3025 level = ob->map->darklevel () - 2;
3129 3026
3130 /* this also picks up whether the object is glowing. 3027 /* this also picks up whether the object is glowing.
3131 * If you carry a light on a non-dark map, its not 3028 * If you carry a light on a non-dark map, its not
3132 * as bad as carrying a light on a pitch dark map */ 3029 * as bad as carrying a light on a pitch dark map */
3133 if (has_carried_lights (ob)) 3030 if (has_carried_lights (ob))
3134 level = -(10 + (2 * ob->map->darkness)); 3031 level = -(10 + (2 * ob->map->darklevel ()));
3135 3032
3136 /* scan through all nearby squares for terrain to hide in */ 3033 /* scan through all nearby squares for terrain to hide in */
3137 for (i = 0, x = ob->x, y = ob->y; i < 9; i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 3034 for (i = 0, x = ob->x, y = ob->y;
3035 i <= SIZEOFFREE1;
3036 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
3138 { 3037 {
3139 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 3038 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3140 if (mflag & P_OUT_OF_MAP) 3039 if (mflag & P_OUT_OF_MAP)
3141 {
3142 continue; 3040 continue;
3143 } 3041
3144 if (mflag & P_BLOCKSVIEW) /* something to hide near! */ 3042 if (mflag & P_BLOCKSVIEW) /* something to hide near! */
3145 level += 2; 3043 level += 2;
3146 else /* open terrain! */ 3044 else /* open terrain! */
3147 level -= 1; 3045 level -= 1;
3148 } 3046 }
… …
3156/* For Hidden creatures - a chance of becoming 'unhidden' 3054/* For Hidden creatures - a chance of becoming 'unhidden'
3157 * every time they move - as we subtract off 'invisibility' 3055 * every time they move - as we subtract off 'invisibility'
3158 * AND, for players, if they move into a ridiculously unhideable 3056 * AND, for players, if they move into a ridiculously unhideable
3159 * spot (surrounded by clear terrain in broad daylight). -b.t. 3057 * spot (surrounded by clear terrain in broad daylight). -b.t.
3160 */ 3058 */
3161
3162void 3059void
3163do_hidden_move (object *op) 3060do_hidden_move (object *op)
3164{ 3061{
3165 int hide = 0, num = random_roll (0, 19, op, PREFER_LOW); 3062 int hide = 0;
3166 object *skop;
3167 3063
3168 if (!op || !op->map) 3064 if (!op || !op->map)
3169 return; 3065 return;
3170 3066
3171 skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING); 3067 object *skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING);
3068 int num = random_roll (0, 19, op, PREFER_LOW);
3172 3069
3173 /* its *extremely* hard to run and sneak/hide at the same time! */ 3070 /* its *extremely* hard to run and sneak/hide at the same time! */
3174 if (op->type == PLAYER && op->contr->run_on) 3071 if (op->type == PLAYER && op->contr->run_on)
3175 if (!skop || num >= skop->level) 3072 if (!skop || num >= skop->level)
3176 { 3073 {
… …
3186 num -= hide; 3083 num -= hide;
3187 3084
3188 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0)) 3085 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0))
3189 { 3086 {
3190 make_visible (op); 3087 make_visible (op);
3088
3191 if (op->type == PLAYER) 3089 if (op->type == PLAYER)
3192 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!"); 3090 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!");
3193 } 3091 }
3194 else if (op->type == PLAYER && skop) 3092 else if (op->type == PLAYER && skop)
3195 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0); 3093 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0);
… …
3248 * object op. This function works fine for monsters, 3146 * object op. This function works fine for monsters,
3249 * but we dont worry if the object isnt the top one in 3147 * but we dont worry if the object isnt the top one in
3250 * a pile (say a coin under a table would return "viewable" 3148 * a pile (say a coin under a table would return "viewable"
3251 * by this routine). Another question, should we be 3149 * by this routine). Another question, should we be
3252 * concerned with the direction the player is looking 3150 * concerned with the direction the player is looking
3253 * in? Realistically, most of use cant see stuff behind 3151 * in? Realistically, most of us can't see stuff behind
3254 * our backs...on the other hand, does the "facing" direction 3152 * our backs...on the other hand, does the "facing" direction
3255 * imply the way your head, or body is facing? Its possible 3153 * imply the way your head, or body is facing? It's possible
3256 * for them to differ. Sigh, this fctn could get a bit more complex. 3154 * for them to differ. Sigh, this fctn could get a bit more complex.
3257 * -b.t. 3155 * -b.t.
3258 * This function is now map tiling safe. 3156 * This function is now map tiling safe.
3259 */ 3157 */
3260
3261int 3158int
3262player_can_view (object *pl, object *op) 3159player_can_view (object *pl, object *op)
3263{ 3160{
3264 rv_vector rv; 3161 rv_vector rv;
3265 int dx, dy; 3162 int dx, dy;
… …
3277 3174
3278 get_rangevector (pl, op, &rv, 0x1); 3175 get_rangevector (pl, op, &rv, 0x1);
3279 3176
3280 /* starting with the 'head' part, lets loop 3177 /* starting with the 'head' part, lets loop
3281 * through the object and find if it has any 3178 * through the object and find if it has any
3282 * part that is in the los array but isnt on 3179 * part that is in the los array but isn't on
3283 * a blocked los square. 3180 * a blocked los square.
3284 * we use the archetype to figure out offsets. 3181 * we use the archetype to figure out offsets.
3285 */ 3182 */
3286 while (op) 3183 while (op)
3287 { 3184 {
3288 dx = rv.distance_x + op->arch->clone.x; 3185 dx = rv.distance_x + op->arch->x;
3289 dy = rv.distance_y + op->arch->clone.y; 3186 dy = rv.distance_y + op->arch->y;
3290 3187
3291 /* only the viewable area the player sees is updated by LOS 3188 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3292 * code, so we need to restrict ourselves to that range of values
3293 * for any meaningful values.
3294 */
3295 if (FABS (dx) <= (pl->contr->ns->mapx / 2) &&
3296 FABS (dy) <= (pl->contr->ns->mapy / 2) &&
3297 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3298 return 1; 3189 return 1;
3190
3299 op = op->more; 3191 op = op->more;
3300 } 3192 }
3193
3301 return 0; 3194 return 0;
3302} 3195}
3303 3196
3304/* routine for both players and monsters. We call this when 3197/* routine for both players and monsters. We call this when
3305 * there is a possibility for our action distrubing our hiding 3198 * there is a possibility for our action distrubing our hiding
3306 * place or invisiblity spell. Artefact invisiblity is not 3199 * place or invisiblity spell. Artefact invisiblity causes
3307 * effected by this. If we arent invisible to begin with, we 3200 * "noise" instead. If we arent invisible to begin with, we
3308 * return 0. 3201 * return 0.
3309 */ 3202 */
3310int 3203int
3311action_makes_visible (object *op) 3204action_makes_visible (object *op)
3312{ 3205{
3313
3314 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE)) 3206 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3315 { 3207 {
3316 if (QUERY_FLAG (op, FLAG_MAKE_INVIS)) 3208 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3209 {
3210 // artefact invisibility is permanent, but we still make noise
3211 // this is important for game-balance.
3212 if (op->contr)
3213 op->make_noise ();
3214
3317 return 0; 3215 return 0;
3216 }
3318 3217
3319 if (op->contr && op->contr->tmp_invis == 0) 3218 if (op->contr && op->contr->tmp_invis == 0)
3320 return 0; 3219 return 0;
3321 3220
3322 /* If monsters, they should become visible */ 3221 /* If monsters, they should become visible */
3323 if (op->hide || !op->contr || (op->contr && op->contr->tmp_invis)) 3222 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
3324 { 3223 {
3325 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible"); 3224 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
3326 return 1; 3225 return 1;
3327 } 3226 }
3328 } 3227 }
3228
3329 return 0; 3229 return 0;
3330} 3230}
3331 3231
3332/* op_on_battleground - checks if the given object op (usually 3232/* op_on_battleground - checks if the given object op (usually
3333 * a player) is standing on a valid battleground-tile, 3233 * a player) is standing on a valid battleground-tile,
… …
3338 * Default is to do the same as before, so only people wanting to have different points need worry about this 3238 * Default is to do the same as before, so only people wanting to have different points need worry about this
3339 */ 3239 */
3340int 3240int
3341op_on_battleground (object *op, int *x, int *y) 3241op_on_battleground (object *op, int *x, int *y)
3342{ 3242{
3343 object *tmp;
3344
3345 /* A battleground-tile needs the following attributes to be valid: 3243 /* A battleground-tile needs the following attributes to be valid:
3346 * is_floor 1 (has to be the FIRST floor beneath the player's feet), 3244 * is_floor 1 (has to be the FIRST floor beneath the player's feet),
3347 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND) 3245 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND)
3348 * and the exit-coordinates sp/hp must both be > 0. 3246 * and the exit-coordinates sp/hp must both be > 0.
3349 * => The intention here is to prevent abuse of the battleground- 3247 * => The intention here is to prevent abuse of the battleground-
3350 * feature (like pickable or hidden battleground tiles). */ 3248 * feature (like pickable or hidden battleground tiles). */
3351 for (tmp = op->below; tmp != NULL; tmp = tmp->below) 3249 for (object *tmp = op->below; tmp; tmp = tmp->below)
3352 { 3250 {
3353 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3251 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
3354 { 3252 {
3355 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && 3253 if (QUERY_FLAG (tmp, FLAG_NO_PICK)
3356 strcmp (tmp->name, "battleground") == 0 && tmp->type == BATTLEGROUND && EXIT_X (tmp) && EXIT_Y (tmp)) 3254 && tmp->type == BATTLEGROUND
3255 && tmp->name == shstr_battleground
3256 && EXIT_X (tmp) && EXIT_Y (tmp))
3357 { 3257 {
3358 /*before we assign the exit, check if this is a teambattle */ 3258 /* before we assign the exit, check if this is a teambattle */
3359 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3259 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3360 { 3260 {
3361 object *invtmp;
3362
3363 for (invtmp = op->inv; invtmp != NULL; invtmp = invtmp->below) 3261 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3364 { 3262 {
3365 if (invtmp->type == FORCE && invtmp->slaying && !strcmp (EXIT_PATH (tmp), invtmp->slaying)) 3263 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3366 { 3264 {
3367 if (x != NULL && y != NULL) 3265 if (x && y)
3368 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3266 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3267
3369 return 1; 3268 return 1;
3370 } 3269 }
3371 } 3270 }
3372 } 3271 }
3272
3373 if (x != NULL && y != NULL) 3273 if (x && y)
3374 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3274 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3275
3375 return 1; 3276 return 1;
3376 } 3277 }
3377 } 3278 }
3378 } 3279 }
3280
3379 /* If we got here, did not find a battleground */ 3281 /* If we got here, did not find a battleground */
3380 return 0; 3282 return 0;
3381} 3283}
3382 3284
3383/* 3285/*
… …
3399 char buf[MAX_BUF]; /* tmp. string buffer */ 3301 char buf[MAX_BUF]; /* tmp. string buffer */
3400 int i = 0, j = 0; 3302 int i = 0, j = 0;
3401 3303
3402 /* get the appropriate treasurelist */ 3304 /* get the appropriate treasurelist */
3403 if (atnr == ATNR_FIRE) 3305 if (atnr == ATNR_FIRE)
3404 trlist = find_treasurelist ("dragon_ability_fire"); 3306 trlist = treasurelist::find (shstr_dragon_ability_fire);
3405 else if (atnr == ATNR_COLD) 3307 else if (atnr == ATNR_COLD)
3406 trlist = find_treasurelist ("dragon_ability_cold"); 3308 trlist = treasurelist::find (shstr_dragon_ability_cold);
3407 else if (atnr == ATNR_ELECTRICITY) 3309 else if (atnr == ATNR_ELECTRICITY)
3408 trlist = find_treasurelist ("dragon_ability_elec"); 3310 trlist = treasurelist::find (shstr_dragon_ability_elec);
3409 else if (atnr == ATNR_POISON) 3311 else if (atnr == ATNR_POISON)
3410 trlist = find_treasurelist ("dragon_ability_poison"); 3312 trlist = treasurelist::find (shstr_dragon_ability_poison);
3411 3313
3412 if (trlist == NULL || who->type != PLAYER) 3314 if (trlist == NULL || who->type != PLAYER)
3413 return; 3315 return;
3414 3316
3415 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++); 3317 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++);
… …
3419 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */ 3321 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */
3420 return; 3322 return;
3421 } 3323 }
3422 3324
3423 /* everything seems okay - now bring on the gift: */ 3325 /* everything seems okay - now bring on the gift: */
3424 item = &(tr->item->clone); 3326 item = tr->item;
3425 3327
3426 if (item->type == SPELL) 3328 if (item->type == SPELL)
3427 { 3329 {
3428 if (check_spell_known (who, item->name)) 3330 if (check_spell_known (who, item->name))
3429 return; 3331 return;
… …
3488 { 3390 {
3489 /* forces in the treasurelist can alter the player's stats */ 3391 /* forces in the treasurelist can alter the player's stats */
3490 object *skin; 3392 object *skin;
3491 3393
3492 /* first get the dragon skin force */ 3394 /* first get the dragon skin force */
3493 shstr_cmp dragon_skin_force ("dragon_skin_force");
3494 for (skin = who->inv; skin && !(skin->arch->name == dragon_skin_force); skin = skin->below) 3395 for (skin = who->inv; skin && !(skin->arch->archname == shstr_dragon_skin_force); skin = skin->below)
3495 ; 3396 ;
3496 3397
3497 if (!skin) 3398 if (!skin)
3498 return; 3399 return;
3499 3400
… …
3534 else 3435 else
3535 { 3436 {
3536 /* generate misc. treasure */ 3437 /* generate misc. treasure */
3537 tmp = arch_to_object (tr->item); 3438 tmp = arch_to_object (tr->item);
3538 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3439 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3539 tmp = insert_ob_in_ob (tmp, who); 3440 who->insert (tmp);
3540 if (who->type == PLAYER)
3541 esrv_send_item (who, tmp);
3542 } 3441 }
3543} 3442}
3544 3443
3545/** 3444/**
3546 * Unready an object for a player. This function does nothing if the object was 3445 * Unready an object for a player. This function does nothing if the object was
3547 * not readied. 3446 * not readied.
3548 */ 3447 */
3549void 3448void
3550player_unready_range_ob (player *pl, object *ob) 3449player_unready_range_ob (player *pl, object *ob)
3551{ 3450{
3552 rangetype i; 3451 if (pl->ob->current_weapon == ob)
3452 pl->ob->current_weapon = 0;
3553 3453
3554 for (i = (rangetype) 0; i < range_size; i = (rangetype) ((int) i + 1)) 3454 if (pl->combat_ob == ob)
3555 { 3455 pl->combat_ob = 0;
3456
3556 if (pl->ranges[i] == ob) 3457 if (pl->ranged_ob == ob)
3557 { 3458 pl->ranged_ob = 0;
3558 pl->ranges[i] = NULL;
3559 if (pl->shoottype == i)
3560 {
3561 pl->shoottype = range_none;
3562 }
3563 }
3564 }
3565} 3459}
3460
3461sint8
3462player::darkness_at (maptile *map, int x, int y) const
3463{
3464 if (!ns)
3465 return LOS_BLOCKED;
3466
3467 int dx, dy;
3468 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3469 return LOS_BLOCKED;
3470
3471 x += dx - ns->current_x;
3472 y += dy - ns->current_y;
3473
3474 return blocked_los (x, y);
3475}
3476
3477void
3478player::infobox (const char *title, const char *msg, int color)
3479{
3480 send_msg (color | NDI_DEF | NDI_REPLY | NDI_CLEAR, title, msg);
3481}
3482
3483void
3484player::statusmsg (const char *msg, int color)
3485{
3486 send_msg (color | NDI_REPLY, INFO_CHANNEL, msg);
3487}
3488
3489void
3490player::failmsg (const char *msg, int color)
3491{
3492 play_sound (sound_find ("generic_failure"));
3493 statusmsg (msg, color);
3494}
3495

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines