ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.96 by root, Mon Jan 8 19:25:53 2007 UTC vs.
Revision 1.237 by root, Thu Nov 5 15:18:26 2009 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
21 * 21 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24 24
25#include <global.h> 25#include <global.h>
26#include <pwd.h>
27#include <sproto.h> 26#include <sproto.h>
28#include <sounds.h> 27#include <sounds.h>
29#include <living.h> 28#include <living.h>
30#include <object.h> 29#include <object.h>
31#include <spells.h> 30#include <spells.h>
34#include <algorithm> 33#include <algorithm>
35#include <functional> 34#include <functional>
36 35
37playervec players; 36playervec players;
38 37
39void
40display_motd (const object *op)
41{
42 char buf[MAX_BUF];
43 char motd[HUGE_BUF];
44 FILE *fp;
45 int comp;
46 int size;
47
48 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
49 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
50 return;
51
52 motd[0] = '\0';
53 size = 0;
54
55 while (fgets (buf, MAX_BUF, fp))
56 {
57 if (*buf == '#')
58 continue;
59
60 strncat (motd + size, buf, HUGE_BUF - size);
61 size += strlen (buf);
62 }
63
64 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
65 close_and_delete (fp, comp);
66}
67
68void
69send_rules (const object *op)
70{
71 char buf[MAX_BUF];
72 char rules[HUGE_BUF];
73 FILE *fp;
74 int comp;
75 int size;
76
77 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
78 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
79 return;
80
81 rules[0] = '\0';
82 size = 0;
83
84 while (fgets (buf, MAX_BUF, fp))
85 {
86 if (*buf == '#')
87 continue;
88
89 if (size + strlen (buf) >= HUGE_BUF)
90 {
91 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
92 break;
93 }
94
95 strncat (rules + size, buf, HUGE_BUF - size);
96 size += strlen (buf);
97 }
98
99 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
100 close_and_delete (fp, comp);
101}
102
103void
104send_news (const object *op)
105{
106 char buf[MAX_BUF];
107 char news[HUGE_BUF];
108 char subject[MAX_BUF];
109 FILE *fp;
110 int comp;
111 int size;
112
113 sprintf (buf, "%s/%s", settings.confdir, settings.news);
114 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
115 return;
116
117 news[0] = '\0';
118 subject[0] = '\0';
119 size = 0;
120
121 while (fgets (buf, MAX_BUF, fp) != NULL)
122 {
123 if (*buf == '#')
124 continue;
125
126 if (*buf == '%')
127 { /* send one news */
128 if (size > 0)
129 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s", "%s\n%s", subject, news); /*send previously read news */
130
131 strcpy (subject, buf + 1);
132 strip_endline (subject);
133 size = 0;
134 news[0] = '\0';
135 }
136 else
137 {
138 if (size + strlen (buf) >= HUGE_BUF)
139 {
140 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
141 break;
142 }
143 strncat (news + size, buf, HUGE_BUF - size);
144 size += strlen (buf);
145 }
146 }
147
148 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
149 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", "%s\n%s", subject, news);
150 close_and_delete (fp, comp);
151}
152
153/* This loads the first map an puts the player on it. */ 38/* This loads the first map an puts the player on it. */
154static void 39static void
155set_first_map (object *op) 40set_first_map (object *op)
156{ 41{
157 op->contr->maplevel = first_map_path; 42 op->contr->maplevel = first_map_path;
158 op->x = -1; 43 op->x = -1;
159 op->y = -1; 44 op->y = -1;
160}
161
162void
163player::enter_map ()
164{
165 object *tmp = object::create ();
166
167 EXIT_PATH (tmp) = maplevel;
168 EXIT_X (tmp) = ob->x;
169 EXIT_Y (tmp) = ob->y;
170 ob->enter_exit (tmp);
171
172 tmp->destroy ();
173} 45}
174 46
175void 47void
176player::activate () 48player::activate ()
177{ 49{
182 ob->remove (); 54 ob->remove ();
183 ob->map = 0; 55 ob->map = 0;
184 ob->activate_recursive (); 56 ob->activate_recursive ();
185 CLEAR_FLAG (ob, FLAG_FRIENDLY); 57 CLEAR_FLAG (ob, FLAG_FRIENDLY);
186 add_friendly_object (ob); 58 add_friendly_object (ob);
187 enter_map ();
188} 59}
189 60
190void 61void
191player::deactivate () 62player::deactivate ()
192{ 63{
194 return; 65 return;
195 66
196 terminate_all_pets (ob); 67 terminate_all_pets (ob);
197 remove_friendly_object (ob); 68 remove_friendly_object (ob);
198 ob->deactivate_recursive (); 69 ob->deactivate_recursive ();
70
71 if (ob->map)
72 maplevel = ob->map->path;
73
199 ob->remove (); 74 ob->remove ();
75 ob->enemy = 0; // sometimes keeps an extra refcount on itself
200 ob->map = 0; 76 ob->map = 0;
77 party = 0;
201 78
202 // for weird reasons, this is often "ob", keeping a circular reference 79 combat_ob = ranged_ob = 0; //TODO, should be special marker, non-refcounted, not this
203 ranges [range_skill] = 0;
204 80
205 players.erase (this); 81 players.erase (this);
206} 82}
207 83
208// connect the player with a specific client 84// connect the player with a specific client
209// also changed, rationalises, and fixes some incorrect settings 85// also changes, rationalises, and fixes some incorrect settings
210void 86void
211player::connect (client *ns) 87player::connect (client *ns)
212{ 88{
213 this->ns = ns; 89 this->ns = ns;
214 ns->pl = this; 90 ns->pl = this;
215 91
216 run_on = 0; 92 run_on = 0;
217 fire_on = 0; 93 fire_on = 0;
94 ob->close_container (); //TODO: client-specific
218 95
219 ns->update_look = 0; 96 ns->update_look = 0;
220 ns->look_position = 0; 97 ns->look_position = 0;
221 98
222 clear_los (ob); 99 clear_los ();
223 100
224 ns->reset_stats (); 101 ns->reset_stats ();
225 102
226 /* make sure he's a player -- needed because of class change. */ 103 /* make sure he's a player -- needed because of class change. */
227 ob->type = PLAYER; // we are paranoid 104 ob->type = PLAYER; // we are paranoid
228 ob->race = ob->arch->clone.race; 105 ob->race = ob->arch->race;
229 106
230 if (!legal_range (ob, shoottype)) 107 ob->update_weight ();
231 shoottype = range_none;
232
233 ob->carrying = sum_weight (ob);
234 link_player_skills (ob); 108 link_skills ();
235 109
236 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER); 110 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
237 111
238 assign (title, ob->arch->clone.name); 112 assign (title, ob->arch->object::name);
239
240 /* can_use_shield is a new flag. However, the can_use.. seems to largely come
241 * from the class, and not race. I don't see any way to get the class information
242 * to then update this. I don't think this will actually break anything - anyone
243 * that can use armour should be able to use a shield. What this may 'break'
244 * are features new characters get, eg, if someone starts up with a Q, they
245 * should be able to use a shield. However, old Q's won't get that advantage.
246 */
247 if (QUERY_FLAG (ob, FLAG_USE_ARMOUR))
248 SET_FLAG (ob, FLAG_USE_SHIELD);
249 113
250 /* if it's a dragon player, set the correct title here */ 114 /* if it's a dragon player, set the correct title here */
251 if (is_dragon_pl (ob)) 115 if (is_dragon_pl (ob))
252 { 116 {
253 object *tmp, *abil = 0, *skin = 0; 117 object *tmp, *abil = 0, *skin = 0;
254 118
255 shstr_cmp dragon_ability_force ("dragon_ability_force");
256 shstr_cmp dragon_skin_force ("dragon_skin_force");
257
258 for (tmp = ob->inv; tmp; tmp = tmp->below) 119 for (tmp = ob->inv; tmp; tmp = tmp->below)
259 if (tmp->type == FORCE) 120 if (tmp->type == FORCE)
260 if (tmp->arch->name == dragon_ability_force) 121 if (tmp->arch->archname == shstr_dragon_ability_force)
261 abil = tmp; 122 abil = tmp;
262 else if (tmp->arch->name == dragon_skin_force) 123 else if (tmp->arch->archname == shstr_dragon_skin_force)
263 skin = tmp; 124 skin = tmp;
264 125
265 set_dragon_name (ob, abil, skin); 126 set_dragon_name (ob, abil, skin);
266 } 127 }
267 128
268 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 129 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
269 130
270 esrv_new_player (this, ob->weight + ob->carrying); 131 esrv_new_player (this);
271 132
272 ob->update_stats (); 133 ob->update_stats ();
134
273 ns->floorbox_update (); 135 ns->floorbox_update ();
274
275 esrv_send_inventory (ob, ob); 136 esrv_send_inventory (ob, ob);
276 esrv_add_spells (this, 0); 137 esrv_add_spells (this, 0);
277 138
278 activate (); 139 activate ();
279 140
280 send_rules (ob);
281 send_news (ob);
282 display_motd (ob);
283
284 INVOKE_PLAYER (CONNECT, this); 141 INVOKE_PLAYER (CONNECT, this);
285 INVOKE_PLAYER (LOGIN, this); 142 INVOKE_PLAYER (LOGIN, this);
286} 143}
287 144
288void 145void
289player::disconnect () 146player::disconnect ()
290{ 147{
148 if (ob)
149 {
150 ob->close_container (); //TODO: client-specific
151 ob->drop_unpaid_items ();
152 }
153
291 if (ns) 154 if (ns)
292 { 155 {
293 if (active) 156 if (active)
294 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0)); 157 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0));
295 158
296 INVOKE_PLAYER (DISCONNECT, this); 159 INVOKE_PLAYER (DISCONNECT, this);
297 160
161 ns->reset_stats ();
298 ns->pl = 0; 162 ns->pl = 0;
299 this->ns = 0; 163 ns = 0;
300 } 164 }
165
166 // this is important for the player scheduler to get the correct refcount
167 // when ns = 0
168 observe = viewpoint = ob;
301 169
302 deactivate (); 170 deactivate ();
303} 171}
304 172
305// the need for this function can be explained 173// the need for this function can be explained
306// by load_object not returning the object 174// by load_object not returning the object
307void 175void
308player::set_object (object *op) 176player::set_object (object *op)
309{ 177{
310 ob = op; 178 ob = observe = viewpoint = op;
311 ob->contr = this; /* this aren't yet in archetype */ 179 ob->contr = this; /* this aren't yet in archetype */
312 180
181 ob->speed = 1.0f;
313 ob->speed_left = 0.5; 182 ob->speed_left = 0.5f;
314 ob->speed = 1.0; 183
315 ob->direction = 5; /* So player faces south */ 184 ob->direction = 5; /* So player faces south */
316 ob->stats.wc = 2;
317 ob->run_away = 25; /* Then we panick... */
318 185
319 ob->roll_stats (); 186 ob->flag [FLAG_READY_WEAPON] = false;
187 ob->flag [FLAG_READY_SKILL] = false;
188 ob->flag [FLAG_READY_BOW] = false;
189
190 for (object *op = ob->inv; op; op = op->below)
191 if (op->flag [FLAG_APPLIED])
192 switch (op->type)
193 {
194 case SKILL:
195 ob->flag [FLAG_APPLIED] = false;
196 break;
197
198 case WAND:
199 case ROD:
200 case HORN:
201 case BOW:
202 ranged_ob = op;
203 break;
204
205 case WEAPON:
206 combat_ob = op;
207 break;
208 }
209
210 ob->change_weapon (combat_ob ? combat_ob : ranged_ob);
211 ob->deactivate (); // change_weapon activates, fix this better
212}
213
214void
215player::set_observe (object *op)
216{
217 observe = viewpoint = op ? op : ob;
218 do_los = 1;
219}
220
221void
222player::set_viewpoint (object *op)
223{
224 viewpoint = op ? op : (object *)observe;
225 do_los = 1;
320} 226}
321 227
322player::player () 228player::player ()
323{ 229{
324 /* There are some elements we want initialised to non zero value - 230 /* There are some elements we want initialised to non zero value -
325 * we deal with that below this point. 231 * we deal with that below this point.
326 */ 232 */
327 outputs_sync = 16; /* Every 2 seconds */ 233 outputs_sync = 4;
328 outputs_count = 8; /* Keeps present behaviour */ 234 outputs_count = 4;
329 unapply = unapply_nochoice; 235 unapply = unapply_nochoice;
330 236
331 savebed_map = first_map_path; /* Init. respawn position */ 237 savebed_map = first_map_path; /* Init. respawn position */
332 238
333 gen_sp_armour = 10; 239 gen_sp_armour = 10;
334 shoottype = range_none;
335 bowtype = bow_normal; 240 bowtype = bow_normal;
336 petmode = pet_normal; 241 petmode = pet_normal;
337 listening = 10;
338 usekeys = containers; 242 usekeys = containers;
339 peaceful = 1; /* default peaceful */ 243 peaceful = 1; /* default peaceful */
340 do_los = 1; 244 do_los = 1;
245
246 weapon_sp = 1.0f;
247 weapon_sp_left = 0.5f;
341} 248}
342 249
343void 250void
344player::do_destroy () 251player::do_destroy ()
345{ 252{
350 if (ob) 257 if (ob)
351 { 258 {
352 ob->destroy_inv (false); 259 ob->destroy_inv (false);
353 ob->destroy (); 260 ob->destroy ();
354 } 261 }
262
263 ob = observe = viewpoint = 0;
355} 264}
356 265
357player::~player () 266player::~player ()
358{ 267{
359 /* Clear item stack */ 268 /* Clear item stack */
368player::create () 277player::create ()
369{ 278{
370 player *pl = new player; 279 player *pl = new player;
371 280
372 pl->set_object (arch_to_object (get_player_archetype (0))); 281 pl->set_object (arch_to_object (get_player_archetype (0)));
282
283 pl->ob->roll_stats ();
284 pl->ob->stats.wc = 2;
285 pl->ob->run_away = 25; /* Then we panick... */
286
373 set_first_map (pl->ob); 287 set_first_map (pl->ob);
374 288
375 return pl; 289 return pl;
376} 290}
377 291
381 * Note: there MUST be at least one player archetype! 295 * Note: there MUST be at least one player archetype!
382 */ 296 */
383archetype * 297archetype *
384get_player_archetype (archetype *at) 298get_player_archetype (archetype *at)
385{ 299{
386 archetype *start = at; 300 // archetypes could have been reloaded
301 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
302
303 if (!nat)
304 return at;
305
306 archvec::iterator i = archetypes.find (nat);
387 307
388 for (;;) 308 for (;;)
389 { 309 {
390 if (at == NULL || at->next == NULL) 310 if (++i == archetypes.end ())
391 at = first_archetype; 311 i = archetypes.begin ();
392 else 312 else if (*i == at)
393 at = at->next; 313 cleanup ("not a single player archetype found");
394 314
395 if (at->clone.type == PLAYER) 315 if ((*i)->type == PLAYER)
396 return at; 316 return *i;
397
398 if (at == start)
399 {
400 LOG (llevError, "No Player archetypes\n");
401 exit (-1);
402 }
403 } 317 }
404} 318}
405 319
406object * 320object *
407get_nearest_player (object *mon) 321get_nearest_player (object *mon)
411 unsigned lastdist; 325 unsigned lastdist;
412 rv_vector rv; 326 rv_vector rv;
413 327
414 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next) 328 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next)
415 { 329 {
416 /* We should not find free objects on this friendly list, but it
417 * does periodically happen. Given that, lets deal with it.
418 * While unlikely, it is possible the next object on the friendly
419 * list is also free, so encapsulate this in a while loop.
420 */
421 while (QUERY_FLAG (ol->ob, FLAG_FREED) || !QUERY_FLAG (ol->ob, FLAG_FRIENDLY))
422 {
423 object *tmp = ol->ob;
424
425 /* Can't do much more other than log the fact, because the object
426 * itself will have been cleared.
427 */
428 LOG (llevDebug, "get_nearest_player: Found free/non friendly object '%s' on friendly list\n",
429 tmp->debug_desc ());
430 ol = ol->next;
431 remove_friendly_object (tmp);
432 if (!ol)
433 return op;
434 }
435
436 /* Remove special check for player from this. First, it looks to cause
437 * some crashes (ol->ob->contr not set properly?), but secondly, a more
438 * complicated method of state checking would be needed in any case -
439 * as it was, a clever player could type quit, and the function would
440 * skip them over while waiting for confirmation. Remove
441 * on_same_map check, as can_detect_enemy also does this
442 */
443 if (!can_detect_enemy (mon, ol->ob, &rv)) 330 if (!can_detect_enemy (mon, ol->ob, &rv))
444 continue; 331 continue;
445 332
446 if (lastdist > rv.distance) 333 if (lastdist > rv.distance)
447 { 334 {
523 x = mon->x; 410 x = mon->x;
524 y = mon->y; 411 y = mon->y;
525 m = mon->map; 412 m = mon->map;
526 dir = rv.direction; 413 dir = rv.direction;
527 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 414 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
528 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 415 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
416
529 /* If we can't solve it within the search distance, return now. */ 417 /* If we can't solve it within the search distance, return now. */
530 if (diff > max) 418 if (diff > max)
531 return 0; 419 return 0;
420
532 while (diff > 1 && max > 0) 421 while (diff > 1 && max > 0)
533 { 422 {
534 lastx = x; 423 lastx = x;
535 lasty = y; 424 lasty = y;
536 lastmap = m; 425 lastmap = m;
618 max--; 507 max--;
619 lastdir = dir; 508 lastdir = dir;
620 if (!firstdir) 509 if (!firstdir)
621 firstdir = dir; 510 firstdir = dir;
622 } 511 }
512
623 if (diff <= 1) 513 if (diff <= 1)
624 { 514 {
625 /* Recalculate diff (distance) because we may not have actually 515 /* Recalculate diff (distance) because we may not have actually
626 * headed toward player for entire distance. 516 * headed toward player for entire distance.
627 */ 517 */
628 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 518 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0);
629 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 519 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
630 } 520 }
521
631 if (diff > max) 522 if (diff > max)
632 return 0; 523 return 0;
633 } 524 }
525
634 /* If we reached the max, didn't find a direction in time */ 526 /* If we reached the max, didn't find a direction in time */
635 if (!max) 527 if (!max)
636 return 0; 528 return 0;
637 529
638 return firstdir; 530 return firstdir;
639} 531}
640 532
641void 533void
642give_initial_items (object *pl, treasurelist * items) 534give_initial_items (object *pl, treasurelist *items)
643{ 535{
644 object *op, *next = NULL;
645
646 if (pl->randomitems != NULL) 536 if (pl->randomitems)
647 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0); 537 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0);
648 538
649 for (op = pl->inv; op; op = next) 539 for (object *next, *op = pl->inv; op; op = next)
650 { 540 {
651 next = op->below; 541 next = op->below;
652 542
653 /* Forces get applied per default, unless they have the 543 /* Forces get applied per default, unless they have the
654 * flag "neutral" set. Sorry but I can't think of a better way 544 * flag "neutral" set. Sorry but I can't think of a better way
659 /* we never give weapons/armour if these cannot be used 549 /* we never give weapons/armour if these cannot be used
660 * by this player due to race restrictions 550 * by this player due to race restrictions
661 */ 551 */
662 if (pl->type == PLAYER) 552 if (pl->type == PLAYER)
663 { 553 {
664 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) && 554 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR)
555 &&
665 (op->type == ARMOUR || op->type == BOOTS || 556 (op->type == ARMOUR || op->type == BOOTS
666 op->type == CLOAK || op->type == HELMET || 557 || op->type == CLOAK || op->type == HELMET
667 op->type == SHIELD || op->type == GLOVES || 558 || op->type == SHIELD || op->type == GLOVES
559 || op->type == BRACERS || op->type == GIRDLE))
668 op->type == BRACERS || op->type == GIRDLE)) || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 560 || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON))
669 { 561 {
670 op->destroy (); 562 op->destroy ();
671 continue; 563 continue;
672 } 564 }
673 } 565 }
674 566
675 /* This really needs to be better - we should really give 567 /* Here we remove duplicated skills (as duplicated spell objects have
676 * a substitute spellbook. The problem is that we don't really 568 * _very_ confusing effects for players), which could for instance be
677 * have a good idea what to replace it with (need something like 569 * generated by bad treasurelists. - elmex
678 * a first level treasurelist for each skill.)
679 * remove duplicate skills also
680 */ 570 */
681 if (op->type == SPELLBOOK || op->type == SKILL) 571 if (op->type == SKILL)
682 { 572 {
683 object *tmp;
684
685 for (tmp = op->below; tmp; tmp = tmp->below) 573 for (object *tmp = op->below; tmp; tmp = tmp->below)
686 if (tmp->type == op->type && tmp->name == op->name) 574 if (tmp->type == op->type && tmp->name == op->name)
687 break;
688
689 if (tmp)
690 { 575 {
691 op->destroy (); 576 op->destroy ();
577 LOG (llevError,
692 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 578 "give_initial_items: Removing duplicate skill %s\n", &tmp->name);
693 continue; 579 break;
694 } 580 }
695 581
696 if (op->nrof > 1) 582 if (op->nrof > 1)
697 op->nrof = 1; 583 op->nrof = 1;
698 } 584 }
699 585
700 if (op->type == SPELLBOOK && op->inv) 586 if (op->type == SPELLBOOK && op->inv)
701 {
702 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP); 587 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP);
703 }
704 588
705 /* Give starting characters identified, uncursed, and undamned 589 /* Give starting characters identified, uncursed, and undamned
706 * items. Just don't identify gold or silver, or it won't be 590 * items. Just don't identify gold or silver, or it won't be
707 * merged properly. 591 * merged properly.
708 */ 592 */
709 if (need_identify (op)) 593 if (need_identify (op))
710 { 594 {
711 SET_FLAG (op, FLAG_IDENTIFIED); 595 SET_FLAG (op, FLAG_IDENTIFIED);
712 CLEAR_FLAG (op, FLAG_CURSED); 596 CLEAR_FLAG (op, FLAG_CURSED);
713 CLEAR_FLAG (op, FLAG_DAMNED); 597 CLEAR_FLAG (op, FLAG_DAMNED);
714 } 598 }
599
715 if (op->type == SPELL) 600 if (op->type == SPELL)
716 { 601 {
717 op->destroy (); 602 op->destroy ();
718 continue; 603 continue;
719 } 604 }
721 { 606 {
722 SET_FLAG (op, FLAG_CAN_USE_SKILL); 607 SET_FLAG (op, FLAG_CAN_USE_SKILL);
723 op->stats.exp = 0; 608 op->stats.exp = 0;
724 op->level = 1; 609 op->level = 1;
725 } 610 }
726 /* lock all 'normal items by default */ 611 else /* lock all 'normal items by default */
727 else
728 SET_FLAG (op, FLAG_INV_LOCKED); 612 SET_FLAG (op, FLAG_INV_LOCKED);
729 } /* for loop of objects in player inv */ 613 } /* for loop of objects in player inv */
730 614
731 /* Need to set up the skill pointers */ 615 /* Need to set up the skill pointers */
732 link_player_skills (pl); 616 pl->contr->link_skills ();
733} 617}
734 618
735void 619void
736get_party_password (object *op, partylist *party) 620get_party_password (object *op, partylist *party)
737{ 621{
752roll_stat (void) 636roll_stat (void)
753{ 637{
754 int a[4], i, j, k; 638 int a[4], i, j, k;
755 639
756 for (i = 0; i < 4; i++) 640 for (i = 0; i < 4; i++)
757 a[i] = (int) RANDOM () % 6 + 1; 641 a[i] = (int) rndm (6) + 1;
758 642
759 for (i = 0, j = 0, k = 7; i < 4; i++) 643 for (i = 0, j = 0, k = 7; i < 4; i++)
760 if (a[i] < k) 644 if (a[i] < k)
761 k = a[i], j = i; 645 k = a[i], j = i;
762 646
768} 652}
769 653
770void 654void
771object::roll_stats () 655object::roll_stats ()
772{ 656{
773 int statsort [7]; 657 int statsort [NUM_STATS];
774 658
775 for (;;) 659 for (;;)
776 { 660 {
777 int sum = 0; 661 int sum = 0;
778 for (int i = 7; i--; ) 662 for (int i = NUM_STATS; i--; )
779 sum += statsort [i] = roll_stat (); 663 sum += statsort [i] = roll_stat ();
780 664
781 if (sum >= 82 && sum <= 116) 665 if (sum >= 82 && sum <= 116)
782 break; 666 break;
783 } 667 }
784 668
785 // Sort the stats so that rerolling is easier... 669 // Sort the stats so that rerolling is easier...
786 std::sort (statsort, statsort + 7, std::greater<int>()); 670 std::sort (statsort, statsort + NUM_STATS, std::greater<int>());
787 671
672 for (int i = 0; i < NUM_STATS; ++i)
788 stats.Str = statsort[0]; 673 stats.stat (i) = statsort [i];
789 stats.Dex = statsort[1];
790 stats.Con = statsort[2];
791 stats.Int = statsort[3];
792 stats.Wis = statsort[4];
793 stats.Pow = statsort[5];
794 stats.Cha = statsort[6];
795 674
796 stats.exp = 0; 675 stats.exp = 0;
797 stats.ac = 0; 676 stats.ac = 0;
798 677
799 stats.hp = stats.maxhp; 678 stats.hp = stats.maxhp;
811} 690}
812 691
813void 692void
814object::swap_stats (int a, int b) 693object::swap_stats (int a, int b)
815{ 694{
816 int tmp = get_attr_value (&contr->orig_stats, a); 695 swap (contr->orig_stats.stat (a), contr->orig_stats.stat (b));
817 set_attr_value (&contr->orig_stats, a, get_attr_value (&contr->orig_stats, b));
818 set_attr_value (&contr->orig_stats, b, tmp);
819 696
697 for (int i = 0; i < NUM_STATS; ++i)
820 stats.Str = contr->orig_stats.Str; 698 stats.stat (i) = contr->orig_stats.stat (i);
821 stats.Dex = contr->orig_stats.Dex;
822 stats.Con = contr->orig_stats.Con;
823 stats.Int = contr->orig_stats.Int;
824 stats.Wis = contr->orig_stats.Wis;
825 stats.Pow = contr->orig_stats.Pow;
826 stats.Cha = contr->orig_stats.Cha;
827 699
828 //TODO: the following code looks so borked and should, at the very least, 700 //TODO: the following code looks so borked and should, at the very least,
829 // be merged with the similar code in roll_stats 701 // be merged with the similar code in roll_stats
830 stats.ac = 0; 702 stats.ac = 0;
831 703
850static void 722static void
851start_info (object *op) 723start_info (object *op)
852{ 724{
853 char buf[MAX_BUF]; 725 char buf[MAX_BUF];
854 726
855 sprintf (buf, "Welcome to Crossfire v%s!", VERSION); 727 sprintf (buf, "Welcome to Deliantra v%s!", VERSION);
856 new_draw_info (NDI_UNIQUE, 0, op, buf); 728 new_draw_info (NDI_UNIQUE, 0, op, buf);
857 //new_draw_info (NDI_UNIQUE, 0, op, "Press `?' for help");
858 //new_draw_info (NDI_UNIQUE, 0, op, " ");
859} 729}
860 730
861/* This function takes the key that is passed, and does the 731/* This function takes the key that is passed, and does the
862 * appropriate action with it (change race, or other things). 732 * appropriate action with it (change race, or other things).
863 * The function name is for historical reasons - now we have 733 * The function name is for historical reasons - now we have
864 * separate race and class; this actually changes the RACE, 734 * separate race and class; this actually changes the RACE,
865 * not the class. 735 * not the class.
866 */ 736 */
867int 737void
868key_change_class (object *op, char key) 738player::chargen_race_done ()
869{ 739{
870 int tmp_loop;
871
872 if (key == 'd' || key == 'D')
873 {
874 char buf[MAX_BUF];
875
876 /* this must before then initial items are given */ 740 /* this must before then initial items are given */
877 esrv_new_player (op->contr, op->weight + op->carrying); 741 esrv_new_player (ob->contr);
878 742
879 treasurelist *tl = find_treasurelist ("starting_wealth"); 743 treasurelist *tl = treasurelist::find ("starting_wealth");
880 if (tl) 744 if (tl)
881 create_treasure (tl, op, 0, 0, 0); 745 create_treasure (tl, ob, 0, 0, 0);
882 746
883 INVOKE_PLAYER (BIRTH, op->contr); 747 INVOKE_PLAYER (BIRTH, ob->contr);
884 INVOKE_PLAYER (LOGIN, op->contr); 748 INVOKE_PLAYER (LOGIN, ob->contr);
885 749
886 op->contr->ns->state = ST_PLAYING; 750 ob->contr->ns->state = ST_PLAYING;
887 751
888 if (op->msg) 752 if (ob->msg)
889 op->msg = NULL; 753 ob->msg = 0;
890 754
891 /* We create this now because some of the unique maps will need it
892 * to save here.
893 */
894 sprintf (buf, "%s/%s/%s", settings.localdir, settings.playerdir, &op->name);
895 make_path_to_file (buf);
896
897 start_info (op); 755 start_info (ob);
898 CLEAR_FLAG (op, FLAG_WIZ); 756 CLEAR_FLAG (ob, FLAG_WIZ);
899 give_initial_items (op, op->randomitems); 757 give_initial_items (ob, ob->randomitems);
900 link_player_skills (op);
901 esrv_send_inventory (op, op); 758 esrv_send_inventory (ob, ob);
902 op->update_stats (); 759 ob->update_stats ();
903 760
904 /* This moves the player to a different start map, if there 761 /* This moves the player to a different start map, if there
905 * is one for this race 762 * is one for this race
906 */ 763 */
907 if (*first_map_ext_path) 764 if (*first_map_ext_path)
908 { 765 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
909 object *tmp;
910 char mapname[MAX_BUF];
911
912 snprintf (mapname, MAX_BUF - 1, "%s/%s", &first_map_ext_path, &op->arch->name);
913 tmp = object::create ();
914 EXIT_PATH (tmp) = mapname;
915 EXIT_X (tmp) = op->x;
916 EXIT_Y (tmp) = op->y;
917 op->enter_exit (tmp); /* we don't really care if it succeeded;
918 * if the map isn't there, then stay on the
919 * default initial map */
920 tmp->destroy ();
921 }
922 else 766 else
923 LOG (llevDebug, "first_map_ext_path not set\n"); 767 LOG (llevDebug, "first_map_ext_path not set\n");
768}
924 769
925 return 0; 770void
926 } 771player::chargen_race_next ()
927 772{
928 /* Following actually changes the race - this is the default command 773 /* Following actually changes the race - this is the default command
929 * if we don't match with one of the options above. 774 * if we don't match with one of the options above.
930 */ 775 */
931 776
932 tmp_loop = 0; 777 do
933 while (!tmp_loop)
934 { 778 {
935 shstr name = op->name; 779 shstr name = ob->name;
936 int x = op->x, y = op->y; 780 int x = ob->x, y = ob->y;
937 781
938 op->remove_statbonus (); 782 ob->remove_statbonus ();
939 op->remove (); 783 ob->remove ();
940 op->arch = get_player_archetype (op->arch); 784 ob->arch = get_player_archetype (ob->arch);
941 op->arch->clone.copy_to (op); 785 ob->arch->copy_to (ob);
942 op->instantiate (); 786 ob->instantiate ();
943 op->stats = op->contr->orig_stats; 787 ob->stats = ob->contr->orig_stats;
944 op->name = op->name_pl = name; 788 ob->name = ob->name_pl = name;
945 op->x = x; 789 ob->x = x;
946 op->y = y; 790 ob->y = y;
947 SET_ANIMATION (op, 2); /* So player faces south */ 791 SET_ANIMATION (ob, 2); /* So player faces south */
948 insert_ob_in_map (op, op->map, op, 0); 792 insert_ob_in_map (ob, ob->map, ob, 0);
949 assign (op->contr->title, op->arch->clone.name); 793 assign (ob->contr->title, ob->arch->object::name);
950 op->add_statbonus (); 794 ob->add_statbonus ();
951 tmp_loop = allowed_class (op);
952 } 795 }
796 while (!allowed_class (ob));
953 797
954 update_object (op, UP_OBJ_FACE); 798 update_object (ob, UP_OBJ_FACE);
955 esrv_update_item (UPD_FACE, op, op); 799 esrv_update_item (UPD_FACE, ob, ob);
956 op->update_stats (); 800 ob->update_stats ();
957 op->stats.hp = op->stats.maxhp; 801 ob->stats.hp = ob->stats.maxhp;
958 op->stats.sp = op->stats.maxsp; 802 ob->stats.sp = ob->stats.maxsp;
959 op->stats.grace = 0; 803 ob->stats.grace = 0;
960
961 if (op->msg)
962 new_draw_info (NDI_BLUE, 0, op, op->msg);
963
964 send_query (op->contr->ns, CS_QUERY_SINGLECHAR, "Press any key for the next race.\nPress `d' to play this race.\n");
965 return 0;
966} 804}
967 805
968void 806void
969flee_player (object *op) 807flee_player (object *op)
970{ 808{
976 LOG (llevDebug, "Fleeing player is dead.\n"); 814 LOG (llevDebug, "Fleeing player is dead.\n");
977 CLEAR_FLAG (op, FLAG_SCARED); 815 CLEAR_FLAG (op, FLAG_SCARED);
978 return; 816 return;
979 } 817 }
980 818
981 if (op->enemy == NULL) 819 if (!op->enemy)
982 { 820 {
983 LOG (llevDebug, "Fleeing player had no enemy.\n"); 821 LOG (llevDebug, "Fleeing player had no enemy.\n");
984 CLEAR_FLAG (op, FLAG_SCARED); 822 CLEAR_FLAG (op, FLAG_SCARED);
985 return; 823 return;
986 } 824 }
987 825
988 /* Seen some crashes here. Since we don't store an
989 * op->enemy_count, it is possible that something destroys the
990 * actual enemy, and the object is recycled.
991 */
992 if (op->enemy->map == NULL)
993 {
994 CLEAR_FLAG (op, FLAG_SCARED);
995 op->enemy = NULL;
996 return;
997 }
998
999 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0)) 826 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
1000 { 827 {
1001 op->enemy = NULL; 828 op->enemy = NULL;
1002 CLEAR_FLAG (op, FLAG_SCARED); 829 CLEAR_FLAG (op, FLAG_SCARED);
1003 return; 830 return;
1006 get_rangevector (op, op->enemy, &rv, 0); 833 get_rangevector (op, op->enemy, &rv, 0);
1007 834
1008 dir = absdir (4 + rv.direction); 835 dir = absdir (4 + rv.direction);
1009 for (diff = 0; diff < 3; diff++) 836 for (diff = 0; diff < 3; diff++)
1010 { 837 {
1011 int m = 1 - (RANDOM () & 2); 838 int m = 1 - rndm (2) * 2;
1012 839
1013 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 840 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op)))
1014 return; 841 return;
1015 } 842 }
1016 843
1017 /* Cornered, get rid of scared */ 844 /* Cornered, get rid of scared */
1018 CLEAR_FLAG (op, FLAG_SCARED); 845 CLEAR_FLAG (op, FLAG_SCARED);
1019 op->enemy = NULL; 846 op->enemy = NULL;
1020} 847}
1021 848
1022
1023/* check_pick sees if there is stuff to be picked up/picks up stuff. 849/* check_pick sees if there is stuff to be picked up/picks up stuff.
1024 * IT returns 1 if the player should keep on moving, 0 if he should 850 * It returns 1 if the player should keep on moving, 0 if he should
1025 * stop. 851 * stop.
1026 */ 852 */
1027int 853int
1028check_pick (object *op) 854check_pick (object *op)
1029{ 855{
1030 object *tmp, *next; 856 object *tmp, *next;
1031 int stop = 0; 857 int stop = 0;
1032 int j, k, wvratio; 858 int wvratio;
1033 char putstring[128], tmpstr[16];
1034 859
1035 /* if you're flying, you cna't pick up anything */ 860 /* if you're flying, you cna't pick up anything */
1036 if (op->move_type & MOVE_FLYING) 861 if (op->move_type & MOVE_FLYING)
1037 return 1; 862 return 1;
1038 863
1039 next = op->below; 864 next = op->below;
1040 865
866 int cnt = MAX_ITEM_PER_DROP;
867#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
868
1041 /* loop while there are items on the floor that are not marked as 869 /* loop while there are items on the floor that are not marked as
1042 * destroyed */ 870 * destroyed */
1043 while (next && !next->destroyed ()) 871 while (next && !next->destroyed ())
1044 { 872 {
1045 tmp = next; 873 tmp = next;
1046 next = tmp->below; 874 next = tmp->below;
1047 875
876 if (cnt <= 0)
877 {
878 op->failmsg ("Couldn't pickup all items at once.");
879 return 0;
880 }
881
1048 if (op->destroyed ()) 882 if (op->destroyed ())
1049 return 0; 883 return 0;
1050 884
1051 if (!can_pick (op, tmp)) 885 if (!can_pick (op, tmp))
1052 continue; 886 continue;
1053 887
1054 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 888 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1055 { 889 {
1056 if (item_matched_string (op, tmp, op->contr->search_str)) 890 if (item_matched_string (op, tmp, op->contr->search_str))
1057 pick_up (op, tmp); 891 CHK_PICK_PICKUP;
892
1058 continue; 893 continue;
1059 } 894 }
1060 895
1061 /* high not bit set? We're using the old autopickup model */ 896 /* pickup handling */
897 if (op->contr->mode & PU_DEBUG)
898 {
899 /* some debugging code to figure out item information */
900 const char *str = tmp->name
901 ? format ("item name: %s item type: %d weight/value: %d",
902 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))))
903 : format ("item name: %s item type: %d weight/value: %d",
904 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
905
906 new_draw_info (NDI_UNIQUE, 0, op, str);
907 }
908
909 if (op->contr->mode & PU_INHIBIT)
910 return 1;
911
912 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
913 return 1;
914
915 /* philosophy:
916 * It's easy to grab an item type from a pile, as long as it's
917 * generic. This takes no game-time. For more detailed pickups
918 * and selections, select-items should be used. This is a
919 * grab-as-you-run type mode that's really useful for arrows for
920 * example.
921 * The drawback: right now it has no frontend, so you need to
922 * stick the bits you want into a calculator in hex mode and then
923 * convert to decimal and then 'pickup <#>
924 */
925
926 /* the first two modes are exclusive: if NOTHING we return, if
927 * STOP then we stop. All the rest are applied sequentially,
928 * meaning if any test passes, the item gets picked up. */
929
930 /* if mode is set to pick nothing up, return */
931 if (op->contr->mode == PU_NOTHING)
932 return 1;
933
934 /* if mode is set to stop when encountering objects, return */
935 /* take STOP before INHIBIT since it doesn't actually pick
936 * anything up */
937 if (op->contr->mode & PU_STOP)
938 return 0;
939
940 /* useful for going into stores and not losing your settings... */
941 /* and for battles wher you don't want to get loaded down while
942 * fighting */
943 if (op->contr->mode & PU_INHIBIT)
944 return 1;
945
946 /* prevent us from turning into auto-thieves :) */
947 if (QUERY_FLAG (tmp, FLAG_UNPAID))
948 continue;
949
950 /* ignore known cursed objects */
951 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED)
952 continue;
953
954 /* all food and drink if desired */
955 /* question: don't pick up known-poisonous stuff? */
1062 if (!(op->contr->mode & PU_NEWMODE)) 956 if (op->contr->mode & PU_FOOD)
957 if (tmp->type == FOOD)
1063 { 958 {
1064 switch (op->contr->mode) 959 CHK_PICK_PICKUP;
960 continue;
961 }
962
963 if (op->contr->mode & PU_DRINK)
964 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)))
965 {
966 CHK_PICK_PICKUP;
967 continue;
968 }
969
970 if (op->contr->mode & PU_POTION)
971 if (tmp->type == POTION)
972 {
973 CHK_PICK_PICKUP;
974 continue;
975 }
976
977 /* spellbooks, skillscrolls and normal books/scrolls */
978 if (op->contr->mode & PU_SPELLBOOK)
979 if (tmp->type == SPELLBOOK)
980 {
981 CHK_PICK_PICKUP;
982 continue;
983 }
984
985 if (op->contr->mode & PU_SKILLSCROLL)
986 if (tmp->type == SKILLSCROLL)
987 {
988 CHK_PICK_PICKUP;
989 continue;
990 }
991
992 if (op->contr->mode & PU_READABLES)
993 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
994 {
995 CHK_PICK_PICKUP;
996 continue;
997 }
998
999 /* wands/staves/rods/horns */
1000 if (op->contr->mode & PU_MAGIC_DEVICE)
1001 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1002 {
1003 CHK_PICK_PICKUP;
1004 continue;
1005 }
1006
1007 /* pick up all magical items */
1008 if (op->contr->mode & PU_MAGICAL)
1009 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1010 {
1011 CHK_PICK_PICKUP;
1012 continue;
1013 }
1014
1015 if (op->contr->mode & PU_VALUABLES)
1016 {
1017 if (tmp->type == MONEY || tmp->type == GEM)
1065 { 1018 {
1066 case 0: 1019 CHK_PICK_PICKUP;
1067 return 1; /* don't pick up */ 1020 continue;
1068 case 1:
1069 pick_up (op, tmp);
1070 return 1;
1071 case 2:
1072 pick_up (op, tmp);
1073 return 0;
1074 case 3:
1075 return 0; /* stop before pickup */
1076 case 4:
1077 pick_up (op, tmp);
1078 break;
1079 case 5:
1080 pick_up (op, tmp);
1081 stop = 1;
1082 break;
1083 case 6:
1084 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1085 pick_up (op, tmp);
1086 break;
1087
1088 case 7:
1089 if (tmp->type == MONEY || tmp->type == GEM)
1090 pick_up (op, tmp);
1091 break;
1092
1093 default:
1094 /* use value density */
1095 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1096 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1097 pick_up (op, tmp);
1098 } 1021 }
1099 } 1022 }
1100 else 1023
1101 { /* old model */ 1024 /* rings & amulets - talismans seems to be typed AMULET */
1102 /* NEW pickup handling */
1103 if (op->contr->mode & PU_DEBUG) 1025 if (op->contr->mode & PU_JEWELS)
1026 if (tmp->type == RING || tmp->type == AMULET)
1104 { 1027 {
1105 /* some debugging code to figure out item information */ 1028 CHK_PICK_PICKUP;
1106 if (tmp->name != NULL)
1107 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1108 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1109 else
1110 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1111 &tmp->arch->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1112
1113 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1114 }
1115
1116 /* philosophy:
1117 * It's easy to grab an item type from a pile, as long as it's
1118 * generic. This takes no game-time. For more detailed pickups
1119 * and selections, select-items should be used. This is a
1120 * grab-as-you-run type mode that's really useful for arrows for
1121 * example.
1122 * The drawback: right now it has no frontend, so you need to
1123 * stick the bits you want into a calculator in hex mode and then
1124 * convert to decimal and then 'pickup <#>
1125 */
1126
1127 /* the first two modes are exclusive: if NOTHING we return, if
1128 * STOP then we stop. All the rest are applied sequentially,
1129 * meaning if any test passes, the item gets picked up. */
1130
1131 /* if mode is set to pick nothing up, return */
1132
1133 if (op->contr->mode & PU_NOTHING)
1134 return 1;
1135
1136 /* if mode is set to stop when encountering objects, return */
1137 /* take STOP before INHIBIT since it doesn't actually pick
1138 * anything up */
1139
1140 if (op->contr->mode & PU_STOP)
1141 return 0;
1142
1143 /* useful for going into stores and not losing your settings... */
1144 /* and for battles wher you don't want to get loaded down while
1145 * fighting */
1146 if (op->contr->mode & PU_INHIBIT)
1147 return 1;
1148
1149 /* prevent us from turning into auto-thieves :) */
1150 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1151 continue; 1029 continue;
1030 }
1152 1031
1153 /* ignore known cursed objects */ 1032 /* we don't forget dragon food */
1154 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1033 if (op->contr->mode & PU_FLESH)
1034 if (tmp->type == FLESH)
1035 {
1036 CHK_PICK_PICKUP;
1155 continue; 1037 continue;
1038 }
1156 1039
1157 /* all food and drink if desired */ 1040 /* bows and arrows. Bows are good for selling! */
1158 /* question: don't pick up known-poisonous stuff? */ 1041 if (op->contr->mode & PU_BOW)
1042 if (tmp->type == BOW)
1043 {
1044 CHK_PICK_PICKUP;
1045 continue;
1046 }
1047
1048 if (op->contr->mode & PU_ARROW)
1049 if (tmp->type == ARROW)
1050 {
1051 CHK_PICK_PICKUP;
1052 continue;
1053 }
1054
1055 /* all kinds of armor etc. */
1056 if (op->contr->mode & PU_ARMOUR)
1057 if (tmp->type == ARMOUR)
1058 {
1059 CHK_PICK_PICKUP;
1060 continue;
1061 }
1062
1063 if (op->contr->mode & PU_HELMET)
1064 if (tmp->type == HELMET)
1065 {
1066 CHK_PICK_PICKUP;
1067 continue;
1068 }
1069
1070 if (op->contr->mode & PU_SHIELD)
1071 if (tmp->type == SHIELD)
1072 {
1073 CHK_PICK_PICKUP;
1074 continue;
1075 }
1076
1159 if (op->contr->mode & PU_FOOD) 1077 if (op->contr->mode & PU_BOOTS)
1160 if (tmp->type == FOOD) 1078 if (tmp->type == BOOTS)
1079 {
1080 CHK_PICK_PICKUP;
1081 continue;
1082 }
1083
1084 if (op->contr->mode & PU_GLOVES)
1085 if (tmp->type == GLOVES)
1086 {
1087 CHK_PICK_PICKUP;
1088 continue;
1089 }
1090
1091 if (op->contr->mode & PU_CLOAK)
1092 if (tmp->type == CLOAK)
1093 {
1094 CHK_PICK_PICKUP;
1095 continue;
1096 }
1097
1098 /* hoping to catch throwing daggers here */
1099 if (op->contr->mode & PU_MISSILEWEAPON)
1100 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1101 {
1102 CHK_PICK_PICKUP;
1103 continue;
1104 }
1105
1106 /* careful: chairs and tables are weapons! */
1107 if (op->contr->mode & PU_ALLWEAPON)
1108 {
1109 if (tmp->type == WEAPON)
1110 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1161 { 1111 {
1162 pick_up (op, tmp); 1112 CHK_PICK_PICKUP;
1163 continue; 1113 continue;
1164 } 1114 }
1115 }
1165 1116
1117 /* misc stuff that's useful */
1166 if (op->contr->mode & PU_DRINK) 1118 if (op->contr->mode & PU_KEY)
1167 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1119 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1168 { 1120 {
1169 pick_up (op, tmp); 1121 CHK_PICK_PICKUP;
1170 continue; 1122 continue;
1171 } 1123 }
1172 1124
1125 /* any of the last 4 bits set means we use the ratio for value
1126 * pickups */
1173 if (op->contr->mode & PU_POTION) 1127 if (op->contr->mode & PU_RATIO)
1174 if (tmp->type == POTION) 1128 {
1129 /* use value density to decide what else to grab */
1130 /* >=7 was >= op->contr->mode */
1131 /* >=7 is the old standard setting. Now we take the last 4 bits
1175 { 1132 */
1176 pick_up (op, tmp);
1177 continue;
1178 }
1179
1180 /* spellbooks, skillscrolls and normal books/scrolls */
1181 if (op->contr->mode & PU_SPELLBOOK)
1182 if (tmp->type == SPELLBOOK)
1183 {
1184 pick_up (op, tmp);
1185 continue;
1186 }
1187
1188 if (op->contr->mode & PU_SKILLSCROLL)
1189 if (tmp->type == SKILLSCROLL)
1190 {
1191 pick_up (op, tmp);
1192 continue;
1193 }
1194
1195 if (op->contr->mode & PU_READABLES)
1196 if (tmp->type == BOOK || tmp->type == SCROLL)
1197 {
1198 pick_up (op, tmp);
1199 continue;
1200 }
1201
1202 /* wands/staves/rods/horns */
1203 if (op->contr->mode & PU_MAGIC_DEVICE)
1204 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1205 {
1206 pick_up (op, tmp);
1207 continue;
1208 }
1209
1210 /* pick up all magical items */
1211 if (op->contr->mode & PU_MAGICAL) 1133 wvratio = op->contr->mode & PU_RATIO;
1212 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1134 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1213 {
1214 pick_up (op, tmp);
1215 continue;
1216 }
1217
1218 if (op->contr->mode & PU_VALUABLES)
1219 { 1135 {
1220 if (tmp->type == MONEY || tmp->type == GEM) 1136#if 0
1137 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1138 if (tmp->name != NULL)
1221 { 1139 {
1222 pick_up (op, tmp); 1140 fprintf (stderr, "%s", tmp->name);
1223 continue;
1224 } 1141 }
1225 }
1226
1227 /* rings & amulets - talismans seems to be typed AMULET */
1228 if (op->contr->mode & PU_JEWELS)
1229 if (tmp->type == RING || tmp->type == AMULET)
1230 {
1231 pick_up (op, tmp);
1232 continue;
1233 }
1234
1235 /* we don't forget dragon food */
1236 if (op->contr->mode & PU_FLESH)
1237 if (tmp->type == FLESH)
1238 {
1239 pick_up (op, tmp);
1240 continue;
1241 }
1242
1243 /* bows and arrows. Bows are good for selling! */
1244 if (op->contr->mode & PU_BOW)
1245 if (tmp->type == BOW)
1246 {
1247 pick_up (op, tmp);
1248 continue;
1249 }
1250
1251 if (op->contr->mode & PU_ARROW)
1252 if (tmp->type == ARROW)
1253 {
1254 pick_up (op, tmp);
1255 continue;
1256 }
1257
1258 /* all kinds of armor etc. */
1259 if (op->contr->mode & PU_ARMOUR)
1260 if (tmp->type == ARMOUR)
1261 {
1262 pick_up (op, tmp);
1263 continue;
1264 }
1265
1266 if (op->contr->mode & PU_HELMET)
1267 if (tmp->type == HELMET)
1268 {
1269 pick_up (op, tmp);
1270 continue;
1271 }
1272
1273 if (op->contr->mode & PU_SHIELD)
1274 if (tmp->type == SHIELD)
1275 {
1276 pick_up (op, tmp);
1277 continue;
1278 }
1279
1280 if (op->contr->mode & PU_BOOTS)
1281 if (tmp->type == BOOTS)
1282 {
1283 pick_up (op, tmp);
1284 continue;
1285 }
1286
1287 if (op->contr->mode & PU_GLOVES)
1288 if (tmp->type == GLOVES)
1289 {
1290 pick_up (op, tmp);
1291 continue;
1292 }
1293
1294 if (op->contr->mode & PU_CLOAK)
1295 if (tmp->type == CLOAK)
1296 {
1297 pick_up (op, tmp);
1298 continue;
1299 }
1300
1301 /* hoping to catch throwing daggers here */
1302 if (op->contr->mode & PU_MISSILEWEAPON)
1303 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1304 {
1305 pick_up (op, tmp);
1306 continue;
1307 }
1308
1309 /* careful: chairs and tables are weapons! */
1310 if (op->contr->mode & PU_ALLWEAPON)
1311 {
1312 if (tmp->type == WEAPON && tmp->name != NULL)
1313 {
1314 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->name, "table") == NULL &&
1315 strstr (tmp->name, "chair") && strstr (tmp->arch->name, "chair") == NULL)
1316 {
1317 pick_up (op, tmp);
1318 continue;
1319 }
1320 }
1321
1322 if (tmp->type == WEAPON && tmp->name == NULL)
1323 {
1324 if (strstr (tmp->arch->name, "table") == NULL && strstr (tmp->arch->name, "chair") == NULL)
1325 {
1326 pick_up (op, tmp);
1327 continue;
1328 }
1329 }
1330 }
1331
1332 /* misc stuff that's useful */
1333 if (op->contr->mode & PU_KEY)
1334 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1335 {
1336 pick_up (op, tmp);
1337 continue;
1338 }
1339
1340 /* any of the last 4 bits set means we use the ratio for value
1341 * pickups */
1342 if (op->contr->mode & PU_RATIO)
1343 {
1344 /* use value density to decide what else to grab */
1345 /* >=7 was >= op->contr->mode */
1346 /* >=7 is the old standard setting. Now we take the last 4 bits
1347 * and multiply them by 5, giving 0..15*5== 5..75 */
1348 wvratio = (op->contr->mode & PU_RATIO) * 5;
1349 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio)
1350 {
1351 pick_up (op, tmp);
1352#if 0
1353 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1354 if (tmp->name != NULL)
1355 {
1356 fprintf (stderr, "%s", tmp->name);
1357 }
1358 else 1142 else
1359 fprintf (stderr, "%s", tmp->arch->name); 1143 fprintf (stderr, "%s", tmp->arch->archname);
1360 fprintf (stderr, ",%d] = ", tmp->type); 1144 fprintf (stderr, ",%d] = ", tmp->type);
1361 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1145 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1362#endif 1146#endif
1147 CHK_PICK_PICKUP;
1363 continue; 1148 continue;
1364 }
1365 } 1149 }
1366 } /* the new pickup model */ 1150 } /* the new pickup model */
1367 } 1151 }
1368 1152
1369 return !stop; 1153 return !stop;
1375 * found object is returned. 1159 * found object is returned.
1376 */ 1160 */
1377object * 1161object *
1378find_arrow (object *op, const char *type) 1162find_arrow (object *op, const char *type)
1379{ 1163{
1380 object *tmp = NULL;
1381
1382 for (op = op->inv; op; op = op->below) 1164 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1383 if (!tmp && op->type == CONTAINER && op->race == type && QUERY_FLAG (op, FLAG_APPLIED))
1384 tmp = find_arrow (op, type);
1385 else if (op->type == ARROW && op->race == type) 1165 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1166 return splay (tmp);
1167
1168 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1169 if (tmp->type == CONTAINER && QUERY_FLAG (tmp, FLAG_APPLIED) && !strcmp (&tmp->race, type))
1170 if (object *arrow = find_arrow (tmp, type))
1171 {
1172 splay (tmp);
1386 return op; 1173 return arrow;
1174 }
1175
1387 return tmp; 1176 return 0;
1388} 1177}
1389 1178
1390/* 1179/*
1391 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1180 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1392 * against the target. A full test is not performed, simply a basic test 1181 * against the target. A full test is not performed, simply a basic test
1393 * of resistances. The archer is making a quick guess at what he sees down 1182 * of resistances. The archer is making a quick guess at what he sees down
1394 * the hall. Failing that it does it's best to pick the highest plus arrow. 1183 * the hall. Failing that it does it's best to pick the highest plus arrow.
1395 */ 1184 */
1396
1397object * 1185object *
1398find_better_arrow (object *op, object *target, const char *type, int *better) 1186find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1399{ 1187{
1400 object *tmp = NULL, *arrow, *ntmp; 1188 object *tmp = NULL, *arrow, *ntmp;
1401 int attacknum, attacktype, betterby = 0, i; 1189 int attacknum, attacktype, betterby = 0, i;
1402 1190
1403 if (!type) 1191 if (!type)
1407 { 1195 {
1408 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1196 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED))
1409 { 1197 {
1410 i = 0; 1198 i = 0;
1411 ntmp = find_better_arrow (arrow, target, type, &i); 1199 ntmp = find_better_arrow (arrow, target, type, &i);
1200
1412 if (i > betterby) 1201 if (i > betterby)
1413 { 1202 {
1414 tmp = ntmp; 1203 tmp = ntmp;
1415 betterby = i; 1204 betterby = i;
1416 } 1205 }
1417 } 1206 }
1418 else if (arrow->type == ARROW && arrow->race == type) 1207 else if (arrow->type == ARROW && arrow->race == type)
1419 { 1208 {
1420 /* allways prefer assasination/slaying */ 1209 /* allways prefer assasination/slaying */
1421 if (target->race != NULL && arrow->slaying != NULL && strstr (arrow->slaying, target->race)) 1210 if (target->race && arrow->slaying.contains (target->race))
1422 { 1211 {
1423 if (arrow->attacktype & AT_DEATH) 1212 if (arrow->attacktype & AT_DEATH)
1424 { 1213 {
1425 *better = 100; 1214 *better = 100;
1426 return arrow; 1215 return arrow;
1434 else 1223 else
1435 { 1224 {
1436 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++) 1225 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++)
1437 { 1226 {
1438 attacktype = 1 << attacknum; 1227 attacktype = 1 << attacknum;
1439 if ((arrow->attacktype & attacktype) && (target->arch->clone.resist[attacknum]) < 0) 1228 if ((arrow->attacktype & attacktype) && (target->arch->resist[attacknum]) < 0)
1440 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100) > betterby) 1229 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100) > betterby)
1441 { 1230 {
1442 tmp = arrow; 1231 tmp = arrow;
1443 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100; 1232 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1444 } 1233 }
1445 } 1234 }
1235
1446 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1236 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1447 { 1237 {
1448 tmp = arrow; 1238 tmp = arrow;
1449 betterby = 2 + arrow->magic + arrow->stats.dam; 1239 betterby = 2 + arrow->magic + arrow->stats.dam;
1450 } 1240 }
1241
1451 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1242 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1452 { 1243 {
1453 tmp = arrow; 1244 tmp = arrow;
1454 betterby = 1 + arrow->magic + arrow->stats.dam; 1245 betterby = 1 + arrow->magic + arrow->stats.dam;
1455 } 1246 }
1456 } 1247 }
1457 } 1248 }
1458 } 1249 }
1250
1459 if (tmp == NULL && arrow == NULL) 1251 if (tmp == NULL && arrow == NULL)
1460 return find_arrow (op, type); 1252 return find_arrow (op, type);
1461 1253
1462 *better = betterby; 1254 *better = betterby;
1463 return tmp; 1255 return tmp;
1467 * find_better_arrow to find a decent arrow to use. 1259 * find_better_arrow to find a decent arrow to use.
1468 * op = the shooter 1260 * op = the shooter
1469 * type = bow->race 1261 * type = bow->race
1470 * dir = fire direction 1262 * dir = fire direction
1471 */ 1263 */
1472
1473object * 1264object *
1474pick_arrow_target (object *op, const char *type, int dir) 1265pick_arrow_target (object *op, shstr_cmp type, int dir)
1475{ 1266{
1476 object *tmp = NULL; 1267 object *tmp = NULL;
1477 maptile *m; 1268 maptile *m;
1478 int i, mflags, found, number; 1269 int i, mflags, found, number;
1479 sint16 x, y; 1270 sint16 x, y;
1494 for (i = 0, found = 0; i < 20; i++) 1285 for (i = 0, found = 0; i < 20; i++)
1495 { 1286 {
1496 x += freearr_x[dir]; 1287 x += freearr_x[dir];
1497 y += freearr_y[dir]; 1288 y += freearr_y[dir];
1498 mflags = get_map_flags (m, &m, x, y, &x, &y); 1289 mflags = get_map_flags (m, &m, x, y, &x, &y);
1290
1499 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1291 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1500 { 1292 {
1501 tmp = NULL; 1293 tmp = 0;
1502 break; 1294 break;
1503 } 1295 }
1504 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1296 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1505 { 1297 {
1506 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1298 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1507 * perhaps a bad assumption. 1299 * perhaps a bad assumption.
1508 */ 1300 */
1509 tmp = NULL; 1301 tmp = 0;
1510 break; 1302 break;
1511 } 1303 }
1304
1512 if (mflags & P_IS_ALIVE) 1305 if (mflags & P_IS_ALIVE)
1513 {
1514 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1306 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1515 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1307 if (QUERY_FLAG (tmp, FLAG_ALIVE))
1516 {
1517 found++;
1518 break;
1519 }
1520 if (found)
1521 break; 1308 break;
1522 }
1523 } 1309 }
1524 if (tmp == NULL) 1310
1311 if (!tmp)
1525 return find_arrow (op, type); 1312 return find_arrow (op, type);
1526 1313
1527 if (tmp->head) 1314 if (tmp->head)
1528 tmp = tmp->head; 1315 tmp = tmp->head;
1529 1316
1542 */ 1329 */
1543int 1330int
1544fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy) 1331fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy)
1545{ 1332{
1546 object *left, *bow; 1333 object *left, *bow;
1547 int bowspeed, mflags; 1334 int mflags;
1548 maptile *m; 1335 maptile *m;
1549 1336
1550 if (!dir) 1337 if (!dir)
1551 { 1338 {
1552 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!"); 1339 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!");
1553 return 0; 1340 return 0;
1554 } 1341 }
1555 1342
1556 if (op->type == PLAYER) 1343 if (op->contr)
1557 bow = op->contr->ranges[range_bow]; 1344 bow = op->current_weapon;
1558 else 1345 else
1559 { 1346 {
1560 for (bow = op->inv; bow; bow = bow->below) 1347 for (bow = op->inv; bow; bow = bow->below)
1561 /* Don't check for applied - monsters don't apply bows - in that way, they 1348 /* Don't check for applied - monsters don't apply bows - in that way, they
1562 * don't need to switch back and forth between bows and weapons. 1349 * don't need to switch back and forth between bows and weapons.
1567 if (!bow) 1354 if (!bow)
1568 { 1355 {
1569 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1356 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1570 return 0; 1357 return 0;
1571 } 1358 }
1359
1360 // optimisation: move object to top so we will find it quickly again
1361 splay (bow);
1572 } 1362 }
1573 1363
1574 if (!bow->race || !bow->skill) 1364 if (!bow->race || !bow->skill)
1575 { 1365 {
1576 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1366 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1577 return 0; 1367 return 0;
1578 } 1368 }
1579
1580 bowspeed = bow->stats.sp + dex_bonus[op->stats.Dex];
1581
1582 /* penalize ROF for bestarrow */
1583 if (op->type == PLAYER && op->contr->bowtype == bow_bestarrow)
1584 bowspeed -= dex_bonus[op->stats.Dex] + 5;
1585
1586 if (bowspeed < 1)
1587 bowspeed = 1;
1588 1369
1589 if (arrow == NULL) 1370 if (arrow == NULL)
1590 { 1371 {
1591 if ((arrow = find_arrow (op, bow->race)) == NULL) 1372 if ((arrow = find_arrow (op, bow->race)) == NULL)
1592 { 1373 {
1593 if (op->type == PLAYER) 1374 if (op->type == PLAYER)
1594 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1375 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1595 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1376 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1596 else 1377 else
1597 CLEAR_FLAG (op, FLAG_READY_BOW); 1378 CLEAR_FLAG (op, FLAG_READY_BOW);
1379
1598 return 0; 1380 return 0;
1599 } 1381 }
1600 } 1382 }
1601 1383
1602 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy); 1384 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy);
1610 } 1392 }
1611 1393
1612 /* this should not happen, but sometimes does */ 1394 /* this should not happen, but sometimes does */
1613 if (arrow->nrof == 0) 1395 if (arrow->nrof == 0)
1614 { 1396 {
1397 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1615 arrow->destroy (); 1398 arrow->destroy ();
1616 return 0; 1399 return 0;
1617 } 1400 }
1618 1401
1619 left = arrow; /* these are arrows left to the player */ 1402 left = arrow; /* these are arrows left to the player */
1620 arrow = get_split_ob (arrow, 1); 1403 arrow = arrow->split ();
1621 if (!arrow) 1404 if (!arrow)
1622 { 1405 {
1623 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1406 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1624 return 0; 1407 return 0;
1625 } 1408 }
1626 1409
1627 arrow->set_owner (op); 1410 arrow->set_owner (op);
1628 arrow->skill = bow->skill; 1411 arrow->skill = bow->skill;
1629 arrow->direction = dir; 1412 arrow->direction = dir;
1630 1413
1414 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1415 arrow->stats.hp = arrow->stats.dam;
1416 arrow->stats.grace = arrow->attacktype;
1417 arrow->custom_name = arrow->slaying;
1418
1419#if 0
1420 if (player *pl = op->contr)
1421 {
1422 float speed = pl->weapon_sp;
1423
1424 /* penalize ROF for bestarrow */
1425 if (pl->bowtype == bow_bestarrow)
1426 speed *= .9f;
1427 else
1428 speed *= 1.f + dex_bonus[op->stats.Dex] * .2f;
1429
1430 op->speed_left += speed - op->speed;
1431 }
1432#endif
1433
1434 SET_ANIMATION (arrow, arrow->direction);
1435
1436 /* update the speed */
1437 arrow->speed = ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1438 + bow->stats.dam / 7.f;
1439
1440 arrow->set_speed (max (arrow->speed, 2.f));
1441 arrow->speed_left = 0;
1442
1443 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1444
1631 if (op->type == PLAYER) 1445 if (op->type == PLAYER)
1632 { 1446 {
1633 op->speed_left = 0.01 - (float) FABS (op->speed) * 100 / bowspeed;
1634 op->update_stats ();
1635 }
1636
1637 SET_ANIMATION (arrow, arrow->direction);
1638 arrow->stats.sp = arrow->stats.wc; /* save original wc and dam */
1639 arrow->stats.hp = arrow->stats.dam;
1640 arrow->stats.grace = arrow->attacktype;
1641 if (arrow->slaying != NULL)
1642 arrow->spellarg = strdup (arrow->slaying);
1643
1644 /* Note that this was different for monsters - they got their level
1645 * added to the damage. I think the strength bonus is more proper.
1646 */
1647
1648 arrow->stats.dam += (QUERY_FLAG (bow, FLAG_NO_STRENGTH) ? 0 : dam_bonus[op->stats.Str]) + bow->stats.dam + bow->magic + arrow->magic;
1649
1650 /* update the speed */
1651 arrow->speed = (float) ((QUERY_FLAG (bow, FLAG_NO_STRENGTH) ?
1652 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.0 + (float) bow->stats.dam / 7.0;
1653
1654 arrow->set_speed (max (arrow->speed, 1.0));
1655 arrow->speed_left = 0;
1656
1657 if (op->type == PLAYER)
1658 {
1659 arrow->stats.wc = 20 - bow->magic - arrow->magic -
1660 (op->chosen_skill ? op->chosen_skill->level : op->level) -
1661 dex_bonus[op->stats.Dex] - thaco_bonus[op->stats.Str] - arrow->stats.wc - bow->stats.wc + wc_mod;
1662
1663 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level; 1447 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level;
1448 wc -= dex_bonus[op->stats.Dex];
1449
1450 if (!arrow->slaying)
1451 arrow->slaying = op->slaying;
1452
1453 arrow->attacktype |= op->attacktype;
1664 } 1454 }
1665 else 1455 else
1666 { 1456 {
1667 arrow->stats.wc = op->stats.wc - bow->magic - arrow->magic - arrow->stats.wc + wc_mod;
1668 arrow->level = op->level; 1457 arrow->level = op->level;
1669 } 1458 arrow->stats.wc -= bow->magic;
1670 1459
1671 if (arrow->attacktype == AT_PHYSICAL) 1460 if (!arrow->slaying)
1461 arrow->slaying = bow->slaying;
1462
1672 arrow->attacktype |= bow->attacktype; 1463 arrow->attacktype |= bow->attacktype;
1464 }
1673 1465
1674 if (bow->slaying) 1466 wc -= arrow->level;
1675 arrow->slaying = bow->slaying; 1467 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1676 1468
1469 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1677 arrow->move_type = MOVE_FLY_LOW; 1470 arrow->move_type = MOVE_FLY_LOW;
1678 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1471 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1679 1472
1680 play_sound_map (op->map, op->x, op->y, SOUND_FIRE_ARROW); 1473 op->play_sound (sound_find ("fire_arrow"));
1681 m->insert (arrow, sx, sy, op); 1474 m->insert (arrow, sx, sy, op);
1682 1475
1683 if (!arrow->destroyed ()) 1476 if (!arrow->destroyed ())
1684 move_arrow (arrow); 1477 move_arrow (arrow);
1685
1686 if (op->type == PLAYER)
1687 {
1688 if (left->destroyed ())
1689 esrv_del_item (op->contr, left->count);
1690 else
1691 esrv_send_item (op, left);
1692 }
1693 1478
1694 return 1; 1479 return 1;
1695} 1480}
1696 1481
1697/* Special fire code for players - this takes into 1482/* Special fire code for players - this takes into
1702 * hence the function name. 1487 * hence the function name.
1703 */ 1488 */
1704int 1489int
1705player_fire_bow (object *op, int dir) 1490player_fire_bow (object *op, int dir)
1706{ 1491{
1707 int ret = 0, wcmod = 0; 1492 int ret;
1708 1493
1709 if (op->contr->bowtype == bow_bestarrow) 1494 if (op->contr->bowtype == bow_bestarrow)
1710 { 1495 {
1711 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranges[range_bow]->race, dir), dir, 0, op->x, op->y); 1496 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1712 } 1497 }
1713 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1498 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1714 { 1499 {
1715 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1500 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1716 wcmod = -1;
1717
1718 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1501 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1719 } 1502 }
1720 else if (op->contr->bowtype == bow_threewide) 1503 else if (op->contr->bowtype == bow_threewide)
1721 { 1504 {
1722 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1505 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1723 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1506 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]);
1724 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1507 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]);
1725 } 1508 }
1726 else if (op->contr->bowtype == bow_spreadshot) 1509 else if (op->contr->bowtype == bow_spreadshot)
1727 { 1510 {
1728 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1511 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1729 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1512 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1730 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1513 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1731
1732 } 1514 }
1733 else 1515 else
1734 { 1516 {
1735 /* Simple case */ 1517 /* Simple case */
1736 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1518 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1737 } 1519 }
1520
1738 return ret; 1521 return ret;
1739} 1522}
1740
1741 1523
1742/* Fires a misc (wand/rod/horn) object in 'dir'. 1524/* Fires a misc (wand/rod/horn) object in 'dir'.
1743 * Broken apart from 'fire' to keep it more readable. 1525 * Broken apart from 'fire' to keep it more readable.
1744 */ 1526 */
1745void 1527void
1746fire_misc_object (object *op, int dir) 1528fire_misc_object (object *op, int dir)
1747{ 1529{
1748 object *item; 1530 object *item = op->contr->ranged_ob;
1749 1531
1750 if (!op->contr->ranges[range_misc]) 1532 if (!item)
1751 { 1533 {
1752 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied."); 1534 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied.");
1753 return; 1535 return;
1754 } 1536 }
1755 1537
1756 item = op->contr->ranges[range_misc];
1757 if (!item->inv) 1538 if (!item->inv)
1758 { 1539 {
1759 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1540 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1760 return; 1541 return;
1761 } 1542 }
1543
1544 if (!op->change_weapon (item))
1545 return;
1546
1762 if (item->type == WAND) 1547 if (item->type == WAND)
1763 { 1548 {
1764 if (item->stats.food <= 0) 1549 if (item->stats.food <= 0)
1765 { 1550 {
1766 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1551 op->contr->play_sound (sound_find ("wand_poof"));
1767 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0)); 1552 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0));
1553
1768 return; 1554 return;
1769 } 1555 }
1770 } 1556 }
1771 else if (item->type == ROD || item->type == HORN) 1557 else if (item->type == ROD || item->type == HORN)
1772 { 1558 {
1773 if (item->stats.hp < MAX (item->inv->stats.sp, item->inv->stats.grace)) 1559 sint16 spell_sp = MAX (item->inv->stats.sp, item->inv->stats.grace);
1560
1561 // using the maximum of the rods charge allows at least one spell cast
1562 // for a rod or horn, this fixes some broken rods.
1563 if (item->stats.hp < MIN (spell_sp, item->stats.maxhp))
1774 { 1564 {
1775 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1565 op->contr->play_sound (sound_find ("wand_poof"));
1566
1776 if (item->type == ROD) 1567 if (item->type == ROD)
1777 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1568 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1778 else 1569 else
1779 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0)); 1570 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0));
1571
1780 return; 1572 return;
1781 } 1573 }
1782 } 1574 }
1783 1575
1784 if (cast_spell (op, item, dir, item->inv, NULL)) 1576 if (cast_spell (op, item, dir, item->inv, NULL))
1785 { 1577 {
1786 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1578 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1579
1787 if (item->type == WAND) 1580 if (item->type == WAND)
1788 { 1581 {
1789 if (!(--item->stats.food)) 1582 if (!(--item->stats.food))
1790 { 1583 {
1791 object *tmp; 1584 object *tmp;
1792 1585
1793 if (item->arch) 1586 if (item->arch)
1794 { 1587 {
1795 CLEAR_FLAG (item, FLAG_ANIMATE); 1588 CLEAR_FLAG (item, FLAG_ANIMATE);
1796 item->face = item->arch->clone.face; 1589 item->face = item->arch->face;
1797 item->set_speed (0); 1590 item->set_speed (0);
1798 } 1591 }
1799 1592
1800 if ((tmp = item->in_player ())) 1593 if (object *pl = item->visible_to ())
1801 esrv_update_item (UPD_ANIM, tmp, item); 1594 esrv_update_item (UPD_ANIM, pl, item);
1802 } 1595 }
1803 } 1596 }
1804 else if (item->type == ROD || item->type == HORN) 1597 else if (item->type == ROD || item->type == HORN)
1805 drain_rod_charge (item); 1598 drain_rod_charge (item);
1806 } 1599 }
1807} 1600}
1808 1601
1809/* Received a fire command for the player - go and do it. 1602/* Received a fire command for the player - go and do it.
1810 */ 1603 */
1811void 1604bool
1812fire (object *op, int dir) 1605fire (object *op, int dir)
1813{ 1606{
1814 int spellcost = 0; 1607 int spellcost = 0;
1608
1609 player *pl = op->contr;
1610
1611 if (pl->golem)
1612 {
1613 control_golem (op->contr->golem, dir);
1614 return false;
1615 }
1616
1617 object *ob = pl->ranged_ob;
1618
1619 if (!ob)
1620 return false;
1621
1622 if (op->speed_left > 0.f)
1623 --op->speed_left;
1624 else
1625 return false;
1626
1627 if (!op->change_weapon (ob))
1628 return false;
1815 1629
1816 /* check for loss of invisiblity/hide */ 1630 /* check for loss of invisiblity/hide */
1817 if (action_makes_visible (op)) 1631 if (action_makes_visible (op))
1818 make_visible (op); 1632 make_visible (op);
1819 1633
1820 switch (op->contr->shoottype) 1634 switch (ob->type)
1821 { 1635 {
1822 case range_none: 1636 case BOW:
1823 return;
1824
1825 case range_bow:
1826 player_fire_bow (op, dir); 1637 player_fire_bow (op, dir);
1827 return; 1638 break;
1828 1639
1829 case range_magic: /* Casting spells */ 1640 case SPELL:
1830 spellcost = (cast_spell (op, op, dir, op->contr->ranges[range_magic], op->contr->spellparam[0] ? op->contr->spellparam : 0)); 1641 spellcost = cast_spell (op, op, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1831 return; 1642 break;
1832 1643
1833 case range_misc: 1644 case BUILDER:
1645 apply_map_builder (op, dir);
1646 break;
1647
1648 case SKILL:
1649 do_skill (op, op, ob, dir, 0);
1650 break;
1651
1652 default:
1834 fire_misc_object (op, dir); 1653 fire_misc_object (op, dir);
1835 return; 1654 break;
1836
1837 case range_golem: /* Control summoned monsters from scrolls */
1838 if (QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
1839 {
1840 op->contr->ranges[range_golem] = 0;
1841 op->contr->shoottype = range_none;
1842 }
1843 else
1844 control_golem (op->contr->ranges[range_golem], dir);
1845 return;
1846
1847 case range_skill:
1848 if (!op->chosen_skill)
1849 {
1850 if (op->type == PLAYER)
1851 new_draw_info (NDI_UNIQUE, 0, op, "You have no applicable skill to use.");
1852 return;
1853 }
1854
1855 do_skill (op, op, op->chosen_skill, dir, NULL);
1856 return;
1857 case range_builder:
1858 apply_map_builder (op, dir);
1859 return;
1860 default:
1861 new_draw_info (NDI_UNIQUE, 0, op, "Illegal shoot type.");
1862 return;
1863 } 1655 }
1864}
1865 1656
1657 return true;
1658}
1866 1659
1867 1660static object *
1868/* find_key
1869 * We try to find a key for the door as passed. If we find a key
1870 * and successfully use it, we return the key, otherwise NULL
1871 * This function merges both normal and locked door, since the logic
1872 * for both is the same - just the specific key is different.
1873 * pl is the player,
1874 * inv is the objects inventory to searched
1875 * door is the door we are trying to match against.
1876 * This function can be called recursively to search containers.
1877 */
1878
1879object *
1880find_key (object *pl, object *container, object *door) 1661find_key_ (object *pl, object *container, object *door)
1881{ 1662{
1882 object *tmp, *key; 1663 object *tmp, *key;
1883 1664
1884 /* Should not happen, but sanity checking is never bad */ 1665 /* Should not happen, but sanity checking is never bad */
1885 if (container->inv == NULL) 1666 if (!container->inv)
1886 return NULL; 1667 return 0;
1887 1668
1888 /* First, lets try to find a key in the top level inventory */ 1669 /* First, lets try to find a key in the top level inventory */
1889 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1670 for (tmp = container->inv; tmp; tmp = tmp->below)
1890 { 1671 {
1891 if (door->type == DOOR && tmp->type == KEY) 1672 if (door->type == DOOR && tmp->type == KEY)
1892 break; 1673 break;
1674
1893 /* For sanity, we should really check door type, but other stuff 1675 /* For sanity, we should really check door type, but other stuff
1894 * (like containers) can be locked with special keys 1676 * (like containers) can be locked with special keys
1895 */ 1677 */
1896 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1678 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1897 break; 1679 break;
1898 } 1680 }
1681
1899 /* No key found - lets search inventories now */ 1682 /* No key found - lets search inventories now */
1900 /* If we find and use a key in an inventory, return at that time. 1683 /* If we find and use a key in an inventory, return at that time.
1901 * otherwise, if we search all the inventories and still don't find 1684 * otherwise, if we search all the inventories and still don't find
1902 * a key, return 1685 * a key, return
1903 */ 1686 */
1904 if (!tmp) 1687 if (!tmp)
1905 { 1688 {
1906 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1689 for (tmp = container->inv; tmp; tmp = tmp->below)
1907 {
1908 /* No reason to search empty containers */ 1690 /* No reason to search empty containers */
1909 if (tmp->type == CONTAINER && tmp->inv) 1691 if (tmp->type == CONTAINER && tmp->inv)
1910 {
1911 if ((key = find_key (pl, tmp, door)) != NULL) 1692 if ((key = find_key_ (pl, tmp, door)))
1912 return key; 1693 return key;
1913 } 1694
1914 }
1915 if (!tmp) 1695 if (!tmp)
1916 return NULL; 1696 return 0;
1917 } 1697 }
1698
1918 /* We get down here if we have found a key. Now if its in a container, 1699 /* We get down here if we have found a key. Now if its in a container,
1919 * see if we actually want to use it 1700 * see if we actually want to use it
1920 */ 1701 */
1921 if (pl != container) 1702 if (pl != container)
1922 { 1703 {
1923 /* Only let players use keys in containers */ 1704 /* Only let players use keys in containers */
1924 if (!pl->contr) 1705 if (!pl->contr)
1925 return NULL; 1706 return 0;
1707
1926 /* cases where this fails: 1708 /* cases where this fails:
1927 * If we only search the player inventory, return now since we 1709 * If we only search the player inventory, return now since we
1928 * are not in the players inventory. 1710 * are not in the players inventory.
1929 * If the container is not active, return now since only active 1711 * If the container is not active, return now since only active
1930 * containers can be used. 1712 * containers can be used.
1934 * inv must have been an container and must have been active. 1716 * inv must have been an container and must have been active.
1935 * 1717 *
1936 * Change the color so that the message doesn't disappear with 1718 * Change the color so that the message doesn't disappear with
1937 * all the others. 1719 * all the others.
1938 */ 1720 */
1939 if (pl->contr->usekeys == key_inventory || 1721 if (pl->contr->usekeys == key_inventory
1940 !QUERY_FLAG (container, FLAG_APPLIED) || 1722 || !QUERY_FLAG (container, FLAG_APPLIED)
1941 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1723 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
1942 { 1724 {
1943 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1725 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1944 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1726 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1945 return NULL; 1727 return NULL;
1946 } 1728 }
1947 } 1729 }
1730
1948 return tmp; 1731 return tmp;
1732}
1733
1734/* find_key
1735 * We try to find a key for the door as passed. If we find a key
1736 * and successfully use it, we return the key, otherwise NULL
1737 * This function merges both normal and locked door, since the logic
1738 * for both is the same - just the specific key is different.
1739 * pl is the player,
1740 * inv is the objects inventory to searched
1741 * door is the door we are trying to match against.
1742 * This function can be called recursively to search containers.
1743 */
1744object *
1745find_key (object *pl, object *container, object *door)
1746{
1747 if (door->slaying && is_match_expr (door->slaying))
1748 {
1749 // for match expressions, we try to find the key by applying the match
1750 // to the op itself, which is supposed to find the "key", instead
1751 // of searching through containers ourselves.
1752
1753 return match_one (door->slaying, container, door, pl, pl);
1754 }
1755 else
1756 return find_key_ (pl, container, door);
1949} 1757}
1950 1758
1951/* moved door processing out of move_player_attack. 1759/* moved door processing out of move_player_attack.
1952 * returns 1 if player has opened the door with a key 1760 * returns 1 if player has opened the door with a key
1953 * such that the caller should not do anything more, 1761 * such that the caller should not do anything more,
1954 * 0 otherwise 1762 * 0 otherwise
1955 */ 1763 */
1956static int 1764static int
1957player_attack_door (object *op, object *door) 1765player_attack_door (object *op, object *door)
1958{ 1766{
1959 /* If its a door, try to find a use a key. If we do destroy the door, 1767 /* If its a door, try to find a key. If we do destroy the door,
1960 * might as well return immediately as there is nothing more to do - 1768 * might as well return immediately as there is nothing more to do -
1961 * otherwise, we fall through to the rest of the code. 1769 * otherwise, we fall through to the rest of the code.
1962 */ 1770 */
1963 object *key = find_key (op, op, door); 1771 object *key = find_key (op, op, door);
1964 1772
1965 /* IF we found a key, do some extra work */ 1773 /* If we found a key, do some extra work */
1966 if (key) 1774 if (key)
1967 { 1775 {
1968 object *container = key->env; 1776 object *container = key->env;
1969 1777
1970 play_sound_map (op->map, op->x, op->y, SOUND_OPEN_DOOR);
1971 if (action_makes_visible (op)) 1778 if (action_makes_visible (op))
1972 make_visible (op); 1779 make_visible (op);
1780
1973 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP)) 1781 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP))
1974 spring_trap (door->inv, op); 1782 spring_trap (door->inv, op);
1783
1975 if (door->type == DOOR) 1784 if (door->type == DOOR)
1976 {
1977 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */ 1785 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */
1978 }
1979 else if (door->type == LOCKED_DOOR) 1786 else if (door->type == LOCKED_DOOR)
1980 { 1787 {
1981 new_draw_info_format (NDI_UNIQUE, NDI_BROWN, op, "You open the door with the %s", query_short_name (key)); 1788 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN);
1982 remove_door2 (door); /* remove door without violence ;-) */ 1789 remove_door2 (door); /* remove door without violence ;-) */
1983 } 1790 }
1791
1984 /* Do this after we print the message */ 1792 /* Do this after we print the message */
1985 decrease_ob (key); /* Use up one of the keys */ 1793 key->decrease (); /* Use up one of the keys */
1986 /* Need to update the weight the container the key was in */ 1794
1987 if (container != op)
1988 esrv_update_item (UPD_WEIGHT, op, container);
1989 return 1; /* Nothing more to do below */ 1795 return 1; /* Nothing more to do below */
1990 } 1796 }
1991 else if (door->type == LOCKED_DOOR) 1797 else if (door->type == LOCKED_DOOR)
1992 { 1798 {
1993 /* Might as well return now - no other way to open this */ 1799 /* Might as well return now - no other way to open this */
1994 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, door->msg); 1800 op->failmsg (door->msg ? &door->msg : "Hmm, you miss the certain something to open this door...");
1995 return 1; 1801 return 1;
1996 } 1802 }
1803
1997 return 0; 1804 return 0;
1998} 1805}
1999 1806
2000/* This function is just part of a breakup from move_player. 1807/* This function is just part of a breakup from move_player.
2001 * It should keep the code cleaner. 1808 * It should keep the code cleaner.
2002 * When this is called, the players direction has been updated 1809 * When this is called, the players direction has been updated
2003 * (taking into account confusion.) The player is also actually 1810 * (taking into account confusion.) The player is also actually
2004 * going to try and move (not fire weapons). 1811 * going to try and move (not fire weapons).
2005 */ 1812 */
2006void 1813bool
2007move_player_attack (object *op, int dir) 1814move_player_attack (object *op, int dir)
2008{ 1815{
2009 object *tmp, *mon; 1816 if (!op->contr->braced && op->speed_left > 0.f && move_ob (op, dir, op))
2010 sint16 nx, ny; 1817 {
1818 --op->speed_left;
1819 return true;
1820 }
1821
2011 int on_battleground; 1822 int on_battleground;
2012 maptile *m;
2013 1823
2014 nx = freearr_x[dir] + op->x; 1824 sint16 nx = freearr_x[dir] + op->x;
2015 ny = freearr_y[dir] + op->y; 1825 sint16 ny = freearr_y[dir] + op->y;
2016 1826
2017 on_battleground = op_on_battleground (op, 0, 0); 1827 on_battleground = op_on_battleground (op, 0, 0);
1828
1829 if (out_of_map (op->map, nx, ny))
1830 return false;
2018 1831
2019 /* If braced, or can't move to the square, and it is not out of the 1832 /* If braced, or can't move to the square, and it is not out of the
2020 * map, attack it. Note order of if statement is important - don't 1833 * map, attack it. Note order of if statement is important - don't
2021 * want to be calling move_ob if braced, because move_ob will move the 1834 * want to be calling move_ob if braced, because move_ob will move the
2022 * player. This is a pretty nasty hack, because if we could 1835 * player. This is a pretty nasty hack, because if we could
2023 * move to some space, it then means that if we are braced, we should 1836 * move to some space, it then means that if we are braced, we should
2024 * do nothing at all. As it is, if we are braced, we go through 1837 * do nothing at all. As it is, if we are braced, we go through
2025 * quite a bit of processing. However, it probably is less than what 1838 * quite a bit of processing. However, it probably is less than what
2026 * move_ob uses. 1839 * move_ob uses.
2027 */ 1840 */
2028 if ((op->contr->braced || !move_ob (op, dir, op)) && !out_of_map (op->map, nx, ny)) 1841 maptile *m = op->map->xy_find (nx, ny);
1842
1843 /* Go through all the objects, and find ones of interest. Only stop if
1844 * we find a monster - that is something we know we want to attack.
1845 * if its a door or barrel (can roll) see if there may be monsters
1846 * on the space
1847 */
1848 object *mon;
1849 for (mon = m->at (nx, ny).bot; mon; mon = mon->above)
1850 {
1851 if ((mon->flag [FLAG_ALIVE]
1852 || mon->type == LOCKED_DOOR
1853 || mon->flag [FLAG_CAN_ROLL])
1854 && mon != op)
1855 break;
2029 { 1856 }
2030 if (OUT_OF_REAL_MAP (op->map, nx, ny)) 1857
1858 if (!mon) /* This happens anytime the player tries to move */
1859 return false; /* into a wall */
1860
1861 mon = mon->head_ ();
1862
1863 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
1864 if (op->contr->weapon_sp_left > 0.f)
1865 if (player_attack_door (op, mon))
1866 {
1867 --op->contr->weapon_sp_left;
1868 return true;
2031 { 1869 }
2032 m = op->map->xy_find (nx, ny); 1870
2033 if (!m) 1871 /* The following deals with possibly attacking peaceful
2034 return; /* Don't think this should happen */ 1872 * or friendly creatures. Basically, all players are considered
1873 * unaggressive. If the moving player has peaceful set, then the
1874 * object should be pushed instead of attacked. It is assumed that
1875 * if you are braced, you will not attack friends accidently,
1876 * and thus will not push them.
1877 */
1878
1879 /* If the creature is a pet, push it even if the player is not
1880 * peaceful. Our assumption is the creature is a pet if the
1881 * player owns it and it is either friendly or unagressive.
1882 */
1883 if (op->type == PLAYER
1884 && ((mon->owner && mon->owner->contr
1885 && same_party (mon->owner->contr->party, op->contr->party))
1886 || mon->owner == op)
1887 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
1888 {
1889 /* If we're braced, we don't want to switch places with it */
1890 if (op->contr->braced)
1891 return false;
1892
1893 if (op->speed_left > 0.f)
1894 {
1895 --op->speed_left;
1896
1897 op->play_sound (sound_find ("push_player"));
1898 push_ob (mon, dir, op);
1899
1900 if (action_makes_visible (op))
1901 make_visible (op);
1902
1903 return true;
2035 } 1904 }
2036 else 1905 else
2037 m = op->map;
2038
2039 if (!(tmp = m->at (nx, ny).bot))
2040 return; 1906 return false;
1907 }
2041 1908
2042 mon = 0;
2043 /* Go through all the objects, and find ones of interest. Only stop if
2044 * we find a monster - that is something we know we want to attack.
2045 * if its a door or barrel (can roll) see if there may be monsters
2046 * on the space
2047 */
2048 while (tmp)
2049 {
2050 if (tmp == op)
2051 {
2052 tmp = tmp->above;
2053 continue;
2054 }
2055
2056 if (QUERY_FLAG (tmp, FLAG_ALIVE))
2057 {
2058 mon = tmp;
2059 break;
2060 }
2061
2062 if (tmp->type == LOCKED_DOOR || QUERY_FLAG (tmp, FLAG_CAN_ROLL))
2063 mon = tmp;
2064
2065 tmp = tmp->above;
2066 }
2067
2068 if (!mon) /* This happens anytime the player tries to move */
2069 return; /* into a wall */
2070
2071 if (mon->head)
2072 mon = mon->head;
2073
2074 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2075 if (player_attack_door (op, mon))
2076 return;
2077
2078 /* The following deals with possibly attacking peaceful
2079 * or frienddly creatures. Basically, all players are considered
2080 * unaggressive. If the moving player has peaceful set, then the
2081 * object should be pushed instead of attacked. It is assumed that
2082 * if you are braced, you will not attack friends accidently,
2083 * and thus will not push them.
2084 */
2085
2086 /* If the creature is a pet, push it even if the player is not
2087 * peaceful. Our assumption is the creature is a pet if the
2088 * player owns it and it is either friendly or unagressive.
2089 */
2090 if ((op->type == PLAYER)
2091#if COZY_SERVER
2092 &&
2093 ((mon->owner && mon->owner->contr
2094 && same_party (mon->owner->contr->party, op->contr->party)) || mon->owner == op)
2095#else
2096 && mon->owner == op
2097#endif
2098 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
2099 {
2100 /* If we're braced, we don't want to switch places with it */
2101 if (op->contr->braced)
2102 return;
2103
2104 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER);
2105 (void) push_ob (mon, dir, op);
2106 if (op->contr->tmp_invis || op->hide)
2107 make_visible (op);
2108
2109 return;
2110 }
2111
2112 /* in certain circumstances, you shouldn't attack friendly 1909 /* in certain circumstances, you shouldn't attack friendly
2113 * creatures. Note that if you are braced, you can't push 1910 * creatures. Note that if you are braced, you can't push
2114 * someone, but put it inside this loop so that you won't 1911 * someone, but put it inside this loop so that you won't
2115 * attack them either. 1912 * attack them either.
2116 */ 1913 */
2117 if ((mon->type == PLAYER || mon->enemy != op) && 1914 if ((mon->type == PLAYER || mon->enemy != op)
2118 (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) && ( 1915 && (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY))
2119#ifdef PROHIBIT_PLAYERKILL
2120 (op->contr->peaceful 1916 && ((op->contr->peaceful
2121 || (mon->type == PLAYER 1917 || (mon->type == PLAYER && mon->contr->peaceful))
2122 && mon->contr->
2123 peaceful)) &&
2124#else
2125 op->contr->peaceful &&
2126#endif
2127 !on_battleground)) 1918 && !on_battleground))
1919 {
1920 if (op->speed_left > 0.f)
2128 { 1921 {
1922 --op->speed_left;
1923
2129 if (!op->contr->braced) 1924 if (!op->contr->braced)
2130 { 1925 {
2131 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER); 1926 op->play_sound (sound_find ("push_player"));
2132 push_ob (mon, dir, op); 1927 push_ob (mon, dir, op);
2133 } 1928 }
2134 else 1929 else
2135 new_draw_info (0, 0, op, "You withhold your attack"); 1930 op->statusmsg ("You withhold your attack");
2136 1931
2137 if (op->contr->tmp_invis || op->hide) 1932 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN])
2138 make_visible (op); 1933 make_visible (op);
2139 }
2140 1934
1935 return true;
1936 }
1937 }
2141 /* If the object is a boulder or other rollable object, then 1938 /* If the object is a boulder or other rollable object, then
2142 * roll it if not braced. You can't roll it if you are braced. 1939 * roll it if not braced. You can't roll it if you are braced.
2143 */ 1940 */
2144 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 1941 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced))
1942 {
1943 if (op->speed_left > 0.f)
2145 { 1944 {
1945 --op->speed_left;
1946
2146 recursive_roll (mon, dir, op); 1947 recursive_roll (mon, dir, op);
2147 if (action_makes_visible (op)) 1948 if (action_makes_visible (op))
2148 make_visible (op); 1949 make_visible (op);
2149 }
2150 1950
1951 return true;
1952 }
1953 }
2151 /* Any generic living creature. Including things like doors. 1954 /* Any generic living creature. Including things like doors.
2152 * Way it works is like this: First, it must have some hit points 1955 * Way it works is like this: First, it must have some hit points
2153 * and be living. Then, it must be one of the following: 1956 * and be living. Then, it must be one of the following:
2154 * 1) Not a player, 2) A player, but of a different party. Note 1957 * 1) Not a player, 2) A player, but of a different party. Note
2155 * that party_number -1 is no party, so attacks can still happen. 1958 * that party_number -1 is no party, so attacks can still happen.
2156 */ 1959 */
2157 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 1960 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) &&
2158 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 1961 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2159 { 1962 {
2160 1963 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2161 /* If the player hasn't hit something this tick, and does
2162 * so, give them speed boost based on weapon speed. Doing
2163 * it here is better than process_players2, which basically
2164 * incurred a 1 tick offset.
2165 */
2166 if (!op->contr->has_hit)
2167 { 1964 {
2168 op->speed_left += op->speed / op->contr->weapon_sp; 1965 --op->contr->weapon_sp_left;
2169
2170 op->contr->has_hit = 1; /* The last action was to hit, so use weapon_sp */
2171 }
2172 1966
2173 skill_attack (mon, op, 0, 0, 0); 1967 skill_attack (mon, op, 0, 0, 0);
2174
2175 /* If attacking another player, that player gets automatic
2176 * hitback, and doesn't loose luck either.
2177 * Disable hitback on the battleground or if the target is
2178 * the wiz.
2179 */
2180 if (mon->type == PLAYER && mon->stats.hp >= 0 && !mon->contr->has_hit && !on_battleground && !QUERY_FLAG (mon, FLAG_WIZ))
2181 {
2182 short luck = mon->stats.luck;
2183
2184 mon->contr->has_hit = 1;
2185 skill_attack (op, mon, 0, 0, 0);
2186 mon->stats.luck = luck;
2187 }
2188 1968
2189 if (action_makes_visible (op)) 1969 if (action_makes_visible (op))
2190 make_visible (op); 1970 make_visible (op);
2191 }
2192 } /* if player should attack something */
2193}
2194 1971
2195int 1972 return true;
1973 }
1974 }
1975
1976 return false;
1977}
1978
1979bool
2196move_player (object *op, int dir) 1980move_player (object *op, int dir)
2197{ 1981{
2198 int pick; 1982 int pick;
2199 1983
2200 if (!op->map || op->map->in_memory != MAP_IN_MEMORY) 1984 if (!op->map || op->map->in_memory != MAP_ACTIVE)
2201 return 0; 1985 return 0;
2202 1986
2203 /* Sanity check: make sure dir is valid */ 1987 /* Sanity check: make sure dir is valid */
2204 if ((dir < 0) || (dir >= 9)) 1988 if ((dir < 0) || (dir >= 9))
2205 { 1989 {
2207 return 0; 1991 return 0;
2208 } 1992 }
2209 1993
2210 /* peterm: added following line */ 1994 /* peterm: added following line */
2211 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 1995 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir)
2212 dir = absdir (dir + RANDOM () % 3 + RANDOM () % 3 - 2); 1996 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2213 1997
2214 op->facing = dir; 1998 op->facing = dir;
2215 1999
2216 if (op->hide) 2000 if (op->flag [FLAG_HIDDEN])
2217 do_hidden_move (op); 2001 do_hidden_move (op);
2218 2002
2003 bool retval;
2004
2219 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2005 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2220 /*nop */ ; 2006 retval = RESULT_INT (0);
2221 else if (op->contr->fire_on) 2007 else if (op->contr->fire_on)
2222 fire (op, dir); 2008 retval = fire (op, dir);
2223 else 2009 else
2224 { 2010 {
2225 move_player_attack (op, dir); 2011 retval = move_player_attack (op, dir);
2226 pick = check_pick (op); 2012 pick = check_pick (op);
2227 } 2013 }
2228 2014
2229 /* Add special check for newcs players and fire on - this way, the 2015 /* Add special check for newcs players and fire on - this way, the
2230 * server can handle repeat firing. 2016 * server can handle repeat firing.
2237 /* Update how the player looks. Use the facing, so direction may 2023 /* Update how the player looks. Use the facing, so direction may
2238 * get reset to zero. This allows for full animation capabilities 2024 * get reset to zero. This allows for full animation capabilities
2239 * for players. 2025 * for players.
2240 */ 2026 */
2241 animate_object (op, op->facing); 2027 animate_object (op, op->facing);
2242 return 0; 2028
2029 return retval;
2243} 2030}
2244 2031
2245/* This is similar to handle_player, below, but is only used by the 2032/* This is similar to handle_player, below, but is only used by the
2246 * new client/server stuff. 2033 * new client/server stuff.
2247 * This is sort of special, in that the new client/server actually uses 2034 * This is sort of special, in that the new client/server actually uses
2248 * the new speed values for commands. 2035 * the new speed values for commands.
2249 * 2036 *
2250 * Returns true if there are more actions we can do. 2037 * Returns true if there are more actions we can do. Should not do
2038 * many actions in a row, as that would be too unfair to other
2039 * players.
2251 */ 2040 */
2252int 2041bool
2253handle_newcs_player (object *op) 2042handle_newcs_player (object *op)
2254{ 2043{
2255 if (op->contr->hidden)
2256 {
2257 op->invisible = 1000;
2258 /* the socket code flashes the player visible/invisible
2259 * depending on the value of invisible, so we need to
2260 * alternate it here for it to work correctly.
2261 */
2262 if (pticks & 2)
2263 op->invisible--;
2264 }
2265 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2266 {
2267 op->invisible--;
2268 if (!op->invisible)
2269 {
2270 make_visible (op);
2271 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2272 }
2273 }
2274
2275 if (QUERY_FLAG (op, FLAG_SCARED)) 2044 if (QUERY_FLAG (op, FLAG_SCARED))
2276 { 2045 {
2277 flee_player (op); 2046 if (op->speed_left > 0.f)
2278 /* If player is still scared, that is his action for this tick */
2279 if (QUERY_FLAG (op, FLAG_SCARED))
2280 { 2047 {
2281 op->speed_left--; 2048 --op->speed_left;
2049 flee_player (op);
2050
2282 return 0; 2051 return true;
2283 } 2052 }
2053 else
2054 return false;
2284 } 2055 }
2285
2286 /* I've been seeing crashes where the golem has been destroyed, but
2287 * the player object still points to the defunct golem. The code that
2288 * destroys the golem looks correct, and it doesn't always happen, so
2289 * put this in a a workaround to clean up the golem pointer.
2290 */
2291 if (op->contr->ranges[range_golem] && QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
2292 op->contr->ranges[range_golem] = 0;
2293 2056
2294 /* call this here - we also will call this in do_ericserver, but 2057 /* call this here - we also will call this in do_ericserver, but
2295 * the players time has been increased when doericserver has been 2058 * the players time has been increased when doericserver has been
2296 * called, so we recheck it here. 2059 * called, so we recheck it here.
2297 */ 2060 */
2298 if (op->contr->ns->handle_command ()) 2061 if (op->contr->ns->handle_command ())
2299 return 1; 2062 return true;
2300 2063
2301 if (op->speed_left > 0)
2302 {
2303 if (op->direction && (op->contr->run_on || op->contr->fire_on)) 2064 if (op->direction && (op->contr->run_on || op->contr->fire_on))
2304 {
2305 /* All move commands take 1 tick, at least for now */
2306 op->speed_left--;
2307
2308 /* Instead of all the stuff below, let move_player take care
2309 * of it. Also, some of the skill stuff is only put in
2310 * there, as well as the confusion stuff.
2311 */
2312 move_player (op, op->direction); 2065 return move_player (op, op->direction);
2313 2066
2314 return op->speed_left > 0;
2315 }
2316 }
2317
2318 return 0; 2067 return false;
2319} 2068}
2320 2069
2321int 2070int
2322save_life (object *op) 2071save_life (object *op)
2323{ 2072{
2325 return 0; 2074 return 0;
2326 2075
2327 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2076 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2328 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2077 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE))
2329 { 2078 {
2330 play_sound_map (op->map, op->x, op->y, SOUND_OB_EVAPORATE); 2079 op->play_sound (sound_find ("ob_evaporate"));
2331 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2080 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2332
2333 if (op->contr)
2334 esrv_del_item (op->contr, tmp->count);
2335 2081
2336 tmp->destroy (); 2082 tmp->destroy ();
2337 CLEAR_FLAG (op, FLAG_LIFESAVE); 2083 CLEAR_FLAG (op, FLAG_LIFESAVE);
2338 2084
2339 if (op->stats.hp < 0) 2085 if (op->stats.hp < 0)
2352 return 0; 2098 return 0;
2353} 2099}
2354 2100
2355/* This goes throws the inventory and removes unpaid objects, and puts them 2101/* This goes throws the inventory and removes unpaid objects, and puts them
2356 * back in the map (location and map determined by values of env). This 2102 * back in the map (location and map determined by values of env). This
2357 * function will descend into containers. op is the object to start the search 2103 * function will descend into containers. op is the object to start the search
2358 * from. 2104 * from.
2359 */ 2105 */
2106static void
2107drop_unpaid_items (object *op, object *env)
2108{
2109 while (op)
2110 {
2111 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2112
2113 if (QUERY_FLAG (op, FLAG_UNPAID))
2114 op->insert_at (env);
2115 else if (op->inv)
2116 drop_unpaid_items (op->inv, env);
2117
2118 op = next;
2119 }
2120}
2121
2360void 2122void
2361remove_unpaid_objects (object *op, object *env) 2123object::drop_unpaid_items ()
2362{ 2124{
2363 object *next; 2125 if (!flag [FLAG_REMOVED])
2364 2126 ::drop_unpaid_items (inv, this);
2365 while (op)
2366 {
2367 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2368
2369 if (QUERY_FLAG (op, FLAG_UNPAID))
2370 {
2371 if (env->type == PLAYER)
2372 esrv_del_item (env->contr, op->count);
2373
2374 op->insert_at (env);
2375 }
2376 else if (op->inv)
2377 remove_unpaid_objects (op->inv, env);
2378
2379 op = next;
2380 }
2381} 2127}
2382 2128
2383/* 2129/*
2384 * Returns pointer a static string containing gravestone text 2130 * Returns pointer a static string containing gravestone text
2385 * Moved from apply.c to player.c - player.c is what 2131 * Moved from apply.c to player.c - player.c is what
2386 * actually uses this function. player.c may not be quite the 2132 * actually uses this function. player.c may not be quite the
2387 * best, a misc file for object actions is probably better, 2133 * best, a misc file for object actions is probably better,
2388 * but there isn't one in the server directory. 2134 * but there isn't one in the server directory.
2389 */ 2135 */
2390char * 2136const char *
2391gravestone_text (object *op) 2137gravestone_text (object *op)
2392{ 2138{
2393 static char buf2[MAX_BUF]; 2139 static dynbuf_text buf;
2394 char buf[MAX_BUF];
2395 time_t now = time (NULL);
2396 2140
2397 strcpy (buf2, " R.I.P.\n\n"); 2141 buf << "---- R.I.P. ----\n\n"
2142 << op->name;
2143
2398 if (op->type == PLAYER) 2144 if (op->type == PLAYER)
2399 sprintf (buf, "%s the %s\n", &op->name, op->contr->title); 2145 buf << " the " << op->contr->title;
2400 else
2401 sprintf (buf, "%s\n", &op->name);
2402 2146
2403 strncat (buf2, " ", 20 - strlen (buf) / 2); 2147 buf << "\n\n";
2404 strcat (buf2, buf); 2148
2149 buf << "who was level ";
2150 buf << (sint32)op->level << "\n\n" // OO breakdown
2151 << " when " << (op->contr ? "killed" : "died") << "\n\n";
2152
2405 if (op->type == PLAYER) 2153 if (op->type == PLAYER)
2406 sprintf (buf, "who was in level %d when killed\n", op->level); 2154 buf << "by " << op->contr->killer_name () << ".\n\n";
2407 else
2408 sprintf (buf, "who was in level %d when died.\n\n", op->level);
2409 2155
2410 strncat (buf2, " ", 20 - strlen (buf) / 2);
2411 strcat (buf2, buf);
2412 if (op->type == PLAYER)
2413 { 2156 {
2414 sprintf (buf, "by %s.\n\n", op->contr->killer); 2157 static char buf2[128];
2415 strncat (buf2, " ", 21 - strlen (buf) / 2); 2158 time_t now = time (NULL);
2416 strcat (buf2, buf);
2417 }
2418
2419 strftime (buf, MAX_BUF, "%b %d %Y\n", localtime (&now)); 2159 strftime (buf2, 128, "%b %d %Y\n\n", localtime (&now));
2420 strncat (buf2, " ", 20 - strlen (buf) / 2); 2160 buf << buf2;
2421 strcat (buf2, buf); 2161 }
2422 2162
2423 return buf2; 2163 return buf;
2424} 2164}
2425 2165
2426void 2166void
2427do_some_living (object *op) 2167do_some_living (object *op)
2428{ 2168{
2435 int rate_grace = 2000; 2175 int rate_grace = 2000;
2436 const int max_hp = 1; 2176 const int max_hp = 1;
2437 const int max_sp = 1; 2177 const int max_sp = 1;
2438 const int max_grace = 1; 2178 const int max_grace = 1;
2439 2179
2440 if (op->contr->outputs_sync) 2180 if (op->contr->hidden)
2181 {
2182 op->invisible = 1000;
2183 /* the socket code flashes the player visible/invisible
2184 * depending on the value of invisible, so we need to
2185 * alternate it here for it to work correctly.
2186 */
2187 if (pticks & 2)
2188 op->invisible--;
2441 { 2189 }
2442 for (i = 0; i < NUM_OUTPUT_BUFS; i++) 2190 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS)))
2443 if (op->contr->outputs[i].buf && (op->contr->outputs[i].first_update + op->contr->outputs_sync) < (uint16) pticks) 2191 {
2444 flush_output_element (op, &op->contr->outputs[i]); 2192 if (!op->invisible--)
2193 {
2194 make_visible (op);
2195 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2196 }
2445 } 2197 }
2446 2198
2447 if (op->contr->ns->state == ST_PLAYING) 2199 if (op->contr->ns->state == ST_PLAYING)
2448 { 2200 {
2449 /* these next three if clauses make it possible to SLOW DOWN 2201 /* these next three if clauses make it possible to SLOW DOWN
2468 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace; 2220 gen_grace = (op->contr->gen_grace + 1) * op->stats.maxgrace;
2469 else 2221 else
2470 { 2222 {
2471 gen_grace = op->stats.maxgrace; 2223 gen_grace = op->stats.maxgrace;
2472 rate_grace -= rate_grace / 2 * op->contr->gen_grace; 2224 rate_grace -= rate_grace / 2 * op->contr->gen_grace;
2473 }
2474
2475 /* Regenerate Spell Points */
2476 if (op->contr->ranges[range_golem] == NULL && --op->last_sp < 0)
2477 {
2478 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2479 if (op->stats.sp < op->stats.maxsp)
2480 {
2481 op->stats.sp++;
2482 /* dms do not consume food */
2483 if (!QUERY_FLAG (op, FLAG_WIZ))
2484 {
2485 op->stats.food--;
2486 if (op->contr->digestion < 0)
2487 op->stats.food += op->contr->digestion;
2488 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2489 op->stats.food = last_food;
2490 }
2491 }
2492
2493 if (max_sp > 1)
2494 {
2495 over_sp = (gen_sp + 10) / rate_sp;
2496 if (over_sp > 0)
2497 {
2498 if (op->stats.sp < op->stats.maxsp)
2499 {
2500 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2501
2502 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2503 op->stats.sp--;
2504
2505 if (op->stats.sp > op->stats.maxsp)
2506 op->stats.sp = op->stats.maxsp;
2507 }
2508 op->last_sp = 0;
2509 }
2510 else
2511 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2512 }
2513 else
2514 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2515 } 2225 }
2516 2226
2517 /* Regenerate Grace */ 2227 /* Regenerate Grace */
2518 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */ 2228 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */
2519 if (--op->last_grace < 0) 2229 if (--op->last_grace < 0)
2540 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10); 2250 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2541 } 2251 }
2542 /* wearing stuff doesn't detract from grace generation. */ 2252 /* wearing stuff doesn't detract from grace generation. */
2543 } 2253 }
2544 2254
2255 if (op->stats.food > 0)
2256 {
2545 /* Regenerate Hit Points */ 2257 /* Regenerate Spell Points */
2546 if (--op->last_heal < 0) 2258 if (!op->contr->golem && --op->last_sp < 0)
2547 {
2548 if (op->stats.hp < op->stats.maxhp)
2549 { 2259 {
2550 op->stats.hp++; 2260 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2551 /* dms do not consume food */ 2261
2552 if (!QUERY_FLAG (op, FLAG_WIZ)) 2262 if (op->stats.sp < op->stats.maxsp)
2553 { 2263 {
2264 op->stats.sp++;
2265
2266 /* dms do not consume food */
2267 if (!QUERY_FLAG (op, FLAG_WIZ))
2268 {
2554 op->stats.food--; 2269 op->stats.food--;
2270
2555 if (op->contr->digestion < 0) 2271 if (op->contr->digestion < 0)
2556 op->stats.food += op->contr->digestion; 2272 op->stats.food += op->contr->digestion;
2557 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH)) 2273 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2558 op->stats.food = last_food; 2274 op->stats.food = last_food;
2275 }
2559 } 2276 }
2560 }
2561 2277
2562 if (max_hp > 1) 2278 if (max_sp > 1)
2563 {
2564 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2565 if (over_hp > 0)
2566 { 2279 {
2567 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0; 2280 over_sp = (gen_sp + 10) / rate_sp;
2281 if (over_sp > 0)
2282 {
2283 if (op->stats.sp < op->stats.maxsp)
2284 {
2285 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2286
2287 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2288 op->stats.sp--;
2289
2290 if (op->stats.sp > op->stats.maxsp)
2291 op->stats.sp = op->stats.maxsp;
2292 }
2293
2568 op->last_heal = 0; 2294 op->last_sp = 0;
2295 }
2296 else
2297 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2569 } 2298 }
2570 else 2299 else
2300 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2301 }
2302
2303 /* Regenerate Hit Points */
2304 if (--op->last_heal < 0)
2305 {
2306 if (op->stats.hp < op->stats.maxhp)
2571 { 2307 {
2572 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2308 op->stats.hp++;
2309
2310 /* dms do not consume food */
2311 if (!QUERY_FLAG (op, FLAG_WIZ))
2312 {
2313 op->stats.food--;
2314
2315 if (op->contr->digestion < 0)
2316 op->stats.food += op->contr->digestion;
2317 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2318 op->stats.food = last_food;
2319 }
2573 } 2320 }
2321
2322 if (max_hp > 1)
2323 {
2324 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2325
2326 if (over_hp > 0)
2327 {
2328 op->stats.sp += over_hp + (rndm (rate_hp) > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0;
2329 op->last_heal = 0;
2330 }
2331 else
2332 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2574 } 2333 }
2575 else 2334 else
2576 {
2577 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10); 2335 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2578 } 2336 }
2579 } 2337 }
2580 2338
2581 /* Digestion */ 2339 /* Digestion */
2582 if (--op->last_eat < 0) 2340 if (--op->last_eat < 0)
2583 { 2341 {
2584#ifdef COZY_SERVER 2342 int bonus = max (0, op->contr->digestion),
2585 int dg = op->contr->digestion >= 0 && op->contr->digestion < 2 ? 2 : op->contr->digestion; 2343 penalty = max (0, -op->contr->digestion);
2586 int bonus = dg > 0 ? dg : 0, penalty = dg < 0 ? -dg : 0;
2587#else
2588 int bonus = op->contr->digestion > 0 ? op->contr->digestion : 0, penalty = op->contr->digestion < 0 ? -op->contr->digestion : 0;
2589#endif
2590 2344
2591 if (op->contr->gen_hp > 0)
2592 op->last_eat = 25 * (1 + bonus) / (op->contr->gen_hp + penalty + 1); 2345 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2593 else
2594 op->last_eat = 25 * (1 + bonus) / (penalty + 1);
2595 2346
2596 /* dms do not consume food */ 2347 /* dms do not consume food */
2597 if (!QUERY_FLAG (op, FLAG_WIZ)) 2348 if (!QUERY_FLAG (op, FLAG_WIZ))
2598 op->stats.food--; 2349 op->stats.food--;
2599 } 2350 }
2600 2351
2601 if (op->stats.food < 0 && op->stats.hp >= 0) 2352 if (op->stats.food < 0 && op->stats.hp >= 0)
2602 { 2353 {
2603 object *tmp, *flesh = 0; 2354 object *flesh = 0;
2604 2355
2605 for (tmp = op->inv; tmp; tmp = tmp->below) 2356 for_inv_removable (op, tmp)
2606 { 2357 {
2607 if (!QUERY_FLAG (tmp, FLAG_UNPAID)) 2358 if (QUERY_FLAG (tmp, FLAG_UNPAID))
2359 continue;
2360
2361 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2608 { 2362 {
2609 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2363 op->statusmsg ("You blindly grab for a bite of food. "
2610 { 2364 "H<To prevent you from starving, you ate some random item from your backpack.>");
2611 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food.");
2612 manual_apply (op, tmp, 0); 2365 manual_apply (op, tmp, 0);
2366
2613 if (op->stats.food >= 0 || op->stats.hp < 0) 2367 if (op->stats.food >= 0 || op->stats.hp < 0)
2614 break; 2368 break;
2615 } 2369 }
2616 else if (tmp->type == FLESH) 2370 else if (tmp->type == FLESH)
2617 flesh = tmp; 2371 flesh = tmp;
2618 } /* End if paid for object */ 2372 }
2619 } /* end of for loop */
2620 2373
2621 /* If player is still starving, it means they don't have any food, so 2374 /* If player is still starving, it means they don't have any food, so
2622 * eat flesh instead. 2375 * eat flesh instead.
2623 */ 2376 */
2624 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2377 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2625 { 2378 {
2626 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2379 op->statusmsg ("You blindly grab for a bite of food. "
2380 "H<To prevent you from starving, you ate some random item from your backpack.>");
2627 manual_apply (op, flesh, 0); 2381 manual_apply (op, flesh, 0);
2628 } 2382 }
2383
2384 // If player is still starving, alert him!
2385 if (op->stats.food < 0)
2386 op->failmsg ("You are starving! "
2387 "H<Eat some food to increase your food and prevent you from an untimely death.>");
2388 }
2389
2390 if (op->stats.food < 0)
2629 } 2391 {
2392 op->stats.hp += op->stats.food;
2393 op->stats.food = 0;
2630 2394
2631 while (op->stats.food < 0 && op->stats.hp >= 0) 2395 if (op->stats.hp < 0)
2632 op->stats.food++, op->stats.hp--; 2396 {
2397 op->contr->killer = archetype::get ("killer_starvation");
2398 op->contr->killer->destroy ();
2399 }
2400 }
2633 2401
2402 /* killer should be set here already */
2634 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2403 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ))
2635 kill_player (op); 2404 kill_player (op);
2636 } 2405 }
2637} 2406}
2638 2407
2642 * file. 2411 * file.
2643 */ 2412 */
2644void 2413void
2645kill_player (object *op) 2414kill_player (object *op)
2646{ 2415{
2647 char buf[MAX_BUF];
2648 int x, y; 2416 int x, y;
2649
2650 //int i;
2651 maptile *map; /* this is for resurrection */ 2417 maptile *map; /* this is for resurrection */
2652
2653 /* int z;
2654 int num_stats_lose;
2655 int lost_a_stat;
2656 int lose_this_stat;
2657 int this_stat; */
2658 int will_kill_again; 2418 int will_kill_again;
2659 archetype *at; 2419 archetype *at;
2660 object *tmp; 2420 object *tmp;
2661 2421
2662 if (save_life (op)) 2422 if (save_life (op))
2663 return; 2423 return;
2664 2424
2425 dynbuf_text deathtab;
2426
2427 /* restore player */
2428 at = archetype::find ("poisoning");
2429 if (object *tmp = present_arch_in_ob (at, op))
2430 {
2431 tmp->destroy ();
2432 deathtab << "Your body feels cleansed...\r";
2433 }
2434
2435 at = archetype::find ("confusion");
2436 if (object *tmp = present_arch_in_ob (at, op))
2437 {
2438 tmp->destroy ();
2439 deathtab << "Your mind feels clearer...\r";
2440 }
2441
2442 cure_disease (op, 0, 0); /* remove any disease */
2443
2444 max_it (op->stats.hp , op->stats.maxhp);
2445 max_it (op->stats.sp , op->stats.maxsp);
2446 max_it (op->stats.grace, op->stats.maxgrace);
2447
2448 if (op->stats.food <= 0)
2449 op->stats.food = 999;
2450
2451 // remove all spell effects that are active
2452 // to avoid long-term effects such as word-of-recall
2453 for (object *item = op->inv; item; )
2454 {
2455 object *next = item->below;
2456
2457 if (item->type == SPELL_EFFECT && item->active)
2458 item->destroy ();
2459
2460 item = next;
2461 }
2665 2462
2666 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2463 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2667 * in cities ONLY!!! It is very important that this doesn't get abused. 2464 * in cities ONLY!!! It is very important that this doesn't get abused.
2668 * Look at op_on_battleground() for more info --AndreasV 2465 * Look at op_on_battleground() for more info --AndreasV
2669 */ 2466 */
2670 if (op_on_battleground (op, &x, &y)) 2467 if (op_on_battleground (op, &x, &y))
2671 { 2468 {
2672 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2469 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2673 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2674
2675 /* restore player */
2676 at = archetype::find ("poisoning");
2677 if (object *tmp = present_arch_in_ob (at, op))
2678 {
2679 tmp->destroy ();
2680 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2681 }
2682
2683 at = archetype::find ("confusion");
2684 if (object *tmp = present_arch_in_ob (at, op))
2685 {
2686 tmp->destroy ();
2687 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2688 }
2689
2690 cure_disease (op, 0); /* remove any disease */
2691 op->stats.hp = op->stats.maxhp;
2692 if (op->stats.food <= 0)
2693 op->stats.food = 999;
2694 2470
2695 /* create a bodypart-trophy to make the winner happy */ 2471 /* create a bodypart-trophy to make the winner happy */
2696 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2472 if (object *tmp = arch_to_object (archetype::find ("finger")))
2697 { 2473 {
2698 sprintf (buf, "%s's finger", &op->name); 2474 tmp->name = format ("%s's finger" , &op->name);
2699 tmp->name = buf; 2475 tmp->name_pl = format ("%s's fingers", &op->name);
2700 sprintf (buf, " This finger has been cut off %s\n"
2701 " the %s, when he was defeated at\n level %d by %s.\n",
2702 &op->name, op->contr->title, (int) (op->level), op->contr->killer);
2703 tmp->msg = buf; 2476 tmp->msg = format (
2477 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2478 &op->name, op->contr->title,
2479 (int)op->level,
2480 op->contr->killer_name ()
2481 );
2704 tmp->value = 0, tmp->material = 0, tmp->type = 0; 2482 tmp->value = 0, tmp->type = 0;
2705 tmp->materialname = NULL; 2483 tmp->materialname = "organics";
2706 tmp->insert_at (op, tmp); 2484 tmp->insert_at (op, tmp);
2707 } 2485 }
2708 2486
2709 /* teleport defeated player to new destination */ 2487 /* teleport defeated player to new destination */
2710 transfer_ob (op, x, y, 0, NULL); 2488 transfer_ob (op, x, y, 0, NULL);
2711 op->contr->braced = 0; 2489 op->contr->braced = 0;
2490
2491 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2712 return; 2492 return;
2713 } 2493 }
2714 2494
2495 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2496 deathtab << "T<YOU HAVE DIED>\n\n";
2497
2715 INVOKE_PLAYER (DEATH, op->contr); 2498 INVOKE_PLAYER (DEATH, op->contr);
2716 2499
2717 command_kill_pets (op, 0); 2500 command_kill_pets (op, 0);
2718 2501
2719 if (op->stats.food < 0) 2502 op->contr->play_sound (sound_find ("player_dies"));
2720 {
2721 sprintf (buf, "%s starved to death.", &op->name);
2722 strcpy (op->contr->killer, "starvation");
2723 }
2724 else
2725 sprintf (buf, "%s died.", &op->name);
2726
2727 play_sound_player_only (op->contr, SOUND_PLAYER_DIES, 0, 0);
2728 2503
2729 /* save the map location for corpse, gravestone */ 2504 /* save the map location for corpse, gravestone */
2730 x = op->x; 2505 x = op->x;
2731 y = op->y; 2506 y = op->y;
2732 map = op->map; 2507 map = op->map;
2760 2535
2761 lost_a_stat = 0; 2536 lost_a_stat = 0;
2762 2537
2763 for (z = 0; z < num_stats_lose; z++) 2538 for (z = 0; z < num_stats_lose; z++)
2764 { 2539 {
2765 i = RANDOM () % NUM_STATS; 2540 i = rndm (NUM_STATS);
2766 2541
2767 if (settings.stat_loss_on_death) 2542 if (settings.stat_loss_on_death)
2768 { 2543 {
2769 /* Pick a random stat and take a point off it. Tell the player 2544 /* Pick a random stat and take a point off it. Tell the player
2770 * what he lost. 2545 * what he lost.
2821 } 2596 }
2822 } 2597 }
2823 2598
2824 if (lose_this_stat) 2599 if (lose_this_stat)
2825 { 2600 {
2826 this_stat = get_attr_value (&(dep->stats), i); 2601 this_stat = get_attr_value (&dep->stats, i);
2827 /* We could try to do something clever like find another 2602 /* We could try to do something clever like find another
2828 * stat to reduce if this fails. But chances are, if 2603 * stat to reduce if this fails. But chances are, if
2829 * stats have been depleted to -50, all are pretty low 2604 * stats have been depleted to -50, all are pretty low
2830 * and should be roughly the same, so it shouldn't make a 2605 * and should be roughly the same, so it shouldn't make a
2831 * difference. 2606 * difference.
2839 lost_a_stat = 1; 2614 lost_a_stat = 1;
2840 } 2615 }
2841 } 2616 }
2842 } 2617 }
2843 } 2618 }
2619
2844 /* If no stat lost, tell the player. */ 2620 /* If no stat lost, tell the player. */
2845 if (!lost_a_stat) 2621 if (!lost_a_stat)
2846 { 2622 {
2847 /* determine_god() seems to not work sometimes... why is this? 2623 /* determine_god() seems to not work sometimes... why is this?
2848 Should I be using something else? GD */ 2624 Should I be using something else? GD */
2849 const char *god = determine_god (op); 2625 shstr_tmp god = determine_god (op);
2850 2626
2851 if (god && (strcmp (god, "none"))) 2627 if (god != shstr_none)
2852 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2628 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2853 else 2629 else
2854 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2630 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2855 } 2631 }
2856#else 2632#else
2857 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you" " feel a holy presence protecting you from losing yourself completely."); 2633 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2858#endif 2634#endif
2859 2635
2860 /* Put a gravestone up where the character 'almost' died. List the 2636 /* Put a gravestone up where the character 'almost' died. List the
2861 * exp loss on the stone. 2637 * exp loss on the stone.
2862 */ 2638 */
2863 tmp = arch_to_object (archetype::find ("gravestone")); 2639 tmp = arch_to_object (archetype::find ("gravestone"));
2864 sprintf (buf, "%s's gravestone", &op->name); 2640 tmp->name = format ("%s's gravestone", &op->name);
2865 tmp->name = buf; 2641 tmp->name_pl = format ("%s's gravestones", &op->name);
2866 sprintf (buf, "%s's gravestones", &op->name); 2642 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2867 tmp->name_pl = buf; 2643 &op->name, op->contr->title, op->contr->killer_name ());
2868 sprintf (buf, "RIP\nHere rests the hero %s the %s,\n" "who was killed\n" "by %s.\n", &op->name, op->contr->title, op->contr->killer);
2869 tmp->msg = buf;
2870 tmp->x = op->x, tmp->y = op->y; 2644 tmp->x = op->x, tmp->y = op->y;
2871 insert_ob_in_map (tmp, op->map, NULL, 0); 2645 insert_ob_in_map (tmp, op->map, NULL, 0);
2872 2646
2873 /**************************************/ 2647 /**************************************/
2874 /* */ 2648 /* */
2875 /* Subtract the experience points, */ 2649 /* Subtract the experience points, */
2876 /* if we died cause of food, give us */
2877 /* food, and reset HP's... */
2878 /* */ 2650 /* */
2879 /**************************************/ 2651 /**************************************/
2880 2652
2881 /* remove any poisoning and confusion the character may be suffering. */
2882 /* restore player */
2883 at = archetype::find ("poisoning");
2884 tmp = present_arch_in_ob (at, op);
2885
2886 if (tmp)
2887 {
2888 tmp->destroy ();
2889 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2890 }
2891
2892 at = archetype::find ("confusion");
2893 tmp = present_arch_in_ob (at, op);
2894 if (tmp)
2895 {
2896 tmp->destroy ();
2897 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2898 }
2899
2900 cure_disease (op, 0); /* remove any disease */
2901
2902 /*add_exp(op, (op->stats.exp * -0.20)); */ 2653 /*add_exp(op, (op->stats.exp * -0.20)); */
2903 apply_death_exp_penalty (op); 2654 apply_death_exp_penalty (op);
2904 if (op->stats.food < 100)
2905 op->stats.food = 900;
2906 op->stats.hp = op->stats.maxhp;
2907 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2908 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2909 2655
2910 /* 2656 /*
2911 * Check to see if the player is in a shop. IF so, then check to see if
2912 * the player has any unpaid items. If so, remove them and put them back 2657 * Check to see if the player has any unpaid items. If so, remove them
2913 * in the map. 2658 * and put them back in the map.
2914 */ 2659 */
2915 2660 op->drop_unpaid_items ();
2916 if (is_in_shop (op))
2917 remove_unpaid_objects (op->inv, op);
2918 2661
2919 /****************************************/ 2662 /****************************************/
2920 /* */ 2663 /* */
2921 /* Move player to his current respawn- */ 2664 /* Move player to his current respawn- */
2922 /* position (usually last savebed) */ 2665 /* position (usually last savebed) */
2942 object *force; 2685 object *force;
2943 int at; 2686 int at;
2944 2687
2945 force = get_archetype (FORCE_NAME); 2688 force = get_archetype (FORCE_NAME);
2946 /* 50 ticks should be enough time for the spell to abate */ 2689 /* 50 ticks should be enough time for the spell to abate */
2947 force->speed = 0.1; 2690 force->speed = 0.1f;
2948 force->speed_left = -5.0; 2691 force->speed_left = -5.f;
2949 SET_FLAG (force, FLAG_APPLIED); 2692 SET_FLAG (force, FLAG_APPLIED);
2950 for (at = 0; at < NROFATTACKS; at++) 2693 for (at = 0; at < NROFATTACKS; at++)
2951 if (will_kill_again & (1 << at)) 2694 if (will_kill_again & (1 << at))
2952 force->resist[at] = 100; 2695 force->resist[at] = 100;
2953 2696
2954 insert_ob_in_ob (force, op); 2697 insert_ob_in_ob (force, op);
2955 op->update_stats (); 2698 op->update_stats ();
2956
2957 } 2699 }
2958 2700
2959 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2701 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2960} 2702}
2961 2703
2962void 2704void
2963loot_object (object *op) 2705loot_object (object *op)
2964{ /* Grab and destroy some treasure */ 2706{ /* Grab and destroy some treasure */
2965 object *tmp, *tmp2, *next; 2707 object *tmp, *tmp2, *next;
2966 2708
2967 if (op->container) 2709 op->close_container (); /* close open sack first */
2968 esrv_apply_container (op, op->container); /* close open sack first */
2969 2710
2970 for (tmp = op->inv; tmp; tmp = next) 2711 for (tmp = op->inv; tmp; tmp = next)
2971 { 2712 {
2972 next = tmp->below; 2713 next = tmp->below;
2973 2714
2974 if (tmp->invisible) 2715 if (tmp->invisible)
2975 continue; 2716 continue;
2976 2717
2977 tmp->remove (); 2718 tmp->remove ();
2978 tmp->x = op->x, tmp->y = op->y; 2719 tmp->x = op->x, tmp->y = op->y;
2720
2979 if (tmp->type == CONTAINER) 2721 if (tmp->type == CONTAINER)
2980 { /* empty container to ground */ 2722 loot_object (tmp); /* empty container to ground */
2981 loot_object (tmp); 2723
2982 }
2983 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(RANDOM () % 3))) 2724 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3))))
2984 { 2725 {
2985 if (tmp->nrof > 1) 2726 if (tmp->nrof > 1)
2986 { 2727 {
2987 tmp2 = get_split_ob (tmp, 1 + RANDOM () % (tmp->nrof - 1)); 2728 tmp->decrease (rndm (1, tmp->nrof - 1));
2988 tmp2->destroy ();
2989 insert_ob_in_map (tmp, op->map, NULL, 0); 2729 insert_ob_in_map (tmp, op->map, NULL, 0);
2990 } 2730 }
2991 else 2731 else
2992 tmp->destroy (); 2732 tmp->destroy ();
2993 } 2733 }
2999/* 2739/*
3000 * fix_weight(): Check recursively the weight of all players, and fix 2740 * fix_weight(): Check recursively the weight of all players, and fix
3001 * what needs to be fixed. Refresh windows and fix speed if anything 2741 * what needs to be fixed. Refresh windows and fix speed if anything
3002 * was changed. 2742 * was changed.
3003 */ 2743 */
3004
3005void 2744void
3006fix_weight (void) 2745fix_weight (void)
3007{ 2746{
3008 for_all_players (pl) 2747 for_all_players (pl)
3009 { 2748 {
3010 int old = pl->ob->carrying, sum = sum_weight (pl->ob); 2749 sint32 old = pl->ob->carrying;
3011 2750
3012 if (old == sum) 2751 pl->ob->update_weight ();
3013 continue; 2752
2753 if (old != pl->ob->carrying)
2754 {
3014 pl->ob->update_stats (); 2755 pl->ob->update_stats ();
3015 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, old, sum); 2756 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, (int)old, (int)pl->ob->carrying);
2757 }
3016 } 2758 }
3017} 2759}
3018 2760
3019void 2761void
3020fix_luck (void) 2762fix_luck (void)
3062} 2804}
3063 2805
3064void 2806void
3065make_visible (object *op) 2807make_visible (object *op)
3066{ 2808{
3067 op->hide = 0; 2809 op->flag [FLAG_HIDDEN] = 0;
3068 op->invisible = 0; 2810 op->invisible = 0;
2811
3069 if (op->type == PLAYER) 2812 if (op->type == PLAYER)
3070 { 2813 {
3071 op->contr->tmp_invis = 0; 2814 op->contr->tmp_invis = 0;
3072 op->contr->invis_race = 0; 2815 op->contr->invis_race = 0;
3073 } 2816 }
2817
3074 update_object (op, UP_OBJ_FACE); 2818 update_object (op, UP_OBJ_CHANGE);
3075} 2819}
3076 2820
3077int 2821int
3078is_true_undead (object *op) 2822is_true_undead (object *op)
3079{ 2823{
3080 object *tmp = NULL;
3081
3082 if (QUERY_FLAG (&op->arch->clone, FLAG_UNDEAD)) 2824 if (QUERY_FLAG (op->arch, FLAG_UNDEAD))
3083 return 1; 2825 return 1;
3084 2826
3085 return 0; 2827 return 0;
3086} 2828}
3087 2829
3088/* look at the surrounding terrain to determine 2830/* look at the surrounding terrain to determine
3089 * the hideability of this object. Positive levels 2831 * the hideability of this object. Positive levels
3090 * indicate greater hideability. 2832 * indicate greater hideability.
3091 */ 2833 */
3092
3093int 2834int
3094hideability (object *ob) 2835hideability (object *ob)
3095{ 2836{
3096 int i, level = 0, mflag; 2837 int i, level = 0, mflag;
3097 sint16 x, y; 2838 sint16 x, y;
3098 2839
3099 if (!ob || !ob->map) 2840 if (!ob || !ob->map)
3100 return 0; 2841 return 0;
3101 2842
3102 /* so, on normal lighted maps, its hard to hide */ 2843 /* so, on normal lighted maps, its hard to hide */
3103 level = ob->map->darkness - 2; 2844 level = ob->map->darklevel () - 2;
3104 2845
3105 /* this also picks up whether the object is glowing. 2846 /* this also picks up whether the object is glowing.
3106 * If you carry a light on a non-dark map, its not 2847 * If you carry a light on a non-dark map, its not
3107 * as bad as carrying a light on a pitch dark map */ 2848 * as bad as carrying a light on a pitch dark map */
3108 if (has_carried_lights (ob)) 2849 if (ob->has_carried_lights ())
3109 level = -(10 + (2 * ob->map->darkness)); 2850 level = -(10 + (2 * ob->map->darklevel ()));
3110 2851
3111 /* scan through all nearby squares for terrain to hide in */ 2852 /* scan through all nearby squares for terrain to hide in */
3112 for (i = 0, x = ob->x, y = ob->y; i < 9; i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2853 for (i = 0, x = ob->x, y = ob->y;
2854 i <= SIZEOFFREE1;
2855 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
3113 { 2856 {
3114 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 2857 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3115 if (mflag & P_OUT_OF_MAP) 2858 if (mflag & P_OUT_OF_MAP)
3116 {
3117 continue; 2859 continue;
3118 } 2860
3119 if (mflag & P_BLOCKSVIEW) /* something to hide near! */ 2861 if (mflag & P_BLOCKSVIEW) /* something to hide near! */
3120 level += 2; 2862 level += 2;
3121 else /* open terrain! */ 2863 else /* open terrain! */
3122 level -= 1; 2864 level -= 1;
3123 } 2865 }
3131/* For Hidden creatures - a chance of becoming 'unhidden' 2873/* For Hidden creatures - a chance of becoming 'unhidden'
3132 * every time they move - as we subtract off 'invisibility' 2874 * every time they move - as we subtract off 'invisibility'
3133 * AND, for players, if they move into a ridiculously unhideable 2875 * AND, for players, if they move into a ridiculously unhideable
3134 * spot (surrounded by clear terrain in broad daylight). -b.t. 2876 * spot (surrounded by clear terrain in broad daylight). -b.t.
3135 */ 2877 */
3136
3137void 2878void
3138do_hidden_move (object *op) 2879do_hidden_move (object *op)
3139{ 2880{
3140 int hide = 0, num = random_roll (0, 19, op, PREFER_LOW); 2881 int hide = 0;
3141 object *skop;
3142 2882
3143 if (!op || !op->map) 2883 if (!op || !op->map)
3144 return; 2884 return;
3145 2885
3146 skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING); 2886 object *skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING);
2887 int num = random_roll (0, 19, op, PREFER_LOW);
3147 2888
3148 /* its *extremely* hard to run and sneak/hide at the same time! */ 2889 /* its *extremely* hard to run and sneak/hide at the same time! */
3149 if (op->type == PLAYER && op->contr->run_on) 2890 if (op->type == PLAYER && op->contr->run_on)
3150 if (!skop || num >= skop->level) 2891 if (!skop || num >= skop->level)
3151 { 2892 {
3161 num -= hide; 2902 num -= hide;
3162 2903
3163 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0)) 2904 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0))
3164 { 2905 {
3165 make_visible (op); 2906 make_visible (op);
2907
3166 if (op->type == PLAYER) 2908 if (op->type == PLAYER)
3167 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!"); 2909 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!");
3168 } 2910 }
3169 else if (op->type == PLAYER && skop) 2911 else if (op->type == PLAYER && skop)
3170 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0); 2912 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0);
3223 * object op. This function works fine for monsters, 2965 * object op. This function works fine for monsters,
3224 * but we dont worry if the object isnt the top one in 2966 * but we dont worry if the object isnt the top one in
3225 * a pile (say a coin under a table would return "viewable" 2967 * a pile (say a coin under a table would return "viewable"
3226 * by this routine). Another question, should we be 2968 * by this routine). Another question, should we be
3227 * concerned with the direction the player is looking 2969 * concerned with the direction the player is looking
3228 * in? Realistically, most of use cant see stuff behind 2970 * in? Realistically, most of us can't see stuff behind
3229 * our backs...on the other hand, does the "facing" direction 2971 * our backs...on the other hand, does the "facing" direction
3230 * imply the way your head, or body is facing? Its possible 2972 * imply the way your head, or body is facing? It's possible
3231 * for them to differ. Sigh, this fctn could get a bit more complex. 2973 * for them to differ. Sigh, this fctn could get a bit more complex.
3232 * -b.t. 2974 * -b.t.
3233 * This function is now map tiling safe. 2975 * This function is now map tiling safe.
3234 */ 2976 */
3235
3236int 2977int
3237player_can_view (object *pl, object *op) 2978player_can_view (object *pl, object *op)
3238{ 2979{
3239 rv_vector rv; 2980 rv_vector rv;
3240 int dx, dy; 2981 int dx, dy;
3252 2993
3253 get_rangevector (pl, op, &rv, 0x1); 2994 get_rangevector (pl, op, &rv, 0x1);
3254 2995
3255 /* starting with the 'head' part, lets loop 2996 /* starting with the 'head' part, lets loop
3256 * through the object and find if it has any 2997 * through the object and find if it has any
3257 * part that is in the los array but isnt on 2998 * part that is in the los array but isn't on
3258 * a blocked los square. 2999 * a blocked los square.
3259 * we use the archetype to figure out offsets. 3000 * we use the archetype to figure out offsets.
3260 */ 3001 */
3261 while (op) 3002 while (op)
3262 { 3003 {
3263 dx = rv.distance_x + op->arch->clone.x; 3004 dx = rv.distance_x + op->arch->x;
3264 dy = rv.distance_y + op->arch->clone.y; 3005 dy = rv.distance_y + op->arch->y;
3265 3006
3266 /* only the viewable area the player sees is updated by LOS 3007 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3267 * code, so we need to restrict ourselves to that range of values
3268 * for any meaningful values.
3269 */
3270 if (FABS (dx) <= (pl->contr->ns->mapx / 2) &&
3271 FABS (dy) <= (pl->contr->ns->mapy / 2) &&
3272 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3273 return 1; 3008 return 1;
3009
3274 op = op->more; 3010 op = op->more;
3275 } 3011 }
3012
3276 return 0; 3013 return 0;
3277} 3014}
3278 3015
3279/* routine for both players and monsters. We call this when 3016/* routine for both players and monsters. We call this when
3280 * there is a possibility for our action distrubing our hiding 3017 * there is a possibility for our action distrubing our hiding
3281 * place or invisiblity spell. Artefact invisiblity is not 3018 * place or invisiblity spell. Artefact invisiblity causes
3282 * effected by this. If we arent invisible to begin with, we 3019 * "noise" instead. If we arent invisible to begin with, we
3283 * return 0. 3020 * return 0.
3284 */ 3021 */
3285int 3022int
3286action_makes_visible (object *op) 3023action_makes_visible (object *op)
3287{ 3024{
3288
3289 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE)) 3025 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3290 { 3026 {
3291 if (QUERY_FLAG (op, FLAG_MAKE_INVIS)) 3027 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3028 {
3029 // artefact invisibility is permanent, but we still make noise
3030 // this is important for game-balance.
3031 if (op->contr)
3032 op->make_noise ();
3033
3292 return 0; 3034 return 0;
3035 }
3293 3036
3294 if (op->contr && op->contr->tmp_invis == 0) 3037 if (op->contr && op->contr->tmp_invis == 0)
3295 return 0; 3038 return 0;
3296 3039
3297 /* If monsters, they should become visible */ 3040 /* If monsters, they should become visible */
3298 if (op->hide || !op->contr || (op->contr && op->contr->tmp_invis)) 3041 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
3299 { 3042 {
3300 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible"); 3043 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
3301 return 1; 3044 return 1;
3302 } 3045 }
3303 } 3046 }
3047
3304 return 0; 3048 return 0;
3305} 3049}
3306 3050
3307/* op_on_battleground - checks if the given object op (usually 3051/* op_on_battleground - checks if the given object op (usually
3308 * a player) is standing on a valid battleground-tile, 3052 * a player) is standing on a valid battleground-tile,
3313 * Default is to do the same as before, so only people wanting to have different points need worry about this 3057 * Default is to do the same as before, so only people wanting to have different points need worry about this
3314 */ 3058 */
3315int 3059int
3316op_on_battleground (object *op, int *x, int *y) 3060op_on_battleground (object *op, int *x, int *y)
3317{ 3061{
3318 object *tmp;
3319
3320 /* A battleground-tile needs the following attributes to be valid: 3062 /* A battleground-tile needs the following attributes to be valid:
3321 * is_floor 1 (has to be the FIRST floor beneath the player's feet), 3063 * is_floor 1 (has to be the FIRST floor beneath the player's feet),
3322 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND) 3064 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND)
3323 * and the exit-coordinates sp/hp must both be > 0. 3065 * and the exit-coordinates sp/hp must both be > 0.
3324 * => The intention here is to prevent abuse of the battleground- 3066 * => The intention here is to prevent abuse of the battleground-
3325 * feature (like pickable or hidden battleground tiles). */ 3067 * feature (like pickable or hidden battleground tiles). */
3326 for (tmp = op->below; tmp != NULL; tmp = tmp->below) 3068 for (object *tmp = op->below; tmp; tmp = tmp->below)
3327 { 3069 {
3328 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3070 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
3329 { 3071 {
3330 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && 3072 if (QUERY_FLAG (tmp, FLAG_NO_PICK)
3331 strcmp (tmp->name, "battleground") == 0 && tmp->type == BATTLEGROUND && EXIT_X (tmp) && EXIT_Y (tmp)) 3073 && tmp->type == BATTLEGROUND
3074 && tmp->name == shstr_battleground
3075 && EXIT_X (tmp) && EXIT_Y (tmp))
3332 { 3076 {
3333 /*before we assign the exit, check if this is a teambattle */ 3077 /* before we assign the exit, check if this is a teambattle */
3334 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3078 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3335 { 3079 {
3336 object *invtmp;
3337
3338 for (invtmp = op->inv; invtmp != NULL; invtmp = invtmp->below) 3080 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3339 { 3081 {
3340 if (invtmp->type == FORCE && invtmp->slaying && !strcmp (EXIT_PATH (tmp), invtmp->slaying)) 3082 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3341 { 3083 {
3342 if (x != NULL && y != NULL) 3084 if (x && y)
3343 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3085 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3086
3344 return 1; 3087 return 1;
3345 } 3088 }
3346 } 3089 }
3347 } 3090 }
3091
3348 if (x != NULL && y != NULL) 3092 if (x && y)
3349 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3093 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3094
3350 return 1; 3095 return 1;
3351 } 3096 }
3352 } 3097 }
3353 } 3098 }
3099
3354 /* If we got here, did not find a battleground */ 3100 /* If we got here, did not find a battleground */
3355 return 0; 3101 return 0;
3356} 3102}
3357 3103
3358/* 3104/*
3374 char buf[MAX_BUF]; /* tmp. string buffer */ 3120 char buf[MAX_BUF]; /* tmp. string buffer */
3375 int i = 0, j = 0; 3121 int i = 0, j = 0;
3376 3122
3377 /* get the appropriate treasurelist */ 3123 /* get the appropriate treasurelist */
3378 if (atnr == ATNR_FIRE) 3124 if (atnr == ATNR_FIRE)
3379 trlist = find_treasurelist ("dragon_ability_fire"); 3125 trlist = treasurelist::find (shstr_dragon_ability_fire);
3380 else if (atnr == ATNR_COLD) 3126 else if (atnr == ATNR_COLD)
3381 trlist = find_treasurelist ("dragon_ability_cold"); 3127 trlist = treasurelist::find (shstr_dragon_ability_cold);
3382 else if (atnr == ATNR_ELECTRICITY) 3128 else if (atnr == ATNR_ELECTRICITY)
3383 trlist = find_treasurelist ("dragon_ability_elec"); 3129 trlist = treasurelist::find (shstr_dragon_ability_elec);
3384 else if (atnr == ATNR_POISON) 3130 else if (atnr == ATNR_POISON)
3385 trlist = find_treasurelist ("dragon_ability_poison"); 3131 trlist = treasurelist::find (shstr_dragon_ability_poison);
3386 3132
3387 if (trlist == NULL || who->type != PLAYER) 3133 if (trlist == NULL || who->type != PLAYER)
3388 return; 3134 return;
3389 3135
3390 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++); 3136 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++);
3394 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */ 3140 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */
3395 return; 3141 return;
3396 } 3142 }
3397 3143
3398 /* everything seems okay - now bring on the gift: */ 3144 /* everything seems okay - now bring on the gift: */
3399 item = &(tr->item->clone); 3145 item = tr->item;
3400 3146
3401 if (item->type == SPELL) 3147 if (item->type == SPELL)
3402 { 3148 {
3403 if (check_spell_known (who, item->name)) 3149 if (check_spell_known (who, item->name))
3404 return; 3150 return;
3463 { 3209 {
3464 /* forces in the treasurelist can alter the player's stats */ 3210 /* forces in the treasurelist can alter the player's stats */
3465 object *skin; 3211 object *skin;
3466 3212
3467 /* first get the dragon skin force */ 3213 /* first get the dragon skin force */
3468 shstr_cmp dragon_skin_force ("dragon_skin_force");
3469 for (skin = who->inv; skin && !(skin->arch->name == dragon_skin_force); skin = skin->below) 3214 for (skin = who->inv; skin && !(skin->arch->archname == shstr_dragon_skin_force); skin = skin->below)
3470 ; 3215 ;
3471 3216
3472 if (!skin) 3217 if (!skin)
3473 return; 3218 return;
3474 3219
3509 else 3254 else
3510 { 3255 {
3511 /* generate misc. treasure */ 3256 /* generate misc. treasure */
3512 tmp = arch_to_object (tr->item); 3257 tmp = arch_to_object (tr->item);
3513 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3258 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3514 tmp = insert_ob_in_ob (tmp, who); 3259 who->insert (tmp);
3515 if (who->type == PLAYER)
3516 esrv_send_item (who, tmp);
3517 } 3260 }
3518} 3261}
3519 3262
3520/** 3263/**
3521 * Unready an object for a player. This function does nothing if the object was 3264 * Unready an object for a player. This function does nothing if the object was
3522 * not readied. 3265 * not readied.
3523 */ 3266 */
3524void 3267void
3525player_unready_range_ob (player *pl, object *ob) 3268player_unready_range_ob (player *pl, object *ob)
3526{ 3269{
3527 for (rangetype i = (rangetype) 0; i < range_size; i = (rangetype) ((int) i + 1)) 3270 if (pl->ob->current_weapon == ob)
3271 pl->ob->current_weapon = 0;
3272
3273 if (pl->combat_ob == ob)
3274 pl->combat_ob = 0;
3275
3528 if (pl->ranges[i] == ob) 3276 if (pl->ranged_ob == ob)
3529 {
3530 pl->ranges[i] = 0; 3277 pl->ranged_ob = 0;
3531 if (pl->shoottype == i)
3532 pl->shoottype = range_none;
3533 }
3534} 3278}
3279
3280sint8
3281player::darkness_at (maptile *map, int x, int y) const
3282{
3283 if (!ns)
3284 return LOS_BLOCKED;
3285
3286 int dx, dy;
3287 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3288 return LOS_BLOCKED;
3289
3290 x += dx - ns->current_x;
3291 y += dy - ns->current_y;
3292
3293 return blocked_los (x, y);
3294}
3295
3296void
3297player::infobox (const char *title, const char *msg, int color)
3298{
3299 send_msg (color | NDI_DEF | NDI_REPLY | NDI_CLEAR, title, msg);
3300}
3301
3302void
3303player::statusmsg (const char *msg, int color)
3304{
3305 send_msg (color | NDI_REPLY, INFO_CHANNEL, msg);
3306}
3307
3308void
3309player::failmsg (const char *msg, int color)
3310{
3311 play_sound (sound_find ("generic_failure"));
3312 statusmsg (msg, color);
3313}
3314

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines