ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/player.C
(Generate patch)

Comparing deliantra/server/server/player.C (file contents):
Revision 1.99 by root, Thu Jan 18 19:42:10 2007 UTC vs.
Revision 1.294 by root, Wed Nov 16 23:42:03 2016 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
21 * 21 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24 24
25//+GPL
26
27#include <algorithm>
28#include <functional>
29
25#include <global.h> 30#include <global.h>
26#include <pwd.h>
27#include <sproto.h> 31#include <sproto.h>
28#include <sounds.h> 32#include <sounds.h>
29#include <living.h> 33#include <living.h>
30#include <object.h> 34#include <object.h>
31#include <spells.h> 35#include <spells.h>
32#include <skills.h> 36#include <skills.h>
33 37
34#include <algorithm>
35#include <functional>
36
37playervec players; 38playervec players;
38
39void
40display_motd (const object *op)
41{
42 char buf[MAX_BUF];
43 char motd[HUGE_BUF];
44 FILE *fp;
45 int comp;
46 int size;
47
48 sprintf (buf, "%s/%s", settings.confdir, settings.motd);
49 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
50 return;
51
52 motd[0] = '\0';
53 size = 0;
54
55 while (fgets (buf, MAX_BUF, fp))
56 {
57 if (*buf == '#')
58 continue;
59
60 strncat (motd + size, buf, HUGE_BUF - size);
61 size += strlen (buf);
62 }
63
64 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_MOTD, MSG_SUBTYPE_NONE, motd, NULL);
65 close_and_delete (fp, comp);
66}
67
68void
69send_rules (const object *op)
70{
71 char buf[MAX_BUF];
72 char rules[HUGE_BUF];
73 FILE *fp;
74 int comp;
75 int size;
76
77 sprintf (buf, "%s/%s", settings.confdir, settings.rules);
78 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
79 return;
80
81 rules[0] = '\0';
82 size = 0;
83
84 while (fgets (buf, MAX_BUF, fp))
85 {
86 if (*buf == '#')
87 continue;
88
89 if (size + strlen (buf) >= HUGE_BUF)
90 {
91 LOG (llevDebug, "Warning, rules size is > %d bytes.\n", HUGE_BUF);
92 break;
93 }
94
95 strncat (rules + size, buf, HUGE_BUF - size);
96 size += strlen (buf);
97 }
98
99 draw_ext_info (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_RULES, rules, NULL);
100 close_and_delete (fp, comp);
101}
102
103void
104send_news (const object *op)
105{
106 char buf[MAX_BUF];
107 char news[HUGE_BUF];
108 char subject[MAX_BUF];
109 FILE *fp;
110 int comp;
111 int size;
112
113 sprintf (buf, "%s/%s", settings.confdir, settings.news);
114 if ((fp = open_and_uncompress (buf, 0, &comp)) == NULL)
115 return;
116
117 news[0] = '\0';
118 subject[0] = '\0';
119 size = 0;
120
121 while (fgets (buf, MAX_BUF, fp) != NULL)
122 {
123 if (*buf == '#')
124 continue;
125
126 if (*buf == '%')
127 { /* send one news */
128 if (size > 0)
129 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op, MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s", "%s\n%s", subject, news); /*send previously read news */
130
131 strcpy (subject, buf + 1);
132 strip_endline (subject);
133 size = 0;
134 news[0] = '\0';
135 }
136 else
137 {
138 if (size + strlen (buf) >= HUGE_BUF)
139 {
140 LOG (llevDebug, "Warning, one news item has size > %d bytes.\n", HUGE_BUF);
141 break;
142 }
143 strncat (news + size, buf, HUGE_BUF - size);
144 size += strlen (buf);
145 }
146 }
147
148 draw_ext_info_format (NDI_UNIQUE | NDI_GREEN, 0, op,
149 MSG_TYPE_ADMIN, MSG_TYPE_ADMIN_NEWS, "INFORMATION: %s\n%s\n", "%s\n%s", subject, news);
150 close_and_delete (fp, comp);
151}
152 39
153/* This loads the first map an puts the player on it. */ 40/* This loads the first map an puts the player on it. */
154static void 41static void
155set_first_map (object *op) 42set_first_map (object *op)
156{ 43{
157 op->contr->maplevel = first_map_path; 44 op->contr->maplevel = first_map_path;
158 op->x = -1; 45 op->x = -1;
159 op->y = -1; 46 op->y = -1;
160}
161
162void
163player::enter_map ()
164{
165 object *tmp = object::create ();
166
167 EXIT_PATH (tmp) = maplevel;
168 EXIT_X (tmp) = ob->x;
169 EXIT_Y (tmp) = ob->y;
170 ob->enter_exit (tmp);
171
172 tmp->destroy ();
173} 47}
174 48
175void 49void
176player::activate () 50player::activate ()
177{ 51{
… …
180 54
181 players.insert (this); 55 players.insert (this);
182 ob->remove (); 56 ob->remove ();
183 ob->map = 0; 57 ob->map = 0;
184 ob->activate_recursive (); 58 ob->activate_recursive ();
185 CLEAR_FLAG (ob, FLAG_FRIENDLY); 59 ob->clr_flag (FLAG_FRIENDLY);
186 add_friendly_object (ob); 60 add_friendly_object (ob);
187 enter_map ();
188} 61}
189 62
190void 63void
191player::deactivate () 64player::deactivate ()
192{ 65{
… …
194 return; 67 return;
195 68
196 terminate_all_pets (ob); 69 terminate_all_pets (ob);
197 remove_friendly_object (ob); 70 remove_friendly_object (ob);
198 ob->deactivate_recursive (); 71 ob->deactivate_recursive ();
72
73 if (ob->map)
199 maplevel = ob->map->path; 74 maplevel = ob->map->path;
75
200 ob->remove (); 76 ob->remove ();
77 ob->enemy = 0; // sometimes keeps an extra refcount on itself
201 ob->map = 0; 78 ob->map = 0;
202 79 party = 0;
203 // for weird reasons, this is often "ob", keeping a circular reference
204 ranges [range_skill] = 0;
205 80
206 players.erase (this); 81 players.erase (this);
207} 82}
208 83
209// connect the player with a specific client 84// connect the player with a specific client
210// also changed, rationalises, and fixes some incorrect settings 85// also changes, rationalises, and fixes some incorrect settings
211void 86void
212player::connect (client *ns) 87player::connect (client *ns)
213{ 88{
214 this->ns = ns; 89 this->ns = ns;
215 ns->pl = this; 90 ns->pl = this;
216 91
217 run_on = 0; 92 run_on = 0;
218 fire_on = 0; 93 fire_on = 0;
219 ob->container = 0; //TODO: client-specific 94 ob->close_container (); //TODO: client-specific
220 95
221 ns->update_look = 0; 96 ns->update_look = 0;
222 ns->look_position = 0; 97 ns->look_position = 0;
223 98
224 clear_los (ob); 99 clear_los ();
225 100
226 ns->reset_stats (); 101 ns->reset_stats ();
227 102
228 /* make sure he's a player -- needed because of class change. */ 103 /* make sure he's a player -- needed because of class change. */
229 ob->type = PLAYER; // we are paranoid 104 ob->type = PLAYER; // we are paranoid
230 ob->race = ob->arch->clone.race; 105 ob->race = ob->arch->race;
231 106
232 if (!legal_range (ob, shoottype)) 107 ob->update_weight ();
233 shoottype = range_none;
234
235 ob->carrying = sum_weight (ob);
236 link_player_skills (ob); 108 link_skills ();
237 109
238 CLEAR_FLAG (ob, FLAG_NO_FIX_PLAYER);
239
240 assign (title, ob->arch->clone.name); 110 assign (title, ob->arch->object::name);
241
242 /* can_use_shield is a new flag. However, the can_use.. seems to largely come
243 * from the class, and not race. I don't see any way to get the class information
244 * to then update this. I don't think this will actually break anything - anyone
245 * that can use armour should be able to use a shield. What this may 'break'
246 * are features new characters get, eg, if someone starts up with a Q, they
247 * should be able to use a shield. However, old Q's won't get that advantage.
248 */
249 if (QUERY_FLAG (ob, FLAG_USE_ARMOUR))
250 SET_FLAG (ob, FLAG_USE_SHIELD);
251 111
252 /* if it's a dragon player, set the correct title here */ 112 /* if it's a dragon player, set the correct title here */
253 if (is_dragon_pl (ob)) 113 if (ob->is_dragon ())
254 { 114 {
255 object *tmp, *abil = 0, *skin = 0; 115 object *tmp, *abil = 0, *skin = 0;
256
257 shstr_cmp dragon_ability_force ("dragon_ability_force");
258 shstr_cmp dragon_skin_force ("dragon_skin_force");
259 116
260 for (tmp = ob->inv; tmp; tmp = tmp->below) 117 for (tmp = ob->inv; tmp; tmp = tmp->below)
261 if (tmp->type == FORCE) 118 if (tmp->type == FORCE)
262 if (tmp->arch->name == dragon_ability_force) 119 if (tmp->arch->archname == shstr_dragon_ability_force)
263 abil = tmp; 120 abil = tmp;
264 else if (tmp->arch->name == dragon_skin_force) 121 else if (tmp->arch->archname == shstr_dragon_skin_force)
265 skin = tmp; 122 skin = tmp;
266 123
267 set_dragon_name (ob, abil, skin); 124 set_dragon_name (ob, abil, skin);
268 } 125 }
269 126
270 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!"); 127 new_draw_info (NDI_UNIQUE, 0, ob, "Welcome Back!");
271 128
272 esrv_new_player (this, ob->weight + ob->carrying); 129 esrv_new_player (this);
130
131 ob->flag [FLAG_READY_WEAPON] = false;
132 ob->flag [FLAG_READY_SKILL] = false;
133 ob->flag [FLAG_READY_RANGE] = false;
134 ob->flag [FLAG_READY_BOW] = false;
273 135
274 ob->update_stats (); 136 ob->update_stats ();
137
275 ns->floorbox_update (); 138 ns->floorbox_update ();
276
277 esrv_send_inventory (ob, ob); 139 esrv_send_inventory (ob, ob);
278 esrv_add_spells (this, 0); 140 esrv_add_spells (this, 0);
279 141
280 activate (); 142 activate ();
281 143
282 send_rules (ob);
283 send_news (ob);
284 display_motd (ob);
285
286 INVOKE_PLAYER (CONNECT, this); 144 INVOKE_PLAYER (CONNECT, this);
287 INVOKE_PLAYER (LOGIN, this); 145 INVOKE_PLAYER (LOGIN, this);
288} 146}
289 147
290void 148void
291player::disconnect () 149player::disconnect ()
292{ 150{
151 if (ob)
152 {
153 ob->close_container (); //TODO: client-specific
154 ob->drop_unpaid_items ();
155 }
156
293 if (ns) 157 if (ns)
294 { 158 {
295 if (active) 159 if (active)
296 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0)); 160 INVOKE_PLAYER (LOGOUT, this, ARG_INT (0));
297 161
298 INVOKE_PLAYER (DISCONNECT, this); 162 INVOKE_PLAYER (DISCONNECT, this);
299 163
300 ns->reset_stats (); 164 ns->reset_stats ();
301 ns->pl = 0; 165 ns->pl = 0;
302 this->ns = 0; 166 ns = 0;
303 } 167 }
304 168
305 ob->container = 0; //TODO: client-specific 169 // this is important for the player scheduler to get the correct refcount
170 // when ns = 0
171 observe = viewpoint = ob;
172
306 deactivate (); 173 deactivate ();
307} 174}
175
176//-GPL
308 177
309// the need for this function can be explained 178// the need for this function can be explained
310// by load_object not returning the object 179// by load_object not returning the object
311void 180void
312player::set_object (object *op) 181player::set_object (object *op)
313{ 182{
314 ob = op; 183 ob = observe = viewpoint = op;
315 ob->contr = this; /* this aren't yet in archetype */ 184 ob->contr = this; /* this aren't yet in archetype */
316 185
186 ob->speed = 1.0f; // object still inactive, keep it that way
317 ob->speed_left = 0.5; 187 ob->speed_left = 0.5f;
318 ob->speed = 1.0; 188
319 ob->direction = 5; /* So player faces south */ 189 ob->direction = 5; /* So player faces south */
320 ob->stats.wc = 2;
321 ob->run_away = 25; /* Then we panick... */
322
323 ob->roll_stats ();
324} 190}
191
192void
193player::set_observe (object *op)
194{
195 observe = viewpoint = op ? op : ob;
196 do_los = 1;
197}
198
199void
200player::set_viewpoint (object *op)
201{
202 viewpoint = op ? op : (object *)observe;
203 do_los = 1;
204}
205
206//+GPL
325 207
326player::player () 208player::player ()
327{ 209{
328 /* There are some elements we want initialised to non zero value - 210 /* There are some elements we want initialised to non zero value -
329 * we deal with that below this point. 211 * we deal with that below this point.
330 */ 212 */
331 outputs_sync = 16; /* Every 2 seconds */ 213 outputs_sync = 4;
332 outputs_count = 8; /* Keeps present behaviour */ 214 outputs_count = 4;
333 unapply = unapply_nochoice; 215 unapply = unapply_nochoice;
334 216
335 savebed_map = first_map_path; /* Init. respawn position */ 217 savebed_map = first_map_path; /* Init. respawn position */
336 218
337 gen_sp_armour = 10; 219 gen_sp_armour = 10;
338 shoottype = range_none;
339 bowtype = bow_normal; 220 bowtype = bow_normal;
340 petmode = pet_normal; 221 petmode = pet_normal;
341 listening = 10;
342 usekeys = containers; 222 usekeys = containers;
343 peaceful = 1; /* default peaceful */ 223 peaceful = 1; /* default peaceful */
344 do_los = 1; 224 do_los = 1;
225
226 weapon_sp = 1.0f;
227 weapon_sp_left = 0.5f;
345} 228}
346 229
347void 230void
348player::do_destroy () 231player::do_destroy ()
349{ 232{
350 disconnect (); 233 disconnect ();
351 234
352 attachable::do_destroy (); 235 attachable::do_destroy ();
353 236
354 if (ob) 237 if (ob)
355 {
356 ob->destroy_inv (false);
357 ob->destroy (); 238 ob->destroy ();
358 } 239
240 ob = observe = viewpoint = 0;
359} 241}
360 242
361player::~player () 243player::~player ()
362{ 244{
363 /* Clear item stack */ 245 /* Clear item stack */
364 free (stack_items); 246 free (stack_items);
247}
248
249/*
250 * get_player_archetype() return next player archetype from archetype
251 * list. Not very efficient routine, but used only creating new players.
252 * Note: there MUST be at least one player archetype!
253 */
254static archetype *
255get_player_archetype (archetype *at)
256{
257 // archetypes could have been reloaded
258 archetype *nat = at ? archetype::find (at->archname) : archetypes [0];
259
260 if (!nat)
261 return at;
262
263 archvec::iterator i = archetypes.find (nat);
264
265 for (;;)
266 {
267 if (++i == archetypes.end ())
268 i = archetypes.begin ();
269 else if (*i == at)
270 cleanup ("not a single player archetype found");
271
272 if ((*i)->type == PLAYER)
273 return *i;
274 }
365} 275}
366 276
367/* Tries to add player on the connection passed in ns. 277/* Tries to add player on the connection passed in ns.
368 * All we can really get in this is some settings like host and display 278 * All we can really get in this is some settings like host and display
369 * mode. 279 * mode.
… …
371player * 281player *
372player::create () 282player::create ()
373{ 283{
374 player *pl = new player; 284 player *pl = new player;
375 285
376 pl->set_object (arch_to_object (get_player_archetype (0))); 286 pl->set_object (get_player_archetype (0)->instance ());
287
288 pl->ob->roll_stats ();
289 pl->ob->stats.wc = 2;
290 pl->ob->run_away = 25; /* Then we panick... */
291
377 set_first_map (pl->ob); 292 set_first_map (pl->ob);
378 293
379 return pl; 294 return pl;
380}
381
382/*
383 * get_player_archetype() return next player archetype from archetype
384 * list. Not very efficient routine, but used only creating new players.
385 * Note: there MUST be at least one player archetype!
386 */
387archetype *
388get_player_archetype (archetype *at)
389{
390 archetype *start = at;
391
392 for (;;)
393 {
394 if (at == NULL || at->next == NULL)
395 at = first_archetype;
396 else
397 at = at->next;
398
399 if (at->clone.type == PLAYER)
400 return at;
401
402 if (at == start)
403 {
404 LOG (llevError, "No Player archetypes\n");
405 exit (-1);
406 }
407 }
408} 295}
409 296
410object * 297object *
411get_nearest_player (object *mon) 298get_nearest_player (object *mon)
412{ 299{
… …
415 unsigned lastdist; 302 unsigned lastdist;
416 rv_vector rv; 303 rv_vector rv;
417 304
418 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next) 305 for (ol = first_friendly_object, lastdist = 1000; ol; ol = ol->next)
419 { 306 {
420 /* We should not find free objects on this friendly list, but it
421 * does periodically happen. Given that, lets deal with it.
422 * While unlikely, it is possible the next object on the friendly
423 * list is also free, so encapsulate this in a while loop.
424 */
425 while (QUERY_FLAG (ol->ob, FLAG_FREED) || !QUERY_FLAG (ol->ob, FLAG_FRIENDLY))
426 {
427 object *tmp = ol->ob;
428
429 /* Can't do much more other than log the fact, because the object
430 * itself will have been cleared.
431 */
432 LOG (llevDebug, "get_nearest_player: Found free/non friendly object '%s' on friendly list\n",
433 tmp->debug_desc ());
434 ol = ol->next;
435 remove_friendly_object (tmp);
436 if (!ol)
437 return op;
438 }
439
440 /* Remove special check for player from this. First, it looks to cause
441 * some crashes (ol->ob->contr not set properly?), but secondly, a more
442 * complicated method of state checking would be needed in any case -
443 * as it was, a clever player could type quit, and the function would
444 * skip them over while waiting for confirmation. Remove
445 * on_same_map check, as can_detect_enemy also does this
446 */
447 if (!can_detect_enemy (mon, ol->ob, &rv)) 307 if (!can_detect_enemy (mon, ol->ob, &rv))
448 continue; 308 continue;
449 309
450 if (lastdist > rv.distance) 310 if (lastdist > rv.distance)
451 { 311 {
… …
513 */ 373 */
514int 374int
515path_to_player (object *mon, object *pl, unsigned mindiff) 375path_to_player (object *mon, object *pl, unsigned mindiff)
516{ 376{
517 rv_vector rv; 377 rv_vector rv;
518 sint16 x, y;
519 int lastx, lasty, dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES, mflags, blocked; 378 int dir, i, diff, firstdir = 0, lastdir, max = MAX_SPACES;
520 maptile *m, *lastmap;
521 379
522 get_rangevector (mon, pl, &rv, 0); 380 get_rangevector (mon, pl, &rv, 0);
523 381
524 if (rv.distance < mindiff) 382 if (rv.distance < mindiff)
525 return 0; 383 return 0;
526 384
527 x = mon->x; 385 mapxy pos (mon);
528 y = mon->y;
529 m = mon->map;
530 dir = rv.direction; 386 dir = rv.direction;
531 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */ 387 lastdir = firstdir = rv.direction; /* perhaps we stand next to pl, init firstdir too */
532 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 388 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
389
533 /* If we can't solve it within the search distance, return now. */ 390 /* If we can't solve it within the search distance, return now. */
534 if (diff > max) 391 if (diff > max)
535 return 0; 392 return 0;
393
536 while (diff > 1 && max > 0) 394 while (diff > 1 && max > 0)
537 { 395 {
538 lastx = x; 396 mapxy lastpos = pos;
539 lasty = y;
540 lastmap = m;
541 x = lastx + freearr_x[dir];
542 y = lasty + freearr_y[dir];
543 397
544 mflags = get_map_flags (m, &m, x, y, &x, &y); 398 pos.move (dir);
545 blocked = (mflags & P_OUT_OF_MAP) ? MOVE_ALL : GET_MAP_MOVE_BLOCK (m, x, y);
546 399
547 /* Space is blocked - try changing direction a little */ 400 /* Space is blocked - try changing direction a little */
548 if ((mflags & P_OUT_OF_MAP) || ((OB_TYPE_MOVE_BLOCK (mon, blocked) || (mflags & P_BLOCKSVIEW)) 401 if (!pos.normalise ()
549 && (m == mon->map && blocked_link (mon, m, x, y)))) 402 || (((pos->flags () & P_BLOCKSVIEW) || OB_TYPE_MOVE_BLOCK (mon, pos->move_block))
403 && blocked_link (mon, pos.m, pos.x, pos.y)))
550 { 404 {
551 /* recalculate direction from last good location. Possible 405 /* recalculate direction from last good location. Possible
552 * we were not traversing ideal location before. 406 * we were not traversing ideal location before.
553 */ 407 */
554 get_rangevector_from_mapcoord (lastmap, lastx, lasty, pl, &rv, 0); 408 get_rangevector_from_mapcoord (lastpos.m, lastpos.x, lastpos.y, pl, &rv, 0);
555 if (rv.direction != dir) 409 if (rv.direction != dir)
556 { 410 {
557 /* OK - says direction should be different - lets reset the 411 /* OK - says direction should be different - lets reset the
558 * the values so it will try again. 412 * the values so it will try again.
559 */ 413 */
560 x = lastx;
561 y = lasty;
562 m = lastmap; 414 pos = lastpos;
563 dir = firstdir = rv.direction; 415 dir = firstdir = rv.direction;
564 } 416 }
565 else 417 else
566 { 418 {
567 /* direct path is blocked - try taking a side step to 419 /* direct path is blocked - try taking a side step to
… …
574 */ 426 */
575 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++) 427 for (i = -DETOUR_AMOUNT; i <= DETOUR_AMOUNT; i++)
576 { 428 {
577 if (i == 0) 429 if (i == 0)
578 continue; /* already did this, so skip it */ 430 continue; /* already did this, so skip it */
431
579 /* Use lastdir here - otherwise, 432 /* Use lastdir here - otherwise,
580 * since the direction that the creature should move in 433 * since the direction that the creature should move in
581 * may change, you could get infinite loops. 434 * may change, you could get infinite loops.
582 * ie, player is northwest, but monster can only 435 * ie, player is northwest, but monster can only
583 * move west, so it does that. It goes some distance, 436 * move west, so it does that. It goes some distance,
… …
585 * can't do that, but now finds it can move east, and 438 * can't do that, but now finds it can move east, and
586 * gets back to its original point. lastdir contains 439 * gets back to its original point. lastdir contains
587 * the last direction the creature has successfully 440 * the last direction the creature has successfully
588 * moved. 441 * moved.
589 */ 442 */
590
591 x = lastx + freearr_x[absdir (lastdir + i)];
592 y = lasty + freearr_y[absdir (lastdir + i)];
593 m = lastmap; 443 pos = lastpos;
594 mflags = get_map_flags (m, &m, x, y, &x, &y); 444 pos.move (absdir (lastdir + i));
595 if (mflags & P_OUT_OF_MAP) 445
446 if (!pos.normalise ())
596 continue; 447 continue;
597 blocked = GET_MAP_MOVE_BLOCK (m, x, y); 448
598 if (OB_TYPE_MOVE_BLOCK (mon, blocked)) 449 mapspace &ms = *pos;
450
451 if (ms.flags () & P_BLOCKSVIEW)
599 continue; 452 continue;
600 if (mflags & P_BLOCKSVIEW) 453
454 if (OB_TYPE_MOVE_BLOCK (mon, ms.move_block))
601 continue; 455 continue;
602 456
603 if (m == mon->map && blocked_link (mon, m, x, y)) 457 if (blocked_link (mon, pos.m, pos.x, pos.y))
604 break; 458 break;
605 } 459 }
460
606 /* go through entire loop without finding a valid 461 /* go through entire loop without finding a valid
607 * sidestep to take - thus, no valid path. 462 * sidestep to take - thus, no valid path.
608 */ 463 */
609 if (i == (DETOUR_AMOUNT + 1)) 464 if (i == DETOUR_AMOUNT + 1)
610 return 0; 465 return 0;
466
611 diff--; 467 diff--;
612 lastdir = dir; 468 lastdir = dir;
613 max--; 469 max--;
614 if (!firstdir) 470 if (!firstdir)
615 firstdir = dir + i; 471 firstdir = dir + i;
… …
619 { 475 {
620 /* we moved towards creature, so diff is less */ 476 /* we moved towards creature, so diff is less */
621 diff--; 477 diff--;
622 max--; 478 max--;
623 lastdir = dir; 479 lastdir = dir;
480
624 if (!firstdir) 481 if (!firstdir)
625 firstdir = dir; 482 firstdir = dir;
626 } 483 }
484
627 if (diff <= 1) 485 if (diff <= 1)
628 { 486 {
629 /* Recalculate diff (distance) because we may not have actually 487 /* Recalculate diff (distance) because we may not have actually
630 * headed toward player for entire distance. 488 * headed toward player for entire distance.
631 */ 489 */
632 get_rangevector_from_mapcoord (m, x, y, pl, &rv, 0); 490 get_rangevector_from_mapcoord (pos.m, pos.x, pos.y, pl, &rv, 0);
633 diff = FABS (rv.distance_x) > FABS (rv.distance_y) ? FABS (rv.distance_x) : FABS (rv.distance_y); 491 diff = ::max (abs (rv.distance_x), abs (rv.distance_y));
634 } 492 }
493
635 if (diff > max) 494 if (diff > max)
636 return 0; 495 return 0;
637 } 496 }
497
638 /* If we reached the max, didn't find a direction in time */ 498 /* If we reached the max, didn't find a direction in time */
639 if (!max) 499 if (!max)
640 return 0; 500 return 0;
641 501
642 return firstdir; 502 return firstdir;
643} 503}
644 504
645void 505void
646give_initial_items (object *pl, treasurelist * items) 506give_initial_items (object *pl, treasurelist *items)
647{ 507{
648 object *op, *next = NULL;
649
650 if (pl->randomitems != NULL) 508 if (pl->randomitems)
651 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0); 509 create_treasure (items, pl, GT_STARTEQUIP | GT_ONLY_GOOD, 1, 0);
652 510
653 for (op = pl->inv; op; op = next) 511 for (object *next, *op = pl->inv; op; op = next)
654 { 512 {
655 next = op->below; 513 next = op->below;
656 514
657 /* Forces get applied per default, unless they have the 515 /* Forces get applied per default, unless they have the
658 * flag "neutral" set. Sorry but I can't think of a better way 516 * flag "neutral" set. Sorry but I can't think of a better way
659 */ 517 */
660 if (op->type == FORCE && !QUERY_FLAG (op, FLAG_NEUTRAL)) 518 if (op->type == FORCE && !op->flag [FLAG_NEUTRAL])
661 SET_FLAG (op, FLAG_APPLIED); 519 op->set_flag (FLAG_APPLIED);
662 520
663 /* we never give weapons/armour if these cannot be used 521 /* we never give weapons/armour if these cannot be used
664 * by this player due to race restrictions 522 * by this player due to race restrictions
665 */ 523 */
666 if (pl->type == PLAYER) 524 if (pl->type == PLAYER)
667 { 525 {
668 if ((!QUERY_FLAG (pl, FLAG_USE_ARMOUR) && 526 if ((!pl->flag [FLAG_USE_ARMOUR]
527 &&
669 (op->type == ARMOUR || op->type == BOOTS || 528 (op->type == ARMOUR || op->type == BOOTS
670 op->type == CLOAK || op->type == HELMET || 529 || op->type == CLOAK || op->type == HELMET
671 op->type == SHIELD || op->type == GLOVES || 530 || op->type == SHIELD || op->type == GLOVES
672 op->type == BRACERS || op->type == GIRDLE)) || (!QUERY_FLAG (pl, FLAG_USE_WEAPON) && op->type == WEAPON)) 531 || op->type == BRACERS || op->type == GIRDLE))
532 || (!pl->flag [FLAG_USE_WEAPON] && op->type == WEAPON))
673 { 533 {
674 op->destroy (); 534 op->destroy ();
675 continue; 535 continue;
676 } 536 }
677 } 537 }
678 538
679 /* This really needs to be better - we should really give 539 /* Here we remove duplicated skills (as duplicated spell objects have
680 * a substitute spellbook. The problem is that we don't really 540 * _very_ confusing effects for players), which could for instance be
681 * have a good idea what to replace it with (need something like 541 * generated by multiple treasurelists specifying the same skills.
682 * a first level treasurelist for each skill.)
683 * remove duplicate skills also
684 */ 542 */
685 if (op->type == SPELLBOOK || op->type == SKILL) 543 if (op->type == SKILL)
686 { 544 {
687 object *tmp;
688
689 for (tmp = op->below; tmp; tmp = tmp->below) 545 for (object *tmp = op->below; tmp; tmp = tmp->below)
690 if (tmp->type == op->type && tmp->name == op->name) 546 if (tmp->type == op->type && tmp->name == op->name)
691 break;
692
693 if (tmp)
694 { 547 {
695 op->destroy (); 548 op->destroy ();
696 LOG (llevError, "give_initial_items: Removing duplicate object %s\n", &tmp->name); 549 break;
697 continue;
698 } 550 }
699 551
700 if (op->nrof > 1) 552 if (op->nrof > 1)
701 op->nrof = 1; 553 op->nrof = 1;
702 } 554 }
703 555
704 if (op->type == SPELLBOOK && op->inv) 556 if (op->type == SPELLBOOK && op->inv)
705 { 557 op->inv->clr_flag (FLAG_STARTEQUIP);
706 CLEAR_FLAG (op->inv, FLAG_STARTEQUIP);
707 }
708 558
709 /* Give starting characters identified, uncursed, and undamned 559 /* Give starting characters identified, uncursed, and undamned
710 * items. Just don't identify gold or silver, or it won't be 560 * items. Just don't identify gold or silver, or it won't be
711 * merged properly. 561 * merged properly.
712 */ 562 */
713 if (need_identify (op)) 563 if (op->need_identify ())
714 {
715 SET_FLAG (op, FLAG_IDENTIFIED);
716 CLEAR_FLAG (op, FLAG_CURSED);
717 CLEAR_FLAG (op, FLAG_DAMNED);
718 } 564 {
565 op->set_flag (FLAG_IDENTIFIED);
566 op->clr_flag (FLAG_CURSED);
567 op->clr_flag (FLAG_DAMNED);
568 }
569
719 if (op->type == SPELL) 570 if (op->type == SPELL)
720 { 571 {
721 op->destroy (); 572 op->destroy ();
722 continue; 573 continue;
723 } 574 }
724 else if (op->type == SKILL) 575 else if (op->type == SKILL)
725 { 576 {
726 SET_FLAG (op, FLAG_CAN_USE_SKILL); 577 op->set_flag (FLAG_CAN_USE_SKILL);
727 op->stats.exp = 0; 578 op->stats.exp = 0;
728 op->level = 1; 579 op->level = 1;
729 } 580 }
730 /* lock all 'normal items by default */ 581 else /* lock all 'normal items by default */
731 else 582 op->set_flag (FLAG_INV_LOCKED);
732 SET_FLAG (op, FLAG_INV_LOCKED);
733 } /* for loop of objects in player inv */ 583 } /* for loop of objects in player inv */
734 584
735 /* Need to set up the skill pointers */ 585 /* Need to set up the skill pointers */
736 link_player_skills (pl); 586 pl->contr->link_skills ();
737} 587}
738 588
739void 589void
740get_party_password (object *op, partylist *party) 590get_party_password (object *op, partylist *party)
741{ 591{
… …
751 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:"); 601 send_query (op->contr->ns, CS_QUERY_HIDEINPUT, "What is the password?\n:");
752} 602}
753 603
754/* This rolls four 1-6 rolls and sums the best 3 of the 4. */ 604/* This rolls four 1-6 rolls and sums the best 3 of the 4. */
755static int 605static int
756roll_stat (void) 606roll_stat ()
757{ 607{
758 int a[4], i, j, k; 608 int a[4], i, j, k;
759 609
760 for (i = 0; i < 4; i++) 610 for (i = 0; i < 4; i++)
761 a[i] = (int) rndm (6) + 1; 611 a[i] = rndm (1, 6);
762 612
763 for (i = 0, j = 0, k = 7; i < 4; i++) 613 for (i = 0, j = 0, k = 7; i < 4; i++)
764 if (a[i] < k) 614 if (a[i] < k)
765 k = a[i], j = i; 615 k = a[i], j = i;
766 616
… …
772} 622}
773 623
774void 624void
775object::roll_stats () 625object::roll_stats ()
776{ 626{
777 int statsort [7]; 627 int statsort [NUM_STATS];
778 628
779 for (;;) 629 for (;;)
780 { 630 {
781 int sum = 0; 631 int sum = 0;
782 for (int i = 7; i--; ) 632 for (int i = NUM_STATS; i--; )
783 sum += statsort [i] = roll_stat (); 633 sum += statsort [i] = roll_stat ();
784 634
785 if (sum >= 82 && sum <= 116) 635 if (sum >= 82 && sum <= 116)
786 break; 636 break;
787 } 637 }
788 638
789 // Sort the stats so that rerolling is easier... 639 // Sort the stats so that rerolling is easier...
790 std::sort (statsort, statsort + 7, std::greater<int>()); 640 std::sort (statsort, statsort + NUM_STATS, std::greater<int>());
791 641
642 for (int i = 0; i < NUM_STATS; ++i)
792 stats.Str = statsort[0]; 643 stats.stat (i) = statsort [i];
793 stats.Dex = statsort[1];
794 stats.Con = statsort[2];
795 stats.Int = statsort[3];
796 stats.Wis = statsort[4];
797 stats.Pow = statsort[5];
798 stats.Cha = statsort[6];
799 644
800 stats.exp = 0; 645 stats.exp = 0;
801 stats.ac = 0; 646 stats.ac = 0;
802 647
803 stats.hp = stats.maxhp; 648 stats.hp = stats.maxhp;
… …
815} 660}
816 661
817void 662void
818object::swap_stats (int a, int b) 663object::swap_stats (int a, int b)
819{ 664{
820 int tmp = get_attr_value (&contr->orig_stats, a); 665 swap (contr->orig_stats.stat (a), contr->orig_stats.stat (b));
821 set_attr_value (&contr->orig_stats, a, get_attr_value (&contr->orig_stats, b));
822 set_attr_value (&contr->orig_stats, b, tmp);
823 666
667 for (int i = 0; i < NUM_STATS; ++i)
824 stats.Str = contr->orig_stats.Str; 668 stats.stat (i) = contr->orig_stats.stat (i);
825 stats.Dex = contr->orig_stats.Dex;
826 stats.Con = contr->orig_stats.Con;
827 stats.Int = contr->orig_stats.Int;
828 stats.Wis = contr->orig_stats.Wis;
829 stats.Pow = contr->orig_stats.Pow;
830 stats.Cha = contr->orig_stats.Cha;
831 669
832 //TODO: the following code looks so borked and should, at the very least, 670 //TODO: the following code looks so borked and should, at the very least,
833 // be merged with the similar code in roll_stats 671 // be merged with the similar code in roll_stats
834 stats.ac = 0; 672 stats.ac = 0;
835 673
… …
854static void 692static void
855start_info (object *op) 693start_info (object *op)
856{ 694{
857 char buf[MAX_BUF]; 695 char buf[MAX_BUF];
858 696
859 sprintf (buf, "Welcome to Crossfire v%s!", VERSION); 697 sprintf (buf, "Welcome to Deliantra v%s!", VERSION);
860 new_draw_info (NDI_UNIQUE, 0, op, buf); 698 new_draw_info (NDI_UNIQUE, 0, op, buf);
861 //new_draw_info (NDI_UNIQUE, 0, op, "Press `?' for help");
862 //new_draw_info (NDI_UNIQUE, 0, op, " ");
863} 699}
864 700
865/* This function takes the key that is passed, and does the 701/* This function takes the key that is passed, and does the
866 * appropriate action with it (change race, or other things). 702 * appropriate action with it (change race, or other things).
867 * The function name is for historical reasons - now we have 703 * The function name is for historical reasons - now we have
868 * separate race and class; this actually changes the RACE, 704 * separate race and class; this actually changes the RACE,
869 * not the class. 705 * not the class.
870 */ 706 */
871int 707void
872key_change_class (object *op, char key) 708player::chargen_race_done ()
873{ 709{
874 int tmp_loop;
875
876 if (key == 'd' || key == 'D')
877 {
878 char buf[MAX_BUF];
879
880 /* this must before then initial items are given */ 710 /* this must before then initial items are given */
881 esrv_new_player (op->contr, op->weight + op->carrying); 711 esrv_new_player (ob->contr);
882 712
883 treasurelist *tl = find_treasurelist ("starting_wealth"); 713 treasurelist *tl = treasurelist::find (shstr_starting_wealth);
884 if (tl) 714 if (tl)
885 create_treasure (tl, op, 0, 0, 0); 715 create_treasure (tl, ob, 0, 0, 0);
886 716
887 INVOKE_PLAYER (BIRTH, op->contr); 717 INVOKE_PLAYER (BIRTH, ob->contr);
888 INVOKE_PLAYER (LOGIN, op->contr);
889 718
890 op->contr->ns->state = ST_PLAYING; 719 ob->contr->ns->state = ST_PLAYING;
891 720
892 if (op->msg) 721 if (ob->msg)
893 op->msg = NULL; 722 ob->msg = 0;
894 723
895 /* We create this now because some of the unique maps will need it
896 * to save here.
897 */
898 sprintf (buf, "%s/%s/%s", settings.localdir, settings.playerdir, &op->name);
899 make_path_to_file (buf);
900
901 start_info (op); 724 start_info (ob);
902 CLEAR_FLAG (op, FLAG_WIZ); 725 ob->clr_flag (FLAG_WIZ);
903 give_initial_items (op, op->randomitems); 726 give_initial_items (ob, ob->randomitems);
904 link_player_skills (op);
905 esrv_send_inventory (op, op); 727 esrv_send_inventory (ob, ob);
906 op->update_stats (); 728 ob->update_stats ();
907 729
908 /* This moves the player to a different start map, if there 730 /* This moves the player to a different start map, if there
909 * is one for this race 731 * is one for this race
910 */ 732 */
911 if (*first_map_ext_path) 733 if (*first_map_ext_path)
912 { 734 ob->player_goto (format ("%s/%s", &first_map_ext_path, &ob->arch->archname), ob->x, ob->y);
913 object *tmp;
914 char mapname[MAX_BUF];
915
916 snprintf (mapname, MAX_BUF - 1, "%s/%s", &first_map_ext_path, &op->arch->name);
917 tmp = object::create ();
918 EXIT_PATH (tmp) = mapname;
919 EXIT_X (tmp) = op->x;
920 EXIT_Y (tmp) = op->y;
921 op->enter_exit (tmp); /* we don't really care if it succeeded;
922 * if the map isn't there, then stay on the
923 * default initial map */
924 tmp->destroy ();
925 }
926 else 735 else
927 LOG (llevDebug, "first_map_ext_path not set\n"); 736 LOG (llevDebug, "first_map_ext_path not set\n");
737}
928 738
929 return 0; 739/*
930 } 740 * Returns true if the given player is a legal class.
741 * The function to add and remove class-bonuses to the stats doesn't
742 * check if the stat becomes negative, thus this function
743 * merely checks that all stats are 1 or more, and returns
744 * false otherwise.
745 */
746static int
747allowed_class (const object *op)
748{
749 return op->stats.Dex > 0
750 && op->stats.Str > 0
751 && op->stats.Con > 0
752 && op->stats.Int > 0
753 && op->stats.Wis > 0
754 && op->stats.Pow > 0
755 && op->stats.Cha > 0;
756}
931 757
758void
759player::chargen_race_next ()
760{
932 /* Following actually changes the race - this is the default command 761 /* Following actually changes the race - this is the default command
933 * if we don't match with one of the options above. 762 * if we don't match with one of the options above.
934 */ 763 */
935 764
936 tmp_loop = 0; 765 do
937 while (!tmp_loop)
938 { 766 {
939 shstr name = op->name; 767 shstr name = ob->name;
940 int x = op->x, y = op->y; 768 int x = ob->x, y = ob->y;
941 769
942 op->remove_statbonus (); 770 ob->remove_statbonus ();
943 op->remove (); 771 ob->remove ();
944 op->arch = get_player_archetype (op->arch); 772 ob->arch = get_player_archetype (ob->arch);
945 op->arch->clone.copy_to (op); 773 ob->arch->copy_to (ob);
946 op->instantiate (); 774 ob->instantiate ();
947 op->stats = op->contr->orig_stats; 775 ob->stats = ob->contr->orig_stats;
948 op->name = op->name_pl = name; 776 ob->name = ob->name_pl = name;
949 op->x = x; 777 ob->x = x;
950 op->y = y; 778 ob->y = y;
951 SET_ANIMATION (op, 2); /* So player faces south */ 779 SET_ANIMATION (ob, 2); /* So player faces south */
952 insert_ob_in_map (op, op->map, op, 0); 780 insert_ob_in_map (ob, ob->map, ob, 0);
953 assign (op->contr->title, op->arch->clone.name); 781 assign (ob->contr->title, ob->arch->object::name);
954 op->add_statbonus (); 782 ob->add_statbonus ();
955 tmp_loop = allowed_class (op);
956 } 783 }
784 while (!allowed_class (ob));
957 785
958 update_object (op, UP_OBJ_FACE); 786 update_object (ob, UP_OBJ_FACE);
959 esrv_update_item (UPD_FACE, op, op); 787 esrv_update_item (UPD_FACE, ob, ob);
960 op->update_stats (); 788 ob->update_stats ();
961 op->stats.hp = op->stats.maxhp; 789 ob->stats.hp = ob->stats.maxhp;
962 op->stats.sp = op->stats.maxsp; 790 ob->stats.sp = ob->stats.maxsp;
963 op->stats.grace = 0; 791 ob->stats.grace = 0;
964
965 if (op->msg)
966 new_draw_info (NDI_BLUE, 0, op, op->msg);
967
968 send_query (op->contr->ns, CS_QUERY_SINGLECHAR, "Press any key for the next race.\nPress `d' to play this race.\n");
969 return 0;
970} 792}
971 793
972void 794static void
973flee_player (object *op) 795flee_player (object *op)
974{ 796{
975 int dir, diff; 797 int dir, diff;
976 rv_vector rv; 798 rv_vector rv;
977 799
978 if (op->stats.hp < 0) 800 if (op->stats.hp < 0)
979 { 801 {
980 LOG (llevDebug, "Fleeing player is dead.\n"); 802 LOG (llevDebug, "Fleeing player is dead.\n");
981 CLEAR_FLAG (op, FLAG_SCARED); 803 op->clr_flag (FLAG_SCARED);
982 return; 804 return;
983 } 805 }
984 806
985 if (op->enemy == NULL) 807 if (!op->enemy)
986 { 808 {
987 LOG (llevDebug, "Fleeing player had no enemy.\n"); 809 LOG (llevDebug, "Fleeing player had no enemy.\n");
988 CLEAR_FLAG (op, FLAG_SCARED); 810 op->clr_flag (FLAG_SCARED);
989 return; 811 return;
990 } 812 }
991 813
992 /* Seen some crashes here. Since we don't store an 814 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
993 * op->enemy_count, it is possible that something destroys the
994 * actual enemy, and the object is recycled.
995 */
996 if (op->enemy->map == NULL)
997 { 815 {
998 CLEAR_FLAG (op, FLAG_SCARED);
999 op->enemy = NULL; 816 op->enemy = NULL;
1000 return; 817 op->clr_flag (FLAG_SCARED);
1001 }
1002
1003 if (!(random_roll (0, 4, op, PREFER_LOW)) && did_make_save (op, op->level, 0))
1004 {
1005 op->enemy = NULL;
1006 CLEAR_FLAG (op, FLAG_SCARED);
1007 return; 818 return;
1008 } 819 }
1009 820
1010 get_rangevector (op, op->enemy, &rv, 0); 821 get_rangevector (op, op->enemy, &rv, 0);
1011 822
1012 dir = absdir (4 + rv.direction); 823 dir = absdir (4 + rv.direction);
1013 for (diff = 0; diff < 3; diff++) 824 for (diff = 0; diff < 3; diff++)
1014 { 825 {
1015 int m = 1 - (RANDOM () & 2); 826 int m = 1 - rndm (2) * 2;
1016 827
1017 if (move_ob (op, absdir (dir + diff * m), op) || (diff == 0 && move_ob (op, absdir (dir - diff * m), op))) 828 if (op->move (absdir (dir + diff * m)) || (diff == 0 && op->move (absdir (dir - diff * m))))
1018 return; 829 return;
1019 } 830 }
1020 831
1021 /* Cornered, get rid of scared */ 832 /* Cornered, get rid of scared */
1022 CLEAR_FLAG (op, FLAG_SCARED); 833 op->clr_flag (FLAG_SCARED);
1023 op->enemy = NULL; 834 op->enemy = NULL;
1024} 835}
1025 836
1026
1027/* check_pick sees if there is stuff to be picked up/picks up stuff. 837/* check_pick sees if there is stuff to be picked up/picks up stuff.
1028 * IT returns 1 if the player should keep on moving, 0 if he should 838 * It returns 1 if the player should keep on moving, 0 if he should
1029 * stop. 839 * stop.
1030 */ 840 */
1031int 841int
1032check_pick (object *op) 842check_pick (object *op)
1033{ 843{
1034 object *tmp, *next; 844 object *tmp, *next;
1035 int stop = 0; 845 int stop = 0;
1036 int j, k, wvratio; 846 int wvratio;
1037 char putstring[128], tmpstr[16];
1038 847
1039 /* if you're flying, you cna't pick up anything */ 848 /* if you're flying, you can't pick up anything */
1040 if (op->move_type & MOVE_FLYING) 849 if (op->move_type & MOVE_FLYING)
1041 return 1; 850 return 1;
1042 851
1043 next = op->below; 852 next = op->below;
853
854 int cnt = MAX_ITEM_PER_ACTION;
855#define CHK_PICK_PICKUP do { pick_up (op, tmp); cnt--; } while (0)
1044 856
1045 /* loop while there are items on the floor that are not marked as 857 /* loop while there are items on the floor that are not marked as
1046 * destroyed */ 858 * destroyed */
1047 while (next && !next->destroyed ()) 859 while (next && !next->destroyed ())
1048 { 860 {
1049 tmp = next; 861 tmp = next;
1050 next = tmp->below; 862 next = tmp->below;
1051 863
864 if (cnt <= 0)
865 {
866 op->failmsg ("Couldn't pickup all items at once.");
867 return 0;
868 }
869
1052 if (op->destroyed ()) 870 if (op->destroyed ())
1053 return 0; 871 return 0;
1054 872
1055 if (!can_pick (op, tmp)) 873 if (!can_pick (op, tmp))
1056 continue; 874 continue;
1057 875
1058 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE) 876 if (op->contr->search_str[0] != '\0' && settings.search_items == TRUE)
1059 { 877 {
1060 if (item_matched_string (op, tmp, op->contr->search_str)) 878 if (item_matched_string (op, tmp, op->contr->search_str))
1061 pick_up (op, tmp); 879 CHK_PICK_PICKUP;
880
1062 continue; 881 continue;
1063 } 882 }
1064 883
1065 /* high not bit set? We're using the old autopickup model */ 884 /* pickup handling */
885 if (op->contr->mode & PU_DEBUG)
886 {
887 /* some debugging code to figure out item information */
888 const char *str = tmp->name
889 ? format ("item name: %s item type: %d weight/value: %d",
890 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))))
891 : format ("item name: %s item type: %d weight/value: %d",
892 &tmp->arch->archname, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
893
894 new_draw_info (NDI_UNIQUE, 0, op, str);
895 }
896
897 if (op->contr->mode & PU_INHIBIT)
898 return 1;
899
900 if (!(op->contr->mode & PU_ENABLE)) // TODO: fix client
901 return 1;
902
903 /* philosophy:
904 * It's easy to grab an item type from a pile, as long as it's
905 * generic. This takes no game-time. For more detailed pickups
906 * and selections, select-items should be used. This is a
907 * grab-as-you-run type mode that's really useful for arrows for
908 * example.
909 * The drawback: right now it has no frontend, so you need to
910 * stick the bits you want into a calculator in hex mode and then
911 * convert to decimal and then 'pickup <#>
912 */
913
914 /* the first two modes are exclusive: if NOTHING we return, if
915 * STOP then we stop. All the rest are applied sequentially,
916 * meaning if any test passes, the item gets picked up. */
917
918 /* if mode is set to pick nothing up, return */
919 if (op->contr->mode == PU_NOTHING)
920 return 1;
921
922 /* if mode is set to stop when encountering objects, return */
923 /* take STOP before INHIBIT since it doesn't actually pick
924 * anything up */
925 if (op->contr->mode & PU_STOP)
926 return 0;
927
928 /* useful for going into stores and not losing your settings... */
929 /* and for battles wher you don't want to get loaded down while
930 * fighting */
931 if (op->contr->mode & PU_INHIBIT)
932 return 1;
933
934 /* prevent us from turning into auto-thieves :) */
935 if (tmp->flag [FLAG_UNPAID])
936 continue;
937
938 /* ignore known cursed objects */
939 if (tmp->flag [FLAG_KNOWN_CURSED] && op->contr->mode & PU_NOT_CURSED)
940 continue;
941
942 /* all food and drink if desired */
943 /* question: don't pick up known-poisonous stuff? */
1066 if (!(op->contr->mode & PU_NEWMODE)) 944 if (op->contr->mode & PU_FOOD)
945 if (tmp->type == FOOD)
1067 { 946 {
1068 switch (op->contr->mode) 947 CHK_PICK_PICKUP;
948 continue;
949 }
950
951 if (op->contr->mode & PU_DRINK)
952 if (tmp->type == DRINK || (tmp->type == POISON && !tmp->flag [FLAG_KNOWN_CURSED]))
953 {
954 CHK_PICK_PICKUP;
955 continue;
956 }
957
958 if (op->contr->mode & PU_POTION)
959 if (tmp->type == POTION)
960 {
961 CHK_PICK_PICKUP;
962 continue;
963 }
964
965 /* spellbooks, skillscrolls and normal books/scrolls */
966 if (op->contr->mode & PU_SPELLBOOK)
967 if (tmp->type == SPELLBOOK)
968 {
969 CHK_PICK_PICKUP;
970 continue;
971 }
972
973 if (op->contr->mode & PU_SKILLSCROLL)
974 if (tmp->type == SKILLSCROLL)
975 {
976 CHK_PICK_PICKUP;
977 continue;
978 }
979
980 if (op->contr->mode & PU_READABLES)
981 if (tmp->type == BOOK || tmp->type == SCROLL || tmp->type == INSCRIBABLE)
982 {
983 CHK_PICK_PICKUP;
984 continue;
985 }
986
987 /* wands/staves/rods/horns */
988 if (op->contr->mode & PU_MAGIC_DEVICE)
989 if (tmp->type == WAND
990 || tmp->type == ROD
991 || tmp->type == HORN
992 || tmp->type == POWER_CRYSTAL)
993 {
994 CHK_PICK_PICKUP;
995 continue;
996 }
997
998 /* pick up all magical items */
999 if (op->contr->mode & PU_MAGICAL)
1000 if (tmp->flag [FLAG_KNOWN_MAGICAL]
1001 && !tmp->flag [FLAG_KNOWN_CURSED])
1002 {
1003 CHK_PICK_PICKUP;
1004 continue;
1005 }
1006
1007 if (op->contr->mode & PU_VALUABLES)
1008 {
1009 if (tmp->type == MONEY || tmp->type == GEM)
1069 { 1010 {
1070 case 0: 1011 CHK_PICK_PICKUP;
1071 return 1; /* don't pick up */ 1012 continue;
1072 case 1:
1073 pick_up (op, tmp);
1074 return 1;
1075 case 2:
1076 pick_up (op, tmp);
1077 return 0;
1078 case 3:
1079 return 0; /* stop before pickup */
1080 case 4:
1081 pick_up (op, tmp);
1082 break;
1083 case 5:
1084 pick_up (op, tmp);
1085 stop = 1;
1086 break;
1087 case 6:
1088 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))
1089 pick_up (op, tmp);
1090 break;
1091
1092 case 7:
1093 if (tmp->type == MONEY || tmp->type == GEM)
1094 pick_up (op, tmp);
1095 break;
1096
1097 default:
1098 /* use value density */
1099 if (!QUERY_FLAG (tmp, FLAG_UNPAID)
1100 && (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= op->contr->mode)
1101 pick_up (op, tmp);
1102 } 1013 }
1103 } 1014 }
1104 else 1015
1105 { /* old model */ 1016 /* rings & amulets - talismans seems to be typed AMULET */
1106 /* NEW pickup handling */
1107 if (op->contr->mode & PU_DEBUG) 1017 if (op->contr->mode & PU_JEWELS)
1018 if (tmp->type == RING
1019 || tmp->type == AMULET
1020 || tmp->type == GIRDLE
1021 || tmp->type == SKILL_TOOL)
1108 { 1022 {
1109 /* some debugging code to figure out item information */ 1023 CHK_PICK_PICKUP;
1110 if (tmp->name != NULL)
1111 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1112 &tmp->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1113 else
1114 sprintf (putstring, "item name: %s item type: %d weight/value: %d",
1115 &tmp->arch->name, tmp->type, (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))));
1116
1117 new_draw_info (NDI_UNIQUE, 0, op, putstring);
1118 }
1119
1120 /* philosophy:
1121 * It's easy to grab an item type from a pile, as long as it's
1122 * generic. This takes no game-time. For more detailed pickups
1123 * and selections, select-items should be used. This is a
1124 * grab-as-you-run type mode that's really useful for arrows for
1125 * example.
1126 * The drawback: right now it has no frontend, so you need to
1127 * stick the bits you want into a calculator in hex mode and then
1128 * convert to decimal and then 'pickup <#>
1129 */
1130
1131 /* the first two modes are exclusive: if NOTHING we return, if
1132 * STOP then we stop. All the rest are applied sequentially,
1133 * meaning if any test passes, the item gets picked up. */
1134
1135 /* if mode is set to pick nothing up, return */
1136
1137 if (op->contr->mode & PU_NOTHING)
1138 return 1;
1139
1140 /* if mode is set to stop when encountering objects, return */
1141 /* take STOP before INHIBIT since it doesn't actually pick
1142 * anything up */
1143
1144 if (op->contr->mode & PU_STOP)
1145 return 0;
1146
1147 /* useful for going into stores and not losing your settings... */
1148 /* and for battles wher you don't want to get loaded down while
1149 * fighting */
1150 if (op->contr->mode & PU_INHIBIT)
1151 return 1;
1152
1153 /* prevent us from turning into auto-thieves :) */
1154 if (QUERY_FLAG (tmp, FLAG_UNPAID))
1155 continue; 1024 continue;
1025 }
1156 1026
1157 /* ignore known cursed objects */ 1027 /* we don't forget dragon food */
1158 if (QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) && op->contr->mode & PU_NOT_CURSED) 1028 if (op->contr->mode & PU_FLESH)
1029 if (tmp->type == FLESH)
1030 {
1031 CHK_PICK_PICKUP;
1159 continue; 1032 continue;
1033 }
1160 1034
1161 /* all food and drink if desired */ 1035 /* bows and arrows. Bows are good for selling! */
1162 /* question: don't pick up known-poisonous stuff? */ 1036 if (op->contr->mode & PU_BOW)
1037 if (tmp->type == BOW)
1038 {
1039 CHK_PICK_PICKUP;
1040 continue;
1041 }
1042
1043 if (op->contr->mode & PU_ARROW)
1044 if (tmp->type == ARROW)
1045 {
1046 CHK_PICK_PICKUP;
1047 continue;
1048 }
1049
1050 /* all kinds of armor etc. */
1051 if (op->contr->mode & PU_ARMOUR)
1052 if (tmp->type == ARMOUR)
1053 {
1054 CHK_PICK_PICKUP;
1055 continue;
1056 }
1057
1058 if (op->contr->mode & PU_HELMET)
1059 if (tmp->type == HELMET)
1060 {
1061 CHK_PICK_PICKUP;
1062 continue;
1063 }
1064
1065 if (op->contr->mode & PU_SHIELD)
1066 if (tmp->type == SHIELD)
1067 {
1068 CHK_PICK_PICKUP;
1069 continue;
1070 }
1071
1163 if (op->contr->mode & PU_FOOD) 1072 if (op->contr->mode & PU_BOOTS)
1164 if (tmp->type == FOOD) 1073 if (tmp->type == BOOTS)
1074 {
1075 CHK_PICK_PICKUP;
1076 continue;
1077 }
1078
1079 if (op->contr->mode & PU_GLOVES)
1080 if (tmp->type == GLOVES || tmp->type == BRACERS)
1081 {
1082 CHK_PICK_PICKUP;
1083 continue;
1084 }
1085
1086 if (op->contr->mode & PU_CLOAK)
1087 if (tmp->type == CLOAK)
1088 {
1089 CHK_PICK_PICKUP;
1090 continue;
1091 }
1092
1093 /* hoping to catch throwing daggers here */
1094 if (op->contr->mode & PU_MISSILEWEAPON)
1095 if (tmp->type == WEAPON && tmp->flag [FLAG_IS_THROWN])
1096 {
1097 CHK_PICK_PICKUP;
1098 continue;
1099 }
1100
1101 /* careful: chairs and tables are weapons! */
1102 if (op->contr->mode & PU_ALLWEAPON)
1103 {
1104 if (tmp->type == WEAPON)
1105 if (!tmp->arch->archname.contains ("table") && !tmp->arch->archname.contains ("chair"))
1165 { 1106 {
1166 pick_up (op, tmp); 1107 CHK_PICK_PICKUP;
1167 continue; 1108 continue;
1168 } 1109 }
1110 }
1169 1111
1112 /* misc stuff that's useful */
1170 if (op->contr->mode & PU_DRINK) 1113 if (op->contr->mode & PU_KEY)
1171 if (tmp->type == DRINK || (tmp->type == POISON && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED))) 1114 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1172 { 1115 {
1173 pick_up (op, tmp); 1116 CHK_PICK_PICKUP;
1174 continue; 1117 continue;
1175 } 1118 }
1176 1119
1120 /* any of the last 4 bits set means we use the ratio for value
1121 * pickups */
1177 if (op->contr->mode & PU_POTION) 1122 if (op->contr->mode & PU_RATIO)
1178 if (tmp->type == POTION) 1123 {
1124 /* use value density to decide what else to grab */
1125 /* >=7 was >= op->contr->mode */
1126 /* >=7 is the old standard setting. Now we take the last 4 bits
1179 { 1127 */
1180 pick_up (op, tmp);
1181 continue;
1182 }
1183
1184 /* spellbooks, skillscrolls and normal books/scrolls */
1185 if (op->contr->mode & PU_SPELLBOOK)
1186 if (tmp->type == SPELLBOOK)
1187 {
1188 pick_up (op, tmp);
1189 continue;
1190 }
1191
1192 if (op->contr->mode & PU_SKILLSCROLL)
1193 if (tmp->type == SKILLSCROLL)
1194 {
1195 pick_up (op, tmp);
1196 continue;
1197 }
1198
1199 if (op->contr->mode & PU_READABLES)
1200 if (tmp->type == BOOK || tmp->type == SCROLL)
1201 {
1202 pick_up (op, tmp);
1203 continue;
1204 }
1205
1206 /* wands/staves/rods/horns */
1207 if (op->contr->mode & PU_MAGIC_DEVICE)
1208 if (tmp->type == WAND || tmp->type == ROD || tmp->type == HORN)
1209 {
1210 pick_up (op, tmp);
1211 continue;
1212 }
1213
1214 /* pick up all magical items */
1215 if (op->contr->mode & PU_MAGICAL) 1128 wvratio = op->contr->mode & PU_RATIO;
1216 if (QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)) 1129 if (1000 * query_cost (tmp, op, F_TRUE) / tmp->total_weight () >= wvratio * 100)
1217 {
1218 pick_up (op, tmp);
1219 continue;
1220 }
1221
1222 if (op->contr->mode & PU_VALUABLES)
1223 { 1130 {
1224 if (tmp->type == MONEY || tmp->type == GEM) 1131#if 0
1132 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1133 if (tmp->name != NULL)
1225 { 1134 {
1226 pick_up (op, tmp); 1135 fprintf (stderr, "%s", tmp->name);
1227 continue;
1228 } 1136 }
1229 }
1230
1231 /* rings & amulets - talismans seems to be typed AMULET */
1232 if (op->contr->mode & PU_JEWELS)
1233 if (tmp->type == RING || tmp->type == AMULET)
1234 {
1235 pick_up (op, tmp);
1236 continue;
1237 }
1238
1239 /* we don't forget dragon food */
1240 if (op->contr->mode & PU_FLESH)
1241 if (tmp->type == FLESH)
1242 {
1243 pick_up (op, tmp);
1244 continue;
1245 }
1246
1247 /* bows and arrows. Bows are good for selling! */
1248 if (op->contr->mode & PU_BOW)
1249 if (tmp->type == BOW)
1250 {
1251 pick_up (op, tmp);
1252 continue;
1253 }
1254
1255 if (op->contr->mode & PU_ARROW)
1256 if (tmp->type == ARROW)
1257 {
1258 pick_up (op, tmp);
1259 continue;
1260 }
1261
1262 /* all kinds of armor etc. */
1263 if (op->contr->mode & PU_ARMOUR)
1264 if (tmp->type == ARMOUR)
1265 {
1266 pick_up (op, tmp);
1267 continue;
1268 }
1269
1270 if (op->contr->mode & PU_HELMET)
1271 if (tmp->type == HELMET)
1272 {
1273 pick_up (op, tmp);
1274 continue;
1275 }
1276
1277 if (op->contr->mode & PU_SHIELD)
1278 if (tmp->type == SHIELD)
1279 {
1280 pick_up (op, tmp);
1281 continue;
1282 }
1283
1284 if (op->contr->mode & PU_BOOTS)
1285 if (tmp->type == BOOTS)
1286 {
1287 pick_up (op, tmp);
1288 continue;
1289 }
1290
1291 if (op->contr->mode & PU_GLOVES)
1292 if (tmp->type == GLOVES)
1293 {
1294 pick_up (op, tmp);
1295 continue;
1296 }
1297
1298 if (op->contr->mode & PU_CLOAK)
1299 if (tmp->type == CLOAK)
1300 {
1301 pick_up (op, tmp);
1302 continue;
1303 }
1304
1305 /* hoping to catch throwing daggers here */
1306 if (op->contr->mode & PU_MISSILEWEAPON)
1307 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_IS_THROWN))
1308 {
1309 pick_up (op, tmp);
1310 continue;
1311 }
1312
1313 /* careful: chairs and tables are weapons! */
1314 if (op->contr->mode & PU_ALLWEAPON)
1315 {
1316 if (tmp->type == WEAPON && tmp->name != NULL)
1317 {
1318 if (strstr (tmp->name, "table") == NULL && strstr (tmp->arch->name, "table") == NULL &&
1319 strstr (tmp->name, "chair") && strstr (tmp->arch->name, "chair") == NULL)
1320 {
1321 pick_up (op, tmp);
1322 continue;
1323 }
1324 }
1325
1326 if (tmp->type == WEAPON && tmp->name == NULL)
1327 {
1328 if (strstr (tmp->arch->name, "table") == NULL && strstr (tmp->arch->name, "chair") == NULL)
1329 {
1330 pick_up (op, tmp);
1331 continue;
1332 }
1333 }
1334 }
1335
1336 /* misc stuff that's useful */
1337 if (op->contr->mode & PU_KEY)
1338 if (tmp->type == KEY || tmp->type == SPECIAL_KEY)
1339 {
1340 pick_up (op, tmp);
1341 continue;
1342 }
1343
1344 /* any of the last 4 bits set means we use the ratio for value
1345 * pickups */
1346 if (op->contr->mode & PU_RATIO)
1347 {
1348 /* use value density to decide what else to grab */
1349 /* >=7 was >= op->contr->mode */
1350 /* >=7 is the old standard setting. Now we take the last 4 bits
1351 * and multiply them by 5, giving 0..15*5== 5..75 */
1352 wvratio = (op->contr->mode & PU_RATIO) * 5;
1353 if ((query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1))) >= (unsigned int) wvratio)
1354 {
1355 pick_up (op, tmp);
1356#if 0
1357 fprintf (stderr, "HIGH WEIGHT/VALUE [");
1358 if (tmp->name != NULL)
1359 {
1360 fprintf (stderr, "%s", tmp->name);
1361 }
1362 else 1137 else
1363 fprintf (stderr, "%s", tmp->arch->name); 1138 fprintf (stderr, "%s", tmp->arch->archname);
1364 fprintf (stderr, ",%d] = ", tmp->type); 1139 fprintf (stderr, ",%d] = ", tmp->type);
1365 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * MAX (tmp->nrof, 1)))); 1140 fprintf (stderr, "%d\n", (int) (query_cost (tmp, op, F_TRUE) * 100 / (tmp->weight * max (tmp->nrof, 1))));
1366#endif 1141#endif
1142 CHK_PICK_PICKUP;
1367 continue; 1143 continue;
1368 }
1369 } 1144 }
1370 } /* the new pickup model */ 1145 } /* the new pickup model */
1371 } 1146 }
1372 1147
1373 return !stop; 1148 return !stop;
1149}
1150
1151/* routine for both players and monsters. We call this when
1152 * there is a possibility for our action distrubing our hiding
1153 * place or invisiblity spell. Artefact invisiblity causes
1154 * "noise" instead. If we arent invisible to begin with, we
1155 * return 0.
1156 */
1157static int
1158action_makes_visible (object *op)
1159{
1160 if (op->invisible && op->flag [FLAG_ALIVE])
1161 {
1162 if (op->flag [FLAG_MAKE_INVIS])
1163 {
1164 // artefact invisibility is permanent, but we still make noise
1165 // this is important for game-balance.
1166 if (op->contr)
1167 op->make_noise ();
1168
1169 return 0;
1170 }
1171
1172 if (op->contr && op->contr->tmp_invis == 0)
1173 return 0;
1174
1175 /* If monsters, they should become visible */
1176 if (op->flag [FLAG_HIDDEN] || !op->contr || (op->contr && op->contr->tmp_invis))
1177 {
1178 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->flag [FLAG_HIDDEN] ? "unhidden" : "visible");
1179 return 1;
1180 }
1181 }
1182
1183 return 0;
1374} 1184}
1375 1185
1376/* 1186/*
1377 * Find an arrow in the inventory and after that 1187 * Find an arrow in the inventory and after that
1378 * in the right type container (quiver). Pointer to the 1188 * in the right type container (quiver). Pointer to the
1379 * found object is returned. 1189 * found object is returned.
1380 */ 1190 */
1381object * 1191static object *
1382find_arrow (object *op, const char *type) 1192find_arrow (object *op, const char *type)
1383{ 1193{
1384 object *tmp = NULL;
1385
1386 for (op = op->inv; op; op = op->below) 1194 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1387 if (!tmp && op->type == CONTAINER && op->race == type && QUERY_FLAG (op, FLAG_APPLIED))
1388 tmp = find_arrow (op, type);
1389 else if (op->type == ARROW && op->race == type) 1195 if (tmp->type == ARROW && !strcmp (&tmp->race, type))
1196 return splay (tmp);
1197
1198 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1199 if (tmp->type == CONTAINER && tmp->flag [FLAG_APPLIED] && !strcmp (&tmp->race, type))
1200 if (object *arrow = find_arrow (tmp, type))
1201 {
1202 splay (tmp);
1390 return op; 1203 return arrow;
1204 }
1205
1391 return tmp; 1206 return 0;
1392} 1207}
1393 1208
1394/* 1209/*
1395 * Similar to find_arrow, but looks for (roughly) the best arrow to use 1210 * Similar to find_arrow, but looks for (roughly) the best arrow to use
1396 * against the target. A full test is not performed, simply a basic test 1211 * against the target. A full test is not performed, simply a basic test
1397 * of resistances. The archer is making a quick guess at what he sees down 1212 * of resistances. The archer is making a quick guess at what he sees down
1398 * the hall. Failing that it does it's best to pick the highest plus arrow. 1213 * the hall. Failing that it does it's best to pick the highest plus arrow.
1399 */ 1214 */
1400 1215static object *
1401object *
1402find_better_arrow (object *op, object *target, const char *type, int *better) 1216find_better_arrow (object *op, object *target, shstr_cmp type, int *better)
1403{ 1217{
1404 object *tmp = NULL, *arrow, *ntmp; 1218 object *tmp = NULL, *arrow, *ntmp;
1405 int attacknum, attacktype, betterby = 0, i; 1219 int attacknum, attacktype, betterby = 0, i;
1406 1220
1407 if (!type) 1221 if (!type)
1408 return NULL; 1222 return NULL;
1409 1223
1410 for (arrow = op->inv; arrow; arrow = arrow->below) 1224 for (arrow = op->inv; arrow; arrow = arrow->below)
1411 { 1225 {
1412 if (arrow->type == CONTAINER && arrow->race == type && QUERY_FLAG (arrow, FLAG_APPLIED)) 1226 if (arrow->type == CONTAINER && arrow->race == type && arrow->flag [FLAG_APPLIED])
1413 { 1227 {
1414 i = 0; 1228 i = 0;
1415 ntmp = find_better_arrow (arrow, target, type, &i); 1229 ntmp = find_better_arrow (arrow, target, type, &i);
1230
1416 if (i > betterby) 1231 if (i > betterby)
1417 { 1232 {
1418 tmp = ntmp; 1233 tmp = ntmp;
1419 betterby = i; 1234 betterby = i;
1420 } 1235 }
1421 } 1236 }
1422 else if (arrow->type == ARROW && arrow->race == type) 1237 else if (arrow->type == ARROW && arrow->race == type)
1423 { 1238 {
1424 /* allways prefer assasination/slaying */ 1239 /* allways prefer assasination/slaying */
1425 if (target->race != NULL && arrow->slaying != NULL && strstr (arrow->slaying, target->race)) 1240 if (target->race && arrow->slaying.contains (target->race))
1426 { 1241 {
1427 if (arrow->attacktype & AT_DEATH) 1242 if (arrow->attacktype & AT_DEATH)
1428 { 1243 {
1429 *better = 100; 1244 *better = 100;
1430 return arrow; 1245 return arrow;
… …
1438 else 1253 else
1439 { 1254 {
1440 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++) 1255 for (attacknum = 0; attacknum < NROFATTACKS; attacknum++)
1441 { 1256 {
1442 attacktype = 1 << attacknum; 1257 attacktype = 1 << attacknum;
1443 if ((arrow->attacktype & attacktype) && (target->arch->clone.resist[attacknum]) < 0) 1258 if ((arrow->attacktype & attacktype) && (target->arch->resist[attacknum]) < 0)
1444 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100) > betterby) 1259 if (((arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100) > betterby)
1445 { 1260 {
1446 tmp = arrow; 1261 tmp = arrow;
1447 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->clone.resist[attacknum]) / 100; 1262 betterby = (arrow->magic + arrow->stats.dam) * (100 - target->arch->resist[attacknum]) / 100;
1448 } 1263 }
1449 } 1264 }
1265
1450 if ((2 + arrow->magic + arrow->stats.dam) > betterby) 1266 if ((2 + arrow->magic + arrow->stats.dam) > betterby)
1451 { 1267 {
1452 tmp = arrow; 1268 tmp = arrow;
1453 betterby = 2 + arrow->magic + arrow->stats.dam; 1269 betterby = 2 + arrow->magic + arrow->stats.dam;
1454 } 1270 }
1271
1455 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby) 1272 if (arrow->title && (1 + arrow->magic + arrow->stats.dam) > betterby)
1456 { 1273 {
1457 tmp = arrow; 1274 tmp = arrow;
1458 betterby = 1 + arrow->magic + arrow->stats.dam; 1275 betterby = 1 + arrow->magic + arrow->stats.dam;
1459 } 1276 }
1460 } 1277 }
1461 } 1278 }
1462 } 1279 }
1280
1463 if (tmp == NULL && arrow == NULL) 1281 if (tmp == NULL && arrow == NULL)
1464 return find_arrow (op, type); 1282 return find_arrow (op, type);
1465 1283
1466 *better = betterby; 1284 *better = betterby;
1467 return tmp; 1285 return tmp;
… …
1471 * find_better_arrow to find a decent arrow to use. 1289 * find_better_arrow to find a decent arrow to use.
1472 * op = the shooter 1290 * op = the shooter
1473 * type = bow->race 1291 * type = bow->race
1474 * dir = fire direction 1292 * dir = fire direction
1475 */ 1293 */
1476 1294static object *
1477object *
1478pick_arrow_target (object *op, const char *type, int dir) 1295pick_arrow_target (object *op, shstr_cmp type, int dir)
1479{ 1296{
1480 object *tmp = NULL; 1297 object *tmp = NULL;
1481 maptile *m; 1298 maptile *m;
1482 int i, mflags, found, number; 1299 int i, mflags, found, number;
1483 sint16 x, y; 1300 sint16 x, y;
… …
1498 for (i = 0, found = 0; i < 20; i++) 1315 for (i = 0, found = 0; i < 20; i++)
1499 { 1316 {
1500 x += freearr_x[dir]; 1317 x += freearr_x[dir];
1501 y += freearr_y[dir]; 1318 y += freearr_y[dir];
1502 mflags = get_map_flags (m, &m, x, y, &x, &y); 1319 mflags = get_map_flags (m, &m, x, y, &x, &y);
1320
1503 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW) 1321 if (mflags & P_OUT_OF_MAP || mflags & P_BLOCKSVIEW)
1504 { 1322 {
1505 tmp = NULL; 1323 tmp = 0;
1506 break; 1324 break;
1507 } 1325 }
1508 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW) 1326 else if (GET_MAP_MOVE_BLOCK (m, x, y) == MOVE_FLY_LOW)
1509 { 1327 {
1510 /* This block presumes arrows and the like are MOVE_FLY_SLOW - 1328 /* This block presumes arrows and the like are MOVE_FLY_SLOW -
1511 * perhaps a bad assumption. 1329 * perhaps a bad assumption.
1512 */ 1330 */
1513 tmp = NULL; 1331 tmp = 0;
1514 break; 1332 break;
1515 } 1333 }
1334
1516 if (mflags & P_IS_ALIVE) 1335 if (mflags & P_IS_ALIVE)
1517 {
1518 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 1336 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1519 if (QUERY_FLAG (tmp, FLAG_ALIVE)) 1337 if (tmp->flag [FLAG_ALIVE])
1520 {
1521 found++;
1522 break;
1523 }
1524 if (found)
1525 break; 1338 break;
1526 }
1527 } 1339 }
1528 if (tmp == NULL) 1340
1341 if (!tmp)
1529 return find_arrow (op, type); 1342 return find_arrow (op, type);
1530 1343
1531 if (tmp->head) 1344 if (tmp->head)
1532 tmp = tmp->head; 1345 tmp = tmp->head;
1533 1346
… …
1546 */ 1359 */
1547int 1360int
1548fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy) 1361fire_bow (object *op, object *part, object *arrow, int dir, int wc_mod, sint16 sx, sint16 sy)
1549{ 1362{
1550 object *left, *bow; 1363 object *left, *bow;
1551 int bowspeed, mflags; 1364 int mflags;
1552 maptile *m; 1365 maptile *m;
1553 1366
1554 if (!dir) 1367 if (!dir)
1555 { 1368 {
1556 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!"); 1369 new_draw_info (NDI_UNIQUE, 0, op, "You can't shoot yourself!");
1557 return 0; 1370 return 0;
1558 } 1371 }
1559 1372
1560 if (op->type == PLAYER) 1373 if (op->contr)
1561 bow = op->contr->ranges[range_bow]; 1374 bow = op->current_weapon;
1562 else 1375 else
1563 { 1376 {
1564 for (bow = op->inv; bow; bow = bow->below) 1377 for (bow = op->inv; bow; bow = bow->below)
1565 /* Don't check for applied - monsters don't apply bows - in that way, they 1378 /* Don't check for applied - monsters don't apply bows - in that way, they
1566 * don't need to switch back and forth between bows and weapons. 1379 * don't need to switch back and forth between bows and weapons.
… …
1571 if (!bow) 1384 if (!bow)
1572 { 1385 {
1573 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name); 1386 LOG (llevError, "Range: bow without activated bow (%s).\n", &op->name);
1574 return 0; 1387 return 0;
1575 } 1388 }
1389
1390 // optimisation: move object to top so we will find it quickly again
1391 splay (bow);
1576 } 1392 }
1577 1393
1578 if (!bow->race || !bow->skill) 1394 if (!bow->race || !bow->skill)
1579 { 1395 {
1580 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name); 1396 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s is broken.", &bow->name);
1581 return 0; 1397 return 0;
1582 } 1398 }
1583
1584 bowspeed = bow->stats.sp + dex_bonus[op->stats.Dex];
1585
1586 /* penalize ROF for bestarrow */
1587 if (op->type == PLAYER && op->contr->bowtype == bow_bestarrow)
1588 bowspeed -= dex_bonus[op->stats.Dex] + 5;
1589
1590 if (bowspeed < 1)
1591 bowspeed = 1;
1592 1399
1593 if (arrow == NULL) 1400 if (arrow == NULL)
1594 { 1401 {
1595 if ((arrow = find_arrow (op, bow->race)) == NULL) 1402 if ((arrow = find_arrow (op, bow->race)) == NULL)
1596 { 1403 {
1597 if (op->type == PLAYER) 1404 if (op->type == PLAYER)
1598 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1405 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1599 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */ 1406 /* FLAG_READY_BOW will get reset if the monsters picks up some arrows */
1600 else 1407 else
1601 CLEAR_FLAG (op, FLAG_READY_BOW); 1408 op->clr_flag (FLAG_READY_BOW);
1409
1602 return 0; 1410 return 0;
1603 } 1411 }
1604 } 1412 }
1605 1413
1606 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy); 1414 mflags = get_map_flags (op->map, &m, sx, sy, &sx, &sy);
… …
1614 } 1422 }
1615 1423
1616 /* this should not happen, but sometimes does */ 1424 /* this should not happen, but sometimes does */
1617 if (arrow->nrof == 0) 1425 if (arrow->nrof == 0)
1618 { 1426 {
1427 LOG (llevError | logBacktrace, "arrow (%s) has nrof 0\n", arrow->debug_desc ());
1619 arrow->destroy (); 1428 arrow->destroy ();
1620 return 0; 1429 return 0;
1621 } 1430 }
1622 1431
1623 left = arrow; /* these are arrows left to the player */ 1432 left = arrow; /* these are arrows left to the player */
1624 arrow = get_split_ob (arrow, 1); 1433 arrow = arrow->split ();
1625 if (!arrow) 1434 if (!arrow)
1626 { 1435 {
1627 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race); 1436 new_draw_info_format (NDI_UNIQUE, 0, op, "You have no %s left.", &bow->race);
1628 return 0; 1437 return 0;
1629 } 1438 }
1630 1439
1631 arrow->set_owner (op); 1440 arrow->set_owner (op);
1632 arrow->skill = bow->skill; 1441 arrow->skill = bow->skill;
1633 arrow->direction = dir; 1442 arrow->direction = dir;
1634 1443
1444 arrow->stats.sp = arrow->stats.wc; /* save original wc, dam, attacktype and slaying */
1445 arrow->stats.hp = arrow->stats.dam;
1446 arrow->stats.grace = arrow->attacktype;
1447 arrow->custom_name = arrow->slaying;
1448
1449#if 0
1450 if (player *pl = op->contr)
1451 {
1452 float speed = pl->weapon_sp;
1453
1454 /* penalize ROF for bestarrow */
1455 if (pl->bowtype == bow_bestarrow)
1456 speed *= .9f;
1457 else
1458 speed *= 1.f + dex_bonus[op->stats.Dex] * .2f;
1459
1460 op->speed_left += speed - op->speed;
1461 }
1462#endif
1463
1464 SET_ANIMATION (arrow, arrow->direction);
1465
1466 /* update the speed */
1467
1468 arrow->speed_left = 0;
1469 arrow->set_speed (max (2.f,
1470 ((bow->flag [FLAG_NO_STRENGTH] ? 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.f
1471 + bow->stats.dam / 7.f
1472 ));
1473
1474 int wc = op->stats.wc + wc_mod - arrow->magic - arrow->stats.wc;
1475
1635 if (op->type == PLAYER) 1476 if (op->type == PLAYER)
1636 { 1477 {
1637 op->speed_left = 0.01 - (float) FABS (op->speed) * 100 / bowspeed;
1638 op->update_stats ();
1639 }
1640
1641 SET_ANIMATION (arrow, arrow->direction);
1642 arrow->stats.sp = arrow->stats.wc; /* save original wc and dam */
1643 arrow->stats.hp = arrow->stats.dam;
1644 arrow->stats.grace = arrow->attacktype;
1645 if (arrow->slaying != NULL)
1646 arrow->spellarg = strdup (arrow->slaying);
1647
1648 /* Note that this was different for monsters - they got their level
1649 * added to the damage. I think the strength bonus is more proper.
1650 */
1651
1652 arrow->stats.dam += (QUERY_FLAG (bow, FLAG_NO_STRENGTH) ? 0 : dam_bonus[op->stats.Str]) + bow->stats.dam + bow->magic + arrow->magic;
1653
1654 /* update the speed */
1655 arrow->speed = (float) ((QUERY_FLAG (bow, FLAG_NO_STRENGTH) ?
1656 0 : dam_bonus[op->stats.Str]) + bow->magic + arrow->magic) / 5.0 + (float) bow->stats.dam / 7.0;
1657
1658 arrow->set_speed (max (arrow->speed, 1.0));
1659 arrow->speed_left = 0;
1660
1661 if (op->type == PLAYER)
1662 {
1663 arrow->stats.wc = 20 - bow->magic - arrow->magic -
1664 (op->chosen_skill ? op->chosen_skill->level : op->level) -
1665 dex_bonus[op->stats.Dex] - thaco_bonus[op->stats.Str] - arrow->stats.wc - bow->stats.wc + wc_mod;
1666
1667 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level; 1478 arrow->level = op->chosen_skill ? op->chosen_skill->level : op->level;
1479 wc -= dex_bonus[op->stats.Dex];
1480
1481 if (!arrow->slaying)
1482 arrow->slaying = op->slaying;
1483
1484 arrow->attacktype |= op->attacktype;
1668 } 1485 }
1669 else 1486 else
1670 { 1487 {
1671 arrow->stats.wc = op->stats.wc - bow->magic - arrow->magic - arrow->stats.wc + wc_mod;
1672 arrow->level = op->level; 1488 arrow->level = op->level;
1673 } 1489 arrow->stats.wc -= bow->magic;
1674 1490
1675 if (arrow->attacktype == AT_PHYSICAL) 1491 if (!arrow->slaying)
1492 arrow->slaying = bow->slaying;
1493
1676 arrow->attacktype |= bow->attacktype; 1494 arrow->attacktype |= bow->attacktype;
1495 }
1677 1496
1678 if (bow->slaying) 1497 wc -= arrow->level;
1679 arrow->slaying = bow->slaying; 1498 arrow->stats.dam = clamp (arrow->stats.dam + op->stats.dam + arrow->magic, MIN_DAM, MAX_DAM);
1680 1499
1500 arrow->stats.wc = clamp (wc, MIN_WC, MAX_WC);
1681 arrow->move_type = MOVE_FLY_LOW; 1501 arrow->move_type = MOVE_FLY_LOW;
1682 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK; 1502 arrow->move_on = MOVE_FLY_LOW | MOVE_WALK;
1683 1503
1684 play_sound_map (op->map, op->x, op->y, SOUND_FIRE_ARROW); 1504 op->play_sound (sound_find ("fire_arrow"));
1685 m->insert (arrow, sx, sy, op); 1505 m->insert (arrow, sx, sy, op);
1686 1506
1687 if (!arrow->destroyed ()) 1507 if (!arrow->destroyed ())
1688 move_arrow (arrow); 1508 move_arrow (arrow);
1689
1690 if (op->type == PLAYER)
1691 {
1692 if (left->destroyed ())
1693 esrv_del_item (op->contr, left->count);
1694 else
1695 esrv_send_item (op, left);
1696 }
1697 1509
1698 return 1; 1510 return 1;
1699} 1511}
1700 1512
1701/* Special fire code for players - this takes into 1513/* Special fire code for players - this takes into
… …
1703 * but monsters can't. Putting that code here 1515 * but monsters can't. Putting that code here
1704 * makes the fire_bow code much cleaner. 1516 * makes the fire_bow code much cleaner.
1705 * this function should only be called if 'op' is a player, 1517 * this function should only be called if 'op' is a player,
1706 * hence the function name. 1518 * hence the function name.
1707 */ 1519 */
1708int 1520static int
1709player_fire_bow (object *op, int dir) 1521player_fire_bow (object *op, int dir)
1710{ 1522{
1711 int ret = 0, wcmod = 0; 1523 int ret;
1712 1524
1713 if (op->contr->bowtype == bow_bestarrow) 1525 if (op->contr->bowtype == bow_bestarrow)
1714 { 1526 {
1715 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranges[range_bow]->race, dir), dir, 0, op->x, op->y); 1527 ret = fire_bow (op, op, pick_arrow_target (op, op->contr->ranged_ob->race, dir), dir, 0, op->x, op->y);
1716 } 1528 }
1717 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw) 1529 else if (op->contr->bowtype >= bow_n && op->contr->bowtype <= bow_nw)
1718 { 1530 {
1719 if (!similar_direction (dir, op->contr->bowtype - bow_n + 1)) 1531 int wcmod = similar_direction (dir, op->contr->bowtype - bow_n + 1) ? 0 : -1;
1720 wcmod = -1;
1721
1722 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y); 1532 ret = fire_bow (op, op, NULL, op->contr->bowtype - bow_n + 1, wcmod, op->x, op->y);
1723 } 1533 }
1724 else if (op->contr->bowtype == bow_threewide) 1534 else if (op->contr->bowtype == bow_threewide)
1725 { 1535 {
1726 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1536 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1727 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]); 1537 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir + 2)], op->y + freearr_y[absdir (dir + 2)]);
1728 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]); 1538 ret |= fire_bow (op, op, NULL, dir, -5, op->x + freearr_x[absdir (dir - 2)], op->y + freearr_y[absdir (dir - 2)]);
1729 } 1539 }
1730 else if (op->contr->bowtype == bow_spreadshot) 1540 else if (op->contr->bowtype == bow_spreadshot)
1731 { 1541 {
1732 ret |= fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1542 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1733 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y); 1543 ret |= fire_bow (op, op, NULL, absdir (dir - 1), -5, op->x, op->y);
1734 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y); 1544 ret |= fire_bow (op, op, NULL, absdir (dir + 1), -5, op->x, op->y);
1735
1736 } 1545 }
1737 else 1546 else
1738 { 1547 {
1739 /* Simple case */ 1548 /* Simple case */
1740 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y); 1549 ret = fire_bow (op, op, NULL, dir, 0, op->x, op->y);
1741 } 1550 }
1551
1742 return ret; 1552 return ret;
1743} 1553}
1744
1745 1554
1746/* Fires a misc (wand/rod/horn) object in 'dir'. 1555/* Fires a misc (wand/rod/horn) object in 'dir'.
1747 * Broken apart from 'fire' to keep it more readable. 1556 * Broken apart from 'fire' to keep it more readable.
1748 */ 1557 */
1749void 1558static void
1750fire_misc_object (object *op, int dir) 1559fire_misc_object (object *op, int dir)
1751{ 1560{
1752 object *item; 1561 object *item = op->contr->ranged_ob;
1753 1562
1754 if (!op->contr->ranges[range_misc]) 1563 if (!item)
1755 { 1564 {
1756 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied."); 1565 new_draw_info (NDI_UNIQUE, 0, op, "You have range item readied.");
1757 return; 1566 return;
1758 } 1567 }
1759 1568
1760 item = op->contr->ranges[range_misc];
1761 if (!item->inv) 1569 if (!item->inv)
1762 { 1570 {
1763 LOG (llevError, "Object %s lacks a spell\n", &item->name); 1571 LOG (llevError, "Object %s lacks a spell\n", &item->name);
1764 return; 1572 return;
1765 } 1573 }
1574
1575 if (!op->apply (item))
1576 return;
1577
1766 if (item->type == WAND) 1578 if (item->type == WAND)
1767 { 1579 {
1768 if (item->stats.food <= 0) 1580 if (item->stats.food <= 0)
1769 { 1581 {
1770 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1582 op->contr->play_sound (sound_find ("wand_poof"));
1771 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0)); 1583 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s goes poof.", query_base_name (item, 0));
1584
1772 return; 1585 return;
1773 } 1586 }
1774 } 1587 }
1775 else if (item->type == ROD || item->type == HORN) 1588 else if (item->type == ROD || item->type == HORN)
1776 { 1589 {
1777 if (item->stats.hp < MAX (item->inv->stats.sp, item->inv->stats.grace)) 1590 sint16 spell_sp = max (item->inv->stats.sp, item->inv->stats.grace);
1591
1592 // using the maximum of the rods charge allows at least one spell cast
1593 // for a rod or horn, this fixes some broken rods.
1594 if (item->stats.hp < min (spell_sp, item->stats.maxhp))
1778 { 1595 {
1779 play_sound_player_only (op->contr, SOUND_WAND_POOF, 0, 0); 1596 op->contr->play_sound (sound_find ("wand_poof"));
1597
1780 if (item->type == ROD) 1598 if (item->type == ROD)
1781 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0)); 1599 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s whines for a while, but nothing happens.", query_base_name (item, 0));
1782 else 1600 else
1783 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0)); 1601 new_draw_info_format (NDI_UNIQUE, 0, op, "The %s needs more time to charge.", query_base_name (item, 0));
1602
1784 return; 1603 return;
1785 } 1604 }
1786 } 1605 }
1787 1606
1788 if (cast_spell (op, item, dir, item->inv, NULL)) 1607 if (cast_spell (op, item, dir, item->inv, NULL))
1789 { 1608 {
1790 SET_FLAG (op, FLAG_BEEN_APPLIED); /* You now know something about it */ 1609 item->flag [FLAG_BEEN_APPLIED] = true; /* You now know something about it */
1610
1791 if (item->type == WAND) 1611 if (item->type == WAND)
1792 { 1612 {
1793 if (!(--item->stats.food)) 1613 if (!(--item->stats.food))
1794 { 1614 {
1795 object *tmp;
1796
1797 if (item->arch) 1615 if (item->arch)
1798 { 1616 {
1799 CLEAR_FLAG (item, FLAG_ANIMATE); 1617 item->clr_flag (FLAG_ANIMATE);
1800 item->face = item->arch->clone.face; 1618 item->face = item->arch->face;
1801 item->set_speed (0); 1619 item->set_speed (0);
1802 } 1620 }
1803 1621
1804 if ((tmp = item->in_player ())) 1622 if (object *pl = item->visible_to ())
1805 esrv_update_item (UPD_ANIM, tmp, item); 1623 esrv_update_item (UPD_ANIM, pl, item);
1806 } 1624 }
1807 } 1625 }
1808 else if (item->type == ROD || item->type == HORN) 1626 else if (item->type == ROD || item->type == HORN)
1809 drain_rod_charge (item); 1627 drain_rod_charge (item);
1810 } 1628 }
1811} 1629}
1812 1630
1813/* Received a fire command for the player - go and do it. 1631/* Received a fire command for the player - go and do it.
1814 */ 1632 */
1815void 1633bool
1816fire (object *op, int dir) 1634fire (object *who, int dir)
1817{ 1635{
1818 int spellcost = 0; 1636 int spellcost = 0;
1819 1637
1638 player *pl = who->contr;
1639
1640 if (pl->golem)
1641 {
1642 control_golem (who->contr->golem, dir);
1643 return false;
1644 }
1645
1646 object *ob = pl->ranged_ob;
1647
1648 if (!ob)
1649 return false;
1650
1651 if (who->speed_left > 0.f)
1652 --who->speed_left;
1653 else
1654 return false;
1655
1656 if (!who->apply (ob))
1657 return false;
1658
1820 /* check for loss of invisiblity/hide */ 1659 /* check for loss of invisiblity/hide */
1821 if (action_makes_visible (op)) 1660 if (action_makes_visible (who))
1822 make_visible (op); 1661 make_visible (who);
1823 1662
1824 switch (op->contr->shoottype) 1663 switch (ob->type)
1825 { 1664 {
1826 case range_none: 1665 case BOW:
1827 return;
1828
1829 case range_bow:
1830 player_fire_bow (op, dir); 1666 player_fire_bow (who, dir);
1831 return; 1667 break;
1832 1668
1833 case range_magic: /* Casting spells */ 1669 case SPELL:
1834 spellcost = (cast_spell (op, op, dir, op->contr->ranges[range_magic], op->contr->spellparam[0] ? op->contr->spellparam : 0)); 1670 spellcost = cast_spell (who, who, dir, ob, *pl->spellparam ? pl->spellparam : 0);
1835 return; 1671 break;
1836 1672
1837 case range_misc: 1673 case BUILDER:
1838 fire_misc_object (op, dir);
1839 return;
1840
1841 case range_golem: /* Control summoned monsters from scrolls */
1842 if (QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
1843 {
1844 op->contr->ranges[range_golem] = 0;
1845 op->contr->shoottype = range_none;
1846 }
1847 else
1848 control_golem (op->contr->ranges[range_golem], dir);
1849 return;
1850
1851 case range_skill:
1852 if (!op->chosen_skill)
1853 {
1854 if (op->type == PLAYER)
1855 new_draw_info (NDI_UNIQUE, 0, op, "You have no applicable skill to use.");
1856 return;
1857 }
1858
1859 do_skill (op, op, op->chosen_skill, dir, NULL);
1860 return;
1861 case range_builder:
1862 apply_map_builder (op, dir); 1674 apply_map_builder (who, dir);
1863 return; 1675 break;
1676
1677 case SKILL:
1678 do_skill (who, who, ob, dir, 0);
1679 break;
1680
1681 case RANGED:
1682 do_skill (who, ob, who->chosen_skill, dir, 0);
1683 break;
1684
1864 default: 1685 default:
1865 new_draw_info (NDI_UNIQUE, 0, op, "Illegal shoot type."); 1686 fire_misc_object (who, dir);
1866 return; 1687 break;
1867 } 1688 }
1868}
1869 1689
1690 return true;
1691}
1870 1692
1871 1693static object *
1872/* find_key
1873 * We try to find a key for the door as passed. If we find a key
1874 * and successfully use it, we return the key, otherwise NULL
1875 * This function merges both normal and locked door, since the logic
1876 * for both is the same - just the specific key is different.
1877 * pl is the player,
1878 * inv is the objects inventory to searched
1879 * door is the door we are trying to match against.
1880 * This function can be called recursively to search containers.
1881 */
1882
1883object *
1884find_key (object *pl, object *container, object *door) 1694find_key_ (object *pl, object *container, object *door)
1885{ 1695{
1886 object *tmp, *key; 1696 object *tmp, *key;
1887 1697
1888 /* Should not happen, but sanity checking is never bad */ 1698 /* Should not happen, but sanity checking is never bad */
1889 if (container->inv == NULL) 1699 if (!container->inv)
1890 return NULL; 1700 return 0;
1891 1701
1892 /* First, lets try to find a key in the top level inventory */ 1702 /* First, lets try to find a key in the top level inventory */
1893 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1703 for (tmp = container->inv; tmp; tmp = tmp->below)
1894 { 1704 {
1895 if (door->type == DOOR && tmp->type == KEY) 1705 if (door->type == DOOR && tmp->type == KEY)
1896 break; 1706 break;
1707
1897 /* For sanity, we should really check door type, but other stuff 1708 /* For sanity, we should really check door type, but other stuff
1898 * (like containers) can be locked with special keys 1709 * (like containers) can be locked with special keys
1899 */ 1710 */
1900 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying) 1711 if (tmp->slaying && tmp->type == SPECIAL_KEY && tmp->slaying == door->slaying)
1901 break; 1712 break;
1902 } 1713 }
1714
1903 /* No key found - lets search inventories now */ 1715 /* No key found - lets search inventories now */
1904 /* If we find and use a key in an inventory, return at that time. 1716 /* If we find and use a key in an inventory, return at that time.
1905 * otherwise, if we search all the inventories and still don't find 1717 * otherwise, if we search all the inventories and still don't find
1906 * a key, return 1718 * a key, return
1907 */ 1719 */
1908 if (!tmp) 1720 if (!tmp)
1909 { 1721 {
1910 for (tmp = container->inv; tmp != NULL; tmp = tmp->below) 1722 for (tmp = container->inv; tmp; tmp = tmp->below)
1911 {
1912 /* No reason to search empty containers */ 1723 /* No reason to search empty containers */
1913 if (tmp->type == CONTAINER && tmp->inv) 1724 if (tmp->type == CONTAINER && tmp->inv)
1914 {
1915 if ((key = find_key (pl, tmp, door)) != NULL) 1725 if ((key = find_key_ (pl, tmp, door)))
1916 return key; 1726 return key;
1917 } 1727
1918 }
1919 if (!tmp) 1728 if (!tmp)
1920 return NULL; 1729 return 0;
1921 } 1730 }
1731
1922 /* We get down here if we have found a key. Now if its in a container, 1732 /* We get down here if we have found a key. Now if its in a container,
1923 * see if we actually want to use it 1733 * see if we actually want to use it
1924 */ 1734 */
1925 if (pl != container) 1735 if (pl != container)
1926 { 1736 {
1927 /* Only let players use keys in containers */ 1737 /* Only let players use keys in containers */
1928 if (!pl->contr) 1738 if (!pl->contr)
1929 return NULL; 1739 return 0;
1740
1930 /* cases where this fails: 1741 /* cases where this fails:
1931 * If we only search the player inventory, return now since we 1742 * If we only search the player inventory, return now since we
1932 * are not in the players inventory. 1743 * are not in the players inventory.
1933 * If the container is not active, return now since only active 1744 * If the container is not active, return now since only active
1934 * containers can be used. 1745 * containers can be used.
… …
1938 * inv must have been an container and must have been active. 1749 * inv must have been an container and must have been active.
1939 * 1750 *
1940 * Change the color so that the message doesn't disappear with 1751 * Change the color so that the message doesn't disappear with
1941 * all the others. 1752 * all the others.
1942 */ 1753 */
1943 if (pl->contr->usekeys == key_inventory || 1754 if (pl->contr->usekeys == key_inventory
1944 !QUERY_FLAG (container, FLAG_APPLIED) || 1755 || !container->flag [FLAG_APPLIED]
1945 (pl->contr->usekeys == keyrings && (!container->race || strcmp (container->race, "keys")))) 1756 || (pl->contr->usekeys == keyrings && container->race != shstr_keys))
1946 { 1757 {
1947 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl, 1758 new_draw_info_format (NDI_UNIQUE | NDI_BROWN, 0, pl,
1948 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container)); 1759 "The %s in your %s vibrates as you approach the door", query_name (tmp), query_name (container));
1949 return NULL; 1760 return NULL;
1950 } 1761 }
1951 } 1762 }
1763
1952 return tmp; 1764 return tmp;
1765}
1766
1767/* find_key
1768 * We try to find a key for the door as passed. If we find a key
1769 * and successfully use it, we return the key, otherwise NULL
1770 * This function merges both normal and locked door, since the logic
1771 * for both is the same - just the specific key is different.
1772 * pl is the player,
1773 * inv is the objects inventory to searched
1774 * door is the door we are trying to match against.
1775 * This function can be called recursively to search containers.
1776 */
1777object *
1778find_key (object *pl, object *container, object *door)
1779{
1780 if (door->slaying && is_match_expr (door->slaying))
1781 {
1782 // for match expressions, we try to find the key by applying the match
1783 // to the op itself, which is supposed to find the "key", instead
1784 // of searching through containers ourselves.
1785
1786 return match_one (door->slaying, container, door, pl, pl);
1787 }
1788 else
1789 return find_key_ (pl, container, door);
1953} 1790}
1954 1791
1955/* moved door processing out of move_player_attack. 1792/* moved door processing out of move_player_attack.
1956 * returns 1 if player has opened the door with a key 1793 * returns 1 if player has opened the door with a key
1957 * such that the caller should not do anything more, 1794 * such that the caller should not do anything more,
1958 * 0 otherwise 1795 * 0 otherwise
1959 */ 1796 */
1960static int 1797static int
1961player_attack_door (object *op, object *door) 1798player_attack_door (object *op, object *door)
1962{ 1799{
1963 /* If its a door, try to find a use a key. If we do destroy the door, 1800 /* If its a door, try to find a key. If we do destroy the door,
1964 * might as well return immediately as there is nothing more to do - 1801 * might as well return immediately as there is nothing more to do -
1965 * otherwise, we fall through to the rest of the code. 1802 * otherwise, we fall through to the rest of the code.
1966 */ 1803 */
1967 object *key = find_key (op, op, door); 1804 object *key = find_key (op, op, door);
1968 1805
1969 /* IF we found a key, do some extra work */ 1806 /* If we found a key, do some extra work */
1970 if (key) 1807 if (key)
1971 { 1808 {
1972 object *container = key->env; 1809 object *container = key->env;
1973 1810
1974 play_sound_map (op->map, op->x, op->y, SOUND_OPEN_DOOR);
1975 if (action_makes_visible (op)) 1811 if (action_makes_visible (op))
1976 make_visible (op); 1812 make_visible (op);
1813
1977 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP)) 1814 if (door->inv && (door->inv->type == RUNE || door->inv->type == TRAP))
1978 spring_trap (door->inv, op); 1815 spring_trap (door->inv, op);
1816
1979 if (door->type == DOOR) 1817 if (door->type == DOOR)
1980 {
1981 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */ 1818 hit_player (door, 9998, op, AT_PHYSICAL, 1); /* Break through the door */
1982 }
1983 else if (door->type == LOCKED_DOOR) 1819 else if (door->type == LOCKED_DOOR)
1984 { 1820 {
1985 new_draw_info_format (NDI_UNIQUE, NDI_BROWN, op, "You open the door with the %s", query_short_name (key)); 1821 op->statusmsg (format ("You open the door with the %s", query_short_name (key)), NDI_BROWN);
1986 remove_door2 (door); /* remove door without violence ;-) */ 1822 remove_door2 (door); /* remove door without violence ;-) */
1987 } 1823 }
1824
1988 /* Do this after we print the message */ 1825 /* Do this after we print the message */
1989 decrease_ob (key); /* Use up one of the keys */ 1826 key->decrease (); /* Use up one of the keys */
1990 /* Need to update the weight the container the key was in */ 1827
1991 if (container != op)
1992 esrv_update_item (UPD_WEIGHT, op, container);
1993 return 1; /* Nothing more to do below */ 1828 return 1; /* Nothing more to do below */
1994 } 1829 }
1995 else if (door->type == LOCKED_DOOR) 1830 else if (door->type == LOCKED_DOOR)
1996 { 1831 {
1997 /* Might as well return now - no other way to open this */ 1832 /* Might as well return now - no other way to open this */
1998 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, door->msg); 1833 op->failmsg (door->msg ? &door->msg : "Hmm, you miss the certain something to open this door...");
1999 return 1; 1834 return 1;
2000 } 1835 }
1836
2001 return 0; 1837 return 0;
2002} 1838}
2003 1839
2004/* This function is just part of a breakup from move_player. 1840/* This function is just part of a breakup from move_player.
2005 * It should keep the code cleaner. 1841 * It should keep the code cleaner.
2006 * When this is called, the players direction has been updated 1842 * When this is called, the players direction has been updated
2007 * (taking into account confusion.) The player is also actually 1843 * (taking into account confusion.) The player is also actually
2008 * going to try and move (not fire weapons). 1844 * going to try and move (not fire weapons).
2009 */ 1845 */
2010void 1846bool
2011move_player_attack (object *op, int dir) 1847move_player_attack (object *op, int dir)
2012{ 1848{
2013 object *tmp, *mon; 1849 if (!op->contr->braced && op->speed_left > 0.f && op->move (dir))
2014 sint16 nx, ny; 1850 {
2015 int on_battleground; 1851 --op->speed_left;
2016 maptile *m; 1852 return true;
1853 }
2017 1854
2018 nx = freearr_x[dir] + op->x; 1855 sint16 nx = freearr_x[dir] + op->x;
2019 ny = freearr_y[dir] + op->y; 1856 sint16 ny = freearr_y[dir] + op->y;
2020 1857
2021 on_battleground = op_on_battleground (op, 0, 0); 1858 if (out_of_map (op->map, nx, ny))
1859 return false;
2022 1860
2023 /* If braced, or can't move to the square, and it is not out of the 1861 /* If braced, or can't move to the square, and it is not out of the
2024 * map, attack it. Note order of if statement is important - don't 1862 * map, attack it. Note order of if statement is important - don't
2025 * want to be calling move_ob if braced, because move_ob will move the 1863 * want to be calling move_ob if braced, because move_ob will move the
2026 * player. This is a pretty nasty hack, because if we could 1864 * player. This is a pretty nasty hack, because if we could
2027 * move to some space, it then means that if we are braced, we should 1865 * move to some space, it then means that if we are braced, we should
2028 * do nothing at all. As it is, if we are braced, we go through 1866 * do nothing at all. As it is, if we are braced, we go through
2029 * quite a bit of processing. However, it probably is less than what 1867 * quite a bit of processing. However, it probably is less than what
2030 * move_ob uses. 1868 * move_ob uses.
2031 */ 1869 */
2032 if ((op->contr->braced || !move_ob (op, dir, op)) && !out_of_map (op->map, nx, ny)) 1870 maptile *m = op->map->xy_find (nx, ny);
1871
1872 /* Go through all the objects, and find ones of interest. Only stop if
1873 * we find a monster - that is something we know we want to attack.
1874 * if its a door or barrel (can roll) see if there may be monsters
1875 * on the space
1876 */
1877 object *mon;
1878 for (mon = m->at (nx, ny).bot; mon; mon = mon->above)
1879 {
1880 if ((mon->flag [FLAG_ALIVE]
1881 || mon->type == LOCKED_DOOR
1882 || mon->flag [FLAG_CAN_ROLL])
1883 && mon != op)
1884 break;
2033 { 1885 }
2034 if (OUT_OF_REAL_MAP (op->map, nx, ny)) 1886
1887 /* no monster == player tries to move into a wall or so */
1888 if (!mon)
1889 {
1890 for (object *ob = m->at (nx, ny).top; ob; ob = ob->below)
1891 if (op->move_type & ob->move_block)
2035 { 1892 {
2036 m = op->map->xy_find (nx, ny); 1893 if (ob->move_block == MOVE_ALL)
2037 if (!m) 1894 move_into_wall (op, ob);
2038 return; /* Don't think this should happen */ 1895 else
1896 {
1897 if (op->contr->ns->bumpmsg)
1898 {
1899 op->play_sound (sound_find ("blocked_move"));
1900
1901 op->statusmsg (ob->invisible
1902 ? "Something blocks you."
1903 : format ("Something blocks you from entering the %s.", query_name (ob))
1904 );
1905 }
1906 }
1907
1908 break;
1909 }
1910
1911 return false;
1912 }
1913
1914 mon = mon->head_ ();
1915
1916 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
1917 if (op->contr->weapon_sp_left > 0.f)
1918 if (player_attack_door (op, mon))
1919 {
1920 --op->contr->weapon_sp_left;
1921 return true;
1922 }
1923
1924 /* The following deals with possibly attacking peaceful
1925 * or friendly creatures. Basically, all players are considered
1926 * unaggressive. If the moving player has peaceful set, then the
1927 * object should be pushed instead of attacked. It is assumed that
1928 * if you are braced, you will not attack friends accidently,
1929 * and thus will not push them.
1930 */
1931
1932 /* If the creature is a pet, push it even if the player is not
1933 * peaceful. Our assumption is the creature is a pet if the
1934 * player owns it and it is either friendly or unagressive.
1935 */
1936 if (op->type == PLAYER
1937 && ((mon->owner && mon->owner->contr
1938 && same_party (mon->owner->contr->party, op->contr->party))
1939 || mon->owner == op)
1940 && (mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY]))
1941 {
1942 /* If we're braced, we don't want to switch places with it */
1943 if (op->contr->braced)
1944 return false;
1945
1946 if (op->speed_left > 0.f)
1947 {
1948 --op->speed_left;
1949
1950 op->play_sound (sound_find ("push_player"));
1951 push_ob (mon, dir, op);
1952
1953 if (action_makes_visible (op))
1954 make_visible (op);
1955
1956 return true;
2039 } 1957 }
2040 else 1958 else
2041 m = op->map;
2042
2043 if (!(tmp = m->at (nx, ny).bot))
2044 return; 1959 return false;
1960 }
2045 1961
2046 mon = 0; 1962 bool on_battleground = op_on_battleground (op, 0, 0);
2047 /* Go through all the objects, and find ones of interest. Only stop if
2048 * we find a monster - that is something we know we want to attack.
2049 * if its a door or barrel (can roll) see if there may be monsters
2050 * on the space
2051 */
2052 while (tmp)
2053 {
2054 if (tmp == op)
2055 {
2056 tmp = tmp->above;
2057 continue;
2058 }
2059 1963
2060 if (QUERY_FLAG (tmp, FLAG_ALIVE))
2061 {
2062 mon = tmp;
2063 break;
2064 }
2065
2066 if (tmp->type == LOCKED_DOOR || QUERY_FLAG (tmp, FLAG_CAN_ROLL))
2067 mon = tmp;
2068
2069 tmp = tmp->above;
2070 }
2071
2072 if (!mon) /* This happens anytime the player tries to move */
2073 return; /* into a wall */
2074
2075 if (mon->head)
2076 mon = mon->head;
2077
2078 if ((mon->type == DOOR && mon->stats.hp >= 0) || (mon->type == LOCKED_DOOR))
2079 if (player_attack_door (op, mon))
2080 return;
2081
2082 /* The following deals with possibly attacking peaceful
2083 * or frienddly creatures. Basically, all players are considered
2084 * unaggressive. If the moving player has peaceful set, then the
2085 * object should be pushed instead of attacked. It is assumed that
2086 * if you are braced, you will not attack friends accidently,
2087 * and thus will not push them.
2088 */
2089
2090 /* If the creature is a pet, push it even if the player is not
2091 * peaceful. Our assumption is the creature is a pet if the
2092 * player owns it and it is either friendly or unagressive.
2093 */
2094 if ((op->type == PLAYER)
2095#if COZY_SERVER
2096 &&
2097 ((mon->owner && mon->owner->contr
2098 && same_party (mon->owner->contr->party, op->contr->party)) || mon->owner == op)
2099#else
2100 && mon->owner == op
2101#endif
2102 && (QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)))
2103 {
2104 /* If we're braced, we don't want to switch places with it */
2105 if (op->contr->braced)
2106 return;
2107
2108 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER);
2109 (void) push_ob (mon, dir, op);
2110 if (op->contr->tmp_invis || op->hide)
2111 make_visible (op);
2112
2113 return;
2114 }
2115
2116 /* in certain circumstances, you shouldn't attack friendly 1964 /* in certain circumstances, you shouldn't attack friendly
2117 * creatures. Note that if you are braced, you can't push 1965 * creatures. Note that if you are braced, you can't push
2118 * someone, but put it inside this loop so that you won't 1966 * someone, but put it inside this loop so that you won't
2119 * attack them either. 1967 * attack them either.
2120 */ 1968 */
2121 if ((mon->type == PLAYER || mon->enemy != op) && 1969 if ((mon->type == PLAYER || mon->enemy != op)
2122 (mon->type == PLAYER || QUERY_FLAG (mon, FLAG_UNAGGRESSIVE) || QUERY_FLAG (mon, FLAG_FRIENDLY)) && ( 1970 && (mon->type == PLAYER || mon->flag [FLAG_UNAGGRESSIVE] || mon->flag [FLAG_FRIENDLY])
2123#ifdef PROHIBIT_PLAYERKILL
2124 (op->contr->peaceful 1971 && ((op->contr->peaceful
2125 || (mon->type == PLAYER 1972 || (mon->type == PLAYER && mon->contr->peaceful))
2126 && mon->contr->
2127 peaceful)) &&
2128#else
2129 op->contr->peaceful &&
2130#endif
2131 !on_battleground)) 1973 && !on_battleground))
1974 {
1975 if (op->speed_left > 0.f)
2132 { 1976 {
1977 --op->speed_left;
1978
2133 if (!op->contr->braced) 1979 if (!op->contr->braced)
2134 { 1980 {
2135 play_sound_map (op->map, op->x, op->y, SOUND_PUSH_PLAYER); 1981 op->play_sound (sound_find ("push_player"));
2136 push_ob (mon, dir, op); 1982 push_ob (mon, dir, op);
2137 } 1983 }
2138 else 1984 else
2139 new_draw_info (0, 0, op, "You withhold your attack"); 1985 op->statusmsg ("You withhold your attack");
2140 1986
2141 if (op->contr->tmp_invis || op->hide) 1987 if (op->contr->tmp_invis || op->flag [FLAG_HIDDEN])
2142 make_visible (op); 1988 make_visible (op);
2143 }
2144 1989
1990 return true;
1991 }
1992 }
2145 /* If the object is a boulder or other rollable object, then 1993 /* If the object is a boulder or other rollable object, then
2146 * roll it if not braced. You can't roll it if you are braced. 1994 * roll it if not braced. You can't roll it if you are braced.
2147 */ 1995 */
2148 else if (QUERY_FLAG (mon, FLAG_CAN_ROLL) && (!op->contr->braced)) 1996 else if (mon->flag [FLAG_CAN_ROLL] && (!op->contr->braced))
1997 {
1998 if (op->speed_left > 0.f)
2149 { 1999 {
2000 --op->speed_left;
2001
2150 recursive_roll (mon, dir, op); 2002 recursive_roll (mon, dir, op);
2151 if (action_makes_visible (op)) 2003 if (action_makes_visible (op))
2152 make_visible (op); 2004 make_visible (op);
2153 }
2154 2005
2006 return true;
2007 }
2008 }
2155 /* Any generic living creature. Including things like doors. 2009 /* Any generic living creature. Including things like doors.
2156 * Way it works is like this: First, it must have some hit points 2010 * Way it works is like this: First, it must have some hit points
2157 * and be living. Then, it must be one of the following: 2011 * and be living. Then, it must be one of the following:
2158 * 1) Not a player, 2) A player, but of a different party. Note 2012 * 1) Not a player, 2) A player, but of a different party. Note
2159 * that party_number -1 is no party, so attacks can still happen. 2013 * that party_number -1 is no party, so attacks can still happen.
2160 */ 2014 */
2161 else if ((mon->stats.hp >= 0) && QUERY_FLAG (mon, FLAG_ALIVE) && 2015 else if ((mon->stats.hp >= 0) && mon->flag [FLAG_ALIVE] &&
2162 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party))) 2016 ((mon->type != PLAYER || op->contr->party == NULL || op->contr->party != mon->contr->party)))
2163 { 2017 {
2164 2018 if (op->contr->weapon_sp_left > 0.f && !op->flag [FLAG_WIZPASS])
2165 /* If the player hasn't hit something this tick, and does
2166 * so, give them speed boost based on weapon speed. Doing
2167 * it here is better than process_players2, which basically
2168 * incurred a 1 tick offset.
2169 */
2170 if (!op->contr->has_hit)
2171 { 2019 {
2172 op->speed_left += op->speed / op->contr->weapon_sp; 2020 --op->contr->weapon_sp_left;
2173
2174 op->contr->has_hit = 1; /* The last action was to hit, so use weapon_sp */
2175 }
2176 2021
2177 skill_attack (mon, op, 0, 0, 0); 2022 skill_attack (mon, op, 0, 0, 0);
2178
2179 /* If attacking another player, that player gets automatic
2180 * hitback, and doesn't loose luck either.
2181 * Disable hitback on the battleground or if the target is
2182 * the wiz.
2183 */
2184 if (mon->type == PLAYER && mon->stats.hp >= 0 && !mon->contr->has_hit && !on_battleground && !QUERY_FLAG (mon, FLAG_WIZ))
2185 {
2186 short luck = mon->stats.luck;
2187
2188 mon->contr->has_hit = 1;
2189 skill_attack (op, mon, 0, 0, 0);
2190 mon->stats.luck = luck;
2191 }
2192 2023
2193 if (action_makes_visible (op)) 2024 if (action_makes_visible (op))
2194 make_visible (op); 2025 make_visible (op);
2195 }
2196 } /* if player should attack something */
2197}
2198 2026
2199int 2027 return true;
2028 }
2029 }
2030
2031 return false;
2032}
2033
2034bool
2200move_player (object *op, int dir) 2035move_player (object *op, int dir)
2201{ 2036{
2202 int pick;
2203
2204 if (!op->map || op->map->in_memory != MAP_IN_MEMORY) 2037 if (!op->map || op->map->state != MAP_ACTIVE)
2205 return 0; 2038 return 0;
2206 2039
2207 /* Sanity check: make sure dir is valid */ 2040 /* Sanity check: make sure dir is valid */
2208 if ((dir < 0) || (dir >= 9)) 2041 if (dir < 0 || dir > 8)
2209 { 2042 {
2210 LOG (llevError, "move_player: invalid direction %d\n", dir); 2043 LOG (llevError, "move_player: invalid direction %d\n", dir);
2211 return 0; 2044 return 0;
2212 } 2045 }
2213 2046
2214 /* peterm: added following line */ 2047 /* peterm: added following line */
2215 if (QUERY_FLAG (op, FLAG_CONFUSED) && dir) 2048 if (op->flag [FLAG_CONFUSED] && dir)
2216 dir = absdir (dir + rndm (3) + rndm (3) - 2); 2049 dir = absdir (dir + rndm (3) + rndm (3) - 2);
2217 2050
2218 op->facing = dir; 2051 op->facing = dir;
2219 2052
2220 if (op->hide) 2053 if (op->flag [FLAG_HIDDEN])
2221 do_hidden_move (op); 2054 do_hidden_move (op);
2222 2055
2056 bool retval;
2057 int pick = 0;
2058
2223 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir))) 2059 if (INVOKE_PLAYER (MOVE, op->contr, ARG_INT (dir)))
2224 /*nop */ ; 2060 retval = RESULT_INT (0);
2225 else if (op->contr->fire_on) 2061 else if (op->contr->fire_on)
2226 fire (op, dir); 2062 retval = fire (op, dir);
2227 else 2063 else
2228 { 2064 {
2229 move_player_attack (op, dir); 2065 retval = move_player_attack (op, dir);
2230 pick = check_pick (op); 2066 pick = check_pick (op);
2231 } 2067 }
2232 2068
2233 /* Add special check for newcs players and fire on - this way, the 2069 /* Add special check for newcs players and fire on - this way, the
2234 * server can handle repeat firing. 2070 * server can handle repeat firing.
… …
2241 /* Update how the player looks. Use the facing, so direction may 2077 /* Update how the player looks. Use the facing, so direction may
2242 * get reset to zero. This allows for full animation capabilities 2078 * get reset to zero. This allows for full animation capabilities
2243 * for players. 2079 * for players.
2244 */ 2080 */
2245 animate_object (op, op->facing); 2081 animate_object (op, op->facing);
2246 return 0; 2082
2083 return retval;
2247} 2084}
2248 2085
2249/* This is similar to handle_player, below, but is only used by the 2086/* This is similar to handle_player, below, but is only used by the
2250 * new client/server stuff. 2087 * new client/server stuff.
2251 * This is sort of special, in that the new client/server actually uses 2088 * This is sort of special, in that the new client/server actually uses
2252 * the new speed values for commands. 2089 * the new speed values for commands.
2253 * 2090 *
2254 * Returns true if there are more actions we can do. 2091 * Returns true if there are more actions we can do. Should not do
2092 * many actions in a row, as that would be too unfair to other
2093 * players.
2255 */ 2094 */
2256int 2095bool
2257handle_newcs_player (object *op) 2096handle_newcs_player (object *op)
2258{ 2097{
2259 if (op->contr->hidden) 2098 if (op->flag [FLAG_SCARED])
2260 {
2261 op->invisible = 1000;
2262 /* the socket code flashes the player visible/invisible
2263 * depending on the value of invisible, so we need to
2264 * alternate it here for it to work correctly.
2265 */
2266 if (pticks & 2)
2267 op->invisible--;
2268 } 2099 {
2269 else if (op->invisible && !(QUERY_FLAG (op, FLAG_MAKE_INVIS))) 2100 if (op->speed_left > 0.f)
2270 {
2271 op->invisible--;
2272 if (!op->invisible)
2273 {
2274 make_visible (op);
2275 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2276 } 2101 {
2277 }
2278
2279 if (QUERY_FLAG (op, FLAG_SCARED))
2280 {
2281 flee_player (op);
2282 /* If player is still scared, that is his action for this tick */
2283 if (QUERY_FLAG (op, FLAG_SCARED))
2284 {
2285 op->speed_left--; 2102 --op->speed_left;
2103 flee_player (op);
2104
2286 return 0; 2105 return true;
2287 } 2106 }
2107 else
2108 return false;
2288 } 2109 }
2289
2290 /* I've been seeing crashes where the golem has been destroyed, but
2291 * the player object still points to the defunct golem. The code that
2292 * destroys the golem looks correct, and it doesn't always happen, so
2293 * put this in a a workaround to clean up the golem pointer.
2294 */
2295 if (op->contr->ranges[range_golem] && QUERY_FLAG (op->contr->ranges[range_golem], FLAG_REMOVED))
2296 op->contr->ranges[range_golem] = 0;
2297 2110
2298 /* call this here - we also will call this in do_ericserver, but 2111 /* call this here - we also will call this in do_ericserver, but
2299 * the players time has been increased when doericserver has been 2112 * the players time has been increased when doericserver has been
2300 * called, so we recheck it here. 2113 * called, so we recheck it here.
2301 */ 2114 */
2302 if (op->contr->ns->handle_command ()) 2115 if (op->contr->ns->handle_command ())
2303 return 1; 2116 return true;
2304 2117
2305 if (op->speed_left > 0)
2306 {
2307 if (op->direction && (op->contr->run_on || op->contr->fire_on)) 2118 if (op->direction && (op->contr->run_on || op->contr->fire_on))
2308 {
2309 /* All move commands take 1 tick, at least for now */
2310 op->speed_left--;
2311
2312 /* Instead of all the stuff below, let move_player take care
2313 * of it. Also, some of the skill stuff is only put in
2314 * there, as well as the confusion stuff.
2315 */
2316 move_player (op, op->direction); 2119 return move_player (op, op->direction);
2317 2120
2318 return op->speed_left > 0;
2319 }
2320 }
2321
2322 return 0; 2121 return false;
2323} 2122}
2324 2123
2325int 2124static int
2326save_life (object *op) 2125save_life (object *op)
2327{ 2126{
2328 if (!QUERY_FLAG (op, FLAG_LIFESAVE)) 2127 if (!op->flag [FLAG_LIFESAVE])
2329 return 0; 2128 return 0;
2330 2129
2331 for (object *tmp = op->inv; tmp; tmp = tmp->below) 2130 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2332 if (QUERY_FLAG (tmp, FLAG_APPLIED) && QUERY_FLAG (tmp, FLAG_LIFESAVE)) 2131 if (tmp->flag [FLAG_APPLIED] && tmp->flag [FLAG_LIFESAVE])
2333 { 2132 {
2334 play_sound_map (op->map, op->x, op->y, SOUND_OB_EVAPORATE); 2133 op->play_sound (sound_find ("ob_evaporate"));
2335 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp)); 2134 new_draw_info_format (NDI_UNIQUE, 0, op, "Your %s vibrates violently, then evaporates.", query_name (tmp));
2336 2135
2337 if (op->contr)
2338 esrv_del_item (op->contr, tmp->count);
2339
2340 tmp->destroy (); 2136 tmp->destroy ();
2341 CLEAR_FLAG (op, FLAG_LIFESAVE); 2137 op->clr_flag (FLAG_LIFESAVE);
2342 2138
2343 if (op->stats.hp < 0) 2139 if (op->stats.hp < 0)
2344 op->stats.hp = op->stats.maxhp; 2140 op->stats.hp = op->stats.maxhp;
2345 2141
2346 if (op->stats.food < 0) 2142 if (op->stats.food < 0)
2347 op->stats.food = 999; 2143 op->stats.food = MAX_FOOD;
2348 2144
2349 op->update_stats (); 2145 op->update_stats ();
2350 return 1; 2146 return 1;
2351 } 2147 }
2352 2148
2353 LOG (llevError, "Error: LIFESAVE set without applied object.\n"); 2149 LOG (llevError, "Error: LIFESAVE set without applied object.\n");
2354 CLEAR_FLAG (op, FLAG_LIFESAVE); 2150 op->clr_flag (FLAG_LIFESAVE);
2355 enter_player_savebed (op); /* bring him home. */ 2151 enter_player_savebed (op); /* bring him home. */
2356 return 0; 2152 return 0;
2357} 2153}
2358 2154
2359/* This goes throws the inventory and removes unpaid objects, and puts them 2155/* This goes throws the inventory and removes unpaid objects, and puts them
2360 * back in the map (location and map determined by values of env). This 2156 * back in the map (location and map determined by values of env). This
2361 * function will descend into containers. op is the object to start the search 2157 * function will descend into containers. op is the object to start the search
2362 * from. 2158 * from.
2363 */ 2159 */
2160static void
2161drop_unpaid_items (object *op, object *env)
2162{
2163 while (op)
2164 {
2165 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2166
2167 if (op->flag [FLAG_UNPAID])
2168 op->insert_at (env);
2169 else if (op->inv)
2170 drop_unpaid_items (op->inv, env);
2171
2172 op = next;
2173 }
2174}
2175
2364void 2176void
2365remove_unpaid_objects (object *op, object *env) 2177object::drop_unpaid_items ()
2366{ 2178{
2367 object *next; 2179 if (!flag [FLAG_REMOVED])
2368 2180 ::drop_unpaid_items (inv, this);
2369 while (op)
2370 {
2371 object *next = op->below; /* Make sure we have a good value, in case we remove object 'op' */
2372
2373 if (QUERY_FLAG (op, FLAG_UNPAID))
2374 {
2375 if (env->type == PLAYER)
2376 esrv_del_item (env->contr, op->count);
2377
2378 op->insert_at (env);
2379 }
2380 else if (op->inv)
2381 remove_unpaid_objects (op->inv, env);
2382
2383 op = next;
2384 }
2385}
2386
2387/*
2388 * Returns pointer a static string containing gravestone text
2389 * Moved from apply.c to player.c - player.c is what
2390 * actually uses this function. player.c may not be quite the
2391 * best, a misc file for object actions is probably better,
2392 * but there isn't one in the server directory.
2393 */
2394char *
2395gravestone_text (object *op)
2396{
2397 static char buf2[MAX_BUF];
2398 char buf[MAX_BUF];
2399 time_t now = time (NULL);
2400
2401 strcpy (buf2, " R.I.P.\n\n");
2402 if (op->type == PLAYER)
2403 sprintf (buf, "%s the %s\n", &op->name, op->contr->title);
2404 else
2405 sprintf (buf, "%s\n", &op->name);
2406
2407 strncat (buf2, " ", 20 - strlen (buf) / 2);
2408 strcat (buf2, buf);
2409 if (op->type == PLAYER)
2410 sprintf (buf, "who was in level %d when killed\n", op->level);
2411 else
2412 sprintf (buf, "who was in level %d when died.\n\n", op->level);
2413
2414 strncat (buf2, " ", 20 - strlen (buf) / 2);
2415 strcat (buf2, buf);
2416 if (op->type == PLAYER)
2417 {
2418 sprintf (buf, "by %s.\n\n", op->contr->killer);
2419 strncat (buf2, " ", 21 - strlen (buf) / 2);
2420 strcat (buf2, buf);
2421 }
2422
2423 strftime (buf, MAX_BUF, "%b %d %Y\n", localtime (&now));
2424 strncat (buf2, " ", 20 - strlen (buf) / 2);
2425 strcat (buf2, buf);
2426
2427 return buf2;
2428} 2181}
2429 2182
2430void 2183void
2431do_some_living (object *op) 2184do_some_living (object *op)
2432{ 2185{
2433 int last_food = op->stats.food; 2186 int last_food = op->stats.food;
2434 int gen_hp, gen_sp, gen_grace; 2187 int gen_hp, gen_sp, gen_grace;
2435 int over_hp, over_sp, over_grace;
2436 int i;
2437 int rate_hp = 1200; 2188 int rate_hp = 1200;
2438 int rate_sp = 2500; 2189 int rate_sp = 2500;
2439 int rate_grace = 2000; 2190 int rate_grace = 2000;
2440 const int max_hp = 1; 2191 const int max_hp = 1;
2441 const int max_sp = 1; 2192 const int max_sp = 1;
2442 const int max_grace = 1; 2193 const int max_grace = 1;
2443 2194
2444 if (op->contr->outputs_sync) 2195#if 0
2196 if (op->contr->hidden)
2197 {
2198 op->invisible = 1000;
2199 /* the socket code flashes the player visible/invisible
2200 * depending on the value of invisible, so we need to
2201 * alternate it here for it to work correctly.
2202 */
2203 if (server_tick & 2)
2204 op->invisible--;
2445 { 2205 }
2446 for (i = 0; i < NUM_OUTPUT_BUFS; i++) 2206 else
2447 if (op->contr->outputs[i].buf && (op->contr->outputs[i].first_update + op->contr->outputs_sync) < (uint16) pticks) 2207#endif
2448 flush_output_element (op, &op->contr->outputs[i]); 2208 if (op->invisible && !(op->flag [FLAG_MAKE_INVIS]))
2209 {
2210 if (!op->invisible--)
2211 {
2212 make_visible (op);
2213 new_draw_info (NDI_UNIQUE, 0, op, "Your invisibility spell runs out.");
2214 }
2449 } 2215 }
2450 2216
2451 if (op->contr->ns->state == ST_PLAYING) 2217 if (op->contr->ns->state == ST_PLAYING)
2452 { 2218 {
2453 /* these next three if clauses make it possible to SLOW DOWN 2219 /* these next three if clauses make it possible to SLOW DOWN
… …
2474 { 2240 {
2475 gen_grace = op->stats.maxgrace; 2241 gen_grace = op->stats.maxgrace;
2476 rate_grace -= rate_grace / 2 * op->contr->gen_grace; 2242 rate_grace -= rate_grace / 2 * op->contr->gen_grace;
2477 } 2243 }
2478 2244
2479 /* Regenerate Spell Points */ 2245 /* Regenerate Grace */
2480 if (op->contr->ranges[range_golem] == NULL && --op->last_sp < 0) 2246 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */
2247 if (--op->last_grace < 0)
2481 { 2248 {
2482 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2483 if (op->stats.sp < op->stats.maxsp) 2249 if (op->stats.grace < op->stats.maxgrace / 2)
2250 op->stats.grace++; /* no penalty in food for regaining grace */
2251
2252 int temp = gen_grace < 20 ? 30 : gen_grace + 10;
2253
2254 if (max_grace > 1)
2484 { 2255 {
2485 op->stats.sp++; 2256 int over_grace = temp / rate_grace;
2486 /* dms do not consume food */ 2257
2487 if (!QUERY_FLAG (op, FLAG_WIZ)) 2258 if (over_grace > 0)
2488 { 2259 {
2489 op->stats.food--; 2260 op->stats.sp += over_grace + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > (temp % rate_grace)) ? -1 : 0;
2490 if (op->contr->digestion < 0) 2261 op->last_grace = 0;
2491 op->stats.food += op->contr->digestion;
2492 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2493 op->stats.food = last_food;
2494 } 2262 }
2263 else
2264 op->last_grace = rate_grace / temp;
2495 } 2265 }
2266 else
2267 op->last_grace = rate_grace / temp;
2496 2268
2497 if (max_sp > 1) 2269 /* wearing stuff doesn't detract from grace generation. */
2270 }
2271
2272 if (op->stats.food > 0)
2273 {
2274 /* Regenerate Spell Points */
2275 if (!op->contr->golem && --op->last_sp < 0)
2498 { 2276 {
2499 over_sp = (gen_sp + 10) / rate_sp; 2277 gen_sp = gen_sp * 10 / (op->contr->gen_sp_armour < 10 ? 10 : op->contr->gen_sp_armour);
2500 if (over_sp > 0) 2278
2279 if (op->stats.sp < op->stats.maxsp)
2501 { 2280 {
2502 if (op->stats.sp < op->stats.maxsp) 2281 op->stats.sp++;
2282
2283 /* dms do not consume food */
2284 if (!op->flag [FLAG_WIZ])
2503 { 2285 {
2504 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2505
2506 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2507 op->stats.sp--; 2286 op->stats.food--;
2508 2287
2509 if (op->stats.sp > op->stats.maxsp) 2288 if (op->contr->digestion < 0)
2289 op->stats.food += op->contr->digestion;
2290 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2510 op->stats.sp = op->stats.maxsp; 2291 op->stats.food = last_food;
2511 } 2292 }
2293 }
2294
2295 if (max_sp > 1)
2296 {
2297 int over_sp = (gen_sp + 10) / rate_sp;
2298 if (over_sp > 0)
2299 {
2300 if (op->stats.sp < op->stats.maxsp)
2301 {
2302 op->stats.sp += over_sp > max_sp ? max_sp : over_sp;
2303
2304 if (random_roll (0, rate_sp - 1, op, PREFER_LOW) > ((gen_sp + 10) % rate_sp))
2305 op->stats.sp--;
2306
2307 if (op->stats.sp > op->stats.maxsp)
2308 op->stats.sp = op->stats.maxsp;
2309 }
2310
2512 op->last_sp = 0; 2311 op->last_sp = 0;
2312 }
2313 else
2314 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2513 } 2315 }
2514 else 2316 else
2515 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10); 2317 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2516 } 2318 }
2517 else
2518 op->last_sp = rate_sp / (gen_sp < 20 ? 30 : gen_sp + 10);
2519 }
2520 2319
2521 /* Regenerate Grace */ 2320 /* Regenerate Hit Points */
2522 /* I altered this a little - maximum grace is ony achieved through prayer -b.t. */
2523 if (--op->last_grace < 0) 2321 if (--op->last_heal < 0)
2524 {
2525 if (op->stats.grace < op->stats.maxgrace / 2)
2526 op->stats.grace++; /* no penalty in food for regaining grace */
2527
2528 if (max_grace > 1)
2529 { 2322 {
2530 over_grace = (gen_grace < 20 ? 30 : gen_grace + 10) / rate_grace; 2323 if (op->stats.hp < op->stats.maxhp)
2531 if (over_grace > 0)
2532 { 2324 {
2533 op->stats.sp += over_grace 2325 op->stats.hp++;
2534 + (random_roll (0, rate_grace - 1, op, PREFER_HIGH) > ((gen_grace < 20 ? 30 : gen_grace + 10) % rate_grace)) ? -1 : 0; 2326
2327 /* dms do not consume food */
2328 if (!op->flag [FLAG_WIZ])
2329 {
2330 op->stats.food--;
2331
2332 if (op->contr->digestion < 0)
2333 op->stats.food += op->contr->digestion;
2334 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2335 op->stats.food = last_food;
2336 }
2337 }
2338
2339 int temp = gen_hp < 20 ? 30 : gen_hp + 10;
2340
2341 if (max_hp > 1)
2342 {
2343 int over_hp = temp / rate_hp;
2344
2345 if (over_hp > 0)
2346 {
2347 op->stats.sp += over_hp + (random_roll (0, rate_hp - 1, op, PREFER_HIGH) > (temp % rate_hp)) ? -1 : 0;
2535 op->last_grace = 0; 2348 op->last_heal = 0;
2349 }
2350 else
2351 op->last_heal = rate_hp / temp;
2536 } 2352 }
2537 else 2353 else
2538 {
2539 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2540 }
2541 }
2542 else
2543 {
2544 op->last_grace = rate_grace / (gen_grace < 20 ? 30 : gen_grace + 10);
2545 }
2546 /* wearing stuff doesn't detract from grace generation. */
2547 }
2548
2549 /* Regenerate Hit Points */
2550 if (--op->last_heal < 0)
2551 {
2552 if (op->stats.hp < op->stats.maxhp)
2553 {
2554 op->stats.hp++;
2555 /* dms do not consume food */
2556 if (!QUERY_FLAG (op, FLAG_WIZ))
2557 {
2558 op->stats.food--;
2559 if (op->contr->digestion < 0)
2560 op->stats.food += op->contr->digestion;
2561 else if (op->contr->digestion > 0 && random_roll (0, op->contr->digestion, op, PREFER_HIGH))
2562 op->stats.food = last_food;
2563 }
2564 }
2565
2566 if (max_hp > 1)
2567 {
2568 over_hp = (gen_hp < 20 ? 30 : gen_hp + 10) / rate_hp;
2569 if (over_hp > 0)
2570 {
2571 op->stats.sp += over_hp + (RANDOM () % rate_hp > ((gen_hp < 20 ? 30 : gen_hp + 10) % rate_hp)) ? -1 : 0;
2572 op->last_heal = 0; 2354 op->last_heal = rate_hp / temp;
2573 }
2574 else
2575 {
2576 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2577 }
2578 }
2579 else
2580 {
2581 op->last_heal = rate_hp / (gen_hp < 20 ? 30 : gen_hp + 10);
2582 } 2355 }
2583 } 2356 }
2584 2357
2585 /* Digestion */ 2358 /* Digestion */
2586 if (--op->last_eat < 0) 2359 if (--op->last_eat < 0)
2587 { 2360 {
2588#ifdef COZY_SERVER 2361 int bonus = max (0, op->contr->digestion),
2589 int dg = op->contr->digestion >= 0 && op->contr->digestion < 2 ? 2 : op->contr->digestion; 2362 penalty = max (0, -op->contr->digestion);
2590 int bonus = dg > 0 ? dg : 0, penalty = dg < 0 ? -dg : 0;
2591#else
2592 int bonus = op->contr->digestion > 0 ? op->contr->digestion : 0, penalty = op->contr->digestion < 0 ? -op->contr->digestion : 0;
2593#endif
2594 2363
2595 if (op->contr->gen_hp > 0)
2596 op->last_eat = 25 * (1 + bonus) / (op->contr->gen_hp + penalty + 1); 2364 op->last_eat = 25 * (1 + bonus) / (max (0, op->contr->gen_hp) + penalty + 1);
2597 else
2598 op->last_eat = 25 * (1 + bonus) / (penalty + 1);
2599 2365
2600 /* dms do not consume food */ 2366 /* dms do not consume food */
2601 if (!QUERY_FLAG (op, FLAG_WIZ)) 2367 if (!op->flag [FLAG_WIZ])
2602 op->stats.food--; 2368 op->stats.food--;
2603 } 2369 }
2604 2370
2605 if (op->stats.food < 0 && op->stats.hp >= 0) 2371 if (op->stats.food < 0 && op->stats.hp >= 0)
2606 { 2372 {
2607 object *tmp, *flesh = 0; 2373 object *flesh = 0;
2608 2374
2609 for (tmp = op->inv; tmp; tmp = tmp->below) 2375 for_inv_removable (op, tmp)
2610 { 2376 {
2611 if (!QUERY_FLAG (tmp, FLAG_UNPAID)) 2377 if (tmp->flag [FLAG_UNPAID])
2378 continue;
2379
2380 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON)
2612 { 2381 {
2613 if (tmp->type == FOOD || tmp->type == DRINK || tmp->type == POISON) 2382 op->statusmsg ("You blindly grab for a bite of food. "
2614 { 2383 "H<To prevent you from starving, you ate some random item from your backpack.>");
2615 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2384 op->apply (tmp);
2616 manual_apply (op, tmp, 0); 2385
2617 if (op->stats.food >= 0 || op->stats.hp < 0) 2386 if (op->stats.food >= 0 || op->stats.hp < 0)
2618 break; 2387 break;
2619 } 2388 }
2620 else if (tmp->type == FLESH) 2389 else if (tmp->type == FLESH)
2621 flesh = tmp; 2390 flesh = tmp;
2622 } /* End if paid for object */ 2391 }
2623 } /* end of for loop */
2624 2392
2625 /* If player is still starving, it means they don't have any food, so 2393 /* If player is still starving, it means they don't have any food, so
2626 * eat flesh instead. 2394 * eat flesh instead.
2627 */ 2395 */
2628 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh) 2396 if (op->stats.food < 0 && op->stats.hp >= 0 && flesh)
2629 { 2397 {
2630 new_draw_info (NDI_UNIQUE, 0, op, "You blindly grab for a bite of food."); 2398 op->statusmsg ("You blindly grab for a bite of food. "
2399 "H<To prevent you from starving, you ate some random item from your backpack.>");
2631 manual_apply (op, flesh, 0); 2400 op->apply (flesh);
2632 } 2401 }
2402
2403 // If player is still starving, alert him!
2404 if (op->stats.food < 0)
2405 op->failmsg ("You are starving! "
2406 "H<Eat some food to increase your food and prevent you from an untimely death.>");
2407 }
2408
2409 if (op->stats.food < 0)
2633 } 2410 {
2411 op->stats.hp += op->stats.food;
2412 op->stats.food = 0;
2634 2413
2635 while (op->stats.food < 0 && op->stats.hp >= 0) 2414 if (op->stats.hp < 0)
2636 op->stats.food++, op->stats.hp--; 2415 {
2416 op->contr->killer = archetype::get ("killer_starvation");
2417 op->contr->killer->destroy ();
2418 }
2419 }
2637 2420
2421 /* killer should be set here already */
2638 if (op->stats.hp < 0 && !QUERY_FLAG (op, FLAG_WIZ)) 2422 if (op->stats.hp < 0 && !op->flag [FLAG_WIZ])
2639 kill_player (op); 2423 kill_player (op);
2640 } 2424 }
2641} 2425}
2642 2426
2643/* If the player should die (lack of hp, food, etc), we call this. 2427/* If the player should die (lack of hp, food, etc), we call this.
… …
2646 * file. 2430 * file.
2647 */ 2431 */
2648void 2432void
2649kill_player (object *op) 2433kill_player (object *op)
2650{ 2434{
2651 char buf[MAX_BUF];
2652 int x, y; 2435 int x, y;
2653
2654 //int i;
2655 maptile *map; /* this is for resurrection */ 2436 maptile *map; /* this is for resurrection */
2656
2657 /* int z;
2658 int num_stats_lose;
2659 int lost_a_stat;
2660 int lose_this_stat;
2661 int this_stat; */
2662 int will_kill_again; 2437 int will_kill_again;
2663 archetype *at; 2438 archetype *at;
2664 object *tmp; 2439 object *tmp;
2665 2440
2666 if (save_life (op)) 2441 if (save_life (op))
2667 return; 2442 return;
2668 2443
2444 dynbuf_text deathtab;
2445
2446 /* restore player */
2447 at = archetype::find (shstr_poisoning);
2448 if (object *tmp = present_arch_in_ob (at, op))
2449 {
2450 tmp->destroy ();
2451 deathtab << "Your body feels cleansed...\r";
2452 }
2453
2454 at = archetype::find (shstr_confusion);
2455 if (object *tmp = present_arch_in_ob (at, op))
2456 {
2457 tmp->destroy ();
2458 deathtab << "Your mind feels clearer...\r";
2459 }
2460
2461 cure_disease (op, 0, 0); /* remove any disease */
2462
2463 max_it (op->stats.hp , op->stats.maxhp);
2464 max_it (op->stats.sp , op->stats.maxsp);
2465 max_it (op->stats.grace, op->stats.maxgrace);
2466 max_it (op->stats.food , 200);
2467
2468 // remove all spell effects that are active
2469 // to avoid long-term effects such as word-of-recall
2470 for (object *item = op->inv; item; )
2471 {
2472 object *next = item->below;
2473
2474 if (item->type == SPELL_EFFECT && item->active)
2475 item->destroy ();
2476
2477 item = next;
2478 }
2669 2479
2670 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas 2480 /* If player dies on BATTLEGROUND, no stat/exp loss! For Combat-Arenas
2671 * in cities ONLY!!! It is very important that this doesn't get abused. 2481 * in cities ONLY!!! It is very important that this doesn't get abused.
2672 * Look at op_on_battleground() for more info --AndreasV 2482 * Look at op_on_battleground() for more info --AndreasV
2673 */ 2483 */
2674 if (op_on_battleground (op, &x, &y)) 2484 if (op_on_battleground (op, &x, &y))
2675 { 2485 {
2676 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "You have been defeated in combat!"); 2486 deathtab << "You almost died in combat, but local medics have saved your life...\r";
2677 new_draw_info (NDI_UNIQUE | NDI_NAVY, 0, op, "Local medics have saved your life...");
2678
2679 /* restore player */
2680 at = archetype::find ("poisoning");
2681 if (object *tmp = present_arch_in_ob (at, op))
2682 {
2683 tmp->destroy ();
2684 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2685 }
2686
2687 at = archetype::find ("confusion");
2688 if (object *tmp = present_arch_in_ob (at, op))
2689 {
2690 tmp->destroy ();
2691 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2692 }
2693
2694 cure_disease (op, 0); /* remove any disease */
2695 op->stats.hp = op->stats.maxhp;
2696 if (op->stats.food <= 0)
2697 op->stats.food = 999;
2698 2487
2699 /* create a bodypart-trophy to make the winner happy */ 2488 /* create a bodypart-trophy to make the winner happy */
2700 if (object *tmp = arch_to_object (archetype::find ("finger"))) 2489 object *tmp = archetype::find (shstr_finger)->instance ();
2701 { 2490
2702 sprintf (buf, "%s's finger", &op->name); 2491 tmp->name = format ("%s's finger" , &op->name);
2703 tmp->name = buf; 2492 tmp->name_pl = format ("%s's fingers", &op->name);
2704 sprintf (buf, " This finger has been cut off %s\n" 2493 tmp->msg = format (
2705 " the %s, when he was defeated at\n level %d by %s.\n", 2494 "This finger has been cut off of %s the %s, when he was defeated at level %d by %s.\n",
2706 &op->name, op->contr->title, (int) (op->level), op->contr->killer); 2495 &op->name, op->contr->title,
2707 tmp->msg = buf; 2496 (int)op->level,
2497 op->contr->killer_name ()
2498 );
2708 tmp->value = 0, tmp->material = 0, tmp->type = 0; 2499 tmp->value = 0, tmp->type = 0;
2709 tmp->materialname = NULL; 2500 tmp->material = name_to_material (shstr_organic);
2710 tmp->insert_at (op, tmp); 2501 tmp->insert_at (op, tmp);
2711 }
2712 2502
2713 /* teleport defeated player to new destination */ 2503 /* teleport defeated player to new destination */
2714 transfer_ob (op, x, y, 0, NULL); 2504 transfer_ob (op, x, y, 0, NULL);
2715 op->contr->braced = 0; 2505 op->contr->braced = 0;
2506
2507 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2716 return; 2508 return;
2717 } 2509 }
2718 2510
2511 deathtab << "You were killed by " << op->contr->killer_name () << ".\n\n";
2512 deathtab << "T<YOU HAVE DIED>\n\n";
2513
2719 INVOKE_PLAYER (DEATH, op->contr); 2514 INVOKE_PLAYER (DEATH, op->contr);
2720 2515
2721 command_kill_pets (op, 0); 2516 command_kill_pets (op, 0);
2722 2517
2723 if (op->stats.food < 0) 2518 op->contr->play_sound (sound_find ("player_dies"));
2724 {
2725 sprintf (buf, "%s starved to death.", &op->name);
2726 strcpy (op->contr->killer, "starvation");
2727 }
2728 else
2729 sprintf (buf, "%s died.", &op->name);
2730
2731 play_sound_player_only (op->contr, SOUND_PLAYER_DIES, 0, 0);
2732 2519
2733 /* save the map location for corpse, gravestone */ 2520 /* save the map location for corpse, gravestone */
2734 x = op->x; 2521 x = op->x;
2735 y = op->y; 2522 y = op->y;
2736 map = op->map; 2523 map = op->map;
… …
2764 2551
2765 lost_a_stat = 0; 2552 lost_a_stat = 0;
2766 2553
2767 for (z = 0; z < num_stats_lose; z++) 2554 for (z = 0; z < num_stats_lose; z++)
2768 { 2555 {
2769 i = RANDOM () % NUM_STATS; 2556 i = rndm (NUM_STATS);
2770 2557
2771 if (settings.stat_loss_on_death) 2558 if (settings.stat_loss_on_death)
2772 { 2559 {
2773 /* Pick a random stat and take a point off it. Tell the player 2560 /* Pick a random stat and take a point off it. Tell the player
2774 * what he lost. 2561 * what he lost.
… …
2781 lost_a_stat = 1; 2568 lost_a_stat = 1;
2782 } 2569 }
2783 else 2570 else
2784 { 2571 {
2785 /* deplete a stat */ 2572 /* deplete a stat */
2786 archetype *deparch = archetype::find ("depletion"); 2573 archetype *deparch = archetype::find (shstr_depletion);
2787 object *dep; 2574 object *dep;
2788 2575
2789 dep = present_arch_in_ob (deparch, op); 2576 dep = present_arch_in_ob (deparch, op);
2790 if (!dep) 2577 if (!dep)
2791 { 2578 {
2792 dep = arch_to_object (deparch); 2579 dep = deparch->instance ();
2793 insert_ob_in_ob (dep, op); 2580 insert_ob_in_ob (dep, op);
2794 } 2581 }
2795 lose_this_stat = 1; 2582 lose_this_stat = 1;
2796 if (settings.balanced_stat_loss) 2583 if (settings.balanced_stat_loss)
2797 { 2584 {
… …
2825 } 2612 }
2826 } 2613 }
2827 2614
2828 if (lose_this_stat) 2615 if (lose_this_stat)
2829 { 2616 {
2830 this_stat = get_attr_value (&(dep->stats), i); 2617 this_stat = get_attr_value (&dep->stats, i);
2831 /* We could try to do something clever like find another 2618 /* We could try to do something clever like find another
2832 * stat to reduce if this fails. But chances are, if 2619 * stat to reduce if this fails. But chances are, if
2833 * stats have been depleted to -50, all are pretty low 2620 * stats have been depleted to -50, all are pretty low
2834 * and should be roughly the same, so it shouldn't make a 2621 * and should be roughly the same, so it shouldn't make a
2835 * difference. 2622 * difference.
2836 */ 2623 */
2837 if (this_stat >= -50) 2624 if (this_stat >= -50)
2838 { 2625 {
2839 change_attr_value (&(dep->stats), i, -1); 2626 change_attr_value (&(dep->stats), i, -1);
2840 SET_FLAG (dep, FLAG_APPLIED); 2627 dep->set_flag (FLAG_APPLIED);
2841 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]); 2628 new_draw_info (NDI_UNIQUE, 0, op, lose_msg[i]);
2842 op->update_stats (); 2629 op->update_stats ();
2843 lost_a_stat = 1; 2630 lost_a_stat = 1;
2844 } 2631 }
2845 } 2632 }
2846 } 2633 }
2847 } 2634 }
2635
2848 /* If no stat lost, tell the player. */ 2636 /* If no stat lost, tell the player. */
2849 if (!lost_a_stat) 2637 if (!lost_a_stat)
2850 { 2638 {
2851 /* determine_god() seems to not work sometimes... why is this? 2639 /* determine_god() seems to not work sometimes... why is this?
2852 Should I be using something else? GD */ 2640 Should I be using something else? GD */
2853 const char *god = determine_god (op); 2641 shstr_tmp god = determine_god (op);
2854 2642
2855 if (god && (strcmp (god, "none"))) 2643 if (god != shstr_none)
2856 new_draw_info_format (NDI_UNIQUE, 0, op, "For a brief moment you feel the holy presence of %s protecting" " you.", god); 2644 deathtab << "For a brief moment you feel the holy presence of " << god << " protecting you.\r";
2857 else 2645 else
2858 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you feel a holy presence protecting you."); 2646 deathtab << "For a brief moment you feel a holy presence protecting you.\r";
2859 } 2647 }
2860#else 2648#else
2861 new_draw_info (NDI_UNIQUE, 0, op, "For a brief moment you" " feel a holy presence protecting you from losing yourself completely."); 2649 deathtab << "For a brief moment you feel a holy presence protecting you from losing yourself completely.";
2862#endif 2650#endif
2863 2651
2864 /* Put a gravestone up where the character 'almost' died. List the 2652 /* Put a gravestone up where the character 'almost' died. List the
2865 * exp loss on the stone. 2653 * exp loss on the stone.
2866 */ 2654 */
2867 tmp = arch_to_object (archetype::find ("gravestone")); 2655 tmp = archetype::find (shstr_gravestone)->instance ();
2868 sprintf (buf, "%s's gravestone", &op->name); 2656 tmp->name = format ("%s's gravestone", &op->name);
2869 tmp->name = buf; 2657 tmp->name_pl = format ("%s's gravestones", &op->name);
2870 sprintf (buf, "%s's gravestones", &op->name); 2658 tmp->msg = format ("T<RIP>\n\nHere rests the hero %s the %s,\rwho was killed\rby %s.\n",
2871 tmp->name_pl = buf; 2659 &op->name, op->contr->title, op->contr->killer_name ());
2872 sprintf (buf, "RIP\nHere rests the hero %s the %s,\n" "who was killed\n" "by %s.\n", &op->name, op->contr->title, op->contr->killer);
2873 tmp->msg = buf;
2874 tmp->x = op->x, tmp->y = op->y; 2660 tmp->x = op->x, tmp->y = op->y;
2875 insert_ob_in_map (tmp, op->map, NULL, 0); 2661 insert_ob_in_map (tmp, op->map, NULL, 0);
2876 2662
2877 /**************************************/ 2663 /**************************************/
2878 /* */ 2664 /* */
2879 /* Subtract the experience points, */ 2665 /* Subtract the experience points, */
2880 /* if we died cause of food, give us */
2881 /* food, and reset HP's... */
2882 /* */ 2666 /* */
2883 /**************************************/ 2667 /**************************************/
2884 2668
2885 /* remove any poisoning and confusion the character may be suffering. */
2886 /* restore player */
2887 at = archetype::find ("poisoning");
2888 tmp = present_arch_in_ob (at, op);
2889
2890 if (tmp)
2891 {
2892 tmp->destroy ();
2893 new_draw_info (NDI_UNIQUE, 0, op, "Your body feels cleansed");
2894 }
2895
2896 at = archetype::find ("confusion");
2897 tmp = present_arch_in_ob (at, op);
2898 if (tmp)
2899 {
2900 tmp->destroy ();
2901 new_draw_info (NDI_UNIQUE, 0, tmp, "Your mind feels clearer");
2902 }
2903
2904 cure_disease (op, 0); /* remove any disease */
2905
2906 /*add_exp(op, (op->stats.exp * -0.20)); */ 2669 /*add_exp(op, (op->stats.exp * -0.20)); */
2907 apply_death_exp_penalty (op); 2670 apply_death_exp_penalty (op);
2908 if (op->stats.food < 100)
2909 op->stats.food = 900;
2910 op->stats.hp = op->stats.maxhp;
2911 op->stats.sp = MAX (op->stats.sp, op->stats.maxsp);
2912 op->stats.grace = MAX (op->stats.grace, op->stats.maxgrace);
2913 2671
2914 /* 2672 /*
2915 * Check to see if the player is in a shop. IF so, then check to see if
2916 * the player has any unpaid items. If so, remove them and put them back 2673 * Check to see if the player has any unpaid items. If so, remove them
2917 * in the map. 2674 * and put them back in the map.
2918 */ 2675 */
2919 2676 op->drop_unpaid_items ();
2920 if (is_in_shop (op))
2921 remove_unpaid_objects (op->inv, op);
2922 2677
2923 /****************************************/ 2678 /****************************************/
2924 /* */ 2679 /* */
2925 /* Move player to his current respawn- */ 2680 /* Move player to his current respawn- */
2926 /* position (usually last savebed) */ 2681 /* position (usually last savebed) */
… …
2944 if (will_kill_again) 2699 if (will_kill_again)
2945 { 2700 {
2946 object *force; 2701 object *force;
2947 int at; 2702 int at;
2948 2703
2949 force = get_archetype (FORCE_NAME); 2704 force = archetype::get (FORCE_NAME);
2950 /* 50 ticks should be enough time for the spell to abate */ 2705 /* 50 ticks should be enough time for the spell to abate */
2951 force->speed = 0.1;
2952 force->speed_left = -5.0; 2706 force->speed_left = -5.f;
2953 SET_FLAG (force, FLAG_APPLIED); 2707 force->set_speed (0.1f);
2708 force->set_flag (FLAG_APPLIED);
2709
2954 for (at = 0; at < NROFATTACKS; at++) 2710 for (at = 0; at < NROFATTACKS; at++)
2955 if (will_kill_again & (1 << at)) 2711 if (will_kill_again & (1 << at))
2956 force->resist[at] = 100; 2712 force->resist[at] = 100;
2957 2713
2958 insert_ob_in_ob (force, op); 2714 insert_ob_in_ob (force, op);
2959 op->update_stats (); 2715 op->update_stats ();
2960
2961 } 2716 }
2962 2717
2963 new_draw_info (NDI_UNIQUE, 0, op, "YOU HAVE DIED."); 2718 op->contr->infobox (MSG_CHANNEL ("death"), deathtab);
2964} 2719}
2965 2720
2966void 2721static void
2967loot_object (object *op) 2722loot_object (object *op)
2968{ /* Grab and destroy some treasure */ 2723{ /* Grab and destroy some treasure */
2969 object *tmp, *tmp2, *next; 2724 object *tmp, *next;
2970 2725
2971 if (op->container) 2726 op->close_container (); /* close open sack first */
2972 esrv_apply_container (op, op->container); /* close open sack first */
2973 2727
2974 for (tmp = op->inv; tmp; tmp = next) 2728 for (tmp = op->inv; tmp; tmp = next)
2975 { 2729 {
2976 next = tmp->below; 2730 next = tmp->below;
2977 2731
2978 if (tmp->invisible) 2732 if (tmp->invisible)
2979 continue; 2733 continue;
2980 2734
2981 tmp->remove (); 2735 tmp->remove ();
2982 tmp->x = op->x, tmp->y = op->y; 2736 tmp->x = op->x, tmp->y = op->y;
2737
2983 if (tmp->type == CONTAINER) 2738 if (tmp->type == CONTAINER)
2984 { /* empty container to ground */ 2739 loot_object (tmp); /* empty container to ground */
2985 loot_object (tmp); 2740
2986 } 2741 if (!tmp->flag [FLAG_UNIQUE] && (tmp->flag [FLAG_STARTEQUIP] || tmp->flag [FLAG_NO_DROP] || !(rndm (3))))
2987 if (!QUERY_FLAG (tmp, FLAG_UNIQUE) && (QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_DROP) || !(rndm (3))))
2988 { 2742 {
2989 if (tmp->nrof > 1) 2743 if (tmp->nrof > 1)
2990 { 2744 {
2991 tmp2 = get_split_ob (tmp, 1 + RANDOM () % (tmp->nrof - 1)); 2745 tmp->decrease (rndm (1, tmp->nrof - 1));
2992 tmp2->destroy ();
2993 insert_ob_in_map (tmp, op->map, NULL, 0); 2746 insert_ob_in_map (tmp, op->map, NULL, 0);
2994 } 2747 }
2995 else 2748 else
2996 tmp->destroy (); 2749 tmp->destroy ();
2997 } 2750 }
… …
3003/* 2756/*
3004 * fix_weight(): Check recursively the weight of all players, and fix 2757 * fix_weight(): Check recursively the weight of all players, and fix
3005 * what needs to be fixed. Refresh windows and fix speed if anything 2758 * what needs to be fixed. Refresh windows and fix speed if anything
3006 * was changed. 2759 * was changed.
3007 */ 2760 */
3008
3009void 2761void
3010fix_weight (void) 2762fix_weight ()
3011{ 2763{
3012 for_all_players (pl) 2764 for_all_players (pl)
3013 { 2765 {
3014 int old = pl->ob->carrying, sum = sum_weight (pl->ob); 2766 weight_t old = pl->ob->carrying;
3015 2767
3016 if (old == sum) 2768 pl->ob->update_weight ();
3017 continue; 2769
2770 if (old != pl->ob->carrying)
2771 {
3018 pl->ob->update_stats (); 2772 pl->ob->update_stats ();
3019 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, old, sum); 2773 LOG (llevDebug, "Fixed inventory in %s (%d -> %d)\n", &pl->ob->name, (int)old, (int)pl->ob->carrying);
2774 }
3020 } 2775 }
3021} 2776}
3022 2777
3023void 2778void
3024fix_luck (void) 2779fix_luck ()
3025{ 2780{
3026 for_all_players (pl) 2781 for_all_players (pl)
3027 if (!pl->ob->contr->ns->state) 2782 if (!pl->ob->contr->ns->state)
3028 pl->ob->change_luck (0); 2783 pl->ob->change_luck (0);
3029} 2784}
… …
3066} 2821}
3067 2822
3068void 2823void
3069make_visible (object *op) 2824make_visible (object *op)
3070{ 2825{
3071 op->hide = 0; 2826 op->flag [FLAG_HIDDEN] = 0;
3072 op->invisible = 0; 2827 op->invisible = 0;
2828
3073 if (op->type == PLAYER) 2829 if (op->type == PLAYER)
3074 { 2830 {
3075 op->contr->tmp_invis = 0; 2831 op->contr->tmp_invis = 0;
3076 op->contr->invis_race = 0; 2832 op->contr->invis_race = 0;
3077 } 2833 }
2834
3078 update_object (op, UP_OBJ_FACE); 2835 update_object (op, UP_OBJ_CHANGE);
3079} 2836}
3080 2837
3081int 2838int
3082is_true_undead (object *op) 2839is_true_undead (object *op)
3083{ 2840{
3084 object *tmp = NULL; 2841 if (op->arch->flag [FLAG_UNDEAD])
3085
3086 if (QUERY_FLAG (&op->arch->clone, FLAG_UNDEAD))
3087 return 1; 2842 return 1;
3088 2843
3089 return 0; 2844 return 0;
3090} 2845}
3091 2846
3092/* look at the surrounding terrain to determine 2847/* look at the surrounding terrain to determine
3093 * the hideability of this object. Positive levels 2848 * the hideability of this object. Positive levels
3094 * indicate greater hideability. 2849 * indicate greater hideability.
3095 */ 2850 */
3096
3097int 2851int
3098hideability (object *ob) 2852hideability (object *ob)
3099{ 2853{
3100 int i, level = 0, mflag; 2854 int i, level = 0, mflag;
3101 sint16 x, y; 2855 sint16 x, y;
3102 2856
3103 if (!ob || !ob->map) 2857 if (!ob || !ob->map)
3104 return 0; 2858 return 0;
3105 2859
3106 /* so, on normal lighted maps, its hard to hide */ 2860 /* so, on normal lighted maps, its hard to hide */
3107 level = ob->map->darkness - 2; 2861 level = ob->map->darklevel () - 2;
3108 2862
3109 /* this also picks up whether the object is glowing. 2863 /* this also picks up whether the object is glowing.
3110 * If you carry a light on a non-dark map, its not 2864 * If you carry a light on a non-dark map, its not
3111 * as bad as carrying a light on a pitch dark map */ 2865 * as bad as carrying a light on a pitch dark map */
3112 if (has_carried_lights (ob)) 2866 if (ob->has_carried_lights ())
3113 level = -(10 + (2 * ob->map->darkness)); 2867 level = -(10 + (2 * ob->map->darklevel ()));
3114 2868
3115 /* scan through all nearby squares for terrain to hide in */ 2869 /* scan through all nearby squares for terrain to hide in */
3116 for (i = 0, x = ob->x, y = ob->y; i < 9; i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i]) 2870 for (i = 0, x = ob->x, y = ob->y;
2871 i <= SIZEOFFREE1;
2872 i++, x = ob->x + freearr_x[i], y = ob->y + freearr_y[i])
3117 { 2873 {
3118 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL); 2874 mflag = get_map_flags (ob->map, NULL, x, y, NULL, NULL);
3119 if (mflag & P_OUT_OF_MAP) 2875 if (mflag & P_OUT_OF_MAP)
3120 {
3121 continue; 2876 continue;
3122 } 2877
3123 if (mflag & P_BLOCKSVIEW) /* something to hide near! */ 2878 if (mflag & P_BLOCKSVIEW) /* something to hide near! */
3124 level += 2; 2879 level += 2;
3125 else /* open terrain! */ 2880 else /* open terrain! */
3126 level -= 1; 2881 level -= 1;
3127 } 2882 }
… …
3135/* For Hidden creatures - a chance of becoming 'unhidden' 2890/* For Hidden creatures - a chance of becoming 'unhidden'
3136 * every time they move - as we subtract off 'invisibility' 2891 * every time they move - as we subtract off 'invisibility'
3137 * AND, for players, if they move into a ridiculously unhideable 2892 * AND, for players, if they move into a ridiculously unhideable
3138 * spot (surrounded by clear terrain in broad daylight). -b.t. 2893 * spot (surrounded by clear terrain in broad daylight). -b.t.
3139 */ 2894 */
3140
3141void 2895void
3142do_hidden_move (object *op) 2896do_hidden_move (object *op)
3143{ 2897{
3144 int hide = 0, num = random_roll (0, 19, op, PREFER_LOW); 2898 int hide = 0;
3145 object *skop;
3146 2899
3147 if (!op || !op->map) 2900 if (!op || !op->map)
3148 return; 2901 return;
3149 2902
3150 skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING); 2903 object *skop = find_obj_by_type_subtype (op, SKILL, SK_HIDING);
2904 int num = random_roll (0, 19, op, PREFER_LOW);
3151 2905
3152 /* its *extremely* hard to run and sneak/hide at the same time! */ 2906 /* its *extremely* hard to run and sneak/hide at the same time! */
3153 if (op->type == PLAYER && op->contr->run_on) 2907 if (op->type == PLAYER && op->contr->run_on)
3154 if (!skop || num >= skop->level) 2908 if (!skop || num >= skop->level)
3155 { 2909 {
… …
3165 num -= hide; 2919 num -= hide;
3166 2920
3167 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0)) 2921 if ((op->type == PLAYER && hide < -10) || ((op->invisible -= num) <= 0))
3168 { 2922 {
3169 make_visible (op); 2923 make_visible (op);
2924
3170 if (op->type == PLAYER) 2925 if (op->type == PLAYER)
3171 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!"); 2926 new_draw_info (NDI_UNIQUE, 0, op, "You moved out of hiding! You are visible!");
3172 } 2927 }
3173 else if (op->type == PLAYER && skop) 2928 else if (op->type == PLAYER && skop)
3174 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0); 2929 change_exp (op, calc_skill_exp (op, NULL, skop), skop->skill, 0);
… …
3189 2944
3190 if (who->type == PLAYER) 2945 if (who->type == PLAYER)
3191 player = 1; 2946 player = 1;
3192 2947
3193 else 2948 else
3194 friendly = QUERY_FLAG (who, FLAG_FRIENDLY); 2949 friendly = who->flag [FLAG_FRIENDLY];
3195 2950
3196 /* search adjacent squares */ 2951 /* search adjacent squares */
3197 for (i = 1; i < 9; i++) 2952 for (i = 1; i < 9; i++)
3198 { 2953 {
3199 x = who->x + freearr_x[i]; 2954 x = who->x + freearr_x[i];
… …
3208 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y))) 2963 if (OB_TYPE_MOVE_BLOCK (who, GET_MAP_MOVE_BLOCK (m, x, y)))
3209 continue; 2964 continue;
3210 2965
3211 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 2966 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
3212 { 2967 {
3213 if ((player ||friendly) &&QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_UNAGGRESSIVE)) 2968 if ((player ||friendly) &&tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_UNAGGRESSIVE])
3214 return 1; 2969 return 1;
3215 else if (tmp->type == PLAYER) 2970 else if (tmp->type == PLAYER)
3216 {
3217 /*don't let a hidden DM prevent you from hiding */
3218 if (!QUERY_FLAG (tmp, FLAG_WIZ) || tmp->contr->hidden == 0)
3219 return 1; 2971 return 1;
3220 }
3221 } 2972 }
3222 } 2973 }
3223 return 0; 2974 return 0;
3224} 2975}
3225 2976
3226/* check the player los field for viewability of the 2977/* check the player los field for viewability of the
3227 * object op. This function works fine for monsters, 2978 * object op. This function works fine for monsters,
3228 * but we dont worry if the object isnt the top one in 2979 * but we dont worry if the object isnt the top one in
3229 * a pile (say a coin under a table would return "viewable" 2980 * a pile (say a coin under a table would return "viewable"
3230 * by this routine). Another question, should we be 2981 * by this routine). Another question, should we be
3231 * concerned with the direction the player is looking 2982 * concerned with the direction the player is looking
3232 * in? Realistically, most of use cant see stuff behind 2983 * in? Realistically, most of us can't see stuff behind
3233 * our backs...on the other hand, does the "facing" direction 2984 * our backs...on the other hand, does the "facing" direction
3234 * imply the way your head, or body is facing? Its possible 2985 * imply the way your head, or body is facing? It's possible
3235 * for them to differ. Sigh, this fctn could get a bit more complex. 2986 * for them to differ. Sigh, this fctn could get a bit more complex.
3236 * -b.t. 2987 * -b.t.
3237 * This function is now map tiling safe. 2988 * This function is now map tiling safe.
3238 */ 2989 */
3239
3240int 2990int
3241player_can_view (object *pl, object *op) 2991player_can_view (object *pl, object *op)
3242{ 2992{
3243 rv_vector rv; 2993 rv_vector rv;
3244 int dx, dy; 2994 int dx, dy;
… …
3256 3006
3257 get_rangevector (pl, op, &rv, 0x1); 3007 get_rangevector (pl, op, &rv, 0x1);
3258 3008
3259 /* starting with the 'head' part, lets loop 3009 /* starting with the 'head' part, lets loop
3260 * through the object and find if it has any 3010 * through the object and find if it has any
3261 * part that is in the los array but isnt on 3011 * part that is in the los array but isn't on
3262 * a blocked los square. 3012 * a blocked los square.
3263 * we use the archetype to figure out offsets. 3013 * we use the archetype to figure out offsets.
3264 */ 3014 */
3265 while (op) 3015 while (op)
3266 { 3016 {
3267 dx = rv.distance_x + op->arch->clone.x; 3017 dx = rv.distance_x + op->arch->x;
3268 dy = rv.distance_y + op->arch->clone.y; 3018 dy = rv.distance_y + op->arch->y;
3269 3019
3270 /* only the viewable area the player sees is updated by LOS 3020 if (pl->contr->blocked_los (dx, dy) != LOS_BLOCKED)
3271 * code, so we need to restrict ourselves to that range of values
3272 * for any meaningful values.
3273 */
3274 if (FABS (dx) <= (pl->contr->ns->mapx / 2) &&
3275 FABS (dy) <= (pl->contr->ns->mapy / 2) &&
3276 !pl->contr->blocked_los[dx + (pl->contr->ns->mapx / 2)][dy + (pl->contr->ns->mapy / 2)])
3277 return 1; 3021 return 1;
3022
3278 op = op->more; 3023 op = op->more;
3279 } 3024 }
3280 return 0;
3281}
3282 3025
3283/* routine for both players and monsters. We call this when
3284 * there is a possibility for our action distrubing our hiding
3285 * place or invisiblity spell. Artefact invisiblity is not
3286 * effected by this. If we arent invisible to begin with, we
3287 * return 0.
3288 */
3289int
3290action_makes_visible (object *op)
3291{
3292
3293 if (op->invisible && QUERY_FLAG (op, FLAG_ALIVE))
3294 {
3295 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
3296 return 0;
3297
3298 if (op->contr && op->contr->tmp_invis == 0)
3299 return 0;
3300
3301 /* If monsters, they should become visible */
3302 if (op->hide || !op->contr || (op->contr && op->contr->tmp_invis))
3303 {
3304 new_draw_info_format (NDI_UNIQUE, 0, op, "You become %s!", op->hide ? "unhidden" : "visible");
3305 return 1;
3306 }
3307 }
3308 return 0; 3026 return 0;
3309} 3027}
3310 3028
3311/* op_on_battleground - checks if the given object op (usually 3029/* op_on_battleground - checks if the given object op (usually
3312 * a player) is standing on a valid battleground-tile, 3030 * a player) is standing on a valid battleground-tile,
… …
3317 * Default is to do the same as before, so only people wanting to have different points need worry about this 3035 * Default is to do the same as before, so only people wanting to have different points need worry about this
3318 */ 3036 */
3319int 3037int
3320op_on_battleground (object *op, int *x, int *y) 3038op_on_battleground (object *op, int *x, int *y)
3321{ 3039{
3322 object *tmp;
3323
3324 /* A battleground-tile needs the following attributes to be valid: 3040 /* A battleground-tile needs the following attributes to be valid:
3325 * is_floor 1 (has to be the FIRST floor beneath the player's feet), 3041 * is_floor 1 (has to be the FIRST floor beneath the player's feet),
3326 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND) 3042 * name="battleground", no_pick 1, type=58 (type BATTLEGROUND)
3327 * and the exit-coordinates sp/hp must both be > 0. 3043 * and the exit-coordinates sp/hp must both be > 0.
3328 * => The intention here is to prevent abuse of the battleground- 3044 * => The intention here is to prevent abuse of the battleground-
3329 * feature (like pickable or hidden battleground tiles). */ 3045 * feature (like pickable or hidden battleground tiles). */
3330 for (tmp = op->below; tmp != NULL; tmp = tmp->below) 3046 for (object *tmp = op->below; tmp; tmp = tmp->below)
3331 { 3047 {
3332 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 3048 if (tmp->flag [FLAG_IS_FLOOR])
3333 { 3049 {
3334 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && 3050 if (tmp->flag [FLAG_NO_PICK]
3335 strcmp (tmp->name, "battleground") == 0 && tmp->type == BATTLEGROUND && EXIT_X (tmp) && EXIT_Y (tmp)) 3051 && tmp->type == BATTLEGROUND
3052 && tmp->name == shstr_battleground
3053 && EXIT_X (tmp) && EXIT_Y (tmp))
3336 { 3054 {
3337 /*before we assign the exit, check if this is a teambattle */ 3055 /* before we assign the exit, check if this is a teambattle */
3338 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp)) 3056 if (EXIT_ALT_X (tmp) && EXIT_ALT_Y (tmp) && EXIT_PATH (tmp))
3339 {
3340 object *invtmp;
3341
3342 for (invtmp = op->inv; invtmp != NULL; invtmp = invtmp->below) 3057 for (object *invtmp = op->inv; invtmp; invtmp = invtmp->below)
3058 if (invtmp->type == FORCE && invtmp->slaying && tmp->slaying == invtmp->slaying)
3343 { 3059 {
3344 if (invtmp->type == FORCE && invtmp->slaying && !strcmp (EXIT_PATH (tmp), invtmp->slaying))
3345 {
3346 if (x != NULL && y != NULL) 3060 if (x && y)
3347 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp); 3061 *x = EXIT_ALT_X (tmp), *y = EXIT_ALT_Y (tmp);
3062
3348 return 1; 3063 return 1;
3349 }
3350 } 3064 }
3351 } 3065
3352 if (x != NULL && y != NULL) 3066 if (x && y)
3353 *x = EXIT_X (tmp), *y = EXIT_Y (tmp); 3067 *x = EXIT_X (tmp), *y = EXIT_Y (tmp);
3068
3354 return 1; 3069 return 1;
3355 } 3070 }
3356 } 3071 }
3357 } 3072 }
3073
3358 /* If we got here, did not find a battleground */ 3074 /* If we got here, did not find a battleground */
3359 return 0; 3075 return 0;
3360} 3076}
3361 3077
3362/* 3078/*
… …
3378 char buf[MAX_BUF]; /* tmp. string buffer */ 3094 char buf[MAX_BUF]; /* tmp. string buffer */
3379 int i = 0, j = 0; 3095 int i = 0, j = 0;
3380 3096
3381 /* get the appropriate treasurelist */ 3097 /* get the appropriate treasurelist */
3382 if (atnr == ATNR_FIRE) 3098 if (atnr == ATNR_FIRE)
3383 trlist = find_treasurelist ("dragon_ability_fire"); 3099 trlist = treasurelist::find (shstr_dragon_ability_fire);
3384 else if (atnr == ATNR_COLD) 3100 else if (atnr == ATNR_COLD)
3385 trlist = find_treasurelist ("dragon_ability_cold"); 3101 trlist = treasurelist::find (shstr_dragon_ability_cold);
3386 else if (atnr == ATNR_ELECTRICITY) 3102 else if (atnr == ATNR_ELECTRICITY)
3387 trlist = find_treasurelist ("dragon_ability_elec"); 3103 trlist = treasurelist::find (shstr_dragon_ability_elec);
3388 else if (atnr == ATNR_POISON) 3104 else if (atnr == ATNR_POISON)
3389 trlist = find_treasurelist ("dragon_ability_poison"); 3105 trlist = treasurelist::find (shstr_dragon_ability_poison);
3390 3106
3391 if (trlist == NULL || who->type != PLAYER) 3107 if (trlist == NULL || who->type != PLAYER)
3392 return; 3108 return;
3393 3109
3394 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++); 3110 for (i = 0, tr = trlist->items; tr != NULL && i < level - 1; tr = tr->next, i++);
… …
3398 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */ 3114 /* LOG(llevDebug, "-> no more treasure for %s\n", change_resist_msg[atnr]); */
3399 return; 3115 return;
3400 } 3116 }
3401 3117
3402 /* everything seems okay - now bring on the gift: */ 3118 /* everything seems okay - now bring on the gift: */
3403 item = &(tr->item->clone); 3119 item = tr->item;
3404 3120
3405 if (item->type == SPELL) 3121 if (item->type == SPELL)
3406 { 3122 {
3407 if (check_spell_known (who, item->name)) 3123 if (check_spell_known (who, item->name))
3408 return; 3124 return;
… …
3467 { 3183 {
3468 /* forces in the treasurelist can alter the player's stats */ 3184 /* forces in the treasurelist can alter the player's stats */
3469 object *skin; 3185 object *skin;
3470 3186
3471 /* first get the dragon skin force */ 3187 /* first get the dragon skin force */
3472 shstr_cmp dragon_skin_force ("dragon_skin_force");
3473 for (skin = who->inv; skin && !(skin->arch->name == dragon_skin_force); skin = skin->below) 3188 for (skin = who->inv; skin && !(skin->arch->archname == shstr_dragon_skin_force); skin = skin->below)
3474 ; 3189 ;
3475 3190
3476 if (!skin) 3191 if (!skin)
3477 return; 3192 return;
3478 3193
… …
3492 else 3207 else
3493 j = 1; 3208 j = 1;
3494 strcat (buf, spellpathnames[i]); 3209 strcat (buf, spellpathnames[i]);
3495 } 3210 }
3496 } 3211 }
3212
3497 strcat (buf, "."); 3213 strcat (buf, ".");
3498 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf); 3214 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, buf);
3499 } 3215 }
3500 3216
3501 /* evtl. adding flags: */ 3217 /* evtl. adding flags: */
3502 if (QUERY_FLAG (item, FLAG_XRAYS)) 3218 if (item->flag [FLAG_XRAYS])
3503 SET_FLAG (skin, FLAG_XRAYS); 3219 skin->set_flag (FLAG_XRAYS);
3504 if (QUERY_FLAG (item, FLAG_STEALTH)) 3220 if (item->flag [FLAG_STEALTH])
3505 SET_FLAG (skin, FLAG_STEALTH); 3221 skin->set_flag (FLAG_STEALTH);
3506 if (QUERY_FLAG (item, FLAG_SEE_IN_DARK)) 3222 if (item->flag [FLAG_SEE_IN_DARK])
3507 SET_FLAG (skin, FLAG_SEE_IN_DARK); 3223 skin->set_flag (FLAG_SEE_IN_DARK);
3508 3224
3509 /* print message if there is one */ 3225 /* print message if there is one */
3510 if (item->msg != NULL) 3226 if (item->msg != NULL)
3511 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg); 3227 new_draw_info (NDI_UNIQUE | NDI_BLUE, 0, who, item->msg);
3512 } 3228 }
3513 else 3229 else
3514 { 3230 {
3515 /* generate misc. treasure */ 3231 /* generate misc. treasure */
3516 tmp = arch_to_object (tr->item); 3232 tmp = tr->item->instance ();
3517 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp)); 3233 new_draw_info_format (NDI_UNIQUE | NDI_BLUE, 0, who, "You gained %s", query_short_name (tmp));
3518 tmp = insert_ob_in_ob (tmp, who); 3234 who->insert (tmp);
3519 if (who->type == PLAYER)
3520 esrv_send_item (who, tmp);
3521 } 3235 }
3522} 3236}
3523 3237
3524/** 3238//-GPL
3525 * Unready an object for a player. This function does nothing if the object was 3239
3526 * not readied. 3240sint8
3527 */ 3241player::darkness_at (maptile *map, int x, int y) const
3242{
3243 if (!ns)
3244 return LOS_BLOCKED;
3245
3246 int dx, dy;
3247 if (!adjacent_map (map, ns->current_map, &dx, &dy))
3248 return LOS_BLOCKED;
3249
3250 x += dx - ns->current_x;
3251 y += dy - ns->current_y;
3252
3253 return blocked_los (x, y);
3254}
3255
3528void 3256void
3529player_unready_range_ob (player *pl, object *ob) 3257player::infobox (const char *title, const char *msg, int color)
3530{ 3258{
3531 for (rangetype i = (rangetype) 0; i < range_size; i = (rangetype) ((int) i + 1)) 3259 send_msg (color | NDI_DEF | NDI_REPLY | NDI_CLEAR, title, msg);
3532 if (pl->ranges[i] == ob)
3533 {
3534 pl->ranges[i] = 0;
3535 if (pl->shoottype == i)
3536 pl->shoottype = range_none;
3537 }
3538} 3260}
3261
3262void
3263player::statusmsg (const char *msg, int color)
3264{
3265 send_msg (color | NDI_REPLY, INFO_CHANNEL, msg);
3266}
3267
3268void
3269player::failmsg (const char *msg, int color)
3270{
3271 play_sound (sound_find ("generic_failure"));
3272 statusmsg (msg, color);
3273}
3274
3275void
3276object::failmsgf (const char *format, ...)
3277{
3278 if (!contr)
3279 return;
3280
3281 va_list ap;
3282 va_start (ap, format);
3283 contr->failmsg (vformat (format, ap));
3284 va_end (ap);
3285}
3286
3287void
3288player::failmsgf (const char *format, ...)
3289{
3290 va_list ap;
3291 va_start (ap, format);
3292 failmsg (vformat (format, ap));
3293 va_end (ap);
3294}
3295

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines