ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/skill_util.C
(Generate patch)

Comparing deliantra/server/server/skill_util.C (file contents):
Revision 1.13 by root, Sat Sep 16 22:24:13 2006 UTC vs.
Revision 1.67 by root, Thu Sep 25 04:09:57 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copryight (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23 23
24/* Created July 95 to separate skill utilities from actual skills -b.t. */ 24/* Created July 95 to separate skill utilities from actual skills -b.t. */
25 25
26/* Reconfigured skills code to allow linking of skills to experience 26/* Reconfigured skills code to allow linking of skills to experience
27 * categories. This is done solely through the init_new_exp_system() fctn. 27 * categories. This is done solely through the init_new_exp_system() fctn.
39 39
40/* #define SKILL_UTIL_DEBUG */ 40/* #define SKILL_UTIL_DEBUG */
41 41
42#include <global.h> 42#include <global.h>
43#include <object.h> 43#include <object.h>
44#ifndef __CEXTRACT__
45# include <sproto.h> 44#include <sproto.h>
46#endif
47#include <living.h> /* for defs of STR,CON,DEX,etc. -b.t. */ 45#include <living.h> /* for defs of STR,CON,DEX,etc. -b.t. */
48#include <spells.h> 46#include <spells.h>
49 47
50/* Table of unarmed attack skills. Terminated by -1. This 48const uint8_t skill_flags[NUM_SKILLS] = {
51 * is also the list that we should try to use skills when 49 0, // SK_NONE
52 * automatically applying one for the player. 50# define def(uc, flags) flags,
53 * Note it is hardcoded in the skill_util.c that dragons always 51# include "skillinc.h"
54 * want clawing if possible. 52# undef def
55 */
56static uint8 unarmed_skills[] = {
57 SK_KARATE,
58 SK_CLAWING,
59 SK_FLAME_TOUCH,
60 SK_SPARK_TOUCH,
61 SK_SHIVER,
62 SK_ACID_SPLASH,
63 SK_POISON_NAIL,
64 SK_PUNCHING,
65 (uint8)-1
66}; 53};
67 54
68static int attack_hth (object *pl, int dir, const char *string, object *skill); 55static int attack_hth (object *pl, int dir, const char *string, object *skill);
69static int attack_melee_weapon (object *op, int dir, const char *string, object *skill); 56static int attack_melee_weapon (object *op, int dir, const char *string, object *skill);
70 57
73 * subtypes. 60 * subtypes.
74 */ 61 */
75void 62void
76init_skills (void) 63init_skills (void)
77{ 64{
78 int i; 65 for_all_archetypes (at)
79 archetype *at;
80
81 for (at = first_archetype; at != NULL; at = at->next)
82 if (at->clone.type == SKILL) 66 if (at->type == SKILL)
83 { 67 {
84 if (skill_names[at->clone.subtype] != NULL) 68 if (skill_names[at->subtype])
85 LOG (llevError, "init_skills: multiple skill using same subtype %d, %s, %s\n", 69 LOG (llevError, "init_skills: multiple skill using same subtype %d, %s, %s\n",
86 at->clone.subtype, &skill_names[at->clone.subtype], &at->clone.skill); 70 at->subtype, &skill_names[at->subtype], &at->skill);
87 else 71 else
88 skill_names[at->clone.subtype] = at->clone.skill; 72 skill_names[at->subtype] = at->skill;
89 } 73 }
90 74
91 /* This isn't really an error if there is no skill subtype set, but 75 /* This isn't really an error if there is no skill subtype set, but
92 * checking for this may catch some user errors. 76 * checking for this may catch some user errors.
93 */ 77 */
94 for (i = 1; i < NUM_SKILLS; i++) 78 for (int i = 1; i < NUM_SKILLS; i++)
95 {
96 if (!skill_names[i]) 79 if (!skill_names[i])
97 LOG (llevError, "init_skills: skill subtype %d doesn't have a name?\n", i); 80 LOG (llevError, "init_skills: skill subtype %d doesn't have a name?\n", i);
98 }
99} 81}
100
101 82
102/* This function goes through the player inventory and sets 83/* This function goes through the player inventory and sets
103 * up the last_skills[] array in the player object. 84 * up the last_skills[] array in the player object.
104 * the last_skills[] is used to more quickly lookup skills - 85 * the last_skills[] is used to more quickly lookup skills -
105 * mostly used for sending exp. 86 * mostly used for sending exp.
106 */ 87 */
107void 88void
108link_player_skills (object *op) 89player::link_skills ()
109{ 90{
110 object *tmp; 91 for (int i = 0; i < NUM_SKILLS; ++i)
92 last_skill_ob [i] = 0;
111 93
112 for (tmp = op->inv; tmp; tmp = tmp->below) 94 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
113 {
114 if (tmp->type == SKILL) 95 if (tmp->type == SKILL)
96 {
97 assert (IN_RANGE_EXC (tmp->subtype, 0, NUM_SKILLS));
98
99 if (last_skill_ob [tmp->subtype] != tmp)
115 { 100 {
116 /* This is really a warning, hence no else below */ 101 /* This is really a warning, hence no else below */
117 if (op->contr->last_skill_ob[tmp->subtype] && op->contr->last_skill_ob[tmp->subtype] != tmp) 102 if (last_skill_ob [tmp->subtype])
118 {
119 LOG (llevError, "Multiple skills with the same subtype? %s, %s\n", 103 LOG (llevError, "Multiple skills with the same subtype? %s, %s\n",
120 &op->contr->last_skill_ob[tmp->subtype]->skill, &tmp->skill); 104 &last_skill_ob [tmp->subtype]->skill, &tmp->skill);
105
106 last_skill_ob [tmp->subtype] = tmp;
107 if (ns)
108 ns->last_skill_exp [tmp->subtype] = -1;
121 } 109 }
122 if (tmp->subtype >= NUM_SKILLS)
123 {
124 LOG (llevError, "Invalid subtype number %d (range 0-%d)\n", tmp->subtype, NUM_SKILLS);
125 }
126 else
127 {
128 op->contr->last_skill_ob[tmp->subtype] = tmp;
129 op->contr->last_skill_exp[tmp->subtype] = -1;
130 }
131 } 110 }
132 } 111}
112
113static object *
114find_skill (object *who, const shstr &sh)
115{
116 for (object *tmp = who->inv; tmp; tmp = tmp->below)
117 if (tmp->skill == sh && tmp->type == SKILL)
118 return tmp;
119
120 return 0;
133} 121}
134 122
135/* This returns the skill pointer of the given name (the 123/* This returns the skill pointer of the given name (the
136 * one that accumlates exp, has the level, etc). 124 * one that accumulates exp, has the level, etc).
137 * 125 *
138 * It is presumed that the player will be needing to actually 126 * It is presumed that the player will be needing to actually
139 * use the skill, so thus if use of the skill requires a skill 127 * use the skill, so thus if use of the skill requires a skill
140 * tool, this code will equip it. 128 * tool, this code will equip it.
141 */ 129 */
142object * 130object *
143find_skill_by_name (object *who, const char *name) 131find_skill_by_name (object *who, const shstr &sh)
144{ 132{
145 object *skill = NULL, *skill_tool = NULL, *tmp; 133 object *skill_tool = 0;
146 134
147 if (!name)
148 return NULL;
149
150 /* We make sure the length of the string in the object is greater
151 * in length than the passed string. Eg, if we have a skill called
152 * 'hi', we don't want to match if the user passed 'high'
153 */
154 for (tmp = who->inv; tmp != NULL; tmp = tmp->below) 135 for (object *tmp = who->inv; tmp; tmp = tmp->below)
136 if (tmp->skill == sh)
155 { 137 {
156 if (tmp->type == SKILL && !strncasecmp (name, tmp->skill, strlen (name)) && (size_t) strlen (tmp->skill) >= strlen (name)) 138 if (tmp->type == SKILL && (tmp->flag [FLAG_CAN_USE_SKILL] || tmp->flag [FLAG_APPLIED]))
157 skill = tmp; 139 /* If this is a skill that can be used without applying tool, return it */
158 140 return splay (tmp);
159 /* Try to find appropriate skilltool. If the player has one already 141 /* Try to find appropriate skilltool. If the player has one already
160 * applied, we try to keep using that one. 142 * applied, we try to keep using that one.
161 */ 143 */
162 else if (tmp->type == SKILL_TOOL && !strncasecmp (name, tmp->skill, strlen (name)) && (size_t) strlen (tmp->skill) >= strlen (name)) 144 else if (tmp->type == SKILL_TOOL && !skill_tool)
163 {
164 if (QUERY_FLAG (tmp, FLAG_APPLIED))
165 skill_tool = tmp; 145 skill_tool = tmp;
166 else if (!skill_tool || !QUERY_FLAG (skill_tool, FLAG_APPLIED))
167 skill_tool = tmp;
168 } 146 }
169 } 147
170 /* If this is a skill that can be used without a tool, return it */ 148 if (!skill_tool)
171 if (skill && QUERY_FLAG (skill, FLAG_CAN_USE_SKILL))
172 return skill; 149 return 0;
173 150
174 /* Player has a tool to use the skill. IF not applied, apply it - 151 /* Player has a tool to use the skill. If not applied, apply it -
175 * if not successful, return null. If they do have the skill tool 152 * if not successful, return null. If they do have the skill tool
176 * but not the skill itself, give it to them. 153 * but not the skill itself, give it to them.
177 */ 154 */
178 if (skill_tool) 155 object *skill = find_skill (who, skill_tool->skill);
179 { 156
180 if (!QUERY_FLAG (skill_tool, FLAG_APPLIED))
181 {
182 if (apply_special (who, skill_tool, 0))
183 return NULL;
184 }
185 if (!skill) 157 if (!skill)
186 {
187 skill = give_skill_by_name (who, skill_tool->skill); 158 skill = give_skill_by_name (who, skill_tool->skill);
188 link_player_skills (who); 159
189 } 160 if (!skill_tool->flag [FLAG_APPLIED])
161 if (apply_special (who, splay (skill_tool), AP_APPLY | AP_NO_READY))
190 return skill; 162 return 0;
191 } 163
164 return splay (skill);
165}
166
167object *
168find_skill_by_name (object *who, const char *name)
169{
170 if (!name)
171 return 0;
172
173 for (object *tmp = who->inv; tmp; tmp = tmp->below)
174 if ((tmp->type == SKILL || tmp->type == SKILL_TOOL)
175 && tmp->skill.begins_with (name))
176 if (object *skop = find_skill_by_name (who, tmp->skill))
177 return skop;
178
192 return NULL; 179 return 0;
193} 180}
194
195 181
196/* This returns the skill pointer of the given name (the 182/* This returns the skill pointer of the given name (the
197 * one that accumlates exp, has the level, etc). 183 * one that accumulates exp, has the level, etc).
198 * 184 *
199 * It is presumed that the player will be needing to actually 185 * It is presumed that the player will be needing to actually
200 * use the skill, so thus if use of the skill requires a skill 186 * use the skill, so thus if use of the skill requires a skill
201 * tool, this code will equip it. 187 * tool, this code will equip it.
202 * 188 *
205 * this replaces find_skill. 191 * this replaces find_skill.
206 */ 192 */
207object * 193object *
208find_skill_by_number (object *who, int skillno) 194find_skill_by_number (object *who, int skillno)
209{ 195{
210 object *skill = NULL, *skill_tool = NULL, *tmp;
211
212 if (skillno < 1 || skillno >= NUM_SKILLS)
213 return NULL;
214
215 for (tmp = who->inv; tmp != NULL; tmp = tmp->below) 196 for (object *tmp = who->inv; tmp; tmp = tmp->below)
216 {
217 if (tmp->type == SKILL && tmp->subtype == skillno) 197 if (tmp->type == SKILL && tmp->subtype == skillno)
218 skill = tmp; 198 if (object *skop = find_skill_by_name (who, tmp->skill))
219
220 /* Try to find appropriate skilltool. If the player has one already
221 * applied, we try to keep using that one.
222 */
223 else if (tmp->type == SKILL_TOOL && tmp->subtype == skillno)
224 {
225 if (QUERY_FLAG (tmp, FLAG_APPLIED))
226 skill_tool = tmp;
227 else if (!skill_tool || !QUERY_FLAG (skill_tool, FLAG_APPLIED))
228 skill_tool = tmp;
229 }
230 }
231 /* If this is a skill that can be used without a tool, return it */
232 if (skill && QUERY_FLAG (skill, FLAG_CAN_USE_SKILL))
233 return skill;
234
235 /* Player has a tool to use the skill. IF not applied, apply it -
236 * if not successful, return null. If they do have the skill tool
237 * but not the skill itself, give it to them.
238 */
239 if (skill_tool)
240 {
241 if (!QUERY_FLAG (skill_tool, FLAG_APPLIED))
242 {
243 if (apply_special (who, skill_tool, 0))
244 return NULL;
245 }
246 if (!skill)
247 {
248 skill = give_skill_by_name (who, skill_tool->skill);
249 link_player_skills (who);
250 }
251 return skill; 199 return skop;
252 } 200
253 return NULL; 201 return 0;
254} 202}
255 203
256/* This changes the objects skill to new_skill. 204/* This changes the objects chosen_skill to new_skill.
257 * note that this function doesn't always need to get used -
258 * you can now add skill exp to the player without the chosen_skill being
259 * set. This function is of most interest to players to update
260 * the various range information.
261 * if new_skill is null, this just unapplies the skill.
262 * flag has the current meaning:
263 * 0x1: If set, don't update the range pointer. This is useful when we
264 * need to ready a new skill, but don't want to clobber range.
265 * return 1 on success, 0 on error 205 * return 1 on success, 0 on error
266 */ 206 */
267 207bool
268int 208object::change_skill (object *new_skill)
269change_skill (object *who, object *new_skill, int flag)
270{ 209{
271 int old_range;
272
273 if (who->type != PLAYER) 210 if (type != PLAYER)
274 return 0; 211 return 0;
275 212
276 old_range = who->contr->shoottype; 213 // optimise this supposedly common case
277 214 if (new_skill == chosen_skill)
278 if (who->chosen_skill && who->chosen_skill == new_skill)
279 {
280 /* optimization for changing skill to current skill */
281 if (who->type == PLAYER && !(flag & 0x1))
282 who->contr->shoottype = range_skill;
283 return 1; 215 return 1;
284 }
285 216
286 if (!new_skill || who->chosen_skill)
287 if (who->chosen_skill) 217 if (chosen_skill)
288 apply_special (who, who->chosen_skill, AP_UNAPPLY);
289
290 /* Only goal in this case was to unapply a skill */
291 if (!new_skill)
292 return 0;
293
294 if (apply_special (who, new_skill, AP_APPLY))
295 {
296 return 0;
297 } 218 {
298 if (flag & 0x1) 219 chosen_skill->flag [FLAG_APPLIED] = false;
299 who->contr->shoottype = (rangetype) old_range; 220 change_abil (this, chosen_skill);
221 }
300 222
223 chosen_skill = new_skill;
224
225 if (chosen_skill)
226 {
227 chosen_skill->flag [FLAG_APPLIED] = true;
228 change_abil (this, chosen_skill);
229 }
230
231 // always clear current weapon, as the selected skill could
232 // conflict with the current weapon skill, which would go
233 // undetected and exp would be given to the wrong skill.
234 current_weapon = 0;
235
236 update_stats ();
301 return 1; 237 return 1;
302}
303
304/* This function just clears the chosen_skill and range_skill values
305 * inthe player.
306 */
307void
308clear_skill (object *who)
309{
310 who->chosen_skill = NULL;
311 CLEAR_FLAG (who, FLAG_READY_SKILL);
312 if (who->type == PLAYER)
313 {
314 who->contr->ranges[range_skill] = NULL;
315 if (who->contr->shoottype == range_skill)
316 who->contr->shoottype = range_none;
317 }
318} 238}
319 239
320/* do_skill() - Main skills use function-similar in scope to cast_spell(). 240/* do_skill() - Main skills use function-similar in scope to cast_spell().
321 * We handle all requests for skill use outside of some combat here. 241 * We handle all requests for skill use outside of some combat here.
322 * We require a separate routine outside of fire() so as to allow monsters 242 * We require a separate routine outside of fire() so as to allow monsters
325 * exp - no caller needed that info, but it also prevented the callers 245 * exp - no caller needed that info, but it also prevented the callers
326 * from know if a skill was actually used, as many skills don't 246 * from know if a skill was actually used, as many skills don't
327 * give any exp for their direct use (eg, throwing). 247 * give any exp for their direct use (eg, throwing).
328 * It returns 0 if no skill was used. 248 * It returns 0 if no skill was used.
329 */ 249 */
330
331int 250int
332do_skill (object *op, object *part, object *skill, int dir, const char *string) 251do_skill (object *op, object *part, object *skill, int dir, const char *string)
333{ 252{
334 int success = 0, exp = 0; 253 int success = 0, exp = 0;
335 int did_alc = 0; 254 int did_alc = 0;
336 object *tmp, *next;
337 255
338 if (!skill) 256 if (!skill)
339 return 0; 257 return 0;
340 258
341 /* The code below presumes that the skill points to the object that 259 /* The code below presumes that the skill points to the object that
343 * go and try to find the actual real skill pointer, and if the 261 * go and try to find the actual real skill pointer, and if the
344 * the player doesn't have a bucket for that, create one. 262 * the player doesn't have a bucket for that, create one.
345 */ 263 */
346 if (skill->type != SKILL && op->type == PLAYER) 264 if (skill->type != SKILL && op->type == PLAYER)
347 { 265 {
348 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 266 for (object *tmp = op->inv; tmp; tmp = tmp->below)
349 {
350 if (tmp->type == SKILL && tmp->skill == skill->skill) 267 if (tmp->type == SKILL && tmp->skill == skill->skill)
351 break; 268 {
269 skill = tmp;
270 goto found;
352 } 271 }
353 if (!tmp) 272
354 tmp = give_skill_by_name (op, skill->skill); 273 skill = give_skill_by_name (op, skill->skill);
355 skill = tmp; 274found: ;
356 } 275 }
357 276
358 // skill, by_whom, on_which_object, which direction, skill_argument 277 // skill, by_whom, on_which_object, which direction, skill_argument
359 if (INVOKE_OBJECT (USE_SKILL, skill, ARG_OBJECT (op), ARG_OBJECT (part), ARG_INT (dir), ARG_STRING (string))) 278 if (INVOKE_OBJECT (USE_SKILL, skill, ARG_OBJECT (op), ARG_OBJECT (part), ARG_INT (dir), ARG_STRING (string)))
360 return 0; 279 return 0;
361 280
362 switch (skill->subtype) 281 switch (skill->subtype)
363 { 282 {
364 case SK_LEVITATION: 283 case SK_LEVITATION:
365 /* Not 100% sure if this will work with new movement code - 284 /* Not 100% sure if this will work with new movement code -
366 * the levitation skill has move_type for flying, so when 285 * the levitation skill has move_type for flying, so when
367 * equipped, that should transfer to player, when not, 286 * equipped, that should transfer to player, when not,
368 * shouldn't. 287 * shouldn't.
369 */ 288 */
370 if (QUERY_FLAG (skill, FLAG_APPLIED)) 289 if (QUERY_FLAG (skill, FLAG_APPLIED))
371 { 290 {
372 CLEAR_FLAG (skill, FLAG_APPLIED); 291 CLEAR_FLAG (skill, FLAG_APPLIED);
373 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth."); 292 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth.");
374 } 293 }
375 else 294 else
376 { 295 {
377 SET_FLAG (skill, FLAG_APPLIED); 296 SET_FLAG (skill, FLAG_APPLIED);
378 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!."); 297 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!");
379 } 298 }
380 fix_player (op); 299
300 op->update_stats ();
381 success = 1; 301 success = 1;
382 break; 302 break;
383 303
384 case SK_STEALING: 304 case SK_STEALING:
385 exp = success = steal (op, dir, skill); 305 exp = success = steal (op, dir, skill);
386 break; 306 break;
387 307
388 case SK_LOCKPICKING: 308 case SK_LOCKPICKING:
389 exp = success = pick_lock (op, dir, skill); 309 exp = success = pick_lock (op, dir, skill);
390 break; 310 break;
391 311
392 case SK_HIDING: 312 case SK_HIDING:
393 exp = success = hide (op, skill); 313 exp = success = hide (op, skill);
394 break; 314 break;
395 315
396 case SK_JUMPING: 316 case SK_JUMPING:
397 success = jump (op, dir, skill); 317 exp = success = jump (op, dir, skill);
398 break; 318 break;
399 319
400 case SK_INSCRIPTION: 320 case SK_INSCRIPTION:
401 exp = success = write_on_item (op, string, skill); 321 exp = success = write_on_item (op, string, skill);
402 break; 322 break;
403 323
404 case SK_MEDITATION: 324 case SK_MEDITATION:
405 meditate (op, skill); 325 meditate (op, skill);
406 success = 1; 326 success = 1;
407 break; 327 break;
408 /* note that the following 'attack' skills gain exp through hit_player() */ 328 /* note that the following 'attack' skills gain exp through hit_player() */
409 329
410 case SK_KARATE: 330 case SK_KARATE:
411 (void) attack_hth (op, dir, "karate-chopped", skill); 331 attack_hth (op, dir, "karate-chopped", skill);
412 break; 332 break;
413 333
414 case SK_PUNCHING: 334 case SK_PUNCHING:
415 (void) attack_hth (op, dir, "punched", skill); 335 attack_hth (op, dir, "punched", skill);
416 break; 336 break;
417 337
418 case SK_FLAME_TOUCH: 338 case SK_FLAME_TOUCH:
419 (void) attack_hth (op, dir, "flamed", skill); 339 attack_hth (op, dir, "flamed", skill);
420 break; 340 break;
421 341
422 case SK_SPARK_TOUCH: 342 case SK_SPARK_TOUCH:
423 (void) attack_hth (op, dir, "zapped", skill); 343 attack_hth (op, dir, "zapped", skill);
424 break; 344 break;
425 345
426 case SK_SHIVER: 346 case SK_SHIVER:
427 (void) attack_hth (op, dir, "froze", skill); 347 attack_hth (op, dir, "froze", skill);
428 break; 348 break;
429 349
430 case SK_ACID_SPLASH: 350 case SK_ACID_SPLASH:
431 (void) attack_hth (op, dir, "dissolved", skill); 351 attack_hth (op, dir, "dissolved", skill);
432 break; 352 break;
433 353
434 case SK_POISON_NAIL: 354 case SK_POISON_NAIL:
435 (void) attack_hth (op, dir, "injected poison into", skill); 355 attack_hth (op, dir, "injected poison into", skill);
436 break; 356 break;
437 357
438 case SK_CLAWING: 358 case SK_CLAWING:
439 (void) attack_hth (op, dir, "clawed", skill); 359 attack_hth (op, dir, "clawed", skill);
440 break; 360 break;
441 361
442 case SK_ONE_HANDED_WEAPON: 362 case SK_ONE_HANDED_WEAPON:
443 case SK_TWO_HANDED_WEAPON: 363 case SK_TWO_HANDED_WEAPON:
444 (void) attack_melee_weapon (op, dir, NULL, skill); 364 attack_melee_weapon (op, dir, NULL, skill);
445 break; 365 break;
446 366
447 case SK_FIND_TRAPS: 367 case SK_FIND_TRAPS:
448 exp = success = find_traps (op, skill); 368 exp = success = find_traps (op, skill);
449 break; 369 break;
450 370
451 case SK_SINGING: 371 case SK_SINGING:
452 exp = success = singing (op, dir, skill); 372 exp = success = singing (op, dir, skill);
453 break; 373 break;
454 374
455 case SK_ORATORY: 375 case SK_ORATORY:
456 exp = success = use_oratory (op, dir, skill); 376 exp = success = use_oratory (op, dir, skill);
457 break; 377 break;
458 378
459 case SK_SMITHERY: 379 case SK_SMITHERY:
460 case SK_BOWYER: 380 case SK_BOWYER:
461 case SK_JEWELER: 381 case SK_JEWELER:
462 case SK_ALCHEMY: 382 case SK_ALCHEMY:
463 case SK_THAUMATURGY: 383 case SK_THAUMATURGY:
464 case SK_LITERACY: 384 case SK_LITERACY:
465 case SK_WOODSMAN: 385 case SK_WOODSMAN:
466 /* first, we try to find a cauldron, and do the alchemy thing. 386 /* first, we try to find a cauldron, and do the alchemy thing.
467 * failing that, we go and identify stuff. 387 * failing that, we go and identify stuff.
468 */ 388 */
469 for (tmp = get_map_ob (op->map, op->x, op->y); tmp != NULL; tmp = next) 389 for (object *next, *tmp = GET_MAP_OB (op->map, op->x, op->y); tmp; tmp = next)
470 { 390 {
471 next = tmp->above; 391 next = tmp->above;
392
472 if (QUERY_FLAG (tmp, FLAG_IS_CAULDRON)) 393 if (QUERY_FLAG (tmp, FLAG_IS_CAULDRON))
473 { 394 {
474 attempt_do_alchemy (op, tmp); 395 attempt_do_alchemy (op, tmp);
396
475 if (QUERY_FLAG (tmp, FLAG_APPLIED)) 397 if (QUERY_FLAG (tmp, FLAG_APPLIED))
476 esrv_send_inventory (op, tmp); 398 esrv_send_inventory (op, tmp);
399
477 did_alc = 1; 400 did_alc = 1;
478 } 401 }
479 } 402 }
403
480 if (did_alc == 0) 404 if (did_alc == 0)
481 exp = success = skill_ident (op, skill);
482 break;
483
484 case SK_DET_MAGIC:
485 case SK_DET_CURSE:
486 exp = success = skill_ident (op, skill); 405 exp = success = skill_ident (op, skill);
406
487 break; 407 break;
488 408
409 case SK_DET_MAGIC:
410 case SK_DET_CURSE:
411 exp = success = skill_ident (op, skill);
412 break;
413
489 case SK_DISARM_TRAPS: 414 case SK_DISARM_TRAPS:
490 exp = success = remove_trap (op, dir, skill); 415 exp = success = remove_trap (op, dir, skill);
491 break; 416 break;
492 417
493 case SK_THROWING: 418 case SK_THROWING:
494 success = skill_throw (op, part, dir, string, skill); 419 success = skill_throw (op, part, dir, string, skill);
495 break; 420 break;
496 421
497 case SK_SET_TRAP: 422 case SK_SET_TRAP:
498 new_draw_info (NDI_UNIQUE, 0, op, "This skill is not currently implemented."); 423 new_draw_info (NDI_UNIQUE, 0, op, "This skill is not currently implemented.");
499 break; 424 break;
500 425
501 case SK_USE_MAGIC_ITEM: 426 case SK_USE_MAGIC_ITEM:
502 case SK_MISSILE_WEAPON: 427 case SK_MISSILE_WEAPON:
503 new_draw_info (NDI_UNIQUE, 0, op, "There is no special attack for this skill."); 428 new_draw_info (NDI_UNIQUE, 0, op, "There is no special attack for this skill.");
504 break; 429 break;
505 430
506 case SK_PRAYING: 431 case SK_PRAYING:
507 success = pray (op, skill); 432 success = pray (op, skill);
508 break; 433 break;
509 434
510 case SK_BARGAINING: 435 case SK_BARGAINING:
511 success = describe_shop (op); 436 success = describe_shop (op);
512 break; 437 break;
513 438
514 case SK_SORCERY: 439 case SK_SORCERY:
515 case SK_EVOCATION: 440 case SK_EVOCATION:
516 case SK_PYROMANCY: 441 case SK_PYROMANCY:
517 case SK_SUMMONING: 442 case SK_SUMMONING:
518 case SK_CLIMBING: 443 case SK_CLIMBING:
519 new_draw_info (NDI_UNIQUE, 0, op, "This skill is already in effect."); 444 new_draw_info (NDI_UNIQUE, 0, op, "This skill is already in effect.");
520 break; 445 break;
521 446
522 default: 447 default:
523 LOG (llevDebug, "%s attempted to use unknown skill: %d\n", query_name (op), op->chosen_skill->stats.sp); 448 LOG (llevDebug, "%s attempted to use unknown skill: %d\n", query_name (op), op->chosen_skill->stats.sp);
524 break; 449 break;
525 } 450 }
526 451
527 /* For players we now update the speed_left from using the skill. 452 /* For players we now update the speed_left from using the skill.
528 * Monsters have no skill use time because of the random nature in 453 * Monsters have no skill use time because of the random nature in
529 * which use_monster_skill is called already simulates this. 454 * which use_monster_skill is called already simulates this.
530 * If certain skills should take more/less time, that should be 455 * If certain skills should take more/less time, that should be
531 * in the code for the skill itself. 456 * in the code for the skill itself.
532 */ 457 */
533
534 if (op->type == PLAYER) 458 if (op->type == PLAYER)
535 op->speed_left -= 1.0; 459 op->speed_left -= 1.f;
536 460
537 /* this is a good place to add experience for successfull use of skills. 461 /* this is a good place to add experience for successfull use of skills.
538 * Note that add_exp() will figure out player/monster experience 462 * Note that add_exp() will figure out player/monster experience
539 * gain problems. 463 * gain problems.
540 */ 464 */
568 * op is the object that was 'defeated'. 492 * op is the object that was 'defeated'.
569 * skill is the skill used. If no skill is used, it should just 493 * skill is the skill used. If no skill is used, it should just
570 * point back to who. 494 * point back to who.
571 * 495 *
572 */ 496 */
573
574int 497int
575calc_skill_exp (object *who, object *op, object *skill) 498calc_skill_exp (object *who, object *op, object *skill)
576{ 499{
577 int op_exp = 0, op_lvl = 0; 500 int op_exp = 0, op_lvl = 0;
578 float base, value, lvl_mult = 0.0; 501 float base, value, lvl_mult = 0.0;
587 * If an object is not alive and magical we set the base exp higher to 510 * If an object is not alive and magical we set the base exp higher to
588 * help out exp awards for skill_ident skills. Also, if 511 * help out exp awards for skill_ident skills. Also, if
589 * an item is type RUNE, we give out exp based on stats.Cha 512 * an item is type RUNE, we give out exp based on stats.Cha
590 * and level (this was the old system) -b.t. 513 * and level (this was the old system) -b.t.
591 */ 514 */
592
593 if (!op) 515 if (!op)
594 { /* no item/creature */ 516 { /* no item/creature */
595 op_lvl = who->map->difficulty < 1 ? 1 : who->map->difficulty; 517 op_lvl = max (1, who->map->difficulty);
596 op_exp = 0; 518 op_exp = 0;
597 } 519 }
598 else if (op->type == RUNE || op->type == TRAP) 520 else if (op->type == RUNE || op->type == TRAP)
599 { /* all traps. If stats.Cha > 1 we use that 521 { /* all traps. If stats.Cha > 1 we use that
600 * for the amount of experience */ 522 * for the amount of experience */
604 else 526 else
605 { /* all other items/living creatures */ 527 { /* all other items/living creatures */
606 op_exp = op->stats.exp; 528 op_exp = op->stats.exp;
607 op_lvl = op->level; 529 op_lvl = op->level;
608 if (!QUERY_FLAG (op, FLAG_ALIVE)) 530 if (!QUERY_FLAG (op, FLAG_ALIVE))
609 { /* for ident/make items */ 531 op_lvl += 5 * abs (op->magic); /* for ident/make items */
610 op_lvl += 5 * abs (op->magic);
611 }
612 } 532 }
613 533
614 if (op_lvl < 1) 534 if (op_lvl < 1)
615 op_lvl = 1; 535 op_lvl = 1;
616 536
624 /* if skill really is a skill, then we can look at the skill archetype for 544 /* if skill really is a skill, then we can look at the skill archetype for
625 * bse reward value (exp) and level multiplier factor. 545 * bse reward value (exp) and level multiplier factor.
626 */ 546 */
627 if (skill->type == SKILL) 547 if (skill->type == SKILL)
628 { 548 {
629 base += skill->arch->clone.stats.exp; 549 base += skill->arch->stats.exp;
630 if (settings.simple_exp) 550 if (settings.simple_exp)
631 { 551 {
632 if (skill->arch->clone.level) 552 if (skill->arch->level)
633 lvl_mult = (float) skill->arch->clone.level / 100.0; 553 lvl_mult = (float) skill->arch->level / 100.0;
634 else 554 else
635 lvl_mult = 1.0; /* no adjustment */ 555 lvl_mult = 1.0; /* no adjustment */
636 } 556 }
637 else 557 else
638 { 558 {
639 if (skill->level) 559 if (skill->level)
640 lvl_mult = ((float) skill->arch->clone.level * (float) op_lvl) / ((float) skill->level * 100.0); 560 lvl_mult = ((float) skill->arch->level * (float) op_lvl) / ((float) skill->level * 100.0);
641 else 561 else
642 lvl_mult = 1.0; 562 lvl_mult = 1.0;
643 } 563 }
644 } 564 }
645 else 565 else
646 { 566 {
647 /* Don't divide by zero here! */ 567 /* Don't divide by zero here! */
648 lvl_mult = (float) op_lvl / (float) (skill->level ? skill->level : 1); 568 lvl_mult = (float) op_lvl / (float) max (1, skill->level);
649 } 569 }
650 } 570 }
651 571
652 /* assemble the exp total, and return value */ 572 /* assemble the exp total, and return value */
653 573
667 * This one actually teaches the player the skill as something 587 * This one actually teaches the player the skill as something
668 * they can equip. 588 * they can equip.
669 * Return 0 if the player knows the skill, 1 if the 589 * Return 0 if the player knows the skill, 1 if the
670 * player learns the skill, 2 otherwise. 590 * player learns the skill, 2 otherwise.
671 */ 591 */
672
673int 592int
674learn_skill (object *pl, object *scroll) 593learn_skill (object *pl, object *scroll)
675{ 594{
676 object *tmp;
677
678 if (!scroll->skill) 595 if (!scroll->skill)
679 { 596 {
680 LOG (llevError, "skill scroll %s does not have skill pointer set.\n", &scroll->name); 597 LOG (llevError, "skill scroll %s does not have skill pointer set.\n", &scroll->name);
681 return 2; 598 return 2;
682 } 599 }
683 600
684 /* can't use find_skill_by_name because we want skills the player knows 601 object *tmp = find_skill (pl, scroll->skill);
685 * but can't use natively.
686 */
687
688 for (tmp = pl->inv; tmp != NULL; tmp = tmp->below)
689 if (tmp->type == SKILL && !strncasecmp (scroll->skill, tmp->skill, strlen (scroll->skill)))
690 break;
691 602
692 /* player already knows it */ 603 /* player already knows it */
693 if (tmp && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL)) 604 if (tmp && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL))
694 return 0; 605 return 0;
695
696
697 606
698 /* now a random change to learn, based on player Int. 607 /* now a random change to learn, based on player Int.
699 * give bonus based on level - otherwise stupid characters 608 * give bonus based on level - otherwise stupid characters
700 * might never be able to learn anything. 609 * might never be able to learn anything.
701 */ 610 */
710 LOG (llevError, "skill scroll %s does not have valid skill name (%s).\n", &scroll->name, &scroll->skill); 619 LOG (llevError, "skill scroll %s does not have valid skill name (%s).\n", &scroll->name, &scroll->skill);
711 return 2; 620 return 2;
712 } 621 }
713 622
714 SET_FLAG (tmp, FLAG_CAN_USE_SKILL); 623 SET_FLAG (tmp, FLAG_CAN_USE_SKILL);
715 link_player_skills (pl); 624
716 return 1; 625 return 1;
717} 626}
718 627
719/* Gives a percentage clipped to 0% -> 100% of a/b. */ 628/* Gives a percentage clipped to 0% -> 100% of a/b. */
720
721/* Probably belongs in some global utils-type file? */ 629/* Probably belongs in some global utils-type file? */
722static int 630static int
723clipped_percent (sint64 a, sint64 b) 631clipped_percent (sint64 a, sint64 b)
724{ 632{
725 int rv; 633 int rv;
745 * Note this function is a bit more complicated becauase we 653 * Note this function is a bit more complicated becauase we
746 * we want ot sort the skills before printing them. If we 654 * we want ot sort the skills before printing them. If we
747 * just dumped this as we found it, this would be a bit 655 * just dumped this as we found it, this would be a bit
748 * simpler. 656 * simpler.
749 */ 657 */
750 658//TODO: egad, do it in perl, do not suffer from the big buffer on stack, make it one single drawinfo.
751void 659void
752show_skills (object *op, const char *search) 660show_skills (object *pl, const char *search)
753{ 661{
754 object *tmp = NULL;
755 char buf[MAX_BUF];
756 const char *cp; 662 const char *cp;
757 int i, num_skills_found = 0; 663 int i, num_skills_found = 0;
758 static const char *const periods = "........................................"; 664 const char *const periods = ".............................."; // 30
759 665
760 /* Need to have a pointer and use strdup for qsort to work properly */ 666 /* Need to have a pointer and use strdup for qsort to work properly */
761 char skills[NUM_SKILLS][MAX_BUF]; 667 char skills[NUM_SKILLS][128]; // d'oh
762 668
669 object *op = pl->contr->ob;
763 670
764 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 671 for (object *tmp = op->inv; tmp; tmp = tmp->below)
765 { 672 {
766 if (tmp->type == SKILL) 673 if (tmp->type == SKILL)
767 { 674 {
768 if (search && strstr (tmp->name, search) == NULL) 675 if (search && !strstr (tmp->name, search))
769 continue; 676 continue;
677
678 char buf[30];
679
770 /* Basically want to fill this out to 40 spaces with periods */ 680 /* Basically want to fill this out to 30 spaces with periods */
771 sprintf (buf, "%s%s", &tmp->name, periods); 681 snprintf (buf, sizeof (buf), "%s%s", &tmp->name, periods);
772 buf[40] = 0;
773 682
774 if (settings.permanent_exp_ratio) 683 if (settings.permanent_exp_ratio)
775 {
776 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%lld/%lld/%d%%)", 684 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 "/%d%%)",
777 buf, tmp->level, 685 buf, tmp->level, tmp->stats.exp,
778 (long long) tmp->stats.exp,
779 (long long) level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp)); 686 level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp));
780 }
781 else 687 else
782 {
783 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%lld/%lld)", 688 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 ")",
784 buf, tmp->level, (long long) tmp->stats.exp, (long long) level_exp (tmp->level + 1, op->expmul)); 689 buf, tmp->level, tmp->stats.exp, level_exp (tmp->level + 1, op->expmul));
785 } 690
786 /* I don't know why some characters get a bunch of skills, but 691 /* I don't know why some characters get a bunch of skills, but
787 * it sometimes happens (maybe a leftover from bugier earlier code 692 * it sometimes happens (maybe a leftover from bugier earlier code
788 * and those character are still about). In any case, lets handle 693 * and those character are still about). In any case, lets handle
789 * it so it doesn't crash the server - otherwise, one character may 694 * it so it doesn't crash the server - otherwise, one character may
790 * crash the server numerous times. 695 * crash the server numerous times.
796 break; 701 break;
797 } 702 }
798 } 703 }
799 } 704 }
800 705
801 clear_win_info (op); 706 dynbuf_text msg (4096, 1024);
802 new_draw_info (NDI_UNIQUE, 0, op, "Player skills:"); 707
708 msg << "T<Player skills:>\n\n";
803 if (num_skills_found > 1) 709 if (num_skills_found > 1)
804 qsort (skills, num_skills_found, MAX_BUF, (int (*)(const void *, const void *)) strcmp); 710 qsort (skills, num_skills_found, sizeof (skills [0]), (int (*)(const void *, const void *)) std::strcmp);
805 711
806 for (i = 0; i < num_skills_found; i++) 712 for (i = 0; i < num_skills_found; i++)
807 { 713 msg << " C<" << skills [i] << ">\n";
808 new_draw_info (NDI_UNIQUE, 0, op, skills[i]);
809 }
810 714
811 new_draw_info_format (NDI_UNIQUE, 0, op, "You can handle %d weapon improvements.", op->level / 5 + 5); 715 msg << "\nYou can handle " << op->level / 5 + 5 << " weapon improvements.\r";
812 716
813 cp = determine_god (op); 717 cp = determine_god (op);
814 new_draw_info_format (NDI_UNIQUE, 0, op, "You worship %s.", cp ? cp : "no god at current time"); 718 msg << "You worship " << (cp ? cp : "no god at current time") << ".\r";
815 719
816 new_draw_info_format (NDI_UNIQUE, 0, op, "Your equipped item power is %d out of %d\n", 720 msg << "Your equipped item power is " << (int)op->contr->item_power
817 op->contr->item_power, (int) (op->level * settings.item_power_factor)); 721 << " out of " << int (op->level * settings.item_power_factor)
722 << ".\n";
723
724 pl->contr->infobox (MSG_CHANNEL ("skills"), msg);
818} 725}
819 726
820/* use_skill() - similar to invoke command, it executes the skill in the 727/* use_skill() - similar to invoke command, it executes the skill in the
821 * direction that the user is facing. Returns false if we are unable to 728 * direction that the user is facing. Returns false if we are unable to
822 * change to the requested skill, or were unable to use the skill properly. 729 * change to the requested skill, or were unable to use the skill properly.
823 * This is tricky because skills can have spaces. We basically roll 730 * This is tricky because skills can have spaces. We basically roll
824 * our own find_skill_by_name so we can try to do better string matching. 731 * our own find_skill_by_name so we can try to do better string matching.
825 */ 732 */
826
827int 733int
828use_skill (object *op, const char *string) 734use_skill (object *op, const char *string)
829{ 735{
830 object *skop; 736 object *skop;
831 size_t len; 737 size_t len;
832 738
833 if (!string) 739 if (!string)
834 return 0; 740 return 0;
835 741
836 for (skop = op->inv; skop != NULL; skop = skop->below) 742 for (skop = op->inv; skop; skop = skop->below)
837 { 743 {
744 if (skop->type == SKILL
838 if (skop->type == SKILL && QUERY_FLAG (skop, FLAG_CAN_USE_SKILL) && 745 && QUERY_FLAG (skop, FLAG_CAN_USE_SKILL)
839 !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill)))) 746 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill))))
840 break; 747 break;
748 else if (skop->type == SKILL_TOOL
841 else if (skop->type == SKILL_TOOL && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill)))) 749 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill))))
842 break; 750 break;
843 } 751 }
752
844 if (!skop) 753 if (!skop)
845 { 754 {
846 new_draw_info_format (NDI_UNIQUE, 0, op, "Unable to find skill %s", string); 755 new_draw_info_format (NDI_UNIQUE, 0, op, "Unable to find skill %s", string);
847 return 0; 756 return 0;
848 } 757 }
853 * options given to the skill. Its pretty simple - if there 762 * options given to the skill. Its pretty simple - if there
854 * are extra parameters (as deteremined by string length), we 763 * are extra parameters (as deteremined by string length), we
855 * want to skip over any leading spaces. 764 * want to skip over any leading spaces.
856 */ 765 */
857 if (len >= strlen (string)) 766 if (len >= strlen (string))
858 {
859 string = NULL; 767 string = NULL;
860 }
861 else 768 else
862 { 769 {
863 string += len; 770 string += len;
864 while (*string == 0x20) 771 while (*string == 0x20)
865 string++; 772 string++;
773
866 if (strlen (string) == 0) 774 if (strlen (string) == 0)
867 string = NULL; 775 string = NULL;
868 } 776 }
869 777
870#ifdef SKILL_UTIL_DEBUG 778#ifdef SKILL_UTIL_DEBUG
871 LOG (llevDebug, "use_skill() got skill: %s\n", sknum > -1 ? skills[sknum].name : "none"); 779 LOG (llevDebug, "use_skill() got skill: %s\n", sknum > -1 ? skills[sknum].name : "none");
872#endif 780#endif
873 781
874 /* Change to the new skill, then execute it. */
875 if (do_skill (op, op, skop, op->facing, string)) 782 if (do_skill (op, op, skop, op->facing, string))
876 return 1; 783 return 1;
877 784
878 return 0; 785 return 0;
879} 786}
880 787
788static bool
789hth_skill_p (object *skill)
790{
791 return (skill_flags [skill->subtype] & (SF_COMBAT | SF_NEED_WEAPON)) == SF_COMBAT;
792}
881 793
882
883/* This finds the best unarmed skill the player has, and returns 794/* This finds the first unarmed skill the player has, and returns it.
884 * it. Best can vary a little - we consider clawing to always
885 * be the best for dragons.
886 * This could be more intelligent, eg, look at the skill level
887 * of the skill and go from there (eg, a level 40 puncher is
888 * is probably better than level 1 karate). OTOH, if you
889 * don't bother to set up your skill properly, that is the players
890 * problem (although, it might be nice to have a preferred skill
891 * field the player can set.
892 * Unlike the old code, we don't give out any skills - it is
893 * possible you just don't have any ability to get into unarmed
894 * combat. If everyone race/class should have one, this should
895 * be handled in the starting treasurelists, not in the code.
896 */ 795 */
897static object * 796static object *
898find_best_player_hth_skill (object *op) 797find_player_hth_skill (object *op)
899{ 798{
900 object *tmp, *best_skill = NULL;
901 int dragon = is_dragon_pl (op), last_skill = sizeof (unarmed_skills), i;
902
903 for (tmp = op->inv; tmp; tmp = tmp->below) 799 for (object *tmp = op->inv; tmp; tmp = tmp->below)
904 { 800 if (tmp->type == SKILL && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL) && hth_skill_p (tmp))
905 if (tmp->type == SKILL)
906 {
907 if (dragon && tmp->subtype == SK_CLAWING)
908 return tmp; 801 return tmp;
909 802
910 /* The order in the array is preferred order. So basically, 803 return 0;
911 * we just cut down the number to search - eg, if we find a skill
912 * early on in flame touch, then we only need to look into the unarmed_array
913 * to the entry before flame touch - don't care about the entries afterward,
914 * because they are infrerior skills.
915 * if we end up finding the best skill (i==0) might as well return
916 * right away - can't get any better than that.
917 */
918 for (i = 0; i < last_skill; i++)
919 {
920 if (tmp->subtype == unarmed_skills[i] && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL))
921 {
922 best_skill = tmp;
923 last_skill = i;
924 if (i == 0)
925 return best_skill;
926 }
927 }
928 }
929 }
930 return best_skill;
931} 804}
932 805
933/* do_skill_attack() - We have got an appropriate opponent from either 806/* do_skill_attack() - We have got an appropriate opponent from either
934 * move_player_attack() or skill_attack(). In this part we get on with 807 * move_player_attack() or skill_attack(). In this part we get on with
935 * attacking, take care of messages from the attack and changes in invisible. 808 * attacking, take care of messages from the attack and changes in invisible.
937 * tmp is the targetted monster. 810 * tmp is the targetted monster.
938 * op is what is attacking 811 * op is what is attacking
939 * string is passed along to describe what messages to describe 812 * string is passed along to describe what messages to describe
940 * the damage. 813 * the damage.
941 */ 814 */
942
943static int 815static int
944do_skill_attack (object *tmp, object *op, const char *string, object *skill) 816do_skill_attack (object *tmp, object *op, const char *string, object *skill)
945{ 817{
946 int success;
947
948 if (INVOKE_OBJECT (SKILL_ATTACK, op, ARG_OBJECT (tmp), ARG_STRING (string), ARG_OBJECT (skill))) 818 if (INVOKE_OBJECT (SKILL_ATTACK, op, ARG_OBJECT (tmp), ARG_STRING (string), ARG_OBJECT (skill)))
949 return RESULT_INT (0); 819 return RESULT_INT (0);
950 820
951 /* For Players only: if there is no ready weapon, and no "attack" skill 821 /* For Players only: if there is no ready weapon, and no "attack" skill
952 * is readied either then try to find a skill for the player to use. 822 * is readied either then try to find a skill for the player to use.
953 * it is presumed that if skill is set, it is a valid attack skill (eg, 823 * it is presumed that if skill is set, it is a valid attack skill (eg,
954 * the caller should have set it appropriately). We still want to pass 824 * the caller should have set it appropriately). We still want to pass
955 * through that code if skill is set to change to the skill. 825 * through that code if skill is set to change to the skill.
956 */ 826 */
957 if (op->type == PLAYER) 827 if (player *pl = op->contr)
958 { 828 {
959 if (!QUERY_FLAG (op, FLAG_READY_WEAPON)) 829 if (skill)
830 op->change_skill (skill);
831 else
960 { 832 {
961 size_t i; 833 if (!pl->combat_ob)
962
963 if (!skill)
964 { 834 {
965 /* See if the players chosen skill is a combat skill, and use 835 if (QUERY_FLAG (op, FLAG_READY_WEAPON))
966 * it if appropriate.
967 */
968 if (op->chosen_skill)
969 { 836 {
970 for (i = 0; i < sizeof (unarmed_skills); i++) 837 for (tmp = op->inv; tmp; tmp = tmp->below)
971 if (op->chosen_skill->subtype == unarmed_skills[i]) 838 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
972 {
973 skill = op->chosen_skill;
974 break; 839 break;
975 } 840
841 if (!tmp)
842 LOG (llevError, "Could not find applied weapon on %s\n", &op->name);
843
844 pl->combat_ob = tmp;
976 } 845 }
977 /* If we didn't find a skill above, look harder for a good skill */ 846
978 if (!skill) 847 if (!pl->combat_ob)
979 { 848 {
980 skill = find_best_player_hth_skill (op); 849 /* See if the players chosen skill is a combat skill, and use
981 850 * it if appropriate.
982 if (!skill) 851 */
852 if (op->chosen_skill && hth_skill_p (op->chosen_skill))
853 skill = op->chosen_skill;
854 else
983 { 855 {
856 skill = find_player_hth_skill (op);
857
858 if (!skill)
984 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!"); 859 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!");
985 return 0; 860 }
861
862 if (skill)
863 {
864 op->change_skill (0);
865 apply_special (op, skill, AP_APPLY);
986 } 866 }
987 } 867 }
988 } 868
989 if (skill != op->chosen_skill) 869 if (!pl->combat_ob)
990 { 870 {
991 /* now try to ready the new skill */ 871 LOG (llevError, "Could not find anything to attack on %s\n", &op->name);
992 if (!change_skill (op, skill, 0))
993 { /* oh oh, trouble! */
994 new_draw_info_format (NDI_UNIQUE, 0, tmp, "Couldn't change to skill %s", &skill->name);
995 return 0; 872 return 0;
996 } 873 }
997 } 874 }
875
876 if (!op->change_weapon (pl->combat_ob))
877 return 0;
998 } 878 }
999 else 879
880 /* lose invisiblity/hiding status for running attacks */
881 if (pl->tmp_invis)
1000 { 882 {
1001 /* Seen some crashes below where current_weapon is not set, 883 pl->tmp_invis = 0;
1002 * even though the flag says it is. So if current weapon isn't set, 884 op->invisible = 0;
1003 * do some work in trying to find the object to use. 885 op->hide = 0;
1004 */ 886 update_object (op, UP_OBJ_CHANGE);
1005 if (!op->current_weapon)
1006 {
1007 object *tmp;
1008
1009 LOG (llevError, "Player %s does not have current weapon set but flag_ready_weapon is set\n", &op->name);
1010 for (tmp = op->inv; tmp; tmp = tmp->below)
1011 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
1012 break;
1013
1014 if (!tmp)
1015 {
1016 LOG (llevError, "Could not find applied weapon on %s\n", &op->name);
1017 op->current_weapon = NULL;
1018 return 0;
1019 }
1020 else
1021 {
1022 op->current_weapon = tmp;
1023 }
1024 }
1025
1026 /* Has ready weapon - make sure chosen_skill is set up properly */
1027 if (!op->chosen_skill || op->current_weapon->skill != op->chosen_skill->skill)
1028 {
1029 change_skill (op, find_skill_by_name (op, op->current_weapon->skill), 1);
1030 }
1031 } 887 }
1032 } 888 }
1033 889
1034 /* lose invisiblity/hiding status for running attacks */
1035
1036 if (op->type == PLAYER && op->contr->tmp_invis)
1037 {
1038 op->contr->tmp_invis = 0;
1039 op->invisible = 0;
1040 op->hide = 0;
1041 update_object (op, UP_OBJ_FACE);
1042 }
1043
1044 success = attack_ob (tmp, op); 890 int success = attack_ob (tmp, op);
1045 891
1046 /* print appropriate messages to the player */ 892 /* print appropriate messages to the player */
1047 893
1048 if (success && string != NULL && tmp && !QUERY_FLAG (tmp, FLAG_FREED)) 894 if (success && string && tmp && !QUERY_FLAG (tmp, FLAG_FREED))
1049 { 895 {
1050 if (op->type == PLAYER) 896 if (op->type == PLAYER)
1051 new_draw_info_format (NDI_UNIQUE, 0, op, "You %s %s!", string, query_name (tmp)); 897 new_draw_info_format (NDI_UNIQUE, 0, op, "You %s %s!", string, query_name (tmp));
1052 else if (tmp->type == PLAYER) 898 else if (tmp->type == PLAYER)
1053 new_draw_info_format (NDI_UNIQUE, 0, tmp, "%s %s you!", query_name (op), string); 899 new_draw_info_format (NDI_UNIQUE, 0, tmp, "%s %s you!", query_name (op), string);
1054 } 900 }
901
1055 return success; 902 return success;
1056} 903}
1057
1058 904
1059/* skill_attack() - Core routine for use when we attack using a skills 905/* skill_attack() - Core routine for use when we attack using a skills
1060 * system. In essence, this code handles 906 * system. In essence, this code handles
1061 * all skill-based attacks, ie hth, missile and melee weapons should be 907 * all skill-based attacks, i.e. hth, missile and melee weapons should be
1062 * treated here. If an opponent is already supplied by move_player(), 908 * treated here. If an opponent is already supplied by move_player(),
1063 * we move right onto do_skill_attack(), otherwise we find if an 909 * we move right onto do_skill_attack(), otherwise we find if an
1064 * appropriate opponent exists. 910 * appropriate opponent exists.
1065 * 911 *
1066 * This is called by move_player() and attack_hth() 912 * This is called by move_player() and attack_hth()
1067 * 913 *
1068 * Initial implementation by -bt thomas@astro.psu.edu 914 * Initial implementation by -bt thomas@astro.psu.edu
1069 */ 915 */
1070
1071int 916int
1072skill_attack (object *tmp, object *pl, int dir, const char *string, object *skill) 917skill_attack (object *tmp, object *pl, int dir, const char *string, object *skill)
1073{ 918{
1074 sint16 tx, ty; 919 sint16 tx, ty;
1075 maptile *m; 920 maptile *m;
1076 int mflags; 921 int mflags;
1077 922
1078 if (!dir) 923 if (!dir)
1079 dir = pl->facing; 924 dir = pl->facing;
925
1080 tx = freearr_x[dir]; 926 tx = freearr_x[dir];
1081 ty = freearr_y[dir]; 927 ty = freearr_y[dir];
1082 928
1083 /* If we don't yet have an opponent, find if one exists, and attack. 929 /* If we don't yet have an opponent, find if one exists, and attack.
1084 * Legal opponents are the same as outlined in move_player_attack() 930 * Legal opponents are the same as outlined in move_player_attack()
1085 */ 931 */
1086 932 if (!tmp)
1087 if (tmp == NULL)
1088 { 933 {
1089 m = pl->map; 934 m = pl->map;
1090 tx = pl->x + freearr_x[dir]; 935 tx = pl->x + freearr_x[dir];
1091 ty = pl->y + freearr_y[dir]; 936 ty = pl->y + freearr_y[dir];
1092 937
1096 941
1097 /* space must be blocked for there to be anything interesting to do */ 942 /* space must be blocked for there to be anything interesting to do */
1098 if (!OB_TYPE_MOVE_BLOCK (pl, GET_MAP_MOVE_BLOCK (m, tx, ty))) 943 if (!OB_TYPE_MOVE_BLOCK (pl, GET_MAP_MOVE_BLOCK (m, tx, ty)))
1099 return 0; 944 return 0;
1100 945
1101 for (tmp = get_map_ob (m, tx, ty); tmp; tmp = tmp->above) 946 for (tmp = GET_MAP_OB (m, tx, ty); tmp; tmp = tmp->above)
1102 if ((QUERY_FLAG (tmp, FLAG_ALIVE) && tmp->stats.hp >= 0) || QUERY_FLAG (tmp, FLAG_CAN_ROLL) || tmp->type == LOCKED_DOOR) 947 if ((QUERY_FLAG (tmp, FLAG_ALIVE) && tmp->stats.hp >= 0) || QUERY_FLAG (tmp, FLAG_CAN_ROLL) || tmp->type == LOCKED_DOOR)
1103 { 948 {
1104 /* Don't attack party members */ 949 /* Don't attack party members */
1105 if ((pl->type == PLAYER && tmp->type == PLAYER) && (pl->contr->party != NULL && pl->contr->party == tmp->contr->party)) 950 if ((pl->type == PLAYER && tmp->type == PLAYER) && (pl->contr->party != NULL && pl->contr->party == tmp->contr->party))
1106 return 0; 951 return 0;
952
1107 break; 953 break;
1108 } 954 }
1109 } 955 }
956
1110 if (!tmp) 957 if (!tmp)
1111 { 958 {
1112 if (pl->type == PLAYER) 959 if (pl->type == PLAYER)
1113 new_draw_info (NDI_UNIQUE, 0, pl, "There is nothing to attack!"); 960 new_draw_info (NDI_UNIQUE, 0, pl, "There is nothing to attack!");
961
1114 return 0; 962 return 0;
1115 } 963 }
1116 964
1117 return do_skill_attack (tmp, pl, string, skill); 965 return do_skill_attack (tmp, pl, string, skill);
1118} 966}
1119
1120 967
1121/* attack_hth() - this handles all hand-to-hand attacks -b.t. */ 968/* attack_hth() - this handles all hand-to-hand attacks -b.t. */
1122 969
1123/* July 5, 1995 - I broke up attack_hth() into 2 parts. In the first 970/* July 5, 1995 - I broke up attack_hth() into 2 parts. In the first
1124 * (attack_hth) we check for weapon use, etc in the second (the new 971 * (attack_hth) we check for weapon use, etc in the second (the new
1125 * function skill_attack() we actually attack. 972 * function skill_attack() we actually attack.
1126 */ 973 */
1127
1128static int 974static int
1129attack_hth (object *pl, int dir, const char *string, object *skill) 975attack_hth (object *pl, int dir, const char *string, object *skill)
1130{ 976{
1131 object *enemy = NULL, *weapon; 977 object *enemy = NULL, *weapon;
1132 978
1135 { 981 {
1136 if (weapon->type == WEAPON && QUERY_FLAG (weapon, FLAG_APPLIED)) 982 if (weapon->type == WEAPON && QUERY_FLAG (weapon, FLAG_APPLIED))
1137 { 983 {
1138 CLEAR_FLAG (weapon, FLAG_APPLIED); 984 CLEAR_FLAG (weapon, FLAG_APPLIED);
1139 CLEAR_FLAG (pl, FLAG_READY_WEAPON); 985 CLEAR_FLAG (pl, FLAG_READY_WEAPON);
1140 fix_player (pl); 986 pl->update_stats ();
1141 if (pl->type == PLAYER) 987 if (pl->type == PLAYER)
1142 { 988 {
1143 new_draw_info (NDI_UNIQUE, 0, pl, "You unwield your weapon in order to attack."); 989 new_draw_info (NDI_UNIQUE, 0, pl, "You unwield your weapon in order to attack.");
1144 esrv_update_item (UPD_FLAGS, pl, weapon); 990 esrv_update_item (UPD_FLAGS, pl, weapon);
1145 } 991 }
992
1146 break; 993 break;
1147 } 994 }
1148 } 995 }
996
1149 return skill_attack (enemy, pl, dir, string, skill); 997 return skill_attack (enemy, pl, dir, string, skill);
1150} 998}
1151
1152 999
1153/* attack_melee_weapon() - this handles melee weapon attacks -b.t. 1000/* attack_melee_weapon() - this handles melee weapon attacks -b.t.
1154 * For now we are just checking to see if we have a ready weapon here. 1001 * For now we are just checking to see if we have a ready weapon here.
1155 * But there is a real neato possible feature of this scheme which 1002 * But there is a real neato possible feature of this scheme which
1156 * bears mentioning: 1003 * bears mentioning:
1157 * Since we are only calling this from do_skill() in the future 1004 * Since we are only calling this from do_skill() in the future
1158 * we may make this routine handle 'special' melee weapons attacks 1005 * we may make this routine handle 'special' melee weapons attacks
1159 * (like disarming manuever with sai) based on player SK_level and 1006 * (like disarming manuever with sai) based on player SK_level and
1160 * weapon type. 1007 * weapon type.
1161 */ 1008 */
1162
1163static int 1009static int
1164attack_melee_weapon (object *op, int dir, const char *string, object *skill) 1010attack_melee_weapon (object *op, int dir, const char *string, object *skill)
1165{ 1011{
1166 1012
1167 if (!QUERY_FLAG (op, FLAG_READY_WEAPON)) 1013 if (!QUERY_FLAG (op, FLAG_READY_WEAPON))
1168 { 1014 {
1169 if (op->type == PLAYER) 1015 if (op->type == PLAYER)
1170 new_draw_info (NDI_UNIQUE, 0, op, "You have no ready weapon to attack with!"); 1016 new_draw_info (NDI_UNIQUE, 0, op, "You have no ready weapon to attack with!");
1017
1171 return 0; 1018 return 0;
1172 } 1019 }
1020
1173 return skill_attack (NULL, op, dir, string, skill); 1021 return skill_attack (NULL, op, dir, string, skill);
1174
1175} 1022}
1023

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines